{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-50f7c8ea31b468e72b8b792f523e21b94c2ae35191afcb84c9afe7b2dde9e46d", "text": "enableBreakpointsFor?: { languageIds: string[] }; configurationAttributes?: any; initialConfigurations?: any[]; <ins> aiKey?: string; </ins> win?: IRawEnvAdapter; winx86?: IRawEnvAdapter; windows?: IRawEnvAdapter;", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-c409c3170095f67df060bc037a12f96595441d27b19082bb932bcd8b9b10be12", "text": "import { TPromise } from 'vs/base/common/winjs.base'; import editor = require('vs/editor/common/editorCommon'); import aria = require('vs/base/browser/ui/aria/aria'); <ins> import { AIAdapter } from 'vs/base/node/aiAdapter'; </ins> import editorbrowser = require('vs/editor/browser/editorBrowser'); import { IKeybindingService, IKeybindingContextKey } from 'vs/platform/keybinding/common/keybindingService'; import {IMarkerService} from 'vs/platform/markers/common/markers';", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-34166a986d76ea1b0d1e65ab5e8d0f10cb0cc5ae283371d2b67cde892d781e38", "text": "private viewModel: viewmodel.ViewModel; private configurationManager: ConfigurationManager; private debugStringEditorInputs: DebugStringEditorInput[]; <ins> private telemetryAdapter: AIAdapter; </ins> private lastTaskEvent: TaskEvent; private toDispose: lifecycle.IDisposable[]; private inDebugMode: IKeybindingContextKey<boolean>;", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-4c685dc3fe9aa74d3589f73d1f6ba803c907770fd6be58998b9725907b2a31ae", "text": "this.toDispose.push(this.session.addListener2(debug.SessionEvents.OUTPUT, (event: DebugProtocol.OutputEvent) => { if (event.body && event.body.category === 'telemetry') { <del> this.telemetryService.publicLog(event.body.output, event.body.data); </del> <ins> const key = this.configurationManager.getAdapter().aiKey; // only log telemetry events from debug adapter if the adapter provided the telemetry key if (key) { if (!this.telemetryAdapter) { this.telemetryAdapter = new AIAdapter(key, this.session.getType()); } this.telemetryAdapter.log(event.body.output, event.body.data); } </ins> } else if (event.body && typeof event.body.output === 'string' && event.body.output.length > 0) { this.onOutput(event); }", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-0f687f89139185cb13b5786c135121baca7c9c8bdc29c6f388efaf9ea1876883", "text": "}); this.model.updateBreakpoints(data); <ins> if (this.telemetryAdapter) { this.telemetryAdapter.dispose(); this.telemetryAdapter = null; } </ins> this.inDebugMode.reset(); }", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-129e83f64f19f4973c1405b639b1ae8c58eba015c0c82f24a77add076e07bb0b", "text": "private configurationAttributes: any; public initialConfigurations: any[]; public enableBreakpointsFor: { languageIds: string[] }; <ins> public aiKey: string; </ins> constructor(rawAdapter: debug.IRawAdapter, systemVariables: SystemVariables, extensionFolderPath: string) { if (rawAdapter.windows) {", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-9d44a6a46c7e70592c3cbbe4edc499fd1aacb4d06549a94f11919cc1b0aeaee9", "query": "If this key is set, all telemetry information generated in a debug session of the corresponding debug type will be tagged with that key (so that the data is routed to the correct bucket). what would be a good name for that key? (it should match the name used in other places where this key is used).\nthis is probably something you want to use...\nThe functionality for reporting telemetry only supports application insights pipeline, so I suggest calling it something explicit as .\nwe are not using acronyms in our protocol at all, so not a big fan of , I would rather go with . I would put it as a top level attribute under in the . If this is not provided I would ignore the telemetry event so we never mix the adapter telemtery with our vscode telemetry. What do you think?\nyes, put aiKey at the top of . What's about our own debug adapters? Do we get our own keys for them so that their telemetry events go to vscode telemetry?\nWhat we do we with the current adapters telemetry? do we depend on any of them in our current active reporting? If not, let's put them in the standard first party extensions pipeline. Otherwise, we can use the same vscode key, if so I would want make sure that adds standard properties such as machineId and sessionId so the processing scripts can function normally.\nFor Microsoft owned debug adapters, wouldn't we want their telemetry in the same stream as VS Code so that one could look at all activity for the same session? Or are there other good ways to tie that together?\npreviously we were reporting telemetry events of all debug adapters to vscode. With the new mechanism we don't do this any more, so we have to make sure that the node-debug adapter (which is shipping with vscode) still gets reported in the same way as before. So I will set the aiKey.", "positive_passages": [{"docid": "doc-en-vscode-d0d840071caf9f56c2595f047f5a3b3da5ef045e570a22cdc8190fc491d5fd91", "text": "this.initialConfigurations = rawAdapter.initialConfigurations; this._label = rawAdapter.label; this.enableBreakpointsFor = rawAdapter.enableBreakpointsFor; <ins> this.aiKey = rawAdapter.aiKey; </ins> } public get label() {", "commid": "vscode_pr_3054"}], "negative_passages": []}
{"query_id": "q-en-vscode-be4726a31d84ae83f1d505d34fa8f6fcf3e732019f96e874318980db109a194c", "query": "opens the current directory, also opens the current directory - not the parent\nRepros on master. Also: opens opens etc.\ni see the bug and the fix is in - i guess a short term work around is opens the parent directory\nyes the fix should be in the next release, adding a slash is a good work around in the meantime.\nI hope something good happens here. cause the way things are going. pretty much saying microsoft has lost all control of windows", "positive_passages": [{"docid": "doc-en-vscode-1ee20a6b959f948608b88620570b76379af1c73c995e51760fba0c49d4a0d2a5", "text": "// Trim whitespaces path = strings.trim(strings.trim(path, ' '), 't'); <del> // Remove trailing dots path = strings.rtrim(path, '.'); </del> return path; }", "commid": "vscode_pr_3150"}], "negative_passages": []}
{"query_id": "q-en-vscode-5798151fa7167a731663f33f538352f69e57179e599791d172c98110b6056027", "query": "when a link, src or url... contains an underscore character ( _ ) , you can't distinguish it from a misplaced space character because of the default underline below the links.\nAppears to be impractical to solve using in Chromium until it fully adopts the full CSS 3 spec on . What I'll do is use a instead. Tested locally, and it looks good to me: <img width=\"454\" alt=\"screen shot 2016-03-30 at 6 04 54 pm\" src=\"\"\nFixed via", "positive_passages": [{"docid": "doc-en-vscode-c7bd72889b19c4d8156b23a64d2038822422cf3403aa481f2fbbedebca814101", "text": ".monaco-editor .detected-link, .monaco-editor .detected-link-active { text-decoration: underline; <ins> text-underline-position: under; </ins> } .monaco-editor .detected-link-active {", "commid": "vscode_pr_38948"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-95b39fd06de823aa14bd3b338bcc40ef579eb7d16ff25b8e22a11393a33fd081", "text": "\"type\": \"boolean\", \"description\": \"%config.enableSmartCommit%\", \"default\": false <ins> }, \"git.enableCommitSigning\": { \"type\": \"boolean\", \"description\": \"%config.enableCommitSigning%\", \"default\": false </ins> } } }", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-0f64457f48abe431df9ff0629b048c80627c0b6e0287784d65982e87a01d189d", "text": "\"config.ignoreLegacyWarning\": \"Ignores the legacy Git warning\", \"config.ignoreLimitWarning\": \"Ignores the warning when there are too many changes in a repository\", \"config.defaultCloneDirectory\": \"The default location where to clone a git repository\", <del> \"config.enableSmartCommit\": \"Commit all changes when there are no staged changes.\" </del> <ins> \"config.enableSmartCommit\": \"Commit all changes when there are no staged changes.\", \"config.enableCommitSigning\": \"Enables commit signing with GPG.\" </ins> }  No newline at end of file", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-073bac355700a299eb7fd6a73de450c7aec8ef9c995328223b3b5f3a2ebea923", "text": "): Promise<boolean> { const config = workspace.getConfiguration('git'); const enableSmartCommit = config.get<boolean>('enableSmartCommit') === true; <ins> const enableCommitSigning = config.get<boolean>('enableCommitSigning') === true; </ins> const noStagedChanges = this.model.indexGroup.resources.length === 0; const noUnstagedChanges = this.model.workingTreeGroup.resources.length === 0;", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-51cd954e7002b4ec1d4f7ef4eb78d04eb881960e3edf674f2cdaf5ce87d7757c", "text": "opts = { all: noStagedChanges }; } <ins> // enable signing of commits if configurated opts.signCommit = enableCommitSigning; </ins> if ( // no changes (noStagedChanges && noUnstagedChanges)", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-4adb30b17faada10df0fa96e25f50f0a712e51b3207da76202e59065594a03c0", "text": "} } <del> async commit(message: string, opts: { all?: boolean, amend?: boolean, signoff?: boolean } = Object.create(null)): Promise<void> { </del> <ins> async commit(message: string, opts: { all?: boolean, amend?: boolean, signoff?: boolean, signCommit?: boolean } = Object.create(null)): Promise<void> { </ins> const args = ['commit', '--quiet', '--allow-empty-message', '--file', '-']; if (opts.all) {", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-88ac536184d03a6791dc5cf815828ca51711bf9a2c9cc5ac12aab7412e69de43", "text": "args.push('--signoff'); } <ins> if (opts.signCommit) { args.push('-S'); } </ins> try { await this.run(args, { input: message || '' }); } catch (commitErr) {", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-8644cad47eb155299bb9ad12f53bc70ef56522af28f06684cdb21b4c2ab9435c", "query": "VS Code should optionally be able to sign git commits with a given GPG key, as it is a good practice for authorization nowadays.\nDoesn't GitHub's authentication basically do the same thing, since you need to auth with GitHub to push to repos you have access to?\nGitHub auth is NOT related to GPG-signed commits if I know right.\nBasically, I would like built-in functionality for appending the command line argument to , as shown .\nSure, but isn't what it's accomplishing done by GitHub account/email linking? You need to link your email to an account and need credentials to the account to push.\nGPG can be used in any git environment (for instance: GitLab, BitBucket, etc.) I though this could be actual after seeing the .\nthoughts?\nI'd argue that for any given repo, you'd either want to sign all commits or none. Based on that, I suggest to use the git configuration in your repo, , which will make git sign all commits by default. Does that work for you\nI use exactly that, but when I try to commit from VS Code with that config attribute set, I get the following error output in the Git console of Code:\nI misread the issue, I thought you were talking about the vscode repo starting to sign commits, not adding the feature. while looking into signing commits yesterday, this I came across this\nNot just vscode is affected: If you're using an agent: As a workaround (a configuration change affecting not just vscode) it's possible to add to your For example, run Snippet from explaining : From what I've noticed, is now less verbose (doesn't remind me that I \"need my passphrase\" on ; is completely silent on ). I don't know what else this affects and thus I feel bad for suggesting this, but it works. If you're not using an agent: Again referring to Launchpad, you seem to be out of luck.\nThanks for that Does it solve it for you,\nWell, having listened to I'm not signing my commits anymore, but thank you for all the help provided!\n. It is not strictly accurate that signing each commit is \"totally stupid.\"\nit would be nice if vscode gave me the opportunity to sign a commit.\nSigning commits is not \"totally stupid\" and, in fact, has very real security implications. Not all Git code happens to be \"pushed\" to Github or BitBucket. Many places use git internally for all sorts of things and git commit signing is a very needed feature and often a requirement. I am using a gpg-agent and still am unable to sign commits in VSCode, for what it's worth.\nI found the two places that need to be modified for this to work, but wasn't able to setup the vscode repository properly (not able to run tests, linter hangs, unable to run electron) so I just dropped it. I'm leaving the links to the lines here in hope that someone will pick it up, and soon Funny thing is they both do the same thing, and they are both nearly identical, but one is written in async/await and the other uses plain function arguments instead of an options object. Is there a reason for this? Why not just abstract it out as another module and use it through that, would be less hassle maintaining it (and any similar parts that can be solved via the same solution).\n^ seems that git support is divided into two parts - one is git workbench that's in and second is git extension (that's built-in?) Is there any progress on this?\ni dont there is any work going on yet. I will pick this up but not until this weekend\nI like to confirm I am starting work on this. I will a pull request with a WIP title to show progress soon\nHello here, I recently tried committing with set to . However the issue I encountered is related to my name: it contains an accented 'e' (\u00e9) and right now VSCode seems to have some encoding problem (at least with git): ! Which prevents git from detecting the correct GPG key.\nHi! Any progress updates? :)\ngot all the changes needed mapped now going to add menus items etc should be done soon just lots of test and things to write\nI have the change almost complete just tidying up and getting ready to commit.\nPull request Added support to GPG signing hope all is oke\nwould love to see this.\nMe too, it was to the June milestone that got me excited but now its back in the backlog.... So I don't know whats going on. The pull request is this one:\nPlease, that comment, which is purely subjective, is very old and it's quoting achieves nothing, but FUD. Impersonating authors on GitHub is easily done and signing ALL commits is good practice. Especially with hardware tokens, such as Yubikeys. I mean no harm with , I am merely showing how easy it is to submit a commit by another. I feel GitHub could do more here too. On the main page, images are small and easily distracted (I could even change mine, I guess ... and my name). But the \"Verified\" means we've signed that commit. I believe it's important, as others seem to have commented also. !\nI verify ALL my commit is important and we do use yubikeys here at my organisation\nGPG signing provides authentication on the commits themselves. What you said in and subsequent comments are irrelevant to the issue. Because without signing the commit, I can easily fake you as the author and submit a fraudulent patch (e.g. intentionally infringing copyright of your rival company) via other channels (e.g. email) to another committer, who will be having a hard time to know whether you actually wrote the patch or not. And if that committer push the CL to GitHub, GitHub will happily link that to your account. See this commit for example:\nHi all, no need to try to convince me anymore\nYEAHHHHH!\nThis error git commit --quiet --allow-empty-message --file - --all git show gpg: cannot open tty `no tty': No such file or directory error: gpg failed to sign the data fatal: failed to write commit object can be cause by password protected gpg key.\nsomething related to the error you seen:\nI got it to work for me, but only after signing a previous commit (~5 minutes prior) manually through the integrated terminal. I have a hunch that the root cause of the error message , is that VS Code is requesting to open the prompt, and failing to do so. If you already entered your password via prompt previously, VS Code signs the commits perfectly fine.\nYou'll probably want to use a pinentry program that remembers the pass code or prompts graphically. (sorry if terse) On Tue, 17 Oct 2017, 08:33 Jeremy Loy, <:\nusually you see this problem when you dont things set up properly for gpg signing. that has been my experience\nIn Linux, I solve /dev/tty problem by adding binary exec of gpg2 path to git global config", "positive_passages": [{"docid": "doc-en-vscode-0b05d4ed04cbe72bc3922ec427d38a2d18ba3d7152d97c0a233556450ebb84e1", "text": "all?: boolean; amend?: boolean; signoff?: boolean; <ins> signCommit?: boolean; </ins> } export class Model implements Disposable {", "commid": "vscode_pr_27136"}], "negative_passages": []}
{"query_id": "q-en-vscode-3232970587aa16d34ea60e05b9c6b73f51948efe29a63d0089986357f575787d", "query": "Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?\nThinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.\nMarked as candidate as it's a very simple change that's been reported a bunch of times.\nCherry picked to release/1.2", "positive_passages": [{"docid": "doc-en-vscode-8a4d188eafa4345410c82db981119c50323157e22ca6540d6a6779cb8089a0fc", "text": "return function () { var desktop = gulp.src('resources/linux/code.desktop', { base: '.' }) .pipe(replace('@@NAME_LONG@@', product.nameLong)) <ins> .pipe(replace('@@NAME_SHORT@@', product.nameShort)) </ins> .pipe(replace('@@NAME@@', product.applicationName)) .pipe(rename('usr/share/applications/' + product.applicationName + '.desktop'));", "commid": "vscode_pr_6985"}], "negative_passages": []}
{"query_id": "q-en-vscode-3232970587aa16d34ea60e05b9c6b73f51948efe29a63d0089986357f575787d", "query": "Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?\nThinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.\nMarked as candidate as it's a very simple change that's been reported a bunch of times.\nCherry picked to release/1.2", "positive_passages": [{"docid": "doc-en-vscode-d7d2f05763d4f40d8706452202cbf5fc80ac7ac15495baa7168b977fab484d3b", "text": "return function () { var desktop = gulp.src('resources/linux/code.desktop', { base: '.' }) .pipe(replace('@@NAME_LONG@@', product.nameLong)) <ins> .pipe(replace('@@NAME_SHORT@@', product.nameShort)) </ins> .pipe(replace('@@NAME@@', product.applicationName)) .pipe(rename('BUILD/usr/share/applications/' + product.applicationName + '.desktop'));", "commid": "vscode_pr_6985"}], "negative_passages": []}
{"query_id": "q-en-vscode-3232970587aa16d34ea60e05b9c6b73f51948efe29a63d0089986357f575787d", "query": "Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?\nThinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.\nMarked as candidate as it's a very simple change that's been reported a bunch of times.\nCherry picked to release/1.2", "positive_passages": [{"docid": "doc-en-vscode-e457439addf0efa99afadc4066a40b8813a99b57ea5a5051077d2718f09835e6", "text": "Name=@@NAME_LONG@@ Comment=Code Editing. Redefined. GenericName=Text Editor <del> Exec=/usr/bin/@@NAME@@ %U </del> <ins> Exec=/usr/share/@@NAME@@/@@NAME@@ %U </ins> Icon=@@NAME@@ Type=Application StartupNotify=true <del> StartupWMClass=@@NAME@@ </del> <ins> StartupWMClass=@@NAME_SHORT@@ </ins> Categories=Utility;TextEditor;Development;IDE; MimeType=text/plain; Actions=new-window;", "commid": "vscode_pr_6985"}], "negative_passages": []}
{"query_id": "q-en-vscode-3232970587aa16d34ea60e05b9c6b73f51948efe29a63d0089986357f575787d", "query": "Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?\nThinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.\nMarked as candidate as it's a very simple change that's been reported a bunch of times.\nCherry picked to release/1.2", "positive_passages": [{"docid": "doc-en-vscode-7533be9d1b448851258b1f70678638c92835451c253acf30c19147a0ba6bdb95", "text": "Name[ru]=\u041d\u043e\u0432\u043e\u0435 \u043e\u043a\u043d\u043e Name[zh_CN]=\u65b0\u5efa\u7a97\u53e3 Name[zh_TW]=\u958b\u65b0\u8996\u7a97 <del> Exec=/usr/bin/@@NAME@@ --new-window %U </del> <ins> Exec=/usr/share/@@NAME@@/@@NAME@@ --new-window %U </ins> Icon=@@NAME@@", "commid": "vscode_pr_6985"}], "negative_passages": []}
{"query_id": "q-en-vscode-3232970587aa16d34ea60e05b9c6b73f51948efe29a63d0089986357f575787d", "query": "Integrated terminal master issue: Open question: Currently pressing <kbdesc</kbdwill hide the terminal, this can be a problem for some terminal programs, for example . Perhaps this should be configurable?\nThinking about desktop terminals, such as iTerm, I can only close them via a global shortcut, an button or running in the shell. <kbdEscape</kbdshould not bubble outside to the workbench.\nMarked as candidate as it's a very simple change that's been reported a bunch of times.\nCherry picked to release/1.2", "positive_passages": [{"docid": "doc-en-vscode-1eabafa33a4f25cb502e7858f02b2025a3f44d5f759f4e28b6f7e7b8262ac7d1", "text": "this.focusTerminal(); } })); <ins> this.toDispose.push(DOM.addDisposableListener(this.parentDomElement, 'keyup', (event: KeyboardEvent) => { // Keep terminal open on escape if (event.keyCode === 27) { event.stopPropagation(); } })); </ins> this.toDispose.push(this.themeService.onDidThemeChange((themeId) => { <del> this.setTerminalTheme(themeId); </del> <ins> this.setTerminalTheme(); })); this.toDispose.push(this.configurationService.onDidUpdateConfiguration((e) => { this.setTerminalFont(); </ins> })); this.terminal.open(this.terminalDomElement); this.parentDomElement.appendChild(terminalScrollbar.getDomNode()); <del> let config = this.configurationService.getConfiguration<ITerminalConfiguration>(); this.terminalDomElement.style.fontFamily = config.terminal.integrated.fontFamily; this.setTerminalTheme(this.themeService.getTheme()); </del> <ins> this.setTerminalFont(); this.setTerminalTheme(); </ins> resolve(void 0); }); } <del> private setTerminalTheme(themeId: string) { </del> <ins> private setTerminalTheme() { </ins> if (!this.terminal) { return; } <del> let baseThemeId = getBaseThemeId(themeId); </del> <ins> let baseThemeId = getBaseThemeId(this.themeService.getTheme()); </ins> this.terminal.colors = DEFAULT_ANSI_COLORS[baseThemeId]; this.terminal.refresh(0, this.terminal.rows); } <ins> private setTerminalFont() { let config = this.configurationService.getConfiguration<ITerminalConfiguration>(); this.terminalDomElement.style.fontFamily = config.terminal.integrated.fontFamily; } </ins> public focus(): void { this.focusTerminal(true); }", "commid": "vscode_pr_6985"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6288e676c13a8d6389645d2d3b2a858f2509dcc63ea670e2116e47797a645a0", "query": "I am using VSCode on Ubuntu 14.04 x64 VSCode About: Version 0.10.10 Commit Date 2016-03-07T10:30:20.458Z Shell 0.35.6 Renderer 45.0.2454.85 Node 4.1.1 Steps to Reproduce: a git repo folder a change the \"GIT\" tab typing a git message I am thinking of a counter starting with 50 (The number of character that'll be used as the short message appearing in git commits), it helps write meaning full messages, without have a word cut and completed in the description part, the behavior is taken as is from GitKraken\nMy suggestion would be to, instead of always showing a counter, when the first line's length has surpassed 50 characters. I'd gladly take this as a contribution PR! Wanna give it a try?\nIt seems easy to implement this, can I give it a try?\nAbsolutely, looking forward to it.\nIt unfortunately seems as if is no longer working on this.\nPlease bring it back!", "positive_passages": [{"docid": "doc-en-vscode-f684eb936dfa914156012d840839b4a8f5fc8240fb40ed0afd912d2313a1c4b4", "text": "private static COMMIT_KEYBINDING = Platform.isMacintosh ? 'Cmd+Enter' : 'Ctrl+Enter'; private static NEED_MESSAGE = nls.localize('needMessage', \"Please provide a commit message. You can always press **{0}** to commit changes. If there are any staged changes, only those will be committed; otherwise, all changes will.\", ChangesView.COMMIT_KEYBINDING); private static NOTHING_TO_COMMIT = nls.localize('nothingToCommit', \"Once there are some changes to commit, type in the commit message and either press **{0}** to commit changes. If there are any staged changes, only those will be committed; otherwise, all changes will.\", ChangesView.COMMIT_KEYBINDING); <ins> private static LONG_COMMIT = nls.localize('longCommit', \"Great commit summaries are 50 characters or less. Place extra information in next lines.\"); </ins> private instantiationService: IInstantiationService; private editorService: IWorkbenchEditorService;", "commid": "vscode_pr_7399"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6288e676c13a8d6389645d2d3b2a858f2509dcc63ea670e2116e47797a645a0", "query": "I am using VSCode on Ubuntu 14.04 x64 VSCode About: Version 0.10.10 Commit Date 2016-03-07T10:30:20.458Z Shell 0.35.6 Renderer 45.0.2454.85 Node 4.1.1 Steps to Reproduce: a git repo folder a change the \"GIT\" tab typing a git message I am thinking of a counter starting with 50 (The number of character that'll be used as the short message appearing in git commits), it helps write meaning full messages, without have a word cut and completed in the description part, the behavior is taken as is from GitKraken\nMy suggestion would be to, instead of always showing a counter, when the first line's length has surpassed 50 characters. I'd gladly take this as a contribution PR! Wanna give it a try?\nIt seems easy to implement this, can I give it a try?\nAbsolutely, looking forward to it.\nIt unfortunately seems as if is no longer working on this.\nPlease bring it back!", "positive_passages": [{"docid": "doc-en-vscode-4e253ebac02be36d275306e5d2641840c7dfd89bc6a731842a8ecef772ce3bc4", "text": "placeholder: nls.localize('commitMessage', \"Message (press {0} to commit)\", ChangesView.COMMIT_KEYBINDING), validationOptions: { showMessage: true, <del> validation: (): InputBox.IMessage => null </del> <ins> validation: (value): InputBox.IMessage => { if (Strings.trim(value.split('n')[0]).length > 50) { return { content: ChangesView.LONG_COMMIT, type: InputBox.MessageType.WARNING }; } return null; } </ins> }, ariaLabel: nls.localize('commitMessageAriaLabel', \"Git: Type commit message and press {0} to commit\", ChangesView.COMMIT_KEYBINDING), flexibleHeight: true", "commid": "vscode_pr_7399"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-d3064d55f230dc43a4dd1213e990ff5c5cef71a167eda43f50d37be80e4fb11e", "text": "class NoUnexternalizedStringsRuleWalker extends Lint.RuleWalker { <del> private static ImportFailureMessage = 'Do not use double qoutes for imports.'; </del> <ins> private static ImportFailureMessage = 'Do not use double quotes for imports.'; </ins> private static DOUBLE_QUOTE: string = '\"';", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-6d6b59ff74f9e45be9a72920fad3662a82904326ecddfd8eecc4b1635f8c4f3b", "text": "* Writes text to the system clipboard. */ writeText(text: string): void; <ins> /** * Reads the content of the clipboard in plain text */ readText(): string; </ins> }  No newline at end of file", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-7a85cae5220d9e77607527ca27cc49f0ebd5abfc8544ca3ea130ff0e7797ed52", "text": "public writeText(text: string): void { clipboard.writeText(text); } <ins> public readText(): string { return clipboard.readText(); } </ins> }  No newline at end of file", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-fbd80b2e63c1a97fcdf9c8ca62c03a8042a032003a3e1b183f57fb50f3ba64ba", "text": "import { Action, IAction } from 'vs/base/common/actions'; import { ActionItem, BaseActionItem, Separator } from 'vs/base/browser/ui/actionbar/actionbar'; import { Scope, IActionBarRegistry, Extensions as ActionBarExtensions, ActionBarContributor } from 'vs/workbench/browser/actions'; <del> import { GlobalNewUntitledFileAction, SaveFileAsAction, ShowOpenedFileInNewWindow, CopyPathAction, GlobalCopyPathAction, RevealInOSAction, GlobalRevealInOSAction, pasteIntoFocusedFilesExplorerViewItem, FocusOpenEditorsView, FocusFilesExplorer, GlobalCompareResourcesAction, GlobalNewFileAction, GlobalNewFolderAction, RevertFileAction, SaveFilesAction, SaveAllAction, SaveFileAction, MoveFileToTrashAction, TriggerRenameFileAction, PasteFileAction, CopyFileAction, SelectResourceForCompareAction, CompareResourcesAction, NewFolderAction, NewFileAction, OpenToSideAction, ShowActiveFileInExplorer, CollapseExplorerView, RefreshExplorerView, CompareWithSavedAction } from 'vs/workbench/parts/files/browser/fileActions'; </del> <ins> import { GlobalNewUntitledFileAction, SaveFileAsAction, ShowOpenedFileInNewWindow, CopyPathAction, GlobalCopyPathAction, RevealInOSAction, GlobalRevealInOSAction, pasteIntoFocusedFilesExplorerViewItem, FocusOpenEditorsView, FocusFilesExplorer, GlobalCompareResourcesAction, GlobalNewFileAction, GlobalNewFolderAction, RevertFileAction, SaveFilesAction, SaveAllAction, SaveFileAction, MoveFileToTrashAction, TriggerRenameFileAction, PasteFileAction, CopyFileAction, SelectResourceForCompareAction, CompareResourcesAction, NewFolderAction, NewFileAction, OpenToSideAction, ShowActiveFileInExplorer, CollapseExplorerView, RefreshExplorerView, CompareWithSavedAction, CompareWithClipboardAction } from 'vs/workbench/parts/files/browser/fileActions'; </ins> import { revertLocalChangesCommand, acceptLocalChangesCommand, CONFLICT_RESOLUTION_CONTEXT } from 'vs/workbench/parts/files/browser/saveErrorHandler'; import { SyncActionDescriptor, MenuId, MenuRegistry } from 'vs/platform/actions/common/actions'; import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actions';", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-29f127d9e4d50bd641083ad32972db27d2def204fa9feb04e02941b64bddc2f3", "text": "registry.registerWorkbenchAction(new SyncActionDescriptor(GlobalRevealInOSAction, GlobalRevealInOSAction.ID, GlobalRevealInOSAction.LABEL, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_R) }), 'File: Reveal Active File', category); registry.registerWorkbenchAction(new SyncActionDescriptor(ShowOpenedFileInNewWindow, ShowOpenedFileInNewWindow.ID, ShowOpenedFileInNewWindow.LABEL, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_O) }), 'File: Open Active File in New Window', category); registry.registerWorkbenchAction(new SyncActionDescriptor(CompareWithSavedAction, CompareWithSavedAction.ID, CompareWithSavedAction.LABEL, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_D) }), 'File: Compare Active File with Saved', category); <ins> registry.registerWorkbenchAction(new SyncActionDescriptor(CompareWithClipboardAction, CompareWithClipboardAction.ID, CompareWithClipboardAction.LABEL, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_C) }), 'File: Compare Active File with Clipboard', category); </ins> // Commands CommandsRegistry.registerCommand('_files.windowOpen', openWindowCommand);", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-86fd04aa4f629b39b24fb714f60eb3b942391e85e3ef61bd48381d1bca6be132", "text": "import { IMessageService, IMessageWithAction, IConfirmation, Severity, CancelAction, IConfirmationResult } from 'vs/platform/message/common/message'; import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import { getCodeEditor } from 'vs/editor/browser/services/codeEditorService'; <del> import { IEditorViewState } from 'vs/editor/common/editorCommon'; </del> <ins> import { IEditorViewState, IModel } from 'vs/editor/common/editorCommon'; </ins> import { IBackupFileService } from 'vs/workbench/services/backup/common/backup'; import { IWindowsService } from 'vs/platform/windows/common/windows'; import { withFocusedFilesExplorer, revealInOSCommand, revealInExplorerCommand, copyPathCommand } from 'vs/workbench/parts/files/browser/fileCommands'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; <del> import { ITextModelService } from 'vs/editor/common/services/resolverService'; </del> <ins> import { ITextModelService, ITextModelContentProvider } from 'vs/editor/common/services/resolverService'; </ins> import { IConfigurationService, ConfigurationTarget } from 'vs/platform/configuration/common/configuration'; import { once } from 'vs/base/common/event'; <ins> import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; import { IModeService } from 'vs/editor/common/services/modeService'; import { IModelService } from 'vs/editor/common/services/modelService'; </ins> export interface IEditableData { action: IAction;", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-181f61b6239acba66352b3e89967487fa755c468ed8d30e6341c71c5ee3218df", "query": "when i want to compare a local file with a online resource file, i need to save the online file in project folder, and then do compare. it's a little inconvenient. It'll be great if i can copy the content of the online file, and right-click the local file, and choose \"compare with clipboard\".\nAn extension would be ideal for a feature like this.\nfyi\nIt would be great too if also is allowed to compare selection with clipboard.\nIt would be great if we could compare unsaved files...\nI would be open to a PR here, I think it is not a lot of work. Some pointers: register a new text document content provider to be able to open the left hand side of the diff editor to be the contents of the clipboard (pointers: ) register a new action to diff the current editor with the resource that can be handled with from the text document content provider (similar to ) Due to sensitivity of data inside the clipboard it would probably make sense to ask the user for confirmation that the clipboard is accessed. Related to\nHas someone taken up this issue? I am a complete beginner to the VSCode codebase, would I be able to contribute to this issue?\nnot yet, but it seems has started a similar PR in which could be used as input to this one. The difference is that the contents of the left hand side are coming from the clipboard instead of the file on disk.", "positive_passages": [{"docid": "doc-en-vscode-9308ae6cd354a215d13c340d5842f4037373ea11e233dfacf405d00149417780", "text": "} } <ins> export class CompareWithClipboardAction extends Action { public static ID = 'workbench.files.action.compareWithClipboard'; public static LABEL = nls.localize('compareWithClipboard', \"Compare Active File with Clipboard\"); private static SCHEME = 'clipboard'; private toDispose: IDisposable[]; constructor( id: string, label: string, @IWorkbenchEditorService private editorService: IWorkbenchEditorService, @IInstantiationService private instantiationService: IInstantiationService, @ITextModelService private textModelService: ITextModelService, ) { super(id, label); this.enabled = true; this.toDispose = []; } public run(): TPromise<any> { let resource: URI = toResource(this.editorService.getActiveEditorInput(), { supportSideBySide: true, filter: 'file' } ); const provider = this.instantiationService.createInstance(ClipboardContentProvider); const registrationDisposal = this.textModelService.registerTextModelContentProvider(CompareWithClipboardAction.SCHEME, provider); this.toDispose.push(registrationDisposal); if (resource) { const name = paths.basename(resource.fsPath); const editorLabel = nls.localize('clipboardComparisonLabel', \"Clipboard \u2194 {0}\", name); return this.editorService.openEditor({ leftResource: URI.from({ scheme: CompareWithClipboardAction.SCHEME, path: resource.fsPath }), rightResource: resource, label: editorLabel }); } return TPromise.as(true); } public dispose(): void { super.dispose(); this.toDispose = dispose(this.toDispose); } } class ClipboardContentProvider implements ITextModelContentProvider { constructor( @IClipboardService private clipboardService: IClipboardService, @IModeService private modeService: IModeService, @IModelService private modelService: IModelService ) { } provideTextContent(resource: URI): TPromise<IModel> { const model = this.modelService.createModel(this.clipboardService.readText(), this.modeService.getOrCreateMode('text/plain'), resource); return TPromise.as(model); } } </ins> // Diagnostics support let diag: (...args: any[]) => void; if (!diag) {", "commid": "vscode_pr_37841"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-7ce41709c55ab77826924e39ee7384b4b1c0781452547e406d944cea94d51744", "text": "getLineNumberAtVerticalOffset(verticalOffset: number): number; getVerticalOffsetForLineNumber(lineNumber: number): number; getWhitespaceAtVerticalOffset(verticalOffset:number): editorCommon.IViewWhitespaceViewportData; <del> shouldSuppressMouseDownOnViewZone(viewZoneId:number): boolean; </del> <ins> shouldSuppressMouseDownOnViewZone(viewZoneId: number): boolean; shouldSuppressMouseDownOnWidget(widgetId: string): boolean; </ins> /** * Decode an Editor.IPosition from a rendered dom node", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-c62e4f9abbaebf9fb4a63fefe6b9cb12f5eb20f9739b0b46b882817c094035af", "text": "let targetIsLineNumbers = (t.type === editorCommon.MouseTargetType.GUTTER_LINE_NUMBERS); let selectOnLineNumbers = this._context.configuration.editor.viewInfo.selectOnLineNumbers; let targetIsViewZone = (t.type === editorCommon.MouseTargetType.CONTENT_VIEW_ZONE || t.type === editorCommon.MouseTargetType.GUTTER_VIEW_ZONE); <ins> let targetIsWidget = (t.type === editorCommon.MouseTargetType.CONTENT_WIDGET); </ins> let shouldHandle = e.leftButton; if (platform.isMacintosh && e.ctrlKey) { shouldHandle = false; } <del> if (shouldHandle && (targetIsContent || (targetIsLineNumbers && selectOnLineNumbers))) { </del> <ins> var focus = () => { </ins> if (browser.isIE11orEarlier) { // IE does not want to focus when coming in from the browser's address bar if ((<any>e.browserEvent).fromElement) {", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-ee36ef308bf2d2da39bc808b38fe1a5849a0b4f5c80cc6fcf19be70e7d8fce56", "text": "e.preventDefault(); this.viewHelper.focusTextArea(); } <ins> }; if (shouldHandle && (targetIsContent || (targetIsLineNumbers && selectOnLineNumbers))) { focus(); </ins> this._mouseDownOperation.start(t.type, e); } else if (targetIsGutter) {", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-1c6cd73b18b7d60f3e36bc190e09477e815fb65c9a13318b1ca9e1e83cff368d", "text": "} else if (targetIsViewZone) { let viewZoneData = <editorBrowser.IViewZoneData>t.detail; if (this.viewHelper.shouldSuppressMouseDownOnViewZone(viewZoneData.viewZoneId)) { <ins> focus(); this._mouseDownOperation.start(t.type, e); </ins> e.preventDefault(); } <ins> } else if (targetIsWidget && this.viewHelper.shouldSuppressMouseDownOnWidget(<string>t.detail)) { focus(); e.preventDefault(); </ins> } this.viewController.emitMouseDown({", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-b8ba47461734f84c433e41ce53f0b660d06d813f5d9a39ba31eb31caecf40213", "text": "} return this.viewZones.shouldSuppressMouseDownOnViewZone(viewZoneId); }, <ins> shouldSuppressMouseDownOnWidget: (widgetId: string) => { if (this._isDisposed) { throw new Error('ViewImpl.pointerHandler.shouldSuppressMouseDownOnWidget: View is disposed'); } return this.contentWidgets.shouldSuppressMouseDownOnWidget(widgetId); }, </ins> getPositionFromDOMInfo: (spanNode: HTMLElement, offset: number) => { if (this._isDisposed) { throw new Error('ViewImpl.pointerHandler.getPositionFromDOMInfo: View is disposed');", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-5f3211ccf3237a363060522814194793f764d097b2856106b3e09483fb56ef66", "text": "} } <ins> public shouldSuppressMouseDownOnWidget(widgetId: string): boolean { if (this._widgets.hasOwnProperty(widgetId)) { let widgetData = this._widgets[widgetId]; return widgetData.widget.suppressMouseDown; } return false; } </ins> private _layoutBoxInViewport(position:Position, domNode:HTMLElement, ctx:IRenderingContext): IBoxLayoutResult { let visibleRange = ctx.visibleRangeForPosition(position);", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-5ce23d7743ce78f024273db7303d6c2fc68df8038322bad3858b8a2a541772fe", "text": "private static ID: number = 0; <ins> public suppressMouseDown: boolean; </ins> private _id: string; private _domNode: HTMLElement;", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-e62248c6afa5621ee4a8e912331db2d3f6d21be958df408a0c3f7fd6f614a0c6", "text": "this._id = 'codeLensWidget' + (++CodeLensContentWidget.ID); this._editor = editor; <ins> this.suppressMouseDown = true; </ins> this.setSymbolRange(symbolRange); this._domNode = document.createElement('span');", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-1258bf932f264a3ab40bb3716a2b2dc7ec7f20005585c52c48abb70395819afa", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) OS Version: OS X El Capitan 10.11.5 Steps to Reproduce: on the non-link area of a code lens line that nothing at all happens Would really like it to at a minimum to focus the editor (if not already focused), but we really love it if it move the cursor to the previous line. I find myself VERY often clicking on that area to start typing above it and nothing happens.\nI'm assuming (maybe) that this wouldn't be a difficult change -- so if someone had the time to point me in the vague direction, I would be happy to attempt to open a PR for this. :)\nPR welcome! :) It is in I would extract the code that does the focus: to a closure called inside the method. Then, at you can call and then : The reason focusing is complicated is because IE has some weirdness around redirecting focus when coming from the URL bar and doing a mouse down. And the already is a good indicator that the view zone does not want to handle mouse events.", "positive_passages": [{"docid": "doc-en-vscode-832b607656d488c495de0ee328874be0da3b7118b1bc10743694051e37255c56", "text": "* Render this content widget in a location where it could overflow the editor's view dom node. */ allowEditorOverflow?: boolean; <ins> suppressMouseDown?: boolean; </ins> /** * Get a unique identifier of the content widget. */", "commid": "vscode_pr_9249"}], "negative_passages": []}
{"query_id": "q-en-vscode-09f5e117e81d9e5bdec091f4c997089bfb0b4798d3891053b600f2d1bbc6fea6", "query": "VSCode Version: 1.5.0 OS Version: OS X 10.11.6 Steps to Reproduce: this snippet to use Then the example Focus is on the newly created terminal and not preserved.\nBug for", "positive_passages": [{"docid": "doc-en-vscode-5311db0cae2a2eaae4ad45f778ecc7930a348de9ebdfceae6d3f2a453be42739", "text": "public $show(terminalId: number, preserveFocus: boolean): void { this._terminalService.show(!preserveFocus).then((terminalPanel) => { this._terminalService.setActiveTerminalById(terminalId); <ins> if (!preserveFocus) { // If the panel was already showing an explicit focus call is necessary here. terminalPanel.focus(); } </ins> }); }", "commid": "vscode_pr_11419"}], "negative_passages": []}
{"query_id": "q-en-vscode-09f5e117e81d9e5bdec091f4c997089bfb0b4798d3891053b600f2d1bbc6fea6", "query": "VSCode Version: 1.5.0 OS Version: OS X 10.11.6 Steps to Reproduce: this snippet to use Then the example Focus is on the newly created terminal and not preserved.\nBug for", "positive_passages": [{"docid": "doc-en-vscode-fef8a4b702ab05c9572fb4d07fe306732fe1328dcc62c209dd811d691d2a1548", "text": "export interface ITerminalPanel { closeTerminalById(terminalId: number): TPromise<void>; <ins> focus(): void; </ins> sendTextToActiveTerminal(text: string, addNewLine: boolean): void; }", "commid": "vscode_pr_11419"}], "negative_passages": []}
{"query_id": "q-en-vscode-09f5e117e81d9e5bdec091f4c997089bfb0b4798d3891053b600f2d1bbc6fea6", "query": "VSCode Version: 1.5.0 OS Version: OS X 10.11.6 Steps to Reproduce: this snippet to use Then the example Focus is on the newly created terminal and not preserved.\nBug for", "positive_passages": [{"docid": "doc-en-vscode-38755db06c2f5693ebddaa353e9bcded051b104e22dbfdc643c273ccaeffaba4", "text": "return this.show(false).then((terminalPanel) => { this.activeTerminalIndex = index; terminalPanel.setActiveTerminal(this.activeTerminalIndex); <del> terminalPanel.focus(); </del> this._onActiveInstanceChanged.fire(); }); }", "commid": "vscode_pr_11419"}], "negative_passages": []}
{"query_id": "q-en-vscode-c802ada0b44750ffacdefb120b0549a0bdb3a04531582e8bd12fd7b5f07e79a7", "query": "VSCode Version: 1.5.3 (commit ) OS Version: Ubuntu Linux 14.04 Steps to Reproduce: some code that prints the characters to the output window. are incorrectly turned into a newline. F# Code: Output: This has already been reported as , but that bug was incorrectly closed as \"working as designed\" because it was assumed that the code in (I couldn't trace it further back than that). The character sequence is not the ANSI escape for a linefeed/newline; in fact, , since ANSI just uses the single character for that purpose. It's pretty clear, looking at the code, that that's what was the regex was intended to be set to in the lines just above the : it is set to . However, is actually an invalid Javascript hex escape. The specifies that must be followed by two hex digits, because otherwise the sequences (U+0007 BELL) and (U+000C FORM FEED) would be ambiguous. So is an invalid sequence, and is instead interpreted by Javascript as the character followed by the character (the backslash is swallowed). So the correct fix to bug is actually to replace that regex with . Then one could notice that the code immediately below is replacing all occurrences of with , which is a no-op since is . So the regex and the line serve no purpose but to slow things down by spending O(N) time doing a no-op regex search. They can safely be removed without affecting any other code, and this would actually speed things up a fraction.\nfyi\nYup, we should look into this and fix\nmight you be interested into doing a PR that fixes this since you have already done this great analysis? If not, we can follow your analysis to do the changes you proposed. Thanks either way!\nSure, why not? Here's the PR. Do you need me to sign a code licensing agreement of some kind before it can be merged in? If so, let me know how. UPDATE: Oh, I see that MSBOT replied on the PR's comment thread. I'm not surprised that no CLA is required for a commit that removed two lines and none.", "positive_passages": [{"docid": "doc-en-vscode-057f8c4a4a3e8425aabaa27634b9a8807e5b61fd29b83da32dd43df861f48d45", "text": "// Escape codes // http://en.wikipedia.org/wiki/ANSI_escape_code const EL = /x1Bx5B[12]?K/g; // Erase in line <del> const LF = /xA/g; // line feed </del> const COLOR_START = /x1b[d+m/g; // Color const COLOR_END = /x1b[0?m/g; // Color export function removeAnsiEscapeCodes(str: string): string { if (str) { str = str.replace(EL, ''); <del> str = str.replace(LF, 'n'); </del> str = str.replace(COLOR_START, ''); str = str.replace(COLOR_END, ''); }", "commid": "vscode_pr_13345"}], "negative_passages": []}
{"query_id": "q-en-vscode-51f4c7e71ecebd0fc42cb014aa5cd2b6cf513272a8888e632bceb598640b9941", "query": "VSCode Version: 1.6.0 OS Version: windows7 Steps to Reproduce: Create a vscode extension project. Pull off the cable to keep offine. Launch Extension (F5) I cant set breakpoint in my source file. And I find some warn information in Extension Development Host Window : I change the code in Its works. fyi\nSounds like a potential PR fyi\nYeah, PR welcome.\ncan you elaborate why your change is fixing this? If I look at the docs of I can see that host per default is .\ncan`t be resolved when being offline. And fyi\nthanks", "positive_passages": [{"docid": "doc-en-vscode-0d2f5a85913e86ec82244b291822827e443c7b9dd76d741f50695c3c529dc474", "text": "return clb(startPort); }); <del> client.connect(startPort); </del> <ins> client.connect(startPort, '127.0.0.1'); </ins> } function dispose(socket: net.Socket): void {", "commid": "vscode_pr_13739"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-ce05c326b29c1a7cacb7acc33a7240cfa97fadd032066d5ea5ebe0ee308f84dc", "text": "} .monaco-hover .markdown-hover > .hover-contents:not(.code-hover-contents) { <del> max-width: 500px; </del> word-wrap: break-word; }", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-0430d88e31c3c72621c1d7ba75dbc1636ae85f6fd6075fd3c1d63c7eca4e1930", "text": "position: absolute; width: 100%; height: 100%; <del> background: transparent; </del> <ins> background: red; </ins> } .monaco-workbench:not(.reduce-motion) .monaco-sash:before {", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-cbb3e9e06f49bfb5b34c1005e92adcf2d587b67e32399f851ce558d8aa2655f2", "text": "import { Context as SuggestContext } from 'vs/editor/contrib/suggest/browser/suggest'; import { AsyncIterableObject } from 'vs/base/common/async'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; <ins> import { ResizableHoverWidget } from 'vs/editor/contrib/hover/browser/resizableHoverWidget'; </ins> const $ = dom.$; export class ContentHoverController extends Disposable { private readonly _participants: IEditorHoverParticipant[]; <del> private readonly _widget = this._register(this._instantiationService.createInstance(ContentHoverWidget, this._editor)); </del> <ins> // INITIALLY: private readonly _widget = this._register(this._instantiationService.createInstance(ContentHoverWidget, this._editor)); private readonly _widget; </ins> private readonly _computer: ContentHoverComputer; private readonly _hoverOperation: HoverOperation<IHoverPart>;", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-bee2c7bd12b632248a1a8f95b4040273599e0905261fa26cb6981cc75e48ebd9", "text": ") { super(); <ins> this._widget = this._register(this._instantiationService.createInstance(ResizableHoverWidget, this._editor)); </ins> // Instantiate participants and sort them by `hoverOrdinal` which is relevant for rendering order. this._participants = []; for (const participant of HoverParticipantRegistry.getAll()) {", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-964ede88c1a453e01702460de097ca25b00c72c5b4236e441131464192801d45", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .monaco-editor .resizable-widget { z-index: 40; display: block; } </ins>", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-b6461bd37893d813d70cb5125334ff3dc57828825c0534e4b8ca84ffbd01b1ab", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { IResizeEvent, ResizableHTMLElement } from 'vs/base/browser/ui/resizable/resizable'; import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle'; import { ResourceMap } from 'vs/base/common/map'; import { ContentWidgetPositionPreference, ICodeEditor, IContentWidget, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser'; import { IPosition } from 'vs/editor/common/core/position'; import { PositionAffinity } from 'vs/editor/common/model'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import * as dom from 'vs/base/browser/dom'; import { clamp } from 'vs/base/common/numbers'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; import { Emitter, Event } from 'vs/base/common/event'; export abstract class ResizableWidget implements IDisposable { readonly element: ResizableHTMLElement; private readonly _disposables = new DisposableStore(); private readonly _persistingMechanism: IPersistingMechanism; constructor( private readonly _editor: ICodeEditor, private readonly _persistingOptions: IPersistingOptions, ) { console.log('Inside of ResizableWidget constructor'); this.element = new ResizableHTMLElement(); this.element.domNode.classList.add('editor-widget', 'resizable-widget'); if (this._persistingOptions instanceof SingleSizePersistingOptions) { this._persistingMechanism = new SingleSizePersistingMechanism(this, this.element, this._editor, this._persistingOptions); } else if (this._persistingOptions instanceof MultipleSizePersistingOptions) { this._persistingMechanism = new MultipleSizePersistingMechanism(this, this.element, this._editor); } else { throw new Error('Please specify a valid persisting mechanism'); } } dispose(): void { this._disposables.dispose(); this.element.dispose(); } resize(dimension: dom.Dimension): void { } hide(): void { this.element.clearSashHoverState(); } findMaximumRenderingHeight(): number | undefined { return Infinity; } findMaximumRenderingWidth(): number | undefined { return Infinity; } findPersistedSize(): dom.Dimension | undefined { return this._persistingMechanism.findSize(); } } export abstract class ResizableContentWidget implements IContentWidget { abstract ID: string; private _position: IPosition | null = null; private _secondaryPosition: IPosition | null = null; private _preference: ContentWidgetPositionPreference[] = []; private _positionAffinity: PositionAffinity | undefined = undefined; constructor(private readonly resizableWidget: ResizableWidget, private readonly editor: ICodeEditor) { this.editor.addContentWidget(this); console.log('Inisde of ResizableContentWidget constructor'); } findPersistedSize(): dom.Dimension | undefined { return this.resizableWidget.findPersistedSize(); } getId(): string { console.log('this.ID : ', this.ID); return this.ID; } getDomNode(): HTMLElement { console.log('Inside of getDomNode of ResizableContentWidget'); console.log('this.resizableWidget.element.domNode : ', this.resizableWidget.element.domNode); this.resizableWidget.element.domNode.style.zIndex = '49'; this.resizableWidget.element.domNode.style.position = 'fixed'; // this.resizableWidget.element.domNode.style.display = 'block'; return this.resizableWidget.element.domNode; } getPosition(): IContentWidgetPosition | null { console.log('Inside of getPosition of ResizableContentWidget'); const contentWidgetPosition = { position: this._position, secondaryPosition: this._secondaryPosition, preference: (this._preference), positionAffinity: this._positionAffinity }; console.log('contentWidgetPosition: ', contentWidgetPosition); return contentWidgetPosition; } hide(): void { this.editor.layoutContentWidget(this); } set position(position: IPosition | null) { this._position = position; } set secondaryPosition(position: IPosition | null) { this._secondaryPosition = position; } set preference(preference: ContentWidgetPositionPreference[]) { this._preference = preference; } set positionAffinity(affinity: PositionAffinity | undefined) { this._positionAffinity = affinity; } } interface IPersistingOptions { } export class SingleSizePersistingOptions implements IPersistingOptions { constructor( public readonly key: string, public readonly defaultSize: dom.Dimension, @IStorageService public readonly storageService: IStorageService ) { } } export class MultipleSizePersistingOptions implements IPersistingOptions { constructor() { } } interface IPersistingMechanism extends IDisposable { findSize(): dom.Dimension | undefined; } // TODO: maybe need to make more generic, this is specific to the suggest widget class SingleSizePersistingMechanism implements IPersistingMechanism { private readonly _persistedWidgetSize: PersistedWidgetSize | null = null; private readonly _disposables = new DisposableStore(); constructor( private readonly resizableWidget: ResizableWidget, private readonly element: ResizableHTMLElement, private readonly editor: ICodeEditor, private readonly persistingOptions: SingleSizePersistingOptions ) { this._persistedWidgetSize = new PersistedWidgetSize(this.persistingOptions.key, this.persistingOptions.storageService, this.editor); class ResizeState { constructor( readonly persistedSize: dom.Dimension | undefined, readonly currentSize: dom.Dimension, public persistHeight = false, public persistWidth = false, ) { } } let state: ResizeState | undefined; this._disposables.add(this.element.onDidWillResize(() => { // TODO: add back, this._contentWidget.lockPreference(); state = new ResizeState(this._persistedWidgetSize!.restore(), this.element.size); })); this._disposables.add(this.element.onDidResize(e => { this.resizableWidget.resize(new dom.Dimension(e.dimension.width, e.dimension.height)); if (state) { state.persistHeight = state.persistHeight || !!e.north || !!e.south; state.persistWidth = state.persistWidth || !!e.east || !!e.west; } if (!e.done) { return; } if (state) { const fontInfo = this.editor.getOption(EditorOption.fontInfo); const itemHeight = clamp(this.editor.getOption(EditorOption.suggestLineHeight) || fontInfo.lineHeight, 8, 1000); const threshold = Math.round(itemHeight / 2); let { width, height } = this.element.size; if (!state.persistHeight || Math.abs(state.currentSize.height - height) <= threshold) { height = state.persistedSize?.height ?? this.persistingOptions.defaultSize.height; } if (!state.persistWidth || Math.abs(state.currentSize.width - width) <= threshold) { width = state.persistedSize?.width ?? this.persistingOptions.defaultSize.width; } this._persistedWidgetSize!.store(new dom.Dimension(width, height)); } // TODO: add back, reset working state // this._contentWidget.unlockPreference(); state = undefined; })); } findSize(): dom.Dimension | undefined { return undefined; } dispose(): void { this._disposables.dispose(); } } class MultipleSizePersistingMechanism implements IPersistingMechanism { private readonly _persistedWidgetSizes: ResourceMap<Map<string, dom.Dimension>> = new ResourceMap<Map<string, dom.Dimension>>(); private readonly _disposables = new DisposableStore(); private _tooltipPosition: IPosition | null = null; // TODO: not sure if I need the following // private _initialHeight: number = 0; // private _initialTop: number = 0; private _resizing: boolean = false; private _size: dom.Dimension | undefined = undefined; private _maxRenderingHeight: number | undefined = Infinity; private _maxRenderingWidth: number | undefined = Infinity; private readonly _onDidResize = new Emitter<IResizeEvent>(); readonly onDidResize: Event<IResizeEvent> = this._onDidResize.event; // private _renderingAbove: ContentWidgetPositionPreference | undefined = undefined; constructor( private readonly resizableWidget: ResizableWidget, private readonly element: ResizableHTMLElement, public readonly editor: ICodeEditor ) { this.element.minSize = new dom.Dimension(10, 24); this._disposables.add(this.editor.onDidChangeModelContent((e) => { const uri = this.editor.getModel()?.uri; if (!uri || !this._persistedWidgetSizes.has(uri)) { return; } const persistedSizesForUri = this._persistedWidgetSizes.get(uri)!; const updatedPersistedSizesForUri = new Map<string, dom.Dimension>(); for (const change of e.changes) { const changeOffset = change.rangeOffset; const rangeLength = change.rangeLength; const endOffset = changeOffset + rangeLength; const textLength = change.text.length; for (const key of persistedSizesForUri.keys()) { const parsedKey = JSON.parse(key); const tokenOffset = parsedKey[0]; const tokenLength = parsedKey[1]; if (endOffset < tokenOffset) { const oldSize = persistedSizesForUri.get(key)!; const newKey: [number, number] = [tokenOffset - rangeLength + textLength, tokenLength]; updatedPersistedSizesForUri.set(JSON.stringify(newKey), oldSize); } else if (changeOffset >= tokenOffset + tokenLength) { updatedPersistedSizesForUri.set(key, persistedSizesForUri.get(key)!); } } } this._persistedWidgetSizes.set(uri, updatedPersistedSizesForUri); })); this._disposables.add(this.element.onDidWillResize(() => { this._resizing = true; // this._initialHeight = this.element.domNode.clientHeight; // this._initialTop = this.element.domNode.offsetTop; })); this._disposables.add(this.element.onDidResize(e => { let height = e.dimension.height; let width = e.dimension.width; const maxWidth = this.element.maxSize.width; const maxHeight = this.element.maxSize.height; width = Math.min(maxWidth, width); height = Math.min(maxHeight, height); if (!this._maxRenderingHeight) { return; } this._size = new dom.Dimension(width, height); this.element.layout(height, width); // Calling the resize function of the this.resizableWidget.resize(new dom.Dimension(width, height)); // Update the top parameters only when we decided to render above // TODO: presumably do not need to resize the element // if (this._renderingAbove === ContentWidgetPositionPreference.ABOVE) { // \tthis.element.domNode.style.top = this._initialTop - (height - this._initialHeight) + 'px'; // } // const horizontalSashWidth = width - 2 * SASH_WIDTH + 2 * TOTAL_BORDER_WIDTH + 'px'; // this.element.northSash.el.style.width = horizontalSashWidth; // this.element.southSash.el.style.width = horizontalSashWidth; // const verticalSashWidth = height - 2 * SASH_WIDTH + 2 * TOTAL_BORDER_WIDTH + 'px'; // this.element.eastSash.el.style.height = verticalSashWidth; // this.element.westSash.el.style.height = verticalSashWidth; // this.element.eastSash.el.style.top = TOTAL_BORDER_WIDTH + 'px'; // Fire the current dimension // TODO: probably don't need to listen on the firing event? // this._onDidResize.fire({ dimension: this._size, done: false }); this._maxRenderingWidth = this.resizableWidget.findMaximumRenderingWidth(); this._maxRenderingHeight = this.resizableWidget.findMaximumRenderingHeight(); // this._maxRenderingHeight = this.resizableWidget.findMaximumRenderingHeight(this._renderingAbove); if (!this._maxRenderingHeight || !this._maxRenderingWidth) { return; } this.element.maxSize = new dom.Dimension(this._maxRenderingWidth, this._maxRenderingHeight); // Persist the height only when the resizing has stopped if (e.done) { if (!this.editor.hasModel()) { return; } const uri = this.editor.getModel().uri; if (!uri || !this._tooltipPosition) { return; } const persistedSize = new dom.Dimension(width, height); const wordPosition = this.editor.getModel().getWordAtPosition(this._tooltipPosition); if (!wordPosition) { return; } const offset = this.editor.getModel().getOffsetAt({ lineNumber: this._tooltipPosition.lineNumber, column: wordPosition.startColumn }); const length = wordPosition.word.length; // Suppose that the uri does not exist in the persisted widget hover sizes, then create a map if (!this._persistedWidgetSizes.get(uri)) { const persistedWidgetSizesForUri = new Map<string, dom.Dimension>([]); persistedWidgetSizesForUri.set(JSON.stringify([offset, length]), persistedSize); this._persistedWidgetSizes.set(uri, persistedWidgetSizesForUri); } else { const persistedWidgetSizesForUri = this._persistedWidgetSizes.get(uri)!; persistedWidgetSizesForUri.set(JSON.stringify([offset, length]), persistedSize); } this._resizing = false; } // this.editor.layoutOverlayWidget(this); // this.editor.render(); })); } set tooltipPosition(position: IPosition) { this._tooltipPosition = position; } findSize(): dom.Dimension | undefined { console.log('Inside of findSize of the MultiplePersistingMechanisms'); if (!this._tooltipPosition || !this.editor.hasModel()) { return; } const wordPosition = this.editor.getModel().getWordAtPosition(this._tooltipPosition); if (!wordPosition) { return; } const offset = this.editor.getModel().getOffsetAt({ lineNumber: this._tooltipPosition.lineNumber, column: wordPosition.startColumn }); const length = wordPosition.word.length; const uri = this.editor.getModel().uri; const persistedSizesForUri = this._persistedWidgetSizes.get(uri); if (!persistedSizesForUri) { return; } return persistedSizesForUri.get(JSON.stringify([offset, length])); } dispose(): void { this._disposables.dispose(); } } class PersistedWidgetSize { constructor( private readonly _key: string, private readonly _service: IStorageService, editor: ICodeEditor ) { } restore(): dom.Dimension | undefined { const raw = this._service.get(this._key, StorageScope.PROFILE) ?? ''; try { const obj = JSON.parse(raw); if (dom.Dimension.is(obj)) { return dom.Dimension.lift(obj); } } catch { // ignore } return undefined; } store(size: dom.Dimension) { this._service.store(this._key, JSON.stringify(size), StorageScope.PROFILE, StorageTarget.MACHINE); } reset(): void { this._service.remove(this._key, StorageScope.PROFILE); } } </ins>", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-ecdd0fa3ef2c21ed8c9b05d82b3e53261b0655fa9e31d8f9479e000c0f1017ef", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { HoverWidget } from 'vs/base/browser/ui/hover/hoverWidget'; import { DisposableStore } from 'vs/base/common/lifecycle'; import { ContentWidgetPositionPreference, ICodeEditor, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { MultipleSizePersistingOptions, ResizableContentWidget, ResizableWidget } from 'vs/editor/contrib/hover/browser/resizableContentWidget'; import * as dom from 'vs/base/browser/dom'; import { ConfigurationChangedEvent, EditorOption } from 'vs/editor/common/config/editorOptions'; import { Position } from 'vs/editor/common/core/position'; import { HoverStartSource } from 'vs/editor/contrib/hover/browser/hoverOperation'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { PositionAffinity } from 'vs/editor/common/model'; import { IEditorHoverColorPickerWidget } from 'vs/editor/contrib/hover/browser/hoverTypes'; const SCROLLBAR_WIDTH = 10; // TODO: maybe don't need the resizable widget class export class ResizableHoverWidget extends ResizableWidget { public ID = 'editor.contrib.resizableContentHoverWidget'; private hoverDisposables = new DisposableStore(); // The ContentWidget is a child of the resizable widget private resizableContentWidget: ResizableContentHoverWidget; public readonly allowEditorOverflow = true; public readonly _hover: HoverWidget = this.hoverDisposables.add(new HoverWidget()); private readonly editor: ICodeEditor; private readonly _hoverVisibleKey = EditorContextKeys.hoverVisible.bindTo(this._contextKeyService); private readonly _hoverFocusedKey = EditorContextKeys.hoverFocused.bindTo(this._contextKeyService); private readonly _focusTracker = this.hoverDisposables.add(dom.trackFocus(this.getDomNode())); private readonly _horizontalScrollingBy: number = 30; private _visibleData: ContentHoverVisibleData | null = null; private _renderingAbove: ContentWidgetPositionPreference; constructor( editor: ICodeEditor, @IContextKeyService private readonly _contextKeyService: IContextKeyService ) { super(editor, new MultipleSizePersistingOptions()); this.editor = editor; // create here the dom node and all other logic should go here that was in the super abstract class this.resizableContentWidget = new ResizableContentHoverWidget(this, editor); this._renderingAbove = this.editor.getOption(EditorOption.hover).above ? ContentWidgetPositionPreference.ABOVE : ContentWidgetPositionPreference.BELOW; this.hoverDisposables.add(this.element.onDidResize((e) => { // When the resizable hover overlay changes, resize the widget // this._widget.resize(e.dimension); })); this.hoverDisposables.add(this.editor.onDidLayoutChange(() => this._layout())); this.hoverDisposables.add(this.editor.onDidChangeConfiguration((e: ConfigurationChangedEvent) => { if (e.hasChanged(EditorOption.fontInfo)) { this._updateFont(); } })); this._setVisibleData(null); this._layout(); this.hoverDisposables.add(this._focusTracker.onDidFocus(() => { this._hoverFocusedKey.set(true); })); this.hoverDisposables.add(this._focusTracker.onDidBlur(() => { this._hoverFocusedKey.set(false); })); dom.append(this.element.domNode, this._hover.containerDomNode); } public get position(): Position | null { return this._visibleData?.showAtPosition ?? null; } public get isColorPickerVisible(): boolean { return Boolean(this._visibleData?.colorPicker); } public get isVisibleFromKeyboard(): boolean { return (this._visibleData?.source === HoverStartSource.Keyboard); } public get isVisible(): boolean { return this._hoverVisibleKey.get() ?? false; } public get renderingAbove(): ContentWidgetPositionPreference { return this._renderingAbove; } public set renderingAbove(renderingAbove: ContentWidgetPositionPreference) { this._renderingAbove = renderingAbove; } // NEW public override resize(size: dom.Dimension) { console.log('Inside of resize'); // Removing the max height and max width here - the max size is controlled by the resizable overlay this._hover.contentsDomNode.style.maxHeight = 'none'; this._hover.contentsDomNode.style.maxWidth = 'none'; const width = size.width + 'px'; // const width = size.width - 2 * SASH_WIDTH + TOTAL_BORDER_WIDTH + 'px'; this._hover.containerDomNode.style.width = width; this._hover.contentsDomNode.style.width = width; // const height = size.height - 2 * SASH_WIDTH + TOTAL_BORDER_WIDTH + 'px'; const height = size.height + 'px'; this._hover.containerDomNode.style.height = height; this._hover.contentsDomNode.style.height = height; const scrollDimensions = this._hover.scrollbar.getScrollDimensions(); const hasHorizontalScrollbar = (scrollDimensions.scrollWidth > scrollDimensions.width); if (hasHorizontalScrollbar) { // When there is a horizontal scroll-bar use a different height to make the scroll-bar visible const extraBottomPadding = `${this._hover.scrollbar.options.horizontalScrollbarSize}px`; if (this._hover.contentsDomNode.style.paddingBottom !== extraBottomPadding) { this._hover.contentsDomNode.style.paddingBottom = extraBottomPadding; } this._hover.contentsDomNode.style.height = size.height - SCROLLBAR_WIDTH + 'px'; // - 2 * SASH_WIDTH + TOTAL_BORDER_WIDTH } this._hover.scrollbar.scanDomNode(); this.editor.layoutContentWidget(this.resizableContentWidget); this.editor.render(); } public override findMaximumRenderingHeight(): number | undefined { if (!this.editor || !this.editor.hasModel() || !this._visibleData?.showAtPosition) { return; } const editorBox = dom.getDomNodePagePosition(this.editor.getDomNode()); const mouseBox = this.editor.getScrolledVisiblePosition(this._visibleData.showAtPosition); const bodyBox = dom.getClientArea(document.body); let availableSpace: number; if (this._renderingAbove === ContentWidgetPositionPreference.ABOVE) { availableSpace = editorBox.top + mouseBox.top - 30; } else { const mouseBottom = editorBox.top + mouseBox!.top + mouseBox!.height; availableSpace = bodyBox.height - mouseBottom; } let divMaxHeight = 0; for (const childHtmlElement of this._hover.contentsDomNode.children) { divMaxHeight += childHtmlElement.clientHeight; } if (this._hover.contentsDomNode.clientWidth < this._hover.contentsDomNode.scrollWidth) { divMaxHeight += SCROLLBAR_WIDTH; } return Math.min(availableSpace, divMaxHeight); } public findMaxRenderingWidth(): number | undefined { if (!this.editor || !this.editor.hasModel()) { return; } const editorBox = dom.getDomNodePagePosition(this.editor.getDomNode()); const widthOfEditor = editorBox.width; const leftOfEditor = editorBox.left; const glyphMarginWidth = this.editor.getLayoutInfo().glyphMarginWidth; const leftOfContainer = this._hover.containerDomNode.offsetLeft; return widthOfEditor + leftOfEditor - leftOfContainer - glyphMarginWidth; } public override dispose(): void { this.editor.removeContentWidget(this.resizableContentWidget); if (this._visibleData) { this._visibleData.disposables.dispose(); } super.dispose(); } public getDomNode() { return this._hover.containerDomNode; } public getContentsDomNode() { return this._hover.contentsDomNode; } public isMouseGettingCloser(posx: number, posy: number): boolean { if (!this._visibleData) { return false; } if (typeof this._visibleData.initialMousePosX === 'undefined' || typeof this._visibleData.initialMousePosY === 'undefined') { this._visibleData.initialMousePosX = posx; this._visibleData.initialMousePosY = posy; return false; } const widgetRect = dom.getDomNodePagePosition(this.resizableContentWidget.getDomNode()); if (typeof this._visibleData.closestMouseDistance === 'undefined') { this._visibleData.closestMouseDistance = computeDistanceFromPointToRectangle(this._visibleData.initialMousePosX, this._visibleData.initialMousePosY, widgetRect.left, widgetRect.top, widgetRect.width, widgetRect.height); } const distance = computeDistanceFromPointToRectangle(posx, posy, widgetRect.left, widgetRect.top, widgetRect.width, widgetRect.height); if (!distance || !this._visibleData.closestMouseDistance || distance > this._visibleData.closestMouseDistance + 4 /* tolerance of 4 pixels */) { // The mouse is getting farther away return false; } this._visibleData.closestMouseDistance = Math.min(this._visibleData.closestMouseDistance, distance); return true; } private _setVisibleData(visibleData: ContentHoverVisibleData | null): void { if (this._visibleData) { this._visibleData.disposables.dispose(); } this._visibleData = visibleData; this._hoverVisibleKey.set(!!this._visibleData); this._hover.containerDomNode.classList.toggle('hidden', !this._visibleData); } private _layout(): void { const height = Math.max(this.editor.getLayoutInfo().height / 4, 250); const { fontSize, lineHeight } = this.editor.getOption(EditorOption.fontInfo); this._hover.contentsDomNode.style.fontSize = `${fontSize}px`; this._hover.contentsDomNode.style.lineHeight = `${lineHeight / fontSize}`; this._hover.contentsDomNode.style.maxHeight = `${height}px`; this._hover.contentsDomNode.style.maxWidth = `${Math.max(this.editor.getLayoutInfo().width * 0.66, 500)}px`; } private _updateFont(): void { const codeClasses: HTMLElement[] = Array.prototype.slice.call(this._hover.contentsDomNode.getElementsByClassName('code')); codeClasses.forEach(node => this.editor.applyFontInfo(node)); } public showAt(node: DocumentFragment, visibleData: ContentHoverVisibleData): void { this.editor.addContentWidget(this.resizableContentWidget); const persistedSize = this.findPersistedSize(); if (!this.editor || !this.editor.hasModel()) { return; } this._setVisibleData(visibleData); this._hover.contentsDomNode.textContent = ''; this._hover.contentsDomNode.appendChild(node); this._hover.contentsDomNode.style.paddingBottom = ''; this._updateFont(); const containerDomNode = this.resizableContentWidget.getDomNode(); let height; // If the persisted size has already been found then set a maximum height and width if (!persistedSize) { this._hover.contentsDomNode.style.maxHeight = `${Math.max(this.editor.getLayoutInfo().height / 4, 250)}px`; this._hover.contentsDomNode.style.maxWidth = `${Math.max(this.editor.getLayoutInfo().width * 0.66, 500)}px`; this.onContentsChanged(); // Simply force a synchronous render on the editor // such that the widget does not really render with left = '0px' this.editor.render(); height = containerDomNode.clientHeight; } // When there is a persisted size then do not use a maximum height or width else { this._hover.contentsDomNode.style.maxHeight = 'none'; this._hover.contentsDomNode.style.maxWidth = 'none'; height = persistedSize.height; } // The dimensions of the document in which we are displaying the hover const bodyBox = dom.getClientArea(document.body); // Hard-coded in the hover.css file as 1.5em or 24px const minHeight = 24; // The full height is already passed in as a parameter const fullHeight = height; const editorBox = dom.getDomNodePagePosition(this.editor.getDomNode()); const mouseBox = this.editor.getScrolledVisiblePosition(visibleData.showAtPosition); // Position where the editor box starts + the top of the mouse box relatve to the editor + mouse box height const mouseBottom = editorBox.top + mouseBox.top + mouseBox.height; // Total height of the box minus the position of the bottom of the mouse, this is the maximum height below the mouse position const availableSpaceBelow = bodyBox.height - mouseBottom; // Max height below is the minimum of the available space below and the full height of the widget const maxHeightBelow = Math.min(availableSpaceBelow, fullHeight); // The available space above the mouse position is the height of the top of the editor plus the top of the mouse box relative to the editor const availableSpaceAbove = editorBox.top + mouseBox.top - 30; const maxHeightAbove = Math.min(availableSpaceAbove, fullHeight); // We find the maximum height of the widget possible on the top or on the bottom const maxHeight = Math.min(Math.max(maxHeightAbove, maxHeightBelow), fullHeight); if (height < minHeight) { height = minHeight; } if (height > maxHeight) { height = maxHeight; } // Determining whether we should render above or not ideally if (this.editor.getOption(EditorOption.hover).above) { this._renderingAbove = height <= maxHeightAbove ? ContentWidgetPositionPreference.ABOVE : ContentWidgetPositionPreference.BELOW; } else { this._renderingAbove = height <= maxHeightBelow ? ContentWidgetPositionPreference.BELOW : ContentWidgetPositionPreference.ABOVE; } // See https://github.com/microsoft/vscode/issues/140339 // TODO: Doing a second layout of the hover after force rendering the editor if (!persistedSize) { this.onContentsChanged(); } if (visibleData.stoleFocus) { this._hover.containerDomNode.focus(); } visibleData.colorPicker?.layout(); if (!this._visibleData) { return; } const clientHeight = this._hover.containerDomNode.clientHeight; const clientWidth = this._hover.containerDomNode.clientWidth; this.element.layout(clientHeight, clientWidth); this.resizableContentWidget.position = this._visibleData.showAtPosition; this.resizableContentWidget.secondaryPosition = this._visibleData.showAtSecondaryPosition; this.resizableContentWidget.preference = [this._renderingAbove]; this.resizableContentWidget.positionAffinity = this._visibleData.isBeforeContent ? PositionAffinity.LeftOfInjectedText : undefined; this.editor.layoutContentWidget(this.resizableContentWidget); this.editor.render(); console.log('At the end of showAt'); } public override hide(): void { this.element.clearSashHoverState(); if (this._visibleData) { const stoleFocus = this._visibleData.stoleFocus; this._setVisibleData(null); this.editor.layoutContentWidget(this.resizableContentWidget); if (stoleFocus) { this.editor.focus(); } } } // NEW public onContentsChanged(persistedSize?: dom.Dimension | undefined): void { console.log('Inside of onContentsChanged'); const containerDomNode = this.getDomNode(); const contentsDomNode = this.getContentsDomNode(); // Suppose a persisted size is defined if (persistedSize) { const widthMinusSash = Math.min(this.findMaximumRenderingWidth() ?? Infinity, persistedSize.width); //  - SASH_WIDTH // const heightMinusSash = Math.min(this.findMaxRenderingHeight(this._renderingAbove) ?? Infinity, persistedSize.height - SASH_WIDTH); const heightMinusSash = Math.min(this.findMaximumRenderingHeight() ?? Infinity, persistedSize.height); // SASH_WIDTH // Already setting directly the height and width parameters containerDomNode.style.width = widthMinusSash + 'px'; containerDomNode.style.height = heightMinusSash + 'px'; contentsDomNode.style.width = widthMinusSash + 'px'; contentsDomNode.style.height = heightMinusSash + 'px'; } else { // Otherwise the height and width are set to auto containerDomNode.style.width = 'auto'; containerDomNode.style.height = 'auto'; contentsDomNode.style.width = 'auto'; contentsDomNode.style.height = 'auto'; } this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); const scrollDimensions = this._hover.scrollbar.getScrollDimensions(); const hasHorizontalScrollbar = (scrollDimensions.scrollWidth > scrollDimensions.width); if (hasHorizontalScrollbar) { // There is just a horizontal scrollbar const extraBottomPadding = `${this._hover.scrollbar.options.horizontalScrollbarSize}px`; let reposition = false; if (this._hover.contentsDomNode.style.paddingBottom !== extraBottomPadding) { this._hover.contentsDomNode.style.paddingBottom = extraBottomPadding; reposition = true; } const maxRenderingHeight = this.findMaximumRenderingHeight(); // Need the following code since we are using an exact height when using the persisted size. If not used the horizontal scrollbar would just not be visible. if (persistedSize && maxRenderingHeight) { containerDomNode.style.height = Math.min(maxRenderingHeight, persistedSize.height) + 'px'; //  - SASH_WIDTH contentsDomNode.style.height = Math.min(maxRenderingHeight, persistedSize.height - SCROLLBAR_WIDTH) + 'px'; //  - SASH_WIDTH reposition = true; } if (reposition) { this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); } } } // OLD FUNCTION /* public onContentsChanged(): void { this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); const scrollDimensions = this._hover.scrollbar.getScrollDimensions(); const hasHorizontalScrollbar = (scrollDimensions.scrollWidth > scrollDimensions.width); if (hasHorizontalScrollbar) { // There is just a horizontal scrollbar const extraBottomPadding = `${this._hover.scrollbar.options.horizontalScrollbarSize}px`; if (this._hover.contentsDomNode.style.paddingBottom !== extraBottomPadding) { this._hover.contentsDomNode.style.paddingBottom = extraBottomPadding; this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); } } } */ public clear(): void { this._hover.contentsDomNode.textContent = ''; } public focus(): void { this._hover.containerDomNode.focus(); } public scrollUp(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const fontInfo = this.editor.getOption(EditorOption.fontInfo); this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop - fontInfo.lineHeight }); } public scrollDown(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const fontInfo = this.editor.getOption(EditorOption.fontInfo); this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop + fontInfo.lineHeight }); } public scrollLeft(): void { const scrollLeft = this._hover.scrollbar.getScrollPosition().scrollLeft; this._hover.scrollbar.setScrollPosition({ scrollLeft: scrollLeft - this._horizontalScrollingBy }); } public scrollRight(): void { const scrollLeft = this._hover.scrollbar.getScrollPosition().scrollLeft; this._hover.scrollbar.setScrollPosition({ scrollLeft: scrollLeft + this._horizontalScrollingBy }); } public pageUp(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const scrollHeight = this._hover.scrollbar.getScrollDimensions().height; this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop - scrollHeight }); } public pageDown(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const scrollHeight = this._hover.scrollbar.getScrollDimensions().height; this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop + scrollHeight }); } public goToTop(): void { this._hover.scrollbar.setScrollPosition({ scrollTop: 0 }); } public goToBottom(): void { this._hover.scrollbar.setScrollPosition({ scrollTop: this._hover.scrollbar.getScrollDimensions().scrollHeight }); } public escape(): void { this.editor.focus(); } } export class ResizableContentHoverWidget extends ResizableContentWidget { public ID = 'editor.contrib.resizableContentHoverWidget'; private hoverDisposables = new DisposableStore(); constructor(resizableHoverWidget: ResizableHoverWidget, editor: ICodeEditor) { super(resizableHoverWidget, editor); console.log('Inside of resizable content hover widget'); } } class ContentHoverVisibleData { public closestMouseDistance: number | undefined = undefined; constructor( public readonly colorPicker: IEditorHoverColorPickerWidget | null, public readonly showAtPosition: Position, public readonly showAtSecondaryPosition: Position, public readonly preferAbove: boolean, public readonly stoleFocus: boolean, public readonly source: HoverStartSource, public readonly isBeforeContent: boolean, public initialMousePosX: number | undefined, public initialMousePosY: number | undefined, public readonly disposables: DisposableStore ) { } } function computeDistanceFromPointToRectangle(pointX: number, pointY: number, left: number, top: number, width: number, height: number): number { const x = (left + width / 2); // x center of rectangle const y = (top + height / 2); // y center of rectangle const dx = Math.max(Math.abs(pointX - x) - width / 2, 0); const dy = Math.max(Math.abs(pointY - y) - height / 2, 0); return Math.sqrt(dx * dx + dy * dy); } </ins>", "commid": "vscode_pr_178811"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-ce05c326b29c1a7cacb7acc33a7240cfa97fadd032066d5ea5ebe0ee308f84dc", "text": "} .monaco-hover .markdown-hover > .hover-contents:not(.code-hover-contents) { <del> max-width: 500px; </del> word-wrap: break-word; }", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-0430d88e31c3c72621c1d7ba75dbc1636ae85f6fd6075fd3c1d63c7eca4e1930", "text": "position: absolute; width: 100%; height: 100%; <del> background: transparent; </del> <ins> background: red; </ins> } .monaco-workbench:not(.reduce-motion) .monaco-sash:before {", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-cbb3e9e06f49bfb5b34c1005e92adcf2d587b67e32399f851ce558d8aa2655f2", "text": "import { Context as SuggestContext } from 'vs/editor/contrib/suggest/browser/suggest'; import { AsyncIterableObject } from 'vs/base/common/async'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; <ins> import { ResizableHoverWidget } from 'vs/editor/contrib/hover/browser/resizableHoverWidget'; </ins> const $ = dom.$; export class ContentHoverController extends Disposable { private readonly _participants: IEditorHoverParticipant[]; <del> private readonly _widget = this._register(this._instantiationService.createInstance(ContentHoverWidget, this._editor)); </del> <ins> // INITIALLY: private readonly _widget = this._register(this._instantiationService.createInstance(ContentHoverWidget, this._editor)); private readonly _widget; </ins> private readonly _computer: ContentHoverComputer; private readonly _hoverOperation: HoverOperation<IHoverPart>;", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-bee2c7bd12b632248a1a8f95b4040273599e0905261fa26cb6981cc75e48ebd9", "text": ") { super(); <ins> this._widget = this._register(this._instantiationService.createInstance(ResizableHoverWidget, this._editor)); </ins> // Instantiate participants and sort them by `hoverOrdinal` which is relevant for rendering order. this._participants = []; for (const participant of HoverParticipantRegistry.getAll()) {", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-964ede88c1a453e01702460de097ca25b00c72c5b4236e441131464192801d45", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .monaco-editor .resizable-widget { z-index: 40; display: block; } </ins>", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-b6461bd37893d813d70cb5125334ff3dc57828825c0534e4b8ca84ffbd01b1ab", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { IResizeEvent, ResizableHTMLElement } from 'vs/base/browser/ui/resizable/resizable'; import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle'; import { ResourceMap } from 'vs/base/common/map'; import { ContentWidgetPositionPreference, ICodeEditor, IContentWidget, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser'; import { IPosition } from 'vs/editor/common/core/position'; import { PositionAffinity } from 'vs/editor/common/model'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import * as dom from 'vs/base/browser/dom'; import { clamp } from 'vs/base/common/numbers'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; import { Emitter, Event } from 'vs/base/common/event'; export abstract class ResizableWidget implements IDisposable { readonly element: ResizableHTMLElement; private readonly _disposables = new DisposableStore(); private readonly _persistingMechanism: IPersistingMechanism; constructor( private readonly _editor: ICodeEditor, private readonly _persistingOptions: IPersistingOptions, ) { console.log('Inside of ResizableWidget constructor'); this.element = new ResizableHTMLElement(); this.element.domNode.classList.add('editor-widget', 'resizable-widget'); if (this._persistingOptions instanceof SingleSizePersistingOptions) { this._persistingMechanism = new SingleSizePersistingMechanism(this, this.element, this._editor, this._persistingOptions); } else if (this._persistingOptions instanceof MultipleSizePersistingOptions) { this._persistingMechanism = new MultipleSizePersistingMechanism(this, this.element, this._editor); } else { throw new Error('Please specify a valid persisting mechanism'); } } dispose(): void { this._disposables.dispose(); this.element.dispose(); } resize(dimension: dom.Dimension): void { } hide(): void { this.element.clearSashHoverState(); } findMaximumRenderingHeight(): number | undefined { return Infinity; } findMaximumRenderingWidth(): number | undefined { return Infinity; } findPersistedSize(): dom.Dimension | undefined { return this._persistingMechanism.findSize(); } } export abstract class ResizableContentWidget implements IContentWidget { abstract ID: string; private _position: IPosition | null = null; private _secondaryPosition: IPosition | null = null; private _preference: ContentWidgetPositionPreference[] = []; private _positionAffinity: PositionAffinity | undefined = undefined; constructor(private readonly resizableWidget: ResizableWidget, private readonly editor: ICodeEditor) { this.editor.addContentWidget(this); console.log('Inisde of ResizableContentWidget constructor'); } findPersistedSize(): dom.Dimension | undefined { return this.resizableWidget.findPersistedSize(); } getId(): string { console.log('this.ID : ', this.ID); return this.ID; } getDomNode(): HTMLElement { console.log('Inside of getDomNode of ResizableContentWidget'); console.log('this.resizableWidget.element.domNode : ', this.resizableWidget.element.domNode); this.resizableWidget.element.domNode.style.zIndex = '49'; this.resizableWidget.element.domNode.style.position = 'fixed'; // this.resizableWidget.element.domNode.style.display = 'block'; return this.resizableWidget.element.domNode; } getPosition(): IContentWidgetPosition | null { console.log('Inside of getPosition of ResizableContentWidget'); const contentWidgetPosition = { position: this._position, secondaryPosition: this._secondaryPosition, preference: (this._preference), positionAffinity: this._positionAffinity }; console.log('contentWidgetPosition: ', contentWidgetPosition); return contentWidgetPosition; } hide(): void { this.editor.layoutContentWidget(this); } set position(position: IPosition | null) { this._position = position; } set secondaryPosition(position: IPosition | null) { this._secondaryPosition = position; } set preference(preference: ContentWidgetPositionPreference[]) { this._preference = preference; } set positionAffinity(affinity: PositionAffinity | undefined) { this._positionAffinity = affinity; } } interface IPersistingOptions { } export class SingleSizePersistingOptions implements IPersistingOptions { constructor( public readonly key: string, public readonly defaultSize: dom.Dimension, @IStorageService public readonly storageService: IStorageService ) { } } export class MultipleSizePersistingOptions implements IPersistingOptions { constructor() { } } interface IPersistingMechanism extends IDisposable { findSize(): dom.Dimension | undefined; } // TODO: maybe need to make more generic, this is specific to the suggest widget class SingleSizePersistingMechanism implements IPersistingMechanism { private readonly _persistedWidgetSize: PersistedWidgetSize | null = null; private readonly _disposables = new DisposableStore(); constructor( private readonly resizableWidget: ResizableWidget, private readonly element: ResizableHTMLElement, private readonly editor: ICodeEditor, private readonly persistingOptions: SingleSizePersistingOptions ) { this._persistedWidgetSize = new PersistedWidgetSize(this.persistingOptions.key, this.persistingOptions.storageService, this.editor); class ResizeState { constructor( readonly persistedSize: dom.Dimension | undefined, readonly currentSize: dom.Dimension, public persistHeight = false, public persistWidth = false, ) { } } let state: ResizeState | undefined; this._disposables.add(this.element.onDidWillResize(() => { // TODO: add back, this._contentWidget.lockPreference(); state = new ResizeState(this._persistedWidgetSize!.restore(), this.element.size); })); this._disposables.add(this.element.onDidResize(e => { this.resizableWidget.resize(new dom.Dimension(e.dimension.width, e.dimension.height)); if (state) { state.persistHeight = state.persistHeight || !!e.north || !!e.south; state.persistWidth = state.persistWidth || !!e.east || !!e.west; } if (!e.done) { return; } if (state) { const fontInfo = this.editor.getOption(EditorOption.fontInfo); const itemHeight = clamp(this.editor.getOption(EditorOption.suggestLineHeight) || fontInfo.lineHeight, 8, 1000); const threshold = Math.round(itemHeight / 2); let { width, height } = this.element.size; if (!state.persistHeight || Math.abs(state.currentSize.height - height) <= threshold) { height = state.persistedSize?.height ?? this.persistingOptions.defaultSize.height; } if (!state.persistWidth || Math.abs(state.currentSize.width - width) <= threshold) { width = state.persistedSize?.width ?? this.persistingOptions.defaultSize.width; } this._persistedWidgetSize!.store(new dom.Dimension(width, height)); } // TODO: add back, reset working state // this._contentWidget.unlockPreference(); state = undefined; })); } findSize(): dom.Dimension | undefined { return undefined; } dispose(): void { this._disposables.dispose(); } } class MultipleSizePersistingMechanism implements IPersistingMechanism { private readonly _persistedWidgetSizes: ResourceMap<Map<string, dom.Dimension>> = new ResourceMap<Map<string, dom.Dimension>>(); private readonly _disposables = new DisposableStore(); private _tooltipPosition: IPosition | null = null; // TODO: not sure if I need the following // private _initialHeight: number = 0; // private _initialTop: number = 0; private _resizing: boolean = false; private _size: dom.Dimension | undefined = undefined; private _maxRenderingHeight: number | undefined = Infinity; private _maxRenderingWidth: number | undefined = Infinity; private readonly _onDidResize = new Emitter<IResizeEvent>(); readonly onDidResize: Event<IResizeEvent> = this._onDidResize.event; // private _renderingAbove: ContentWidgetPositionPreference | undefined = undefined; constructor( private readonly resizableWidget: ResizableWidget, private readonly element: ResizableHTMLElement, public readonly editor: ICodeEditor ) { this.element.minSize = new dom.Dimension(10, 24); this._disposables.add(this.editor.onDidChangeModelContent((e) => { const uri = this.editor.getModel()?.uri; if (!uri || !this._persistedWidgetSizes.has(uri)) { return; } const persistedSizesForUri = this._persistedWidgetSizes.get(uri)!; const updatedPersistedSizesForUri = new Map<string, dom.Dimension>(); for (const change of e.changes) { const changeOffset = change.rangeOffset; const rangeLength = change.rangeLength; const endOffset = changeOffset + rangeLength; const textLength = change.text.length; for (const key of persistedSizesForUri.keys()) { const parsedKey = JSON.parse(key); const tokenOffset = parsedKey[0]; const tokenLength = parsedKey[1]; if (endOffset < tokenOffset) { const oldSize = persistedSizesForUri.get(key)!; const newKey: [number, number] = [tokenOffset - rangeLength + textLength, tokenLength]; updatedPersistedSizesForUri.set(JSON.stringify(newKey), oldSize); } else if (changeOffset >= tokenOffset + tokenLength) { updatedPersistedSizesForUri.set(key, persistedSizesForUri.get(key)!); } } } this._persistedWidgetSizes.set(uri, updatedPersistedSizesForUri); })); this._disposables.add(this.element.onDidWillResize(() => { this._resizing = true; // this._initialHeight = this.element.domNode.clientHeight; // this._initialTop = this.element.domNode.offsetTop; })); this._disposables.add(this.element.onDidResize(e => { let height = e.dimension.height; let width = e.dimension.width; const maxWidth = this.element.maxSize.width; const maxHeight = this.element.maxSize.height; width = Math.min(maxWidth, width); height = Math.min(maxHeight, height); if (!this._maxRenderingHeight) { return; } this._size = new dom.Dimension(width, height); this.element.layout(height, width); // Calling the resize function of the this.resizableWidget.resize(new dom.Dimension(width, height)); // Update the top parameters only when we decided to render above // TODO: presumably do not need to resize the element // if (this._renderingAbove === ContentWidgetPositionPreference.ABOVE) { // \tthis.element.domNode.style.top = this._initialTop - (height - this._initialHeight) + 'px'; // } // const horizontalSashWidth = width - 2 * SASH_WIDTH + 2 * TOTAL_BORDER_WIDTH + 'px'; // this.element.northSash.el.style.width = horizontalSashWidth; // this.element.southSash.el.style.width = horizontalSashWidth; // const verticalSashWidth = height - 2 * SASH_WIDTH + 2 * TOTAL_BORDER_WIDTH + 'px'; // this.element.eastSash.el.style.height = verticalSashWidth; // this.element.westSash.el.style.height = verticalSashWidth; // this.element.eastSash.el.style.top = TOTAL_BORDER_WIDTH + 'px'; // Fire the current dimension // TODO: probably don't need to listen on the firing event? // this._onDidResize.fire({ dimension: this._size, done: false }); this._maxRenderingWidth = this.resizableWidget.findMaximumRenderingWidth(); this._maxRenderingHeight = this.resizableWidget.findMaximumRenderingHeight(); // this._maxRenderingHeight = this.resizableWidget.findMaximumRenderingHeight(this._renderingAbove); if (!this._maxRenderingHeight || !this._maxRenderingWidth) { return; } this.element.maxSize = new dom.Dimension(this._maxRenderingWidth, this._maxRenderingHeight); // Persist the height only when the resizing has stopped if (e.done) { if (!this.editor.hasModel()) { return; } const uri = this.editor.getModel().uri; if (!uri || !this._tooltipPosition) { return; } const persistedSize = new dom.Dimension(width, height); const wordPosition = this.editor.getModel().getWordAtPosition(this._tooltipPosition); if (!wordPosition) { return; } const offset = this.editor.getModel().getOffsetAt({ lineNumber: this._tooltipPosition.lineNumber, column: wordPosition.startColumn }); const length = wordPosition.word.length; // Suppose that the uri does not exist in the persisted widget hover sizes, then create a map if (!this._persistedWidgetSizes.get(uri)) { const persistedWidgetSizesForUri = new Map<string, dom.Dimension>([]); persistedWidgetSizesForUri.set(JSON.stringify([offset, length]), persistedSize); this._persistedWidgetSizes.set(uri, persistedWidgetSizesForUri); } else { const persistedWidgetSizesForUri = this._persistedWidgetSizes.get(uri)!; persistedWidgetSizesForUri.set(JSON.stringify([offset, length]), persistedSize); } this._resizing = false; } // this.editor.layoutOverlayWidget(this); // this.editor.render(); })); } set tooltipPosition(position: IPosition) { this._tooltipPosition = position; } findSize(): dom.Dimension | undefined { console.log('Inside of findSize of the MultiplePersistingMechanisms'); if (!this._tooltipPosition || !this.editor.hasModel()) { return; } const wordPosition = this.editor.getModel().getWordAtPosition(this._tooltipPosition); if (!wordPosition) { return; } const offset = this.editor.getModel().getOffsetAt({ lineNumber: this._tooltipPosition.lineNumber, column: wordPosition.startColumn }); const length = wordPosition.word.length; const uri = this.editor.getModel().uri; const persistedSizesForUri = this._persistedWidgetSizes.get(uri); if (!persistedSizesForUri) { return; } return persistedSizesForUri.get(JSON.stringify([offset, length])); } dispose(): void { this._disposables.dispose(); } } class PersistedWidgetSize { constructor( private readonly _key: string, private readonly _service: IStorageService, editor: ICodeEditor ) { } restore(): dom.Dimension | undefined { const raw = this._service.get(this._key, StorageScope.PROFILE) ?? ''; try { const obj = JSON.parse(raw); if (dom.Dimension.is(obj)) { return dom.Dimension.lift(obj); } } catch { // ignore } return undefined; } store(size: dom.Dimension) { this._service.store(this._key, JSON.stringify(size), StorageScope.PROFILE, StorageTarget.MACHINE); } reset(): void { this._service.remove(this._key, StorageScope.PROFILE); } } </ins>", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-49a6e04313299b638bdf063b63202f9ab857773dfc5e59e34f2b8e381cfb762f", "query": "When you hover over a type in a TypeScript file, the tooltip that appears has a very low max width, making it difficult to read long type signatures.\nI would include a screenshot but it's not easy to take a screenshot keeping the tooltip on screen!\n! Errors are quite unreadable if the width does not adapt to the font size.\n! it would be nice if the tip used the available space instead of wrapping at an arbitrary point in c# too\n!\n! Same problem using rust's language server.\nGeneral styling control would be very helpful. Also line-height. Another approach would be to have a bottom panel that displays the full error and the tooltip displays a shortened version.\n!\n! When using the auto import feature it is often impossible to differentiate whats what as the import path is cut off due to the limited width of the suggestions window.\nIs this something we can adjust with custom css? It makes snippet infoormation very difficult to read as well. !\nSame in Python. We have to jump through hoops trying to flow doc nicely. And when it appears OK on Windows, it breaks on Mac... ! And it is inconsistent. Ex, hover is OK ! But completion list decides to wrap. What gives? ! Looks like hover respects markdown while completion item doc is plain string and gets wrapped randomly.\n!\nSomeone say long type signatures? !\nHere is a workaround by hacking the file \"C:Program FilesMicrosoft VS Coderesourcesappoutvsworkbench\" Simply append the code above after the original content of file, and restart VSCode. (Title bar may alert a warning message \"Not Supported\" and hacked changes would be overridden by updating VSCode) !\nIt would be nice to have some control on the width. The above does work but vscode presents the message your installation may be corrupt on restarting.\nInstead of hacking the CSS directly as mentioned above, I recommend using the to just override the current CSS. That way when VSCode updates, you can just reload the custom css file that you have specified (personally, I have a project where I hold configurations for my shell, Spacemacs, etc. and this custom CSS file goes there). Until it's officially supported, hacking the CSS is likely the best route. The suggested widths above were a bit much for me, so I settled on the following values for now:\nWhat is preventing the devs from providing a configuration option for this? This issue has been open for almost 2 years, and it bugs me on a daily basis. Would love to see it fixed.\n(since you seem like the most relevant person to ping) is anything likely to be done about this?\nI would love to hear an explanation from devs too. What are the difficulties of implementing this? I imagine it's settings a dynamic max-width and adding some more lines to add it in Settings. Are there other design blockers?\nWill you take a look at this? In 3 days it will be a 2 year anniversary for this simple feature request.\nAssigned to and as I remember we are going to have some UX improvements for editor tooltips and so on.\nmaybe now is the time to take this on? current iteration tries to solve parameter hints ux and this is not that much different\n! I employed CSS and put together full instructions: [Custom CSS and JS Loader extension][1] macOS VS Code: VS Code Insiders: Linux: : [1]: Restart VSCode Ignore \"VSCode is corrupt\" error You can choose to suppress this notice forever Run command \"Reload Custom CSS and JS\"\njust as a disclaimer, if anyone modifies the CSS/JS of the app, it comes up at \u201ccorrupted\u201d in diagnostic checks, and you\u2019ll typically get pushback if you report issues and include diagnostic information. Or, at least, I received pushback when I had custom CSS/JS enabled, and wouldn\u2019t receive help until I turned it off (even though it was harmless/not related to the issue I was having). While this is indeed an okay workaround, we should just keep making our voices heard so that this is natively supported.\n100% agree. This is just a workaround. It's hard enough to read TypeScript lint as it is! :)\nCurrenlty using VSCode 1.30.2, followed instructions step by step, but it's not working. I don't even get the VSCode corrupt error. I'm running Windows 10 (V.1803). Edit: It was my mistake. For anyone who's having trouble, make sure to run Enable Custom CSS and JS from the command palette. Simply restarting won't work.\nThis issue seems to be fixed in 1.32.0-insider (1.32.0-insider) . I hope this is an intended behavior. I want to thank the developers.\nThis change is related to . I confirmed that the max width of is still small as mentioned above. <img width=\"867\" alt=\"2019-02-22 17 06 19\" src=\"https://user-\"\nUpdate: in , only the hovers for problems and the hovers with code blocks become to have larger width. Others have smaller width.\nHello there,your solution is great,but I want to ask how to get rid of the word at the title.As sort of OCD,sufferring from that. thx a lot!\nThis extension was created specifically for solving this:\nThis has been a long standing annoyance, with an issue that's like 2 and a half year ago. It shouldn't take much effort to have a config property that overrides the width/height of the tooltip, surely? Like, 10 mins of effort? <img width=\"525\" alt=\"Screen Shot 2019-07-18 at 6 41 15 PM\" src=\"https://user-\"\nif it's really 10 mins of effort, then I'm sure you can submit a PR for this? I definitely can't do this in anywhere close to 10 mins, so it would be much appreciated!\nSeriously, I want instead of this: ! At least something like this (with syntax highlighting it will be even better): !\nThere's already been a PR. I really don't understand this. I figure most VScode devs develop VScode in VScode, are they comfortable with the current state?\nfyi, it would be great if the hover could be resized\nHow is this issue 4 years old and such a basic thing still isn't implemented?\nIs there any word on whether we could see this soon? The suggestion widget has had resizing enabled since v1.51 in October, 2020. Is this tooltip widget considerably harder to add this feature for or are there additional considerations to be made? Whether it's a click to resize, or a manual adjustment in settings, could we have an update on the status of this addition? Opening new editor tabs just to properly read code annotations for some more descriptive components on my large monitors does feel like an unnecessary extra step.\nmight be very related and close to what you did here:\nHi, Instead of configuring the max width as the title says, could the tooltip hover be resizable ? (Also check for more info on what was done with the suggest widget)\nIt's sad to see that it's still not a thing.. I would really like to adjust the height of hover description tooltips.. The big brother Visual Studio does a much better job already. Let VS Code catch up a little..\nanother possible view for this issue\nIt is 2022/11/11. Christmas is close and I made sure Santa knows what I want!\n\"Excuse me, it's 2023\"\nThis one will be my favorite. Copilot suggestions and TS errors just can't be seen in this tooltip. It's time to fix it.\nIf this is still open and no one is looking at it, I'll take a crack at it. Feel free to assign it to me if that's alright.\nHey all, thank you for your patience. A PR has been made which is currently under work but nearing its completion. You may find it here: Once this PR is merged, you will be able to resize content hovers within Insiders.\nWould you add \"Reset Hover Widget Size\" command in Command Palette? Like we have for suggest widget: \"Reset Suggest Widget Size\". It would be good if we could reset the size to the initial one.\nThank you very much. 1 Is it correct, that this would not stay across different sessions? 2 The default max width is very small, is there any consideration, of increasing that?\nWill this feature also allow us to define the window size of a hover provider in a extension above the current limitations?\nHi if is is decided that the hover widget size should be configurable, there will be a command to clear the persisted sizes. This feature is still under discussion. Hi depending on the implementation, it is possible that the persisted sizes are persisted or not across different sessions. This is still under discussion. Currently the implementation is such that the maximum natural width is the same as before. Hi the current implementation does not provide this functionality. This could be addressed in a separate issue as it is related to the usage of the hover widget by extensions. The current PR that is worked on is the following:\nThanks a lot. And do you consider increasing the default size, that is unfitting to most real world scenarios? The windows is so small, that I feel the need to increase it even on my WXGA Laptop.\nHey all, thank you for the patience. A PR has been merged in order to make the content hover resizable. The change should be visible in tomorrow's VS Code insiders version and in the next stable release which will happen in the coming two weeks. There currently is no mechanism to save the content hover - we are discussing how best to approach it. You may track the issue on persisting the hover content here: we are currently not thinking about increasing the default maximum size. However it is possible that we implement the persisting mechanism as follows: when you increase the content hover size to a specific size, this size is persisted, and it is applied as maximum default size on the next hover appearances. This potential implementation is still under discussion by our team.\nJust want to say thank you you seem to have been tackling a lot of these high-level nitpicks that have been in the VSCode backlog for years, and for that I am very appreciative.\nI can't find a command to clear/reset hover widget size, is this has been ?\nHi currently the command does not exist because a persisting mechanism has not been put into place as of yet. It will appear when the latter is .\nOh okay, thanks a lot", "positive_passages": [{"docid": "doc-en-vscode-ecdd0fa3ef2c21ed8c9b05d82b3e53261b0655fa9e31d8f9479e000c0f1017ef", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { HoverWidget } from 'vs/base/browser/ui/hover/hoverWidget'; import { DisposableStore } from 'vs/base/common/lifecycle'; import { ContentWidgetPositionPreference, ICodeEditor, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { MultipleSizePersistingOptions, ResizableContentWidget, ResizableWidget } from 'vs/editor/contrib/hover/browser/resizableContentWidget'; import * as dom from 'vs/base/browser/dom'; import { ConfigurationChangedEvent, EditorOption } from 'vs/editor/common/config/editorOptions'; import { Position } from 'vs/editor/common/core/position'; import { HoverStartSource } from 'vs/editor/contrib/hover/browser/hoverOperation'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { PositionAffinity } from 'vs/editor/common/model'; import { IEditorHoverColorPickerWidget } from 'vs/editor/contrib/hover/browser/hoverTypes'; const SCROLLBAR_WIDTH = 10; // TODO: maybe don't need the resizable widget class export class ResizableHoverWidget extends ResizableWidget { public ID = 'editor.contrib.resizableContentHoverWidget'; private hoverDisposables = new DisposableStore(); // The ContentWidget is a child of the resizable widget private resizableContentWidget: ResizableContentHoverWidget; public readonly allowEditorOverflow = true; public readonly _hover: HoverWidget = this.hoverDisposables.add(new HoverWidget()); private readonly editor: ICodeEditor; private readonly _hoverVisibleKey = EditorContextKeys.hoverVisible.bindTo(this._contextKeyService); private readonly _hoverFocusedKey = EditorContextKeys.hoverFocused.bindTo(this._contextKeyService); private readonly _focusTracker = this.hoverDisposables.add(dom.trackFocus(this.getDomNode())); private readonly _horizontalScrollingBy: number = 30; private _visibleData: ContentHoverVisibleData | null = null; private _renderingAbove: ContentWidgetPositionPreference; constructor( editor: ICodeEditor, @IContextKeyService private readonly _contextKeyService: IContextKeyService ) { super(editor, new MultipleSizePersistingOptions()); this.editor = editor; // create here the dom node and all other logic should go here that was in the super abstract class this.resizableContentWidget = new ResizableContentHoverWidget(this, editor); this._renderingAbove = this.editor.getOption(EditorOption.hover).above ? ContentWidgetPositionPreference.ABOVE : ContentWidgetPositionPreference.BELOW; this.hoverDisposables.add(this.element.onDidResize((e) => { // When the resizable hover overlay changes, resize the widget // this._widget.resize(e.dimension); })); this.hoverDisposables.add(this.editor.onDidLayoutChange(() => this._layout())); this.hoverDisposables.add(this.editor.onDidChangeConfiguration((e: ConfigurationChangedEvent) => { if (e.hasChanged(EditorOption.fontInfo)) { this._updateFont(); } })); this._setVisibleData(null); this._layout(); this.hoverDisposables.add(this._focusTracker.onDidFocus(() => { this._hoverFocusedKey.set(true); })); this.hoverDisposables.add(this._focusTracker.onDidBlur(() => { this._hoverFocusedKey.set(false); })); dom.append(this.element.domNode, this._hover.containerDomNode); } public get position(): Position | null { return this._visibleData?.showAtPosition ?? null; } public get isColorPickerVisible(): boolean { return Boolean(this._visibleData?.colorPicker); } public get isVisibleFromKeyboard(): boolean { return (this._visibleData?.source === HoverStartSource.Keyboard); } public get isVisible(): boolean { return this._hoverVisibleKey.get() ?? false; } public get renderingAbove(): ContentWidgetPositionPreference { return this._renderingAbove; } public set renderingAbove(renderingAbove: ContentWidgetPositionPreference) { this._renderingAbove = renderingAbove; } // NEW public override resize(size: dom.Dimension) { console.log('Inside of resize'); // Removing the max height and max width here - the max size is controlled by the resizable overlay this._hover.contentsDomNode.style.maxHeight = 'none'; this._hover.contentsDomNode.style.maxWidth = 'none'; const width = size.width + 'px'; // const width = size.width - 2 * SASH_WIDTH + TOTAL_BORDER_WIDTH + 'px'; this._hover.containerDomNode.style.width = width; this._hover.contentsDomNode.style.width = width; // const height = size.height - 2 * SASH_WIDTH + TOTAL_BORDER_WIDTH + 'px'; const height = size.height + 'px'; this._hover.containerDomNode.style.height = height; this._hover.contentsDomNode.style.height = height; const scrollDimensions = this._hover.scrollbar.getScrollDimensions(); const hasHorizontalScrollbar = (scrollDimensions.scrollWidth > scrollDimensions.width); if (hasHorizontalScrollbar) { // When there is a horizontal scroll-bar use a different height to make the scroll-bar visible const extraBottomPadding = `${this._hover.scrollbar.options.horizontalScrollbarSize}px`; if (this._hover.contentsDomNode.style.paddingBottom !== extraBottomPadding) { this._hover.contentsDomNode.style.paddingBottom = extraBottomPadding; } this._hover.contentsDomNode.style.height = size.height - SCROLLBAR_WIDTH + 'px'; // - 2 * SASH_WIDTH + TOTAL_BORDER_WIDTH } this._hover.scrollbar.scanDomNode(); this.editor.layoutContentWidget(this.resizableContentWidget); this.editor.render(); } public override findMaximumRenderingHeight(): number | undefined { if (!this.editor || !this.editor.hasModel() || !this._visibleData?.showAtPosition) { return; } const editorBox = dom.getDomNodePagePosition(this.editor.getDomNode()); const mouseBox = this.editor.getScrolledVisiblePosition(this._visibleData.showAtPosition); const bodyBox = dom.getClientArea(document.body); let availableSpace: number; if (this._renderingAbove === ContentWidgetPositionPreference.ABOVE) { availableSpace = editorBox.top + mouseBox.top - 30; } else { const mouseBottom = editorBox.top + mouseBox!.top + mouseBox!.height; availableSpace = bodyBox.height - mouseBottom; } let divMaxHeight = 0; for (const childHtmlElement of this._hover.contentsDomNode.children) { divMaxHeight += childHtmlElement.clientHeight; } if (this._hover.contentsDomNode.clientWidth < this._hover.contentsDomNode.scrollWidth) { divMaxHeight += SCROLLBAR_WIDTH; } return Math.min(availableSpace, divMaxHeight); } public findMaxRenderingWidth(): number | undefined { if (!this.editor || !this.editor.hasModel()) { return; } const editorBox = dom.getDomNodePagePosition(this.editor.getDomNode()); const widthOfEditor = editorBox.width; const leftOfEditor = editorBox.left; const glyphMarginWidth = this.editor.getLayoutInfo().glyphMarginWidth; const leftOfContainer = this._hover.containerDomNode.offsetLeft; return widthOfEditor + leftOfEditor - leftOfContainer - glyphMarginWidth; } public override dispose(): void { this.editor.removeContentWidget(this.resizableContentWidget); if (this._visibleData) { this._visibleData.disposables.dispose(); } super.dispose(); } public getDomNode() { return this._hover.containerDomNode; } public getContentsDomNode() { return this._hover.contentsDomNode; } public isMouseGettingCloser(posx: number, posy: number): boolean { if (!this._visibleData) { return false; } if (typeof this._visibleData.initialMousePosX === 'undefined' || typeof this._visibleData.initialMousePosY === 'undefined') { this._visibleData.initialMousePosX = posx; this._visibleData.initialMousePosY = posy; return false; } const widgetRect = dom.getDomNodePagePosition(this.resizableContentWidget.getDomNode()); if (typeof this._visibleData.closestMouseDistance === 'undefined') { this._visibleData.closestMouseDistance = computeDistanceFromPointToRectangle(this._visibleData.initialMousePosX, this._visibleData.initialMousePosY, widgetRect.left, widgetRect.top, widgetRect.width, widgetRect.height); } const distance = computeDistanceFromPointToRectangle(posx, posy, widgetRect.left, widgetRect.top, widgetRect.width, widgetRect.height); if (!distance || !this._visibleData.closestMouseDistance || distance > this._visibleData.closestMouseDistance + 4 /* tolerance of 4 pixels */) { // The mouse is getting farther away return false; } this._visibleData.closestMouseDistance = Math.min(this._visibleData.closestMouseDistance, distance); return true; } private _setVisibleData(visibleData: ContentHoverVisibleData | null): void { if (this._visibleData) { this._visibleData.disposables.dispose(); } this._visibleData = visibleData; this._hoverVisibleKey.set(!!this._visibleData); this._hover.containerDomNode.classList.toggle('hidden', !this._visibleData); } private _layout(): void { const height = Math.max(this.editor.getLayoutInfo().height / 4, 250); const { fontSize, lineHeight } = this.editor.getOption(EditorOption.fontInfo); this._hover.contentsDomNode.style.fontSize = `${fontSize}px`; this._hover.contentsDomNode.style.lineHeight = `${lineHeight / fontSize}`; this._hover.contentsDomNode.style.maxHeight = `${height}px`; this._hover.contentsDomNode.style.maxWidth = `${Math.max(this.editor.getLayoutInfo().width * 0.66, 500)}px`; } private _updateFont(): void { const codeClasses: HTMLElement[] = Array.prototype.slice.call(this._hover.contentsDomNode.getElementsByClassName('code')); codeClasses.forEach(node => this.editor.applyFontInfo(node)); } public showAt(node: DocumentFragment, visibleData: ContentHoverVisibleData): void { this.editor.addContentWidget(this.resizableContentWidget); const persistedSize = this.findPersistedSize(); if (!this.editor || !this.editor.hasModel()) { return; } this._setVisibleData(visibleData); this._hover.contentsDomNode.textContent = ''; this._hover.contentsDomNode.appendChild(node); this._hover.contentsDomNode.style.paddingBottom = ''; this._updateFont(); const containerDomNode = this.resizableContentWidget.getDomNode(); let height; // If the persisted size has already been found then set a maximum height and width if (!persistedSize) { this._hover.contentsDomNode.style.maxHeight = `${Math.max(this.editor.getLayoutInfo().height / 4, 250)}px`; this._hover.contentsDomNode.style.maxWidth = `${Math.max(this.editor.getLayoutInfo().width * 0.66, 500)}px`; this.onContentsChanged(); // Simply force a synchronous render on the editor // such that the widget does not really render with left = '0px' this.editor.render(); height = containerDomNode.clientHeight; } // When there is a persisted size then do not use a maximum height or width else { this._hover.contentsDomNode.style.maxHeight = 'none'; this._hover.contentsDomNode.style.maxWidth = 'none'; height = persistedSize.height; } // The dimensions of the document in which we are displaying the hover const bodyBox = dom.getClientArea(document.body); // Hard-coded in the hover.css file as 1.5em or 24px const minHeight = 24; // The full height is already passed in as a parameter const fullHeight = height; const editorBox = dom.getDomNodePagePosition(this.editor.getDomNode()); const mouseBox = this.editor.getScrolledVisiblePosition(visibleData.showAtPosition); // Position where the editor box starts + the top of the mouse box relatve to the editor + mouse box height const mouseBottom = editorBox.top + mouseBox.top + mouseBox.height; // Total height of the box minus the position of the bottom of the mouse, this is the maximum height below the mouse position const availableSpaceBelow = bodyBox.height - mouseBottom; // Max height below is the minimum of the available space below and the full height of the widget const maxHeightBelow = Math.min(availableSpaceBelow, fullHeight); // The available space above the mouse position is the height of the top of the editor plus the top of the mouse box relative to the editor const availableSpaceAbove = editorBox.top + mouseBox.top - 30; const maxHeightAbove = Math.min(availableSpaceAbove, fullHeight); // We find the maximum height of the widget possible on the top or on the bottom const maxHeight = Math.min(Math.max(maxHeightAbove, maxHeightBelow), fullHeight); if (height < minHeight) { height = minHeight; } if (height > maxHeight) { height = maxHeight; } // Determining whether we should render above or not ideally if (this.editor.getOption(EditorOption.hover).above) { this._renderingAbove = height <= maxHeightAbove ? ContentWidgetPositionPreference.ABOVE : ContentWidgetPositionPreference.BELOW; } else { this._renderingAbove = height <= maxHeightBelow ? ContentWidgetPositionPreference.BELOW : ContentWidgetPositionPreference.ABOVE; } // See https://github.com/microsoft/vscode/issues/140339 // TODO: Doing a second layout of the hover after force rendering the editor if (!persistedSize) { this.onContentsChanged(); } if (visibleData.stoleFocus) { this._hover.containerDomNode.focus(); } visibleData.colorPicker?.layout(); if (!this._visibleData) { return; } const clientHeight = this._hover.containerDomNode.clientHeight; const clientWidth = this._hover.containerDomNode.clientWidth; this.element.layout(clientHeight, clientWidth); this.resizableContentWidget.position = this._visibleData.showAtPosition; this.resizableContentWidget.secondaryPosition = this._visibleData.showAtSecondaryPosition; this.resizableContentWidget.preference = [this._renderingAbove]; this.resizableContentWidget.positionAffinity = this._visibleData.isBeforeContent ? PositionAffinity.LeftOfInjectedText : undefined; this.editor.layoutContentWidget(this.resizableContentWidget); this.editor.render(); console.log('At the end of showAt'); } public override hide(): void { this.element.clearSashHoverState(); if (this._visibleData) { const stoleFocus = this._visibleData.stoleFocus; this._setVisibleData(null); this.editor.layoutContentWidget(this.resizableContentWidget); if (stoleFocus) { this.editor.focus(); } } } // NEW public onContentsChanged(persistedSize?: dom.Dimension | undefined): void { console.log('Inside of onContentsChanged'); const containerDomNode = this.getDomNode(); const contentsDomNode = this.getContentsDomNode(); // Suppose a persisted size is defined if (persistedSize) { const widthMinusSash = Math.min(this.findMaximumRenderingWidth() ?? Infinity, persistedSize.width); //  - SASH_WIDTH // const heightMinusSash = Math.min(this.findMaxRenderingHeight(this._renderingAbove) ?? Infinity, persistedSize.height - SASH_WIDTH); const heightMinusSash = Math.min(this.findMaximumRenderingHeight() ?? Infinity, persistedSize.height); // SASH_WIDTH // Already setting directly the height and width parameters containerDomNode.style.width = widthMinusSash + 'px'; containerDomNode.style.height = heightMinusSash + 'px'; contentsDomNode.style.width = widthMinusSash + 'px'; contentsDomNode.style.height = heightMinusSash + 'px'; } else { // Otherwise the height and width are set to auto containerDomNode.style.width = 'auto'; containerDomNode.style.height = 'auto'; contentsDomNode.style.width = 'auto'; contentsDomNode.style.height = 'auto'; } this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); const scrollDimensions = this._hover.scrollbar.getScrollDimensions(); const hasHorizontalScrollbar = (scrollDimensions.scrollWidth > scrollDimensions.width); if (hasHorizontalScrollbar) { // There is just a horizontal scrollbar const extraBottomPadding = `${this._hover.scrollbar.options.horizontalScrollbarSize}px`; let reposition = false; if (this._hover.contentsDomNode.style.paddingBottom !== extraBottomPadding) { this._hover.contentsDomNode.style.paddingBottom = extraBottomPadding; reposition = true; } const maxRenderingHeight = this.findMaximumRenderingHeight(); // Need the following code since we are using an exact height when using the persisted size. If not used the horizontal scrollbar would just not be visible. if (persistedSize && maxRenderingHeight) { containerDomNode.style.height = Math.min(maxRenderingHeight, persistedSize.height) + 'px'; //  - SASH_WIDTH contentsDomNode.style.height = Math.min(maxRenderingHeight, persistedSize.height - SCROLLBAR_WIDTH) + 'px'; //  - SASH_WIDTH reposition = true; } if (reposition) { this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); } } } // OLD FUNCTION /* public onContentsChanged(): void { this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); const scrollDimensions = this._hover.scrollbar.getScrollDimensions(); const hasHorizontalScrollbar = (scrollDimensions.scrollWidth > scrollDimensions.width); if (hasHorizontalScrollbar) { // There is just a horizontal scrollbar const extraBottomPadding = `${this._hover.scrollbar.options.horizontalScrollbarSize}px`; if (this._hover.contentsDomNode.style.paddingBottom !== extraBottomPadding) { this._hover.contentsDomNode.style.paddingBottom = extraBottomPadding; this.editor.layoutContentWidget(this.resizableContentWidget); this._hover.onContentsChanged(); } } } */ public clear(): void { this._hover.contentsDomNode.textContent = ''; } public focus(): void { this._hover.containerDomNode.focus(); } public scrollUp(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const fontInfo = this.editor.getOption(EditorOption.fontInfo); this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop - fontInfo.lineHeight }); } public scrollDown(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const fontInfo = this.editor.getOption(EditorOption.fontInfo); this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop + fontInfo.lineHeight }); } public scrollLeft(): void { const scrollLeft = this._hover.scrollbar.getScrollPosition().scrollLeft; this._hover.scrollbar.setScrollPosition({ scrollLeft: scrollLeft - this._horizontalScrollingBy }); } public scrollRight(): void { const scrollLeft = this._hover.scrollbar.getScrollPosition().scrollLeft; this._hover.scrollbar.setScrollPosition({ scrollLeft: scrollLeft + this._horizontalScrollingBy }); } public pageUp(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const scrollHeight = this._hover.scrollbar.getScrollDimensions().height; this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop - scrollHeight }); } public pageDown(): void { const scrollTop = this._hover.scrollbar.getScrollPosition().scrollTop; const scrollHeight = this._hover.scrollbar.getScrollDimensions().height; this._hover.scrollbar.setScrollPosition({ scrollTop: scrollTop + scrollHeight }); } public goToTop(): void { this._hover.scrollbar.setScrollPosition({ scrollTop: 0 }); } public goToBottom(): void { this._hover.scrollbar.setScrollPosition({ scrollTop: this._hover.scrollbar.getScrollDimensions().scrollHeight }); } public escape(): void { this.editor.focus(); } } export class ResizableContentHoverWidget extends ResizableContentWidget { public ID = 'editor.contrib.resizableContentHoverWidget'; private hoverDisposables = new DisposableStore(); constructor(resizableHoverWidget: ResizableHoverWidget, editor: ICodeEditor) { super(resizableHoverWidget, editor); console.log('Inside of resizable content hover widget'); } } class ContentHoverVisibleData { public closestMouseDistance: number | undefined = undefined; constructor( public readonly colorPicker: IEditorHoverColorPickerWidget | null, public readonly showAtPosition: Position, public readonly showAtSecondaryPosition: Position, public readonly preferAbove: boolean, public readonly stoleFocus: boolean, public readonly source: HoverStartSource, public readonly isBeforeContent: boolean, public initialMousePosX: number | undefined, public initialMousePosY: number | undefined, public readonly disposables: DisposableStore ) { } } function computeDistanceFromPointToRectangle(pointX: number, pointY: number, left: number, top: number, width: number, height: number): number { const x = (left + width / 2); // x center of rectangle const y = (top + height / 2); // y center of rectangle const dx = Math.max(Math.abs(pointX - x) - width / 2, 0); const dy = Math.max(Math.abs(pointY - y) - height / 2, 0); return Math.sqrt(dx * dx + dy * dy); } </ins>", "commid": "vscode_pr_185540"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ce764baec8ad743ebb780126df5ac7570542fdcd4cafc1243929529f79fb34f", "query": "VSCode Version: 1.7.2 () OS Version: Windows 10.0. Steps to Reproduce: a file a sentence of text such as Lorem ipsum sit dolar amet. your keyboard cursor after <kbdTab</kbdExpected: Spaces or tabs to be between and Result: word gets converted into an XML tag and auto closed, leaving us with <Lorem</Loremipsum sit dolar amet. !\nThis is coming from Emmet. To disable this, add: to your settings. Although this is currently the expected behavior, I think we should probably disable emmet expansions in markdown by default because this behavior can be annoying during normal writing. Any thoughts?\nthis behaviour is a consequence of , which has as the goal to not hard code in which language modes emmet is enabled for. As a heuristic uses the grammar's scope name hierarchy as a hint. This heuristic has worked pretty well. The scope of the markdown grammar is . This means Markdown is treated as a specialization of and since emmets supports , is enabled in Markdown as well. According the emmet doc there is no special syntax profile available for Markdown So a quick fix would be to: hard code an exclusion for markdown in #isEmmetEnableMode change the scope name of the markdown grammar, so that it doesn't inherit from html, not sure what the consequences of this are. do you have other ideas how to improve the support for emmet in Markdown and avoid the surprise described in this issue?\nHello, I see the same way as you suggested above. But, perhaps, we can also disable Markdown in the settings, as it was for . If you decide to disable Emmet inside Markdown, it is better to first option. But my 2 cents: Markdown is a lightweight markup language and it presupposes the existence of HTML constructs within yourself. Thus, it seems to me, to disable Emmet inside Markdown is not correct. P.S. Small news: the creator of Emmet had already started work on the second version aka 2.0.0\nthanks for the feedback. I agree with your point that disabling emmet without some way to re-enable it, if someone really wants emmet is better than to totally disable it. Glad to hear about Emmet 2.0.\nCould just be in the default setting for ? That would stop most users from triggering emmet unexpectedly in markdown files, while still allowing users to opt back in to emmet for markdown if they wish\nthe idea is good. It has a small drawback. If someone defines in the settings, then they will not profit from this fix. However, if someone if familiar with this setting and then they know how to disable emmet in markdown, if they are annoyed by it. Bottom line I'm fine with this fix.\nOk, I've merged in which adds to the default list of excluded languages. Not a perfect solution, but it should stop many users from hitting this behavior unexpectedly", "positive_passages": [{"docid": "doc-en-vscode-ccafbca59e43e2c155d746015bb1da3c9ae59b9df9a3d69825cd57bc3f5a8091", "text": "}, 'emmet.excludeLanguages': { 'type': 'array', <del> 'default': [], </del> <ins> 'default': ['markdown'], </ins> 'description': nls.localize('emmetExclude', \"An array of languages where emmet abbreviations should not be expanded.\") }, }", "commid": "vscode_pr_17094"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e7e08a14faa525f594b7bc37537a21ab55d1ee07eff706c4f24e1bd30d78b8f", "query": "VSCode Version: Code - Insiders 1.8.0-insider (, 2016-12-06T16:53:46.634Z) OS Version: Darwin x64 15.6.0 Testing The current message seems to general: \"For better performance exclude folders with many files.\" \"better performance\" is to weak because the typescript server basically shutdown and won't provide any of the advanced features. \"folders with many files\" is vague, it should mention JavaScript/TypeScript files that the user does not work on (like packages/libraries). could also mention that this happens in the js-, that would set the right expectation for the 'Configure Excludes' button and also inform the user how this can be done manually. Needs more thought: \"Too many JavaScript/TypeScript files: To enable advanced editor features in JavaScript/TypeScript files exclude large folders with source files you do not work on.\" /cc\nAlso, the status bar button might benefit from being specific about the language it refers to.", "positive_passages": [{"docid": "doc-en-vscode-2f12b1a741b8f136aaeac337f5faae93fe34fa3b07227c7d8b45017e129d8459", "text": "public show(configFileName: string, largeRoots: string, onExecute: () => void) { this._currentHint = { message: largeRoots.length > 0 <del> ? localize('hintExclude', \"For better performance exclude folders with many files, like: {0}\", largeRoots) : localize('hintExclude.generic', \"For better performance exclude folders with many files.\"), </del> <ins> ? localize('hintExclude', \"To enable JavaScript/TypeScript IntelliSense, exclude folders with many files, like: {0}\", largeRoots) : localize('hintExclude.generic', \"To enable JavaScript/TypeScript IntelliSense, exclude large folders with source files that you do not work on.\"), </ins> options: [{ title: localize('open', \"Configure Excludes\"), execute: () => {", "commid": "vscode_pr_16774"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e7e08a14faa525f594b7bc37537a21ab55d1ee07eff706c4f24e1bd30d78b8f", "query": "VSCode Version: Code - Insiders 1.8.0-insider (, 2016-12-06T16:53:46.634Z) OS Version: Darwin x64 15.6.0 Testing The current message seems to general: \"For better performance exclude folders with many files.\" \"better performance\" is to weak because the typescript server basically shutdown and won't provide any of the advanced features. \"folders with many files\" is vague, it should mention JavaScript/TypeScript files that the user does not work on (like packages/libraries). could also mention that this happens in the js-, that would set the right expectation for the 'Configure Excludes' button and also inform the user how this can be done manually. Needs more thought: \"Too many JavaScript/TypeScript files: To enable advanced editor features in JavaScript/TypeScript files exclude large folders with source files you do not work on.\" /cc\nAlso, the status bar button might benefit from being specific about the language it refers to.", "positive_passages": [{"docid": "doc-en-vscode-6850b82036d9888886a0c8392020993c0cd0d8d941eeb06fb6bf482ff65a540d", "text": "}; this._item.tooltip = this._currentHint.message; this._item.text = localize('large.label', \"Configure Excludes\"); <del> this._item.tooltip = localize('hintExclude.tooltip', \"For better performance exclude folders with many files.\"); </del> <ins> this._item.tooltip = localize('hintExclude.tooltip', \"To enable JavaScript/TypeScript IntelliSense, exclude large folders with source files that you do not work on.\"); </ins> this._item.color = '#A5DF3B'; this._item.show(); this._client.logTelemetry('js.hintProjectExcludes');", "commid": "vscode_pr_16774"}], "negative_passages": []}
{"query_id": "q-en-vscode-24da38d9a5adcb48f948a10cfbaa6444c16c1762e26d2ed6a76470769b1bdcfd", "query": "VSCode Version: Code - Insiders 1.9.0-insider (, 2017-01-20T14:58:38.006Z) OS Version: Linux x64 4.8.0-34-generic Extensions: TypeScript file: ! Press enter: !\nverified.", "positive_passages": [{"docid": "doc-en-vscode-abbfc7b2bf93e8b05889dbfdd2ad1a2f666295453062bb81ee6af0ca3615eb1b", "text": "} else if (enterAction.indentAction === IndentAction.Indent) { // Indent once <del> executeCommand = TypeOperations.typeCommand(range, beforeText + 'n' + config.normalizeIndentation(indentation + 't' + enterAction.appendText), keepPosition); </del> <ins> executeCommand = TypeOperations.typeCommand(range, beforeText + 'n' + config.normalizeIndentation(indentation + enterAction.appendText), keepPosition); </ins> } else if (enterAction.indentAction === IndentAction.IndentOutdent) { // Ultra special let normalIndent = config.normalizeIndentation(indentation); <del> let increasedIndent = config.normalizeIndentation(indentation + 't' + enterAction.appendText); </del> <ins> let increasedIndent = config.normalizeIndentation(indentation + enterAction.appendText); </ins> let typeText = beforeText + 'n' + increasedIndent + 'n' + normalIndent;", "commid": "vscode_pr_18993"}], "negative_passages": []}
{"query_id": "q-en-vscode-24da38d9a5adcb48f948a10cfbaa6444c16c1762e26d2ed6a76470769b1bdcfd", "query": "VSCode Version: Code - Insiders 1.9.0-insider (, 2017-01-20T14:58:38.006Z) OS Version: Linux x64 4.8.0-34-generic Extensions: TypeScript file: ! Press enter: !\nverified.", "positive_passages": [{"docid": "doc-en-vscode-57a545c79e9c12fef8dfa56252731d538d26c5bef0c46f413cb4e7e99c5716d9", "text": "if (!enterResult) { enterResult = { indentAction: IndentAction.None, appendText: '' }; } else { <ins> // Here we add `t` to appendText first because enterAction is leveraging appendText and removeText to change indentation. </ins> if (!enterResult.appendText) { <del> enterResult.appendText = ''; </del> <ins> if ( (enterResult.indentAction === IndentAction.Indent) || (enterResult.indentAction === IndentAction.IndentOutdent) ) { enterResult.appendText = 't'; } else { enterResult.appendText = ''; } </ins> } }", "commid": "vscode_pr_18993"}], "negative_passages": []}
{"query_id": "q-en-vscode-baa33a969db93309ad24ace857b60cb24d4e2707f2969450e49218068e53549e", "query": "Particularly on Windows, should be called to terminate the process. This will ensure the sockets are closed and the pty agent is shutdown.\nClosing in favor of", "positive_passages": [{"docid": "doc-en-vscode-0fc04f62d8d00e404247744c83ce4b062884902b6238bbc51971ffa47d506c10", "text": "}); ptyProcess.on('exit', function (exitCode) { <ins> ptyProcess.kill(); </ins> process.exit(exitCode); });", "commid": "vscode_pr_22844"}], "negative_passages": []}
{"query_id": "q-en-vscode-83fe556b46d99a255f5e92d534ca95c090415bf928d61e22a548f1eba17c4596", "query": "<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with \"./\". Many build systems and tools output file paths relative to the directory the command was run, without the leading \"./\", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in \"\" Is there a reason why relative paths of this form (e.g. no leading \"./\") are not included?\nThe reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.\nI'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:\nNice. I'll write a PR...\nThat would be awesome :+1:\nFixed in", "positive_passages": [{"docid": "doc-en-vscode-a0772aab5998ebfb8536cbadcb6941cd8d9c80eaa1c518f7cf1986a6476a4ace", "text": "const pathSeparatorClause = '/'; const excludedPathCharactersClause = '[^0s!$`&*()[]+'\":;]'; // '\":; are allowed in paths but they are often separators so ignore them const escapedExcludedPathCharactersClause = '(s|!|$|`|&|*|(|)|+)'; <del> /** A regex that matches paths in the form /path, ~/path, ./path, ../path */ const UNIX_LIKE_LOCAL_LINK_REGEX = new RegExp('(' + pathPrefix + '?(' + pathSeparatorClause + '(' + excludedPathCharactersClause + '|' + escapedExcludedPathCharactersClause + ')+)+)'); const winPathPrefix = '([a-zA-Z]:|..?|~)'; </del> <ins> /** A regex that matches paths in the form /foo, ~/foo, ./foo, ../foo, foo/bar */ const UNIX_LIKE_LOCAL_LINK_REGEX = new RegExp('((' + pathPrefix + '|(' + excludedPathCharactersClause + '|' + escapedExcludedPathCharactersClause + ')+)?(' + pathSeparatorClause + '(' + excludedPathCharactersClause + '|' + escapedExcludedPathCharactersClause + ')+)+)'); const winDrivePrefix = '[a-zA-Z]:'; const winPathPrefix = '(' + winDrivePrefix + '|..?|~)'; </ins> const winPathSeparatorClause = '(|/)'; const winExcludedPathCharactersClause = '[^0<>?|/s!$`&*()[]+'\":;]'; <del> /** A regex that matches paths in the form c:path, ~path, .path */ const WINDOWS_LOCAL_LINK_REGEX = new RegExp('(' + winPathPrefix + '?(' + winPathSeparatorClause + '(' + winExcludedPathCharactersClause + ')+)+)'); </del> <ins> /** A regex that matches paths in the form c:foo, ~foo, .foo, ..foo, foobar */ const WINDOWS_LOCAL_LINK_REGEX = new RegExp('((' + winPathPrefix + '|(' + winExcludedPathCharactersClause + ')+)?(' + winPathSeparatorClause + '(' + winExcludedPathCharactersClause + ')+)+)'); </ins> /** Higher than local link, lower than hypertext */ const CUSTOM_LINK_PRIORITY = -1; /** Lowest */", "commid": "vscode_pr_22602"}], "negative_passages": []}
{"query_id": "q-en-vscode-83fe556b46d99a255f5e92d534ca95c090415bf928d61e22a548f1eba17c4596", "query": "<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with \"./\". Many build systems and tools output file paths relative to the directory the command was run, without the leading \"./\", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in \"\" Is there a reason why relative paths of this form (e.g. no leading \"./\") are not included?\nThe reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.\nI'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:\nNice. I'll write a PR...\nThat would be awesome :+1:\nFixed in", "positive_passages": [{"docid": "doc-en-vscode-f0cad3044295844a033d7d4b8b9f57fb012cdd2e79fa50fbd216e51c831c7bba", "text": "}); } <del> private _resolvePath(link: string): TPromise<string> { </del> <ins> protected _preprocessPath(link: string): string { </ins> if (this._platform === platform.Platform.Windows) { // Resolve ~ -> %HOMEDRIVE%%HOMEPATH% if (link.charAt(0) === '~') { if (!process.env.HOMEDRIVE || !process.env.HOMEPATH) { <del> return TPromise.as(void 0); </del> <ins> return null; </ins> } link = `${process.env.HOMEDRIVE}${process.env.HOMEPATH + link.substring(1)}`; } <del> } else { // Resolve workspace path . / .. -> <path>/. / <path/.. if (link.charAt(0) === '.') { if (!this._contextService.hasWorkspace) { </del> <ins> // Resolve relative paths (.a, ..a, ~a, ab) if (!link.match('^' + winDrivePrefix)) { if (!this._contextService.hasWorkspace()) { </ins> // Abort if no workspace is open <del> return TPromise.as(void 0); </del> <ins> return null; </ins> } link = path.join(this._contextService.getWorkspace().resource.fsPath, link); } } <del> // Resolve workspace path . / .. -> <path>/. / <path/.. if (link.charAt(0) === '.') { if (!this._contextService.hasWorkspace) { </del> <ins> // Resolve workspace path . | .. | <relative_path> -> <path>/. | <path>/.. | <path>/<relative_path> else if (link.charAt(0) !== '/' && link.charAt(0) !== '~') { if (!this._contextService.hasWorkspace()) { </ins> // Abort if no workspace is open <del> return TPromise.as(void 0); </del> <ins> return null; </ins> } link = path.join(this._contextService.getWorkspace().resource.fsPath, link); } <ins> return link; } private _resolvePath(link: string): TPromise<string> { link = this._preprocessPath(link); if (!link) { return TPromise.as(void 0); } </ins> // Open an editor if the path exists return pfs.fileExists(link).then(isFile => {", "commid": "vscode_pr_22602"}], "negative_passages": []}
{"query_id": "q-en-vscode-83fe556b46d99a255f5e92d534ca95c090415bf928d61e22a548f1eba17c4596", "query": "<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with \"./\". Many build systems and tools output file paths relative to the directory the command was run, without the leading \"./\", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in \"\" Is there a reason why relative paths of this form (e.g. no leading \"./\") are not included?\nThe reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.\nI'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:\nNice. I'll write a PR...\nThat would be awesome :+1:\nFixed in", "positive_passages": [{"docid": "doc-en-vscode-0563f3a546443edb8bf59830787ae83c46b34faca9432422274b45fb440c3a71", "text": "import * as assert from 'assert'; import { Platform } from 'vs/base/common/platform'; import { TerminalLinkHandler } from 'vs/workbench/parts/terminal/electron-browser/terminalLinkHandler'; <ins> import { IWorkspace, WorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import URI from 'vs/base/common/uri'; import * as path from 'path'; import * as sinon from 'sinon'; </ins> class TestTerminalLinkHandler extends TerminalLinkHandler { public get localLinkRegex(): RegExp { return this._localLinkRegex; } <ins> public preprocessPath(link: string): string { return this._preprocessPath(link); } </ins> } class TestXterm {", "commid": "vscode_pr_22602"}], "negative_passages": []}
{"query_id": "q-en-vscode-83fe556b46d99a255f5e92d534ca95c090415bf928d61e22a548f1eba17c4596", "query": "<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with \"./\". Many build systems and tools output file paths relative to the directory the command was run, without the leading \"./\", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in \"\" Is there a reason why relative paths of this form (e.g. no leading \"./\") are not included?\nThe reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.\nI'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:\nNice. I'll write a PR...\nThat would be awesome :+1:\nFixed in", "positive_passages": [{"docid": "doc-en-vscode-1d78782a8e09508091d2f237c95b35cac48f45747455331a21bd9e18468d17bb", "text": "public setHypertextValidationCallback() { } } <ins> class TestURI extends URI { constructor(private _fakePath: string) { super(); }; get fsPath(): string { return this._fakePath; } } class TestWorkspace implements IWorkspace { resource: URI; constructor(basePath: string) { this.resource = new TestURI(basePath); } } </ins> suite('Workbench - TerminalLinkHandler', () => { suite('localLinkRegex', () => { test('Windows', () => {", "commid": "vscode_pr_22602"}], "negative_passages": []}
{"query_id": "q-en-vscode-83fe556b46d99a255f5e92d534ca95c090415bf928d61e22a548f1eba17c4596", "query": "<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with \"./\". Many build systems and tools output file paths relative to the directory the command was run, without the leading \"./\", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in \"\" Is there a reason why relative paths of this form (e.g. no leading \"./\") are not included?\nThe reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.\nI'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:\nNice. I'll write a PR...\nThat would be awesome :+1:\nFixed in", "positive_passages": [{"docid": "doc-en-vscode-f9cfb048a6b33256730912489c6364dd27aad13273eb8fd17970a188444688d5", "text": "testLink('c:/a/long/path'); testLink('c:alongpath'); testLink('c:mixed/slashpath'); <ins> testLink('a/relative/path'); </ins> }); test('Linux', () => {", "commid": "vscode_pr_22602"}], "negative_passages": []}
{"query_id": "q-en-vscode-83fe556b46d99a255f5e92d534ca95c090415bf928d61e22a548f1eba17c4596", "query": "<!-- Do you have a question? Please ask it on --- VSCode Version: 1.10.2 OS Version: Mac OSX (10.11.6) Steps to Reproduce: VS Code integrated terminal a relative path (eg. ) Description: Let's say you have a build system that outputs a stack trace on a build error or failed test. If this was run from the integrated terminal, the file paths in the output should be included as clickable links which can be clicked to open the file in VSCode. However, this only works if the path is either an absolute path (e.g. ) or a relative path that begins with \"./\". Many build systems and tools output file paths relative to the directory the command was run, without the leading \"./\", Karma for example. So the output would be something like: , not . The first is not matched by VSCode as an openable path, but the second is. I believe that what is determined to be a path comes from the Regex in \"\" Is there a reason why relative paths of this form (e.g. no leading \"./\") are not included?\nThe reason was because until 1.11 links aren't validated so there would be heaps of false positives. Performance was also a factor but it shouldn't impact that much really now that I think about it. Now that links are validated maybe we should be more lenient when linkifying.\nI'll assign this to April but if someone wants to do a PR before then you're welcome. You will need to: Modify the regex to allow paths that are not qualified with , , etc. Make sure that the new path matcher does not conflict with previously matched links and does not create links with adjacent characters. Eg. we want to avoid this:\nNice. I'll write a PR...\nThat would be awesome :+1:\nFixed in", "positive_passages": [{"docid": "doc-en-vscode-623ddc1a3321d69a1eb3e31fc65f2fc5f6cd26e773d19c55f95723eee03a4085", "text": "testLink('./foo'); testLink('../foo'); testLink('/a/long/path'); <ins> testLink('a/relative/path'); }); }); suite('preprocessPath', () => { test('Windows', () => { const linkHandler = new TestTerminalLinkHandler(null, new TestXterm(), Platform.Windows, null, new WorkspaceContextService(new TestWorkspace('C:base'))); let stub = sinon.stub(path, 'join', function (arg1, arg2) { return arg1 + '' + arg2; }); assert.equal(linkHandler.preprocessPath('./src/file1'), 'C:base./src/file1'); assert.equal(linkHandler.preprocessPath('srcfile2'), 'C:basesrcfile2'); assert.equal(linkHandler.preprocessPath('C:absolutepathfile3'), 'C:absolutepathfile3'); stub.restore(); }); test('Linux', () => { const linkHandler = new TestTerminalLinkHandler(null, new TestXterm(), Platform.Linux, null, new WorkspaceContextService(new TestWorkspace('/base'))); let stub = sinon.stub(path, 'join', function (arg1, arg2) { return arg1 + '/' + arg2; }); assert.equal(linkHandler.preprocessPath('./src/file1'), '/base/./src/file1'); assert.equal(linkHandler.preprocessPath('src/file2'), '/base/src/file2'); assert.equal(linkHandler.preprocessPath('/absolute/path/file3'), '/absolute/path/file3'); stub.restore(); }); test('No Workspace', () => { const linkHandler = new TestTerminalLinkHandler(null, new TestXterm(), Platform.Linux, null, new WorkspaceContextService(null)); assert.equal(linkHandler.preprocessPath('./src/file1'), null); assert.equal(linkHandler.preprocessPath('src/file2'), null); assert.equal(linkHandler.preprocessPath('/absolute/path/file3'), '/absolute/path/file3'); </ins> }); }); });  No newline at end of file", "commid": "vscode_pr_22602"}], "negative_passages": []}
{"query_id": "q-en-vscode-8176b5ed55b97e1de970908ac64217ec71792d99eeae9b2b5668070c1707f6c8", "query": "VSCode Version: Code - Insiders 1.11.0-insider (, 2017-03-17T08:14:15.805Z) OS Version: Windows_NT ia32 10.0. Extensions: ; Steps to Reproduce: a terminal and run \"bash\" with a text file containing some lines of text ctrl+v (or right-click) to paste some lines of text What's expected: The text should be appended before the cursor, and the existing text should be there after the cursor. What happens: Existing text disappears, and it seems some extra newlines are when pasting text. Note: there is no such problem when doing the exact same steps with This happens on insider builds, no idea if it happens with standard builds as well.\nMore information. Here is what happens when I try to paste this text function startagent { echo \"Initialising new SSH agent...\" /usr/bin/ssh-agent | sed 's/^echo/#echo/' \"${SSHENV}\" echo succeeded chmod 600 \"${SSHENV}\" . \"${SSHENV}\" /dev/null /usr/bin/ssh-add; } In the middle of a file containing this text: existing file with some text Here is what happens with (that's what expected: text is pasted in between existing text): ! Here is what happens with VSCode: text is pasted with extra newlines plus existing text appears in the middle of the pasted text !\nAny update on this bug ?\nThanks for the ping. I've validated it's definitely an upstream issue. I tried to fix it a couple of days ago but didn't get anywhere. I'd guess it's related to node-pty or winpty as different shells appeared to handle it differently. It also seemed somewhat inconsistent. No plans to invest further in fixing it just yet.\nThis is probably a bug with VSCode's JS xterm module, not a node-pty or winpty bug. I placed these two lines in an untitled editor window: I then set the environment variable , started VSCode, and copy-and-pasted the two lines above into VSCode's integrated terminal. This appeared in the winpty trace: The clipboard has CRLF-delimited lines, because we're on Windows. However, in the VT/100 input format, CR means Return, and LF means Ctrl-Return. Something (probably the JS xterm) is copying the clipboard contents into the pty, and that something should normalize LF and CRLF into CR. I described this bug in detail the last time I saw it:\nthanks! This is likely the culprit then which replaces all end of line chars with on Windows:\nYeah, I think your change will fix the issue. The function looks like it might also need a change. Maybe something like this?\nFYI I think you may have run into these issues before? It would be a good idea to test these changes in in tomorrow's Insiders build.\nI've certainly experienced aspects of this issue from the Python extension when running selections of code in the terminal.\nI was unable to reproduce the problem anyway, so have no way of testing this. But thanks for letting me know :-)", "positive_passages": [{"docid": "doc-en-vscode-2cc5ba4db4d00aec0aab5f4714b382470ea7fa5b8f11ee2bd8544e3b966d856c", "text": "} export class TerminalInstance implements ITerminalInstance { <del> private static readonly EOL_REGEX = /r?n/g; </del> <ins> private static readonly WINDOWS_EOL_REGEX = /r?n/g; </ins> private static _terminalProcessFactory: ITerminalProcessFactory = new StandardTerminalProcessFactory(); private static _lastKnownDimensions: Dimension = null;", "commid": "vscode_pr_25243"}], "negative_passages": []}
{"query_id": "q-en-vscode-8176b5ed55b97e1de970908ac64217ec71792d99eeae9b2b5668070c1707f6c8", "query": "VSCode Version: Code - Insiders 1.11.0-insider (, 2017-03-17T08:14:15.805Z) OS Version: Windows_NT ia32 10.0. Extensions: ; Steps to Reproduce: a terminal and run \"bash\" with a text file containing some lines of text ctrl+v (or right-click) to paste some lines of text What's expected: The text should be appended before the cursor, and the existing text should be there after the cursor. What happens: Existing text disappears, and it seems some extra newlines are when pasting text. Note: there is no such problem when doing the exact same steps with This happens on insider builds, no idea if it happens with standard builds as well.\nMore information. Here is what happens when I try to paste this text function startagent { echo \"Initialising new SSH agent...\" /usr/bin/ssh-agent | sed 's/^echo/#echo/' \"${SSHENV}\" echo succeeded chmod 600 \"${SSHENV}\" . \"${SSHENV}\" /dev/null /usr/bin/ssh-add; } In the middle of a file containing this text: existing file with some text Here is what happens with (that's what expected: text is pasted in between existing text): ! Here is what happens with VSCode: text is pasted with extra newlines plus existing text appears in the middle of the pasted text !\nAny update on this bug ?\nThanks for the ping. I've validated it's definitely an upstream issue. I tried to fix it a couple of days ago but didn't get anywhere. I'd guess it's related to node-pty or winpty as different shells appeared to handle it differently. It also seemed somewhat inconsistent. No plans to invest further in fixing it just yet.\nThis is probably a bug with VSCode's JS xterm module, not a node-pty or winpty bug. I placed these two lines in an untitled editor window: I then set the environment variable , started VSCode, and copy-and-pasted the two lines above into VSCode's integrated terminal. This appeared in the winpty trace: The clipboard has CRLF-delimited lines, because we're on Windows. However, in the VT/100 input format, CR means Return, and LF means Ctrl-Return. Something (probably the JS xterm) is copying the clipboard contents into the pty, and that something should normalize LF and CRLF into CR. I described this bug in detail the last time I saw it:\nthanks! This is likely the culprit then which replaces all end of line chars with on Windows:\nYeah, I think your change will fix the issue. The function looks like it might also need a change. Maybe something like this?\nFYI I think you may have run into these issues before? It would be a good idea to test these changes in in tomorrow's Insiders build.\nI've certainly experienced aspects of this issue from the Python extension when running selections of code in the terminal.\nI was unable to reproduce the problem anyway, so have no way of testing this. But thanks for letting me know :-)", "positive_passages": [{"docid": "doc-en-vscode-40cac31e8f2d7246e1034c26ef0e152e383db68704cb606dc830552c6d0ec11d", "text": "} public sendText(text: string, addNewLine: boolean): void { <del> if (addNewLine && text.substr(text.length - os.EOL.length) !== os.EOL) { text += os.EOL; </del> <ins> text = this._sanitizeInput(text); if (addNewLine && text.substr(text.length - 1) !== 'r') { text += 'r'; </ins> } this._process.send({ event: 'input',", "commid": "vscode_pr_25243"}], "negative_passages": []}
{"query_id": "q-en-vscode-8176b5ed55b97e1de970908ac64217ec71792d99eeae9b2b5668070c1707f6c8", "query": "VSCode Version: Code - Insiders 1.11.0-insider (, 2017-03-17T08:14:15.805Z) OS Version: Windows_NT ia32 10.0. Extensions: ; Steps to Reproduce: a terminal and run \"bash\" with a text file containing some lines of text ctrl+v (or right-click) to paste some lines of text What's expected: The text should be appended before the cursor, and the existing text should be there after the cursor. What happens: Existing text disappears, and it seems some extra newlines are when pasting text. Note: there is no such problem when doing the exact same steps with This happens on insider builds, no idea if it happens with standard builds as well.\nMore information. Here is what happens when I try to paste this text function startagent { echo \"Initialising new SSH agent...\" /usr/bin/ssh-agent | sed 's/^echo/#echo/' \"${SSHENV}\" echo succeeded chmod 600 \"${SSHENV}\" . \"${SSHENV}\" /dev/null /usr/bin/ssh-add; } In the middle of a file containing this text: existing file with some text Here is what happens with (that's what expected: text is pasted in between existing text): ! Here is what happens with VSCode: text is pasted with extra newlines plus existing text appears in the middle of the pasted text !\nAny update on this bug ?\nThanks for the ping. I've validated it's definitely an upstream issue. I tried to fix it a couple of days ago but didn't get anywhere. I'd guess it's related to node-pty or winpty as different shells appeared to handle it differently. It also seemed somewhat inconsistent. No plans to invest further in fixing it just yet.\nThis is probably a bug with VSCode's JS xterm module, not a node-pty or winpty bug. I placed these two lines in an untitled editor window: I then set the environment variable , started VSCode, and copy-and-pasted the two lines above into VSCode's integrated terminal. This appeared in the winpty trace: The clipboard has CRLF-delimited lines, because we're on Windows. However, in the VT/100 input format, CR means Return, and LF means Ctrl-Return. Something (probably the JS xterm) is copying the clipboard contents into the pty, and that something should normalize LF and CRLF into CR. I described this bug in detail the last time I saw it:\nthanks! This is likely the culprit then which replaces all end of line chars with on Windows:\nYeah, I think your change will fix the issue. The function looks like it might also need a change. Maybe something like this?\nFYI I think you may have run into these issues before? It would be a good idea to test these changes in in tomorrow's Insiders build.\nI've certainly experienced aspects of this issue from the Python extension when running selections of code in the terminal.\nI was unable to reproduce the problem anyway, so have no way of testing this. But thanks for letting me know :-)", "positive_passages": [{"docid": "doc-en-vscode-02a3ce0bffec8dfb00d56bf07bdce1a0ee5e2f4d70a57a27b1f6c5aba477d3d3", "text": "} private _sanitizeInput(data: any) { <del> return typeof data === 'string' ? data.replace(TerminalInstance.EOL_REGEX, os.EOL) : data; </del> <ins> return typeof data === 'string' ? data.replace(TerminalInstance.WINDOWS_EOL_REGEX, 'r') : data; </ins> } protected _getCwd(shell: IShellLaunchConfig, workspace: IWorkspace): string {", "commid": "vscode_pr_25243"}], "negative_passages": []}
{"query_id": "q-en-vscode-283d65110775a09080cf52d8bb48f0b24fdeeed3528f1cf19929463ce8467b94", "query": "Chrome-debug supports .js files with query parameters (). But if I load one with \"Open loaded scripts\", the query parameter is stripped. This happens here: since fsPath doesn't include the query parameter. Any idea how to make this work? I don't think URI is expecting to have a URL with another scheme.\nThat normalize code should only be executed if the source could not be found - otherwise should not be and the should be passed to the adapter. Do you know why is that? As for the call - I am not married to it and we can change it to whatever uri massaging techinique would work for you and not break the existing behavior. If we change this I would prefer to be in debt week -april\nIt tries to get the source from , but it looks like that is only populated when it breaks in there, right? Plus it's a different format, the script from the quickopen starts with but the ones in don't.\nI don't know about replacing , would do it if that isn't too hacky.\nYes, is only populated once there is a call stack that contains that source - so if it breaks. Yeah that feels like a total hack. Why don't you experiment with different solutions and create a PR where we can comment and try out different approaches if needed?\nThis regressed from adding back the in DebugContentProvider.getTextContent. is that needed?\nAlso,\nI think opening the file by putting its url into a uri is very fragile, to say the least. I have listed some problems I've noticed while implementing a Loaded Scripts Explorer for the Firefox debug adapter in . My suggestion would be to add the ability to open files using the numerical that the debug adapter assigned to them or using the object that is used for identifying the file in the messages between VS Code and the DA. Whatever solution you adopt, keep in mind that VS Code should be able to determine that the file opened by clicking on a stackframe and the file opened by clicking in the Loaded Scripts Explorer are one and the same - otherwise setting breakpoints in a file opened through the Loaded Scripts Explorer will become problematic.\nI've addressed this issue by making sure that the flow -uri -preserves the data so that the initial and resulting objects are identical. The \"path\" attribute of the source object can contain anything, e.g. a file system path or a full URL. So if a Uri is constructed in the following way: the debugContentProvider inside VS Code will retrieve the content by sending a \"sourceRequest\" with a \"Source\" argument to the debug adapter identified by the debug session.\nVerify that Rob's Chrome-debug case from above works.\nIt is escaping the query parameter, but works anyway using the new loadedSources API, because then we can rely on sourceReference instead of a string path.\nI have also seen this (with the Firefox debug adapter) and couldn't find any user-visibile ill effects. In particular, the source url is displayed correctly in the tab opened from the Loaded Scripts Explorer (i.e. the query parameter is unescaped there and other escaped characters in the url remain escaped).\nAdded \"Verified\" label since both comments from above confirm that this works correctly now.\nIt does rely on me updating chrome-debug, in case anybody else tries this. I'll do that this week.", "positive_passages": [{"docid": "doc-en-vscode-229ad0ad8d208e75e6952cb084f7c912ae0835a7d6343a940848f5e11b6bd2cb", "text": "*--------------------------------------------------------------------------------------------*/ import uri from 'vs/base/common/uri'; <del> import * as paths from 'vs/base/common/paths'; </del> import { localize } from 'vs/nls'; import { TPromise } from 'vs/base/common/winjs.base'; import { guessMimeTypes, MIME_TEXT } from 'vs/base/common/mime';", "commid": "vscode_pr_23949"}], "negative_passages": []}
{"query_id": "q-en-vscode-283d65110775a09080cf52d8bb48f0b24fdeeed3528f1cf19929463ce8467b94", "query": "Chrome-debug supports .js files with query parameters (). But if I load one with \"Open loaded scripts\", the query parameter is stripped. This happens here: since fsPath doesn't include the query parameter. Any idea how to make this work? I don't think URI is expecting to have a URL with another scheme.\nThat normalize code should only be executed if the source could not be found - otherwise should not be and the should be passed to the adapter. Do you know why is that? As for the call - I am not married to it and we can change it to whatever uri massaging techinique would work for you and not break the existing behavior. If we change this I would prefer to be in debt week -april\nIt tries to get the source from , but it looks like that is only populated when it breaks in there, right? Plus it's a different format, the script from the quickopen starts with but the ones in don't.\nI don't know about replacing , would do it if that isn't too hacky.\nYes, is only populated once there is a call stack that contains that source - so if it breaks. Yeah that feels like a total hack. Why don't you experiment with different solutions and create a PR where we can comment and try out different approaches if needed?\nThis regressed from adding back the in DebugContentProvider.getTextContent. is that needed?\nAlso,\nI think opening the file by putting its url into a uri is very fragile, to say the least. I have listed some problems I've noticed while implementing a Loaded Scripts Explorer for the Firefox debug adapter in . My suggestion would be to add the ability to open files using the numerical that the debug adapter assigned to them or using the object that is used for identifying the file in the messages between VS Code and the DA. Whatever solution you adopt, keep in mind that VS Code should be able to determine that the file opened by clicking on a stackframe and the file opened by clicking in the Loaded Scripts Explorer are one and the same - otherwise setting breakpoints in a file opened through the Loaded Scripts Explorer will become problematic.\nI've addressed this issue by making sure that the flow -uri -preserves the data so that the initial and resulting objects are identical. The \"path\" attribute of the source object can contain anything, e.g. a file system path or a full URL. So if a Uri is constructed in the following way: the debugContentProvider inside VS Code will retrieve the content by sending a \"sourceRequest\" with a \"Source\" argument to the debug adapter identified by the debug session.\nVerify that Rob's Chrome-debug case from above works.\nIt is escaping the query parameter, but works anyway using the new loadedSources API, because then we can rely on sourceReference instead of a string path.\nI have also seen this (with the Firefox debug adapter) and couldn't find any user-visibile ill effects. In particular, the source url is displayed correctly in the tab opened from the Loaded Scripts Explorer (i.e. the query parameter is unescaped there and other escaped characters in the url remain escaped).\nAdded \"Verified\" label since both comments from above confirm that this works correctly now.\nIt does rely on me updating chrome-debug, in case anybody else tries this. I'll do that this week.", "positive_passages": [{"docid": "doc-en-vscode-01ea4cc64284a4b41729bd28e69965cebd893825c0f6bbd69a84ab3ab92450d9", "text": "return TPromise.wrapError(localize('unable', \"Unable to resolve the resource without a debug session\")); } const source = process.sources.get(resource.toString()); <del> const rawSource = source ? source.raw : { path: paths.normalize(resource.fsPath, true) }; </del> <ins> let rawSource: DebugProtocol.Source; if (source) { rawSource = source.raw; } else { // Remove debug: scheme rawSource = { path: resource.with({ scheme: '' }).toString(true) }; } </ins> return process.session.source({ sourceReference: source ? source.reference : undefined, source: rawSource }).then(response => { const mime = response.body.mimeType || guessMimeTypes(resource.toString())[0];", "commid": "vscode_pr_23949"}], "negative_passages": []}
{"query_id": "q-en-vscode-dcbb752dcef949bb324e6994ecb1b58fed66f30b65ddf33b8ccfe3b3b4a464f3", "query": "Variable substitutions that are available for (see ) do not include currently selected text. I am looking for something similar to $(CurText) that is available in Visual Studio Arguments for External Tools (see ). Please add a variable ${curtext} which would be replaced with the currently selected text in the editor window. If no selection is available, it could use the current line at cursor position.\nNice idea, but I think it's too late for implement that in the current milestone...\nFixed by in\nVerifiers: what happens if all text in a 300 MB file is selected...\ngood point. Maybe we should put a limit on this. Or only to copy the howl line at most (even though the line could also be 300mb I am fine with that) thoughts?\nSelecting lots of text, at some point I get . If there's a predictable limit where this will fail, we should just cut the string off there. Unless only sending part of the text could be dangerous or unexpected for the user. In any case I think that sending multiple lines of text could be useful.\nthere is not a predictable limit since the variables are used in different scenarios. If somebody has an idea for a limit I am open to PRs", "positive_passages": [{"docid": "doc-en-vscode-bfa9ec9d323eab34c983011887bcd480f31d7f7f3987c8c5592581db6b9b4a30", "text": "return ''; } <ins> private get selectedText(): string { const activeEditor = this.editorService.getActiveEditor(); if (activeEditor) { const editorControl = (<ICodeEditor>activeEditor.getControl()); if (editorControl) { const editorModel = editorControl.getModel(); const editorSelection = editorControl.getSelection(); if (editorModel && editorSelection) { return editorModel.getValueInRange(editorSelection); } } } return ''; } </ins> private getFilePath(): string { let input = this.editorService.getActiveEditorInput(); if (input instanceof DiffEditorInput) {", "commid": "vscode_pr_39483"}], "negative_passages": []}
{"query_id": "q-en-vscode-dcbb752dcef949bb324e6994ecb1b58fed66f30b65ddf33b8ccfe3b3b4a464f3", "query": "Variable substitutions that are available for (see ) do not include currently selected text. I am looking for something similar to $(CurText) that is available in Visual Studio Arguments for External Tools (see ). Please add a variable ${curtext} which would be replaced with the currently selected text in the editor window. If no selection is available, it could use the current line at cursor position.\nNice idea, but I think it's too late for implement that in the current milestone...\nFixed by in\nVerifiers: what happens if all text in a 300 MB file is selected...\ngood point. Maybe we should put a limit on this. Or only to copy the howl line at most (even though the line could also be 300mb I am fine with that) thoughts?\nSelecting lots of text, at some point I get . If there's a predictable limit where this will fail, we should just cut the string off there. Unless only sending part of the text could be dangerous or unexpected for the user. In any case I think that sending multiple lines of text could be useful.\nthere is not a predictable limit since the variables are used in different scenarios. If somebody has an idea for a limit I am open to PRs", "positive_passages": [{"docid": "doc-en-vscode-fbbdccd8bc4033e6e95bc4eb2fea3db842d3a7ceb6035d12494601a287da1626", "text": "assert.strictEqual(configurationResolverService.resolve(workspace, 'abc ${lineNumber} xyz'), `abc ${editorService.mockLineNumber} xyz`); }); <ins> test('current selected text', () => { assert.strictEqual(configurationResolverService.resolve(workspace, 'abc ${selectedText} xyz'), `abc ${editorService.mockSelectedText} xyz`); }); </ins> test('substitute many', () => { if (platform.isWindows) { assert.strictEqual(configurationResolverService.resolve(workspace, '${workspaceFolder} - ${workspaceFolder}'), 'VSCodeworkspaceLocation - VSCodeworkspaceLocation');", "commid": "vscode_pr_39483"}], "negative_passages": []}
{"query_id": "q-en-vscode-dcbb752dcef949bb324e6994ecb1b58fed66f30b65ddf33b8ccfe3b3b4a464f3", "query": "Variable substitutions that are available for (see ) do not include currently selected text. I am looking for something similar to $(CurText) that is available in Visual Studio Arguments for External Tools (see ). Please add a variable ${curtext} which would be replaced with the currently selected text in the editor window. If no selection is available, it could use the current line at cursor position.\nNice idea, but I think it's too late for implement that in the current milestone...\nFixed by in\nVerifiers: what happens if all text in a 300 MB file is selected...\ngood point. Maybe we should put a limit on this. Or only to copy the howl line at most (even though the line could also be 300mb I am fine with that) thoughts?\nSelecting lots of text, at some point I get . If there's a predictable limit where this will fail, we should just cut the string off there. Unless only sending part of the text could be dangerous or unexpected for the user. In any case I think that sending multiple lines of text could be useful.\nthere is not a predictable limit since the variables are used in different scenarios. If somebody has an idea for a limit I am open to PRs", "positive_passages": [{"docid": "doc-en-vscode-b72ebd4472fdcd84ac50c5b566760938713778d907ce1162af65e5e96f2a11ab", "text": "public activeEditorOptions: IEditorOptions; public activeEditorPosition: Position; public mockLineNumber: number; <ins> public mockSelectedText: string; </ins> private callback: (method: string) => void; constructor(callback?: (method: string) => void) { this.callback = callback || ((s: string) => { }); this.mockLineNumber = 15; <ins> this.mockSelectedText = 'selected text'; </ins> } public openEditors(inputs: any[]): Promise {", "commid": "vscode_pr_39483"}], "negative_passages": []}
{"query_id": "q-en-vscode-dcbb752dcef949bb324e6994ecb1b58fed66f30b65ddf33b8ccfe3b3b4a464f3", "query": "Variable substitutions that are available for (see ) do not include currently selected text. I am looking for something similar to $(CurText) that is available in Visual Studio Arguments for External Tools (see ). Please add a variable ${curtext} which would be replaced with the currently selected text in the editor window. If no selection is available, it could use the current line at cursor position.\nNice idea, but I think it's too late for implement that in the current milestone...\nFixed by in\nVerifiers: what happens if all text in a 300 MB file is selected...\ngood point. Maybe we should put a limit on this. Or only to copy the howl line at most (even though the line could also be 300mb I am fine with that) thoughts?\nSelecting lots of text, at some point I get . If there's a predictable limit where this will fail, we should just cut the string off there. Unless only sending part of the text could be dangerous or unexpected for the user. In any case I think that sending multiple lines of text could be useful.\nthere is not a predictable limit since the variables are used in different scenarios. If somebody has an idea for a limit I am open to PRs", "positive_passages": [{"docid": "doc-en-vscode-3ff1d64b9ee3e7a1a02c33ff8f54b0e6f3e002f3628799237a230a0bf63da909", "text": "getId: () => { return null; }, getControl: () => { return { <del> getSelection: () => { return { positionLineNumber: this.mockLineNumber }; } </del> <ins> getSelection: () => { return { positionLineNumber: this.mockLineNumber }; }, getModel: () => { return { getValueInRange: () => this.mockSelectedText }; } </ins> }; }, focus: () => { },", "commid": "vscode_pr_39483"}], "negative_passages": []}
{"query_id": "q-en-vscode-abca1b7e345251a6aa9ed8c632f901f1d4393ca7ec52c2a6c314ce707f5c5e07", "query": "Platforms Tested: Insiders 5-30 Code 1.11.1 Stable Windows 7 OS X Sierra (should be all platforms) Problem: Output panel drop-down does not track current active output if output channel is activated later , typically when an extension output Channel is active (eg Git). Output select box will show the default 0 index output (Tasks) Steps to reproduce: Open code with git repository/workspace select Git output Channel close code reopen code Git output will be active but drop-down shows Tasks Fixed with PR always update active select box selection with setOptions call on any output channel update Tested on Windows 7, OS X\nFixed via", "positive_passages": [{"docid": "doc-en-vscode-4d2a827dc3434b0f1dbb06ac32812f4e763311394d83b21349ca8ea9c56c25e2", "text": ") { super(null, action, [], 0); <del> this.toDispose.push(this.outputService.onOutputChannel(() => this.setOptions(this.getOptions(), this.getSelected(undefined)))); </del> <ins> this.toDispose.push(this.outputService.onOutputChannel(() => { const activeChannelIndex = this.getSelected(this.outputService.getActiveChannel().id); this.setOptions(this.getOptions(), activeChannelIndex); })); </ins> this.toDispose.push(this.outputService.onActiveOutputChannel(activeChannelId => this.setOptions(this.getOptions(), this.getSelected(activeChannelId)))); this.toDispose.push(attachSelectBoxStyler(this.selectBox, themeService));", "commid": "vscode_pr_27645"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6fc19b69b473140b029ba8bce157de61018372bbedce63d12c06446b34603dc", "query": "Testing Steps to Reproduce: integrated terminal and open the find widget the integrated terminal area very skinny bug The find widget starts overflowing into the explorer area: <img width=\"420\" alt=\"screen shot 2017-06-28 at 1 25 51 pm\" src=\"https://user-\"\nAfter , no more overflow but we now clip the find box: !\nI guess we want it to be tiny like in the editor: <img width=\"221\" alt=\"screen shot 2017-07-07 at 3 02 45 pm\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-d1f6dc4beb6743c592913a9e5046330f2bfda2598b3b8c90f778f38200429540", "text": "display: flex; padding: 4px; align-items: center; <ins> width: 220px; max-width: calc(100% - 28px - 28px - 8px); </ins> -webkit-transition: top 200ms linear; -o-transition: top 200ms linear;", "commid": "vscode_pr_30348"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6fc19b69b473140b029ba8bce157de61018372bbedce63d12c06446b34603dc", "query": "Testing Steps to Reproduce: integrated terminal and open the find widget the integrated terminal area very skinny bug The find widget starts overflowing into the explorer area: <img width=\"420\" alt=\"screen shot 2017-06-28 at 1 25 51 pm\" src=\"https://user-\"\nAfter , no more overflow but we now clip the find box: !\nI guess we want it to be tiny like in the editor: <img width=\"221\" alt=\"screen shot 2017-07-07 at 3 02 45 pm\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-de14a099ae1a7b3a26195af9c7c61aa6d1956f38130ce7812cb10fc0a4824da6", "text": "top: 0; } <ins> .monaco-workbench .simple-find-part .monaco-findInput { flex: 1; } </ins> /* Temporarily we don't show match numbers */ .monaco-workbench .simple-find-part .monaco-findInput .controls { display: none;", "commid": "vscode_pr_30348"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6fc19b69b473140b029ba8bce157de61018372bbedce63d12c06446b34603dc", "query": "Testing Steps to Reproduce: integrated terminal and open the find widget the integrated terminal area very skinny bug The find widget starts overflowing into the explorer area: <img width=\"420\" alt=\"screen shot 2017-06-28 at 1 25 51 pm\" src=\"https://user-\"\nAfter , no more overflow but we now clip the find box: !\nI guess we want it to be tiny like in the editor: <img width=\"221\" alt=\"screen shot 2017-07-07 at 3 02 45 pm\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-88398a87a2de4cbf4cd2ce9149329b904b26f66475a0dc449c1a6bacddaf9ebe", "text": ") { super(); this._findInput = this._register(new FindInput(null, this._contextViewService, { <del> width: 155, </del> label: NLS_FIND_INPUT_LABEL, placeholder: NLS_FIND_INPUT_\", }));", "commid": "vscode_pr_30348"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f6aa7c3a38f736a1a34910fa0568796d9a62ff793bf7d5fd71a75265c2959ee", "query": "I noticed that the terminal no sends Operating System Commands (OSC) like setting the window title. Right now the task runner filters them but this gets more and more complex and I am actually not an expert with this. So I would like to request that the terminal provides API to notify data without control sequences. Currently I used these two regular expressions to filter them:\nThere are two unknowns to me right now with this: Various control sequences can do , so where is the best place to gather this data? It might be worth seeing if adding listeners to will give what you need. How do this efficiently. Because a lot of data can stream through the terminal, we should probably only enable this when it's explicitly requested (ie. only fire the event if something is listening). It should probably also be batched. PR welcome upstream.\nFrom a problem matcher point of view it would be enough sending the line. We could sent it when a linefeed is . Then there is still the problem of a line content changing. We once discussed the idea of a line identifier to signal that. I agree that sending single characters might not be a smart idea in terms of performance.\nIf it's just on line feed then many characters could go missing, eg. \"abc\" <move cursor up a row\"def\" <linefeedwould result in \"def\" only. Maybe this is not something we care about, but it could lead to some obscure bugs if people relied on this new API.\nThis is a good example why something like a line model would be helpful: After looking into the issue it looks like that pester constantly 'repaints' the whole screen hence the terminal sending the same line onData over and over again. For me it is very hard to tell whether I have seen that line and whether I have processed it already (the same content). What would be cool if the terminal could provide a line model where is line has an id (number) and changes are signaled on that model instead of sending raw data.\nI actually an ID concept to the buffer when doing the selection stuff () but I ended up not needing it and pulling it out, instead the selection listens to when the buffer is trimmed and adjusts the indexes of its own model. It really didn't feel very good adding it as it introduced much more complexity to the already complex circular list and the overhead of an addition object for every entry - which is a lot when you need to create tens of thousands of these things in an instant. There were other issues that come up with this like IDs being interleaved due to programs having the ability to delete/insert lines so there's no way I could think of to optimize it nicely, leading to a slower, more memory hungry terminal. It would probably be easier and more performant to just deduplicate these errors on your end. For example you could record a hash for current problems and check it before adding new problems, or perhaps even better, record the raw terminal line of the error so you don't need to parse it again for duplicate problems.\nI implemented the deduplicate yesterday but it feels like a hack on my side :-) I need to create a unique key for something that doesn't necessarily have one. I still think having a line bassed model comparable to what the editor exposes would be a nice thing. Me giving the raw data is comparable to the editor signaling raw cursor moves and text changes. Instead I get a nice model with text edit events. And I am not interested in color information like I am not interested in this on an editor buffer.\nJust for the record. I can not filter on the line itself from the terminal without knowing if I have parsed that line already. Matchers are multiline aware and there could be two equal lines in one output on purpose since they difference is made by a line above. Me knowing this is implementing a line model on top of it :-)\nisn't the point of programs rewriting lines that the lines do change and that they may need to be reparsed? Here's one idea that might work for both of us: exposing some data stream you can listen to as in the original comment, but only ever pushing data if it's on the last line in the terminal. Would this cover your use case? For the PS case you would get multiple lines for the last line but maybe this could be more clever somehow in recording when the cursor moves and only reporting the line a single time (not by using IDs but by only reporting once after a call inserts a new line.\nyes, it would be cool to be able to reparse a line when it changes. As I tried to outline in this needs to have some sort of model to do it right. I can't simply decide things on the content of a line. So instead me implementing a line model on top of ANSI control sequence characters I was somehow hoping that the terminal could expose its. I my simple mind the terminal works like this: program -Output with control characters -line model -view model (does the wrapping, could do folding, ...) -DOM. I think the last line suggestion will work for parsing problems. However when exposing this as API in the extension host I think it might be a little to limited.\ncurrently there is only the line model, no view model. I did a big write up on introducing one to properly support reflowing lines here This has been a pretty long discussion across a few issues but to clarify where we are now, here are my concerns: Extra memory overhead in the buffer: I'm currently in the process of trying to push down the terminal's memory usage as I need to store more data against each character and memory usage right now is approaching unacceptable limits imo Here is a snapshot of a 160x24 terminal with 5000 scrollback filled which is not out of the ordinary, I typically have two of these running just in the window with Microsoft/vscode opened: ! Extra processing when data/lines are to the buffer: back in December I made a big effort improving the terminal's performance by attacking it in a number of ways. The main take aways from this experience was that trying to write a high performance terminal in JavaScript/DOM is very hard because processing and displaying data is so expensive. I can now safely say that is the fastest JS terminal out there by a long shot and I want us to maintain this status. A proper view model that can track lines that changes would amount to a significant amount of processing in the worst case which would be generally unnecessary for other use cases. Some possible solutions: a new event that you can listen to that fires when a line feed is to the last line, ie. only fire an event once per line and ignore lines being updated or lines being inserted. Pros: It doesn't involve storing any more data or doing anymore processing, other that pulling the string from the buffer. Cons: it probably isn't sufficient to cover all use cases. an ID to each buffer line () and fire an event when there is a line feed against a line or the cursor moves away from it (specifics here would need to be figured out). Pros: It's a more complete solution and covers more use cases. We need an addition JS object and number associated with each line, this probably doesn't add up to that much data as it's on the line rather than the char. Cons: Additional complexity within the data structure. I'm not so sure just yet when exactly we should fire these events. The IDs will be out of order in some cases which may be confusing to consumers. These events may still fire when the line did not change (eg. if the program/script erased and rewrote the line). a proper view model that throws events only when a line changes. Pros: I think this is the ideal solution from your perspective. Cons: All the cons of number 2. The amount of string comparisons needed here is out of the question in the worst case with my current thinking, unless this was disabled by default and generally did not run on a lot of data. Commentary on the solutions: doesn't look like this is sufficient for problem matchers could work, but I'm not sure it helps much with the issue in behind an option on terminal initialization is probably the best way to go, but it's also the most difficult and time consuming to implement. Work on this is blocked on the following active PRs: & , and it should be done in a way that accommodates future line reflowing\nthanks a lot for the detailed explanation. Having solution 2 will for sure make my life easier and will not make things worse on my end. Regarding option 3: I am not interested in the view model since I need lines unwrapped. The line model is what would work best for me assuming that the line model doesn't have any in there to make lines visually wrap .\noption 3 including reflow is required in order to get unwrapped lines Not sure when I'll have time to work on this, pretty swamped atm. It might be a good opportunity to collaborate if this is high priority for you?\nI will be out on vacation until 2. August. I think we need to address this sooner than later since we can't assume that problems always fit onto one line. An interims solution could be as follows: can we introduce a custom control sequence (e.g. a operating system control sequence) that describes the new lines inserted to wrap the text. I could then filter them on my end since I would be able to distinguish them from normal newline. Would this be something you can add in July then I would catchup with it for the July build ?\nI actually expect you to get the unwrapped lines currently, just wraps the lines when they are going to overflow , that's the only wrapping it knows about. On Windows though I'm not sure rows are ever marked to be wrapped (not 100% sure), at least on PowerShell. This is just how winpty works.", "positive_passages": [{"docid": "doc-en-vscode-5977c2cc7b16cb656f0dc56ad56daf19e4dba975b7423b78f2aac16facd03f44", "text": "* * @param listener The listener function which takes the processes' data stream (including * ANSI escape sequences). <ins> * * @deprecated onLineData will replace this. </ins> */ onData(listener: (data: string) => void): IDisposable; /** <ins> * Attach a listener to listen for new lines added to this terminal instance. * * @param listener The listener function which takes new line strings added to the terminal, * excluding ANSI escape sequences. The line event will fire when an LF character is added to * the terminal (ie. the line is not wrapped), note that this means taht the line data will * never fire for the last line, until the line is ended with a LF character. The lineData * string will contain the fully wrapped line, not containing any LF/CR characters. */ onLineData(listener: (lineData: string) => void): IDisposable; /** </ins> * Attach a listener that fires when the terminal's pty process exits. * * @param listener The listener function which takes the processes' exit code, an exit code of", "commid": "vscode_pr_36999"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f6aa7c3a38f736a1a34910fa0568796d9a62ff793bf7d5fd71a75265c2959ee", "query": "I noticed that the terminal no sends Operating System Commands (OSC) like setting the window title. Right now the task runner filters them but this gets more and more complex and I am actually not an expert with this. So I would like to request that the terminal provides API to notify data without control sequences. Currently I used these two regular expressions to filter them:\nThere are two unknowns to me right now with this: Various control sequences can do , so where is the best place to gather this data? It might be worth seeing if adding listeners to will give what you need. How do this efficiently. Because a lot of data can stream through the terminal, we should probably only enable this when it's explicitly requested (ie. only fire the event if something is listening). It should probably also be batched. PR welcome upstream.\nFrom a problem matcher point of view it would be enough sending the line. We could sent it when a linefeed is . Then there is still the problem of a line content changing. We once discussed the idea of a line identifier to signal that. I agree that sending single characters might not be a smart idea in terms of performance.\nIf it's just on line feed then many characters could go missing, eg. \"abc\" <move cursor up a row\"def\" <linefeedwould result in \"def\" only. Maybe this is not something we care about, but it could lead to some obscure bugs if people relied on this new API.\nThis is a good example why something like a line model would be helpful: After looking into the issue it looks like that pester constantly 'repaints' the whole screen hence the terminal sending the same line onData over and over again. For me it is very hard to tell whether I have seen that line and whether I have processed it already (the same content). What would be cool if the terminal could provide a line model where is line has an id (number) and changes are signaled on that model instead of sending raw data.\nI actually an ID concept to the buffer when doing the selection stuff () but I ended up not needing it and pulling it out, instead the selection listens to when the buffer is trimmed and adjusts the indexes of its own model. It really didn't feel very good adding it as it introduced much more complexity to the already complex circular list and the overhead of an addition object for every entry - which is a lot when you need to create tens of thousands of these things in an instant. There were other issues that come up with this like IDs being interleaved due to programs having the ability to delete/insert lines so there's no way I could think of to optimize it nicely, leading to a slower, more memory hungry terminal. It would probably be easier and more performant to just deduplicate these errors on your end. For example you could record a hash for current problems and check it before adding new problems, or perhaps even better, record the raw terminal line of the error so you don't need to parse it again for duplicate problems.\nI implemented the deduplicate yesterday but it feels like a hack on my side :-) I need to create a unique key for something that doesn't necessarily have one. I still think having a line bassed model comparable to what the editor exposes would be a nice thing. Me giving the raw data is comparable to the editor signaling raw cursor moves and text changes. Instead I get a nice model with text edit events. And I am not interested in color information like I am not interested in this on an editor buffer.\nJust for the record. I can not filter on the line itself from the terminal without knowing if I have parsed that line already. Matchers are multiline aware and there could be two equal lines in one output on purpose since they difference is made by a line above. Me knowing this is implementing a line model on top of it :-)\nisn't the point of programs rewriting lines that the lines do change and that they may need to be reparsed? Here's one idea that might work for both of us: exposing some data stream you can listen to as in the original comment, but only ever pushing data if it's on the last line in the terminal. Would this cover your use case? For the PS case you would get multiple lines for the last line but maybe this could be more clever somehow in recording when the cursor moves and only reporting the line a single time (not by using IDs but by only reporting once after a call inserts a new line.\nyes, it would be cool to be able to reparse a line when it changes. As I tried to outline in this needs to have some sort of model to do it right. I can't simply decide things on the content of a line. So instead me implementing a line model on top of ANSI control sequence characters I was somehow hoping that the terminal could expose its. I my simple mind the terminal works like this: program -Output with control characters -line model -view model (does the wrapping, could do folding, ...) -DOM. I think the last line suggestion will work for parsing problems. However when exposing this as API in the extension host I think it might be a little to limited.\ncurrently there is only the line model, no view model. I did a big write up on introducing one to properly support reflowing lines here This has been a pretty long discussion across a few issues but to clarify where we are now, here are my concerns: Extra memory overhead in the buffer: I'm currently in the process of trying to push down the terminal's memory usage as I need to store more data against each character and memory usage right now is approaching unacceptable limits imo Here is a snapshot of a 160x24 terminal with 5000 scrollback filled which is not out of the ordinary, I typically have two of these running just in the window with Microsoft/vscode opened: ! Extra processing when data/lines are to the buffer: back in December I made a big effort improving the terminal's performance by attacking it in a number of ways. The main take aways from this experience was that trying to write a high performance terminal in JavaScript/DOM is very hard because processing and displaying data is so expensive. I can now safely say that is the fastest JS terminal out there by a long shot and I want us to maintain this status. A proper view model that can track lines that changes would amount to a significant amount of processing in the worst case which would be generally unnecessary for other use cases. Some possible solutions: a new event that you can listen to that fires when a line feed is to the last line, ie. only fire an event once per line and ignore lines being updated or lines being inserted. Pros: It doesn't involve storing any more data or doing anymore processing, other that pulling the string from the buffer. Cons: it probably isn't sufficient to cover all use cases. an ID to each buffer line () and fire an event when there is a line feed against a line or the cursor moves away from it (specifics here would need to be figured out). Pros: It's a more complete solution and covers more use cases. We need an addition JS object and number associated with each line, this probably doesn't add up to that much data as it's on the line rather than the char. Cons: Additional complexity within the data structure. I'm not so sure just yet when exactly we should fire these events. The IDs will be out of order in some cases which may be confusing to consumers. These events may still fire when the line did not change (eg. if the program/script erased and rewrote the line). a proper view model that throws events only when a line changes. Pros: I think this is the ideal solution from your perspective. Cons: All the cons of number 2. The amount of string comparisons needed here is out of the question in the worst case with my current thinking, unless this was disabled by default and generally did not run on a lot of data. Commentary on the solutions: doesn't look like this is sufficient for problem matchers could work, but I'm not sure it helps much with the issue in behind an option on terminal initialization is probably the best way to go, but it's also the most difficult and time consuming to implement. Work on this is blocked on the following active PRs: & , and it should be done in a way that accommodates future line reflowing\nthanks a lot for the detailed explanation. Having solution 2 will for sure make my life easier and will not make things worse on my end. Regarding option 3: I am not interested in the view model since I need lines unwrapped. The line model is what would work best for me assuming that the line model doesn't have any in there to make lines visually wrap .\noption 3 including reflow is required in order to get unwrapped lines Not sure when I'll have time to work on this, pretty swamped atm. It might be a good opportunity to collaborate if this is high priority for you?\nI will be out on vacation until 2. August. I think we need to address this sooner than later since we can't assume that problems always fit onto one line. An interims solution could be as follows: can we introduce a custom control sequence (e.g. a operating system control sequence) that describes the new lines inserted to wrap the text. I could then filter them on my end since I would be able to distinguish them from normal newline. Would this be something you can add in July then I would catchup with it for the July build ?\nI actually expect you to get the unwrapped lines currently, just wraps the lines when they are going to overflow , that's the only wrapping it knows about. On Windows though I'm not sure rows are ever marked to be wrapped (not 100% sure), at least on PowerShell. This is just how winpty works.", "positive_passages": [{"docid": "doc-en-vscode-c57c1f2a52c12dc5f88060a420f0967618f112ae7e2150737921db4d4f33ca8c", "text": "}; } <ins> public onLineData(listener: (lineData: string) => void): lifecycle.IDisposable { if (!this._xterm) { throw new Error('xterm must be initialized'); } const lineFeedListener = () => { const buffer = (<any>this._xterm.buffer); const newLine = buffer.lines.get(buffer.ybase + buffer.y); if (!newLine.isWrapped) { let i = buffer.ybase + buffer.y - 1; let lineData = buffer.translateBufferLineToString(i, true); while (i >= 0 && buffer.lines.get(i--).isWrapped) { lineData = buffer.translateBufferLineToString(i, true) + lineData; } listener(lineData); } }; this._xterm.on('lineFeed', lineFeedListener); return { dispose: () => { if (this._xterm) { this._xterm.off('lineFeed', lineFeedListener); } } }; } </ins> public onExit(listener: (exitCode: number) => void): lifecycle.IDisposable { if (this._process) { this._process.on('exit', listener);", "commid": "vscode_pr_36999"}], "negative_passages": []}
{"query_id": "q-en-vscode-2863ea5b18199b7351b1de33b471f5bcceda4e5ca2caaf5ec9fe04157dba9342", "query": "Would be great to see a tooltip on links, showing the target. Or popping it up in the status bar or elsewhere, like Chrome.\n: Could you please explain the preview functionality bit more with screenshots of Chrome? I am new to open source community and this project. I use vscode often and would love to work on this if someone can guide me a little.\nLower left corner of the Chrome window when I hover the link to your name: ! But I think a normal tooltip would be easier.\nAh yes. I understand what you are talking about now. To verify, where the link is leading to. Seems like a beginner friendly feature. I can pick it up this weekend if anyone can nudge me towards the right direction. :)\nSorry for the delayed response. It seems that tooltips are only shown if the element has a attribute, but not for links that only have a . I wasn't able to find if there is an electron setting to enable tooltips for links without . I think we may have to implement this ourselves. To get started, take a look at this PR that a similar feature to another electron app: Here's where our webview code lives: I believe you should be able to attach a handler to the webview handler. Please let me know if you have any questions about the code or want to discuss potential designs\nI m happy to receive help! :) I was facing issues while trying to build and fiddle around with the source code. Will definitely look into this PR and the code you pointed out this weekend. Thanks for taking your time to post this info. I ll post any questions or designs which I have.\nHi , I will create a PR to add attribute to every .\nFor verification: this was implemented as tooltip when you hover over links in a webview", "positive_passages": [{"docid": "doc-en-vscode-6d023fd56ee44dfd1d266c7d888b01543028949a7d4589e4cc94b0792235e3f2", "text": "const text = data.contents.join('n'); const newDocument = new DOMParser().parseFromString(text, 'text/html'); <ins> newDocument.querySelectorAll('a').forEach(a => { if (!a.title) { a.title = a.href; } }); </ins> // set base-url if applicable if (initData.baseUrl && newDocument.head.getElementsByTagName('base').length === 0) { const baseElement = newDocument.createElement('base');", "commid": "vscode_pr_40572"}], "negative_passages": []}
{"query_id": "q-en-vscode-65b1961dbb461729afd8f7d9690c50a869984ddb402dbd471f5e3aec41d67cce", "query": "<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: latest OS Version: Win10 A little bit more space between last line from terminal and the blue line below would be nice !\nI 1px border on the bottom would be fine, opening to PRs. Who ever wants to pick this up, you need to make sure the size of the terminal is calculated correctly given the new margin. Relevant files: , .\nI'll pick this up. pretty much all of the other terminal issues are already taken, or out of my realm. just let me know somebody's not already working on this ;-)\nsounds good\nPR posted", "positive_passages": [{"docid": "doc-en-vscode-6a6b05e93cb4615ee07b8aababf2f7124abebc69929d17e505f16ae8ba8a82a7", "text": "position: absolute; bottom: 0; top: 0; <ins> padding-bottom: 2px; </ins> } .monaco-workbench .panel.integrated-terminal .xterm a:not(.xterm-invalid-link) {", "commid": "vscode_pr_30728"}], "negative_passages": []}
{"query_id": "q-en-vscode-65b1961dbb461729afd8f7d9690c50a869984ddb402dbd471f5e3aec41d67cce", "query": "<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issues to prefill these. --- VSCode Version: latest OS Version: Win10 A little bit more space between last line from terminal and the blue line below would be nice !\nI 1px border on the bottom would be fine, opening to PRs. Who ever wants to pick this up, you need to make sure the size of the terminal is calculated correctly given the new margin. Relevant files: , .\nI'll pick this up. pretty much all of the other terminal issues are already taken, or out of my realm. just let me know somebody's not already working on this ;-)\nsounds good\nPR posted", "positive_passages": [{"docid": "doc-en-vscode-6e4b1b58badb25473113a68f5aec7f64cc7e5cb49aead337a4b9dec3524de015", "text": "} const padding = parseInt(getComputedStyle(document.querySelector('.terminal-outer-container')).paddingLeft.split('px')[0], 10); <ins> const paddingBottom = parseInt(getComputedStyle(document.querySelector('.terminal-wrapper.active')).paddingBottom.split('px')[0], 10); </ins> // Use left padding as right padding, right padding is not defined in CSS just in case // xterm.js causes an unexpected overflow. const innerWidth = width - padding * 2; <del> TerminalInstance._lastKnownDimensions = new Dimension(innerWidth, height); </del> <ins> const innerHeight = height - paddingBottom; TerminalInstance._lastKnownDimensions = new Dimension(innerWidth, innerHeight); </ins> return TerminalInstance._lastKnownDimensions; }", "commid": "vscode_pr_30728"}], "negative_passages": []}
{"query_id": "q-en-vscode-e5f62ff3ed6ffcf657fa342f47cd1adfaf4ff9f2f6c62648651beb34b6d8ef35", "query": "FYI I commented out the test. Please fix it and enable it.\nThe test is failing because the DOM is no longer filled with nodes so these tests can't work the way they did previously. Is it possible with Spectron to pull a DOM node object, including any custom properties it has? If so I could attach a reference to the object to the terminal element which would allow querying the terminal for this sort of information really easily.\nYes, you can access the DOM in Spectron and we do it in multiple places. For example refer to . This will allow you to execute java script code on the renderer process that has access to DOM and let you return the model you want. But please be aware that, Since it runs in a different process than the test process, console log does not work.\nPR with fix is out , will merge in after release is branched off.", "positive_passages": [{"docid": "doc-en-vscode-15c52aab163d8e76fc62dd0896d507c8b78bcf004e95fc5cf136e38d1bfe8e84", "text": "dom.addClass(this._wrapperElement, 'terminal-wrapper'); this._xtermElement = document.createElement('div'); <ins> // Attach the xterm object to the DOM, exposing it to the smoke tests (<any>this._wrapperElement).xterm = this._xterm; </ins> this._xterm.open(this._xtermElement); this._xterm.attachCustomKeyEventHandler((event: KeyboardEvent) => { // Disable all input if the terminal is exiting", "commid": "vscode_pr_35381"}], "negative_passages": []}
{"query_id": "q-en-vscode-e5f62ff3ed6ffcf657fa342f47cd1adfaf4ff9f2f6c62648651beb34b6d8ef35", "query": "FYI I commented out the test. Please fix it and enable it.\nThe test is failing because the DOM is no longer filled with nodes so these tests can't work the way they did previously. Is it possible with Spectron to pull a DOM node object, including any custom properties it has? If so I could attach a reference to the object to the terminal element which would allow querying the terminal for this sort of information really easily.\nYes, you can access the DOM in Spectron and we do it in multiple places. For example refer to . This will allow you to execute java script code on the renderer process that has access to DOM and let you return the model you want. But please be aware that, Since it runs in a different process than the test process, console log does not work.\nPR with fix is out , will merge in after release is branched off.", "positive_passages": [{"docid": "doc-en-vscode-4b694bae90d96ba4bc4575f9d9adb124e98b0274c1c08a61b4a68202e55dd56d", "text": "import { SpectronApplication } from '../../spectron/application'; <del> export class Terminal { static TERMINAL_SELECTOR = '.panel.integrated-terminal'; static TERMINAL_ROWS_SELECTOR = `${Terminal.TERMINAL_SELECTOR} .xterm-rows > div`; static TERMINAL_CURSOR = `${Terminal.TERMINAL_SELECTOR} .terminal-cursor`; </del> <ins> const PANEL_SELECTOR = 'div[id=\"workbench.panel.terminal\"]'; const XTERM_SELECTOR = `${PANEL_SELECTOR} .terminal-wrapper`; export class Terminal { </ins> constructor(private spectron: SpectronApplication) { } public async showTerminal(): Promise<void> { if (!await this.isVisible()) { await this.spectron.workbench.quickopen.runCommand('View: Toggle Integrated Terminal'); <del> await this.spectron.client.waitForElement(Terminal.TERMINAL_CURSOR); </del> <ins> await this.spectron.client.waitForElement(XTERM_SELECTOR); </ins> await this.waitForTerminalText(text => text.length > 0, 'Waiting for Terminal to be ready'); } } public async isVisible(): Promise<boolean> { <del> const element = await this.spectron.client.element(Terminal.TERMINAL_SELECTOR); </del> <ins> const element = await this.spectron.client.element(PANEL_SELECTOR); </ins> return !!element; }", "commid": "vscode_pr_35381"}], "negative_passages": []}
{"query_id": "q-en-vscode-e5f62ff3ed6ffcf657fa342f47cd1adfaf4ff9f2f6c62648651beb34b6d8ef35", "query": "FYI I commented out the test. Please fix it and enable it.\nThe test is failing because the DOM is no longer filled with nodes so these tests can't work the way they did previously. Is it possible with Spectron to pull a DOM node object, including any custom properties it has? If so I could attach a reference to the object to the terminal element which would allow querying the terminal for this sort of information really easily.\nYes, you can access the DOM in Spectron and we do it in multiple places. For example refer to . This will allow you to execute java script code on the renderer process that has access to DOM and let you return the model you want. But please be aware that, Since it runs in a different process than the test process, console log does not work.\nPR with fix is out , will merge in after release is branched off.", "positive_passages": [{"docid": "doc-en-vscode-1b6f1bab9159ce50873bab80b6ec83905b62dae0d572344b4c96c68fbcde4290", "text": "} private async getTerminalText(): Promise<string[]> { <del> const linesText: string[] = await this.spectron.webclient.selectorExecute<string[]>(Terminal.TERMINAL_ROWS_SELECTOR, div => (Array.isArray(div) ? div : [div]) .map(element => { function getTextFromAll(spanElements: NodeList): string { let text = ''; for (let i = 0; i < spanElements.length; i++) { text += getText(spanElements.item(i) as HTMLElement); } return text; } function getText(spanElement: HTMLElement): string { if (spanElement.hasChildNodes()) { return getTextFromAll(spanElement.childNodes); } return spanElement.textContent || ''; } return getTextFromAll(element.querySelectorAll('span')); })); let lastLineIndex = 0; for (let index = 0; index < linesText.length; index++) { if (linesText[index].trim()) { lastLineIndex = index; </del> <ins> return await this.spectron.webclient.selectorExecute(XTERM_SELECTOR, div => { const xterm = (<any>(Array.isArray(div) ? div[0] : div)).xterm; const buffer = xterm.buffer; const lines: string[] = []; for (let i = 0; i < buffer.lines.length; i++) { lines.push(buffer.translateBufferLineToString(i, true)); } return lines; </ins> } <del> } return linesText.slice(0, lastLineIndex + 1); </del> <ins> ); </ins> } }  No newline at end of file", "commid": "vscode_pr_35381"}], "negative_passages": []}
{"query_id": "q-en-vscode-ad748d2c7885aae18593096248671fa2ea86757587487ef00e465f9d7c6413ad", "query": "I admit that it's a niche scenario, but I think that what \"Open Changes\" shows for not-yet-staged changes to files that have been detected as renamed in the index is incorrect, at least inconsistent with how changes to files in the index are shown that have not been renamed. Steps to Reproduce: an empty directory and initialize a git repository in it. that directory create two files and with identical content: This exact content is somewhat important, as I've confirmed that it triggers git's \"rename detection\" (checked with git v2.14.1). and commit both files. the first line in both files. to . \"\": ! does the right thing for both files, that is, it shows the changes between HEAD and the staged version: : ! : ! the first line in both files once more, but don't stage these changes. still shows the right thing for (in this case the changes between the staged version and the file in the working tree): ! As the content of both files is identical both in the index and the working tree, I would have expected the exact same result for , but now the left side is just empty instead of showing the staged version: ! VSCode Version: Code 1.16.1 (, 2017-09-14T16:26:20.018Z) OS Version: Linux x64 4.12.13-1-ARCH\nHehe great catch! Would you like to to it?\nSo is this issue still open and up for grabs? If so I would like to try to help\nJust look above your comment, there's a PR for it already:\nFixed by", "positive_passages": [{"docid": "doc-en-vscode-90765122f038c83be65ba2eedebf7733f14d65c08bfef1df52ee1dbc4bb78646", "text": "if (ref === '~') { const fileUri = Uri.file(path); const uriString = fileUri.toString(); <del> const [indexStatus] = repository.indexGroup.resourceStates.filter(r => r.original.toString() === uriString); </del> <ins> const [indexStatus] = repository.indexGroup.resourceStates.filter(r => r.resourceUri.toString() === uriString); </ins> ref = indexStatus ? '' : 'HEAD'; }", "commid": "vscode_pr_34690"}], "negative_passages": []}
{"query_id": "q-en-vscode-0f81fc2192f5ef8056a6be34f7a9e51e96ea361a92368717e5c9b1a67637f18f", "query": "a .ts file tab to activate the \"import statement\" snippet Expected and actual: completes to a .tsx file (TypeScript + JSX) tab to activate the \"import statement\" snippet Actual: completes to Expected: completes to Is there any reason why the snippet is inconsistent between .ts and .tsx files?\nYes this is unintentional. I've marked this as help wanted in case anyone want to take a look. Here are the relevant snippet files:\nThanks! See I was also thinking it would be useful to add this to .js and .jsx extensions. What do you think?\nThanks for the PR! The change should be in the next insiders build Yes I think adding the same for js/jsx also make sense. Did you want to submit another PR that copies these snippets over to js/jsx?", "positive_passages": [{"docid": "doc-en-vscode-0edba7bd76637e4fc3d73ba9ef93e54a282f0d8e9287efb0872b5eaaa9cb7789", "text": "\"Import external module.\": { \"prefix\": \"import statement\", \"body\": [ <del> \"import ${1:name} = require('$0');\" </del> <ins> \"import { $0 } from \"${1:module}\";\" </ins> ], \"description\": \"Import external module.\" },", "commid": "vscode_pr_34653"}], "negative_passages": []}
{"query_id": "q-en-vscode-57a9f64b254c68b9266597db911bac4b1697c673092e4bbf998b5ecf83ca22b5", "query": "VSCode Version: Code 1.15.1 (, 2017-08-16T18:07:25.676Z) OS Version: WindowsNT x64 10.0. Extensions: ExtensionVersion ------ overtype0.2.0 python0.7.0 theme-dark-plus-contrast0.1.101 cpptools0.13.0 monitor-file1.0.1 (4 theme extensions excluded) Steps to Reproduce: there is such line in a *.bat file rem set SERVERVERSION=5.7 cursor on it, and uncomment with \"Ctrl+/\" expected: set SERVERVERSION=5.7 actual result: REM rem set SERVERVERSION=5.7 Looks like uncomment is unnecessarily case-sensitive. It should uncomment despite it is 'rem' or 'REM'. I don't care whether with next \"Ctrl+/\" it will add Upper-Case 'REM' instead of 'rem' - it is not problem. <!-- Launch with to check. --Reproduces without extensions: Yes/No", "positive_passages": [{"docid": "doc-en-vscode-62ff40c91334a9ae1b62b6aef7d08644d4dd5cd087d51b1b06f1645db94295ef", "text": "if (offset + needleLength > haystackLength) { return false; } <ins> const haystackUpper = haystack.toUpperCase(); const needleUpper = needle.toUpperCase(); </ins> for (let i = 0; i < needleLength; i++) { <del> if (haystack.charCodeAt(offset + i) !== needle.charCodeAt(i)) { </del> <ins> if (haystackUpper.charCodeAt(offset + i) !== needleUpper.charCodeAt(i)) { </ins> return false; } }", "commid": "vscode_pr_44998"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f700d054040da68f93ea70aad931eb058224e384f8fc1cd983f31a324a5400f", "query": "VSCode Version: Code 1.17.0 (, 2017-10-05T06:07:51.906Z) OS Version: Darwin x64 16.7.0 Extensions: ExtensionVersion ------ vscode-markdownlint0.10.1 xml1.9.2 code-settings-sync2.8.3 sonarlint-vscode1.1.0 html-snippets0.1.0 Bookmarks0.16.0 markdown-preview-github-styles0.0.4 path-intellisense1.4.2 gitignore0.5.0 vscode-eslint1.3.2 githistory0.2.3 jquerysnippets0.0.1 tslint1.0.9 auto-rename-tag0.0.14 Angular22.7.0 HTMLHint0.4.0 cpptools0.13.1 csharp1.12.1 indent-rainbow0.7.2 tsimporter1.2.14 java0.11.0 vscode-open0.1.0 stylelint0.29.1 code-spell-checker1.4.7 code-spell-checker-spanish1.0.1 bootstrap-3-snippets0.1.0 JavaScriptSnippets1.5.0 Steps to Reproduce: new CSS file to add -bdrd with vendor-prefixed as mention in emmet documentation adding a hyphen before. But not show any suggestion or auto-complation list. Expected result: Emmet Documentation: I'm not see in his documentation if there is a way or option to enable this behaviour: <!-- Launch with to check. --Reproduces without extensions: Yes\nYou are right, expanding the abbreviations so that all vendor prefixes are included is not supported in Emmet 2.0 Have you used the command? We could just overload that command to add missing vendor prefixes or have a new command to do the same.\nI'm not using it, but I think is better add it to a new command.\nNote to verifier: The vendor prefixes should be attached as documented in when using the command.", "positive_passages": [{"docid": "doc-en-vscode-2cf9ce1743d5095d49cfceee43559f025644efafb2a0afbdf5611e8c1d7ba4f9", "text": "}, \"css.webkitProperties\": { \"type\": \"string\", <del> \"default\": \"\", </del> <ins> \"default\": \"animation, animation-delay, animation-direction, animation-duration, animation-fill-mode, animation-iteration-count, animation-name, animation-play-state, animation-timing-function, appearance, backface-visibility, background-clip, background-composite, background-origin, background-size, border-fit, border-horizontal-spacing, border-image, border-vertical-spacing, box-align, box-direction, box-flex, box-flex-group, box-lines, box-ordinal-group, box-orient, box-pack, box-reflect, box-shadow, color-correction, column-break-after, column-break-before, column-break-inside, column-count, column-gap, column-rule-color, column-rule-style, column-rule-width, column-span, column-width, dashboard-region, font-smoothing, highlight, hyphenate-character, hyphenate-limit-after, hyphenate-limit-before, hyphens, line-box-contain, line-break, line-clamp, locale, margin-before-collapse, margin-after-collapse, marquee-direction, marquee-increment, marquee-repetition, marquee-style, mask-attachment, mask-box-image, mask-box-image-outset, mask-box-image-repeat, mask-box-image-slice, mask-box-image-source, mask-box-image-width, mask-clip, mask-composite, mask-image, mask-origin, mask-position, mask-repeat, mask-size, nbsp-mode, perspective, perspective-origin, rtl-ordering, text-combine, text-decorations-in-effect, text-emphasis-color, text-emphasis-position, text-emphasis-style, text-fill-color, text-orientation, text-security, text-stroke-color, text-stroke-width, transform, transition, transform-origin, transform-style, transition-delay, transition-duration, transition-property, transition-timing-function, user-drag, user-modify, user-select, writing-mode, svg-shadow, box-sizing, border-radius\", </ins> \"description\": \"%emmetPreferencesCssWebkitProperties%\" }, \"css.mozProperties\": { \"type\": \"string\", <del> \"default\": \"\", </del> <ins> \"default\": \"animation-delay, animation-direction, animation-duration, animation-fill-mode, animation-iteration-count, animation-name, animation-play-state, animation-timing-function, appearance, backface-visibility, background-inline-policy, binding, border-bottom-colors, border-image, border-left-colors, border-right-colors, border-top-colors, box-align, box-direction, box-flex, box-ordinal-group, box-orient, box-pack, box-shadow, box-sizing, column-count, column-gap, column-rule-color, column-rule-style, column-rule-width, column-width, float-edge, font-feature-settings, font-language-override, force-broken-image-icon, hyphens, image-region, orient, outline-radius-bottomleft, outline-radius-bottomright, outline-radius-topleft, outline-radius-topright, perspective, perspective-origin, stack-sizing, tab-size, text-blink, text-decoration-color, text-decoration-line, text-decoration-style, text-size-adjust, transform, transform-origin, transform-style, transition, transition-delay, transition-duration, transition-property, transition-timing-function, user-focus, user-input, user-modify, user-select, window-shadow, background-clip, border-radius\", </ins> \"description\": \"%emmetPreferencesCssMozProperties%\" }, \"css.oProperties\": { \"type\": \"string\", <del> \"default\": \"\", </del> <ins> \"default\": \"dashboard-region, animation, animation-delay, animation-direction, animation-duration, animation-fill-mode, animation-iteration-count, animation-name, animation-play-state, animation-timing-function, border-image, link, link-source, object-fit, object-position, tab-size, table-baseline, transform, transform-origin, transition, transition-delay, transition-duration, transition-property, transition-timing-function, accesskey, input-format, input-required, marquee-dir, marquee-loop, marquee-speed, marquee-style\", </ins> \"description\": \"%emmetPreferencesCssOProperties%\" }, \"css.msProperties\": { \"type\": \"string\", <del> \"default\": \"\", </del> <ins> \"default\": \"accelerator, backface-visibility, background-position-x, background-position-y, behavior, block-progression, box-align, box-direction, box-flex, box-line-progression, box-lines, box-ordinal-group, box-orient, box-pack, content-zoom-boundary, content-zoom-boundary-max, content-zoom-boundary-min, content-zoom-chaining, content-zoom-snap, content-zoom-snap-points, content-zoom-snap-type, content-zooming, filter, flow-from, flow-into, font-feature-settings, grid-column, grid-column-align, grid-column-span, grid-columns, grid-layer, grid-row, grid-row-align, grid-row-span, grid-rows, high-contrast-adjust, hyphenate-limit-chars, hyphenate-limit-lines, hyphenate-limit-zone, hyphens, ime-mode, interpolation-mode, layout-flow, layout-grid, layout-grid-char, layout-grid-line, layout-grid-mode, layout-grid-type, line-break, overflow-style, perspective, perspective-origin, perspective-origin-x, perspective-origin-y, scroll-boundary, scroll-boundary-bottom, scroll-boundary-left, scroll-boundary-right, scroll-boundary-top, scroll-chaining, scroll-rails, scroll-snap-points-x, scroll-snap-points-y, scroll-snap-type, scroll-snap-x, scroll-snap-y, scrollbar-arrow-color, scrollbar-base-color, scrollbar-darkshadow-color, scrollbar-face-color, scrollbar-highlight-color, scrollbar-shadow-color, scrollbar-track-color, text-align-last, text-autospace, text-justify, text-kashida-space, text-overflow, text-size-adjust, text-underline-position, touch-action, transform, transform-origin, transform-origin-x, transform-origin-y, transform-origin-z, transform-style, transition, transition-delay, transition-duration, transition-property, transition-timing-function, user-select, word-break, wrap-flow, wrap-margin, wrap-through, writing-mode\", </ins> \"description\": \"%emmetPreferencesCssMsProperties%\" } }", "commid": "vscode_pr_42385"}], "negative_passages": []}
{"query_id": "q-en-vscode-6d0e3209813ec3ef92f7cc426dfd5c4f95758c31ad2b924c4602f424a3b0b0d3", "query": "VSCode Version: Code - Insiders 1.19.0-insider (, 2017-12-01T06:07:42.474Z) OS Version: Darwin x64 16.5.0 Extensions: ExtensionVersion ------ beautify1.1.1 vscode-caniuse0.5.0 jshint0.10.15 tslint1.0.24 php-debug1.12.1 php-intellisense2.0.4 php-pack1.0.1 plantuml2.3.3 vscode-duplicate1.2.0 sublime-keybindings3.0.3 debugger-for-chrome3.5.0 laravel-blade1.10.0 Steps to Reproduce: a HTML file with references to javascript files over the path of the JS file in any <scripttag 'll get the tooltip \"Alt + click to follow link\" Well, there isn't an Alt key in my MacOS keyboard (stock Apple keyboard). So saying \"Option + click to follow link\" will make more sense for Mac users. Not a big deal though. Thought I'll just point out. :) <!-- Launch with to check. --Reproduces without extensions: Yes/No", "positive_passages": [{"docid": "doc-en-vscode-838f421d06a09380b7ef00a1bfa9d870de7ed1cd80b9d81b885da8c136240e75", "text": ": nls.localize('links.command', \"Ctrl + click to execute command\") ); <del> const HOVER_MESSAGE_GENERAL_ALT = new MarkdownString().appendText(nls.localize('links.navigate.al', \"Alt + click to follow link\")); const HOVER_MESSAGE_COMMAND_ALT = new MarkdownString().appendText(nls.localize('links.command.al', \"Alt + click to execute command\")); </del> <ins> const HOVER_MESSAGE_GENERAL_ALT = new MarkdownString().appendText( platform.isMacintosh ? nls.localize('links.navigate.al.mac', \"Option + click to follow link\") : nls.localize('links.navigate.al', \"Alt + click to follow link\") ); const HOVER_MESSAGE_COMMAND_ALT = new MarkdownString().appendText( platform.isMacintosh ? nls.localize('links.command.al.mac', \"Option + click to execute command\") : nls.localize('links.command.al', \"Alt + click to execute command\") ); </ins> const decoration = { meta: ModelDecorationOptions.register({", "commid": "vscode_pr_44885"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-abaa047ebc3a15540c519d2b2e0609c343e35bc609e3fb84b3cb31faee08b34f", "text": "const position = this.validatePosition(_position); const lineContent = this.getLineContent(position.lineNumber); const lineTokens = this._getLineTokens(position.lineNumber); <del> const offset = position.column - 1; const tokenIndex = lineTokens.findTokenIndexAtOffset(offset); </del> <ins> const tokenIndex = lineTokens.findTokenIndexAtOffset(position.column - 1); // (1). First try checking right biased word const [rbStartOffset, rbEndOffset] = TextModel._findLanguageBoundaries(lineTokens, tokenIndex); const rightBiasedWord = getWordAtText( position.column, LanguageConfigurationRegistry.getWordDefinition(lineTokens.getLanguageId(tokenIndex)), lineContent.substring(rbStartOffset, rbEndOffset), rbStartOffset ); if (rightBiasedWord) { return rightBiasedWord; } // (2). Else, if we were at a language boundary, check the left biased word if (tokenIndex > 0 && rbStartOffset === position.column - 1) { // edge case, where `position` sits between two tokens belonging to two different languages const [lbStartOffset, lbEndOffset] = TextModel._findLanguageBoundaries(lineTokens, tokenIndex - 1); const leftBiasedWord = getWordAtText( position.column, LanguageConfigurationRegistry.getWordDefinition(lineTokens.getLanguageId(tokenIndex - 1)), lineContent.substring(lbStartOffset, lbEndOffset), lbStartOffset ); if (leftBiasedWord) { return leftBiasedWord; } } return null; } private static _findLanguageBoundaries(lineTokens: LineTokens, tokenIndex: number): [number, number] { </ins> const languageId = lineTokens.getLanguageId(tokenIndex); // go left until a different language is hit", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-badca6e4a5643c150668e546ec9080be3204aff31181686e7ccb790bad30a768", "text": "endOffset = lineTokens.getEndOffset(i); } <del> return getWordAtText( position.column, LanguageConfigurationRegistry.getWordDefinition(languageId), lineContent.substring(startOffset, endOffset), startOffset ); </del> <ins> return [startOffset, endOffset]; </ins> } public getWordUntilPosition(position: IPosition): model.IWordAtPosition {", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-de48735072bc58b7295e2d582cf9fafbedb25f0626d7bff98695584b2c914137", "text": "} const pos = editor.getPosition(); model.tokenizeIfCheap(pos.lineNumber); const word = model.getWordAtPosition(pos); if (!word) { return false;", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-b2326884104213705ecedba9f0514123fcaafc3dee5f4cb162e81b726dcf0e0d", "text": "import * as assert from 'assert'; import { Event } from 'vs/base/common/event'; import URI from 'vs/base/common/uri'; <del> import { IDisposable, dispose } from 'vs/base/common/lifecycle'; </del> <ins> import { IDisposable, dispose, Disposable } from 'vs/base/common/lifecycle'; </ins> import { TextModel } from 'vs/editor/common/model/textModel'; import { Handler } from 'vs/editor/common/editorCommon'; <del> import { ISuggestSupport, ISuggestResult, SuggestRegistry, SuggestTriggerKind } from 'vs/editor/common/modes'; </del> <ins> import { ISuggestSupport, ISuggestResult, SuggestRegistry, SuggestTriggerKind, LanguageIdentifier, TokenizationRegistry, IState, MetadataConsts } from 'vs/editor/common/modes'; </ins> import { SuggestModel, LineContext } from 'vs/editor/contrib/suggest/suggestModel'; import { TestCodeEditor, MockScopeLocation } from 'vs/editor/test/browser/testCodeEditor'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection';", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-8ba76b3c94dceed37ba7a8e6e2995c648686452fe30cff26bf658bc1f89fba42", "text": "import { IStorageService, NullStorageService } from 'vs/platform/storage/common/storage'; import { SnippetController2 } from 'vs/editor/contrib/snippet/snippetController2'; import { ISelectedSuggestion } from 'vs/editor/contrib/suggest/suggestWidget'; <ins> import { MockMode } from 'vs/editor/test/common/mocks/mockMode'; import { LanguageConfigurationRegistry } from 'vs/editor/common/modes/languageConfigurationRegistry'; import { TokenizationResult2 } from 'vs/editor/common/core/token'; import { NULL_STATE } from 'vs/editor/common/modes/nullMode'; </ins> function createMockEditor(model: TextModel): TestCodeEditor { const contextKeyService = new MockContextKeyService();", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-c11c7883e95eae3228317b384d37c44d25c83ae7635c61d11d5201ec8034d13e", "text": "} suite('SuggestModel - Context', function () { <ins> const OUTER_LANGUAGE_ID = new LanguageIdentifier('outerMode', 3); const INNER_LANGUAGE_ID = new LanguageIdentifier('innerMode', 4); class OuterMode extends MockMode { constructor() { super(OUTER_LANGUAGE_ID); this._register(LanguageConfigurationRegistry.register(this.getLanguageIdentifier(), {})); this._register(TokenizationRegistry.register(this.getLanguageIdentifier().language, { getInitialState: (): IState => NULL_STATE, tokenize: undefined, tokenize2: (line: string, state: IState): TokenizationResult2 => { const tokensArr: number[] = []; let prevLanguageId: LanguageIdentifier = undefined; for (let i = 0; i < line.length; i++) { const languageId = (line.charAt(i) === 'x' ? INNER_LANGUAGE_ID : OUTER_LANGUAGE_ID); if (prevLanguageId !== languageId) { tokensArr.push(i); tokensArr.push((languageId.id << MetadataConsts.LANGUAGEID_OFFSET)); } prevLanguageId = languageId; } const tokens = new Uint32Array(tokensArr.length); for (let i = 0; i < tokens.length; i++) { tokens[i] = tokensArr[i]; } return new TokenizationResult2(tokens, state); } })); } } </ins> <del> let model: TextModel; </del> <ins> class InnerMode extends MockMode { constructor() { super(INNER_LANGUAGE_ID); this._register(LanguageConfigurationRegistry.register(this.getLanguageIdentifier(), {})); } } </ins> <del> setup(function () { model = TextModel.createFromString('Das Pferd frisst keinen Gurkensalat - Philipp Reis 1861.nWer hat's erfunden?'); </del> <ins> const assertAutoTrigger = (model: TextModel, offset: number, expected: boolean, message?: string): void => { const pos = model.getPositionAt(offset); const editor = createMockEditor(model); editor.setPosition(pos); assert.equal(LineContext.shouldAutoTrigger(editor), expected, message); editor.dispose(); }; let disposables: Disposable[] = []; setup(() => { disposables = []; </ins> }); teardown(function () { <del> model.dispose(); </del> <ins> dispose(disposables); disposables = []; </ins> }); test('Context - shouldAutoTrigger', function () { <ins> const model = TextModel.createFromString('Das Pferd frisst keinen Gurkensalat - Philipp Reis 1861.nWer hat's erfunden?'); disposables.push(model); </ins> <del> function assertAutoTrigger(offset: number, expected: boolean): void { const pos = model.getPositionAt(offset); const editor = createMockEditor(model); editor.setPosition(pos); assert.equal(LineContext.shouldAutoTrigger(editor), expected); editor.dispose(); } assertAutoTrigger(3, true); // end of word, Das| assertAutoTrigger(4, false); // no word Das | assertAutoTrigger(1, false); // middle of word D|as assertAutoTrigger(55, false); // number, 1861| </del> <ins> assertAutoTrigger(model, 3, true, 'end of word, Das|'); assertAutoTrigger(model, 4, false, 'no word Das |'); assertAutoTrigger(model, 1, false, 'middle of word D|as'); assertAutoTrigger(model, 55, false, 'number, 1861|'); </ins> }); <ins> test('shouldAutoTrigger at embedded language boundaries', () => { const outerMode = new OuterMode(); const innerMode = new InnerMode(); disposables.push(outerMode, innerMode); const model = TextModel.createFromString('a<xx>a<x>', undefined, outerMode.getLanguageIdentifier()); disposables.push(model); assertAutoTrigger(model, 1, true, 'a|<x \u2014\u00a0should trigger at end of word'); assertAutoTrigger(model, 2, false, 'a<|x \u2014 should NOT trigger at start of word'); assertAutoTrigger(model, 3, false, 'a<x|x \u2014  should NOT trigger in middle of word'); assertAutoTrigger(model, 4, true, 'a<xx|> \u2014\u00a0should trigger at boundary between languages'); assertAutoTrigger(model, 5, false, 'a<xx>|a \u2014 should NOT trigger at start of word'); assertAutoTrigger(model, 6, true, 'a<xx>a|< \u2014 should trigger at end of word'); assertAutoTrigger(model, 8, true, 'a<xx>a<x|> \u2014 should trigger at end of word at boundary'); }); </ins> }); suite('SuggestModel - TriggerAndCancelOracle', function () {", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-8f6206dbe947b0579de9542df791dbe8fba343aca41f37d49e5fa6ed8bf0a78c", "text": "ModelRawLinesDeleted, ModelRawLinesInserted } from 'vs/editor/common/model/textModelEvents'; import { TextModel } from 'vs/editor/common/model/textModel'; <ins> import { LanguageIdentifier, TokenizationRegistry, IState, MetadataConsts } from 'vs/editor/common/modes'; import { MockMode } from 'vs/editor/test/common/mocks/mockMode'; import { LanguageConfigurationRegistry } from 'vs/editor/common/modes/languageConfigurationRegistry'; import { TokenizationResult2 } from 'vs/editor/common/core/token'; import { NULL_STATE } from 'vs/editor/common/modes/nullMode'; import { dispose, Disposable } from 'vs/base/common/lifecycle'; </ins> // --------- utils", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-182fed8484c5dcdfa9d3754cfe183ea15c5868100bfac8600958e03210960307", "text": "suite('Editor Model - Words', () => { <del> var thisModel: TextModel; </del> <ins> const OUTER_LANGUAGE_ID = new LanguageIdentifier('outerMode', 3); const INNER_LANGUAGE_ID = new LanguageIdentifier('innerMode', 4); class OuterMode extends MockMode { constructor() { super(OUTER_LANGUAGE_ID); this._register(LanguageConfigurationRegistry.register(this.getLanguageIdentifier(), {})); this._register(TokenizationRegistry.register(this.getLanguageIdentifier().language, { getInitialState: (): IState => NULL_STATE, tokenize: undefined, tokenize2: (line: string, state: IState): TokenizationResult2 => { const tokensArr: number[] = []; let prevLanguageId: LanguageIdentifier = undefined; for (let i = 0; i < line.length; i++) { const languageId = (line.charAt(i) === 'x' ? INNER_LANGUAGE_ID : OUTER_LANGUAGE_ID); if (prevLanguageId !== languageId) { tokensArr.push(i); tokensArr.push((languageId.id << MetadataConsts.LANGUAGEID_OFFSET)); } prevLanguageId = languageId; } const tokens = new Uint32Array(tokensArr.length); for (let i = 0; i < tokens.length; i++) { tokens[i] = tokensArr[i]; } return new TokenizationResult2(tokens, state); } })); } } class InnerMode extends MockMode { constructor() { super(INNER_LANGUAGE_ID); this._register(LanguageConfigurationRegistry.register(this.getLanguageIdentifier(), {})); } } let disposables: Disposable[] = []; </ins> setup(() => { <del> var text = ['This text has some  words. ']; thisModel = TextModel.createFromString(text.join('n')); </del> <ins> disposables = []; </ins> }); teardown(() => { <del> thisModel.dispose(); </del> <ins> dispose(disposables); disposables = []; </ins> }); test('Get word at position', () => { <ins> const text = ['This text has some  words. ']; const thisModel = TextModel.createFromString(text.join('n')); disposables.push(thisModel); </ins> assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 1)), { word: 'This', startColumn: 1, endColumn: 5 }); assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 2)), { word: 'This', startColumn: 1, endColumn: 5 }); assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 4)), { word: 'This', startColumn: 1, endColumn: 5 });", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-1751b666f0ef016713ce3e5ebc0edf0f87c1e130308bad928ffb22b3cee78546", "query": "VSCode Version: Version 1.19.1 (1.19.1) 0759f77bb8d86658bc935a10a64f6182c5a1eebaOS Version: macOS, 10.12.6 Steps to Reproduce: TypeScript React, and Reproduces without extensions: Yes.\nFor the case: where the user has just typed , returns false since returns . This in turn is caused by having the following language ranges for the string : where = and = . These language ranges cause to take as the current word, which does not match against the known word patterns\nAny update on this? The Ctrl-Space works and provides the correct autocomplete options for props with associated type. Would be nice if I didn't have to do that each time.\nHave the same problem, but wonder about: \"... autocomplete options for props ...\". Is VS Code capable to autocomplete my custom from an imported component?", "positive_passages": [{"docid": "doc-en-vscode-b18131a4554e874a74279cd0484acf60c1d34a5c8b348ccbe0e857477cf110de", "text": "assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 27)), null); assert.deepEqual(thisModel.getWordAtPosition(new Position(1, 28)), null); }); <ins> test('getWordAtPosition at embedded language boundaries', () => { const outerMode = new OuterMode(); const innerMode = new InnerMode(); disposables.push(outerMode, innerMode); const model = TextModel.createFromString('ab<xx>ab<x>', undefined, outerMode.getLanguageIdentifier()); disposables.push(model); assert.deepEqual(model.getWordAtPosition(new Position(1, 1)), { word: 'ab', startColumn: 1, endColumn: 3 }); assert.deepEqual(model.getWordAtPosition(new Position(1, 2)), { word: 'ab', startColumn: 1, endColumn: 3 }); assert.deepEqual(model.getWordAtPosition(new Position(1, 3)), { word: 'ab', startColumn: 1, endColumn: 3 }); assert.deepEqual(model.getWordAtPosition(new Position(1, 4)), { word: 'xx', startColumn: 4, endColumn: 6 }); assert.deepEqual(model.getWordAtPosition(new Position(1, 5)), { word: 'xx', startColumn: 4, endColumn: 6 }); assert.deepEqual(model.getWordAtPosition(new Position(1, 6)), { word: 'xx', startColumn: 4, endColumn: 6 }); assert.deepEqual(model.getWordAtPosition(new Position(1, 7)), { word: 'ab', startColumn: 7, endColumn: 9 }); }); </ins> });", "commid": "vscode_pr_43349"}], "negative_passages": []}
{"query_id": "q-en-vscode-d79b982faa6aabce964692bb48c4cf29159ee39a529551404b4a8102f80dad81", "query": "In , the comparison functions , , , and have misleading descriptions. For example, says \"Check if is before this position.\" I think it would be more clear to say something like \"Check if this position is before \", as that is when is returned. Likewise for the other three.", "positive_passages": [{"docid": "doc-en-vscode-c2cff4428015554e99fda3695cc53d34a3b0a4db08b7d3b509b9f7b7b038f184", "text": "constructor(line: number, character: number); /** <del> * Check if `other` is before this position. </del> <ins> * Check if this position is before `other`. </ins> * * @param other A position. * @return `true` if position is on a smaller line", "commid": "vscode_pr_41317"}], "negative_passages": []}
{"query_id": "q-en-vscode-d79b982faa6aabce964692bb48c4cf29159ee39a529551404b4a8102f80dad81", "query": "In , the comparison functions , , , and have misleading descriptions. For example, says \"Check if is before this position.\" I think it would be more clear to say something like \"Check if this position is before \", as that is when is returned. Likewise for the other three.", "positive_passages": [{"docid": "doc-en-vscode-4c224cfc83afae52548444af6ba86f9c2c892c66c2721482cde9ddfd54abe456", "text": "isBefore(other: Position): boolean; /** <del> * Check if `other` is before or equal to this position. </del> <ins> * Check if this position is before or equal to `other`. </ins> * * @param other A position. * @return `true` if position is on a smaller line", "commid": "vscode_pr_41317"}], "negative_passages": []}
{"query_id": "q-en-vscode-d79b982faa6aabce964692bb48c4cf29159ee39a529551404b4a8102f80dad81", "query": "In , the comparison functions , , , and have misleading descriptions. For example, says \"Check if is before this position.\" I think it would be more clear to say something like \"Check if this position is before \", as that is when is returned. Likewise for the other three.", "positive_passages": [{"docid": "doc-en-vscode-c41a77af82183166bc4ddfb6cd6a9239323bb0e6f8a1687006fcec385dcd63bb", "text": "isBeforeOrEqual(other: Position): boolean; /** <del> * Check if `other` is after this position. </del> <ins> * Check if this position is after `other`. </ins> * * @param other A position. * @return `true` if position is on a greater line", "commid": "vscode_pr_41317"}], "negative_passages": []}
{"query_id": "q-en-vscode-d79b982faa6aabce964692bb48c4cf29159ee39a529551404b4a8102f80dad81", "query": "In , the comparison functions , , , and have misleading descriptions. For example, says \"Check if is before this position.\" I think it would be more clear to say something like \"Check if this position is before \", as that is when is returned. Likewise for the other three.", "positive_passages": [{"docid": "doc-en-vscode-ff142b4a93a3621c04ba0d01857177f4fc21b97e1d09c78405ab0ef2c1251b57", "text": "isAfter(other: Position): boolean; /** <del> * Check if `other` is after or equal to this position. </del> <ins> * Check if this position is after or equal to `other`. </ins> * * @param other A position. * @return `true` if position is on a greater line", "commid": "vscode_pr_41317"}], "negative_passages": []}
{"query_id": "q-en-vscode-d79b982faa6aabce964692bb48c4cf29159ee39a529551404b4a8102f80dad81", "query": "In , the comparison functions , , , and have misleading descriptions. For example, says \"Check if is before this position.\" I think it would be more clear to say something like \"Check if this position is before \", as that is when is returned. Likewise for the other three.", "positive_passages": [{"docid": "doc-en-vscode-a694ffc2c2bdac7c56c7012db63e718968c2510fc500423f1c6114a4600c09d1", "text": "isAfterOrEqual(other: Position): boolean; /** <del> * Check if `other` equals this position. </del> <ins> * Check if this position is equal to `other`. </ins> * * @param other A position. * @return `true` if the line and character of the given position are equal to", "commid": "vscode_pr_41317"}], "negative_passages": []}
{"query_id": "q-en-vscode-f16d9876d169a3ef5780822c398ced7a1bd7a5ca62da6f4778b94f9bfc07d9a8", "query": "It would be nice to invoke current line codelens actions without moving hands of from keyboard to mouse. It could be done via context ctrl+. where codelens actions are or from ctrl+p, or even new shortcut key which opens context menu which contains only codelens actions. They are sometimes available if extension implements them that way that they are to menus/context etc but this probably could be handled more generic way in vscode itself?\nHi! I just opened a PR with the ability to trigger codelenses with the keyboard. Hope you find this helpful as I do :D I appreciate any suggestions and comments from people coming to this issue", "positive_passages": [{"docid": "doc-en-vscode-79efa635b56f6b311633cf1659d4cd969092640d18e2db1eb6e2997f2f32e409", "text": "import { toDisposable, DisposableStore, dispose } from 'vs/base/common/lifecycle'; import { StableEditorScrollState } from 'vs/editor/browser/core/editorState'; import { ICodeEditor, MouseTargetType, IViewZoneChangeAccessor, IActiveCodeEditor } from 'vs/editor/browser/editorBrowser'; <del> import { registerEditorContribution } from 'vs/editor/browser/editorExtensions'; </del> <ins> import { registerEditorContribution, EditorCommand, ServicesAccessor } from 'vs/editor/browser/editorExtensions'; </ins> import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { IModelDecorationsChangeAccessor } from 'vs/editor/common/model'; import { CodeLensProviderRegistry, CodeLens } from 'vs/editor/common/modes';", "commid": "vscode_pr_91232"}], "negative_passages": []}
{"query_id": "q-en-vscode-f16d9876d169a3ef5780822c398ced7a1bd7a5ca62da6f4778b94f9bfc07d9a8", "query": "It would be nice to invoke current line codelens actions without moving hands of from keyboard to mouse. It could be done via context ctrl+. where codelens actions are or from ctrl+p, or even new shortcut key which opens context menu which contains only codelens actions. They are sometimes available if extension implements them that way that they are to menus/context etc but this probably could be handled more generic way in vscode itself?\nHi! I just opened a PR with the ability to trigger codelenses with the keyboard. Hope you find this helpful as I do :D I appreciate any suggestions and comments from people coming to this issue", "positive_passages": [{"docid": "doc-en-vscode-2a042938d2d569014dfbc96817877f7a12bff1c1e81982b780b0a2649923172e", "text": "import { EditorOption } from 'vs/editor/common/config/editorOptions'; import * as dom from 'vs/base/browser/dom'; import { hash } from 'vs/base/common/hash'; <ins> import { IQuickInputService, IQuickPickItem, IQuickPickSeparator } from 'vs/platform/quickinput/common/quickInput'; </ins> export class CodeLensContribution implements IEditorContribution {", "commid": "vscode_pr_91232"}], "negative_passages": []}
{"query_id": "q-en-vscode-f16d9876d169a3ef5780822c398ced7a1bd7a5ca62da6f4778b94f9bfc07d9a8", "query": "It would be nice to invoke current line codelens actions without moving hands of from keyboard to mouse. It could be done via context ctrl+. where codelens actions are or from ctrl+p, or even new shortcut key which opens context menu which contains only codelens actions. They are sometimes available if extension implements them that way that they are to menus/context etc but this probably could be handled more generic way in vscode itself?\nHi! I just opened a PR with the ability to trigger codelenses with the keyboard. Hope you find this helpful as I do :D I appreciate any suggestions and comments from people coming to this issue", "positive_passages": [{"docid": "doc-en-vscode-33585692863646e922816ea540861955f503dfe1644fe9c288810255f540b5c1", "text": "} }); } <ins> public getLenses(): CodeLensWidget[] { return this._lenses; } } export class ShowLensesInCurrentLineCommand extends EditorCommand { public runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void | Promise<void> { const quickInputService = accessor.get(IQuickInputService); const commandService = accessor.get(ICommandService); const notificationService = accessor.get(INotificationService); const lineNumber = editor.getSelection()?.positionLineNumber; const codelensController = editor.getContribution(CodeLensContribution.ID) as CodeLensContribution; const activeLensesWidgets = codelensController.getLenses().filter(lens => lens.getLineNumber() === lineNumber); const commandArguments: Map<string, any[] | undefined> = new Map(); const items: (IQuickPickItem | IQuickPickSeparator)[] = []; activeLensesWidgets.forEach(widget => { widget.getItems().forEach(codelens => { const command = codelens.symbol.command; if (!command) { return; } items.push({ id: command.id, label: command.title }); commandArguments.set(command.id, command.arguments); }); }); // We dont want an empty picker if (!items.length) { return; } quickInputService.pick(items, { canPickMany: false }).then(item => { const id = item.id!; commandService.executeCommand(id, ...(commandArguments.get(id) || [])).catch(err => notificationService.error(err)); }); } </ins> } registerEditorContribution(CodeLensContribution.ID, CodeLensContribution); <ins> const showLensesInCurrentLineCommand = new ShowLensesInCurrentLineCommand({ id: 'codelens.showLensesInCurrentLine', precondition: undefined }); showLensesInCurrentLineCommand.register(); </ins>", "commid": "vscode_pr_91232"}], "negative_passages": []}
{"query_id": "q-en-vscode-f16d9876d169a3ef5780822c398ced7a1bd7a5ca62da6f4778b94f9bfc07d9a8", "query": "It would be nice to invoke current line codelens actions without moving hands of from keyboard to mouse. It could be done via context ctrl+. where codelens actions are or from ctrl+p, or even new shortcut key which opens context menu which contains only codelens actions. They are sometimes available if extension implements them that way that they are to menus/context etc but this probably could be handled more generic way in vscode itself?\nHi! I just opened a PR with the ability to trigger codelenses with the keyboard. Hope you find this helpful as I do :D I appreciate any suggestions and comments from people coming to this issue", "positive_passages": [{"docid": "doc-en-vscode-a761d9dab5647a4ce4397edab2f0bc451b7951bbd096ef801571d8551bdac489", "text": "} } } <ins> getItems(): CodeLensItem[] { return this._data; } </ins> } registerThemingParticipant((theme, collector) => {", "commid": "vscode_pr_91232"}], "negative_passages": []}
{"query_id": "q-en-vscode-f16d9876d169a3ef5780822c398ced7a1bd7a5ca62da6f4778b94f9bfc07d9a8", "query": "It would be nice to invoke current line codelens actions without moving hands of from keyboard to mouse. It could be done via context ctrl+. where codelens actions are or from ctrl+p, or even new shortcut key which opens context menu which contains only codelens actions. They are sometimes available if extension implements them that way that they are to menus/context etc but this probably could be handled more generic way in vscode itself?\nHi! I just opened a PR with the ability to trigger codelenses with the keyboard. Hope you find this helpful as I do :D I appreciate any suggestions and comments from people coming to this issue", "positive_passages": [{"docid": "doc-en-vscode-3528a417a50e4f629ccc267fb4d6dce8d50ba3dcf545ca5aafc492863d3d7918", "text": "import { CancellationToken } from 'vs/base/common/cancellation'; import { IQuickPickItem, IPickOptions, IInputOptions, IQuickNavigateConfiguration, IQuickPick, IQuickInputButton, IInputBox, QuickPickInput } from 'vs/base/parts/quickinput/common/quickInput'; <del> export { IQuickPickItem, IPickOptions, IInputOptions, IQuickNavigateConfiguration, IQuickPick, IQuickInput, IQuickInputButton, IInputBox, IQuickPickItemButtonEvent, QuickPickInput, IQuickPickSeparator, IKeyMods } from 'vs/base/parts/quickinput/common/quickInput'; </del> <ins> export * from 'vs/base/parts/quickinput/common/quickInput'; </ins> export const IQuickInputService = createDecorator<IQuickInputService>('quickInputService');", "commid": "vscode_pr_91232"}], "negative_passages": []}
{"query_id": "q-en-vscode-eacaa740b6edc1c7ac518042e55993a6c501170d7ddf47fb4270a8a7318c156a", "query": "With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?\nI considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.\nThanks , I would agree that proper overflow behaviour is the way to go. Thanks!\nI think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..\nSome terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.\nI suggest the minimum size of a terminal should be an option in Settings.", "positive_passages": [{"docid": "doc-en-vscode-510acae7609c4f0d6fd506ac14320029d094be531a39c806a20f5749a69e7949", "text": "import { IPartService, Position } from 'vs/workbench/services/part/common/partService'; const SPLIT_PANE_MIN_SIZE = 120; <ins> const TERMINAL_MIN_USEFUL_SIZE = 250; </ins> class SplitPaneContainer { private _height: number;", "commid": "vscode_pr_59140"}], "negative_passages": []}
{"query_id": "q-en-vscode-eacaa740b6edc1c7ac518042e55993a6c501170d7ddf47fb4270a8a7318c156a", "query": "With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?\nI considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.\nThanks , I would agree that proper overflow behaviour is the way to go. Thanks!\nI think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..\nSome terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.\nI suggest the minimum size of a terminal should be an option in Settings.", "positive_passages": [{"docid": "doc-en-vscode-791473a924e1aa98766f9ff8908aaf60a70539d783bffd74e373f99858aa94cc", "text": "configHelper: ITerminalConfigHelper, shellLaunchConfig: IShellLaunchConfig ): ITerminalInstance { <ins> const newTerminalSize = ((this._panelPosition === Position.BOTTOM ? this._container.clientWidth : this._container.clientHeight) / (this._terminalInstances.length + 1)); if (newTerminalSize < TERMINAL_MIN_USEFUL_SIZE) { return undefined; } </ins> const instance = this._terminalService.createInstance( terminalFocusContextKey, configHelper,", "commid": "vscode_pr_59140"}], "negative_passages": []}
{"query_id": "q-en-vscode-eacaa740b6edc1c7ac518042e55993a6c501170d7ddf47fb4270a8a7318c156a", "query": "With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?\nI considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.\nThanks , I would agree that proper overflow behaviour is the way to go. Thanks!\nI think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..\nSome terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.\nI suggest the minimum size of a terminal should be an option in Settings.", "positive_passages": [{"docid": "doc-en-vscode-229ade6875fe181b2e34e1f5a208f421ddaa5939602fc29ff356516e51811bc5", "text": "} protected abstract _showTerminalCloseConfirmation(): TPromise<boolean>; <ins> protected abstract _showNotEnoughSpaceToast(): void; </ins> public abstract createTerminal(shell?: IShellLaunchConfig, wasNewTerminalAction?: boolean): ITerminalInstance; public abstract createTerminalRenderer(name: string): ITerminalInstance; public abstract createInstance(terminalFocusContextKey: IContextKey<boolean>, configHelper: ITerminalConfigHelper, container: HTMLElement, shellLaunchConfig: IShellLaunchConfig, doCreateProcess: boolean): ITerminalInstance;", "commid": "vscode_pr_59140"}], "negative_passages": []}
{"query_id": "q-en-vscode-eacaa740b6edc1c7ac518042e55993a6c501170d7ddf47fb4270a8a7318c156a", "query": "With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?\nI considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.\nThanks , I would agree that proper overflow behaviour is the way to go. Thanks!\nI think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..\nSome terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.\nI suggest the minimum size of a terminal should be an option in Settings.", "positive_passages": [{"docid": "doc-en-vscode-7c374c9b0ecb00fdbaed01c46d43401f148dd0fa209f3818088f1d11dffebc31", "text": "} const instance = tab.split(this._terminalFocusContextKey, this.configHelper, shellLaunchConfig); <del> this._initInstanceListeners(instance); this._onInstancesChanged.fire(); </del> <ins> if (instance) { this._initInstanceListeners(instance); this._onInstancesChanged.fire(); </ins> <del> this._terminalTabs.forEach((t, i) => t.setVisible(i === this._activeTabIndex)); </del> <ins> this._terminalTabs.forEach((t, i) => t.setVisible(i === this._activeTabIndex)); } else { this._showNotEnoughSpaceToast(); } </ins> } protected _initInstanceListeners(instance: ITerminalInstance): void {", "commid": "vscode_pr_59140"}], "negative_passages": []}
{"query_id": "q-en-vscode-eacaa740b6edc1c7ac518042e55993a6c501170d7ddf47fb4270a8a7318c156a", "query": "With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?\nI considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.\nThanks , I would agree that proper overflow behaviour is the way to go. Thanks!\nI think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..\nSome terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.\nI suggest the minimum size of a terminal should be an option in Settings.", "positive_passages": [{"docid": "doc-en-vscode-67ef2936ac111e7785f8c031aed9680cb874653f91475199190603cade2dbc61", "text": "this._terminalTabs = []; this._configHelper = this._instantiationService.createInstance(TerminalConfigHelper); ipc.on('vscode:openFiles', (_event: any, request: IOpenFileRequest) => { // if the request to open files is coming in from the integrated terminal (identified though // the termProgram variable) and we are instructed to wait for editors close, wait for the", "commid": "vscode_pr_59140"}], "negative_passages": []}
{"query_id": "q-en-vscode-eacaa740b6edc1c7ac518042e55993a6c501170d7ddf47fb4270a8a7318c156a", "query": "With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?\nI considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.\nThanks , I would agree that proper overflow behaviour is the way to go. Thanks!\nI think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..\nSome terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.\nI suggest the minimum size of a terminal should be an option in Settings.", "positive_passages": [{"docid": "doc-en-vscode-3139900828195ea1df3407291fa9ca0014b46a799c1cb17abdd2000324b3554d", "text": "}).then(res => !res.confirmed); } <ins> protected _showNotEnoughSpaceToast(): void { this._notificationService.warn(nls.localize('terminal.minWidth', \"Not enough space to split terminal.\")); } </ins> public setContainers(panelContainer: HTMLElement, terminalContainer: HTMLElement): void { this._configHelper.panelContainer = panelContainer; this._terminalContainer = terminalContainer;", "commid": "vscode_pr_59140"}], "negative_passages": []}
{"query_id": "q-en-vscode-6f896230f9a9dafa8af58dedc226d948c3ed38395a7098edebd10440f5837460", "query": "Issue Type: <bFeature Request</bWhen using a touch screen, I want to be able to interact with VSCode in an intuitive manner. When I touch the minimap, I expect the document to scroll immediately on touch-down, not on touch-up. Mouse-up makes sense for a mouse, but not for a touch. When I touch and drag the minimap, I expect the minimap to scroll with my finger. VS Code version: Code 1.22.1 (, 2018-04-06T02:26:57.615Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.487 --- <!-- score: 0.464 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --\nI haven't PR'd vscode before, if anyone who cares about this issue has tips on getting my PR ^^ merged and released I'm happy to put more work into it. I find it very frustrating not having touch-scrolling on the minimap, as I'm so used to it working in old-school Visual Studio!", "positive_passages": [{"docid": "doc-en-vscode-d0661c1c4233ab7a83ce25396cac8ee9b94a7c46fb054744de36ddf1c2ec545e", "text": "import { ModelDecorationMinimapOptions } from 'vs/editor/common/model/textModel'; import { Selection } from 'vs/editor/common/core/selection'; import { Color } from 'vs/base/common/color'; <ins> import { GestureEvent, EventType, Gesture } from 'vs/base/browser/touch'; </ins> function getMinimapLineHeight(renderMinimap: RenderMinimap): number { if (renderMinimap === RenderMinimap.Large) {", "commid": "vscode_pr_81097"}], "negative_passages": []}
{"query_id": "q-en-vscode-6f896230f9a9dafa8af58dedc226d948c3ed38395a7098edebd10440f5837460", "query": "Issue Type: <bFeature Request</bWhen using a touch screen, I want to be able to interact with VSCode in an intuitive manner. When I touch the minimap, I expect the document to scroll immediately on touch-down, not on touch-up. Mouse-up makes sense for a mouse, but not for a touch. When I touch and drag the minimap, I expect the minimap to scroll with my finger. VS Code version: Code 1.22.1 (, 2018-04-06T02:26:57.615Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.487 --- <!-- score: 0.464 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --\nI haven't PR'd vscode before, if anyone who cares about this issue has tips on getting my PR ^^ merged and released I'm happy to put more work into it. I find it very frustrating not having touch-scrolling on the minimap, as I'm so used to it working in old-school Visual Studio!", "positive_passages": [{"docid": "doc-en-vscode-73bacf4611c43db7274a6950517939ca1a82a0595c7b1a032c48a2edbb34d4be", "text": "return Math.round(desiredSliderPosition / this._computedSliderRatio); } <ins> public getDesiredScrollTopFromTouchLocation(pageY: number): number { return Math.round((pageY - this.sliderHeight / 2) / this._computedSliderRatio); } </ins> public static create( options: MinimapOptions, viewportStartLineNumber: number,", "commid": "vscode_pr_81097"}], "negative_passages": []}
{"query_id": "q-en-vscode-6f896230f9a9dafa8af58dedc226d948c3ed38395a7098edebd10440f5837460", "query": "Issue Type: <bFeature Request</bWhen using a touch screen, I want to be able to interact with VSCode in an intuitive manner. When I touch the minimap, I expect the document to scroll immediately on touch-down, not on touch-up. Mouse-up makes sense for a mouse, but not for a touch. When I touch and drag the minimap, I expect the minimap to scroll with my finger. VS Code version: Code 1.22.1 (, 2018-04-06T02:26:57.615Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.487 --- <!-- score: 0.464 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --\nI haven't PR'd vscode before, if anyone who cares about this issue has tips on getting my PR ^^ merged and released I'm happy to put more work into it. I find it very frustrating not having touch-scrolling on the minimap, as I'm so used to it working in old-school Visual Studio!", "positive_passages": [{"docid": "doc-en-vscode-2ac4f7b524058d17d97b3b0b4459d14bef1fd73309cbd5cadeb8b3819bc2cb1f", "text": "private readonly _mouseDownListener: IDisposable; private readonly _sliderMouseMoveMonitor: GlobalMouseMoveMonitor<IStandardMouseMoveEventData>; private readonly _sliderMouseDownListener: IDisposable; <ins> private readonly _sliderTouchStartListener: IDisposable; private readonly _sliderTouchMoveListener: IDisposable; private readonly _sliderTouchEndListener: IDisposable; </ins> private _options: MinimapOptions; private _lastRenderData: RenderData | null; private _selections: Selection[] = []; private _selectionColor: Color | undefined; private _renderDecorations: boolean = false; <ins> private _gestureInProgress: boolean = false; </ins> private _buffers: MinimapBuffers | null; constructor(context: ViewContext) {", "commid": "vscode_pr_81097"}], "negative_passages": []}
{"query_id": "q-en-vscode-6f896230f9a9dafa8af58dedc226d948c3ed38395a7098edebd10440f5837460", "query": "Issue Type: <bFeature Request</bWhen using a touch screen, I want to be able to interact with VSCode in an intuitive manner. When I touch the minimap, I expect the document to scroll immediately on touch-down, not on touch-up. Mouse-up makes sense for a mouse, but not for a touch. When I touch and drag the minimap, I expect the minimap to scroll with my finger. VS Code version: Code 1.22.1 (, 2018-04-06T02:26:57.615Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.487 --- <!-- score: 0.464 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --\nI haven't PR'd vscode before, if anyone who cares about this issue has tips on getting my PR ^^ merged and released I'm happy to put more work into it. I find it very frustrating not having touch-scrolling on the minimap, as I'm so used to it working in old-school Visual Studio!", "positive_passages": [{"docid": "doc-en-vscode-254289966fe733c36d2c9273970e8b2b307f202a23e641619b37ad52ce18d26a", "text": "); } }); <ins> Gesture.addTarget(this._domNode.domNode); this._sliderTouchStartListener = dom.addDisposableListener(this._domNode.domNode, EventType.Start, (e: GestureEvent) => { e.preventDefault(); e.stopPropagation(); if (this._lastRenderData) { this._slider.toggleClassName('active', true); this._gestureInProgress = true; this.scrollDueToTouchEvent(e); } }); this._sliderTouchMoveListener = dom.addStandardDisposableListener(this._domNode.domNode, EventType.Change, (e: GestureEvent) => { e.preventDefault(); e.stopPropagation(); if (this._lastRenderData && this._gestureInProgress) { this.scrollDueToTouchEvent(e); } }); this._sliderTouchEndListener = dom.addStandardDisposableListener(this._domNode.domNode, EventType.End, (e: GestureEvent) => { e.preventDefault(); e.stopPropagation(); this._gestureInProgress = false; this._slider.toggleClassName('active', false); }); } private scrollDueToTouchEvent(touch: GestureEvent) { const startY = this._domNode.domNode.getBoundingClientRect().top; const scrollTop = this._lastRenderData!.renderedLayout.getDesiredScrollTopFromTouchLocation(touch.pageY - startY); this._context.viewLayout.setScrollPositionNow({ scrollTop: scrollTop }); </ins> } public dispose(): void { this._mouseDownListener.dispose(); this._sliderMouseMoveMonitor.dispose(); this._sliderMouseDownListener.dispose(); <ins> this._sliderTouchStartListener.dispose(); this._sliderTouchMoveListener.dispose(); this._sliderTouchEndListener.dispose(); </ins> super.dispose(); }", "commid": "vscode_pr_81097"}], "negative_passages": []}
{"query_id": "q-en-vscode-08086a885ea729908af389c97d9e6c7dfedad50e36c4842725720aac22b2468a", "query": "<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.23.0-insiders x64 commit OS Version: Windows 8.1 x64 After update to latest version window is empty (only main menu bar is visible). Renderer process consumes 16-20% CPU but nothing is changing. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes\ncan you run \"\" from the command line and see if any output is printed?\nThe output is here:\nadding for the (maybe unrelated) spdylog stacktrace that shows up. can you share a screenshot how VSCode looks after it started like this?\n!\ndoes it make any difference if you run with \"\" from the command line?\nThat literal looks weird. It looks like the user has a problem in one of his variables, possibly . Whats the value of your HOMEPATH variable?\nVisually nothing is changed. In console also nothing. is not presented. Username is , but profile folder named as .\ndoes it make any difference if you run \"\" from the command line?\nYes. Window is opening like normal new profile. My profile is broken. Nice. ! UPD: Erased my old profile. Nothing. Same situation. So, trouble is Cyrillic symbols in path to profile folder.\nto verify that can you use the argument with a folder that has the Cyrillic characters and see if you get the same results?\nYes. Launch with Cyrillic characters in path give same result.\nit would be easier for me to reproduce if you could post the exact Cyrillic letters that you are using in here as text so that I can copy it.\nHere it is: .\nI can reproduce and the reason the workbench is not coming up is due to spdylog crashing very early. To reproduce run \"\"\nJust to confirm, you could reproduce by using cyrilic in a path provided to ?\nI can. Command: Result:\nyes\nI can confirm I have an identical problem. My username contains the character '\u00f8', which now makes the insiders build fail to start. Changing the to a path which does not contain that character fixes the issue. However, the Windows context menu action does not work, as the argument is only provided on the shortcut. The stable release (1.22.2) works as expected. EDIT: I fixed the context menu issue manually in the registry, so everything is back to normal for now :)\nI pushed a workaround for now to not crash so badly when we fail to instantiate the spdylog writer. Turns out we already had code in place to protect from failing loads thanks to Alex, but the output channel was failing very early on. fyi maybe you want to quickly check my changes via The real fix probably needs to go into spdylog, pushing to May since this was already happening in stable.\nThis will break Output channels when not writing into file. When user switches between output channels, they will become empty as there is no way to retrieve content now\nI was falling back to old way of writing into channels if fails. I removed this fallback this milestone . You can get that back. But I would really want to remove this fallback because for further enhancements to output channel which depends on spdlog.\nthis is not a real fix, I would expect some regressions. Previously VS Code would not start at all without my workaround. Do you think the current behaviour with my fix is worse than before? I think its clear that we will work on a fix for May.\nIMO The better workaround would be to bring back my fallback . I was doing the same as you except that I fallback to old way of writing into Output channels. This will not have any regressions as it was there in last milestone. When we fix it in May, we can remove the workaround.\nSorry, I am confused. May I know if this issue is due to Loading of spdlog library OR spdlog fails to create a file\nI see the workaround is if spldlog fails to create logger/file. So I think it is better to use my fallback.\nPushed the previous workaround I was using. As said, this will not break output channels if there is an issue creating spdlog logger.\nI don't see issues running dev with a user-data-dir containing a non-ascii character (eg ) any more. I do not understand if this is because of your workaround or if the new spdlog version actually fixed the issue. Moving it to you in order to check if the issue is fixed already, since I don't understand how to repro.\nI too do not see any issues after removing the workaround I before for the crash. Hence removed the workaround. To verify: Open VS Code using an user directory that has non-ascii character (eg \u00f8) Verify that VS Code starts normally and the output channels are properly written Verify that there is no crash\nReopening this as the crash from spdlog is not fixed.\nI still see following error in the console with our log files Edit: This is seen in the console even with the workaround. Workaround just mitigates it by falling back to old output channels. Logs will not work though.\nUpdated node-spdlog library to support in file names. Thanks to for hinting it. With this crash no longer occurs with non ascii or special characters (tested with all reported characters). Added a smoke test to launch VS Code with special characters in user data dir.", "positive_passages": [{"docid": "doc-en-vscode-d21a83ad14b060e9396e6a6a8e5eac4750f425ef42b604264c3d4bdbf39202c1", "text": "\"native-watchdog\": \"0.3.0\", \"node-pty\": \"0.7.7\", \"semver\": \"^5.5.0\", <del> \"spdlog\": \"0.7.1\", </del> <ins> \"spdlog\": \"0.7.2\", </ins> \"sudo-prompt\": \"8.2.0\", \"v8-inspect-profiler\": \"^0.0.8\", \"vscode-chokidar\": \"1.6.4\",", "commid": "vscode_pr_58082"}], "negative_passages": []}
{"query_id": "q-en-vscode-08086a885ea729908af389c97d9e6c7dfedad50e36c4842725720aac22b2468a", "query": "<!-- Do you have a question? Please ask it on --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.23.0-insiders x64 commit OS Version: Windows 8.1 x64 After update to latest version window is empty (only main menu bar is visible). Renderer process consumes 16-20% CPU but nothing is changing. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes\ncan you run \"\" from the command line and see if any output is printed?\nThe output is here:\nadding for the (maybe unrelated) spdylog stacktrace that shows up. can you share a screenshot how VSCode looks after it started like this?\n!\ndoes it make any difference if you run with \"\" from the command line?\nThat literal looks weird. It looks like the user has a problem in one of his variables, possibly . Whats the value of your HOMEPATH variable?\nVisually nothing is changed. In console also nothing. is not presented. Username is , but profile folder named as .\ndoes it make any difference if you run \"\" from the command line?\nYes. Window is opening like normal new profile. My profile is broken. Nice. ! UPD: Erased my old profile. Nothing. Same situation. So, trouble is Cyrillic symbols in path to profile folder.\nto verify that can you use the argument with a folder that has the Cyrillic characters and see if you get the same results?\nYes. Launch with Cyrillic characters in path give same result.\nit would be easier for me to reproduce if you could post the exact Cyrillic letters that you are using in here as text so that I can copy it.\nHere it is: .\nI can reproduce and the reason the workbench is not coming up is due to spdylog crashing very early. To reproduce run \"\"\nJust to confirm, you could reproduce by using cyrilic in a path provided to ?\nI can. Command: Result:\nyes\nI can confirm I have an identical problem. My username contains the character '\u00f8', which now makes the insiders build fail to start. Changing the to a path which does not contain that character fixes the issue. However, the Windows context menu action does not work, as the argument is only provided on the shortcut. The stable release (1.22.2) works as expected. EDIT: I fixed the context menu issue manually in the registry, so everything is back to normal for now :)\nI pushed a workaround for now to not crash so badly when we fail to instantiate the spdylog writer. Turns out we already had code in place to protect from failing loads thanks to Alex, but the output channel was failing very early on. fyi maybe you want to quickly check my changes via The real fix probably needs to go into spdylog, pushing to May since this was already happening in stable.\nThis will break Output channels when not writing into file. When user switches between output channels, they will become empty as there is no way to retrieve content now\nI was falling back to old way of writing into channels if fails. I removed this fallback this milestone . You can get that back. But I would really want to remove this fallback because for further enhancements to output channel which depends on spdlog.\nthis is not a real fix, I would expect some regressions. Previously VS Code would not start at all without my workaround. Do you think the current behaviour with my fix is worse than before? I think its clear that we will work on a fix for May.\nIMO The better workaround would be to bring back my fallback . I was doing the same as you except that I fallback to old way of writing into Output channels. This will not have any regressions as it was there in last milestone. When we fix it in May, we can remove the workaround.\nSorry, I am confused. May I know if this issue is due to Loading of spdlog library OR spdlog fails to create a file\nI see the workaround is if spldlog fails to create logger/file. So I think it is better to use my fallback.\nPushed the previous workaround I was using. As said, this will not break output channels if there is an issue creating spdlog logger.\nI don't see issues running dev with a user-data-dir containing a non-ascii character (eg ) any more. I do not understand if this is because of your workaround or if the new spdlog version actually fixed the issue. Moving it to you in order to check if the issue is fixed already, since I don't understand how to repro.\nI too do not see any issues after removing the workaround I before for the crash. Hence removed the workaround. To verify: Open VS Code using an user directory that has non-ascii character (eg \u00f8) Verify that VS Code starts normally and the output channels are properly written Verify that there is no crash\nReopening this as the crash from spdlog is not fixed.\nI still see following error in the console with our log files Edit: This is seen in the console even with the workaround. Workaround just mitigates it by falling back to old output channels. Logs will not work though.\nUpdated node-spdlog library to support in file names. Thanks to for hinting it. With this crash no longer occurs with non ascii or special characters (tested with all reported characters). Added a smoke test to launch VS Code with special characters in user data dir.", "positive_passages": [{"docid": "doc-en-vscode-b784a5f1eba0f5323f59abececddf50c8cfceea9b9d2874dee078a9db93b6030", "text": "version \"1.0.0\" resolved \"https://registry.yarnpkg.com/sparkles/-/sparkles-1.0.0.tgz#1acbbfb592436d10bbe8f785b7cc6f82815012c3\" <del> spdlog@0.7.1: version \"0.7.1\" resolved \"https://registry.yarnpkg.com/spdlog/-/spdlog-0.7.1.tgz#960b8cdced12e8c482d1df9fa65220789f276979\" </del> <ins> spdlog@0.7.2: version \"0.7.2\" resolved \"https://registry.yarnpkg.com/spdlog/-/spdlog-0.7.2.tgz#9298753d7694b9ee9bbfd7e01ea1e4c6ace1e64d\" </ins> dependencies: bindings \"^1.3.0\" mkdirp \"^0.5.1\"", "commid": "vscode_pr_58082"}], "negative_passages": []}
{"query_id": "q-en-vscode-b9a4facb6b9e507bbf71d276826ad983db7a2e240bb94994931cad2f296584d6", "query": "I did this on accident, but it took a little effort to figure out how I did it. Drag file from Finder onto Explorer Get scrollbar in Explorer to be visible, like by dragging near the top/bottom of the Explorer The entire explorer becomes highlighted when you hold the file over the scrollbar Drop file onto the scrollbar The entire explorer stays highlighted. It stays highlighted through interacting with the explorer and even switching to another viewlet. Only can be reversed by dragging another file onto the explorer. !\nActually a much easier way to repro is to two-finger scroll while dragging the file to get the scrollbar to appear.\ni'm able to reproduce it. will try to fix it\ncouldn't find where to start. help is appreciated\nI gave it a go in this PR:", "positive_passages": [{"docid": "doc-en-vscode-6013adcf8831f42a26afe5f9ca7f21fba89a98ea02d01b745af302e0e00d37fc", "text": "return candidate; } <del> if (element === document.body) { </del> <ins> if (element === this.scrollableElement.getDomNode() || element === document.body) { </ins> return null; } } while (element = element.parentElement);", "commid": "vscode_pr_49747"}], "negative_passages": []}
{"query_id": "q-en-vscode-8ad5afbabd1bf964bae7ee00be6958460382c249eb3b1f453a4645336b2f0d1b", "query": "Have file named in explorer Copy/paste it Window hangs This is from We shouldn't attempt this when the number is = Number.MAXSAFEINTEGER. It loops forever here: This bug will happen whenever incrementFileName fails to modify the file name.\nI guess only interesting thing about this what we should do in this case as we need to create some new file name? Add without changing the original number?\nthat sounds reasonable", "positive_passages": [{"docid": "doc-en-vscode-602e09a9e1f540a336ee0bd773087404c55883c30e5b207ffae9d430c3c746ac", "text": "import { Schemas } from 'vs/base/common/network'; import { IDialogService, IConfirmationResult, IConfirmation, getConfirmMessage } from 'vs/platform/dialogs/common/dialogs'; import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; <ins> import { Constants } from 'vs/editor/common/core/uint'; </ins> export interface IEditableData { action: IAction;", "commid": "vscode_pr_50865"}], "negative_passages": []}
{"query_id": "q-en-vscode-8ad5afbabd1bf964bae7ee00be6958460382c249eb3b1f453a4645336b2f0d1b", "query": "Have file named in explorer Copy/paste it Window hangs This is from We shouldn't attempt this when the number is = Number.MAXSAFEINTEGER. It loops forever here: This bug will happen whenever incrementFileName fails to modify the file name.\nI guess only interesting thing about this what we should do in this case as we need to create some new file name? Add without changing the original number?\nthat sounds reasonable", "positive_passages": [{"docid": "doc-en-vscode-75c92c06cb43721696242fcafa8614ed1bfccb46eac5dc6a35d3c5aa9e39b14b", "text": "export function incrementFileName(name: string, isFolder: boolean): string { const separators = '[.-_]'; <ins> const maxNumber = Constants.MAX_SAFE_SMALL_INTEGER; </ins> // file.1.txt=>file.2.txt let suffixFileRegex = RegExp('(.*' + separators + ')(d+)(..*)$'); if (!isFolder && name.match(suffixFileRegex)) { return name.replace(suffixFileRegex, (match, g1?, g2?, g3?) => { <del> return g1 + strings.pad(parseInt(g2) + 1, g2.length) + g3; </del> <ins> let number = parseInt(g2); return number < maxNumber ? g1 + strings.pad(number + 1, g2.length) + g3 : strings.format('{0}{1}.1{2}', g1, g2, g3); </ins> }); }", "commid": "vscode_pr_50865"}], "negative_passages": []}
{"query_id": "q-en-vscode-8ad5afbabd1bf964bae7ee00be6958460382c249eb3b1f453a4645336b2f0d1b", "query": "Have file named in explorer Copy/paste it Window hangs This is from We shouldn't attempt this when the number is = Number.MAXSAFEINTEGER. It loops forever here: This bug will happen whenever incrementFileName fails to modify the file name.\nI guess only interesting thing about this what we should do in this case as we need to create some new file name? Add without changing the original number?\nthat sounds reasonable", "positive_passages": [{"docid": "doc-en-vscode-e5a76acff5b0b018d018938ad6597726c40026bba3b5f59314056da2e74adf4c", "text": "let prefixFileRegex = RegExp('(d+)(' + separators + '.*)(..*)$'); if (!isFolder && name.match(prefixFileRegex)) { return name.replace(prefixFileRegex, (match, g1?, g2?, g3?) => { <del> return strings.pad(parseInt(g1) + 1, g1.length) + g2 + g3; </del> <ins> let number = parseInt(g1); return number < maxNumber ? strings.pad(number + 1, g1.length) + g2 + g3 : strings.format('{0}{1}.1{2}', g1, g2, g3); </ins> }); }", "commid": "vscode_pr_50865"}], "negative_passages": []}
{"query_id": "q-en-vscode-8ad5afbabd1bf964bae7ee00be6958460382c249eb3b1f453a4645336b2f0d1b", "query": "Have file named in explorer Copy/paste it Window hangs This is from We shouldn't attempt this when the number is = Number.MAXSAFEINTEGER. It loops forever here: This bug will happen whenever incrementFileName fails to modify the file name.\nI guess only interesting thing about this what we should do in this case as we need to create some new file name? Add without changing the original number?\nthat sounds reasonable", "positive_passages": [{"docid": "doc-en-vscode-bd1b7b9a21b0b589e34e8ffdf11f686537502086f7ca5d0aa67c94ae3aaf3077", "text": "// folder.1=>folder.2 if (isFolder && name.match(/(d+)$/)) { <del> return name.replace(/(d+)$/, (match: string, ...groups: any[]) => { return strings.pad(parseInt(groups[0]) + 1, groups[0].length); }); </del> <ins> return name.replace(/(d+)$/, (match: string, ...groups: any[]) => { let number = parseInt(groups[0]); return number < maxNumber ? strings.pad(number + 1, groups[0].length) : strings.format('{0}.1', groups[0]); }); </ins> } // 1.folder=>2.folder if (isFolder && name.match(/^(d+)/)) { <del> return name.replace(/^(d+)/, (match: string, ...groups: any[]) => { return strings.pad(parseInt(groups[0]) + 1, groups[0].length); }); </del> <ins> return name.replace(/^(d+)(.*)$/, (match: string, ...groups: any[]) => { let number = parseInt(groups[0]); return number < maxNumber ? strings.pad(number + 1, groups[0].length) + groups[1] : strings.format('{0}{1}.1', groups[0], groups[1]); }); </ins> } // file/folder=>file.1/folder.1", "commid": "vscode_pr_50865"}], "negative_passages": []}
{"query_id": "q-en-vscode-8ad5afbabd1bf964bae7ee00be6958460382c249eb3b1f453a4645336b2f0d1b", "query": "Have file named in explorer Copy/paste it Window hangs This is from We shouldn't attempt this when the number is = Number.MAXSAFEINTEGER. It loops forever here: This bug will happen whenever incrementFileName fails to modify the file name.\nI guess only interesting thing about this what we should do in this case as we need to create some new file name? Add without changing the original number?\nthat sounds reasonable", "positive_passages": [{"docid": "doc-en-vscode-f39778450d3e0861eb2d0bc72d0d5771e25fc558e0c71dc3e7d553143d07e6b1", "text": "assert.strictEqual(result, 'test_2'); }); <ins> test('Increment file name with suffix version, too big number', function () { const name = 'test.9007199254740992.js'; const result = incrementFileName(name, false); assert.strictEqual(result, 'test.9007199254740992.1.js'); }); test('Increment folder name with suffix version, too big number', function () { const name = 'test.9007199254740992'; const result = incrementFileName(name, true); assert.strictEqual(result, 'test.9007199254740992.1'); }); </ins> test('Increment file name with prefix version', function () { const name = '1.test.js'; const result = incrementFileName(name, false);", "commid": "vscode_pr_50865"}], "negative_passages": []}
{"query_id": "q-en-vscode-8ad5afbabd1bf964bae7ee00be6958460382c249eb3b1f453a4645336b2f0d1b", "query": "Have file named in explorer Copy/paste it Window hangs This is from We shouldn't attempt this when the number is = Number.MAXSAFEINTEGER. It loops forever here: This bug will happen whenever incrementFileName fails to modify the file name.\nI guess only interesting thing about this what we should do in this case as we need to create some new file name? Add without changing the original number?\nthat sounds reasonable", "positive_passages": [{"docid": "doc-en-vscode-7e7b80e0fb4bf018f7544ab9f094c8b8828218db2b7a8aab19bb6dceb48f4a11", "text": "assert.strictEqual(result, '2_test.js'); }); <del> test('Increment folder name with suffix version', function () { </del> <ins> test('Increment file name with prefix version, too big number', function () { const name = '9007199254740992.test.js'; const result = incrementFileName(name, false); assert.strictEqual(result, '9007199254740992.test.1.js'); }); test('Increment folder name with prefix version', function () { </ins> const name = '1.test'; const result = incrementFileName(name, true); assert.strictEqual(result, '2.test'); }); <del> test('Increment folder name with suffix version, trailing zeros', function () { </del> <ins> test('Increment folder name with prefix version, too big number', function () { const name = '9007199254740992.test'; const result = incrementFileName(name, true); assert.strictEqual(result, '9007199254740992.test.1'); }); test('Increment folder name with prefix version, trailing zeros', function () { </ins> const name = '001.test'; const result = incrementFileName(name, true); assert.strictEqual(result, '002.test'); }); <del> test('Increment folder name with suffix version  with `-` as separator', function () { </del> <ins> test('Increment folder name with prefix version  with `-` as separator', function () { </ins> const name = '1-test'; const result = incrementFileName(name, true); assert.strictEqual(result, '2-test');", "commid": "vscode_pr_50865"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-4556573f9d330ca266537b5890c6907c326b43194447e2e2eea7e095176e94c0", "text": "import { nullTokenize2 } from 'vs/editor/common/modes/nullMode'; import { generateTokensCSSForColorMap } from 'vs/editor/common/modes/supports/tokenization'; import { Color } from 'vs/base/common/color'; <ins> import { INotificationService } from 'vs/platform/notification/common/notification'; </ins> import URI from 'vs/base/common/uri'; export class TMScopeRegistry {", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-7f2f4b59059eff94b06c9323a0ec4101d32267e9fd9066b3583be232f1f4d2a9", "text": "private _scopeRegistry: TMScopeRegistry; private _injections: { [scopeName: string]: string[]; }; private _injectedEmbeddedLanguages: { [scopeName: string]: IEmbeddedLanguagesMap[]; }; <ins> private _notificationService: INotificationService; </ins> private _languageToScope: Map<string, string>; private _styleElement: HTMLStyleElement;", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-127fd3a853d5a74711857c261c7bd5e66ec619b52a9a219ecfa209c10cebfbff", "text": "constructor( @IModeService modeService: IModeService, <del> @IWorkbenchThemeService themeService: IWorkbenchThemeService </del> <ins> @IWorkbenchThemeService themeService: IWorkbenchThemeService, @INotificationService notificationService: INotificationService </ins> ) { this._styleElement = dom.createStyleSheet(); this._styleElement.className = 'vscode-tokens-styles';", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-040793ca4aab3e7e1e2abea0e9fee4912c1e921c7ad9d8445499d0951748bbe1", "text": "this._injections = {}; this._injectedEmbeddedLanguages = {}; this._languageToScope = new Map<string, string>(); <ins> this._notificationService = notificationService; </ins> this._grammarRegistry = null;", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-f8236f86a18976f5349aed9d6979d41a1429a1e0445644243da388b7d13e2525", "text": "private registerDefinition(modeId: string): void { this._createGrammar(modeId).then((r) => { <del> TokenizationRegistry.register(modeId, new TMTokenization(this._scopeRegistry, r.languageId, r.grammar, r.initialState, r.containsEmbeddedLanguages)); </del> <ins> TokenizationRegistry.register(modeId, new TMTokenization(this._scopeRegistry, r.languageId, r.grammar, r.initialState, r.containsEmbeddedLanguages, this._notificationService)); </ins> }, onUnexpectedError); } }", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-9d9e028ab8b2c4ff27bc19d54d2f53f031fa4d63c57bf4351e8de777cb4ef954", "text": "private readonly _containsEmbeddedLanguages: boolean; private readonly _seenLanguages: boolean[]; private readonly _initialState: StackElement; <ins> private _tokenizationWarningAlreadyShown: boolean; </ins> <del> constructor(scopeRegistry: TMScopeRegistry, languageId: LanguageId, grammar: IGrammar, initialState: StackElement, containsEmbeddedLanguages: boolean) { </del> <ins> constructor(scopeRegistry: TMScopeRegistry, languageId: LanguageId, grammar: IGrammar, initialState: StackElement, containsEmbeddedLanguages: boolean, @INotificationService private notificationService: INotificationService) { </ins> this._scopeRegistry = scopeRegistry; this._languageId = languageId; this._grammar = grammar;", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-eaccda67f2116422d2ebfdf25128f96ce9fba2d92594e42fc2b0cf68791166d2", "query": "Issue Type: <bBug</bJSON syntax highlighting fails on the following array (item 1, \"response\"): { \"request\": [24], \"response\": [152, 26, 0, 0, 227, 147, 4, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 64, 233, 245, 229, 2, 43, 60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 68, 65, 3, 0, 1, 0, 100, 0, 12, 1, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 70, 32, 32, 32, 32, 82, 67, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 221, 41, 12, 1, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 49, 32, 32, 32, 82, 67, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 52, 41, 12, 1, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 50, 32, 32, 32, 82, 67, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 40, 12, 1, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 51, 32, 32, 32, 82, 67, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 32, 12, 1, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 52, 32, 32, 32, 82, 67, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 231, 70, 12, 1, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 53, 32, 32, 32, 82, 67, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 1, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 54, 32, 32, 32, 82, 67, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 1, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 82, 67, 73, 48, 55, 32, 32, 32, 82, 67, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 2, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 70, 85, 50, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 70, 85, 84, 85, 82, 69, 83, 44, 32, 68, 69, 67, 61, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 65, 0, 12, 2, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 83, 48, 49, 32, 32, 32, 83, 70, 32, 84, 83, 32, 76, 69, 86, 69, 76, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 70, 32, 32, 32, 32, 51, 45, 89, 32, 69, 88, 67, 72, 65, 78, 71, 69, 32, 70, 85, 78, 68, 32, 78, 79, 84, 69, 83, 32, 70, 85, 84, 85, 82, 69, 83, 32, 1, 1, 1, 2, 1, 0, 0, 28, 12, 3, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 49, 32, 32, 32, 69, 70, 51, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 50, 32, 32, 32, 69, 70, 51, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 3, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 69, 70, 51, 48, 51, 32, 32, 32, 69, 70, 51, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 8, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 70, 32, 32, 32, 32, 67, 79, 77, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 8, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 49, 32, 32, 32, 67, 79, 77, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 8, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 67, 79, 77, 48, 50, 32, 32, 32, 67, 79, 77, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 174, 70, 12, 16, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 70, 32, 32, 32, 32, 77, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 16, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 67, 32, 32, 32, 32, 77, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 157, 32, 12, 16, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 80, 32, 32, 32, 32, 77, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 16, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 49, 32, 32, 32, 77, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 171, 0, 12, 16, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 50, 32, 32, 32, 77, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 51, 32, 32, 32, 77, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 52, 32, 32, 32, 77, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 53, 32, 32, 32, 77, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 54, 32, 32, 32, 77, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 16, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 77, 72, 73, 48, 55, 32, 32, 32, 77, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 16, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 77, 72, 73, 32, 77, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 20, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 67, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 80, 32, 32, 32, 32, 83, 84, 79, 67, 75, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 20, 172, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 83, 79, 77, 49, 32, 32, 32, 32, 83, 79, 77, 32, 83, 89, 78, 84, 72, 69, 84, 73, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 20, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 83, 79, 77, 32, 83, 79, 77, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 73, 66, 70, 32, 32, 32, 32, 72, 73, 66, 79, 82, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 24, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 208, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 24, 209, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 48, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 48, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 210, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 211, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 212, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 213, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 214, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 52, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 215, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 53, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 216, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 54, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 24, 217, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 55, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 218, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 56, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 56, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 219, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 49, 57, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 49, 57, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 220, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 48, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 7, 12, 24, 221, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 49, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 24, 222, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 50, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 23, 71, 12, 24, 223, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 83, 72, 50, 51, 32, 32, 32, 72, 73, 66, 79, 82, 32, 84, 50, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 70, 32, 32, 32, 32, 68, 74, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 81, 6, 12, 27, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 49, 32, 32, 32, 68, 74, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 50, 32, 32, 32, 68, 74, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 27, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 51, 32, 32, 32, 68, 74, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 27, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 68, 74, 73, 48, 52, 32, 32, 32, 68, 74, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 70, 32, 32, 32, 32, 72, 83, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 34, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 67, 32, 32, 32, 32, 72, 83, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 34, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 80, 32, 32, 32, 32, 72, 83, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 32, 32, 12, 34, 170, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 68, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 68, 68, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 222, 142, 12, 34, 171, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 73, 83, 84, 71, 32, 32, 32, 32, 73, 78, 68, 69, 88, 32, 83, 84, 82, 65, 78, 71, 76, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 49, 32, 32, 32, 72, 83, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 83, 80, 12, 34, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 50, 32, 32, 32, 72, 83, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 51, 32, 32, 32, 72, 83, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 84, 12, 34, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 52, 32, 32, 32, 72, 83, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 34, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 53, 32, 32, 32, 72, 83, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 179, 71, 12, 34, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 54, 32, 32, 32, 72, 83, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 34, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 83, 73, 48, 55, 32, 32, 32, 72, 83, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 49, 32, 12, 34, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 83, 73, 32, 72, 83, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 35, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 67, 32, 32, 32, 32, 88, 72, 83, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 35, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 83, 80, 32, 32, 32, 32, 88, 72, 83, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 88, 72, 72, 83, 32, 32, 32, 32, 88, 72, 72, 32, 83, 80, 79, 84, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 2, 2, 2, 0, 0, 0, 0, 12, 37, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 67, 32, 32, 32, 32, 88, 72, 72, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 37, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 88, 72, 72, 80, 32, 32, 32, 32, 88, 72, 72, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 38, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 70, 32, 32, 32, 32, 72, 72, 73, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 4, 1, 0, 0, 0, 12, 38, 22, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 67, 32, 32, 32, 32, 72, 72, 73, 32, 67, 65, 76, 76, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 0, 0, 12, 38, 23, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 80, 32, 32, 32, 32, 72, 72, 73, 32, 80, 85, 84, 32, 79, 80, 84, 73, 79, 78, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 2, 82, 82, 12, 38, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 49, 32, 32, 32, 72, 72, 73, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 69, 69, 12, 38, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 50, 32, 32, 32, 72, 72, 73, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 51, 32, 32, 32, 72, 72, 73, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 38, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 52, 32, 32, 32, 72, 72, 73, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 53, 32, 32, 32, 72, 72, 73, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 78, 73, 12, 38, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 54, 32, 32, 32, 72, 72, 73, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 38, 207, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 72, 72, 73, 48, 55, 32, 32, 32, 72, 72, 73, 32, 84, 48, 55, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 78, 12, 38, 250, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 84, 77, 67, 95, 72, 72, 73, 32, 72, 72, 73, 32, 84, 77, 67, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 32, 32, 12, 51, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 70, 32, 32, 32, 32, 86, 79, 76, 32, 70, 85, 84, 85, 82, 69, 83, 46, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 32, 32, 12, 51, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 49, 32, 32, 32, 86, 79, 76, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 51, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 86, 79, 76, 48, 50, 32, 32, 32, 86, 79, 76, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 175, 70, 12, 60, 4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 70, 32, 32, 32, 32, 70, 88, 67, 32, 70, 85, 84, 85, 82, 69, 83, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 1, 1, 1, 2, 1, 0, 0, 0, 12, 60, 201, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 49, 32, 32, 32, 70, 88, 67, 32, 84, 48, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 71, 6, 12, 60, 202, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 50, 32, 32, 32, 70, 88, 67, 32, 84, 48, 50, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 203, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 51, 32, 32, 32, 70, 88, 67, 32, 84, 48, 51, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 221, 41, 12, 60, 204, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 52, 32, 32, 32, 70, 88, 67, 32, 84, 48, 52, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 205, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 53, 32, 32, 32, 70, 88, 67, 32, 84, 48, 53, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0, 12, 60, 206, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, 70, 88, 67, 48, 54, 32, 32, 32, 70, 88, 67, 32, 84, 48, 54, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 2, 1, 2, 1, 0, 0, 0, 0] } VS Code version: Code 1.23.1 (, 2018-05-10T16:04:33.747Z) OS version: Linux x64 3.13.0-40-generic <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-markdownlint0.18.0 xml2.2.0 vscode-docker0.0.27 gitignore0.5.0 githistory0.4.1 python2018.4.0 cpptools0.17.4 title0.1.0 vscode-icons7.23.0 bash-debug0.2.0 annotator0.11.0 code-spell-checker1.6.10 mako0.2.0 cmake0.0.17 gitblame2.4.2 vscode-todo-highlight0.5.12 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nFor performance reasons, we skip tokenization for lines that are longer than 20k. It would be good if the user can see a message when that happens.\nI would like to take this one if you guys think this is a but I would need some guidance. I already this: but I'm getting this error , so, I'm not sure how to import correctly into this file in order to use the method. cc:\nThis code runs on the renderer side, while is only for the extension host process. We have to wait for to add his thoughts. There's something similar when we open very large file. Check out the for that.\nis API available only to vscode extensions and should not be used in the UI code. The UI code should use and inject itself with it. A possible fix would be to prompt (as suggested above), but prompt only once. It would be very annoying to prompt 20 times if there are 20 lines over 20.000 chars.\nPR tackles this.\nTo verify, open a file with a very large line. A message should be shown, explaining why the large line is not tokenized.\nI tried on the production app (May 2018 (version 1.24)) and I didn't get the notification, I guess it hasn't been deployed there yet, right? Where should I verify?\nWe would want that someone else than the author of the change would verify that the issue is fixed. So, there's nothing for you to do here, since you are the author. Someone from the vscode team will pick up this issue and verify it. (The change will make it to the stable channel in the following couple of weeks. For now it is available in the insiders channel at )\nVerified !\nHow about using field for this kind of information? Lines that long only occure on minified files or base64 data images which doesn't actually need any syntax highlighting so this notification is completely useless in my opinion. How to get rid of it?", "positive_passages": [{"docid": "doc-en-vscode-764769850aa69115eee77bd22a58d5036b66851c9e5c49f346ab441e5b402b74", "text": "// Do not attempt to tokenize if a line has over 20k if (line.length >= 20000) { <ins> if (!this._tokenizationWarningAlreadyShown) { this._tokenizationWarningAlreadyShown = true; this.notificationService.warn(nls.localize('too many characters', \"Tokenization is skipped for lines longer than 20k characters for performance reasons.\")); } </ins> console.log(`Line (${line.substr(0, 15)}...): longer than 20k characters, tokenization skipped.`); return nullTokenize2(this._languageId, line, state, offsetDelta); }", "commid": "vscode_pr_51265"}], "negative_passages": []}
{"query_id": "q-en-vscode-e0df8542f9d24ab6d9aa48145b5a24211f925f072e586d1767c83ff82921ac2e", "query": "Learnings from NVAccess testing: I'm not sure how to get to the \"details\". Steps: Visual studio code editor. \"Ctrl+Shift+X\" key navigate to the extension side view bar option. Tab key navigate to the \"More\" option and select different options( \"Show installed Extension, Show outdated extension, Show popular Extension,Etc\") an extension and using \"Tab\" and \"Arrow\" keys navigate through the extension details window on the RHS\nWhat do you think of a \"Read more\" button for each item? It will get a little noisy. Any other ideas?\nOr just update the aria label on the extension item with \"Click to read more\" ? Because hitting Enter when the list item has focus, does open the details\ndefinitely prefer making changes on the code side. The label should probably read like \u201cView extension details\u201d so it\u2019s a little more explicit.", "positive_passages": [{"docid": "doc-en-vscode-f1313ea0b14cededd460ea29b8c326b3aa63f503cc1d44000ebd5626b20a3d6c", "text": "'use strict'; <ins> import { localize } from 'vs/nls'; </ins> import { append, $, addClass, removeClass, toggleClass } from 'vs/base/browser/dom'; import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { Action } from 'vs/base/common/actions';", "commid": "vscode_pr_51805"}], "negative_passages": []}
{"query_id": "q-en-vscode-e0df8542f9d24ab6d9aa48145b5a24211f925f072e586d1767c83ff82921ac2e", "query": "Learnings from NVAccess testing: I'm not sure how to get to the \"details\". Steps: Visual studio code editor. \"Ctrl+Shift+X\" key navigate to the extension side view bar option. Tab key navigate to the \"More\" option and select different options( \"Show installed Extension, Show outdated extension, Show popular Extension,Etc\") an extension and using \"Tab\" and \"Arrow\" keys navigate through the extension details window on the RHS\nWhat do you think of a \"Read more\" button for each item? It will get a little noisy. Any other ideas?\nOr just update the aria label on the extension item with \"Click to read more\" ? Because hitting Enter when the list item has focus, does open the details\ndefinitely prefer making changes on the code side. The label should probably read like \u201cView extension details\u201d so it\u2019s a little more explicit.", "positive_passages": [{"docid": "doc-en-vscode-0ad880501c2ec77b34f0737e4a607e43ea01fb43815374d8a2dc57bff75645a1", "text": "private updateRecommendationStatus(extension: IExtension, data: ITemplateData) { const extRecommendations = this.extensionTipsService.getAllRecommendationsWithReason(); <ins> let ariaLabel = extension.displayName + '. '; </ins> if (!extRecommendations[extension.id.toLowerCase()]) { <del> data.root.setAttribute('aria-label', extension.displayName); data.root.title = ''; </del> removeClass(data.root, 'recommended'); <ins> data.root.title = ''; </ins> } else { <del> data.root.setAttribute('aria-label', extension.displayName + '. ' + extRecommendations[extension.id]); data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText; </del> addClass(data.root, 'recommended'); <ins> ariaLabel += extRecommendations[extension.id.toLowerCase()].reasonText + ' '; data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText; </ins> } <ins> ariaLabel += localize('viewExtensionDetailsAria', \"Press enter for extension details.\"); data.root.setAttribute('aria-label', ariaLabel); </ins> } disposeTemplate(data: ITemplateData): void {", "commid": "vscode_pr_51805"}], "negative_passages": []}
{"query_id": "q-en-vscode-71b53177e9d583173d324936726979a363db2c0d35ff5aeb032679aab1a4d4aa", "query": "This feature request is about accessibility. This is only for removing 1 or 2 Breakpoints from a list of, say 30 breakpoints across multiple files in the Breakpoints List. Right now, there is no Close Button in the Breakpoints List when debugging a program in Visual Studio Code. The only way to remove 1 or 2 breakpoints right now is to: on the Breakpoint from the Breakpoints List. the red dot on the line highlighted by VS Code. the Breakpoint is now removed from the Breakpoints List. I would like to request that we can simplify this process by using the middle scroll wheel click on the mouse, so when you click on one of the Breakpoints with the scroll wheel button, it does all of the 3 steps mentioned above. And, it can act as a Remove Single Breakpoint mouse click action. Just like the middle scroll wheel click on tabs to close 1 tab out of many other tabs.\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.647 --- <!-- score: 0.595 --- <!-- score: 0.583 --- <!-- score: 0.563 --- <!-- score: 0.555 --<!-- potentialduplicatescomment --\nyou can already use \"delete\" or \"cmd + backspace\" on the mac to remove the breakpoint. That way you can easily remove multiple. I do not understand what this has to do with accessibility since all these actions are already accessible. A middle click to remove a breakpoint would be consistent with our middle click to remove a tab. Thus I accept prs that fix this Code pointer Simply add a listener in the list for the mouse click, check if it is the middle one and if yes remove the breakpoint. If nobody volunteres I can look into this in the future\nI am not aware of using \"delete\" keypress to remove the breakpoint. How is this triggered? If I press \"delete\", it would remove a character in my source code.\nfocus on the breakpoints view in the debug viewlet F1 Debug: focus breakpoints\nWouldn't it be more user-friendly just to add a close button for breakpoint list item? For example: !\nIt's more about middle scroll wheel click to remove breakpoints, and I think what you pointed out may be a separate issue.\nrelease notes?", "positive_passages": [{"docid": "doc-en-vscode-764caa0285746d0195fed26333dc11d61e2d5606c33535f4127df7cd9de540fc", "text": "this.disposables.push(this.list.onOpen(e => { let isSingleClick = false; let isDoubleClick = false; <ins> let isMiddleClick = false; </ins> let openToSide = false; const browserEvent = e.browserEvent; if (browserEvent instanceof MouseEvent) { isSingleClick = browserEvent.detail === 1; isDoubleClick = browserEvent.detail === 2; <ins> isMiddleClick = browserEvent.button === 1; </ins> openToSide = (browserEvent.ctrlKey || browserEvent.metaKey || browserEvent.altKey); } const focused = this.list.getFocusedElements(); const element = focused.length ? focused[0] : undefined; <ins> if (isMiddleClick) { if (element instanceof Breakpoint) { this.debugService.removeBreakpoints(element.getId()); } else if (element instanceof FunctionBreakpoint) { this.debugService.removeFunctionBreakpoints(element.getId()); } return; } </ins> if (element instanceof Breakpoint) { openBreakpointSource(element, openToSide, isSingleClick, this.debugService, this.editorService).done(undefined, onUnexpectedError); }", "commid": "vscode_pr_56035"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c84edbaeb2e8f321aa4dd6f966cb1a1dd559773fd2f8287ac78d05c6b455595", "query": "Issue Type: <bBug</bThe cursor after pasting, I'd expect it to be at the end of the pasted text: ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-08-02T05:12:16.245Z) OS version: Darwin x64 17.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ 999-pack10.12.6 ssh0.0.4 github-issues-prs0.9.0 vscode-open-in-github1.7.0 </details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-c02a37087df68c390f55a0ebb28ad8e0d72a66ccc963f95c3ea4fb524300fdcd", "text": "this.searchBox.setModel(this.modelService.createModel('', null, uri.parse('extensions:searchinput'), true)); this.disposables.push(this.searchBox.onDidPaste(() => { <del> this.searchBox.setValue(this.searchBox.getValue().replace(/s+/g, ' ')); </del> <ins> let trimmed = this.searchBox.getValue().replace(/s+/g, ' '); this.searchBox.setValue(trimmed); </ins> this.searchBox.setScrollTop(0); <ins> this.searchBox.setPosition(new Position(1, trimmed.length + 1)); </ins> })); this.disposables.push(this.searchBox.onDidFocusEditorText(() => addClass(this.monacoStyleContainer, 'synthetic-focus'))); this.disposables.push(this.searchBox.onDidBlurEditorText(() => removeClass(this.monacoStyleContainer, 'synthetic-focus')));", "commid": "vscode_pr_55689"}], "negative_passages": []}
{"query_id": "q-en-vscode-cee7451470a934bcb43da11082f2371d0080b61906cd62e93b7db20ce852d903", "query": "I would like to make a pull request that changes the markdown snippet for links to use HTTPS instead of HTTP. Microsoft seems to encourage HTTPS by default in the latest .NET Core & browsers are also encouraging it. To me HTTPS sites seem to be the default for most websites these days.\nSure, please open a pr. I didn't even know we had a snippet for links :)\nFixed by", "positive_passages": [{"docid": "doc-en-vscode-26e1a291a6aa7ab76b45ceefe06221c6a00170613d0c065ed4bd0a54a7564aab", "text": "}, \"Insert link\": { \"prefix\": \"link\", <del> \"body\": \"[${1:text}](http://${2:link})$0\", </del> <ins> \"body\": \"[${1:text}](https://${2:link})$0\", </ins> \"description\": \"Insert link\" }, \"Insert image\": { \"prefix\": \"image\", <del> \"body\": \"![${1:alt}](http://${2:link})$0\", </del> <ins> \"body\": \"![${1:alt}](https://${2:link})$0\", </ins> \"description\": \"Insert image\" } }", "commid": "vscode_pr_56851"}], "negative_passages": []}
{"query_id": "q-en-vscode-5807bc0c8996c95adb7af39dd65fe648fe7d1807d6ca8c55c949414fa38e561d", "query": "Issue Type: <bBug</bI use oh-my-zsh and set integrated terminal /bin/zsh cmd+, to show settings tab terminal(ctrl+shift+`) settings terminal integrated: Font size option. say we have default value 12. . now value is 1 and terminal gets so small 1 so now value is 11. and terminal is gone. expected to see current terminal cursor. i type lots of enters or ctrl+c, then I can see my terminal again. i saw my terminal again, it looks like change font size 11 -1 -12 doesn't make terminal to disappear. VS Code version: Code 1.27.1 (, 2018-09-06T09:14:32.385Z) OS version: Darwin x64 17.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ gitlens8.5.6 code-runner0.9.4 beautify1.4.2 Go0.6.89 vetur0.12.6 vscode-docker0.2.0 java0.30.0 </details<!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.481 --- <!-- score: 0.459 --<!-- potentialduplicatescomment --\nalso vertical scroll of terminal get somewhat screwed even after I see my terminal again by typing enter or ctrl+c\nthis seems to be related to the usage of from xterm: a similar problem with an explanation of a solution can be found here: In short, after the fontSize changes, the terminal renders before the xterm field is updated, so the render uses previous values (corresponding to the previous font size values) Related: ,\ncan some settings only commit the change on blur?\nIf is an invalid font size for that setting, can the terminal ignore it or set a minimum in the setting schema?\nafter thinking about this some more I think this is totally on my end as something weird happens when changing the setting frequently. There is already a minimum value which is why VS Code doesn't crash", "positive_passages": [{"docid": "doc-en-vscode-7baa9d20657a36929b31b039d3a6ef0d7620b9da98f39a99133e13bacbb42e72", "text": "this.addDisposable(this._configurationService.onDidChangeConfiguration(e => { if (e.affectsConfiguration('terminal.integrated')) { this.updateConfig(); <ins> // HACK: Trigger another async layout to ensure xterm's CharMeasure is ready to use, // this hack can be removed when https://github.com/xtermjs/xterm.js/issues/702 is // supported. this.setVisible(this._isVisible); </ins> } if (e.affectsConfiguration('editor.accessibilitySupport')) { this.updateAccessibilitySupport();", "commid": "vscode_pr_60221"}], "negative_passages": []}
{"query_id": "q-en-vscode-98970aca17f80031b7af5038e4ac8ddf64e231e1e93732c0fc47c9a6ef1c48e4", "query": "Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !", "positive_passages": [{"docid": "doc-en-vscode-7ef5cf283b3a7224de0c1b068f8676b46c0b83395b30c4a7771ca4c90e0a5c35", "text": "VERTICAL_REVERSE, } <ins> export interface ActionTrigger { keys: KeyCode[]; keyDown: boolean; } </ins> export interface IActionItemProvider { (action: IAction): IActionItem; }", "commid": "vscode_pr_60000"}], "negative_passages": []}
{"query_id": "q-en-vscode-98970aca17f80031b7af5038e4ac8ddf64e231e1e93732c0fc47c9a6ef1c48e4", "query": "Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !", "positive_passages": [{"docid": "doc-en-vscode-02c5651e799987389dff0afedfbc1fd27126551c8aab3c7e0193cd39dc920db4", "text": "actionRunner?: IActionRunner; ariaLabel?: string; animated?: boolean; <ins> triggerKeys?: ActionTrigger; </ins> } let defaultOptions: IActionBarOptions = { orientation: ActionsOrientation.HORIZONTAL, <del> context: null </del> <ins> context: null, triggerKeys: { keys: [KeyCode.Enter, KeyCode.Space], keyDown: false } </ins> }; export interface IActionOptions extends IActionItemOptions {", "commid": "vscode_pr_60000"}], "negative_passages": []}
{"query_id": "q-en-vscode-98970aca17f80031b7af5038e4ac8ddf64e231e1e93732c0fc47c9a6ef1c48e4", "query": "Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !", "positive_passages": [{"docid": "doc-en-vscode-da2f1c12f991c2821cd88f3ea1df1250633e86cecf3e392c2589c02169db44bd", "text": "this.focusNext(); } else if (event.equals(KeyCode.Escape)) { this.cancel(); <del> } else if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) { // Nothing, just staying out of the else branch </del> <ins> } else if (this.isTriggerKeyEvent(event)) { // Staying out of the else branch even if not triggered if (this.options.triggerKeys && this.options.triggerKeys.keyDown) { this.doTrigger(event); } </ins> } else { eventHandled = false; }", "commid": "vscode_pr_60000"}], "negative_passages": []}
{"query_id": "q-en-vscode-98970aca17f80031b7af5038e4ac8ddf64e231e1e93732c0fc47c9a6ef1c48e4", "query": "Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !", "positive_passages": [{"docid": "doc-en-vscode-6215aaf07af086ff1b4f11ba8d68d2b10e3213a3f941c939ee3089160975727f", "text": "let event = new StandardKeyboardEvent(e as KeyboardEvent); // Run action on Enter/Space <del> if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) { this.doTrigger(event); </del> <ins> if (this.isTriggerKeyEvent(event)) { if (!this.options.triggerKeys.keyDown) { this.doTrigger(event); } </ins> event.preventDefault(); event.stopPropagation(); }", "commid": "vscode_pr_60000"}], "negative_passages": []}
{"query_id": "q-en-vscode-98970aca17f80031b7af5038e4ac8ddf64e231e1e93732c0fc47c9a6ef1c48e4", "query": "Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !", "positive_passages": [{"docid": "doc-en-vscode-c2245f9a58d2bfa351624382b06a90a1281de2e9042eea01f72941e2d25175ea", "text": "} } <ins> private isTriggerKeyEvent(event: StandardKeyboardEvent): boolean { let ret = false; if (this.options.triggerKeys) { this.options.triggerKeys.keys.forEach(keyCode => { ret = ret || event.equals(keyCode); }); } return ret; } </ins> private updateFocusedItem(): void { for (let i = 0; i < this.actionsList.children.length; i++) { let elem = this.actionsList.children[i];", "commid": "vscode_pr_60000"}], "negative_passages": []}
{"query_id": "q-en-vscode-98970aca17f80031b7af5038e4ac8ddf64e231e1e93732c0fc47c9a6ef1c48e4", "query": "Repro: Add keybinding: Find a quick fix, and hit alt+enter quickly. The first action is triggered. I was seeing this here (notice Promise not TPromise): !", "positive_passages": [{"docid": "doc-en-vscode-ad17396b8817d3e9c5ec7f2e0690be3a1afb9425a8aa03367108f7cdbe05b4b9", "text": "actionItemProvider: action => this.doGetActionItem(action, options, parentData), context: options.context, actionRunner: options.actionRunner, <del> ariaLabel: options.ariaLabel </del> <ins> ariaLabel: options.ariaLabel, triggerKeys: { keys: [KeyCode.Enter], keyDown: true } </ins> }); this.actionsList.setAttribute('role', 'menu');", "commid": "vscode_pr_60000"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb71d82ccdf1ca5dc5552812ddc6ee06d49d24c9f17340bfad7656fa4d7354c6", "query": "Env: In Insider version, the API doesn't respect the option. The same code works in the normal vscode 1.28.2.\nThe code here converts the filters from the extension API into the electron API, but the function is supplied with the electron API format so this is not necessary and is causing the break.\nI think this is something that we should ship with 1.29\nWe believe this is a regression, adding candidate label", "positive_passages": [{"docid": "doc-en-vscode-a0b1291b3a287ba7ec8ddeae4300679e9890f2b50b1bf71e59c1ffcb45054d80", "text": "if (defaultUri && defaultUri.scheme !== Schemas.file) { return Promise.reject(new Error('Not supported - Open-dialogs can only be opened on `file`-uris.')); } <del> const filters = []; if (options.filters) { for (let name in options.filters) { filters.push({ name, extensions: options.filters[name] }); } } </del> const newOptions: OpenDialogOptions = { title: options.title, defaultPath: defaultUri && defaultUri.fsPath, buttonLabel: options.openLabel, <del> filters, </del> <ins> filters: options.filters, </ins> properties: [] }; newOptions.properties.push('createDirectory');", "commid": "vscode_pr_62505"}], "negative_passages": []}
{"query_id": "q-en-vscode-a46fe737b4008f322fbf4743dea0b270cd7a557c6c5f346f3fc3a1c59a7f6373", "query": "<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.2 OS Version: Microsoft Windows 10 Pro, 10.0. Build Steps to Reproduce (2 problems): a source code file over an IPv6 URL and notice the faulty incomplete underline: ! Click the link: the default browser opens without accessing the URL <!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.463 --<!-- potentialduplicatescomment --", "positive_passages": [{"docid": "doc-en-vscode-be19ac4520561100f1f70e09e28c2063eb847a0b182959aef1f9f31e3989099f", "text": "resetStateMachine = true; } } else if (state === State.End) { <del> const chClass = classifier.get(chCode); </del> <ins> let chClass: CharacterClass; if (chCode === CharCode.OpenSquareBracket) { // Allow for the authority part to contain ipv6 addresses which contain [ and ] hasOpenSquareBracket = true; chClass = CharacterClass.None; } else { chClass = classifier.get(chCode); } </ins> // Check if character terminates link if (chClass === CharacterClass.ForceTermination) {", "commid": "vscode_pr_62293"}], "negative_passages": []}
{"query_id": "q-en-vscode-a46fe737b4008f322fbf4743dea0b270cd7a557c6c5f346f3fc3a1c59a7f6373", "query": "<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.2 OS Version: Microsoft Windows 10 Pro, 10.0. Build Steps to Reproduce (2 problems): a source code file over an IPv6 URL and notice the faulty incomplete underline: ! Click the link: the default browser opens without accessing the URL <!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.463 --<!-- potentialduplicatescomment --", "positive_passages": [{"docid": "doc-en-vscode-770ec0923009de630e3460741c8623055b83ef402dc7c0781df2920c020319ab", "text": "'                                                                                                                                                 https://msdn.microsoft.com/en-us/library/windows/desktop/ms687414(v=vs.85).aspx                                  ' ); }); <ins> test('issue #62278: \"Ctrl + click to follow link\" for IPv6 URLs', () => { assertLink( 'let x = \"http://[::1]:5000/connect/token\"', '         http://[::1]:5000/connect/token  ' ); }); </ins> });", "commid": "vscode_pr_62293"}], "negative_passages": []}
{"query_id": "q-en-vscode-984cd81dac3a391b79e42311d01dbf23bf6e3cf7ef50bf89a82f4387da913ce5", "query": "macOS run in fullscreen mode open the process explorer the prices explorer window also opens in fullscreen mode...\nHi Gonna take a look at this. It seems to be happening for 'Report issue' also.\nHi Can I help you somehow to get this merged?\nYep! Sorry for the delay, your change looks good. I'll merge it now. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-dca0a1c69d781293123634aec1c6c81aeae386d0f6868d854f1af999533416b6", "text": "const position = this.getWindowPosition(this._issueParentWindow, 700, 800); this._issueWindow = new BrowserWindow({ <ins> fullscreen: false, </ins> width: position.width, height: position.height, minWidth: 300,", "commid": "vscode_pr_64839"}], "negative_passages": []}
{"query_id": "q-en-vscode-984cd81dac3a391b79e42311d01dbf23bf6e3cf7ef50bf89a82f4387da913ce5", "query": "macOS run in fullscreen mode open the process explorer the prices explorer window also opens in fullscreen mode...\nHi Gonna take a look at this. It seems to be happening for 'Report issue' also.\nHi Can I help you somehow to get this merged?\nYep! Sorry for the delay, your change looks good. I'll merge it now. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-caa0a187ea446679bdf96cc6ec03c9d2c20b48b56182ef02d8de080ca7fc6239", "text": "this._processExplorerWindow = new BrowserWindow({ skipTaskbar: true, resizable: true, <ins> fullscreen: false, </ins> width: position.width, height: position.height, minWidth: 300,", "commid": "vscode_pr_64839"}], "negative_passages": []}
{"query_id": "q-en-vscode-c7f6c717d4c04a79b6b415e0dcba2d1eefb102b447e1f0486991d1fddf2b7377", "query": "Set color customizations for the peek widget: 29: ! 30: ! Candidate or 1.30.1 maybe?\nGrrr, another regression... I am for putting this into 1.30.1\nI have pushed a fix to master and I have created we think having for for is good enough, otherwise the PR can be merged for", "positive_passages": [{"docid": "doc-en-vscode-d1d5193a92b747ef6e13b42d599af0a1addf5253730e5190d91e5accb0ae791c", "text": "} const resultsSelectedBackground = theme.getColor(peekViewResultsSelectionBackground); if (resultsSelectedBackground) { <del> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-tree.focused .monaco-tree-rows > .monaco-tree-row.selected:not(.highlighted) { background-color: ${resultsSelectedBackground}; }`); </del> <ins> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-list:focus .monaco-list-rows > .monaco-list-row.selected:not(.highlighted) { background-color: ${resultsSelectedBackground}; }`); </ins> } const resultsSelectedForeground = theme.getColor(peekViewResultsSelectionForeground); if (resultsSelectedForeground) { <del> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-tree.focused .monaco-tree-rows > .monaco-tree-row.selected:not(.highlighted) { color: ${resultsSelectedForeground} !important; }`); </del> <ins> collector.addRule(`.monaco-editor .reference-zone-widget .ref-tree .monaco-list:focus .monaco-list-rows > .monaco-list-row.selected:not(.highlighted) { color: ${resultsSelectedForeground} !important; }`); </ins> } const editorBackground = theme.getColor(peekViewEditorBackground); if (editorBackground) {", "commid": "vscode_pr_64880"}], "negative_passages": []}
{"query_id": "q-en-vscode-7faf64986485648d6d9a0039632745086c443495c2ac63b1afbd603a4106a61c", "query": "While creating a user snippet, the rule must be like this: If I want to show a lot of description, I must write a huge string which includes many escape characters like this: It maybe a good idea that option receive a list value, like the :\nThe Version infomations: Code Version: 1.30.1 (user setup) Commit: Date: 2018-12-18T18:12:07.165Z Electron: 2.0.12 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 OS: Windows_NT x64 10.0.\nCan you guide me on resolving this issue?\nsure, checkout , and", "positive_passages": [{"docid": "doc-en-vscode-0899bf3d58fb921563e51ea8f851eead62b15b6a6ee0e2c0217511a7fa27d415", "text": "}, description: { description: nls.localize('snippetSchema.json.description', 'The snippet description.'), <del> type: 'string' </del> <ins> type: ['string', 'array'] </ins> } }, additionalProperties: false", "commid": "vscode_pr_66159"}], "negative_passages": []}
{"query_id": "q-en-vscode-7faf64986485648d6d9a0039632745086c443495c2ac63b1afbd603a4106a61c", "query": "While creating a user snippet, the rule must be like this: If I want to show a lot of description, I must write a huge string which includes many escape characters like this: It maybe a good idea that option receive a list value, like the :\nThe Version infomations: Code Version: 1.30.1 (user setup) Commit: Date: 2018-12-18T18:12:07.165Z Electron: 2.0.12 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 OS: Windows_NT x64 10.0.\nCan you guide me on resolving this issue?\nsure, checkout , and", "positive_passages": [{"docid": "doc-en-vscode-f1639527387815ddbe70a6aeaf188c2cb75d71df88432e40ad193e1e46cab0fa", "text": "body = body.join('n'); } <ins> if (Array.isArray(description)) { description = description.join('n'); } </ins> if ((typeof prefix !== 'string' && !Array.isArray(prefix)) || typeof body !== 'string') { return; }", "commid": "vscode_pr_66159"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f202a480169a94a44169c515a2d7247ae1332c0a8761aff1cf73f20c612f77a", "query": "Ability to update built in extensions\nThis is a pre-request to enable built-in extension to on-board to\nDisabled updating builtin extensions in stable", "positive_passages": [{"docid": "doc-en-vscode-cbae5aadf2e9e4f411f889fb0114d1cb4fae30abafdc31972095b87e11af57c0", "text": "return; } <del> if (this.extension.type !== ExtensionType.User) { this.enabled = false; this.class = UpdateAction.DisabledClass; this.label = this.getLabel(); return; } </del> const canInstall = await this.extensionsWorkbenchService.canInstall(this.extension); const isInstalled = this.extension.state === ExtensionState.Installed;", "commid": "vscode_pr_145244"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f202a480169a94a44169c515a2d7247ae1332c0a8761aff1cf73f20c612f77a", "query": "Ability to update built in extensions\nThis is a pre-request to enable built-in extension to on-board to\nDisabled updating builtin extensions in stable", "positive_passages": [{"docid": "doc-en-vscode-9fa0b9ea54a91ae9e587dfc5f2bcfb70b69e0273ad13695b179e5160efb0fa0f", "text": "import { IExtensionManifestPropertiesService } from 'vs/workbench/services/extensions/common/extensionManifestPropertiesService'; import { IExtensionService, IExtensionsStatus } from 'vs/workbench/services/extensions/common/extensions'; import { ExtensionEditor } from 'vs/workbench/contrib/extensions/browser/extensionEditor'; <ins> import { isWeb } from 'vs/base/common/platform'; </ins> interface IExtensionStateProvider<T> { (extension: Extension): T;", "commid": "vscode_pr_145244"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f202a480169a94a44169c515a2d7247ae1332c0a8761aff1cf73f20c612f77a", "query": "Ability to update built in extensions\nThis is a pre-request to enable built-in extension to on-board to\nDisabled updating builtin extensions in stable", "positive_passages": [{"docid": "doc-en-vscode-82249f36c806d5dafcb3103741e2400f06ac680ac4635c2bdd4e6f77a9c70283", "text": "if (!this.gallery || !this.local) { return false; } <del> if (this.type !== ExtensionType.User) { return false; } </del> if (!this.local.preRelease && this.gallery.properties.isPreReleaseVersion) { return false; }", "commid": "vscode_pr_145244"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f202a480169a94a44169c515a2d7247ae1332c0a8761aff1cf73f20c612f77a", "query": "Ability to update built in extensions\nThis is a pre-request to enable built-in extension to on-board to\nDisabled updating builtin extensions in stable", "positive_passages": [{"docid": "doc-en-vscode-7eed5698cde866440d8d4fea0804bb4444c7b6679b28a41b881e0c4e486c48a2", "text": "this.queryLocal().then(() => { this.resetIgnoreAutoUpdateExtensions(); this.eventuallyCheckForUpdates(true); <del> // Always auto update builtin extensions if (!this.isAutoUpdateEnabled()) { </del> <ins> // Always auto update builtin extensions in web if (isWeb && !this.isAutoUpdateEnabled()) { </ins> this.autoUpdateBuiltinExtensions(); } });", "commid": "vscode_pr_145244"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f202a480169a94a44169c515a2d7247ae1332c0a8761aff1cf73f20c612f77a", "query": "Ability to update built in extensions\nThis is a pre-request to enable built-in extension to on-board to\nDisabled updating builtin extensions in stable", "positive_passages": [{"docid": "doc-en-vscode-78a70cb4e793974432ddb6fd1ea5107e7ad7f4d1654c1746d8dcd6eedfcba9d9", "text": "} const infos: IExtensionInfo[] = []; for (const installed of this.local) { <del> if (installed.type === ExtensionType.User && (!onlyBuiltin || installed.isBuiltin)) { </del> <ins> if (!onlyBuiltin || installed.isBuiltin) { </ins> infos.push({ ...installed.identifier, preRelease: !!installed.local?.preRelease }); } }", "commid": "vscode_pr_145244"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f202a480169a94a44169c515a2d7247ae1332c0a8761aff1cf73f20c612f77a", "query": "Ability to update built in extensions\nThis is a pre-request to enable built-in extension to on-board to\nDisabled updating builtin extensions in stable", "positive_passages": [{"docid": "doc-en-vscode-4aef2dd6c63897d3ce1010ddbce4ca0e2c6d416b611a67aeb44f238c94b45f65", "text": "assert.strictEqual(extension.outdated, true); }); <del> test('extension is not outdated when local is built in and older than gallery', () => { </del> <ins> test('extension is outdated when local is built in and older than gallery', () => { </ins> const extension = instantiationService.createInstance(Extension, () => ExtensionState.Installed, undefined, aLocalExtension('somext', { version: '1.0.0' }, { type: ExtensionType.System }), aGalleryExtension('somext', { version: '1.0.1' })); <del> assert.strictEqual(extension.outdated, false); </del> <ins> assert.strictEqual(extension.outdated, true); </ins> }); test('extension is outdated when local and gallery are on same version but on different target platforms', () => {", "commid": "vscode_pr_145244"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6c82a40ac80128c6037465fe145129c099abcf30908bed0cf043b53057c1597", "query": "1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the \u00b4Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for\nWould be fixed by .", "positive_passages": [{"docid": "doc-en-vscode-9c24af11d4e54a8769140cfb67a27db6519bc135dd8ef7ee09871553d591d4bc", "text": "}); test('findFiles', () => { <del> return vscode.workspace.findFiles('*.png').then((res) => { </del> <ins> return vscode.workspace.findFiles('**/*.png').then((res) => { assert.equal(res.length, 2); assert.equal(basename(vscode.workspace.asRelativePath(res[0])), 'image.png'); }); }); test('findFiles, exclude', () => { return vscode.workspace.findFiles('**/*.png', '**/sub/**').then((res) => { </ins> assert.equal(res.length, 1); assert.equal(basename(vscode.workspace.asRelativePath(res[0])), 'image.png'); });", "commid": "vscode_pr_69864"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6c82a40ac80128c6037465fe145129c099abcf30908bed0cf043b53057c1597", "query": "1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the \u00b4Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for\nWould be fixed by .", "positive_passages": [{"docid": "doc-en-vscode-4135e97c8c0b973099dd71be567b19861da3bcf5d1e1565f5ea07da5f6c313a4", "text": "disregardSearchExcludeSettings: true, disregardIgnoreFiles: true, includePattern, <ins> excludePattern: typeof excludePatternOrDisregardExcludes === 'string' ? excludePatternOrDisregardExcludes : undefined, </ins> _reason: 'startFileSearch' });", "commid": "vscode_pr_69864"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6c82a40ac80128c6037465fe145129c099abcf30908bed0cf043b53057c1597", "query": "1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the \u00b4Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for\nWould be fixed by .", "positive_passages": [{"docid": "doc-en-vscode-a7f0fd706fdb7565168e781921a0e01032d82d2a0fa88d881c72f199d11d65d9", "text": "const query = queryBuilder.file(folders, { _reason: 'checkExists', includePattern: includes.join(', '), <ins> expandPatterns: true, </ins> exists: true });", "commid": "vscode_pr_69864"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6c82a40ac80128c6037465fe145129c099abcf30908bed0cf043b53057c1597", "query": "1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the \u00b4Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for\nWould be fixed by .", "positive_passages": [{"docid": "doc-en-vscode-3e712722307f044cd19c31e95eaa2b4a2aa4b70e31b121e7237f4a21c01b7e0a", "text": "if (options.includePattern) { includeSearchPathsInfo = options.expandPatterns ? this.parseSearchPaths(options.includePattern) : <del> { pattern: patternListToIExpression(...splitGlobPattern(options.includePattern)) }; </del> <ins> { pattern: patternListToIExpression(options.includePattern) }; </ins> } let excludeSearchPathsInfo: ISearchPathsInfo = {}; if (options.excludePattern) { excludeSearchPathsInfo = options.expandPatterns ? this.parseSearchPaths(options.excludePattern) : <del> { pattern: patternListToIExpression(...splitGlobPattern(options.excludePattern)) }; </del> <ins> { pattern: patternListToIExpression(options.excludePattern) }; </ins> } // Build folderQueries from searchPaths, if given, otherwise folderResources", "commid": "vscode_pr_69864"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6c82a40ac80128c6037465fe145129c099abcf30908bed0cf043b53057c1597", "query": "1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the \u00b4Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for\nWould be fixed by .", "positive_passages": [{"docid": "doc-en-vscode-dd6dded117e49a15258ac3dd7b37a4e68c4871d7ed3e9d611de4d7ca42a0ac17", "text": "}); }); <del> test('splits glob pattern even with expandPatterns disabled', () => { </del> <ins> test('does not split glob pattern when expandPatterns disabled', () => { </ins> assertEqualQueries( queryBuilder.file([ROOT_1_URI], { includePattern: '**/foo, **/bar' }), {", "commid": "vscode_pr_69864"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6c82a40ac80128c6037465fe145129c099abcf30908bed0cf043b53057c1597", "query": "1) use yo code to create an extension 2) Replace the with the code below 4) Press F5 to run the workspace 5) Open a project for a node module that has a nodemodules folder with many modules. 6) Execute the \u00b4Hello World' command --the call workspace.findFiles returns file matches from the folder, but the nodemodules folder is excluded. Running the same extension in stable properly excludes matches in the folder. Tagging as a candiate for February since the change of behavour impacts NPM script running and now proposes scripts from the node_modules. The code for\nWould be fixed by .", "positive_passages": [{"docid": "doc-en-vscode-8f4d1e744073db9eed3306c3044ef0ea4d0f4dfc743edf75734678d45b48a7db", "text": "}], type: QueryType.File, includePattern: { <del> '**/foo': true, '**/bar': true </del> <ins> '**/foo, **/bar': true </ins> } }); });", "commid": "vscode_pr_69864"}], "negative_passages": []}
{"query_id": "q-en-vscode-a9bc22c02632ac9fec4ae46d644c23321bdfb643cb7facec00348f14c17a160c", "query": "Open a folder Create untitled file with some content Quit vscode Open vscode Two windows are opened, one has the folder +untitled file, other is an empty window + untitled file. So the same untitled file is opened in two windows.\nI could only repro this with an empty window: Code via finder all files/folders an untitled file, add changes +q Code via finder <img width=\"490\" alt=\"screen shot 2019-03-07 at 5 42 14 pm\" src=\"https://user-\"\nMoving this to as the last who touched this code.\nfor some reason the  array has multiple entries for the same window?\nTemporally until update is not yet, for prevent backup window add to settings \"window.restoreWindows\": \"none\"\nWhen set , then every close & start VSCode will multiple windows (1 -2, 2 -4, 4 -6, and so on). Fix is needed ASAP.\nthis change is not in the recovery build yet pending right?\nPushed.\nI saw this by downgrading from 1.32.2 to 1.31.1, then upgrading back. But I don't think we care about that.\nI can confirm that this issue is fixed in the latest 1.32.2 release! Thanks! But another one what I noticed: VS Code one existing document Optional: Open a new tab or new window with a new tab and type anything and do NOT save this new file VS Code -Open VS Code Now all tabs are correctly restored! VS Code a File from Windows Explorer with right-click and open in VS Code All tabs should re-opened (Tabs/files from Step 2., 3. and 7.) Only the unsaved file from step 3. and the one from the Windows Explorer, step 7. are opened. And the last session (int this example, file from step 1. is lost! Is this wanted or can this be configured?\nConfirm fix and also above bug with 1.32.2 and 1.32.3. Could You report this as new issue? Now session is partially broken :-(\nthanks. Please see", "positive_passages": [{"docid": "doc-en-vscode-a92e352276b7e47b4f671d7b3e2af9f9f2c38d53aae848376187fab7c2d1b26a", "text": "} // Handle empty to restore <del> if (emptyToRestore.length > 0) { emptyToRestore.forEach(emptyWindowBackupInfo => { </del> <ins> const allEmptyToRestore = arrays.distinct(emptyToRestore, info => info.backupFolder); // prevent duplicates if (allEmptyToRestore.length > 0) { allEmptyToRestore.forEach(emptyWindowBackupInfo => { </ins> const remoteAuthority = emptyWindowBackupInfo.remoteAuthority; const fileInputsForWindow = (fileInputs && fileInputs.remoteAuthority === remoteAuthority) ? fileInputs : undefined;", "commid": "vscode_pr_70179"}], "negative_passages": []}
{"query_id": "q-en-vscode-2ea5245f7f128551d9d321749c985ffdd7866c58d0590bf479b83fb7076a70ad", "query": "Issue Type: <bFeature Request</bHere's what I have tried using as a reference: In the settings page, \"command\" doesn't show up as a link, just plain text. It would be nice if command links were supported like regular URL links. VS Code version: Code 1.32.3 (, 2019-03-14T22:46:48.547Z) OS version: Darwin x64 18.2.0\nI assume you want this in the settings UI.\nThat's correct. A clickable command link above the field.\nSure, out of curiosity, what sort of command would you use this for?\nThe property/setting I'm trying to use this for is a directory path containing some directories. And the command is a refresh command that will pick up the latest setting value and do some parsing of the contained directories. I know I could use to detect changes and trigger the command automatically but I want to allow the user to refresh manually.\nAre you avoiding because it might trigger while the user is not done typing, or is there a different reason?\nYes, that's the main reason.\nI would like to second this. My use case is: My extension involves authenticating with a server, and I have built a web-view for this. This authentication process is too complicated to handle through native VSCode settings (I want to validate the server, there might be 2FA, etc, etc) However, since users have an expectation of seeing their settings in the settings UI, I would like to display the server that the user has authenticated to in the settings UI as a read only property. This requires me to have a description which says \"You can modify this value by doing X\" And overall, it seems like a better user experience to have that description be \"you can modify this by clicking \" and having open my webview, rather than: \"you can modify this setting by selecting the X command in the command palette\"", "positive_passages": [{"docid": "doc-en-vscode-f607ed00302756433d6166dc32d24e15d050de26ed25cc9bd73c82b58b3058d6", "text": "// Rewrite `#editor.fontSize#` to link format text = fixSettingLinks(text); <del> const renderedMarkdown = renderMarkdown({ value: text }, { </del> <ins> const renderedMarkdown = renderMarkdown({ value: text, isTrusted: true }, { </ins> actionHandler: { callback: (content: string) => { if (startsWith(content, '#')) {", "commid": "vscode_pr_100304"}], "negative_passages": []}
{"query_id": "q-en-vscode-e719d7af96ec0d5310dd9fb7e82bd7c8f45aaf1e4fc5f4c542a75178c1728473", "query": "Maybe you've already thought about this but it would be useful to be able to create a new folder in the simplified file dialog. This could be a button in the title bar or a confirmation step when a folder that doesn't exist was typed. Creating a folder and opening it, and creating a folder and saving a file in it, are common workflows so it would be useful to be able to do those in one step.\nFor the meantime:\nHey thanks for the mention! This was a feature I personally needed for quite some time - we all basically do those steps mentioned by on a daily basis so I decided to code an extension for it. Even though the extension already works great, I am actually working on it right now and adding a new feature which will allow it to create new folders using the Simple file dialogs - regardless of user setting, see . If anyone's interested, I think I'll manage to finish it by tomorrow.\nI've been busy with work and other projects but after a long wait, I worked really hard and managed to finish my npm module for Visual Studio Code that implements the aforementioned behavior and shows a custom QuickPick that allows browsing and creating folders from the Command Palette, even nested/recursive folders. The extension that implements this package is available at repo. Not perfect (yet) but it works.\nAlso create new file in Open File dialog would be useful.\nSaving is good. Opening hasn't been implemented -- should there be a new issue for that?", "positive_passages": [{"docid": "doc-en-vscode-10e61334f47c316936c289d65970c930742b625736de003d6791350e3ff1e47d", "text": "// Filename not allowed this.filePickBox.validationMessage = nls.localize('remoteFileDialog.validateBadFilename', 'Please enter a valid file name.'); return Promise.resolve(false); <del> } else if (!statDirname || !statDirname.isDirectory) { </del> <ins> } else if (!statDirname) { </ins> // Folder to save in doesn't exist <ins> const message = nls.localize('remoteFileDialog.validateCreateDirectory', 'The folder {0} does not exist. Would you like to create it?', resources.basename(resources.dirname(uri))); return this.yesNoPrompt(uri, message); } else if (!statDirname.isDirectory) { </ins> this.filePickBox.validationMessage = nls.localize('remoteFileDialog.validateNonexistentDir', 'Please enter a path that exists.'); return Promise.resolve(false); }", "commid": "vscode_pr_152536"}], "negative_passages": []}
{"query_id": "q-en-vscode-bf2dc64c1fb69862e064c402aa4e9cb579e1e7e28b996f51407120f6d2923530", "query": "When picking a Formatter to run for a file type, it'd be nice to see what extension is providing each formatter. This can make it easier to choose which formatter I want to use, or to open an issue to request that the extension use a more obvious name for their formatter :) (in this case, the Ruby extension accidentally provides the legacy formatter as well as the \"current\" formatter at the same time). When in a situation like this, I'm not sure which to choose: <img width=\"621\" alt=\"Screen Shot 2019-04-07 at 6 20 49 PM\" src=\"https://user-\"Maybe have the extension name de-emphasized like the \"Configured Tab Size\" text in the indentation dropdown?: <img width=\"615\" alt=\"Screen Shot 2019-04-07 at 8 29 28 PM\" src=\"https://user-\"\nWe use the 'displayName' or 'name' (when not having the former) but it seems that there are multiple extensions with the same name... We should be more precise in that case.", "positive_passages": [{"docid": "doc-en-vscode-c4c497b43fe5a5a0356f489033331c9753beabdd51f0690bd7d2d99ae105cd2c", "text": "const picks = formatter.map((formatter, index) => { return <IIndexedPick>{ index, <del> label: formatter.displayName || formatter.extensionId || '?' </del> <ins> label: formatter.displayName || formatter.extensionId || '?', description: formatter.extensionId && formatter.extensionId.value </ins> }; }); const langName = this._modeService.getLanguageName(document.getModeId()) || document.getModeId();", "commid": "vscode_pr_71910"}], "negative_passages": []}
{"query_id": "q-en-vscode-94ff3f958f41c70833a1c5cfd665b2bee74f62456e2105d8f440803b4f9ddd8f", "query": "Description Currently, when editing a file, the command <kbdctrl</kbd+<kbdshift</kbd+<kbda</kbd(toggle block comment) generates the following comment placeholder . I wonder if it might be also wise to include this as an auto-closing pair so that when users attempt to write the closing is automatically like other languages (ex: Typescript).\nThis issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the for VS Code. See also our guidelines. Happy Coding!\nI'm not quite sure as to who or where the owner is for the extension. Looking at the I noticed multiple past updates to support additional features. Isn't the proposed feature request present in the issue similar to those past updates?\nOh, you are right. This part is us, not the extension. Sorry for the confusion...\nLooks like a good change to me. Feel free to make a pull request.\nNot able to reproduce ctrl+shift+a not having any effect.\nI assume you are editing a file, but sorry the keybinding I mentioned is for Linux, on macOS for example the keybinding is . The easiest way to test is to simply run the command from the menu \ud83e\udc52 :)\nGot it, in windows it is Shift+Alt+A.\nI forgot to mention I won't be able to submit a PR myself due to my company policy. If anyone would like to take on the issue, please feel free to do so :)\nIn that case, I am more than happy to make a pull request for this. Thanks for the information. I will submit one soon.\nthank you!", "positive_passages": [{"docid": "doc-en-vscode-bb64e6cf816ba0b76ebc76ab53314c645741454e1729101807527dae11cacda1", "text": "{ \"open\": \"{\", \"close\": \"}\" }, { \"open\": \"(\", \"close\": \")\" }, { \"open\": \"'\", \"close\": \"'\", \"notIn\": [\"string\", \"comment\"] }, <del> { \"open\": \"\"\", \"close\": \"\"\", \"notIn\": [\"string\"] } </del> <ins> { \"open\": \"\"\", \"close\": \"\"\", \"notIn\": [\"string\"] }, { \"open\": \"/*\", \"close\": \" */\", \"notIn\": [\"string\", \"comment\"] } </ins> ], \"surroundingPairs\": [ [\"{\", \"}\"],", "commid": "vscode_pr_73841"}], "negative_passages": []}
{"query_id": "q-en-vscode-c63cf426bf0e3e8e08c951c7f1810efa7920f6df253898ca98be83285d194851", "query": "a TypeScript file open (with some code in it) the outline to jump to the beginning of a method something somewhere the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds Yes (both in insiders & stable) Version: 1.34.0-insider (user setup) Commit: Date: 2019-04-26T13:39:29.623Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.\nIt seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g being but it seems like a tree issue <img width=\"777\" alt=\"Screenshot 2019-04-29 at 10 33 24\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-425b552c40648291b32e4995a7aca657fb8542f85c727845dd6b380b545f6e65", "text": "return; } <ins> this._set(nodes, false, browserEvent); } private _set(nodes: ITreeNode<T, any>[], silent: boolean, browserEvent?: UIEvent): void { </ins> this.nodes = [...nodes]; this.elements = undefined; this._nodeSet = undefined; <del> const that = this; this._onDidChange.fire({ get elements() { return that.get(); }, browserEvent }); </del> <ins> if (!silent) { const that = this; this._onDidChange.fire({ get elements() { return that.get(); }, browserEvent }); } </ins> } get(): T[] {", "commid": "vscode_pr_73346"}], "negative_passages": []}
{"query_id": "q-en-vscode-c63cf426bf0e3e8e08c951c7f1810efa7920f6df253898ca98be83285d194851", "query": "a TypeScript file open (with some code in it) the outline to jump to the beginning of a method something somewhere the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds Yes (both in insiders & stable) Version: 1.34.0-insider (user setup) Commit: Date: 2019-04-26T13:39:29.623Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.\nIt seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g being but it seems like a tree issue <img width=\"777\" alt=\"Screenshot 2019-04-29 at 10 33 24\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-e8eed49ae27290c5e1d6ed80205ce2a42e7213298ffca197b87a8f1815a61321", "text": "insertedNodes.forEach(node => dfs(node, insertedNodesVisitor)); const nodes: ITreeNode<T, any>[] = []; <ins> let silent = true; </ins> for (const node of this.nodes) { const id = this.identityProvider.getId(node.element).toString();", "commid": "vscode_pr_73346"}], "negative_passages": []}
{"query_id": "q-en-vscode-c63cf426bf0e3e8e08c951c7f1810efa7920f6df253898ca98be83285d194851", "query": "a TypeScript file open (with some code in it) the outline to jump to the beginning of a method something somewhere the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds Yes (both in insiders & stable) Version: 1.34.0-insider (user setup) Commit: Date: 2019-04-26T13:39:29.623Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.\nIt seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g being but it seems like a tree issue <img width=\"777\" alt=\"Screenshot 2019-04-29 at 10 33 24\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-e4c5aa8e07b9f5907700873f7e95d5a52d5449e3fa5b76e89ce5c87dc6f9eba6", "text": "if (insertedNode) { nodes.push(insertedNode); <ins> } else { silent = false; </ins> } } } <del> this.set(nodes); </del> <ins> this._set(nodes, silent); </ins> } private createNodeSet(): Set<ITreeNode<T, any>> {", "commid": "vscode_pr_73346"}], "negative_passages": []}
{"query_id": "q-en-vscode-2902d485cbeeebc1dd3e0385433a14c1b2f0ef9b775a1f43f1b8c2e2d81352f5", "query": "Extensions smoke tests are failing\nThis was caused because of two reasons has changed their search strategy and looking for extension by name is broken - label of an extension has string which was a bug introduced recently. Fixed them here -", "positive_passages": [{"docid": "doc-en-vscode-f73909b4098d13b4593bbea38b6bac62c3b7012df3eb75b029ac7b42edd65721", "text": "this.parent.removeAttribute('aria-label'); this.parent.title = this.getTooltip(); if (this.extension) { <del> this.parent.setAttribute('aria-label', localize('extension-arialabel', \"{0}. {1} Press enter for extension details.\", this.extension.displayName)); </del> <ins> this.parent.setAttribute('aria-label', localize('extension-arialabel', \"{0}. Press enter for extension details.\", this.extension.displayName)); </ins> } }", "commid": "vscode_pr_73072"}], "negative_passages": []}
{"query_id": "q-en-vscode-2902d485cbeeebc1dd3e0385433a14c1b2f0ef9b775a1f43f1b8c2e2d81352f5", "query": "Extensions smoke tests are failing\nThis was caused because of two reasons has changed their search strategy and looking for extension by name is broken - label of an extension has string which was a bug introduced recently. Fixed them here -", "positive_passages": [{"docid": "doc-en-vscode-fe582ac1668a9b714bc0843fb8549a04237ee3e3785867fae6813bb60e5a14d7", "text": "return; } <del> const extensionName = 'vscode-smoketest-check'; </del> await app.workbench.extensions.openExtensionsViewlet(); <del> await app.workbench.extensions.installExtension(extensionName); </del> <ins> await app.workbench.extensions.installExtension('michelkaporin.vscode-smoketest-check', 'vscode-smoketest-check'); </ins> await app.workbench.extensions.waitForExtensionsViewlet(); await app.workbench.quickopen.runCommand('Smoke Test Check');", "commid": "vscode_pr_73072"}], "negative_passages": []}
{"query_id": "q-en-vscode-2902d485cbeeebc1dd3e0385433a14c1b2f0ef9b775a1f43f1b8c2e2d81352f5", "query": "Extensions smoke tests are failing\nThis was caused because of two reasons has changed their search strategy and looking for extension by name is broken - label of an extension has string which was a bug introduced recently. Fixed them here -", "positive_passages": [{"docid": "doc-en-vscode-3701b644bd1d14781185d676012671e203162e39cce1e60630df2a58cdb3e153", "text": "await this.code.waitForElement(SEARCH_BOX); } <del> async searchForExtension(name: string): Promise<any> { </del> <ins> async searchForExtension(id: string): Promise<any> { </ins> await this.code.waitAndClick(SEARCH_BOX); await this.code.waitForActiveElement(SEARCH_BOX); <del> await this.code.waitForTypeInEditor(SEARCH_BOX, `name:\"${name}\"`); </del> <ins> await this.code.waitForTypeInEditor(SEARCH_BOX, `@id:${id}`); </ins> } <del> async installExtension(name: string): Promise<void> { await this.searchForExtension(name); </del> <ins> async installExtension(id: string, name: string): Promise<void> { await this.searchForExtension(id); </ins> const ariaLabel = `${name}. Press enter for extension details.`; await this.code.waitAndClick(`div.extensions-viewlet[id=\"workbench.view.extensions\"] .monaco-list-row[aria-label=\"${ariaLabel}\"] .extension li[class='action-item'] .extension-action.install`); await this.code.waitForElement(`.extension-editor .monaco-action-bar .action-item:not(.disabled) .extension-action.uninstall`);", "commid": "vscode_pr_73072"}], "negative_passages": []}
{"query_id": "q-en-vscode-2902d485cbeeebc1dd3e0385433a14c1b2f0ef9b775a1f43f1b8c2e2d81352f5", "query": "Extensions smoke tests are failing\nThis was caused because of two reasons has changed their search strategy and looking for extension by name is broken - label of an extension has string which was a bug introduced recently. Fixed them here -", "positive_passages": [{"docid": "doc-en-vscode-07aa9d3c50dc73e6520400277b81e0fa9a8928cd2e05c9bc333887c5a64fec70", "text": "return; } <del> const extensionName = 'German Language Pack for Visual Studio Code'; </del> await app.workbench.extensions.openExtensionsViewlet(); <del> await app.workbench.extensions.installExtension(extensionName); </del> <ins> await app.workbench.extensions.installExtension('ms-ceintl.vscode-language-pack-de', 'German Language Pack for Visual Studio Code'); </ins> await app.restart({ extraArgs: ['--locale=DE'] }); });", "commid": "vscode_pr_73072"}], "negative_passages": []}
{"query_id": "q-en-vscode-e27f845ea830c92fd6c26eb1d08c279539d6a8f688b9421904c20abacb1d7e90", "query": "Issue Type: <bBug</bI noticed when I install extension by clicking on the green \"Install\" button from within the VScode extension page, as opposed to the \"Would you like to install...\" notification/chat bubble in the lower right corner of the editor, the chat bubble stays there, asking me if I want to install the extension I just installed. Would be great if the state was in sync and the bubble would be dismissed when I installed the extension, no matter how. <details<summaryScreenshot after installation</summary<img width=\"2032\" alt=\"Screen Shot 2019-05-06 at 17 54 50\" src=\"https://user-\"</detailsVS Code version: Code 1.33.1 (, 2019-04-11T08:22:55.268Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ project-manager10.5.1 solargraph0.19.6 bracket-pair-colorizer1.0.61 vscode-eslint1.8.2 es7-react-js-snippets2.2.2 gitlens9.7.1 prettier-vscode1.9.0 rails-snippets1.0.8 rest-client0.21.2 vscode-codemetrics1.18.0 vscode-language-babel0.0.22 ruby-rubocop0.8.0 sublime-keybindings4.0.0 debugger-for-chrome4.11.3 JavaScriptSnippets0.2.0 ruby0.22.3 code-settings-sync3.2.9 change-case1.0.0 JavaScriptSnippets1.7.2 </details<!-- generated by issue reporter --\n, I would like to try this , Some starter and code pointers would be helpful :)\nIt depends on how got this notification. can you please let us know how you got this?\nIt shouldn't depend on that. I got it by clicking install button in VS Code Extension Marketplace website, in the browser.\nThis notification comes from here -\n, I checked the code but just wanted to discuss on one thing . Is that notification needed in the first place , clicking on install button on top will do the same job , Also removing that notification will keep the two scenarios consistent and same (Normally opening that extension page and opening the extension page from browser) We can remove the notification prompt to fix the inconsistency .\n, were you able to look into this ? I can remove the notification bubble and send a PR, please confirm :)\nYeah it look unnecessary for me. Please remove it.", "positive_passages": [{"docid": "doc-en-vscode-373af428a48cd60d196255a143b75c28f6d74f4daabc7b51e92991f053c38d70", "text": "import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IWindowService } from 'vs/platform/windows/common/windows'; <del> import Severity from 'vs/base/common/severity'; </del> import { URI } from 'vs/base/common/uri'; import { IExtension, ExtensionState, IExtensionsWorkbenchService, AutoUpdateConfigurationKey, AutoCheckUpdatesConfigurationKey } from 'vs/workbench/contrib/extensions/common/extensions'; import { IEditorService, SIDE_GROUP, ACTIVE_GROUP } from 'vs/workbench/services/editor/common/editorService';", "commid": "vscode_pr_74795"}], "negative_passages": []}
{"query_id": "q-en-vscode-e27f845ea830c92fd6c26eb1d08c279539d6a8f688b9421904c20abacb1d7e90", "query": "Issue Type: <bBug</bI noticed when I install extension by clicking on the green \"Install\" button from within the VScode extension page, as opposed to the \"Would you like to install...\" notification/chat bubble in the lower right corner of the editor, the chat bubble stays there, asking me if I want to install the extension I just installed. Would be great if the state was in sync and the bubble would be dismissed when I installed the extension, no matter how. <details<summaryScreenshot after installation</summary<img width=\"2032\" alt=\"Screen Shot 2019-05-06 at 17 54 50\" src=\"https://user-\"</detailsVS Code version: Code 1.33.1 (, 2019-04-11T08:22:55.268Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ project-manager10.5.1 solargraph0.19.6 bracket-pair-colorizer1.0.61 vscode-eslint1.8.2 es7-react-js-snippets2.2.2 gitlens9.7.1 prettier-vscode1.9.0 rails-snippets1.0.8 rest-client0.21.2 vscode-codemetrics1.18.0 vscode-language-babel0.0.22 ruby-rubocop0.8.0 sublime-keybindings4.0.0 debugger-for-chrome4.11.3 JavaScriptSnippets0.2.0 ruby0.22.3 code-settings-sync3.2.9 change-case1.0.0 JavaScriptSnippets1.7.2 </details<!-- generated by issue reporter --\n, I would like to try this , Some starter and code pointers would be helpful :)\nIt depends on how got this notification. can you please let us know how you got this?\nIt shouldn't depend on that. I got it by clicking install button in VS Code Extension Marketplace website, in the browser.\nThis notification comes from here -\n, I checked the code but just wanted to discuss on one thing . Is that notification needed in the first place , clicking on install button on top will do the same job , Also removing that notification will keep the two scenarios consistent and same (Normally opening that extension page and opening the extension page from browser) We can remove the notification prompt to fix the inconsistency .\n, were you able to look into this ? I can remove the notification bubble and send a PR, please confirm :)\nYeah it look unnecessary for me. Please remove it.", "positive_passages": [{"docid": "doc-en-vscode-a93760560a327779f6d027143325f3fdc662d0ddf9f228ccebe81b170fd1f4eb", "text": "return this.windowService.focusWindow() .then(() => this.open(extension)); } return this.queryGallery({ names: [extensionId], source: 'uri' }, CancellationToken.None).then(result => { if (result.total < 1) { return Promise.resolve(null);", "commid": "vscode_pr_74795"}], "negative_passages": []}
{"query_id": "q-en-vscode-e27f845ea830c92fd6c26eb1d08c279539d6a8f688b9421904c20abacb1d7e90", "query": "Issue Type: <bBug</bI noticed when I install extension by clicking on the green \"Install\" button from within the VScode extension page, as opposed to the \"Would you like to install...\" notification/chat bubble in the lower right corner of the editor, the chat bubble stays there, asking me if I want to install the extension I just installed. Would be great if the state was in sync and the bubble would be dismissed when I installed the extension, no matter how. <details<summaryScreenshot after installation</summary<img width=\"2032\" alt=\"Screen Shot 2019-05-06 at 17 54 50\" src=\"https://user-\"</detailsVS Code version: Code 1.33.1 (, 2019-04-11T08:22:55.268Z) OS version: Darwin x64 18.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ project-manager10.5.1 solargraph0.19.6 bracket-pair-colorizer1.0.61 vscode-eslint1.8.2 es7-react-js-snippets2.2.2 gitlens9.7.1 prettier-vscode1.9.0 rails-snippets1.0.8 rest-client0.21.2 vscode-codemetrics1.18.0 vscode-language-babel0.0.22 ruby-rubocop0.8.0 sublime-keybindings4.0.0 debugger-for-chrome4.11.3 JavaScriptSnippets0.2.0 ruby0.22.3 code-settings-sync3.2.9 change-case1.0.0 JavaScriptSnippets1.7.2 </details<!-- generated by issue reporter --\n, I would like to try this , Some starter and code pointers would be helpful :)\nIt depends on how got this notification. can you please let us know how you got this?\nIt shouldn't depend on that. I got it by clicking install button in VS Code Extension Marketplace website, in the browser.\nThis notification comes from here -\n, I checked the code but just wanted to discuss on one thing . Is that notification needed in the first place , clicking on install button on top will do the same job , Also removing that notification will keep the two scenarios consistent and same (Normally opening that extension page and opening the extension page from browser) We can remove the notification prompt to fix the inconsistency .\n, were you able to look into this ? I can remove the notification bubble and send a PR, please confirm :)\nYeah it look unnecessary for me. Please remove it.", "positive_passages": [{"docid": "doc-en-vscode-599a1c64eb2d97f27423b0bb21d55928d1f494c246783663de3264561e8bc691", "text": "const extension = result.firstPage[0]; return this.windowService.focusWindow().then(() => { <del> return this.open(extension).then(() => { this.notificationService.prompt( Severity.Info, nls.localize('installConfirmation', \"Would you like to install the '{0}' extension?\", extension.displayName, extension.publisher), [{ label: nls.localize('install', \"Install\"), run: () => this.install(extension).then(undefined, error => this.onError(error)) }], { sticky: true } ); }); </del> <ins> return this.open(extension); </ins> }); }); }).then(undefined, error => this.onError(error));", "commid": "vscode_pr_74795"}], "negative_passages": []}
{"query_id": "q-en-vscode-aec580cc18592d155e07bfe296b7f54d87b8f4394176af85c8793e6d21e43c5f", "query": "<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.\nWe might just have to set the cursor in that position, should be simple. Would you like to submit a PR?\nI can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..\nHi, I would like to work on this issue. I'll submit a PR soon.\nDo we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.\nSounds good.", "positive_passages": [{"docid": "doc-en-vscode-63db3b9b377826431c660206f6910bccfeaca8bb9328066b8528e52e73a0d44d", "text": "import { lstat, Stats } from 'fs'; import * as os from 'os'; import * as path from 'path'; <del> import { commands, Disposable, LineChange, MessageOptions, OutputChannel, Position, ProgressLocation, QuickPickItem, Range, SourceControlResourceState, TextDocumentShowOptions, TextEditor, Uri, ViewColumn, window, workspace, WorkspaceEdit, WorkspaceFolder } from 'vscode'; </del> <ins> import { Selection, commands, Disposable, LineChange, MessageOptions, OutputChannel, Position, ProgressLocation, QuickPickItem, Range, SourceControlResourceState, TextDocumentShowOptions, TextEditor, Uri, ViewColumn, window, workspace, WorkspaceEdit, WorkspaceFolder } from 'vscode'; </ins> import TelemetryReporter from 'vscode-extension-telemetry'; import * as nls from 'vscode-nls'; import { Branch, GitErrorCodes, Ref, RefType, Status } from './api/git';", "commid": "vscode_pr_85074"}], "negative_passages": []}
{"query_id": "q-en-vscode-aec580cc18592d155e07bfe296b7f54d87b8f4394176af85c8793e6d21e43c5f", "query": "<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.\nWe might just have to set the cursor in that position, should be simple. Would you like to submit a PR?\nI can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..\nHi, I would like to work on this issue. I'll submit a PR soon.\nDo we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.\nSounds good.", "positive_passages": [{"docid": "doc-en-vscode-60c1fa66f81d6b07f428d541bab6df557febebd8cc1883b3c27972a2d381f7da", "text": "} await this._stageChanges(textEditor, [changes[index]]); <ins> const firstStagedLine = changes[index].modifiedStartLineNumber - 1; textEditor.selections = [new Selection(firstStagedLine, 0, firstStagedLine, 0)]; </ins> } @command('git.stageSelectedRanges', { diff: true })", "commid": "vscode_pr_85074"}], "negative_passages": []}
{"query_id": "q-en-vscode-aec580cc18592d155e07bfe296b7f54d87b8f4394176af85c8793e6d21e43c5f", "query": "<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.\nWe might just have to set the cursor in that position, should be simple. Would you like to submit a PR?\nI can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..\nHi, I would like to work on this issue. I'll submit a PR soon.\nDo we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.\nSounds good.", "positive_passages": [{"docid": "doc-en-vscode-ed2ddf76a9cae2ccb08bb924e801215707f04ce8699eef9af84879b8a3617a2c", "text": "} await this._revertChanges(textEditor, [...changes.slice(0, index), ...changes.slice(index + 1)]); <ins> const firstStagedLine = changes[index].modifiedStartLineNumber - 1; textEditor.selections = [new Selection(firstStagedLine, 0, firstStagedLine, 0)]; </ins> } @command('git.revertSelectedRanges', { diff: true })", "commid": "vscode_pr_85074"}], "negative_passages": []}
{"query_id": "q-en-vscode-aec580cc18592d155e07bfe296b7f54d87b8f4394176af85c8793e6d21e43c5f", "query": "<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.\nWe might just have to set the cursor in that position, should be simple. Would you like to submit a PR?\nI can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..\nHi, I would like to work on this issue. I'll submit a PR soon.\nDo we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.\nSounds good.", "positive_passages": [{"docid": "doc-en-vscode-42770145c3d669ab977e4fa8afb9feb82392816d1175152328946b0b281fd7de", "text": "return; } <ins> const selectionsBeforeRevert = textEditor.selections; </ins> await this._revertChanges(textEditor, selectedChanges); <ins> textEditor.selections = selectionsBeforeRevert; </ins> } private async _revertChanges(textEditor: TextEditor, changes: LineChange[]): Promise<void> {", "commid": "vscode_pr_85074"}], "negative_passages": []}
{"query_id": "q-en-vscode-aec580cc18592d155e07bfe296b7f54d87b8f4394176af85c8793e6d21e43c5f", "query": "<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.\nWe might just have to set the cursor in that position, should be simple. Would you like to submit a PR?\nI can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..\nHi, I would like to work on this issue. I'll submit a PR soon.\nDo we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.\nSounds good.", "positive_passages": [{"docid": "doc-en-vscode-c29066261046d086bafeca6ee40dba6ec0409e22dfc45b71d5f3a3e780e06104", "text": "const originalUri = toGitUri(modifiedUri, '~'); const originalDocument = await workspace.openTextDocument(originalUri); <del> const selectionsBeforeRevert = textEditor.selections; </del> const visibleRangesBeforeRevert = textEditor.visibleRanges; const result = applyLineChanges(originalDocument, modifiedDocument, changes);", "commid": "vscode_pr_85074"}], "negative_passages": []}
{"query_id": "q-en-vscode-aec580cc18592d155e07bfe296b7f54d87b8f4394176af85c8793e6d21e43c5f", "query": "<!-- Please search existing issues to avoid creating duplicates. --Step 0. Version 1.35.0 with extensions disabled. Step 1. Open a file with changes committed in git Step 2. Use ALT+F3 to navigate to the next change in-line Step 3. Click Revert Change Step 4. find the line number you were on and move your cursor there, then hit ALT+F3 again <!-- Describe the feature you'd like. --I would like vscode to remember where I was whenever I revert a change, then return me to that place, so that I can see the change disappear and so that I can proceed using hotkey to the next change.\nWe might just have to set the cursor in that position, should be simple. Would you like to submit a PR?\nI can take a look at this.. As this will be my first pull request here in vscode repo, I will require some help. Do let me know a good starting point for this..\nHi, I would like to work on this issue. I'll submit a PR soon.\nDo we want to fix this for 'stage change' functionality too? It behaves now the same way as 'revert change' - it starts searching from the beginning, instead of placing cursor in staged line position.\nSounds good.", "positive_passages": [{"docid": "doc-en-vscode-a428617f4f8323f7971691060062fab529537c8970a6dec3471d3f5c1555d028", "text": "await modifiedDocument.save(); <del> textEditor.selections = selectionsBeforeRevert; </del> textEditor.revealRange(visibleRangesBeforeRevert[0]); }", "commid": "vscode_pr_85074"}], "negative_passages": []}
{"query_id": "q-en-vscode-3d1e7ffabb0213f52e6a751eba03a55df2b2f6f5b7550ee4be750d5a0ef48989", "query": "Support rendering text decorations in the minimap, beginning with search results. We can add a new option to decorations, similar to in : The new optional property could look like: The find widget can then set this property for its decorations, and the minimap can read the decorations from its text model.", "positive_passages": [{"docid": "doc-en-vscode-959d4d1750d770cac8ffe3c4282a0fe6cfecd797f1dc202e0435c8fb04d1e486", "text": "<key>function</key> <dict> <key>begin</key> <del> <string>((?i:function|filter|configuration|workflow))s+((?:p{L}|d|_|-|.)+)</string> </del> <ins> <string>(?&lt;!S)(?i)(function|filter|configuration|workflow)s+(?:(global|local|script|private):)?((?:p{L}|d|_|-|.)+)</string> </ins> <key>beginCaptures</key> <dict> <key>0</key>", "commid": "vscode_pr_472"}], "negative_passages": []}
{"query_id": "q-en-vscode-3d1e7ffabb0213f52e6a751eba03a55df2b2f6f5b7550ee4be750d5a0ef48989", "query": "Support rendering text decorations in the minimap, beginning with search results. We can add a new option to decorations, similar to in : The new optional property could look like: The find widget can then set this property for its decorations, and the minimap can read the decorations from its text model.", "positive_passages": [{"docid": "doc-en-vscode-b77d6b97d821fd4b583917a0a4c654d4cd1abbfb764ea4e6f170201780e38252", "text": "<key>2</key> <dict> <key>name</key> <del> <string>entity.name.function</string> </del> <ins> <string>storage.modifier.scope.powershell</string> </dict> <key>3</key> <dict> <key>name</key> <string>entity.name.function.powershell</string> </ins> </dict> </dict> <key>end</key>", "commid": "vscode_pr_472"}], "negative_passages": []}
{"query_id": "q-en-vscode-3d1e7ffabb0213f52e6a751eba03a55df2b2f6f5b7550ee4be750d5a0ef48989", "query": "Support rendering text decorations in the minimap, beginning with search results. We can add a new option to decorations, similar to in : The new optional property could look like: The find widget can then set this property for its decorations, and the minimap can read the decorations from its text model.", "positive_passages": [{"docid": "doc-en-vscode-d8711053209a95b59b35649f17316715f4cf9d3bdbfff181ecb94a05694d7549", "text": "<key>uuid</key> <string>f8f5ffb0-503e-11df-9879-0800200c9a66</string> </dict> <del> </plist> </del>  No newline at end of file <ins> </plist> </ins>", "commid": "vscode_pr_472"}], "negative_passages": []}
{"query_id": "q-en-vscode-bc8a89b4a9cc1a6fae90d2a7b361e46719eff29f5212c6a44d8cb32abe1ec55b", "query": "I am a bit confused about this change, isn't it that command line arguments are being passed to Chrome/Electron anyway? Why is this needed? Originally posted by in\nWould you like to submit a PR that reverts the original PR?", "positive_passages": [{"docid": "doc-en-vscode-1981a21c0484542f90cd1147268134bb8fd55c910fa01ff21c63316a686f55b3", "text": "if (jsFlags) { app.commandLine.appendSwitch('--js-flags', jsFlags); } <del> // Disable smooth scrolling for Webviews if (cliArgs['disable-smooth-scrolling']) { app.commandLine.appendSwitch('disable-smooth-scrolling'); } </del> } /**", "commid": "vscode_pr_76944"}], "negative_passages": []}
{"query_id": "q-en-vscode-3f8a221e4a452fb8bea9fd82d072124cba16c0d735ee41b01002b248523b4cb2", "query": "When installing the extension completes, the message is shown: \"Completed installing the extension <publisher.<name. Instead, the extension displayName should be shown. VSCode Version: 1.36 OS Version: Windows 10 !\nCurrently, is displayed, it would be better if is shown.", "positive_passages": [{"docid": "doc-en-vscode-5d0ad41e4b2d3a1fc9946eb9a8460999f32456f677dd8702dc17ac885872d15f", "text": ".then(extensions => { for (const extension of extensions) { const requireReload = !(extension.local && this.extensionService.canAddExtension(toExtensionDescription(extension.local))); <del> const message = requireReload ? localize('InstallVSIXAction.successReload', \"Please reload Visual Studio Code to complete installing the extension {0}.\", extension.identifier.id) : localize('InstallVSIXAction.success', \"Completed installing the extension {0}.\", extension.identifier.id); </del> <ins> const message = requireReload ? localize('InstallVSIXAction.successReload', \"Please reload Visual Studio Code to complete installing the extension {0}.\", extension.displayName || extension.name) : localize('InstallVSIXAction.success', \"Completed installing the extension {0}.\", extension.displayName || extension.name); </ins> const actions = requireReload ? [{ label: localize('InstallVSIXAction.reloadNow', \"Reload Now\"), run: () => this.windowService.reloadWindow()", "commid": "vscode_pr_77147"}], "negative_passages": []}
{"query_id": "q-en-vscode-c4207f9b44eee2212b93595564da87daae33a678d9d528a41f678b8d2e2cdd2e", "query": "Apparently resolving a string like will work but it will leave the last curly brace. We should disallow this case or throw an error, etc. See\nStill seeing some odd behavior (although this may be expected) Repro MacOs : new terminal Bug In the terminal, see: This does not happen if I use a setting such as\nLooks like that's a side effect of 'breaking' the path. Nested variables are just no longer interpolated, it's left as:\nare those side effects you listed above intended side effects of the change? If so, I see the same thing on codespaces and we can just leave this issue verified. Otherwise, should the issue be moved to the next milestone?\nYes, it's intended that variables that have nested segments are no longer replace. Previously it would have resulted in a malformed string.", "positive_passages": [{"docid": "doc-en-vscode-438e765f3447323d117bd278354a8ce5013cc51871a8d4131fac93422062114d", "text": "export class AbstractVariableResolverService implements IConfigurationResolverService { <ins> static readonly VARIABLE_LHS = '${'; </ins> static readonly VARIABLE_REGEXP = /${(.*?)}/g; declare readonly _serviceBrand: undefined;", "commid": "vscode_pr_110428"}], "negative_passages": []}
{"query_id": "q-en-vscode-c4207f9b44eee2212b93595564da87daae33a678d9d528a41f678b8d2e2cdd2e", "query": "Apparently resolving a string like will work but it will leave the last curly brace. We should disallow this case or throw an error, etc. See\nStill seeing some odd behavior (although this may be expected) Repro MacOs : new terminal Bug In the terminal, see: This does not happen if I use a setting such as\nLooks like that's a side effect of 'breaking' the path. Nested variables are just no longer interpolated, it's left as:\nare those side effects you listed above intended side effects of the change? If so, I see the same thing on codespaces and we can just leave this issue verified. Otherwise, should the issue be moved to the next milestone?\nYes, it's intended that variables that have nested segments are no longer replace. Previously it would have resulted in a malformed string.", "positive_passages": [{"docid": "doc-en-vscode-c9efe15ac372fd21eef888f5aba2885b706184ce7a5745e1393832fb5dcf1429", "text": "// loop through all variables occurrences in 'value' const replaced = value.replace(AbstractVariableResolverService.VARIABLE_REGEXP, (match: string, variable: string) => { <ins> // disallow attempted nesting, see #77289 if (variable.includes(AbstractVariableResolverService.VARIABLE_LHS)) { return match; } </ins> let resolvedValue = this.evaluateSingleVariable(match, variable, folderUri, commandValueMapping);", "commid": "vscode_pr_110428"}], "negative_passages": []}
{"query_id": "q-en-vscode-c4207f9b44eee2212b93595564da87daae33a678d9d528a41f678b8d2e2cdd2e", "query": "Apparently resolving a string like will work but it will leave the last curly brace. We should disallow this case or throw an error, etc. See\nStill seeing some odd behavior (although this may be expected) Repro MacOs : new terminal Bug In the terminal, see: This does not happen if I use a setting such as\nLooks like that's a side effect of 'breaking' the path. Nested variables are just no longer interpolated, it's left as:\nare those side effects you listed above intended side effects of the change? If so, I see the same thing on codespaces and we can just leave this issue verified. Otherwise, should the issue be moved to the next milestone?\nYes, it's intended that variables that have nested segments are no longer replace. Previously it would have resulted in a malformed string.", "positive_passages": [{"docid": "doc-en-vscode-4b7c42403b361b9ddc3644864978e7cba598d4d829a5d194ec327a3fd7b54f32", "text": "} }); <ins> test('disallows nested keys (#77289)', () => { assert.strictEqual(configurationResolverService!.resolve(workspace, '${env:key1} ${env:key1${env:key2}}'), 'Value for key1 ${env:key1${env:key2}}'); }); </ins> // test('substitute keys and values in object', () => { // \tconst myObject = { // \t\t'${workspaceRootFolderName}': '${lineNumber}',", "commid": "vscode_pr_110428"}], "negative_passages": []}
{"query_id": "q-en-vscode-bf2eb3a7e1ada1426a619ae5e87192cf3eea187bdb314491de8e880a1cfa7c28", "query": "Are there any commands in VScode to navigate \"up\" or \"down\" (a folder, directly) in a selection in breadcrumbs? <img width=\"659\" alt=\"Screen Shot 2019-07-13 at 7 04 55 PM\" src=\"https://user-\"\nfor what the command id is but pressing ArrowLeft does the job for me\nThe command is actually . It will collapse a node. If already collapsed, it will select the parent. Should we implement a command to simply select the parent?\nI can do this and have a try\ni make a PR but not very clear about how primary work.\nCommand is , you'll be able to configure a custom key binding when it's out.", "positive_passages": [{"docid": "doc-en-vscode-e30a3a3e9fbedc4e8a4d7158f6758129564910bb61f448684e0a826e56145ba9", "text": "} } }); <ins> KeybindingsRegistry.registerCommandAndKeybindingRule({ id: 'list.focusParent', weight: KeybindingWeight.WorkbenchContrib, when: WorkbenchListFocusContextKey, primary: KeyCode.Shift | KeyCode.LeftArrow, handler: (accessor) => { const focused = accessor.get(IListService).lastFocusedList; // Tree only if (focused && !(focused instanceof List || focused instanceof PagedList)) { if (focused instanceof ObjectTree || focused instanceof DataTree || focused instanceof AsyncDataTree) { const tree = focused; const focusedElements = tree.getFocus(); if (focusedElements.length === 0) { return; } const focus = focusedElements[0]; const parent = tree.getParentElement(focus); if (parent) { const fakeKeyboardEvent = new KeyboardEvent('keydown'); tree.setFocus([parent], fakeKeyboardEvent); tree.reveal(parent); } } else { const tree = focused; tree.focusParent({ origin: 'keyboard' }); } } } }); </ins>  No newline at end of file", "commid": "vscode_pr_77848"}], "negative_passages": []}
{"query_id": "q-en-vscode-4b002998e2343db9beed6d12c42bbae5342f51a4d28ca4ae2306d8e408ccd116", "query": "Testing Please see the attached recording ! Notice how 'bb' is only shown after adding 'ccc'\nGood catch. The \"fast update\" only applied when list DOM element is in focus but not when list item is in focus.", "positive_passages": [{"docid": "doc-en-vscode-6a0a07c11d6905f0c4abd42a0262e10cfc3dd3e28fb9c3c61eccb60f826ddc63", "text": "// If a single setting is being refreshed, it's ok to refresh now if that is not the focused setting if (key) { const focusedKey = focusedSetting.getAttribute(AbstractSettingRenderer.SETTING_KEY_ATTR); <del> /** * Update `list`s live if focused item is whole list or list item, * as they have a separate \"submit edit\" step built in before this */ if ( focusedKey === key && !DOM.hasClass(focusedSetting, 'setting-item-list') && !DOM.hasClass(focusedSetting, 'setting-item-contents') </del> <ins> if (focusedKey === key && // update `list`s live, as they have a separate \"submit edit\" step built in before this (focusedSetting.parentElement && !DOM.hasClass(focusedSetting.parentElement, 'setting-item-list')) </ins> ) { this.updateModifiedLabelForKey(key);", "commid": "vscode_pr_78407"}], "negative_passages": []}
{"query_id": "q-en-vscode-f2a85e31b52d4ab998dd1143c023e3db1035ed3609af4d980644e8662513cefc", "query": "Issue Type: <bBug</bIf you have keyboard with multimedia buttons using them in Explorer tree triggers highlights/filtering. focus to Explorer tree Play/Pause media key that filter for was applied ! This keyboard have only one multimedia key, but I expect that other might be affected too. VS Code version: Code - Insiders 1.37.0-insider (, 2019-08-01T05:37:54.848Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --\nI would like to have a go at this.\nCan you still reproduce this? Think it may have been fixed in commit . I know I used to be able to reproduce this but I can't anymore.\nthanks for checking this issue. Unfortunately I'm still able to reproduce this issue wits latest Insiders build. ! Version: 1.40.0-insider (user setup) Commit: Date: 2019-10-22T05:27:32.053Z Electron: 6.0.12 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0. Reported key is (which looks like expected key code for this button) ! UPD. While looks good media key might \"leak\" somewhere on\nIssue related. I am thinking that this key filtering (see below) could be simplified massively. Instead of blacklisting all of these edge cases, we could just check if is a single character. I believe this should only allow key presses that we want. Then we can just add the exceptions such as . If we remove L660 and modify L664 to be: Key filtering:\nI thought about this. But you're going to hit issues with unicode characters, in which one visible character actually has length 1. Let's just keep filtering out these cases one by one, it's fine. Simply add .\nCannot reproduce in 1.39. Could someone who can verify the fix in the latest Insiders?\nFix works as expected for me. Version: 1.40.0-insider (user setup) Commit: Date: 2019-10-31T05:42:33.138Z", "positive_passages": [{"docid": "doc-en-vscode-e81c47a3eb1fe73517c898a39d0a791841ff9eb464eb650a859291e15bac9598", "text": "const onKeyDown = Event.chain(domEvent(this.view.getHTMLElement(), 'keydown')) .filter(e => !isInputElement(e.target as HTMLElement) || e.target === this.filterOnTypeDomNode) <del> .filter(e => e.key !== 'Dead') </del> <ins> .filter(e => e.key !== 'Dead' && !/^Media/.test(e.key)) </ins> .map(e => new StandardKeyboardEvent(e)) .filter(this.keyboardNavigationEventFilter || (() => true)) .filter(() => this.automaticKeyboardNavigation || this.triggered)", "commid": "vscode_pr_83218"}], "negative_passages": []}
{"query_id": "q-en-vscode-894f01d006d8040416c04fcf14fcaa6d39364fea1072689d538b1c71c9d6d7fc", "query": "Reported here: Nice example:\nSorry didn't get the chance to get this done, pushing it out to September.\nNote to self: remember to revert", "positive_passages": [{"docid": "doc-en-vscode-842edf254d6d94b7a20433d02804e497300822f92a26999da155f112aaa28b6d", "text": "private async doRefresh(elements: ITreeItem[]): Promise<void> { if (this.tree) { this.refreshing = true; <del> await Promise.all(elements.map(element => this.tree.updateChildren(element, true))); elements.map(element => this.tree.rerender(element)); </del> <ins> const parents: Set<ITreeItem> = new Set<ITreeItem>(); elements.forEach(element => { if (element !== this.root) { const parent = this.tree.getParentElement(element); parents.add(parent); } else { parents.add(element); } }); await Promise.all(Array.from(parents.values()).map(element => this.tree.updateChildren(element, true))); </ins> this.refreshing = false; this.updateContentAreas(); if (this.focused) {", "commid": "vscode_pr_78390"}], "negative_passages": []}
{"query_id": "q-en-vscode-6590fc903ddbb871d74a94d60824be0ff9f0132bc40589cc25ea25a2205770ad", "query": "VSCode Version: 1.37.1 OS Version: Fedora 30 I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE). I noticed that if I start the CSS-LS without passing a element to initialization, the LS will fail because of . One of the important lines in the stack trace is .\nSubmitted PR for this issue.\nFixed by .\nVerified in master by removing the dataPaths", "positive_passages": [{"docid": "doc-en-vscode-1cc01d9aa392ec127617512e6090c6fd54294dd5a9861cc873ec0a1bfc1b8955", "text": "} } <del> const dataPaths: string[] = params.initializationOptions.dataPaths; </del> <ins> const dataPaths: string[] = params.initializationOptions.dataPaths || []; </ins> const customDataProviders = getDataProviders(dataPaths); function getClientCapability<T>(name: string, def: T) {", "commid": "vscode_pr_79600"}], "negative_passages": []}
{"query_id": "q-en-vscode-6590fc903ddbb871d74a94d60824be0ff9f0132bc40589cc25ea25a2205770ad", "query": "VSCode Version: 1.37.1 OS Version: Fedora 30 I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE). I noticed that if I start the CSS-LS without passing a element to initialization, the LS will fail because of . One of the important lines in the stack trace is .\nSubmitted PR for this issue.\nFixed by .\nVerified in master by removing the dataPaths", "positive_passages": [{"docid": "doc-en-vscode-031ce846aba1debb808c21ad0d4a3938340e1a6b451a84aa4141b7e3a3718cd4", "text": "viewStates[handle] = { visible: input === group.activeEditor, active: input === activeInput, <del> position: editorGroupToViewColumn(this._editorGroupService, group.id || 0), </del> <ins> position: editorGroupToViewColumn(this._editorGroupService, group.id), </ins> }; } }", "commid": "vscode_pr_79600"}], "negative_passages": []}
{"query_id": "q-en-vscode-6590fc903ddbb871d74a94d60824be0ff9f0132bc40589cc25ea25a2205770ad", "query": "VSCode Version: 1.37.1 OS Version: Fedora 30 I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE). I noticed that if I start the CSS-LS without passing a element to initialization, the LS will fail because of . One of the important lines in the stack trace is .\nSubmitted PR for this issue.\nFixed by .\nVerified in master by removing the dataPaths", "positive_passages": [{"docid": "doc-en-vscode-26ccadcaf787e91b9a310f642e7d368a5355440678d89235136b84df3e1fd302", "text": "} private onDidClickLink(handle: WebviewPanelHandle, link: URI): void { <del> if (!link) { return; } </del> const webview = this.getWebviewEditorInput(handle); if (this.isSupportedLink(webview, link)) { this._openerService.open(link);", "commid": "vscode_pr_79600"}], "negative_passages": []}
{"query_id": "q-en-vscode-6590fc903ddbb871d74a94d60824be0ff9f0132bc40589cc25ea25a2205770ad", "query": "VSCode Version: 1.37.1 OS Version: Fedora 30 I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE). I noticed that if I start the CSS-LS without passing a element to initialization, the LS will fail because of . One of the important lines in the stack trace is .\nSubmitted PR for this issue.\nFixed by .\nVerified in master by removing the dataPaths", "positive_passages": [{"docid": "doc-en-vscode-942638dc22ee0871e81d5e305acaed8498c948c87fa6d716b4083476fc2ae7aa", "text": "return; case 'did-click-link': <del> let [uri] = event.args; </del> <ins> const [uri] = event.args; </ins> this._onDidClickLink.fire(URI.parse(uri)); return;", "commid": "vscode_pr_79600"}], "negative_passages": []}
{"query_id": "q-en-vscode-6590fc903ddbb871d74a94d60824be0ff9f0132bc40589cc25ea25a2205770ad", "query": "VSCode Version: 1.37.1 OS Version: Fedora 30 I'm extracting the CSS Language Server for usage in 3rd party IDE (Eclipse IDE). I noticed that if I start the CSS-LS without passing a element to initialization, the LS will fail because of . One of the important lines in the stack trace is .\nSubmitted PR for this issue.\nFixed by .\nVerified in master by removing the dataPaths", "positive_passages": [{"docid": "doc-en-vscode-9a9b3e7541b1613b1f03eae8342112cf0638ffb7e69ce7eb3b784f52387dda36", "text": "clientY: rawEvent.clientY + bounds.top, })); return; <del> } catch (TypeError) { </del> <ins> } catch { </ins> // CustomEvent was treated as MouseEvent so don't do anything - https://github.com/microsoft/vscode/issues/78915 return; } } case 'did-set-content':", "commid": "vscode_pr_79600"}], "negative_passages": []}
{"query_id": "q-en-vscode-5008901ef0bd3e1e2b211b765d763bb1dc87237e04186a574d4f4bc24c595e6f", "query": "Issue Type: <bBug</bSteps to Reproduce: a project/folder mouse into Editor and then move it out from right edge of the window Activity Bar mouse into Side Bar and then move it out from left edge of the window VS Code version: Code 1.37.1 (, 2019-08-15T16:16:34.800Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --\nThe issue seems to be in , but I am not sure what the difference is between that edge of the editor and the others. For some reason the mouseLeave event is not being fired on the right-hand side. It seems it thinks the is the same as the initially given - which means the leave event is never fired. I'm happy to keep digging into this if that's ok with you.", "positive_passages": [{"docid": "doc-en-vscode-f4c990b86260ef563c77c1d67e1c22e3c2f16546af130d4027fe2ab03c124881", "text": "export function addDisposableNonBubblingMouseOutListener(node: Element, handler: (event: MouseEvent) => void): IDisposable { return addDisposableListener(node, 'mouseout', (e: MouseEvent) => { // Mouse out bubbles, so this is an attempt to ignore faux mouse outs coming from children elements <del> let toElement: Node | null = <Node>(e.relatedTarget || e.target); </del> <ins> let toElement: Node | null = <Node>(e.relatedTarget); </ins> while (toElement && toElement !== node) { toElement = toElement.parentNode; }", "commid": "vscode_pr_87827"}], "negative_passages": []}
{"query_id": "q-en-vscode-5008901ef0bd3e1e2b211b765d763bb1dc87237e04186a574d4f4bc24c595e6f", "query": "Issue Type: <bBug</bSteps to Reproduce: a project/folder mouse into Editor and then move it out from right edge of the window Activity Bar mouse into Side Bar and then move it out from left edge of the window VS Code version: Code 1.37.1 (, 2019-08-15T16:16:34.800Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --\nThe issue seems to be in , but I am not sure what the difference is between that edge of the editor and the others. For some reason the mouseLeave event is not being fired on the right-hand side. It seems it thinks the is the same as the initially given - which means the leave event is never fired. I'm happy to keep digging into this if that's ok with you.", "positive_passages": [{"docid": "doc-en-vscode-02d5073fe152b7c00e725dadc7709fab7ea351bf92532e2c538157ce047e25c0", "text": "export function addDisposableNonBubblingPointerOutListener(node: Element, handler: (event: MouseEvent) => void): IDisposable { return addDisposableListener(node, 'pointerout', (e: MouseEvent) => { // Mouse out bubbles, so this is an attempt to ignore faux mouse outs coming from children elements <del> let toElement: Node | null = <Node>(e.relatedTarget || e.target); </del> <ins> let toElement: Node | null = <Node>(e.relatedTarget); </ins> while (toElement && toElement !== node) { toElement = toElement.parentNode; }", "commid": "vscode_pr_87827"}], "negative_passages": []}
{"query_id": "q-en-vscode-c59ea12bb4d903c0831262f61dd4b2011be3c8b0c25414c946772da469ee8403", "query": ", Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this Example: Replacingto with preserve case turned on replaces correctly to Replacing to with preserve case turned on replaces incorrectly to instead of PS : Additional Info from the code I found out there is a bug in function. The whole idea to call the replacement function again at was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.\nThanks for the PR, can you please phrase this issue in the form of a bug report (ie describe what to do, what happens, what is supposed to happen)", "positive_passages": [{"docid": "doc-en-vscode-4593e9e365356e760b7a4f63e11d059161dd6860c15bd12699f47e40218de7ad", "text": "export function buildReplaceStringWithCasePreserved(matches: string[] | null, pattern: string): string { if (matches && (matches[0] !== '')) { <ins> const containsHyphens = validateSpecificSpecialCharacter(matches, pattern, '-'); const containsUnderscores = validateSpecificSpecialCharacter(matches, pattern, '_'); if (containsHyphens && !containsUnderscores) { return buildReplaceStringForSpecificSpecialCharacter(matches, pattern, '-'); } else if (!containsHyphens && containsUnderscores) { return buildReplaceStringForSpecificSpecialCharacter(matches, pattern, '_'); } </ins> if (matches[0].toUpperCase() === matches[0]) { return pattern.toUpperCase(); } else if (matches[0].toLowerCase() === matches[0]) { return pattern.toLowerCase(); } else if (strings.containsUppercaseCharacter(matches[0][0])) { <del> const containsHyphens = validateSpecificSpecialCharacter(matches, pattern, '-'); const containsUnderscores = validateSpecificSpecialCharacter(matches, pattern, '_'); if (containsHyphens && !containsUnderscores) { return buildReplaceStringForSpecificSpecialCharacter(matches, pattern, '-'); } else if (!containsHyphens && containsUnderscores) { return buildReplaceStringForSpecificSpecialCharacter(matches, pattern, '_'); } else { return pattern[0].toUpperCase() + pattern.substr(1); } </del> <ins> return pattern[0].toUpperCase() + pattern.substr(1); </ins> } else { // we don't understand its pattern yet. return pattern;", "commid": "vscode_pr_81781"}], "negative_passages": []}
{"query_id": "q-en-vscode-c59ea12bb4d903c0831262f61dd4b2011be3c8b0c25414c946772da469ee8403", "query": ", Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this Example: Replacingto with preserve case turned on replaces correctly to Replacing to with preserve case turned on replaces incorrectly to instead of PS : Additional Info from the code I found out there is a bug in function. The whole idea to call the replacement function again at was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.\nThanks for the PR, can you please phrase this issue in the form of a bug report (ie describe what to do, what happens, what is supposed to happen)", "positive_passages": [{"docid": "doc-en-vscode-09c2fa07afb52960b41a4f3b9bd311e65948e6528f0b36b52320595d66cd04e3", "text": "assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar-newabc'), 'Newfoo-Newbar-Newabc'); actual = ['Foo-Bar-abc']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar'), 'Newfoo-newbar'); <ins> actual = ['foo-Bar']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar'), 'newfoo-Newbar'); actual = ['foo-BAR']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo-newbar'), 'newfoo-NEWBAR'); </ins> actual = ['Foo_Bar']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo_newbar'), 'Newfoo_Newbar');", "commid": "vscode_pr_81781"}], "negative_passages": []}
{"query_id": "q-en-vscode-c59ea12bb4d903c0831262f61dd4b2011be3c8b0c25414c946772da469ee8403", "query": ", Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this Example: Replacingto with preserve case turned on replaces correctly to Replacing to with preserve case turned on replaces incorrectly to instead of PS : Additional Info from the code I found out there is a bug in function. The whole idea to call the replacement function again at was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.\nThanks for the PR, can you please phrase this issue in the form of a bug report (ie describe what to do, what happens, what is supposed to happen)", "positive_passages": [{"docid": "doc-en-vscode-29fdebeb77a13e253bf21dea5fca4058e4a37e49d7c830a7b4a4b4580a470a84", "text": "assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo_newbar'), 'Newfoo_newbar'); actual = ['Foo_Bar-abc']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo_newbar-abc'), 'Newfoo_newbar-abc'); <ins> actual = ['foo_Bar']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo_newbar'), 'newfoo_Newbar'); actual = ['Foo_BAR']; assert.equal(buildReplaceStringWithCasePreserved(actual, 'newfoo_newbar'), 'Newfoo_NEWBAR'); </ins> }); test('preserve case', () => {", "commid": "vscode_pr_81781"}], "negative_passages": []}
{"query_id": "q-en-vscode-c59ea12bb4d903c0831262f61dd4b2011be3c8b0c25414c946772da469ee8403", "query": ", Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this Example: Replacingto with preserve case turned on replaces correctly to Replacing to with preserve case turned on replaces incorrectly to instead of PS : Additional Info from the code I found out there is a bug in function. The whole idea to call the replacement function again at was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.\nThanks for the PR, can you please phrase this issue in the form of a bug report (ie describe what to do, what happens, what is supposed to happen)", "positive_passages": [{"docid": "doc-en-vscode-9032ac562e3cee88e97b72bdb55df7e58b9182c6b1aafe4fc8ebf31336d8105d", "text": "actual = replacePattern.buildReplaceString(['Foo-Bar-abc'], true); assert.equal(actual, 'Newfoo-newbar'); <ins> replacePattern = parseReplaceString('newfoo-newbar'); actual = replacePattern.buildReplaceString(['foo-Bar'], true); assert.equal(actual, 'newfoo-Newbar'); replacePattern = parseReplaceString('newfoo-newbar'); actual = replacePattern.buildReplaceString(['foo-BAR'], true); assert.equal(actual, 'newfoo-NEWBAR'); </ins> replacePattern = parseReplaceString('newfoo_newbar'); actual = replacePattern.buildReplaceString(['Foo_Bar'], true); assert.equal(actual, 'Newfoo_Newbar');", "commid": "vscode_pr_81781"}], "negative_passages": []}
{"query_id": "q-en-vscode-c59ea12bb4d903c0831262f61dd4b2011be3c8b0c25414c946772da469ee8403", "query": ", Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this Example: Replacingto with preserve case turned on replaces correctly to Replacing to with preserve case turned on replaces incorrectly to instead of PS : Additional Info from the code I found out there is a bug in function. The whole idea to call the replacement function again at was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.\nThanks for the PR, can you please phrase this issue in the form of a bug report (ie describe what to do, what happens, what is supposed to happen)", "positive_passages": [{"docid": "doc-en-vscode-32bc7d2f0ea738624b0ee8a829e5396c700ec00a8d19a13d8cfe1f94a43207d5", "text": "replacePattern = parseReplaceString('newfoo_newbar-abc'); actual = replacePattern.buildReplaceString(['Foo_Bar-abc'], true); assert.equal(actual, 'Newfoo_newbar-abc'); <ins> replacePattern = parseReplaceString('newfoo_newbar'); actual = replacePattern.buildReplaceString(['foo_Bar'], true); assert.equal(actual, 'newfoo_Newbar'); replacePattern = parseReplaceString('newfoo_newbar'); actual = replacePattern.buildReplaceString(['foo_BAR'], true); assert.equal(actual, 'newfoo_NEWBAR'); </ins> }); });", "commid": "vscode_pr_81781"}], "negative_passages": []}
{"query_id": "q-en-vscode-318f37c03b2fdb709168bfc4494ab2e11b939fa0f105c89349a79ed16a14b135", "query": "First, thanks for making VSCode soooo awesome! Wouldn't be as productive as I am without it Currently, VSCode suggests installing the to have support for TypeScript. However, is supposedly going to be deprecated sometime this year. ! Change the suggested extension to ESLint instead. This way, we're providing a solution to the community that is future-proof (at least for the foreseeable future) I'd be happy to open a PR if you were to accept this proposed solution. (it looks like this would be a matter of replacing the extension id here: )\nRemoving it sounds good. We already stopped recommending tslint for general ts users: Probably just remove the whole typescript section for now. Setting up eslint for TypeScript is not simple enough at the moment to show on the welcome page in my opinion Can you submit a PR that does that?\nAgree with you there. Definitely!\nI noticed you the \"help wanted\". I'm planning to submit a PR. Can we change the label indicate this issue is in progress or taken?", "positive_passages": [{"docid": "doc-en-vscode-36b1c07a7f9100d1d828e0509435947a2518111f74131701bcbdd80c233b48d3", "text": "const extensionPacks: ExtensionSuggestion[] = [ { name: localize('welcomePage.javaScript', \"JavaScript\"), id: 'dbaeumer.vscode-eslint' }, <del> { name: localize('welcomePage.typeScript', \"TypeScript\"), id: 'ms-vscode.vscode-typescript-tslint-plugin' }, </del> { name: localize('welcomePage.python', \"Python\"), id: 'ms-python.python' }, // { name: localize('welcomePage.go', \"Go\"), id: 'lukehoban.go' }, { name: localize('welcomePage.php', \"PHP\"), id: 'felixfbecker.php-pack' },", "commid": "vscode_pr_82125"}], "negative_passages": []}
{"query_id": "q-en-vscode-9dc13ef188a12fd1e9d36d36fa531684de42f09668283b2c2048e06389f69714", "query": "! ! Version: 1.39.2 autoReveal always moves the filename entry to the middle in file explorer window when we select a file on tab. if the filename is not visible in the explorer, this is ok. if the filename is visible in explorer, it should not move the filename to the middle in explorer, just highlight the filename where it is, right there in explorer. thanks!\nI've taken a stab at this in as it's something that annoys me, hope that's alright", "positive_passages": [{"docid": "doc-en-vscode-cae309366b8e4dcda5a3665b7bb089e079f05af5e5649ac4d91ef4a8cd13bb56", "text": "if (item.isDisposed) { return this.onSelectResource(resource, reveal, retry + 1); } <del> this.tree.reveal(item, 0.5); </del> <ins> // Don't scroll to the item if it's already visible if (this.tree.getRelativeTop(item) === null) { this.tree.reveal(item, 0.5); } </ins> } this.tree.setFocus([item]);", "commid": "vscode_pr_90626"}], "negative_passages": []}
{"query_id": "q-en-vscode-67ee5005535b2dee1f905472dadf438fd96363a412bcbbb6a5c29ca524430ed1", "query": "I'd love it if the description would specify that this setting only pertains to the command as explained in , as opposed to the SCM interface, which would be the expected behavior according to the current description.\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.564 --<!-- potentialduplicatescomment --\nFeel free to submit a PR for this instead. Here's where you want to edit:\nCool, thanks!", "positive_passages": [{"docid": "doc-en-vscode-3999822792c3518bc851a7dc63622aa54f949bc96658351720f1e65d87eafb07", "text": "\"config.scanRepositories\": \"List of paths to search for git repositories in.\", \"config.showProgress\": \"Controls whether git actions should show progress.\", \"config.rebaseWhenSync\": \"Force git to use rebase when running the sync command.\", <del> \"config.confirmEmptyCommits\": \"Always confirm the creation of empty commits.\", </del> <ins> \"config.confirmEmptyCommits\": \"Always confirm the creation of empty commits for the 'Git: Commit Empty' command.\", </ins> \"config.fetchOnPull\": \"Fetch all branches when pulling or just the current one.\", \"config.pullTags\": \"Fetch all tags when pulling.\", \"config.autoStash\": \"Stash any changes before pulling and restore them after successful pull.\",", "commid": "vscode_pr_83257"}], "negative_passages": []}
{"query_id": "q-en-vscode-086deae9b71bd3e7ee03eb563ab9a11941d5638cc5c014b8a2f2659d6cd3364a", "query": "Babel 7.7 introduces a : , which shares the schema with . When editing a , one expect to see JSON validations same as . I tag it as feature request as Babel 7.7 is not yet released.\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.92 --<!-- potentialduplicatescomment --", "positive_passages": [{"docid": "doc-en-vscode-923ff51d90b0f6179b1a55fc74eb18bf246d0d22ee8cf55b38f9fb49b523e073", "text": "\"url\": \"https://schemastore.azurewebsites.net/schemas/json/babelrc.json\" }, { <ins> \"fileMatch\": \"babel.config.json\", \"url\": \"https://schemastore.azurewebsites.net/schemas/json/babelrc.json\" }, { </ins> \"fileMatch\": \"jsconfig.json\", \"url\": \"https://schemastore.azurewebsites.net/schemas/json/jsconfig.json\" },", "commid": "vscode_pr_83758"}], "negative_passages": []}
{"query_id": "q-en-vscode-09ceea76ba7003edf983f966a44f1220c3db857db7ca744b34cc91e46232539f", "query": "Issue Type: <bBug</bReopening of steps the intergrated terminal. a command that generates more than one screen of content: to bottom run emacs and then close emacs using ctrl+c ctrl+x Bug Terminal scroll position is sometimes reset to top of buffer ! VS Code version: Code - Insiders 1.40.0-insider (, 2019-11-06T16:56:25.487Z) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nCan't repro some things that might help diagnose: Debug VS Code to see what's getting hitting hit. Calls to this when exiting would be particularly interesting Try repro in the demo Enable escape sequence logging and capture the entering emacs logs and exit emacs logs for both the case where it's fine and the case where the scroll is off.\nSeems to happen most reliably when I run emacs as the git editor, but as the screenshot shows it can also happen for normal runs. From debugging: Normal case called with called twice with not called by Bugged case called with called with called again called by with\nThat's definitely the problem, could you get the stacktrace for both of those?\nStacks look the same. Here called with : ! : And with : ! It seems like a timing issue. Between the call to which sets and , someone else is setting . Here's one possible call sequences I see opening emacs in the bad case (true/false is the value of ): ! And from the good case: ! For what it's worth, I also currently see this more often in insiders (vs OSS)\nI don't use emacs or something, just run some tests which output a lot of stuff, then hide and unhide terminal - after a couple of moments I am on top of terminal. Scrolling it with a scrollbar to the bottom doesn't bring me to the last line, so I press enter\nYeah, I have to press enter to get to the bottom of the terminal. I can confirm that this is an issue with Linux and Windows (I see this on both), so it doesn't appear to be specific to any OS. This also happens with both native and remote development, so it is not specific to remote development (which I use a lot). For me, it starts happening after about an hour of use, and then becomes really frequent (almost every time I open the terminal). Its causing me to form a habitual response to just always press enter when I open the terminal :frowning_face:\nAnother repro:\nThe case seems to be a symptom of the TerminalPanel onDidChangeVisibility callback not triggering a setVisible call on the active terminal instance. The code to re-sync the the Terminal viewport and scrollbar is in the TerminalInstance setVisible method. I'm not sure if it's the same issue as the Emacs variation of the bug.\nI'm also having this issue. When I toggle open the terminal on WSL and PowerShell, the terminal is scrolled to the top, even with all extensions disabled. I'm not using emacs - it happens reliably regardless of the type of content in the terminal. Just focusing on the terminal doesn't have this behavior, only toggling it does.\nUpdate: for anyone looking for a temporary fix, I used the extension \"multi-command\" and set up a shortcut to scroll the terminal to the bottom when opening it. Since I needed to first focus the terminal after opening it, I had to set up two cases, toggling when it's closed and toggling when it's already open: \"multiCommand.commands\": [ { \"command\": \"multiCommand.toggleTermClosed\", \"sequence\": [ \"\", \"\", \"\", ] }, { \"command\": \"multiCommand.toggleTermOpen\", \"sequence\": [ \"\", ] } ]`\nverified with steps from", "positive_passages": [{"docid": "doc-en-vscode-e5430b3e2df4a598a497b97353c8d7ff905b48c970d55a05aadde9ada5c479ed", "text": "if (this._terminalService.terminalInstances.length > 0) { this._updateFont(); this._updateTheme(); <ins> this._terminalService.getActiveTab()?.setVisible(visible); </ins> } else { // Check if instances were already restored as part of workbench restore if (this._terminalService.terminalInstances.length === 0) {", "commid": "vscode_pr_88098"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdbe74a5d08107a8b0de08ffcc2827c57a905bff82be3f73473540155c72786e", "query": "Issue Type: <bBug</bTypeScript references code lenses the VS Code Code base, open the line: After type a comma then and re-type again Bug Suggestions take forever to come in Computing the references in TypeScript can potentially be expensive. This is caused because the method is not being as aggressively canceled when the document changes as I expect it to be (and as I believe it used to be) We can workaround this on the TS side but it seems like unexpected behavior /cc VS Code version: Code - OSS Dev 1.41.0 (Commit unknown, Date unknown) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nAdds a TS specific fix. Whenever the document changes, we now aggressively cancel all existing code lens requests against the TS server for that document\nI believe nothing has changed here - at least not as far as my recent memory goes... Cancellation happens after 250ms which isn't aggressive but should also not be perceived as overly slow. Are those 250ms the delay you were seeing?\nthe delay is more like several seconds. It could be because we now provide references code lenses for object members, which adds a lot more references for TS to compute.\nhm... but the delay/debounce on the by this... Does work happens on the extension host thread (not the tsserver-process) so that the cancellation doesn't come through until the event loop is free again?\nOk, so after more digging, I don't think is related to the debounce. Instead it seems some calls to are not ever canceled when the document changes. Here's the basic sequence I see on the extension host side: The issue is that the first batch of resolve requests (40-49) are not cancelled when they should be Resolving individual TS code lenses can take around a second in some cases\nNice find and kudos for digging through that code", "positive_passages": [{"docid": "doc-en-vscode-85c10484a2787d075d31dc3a60001d736660dce2c7d4dd3a896b1582e675158f", "text": "return; } <del> this._currentResolveCodeLensSymbolsPromise = createCancelablePromise(token => { </del> <ins> const resolvePromise = createCancelablePromise(token => { </ins> const promises = toResolve.map((request, i) => {", "commid": "vscode_pr_84331"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdbe74a5d08107a8b0de08ffcc2827c57a905bff82be3f73473540155c72786e", "query": "Issue Type: <bBug</bTypeScript references code lenses the VS Code Code base, open the line: After type a comma then and re-type again Bug Suggestions take forever to come in Computing the references in TypeScript can potentially be expensive. This is caused because the method is not being as aggressively canceled when the document changes as I expect it to be (and as I believe it used to be) We can workaround this on the TS side but it seems like unexpected behavior /cc VS Code version: Code - OSS Dev 1.41.0 (Commit unknown, Date unknown) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nAdds a TS specific fix. Whenever the document changes, we now aggressively cancel all existing code lens requests against the TS server for that document\nI believe nothing has changed here - at least not as far as my recent memory goes... Cancellation happens after 250ms which isn't aggressive but should also not be perceived as overly slow. Are those 250ms the delay you were seeing?\nthe delay is more like several seconds. It could be because we now provide references code lenses for object members, which adds a lot more references for TS to compute.\nhm... but the delay/debounce on the by this... Does work happens on the extension host thread (not the tsserver-process) so that the cancellation doesn't come through until the event loop is free again?\nOk, so after more digging, I don't think is related to the debounce. Instead it seems some calls to are not ever canceled when the document changes. Here's the basic sequence I see on the extension host side: The issue is that the first batch of resolve requests (40-49) are not cancelled when they should be Resolving individual TS code lenses can take around a second in some cases\nNice find and kudos for digging through that code", "positive_passages": [{"docid": "doc-en-vscode-a4bd79530d67cd11680aef1882fc966d47d19cf5d0b013ea8fdf99db7a664e78", "text": "return Promise.all(promises); }); <ins> this._currentResolveCodeLensSymbolsPromise = resolvePromise; </ins> this._currentResolveCodeLensSymbolsPromise.then(() => { if (this._currentCodeLensModel) { // update the cached state with new resolved items this._codeLensCache.put(model, this._currentCodeLensModel); } this._oldCodeLensModels.clear(); // dispose old models once we have updated the UI with the current model <del> this._currentResolveCodeLensSymbolsPromise = undefined; </del> <ins> if (resolvePromise === this._currentResolveCodeLensSymbolsPromise) { this._currentResolveCodeLensSymbolsPromise = undefined; } </ins> }, err => { onUnexpectedError(err); // can also be cancellation! <del> this._currentResolveCodeLensSymbolsPromise = undefined; </del> <ins> if (resolvePromise === this._currentResolveCodeLensSymbolsPromise) { this._currentResolveCodeLensSymbolsPromise = undefined; } </ins> }); } }", "commid": "vscode_pr_84331"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-6213c185ebfb9046fe36e380b1fe21aaa8eda199e93717d2e35bed5566f9f526", "text": "} <del> export function findValidPasteFileTarget(explorerService: IExplorerService, targetFolder: ExplorerItem, fileToPaste: { resource: URI; isDirectory?: boolean; allowOverwrite: boolean }, incrementalNaming: 'simple' | 'smart'): URI { </del> <ins> export function findValidPasteFileTarget(explorerService: IExplorerService, targetFolder: ExplorerItem, fileToPaste: { resource: URI; isDirectory?: boolean; allowOverwrite: boolean }, incrementalNaming: 'simple' | 'smart' | 'disabled'): URI { </ins> let name = resources.basenameOrAuthority(fileToPaste.resource); let candidate = resources.joinPath(targetFolder.resource, name);", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-eb26e614d10370ed9d3cbf3a0d6d83c2780d8126bdfaece77acadb697ecd176d", "text": "break; } <del> name = incrementFileName(name, !!fileToPaste.isDirectory, incrementalNaming); </del> <ins> if (incrementalNaming !== 'disabled') { name = incrementFileName(name, !!fileToPaste.isDirectory, incrementalNaming); } </ins> candidate = resources.joinPath(targetFolder.resource, name); }", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-e2159fd25b5882bd5d61cb1e8d019a8a685e7f30126ff93eff7a0ebb973f5350", "text": "const context = explorerService.getContext(true); const toPaste = resources.distinctParents(await clipboardService.readResources(), r => r); const element = context.length ? context[0] : explorerService.roots[0]; <ins> const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; </ins> try { // Check if target is ancestor of pasted folder", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-abd2aabb8174bfce1d079cdb8fece89857b400ef742d8ef8ed51cbc874eaec01", "text": "target = element.isDirectory ? element : element.parent!; } <del> const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove }, incrementalNaming); </del> <ins> const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming); </ins> return { source: fileToPaste, target: targetFile }; }));", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-a3f3a1d02f624b4cbfb465b5b6bcf0a08bb9837f0ffb0839c468a4d7e92747ff", "text": "}; await explorerService.applyBulkEdit(resourceFileEdits, options); } else { <del> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { copy: true })); </del> <ins> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { copy: true, overwrite: incrementalNaming === 'disabled' })); </ins> const undoLevel = configurationService.getValue<IFilesConfiguration>().explorer.confirmUndo; const options = { confirmBeforeUndo: undoLevel === UndoConfirmLevel.Default || undoLevel === UndoConfirmLevel.Verbose,", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-681c49d5483f7b2c7b618e992db560297cc15f3c53f1eb1bad522c4d844df6cd", "text": "}, 'explorer.incrementalNaming': { 'type': 'string', <del> enum: ['simple', 'smart'], </del> <ins> enum: ['simple', 'smart', 'disabled'], </ins> enumDescriptions: [ nls.localize('simple', \"Appends the word \"copy\" at the end of the duplicated name potentially followed by a number\"), <del> nls.localize('smart', \"Adds a number at the end of the duplicated name. If some number is already part of the name, tries to increase that number\") </del> <ins> nls.localize('smart', \"Adds a number at the end of the duplicated name. If some number is already part of the name, tries to increase that number\"), nls.localize('disabled', \"Disables incremental naming. If two files with the same name exist you will be prompted to overwrite the existing file\") </ins> ], description: nls.localize('explorer.incrementalNaming', \"Controls what naming strategy to use when a giving a new name to a duplicated explorer item on paste.\"), default: 'simple'", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ef75b3ae9a96bc2cc7c908e5306b5d52d1d75fedfcffbbc5906ba57a83b7d70", "query": "Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nWe are open to a PR which adds the option to the setting. Code pointer\nTo verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file", "positive_passages": [{"docid": "doc-en-vscode-62072756089611d3da46ba59a39d5d7f98d8ce73b853c518ad973de300bd4669", "text": "colors: boolean; badges: boolean; }; <del> incrementalNaming: 'simple' | 'smart'; </del> <ins> incrementalNaming: 'simple' | 'smart' | 'disabled'; </ins> excludeGitIgnore: boolean; fileNesting: { enabled: boolean;", "commid": "vscode_pr_160218"}], "negative_passages": []}
{"query_id": "q-en-vscode-759949766640196ce8609ca3a227858e9a5dfc7d2effcd4e5bfea3ce215e67d8", "query": "<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: code-server2.1692-vsc1.39.2-linux-x86_64 and a few previous OS Version: Fedora 31 Firefox 70 @ Windows 10 1909 I am running VS Code remotely via code-server. When I use Find function to search something, then press Esc to exit search field and try to insert a new line by Enter, the search field is opened instead of inserting a new line. It works fine in Chrome though. +F, type a text, press Enter Esc to exit search field, eventually press End to deselect found text Enter field is opened again instead of inserting a new line <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.482 --<!-- potentialduplicatescomment --\nA similar issue was reported for the monaco-editor. The cause and fix should be the same, so I'm linking it here:\nYes, monaco playground behaves the same on my side.\nI wonder if this issue is reproducible when running VSCode in a browser. We allow to run VSCode in a very simplified form in a browser following these steps: setup to be able to run VSCode out of sources: run from a command line it should open a browser with VSCode running If you are not able to set this up, we also provide a hosted version of VSCode for Web at: https://vscode-web-test- Does the issue reproduce in that setup in the browser?\nI just tried the web version and it reproduces there, too.\nI have tested the playground on azurewebsites and the issue is reproducible. !\nThanks for testing\nThis problem happens to me too, when using codercom/code-server:2.1688-vsc1.39.2 in Firefox Linux. Enter starts working again when you close the Find box enough times by clicking it instead of pressing Escape.", "positive_passages": [{"docid": "doc-en-vscode-20ca8f34555758ae02afd59981504f36b0b91aad24b7a8047326c8fa14ca1eef", "text": "} public disable(): void { <ins> this.blur(); </ins> this.input.disabled = true; this._hideMessage(); }", "commid": "vscode_pr_85094"}], "negative_passages": []}
{"query_id": "q-en-vscode-e585ddeba652daa41182440f9890d68f68f1a8e9d37c5b1a940c52e260538de0", "query": "VS Code has support for . It would be nice to also have support for \"normal\" region folding.\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.732 --- <!-- score: 0.506 --- <!-- score: 0.503 --- <!-- score: 0.456 --<!-- potentialduplicatescomment --", "positive_passages": [{"docid": "doc-en-vscode-367f5d0f1b0a4e2d2fdfc171d159f40e951b0870f5c2b9b18a5e0ccf7eaeb7ad", "text": "], \"folding\": { \"markers\": { <del> \"start\": \"^=pods*$\", \"end\": \"^=cuts*$\" </del> <ins> \"start\": \"^(?:(?:=pods*$)|(?:s*#regionb))\", \"end\": \"^(?:(?:=cuts*$)|(?:s*#endregionb))\" </ins> } } }  No newline at end of file", "commid": "vscode_pr_85642"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-09adf1a1c592b5c38eaa93426ef3de728120c02f02756a6def6cde761ec85823", "text": "description: localize('symbolSortOrder', \"Controls how symbols are sorted in the breadcrumbs outline view.\"), type: 'string', default: 'position', <ins> overridable: true, </ins> enum: ['position', 'name', 'type'], enumDescriptions: [ localize('symbolSortOrder.position', \"Show symbol outline in file position order.\"),", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-e77c4e42b0dadb2802ebbfa3bb629959e22e510376202a79f0bbf99af3c73f14", "text": "import { URI } from 'vs/base/common/uri'; import 'vs/css!./media/breadcrumbscontrol'; import { OutlineElement, OutlineModel, TreeElement } from 'vs/editor/contrib/documentSymbols/outlineModel'; <del> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </del> <ins> import { IConfigurationService, IConfigurationOverrides } from 'vs/platform/configuration/common/configuration'; </ins> import { FileKind, IFileService, IFileStat } from 'vs/platform/files/common/files'; import { IConstructorSignature1, IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { WorkbenchDataTree, WorkbenchAsyncDataTree } from 'vs/platform/list/browser/listService';", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-7c544ec327ffa5a95056047a102ce46b5bc5f6773cd49f72ec9097661dd4b3ce", "text": "export class BreadcrumbsOutlinePicker extends BreadcrumbsPicker { protected readonly _symbolSortOrder: BreadcrumbsConfig<'position' | 'name' | 'type'>; <ins> protected _outlineComparator: OutlineItemComparator; </ins> constructor( parent: HTMLElement,", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-ed0d5de5f7682dcc547d33e84e791c4bcfbaf7603c1786e8a5fb987af908a4e8", "text": ") { super(parent, instantiationService, themeService, configurationService); this._symbolSortOrder = BreadcrumbsConfig.SymbolSortOrder.bindTo(this._configurationService); <ins> this._outlineComparator = new OutlineItemComparator(); </ins> } protected _createTree(container: HTMLElement) {", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-f33528c4e61fbcf0fc2379b29de0cddf3528167e82b7ec15009f737c714900d5", "text": "collapseByDefault: true, expandOnlyOnTwistieClick: true, multipleSelectionSupport: false, <del> sorter: new OutlineItemComparator(this._getOutlineItemCompareType()), </del> <ins> sorter: this._outlineComparator, </ins> identityProvider: new OutlineIdentityProvider(), keyboardNavigationLabelProvider: new OutlineNavigationLabelProvider(), filter: this._instantiationService.createInstance(OutlineFilter, 'breadcrumbs')", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-ea15c63118d4d79279690d6abf91a98ad563cb8732efe82457fa763409f0c728", "text": "const tree = this._tree as WorkbenchDataTree<OutlineModel, any, FuzzyScore>; tree.setInput(model); <ins> const textModel = model.textModel; const overrideConfiguration = { resource: textModel.uri, overrideIdentifier: textModel.getLanguageIdentifier().language }; this._outlineComparator.type = this._getOutlineItemCompareType(overrideConfiguration); </ins> if (element !== model) { tree.reveal(element, 0.5); tree.setFocus([element], this._fakeEvent);", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-eace274717908d9a1cf27b03af1a9b22158f8e0b01a8018eba21b311693c945a", "query": "The setting \"breadcrumbs.symbolSortOrder\" cannot be enabled for a specific language, i.e. \"[markdown]\": { \"breadcrumbs.symbolSortOrder\": \"position\" } is not possible in the settings. It makes sense to sort by position in markdown files to see headers and subheaders as they are. However, one might want to display symbols by type when writing code. Thank you in advance!\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!\nActually not a duplicate but should be straight forward to implement as filter-options can already be defined per language\nCould you point me towards how to get the current resource from the editor model inside ?\nThe  has a reference to the text model\nto verify, have this setting and a file with this content (symbol should be sorted alphabetically) Now, paste the same content into and make sure symbols are sorted by position", "positive_passages": [{"docid": "doc-en-vscode-8a628391e95bcd2ed30f536903bcab0e9e462d13c491f603f43ecd689bf1d8e7", "text": "} } <del> private _getOutlineItemCompareType(): OutlineSortOrder { switch (this._symbolSortOrder.getValue()) { </del> <ins> private _getOutlineItemCompareType(overrideConfiguration?: IConfigurationOverrides): OutlineSortOrder { switch (this._symbolSortOrder.getValue(overrideConfiguration)) { </ins> case 'name': return OutlineSortOrder.ByName; case 'type':", "commid": "vscode_pr_86430"}], "negative_passages": []}
{"query_id": "q-en-vscode-2788b7860a6fe84c04ff446d0b67506f64215cbf780377e8f0d6662eff0ba10b", "query": "insiders, install remote SSH extension the Remote view container all the views via context menu menu on the title -the views are not there and they can not be brought back -the views are back -I would expect the hidden state to be preserved fyi !\nAssigning to as remote viewlet has special treatment.\nOriginal decision was that none of the views in the filter-view should be hide-able. Looks like I missed a spot!", "positive_passages": [{"docid": "doc-en-vscode-c4b548c98983b7beeb1eceec924b5bad8c70fc8eedd84e24bd6c53742edb7337", "text": "this.focus(); } <del> getContextMenuActions(): IAction[] { </del> <ins> getContextMenuActions(viewDescriptor?: IViewDescriptor): IAction[] { </ins> const result: IAction[] = []; <ins> if (viewDescriptor) { result.push(<IAction>{ id: `${viewDescriptor.id}.removeView`, label: localize('hideView', \"Hide\"), enabled: viewDescriptor.canToggleVisibility, run: () => this.toggleViewVisibility(viewDescriptor.id) }); } </ins> const viewToggleActions = this.viewsModel.viewDescriptors.map(viewDescriptor => (<IAction>{ id: `${viewDescriptor.id}.toggleVisibility`, label: viewDescriptor.name,", "commid": "vscode_pr_86110"}], "negative_passages": []}
{"query_id": "q-en-vscode-2788b7860a6fe84c04ff446d0b67506f64215cbf780377e8f0d6662eff0ba10b", "query": "insiders, install remote SSH extension the Remote view container all the views via context menu menu on the title -the views are not there and they can not be brought back -the views are back -I would expect the hidden state to be preserved fyi !\nAssigning to as remote viewlet has special treatment.\nOriginal decision was that none of the views in the filter-view should be hide-able. Looks like I missed a spot!", "positive_passages": [{"docid": "doc-en-vscode-a93fcc8a1cccfd17a5d74787b7615e1f387a688ac9a31261ea99842577160e55", "text": "run: () => this.toggleViewVisibility(viewDescriptor.id) })); <ins> if (result.length && viewToggleActions.length) { result.push(new Separator()); } </ins> result.push(...viewToggleActions); const parentActions = this.getViewletContextMenuActions(); <del> if (viewToggleActions.length && parentActions.length) { </del> <ins> if (result.length && parentActions.length) { </ins> result.push(new Separator()); } result.push(...parentActions); return result; }", "commid": "vscode_pr_86110"}], "negative_passages": []}
{"query_id": "q-en-vscode-2788b7860a6fe84c04ff446d0b67506f64215cbf780377e8f0d6662eff0ba10b", "query": "insiders, install remote SSH extension the Remote view container all the views via context menu menu on the title -the views are not there and they can not be brought back -the views are back -I would expect the hidden state to be preserved fyi !\nAssigning to as remote viewlet has special treatment.\nOriginal decision was that none of the views in the filter-view should be hide-able. Looks like I missed a spot!", "positive_passages": [{"docid": "doc-en-vscode-7c5b01a2b09fab3ab020c2a204079049fa8ed5232201bdf10f5edbc3a8ed797c", "text": "event.stopPropagation(); event.preventDefault(); <del> const actions: IAction[] = []; actions.push(<IAction>{ id: `${viewDescriptor.id}.removeView`, label: localize('hideView', \"Hide\"), enabled: viewDescriptor.canToggleVisibility, run: () => this.toggleViewVisibility(viewDescriptor.id) }); const otherActions = this.getContextMenuActions(); if (otherActions.length) { actions.push(...[new Separator(), ...otherActions]); } </del> <ins> const actions: IAction[] = this.getContextMenuActions(viewDescriptor); </ins> let anchor: { x: number, y: number } = { x: event.posx, y: event.posy }; this.contextMenuService.showContextMenu({", "commid": "vscode_pr_86110"}], "negative_passages": []}
{"query_id": "q-en-vscode-d9c611348efd100569cc7cce7629399b011130480e9173ddad712cbc676ea2d2", "query": "VSCode Version: 1.41.0 OS Version: Not applicable Steps to Reproduce: to row 231 that the word 'must' is unexpectedly repeated. Does this issue occur when all extensions are disabled?: Yes\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.555 --- <!-- score: 0.539 --<!-- potentialduplicatescomment --", "positive_passages": [{"docid": "doc-en-vscode-a051cddc2917ee85fdfecaab15dae3de31a3480a65068e71579af77f608ac4fc", "text": "if (contribution.scopes) { if ((!Array.isArray(contribution.scopes) || contribution.scopes.some(s => typeof s !== 'string'))) { <del> collector.error(nls.localize('invalid.scopes', \"If defined, 'configuration.tokenStyleDefaults.scopes' must must be an array or strings\")); </del> <ins> collector.error(nls.localize('invalid.scopes', \"If defined, 'configuration.tokenStyleDefaults.scopes' must be an array or strings\")); </ins> continue; } tokenStyleDefault.scopesToProbe = [contribution.scopes];", "commid": "vscode_pr_88468"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-91676ca0463626cb1552d14bb19792bd3106a4d529ba914dbe884cee6f580f2d", "text": "if (ranges.length > 0) { this._emitModelTokensChangedEvent({ tokenizationSupportChanged: false, <ins> semanticTokensApplied: false, </ins> ranges: ranges }); }", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-141d13b39b4fab449146a5ee3cb72fece161ac75d6e7951f704731a009c4d5f1", "text": "this._emitModelTokensChangedEvent({ tokenizationSupportChanged: false, <ins> semanticTokensApplied: tokens !== null, </ins> ranges: [{ fromLineNumber: 1, toLineNumber: this.getLineCount() }] }); }", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-54521915eb1bf971adb9783c68a668ed5448c17a82227fdd81eea6d1f470533b", "text": "this._tokens.flush(); this._emitModelTokensChangedEvent({ tokenizationSupportChanged: true, <ins> semanticTokensApplied: false, </ins> ranges: [{ fromLineNumber: 1, toLineNumber: this._buffer.getLineCount()", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-af9a7a6dcc66b9eb8a63c9de3401bd3bd0b3014f8c22062eb56027affdec2960", "text": "this._emitModelTokensChangedEvent({ tokenizationSupportChanged: false, <ins> semanticTokensApplied: false, </ins> ranges: [{ fromLineNumber: 1, toLineNumber: this.getLineCount() }] }); }", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-840c4340f9fc62b8456db2a4673d1536e3bf08ea18cd74ed0aeea561e9f4caef", "text": "*/ export interface IModelTokensChangedEvent { readonly tokenizationSupportChanged: boolean; <ins> readonly semanticTokensApplied: boolean; </ins> readonly ranges: { /** * The start of the range (inclusive)", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-05e4ca169dcc77bb54123885755ed6a4d74b5372a345c60edf8574bf7ede24ae", "text": "import './largeFileOptimizations'; import './inspectEditorTokens/inspectEditorTokens'; import './saveParticipants'; <ins> import './semanticTokensHelp'; </ins> import './toggleColumnSelection'; import './toggleMinimap'; import './toggleMultiCursorModifier';", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a3d93bac0e85e9030db26940647015adc55ed5f2a0273dee84238268fbc38a0", "query": "As mentioned in , the goal is to improve the first impression of semantic highlighting as well allow themes to opt-in to semantic highlighting. give themes a way to opt-in to semantic highlighting enable semantic coloring by default only the built-in themes. All other themes can be enabled by the theme author or in the user settings. show a notification when semantic coloring shows up the first time. The notification will point to the docs with background and information on how to configure the feature. fix the bugs found related to wrong token classification and color lookup. no longer show semantic color in imports\nI like this feature. I think an individual config is better than a global one because it will allow us to use non-maintained themes that have semantic highlighting disabled and themes that have it enabled, without having to set the global config every time we change from a theme that uses it to one that doesn't\nIt's a good default setting\nWhat are the reasons? It would be nice to know what most theme creators think, not just a few. Maybe some of us would like to use it A configuration could be to enable or disable that feature:\nChanges pushed.\nTo verify: create TypeScript file . If semantic color is enabled, , and all get the function color Open a built-in in theme, semantic color should be enabled verify that the very first time the semantic colors are show, a notification dialog is shown Install a theme from the marketplace (e.g. ), semantic color should be disabled. try and semantic highlighting should be enabled verify\n~Now that semantic highlighting is opt-in on a per theme basis, is there any way for a user to override that? I use Monokai Pro, which hasn't been updated in quite some time, and the developer seems fairly inactive now. The semantic highlighting was working great on 1.43, and I'd like to get it back now that it's been disabled in 1.43.1.~ ~I tried adding~ ~to my user config, but that didn't work.~ Edit: The above actually did work, except that semantic highlighting doesn't work on imports. I see now that this is the intended behavior. But why is semantic highlighting no longer available for import statements?\nMake sure to also remove\nSorry, I was able to get semantic highlighting working by setting the config in my previous reply. But I'm wondering if it's possible to re-enable semantic highlighting on imports. On 1.43, variable names in import statements in Javascript would be highlighted based on their type. But on 1.43.1 with semantic highlighting enabled, import lines are no longer highlighted, as noted in your original message.", "positive_passages": [{"docid": "doc-en-vscode-c32e297855c3274000bf9c2847cc9d9301d1a4e930ea491106a8593f5aaf7168", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as nls from 'vs/nls'; import * as path from 'vs/base/common/path'; import { Disposable, DisposableStore } from 'vs/base/common/lifecycle'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { registerEditorContribution } from 'vs/editor/browser/editorExtensions'; import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { URI } from 'vs/base/common/uri'; import { ITextModel } from 'vs/editor/common/model'; import { IWorkbenchThemeService } from 'vs/workbench/services/themes/common/workbenchThemeService'; /** * Shows a message when semantic tokens are shown the first time. */ export class SemanticTokensHelp extends Disposable implements IEditorContribution { public static readonly ID = 'editor.contrib.semanticHighlightHelp'; constructor( _editor: ICodeEditor, @INotificationService _notificationService: INotificationService, @IOpenerService _openerService: IOpenerService, @IWorkbenchThemeService _themeService: IWorkbenchThemeService ) { super(); const toDispose = this._register(new DisposableStore()); const localToDispose = toDispose.add(new DisposableStore()); const installChangeTokenListener = (model: ITextModel) => { localToDispose.add(model.onDidChangeTokens((e) => { if (!e.semanticTokensApplied) { return; } toDispose.dispose(); // uninstall all listeners, makes sure the notification is only shown once per window const message = nls.localize( { key: 'semanticTokensHelp', comment: [ 'Variable 0 will be a file name.', 'Variable 1 will be a theme name.' ] }, \"Semantic highlighting has been applied to '{0}' as the theme '{1}' has semantic highlighting enabled.\", path.basename(model.uri.path), _themeService.getColorTheme().label ); _notificationService.prompt(Severity.Info, message, [ { label: nls.localize('learnMoreButton', \"Learn More\"), run: () => { const url = 'https://go.microsoft.com/fwlink/?linkid=2122588'; _openerService.open(URI.parse(url)); } } ], { neverShowAgain: { id: 'editor.contrib.semanticTokensHelp' } }); })); }; const model = _editor.getModel(); if (model !== null) { installChangeTokenListener(model); } toDispose.add(_editor.onDidChangeModel((e) => { localToDispose.clear(); const model = _editor.getModel(); if (!model) { return; } installChangeTokenListener(model); })); } } registerEditorContribution(SemanticTokensHelp.ID, SemanticTokensHelp); </ins>", "commid": "vscode_pr_92739"}], "negative_passages": []}
{"query_id": "q-en-vscode-a1e6f4a9999f2d4c8067490d0315b859841126d54a3ca1fd42e9cb87ba8eadf1", "query": "Testing Why is not there a contribution point for timeline provider? Following are the advantages I am not sure how I have to activate my extension if I only contribute timeline provider. Having a timeline contribution point can allow me to activate my extension when user starts using the timeline my extension contributesAlso helps in displaying the feature contributions in extension editor view\nand I talked about supporting this originally but felt that it was something that could be later.\nHm, not sure... Somehow timeline feels like master-detail, e.g you open an editor and the timeline shows its contents. With that usage-pattern it feels wrong to have an activation event. Then there is the 'Open timeline' command which is different... You could that command as activation event and all is good\nOn what event shall an extension contributing a timeline should be activated?\nFor instance these and\nshould we support an activation? Rather than a really specific point just for the timeline?\nYeah, that would make sense\nTo verify ensure that your extension that contributes a timeline can activate properly when the timeline is revealed via the activation", "positive_passages": [{"docid": "doc-en-vscode-6135f2398d620143de164f5424b3d986e3ca955a2ea22393c9e2639085824465", "text": "import { IHoverService } from 'vs/workbench/services/hover/browser/hover'; import { IHoverDelegate, IHoverDelegateOptions } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; <ins> import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; </ins> const ItemHeight = 22;", "commid": "vscode_pr_148052"}], "negative_passages": []}
{"query_id": "q-en-vscode-a1e6f4a9999f2d4c8067490d0315b859841126d54a3ca1fd42e9cb87ba8eadf1", "query": "Testing Why is not there a contribution point for timeline provider? Following are the advantages I am not sure how I have to activate my extension if I only contribute timeline provider. Having a timeline contribution point can allow me to activate my extension when user starts using the timeline my extension contributesAlso helps in displaying the feature contributions in extension editor view\nand I talked about supporting this originally but felt that it was something that could be later.\nHm, not sure... Somehow timeline feels like master-detail, e.g you open an editor and the timeline shows its contents. With that usage-pattern it feels wrong to have an activation event. Then there is the 'Open timeline' command which is different... You could that command as activation event and all is good\nOn what event shall an extension contributing a timeline should be activated?\nFor instance these and\nshould we support an activation? Rather than a really specific point just for the timeline?\nYeah, that would make sense\nTo verify ensure that your extension that contributes a timeline can activate properly when the timeline is revealed via the activation", "positive_passages": [{"docid": "doc-en-vscode-ad1d9760292c2116b9d92fbe1e3b4d4427a517a5fb5a7c4aab99d72529dd54d2", "text": "@IThemeService themeService: IThemeService, @ITelemetryService telemetryService: ITelemetryService, @ILabelService private readonly labelService: ILabelService, <del> @IUriIdentityService private readonly uriIdentityService: IUriIdentityService </del> <ins> @IUriIdentityService private readonly uriIdentityService: IUriIdentityService, @IExtensionService private readonly extensionService: IExtensionService, </ins> ) { super({ ...options, titleMenuId: MenuId.TimelineTitle }, keybindingService, contextMenuService, configurationService, contextKeyService, viewDescriptorService, instantiationService, openerService, themeService, telemetryService);", "commid": "vscode_pr_148052"}], "negative_passages": []}
{"query_id": "q-en-vscode-a1e6f4a9999f2d4c8067490d0315b859841126d54a3ca1fd42e9cb87ba8eadf1", "query": "Testing Why is not there a contribution point for timeline provider? Following are the advantages I am not sure how I have to activate my extension if I only contribute timeline provider. Having a timeline contribution point can allow me to activate my extension when user starts using the timeline my extension contributesAlso helps in displaying the feature contributions in extension editor view\nand I talked about supporting this originally but felt that it was something that could be later.\nHm, not sure... Somehow timeline feels like master-detail, e.g you open an editor and the timeline shows its contents. With that usage-pattern it feels wrong to have an activation event. Then there is the 'Open timeline' command which is different... You could that command as activation event and all is good\nOn what event shall an extension contributing a timeline should be activated?\nFor instance these and\nshould we support an activation? Rather than a really specific point just for the timeline?\nYeah, that would make sense\nTo verify ensure that your extension that contributes a timeline can activate properly when the timeline is revealed via the activation", "positive_passages": [{"docid": "doc-en-vscode-8494c3bc0ff614edbcaeff6808a05c26772b6a2e601b6e1f82fcdefc6df21517", "text": "override setVisible(visible: boolean): void { if (visible) { <ins> this.extensionService.activateByEvent('onView:timeline'); </ins> this.visibilityDisposables = new DisposableStore(); this.editorService.onDidActiveEditorChange(this.onActiveEditorChanged, this, this.visibilityDisposables);", "commid": "vscode_pr_148052"}], "negative_passages": []}
{"query_id": "q-en-vscode-e26c10db1492448a903a8260435bc166d3d24de9c0106b181366898660e98e5c", "query": "Issue Type: <bBug</bI moved all views in panel to sidebar and VSCode crashed the first time I pressed ctrl + j to show panel. I can consistently repro this issue. VS Code version: Code - Insiders 1.44.0-insider (, 2020-04-03T23:31:33.481Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\nTo Verify: all panels to the sidebar (panel will hide) Ctrl+J that the panel opens to an empty view e.g. (empty Terminal View) and that you do not crash. We will iterate on a better UX next milestone.\nI made this change as the safest option for now. If you have a better solution that warrants another fix, please take over. Otherwise, will roll with this.\nYah looks the safest fix for now. Seems panel is not ready to handle no active panels. Is there a follow up issue for this created?\nbut the panel does handle no active panels if you run the command instead of (<kbdCtrl</kbd+<kbdJ</kbd) !\nYeah there are some issues with it and it is not working always. Hence we did a safe fix for now. We are working on this with proper UX for next milestone.", "positive_passages": [{"docid": "doc-en-vscode-640869d149e5b47222e5d20032c98e769cf44263fc1a8938a983a7f98619dca4", "text": "const viewContainer = this.getViewContainer(panelDescriptor.id); if (viewContainer?.hideIfEmpty) { const viewDescriptors = this.viewDescriptorService.getViewDescriptors(viewContainer); <del> if (viewDescriptors.activeViewDescriptors.length === 0) { </del> <ins> if (viewDescriptors.activeViewDescriptors.length === 0 && this.compositeBar.getPinnedComposites().length > 1) { </ins> this.hideComposite(panelDescriptor.id); // Update the composite bar by hiding } }", "commid": "vscode_pr_94566"}], "negative_passages": []}
{"query_id": "q-en-vscode-9fd932f7bd69a8995d71967120fe6a03d3017c928fe98a76869946a723a4cb4b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.44.0 OS Version: PopOS! 19.10 Steps to Reproduce: Not necessary, it's just a typo._ <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. The description string for is , should be . I know this is a very minor cosmetic issue, but I thought I bring it up anyway.", "positive_passages": [{"docid": "doc-en-vscode-971d2dc510d110c441e510652f06317474dd727715848f7e6639c6ef4b34f801", "text": "\"config.enableSmartCommit\": \"Commit all changes when there are no staged changes.\", \"config.smartCommitChanges\": \"Control which changes are automatically staged by Smart Commit.\", \"config.smartCommitChanges.all\": \"Automatically stage all changes.\", <del> \"config.smartCommitChanges.tracked\": \"Automatically staged tracked changes only.\", </del> <ins> \"config.smartCommitChanges.tracked\": \"Automatically stage tracked changes only.\", </ins> \"config.suggestSmartCommit\": \"Suggests to enable smart commit (commit all changes when there are no staged changes).\", \"config.enableCommitSigning\": \"Enables commit signing with GPG.\", \"config.discardAllScope\": \"Controls what changes are discarded by the `Discard all changes` command. `all` discards all changes. `tracked` discards only tracked files. `prompt` shows a prompt dialog every time the action is run.\",", "commid": "vscode_pr_94993"}], "negative_passages": []}
{"query_id": "q-en-vscode-25bdf6104af2e1fe18d7d66c97ef98b3d2496a4e5e25d097d7777aee00da980b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.44.1 OS Version: Linux 5.6.4-arch1-1 SMP PREEMPT x86_64 GNU/Linux Steps to Reproduce: a symbolic link to the VSCode starting script with a space in the name. For example: \"My VSCode\" from the terminal Error is printed to the terminal: All in the starting script () should be enclosed in double quotes to avoid this error. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes\nI can take this!\ngreat!", "positive_passages": [{"docid": "doc-en-vscode-7fe3ea40204204501b598a4d922d8a8a71f6f70e77499dbc38c624a49a4b2918", "text": "fi fi <del> if [ ! -L $0 ]; then </del> <ins> if [ ! -L \"$0\" ]; then </ins> # if path is not a symlink, find relatively <del> VSCODE_PATH=\"$(dirname $0)/..\" </del> <ins> VSCODE_PATH=\"$(dirname \"$0\")/..\" </ins> else if command -v readlink >/dev/null; then # if readlink exists, follow the symlink and find relatively <del> VSCODE_PATH=\"$(dirname $(readlink -f $0))/..\" </del> <ins> VSCODE_PATH=\"$(dirname $(readlink -f \"$0\"))/..\" </ins> else # else use the standard install location VSCODE_PATH=\"/usr/share/@@NAME@@\"", "commid": "vscode_pr_97527"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-144bc7c402a35b7176c026ae0b653e3fa5a14b9a15672c9f3cb3a2c7f6a904f7", "text": "// create the suggestion resolver if (typeof provider.resolveCompletionItem !== 'function') { this._resolveCache = Promise.resolve(); <ins> this._isResolved = true; </ins> } } // resolving get isResolved() { <del> return Boolean(this._resolveCache); </del> <ins> return Boolean(this._isResolved); </ins> } private _resolveCache?: Promise<void>; <ins> private _isResolved?: boolean; </ins> async resolve(token: CancellationToken) { if (!this._resolveCache) { const sub = token.onCancellationRequested(() => { this._resolveCache = undefined; <ins> this._isResolved = false; </ins> }); this._resolveCache = Promise.resolve(this.provider.resolveCompletionItem!(this.completion, token)).then(value => { Object.assign(this.completion, value); <ins> this._isResolved = true; </ins> sub.dispose(); }, err => { if (isPromiseCanceledError(err)) { // the IPC queue will reject the request with the // cancellation error -> reset cached this._resolveCache = undefined; <ins> this._isResolved = false; </ins> } }); }", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-7e37cb09ea19c4e88aa358824579d6ed1dbeaf72b86ab7c9d98e8dc7bfdc10dc", "text": "import { EditorOption } from 'vs/editor/common/config/editorOptions'; import * as platform from 'vs/base/common/platform'; import { MenuRegistry } from 'vs/platform/actions/common/actions'; <ins> import { CancellationTokenSource } from 'vs/base/common/cancellation'; </ins> // sticky suggest widget which doesn't disappear on focus out and such let _sticky = false;", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-740736fa59194bde8ee9c7b52b32db832e6846788c416a3a96bdf721417cf03c", "text": "const modelVersionNow = model.getAlternativeVersionId(); const { item } = event; <ins> // const tasks: Promise<any>[] = []; const cts = new CancellationTokenSource(); </ins> // pushing undo stops *before* additional text edits and // *after* the main edit if (!(flags & InsertFlags.NoBeforeUndoStop)) {", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-3bb46772a83bf1cace1ea0103618c97288a89e0a7f27300e915fb354d1e7e26b", "text": "// keep item in memory this._memoryService.memorize(model, this.editor.getPosition(), item); <del> const scrollState = StableEditorScrollState.capture(this.editor); </del> if (Array.isArray(item.completion.additionalTextEdits)) { <del> this.editor.executeEdits('suggestController.additionalTextEdits', item.completion.additionalTextEdits.map(edit => EditOperation.replace(Range.lift(edit.range), edit.text))); </del> <ins> // sync additional edits const scrollState = StableEditorScrollState.capture(this.editor); this.editor.executeEdits( 'suggestController.additionalTextEdits.sync', item.completion.additionalTextEdits.map(edit => EditOperation.replace(Range.lift(edit.range), edit.text)) ); scrollState.restoreRelativeVerticalPositionOfCursor(this.editor); } else if (!item.isResolved) { // async additional edits let position: IPosition | undefined; const docListener = model.onDidChangeContent(e => { if (e.isFlush) { cts.cancel(); docListener.dispose(); return; } for (let change of e.changes) { const thisPosition = Range.getEndPosition(change.range); if (!position || Position.isBefore(thisPosition, position)) { position = thisPosition; } } }); let oldFlags = flags; flags |= InsertFlags.NoAfterUndoStop; let didType = false; let typeListener = this.editor.onWillType(() => { typeListener.dispose(); didType = true; if (!(oldFlags & InsertFlags.NoAfterUndoStop)) { this.editor.pushUndoStop(); } }); tasks.push(item.resolve(cts.token).then(() => { if (!item.completion.additionalTextEdits || cts.token.isCancellationRequested) { return; } if (position && item.completion.additionalTextEdits.some(edit => Position.isBefore(position!, Range.getStartPosition(edit.range)))) { return; } if (didType) { this.editor.pushUndoStop(); } this.editor.executeEdits( 'suggestController.additionalTextEdits.async', item.completion.additionalTextEdits.map(edit => EditOperation.replace(Range.lift(edit.range), edit.text)) ); if (didType || !(oldFlags & InsertFlags.NoAfterUndoStop)) { this.editor.pushUndoStop(); } }).finally(() => { docListener.dispose(); typeListener.dispose(); })); </ins> } let { insertText } = item.completion;", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-691a7f2b90f70f8df67cf51cf52d492e30755e522ae9cedf98d4f6df68a48194", "text": "adjustWhitespace: !(item.completion.insertTextRules! & CompletionItemInsertTextRule.KeepWhitespace) }); <del> scrollState.restoreRelativeVerticalPositionOfCursor(this.editor); </del> if (!(flags & InsertFlags.NoAfterUndoStop)) { this.editor.pushUndoStop(); }", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-a2d26c14d37bad1726b9c40aa189c05d836651fcf0b00a2b13025f32012e3259", "text": "if (!item.completion.command) { // done this.model.cancel(); <del> this.model.clear(); </del> } else if (item.completion.command.id === TriggerSuggestAction.id) { // retigger", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-dc025a75e3870c5c079209247f530ba71028d381447e23d7434665c38b8fd0d8", "text": "} else { // exec command, done <del> this._commandService.executeCommand(item.completion.command.id, ...(item.completion.command.arguments ? [...item.completion.command.arguments] : [])) .catch(onUnexpectedError) .finally(() => this.model.clear()); // <- clear only now, keep commands alive </del> <ins> tasks.push(this._commandService.executeCommand(item.completion.command.id, ...(item.completion.command.arguments ? [...item.completion.command.arguments] : [])).catch(onUnexpectedError)); </ins> this.model.cancel(); } if (flags & InsertFlags.KeepAlternativeSuggestions) { this._alternatives.value.set(event, next => { <ins> // cancel resolving of additional edits cts.cancel(); </ins> // this is not so pretty. when inserting the 'next' // suggestion we undo until we are at the state at // which we were before inserting the previous suggestion...", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-dcba478c00282f07dbc20aac1f5073f6e1ed45475b89fc6665b0bc145737a28c", "text": "} this._alertCompletionItem(item); <ins> // clear only now - after all tasks are done Promise.all(tasks).finally(() => { this.model.clear(); cts.dispose(); }); </ins> } getOverwriteInfo(item: CompletionItem, toggleMode: boolean): { overwriteBefore: number, overwriteAfter: number } {", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-7d3768d147f02f8fe7021a5510e936e0994e773487d69a7fe70de0ad8d148343", "text": "import { SnippetController2 } from 'vs/editor/contrib/snippet/snippetController2'; import { IMenuService, IMenu } from 'vs/platform/actions/common/actions'; import { createTextModel } from 'vs/editor/test/common/editorTestUtils'; <ins> import { Range } from 'vs/editor/common/core/range'; import { timeout } from 'vs/base/common/async'; </ins> suite('SuggestController', function () {", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-2be968533643682327ab6173eb0b62d9cdaeecc862712f2cddfe5fc968066c26", "query": "This is somewhat the opposite of and the acknowledgement that computing additional text edits for all items upfront is too demanding. This issue is only about and the goal is a pragmatic solution, similar to the one that we have for . Idea accept an unresolved completion proceed with insertion as usual set up a content change listener resolve the items once resolved check if additional edits overlap with \"concurrent\" changes. when they overlap, do nothing otherwise proceed\nThe first version for this is now merged to master, it's a pragmatic approach that's better then not resolving but worst than (costly) upfront resolving. Items to followup on [ ] telemetry and follow up issues [ ] - TS issue for having incomplete items [ ] [ ] java for returning very few (resolved) completions, e.g doing the right thing\n/cc - My understanding is that Java resolves all items upfront, e.g compute additional text edits during \"provide\", and that it is quite expensive and therefore Java only returns a small amount of items. Is that correct? Could Java return results faster when additional text edits are computed during resolve (and therefore only for selected items)?\nYes. I think so! is the dev who was working on Java completion. I believe he can provide more insights toward this topic. // cc\nthis is exactly the behavior that used to have, ie compute all the completion items first (fast), then the text edits were computed during resolveCompletion. We were asked to not do that as and changed to return a small subset of completion items (with incomplete=true), with full text edits computed upfront. The user experience is definitely not as good as with our initial implementation.\nTo be clear, computing any Java textedit upfront is costly when returning 100+ items (and we can return several thousands items). We'd prefer if the async insertion of textedits covered all textedits, not just the additional ones.\nThe requirements discussed in are still true and there are no plans to change that. There is (which might be derived from ) and . The former () is inserted at the cursor and must be inserted synchronous to accepting a completion (we cannot block typing while waiting for that). The latter () is meant for things like import-statements and we now want to relax that, e.g it can come late and we try to apply those edits despite the user having typed more.\nWhen exactly does run, is it only when an item gets highlighted in the menu? Can't tell from the docs. I only need to generate for the completion item the user ends up applying -- doing it for other items is unnecessary work that's bogging down the extension host, and I will have to implement yielding. I assume no one would need to generate before a completion item is applied? Is there any kind of completion applied event we can hook into to work around this for the time being?\nThat's exactly what is about . Today, there is no guarantee that is ever called because its original design is to provide data for the suggest details widget. However, we see that (amongst other things) are computed during resolve and leads to subtle bugs (because don't always call resolve or always await it) Well, is the problem if you do not generate them upfront. select suggestion synchronously inserts the string starts for additional text edits continues to type quickly and all over the place -call eventually returns but it is unclear if the edits are still valid because the state changed many types in-between Solutions: Won't work because in JS you cannot wait for another \"thread\" or \"process\", the world always keeps turning Implement a full -solution because this is two entities \"typing\" concurrently in the same document. However, it will feel awkward because the user doesn't expect to be such a scenario. approach that tries to apply additional edits if possible but inserts the \"main edit\" (insertText) always synchronously. () \"if possible\" is currently defined as \"no edit has occurred before the first additional edit\". That works well if you use additional edits for things like imports or prefixes (which is the indented use-case) but won't work if additional text edits change the main edit, like appending a call-operators with arguments etc\nI mean JS can't block but ignoring typing while awaiting is possible -- I was imagining that VSCode would keep the completions menu open and ignore any typing until is resolved and all text edits applied for the accepted item. Obviously this would be bad if resolving takes a long time, but the API has cancelation tokens already, so the UI would just need to show a spinner/cancel icon, and also cancel if the user presses ESC or navigates to a different editor, for a decent UX. I think this would be less confusing for users too; it's the only way it would be clear when VSCode is completely done applying the completion. I think many users would be confused if imports usually get but not when they resume typing too soon. FWIW I can syncronously generate the additional text edits I need, so I'd be happy if there were an API to synchronously generate them when the completion item is accepted. I know not everyone would be able to generate them sync though.\nAlso I know my questions may have seemed redundant, but I hadn't seen anyone on this thread point out that it would be ideal to avoid ever computing additional text edits (or even the primary insert text) for unselected completions. Since can get called before any item is accepted (I assume, since it seems to be for showing additional details in the menu), I'd think any solution via could still result in unnecessarily generating additional edits that are ultimately discarded.\nThe golden rule is that \"you can always type inside the editor\". Ignoring typing is not a good solution and will bug users. Just think of quick suggest and auto accept characters - you don't want the editor to stop typing just because an extension is taking a little longer (+50ms). To be precise you should have written \"typing at or before the offset at which additional edits are going to happen\" I honestly think the majority can generate them synchronously but this happens in the extension host process or the language server process, and all of that might happen on a different machine and there is no way to synchronously transport that into the UI.\nre with the current changes you should be able to have a \"simple insert text\", say , and compute an additional text edit, like , that goes in front of it so that you eventually have . Right? Or am I missing something?\nthat might actually be a good idea ;-) In practice though, we might need to revisit the way the principal TextEdit is computed (i.e rewrite a bunch of stuff from upstream JDT)\nI get the desire to be able to always be able to type inside the editor and agree that's an important principle. The only reason I think this case is an exception is that: The user would probably want to wait for all edits to get applied anyway. Seems unlikely that people would want to get the main edit without the additional edits By making the operation cancelable, you can still go back to typing immediately if you so desire. I certainly wouldn't want to block the user from typing without recourse (as you know, I feel frustrated that happens currently when using Vim extensions) On the other hand, I guess it's unlikely that the additional text edits would overlap whatever the user continues typing...\nI hadn't thought about auto accept characters though, that's a good point. That's something I don't have experience with. Also considering that VSCode could pop up a warning if it has to bail on inserting additional edits, it's not a big deal if it ever happens\nI remember that we have some new data points regarding the time consumption in different stages of code completion in Can you share that data and see how we can tune it with this change?\nFor Java language server, below is a sample of call tree when triggering completion. (time value is larger than expected because of extra overhead from JProfiler) ! Total time of completion stage mainly consists of three parts: competion candidates in JDT to CompletionItems (calc textEdits, additionalTextEdits, etc.) --- calc an incomplete list of only 50 items by default (the full list can contain thousands) --- here calculating import statements costs a lot of time server-side code snippets (not much related to this topic) I did a simple experiment on java language server, with vscode-insider built on 2020-5-15. I was using spring-petclinic, which is not a big one, but with some dependencies. Type a initial letter, e.g. \"O\", and observe perf of completion and resolve. Do multiple times for statistics. Calculating additionalTextEdits async in resolve stage does decrease the time cost a lot. textEdits and additionalTextEdits are calculated during completion stage. completion: ~150 ms resolve(avg of top 10 items): ~10 ms Now I simply move a bunch of textedit calculation from \"completion\" stage into \"resolve\" stage. completion: ~100 ms resolve(avg of top 10 items): ~17 ms !\nI just realized that can return a thenable, but I assume that would delay the appearance of the entire menu?\nClosing as we haven't seen issues with the new pragmatic approach and the plan is to stick with it.\nso how do servers know that clients support lazy-loading of additional textedits? Surely this should be a client capability advertised by vscode (that needs to be specced in the LSP)\nis the right person for that and you should probably create a follow up issue in the LSP land\ncorresponding LSP feature request created here please add more details if I miss anything.\nThanks\nTo verify: use TypeScript have a suggestion that will import a symbol make sure that suggestion isn't first or focused in the UI use the mouse(!) to select the suggestion make sure the import is there make sure undo, redo works as expected", "positive_passages": [{"docid": "doc-en-vscode-1401d39494d82d6a0dc3b4a6630f3778f49236150564c7a9cc61276746b4072c", "text": "assert.equal(editor.getValue(), '    let name = foo'); }); <ins> test('use additionalTextEdits sync when possible', async function () { disposables.add(CompletionProviderRegistry.register({ scheme: 'test-ctrl' }, { provideCompletionItems(doc, pos) { return { suggestions: [{ kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hello', range: Range.fromPositions(pos), additionalTextEdits: [{ text: 'I came sync', range: { startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 1 } }] }] }; }, async resolveCompletionItem(item) { return item; } })); editor.setValue('hellonhallo'); editor.setSelection(new Selection(2, 6, 2, 6)); // trigger let p1 = Event.toPromise(controller.model.onDidSuggest); controller.triggerSuggest(); await p1; // let p2 = Event.toPromise(controller.model.onDidCancel); controller.acceptSelectedSuggestion(false, false); await p2; // insertText happens sync! assert.equal(editor.getValue(), 'I came synchellonhallohello'); }); test('resolve additionalTextEdits async when needed', async function () { let resolveCallCount = 0; disposables.add(CompletionProviderRegistry.register({ scheme: 'test-ctrl' }, { provideCompletionItems(doc, pos) { return { suggestions: [{ kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hello', range: Range.fromPositions(pos) }] }; }, async resolveCompletionItem(item) { resolveCallCount += 1; await timeout(10); item.additionalTextEdits = [{ text: 'I came late', range: { startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 1 } }]; return item; } })); editor.setValue('hellonhallo'); editor.setSelection(new Selection(2, 6, 2, 6)); // trigger let p1 = Event.toPromise(controller.model.onDidSuggest); controller.triggerSuggest(); await p1; // let p2 = Event.toPromise(controller.model.onDidCancel); controller.acceptSelectedSuggestion(false, false); await p2; // insertText happens sync! assert.equal(editor.getValue(), 'hellonhallohello'); assert.equal(resolveCallCount, 1); // additional edits happened after a litte wait await timeout(20); assert.equal(editor.getValue(), 'I came latehellonhallohello'); // single undo stop editor.getModel()?.undo(); assert.equal(editor.getValue(), 'hellonhallo'); }); test('resolve additionalTextEdits async when needed (typing)', async function () { let resolveCallCount = 0; let resolve: Function = () => { }; disposables.add(CompletionProviderRegistry.register({ scheme: 'test-ctrl' }, { provideCompletionItems(doc, pos) { return { suggestions: [{ kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hello', range: Range.fromPositions(pos) }] }; }, async resolveCompletionItem(item) { resolveCallCount += 1; await new Promise(_resolve => resolve = _resolve); item.additionalTextEdits = [{ text: 'I came late', range: { startLineNumber: 1, startColumn: 1, endLineNumber: 1, endColumn: 1 } }]; return item; } })); editor.setValue('hellonhallo'); editor.setSelection(new Selection(2, 6, 2, 6)); // trigger let p1 = Event.toPromise(controller.model.onDidSuggest); controller.triggerSuggest(); await p1; // let p2 = Event.toPromise(controller.model.onDidCancel); controller.acceptSelectedSuggestion(false, false); await p2; // insertText happens sync! assert.equal(editor.getValue(), 'hellonhallohello'); assert.equal(resolveCallCount, 1); // additional edits happened after a litte wait assert.ok(editor.getSelection()?.equalsSelection(new Selection(2, 11, 2, 11))); editor.trigger('test', 'type', { text: 'TYPING' }); assert.equal(editor.getValue(), 'hellonhallohelloTYPING'); resolve(); await timeout(10); assert.equal(editor.getValue(), 'I came latehellonhallohelloTYPING'); assert.ok(editor.getSelection()?.equalsSelection(new Selection(2, 17, 2, 17))); }); // additional edit come late and are AFTER the selection -> cancel test('resolve additionalTextEdits async when needed (simple conflict)', async function () { let resolveCallCount = 0; let resolve: Function = () => { }; disposables.add(CompletionProviderRegistry.register({ scheme: 'test-ctrl' }, { provideCompletionItems(doc, pos) { return { suggestions: [{ kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hello', range: Range.fromPositions(pos) }] }; }, async resolveCompletionItem(item) { resolveCallCount += 1; await new Promise(_resolve => resolve = _resolve); item.additionalTextEdits = [{ text: 'I came late', range: { startLineNumber: 1, startColumn: 6, endLineNumber: 1, endColumn: 6 } }]; return item; } })); editor.setValue(''); editor.setSelection(new Selection(1, 1, 1, 1)); // trigger let p1 = Event.toPromise(controller.model.onDidSuggest); controller.triggerSuggest(); await p1; // let p2 = Event.toPromise(controller.model.onDidCancel); controller.acceptSelectedSuggestion(false, false); await p2; // insertText happens sync! assert.equal(editor.getValue(), 'hello'); assert.equal(resolveCallCount, 1); resolve(); await timeout(10); assert.equal(editor.getValue(), 'hello'); }); // additional edit come late and are AFTER the position at which the user typed -> cancelled test('resolve additionalTextEdits async when needed (conflict)', async function () { let resolveCallCount = 0; let resolve: Function = () => { }; disposables.add(CompletionProviderRegistry.register({ scheme: 'test-ctrl' }, { provideCompletionItems(doc, pos) { return { suggestions: [{ kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hello', range: Range.fromPositions(pos) }] }; }, async resolveCompletionItem(item) { resolveCallCount += 1; await new Promise(_resolve => resolve = _resolve); item.additionalTextEdits = [{ text: 'I came late', range: { startLineNumber: 1, startColumn: 2, endLineNumber: 1, endColumn: 2 } }]; return item; } })); editor.setValue('hellonhallo'); editor.setSelection(new Selection(2, 6, 2, 6)); // trigger let p1 = Event.toPromise(controller.model.onDidSuggest); controller.triggerSuggest(); await p1; // let p2 = Event.toPromise(controller.model.onDidCancel); controller.acceptSelectedSuggestion(false, false); await p2; // insertText happens sync! assert.equal(editor.getValue(), 'hellonhallohello'); assert.equal(resolveCallCount, 1); // additional edits happened after a litte wait editor.setSelection(new Selection(1, 1, 1, 1)); editor.trigger('test', 'type', { text: 'TYPING' }); assert.equal(editor.getValue(), 'TYPINGhellonhallohello'); resolve(); await timeout(10); assert.equal(editor.getValue(), 'TYPINGhellonhallohello'); assert.ok(editor.getSelection()?.equalsSelection(new Selection(1, 7, 1, 7))); }); test('resolve additionalTextEdits async when needed (cancel)', async function () { let resolve: Function[] = []; disposables.add(CompletionProviderRegistry.register({ scheme: 'test-ctrl' }, { provideCompletionItems(doc, pos) { return { suggestions: [{ kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hello', range: Range.fromPositions(pos) }, { kind: CompletionItemKind.Snippet, label: 'let', insertText: 'hallo', range: Range.fromPositions(pos) }] }; }, async resolveCompletionItem(item) { await new Promise(_resolve => resolve.push(_resolve)); item.additionalTextEdits = [{ text: 'additionalTextEdits', range: { startLineNumber: 1, startColumn: 2, endLineNumber: 1, endColumn: 2 } }]; return item; } })); editor.setValue('abc'); editor.setSelection(new Selection(1, 1, 1, 1)); // trigger let p1 = Event.toPromise(controller.model.onDidSuggest); controller.triggerSuggest(); await p1; // let p2 = Event.toPromise(controller.model.onDidCancel); controller.acceptSelectedSuggestion(true, false); await p2; // insertText happens sync! assert.equal(editor.getValue(), 'helloabc'); // next controller.acceptNextSuggestion(); // resolve additional edits (MUST be cancelled) resolve.forEach(fn => fn); resolve.length = 0; await timeout(10); // next suggestion used assert.equal(editor.getValue(), 'halloabc'); }); </ins> });", "commid": "vscode_pr_97515"}], "negative_passages": []}
{"query_id": "q-en-vscode-cb843a5ed26154e74d3b563dbd122c1e9af1f503040ba8bbf5ebaf661580df80", "query": "ERR LinkedMap got modified during iteration.: Error: LinkedMap got modified during iteration. at LinkedMap.forEach (file:///Applications/Visual Studio Code - ) at g.cleanUp (file:///Applications/Visual Studio Code - ) at g.saveState (file:///Applications/Visual Studio Code - ) at file:///Applications/Visual Studio Code - Code is here:", "positive_passages": [{"docid": "doc-en-vscode-45cf77111b20bd805f6f7a5930f173cf43f68dc46f3337a66cd15e1bd7b0d15d", "text": "private cleanUp(): void { const cache = this.doLoad(); <del> // Remove groups from states that no longer exist cache.forEach((mapGroupToMemento, resource) => { </del> <ins> // Remove groups from states that no longer exist. Since we modify the // cache and its is a LRU cache make a copy to ensure iteration succeeds const entries = [...cache.entries()]; for (const [resource, mapGroupToMemento] of entries) { </ins> Object.keys(mapGroupToMemento).forEach(group => { const groupId: GroupIdentifier = Number(group); if (!this.editorGroupService.getGroup(groupId)) { delete mapGroupToMemento[groupId]; if (isEmptyObject(mapGroupToMemento)) { cache.delete(resource); } } }); <del> }); </del> <ins> } </ins> } }", "commid": "vscode_pr_97603"}], "negative_passages": []}
{"query_id": "q-en-vscode-cf365a15576edae35f742d52eca205a3671d61ddbca495c64b93d31d9a6c2fd4", "query": "see gif open GH notebook with a few cell that reference a variable run peek references and select entries notice how notebook cells are being highlighted, like \"Milestone Work\" get selected !\nI can repro in Insiders but not master, I'll check again tomorrow\nThis happens because of this listener: Tho, not yet sure why the selection keeps changing... Maybe some inner list event (from the references list) bubbles up to the outer list\nThat listener is fine, it's the nested lists\nHey do you have any thoughts on handling this? We have a list inside another list. The inner list handles the touch event properly. The outer list then handles the event and picks up the wrong index because it finds the data attribute inside the inner list in We can Make sure the event is fired on the outer list with the correct element, by fixing to check whether it's in the right list Not fire the event on the outer list at all, when we see that it originates in a different list Add some property to the list event that says it originated in a different list so the consumer can decide In this particular case, I think any of these are fine\nThinking more, I don't think that the event should ever be handled by two lists at all. Meaning we either mark the browserEvent as handled, like with preventDefault/isDefaultPrevented, or we make the list check every event to be sure that it originated in this list.\nThis sounds good to me. This also sounds good to me.\nrelated when I do peek references, I see markdown cells being selected? ! Notice I'm looking for under-discussion but \"Configure\" is being highlighted as one of the references\nFrom Good catch, I didn't notice that\nThanks for the quick handling!", "positive_passages": [{"docid": "doc-en-vscode-2d7095b7d0c4a58c4a31b365b7f09b4f6ff6ef51f60963cfadcc56d8f812b14c", "text": "return; } <ins> if (e.browserEvent.defaultPrevented) { return; } </ins> const focus = e.index; if (typeof focus === 'undefined') {", "commid": "vscode_pr_169680"}], "negative_passages": []}
{"query_id": "q-en-vscode-cf365a15576edae35f742d52eca205a3671d61ddbca495c64b93d31d9a6c2fd4", "query": "see gif open GH notebook with a few cell that reference a variable run peek references and select entries notice how notebook cells are being highlighted, like \"Milestone Work\" get selected !\nI can repro in Insiders but not master, I'll check again tomorrow\nThis happens because of this listener: Tho, not yet sure why the selection keeps changing... Maybe some inner list event (from the references list) bubbles up to the outer list\nThat listener is fine, it's the nested lists\nHey do you have any thoughts on handling this? We have a list inside another list. The inner list handles the touch event properly. The outer list then handles the event and picks up the wrong index because it finds the data attribute inside the inner list in We can Make sure the event is fired on the outer list with the correct element, by fixing to check whether it's in the right list Not fire the event on the outer list at all, when we see that it originates in a different list Add some property to the list event that says it originated in a different list so the consumer can decide In this particular case, I think any of these are fine\nThinking more, I don't think that the event should ever be handled by two lists at all. Meaning we either mark the browserEvent as handled, like with preventDefault/isDefaultPrevented, or we make the list check every event to be sure that it originated in this list.\nThis sounds good to me. This also sounds good to me.\nrelated when I do peek references, I see markdown cells being selected? ! Notice I'm looking for under-discussion but \"Configure\" is being highlighted as one of the references\nFrom Good catch, I didn't notice that\nThanks for the quick handling!", "positive_passages": [{"docid": "doc-en-vscode-9725661aa5916b718530533909a3cdc8106610b0767f6be359eaf79e910f29d8", "text": "this.list.setSelection([focus], e.browserEvent); } <ins> e.browserEvent.preventDefault(); </ins> this._onPointer.fire(e); }", "commid": "vscode_pr_169680"}], "negative_passages": []}
{"query_id": "q-en-vscode-cf365a15576edae35f742d52eca205a3671d61ddbca495c64b93d31d9a6c2fd4", "query": "see gif open GH notebook with a few cell that reference a variable run peek references and select entries notice how notebook cells are being highlighted, like \"Milestone Work\" get selected !\nI can repro in Insiders but not master, I'll check again tomorrow\nThis happens because of this listener: Tho, not yet sure why the selection keeps changing... Maybe some inner list event (from the references list) bubbles up to the outer list\nThat listener is fine, it's the nested lists\nHey do you have any thoughts on handling this? We have a list inside another list. The inner list handles the touch event properly. The outer list then handles the event and picks up the wrong index because it finds the data attribute inside the inner list in We can Make sure the event is fired on the outer list with the correct element, by fixing to check whether it's in the right list Not fire the event on the outer list at all, when we see that it originates in a different list Add some property to the list event that says it originated in a different list so the consumer can decide In this particular case, I think any of these are fine\nThinking more, I don't think that the event should ever be handled by two lists at all. Meaning we either mark the browserEvent as handled, like with preventDefault/isDefaultPrevented, or we make the list check every event to be sure that it originated in this list.\nThis sounds good to me. This also sounds good to me.\nrelated when I do peek references, I see markdown cells being selected? ! Notice I'm looking for under-discussion but \"Configure\" is being highlighted as one of the references\nFrom Good catch, I didn't notice that\nThanks for the quick handling!", "positive_passages": [{"docid": "doc-en-vscode-aafd0455ac87f0965670b393260185b676e739f157139468ccaaa376b30f4fca", "text": "return; } <ins> if (e.browserEvent.defaultPrevented) { return; } </ins> const focus = this.list.getFocus(); this.list.setSelection(focus, e.browserEvent); <ins> e.browserEvent.preventDefault(); </ins> } private changeSelection(e: IListMouseEvent<T> | IListTouchEvent<T>): void {", "commid": "vscode_pr_169680"}], "negative_passages": []}
{"query_id": "q-en-vscode-cf365a15576edae35f742d52eca205a3671d61ddbca495c64b93d31d9a6c2fd4", "query": "see gif open GH notebook with a few cell that reference a variable run peek references and select entries notice how notebook cells are being highlighted, like \"Milestone Work\" get selected !\nI can repro in Insiders but not master, I'll check again tomorrow\nThis happens because of this listener: Tho, not yet sure why the selection keeps changing... Maybe some inner list event (from the references list) bubbles up to the outer list\nThat listener is fine, it's the nested lists\nHey do you have any thoughts on handling this? We have a list inside another list. The inner list handles the touch event properly. The outer list then handles the event and picks up the wrong index because it finds the data attribute inside the inner list in We can Make sure the event is fired on the outer list with the correct element, by fixing to check whether it's in the right list Not fire the event on the outer list at all, when we see that it originates in a different list Add some property to the list event that says it originated in a different list so the consumer can decide In this particular case, I think any of these are fine\nThinking more, I don't think that the event should ever be handled by two lists at all. Meaning we either mark the browserEvent as handled, like with preventDefault/isDefaultPrevented, or we make the list check every event to be sure that it originated in this list.\nThis sounds good to me. This also sounds good to me.\nrelated when I do peek references, I see markdown cells being selected? ! Notice I'm looking for under-discussion but \"Configure\" is being highlighted as one of the references\nFrom Good catch, I didn't notice that\nThanks for the quick handling!", "positive_passages": [{"docid": "doc-en-vscode-96eb9fcd30c1f3d7a5c77d170912ebae74f976f9300c3d350435f684066ae734", "text": "return; } <ins> if (e.browserEvent.defaultPrevented) { return; } </ins> const node = e.element; if (!node) {", "commid": "vscode_pr_169680"}], "negative_passages": []}
{"query_id": "q-en-vscode-cf365a15576edae35f742d52eca205a3671d61ddbca495c64b93d31d9a6c2fd4", "query": "see gif open GH notebook with a few cell that reference a variable run peek references and select entries notice how notebook cells are being highlighted, like \"Milestone Work\" get selected !\nI can repro in Insiders but not master, I'll check again tomorrow\nThis happens because of this listener: Tho, not yet sure why the selection keeps changing... Maybe some inner list event (from the references list) bubbles up to the outer list\nThat listener is fine, it's the nested lists\nHey do you have any thoughts on handling this? We have a list inside another list. The inner list handles the touch event properly. The outer list then handles the event and picks up the wrong index because it finds the data attribute inside the inner list in We can Make sure the event is fired on the outer list with the correct element, by fixing to check whether it's in the right list Not fire the event on the outer list at all, when we see that it originates in a different list Add some property to the list event that says it originated in a different list so the consumer can decide In this particular case, I think any of these are fine\nThinking more, I don't think that the event should ever be handled by two lists at all. Meaning we either mark the browserEvent as handled, like with preventDefault/isDefaultPrevented, or we make the list check every event to be sure that it originated in this list.\nThis sounds good to me. This also sounds good to me.\nrelated when I do peek references, I see markdown cells being selected? ! Notice I'm looking for under-discussion but \"Configure\" is being highlighted as one of the references\nFrom Good catch, I didn't notice that\nThanks for the quick handling!", "positive_passages": [{"docid": "doc-en-vscode-f32bd210b9a0c20145e64b2a49110012dee19084ce3c4dfcf98c39152abbffd5", "text": "return; } <ins> if (e.browserEvent.defaultPrevented) { return; } </ins> super.onDoubleClick(e); } }", "commid": "vscode_pr_169680"}], "negative_passages": []}
{"query_id": "q-en-vscode-cf365a15576edae35f742d52eca205a3671d61ddbca495c64b93d31d9a6c2fd4", "query": "see gif open GH notebook with a few cell that reference a variable run peek references and select entries notice how notebook cells are being highlighted, like \"Milestone Work\" get selected !\nI can repro in Insiders but not master, I'll check again tomorrow\nThis happens because of this listener: Tho, not yet sure why the selection keeps changing... Maybe some inner list event (from the references list) bubbles up to the outer list\nThat listener is fine, it's the nested lists\nHey do you have any thoughts on handling this? We have a list inside another list. The inner list handles the touch event properly. The outer list then handles the event and picks up the wrong index because it finds the data attribute inside the inner list in We can Make sure the event is fired on the outer list with the correct element, by fixing to check whether it's in the right list Not fire the event on the outer list at all, when we see that it originates in a different list Add some property to the list event that says it originated in a different list so the consumer can decide In this particular case, I think any of these are fine\nThinking more, I don't think that the event should ever be handled by two lists at all. Meaning we either mark the browserEvent as handled, like with preventDefault/isDefaultPrevented, or we make the list check every event to be sure that it originated in this list.\nThis sounds good to me. This also sounds good to me.\nrelated when I do peek references, I see markdown cells being selected? ! Notice I'm looking for under-discussion but \"Configure\" is being highlighted as one of the references\nFrom Good catch, I didn't notice that\nThanks for the quick handling!", "positive_passages": [{"docid": "doc-en-vscode-e6d9a71298b6bb25ed6d9a9426b65d84c7dfd40cd4df17d9e425d1a1f1f185ba", "text": "} if (node.collapsible) { <del> // Do not set this before calling a handler on the super class, because it will reject it as handled e.browserEvent.isHandledByList = true; </del> const location = this.tree.getNodeLocation(node); const recursive = e.browserEvent.altKey; this.tree.setFocus([location]); this.tree.toggleCollapsed(location, recursive); if (expandOnlyOnTwistieClick && onTwistie) { <ins> // Do not set this before calling a handler on the super class, because it will reject it as handled e.browserEvent.isHandledByList = true; </ins> return; } }", "commid": "vscode_pr_182084"}], "negative_passages": []}
{"query_id": "q-en-vscode-b683ac1573953ce4d5fe1bcea18edffa26df02739619ba8a11d81ceb11185f70", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently the VS Code Git commit message box automatically synchronises with the contents of .git/MERGEMSG (provided you have not entered your own commit message yet into VS Code). I would like to request support for VS Code to do the same with .git/SQUASHMSG (produced when running ). This would provide better integration between VS code git related VS Code extensions which often have the ability to perform a squash merge via the extension GUI but do not typically replicate any of the existing VS Code git interface (commit message box and changed file list).\nI wouldn't mind taking this on, and I've looked through the code so I have a pretty good idea of what's required to implement this. Just one question, though \u2014 is there any situation where and are both present? If so: which one do we think should take precedence as the 'default' commit message?\nmy suggestion would be to follow what git-gui does since it's bundled with git. Looks like it preferences MERGEMSG over SQUASHMSG (see )\nThat makes sense, and that's what I was thinking too. I'll put a PR in shortly!\nI got this to partially work by: a file with some content like \"HELLO\" a local branch file sometimes gets filled with content, like the following it seems like the content of the file is not constant for me, and changes once I do a squash Reopening this for discussion. I also might be doing something wrong. Bonus bug: when chaning the content of the SQUASHMSG the scm input does not reg resized and ends up looking broken (picture attached). So I would recommend that we revert this PR and polish it a bit more. !\nIt worked fine (and always displayed the intended (?) squash msg), but maybe it's because I was only squashing another branch that only had one commit? I concur that it seems like the contents of SQUASHMSG aren't always consistent though, now that I've tried with a branch with more than one commit. EDIT: It seems like it displays all of the squashed commits in one message, prefaced by As for the bonus bug, is that issue exclusive to SQUASHMSG or does it also happen if you change the contents of MERGE_MSG?\nYou're not supposed to manually create or edit the file. This is a file created by git during the command. When you run this command you will have a commit pending... and the input box should be prepopulated with a template commit message. Can you try this again? Thanks for the input box issue though, will try to repro.\nThis was the intended behaviour behind this feature request. I'm not expecting VS Code to do anything magical here with SQUASHMSG. It should just be taking the entire contents of the file as other graphical git tools do (and as a command line call to does if SQUASHMSG exists). I do not think the PR needs reverting.\nAdded another commit, since the can exist but just have no content. In that case we should take . Please verify once again, now the feature is clearer.\nSorry for the confusion, just was not very clear to me. I will verify this later today.\nAdding verified label since the git commit gets nicely preopulated with the squash message.", "positive_passages": [{"docid": "doc-en-vscode-4cb60f8895cb7b498465bec9e3da57e7a130324d65cf4d917342d78ab0c565af", "text": "return message.replace(/^s*#.*$n?/gm, '').trim(); } <ins> async getSquashMessage(): Promise<string | undefined> { const squashMsgPath = path.join(this.repositoryRoot, '.git', 'SQUASH_MSG'); try { const raw = await fs.readFile(squashMsgPath, 'utf8'); return this.stripCommitMessageComments(raw); } catch { return undefined; } } </ins> async getMergeMessage(): Promise<string | undefined> { const mergeMsgPath = path.join(this.repositoryRoot, '.git', 'MERGE_MSG');", "commid": "vscode_pr_101114"}], "negative_passages": []}
{"query_id": "q-en-vscode-b683ac1573953ce4d5fe1bcea18edffa26df02739619ba8a11d81ceb11185f70", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently the VS Code Git commit message box automatically synchronises with the contents of .git/MERGEMSG (provided you have not entered your own commit message yet into VS Code). I would like to request support for VS Code to do the same with .git/SQUASHMSG (produced when running ). This would provide better integration between VS code git related VS Code extensions which often have the ability to perform a squash merge via the extension GUI but do not typically replicate any of the existing VS Code git interface (commit message box and changed file list).\nI wouldn't mind taking this on, and I've looked through the code so I have a pretty good idea of what's required to implement this. Just one question, though \u2014 is there any situation where and are both present? If so: which one do we think should take precedence as the 'default' commit message?\nmy suggestion would be to follow what git-gui does since it's bundled with git. Looks like it preferences MERGEMSG over SQUASHMSG (see )\nThat makes sense, and that's what I was thinking too. I'll put a PR in shortly!\nI got this to partially work by: a file with some content like \"HELLO\" a local branch file sometimes gets filled with content, like the following it seems like the content of the file is not constant for me, and changes once I do a squash Reopening this for discussion. I also might be doing something wrong. Bonus bug: when chaning the content of the SQUASHMSG the scm input does not reg resized and ends up looking broken (picture attached). So I would recommend that we revert this PR and polish it a bit more. !\nIt worked fine (and always displayed the intended (?) squash msg), but maybe it's because I was only squashing another branch that only had one commit? I concur that it seems like the contents of SQUASHMSG aren't always consistent though, now that I've tried with a branch with more than one commit. EDIT: It seems like it displays all of the squashed commits in one message, prefaced by As for the bonus bug, is that issue exclusive to SQUASHMSG or does it also happen if you change the contents of MERGE_MSG?\nYou're not supposed to manually create or edit the file. This is a file created by git during the command. When you run this command you will have a commit pending... and the input box should be prepopulated with a template commit message. Can you try this again? Thanks for the input box issue though, will try to repro.\nThis was the intended behaviour behind this feature request. I'm not expecting VS Code to do anything magical here with SQUASHMSG. It should just be taking the entire contents of the file as other graphical git tools do (and as a command line call to does if SQUASHMSG exists). I do not think the PR needs reverting.\nAdded another commit, since the can exist but just have no content. In that case we should take . Please verify once again, now the feature is clearer.\nSorry for the confusion, just was not very clear to me. I will verify this later today.\nAdding verified label since the git commit gets nicely preopulated with the squash message.", "positive_passages": [{"docid": "doc-en-vscode-de63d3799f65fda975820f3750e959c521c8a8e27d0c79ce3e79215d677d79ef", "text": "} async getInputTemplate(): Promise<string> { <del> const mergeMessage = await this.repository.getMergeMessage(); </del> <ins> const commitMessage = (await Promise.all([this.repository.getMergeMessage(), this.repository.getSquashMessage()])).find(msg => msg !== undefined); </ins> <del> if (mergeMessage) { return mergeMessage; </del> <ins> if (commitMessage) { return commitMessage; </ins> } return await this.repository.getCommitTemplate();", "commid": "vscode_pr_101114"}], "negative_passages": []}
{"query_id": "q-en-vscode-56926236e2ff478ac1bda76c1146e1b2eb5032208e70e0784150e21a56cef01d", "query": "VSCode Version: 1.47 insiders OS Version: Windows Steps to Reproduce: on the \"Add item\" button in and press enter. ! Does this issue occur when all extensions are disabled?: Yes", "positive_passages": [{"docid": "doc-en-vscode-9dbde128f1865b00ebf6b2371041547336cb81e94834450db32b20c729f26b59", "text": "} } // New item was added <del> else if (template.objectWidget.isItemNew(e.originalItem)) { </del> <ins> else if (template.objectWidget.isItemNew(e.originalItem) && e.item.key.data !== '') { </ins> newValue[e.item.key.data] = e.item.value.data; newItems.push(e.item); }", "commid": "vscode_pr_101809"}], "negative_passages": []}
{"query_id": "q-en-vscode-440d87acb074cf59e2a29ebdb1f07227df7e3c47169f85422776fbe1eebfa496", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47 OS Version: MacOS Steps to Reproduce: a local project server (f.ex angular) with a long filename (some 16+ characters) <filename.<extension. a debug session (f.ex firefox), and check the debug console output. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes !\nI don't understand what the screenshot is showing. Please show the whole debug console. I do not understand what gets concatenated in the screenshot. What exactly are you expecting and what is the erroneous behavior?\nattached photo of whole debug console - error occurs on last line. Behavior: supposedly filenames (some 16+ characters) will be shortened with (...) instead of showing the whole filename and line number. Expecting: the whole filename and line number where a console log is being outputted. !\nYes, I agree this is an issue. The problem is that we set a to 150 . The ideal solution would be that the elements gets shrinked first, and that it has unlimited size. Adding help wanted as I am open to review a PR which fixes this. If nobody tackles this I can also look into this in the future.\nHi I can give this a try.\ngreat, thanks!", "positive_passages": [{"docid": "doc-en-vscode-aa5f34d5d6d34c29c1d5e03b6be67a0f8d0652934b05a7b84865f0859a8f9494", "text": "} .monaco-workbench .repl .repl-tree .output.expression.value-and-source .value { <del> flex: 1; </del> <ins> margin-right: 4px; </ins> } .monaco-workbench .repl .repl-tree .monaco-tl-contents .arrow {", "commid": "vscode_pr_104052"}], "negative_passages": []}
{"query_id": "q-en-vscode-440d87acb074cf59e2a29ebdb1f07227df7e3c47169f85422776fbe1eebfa496", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47 OS Version: MacOS Steps to Reproduce: a local project server (f.ex angular) with a long filename (some 16+ characters) <filename.<extension. a debug session (f.ex firefox), and check the debug console output. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes !\nI don't understand what the screenshot is showing. Please show the whole debug console. I do not understand what gets concatenated in the screenshot. What exactly are you expecting and what is the erroneous behavior?\nattached photo of whole debug console - error occurs on last line. Behavior: supposedly filenames (some 16+ characters) will be shortened with (...) instead of showing the whole filename and line number. Expecting: the whole filename and line number where a console log is being outputted. !\nYes, I agree this is an issue. The problem is that we set a to 150 . The ideal solution would be that the elements gets shrinked first, and that it has unlimited size. Adding help wanted as I am open to review a PR which fixes this. If nobody tackles this I can also look into this in the future.\nHi I can give this a try.\ngreat, thanks!", "positive_passages": [{"docid": "doc-en-vscode-bce359c8bac83270ed07d13ef8ae2981727dcb437a85d5f6fb64babd863cbdb9", "text": "} .monaco-workbench .repl .repl-tree .output.expression.value-and-source .source { <del> margin-left: 4px; </del> <ins> margin-left: auto; </ins> margin-right: 8px; cursor: pointer; text-decoration: underline; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; <del> max-width: 150px; </del> <ins> text-align: right; </ins> } .monaco-workbench .repl .repl-tree .output.expression > .value,", "commid": "vscode_pr_104052"}], "negative_passages": []}
{"query_id": "q-en-vscode-84e2b29eeb7b1f6cf5c171ad9f3163f245bea1de4811bd4d8bc5ac6e1cdb2b63", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.2 OS Version: Windows 10 (2004) Steps to Reproduce: a dotnet project & to a problems pane and check \"Hide Excluded Files\" and open problems Expected: problems pane not to show problems in generated code in folder. Actual: all problems are still visible under problems pane but as expected not visible in the explorer. ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No, the \"problems\" are generated by an extension. So cannot reproduce this way. Related issue:\nAFAIK the feature in Problems to exclude items uses its own filter, which you must enter in the field to the left of the filter button. I don't think it pays any attention to\nThis comment suggests that suppose to work: While I can use the Filter on the left, it is separate from \"Hide Excluded Files\" option. They don't interact.\nDeferring to\nClarification with regards to Problems are always visible not only when the file is open in the editor. I opened one in the screenshot just to show the error, but others that aren't open in the editor are still visible in the Problems pane too.\nOh alright, I realized I misunderstood so that is why I deleted my comment. I apologize for any confusion. Lemme see if I can figure something out today\nHi upon further investigation it appears that this feature uses a different list. I believe that it goes off of this list found in settings. But I do also acknowledge . could you maybe give me some input here? Maybe it can use both the global setting and the option together? <img width=\"981\" alt=\"Screen Shot 2020-08-07 at 10 13 42 AM\" src=\"https://user-\"\nthis also happens with php language server. is there a of some sort, like has? I have to disable altogether because doesn't stop vscode to fill Problems pane.\nI wasn't able to reproduce this issue when I tested just now on 1.52.1. Problems reported on a file whose name matched a glob in disappeared from the panel when I selected the \"Hide Excluded Files\" filter. They reappeared when I deselected that filter option, or when I removed or disabled the entry. If the problem still exists for you please provide simple repro steps.\nVery much appreciated for validating the issue again. Please provide exact steps to repro.\nHey I did a repro on a clean machine and I know exactly what the issue is now. It has to do with how glob pattern is applied in the problems pane. If you apply it on folder like this - it does not work for problems pane, but works in explorer view. If you apply it on all files inside the folder - it works for problems pane and explorer view. I was able to reproduce this behaviour in typescript solution too, so was a red herring. !\nThanks for the repro. Will investigate in February.\nPushed a PR with a possible fix", "positive_passages": [{"docid": "doc-en-vscode-53bb11e6e61f56e95bd077933e94b72e7bdbb11318955844cd382c7c2b01ea47", "text": "const filesExcludeByRoot = Array.isArray(filesExclude) ? filesExclude : []; const excludesExpression: IExpression = Array.isArray(filesExclude) ? getEmptyExpression() : filesExclude; <ins> for (const { expression } of filesExcludeByRoot) { for (const pattern of Object.keys(expression)) { if (!pattern.endsWith('/**')) { // Append `/**` to pattern to match a parent folder #103631 expression[`${strings.rtrim(pattern, '/')}/**`] = expression[pattern]; } } } </ins> const negate = filter.startsWith('!'); this.textFilter = { text: (negate ? strings.ltrim(filter, '!') : filter).trim(), negate }; const includeExpression: IExpression = getEmptyExpression();", "commid": "vscode_pr_119040"}], "negative_passages": []}
{"query_id": "q-en-vscode-30d3e92cbda311ce4420166dda5c84f13369957e8045ce2e39e955b0e315d744", "query": "Issue Type: <bBug</bWhen : one mouse wheel scroll in extension view: moves 100px one mouse wheel scroll in settings editor: moves 100px When : one mouse wheel scroll in extension view: moves 100px, with slight animation one mouse wheel scroll in settings editor: moves 15~25px, without animation I'm using a Logitech G502 Lightspeed mouse, without any scrolling tweaking softwares. ! VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-05T05:30:25.429Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --\nI don't see this, any idea\nI believe this setting is ignored for macOS. Duplicate of\nActually not a duplicate. Interesting. I need to get my hands on a mouse to see if I can repro.\nCreated a PR that fixes this:", "positive_passages": [{"docid": "doc-en-vscode-a7ff9b5995e9c5c16f203ba50aec615c2145ee1dbf2b670bec227d2d2693967c", "text": "this.render(previousRenderRange, e.scrollTop, e.height, e.scrollLeft, e.scrollWidth); if (this.supportDynamicHeights) { <del> this._rerender(e.scrollTop, e.height); </del> <ins> // Don't update scrollTop from within an scroll event // so we don't break smooth scrolling. #104144 this._rerender(e.scrollTop, e.height, false); </ins> } } catch (err) { console.error('Got bad scroll event:', e);", "commid": "vscode_pr_104284"}], "negative_passages": []}
{"query_id": "q-en-vscode-30d3e92cbda311ce4420166dda5c84f13369957e8045ce2e39e955b0e315d744", "query": "Issue Type: <bBug</bWhen : one mouse wheel scroll in extension view: moves 100px one mouse wheel scroll in settings editor: moves 100px When : one mouse wheel scroll in extension view: moves 100px, with slight animation one mouse wheel scroll in settings editor: moves 15~25px, without animation I'm using a Logitech G502 Lightspeed mouse, without any scrolling tweaking softwares. ! VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-05T05:30:25.429Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --\nI don't see this, any idea\nI believe this setting is ignored for macOS. Duplicate of\nActually not a duplicate. Interesting. I need to get my hands on a mouse to see if I can repro.\nCreated a PR that fixes this:", "positive_passages": [{"docid": "doc-en-vscode-bc617f4d7963d05bd8a5c6b3e0c302b0ffc4bd4d4d3ebde7d5197a90819d04f7", "text": "* Given a stable rendered state, checks every rendered element whether it needs * to be probed for dynamic height. Adjusts scroll height and top if necessary. */ <del> private _rerender(renderTop: number, renderHeight: number): void { </del> <ins> private _rerender(renderTop: number, renderHeight: number, updateScrollTop: boolean = true): void { </ins> const previousRenderRange = this.getRenderRange(renderTop, renderHeight); // Let's remember the second element's position, this helps in scrolling up", "commid": "vscode_pr_104284"}], "negative_passages": []}
{"query_id": "q-en-vscode-30d3e92cbda311ce4420166dda5c84f13369957e8045ce2e39e955b0e315d744", "query": "Issue Type: <bBug</bWhen : one mouse wheel scroll in extension view: moves 100px one mouse wheel scroll in settings editor: moves 100px When : one mouse wheel scroll in extension view: moves 100px, with slight animation one mouse wheel scroll in settings editor: moves 15~25px, without animation I'm using a Logitech G502 Lightspeed mouse, without any scrolling tweaking softwares. ! VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-05T05:30:25.429Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --\nI don't see this, any idea\nI believe this setting is ignored for macOS. Duplicate of\nActually not a duplicate. Interesting. I need to get my hands on a mouse to see if I can repro.\nCreated a PR that fixes this:", "positive_passages": [{"docid": "doc-en-vscode-195cce9332696cbccf83f448754687394a98bb1c60c1d93c6a638e21916fe03d", "text": "} } <del> if (typeof anchorElementIndex === 'number') { </del> <ins> if (updateScrollTop && typeof anchorElementIndex === 'number') { </ins> this.scrollTop = this.elementTop(anchorElementIndex) - anchorElementTopDelta!; }", "commid": "vscode_pr_104284"}], "negative_passages": []}
{"query_id": "q-en-vscode-fee729438a322534546b37650e250b9794183eb254a0648e5a893344e898e9b7", "query": "Issue Type: <bBug</brepo your user tsdk to use this version, for example: load the VS Code workspace (making sure you are using your user TS version) a file in and try getting the document outline Bug Big delay. This is because two full TS Servers are being spawned instead of a syntax only server + full server (see memory usage in screenshot): <img width=\"1079\" alt=\"Screen Shot 2020-08-11 at 3 13 33 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-11T10:13:04.551Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nSeems like this was caused by\nFor verification, try the following cases: Using TS 3.9.7 Using TS 4.0.1-rc Using TS Using an old TS version like 3.5 (older versions don't support the syntax server at all) All should load the document symbols quickly even while the loading spinner is showing You can use the same global install in all cases, just make sure to reload VS Code each time\nAssigning this to july milestone since it is a candidate.\nfollowing your steps I have verified that the outline get loaded quickly, however I still see two tsservers spinning up when I open the process explorer. If I understood correctly this is by design, since only one of them has a large memory usage. I have verified for TS: 3.9.7, 4.0.1-rc. ts 3.5 Thus adding verified label !", "positive_passages": [{"docid": "doc-en-vscode-c97caa732ea92f49a39fd9424be8ea8cee7abbc47a37252c1f6a963d62241a18", "text": "import { GetErrRoutingTsServer, ITypeScriptServer, ProcessBasedTsServer, SyntaxRoutingTsServer, TsServerDelegate, TsServerProcessFactory, TsServerProcessKind } from './server'; import { TypeScriptVersionManager } from './versionManager'; import { ITypeScriptVersionProvider, TypeScriptVersion } from './versionProvider'; <del> import * as semver from 'semver'; </del> const enum CompositeServerType { /** Run a single server that handles all commands  */", "commid": "vscode_pr_104457"}], "negative_passages": []}
{"query_id": "q-en-vscode-fee729438a322534546b37650e250b9794183eb254a0648e5a893344e898e9b7", "query": "Issue Type: <bBug</brepo your user tsdk to use this version, for example: load the VS Code workspace (making sure you are using your user TS version) a file in and try getting the document outline Bug Big delay. This is because two full TS Servers are being spawned instead of a syntax only server + full server (see memory usage in screenshot): <img width=\"1079\" alt=\"Screen Shot 2020-08-11 at 3 13 33 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-11T10:13:04.551Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nSeems like this was caused by\nFor verification, try the following cases: Using TS 3.9.7 Using TS 4.0.1-rc Using TS Using an old TS version like 3.5 (older versions don't support the syntax server at all) All should load the document symbols quickly even while the loading spinner is showing You can use the same global install in all cases, just make sure to reload VS Code each time\nAssigning this to july milestone since it is a candidate.\nfollowing your steps I have verified that the outline get loaded quickly, however I still see two tsservers spinning up when I open the process explorer. If I understood correctly this is by design, since only one of them has a large memory usage. I have verified for TS: 3.9.7, 4.0.1-rc. ts 3.5 Thus adding verified label !", "positive_passages": [{"docid": "doc-en-vscode-45fb78c588c9ceda9c55c80eb8703804b1f3f253c8ed6ad434224408bd928108", "text": "let tsServerLogFile: string | undefined; if (kind === TsServerProcessKind.Syntax) { <del> if (semver.gte(API.v400rc.fullVersionString, apiVersion.fullVersionString)) { args.push('--serverMode'); args.push('partialSemantic'); } else { </del> <ins> if (apiVersion.gte(API.v401)) { args.push('--serverMode', 'partialSemantic'); } else { </ins> args.push('--syntaxOnly'); } }", "commid": "vscode_pr_104457"}], "negative_passages": []}
{"query_id": "q-en-vscode-fee729438a322534546b37650e250b9794183eb254a0648e5a893344e898e9b7", "query": "Issue Type: <bBug</brepo your user tsdk to use this version, for example: load the VS Code workspace (making sure you are using your user TS version) a file in and try getting the document outline Bug Big delay. This is because two full TS Servers are being spawned instead of a syntax only server + full server (see memory usage in screenshot): <img width=\"1079\" alt=\"Screen Shot 2020-08-11 at 3 13 33 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.48.0-insider (, 2020-08-11T10:13:04.551Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nSeems like this was caused by\nFor verification, try the following cases: Using TS 3.9.7 Using TS 4.0.1-rc Using TS Using an old TS version like 3.5 (older versions don't support the syntax server at all) All should load the document symbols quickly even while the loading spinner is showing You can use the same global install in all cases, just make sure to reload VS Code each time\nAssigning this to july milestone since it is a candidate.\nfollowing your steps I have verified that the outline get loaded quickly, however I still see two tsservers spinning up when I open the process explorer. If I understood correctly this is by design, since only one of them has a large memory usage. I have verified for TS: 3.9.7, 4.0.1-rc. ts 3.5 Thus adding verified label !", "positive_passages": [{"docid": "doc-en-vscode-17af0a524a9397d103baf9a1b1318f63cf3967f632a59afd729b1aa33946dfc9", "text": "public static readonly v380 = API.fromSimpleString('3.8.0'); public static readonly v381 = API.fromSimpleString('3.8.1'); public static readonly v390 = API.fromSimpleString('3.9.0'); <del> public static readonly v400rc = API.fromSimpleString('4.0.0-rc'); </del> public static readonly v400 = API.fromSimpleString('4.0.0'); <ins> public static readonly v401 = API.fromSimpleString('4.0.1'); </ins> public static fromVersionString(versionString: string): API { let version = semver.valid(versionString);", "commid": "vscode_pr_104457"}], "negative_passages": []}
{"query_id": "q-en-vscode-1f55725d3d3625dfc643244c916d02b1331fc45814b9a425cb9da3e77fdf2af5", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In markdown mode, Dimmed Monokai theme: does not render bold / italic. no special color for link / image title. !\nThe markdown used in the screenshot:", "positive_passages": [{"docid": "doc-en-vscode-77589a0cc7e6ce9831e367cfeb6a1e47fa1c693fe6e376341d4c606871b1be1a", "text": "} }, { <ins> \"name\": \"Markdown Headings\", \"scope\": \"markup.heading.markdown\", \"settings\": { \"fontStyle\": \"bold\" } }, { \"name\": \"Markdown Quote\", \"scope\": \"markup.quote.markdown\", \"settings\": { \"fontStyle\": \"italic\", \"foreground\": \"\" } }, { \"name\": \"Markdown Bold\", \"scope\": \"markup.bold.markdown\", \"settings\": { \"fontStyle\": \"bold\" } }, { \"name\": \"Markdown Link Title/Description\", \"scope\": \"string.other.link.title.markdown,string.other.link.description.markdown\", \"settings\": { \"foreground\": \"#AE81FF\" } }, { \"name\": \"Markdown Underline Link/Image\", \"scope\": \"markup.underline.link.markdown,markup.underline.link.image.markdown\", \"settings\": { \"foreground\": \"\" } }, { \"name\": \"Markdown Emphasis\", \"scope\": \"markup.italic.markdown\", \"settings\": { \"fontStyle\": \"italic\" } }, { \"name\": \"Markdown Punctuation Definition Link\", \"scope\": \"markup.list.unnumbered.markdown, markup.list.numbered.markdown\", \"settings\": { \"foreground\": \"\" } }, { \"name\": \"Markdown List Punctuation\", \"scope\": [ \"punctuation.definition.list.begin.markdown\" ], \"settings\": { \"foreground\": \"\" } }, { </ins> \"scope\": \"token.info-token\", \"settings\": { \"foreground\": \"#6796e6\"", "commid": "vscode_pr_104468"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-d6021d487b24c1b43f5532e4e96a0b55ef6e754fb9fce870e7e67490179141e1", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { ExtensionContext } from 'vscode'; </del> <ins> import { ExtensionContext, Uri } from 'vscode'; </ins> import { LanguageClientOptions } from 'vscode-languageclient'; import { startClient, LanguageClientConstructor } from '../cssClient'; import { LanguageClient } from 'vscode-languageclient/browser';", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-c51421c7f49933aa2ebf2fcb9c69ff5e14ec2097b6eb171f0aa87467862e9bac", "text": "// this method is called when vs code is activated export function activate(context: ExtensionContext) { <del> const serverMain = context.asAbsolutePath('server/dist/browser/cssServerMain.js'); </del> <ins> const serverMain = Uri.joinPath(context.extensionUri, 'server/dist/browser/cssServerMain.js'); </ins> try { <del> const worker = new Worker(serverMain); </del> <ins> const worker = new Worker(serverMain.toString()); </ins> const newLanguageClient: LanguageClientConstructor = (id: string, name: string, clientOptions: LanguageClientOptions) => { return new LanguageClient(id, name, clientOptions, worker); };", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-de394e3f710bc34fc9b9120dafd6de326578d2d46e036495a03b59f67c019ca7", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { ExtensionContext } from 'vscode'; </del> <ins> import { ExtensionContext, Uri } from 'vscode'; </ins> import { LanguageClientOptions } from 'vscode-languageclient'; import { startClient, LanguageClientConstructor } from '../htmlClient'; import { LanguageClient } from 'vscode-languageclient/browser';", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-09df6e66aaa3a8b6dd966467bbb4bfb12b96cae632c6ba0bda7303f6b6895318", "text": "// this method is called when vs code is activated export function activate(context: ExtensionContext) { <del> const serverMain = context.asAbsolutePath('server/dist/browser/htmlServerMain.js'); </del> <ins> const serverMain = Uri.joinPath(context.extensionUri, 'server/dist/browser/htmlServerMain.js'); </ins> try { <del> const worker = new Worker(serverMain); </del> <ins> const worker = new Worker(serverMain.toString()); </ins> const newLanguageClient: LanguageClientConstructor = (id: string, name: string, clientOptions: LanguageClientOptions) => { return new LanguageClient(id, name, clientOptions, worker); };", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-7dfd4c179ddc87591fb79353fcfd4baa0b2efe454d029e33e9d7f6113fe3a334", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { ExtensionContext } from 'vscode'; </del> <ins> import { ExtensionContext, Uri } from 'vscode'; </ins> import { LanguageClientOptions } from 'vscode-languageclient'; import { startClient, LanguageClientConstructor } from '../jsonClient'; import { LanguageClient } from 'vscode-languageclient/browser';", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-25131dc0217ddbd95edcf3f39057cc0400ee0bf00dd82542322e0bd09ed51c89", "text": "// this method is called when vs code is activated export function activate(context: ExtensionContext) { <del> const serverMain = context.asAbsolutePath('server/dist/browser/jsonServerMain.js'); </del> <ins> const serverMain = Uri.joinPath(context.extensionUri, 'server/dist/browser/jsonServerMain.js'); </ins> try { <del> const worker = new Worker(serverMain); </del> <ins> const worker = new Worker(serverMain.toString()); </ins> const newLanguageClient: LanguageClientConstructor = (id: string, name: string, clientOptions: LanguageClientOptions) => { return new LanguageClient(id, name, clientOptions, worker); };", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-e255070e97b4bbbd1a5dd83ccb70eb5d541d7ed61b672be00b96a055d1170925", "text": "const versionProvider = new StaticVersionProvider( new TypeScriptVersion( TypeScriptVersionSource.Bundled, <del> context.asAbsolutePath('dist/browser/typescript-web/tsserver.web.js'), </del> <ins> vscode.Uri.joinPath(context.extensionUri, 'dist/browser/typescript-web/tsserver.web.js').toString(), </ins> API.v400)); const lazyClientHost = createLazyClientHost(context, false, {", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-183e4dd6f91c728d2bde6b7a637f46abc68372f2acc75752679b72cd7353fd93", "query": "The usage of as seen here only works because there is there is special code to return a url-string (instead of a path, see ). For loading extension relative resources the and should be used. That is the new, web-ready replacement API\nfyi\ntried to adopt this. When will be available. I can't find it in .\nOpened for ESLint\nIt's in the API since 4 months:", "positive_passages": [{"docid": "doc-en-vscode-00a608068a821ad08ada553392eac3055356928858e48c5080b59fc97a316223", "text": "return getExtensionApi(onCompletionAccepted.event, pluginManager); }", "commid": "vscode_pr_105585"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-f01c17a12f09ad8cee28a82b51557f6dba9b57f4d978e511578a069f5c82165a", "text": "\"vscode-ripgrep\": \"^1.8.0\", \"vscode-sqlite3\": \"4.0.10\", \"vscode-textmate\": \"5.2.0\", <del> \"xterm\": \"4.9.0-beta.8\", </del> <ins> \"xterm\": \"4.9.0-beta.24\", </ins> \"xterm-addon-search\": \"0.7.0\", \"xterm-addon-unicode11\": \"0.2.0\", \"xterm-addon-webgl\": \"0.8.0\",", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-8c570f9f51eb9571e338012cc3e611445c65b524a45e7b4f8d3f0b61fda71ace", "text": "\"vscode-proxy-agent\": \"^0.5.2\", \"vscode-ripgrep\": \"^1.8.0\", \"vscode-textmate\": \"5.2.0\", <del> \"xterm\": \"4.9.0-beta.8\", </del> <ins> \"xterm\": \"4.9.0-beta.24\", </ins> \"xterm-addon-search\": \"0.7.0\", \"xterm-addon-unicode11\": \"0.2.0\", \"xterm-addon-webgl\": \"0.8.0\",", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-497129a461ded04f5728b51f129601902f4f4233be16e8363d93b18f54161358", "text": "\"semver-umd\": \"^5.5.7\", \"vscode-oniguruma\": \"1.3.1\", \"vscode-textmate\": \"5.2.0\", <del> \"xterm\": \"4.9.0-beta.8\", </del> <ins> \"xterm\": \"4.9.0-beta.24\", </ins> \"xterm-addon-search\": \"0.7.0\", \"xterm-addon-unicode11\": \"0.2.0\", \"xterm-addon-webgl\": \"0.8.0\"", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-f26f78c5e818f0a485d20264fde6855ecd67b96169763fc8d233daa404254db4", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.8.0.tgz#4bc6bb4dbfea5b0d2d7978d6c5cef922d584fb4f\" integrity sha512-dlpYPsv0C9S6v6+T/h/d/otSbdUTizMJdxvSoS34tUpMOHev6iW7Zqt5KRFqYxl4vCqpDk9Wmhb3fKL3kwX5fQ== <del> xterm@4.9.0-beta.8: version \"4.9.0-beta.8\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.8.tgz#ca121934d63f88668d2d5b11d9b2fc3bde7bd805\" integrity sha512-EEonYBLANDUBfEeEnHG632bZdgBaAUWst8LFr6oC6f2uLFfJGHQvVJuLaEkPtRvS+jOeoorEXZRPmso1/ANHXA== </del> <ins> xterm@4.9.0-beta.24: version \"4.9.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.24.tgz#48f0990c6d32ad3a9bcc4fb49531d7effdaccea5\" integrity sha512-CIVxxxbBiSw1WOMkIjjivaiIC9jNgih4klfWsRGx0qiDF5nbzHuLXkPTt+yAQUu9FCyTUwECm9Pkl3gUsSaGKg== </ins>", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-3035f38fa6b761357585729540b69322cb739c7f5f1ec05810cd15bf8e2c0ded", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.8.0.tgz#4bc6bb4dbfea5b0d2d7978d6c5cef922d584fb4f\" integrity sha512-dlpYPsv0C9S6v6+T/h/d/otSbdUTizMJdxvSoS34tUpMOHev6iW7Zqt5KRFqYxl4vCqpDk9Wmhb3fKL3kwX5fQ== <del> xterm@4.9.0-beta.8: version \"4.9.0-beta.8\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.8.tgz#ca121934d63f88668d2d5b11d9b2fc3bde7bd805\" integrity sha512-EEonYBLANDUBfEeEnHG632bZdgBaAUWst8LFr6oC6f2uLFfJGHQvVJuLaEkPtRvS+jOeoorEXZRPmso1/ANHXA== </del> <ins> xterm@4.9.0-beta.24: version \"4.9.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.24.tgz#48f0990c6d32ad3a9bcc4fb49531d7effdaccea5\" integrity sha512-CIVxxxbBiSw1WOMkIjjivaiIC9jNgih4klfWsRGx0qiDF5nbzHuLXkPTt+yAQUu9FCyTUwECm9Pkl3gUsSaGKg== </ins> yauzl@^2.9.2: version \"2.10.0\"", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-8cf046b3cdb5e5f3ed73e921be20494c85a52944e701e7c40e800dd10bae26ef", "text": "// Listen for modifier before handing it off to the hover to handle so it gets disposed correctly this._hoverListeners = new DisposableStore(); this._hoverListeners.add(dom.addDisposableListener(document, 'keydown', e => { <del> if (this._isModifierDown(e)) { </del> <ins> if (!e.repeat && this._isModifierDown(e)) { </ins> this._enableDecorations(); } })); this._hoverListeners.add(dom.addDisposableListener(document, 'keyup', e => { <del> if (!this._isModifierDown(e)) { </del> <ins> if (!e.repeat && !this._isModifierDown(e)) { </ins> this._disableDecorations(); } }));", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-2097c1ed4b4720227571e4f0017c86b63f34aa3c40f37a554622aef073f22cbe", "query": "Since we don't know when links are no longer cached by , we cannot drop the objects. Upstream part:", "positive_passages": [{"docid": "doc-en-vscode-aa443c26ecb78248fb67528d6fdf3019e81615002c08a9b2849f5ec63157cbb2", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.8.0.tgz#4bc6bb4dbfea5b0d2d7978d6c5cef922d584fb4f\" integrity sha512-dlpYPsv0C9S6v6+T/h/d/otSbdUTizMJdxvSoS34tUpMOHev6iW7Zqt5KRFqYxl4vCqpDk9Wmhb3fKL3kwX5fQ== <del> xterm@4.9.0-beta.8: version \"4.9.0-beta.8\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.8.tgz#ca121934d63f88668d2d5b11d9b2fc3bde7bd805\" integrity sha512-EEonYBLANDUBfEeEnHG632bZdgBaAUWst8LFr6oC6f2uLFfJGHQvVJuLaEkPtRvS+jOeoorEXZRPmso1/ANHXA== </del> <ins> xterm@4.9.0-beta.24: version \"4.9.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.9.0-beta.24.tgz#48f0990c6d32ad3a9bcc4fb49531d7effdaccea5\" integrity sha512-CIVxxxbBiSw1WOMkIjjivaiIC9jNgih4klfWsRGx0qiDF5nbzHuLXkPTt+yAQUu9FCyTUwECm9Pkl3gUsSaGKg== </ins> y18n@^3.2.1: version \"3.2.1\"", "commid": "vscode_pr_106153"}], "negative_passages": []}
{"query_id": "q-en-vscode-d8d936b13b3acbb45607408043406fdd5172e77353d58a403187577b49a1df3b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The repository picker feature allows to pick github repos after selecting the GitHub provider. Asking for option to default the provider to GitHub so that user can have one less click when creating a codespace. it lists all repos where you are owner, is it possible to list repos of organizations you are in as well? A side question is how does the api authenticate, is it with the stored git credentials in git extension? Thanks, Jason\nSure, I can accept a PR here. But let's call it . Note that multiple providers can have the same name, tho that is a hypothetical issue, so no worries. The code that gets the repositories lives in the GitHub core extension: Maybe by querying for you'd get those repos? If so, we could add another option to the command . Authentication is implemented via the GitHub Authentication core", "positive_passages": [{"docid": "doc-en-vscode-2c28de651c027e5d1f3f5c6d96566cc3bedb437c58a1e8c9acecdd1fb8d0681c", "text": "export interface PickRemoteSourceOptions { readonly providerLabel?: (provider: RemoteSourceProvider) => string; readonly urlLabel?: string; <ins> readonly providerName?: string; </ins> } export async function pickRemoteSource(model: Model, options: PickRemoteSourceOptions = {}): Promise<string | undefined> { const quickpick = window.createQuickPick<(QuickPickItem & { provider?: RemoteSourceProvider, url?: string })>(); quickpick.ignoreFocusOut = true; <del> const providers = model.getRemoteProviders() .map(provider => ({ label: (provider.icon ? `$(${provider.icon}) ` : '') + (options.providerLabel ? options.providerLabel(provider) : provider.name), alwaysShow: true, provider })); quickpick.placeholder = providers.length === 0 ? localize('provide url', \"Provide repository URL\") : localize('provide url or pick', \"Provide repository URL or pick a repository source.\"); const updatePicks = (value?: string) => { if (value) { quickpick.items = [{ label: options.urlLabel ?? localize('url', \"URL\"), description: value, alwaysShow: true, url: value }, ...providers]; } else { quickpick.items = providers; } }; quickpick.onDidChangeValue(updatePicks); updatePicks(); const result = await getQuickPickResult(quickpick); if (result) { if (result.url) { return result.url; } else if (result.provider) { const quickpick = new RemoteSourceProviderQuickPick(result.provider); const remote = await quickpick.pick(); if (remote) { if (typeof remote.url === 'string') { return remote.url; } else if (remote.url.length > 0) { return await window.showQuickPick(remote.url, { ignoreFocusOut: true, placeHolder: localize('pick url', \"Choose a URL to clone from.\") }); } </del> <ins> const targetedProvider = model.getRemoteProviders().filter(provider => provider.name === options.providerName); if (targetedProvider && targetedProvider.length === 1) { return await pickProviderSource(targetedProvider[0]); } else { const providers = model.getRemoteProviders() .map(provider => ({ label: (provider.icon ? `$(${provider.icon}) ` : '') + (options.providerLabel ? options.providerLabel(provider) : provider.name), alwaysShow: true, provider })); quickpick.placeholder = providers.length === 0 ? localize('provide url', \"Provide repository URL\") : localize('provide url or pick', \"Provide repository URL or pick a repository source.\"); const updatePicks = (value?: string) => { if (value) { quickpick.items = [{ label: options.urlLabel ?? localize('url', \"URL\"), description: value, alwaysShow: true, url: value }, ...providers]; } else { quickpick.items = providers; } }; quickpick.onDidChangeValue(updatePicks); updatePicks(); const result = await getQuickPickResult(quickpick); if (result) { if (result.url) { return result.url; } else if (result.provider) { return await pickProviderSource(result.provider); </ins> } } } return undefined; } <ins> async function pickProviderSource(provider: RemoteSourceProvider): Promise<string | undefined> { const quickpick = new RemoteSourceProviderQuickPick(provider); const remote = await quickpick.pick(); if (remote) { if (typeof remote.url === 'string') { return remote.url; } else if (remote.url.length > 0) { return await window.showQuickPick(remote.url, { ignoreFocusOut: true, placeHolder: localize('pick url', \"Choose a URL to clone from.\") }); } } return undefined; } </ins>", "commid": "vscode_pr_106368"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-167386d0bade2017766e65c172a2e61c4cfb5fbc587e61fdf72af9a59bcb9f24", "text": "{ \"view\": \"scm\", \"contents\": \"%view.workbench.scm.empty%\", <del> \"when\": \"config.git.enabled && git.state == initialized && workbenchState == empty\", </del> <ins> \"when\": \"config.git.enabled && workbenchState == empty\", \"enablement\": \"git.state == initialized\", </ins> \"group\": \"2_open@1\" }, { \"view\": \"scm\", \"contents\": \"%view.workbench.scm.folder%\", <del> \"when\": \"config.git.enabled && git.state == initialized && workbenchState == folder\", </del> <ins> \"when\": \"config.git.enabled && workbenchState == folder\", \"enablement\": \"git.state == initialized\", </ins> \"group\": \"5_scm@1\" }, { \"view\": \"scm\", \"contents\": \"%view.workbench.scm.workspace%\", \"when\": \"config.git.enabled && git.state == initialized && workbenchState == workspace && workspaceFolderCount != 0\", <ins> \"enablement\": \"git.state == initialized\", </ins> \"group\": \"5_scm@1\" }, { \"view\": \"scm\", \"contents\": \"%view.workbench.scm.emptyWorkspace%\", <del> \"when\": \"config.git.enabled && git.state == initialized && workbenchState == workspace && workspaceFolderCount == 0\", </del> <ins> \"when\": \"config.git.enabled && workbenchState == workspace && workspaceFolderCount == 0\", \"enablement\": \"git.state == initialized\", </ins> \"group\": \"2_open@1\" }, { \"view\": \"explorer\", \"contents\": \"%view.workbench.cloneRepository%\", <del> \"when\": \"config.git.enabled && git.state == initialized\", </del> <ins> \"when\": \"config.git.enabled\", \"enablement\": \"git.state == initialized\", </ins> \"group\": \"5_scm@1\" } ]", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-10a8de5de290732b4442f2b5fd023cccfd3ff5956ef72262edbdc98ddc307e43", "text": "\"view.workbench.scm.folder\": \"The folder currently open doesn't have a git repository. You can initialize a repository which will enable source control features powered by git.n[Initialize Repository](command:git.init?%5Btrue%5D)nTo learn more about how to use git and source control in VS Code [read our docs](https://aka.ms/vscode-scm).\", \"view.workbench.scm.workspace\": \"The workspace currently open doesn't have any folders containing git repositories. You can initialize a repository on a folder which will enable source control features powered by git.n[Initialize Repository](command:git.init)nTo learn more about how to use git and source control in VS Code [read our docs](https://aka.ms/vscode-scm).\", \"view.workbench.scm.emptyWorkspace\": \"The workspace currently open doesn't have any folders containing git repositories.n[Add Folder to Workspace](command:workbench.action.addRootFolder)nTo learn more about how to use git and source control in VS Code [read our docs](https://aka.ms/vscode-scm).\", <del> \"view.workbench.cloneRepository\": \"You can also clone a repository from a URL. To learn more about how to use git and source control in VS Code [read our docs](https://aka.ms/vscode-scm).n[Clone Repository](command:git.clone)\" </del> <ins> \"view.workbench.cloneRepository\": \"You can also clone a repository from a URL. To learn more about how to use git and source control in VS Code [read our docs](https://aka.ms/vscode-scm).n[Clone Repository](command:git.clone 'Clone a repository once the git extension has activated')\" </ins> }", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-c7e145a215b565198f8d8eeb6d661a065c74add783a121962436e5edefaa078d", "text": "this.bodyContainer.classList.add('welcome'); this.viewWelcomeContainer.innerText = ''; <del> let buttonIndex = 0; </del> for (const { content, preconditions } of contents) { <ins> let buttonIndex = 0; </ins> const lines = content.split('n'); for (let line of lines) {", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-d92dcc6724c1bb084d2ae05292e3f2fdf452c7daa65e34b4e608b654e64d8455", "text": "for (const welcome of contribution.value) { const id = ViewIdentifierMap[welcome.view] ?? welcome.view; const { group, order } = parseGroupAndOrder(welcome, contribution); <ins> const enablement = ContextKeyExpr.deserialize(welcome.enablement); </ins> const disposable = viewsRegistry.registerViewWelcomeContent(id, { content: welcome.contents, when: ContextKeyExpr.deserialize(welcome.when), <ins> // supply the enablement clause for each line in case the line defines a button preconditions: welcome.contents.split('n').map((_) => enablement), </ins> group, order });", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-323a02f624338371fbc74b26f8541280dad243c8f76a93e161a9efdc796109e2", "text": "contents = 'contents', when = 'when', group = 'group', <ins> enablement = 'enablement', </ins> } export interface ViewWelcome {", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-7d747f69a6c898341afe709f058dd8406e4ae6297782fa9bd34993f1f4de932c", "text": "readonly [ViewsWelcomeExtensionPointFields.contents]: string; readonly [ViewsWelcomeExtensionPointFields.when]: string; readonly [ViewsWelcomeExtensionPointFields.group]: string; <ins> readonly [ViewsWelcomeExtensionPointFields.enablement]: string; </ins> } export type ViewsWelcomeExtensionPoint = ViewWelcome[];", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0ceb1d2bb8c2c54722542b33941e4cd5dae1c375b8c11d1379be40a3c95fe78", "query": "Below is a recording of a Control-R reload when no workspace is open and one non-builtin extension is contributing to to the Welcome view of Explorer. ! Observe how we start with Explorer's usual \"NO FOLDER OPEN\" view. Next my extension contributes its text and buttons. Finally the built-in git extension contributes text and a button. Since built-ins get higher priority the content from my extension jumps downward, perhaps while I'm reading it or trying to click one of its actions (link, button). There's no progress indicator when the content is being fetched and assembled, and it's hard to know how long to wait before concluding that no other extensions are going to contribute. VS Code version: Code 1.49.0 (, 2020-09-10T13:22:08.892Z) OS version: Windows_NT x64 10.0.\nSimilarly on the Source Control view, it starts with a message saying \"No source control providers registered\" and stays this way long enough for me to worry that something is broken or missing. Eventually the contribution from the git extension arrives. If a progress indicator isn't , maybe at least the initial message could say something like \"Please wait while we look for source control providers\". Then if nothing contributes (e.g. the git extension has been disabled,) it could then display \"No source control providers registered\".\nThis will be very hard to achieve. The problem here isn't actually the extension point, for which we could definitely add a progress indicator, but the activation of the git extension. That git section won't appear until the git extension is activated and all the potential repo locations have been probed... We simply can't add a progress indicator for that in the core unless we add some more API.\nOn this, we could potentially add a message.\nThat might help.\nClosing this until we get actual user feedback that it's needed, sorry", "positive_passages": [{"docid": "doc-en-vscode-c99d56f0c288070a282ce4c49009ff294870304aef5bc90d2e19294fb6b8ad7b", "text": "type: 'string', description: nls.localize('contributes.viewsWelcome.view.group', \"Group to which this welcome content belongs.\"), }, <ins> [ViewsWelcomeExtensionPointFields.enablement]: { type: 'string', description: nls.localize('contributes.viewsWelcome.view.enablement', \"Condition when the welcome content buttons should be enabled.\"), }, </ins> } } });", "commid": "vscode_pr_107705"}], "negative_passages": []}
{"query_id": "q-en-vscode-5d8d684e0ddc6fe6c4200376a869a59639e328e4a78e0b75f318641ddb67e502", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2- -1.49.0- OS Version: Ubuntu 20.04.1 LTS Steps to Reproduce: -dev not installed and install code1.48.2- --VSCode works apt update; apt-upgrade VSCode to 1.49.0- --VSCode fails with: /usr/share/code/bin/../code: error while loading shared libraries: cannot open shared object file: No such file or directory install libgbm-dev --VSCode works Expected: upgrade checks for dependency and installs missing library\nnew Electron 9 dep needs to be declared here?\nI didn't know about this dependency configuration in the codebase, yes adding should be sufficient. It is a new dependency for chromium 83 to use memory buffers in gpu code path.\nThis bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nTested this by upgrading from 1.48.2 to 1.50.1", "positive_passages": [{"docid": "doc-en-vscode-814528b88934719a49ddf7e2f161ef448e27d076c990b8f715873e14635f5b8b", "text": "Package: @@NAME@@ Version: @@VERSION@@ Section: devel <del> Depends: libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1 </del> <ins> Depends: libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1, libgbm1 </ins> Priority: optional Architecture: @@ARCHITECTURE@@ Maintainer: Microsoft Corporation <vscode-linux@microsoft.com>", "commid": "vscode_pr_107611"}], "negative_passages": []}
{"query_id": "q-en-vscode-5d8d684e0ddc6fe6c4200376a869a59639e328e4a78e0b75f318641ddb67e502", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2- -1.49.0- OS Version: Ubuntu 20.04.1 LTS Steps to Reproduce: -dev not installed and install code1.48.2- --VSCode works apt update; apt-upgrade VSCode to 1.49.0- --VSCode fails with: /usr/share/code/bin/../code: error while loading shared libraries: cannot open shared object file: No such file or directory install libgbm-dev --VSCode works Expected: upgrade checks for dependency and installs missing library\nnew Electron 9 dep needs to be declared here?\nI didn't know about this dependency configuration in the codebase, yes adding should be sufficient. It is a new dependency for chromium 83 to use memory buffers in gpu code path.\nThis bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nTested this by upgrading from 1.48.2 to 1.50.1", "positive_passages": [{"docid": "doc-en-vscode-e7b5ed080eba5c5cf1688fcc7bd06488f73c8c4d6e610d5cd98101f9d6d03183", "text": "\"libc.so.6(GLIBC_2.9)(64bit)\", \"libxcb.so.1()(64bit)\", \"libxkbfile.so.1()(64bit)\", <del> \"libsecret-1.so.0()(64bit)\" </del> <ins> \"libsecret-1.so.0()(64bit)\", \"libgbm.so.1()(64bit)\" </ins> ], \"aarch64\": [ \"libpthread.so.0()(aarch64)\",", "commid": "vscode_pr_107611"}], "negative_passages": []}
{"query_id": "q-en-vscode-5d8d684e0ddc6fe6c4200376a869a59639e328e4a78e0b75f318641ddb67e502", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2- -1.49.0- OS Version: Ubuntu 20.04.1 LTS Steps to Reproduce: -dev not installed and install code1.48.2- --VSCode works apt update; apt-upgrade VSCode to 1.49.0- --VSCode fails with: /usr/share/code/bin/../code: error while loading shared libraries: cannot open shared object file: No such file or directory install libgbm-dev --VSCode works Expected: upgrade checks for dependency and installs missing library\nnew Electron 9 dep needs to be declared here?\nI didn't know about this dependency configuration in the codebase, yes adding should be sufficient. It is a new dependency for chromium 83 to use memory buffers in gpu code path.\nThis bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nTested this by upgrading from 1.48.2 to 1.50.1", "positive_passages": [{"docid": "doc-en-vscode-16f3479cd50d781d9a89f694257df10b5ac616a36712f00183a0a048fc57244b", "text": "- libgconf-2-4 - libglib2.0-bin - libgnome-keyring0 <ins> - libgbm1 </ins> - libgtk-3-0 - libnotify4 - libnspr4", "commid": "vscode_pr_107611"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-45e2b0490a088f2c68acaa275873641f2c213e7c2ce0eaa15f0a338a52b69a63", "text": "const editorService = accessor.get(IEditorService); const viewsService = accessor.get(IViewsService); const notificationService = accessor.get(INotificationService); <ins> const workingCopyFileService = accessor.get(IWorkingCopyFileService); </ins> await viewsService.openView(VIEW_ID, true);", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-47621c52105070e7bf16b608120825b5e54135cc233a625a124fdcdc53c75265", "text": "const onSuccess = async (value: string): Promise<void> => { try { <del> const created = isFolder ? await fileService.createFolder(resources.joinPath(folder.resource, value)) : await textFileService.create(resources.joinPath(folder.resource, value)); </del> <ins> const created = isFolder ? await workingCopyFileService.createFolder(resources.joinPath(folder.resource, value)) : await textFileService.create(resources.joinPath(folder.resource, value)); </ins> await refreshIfSeparator(value, explorerService); isFolder ?", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-6071caab4a2b613b72d4f30795d945780ab0820c8d6b401b263f400be4535d66", "text": "create(resource: URI, contents?: VSBuffer | VSBufferReadable | VSBufferReadableStream, options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata>; /** <ins> * Will create a folder and any parent folder that needs to be created. * * Working copy owners can listen to the `onWillRunWorkingCopyFileOperation` and * `onDidRunWorkingCopyFileOperation` events to participate. * * Note: events will only be emitted for the provided resource, but not any * parent folders that are being created as part of the operation. */ createFolder(resource: URI): Promise<IFileStatWithMetadata>; /** </ins> * Will move working copies matching the provided resources and corresponding children * to the target resources using the associated file service for those resources. *", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-c5d173ce64ada57a59aad97c366e5afbf17dd0ef4faa999841e1749692f580e4", "text": "//#region File operations <del> async create(resource: URI, contents?: VSBuffer | VSBufferReadable | VSBufferReadableStream, options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata> { </del> <ins> create(resource: URI, contents?: VSBuffer | VSBufferReadable | VSBufferReadableStream, options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata> { return this.doCreateFileOrFolder(resource, true, contents, options); } createFolder(resource: URI, options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata> { return this.doCreateFileOrFolder(resource, false); } async doCreateFileOrFolder(resource: URI, isFile: boolean, contents?: VSBuffer | VSBufferReadable | VSBufferReadableStream, options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata> { </ins> // validate create operation before starting <del> const validateCreate = await this.fileService.canCreateFile(resource, options); if (validateCreate instanceof Error) { throw validateCreate; </del> <ins> if (isFile) { const validateCreate = await this.fileService.canCreateFile(resource, options); if (validateCreate instanceof Error) { throw validateCreate; } </ins> } // file operation participant", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-d4fc7e85dbacff585935ccc76b6c014ed0f47dc0674efe7c93942a30bb7b1325", "text": "// now actually create on disk let stat: IFileStatWithMetadata; try { <del> stat = await this.fileService.createFile(resource, contents, { overwrite: options?.overwrite }); </del> <ins> if (isFile) { stat = await this.fileService.createFile(resource, contents, { overwrite: options?.overwrite }); } else { stat = await this.fileService.createFolder(resource); } </ins> } catch (error) { // error event", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-c4add506df96b07b07778a3fcc5a02cd1f6f25467d86d89553112b418fb13d64", "text": "model1.dispose(); }); <ins> test('createFolder', async function () { let eventCounter = 0; let correlationId: number | undefined = undefined; const resource = toResource.call(this, '/path/folder'); const participant = accessor.workingCopyFileService.addFileOperationParticipant({ participate: async (files, operation) => { assert.equal(files.length, 1); const file = files[0]; assert.equal(file.target.toString(), resource.toString()); assert.equal(operation, FileOperation.CREATE); eventCounter++; } }); const listener1 = accessor.workingCopyFileService.onWillRunWorkingCopyFileOperation(e => { assert.equal(e.files.length, 1); const file = e.files[0]; assert.equal(file.target.toString(), resource.toString()); assert.equal(e.operation, FileOperation.CREATE); correlationId = e.correlationId; eventCounter++; }); const listener2 = accessor.workingCopyFileService.onDidRunWorkingCopyFileOperation(e => { assert.equal(e.files.length, 1); const file = e.files[0]; assert.equal(file.target.toString(), resource.toString()); assert.equal(e.operation, FileOperation.CREATE); assert.equal(e.correlationId, correlationId); eventCounter++; }); await accessor.workingCopyFileService.createFolder(resource); assert.equal(eventCounter, 3); participant.dispose(); listener1.dispose(); listener2.dispose(); }); </ins> async function testEventsMoveOrCopy(files: { source: URI, target: URI }[], move?: boolean): Promise<number> { let eventCounter = 0;", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-8429e79801d1188f59257bb8e53ffa9b97809bfed3e48386b8b961a627ea5c32", "text": "move(_source: URI, _target: URI, _overwrite?: boolean): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } copy(_source: URI, _target: URI, _overwrite?: boolean): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } createFile(_resource: URI, _content?: VSBuffer | VSBufferReadable, _options?: ICreateFileOptions): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } <del> createFolder(_resource: URI): Promise<IFileStatWithMetadata> { throw new Error('not implemented'); } </del> <ins> createFolder(_resource: URI): Promise<IFileStatWithMetadata> { return Promise.resolve(null!); } </ins> onDidChangeFileSystemProviderRegistrations = Event.None;", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-f1909379a13d16df149b23bf1bb7a2e135c2232f10c77d159dfcb04b7cbe715f", "query": "It does fire for folder on move and delete. According to the reason lies here: The code goes directly to the file service. Since we correctly report move and delete for folders I think we should report create as well.\nSome background: I want to adopt this in LSP but specing that this only works for move and delete of folders sounds a little silly. So I want to make sure that there is either a very compelling reason or there is some ack. that we will fix it in the future.\nWe currently have no related method such as for folders that the explorer could use here: If we support this, I guess one question in terms of API breakage is wether it is fine to let and emit events for folders too while they currently only emit for files. If we think this is fine, then I think this would be a relatively simple change to make.\nI don't consider that breakage, it's a bug fix esp. given that move and delete already fire events for both\nVerification: write an extension that registers to and and verify you see both events when you right click into the explorer and create a new folder.\nThanks for fixing!", "positive_passages": [{"docid": "doc-en-vscode-e3b9022a0d798333d2fbc8b59b7424837dfdc1854f05d121b4e10ae803ccc79f", "text": "getDirty(resource: URI): IWorkingCopy[] { return []; } create(resource: URI, contents?: VSBuffer | VSBufferReadable | VSBufferReadableStream, options?: { overwrite?: boolean | undefined; } | undefined): Promise<IFileStatWithMetadata> { throw new Error('Method not implemented.'); } <ins> createFolder(resource: URI): Promise<IFileStatWithMetadata> { throw new Error('Method not implemented.'); } </ins> move(files: { source: URI; target: URI; }[], options?: { overwrite?: boolean }): Promise<IFileStatWithMetadata[]> { throw new Error('Method not implemented.'); }", "commid": "vscode_pr_109294"}], "negative_passages": []}
{"query_id": "q-en-vscode-9119167c4f8294f035fc1a9a9e00cf232793584e8138e0db4ba49afa3400a45c", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --This would prevent needing to convert the to a string only for it to be parsed back into a later on, and is friendlier to developers.\nproposed or finalized?", "positive_passages": [{"docid": "doc-en-vscode-5e53b4729473efb7a13bddfed5ba885ec502856d70349e6da79cbf5cadf929a0", "text": "* @param pattern A file glob pattern like `*.{ts,js}` that will be matched on file paths * relative to the base path. */ <del> constructor(base: WorkspaceFolder | string, pattern: string) </del> <ins> constructor(base: Uri | WorkspaceFolder | string, pattern: string) </ins> } /**", "commid": "vscode_pr_111155"}], "negative_passages": []}
{"query_id": "q-en-vscode-9119167c4f8294f035fc1a9a9e00cf232793584e8138e0db4ba49afa3400a45c", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --This would prevent needing to convert the to a string only for it to be parsed back into a later on, and is friendlier to developers.\nproposed or finalized?", "positive_passages": [{"docid": "doc-en-vscode-8375038373bb59bb8d5c4edb207cf36fb7a848a88e8eca93df1462b9f95773c8", "text": "pattern: string; <del> constructor(base: vscode.WorkspaceFolder | string, pattern: string) { </del> <ins> constructor(base: URI | vscode.WorkspaceFolder | string, pattern: string) { </ins> if (typeof base !== 'string') { <del> if (!base || !URI.isUri(base.uri)) { </del> <ins> if (!base || !URI.isUri(base) && !URI.isUri(base.uri)) { </ins> throw illegalArgument('base'); } }", "commid": "vscode_pr_111155"}], "negative_passages": []}
{"query_id": "q-en-vscode-9119167c4f8294f035fc1a9a9e00cf232793584e8138e0db4ba49afa3400a45c", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --This would prevent needing to convert the to a string only for it to be parsed back into a later on, and is friendlier to developers.\nproposed or finalized?", "positive_passages": [{"docid": "doc-en-vscode-751b0779c14cdb123caa2f074238102f52dbd459c1d56e7825d09dfd68973a2a", "text": "if (typeof base === 'string') { this.base = base; <ins> } else if (URI.isUri(base)) { this.baseFolder = base; this.base = base.fsPath; </ins> } else { this.baseFolder = base.uri; this.base = base.uri.fsPath;", "commid": "vscode_pr_111155"}], "negative_passages": []}
{"query_id": "q-en-vscode-e9b4bfa229478cd12572af832214a1f3fb195e76e290258671308855c2a6257c", "query": "Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !\nThis still reproduces\ndoes this still repro? maybe its imperceptible to me?\nYeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?\nlooks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately\nYeah that seems like a reasonable ask since it goes to the extension host and back, today.\nThis issue has existed since 2 years! But only recently have I encountered this.", "positive_passages": [{"docid": "doc-en-vscode-d31db9f2b8394a282fff21985af020286d248738cad53ca97848cbcdf859eb18", "text": "import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { getCurrentAuthenticationSessionInfo } from 'vs/workbench/services/authentication/browser/authenticationService'; <del> import { AuthenticationSession, IAuthenticationService } from 'vs/workbench/services/authentication/common/authentication'; </del> <ins> import { AuthenticationSessionAccount, IAuthenticationService } from 'vs/workbench/services/authentication/common/authentication'; </ins> import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IProductService } from 'vs/platform/product/common/productService';", "commid": "vscode_pr_176319"}], "negative_passages": []}
{"query_id": "q-en-vscode-e9b4bfa229478cd12572af832214a1f3fb195e76e290258671308855c2a6257c", "query": "Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !\nThis still reproduces\ndoes this still repro? maybe its imperceptible to me?\nYeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?\nlooks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately\nYeah that seems like a reasonable ask since it goes to the extension host and back, today.\nThis issue has existed since 2 years! But only recently have I encountered this.", "positive_passages": [{"docid": "doc-en-vscode-957887733b942fb0a580ccc6c60722ce59d49390c5f0400f32bcfde6897ff590", "text": "import { ICredentialsService } from 'vs/platform/credentials/common/credentials'; import { IUserDataProfileService } from 'vs/workbench/services/userDataProfile/common/userDataProfile'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> export class ViewContainerActivityAction extends ActivityAction {", "commid": "vscode_pr_176319"}], "negative_passages": []}
{"query_id": "q-en-vscode-e9b4bfa229478cd12572af832214a1f3fb195e76e290258671308855c2a6257c", "query": "Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !\nThis still reproduces\ndoes this still repro? maybe its imperceptible to me?\nYeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?\nlooks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately\nYeah that seems like a reasonable ask since it goes to the extension host and back, today.\nThis issue has existed since 2 years! But only recently have I encountered this.", "positive_passages": [{"docid": "doc-en-vscode-9357a40506b26ed5eb37ea561e74b1be267e7425e2fa2161888370abfc97579d", "text": "static readonly ACCOUNTS_VISIBILITY_PREFERENCE_KEY = 'workbench.activity.showAccounts'; <ins> private readonly groupedAccounts: Map<string, (AuthenticationSessionAccount & { canSignOut: boolean })[]> = new Map(); private readonly problematicProviders: Set<string> = new Set(); private initialized = false; private sessionFromEmbedder = getCurrentAuthenticationSessionInfo(this.credentialsService, this.productService); </ins> constructor( action: ActivityAction, contextMenuActionsProvider: () => IAction[],", "commid": "vscode_pr_176319"}], "negative_passages": []}
{"query_id": "q-en-vscode-e9b4bfa229478cd12572af832214a1f3fb195e76e290258671308855c2a6257c", "query": "Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !\nThis still reproduces\ndoes this still repro? maybe its imperceptible to me?\nYeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?\nlooks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately\nYeah that seems like a reasonable ask since it goes to the extension host and back, today.\nThis issue has existed since 2 years! But only recently have I encountered this.", "positive_passages": [{"docid": "doc-en-vscode-363a7dda0c985bfaee94d9c0884ad883d9c7987e7408110560e2916ee68393f9", "text": "@IStorageService private readonly storageService: IStorageService, @IKeybindingService keybindingService: IKeybindingService, @ICredentialsService private readonly credentialsService: ICredentialsService, <ins> @ILogService private readonly logService: ILogService </ins> ) { super(MenuId.AccountsContext, action, contextMenuActionsProvider, true, colors, activityHoverOptions, themeService, hoverService, menuService, contextMenuService, contextKeyService, configurationService, environmentService, keybindingService); <ins> this.registerListeners(); this.initialize(); } private registerListeners(): void { this._register(this.authenticationService.onDidRegisterAuthenticationProvider(async (e) => { await this.addAccountsFromProvider(e.id); })); this._register(this.authenticationService.onDidUnregisterAuthenticationProvider((e) => { this.groupedAccounts.delete(e.id); this.problematicProviders.delete(e.id); })); this._register(this.authenticationService.onDidChangeSessions(async e => { const promises = []; for (const changed of e.event.changed) { promises.push(this.addOrUpdateAccount(e.providerId, changed.account)); } for (const added of e.event.added) { promises.push(this.addOrUpdateAccount(e.providerId, added.account)); } const result = await Promise.allSettled(promises); for (const r of result) { if (r.status === 'rejected') { this.logService.error(r.reason); } } for (const removed of e.event.removed) { this.removeAccount(e.providerId, removed.account); } })); } // This function exists to ensure that the accounts are added for auth providers that had already been registered // before the menu was created. private async initialize(): Promise<void> { const providerIds = this.authenticationService.getProviderIds(); const results = await Promise.allSettled(providerIds.map(providerId => this.addAccountsFromProvider(providerId))); // Log any errors that occurred while initializing. We try to be best effort here to show the most amount of accounts for (const result of results) { if (result.status === 'rejected') { this.logService.error(result.reason); } } this.initialized = true; </ins> } <ins> //#region overrides </ins> protected override async resolveMainMenuActions(accountsMenu: IMenu, disposables: DisposableStore): Promise<IAction[]> { await super.resolveMainMenuActions(accountsMenu, disposables); <del> const otherCommands = accountsMenu.getActions(); </del> const providers = this.authenticationService.getProviderIds(); <del> const allSessions = providers.map(async providerId => { try { const sessions = await this.authenticationService.getSessions(providerId); const groupedSessions: { [label: string]: AuthenticationSession[] } = {}; sessions.forEach(session => { if (groupedSessions[session.account.label]) { groupedSessions[session.account.label].push(session); } else { groupedSessions[session.account.label] = [session]; } }); </del> <ins> const otherCommands = accountsMenu.getActions(); let menus: IAction[] = []; </ins> <del> return { providerId, sessions: groupedSessions }; } catch { return { providerId }; </del> <ins> for (const providerId of providers) { if (!this.initialized) { const noAccountsAvailableAction = disposables.add(new Action('noAccountsAvailable', localize('loading', \"Loading...\"), undefined, false)); menus.push(noAccountsAvailableAction); break; } const providerLabel = this.authenticationService.getLabel(providerId); const accounts = this.groupedAccounts.get(providerId); if (!accounts) { if (this.problematicProviders.has(providerId)) { const providerUnavailableAction = disposables.add(new Action('providerUnavailable', localize('authProviderUnavailable', '{0} is currently unavailable', providerLabel), undefined, false)); menus.push(providerUnavailableAction); // try again in the background so that if the failure was intermittent, we can resolve it on the next showing of the menu try { await this.addAccountsFromProvider(providerId); } catch (e) { this.logService.error(e); } } continue; </ins> } <del> }); const result = await Promise.all(allSessions); let menus: IAction[] = []; const authenticationSession = await getCurrentAuthenticationSessionInfo(this.credentialsService, this.productService); result.forEach(sessionInfo => { const providerDisplayName = this.authenticationService.getLabel(sessionInfo.providerId); if (sessionInfo.sessions) { Object.keys(sessionInfo.sessions).forEach(accountName => { const manageExtensionsAction = disposables.add(new Action(`configureSessions${accountName}`, localize('manageTrustedExtensions', \"Manage Trusted Extensions\"), '', true, () => { return this.authenticationService.manageTrustedExtensionsForAccount(sessionInfo.providerId, accountName); })); const signOutAction = disposables.add(new Action('signOut', localize('signOut', \"Sign Out\"), '', true, () => { return this.authenticationService.removeAccountSessions(sessionInfo.providerId, accountName, sessionInfo.sessions[accountName]); })); </del> <ins> for (const account of accounts) { const manageExtensionsAction = disposables.add(new Action(`configureSessions${account.label}`, localize('manageTrustedExtensions', \"Manage Trusted Extensions\"), undefined, true, () => { return this.authenticationService.manageTrustedExtensionsForAccount(providerId, account.label); })); </ins> <del> const providerSubMenuActions = [manageExtensionsAction]; </del> <ins> const providerSubMenuActions: Action[] = [manageExtensionsAction]; </ins> <del> const hasEmbedderAccountSession = sessionInfo.sessions[accountName].some(session => session.id === (authenticationSession?.id)); if (!hasEmbedderAccountSession || authenticationSession?.canSignOut) { providerSubMenuActions.push(signOutAction); } </del> <ins> if (account.canSignOut) { const signOutAction = disposables.add(new Action('signOut', localize('signOut', \"Sign Out\"), undefined, true, async () => { const allSessions = await this.authenticationService.getSessions(providerId); const sessionsForAccount = allSessions.filter(s => s.account.id === account.id); return await this.authenticationService.removeAccountSessions(providerId, account.label, sessionsForAccount); })); providerSubMenuActions.push(signOutAction); } </ins> <del> const providerSubMenu = new SubmenuAction('activitybar.submenu', `${accountName} (${providerDisplayName})`, providerSubMenuActions); menus.push(providerSubMenu); }); } else { const providerUnavailableAction = disposables.add(new Action('providerUnavailable', localize('authProviderUnavailable', '{0} is currently unavailable', providerDisplayName))); menus.push(providerUnavailableAction); </del> <ins> const providerSubMenu = new SubmenuAction('activitybar.submenu', `${account.label} (${providerLabel})`, providerSubMenuActions); menus.push(providerSubMenu); </ins> } <del> }); </del> <ins> } </ins> if (providers.length && !menus.length) { const noAccountsAvailableAction = disposables.add(new Action('noAccountsAvailable', localize('noAccounts', \"You are not signed in to any accounts\"), undefined, false));", "commid": "vscode_pr_176319"}], "negative_passages": []}
{"query_id": "q-en-vscode-e9b4bfa229478cd12572af832214a1f3fb195e76e290258671308855c2a6257c", "query": "Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !\nThis still reproduces\ndoes this still repro? maybe its imperceptible to me?\nYeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?\nlooks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately\nYeah that seems like a reasonable ask since it goes to the extension host and back, today.\nThis issue has existed since 2 years! But only recently have I encountered this.", "positive_passages": [{"docid": "doc-en-vscode-be68aa859c79a4aed5e6c07c42c021d18a4682c587efb1de20a97dfdc99dff0d", "text": "return actions; } <ins> //#endregion //#region groupedAccounts helpers private async addOrUpdateAccount(providerId: string, account: AuthenticationSessionAccount): Promise<void> { const accounts = this.groupedAccounts.get(providerId); const existingAccount = accounts?.find(a => a.id === account.id); if (existingAccount) { if (existingAccount.label !== account.label) { existingAccount.label = account.label; } return; } const sessionFromEmbedder = await this.sessionFromEmbedder; // If the session stored from the embedder allows sign out, then we can treat it and all others as sign out-able let canSignOut = !!sessionFromEmbedder?.canSignOut; if (!canSignOut) { if (sessionFromEmbedder?.id) { const sessions = (await this.authenticationService.getSessions(providerId)).filter(s => s.account.id === account.id); canSignOut = !sessions.some(s => s.id === sessionFromEmbedder.id); } else { // The default if we don't have a session from the embedder is to allow sign out canSignOut = true; } } if (!accounts) { this.groupedAccounts.set(providerId, [{ ...account, canSignOut }]); return; } accounts.push({ ...account, canSignOut }); } private removeAccount(providerId: string, account: AuthenticationSessionAccount): void { const accounts = this.groupedAccounts.get(providerId); if (!accounts) { return; } const index = accounts.findIndex(a => a.id === account.id); if (index === -1) { return; } accounts.splice(index, 1); if (accounts.length === 0) { this.groupedAccounts.delete(providerId); } } private async addAccountsFromProvider(providerId: string): Promise<void> { try { const sessions = await this.authenticationService.getSessions(providerId); this.problematicProviders.delete(providerId); const result = await Promise.allSettled(sessions.map(s => this.addOrUpdateAccount(providerId, s.account))); for (const r of result) { if (r.status === 'rejected') { this.logService.error(r.reason); } } } catch (e) { this.logService.error(e); this.problematicProviders.add(providerId); } } //#endregion </ins> } export interface IProfileActivity extends IActivity {", "commid": "vscode_pr_176319"}], "negative_passages": []}
{"query_id": "q-en-vscode-e9b4bfa229478cd12572af832214a1f3fb195e76e290258671308855c2a6257c", "query": "Update: reproduces in web + desktop Steps to Reproduce: a Codespace until it is loaded various activity bar items that open menus (gear menu, accounts, main menu, home indicator) = somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking? !\nThis still reproduces\ndoes this still repro? maybe its imperceptible to me?\nYeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?\nlooks like we fetch session info every time, so this probably adds some delay. maybe this can be cached and updated separately\nYeah that seems like a reasonable ask since it goes to the extension host and back, today.\nThis issue has existed since 2 years! But only recently have I encountered this.", "positive_passages": [{"docid": "doc-en-vscode-acf9443eba3fb8ae609d460cf56289a53ba79ccc11763c6cbe13a9bbd7b3bcaa", "text": "import { Event } from 'vs/base/common/event'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; <ins> export interface AuthenticationSessionAccount { label: string; id: string; } </ins> export interface AuthenticationSession { id: string; accessToken: string; <del> account: { label: string; id: string; }; </del> <ins> account: AuthenticationSessionAccount; </ins> scopes: ReadonlyArray<string>; idToken?: string; }", "commid": "vscode_pr_176319"}], "negative_passages": []}
{"query_id": "q-en-vscode-553e1ae93832a9eb05964b687b7920ffe6b60544ff0f65d9ab0d0bf7173ea2ee", "query": "The find widget's update history is wrapped in a delayer promise which can cause an unhandled promise rejection when the widget is getting disposed of if the delayer's completion promise hasn't been cleanup up. This can happen if the editor is closed before the find widget has time to finish closing. This change addressed the issue by handling the rejected promise returned by . <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.51.1 OS Version: macOS Steps to Reproduce: new editor. -F to open the find widget. to close the find widget and quickly close the editor before the widget has time to close.", "positive_passages": [{"docid": "doc-en-vscode-5013f423116ad96615f18b281828001830e68a7517c90ee35b460ba2610a9e04", "text": "} private _delayedUpdateHistory() { <del> this._updateHistoryDelayer.trigger(this._updateHistory.bind(this)); </del> <ins> this._updateHistoryDelayer.trigger(this._updateHistory.bind(this)).then(undefined, onUnexpectedError); </ins> } private _updateHistory() {", "commid": "vscode_pr_111541"}], "negative_passages": []}
{"query_id": "q-en-vscode-47f30727aa358653f75b2494291faddb6ea3cdf0b740273c2ae6cbcc86bacffc", "query": "We have been seeing a bunch of remote issues where the remote extension host burns a lot of CPU. I think it is caused by our port scanning code, which executes even if the setting is false. See Possible issues: / Other: ? ? ? *\nLooks like we need to work on our indentation and ensuring that we break lines once they go past the edge of the screen for the sake of readability\nI could reproduce some increased CPU usage of the remote extension host using the project linked to i.e.\nIn insiders, you can now temporarily disable the port scanning code by adding this line to your .bashrc file, then restarting the VS Code server on your remote:\nOnce we have an insiders build I'll start commenting in each of the issues asking folks to try out the workaround in insiders.\nKeeping open for now so that the issue can be found more easily.\nClosing since the fix is available in insiders.\nVerified that cpu usage was reasonable when running the petclinic app", "positive_passages": [{"docid": "doc-en-vscode-c30d41773cae28470f328cfd31a3fe6650a4085fec29f7532d24fe9bcb9104eb", "text": "import { exec } from 'child_process'; import * as resources from 'vs/base/common/resources'; import * as fs from 'fs'; <ins> import * as pfs from 'vs/base/node/pfs'; </ins> import { isLinux } from 'vs/base/common/platform'; import { IExtHostTunnelService, TunnelDto } from 'vs/workbench/api/common/extHostTunnelService'; import { asPromise } from 'vs/base/common/async'; import { Event, Emitter } from 'vs/base/common/event'; import { TunnelOptions, TunnelCreationOptions } from 'vs/platform/remote/common/tunnel'; import { IExtensionDescription } from 'vs/platform/extensions/common/extensions'; <ins> import { promisify } from 'util'; import { MovingAverage } from 'vs/base/common/numbers'; </ins> class ExtensionTunnel implements vscode.Tunnel { private _onDispose: Emitter<void> = new Emitter();", "commid": "vscode_pr_113342"}], "negative_passages": []}
{"query_id": "q-en-vscode-47f30727aa358653f75b2494291faddb6ea3cdf0b740273c2ae6cbcc86bacffc", "query": "We have been seeing a bunch of remote issues where the remote extension host burns a lot of CPU. I think it is caused by our port scanning code, which executes even if the setting is false. See Possible issues: / Other: ? ? ? *\nLooks like we need to work on our indentation and ensuring that we break lines once they go past the edge of the screen for the sake of readability\nI could reproduce some increased CPU usage of the remote extension host using the project linked to i.e.\nIn insiders, you can now temporarily disable the port scanning code by adding this line to your .bashrc file, then restarting the VS Code server on your remote:\nOnce we have an insiders build I'll start commenting in each of the issues asking folks to try out the workaround in insiders.\nKeeping open for now so that the issue can be found more easily.\nClosing since the fix is available in insiders.\nVerified that cpu usage was reasonable when running the petclinic app", "positive_passages": [{"docid": "doc-en-vscode-384491a39eaed3522b0c7c0902f0aa4a75c637c693dd3a0b31435c19aeffe336", "text": ") { super(); this._proxy = extHostRpc.getProxy(MainContext.MainThreadTunnelService); <del> if (initData.remote.isRemote && initData.remote.authority && !process.env['VSCODE_DISABLE_PROC_READING']) { </del> <ins> if (initData.remote.isRemote && initData.remote.authority) { </ins> this.registerCandidateFinder(); } }", "commid": "vscode_pr_113342"}], "negative_passages": []}
{"query_id": "q-en-vscode-47f30727aa358653f75b2494291faddb6ea3cdf0b740273c2ae6cbcc86bacffc", "query": "We have been seeing a bunch of remote issues where the remote extension host burns a lot of CPU. I think it is caused by our port scanning code, which executes even if the setting is false. See Possible issues: / Other: ? ? ? *\nLooks like we need to work on our indentation and ensuring that we break lines once they go past the edge of the screen for the sake of readability\nI could reproduce some increased CPU usage of the remote extension host using the project linked to i.e.\nIn insiders, you can now temporarily disable the port scanning code by adding this line to your .bashrc file, then restarting the VS Code server on your remote:\nOnce we have an insiders build I'll start commenting in each of the issues asking folks to try out the workaround in insiders.\nKeeping open for now so that the issue can be found more easily.\nClosing since the fix is available in insiders.\nVerified that cpu usage was reasonable when running the petclinic app", "positive_passages": [{"docid": "doc-en-vscode-fc2e2cfa0f115d48d1c5c467ac95dd2dc479dddf50c9ad5f28c4b79c8ed5b0bd", "text": "return this._proxy.$getTunnels(); } <del> registerCandidateFinder(): void { // Every two seconds, scan to see if the candidate ports have changed; if (isLinux) { let oldPorts: { host: string, port: number, detail: string }[] | undefined = undefined; setInterval(async () => { const newPorts = await this.findCandidatePorts(); if (!oldPorts || (JSON.stringify(oldPorts) !== JSON.stringify(newPorts))) { oldPorts = newPorts; this._proxy.$onFoundNewCandidates(oldPorts.filter(async (candidate) => await this._showCandidatePort(candidate.host, candidate.port, candidate.detail))); return; } }, 2000); </del> <ins> private calculateDelay(movingAverage: number) { // Some local testing indicated that the moving average might be between 50-100 ms. return Math.max(movingAverage * 20, 2000); } async registerCandidateFinder(): Promise<void> { // Regularly scan to see if the candidate ports have changed. if (!isLinux) { return; } let movingAverage = new MovingAverage(); let oldPorts: { host: string, port: number, detail: string }[] | undefined = undefined; while (1) { const startTime = new Date().getTime(); const newPorts = await this.findCandidatePorts(); const timeTaken = new Date().getTime() - startTime; movingAverage.update(timeTaken); if (!oldPorts || (JSON.stringify(oldPorts) !== JSON.stringify(newPorts))) { oldPorts = newPorts; await this._proxy.$onFoundNewCandidates(oldPorts.filter(async (candidate) => await this._showCandidatePort(candidate.host, candidate.port, candidate.detail))); } await (new Promise<void>(resolve => setTimeout(() => resolve(), this.calculateDelay(movingAverage.value)))); </ins> } }", "commid": "vscode_pr_113342"}], "negative_passages": []}
{"query_id": "q-en-vscode-47f30727aa358653f75b2494291faddb6ea3cdf0b740273c2ae6cbcc86bacffc", "query": "We have been seeing a bunch of remote issues where the remote extension host burns a lot of CPU. I think it is caused by our port scanning code, which executes even if the setting is false. See Possible issues: / Other: ? ? ? *\nLooks like we need to work on our indentation and ensuring that we break lines once they go past the edge of the screen for the sake of readability\nI could reproduce some increased CPU usage of the remote extension host using the project linked to i.e.\nIn insiders, you can now temporarily disable the port scanning code by adding this line to your .bashrc file, then restarting the VS Code server on your remote:\nOnce we have an insiders build I'll start commenting in each of the issues asking folks to try out the workaround in insiders.\nKeeping open for now so that the issue can be found more easily.\nClosing since the fix is available in insiders.\nVerified that cpu usage was reasonable when running the petclinic app", "positive_passages": [{"docid": "doc-en-vscode-84c53c332d13a2f78e9ad3817641c94b621741d05d07be9c67b3e6e025db9e75", "text": "let tcp: string = ''; let tcp6: string = ''; try { <del> tcp = fs.readFileSync('/proc/net/tcp', 'utf8'); tcp6 = fs.readFileSync('/proc/net/tcp6', 'utf8'); </del> <ins> tcp = await pfs.readFile('/proc/net/tcp', 'utf8'); tcp6 = await pfs.readFile('/proc/net/tcp6', 'utf8'); </ins> } catch (e) { // File reading error. No additional handling needed. }", "commid": "vscode_pr_113342"}], "negative_passages": []}
{"query_id": "q-en-vscode-47f30727aa358653f75b2494291faddb6ea3cdf0b740273c2ae6cbcc86bacffc", "query": "We have been seeing a bunch of remote issues where the remote extension host burns a lot of CPU. I think it is caused by our port scanning code, which executes even if the setting is false. See Possible issues: / Other: ? ? ? *\nLooks like we need to work on our indentation and ensuring that we break lines once they go past the edge of the screen for the sake of readability\nI could reproduce some increased CPU usage of the remote extension host using the project linked to i.e.\nIn insiders, you can now temporarily disable the port scanning code by adding this line to your .bashrc file, then restarting the VS Code server on your remote:\nOnce we have an insiders build I'll start commenting in each of the issues asking folks to try out the workaround in insiders.\nKeeping open for now so that the issue can be found more easily.\nClosing since the fix is available in insiders.\nVerified that cpu usage was reasonable when running the petclinic app", "positive_passages": [{"docid": "doc-en-vscode-7a0178144f41e04ca2f8fa46ff309c61390e239a3304a12b9fa576ff905013c9", "text": "}); })); <del> const procChildren = fs.readdirSync('/proc'); const processes: { pid: number, cwd: string, cmd: string }[] = []; </del> <ins> const procChildren = await pfs.readdir('/proc'); const processes: { pid: number, cwd: string, cmd: string }[] = []; </ins> for (let childName of procChildren) { try { const pid: number = Number(childName); const childUri = resources.joinPath(URI.file('/proc'), childName); <del> const childStat = fs.statSync(childUri.fsPath); </del> <ins> const childStat = await pfs.stat(childUri.fsPath); </ins> if (childStat.isDirectory() && !isNaN(pid)) { <del> const cwd = fs.readlinkSync(resources.joinPath(childUri, 'cwd').fsPath); const cmd = fs.readFileSync(resources.joinPath(childUri, 'cmdline').fsPath, 'utf8'); </del> <ins> const cwd = await promisify(fs.readlink)(resources.joinPath(childUri, 'cwd').fsPath); const cmd = await pfs.readFile(resources.joinPath(childUri, 'cmdline').fsPath, 'utf8'); </ins> processes.push({ pid, cwd, cmd }); } } catch (e) {", "commid": "vscode_pr_113342"}], "negative_passages": []}
{"query_id": "q-en-vscode-689bc5587c18b2ff1a79e2c33e01854720caa3dbd52c94444ecc4bbc8680e727", "query": "VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select \"Select for Compare\". click on any other item and select \"Compare with Selected\". ! Does this issue occur when all extensions are disabled?: Yes\n//cc not sure we have a context key to use here already\nCode pointer We would need to use that context key for all the compare context menu actions in the Open Editors view\nisn't this just a matter of using for this command? We seem to be using this also to limit commands such as \"Copy\"?\nyou are correct, I checked and this is indeed the context key we needed here.\nWill have to revert this due to\nPR:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-54724007c67df27747ca1f50a9d1c699c1d2c6e868794b26f6cf34a3ff54bd17", "text": "// Menu registration - open editors <ins> const isFileOrUntitledResourceContextKey = ContextKeyExpr.or(ResourceContextKey.IsFileSystemResource, ResourceContextKey.Scheme.isEqualTo(Schemas.untitled)); </ins> const openToSideCommand = { id: OPEN_TO_SIDE_COMMAND_ID, title: nls.localize('openToSide', \"Open to the Side\")", "commid": "vscode_pr_115665"}], "negative_passages": []}
{"query_id": "q-en-vscode-689bc5587c18b2ff1a79e2c33e01854720caa3dbd52c94444ecc4bbc8680e727", "query": "VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select \"Select for Compare\". click on any other item and select \"Compare with Selected\". ! Does this issue occur when all extensions are disabled?: Yes\n//cc not sure we have a context key to use here already\nCode pointer We would need to use that context key for all the compare context menu actions in the Open Editors view\nisn't this just a matter of using for this command? We seem to be using this also to limit commands such as \"Copy\"?\nyou are correct, I checked and this is indeed the context key we needed here.\nWill have to revert this due to\nPR:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-7b339984e540e9a249729a4116cae898d5a01fccd5ff7e4a8f48b11bec8b5b4e", "text": "group: 'navigation', order: 10, command: openToSideCommand, <del> when: ContextKeyExpr.or(ResourceContextKey.IsFileSystemResource, ResourceContextKey.Scheme.isEqualTo(Schemas.untitled)) </del> <ins> when: isFileOrUntitledResourceContextKey </ins> }); MenuRegistry.appendMenuItem(MenuId.OpenEditorsContext, {", "commid": "vscode_pr_115665"}], "negative_passages": []}
{"query_id": "q-en-vscode-689bc5587c18b2ff1a79e2c33e01854720caa3dbd52c94444ecc4bbc8680e727", "query": "VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select \"Select for Compare\". click on any other item and select \"Compare with Selected\". ! Does this issue occur when all extensions are disabled?: Yes\n//cc not sure we have a context key to use here already\nCode pointer We would need to use that context key for all the compare context menu actions in the Open Editors view\nisn't this just a matter of using for this command? We seem to be using this also to limit commands such as \"Copy\"?\nyou are correct, I checked and this is indeed the context key we needed here.\nWill have to revert this due to\nPR:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-6f413ce7a4269a8dca1ba86497e236bf7010dc8040327b21ac33273ba4529cc1", "text": "group: '3_compare', order: 20, command: compareResourceCommand, <del> when: ContextKeyExpr.and(ResourceContextKey.HasResource, ResourceSelectedForCompareContext, WorkbenchListDoubleSelection.toNegated()) </del> <ins> when: ContextKeyExpr.and(ResourceContextKey.HasResource, ResourceSelectedForCompareContext, isFileOrUntitledResourceContextKey, WorkbenchListDoubleSelection.toNegated()) </ins> }); const selectForCompareCommand = {", "commid": "vscode_pr_115665"}], "negative_passages": []}
{"query_id": "q-en-vscode-689bc5587c18b2ff1a79e2c33e01854720caa3dbd52c94444ecc4bbc8680e727", "query": "VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select \"Select for Compare\". click on any other item and select \"Compare with Selected\". ! Does this issue occur when all extensions are disabled?: Yes\n//cc not sure we have a context key to use here already\nCode pointer We would need to use that context key for all the compare context menu actions in the Open Editors view\nisn't this just a matter of using for this command? We seem to be using this also to limit commands such as \"Copy\"?\nyou are correct, I checked and this is indeed the context key we needed here.\nWill have to revert this due to\nPR:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-96fcd71df3f2d77c0c3e147f9b8c405786d5658259fed6adccec1ea83f45a065", "text": "group: '3_compare', order: 30, command: selectForCompareCommand, <del> when: ContextKeyExpr.and(ResourceContextKey.HasResource, WorkbenchListDoubleSelection.toNegated()) </del> <ins> when: ContextKeyExpr.and(ResourceContextKey.HasResource, isFileOrUntitledResourceContextKey, WorkbenchListDoubleSelection.toNegated()) </ins> }); const compareSelectedCommand = {", "commid": "vscode_pr_115665"}], "negative_passages": []}
{"query_id": "q-en-vscode-689bc5587c18b2ff1a79e2c33e01854720caa3dbd52c94444ecc4bbc8680e727", "query": "VSCode Version: 1.52.1 OS Version: Windows 10 Steps to Reproduce: a WebView tab, such as the Markdown preview. click on it in the Open Editors Section, and select \"Select for Compare\". click on any other item and select \"Compare with Selected\". ! Does this issue occur when all extensions are disabled?: Yes\n//cc not sure we have a context key to use here already\nCode pointer We would need to use that context key for all the compare context menu actions in the Open Editors view\nisn't this just a matter of using for this command? We seem to be using this also to limit commands such as \"Copy\"?\nyou are correct, I checked and this is indeed the context key we needed here.\nWill have to revert this due to\nPR:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-be365c800b391f45b33f338f8c72aa7de3864f7982cba84f008cb2f7e228b7a7", "text": "group: '3_compare', order: 30, command: compareSelectedCommand, <del> when: ContextKeyExpr.and(ResourceContextKey.HasResource, WorkbenchListDoubleSelection) </del> <ins> when: ContextKeyExpr.and(ResourceContextKey.HasResource, WorkbenchListDoubleSelection, isFileOrUntitledResourceContextKey) </ins> }); MenuRegistry.appendMenuItem(MenuId.OpenEditorsContext, {", "commid": "vscode_pr_115665"}], "negative_passages": []}
{"query_id": "q-en-vscode-0575e6505ade5bfd84e4fd2fddad3a69259a1a17238ee2f864ffaa07a465970d", "query": "Testing Create multiple editor groups Ensure that the selected tab is not the first one in the editor group Start dragging the sash so that there is not enough room to wrap tabs Notice how the name of the tab that is visible jitters as it switches between the name of the first tab, and the name of the selected tab !\nYeah I was not able to figure out what triggers this and was even suspecting a browser bug (though didn't follow up). //cc\nI see this being related to: is called we enable wrapping we disable wrapping right after because we figure out the space is too limited somehow the scrollbar is now in a bad spot and needs a proper reset to avoid flicker\nI was able to find the origin of the bug in : wrapping is activated even when there is no space due to the actions right to the last tab. In the next call, it is disabled again, because the action's size is considered in that case. Constantly switching between wrapping and not wrapping makes it behave weird. I'll make a PR.", "positive_passages": [{"docid": "doc-en-vscode-aa9c285c81e979b58d7f5dabd68e86b38f5a990ea621cf73e97df3cb8fa57aff", "text": "if (this.accessor.partOptions.wrapTabs) { const visibleTabsWidth = tabsContainer.offsetWidth; const allTabsWidth = tabsContainer.scrollWidth; <ins> const lastTabFitsWrapped = () => { const lastTab = this.getLastTab(); if (!lastTab) { return true; // no tab always fits } return lastTab.offsetWidth <= (dimensions.available.width - editorToolbarContainer.offsetWidth); }; </ins> // If tabs wrap or should start to wrap (when width exceeds visible width) // we must trigger `updateWrapping` to set the `last-tab-margin-right` // accordingly based on the number of actions. The margin is important to // properly position the last tab apart from the actions <del> if (tabsWrapMultiLine || allTabsWidth > visibleTabsWidth) { </del> <ins> // // We already check here if the last tab would fit when wrapped given the // editor toolbar will also show right next to it. This ensures we are not // enabling wrapping only to disable it again in the code below (this fixes // flickering issue https://github.com/microsoft/vscode/issues/115050) if (tabsWrapMultiLine || (allTabsWidth > visibleTabsWidth && lastTabFitsWrapped())) { </ins> updateTabsWrapping(true); } // Tabs wrap multiline: remove wrapping under certain size constraint conditions if (tabsWrapMultiLine) { <del> const lastTab = this.getLastTab(); </del> if ( (tabsContainer.offsetHeight > dimensions.available.height) ||\t\t\t\t\t\t\t\t\t\t\t// if height exceeds available height (allTabsWidth === visibleTabsWidth && tabsContainer.offsetHeight === TabsTitleControl.TAB_HEIGHT) ||\t// if wrapping is not needed anymore <del> (lastTab && lastTab.offsetWidth > (dimensions.available.width - editorToolbarContainer.offsetWidth))\t// if editor actions occupy too much space </del> <ins> (!lastTabFitsWrapped())\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t// if last tab does not fit anymore </ins> ) { updateTabsWrapping(false); }", "commid": "vscode_pr_115273"}], "negative_passages": []}
{"query_id": "q-en-vscode-190a888961b615eef7b7c2a70383fbc8ff9aaedf1d1f374c08c8b1524225e770", "query": "Issue Type: <bBug</bRepro a terminal both terminals, run some kind of script that outputs text that horizontally fills the terminal resize the left terminal to make the right one smaller Bug For a half second during the resize, the content of two terminals end up overlapping https://user- VS Code version: Code - Insiders 1.53.0-insider (, 2021-01-26T05:12:23.287Z) OS version: Darwin x64 20.2.0 Remote OS version: Linux x64 5.4.0-1036-azure <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nI think this is just a problem with the dom renderer?\nOh yeah, I had set. There's a slight amount of overlap with canvas renderer (specifically the sash border seems to overlap with a few characters of the terminal for a few hundred ms at most), but it is much better\nShould probably use on each pane, that should fix.", "positive_passages": [{"docid": "doc-en-vscode-842746c68d6e53c57cc4a158861c74ee1a1c1d04a246667244f737ff2016895a", "text": ".monaco-workbench .pane-body.integrated-terminal .split-view-view { box-sizing: border-box; <ins> overflow: hidden; </ins> } /* border-color is set by theme key terminal.border */", "commid": "vscode_pr_115345"}], "negative_passages": []}
{"query_id": "q-en-vscode-11d52f54d243a5d9a68a23db0a2bc53f4c8b9280b1585c86dda390644c9633c7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.52.1 OS Version: Windows 10 1909 Steps to Reproduce: then press to run extension any folder with some code. code lens show, then hover one of codelens. Actual Result: ! Is this an expected behavior of vscode extension? Or is there any configation to show it?\nI believe this is expected behavior, however forwarding to so he can close\nYes. what tooltip to you expect when hovering over a code lens?\nAs , show maybe suitable I think.\nAh, I see. That actually makes sense and would be a simple change\nCan I take a look at this issue and try to work on this?\nThis is where the dom-nodes for codelens are created: Using the title attribute on them should do the job\nIs the native tooltip sufficient for the fix? Windows & MacOS :-------------------------: <img src=\"https://user-\" width=\"400\"Windows | MacOS :-------------------------:|:-------------------------: <img src=\"https://user-\" width=\"400\"| <img src=\"https://user-\" width=\"400\"", "positive_passages": [{"docid": "doc-en-vscode-e1bd37b58ae0c982fb863ff43ab08c33bbd8aa18f7c98a6ed6a7b7e0e482c079", "text": "if (lens.command) { const title = renderLabelWithIcons(lens.command.title.trim()); if (lens.command.id) { <del> children.push(dom.$('a', { id: String(i) }, ...title)); </del> <ins> children.push(dom.$('a', { id: String(i), title: lens.command.tooltip }, ...title)); </ins> this._commands.set(String(i), lens.command); } else { <del> children.push(dom.$('span', undefined, ...title)); </del> <ins> children.push(dom.$('span', { title: lens.command.tooltip }, ...title)); </ins> } if (i + 1 < lenses.length) { children.push(dom.$('span', undefined, 'u00a0|u00a0'));", "commid": "vscode_pr_118468"}], "negative_passages": []}
{"query_id": "q-en-vscode-32d048a044e14f0dff11cf04aedd5d5cefb178cfa35cac3431fa113c2a20da08", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: n/a OS Version: macOS 10.15.7, npm 7.5.0 Steps to Reproduce: to the and read the instructions in the \"Integrate\" section: a terminal and run the command as indicated: . Expected outcome: installs the freestanding JSON language server. Actual outcome: reports the following: I have attached the cited log file. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: n/a <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nSorry, that was a typo in the README. Please try\nSuccessfully installed using , thank you very much!", "positive_passages": [{"docid": "doc-en-vscode-c0ca269cd801fdb5b1c6664c1409b4c4adc9a90a2a92f73dad633d8d815bc39d", "text": "* Submitting pull requests ## Related Projects <del> Many of the core components and extensions to Code live in their own repositories on GitHub. For example, the [node debug adapter](https://github.com/microsoft/vscode-node-debug), the [mono debug adapter](https://github.com/microsoft/vscode-mono-debug). </del> <ins> Many of the core components and extensions to Code live in their own repositories on GitHub. For example, the [node debug adapter](https://github.com/microsoft/vscode-node-debug) and the [mono debug adapter](https://github.com/microsoft/vscode-mono-debug). </ins> For a complete list, please see the [Related Projects](https://github.com/Microsoft/vscode/wiki/Related-Projects) page on our wiki.", "commid": "vscode_pr_83"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-b4d7308bb391d8a8c7dfda0565b5a1e8e6a9b31b9b0793f2cc49722cfadc155a", "text": "unhideMarkdownPreview(cell: ICellViewModel): Promise<void>; hideMarkdownPreview(cell: ICellViewModel): Promise<void>; removeMarkdownPreview(cell: ICellViewModel): Promise<void>; <ins> updateMarkdownPreviewSelectionState(cell: ICellViewModel, isSelected: boolean): Promise<void>; </ins> /** * Render the output in webview layer", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-6e757ecd85718f0e40b6e6388e7193ba3d83dfa175adbe41e5009d52eec27f50", "text": "await this._webview?.removeMarkdownPreview(cell.id); } <ins> async updateMarkdownPreviewSelectionState(cell: ICellViewModel, isSelected: boolean): Promise<void> { if (!this._webview) { return; } await this._resolveWebview(); await this._webview?.updateMarkdownPreviewSelectionState(cell.id, isSelected); } </ins> async createInset(cell: CodeCellViewModel, output: IInsetRenderOutput, offset: number): Promise<void> { this._insetModifyQueueByOutputId.queue(output.source.model.outputId, async () => { if (!this._webview) {", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-7ad8d8b4e5de7d5dca4beb8bb258e0c42eaac1d85d464562212a9de532bcad81", "text": "top: number; } <ins> export interface IUpdateMarkdownPreviewSelectionState { readonly type: 'updateMarkdownPreviewSelectionState', readonly id: string; readonly isSelected: boolean; } </ins> export interface IInitializeMarkdownMessage { type: 'initializeMarkdownPreview'; cells: Array<{ cellId: string, content: string }>;", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-cd95a1f15b5b74e3df5a8de22d45472e3ce82f7964df1b8ebccb5ba44fe187a8", "text": "| IShowMarkdownMessage | IHideMarkdownMessage | IUnhideMarkdownMessage <ins> | IUpdateMarkdownPreviewSelectionState </ins> | IInitializeMarkdownMessage | IViewScrollMarkdownRequestMessage;", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-1cbe9697c9e24f7bdd29cd7cdcb1f1d46b22e0b581654e399b8f2f64c53aecb4", "text": "padding-left: ${this.options.leftMargin}px; } <ins> #container > div > div.preview.selected { background: var(--vscode-notebook-selectedCellBackground); } </ins> #container > div > div.preview img { max-width: 100%; max-height: 100%;", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-a50e9e8b685223f770affb5aeea5862d47db887155ab2eae5212d7e0828a8910", "text": "}); } <ins> async updateMarkdownPreviewSelectionState(cellId: any, isSelected: boolean) { if (this._disposed) { return; } this._sendMessageToWebview({ type: 'updateMarkdownPreviewSelectionState', id: cellId, isSelected }); } async updateMarkdownPreviewDecpratopms(cellId: any, isSelected: boolean) { if (this._disposed) { return; } this._sendMessageToWebview({ type: 'updateMarkdownPreviewSelectionState', id: cellId, isSelected }); } </ins> async initializeMarkdown(cells: Array<{ cellId: string, content: string }>) { await this._loaded;", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-1d587786efb38ccd666740f8953f9e8d23bd761fe8f3b3ab586dd204ca7cef4a", "text": "} private updateForLayout(element: MarkdownCellViewModel, templateData: MarkdownCellRenderTemplate): void { <del> // templateData.focusIndicatorLeft.style.height = `${element.layoutInfo.indicatorHeight}px`; </del> templateData.focusIndicatorBottom.style.top = `${element.layoutInfo.totalHeight - BOTTOM_CELL_TOOLBAR_GAP - CELL_BOTTOM_MARGIN}px`; const focusSideHeight = element.layoutInfo.totalHeight - BOTTOM_CELL_TOOLBAR_GAP;", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-1ca2f597ca6f966407342eb67be4b872015d87dc07b55115ff9a4d7af5427779", "text": "} })); <ins> // Update for selection if (this.useRenderer) { this._register(this.notebookEditor.onDidChangeSelection(() => { const selectedCells = this.notebookEditor.getSelectionViewModels(); const isSelected = selectedCells.length > 1 && selectedCells.some(selectedCell => selectedCell === viewCell); this.notebookEditor.updateMarkdownPreviewSelectionState(viewCell, isSelected); })); } // apply decorations </ins> this._register(viewCell.onCellDecorationsChanged((e) => { e.added.forEach(options => { if (options.className) { <del> templateData.rootContainer.classList.add(options.className); </del> <ins> if (this.useRenderer) { this.notebookEditor.deltaCellOutputContainerClassNames(this.viewCell.id, [options.className], []); } else { templateData.rootContainer.classList.add(options.className); } </ins> } }); e.removed.forEach(options => { if (options.className) { <del> templateData.rootContainer.classList.remove(options.className); </del> <ins> if (this.useRenderer) { this.notebookEditor.deltaCellOutputContainerClassNames(this.viewCell.id, [], [options.className]); } else { templateData.rootContainer.classList.remove(options.className); } </ins> } }); })); <del> // apply decorations </del> viewCell.getCellDecorations().forEach(options => { if (options.className) { <del> templateData.rootContainer.classList.add(options.className); </del> <ins> if (this.useRenderer) { this.notebookEditor.deltaCellOutputContainerClassNames(this.viewCell.id, [options.className], []); } else { templateData.rootContainer.classList.add(options.className); } </ins> } });", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-4d234368aa840a8bd5b40b1be39bf326a2a40ae1b6676d61cf9755061100f607", "text": "const data = event.data; let cellContainer = document.getElementById(data.id); if (cellContainer) { <del> cellContainer?.parentElement?.removeChild(cellContainer); </del> <ins> cellContainer.parentElement?.removeChild(cellContainer); } } break; case 'updateMarkdownPreviewSelectionState': { const data = event.data; const previewNode = document.getElementById(`${data.id}_preview`); if (previewNode) { previewNode.classList.toggle('selected', data.isSelected); </ins> } } break;", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-43ccf1ff568d3824b6d318a47879c0181ecdd22a7bae6fc98d1be589f30d2511", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54-Insiders OS Version: macOS open a GitHub issue notebook cmd+shift+o navigate down only code cells are highlighted https://user- <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-b15cbf86c764f8129e3ab67ac25686ceaf5c5a2c4c0a14ac133a45d3e1300e83", "text": "markdownCellDragEnd(cellId: string, position: { clientY: number }): void { throw new Error('Method not implemented.'); } <ins> updateMarkdownPreviewSelectionState(cell: ICellViewModel, isSelected: boolean): Promise<void> { throw new Error('Method not implemented.'); } </ins> async beginComputeContributedKernels(): Promise<INotebookKernel[]> { return []; }", "commid": "vscode_pr_117947"}], "negative_passages": []}
{"query_id": "q-en-vscode-23938cb97387e4fb862bcce07d8b46e9f1ae12cd7e5854b51900e16763411404", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --\nThis is about\nYeah see pull request sorry. I just lumped it into something else.", "positive_passages": [{"docid": "doc-en-vscode-6629b77221cfba12f2de90c60c4468354d3a159780e394868c7e48c92774eb85", "text": "protected _modifyText(text: string, wordSeparators: string): string { return (text .replace(/(p{Ll})(p{Lu})/gmu, '$1_$2') <del> .replace(/([^b_])(p{Lu})(p{Ll})/gmu, '$1_$2$3') </del> <ins> .replace(/(p{Lu}|p{N})(p{Lu})(p{Ll})/gmu, '$1_$2$3') </ins> .toLocaleLowerCase() ); }", "commid": "vscode_pr_118400"}], "negative_passages": []}
{"query_id": "q-en-vscode-23938cb97387e4fb862bcce07d8b46e9f1ae12cd7e5854b51900e16763411404", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --\nThis is about\nYeah see pull request sorry. I just lumped it into something else.", "positive_passages": [{"docid": "doc-en-vscode-16f625718485b954778d0ee96a14bf1d8c231becd69debfd209a6b17ff68d1a2", "text": "`function helloWorld() { return someGlobalObject.printHelloWorld(\"en\", \"utf-8\"); } <del> helloWorld();`.replace(/^s+/gm, '') </del> <ins> helloWorld();`.replace(/^s+/gm, ''), `'JavaScript'`, 'parseHTML4String', '_accessor: ServicesAccessor' </ins> ], {}, (editor) => { let model = editor.getModel()!; let uppercaseAction = new UpperCaseAction();", "commid": "vscode_pr_118400"}], "negative_passages": []}
{"query_id": "q-en-vscode-23938cb97387e4fb862bcce07d8b46e9f1ae12cd7e5854b51900e16763411404", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --\nThis is about\nYeah see pull request sorry. I just lumped it into something else.", "positive_passages": [{"docid": "doc-en-vscode-54f2032b9634400a8d047879b0cdd7cd46ef9e3dc785089a187d4aab6f1e425b", "text": "} hello_world();`.replace(/^s+/gm, '')); assertSelection(editor, new Selection(14, 1, 17, 15)); <ins> editor.setSelection(new Selection(18, 1, 18, 13)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(18), `'java_script'`); assertSelection(editor, new Selection(18, 1, 18, 14)); editor.setSelection(new Selection(19, 1, 19, 17)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(19), 'parse_html4_string'); assertSelection(editor, new Selection(19, 1, 19, 19)); editor.setSelection(new Selection(20, 1, 20, 28)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(20), '_accessor: services_accessor'); assertSelection(editor, new Selection(20, 1, 20, 29)); </ins> } );", "commid": "vscode_pr_118400"}], "negative_passages": []}
{"query_id": "q-en-vscode-23938cb97387e4fb862bcce07d8b46e9f1ae12cd7e5854b51900e16763411404", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --\nThis is about\nYeah see pull request sorry. I just lumped it into something else.", "positive_passages": [{"docid": "doc-en-vscode-11af3fb3f2af3be3946c915b0ed43e7fba7e9bf1b64f564dcd20d47c5e281d8c", "text": "- use the `--debug` to see an electron window with dev tools which allows for debugging - to run only a subset of tests use the `--run` or `--glob` options <ins> - use `yarn watch` to automatically compile changes </ins> For instance, `./scripts/test.sh --debug --glob **/extHost*.test.js` runs all tests from `extHost`-files and enables you to debug them.", "commid": "vscode_pr_118400"}], "negative_passages": []}
{"query_id": "q-en-vscode-23938cb97387e4fb862bcce07d8b46e9f1ae12cd7e5854b51900e16763411404", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --\nThis is about\nYeah see pull request sorry. I just lumped it into something else.", "positive_passages": [{"docid": "doc-en-vscode-a95973c12aa3fb04681971e972708c104aa65c87063de2c6835616df312f5253", "text": "## Run (with node) <del> yarn run mocha --run src/vs/editor/test/browser/controller/cursor.test.ts </del> <ins> yarn run mocha --ui tdd --run src/vs/editor/test/browser/controller/cursor.test.ts </ins> ## Coverage", "commid": "vscode_pr_118400"}], "negative_passages": []}
{"query_id": "q-en-vscode-88350a42f9f541f0cf2750e47dc3294e1fa74ecb2ea736f26f6876886e44e4fd", "query": "The call was removed in\nIt's weird, seems like in stable we should be leaking terminal processes then but I see them shut down immediately after closing the window in stable...", "positive_passages": [{"docid": "doc-en-vscode-2d61704c5951ff86fc7a1606cc2582a6133b22e767898e8d8276a53bc3c7c214", "text": "return this._remoteTerminalChannel.setTerminalLayoutInfo(layout); } <del> public getTerminalLayoutInfo(): Promise<ITerminalsLayoutInfo | undefined> { </del> <ins> public async getTerminalLayoutInfo(): Promise<ITerminalsLayoutInfo | undefined> { await this._remoteTerminalChannel?.listProcesses(true); </ins> if (!this._remoteTerminalChannel) { throw new Error(`Cannot call getActiveInstanceId when there is no remote`); }", "commid": "vscode_pr_118571"}], "negative_passages": []}
{"query_id": "q-en-vscode-469729638394f349dcc49a42438b90e527e8c963a26301debedcbcbd4521c4d2", "query": "On Windows: a local empty folder an empty a with the following contents: the Markdown preview the link File opens with a strange input, as if its entire path is the file name. Also, if you open from the Explorer, it now appears twice in Quick Open: once normally and another in the weird long format. !\nwindows? local/wsl? Doesn't repro on macOS so I suspect an issue with how URIs are being created from the markdown.\nThis is local Windows, updated the steps.\nThere is some weird encoding going on with that URL, here is what it should look like: And here is what I get:\nI'm working on this issue. I've logged out how the Markdown Preview renders the paths to HTML with \"Click Here Absolute Path\" containing the same link as in the issue: Markdown: HTML Output: The paths are correct though. Plus I think the link should be given as a relative path (ie. ) instead of an absolute path. Giving the absolute path here () is not correct. Btw, I've tried on other IDEs for comparison, they all don't open the absolute path link properly (or open nothing at all). The relative path link always works. Not sure how would you want to tackle this now?\nI have a hunch that maybe the issue is somewhat related to\nThanks, for the pointer. I misunderstood the issue at first...", "positive_passages": [{"docid": "doc-en-vscode-2034ee5b1abd59a1da629fd21d2e84772a127ec7e36233ff48343b69e08c47af", "text": "private async onDidClickPreviewLink(href: string) { let [hrefPath, fragment] = decodeURIComponent(href).split('#'); <del> // We perviously already resolve absolute paths. // Now make sure we handle relative file paths </del> if (hrefPath[0] !== '/') { <del> // Fix #93691, use this.resource.fsPath instead of this.resource.path hrefPath = path.join(path.dirname(this.resource.fsPath), hrefPath); </del> <ins> // We perviously already resolve absolute paths. // Now make sure we handle relative file paths const dirnameUri = vscode.Uri.parse(path.dirname(this.resource.path)); hrefPath = vscode.Uri.joinPath(dirnameUri, hrefPath).path; </ins> } else { // Handle any normalized file paths <del> hrefPath = vscode.Uri.parse(hrefPath.replace('/file', '')).fsPath; </del> <ins> hrefPath = vscode.Uri.parse(hrefPath.replace('/file', '')).path; </ins> } const config = vscode.workspace.getConfiguration('markdown', this.resource);", "commid": "vscode_pr_120090"}], "negative_passages": []}
{"query_id": "q-en-vscode-259030ef976ff6eaa275d8109d488f1a36d9993f2127759c8edfd102556029f7", "query": "skipped in\nSeems to only flake on Windows\nCouldn't reproduce locally\nLet's try re-enable in debt week", "positive_passages": [{"docid": "doc-en-vscode-e0c3d25ad661d58e1e69e7c7417ad5cefa421f52273b37cf5f4a97c2395da1ef", "text": "}); }); <del> // https://github.com/microsoft/vscode/issues/119826 suite.skip('environmentVariableCollection', () => { </del> <ins> suite('environmentVariableCollection', () => { </ins> test('should have collection variables apply to terminals immediately after setting', (done) => { // Text to match on before passing the test const expectedText = [", "commid": "vscode_pr_125743"}], "negative_passages": []}
{"query_id": "q-en-vscode-d77133b6169516e818508357d37a777ee15ec18977ee9a706ad14b11eb4c4be2", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nI created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell\nany chance you can do a screen recording of the reproduce?\nCan't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.", "positive_passages": [{"docid": "doc-en-vscode-5e590cd3f2c660bdd5e9dc208bd6f175b89fbc0f8af12204b8d66a881e914def", "text": "assert.strictEqual(count, 0); }); <ins> test('correct cell selection on undo/redo of cell creation', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest'); await vscode.commands.executeCommand('notebook.cell.insertCodeCellBelow'); await vscode.commands.executeCommand('undo'); const selectionUndo = [...vscode.window.activeNotebookEditor!.selections]; await vscode.commands.executeCommand('redo'); const selectionRedo = vscode.window.activeNotebookEditor!.selections; // On undo, the selected cell must be the upper cell, ie the first one assert.strictEqual(selectionUndo.length, 1); assert.strictEqual(selectionUndo[0].start, 0); assert.strictEqual(selectionUndo[0].end, 1); // On redo, the selected cell must be the new cell, ie the second one assert.strictEqual(selectionRedo.length, 1); assert.strictEqual(selectionRedo[0].start, 1); assert.strictEqual(selectionRedo[0].end, 2); }); </ins> test('editor editing event 2', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');", "commid": "vscode_pr_120086"}], "negative_passages": []}
{"query_id": "q-en-vscode-d77133b6169516e818508357d37a777ee15ec18977ee9a706ad14b11eb4c4be2", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nI created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell\nany chance you can do a screen recording of the reproduce?\nCan't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.", "positive_passages": [{"docid": "doc-en-vscode-3d1b3bd9e63066976f7066e17cf1ee4738ea9718cd3ee3de50b5f792cc8eb53f", "text": "} async runWithContext(accessor: ServicesAccessor, context: INotebookActionContext): Promise<void> { <del> const newCell = context.notebookEditor.insertNotebookCell(context.cell, this.kind, this.direction, undefined, true); if (newCell) { context.notebookEditor.focusNotebookCell(newCell, 'editor'); } </del> <ins> context.notebookEditor.insertNotebookCell(context.cell, this.kind, this.direction, undefined, true); </ins> } }", "commid": "vscode_pr_120086"}], "negative_passages": []}
{"query_id": "q-en-vscode-d77133b6169516e818508357d37a777ee15ec18977ee9a706ad14b11eb4c4be2", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nI created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell\nany chance you can do a screen recording of the reproduce?\nCan't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.", "positive_passages": [{"docid": "doc-en-vscode-d739f9a6ea6c0d7a0fb63610e46ad5ffac3064a7d189499c65d940851c0ac331", "text": "createCell(index: number, source: string, language: string, type: CellKind, metadata: NotebookCellMetadata | undefined, outputs: IOutputDto[], synchronous: boolean, pushUndoStop: boolean = true, previouslyPrimary: number | null = null, previouslyFocused: ICellViewModel[] = []): CellViewModel { const beforeSelections = previouslyFocused.map(e => e.handle); <ins> const endSelections: ISelectionState = { kind: SelectionStateType.Index, focus: { start: index, end: index + 1 }, selections: [{ start: index, end: index + 1 }] }; </ins> this._notebook.applyEdits([ { editType: CellEditType.Replace,", "commid": "vscode_pr_120086"}], "negative_passages": []}
{"query_id": "q-en-vscode-d77133b6169516e818508357d37a777ee15ec18977ee9a706ad14b11eb4c4be2", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nI created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell\nany chance you can do a screen recording of the reproduce?\nCan't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.", "positive_passages": [{"docid": "doc-en-vscode-2bbe207d22639ae5468204c63e3d824146ba92d941d05b139e1fd9322f8176a1", "text": "} ] } <del> ], synchronous, { kind: SelectionStateType.Handle, primary: previouslyPrimary, selections: beforeSelections }, () => undefined, undefined); </del> <ins> ], synchronous, { kind: SelectionStateType.Handle, primary: previouslyPrimary, selections: beforeSelections }, () => endSelections, undefined); </ins> return this._viewCells[index]; }", "commid": "vscode_pr_120086"}], "negative_passages": []}
{"query_id": "q-en-vscode-541725f4084fa3aebff54fe47b6456fcb61a9e2a363c955e49bf6712c81f9383", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.0 OS Version: Windows 10 Home 20H2 .867 Steps to Reproduce: run latest version of VS Code, 1.55.0 the list of default WSL profiles and you will find something like \"Ubuntu (predet.)\" instead of just \"Ubuntu\". profile is impossible to launch, because there is NO distro named \"Ubuntu (predet.)\". This happens because , at line 178 of latest snapshot I'm checking, does this: . It should remove other locales, too. I know this is difficult to do because... well, there's plenty of locales. So, in order to get the distribution name, another way should be used. I think it's safe to remove any last element within parentheses from the distro name as returned by , but really another method is available which I think it's safer, but I'm not sure how to write it in TypeScript. I have the following code already written in Python, for a system maintenance script I use in my own system, where I retrieve the installed distribution names from the registry: It's a partial code but well, I think it's self explanatory, and I can provide further information if needed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nSame happens to me with the new version 1.55.0 One temporal solution that I found is to disable the autodetection of the distros and include each one with the profile setting:\nhi, at first glance it looks that adding a -q argument to the 'wsl -l' command would be safe... regards\nThanks for the suggestion and the fix. Still, I'll keep an eye on this, just in case Microsoft decides to change command line interface. But so far, so good, and it's simpler than having to read the registry\nJust encountered this issue today (after updating Docker for Desktop, but not sure if this has something to do with the issue).\nVerified in", "positive_passages": [{"docid": "doc-en-vscode-d1f671d8828be154f2e45791ac5f521771519770110200231d3cf6eb8bb3785a", "text": "if (useWslProfiles) { const distroOutput = await new Promise<string>((resolve, reject) => { // wsl.exe output is encoded in utf16le (ie. A -> 0x4100) <del> cp.exec('wsl.exe -l', { encoding: 'utf16le' }, (err, stdout) => { </del> <ins> cp.exec('wsl.exe -l -q', { encoding: 'utf16le' }, (err, stdout) => { </ins> if (err) { return reject('Problem occurred when getting wsl distros'); }", "commid": "vscode_pr_120382"}], "negative_passages": []}
{"query_id": "q-en-vscode-541725f4084fa3aebff54fe47b6456fcb61a9e2a363c955e49bf6712c81f9383", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.0 OS Version: Windows 10 Home 20H2 .867 Steps to Reproduce: run latest version of VS Code, 1.55.0 the list of default WSL profiles and you will find something like \"Ubuntu (predet.)\" instead of just \"Ubuntu\". profile is impossible to launch, because there is NO distro named \"Ubuntu (predet.)\". This happens because , at line 178 of latest snapshot I'm checking, does this: . It should remove other locales, too. I know this is difficult to do because... well, there's plenty of locales. So, in order to get the distribution name, another way should be used. I think it's safe to remove any last element within parentheses from the distro name as returned by , but really another method is available which I think it's safer, but I'm not sure how to write it in TypeScript. I have the following code already written in Python, for a system maintenance script I use in my own system, where I retrieve the installed distribution names from the registry: It's a partial code but well, I think it's self explanatory, and I can provide further information if needed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --\nSame happens to me with the new version 1.55.0 One temporal solution that I found is to disable the autodetection of the distros and include each one with the profile setting:\nhi, at first glance it looks that adding a -q argument to the 'wsl -l' command would be safe... regards\nThanks for the suggestion and the fix. Still, I'll keep an eye on this, just in case Microsoft decides to change command line interface. But so far, so good, and it's simpler than having to read the registry\nJust encountered this issue today (after updating Docker for Desktop, but not sure if this has something to do with the issue).\nVerified in", "positive_passages": [{"docid": "doc-en-vscode-873ff6631fff4e0713ff24601a000c58c9712cc74d3b19e4b0b2a9d8ad676052", "text": "if (distroOutput) { const regex = new RegExp(/[r?n]/); const distroNames = distroOutput.split(regex).filter(t => t.trim().length > 0 && t !== ''); <del> // don't need the Windows Subsystem for Linux Distributions header distroNames.shift(); </del> for (let distroName of distroNames) { <del> // Remove default from distro name distroName = distroName.replace(/ (Default)$/, ''); </del> // Skip empty lines if (distroName === '') { continue;", "commid": "vscode_pr_120382"}], "negative_passages": []}
{"query_id": "q-en-vscode-2cc856f740782963019fedcda4ea658c2e9868c575554b8454755b828d96ec0c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.56.0-insider OS Version: MacOS Big Sur 11.2.3 Steps to Reproduce: Settings and and editor it manually. a rule: editors can't be edited anymore. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-599f5c0cf7f5e4ed5d49b183dffff5a5d8b2422e59dbf2fc2d8f8bfc5a42a090", "text": "this.textArea.setAttribute('aria-haspopup', 'false'); this.textArea.setAttribute('aria-autocomplete', 'both'); <del> if (options.get(EditorOption.domReadOnly)) { </del> <ins> if (options.get(EditorOption.domReadOnly) && options.get(EditorOption.readOnly)) { </ins> this.textArea.setAttribute('readonly', 'true'); }", "commid": "vscode_pr_120503"}], "negative_passages": []}
{"query_id": "q-en-vscode-2cc856f740782963019fedcda4ea658c2e9868c575554b8454755b828d96ec0c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.56.0-insider OS Version: MacOS Big Sur 11.2.3 Steps to Reproduce: Settings and and editor it manually. a rule: editors can't be edited anymore. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-998a703fdfabdaca4c864726efa0db1a5368e04fcb2bca8ca8b3783a0edc15a5", "text": "this.textArea.setAttribute('aria-label', this._getAriaLabel(options)); this.textArea.setAttribute('tabindex', String(options.get(EditorOption.tabIndex))); <del> if (e.hasChanged(EditorOption.domReadOnly)) { if (options.get(EditorOption.domReadOnly)) { </del> <ins> if (e.hasChanged(EditorOption.domReadOnly) || e.hasChanged(EditorOption.readOnly)) { if (options.get(EditorOption.domReadOnly) && options.get(EditorOption.readOnly)) { </ins> this.textArea.setAttribute('readonly', 'true'); } else { this.textArea.removeAttribute('readonly');", "commid": "vscode_pr_120503"}], "negative_passages": []}
{"query_id": "q-en-vscode-0d29eb0029a7c980c02d3e8be2d990cf255e12dd35a62b67ef1bdd21e2d96ce4", "query": "editor hover over any link correctly uses and ignores ! VS Code version: Code - Insiders 1.56.0-insider (, 2021-04-16T11:25:09.662Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.57 --<!-- potentialduplicatescomment --\ncan you explain the issue/feature to me a bit more? The way I am understanding it right now, is the behavior I am seeing, so I think I am misunderstanding something. I have this in my settings. This is what I see. Where/when am I expected to see the blue text? <img width=\"939\" alt=\"Screen Shot 2021-05-07 at 6 43 02 PM\" src=\"https://user-\"\nwhen you mouseover the link, like here: !\nthanks for clarifying, submitted a PR for this.", "positive_passages": [{"docid": "doc-en-vscode-3e5a10e650bc6ea6e5a6fa2d8e81ceab809184fe0d0abe4023d994b0ef134fcc", "text": "import { ModesGlyphHoverWidget } from 'vs/editor/contrib/hover/modesGlyphHover'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { IOpenerService } from 'vs/platform/opener/common/opener'; <del> import { editorHoverBackground, editorHoverBorder, editorHoverHighlight, textCodeBlockBackground, textLinkForeground, editorHoverStatusBarBackground, editorHoverForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { editorHoverBackground, editorHoverBorder, editorHoverHighlight, textCodeBlockBackground, textLinkForeground, editorHoverStatusBarBackground, editorHoverForeground, textLinkActiveForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { AccessibilitySupport } from 'vs/platform/accessibility/common/accessibility'; import { GotoDefinitionAtPositionEditorContribution } from 'vs/editor/contrib/gotoSymbol/link/goToDefinitionAtPosition';", "commid": "vscode_pr_123384"}], "negative_passages": []}
{"query_id": "q-en-vscode-0d29eb0029a7c980c02d3e8be2d990cf255e12dd35a62b67ef1bdd21e2d96ce4", "query": "editor hover over any link correctly uses and ignores ! VS Code version: Code - Insiders 1.56.0-insider (, 2021-04-16T11:25:09.662Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --\n(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.57 --<!-- potentialduplicatescomment --\ncan you explain the issue/feature to me a bit more? The way I am understanding it right now, is the behavior I am seeing, so I think I am misunderstanding something. I have this in my settings. This is what I see. Where/when am I expected to see the blue text? <img width=\"939\" alt=\"Screen Shot 2021-05-07 at 6 43 02 PM\" src=\"https://user-\"\nwhen you mouseover the link, like here: !\nthanks for clarifying, submitted a PR for this.", "positive_passages": [{"docid": "doc-en-vscode-7ef011d771a313f8ce704a0b13709e165201bb182bba6a1e4b2cda4baf49aecb", "text": "if (link) { collector.addRule(`.monaco-editor .monaco-hover a { color: ${link}; }`); } <ins> const linkHover = theme.getColor(textLinkActiveForeground); if (linkHover) { collector.addRule(`.monaco-editor .monaco-hover a:hover { color: ${linkHover}; }`); } </ins> const hoverForeground = theme.getColor(editorHoverForeground); if (hoverForeground) { collector.addRule(`.monaco-editor .monaco-hover { color: ${hoverForeground}; }`);", "commid": "vscode_pr_123384"}], "negative_passages": []}
{"query_id": "q-en-vscode-c6c1790dd1e77f83faf11aaf68f2008df2f34693617bf842295ae43a40155726", "query": "If you \"refresh\" an item (with children) by calling and the item is not expanded, the method still gets called. should not be called until the item is expanded, otherwise potentially expensive operations can be run for no visible reason (since the children are hidden).\nThis could result in unexpected behavior. If an extension currently relies on to always update the children then there would be out-of-date tree items.\nHow would this result in unexpected behavior? If the tree item has not loaded its children, why should calling refresh on it force its children to load?\nI'm concerned that some extension authors have come to depend on the current behavior to keep their internal tree structure updated. I suppose we can try it and see if there are any complaints.\nI think a change like this would need to happen in the , as at the custom tree view level we have no knowledge of whether a node is currently expanded or not. Is this something you'd be interested in doing?\nNot sure I follow. What describes is exactly how the AsyncDataTree works: children aren't resolved until the user expands the parent the first time.\nI am looking for a way to call on the AsyncDataTree such that if the tree item passed in to is collapsed, it will: \"invalidate\" the children or the tree item and not actually call on that tree item rerender the tree item instead of: calling for the tree item rerendering the tree item\nOh I guess I was wrong, what I said only applies to the next level. But the first node is called with will always have its be called. We can maybe add an option here, or even change the default behavior as I see no reason for collapsed tree nodes to need a call.\nany update here? This issue causes GitLens to request way more data than desired in multiple cases (before the user expands them that is).\nThank you!\nThanks for the nudge!\nMaybe it's easier if you verify this one.\nwill verify.\nFYI, I tested GitLens with this change (in today's insiders) and it looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-fd9b5bff73325f0240fb50b55eb7b9128b76cfd544f22c57355576911c2b3175", "text": "return result; } <ins> if (node !== this.root) { const treeNode = this.tree.getNode(node); if (treeNode.collapsed) { node.hasChildren = !!this.dataSource.hasChildren(node.element!); node.stale = true; return; } } </ins> return this.doRefreshSubTree(node, recursive, viewStateContext); }", "commid": "vscode_pr_155729"}], "negative_passages": []}
{"query_id": "q-en-vscode-c6c1790dd1e77f83faf11aaf68f2008df2f34693617bf842295ae43a40155726", "query": "If you \"refresh\" an item (with children) by calling and the item is not expanded, the method still gets called. should not be called until the item is expanded, otherwise potentially expensive operations can be run for no visible reason (since the children are hidden).\nThis could result in unexpected behavior. If an extension currently relies on to always update the children then there would be out-of-date tree items.\nHow would this result in unexpected behavior? If the tree item has not loaded its children, why should calling refresh on it force its children to load?\nI'm concerned that some extension authors have come to depend on the current behavior to keep their internal tree structure updated. I suppose we can try it and see if there are any complaints.\nI think a change like this would need to happen in the , as at the custom tree view level we have no knowledge of whether a node is currently expanded or not. Is this something you'd be interested in doing?\nNot sure I follow. What describes is exactly how the AsyncDataTree works: children aren't resolved until the user expands the parent the first time.\nI am looking for a way to call on the AsyncDataTree such that if the tree item passed in to is collapsed, it will: \"invalidate\" the children or the tree item and not actually call on that tree item rerender the tree item instead of: calling for the tree item rerendering the tree item\nOh I guess I was wrong, what I said only applies to the next level. But the first node is called with will always have its be called. We can maybe add an option here, or even change the default behavior as I see no reason for collapsed tree nodes to need a call.\nany update here? This issue causes GitLens to request way more data than desired in multiple cases (before the user expands them that is).\nThank you!\nThanks for the nudge!\nMaybe it's easier if you verify this one.\nwill verify.\nFYI, I tested GitLens with this change (in today's insiders) and it looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-6288dad3e390a925585529818b5b2148b242756feb862ec79772de1e5dd5c0c6", "text": "import { AsyncDataTree } from 'vs/base/browser/ui/tree/asyncDataTree'; import { IAsyncDataSource, ITreeNode, ITreeRenderer } from 'vs/base/browser/ui/tree/tree'; import { timeout } from 'vs/base/common/async'; <ins> import { Iterable } from 'vs/base/common/iterator'; </ins> interface Element { id: string;", "commid": "vscode_pr_155729"}], "negative_passages": []}
{"query_id": "q-en-vscode-c6c1790dd1e77f83faf11aaf68f2008df2f34693617bf842295ae43a40155726", "query": "If you \"refresh\" an item (with children) by calling and the item is not expanded, the method still gets called. should not be called until the item is expanded, otherwise potentially expensive operations can be run for no visible reason (since the children are hidden).\nThis could result in unexpected behavior. If an extension currently relies on to always update the children then there would be out-of-date tree items.\nHow would this result in unexpected behavior? If the tree item has not loaded its children, why should calling refresh on it force its children to load?\nI'm concerned that some extension authors have come to depend on the current behavior to keep their internal tree structure updated. I suppose we can try it and see if there are any complaints.\nI think a change like this would need to happen in the , as at the custom tree view level we have no knowledge of whether a node is currently expanded or not. Is this something you'd be interested in doing?\nNot sure I follow. What describes is exactly how the AsyncDataTree works: children aren't resolved until the user expands the parent the first time.\nI am looking for a way to call on the AsyncDataTree such that if the tree item passed in to is collapsed, it will: \"invalidate\" the children or the tree item and not actually call on that tree item rerender the tree item instead of: calling for the tree item rerendering the tree item\nOh I guess I was wrong, what I said only applies to the next level. But the first node is called with will always have its be called. We can maybe add an option here, or even change the default behavior as I see no reason for collapsed tree nodes to need a call.\nany update here? This issue causes GitLens to request way more data than desired in multiple cases (before the user expands them that is).\nThank you!\nThanks for the nudge!\nMaybe it's easier if you verify this one.\nwill verify.\nFYI, I tested GitLens with this change (in today's insiders) and it looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-a04a6d5cbfea88112c5b977372eb8d30d996ab4efe42564589ef402b08d432b6", "text": "assert.deepStrictEqual(Array.from(container.querySelectorAll('.monaco-list-row')).map(e => e.textContent), ['a', 'b2']); }); <ins> test('issue #121567', async () => { const container = document.createElement('div'); const calls: Element[] = []; const dataSource = new class implements IAsyncDataSource<Element, Element> { hasChildren(element: Element): boolean { return !!element.children && element.children.length > 0; } async getChildren(element: Element) { calls.push(element); return element.children ?? Iterable.empty(); } }; const model = new Model({ id: 'root', children: [{ id: 'a', children: [{ id: 'aa' }] }] }); const a = model.get('a'); const tree = new AsyncDataTree<Element, Element>('test', container, new VirtualDelegate(), [new Renderer()], dataSource, { identityProvider: new IdentityProvider() }); tree.layout(200); await tree.setInput(model.root); assert.strictEqual(calls.length, 1, 'There should be a single getChildren call for the root'); assert(tree.isCollapsible(a), 'a is collapsible'); assert(tree.isCollapsed(a), 'a is collapsed'); await tree.updateChildren(a, false); assert.strictEqual(calls.length, 1, 'There should be no changes to the calls list, since a was collapsed'); assert(tree.isCollapsible(a), 'a is collapsible'); assert(tree.isCollapsed(a), 'a is collapsed'); const children = a.children; a.children = []; await tree.updateChildren(a, false); assert.strictEqual(calls.length, 1, 'There should still be no changes to the calls list, since a was collapsed'); assert(!tree.isCollapsible(a), 'a is no longer collapsible'); assert(tree.isCollapsed(a), 'a is collapsed'); a.children = children; await tree.updateChildren(a, false); assert.strictEqual(calls.length, 1, 'There should still be no changes to the calls list, since a was collapsed'); assert(tree.isCollapsible(a), 'a is collapsible again'); assert(tree.isCollapsed(a), 'a is collapsed'); await tree.expand(a); assert.strictEqual(calls.length, 2, 'Finally, there should be a getChildren call for a'); assert(tree.isCollapsible(a), 'a is still collapsible'); assert(!tree.isCollapsed(a), 'a is expanded'); }); </ins> });", "commid": "vscode_pr_155729"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b8c42d4394fd18a3090754bf9b1f1b0a218c467cc1642e61519fcec78528f8c", "query": "If the knows which languages a user tried in their first day, it could unlock more specific questions to further improve the language onboarding experience. How though. tracks the edited count for languages that run surveys; which are the languages we care most about right now. Only issue is that the storage key isn't exported, so the doesn't know about it. any general thoughts on the idea, and best practices on how to make the storage keys known to the ces survey code; so they can be read and attached as params to the survey URL?\nThe CES code already has access to the same . Can't you copy the maps the surveys to storage service keys over to CES and read them from there?\nSure, was mainly worried that this creates some copy/pasta. Will take that approach for an initial pull request draft and gather feedback.\nNo worries. We can also extract the common code to a new file, sibling to those two.\nare there verification steps for this?\nSorry that they are so complex and time-intensive. I can also verify that I see survey responses from insiders that include the language data. a fresh VS Code Insiders instance , ensure that you are in the treatment group a Java file and save it. VS Code open for 1 hour to trigger the new-user survey popup and click to open the survey that the URL it opened contains\nOk, see you in an hour!\nThe treatment service does not seem to like me, for some reason. Unmarking as verified for someone else to give it a shot. Note that you need to repeatedly open VS Code windows with new user-data-dir's until you get into the treatment.\nAlso attempted this but no survey after an hour. Confirmed I did get an initial\nwhen the experiment enables the survey you should also get a event? Did that work?\nTesting again\nWorked! [redacted]&javaLang=1", "positive_passages": [{"docid": "doc-en-vscode-675b16496bc7bbbe694f716ca18c80f3eacb4263e380a2379cf52ed449caa381", "text": "import { Event } from 'vs/base/common/event'; const WAIT_TIME_TO_SHOW_SURVEY = 1000 * 60 * 60; // 1 hour <del> const MIN_WAIT_TIME_TO_SHOW_SURVEY = 1000 * 60 * 5; // 5 minutes </del> <ins> const MIN_WAIT_TIME_TO_SHOW_SURVEY = 1000 * 60 * 2; // 2 minutes </ins> const MAX_INSTALL_AGE = 1000 * 60 * 60 * 24; // 24 hours const REMIND_LATER_DELAY = 1000 * 60 * 60 * 4; // 4 hours const SKIP_SURVEY_KEY = 'ces/skipSurvey';", "commid": "vscode_pr_124006"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b8c42d4394fd18a3090754bf9b1f1b0a218c467cc1642e61519fcec78528f8c", "query": "If the knows which languages a user tried in their first day, it could unlock more specific questions to further improve the language onboarding experience. How though. tracks the edited count for languages that run surveys; which are the languages we care most about right now. Only issue is that the storage key isn't exported, so the doesn't know about it. any general thoughts on the idea, and best practices on how to make the storage keys known to the ces survey code; so they can be read and attached as params to the survey URL?\nThe CES code already has access to the same . Can't you copy the maps the surveys to storage service keys over to CES and read them from there?\nSure, was mainly worried that this creates some copy/pasta. Will take that approach for an initial pull request draft and gather feedback.\nNo worries. We can also extract the common code to a new file, sibling to those two.\nare there verification steps for this?\nSorry that they are so complex and time-intensive. I can also verify that I see survey responses from insiders that include the language data. a fresh VS Code Insiders instance , ensure that you are in the treatment group a Java file and save it. VS Code open for 1 hour to trigger the new-user survey popup and click to open the survey that the URL it opened contains\nOk, see you in an hour!\nThe treatment service does not seem to like me, for some reason. Unmarking as verified for someone else to give it a shot. Note that you need to repeatedly open VS Code windows with new user-data-dir's until you get into the treatment.\nAlso attempted this but no survey after an hour. Confirmed I did get an initial\nwhen the experiment enables the survey you should also get a event? Did that work?\nTesting again\nWorked! [redacted]&javaLang=1", "positive_passages": [{"docid": "doc-en-vscode-4d4239e220b48891959f317ee536440344eb16ad0f2502cc57d5402a0795e75a", "text": "run: () => { sendTelemetry('accept'); this.telemetryService.getTelemetryInfo().then(info => { <del> this.openerService.open(URI.parse(`${this.productService.cesSurveyUrl}?o=${encodeURIComponent(platform)}&v=${encodeURIComponent(this.productService.version)}&m=${encodeURIComponent(info.machineId)}`)); </del> <ins> let surveyUrl = `${this.productService.cesSurveyUrl}?o=${encodeURIComponent(platform)}&v=${encodeURIComponent(this.productService.version)}&m=${encodeURIComponent(info.machineId)}`; const usedParams = this.productService.surveys ?.filter(surveyData => surveyData.surveyId && surveyData.languageId) // Counts provided by contrib/surveys/browser/languageSurveys .filter(surveyData => this.storageService.getNumber(`${surveyData.surveyId}.editedCount`, StorageScope.GLOBAL, 0) > 0) .map(surveyData => `${encodeURIComponent(surveyData.languageId)}Lang=1`) .join('&'); if (usedParams) { surveyUrl += `&${usedParams}`; } this.openerService.open(URI.parse(surveyUrl)); </ins> this.skipSurvey(); }); }", "commid": "vscode_pr_124006"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-650ce316956c9cc88c7c054b279cb2914fa48fcb99c96311c231101520190746", "text": "import { ContributedEditorInfo, ContributedEditorPriority, ContributionPointOptions, DEFAULT_EDITOR_ASSOCIATION, DiffEditorInputFactoryFunction, EditorAssociation, EditorAssociations, EditorInputFactoryFunction, editorsAssociationsSettingId, globMatchesResource, IEditorOverrideService, priorityToRank } from 'vs/workbench/services/editor/common/editorOverrideService'; import { IKeyMods, IQuickInputService, IQuickPickItem, IQuickPickSeparator } from 'vs/platform/quickinput/common/quickInput'; import { localize } from 'vs/nls'; <del> import { Codicon } from 'vs/base/common/codicons'; </del> import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { registerSingleton } from 'vs/platform/instantiation/common/extensions';", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-a93dcaec32343c04f1bd207ec16dec487473941dc7fec062b32b741c886f6702", "text": "export class EditorOverrideService extends Disposable implements IEditorOverrideService { readonly _serviceBrand: undefined; <ins> private static readonly configureDefaultID = 'promptOpenWith.configureDefault'; </ins> private _contributionPoints: Map<string | glob.IRelativePattern, ContributionPoints> = new Map<string | glob.IRelativePattern, ContributionPoints>(); private static readonly overrideCacheStorageID = 'editorOverrideService.cache'; private cache: Set<string> | undefined;", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-0094f42776b9e536bbc87fb82bf20b6432987ea92b9564295bcee3e6e5d8be38", "text": "}); } <del> private mapContributionsToQuickPickEntry(resource: URI, group: IEditorGroup, alwaysUpdateSetting?: boolean) { </del> <ins> private mapContributionsToQuickPickEntry(resource: URI, group: IEditorGroup, showDefaultPicker?: boolean) { </ins> const currentEditor = firstOrDefault(group.findEditors(resource)); // If untitled, we want all contribution points let contributionPoints = resource.scheme === Schemas.untitled ? distinct(flatten(Array.from(this._contributionPoints.values())), (contrib) => contrib.editorInfo.id) : this.findMatchingContributions(resource);", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-5bb6597fc6b163efe2beb5046e208b4e33ef357aff72b0d96b3d8a6e662b9fbd", "text": "return priorityToRank(b.editorInfo.priority) - priorityToRank(a.editorInfo.priority); } }); <del> const contribGroups: { defaults: Array<IQuickPickSeparator | IQuickPickItem>, optional: Array<IQuickPickSeparator | IQuickPickItem> } = { defaults: [ { type: 'separator', label: localize('editorOverride.picker.default', 'Defaults') } ], optional: [ { type: 'separator', label: localize('editorOverride.picker.optional', 'Optional') } ], }; </del> <ins> const quickPickEntries: Array<IQuickPickItem | IQuickPickSeparator> = []; </ins> // Get the matching contribtuions and call resolve whether they're active for the picker contributionPoints.forEach(contribPoint => { const isActive = currentEditor ? contribPoint.editorInfo.describes(currentEditor) : false; <del> const quickPickEntry = { </del> <ins> const quickPickEntry: IQuickPickItem = { </ins> id: contribPoint.editorInfo.id, label: contribPoint.editorInfo.label, description: isActive ? localize('promptOpenWith.currentlyActive', \"Currently Active\") : undefined, detail: contribPoint.editorInfo.detail ?? contribPoint.editorInfo.priority, <del> buttons: alwaysUpdateSetting ? [] : [{ iconClass: Codicon.gear.classNames, tooltip: localize('promptOpenWith.setDefaultTooltip', \"Set as default editor for '{0}' files\", extname(resource)) }], </del> }; <del> if (contribPoint.editorInfo.priority === ContributedEditorPriority.option) { contribGroups.optional.push(quickPickEntry); } else { contribGroups.defaults.push(quickPickEntry); } </del> <ins> quickPickEntries.push(quickPickEntry); </ins> }); <del> return [...contribGroups.defaults, ...contribGroups.optional]; </del> <ins> if (!showDefaultPicker) { const separator: IQuickPickSeparator = { type: 'separator' }; quickPickEntries.push(separator); const configureDefaultEntry = { id: EditorOverrideService.configureDefaultID, label: localize('promptOpenWith.configureDefault', \"Configure default editor....\") }; quickPickEntries.push(configureDefaultEntry); } return quickPickEntries; </ins> } <del> private async doPickEditorOverride(editor: IEditorInput, options: IEditorOptions | undefined, group: IEditorGroup, alwaysUpdateSetting?: boolean): Promise<[IEditorOptions, IEditorGroup | undefined] | undefined> { </del> <ins> private async doPickEditorOverride(editor: IEditorInput, options: IEditorOptions | undefined, group: IEditorGroup, showDefaultPicker?: boolean): Promise<[IEditorOptions, IEditorGroup | undefined] | undefined> { </ins> type EditorOverridePick = { readonly item: IQuickPickItem;", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-5c167208f21c0c84ddc44c829674771eaea08e86d5fe46cc648d1ba8f392c3fc", "text": "} // Text editor has the lowest priority because we <del> const editorOverridePicks = this.mapContributionsToQuickPickEntry(resource, group, alwaysUpdateSetting); </del> <ins> const editorOverridePicks = this.mapContributionsToQuickPickEntry(resource, group, showDefaultPicker); </ins> // Create editor override picker const editorOverridePicker = this.quickInputService.createQuickPick<IQuickPickItem>(); <del> const placeHolderMessage = alwaysUpdateSetting ? </del> <ins> const placeHolderMessage = showDefaultPicker ? </ins> localize('prompOpenWith.updateDefaultPlaceHolder', \"Select new default editor for '{0}'\", basename(resource)) : localize('promptOpenWith.placeHolder', \"Select editor for '{0}'\", basename(resource)); editorOverridePicker.placeholder = placeHolderMessage;", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-ceb6a351d28dd68ce21ed4399c9beaecc733f6728dcab1c90d17d5377982f72c", "text": "} // If asked to always update the setting then update it even if the gear isn't clicked <del> if (alwaysUpdateSetting && result?.item.id) { </del> <ins> if (showDefaultPicker && result?.item.id) { </ins> this.updateUserAssociations(`*${extname(resource)}`, result.item.id,); }", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-a10309cc7a6b7da8591654ce38eeabd2897dab5ab5a163aca9c826814644cffd", "query": "When changing the default editor we show a in the quick pick to change this. The gear action by itself is not clear that it will immediately change the default and assume there would be another screen to confirm. ! Change the flow to match how you select different formatters to make it clearer/explicit. In the formatter case, there is a \"Configure Default Formatter...\" that is clear and indicates that user input is required on the next step. The same can be applied to default editors. ! cc", "positive_passages": [{"docid": "doc-en-vscode-17b425e799e821f050104d8db67bc581e0582714e868e65580d9fefe9c498d17", "text": "// options and group to use accordingly if (picked) { <ins> // If the user selected to configure default we trigger this picker again and tell it to show the default picker if (picked.item.id === EditorOverrideService.configureDefaultID) { return this.doPickEditorOverride(editor, options, group, true); } </ins> // Figure out target group let targetGroup: IEditorGroup | undefined; if (picked.keyMods?.alt || picked.keyMods?.ctrlCmd) {", "commid": "vscode_pr_122863"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb2e75d4a3e4463386e8ce868780bf31424749a940adcc473341a87a707ca2be", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.56.0-insider OS Version: Windows 10 Steps to Reproduce: new blank notebook cells only are missing bottom padding: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --", "positive_passages": [{"docid": "doc-en-vscode-21067e7faba742f80857ea0769ca88d0f439b0cb3f63ac6cdc6038d39c55121e", "text": "collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .monaco-list-row > .cell-inner-container { padding-top: ${CELL_TOP_MARGIN}px; }`); collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .markdown-cell-row > .cell-inner-container { padding-bottom: ${MARKDOWN_CELL_BOTTOM_MARGIN}px; padding-top: ${MARKDOWN_CELL_TOP_MARGIN}px; }`); collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .markdown-cell-row > .cell-inner-container.webview-backed-markdown-cell { padding: 0; }`); <del> collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .markdown-cell-row > .webview-backed-markdown-cell.markdown-cell-edit-mode .cell.code { padding-top: ${MARKDOWN_CELL_TOP_MARGIN}px; }`); </del> <ins> collector.addRule(`.notebookOverlay .cell-list-container > .monaco-list > .monaco-scrollable-element > .monaco-list-rows > .markdown-cell-row > .webview-backed-markdown-cell.markdown-cell-edit-mode .cell.code { padding-bottom: ${MARKDOWN_CELL_BOTTOM_MARGIN}px; padding-top: ${MARKDOWN_CELL_TOP_MARGIN}px; }`); </ins> collector.addRule(`.notebookOverlay .output { margin: 0px ${CELL_RIGHT_MARGIN}px 0px ${CODE_CELL_LEFT_MARGIN + CELL_RUN_GUTTER}px; }`); collector.addRule(`.notebookOverlay .output { width: calc(100% - ${CODE_CELL_LEFT_MARGIN + CELL_RUN_GUTTER + CELL_RIGHT_MARGIN}px); }`);", "commid": "vscode_pr_122505"}], "negative_passages": []}
{"query_id": "q-en-vscode-966ba5ff57b3e9a507ca555651d9b56ffb7295d00a9eda2b98964e0146001a74", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.56.2 OS Version: Darwin x64 19.6.0 I was confused by the QuickPick API as and were commented \"This can be read and updated by the extension.\" while wasn't. Then I was trying to dispose QuickInput and create a new one to update items, but after I read the source code I found can be directly updated by extensions\nverification: look at the PR. It updated a comment.", "positive_passages": [{"docid": "doc-en-vscode-c4c5c1b4ec9fafb335335bbbdacb801cecda6ea5352e3bb9def54106be04578f", "text": "readonly onDidTriggerButton: Event<QuickInputButton>; /** <del> * Items to pick from. </del> <ins> * Items to pick from. This can be read and updated by the extension. </ins> */ items: readonly T[];", "commid": "vscode_pr_124485"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-996da7af8bae947587db50bd6f6f2a8dc9ffa1b8ae2c2ca5a17d6087146fed2d", "text": "fileMatch?: string[]; url?: string; schema?: any; <ins> folderUri?: string; </ins> }; export namespace SettingIds {", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-b16f9b2f8ad312cd45aafd3246a7f7129b4feef8db94921d164403c95219da8c", "text": "jsonFoldingLimit = normalizeLimit(workspace.getConfiguration(SettingIds.editorSection, { languageId: 'json' }).get(SettingIds.foldingMaximumRegions)); jsoncFoldingLimit = normalizeLimit(workspace.getConfiguration(SettingIds.editorSection, { languageId: 'jsonc' }).get(SettingIds.foldingMaximumRegions)); <ins> const schemas: JSONSchemaSettings[] = []; </ins> const settings: Settings = { http: { proxy: httpSettings.get('proxy'),", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-c17ac29c3cb974c9d836dbf92c8e0c722c2cb1e61e20f231b260d5cc740139c0", "text": "validate: { enable: configuration.get(SettingIds.enableValidation) }, format: { enable: configuration.get(SettingIds.enableFormatter) }, keepLines: { enable: configuration.get(SettingIds.enableKeepLines) }, <del> schemas: [], </del> <ins> schemas, </ins> resultLimit: resultLimit + 1, // ask for one more so we can detect if the limit has been exceeded jsonFoldingLimit: jsonFoldingLimit + 1, jsoncFoldingLimit: jsoncFoldingLimit + 1 } }; <del> const schemaSettingsById: { [schemaId: string]: JSONSchemaSettings } = Object.create(null); const collectSchemaSettings = (schemaSettings: JSONSchemaSettings[], folderUri?: Uri, isMultiRoot?: boolean) => { let fileMatchPrefix = undefined; if (folderUri && isMultiRoot) { fileMatchPrefix = folderUri.toString(); if (fileMatchPrefix[fileMatchPrefix.length - 1] === '/') { fileMatchPrefix = fileMatchPrefix.substr(0, fileMatchPrefix.length - 1); } } </del> <ins> const collectSchemaSettings = (schemaSettings: JSONSchemaSettings[], folderUri?: Uri) => { </ins> for (const setting of schemaSettings) { const url = getSchemaId(setting, folderUri); <del> if (!url) { continue; } let schemaSetting = schemaSettingsById[url]; if (!schemaSetting) { schemaSetting = schemaSettingsById[url] = { url, fileMatch: [] }; settings.json!.schemas!.push(schemaSetting); } const fileMatches = setting.fileMatch; if (Array.isArray(fileMatches)) { const resultingFileMatches = schemaSetting.fileMatch || []; schemaSetting.fileMatch = resultingFileMatches; const addMatch = (pattern: string) => { //  filter duplicates if (resultingFileMatches.indexOf(pattern) === -1) { resultingFileMatches.push(pattern); } }; for (const fileMatch of fileMatches) { if (fileMatchPrefix) { if (fileMatch[0] === '/') { addMatch(fileMatchPrefix + fileMatch); addMatch(fileMatchPrefix + '/*' + fileMatch); } else { addMatch(fileMatchPrefix + '/' + fileMatch); addMatch(fileMatchPrefix + '/*/' + fileMatch); } } else { addMatch(fileMatch); } } } if (setting.schema && !schemaSetting.schema) { schemaSetting.schema = setting.schema; </del> <ins> if (url) { const schemaSetting: JSONSchemaSettings = { url, fileMatch: setting.fileMatch, folderUri: folderUri?.toString(false), schema: setting.schema }; schemas.push(schemaSetting); </ins> } } }; <del> const folders = workspace.workspaceFolders; // merge global and folder settings. Qualify all file matches with the folder path. </del> const globalSettings = workspace.getConfiguration('json', null).get<JSONSchemaSettings[]>('schemas'); if (Array.isArray(globalSettings)) { <del> if (!folders) { collectSchemaSettings(globalSettings); } </del> <ins> collectSchemaSettings(globalSettings); </ins> } <ins> const folders = workspace.workspaceFolders; </ins> if (folders) { <del> const isMultiRoot = folders.length > 1; </del> for (const folder of folders) { <del> const folderUri = folder.uri; const schemaConfigInfo = workspace.getConfiguration('json', folderUri).inspect<JSONSchemaSettings[]>('schemas'); const folderSchemas = schemaConfigInfo!.workspaceFolderValue; if (Array.isArray(folderSchemas)) { collectSchemaSettings(folderSchemas, folderUri, isMultiRoot); </del> <ins> const schemaConfigInfo = workspace.getConfiguration('json', folder.uri).inspect<JSONSchemaSettings[]>('schemas'); if (schemaConfigInfo && Array.isArray(schemaConfigInfo.workspaceFolderValue)) { collectSchemaSettings(schemaConfigInfo.workspaceFolderValue, folder.uri); </ins> } <del> if (Array.isArray(globalSettings)) { collectSchemaSettings(globalSettings, folderUri, isMultiRoot); } </del> } } return settings;", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-7b4e71310bf6ea1ea21ecc95eaea6f82aef22b26153714e7a69e69f32614f4e4", "text": "url = schema.schema.id || `vscode://schemas/custom/${encodeURIComponent(hash(schema.schema).toString(16))}`; } } else if (folderUri && (url[0] === '.' || url[0] === '/')) { <del> url = Uri.joinPath(folderUri, url).toString(); </del> <ins> url = Uri.joinPath(folderUri, url).toString(false); </ins> } return url; }", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-94e018a73f84c7e959444d01efd7579f42ff47aa8c2241b81b1b064cf76b1202", "text": "- `schemas`: Configures association of file names to schema URL or schemas and/or associations of schema URL to schema content. - `fileMatch`: an array of file names or paths (separated by `/`). `*` can be used as a wildcard. Exclusion patterns can also be defined and start with '!'. A file matches when there is at least one matching pattern and the last matching pattern is not an exclusion pattern. - `url`: The URL of the schema, optional when also a schema is provided. <del> - `schema`: The schema content. </del> <ins> - `schema`: The schema content, optional - `folderUri`: If provided, the association is only used if the document is located in the given folder (directly or indirectly) </ins> - `resultLimit`: The max number of color decorators and outline symbols to be computed (for performance reasons) - `jsonFoldingLimit`: The max number of folding ranges to be computed for json documents (for performance reasons) - `jsoncFoldingLimit`: The max number of folding ranges to be computed for jsonc documents (for performance reasons)", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-40ee53c0a9a5953bb85a1842c6b88dd9c1cd2ca5b4cc9fed125e8593b4c6457a", "text": "* A match succeeds when there is at least one pattern matching and last matching pattern does not start with '!'. */ fileMatch: string[]; <ins> /** * If provided, the association is only used if the validated document is located in the given folder (directly or indirectly) */ folderUri?: string; </ins> /* * The schema for the given URI. * If no schema is provided, the schema will be fetched with the schema request service (if available).", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-61f4e6a3f322c078be3defd4d36dc2c901ef0579779cc24aeb269d1a3472f836", "text": "}, \"main\": \"./out/node/jsonServerMain\", \"dependencies\": { <ins> \"@vscode/l10n\": \"^0.0.11\", </ins> \"jsonc-parser\": \"^3.2.0\", \"request-light\": \"^0.7.0\", <del> \"vscode-json-languageservice\": \"^5.1.4\", </del> <ins> \"vscode-json-languageservice\": \"^5.2.0\", </ins> \"vscode-languageserver\": \"^8.1.0-next.6\", <del> \"vscode-uri\": \"^3.0.7\", \"@vscode/l10n\": \"^0.0.11\" </del> <ins> \"vscode-uri\": \"^3.0.7\" </ins> }, \"devDependencies\": { \"@types/mocha\": \"^9.1.1\",", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-e4b6804a044c00f9fdcf9e0930f87cb321027b5cbd24ebc64c9af04001e34732", "text": "fileMatch?: string[]; url?: string; schema?: JSONSchema; <ins> folderUri?: string; </ins> }", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-12ad7afeca37128dfa35bf4e09b6c72f428dbc090271db22eae2f3e5db73b590", "text": "uri = schema.schema.id || `vscode://schemas/custom/${index}`; } if (uri) { <del> languageSettings.schemas.push({ uri, fileMatch: schema.fileMatch, schema: schema.schema }); </del> <ins> languageSettings.schemas.push({ uri, fileMatch: schema.fileMatch, schema: schema.schema, folderUri: schema.folderUri }); </ins> } }); }", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-9e833a1d28844ae1e1fe695ebd5d9ca77377c4c1dbc8d62689a605d14b4a7caa", "text": "resolved \"https://registry.yarnpkg.com/request-light/-/request-light-0.7.0.tgz#885628bb2f8040c26401ebf258ec51c4ae98ac2a\" integrity sha512-lMbBMrDoxgsyO+yB3sDcrDuX85yYt7sS8BfQd11jtbW/z5ZWgLZRcEGLsLoYw7I0WSUGQBs8CC8ScIxkTX1+6Q== <del> vscode-json-languageservice@^5.1.4: version \"5.1.4\" resolved \"https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.1.4.tgz#cbdb447f281dcd107705e7fe8fbfc0b71db7610d\" integrity sha512-ROZ1ezYQUbq9b/07xYpHtZSyyhoUk3oTTGVAEr6bU1DKr8ELaz9fsDoHno34tKtHj/Tf3deQqfjQNGKdbRuvTw== </del> <ins> vscode-json-languageservice@^5.2.0: version \"5.2.0\" resolved \"https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.2.0.tgz#884b7f108be4310e3332167c3ea60ab17f03418c\" integrity sha512-q8Rdhu2HEddRxvlhVqwh0cWmKK+OtyMB2xRhtqXEQ7cjb0iZ14madb90iJe9fCHPjoj9CGBrq6QzuOp8OE6XWg== </ins> dependencies: \"@vscode/l10n\" \"^0.0.11\" jsonc-parser \"^3.2.0\"", "commid": "vscode_pr_173169"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-8f4cf26c80774bdadeea3be1de3bf0d8c47e1cb1b596e184f85039aec06b4c2b", "text": "} }; <del> const collectSchemaSettings = (schemaSettings: JSONSchemaSettings[], folderUri?: Uri) => { for (const setting of schemaSettings) { const url = getSchemaId(setting, folderUri); if (url) { const schemaSetting: JSONSchemaSettings = { url, fileMatch: setting.fileMatch, folderUri: folderUri?.toString(false), schema: setting.schema }; schemas.push(schemaSetting); </del> <ins> const collectSchemaSettings = (schemaSettings: JSONSchemaSettings[] | undefined, folderUri?: Uri) => { if (schemaSettings) { for (const setting of schemaSettings) { const url = getSchemaId(setting, folderUri); if (url) { const schemaSetting: JSONSchemaSettings = { url, fileMatch: setting.fileMatch, folderUri: folderUri?.toString(false), schema: setting.schema }; schemas.push(schemaSetting); } </ins> } } }; <del> const globalSettings = workspace.getConfiguration('json', null).get<JSONSchemaSettings[]>('schemas'); if (Array.isArray(globalSettings)) { collectSchemaSettings(globalSettings); </del> <ins> const schemaConfigInfo = workspace.getConfiguration('json', null).inspect<JSONSchemaSettings[]>('schemas'); if (schemaConfigInfo) { if (workspace.workspaceFile) { collectSchemaSettings(schemaConfigInfo.workspaceValue, workspace.workspaceFile); } collectSchemaSettings(schemaConfigInfo.globalValue); </ins> } const folders = workspace.workspaceFolders; if (folders) { for (const folder of folders) { const schemaConfigInfo = workspace.getConfiguration('json', folder.uri).inspect<JSONSchemaSettings[]>('schemas'); <del> if (schemaConfigInfo && Array.isArray(schemaConfigInfo.workspaceFolderValue)) { collectSchemaSettings(schemaConfigInfo.workspaceFolderValue, folder.uri); } </del> <ins> collectSchemaSettings(schemaConfigInfo?.workspaceFolderValue, folder.uri); </ins> } } return settings;", "commid": "vscode_pr_175185"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-15c2def108e488797b4dc5669341cde40f43651a1ffee15bb96c9eee429bda68", "text": "} }; <del> const collectSchemaSettings = (schemaSettings: JSONSchemaSettings[] | undefined, folderUri?: Uri) => { </del> <ins> const collectSchemaSettings = (schemaSettings: JSONSchemaSettings[] | undefined, folderUri: Uri | undefined = undefined, settingsLocation = folderUri) => { </ins> if (schemaSettings) { for (const setting of schemaSettings) { <del> const url = getSchemaId(setting, folderUri); </del> <ins> const url = getSchemaId(setting, settingsLocation); </ins> if (url) { const schemaSetting: JSONSchemaSettings = { url, fileMatch: setting.fileMatch, folderUri: folderUri?.toString(false), schema: setting.schema }; schemas.push(schemaSetting);", "commid": "vscode_pr_175320"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-4ba95b7cc53ec8ce011a9d5f1f997bb6832de4afb7fd268e178eb30c70887a3c", "text": "} }; <ins> const folders = workspace.workspaceFolders; </ins> const schemaConfigInfo = workspace.getConfiguration('json', null).inspect<JSONSchemaSettings[]>('schemas'); if (schemaConfigInfo) { <del> if (workspace.workspaceFile) { collectSchemaSettings(schemaConfigInfo.workspaceValue, workspace.workspaceFile); </del> <ins> if (schemaConfigInfo.workspaceValue && workspace.workspaceFile && folders && folders.length) { const settingsLocation = Uri.joinPath(workspace.workspaceFile, '..'); for (const folder of folders) { collectSchemaSettings(schemaConfigInfo.workspaceValue, folder.uri, settingsLocation); } </ins> } collectSchemaSettings(schemaConfigInfo.globalValue); } <del> const folders = workspace.workspaceFolders; </del> if (folders) { for (const folder of folders) { const schemaConfigInfo = workspace.getConfiguration('json', folder.uri).inspect<JSONSchemaSettings[]>('schemas');", "commid": "vscode_pr_175320"}], "negative_passages": []}
{"query_id": "q-en-vscode-aa2e718fa516c3ea8453d0a08df8c23d6d4afea3bd9974eacc1ff983d87dd4b0", "query": "Issue Type: <bBug</bI have a multi-root VSC workspace with three folders: A/ ./subfolderOfA In A/, there is a file and in there, there are the following settings: When I edit some file somewhere inside A/, it seems like this JSON schema file path is only properly resolved If I remove folders and from my multi-root workspace. Shouldn't this work? VS Code version: Code 1.56.2 (, 2021-05-12T17:13:13.157Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (10)</summaryExtensionVersion ------ bracket-pair-colorizer-20.2.0 xml2.5.1 tortoise-svn0.1.1 python2020.9. vscode-pylance2021.5.3 jupyter2021.6. cpptools1.3.1 code-spell-checker1.10.2 open-in-browser2.0.0 vscodeintellicode1.2.14 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nHi Unfortunately, I am not familiar with your planning process but I wanted to ask if this bug will be solved in the near future?\nSorry, I don't know when I will find time for looking at this.\nIt's honestly quite a shame that this feature is missing. Unless you want to modify the json file structure to include the \"$schema\" property you are stuck having to open the given sub-folders directly which is a significant detrement to the DX when working in multi-root workspaces.\nHi Sorry to pick this up again but, according to the motto \"New Year, New Luck\", is there a chance to have this and fixed soon?\nIt seems like relative schema path resolution does not work on Windows, even when not in a multi-root workspace. Schemas always try to resolve in rather than the workspace folder. !\nNote: relative path can not be used in user settings. But they should work in workspace files, where I could reproduce the problem, thanks !\nNow on macOS, unfortunately it seems like json.schemas in the workspace settings are ignored. <img width=\"1605\" alt=\"image\" src=\"https://user-\"Changing to something invalid does not result in any diagnostics being reported, either. However if I move into my user settings and change the schema path to be absolute, it works.\nNow I get in the Problems view with the following setup: In a non-multi-root workspace:\nI created a separate issue to investigate as the error comes from to the empty which is unrelated. If you remove the you should see that the - schema is used\nTo verify: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated look at the folder setings: is associated with schema . Note that this is a relative path to the folder open both files files and check that code completion gives back property , but only when in folder1. You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated\nI tried to verify this using build but the schemas are not used. Here is what I see in the UI: <img width=\"706\" alt=\"image\" src=\"https://user-\" please advise which build I should use for verification.\nLooks like it is still not working on Windows due to to an URI encoding issue.\nI tested as described in with VS Code 1.76.0 on Windows. I observed the following for and in VS Code: no schema-defined code completion is offered there is no schema offered when clicking on the language selector I then tested folder-only settings by opening VS Code to . I observed the same as above for . FWIW, describes another repro with only folder settings (not workspace settings). Is there a known workaround to get validation working using on Windows for 1.76.0?\nthe fix for Windows is coming:\nis now also fixed (and verified)", "positive_passages": [{"docid": "doc-en-vscode-0c269f4261b3a1958506a310f307faa246c34f6d882d92df022b5306c6c9f108", "text": "return settings; } <del> function getSchemaId(schema: JSONSchemaSettings, folderUri?: Uri): string | undefined { </del> <ins> function getSchemaId(schema: JSONSchemaSettings, settingsLocation?: Uri): string | undefined { </ins> let url = schema.url; if (!url) { if (schema.schema) { url = schema.schema.id || `vscode://schemas/custom/${encodeURIComponent(hash(schema.schema).toString(16))}`; } <del> } else if (folderUri && (url[0] === '.' || url[0] === '/')) { url = Uri.joinPath(folderUri, url).toString(false); </del> <ins> } else if (settingsLocation && (url[0] === '.' || url[0] === '/')) { url = Uri.joinPath(settingsLocation, url).toString(false); </ins> } return url; }", "commid": "vscode_pr_175320"}], "negative_passages": []}
{"query_id": "q-en-vscode-6c885d6767e8766bffa9b0c62cb256f38d0cc9e844e489f771d4f2f91cc5b721", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.56.2 OS Version: MacOS Catalina 10.15.6 Steps to Reproduce: VSCode Version any typescript file (for example in ) /Ctrl + Click on any native dom method, for example , there should be a error message popups ! I thinks this is caused by the wrong type definition file path in below code:", "positive_passages": [{"docid": "doc-en-vscode-def605a89f82d72b2c84b86d8cc890c22889bdd216c407002e20568fb3eeae58", "text": "if (isWeb()) { // On web, treat absolute paths as pointing to standard lib files if (filepath.startsWith('/')) { <del> return vscode.Uri.joinPath(this.context.extensionUri, 'node_modules', 'typescript', 'lib', filepath.slice(1)); </del> <ins> return vscode.Uri.joinPath(this.context.extensionUri, 'dist', 'browser', 'typescript', filepath.slice(1)); </ins> } }", "commid": "vscode_pr_125279"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-1ae6b742269e54f6f8d2a61021d548e9faacd1b2bea58b682304a81f832aeb03", "text": "import { IWorkspaceTrustManagementService, IWorkspaceTrustRequestService, workspaceTrustToString } from 'vs/platform/workspace/common/workspaceTrust'; import { Extensions as WorkbenchExtensions, IWorkbenchContribution, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions'; import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; <del> import { Codicon, registerCodicon } from 'vs/base/common/codicons'; </del> <ins> import { Codicon } from 'vs/base/common/codicons'; </ins> import { ThemeColor } from 'vs/workbench/api/common/extHostTypes'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-45a18462215e9a6decaa65ba4bd7305dcb9b877b44425e509f138d112afb048f", "text": "import { LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID } from 'vs/workbench/contrib/extensions/common/extensions'; const BANNER_RESTRICTED_MODE = 'workbench.banner.restrictedMode'; <del> const BANNER_VIRTUAL_WORKSPACE = 'workbench.banner.virtualWorkspace'; const BANNER_VIRTUAL_AND_RESTRICTED = 'workbench.banner.virtualAndRestricted'; </del> const STARTUP_PROMPT_SHOWN_KEY = 'workspace.trust.startupPrompt.shown'; const BANNER_RESTRICTED_MODE_DISMISSED_KEY = 'workbench.banner.restrictedMode.dismissed'; <del> const BANNER_VIRTUAL_WORKSPACE_DISMISSED_KEY = 'workbench.banner.virtualWorkspace.dismissed'; const infoIcon = registerCodicon('workspace-banner-warning-icon', Codicon.info); </del> /* * Trust Request via Service UX handler", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-21c47bff26587ef14ebe0bd52d0b06888a06c919ea26a004f9cd71236b73290d", "text": "break; case 'Manage': this.workspaceTrustRequestService.cancelRequest(); <del> await this.commandService.executeCommand('workbench.trust.manage'); </del> <ins> await this.commandService.executeCommand(MANAGE_TRUST_COMMAND_ID); </ins> break; case 'Cancel': this.workspaceTrustRequestService.cancelRequest();", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-00cf4020bd212d17b5d2747bc81694c9f9378cf986ede8fe5ad2cb8c251c1c3b", "text": "this.statusbarService.updateEntryVisibility(this.entryId, false); } <del> private getBannerItem(isInVirtualWorkspace: boolean, restrictedMode: boolean): IBannerItem | undefined { </del> <ins> private getBannerItem(restrictedMode: boolean): IBannerItem | undefined { </ins> <del> const dismissedVirtual = this.storageService.getBoolean(BANNER_VIRTUAL_WORKSPACE_DISMISSED_KEY, StorageScope.WORKSPACE, false); </del> const dismissedRestricted = this.storageService.getBoolean(BANNER_RESTRICTED_MODE_DISMISSED_KEY, StorageScope.WORKSPACE, false); <del> // all important info has been dismissed if (dismissedVirtual && dismissedRestricted) { return undefined; } // don't show restricted mode only banner if (dismissedRestricted && !isInVirtualWorkspace) { </del> <ins> // info has been dismissed if (dismissedRestricted) { </ins> return undefined; } <del> // don't show virtual workspace only banner if (dismissedVirtual && !restrictedMode) { return undefined; } const choose = (virtual: any, restricted: any, virtualAndRestricted: any) => { return (isInVirtualWorkspace && !dismissedVirtual) && (restrictedMode && !dismissedRestricted) ? virtualAndRestricted : ((isInVirtualWorkspace && !dismissedVirtual) ? virtual : restricted); }; const id = choose(BANNER_VIRTUAL_WORKSPACE, BANNER_RESTRICTED_MODE, BANNER_VIRTUAL_AND_RESTRICTED); const icon = choose(infoIcon, shieldIcon, infoIcon); const [virtualAriaLabel, restrictedModeAriaLabel, virtualAndRestrictedModeAriaLabel] = this.getBannerItemAriaLabels(); const ariaLabel = choose(virtualAriaLabel, restrictedModeAriaLabel, virtualAndRestrictedModeAriaLabel); const [virtualMessage, restrictedModeMessage, virtualAndRestrictedModeMessage] = this.getBannerItemMessages(); const message = choose(virtualMessage, restrictedModeMessage, virtualAndRestrictedModeMessage); const actions = choose( [ { label: localize('virtualBannerLearnMore', \"Learn More\"), href: 'https://aka.ms/vscode-virtual-workspaces' } ], </del> <ins> const actions = </ins> [ { label: localize('restrictedModeBannerManage', \"Manage\"), <del> href: 'command:workbench.trust.manage' </del> <ins> href: 'command:' + MANAGE_TRUST_COMMAND_ID </ins> }, { label: localize('restrictedModeBannerLearnMore', \"Learn More\"), href: 'https://aka.ms/vscode-workspace-trust' } <del> ], [ { label: localize('virtualAndRestrictedModeBannerManage', \"Manage Trust\"), href: 'command:workbench.trust.manage' }, { label: localize('virtualBannerLearnMore', \"Learn More\"), href: 'https://aka.ms/vscode-virtual-workspaces' } ] ); </del> <ins> ]; </ins> return { <del> id, icon, ariaLabel, message, </del> <ins> id: BANNER_RESTRICTED_MODE, icon: shieldIcon, ariaLabel: this.getBannerItemAriaLabels(), message: this.getBannerItemMessages(), </ins> actions, onClose: () => { <del> if (isInVirtualWorkspace) { this.storageService.store(BANNER_VIRTUAL_WORKSPACE_DISMISSED_KEY, true, StorageScope.WORKSPACE, StorageTarget.MACHINE); } </del> if (restrictedMode) { this.storageService.store(BANNER_RESTRICTED_MODE_DISMISSED_KEY, true, StorageScope.WORKSPACE, StorageTarget.MACHINE); }", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-c50882dd183f1786c6eef8e319210882a8e5dec7c7f9a68c8d54c202237520d7", "text": "}; } <del> private getBannerItemAriaLabels(): [string, string, string] { </del> <ins> private getBannerItemAriaLabels(): string { </ins> switch (this.workspaceContextService.getWorkbenchState()) { case WorkbenchState.EMPTY: <del> return [ localize('virtualBannerAriaLabelWindow', \"Some features are not available because the current window is backed by a virtual file system. Use navigation keys to access banner actions.\"), localize('restrictedModeBannerAriaLabelWindow', \"Restricted Mode is intended for safe code browsing. Trust this window to enable all features. Use navigation keys to access banner actions.\"), localize('virtualAndRestrictedModeBannerAriaLabelWindow', \"Some features are not available because the current window is backed by a virtual file system and is not trusted. You can trust this window to enable some of these features. Use navigation keys to access banner actions.\") ]; </del> <ins> return localize('restrictedModeBannerAriaLabelWindow', \"Restricted Mode is intended for safe code browsing. Trust this window to enable all features. Use navigation keys to access banner actions.\"); </ins> case WorkbenchState.FOLDER: <del> return [ localize('virtualBannerAriaLabelFolder', \"Some features are not available because the current folder is backed by a virtual file system. Use navigation keys to access banner actions.\"), localize('restrictedModeBannerAriaLabelFolder', \"Restricted Mode is intended for safe code browsing. Trust this folder to enable all features. Use navigation keys to access banner actions.\"), localize('virtualAndRestrictedModeBannerAriaLabelFolder', \"Some features are not available because the current folder is backed by a virtual file system and is not trusted. You can trust this folder to enable some of these features. Use navigation keys to access banner actions.\") ]; </del> <ins> return localize('restrictedModeBannerAriaLabelFolder', \"Restricted Mode is intended for safe code browsing. Trust this folder to enable all features. Use navigation keys to access banner actions.\"); </ins> case WorkbenchState.WORKSPACE: <del> return [ localize('virtualBannerAriaLabelWorkspace', \"Some features are not available because the current workspace is backed by a virtual file system. Use navigation keys to access banner actions.\"), localize('restrictedModeBannerAriaLabelWorkspace', \"Restricted Mode is intended for safe code browsing. Trust this workspace to enable all features. Use navigation keys to access banner actions.\"), localize('virtualAndRestrictedModeBannerAriaLabelWorkspace', \"Some features are not available because the current workspace is backed by a virtual file system and is not trusted. You can trust this workspace to enable some of these features. Use navigation keys to access banner actions.\") ]; </del> <ins> return localize('restrictedModeBannerAriaLabelWorkspace', \"Restricted Mode is intended for safe code browsing. Trust this workspace to enable all features. Use navigation keys to access banner actions.\"); </ins> } } <del> private getBannerItemMessages(): [string, string, string] { </del> <ins> private getBannerItemMessages(): string { </ins> switch (this.workspaceContextService.getWorkbenchState()) { case WorkbenchState.EMPTY: <del> return [ localize('virtualBannerMessageWindow', \"Some features are not available because the current workspace is backed by a virtual file system.\"), localize('restrictedModeBannerMessageWindow', \"Restricted Mode is intended for safe code browsing. Trust this window to enable all features.\"), localize('virtualAndRestrictedModeBannerMessageWindow', \"Some features are not available because the current window is backed by a virtual file system and is not trusted. You can trust this window to enable some of these features.\") ]; </del> <ins> return localize('restrictedModeBannerMessageWindow', \"Restricted Mode is intended for safe code browsing. Trust this window to enable all features.\"); </ins> case WorkbenchState.FOLDER: <del> return [ localize('virtualBannerMessageFolder', \"Some features are not available because the current folder is backed by a virtual file system.\"), localize('restrictedModeBannerMessageFolder', \"Restricted Mode is intended for safe code browsing. Trust this folder to enable all features.\"), localize('virtualAndRestrictedModeBannerMessageFolder', \"Some features are not available because the current folder is backed by a virtual file system and is not trusted. You can trust this folder to enable some of these features.\") ]; </del> <ins> return localize('restrictedModeBannerMessageFolder', \"Restricted Mode is intended for safe code browsing. Trust this folder to enable all features.\"); </ins> case WorkbenchState.WORKSPACE: <del> return [ localize('virtualBannerMessageWorkspace', \"Some features are not available because the current workspace is backed by a virtual file system.\"), localize('restrictedModeBannerMessageWorkspace', \"Restricted Mode is intended for safe code browsing. Trust this workspace to enable all features.\"), localize('virtualAndRestrictedModeBannerMessageWorkspace', \"Some features are not available because the current workspace is backed by a virtual file system and is not trusted. You can trust this workspace to enable some of these features.\") ]; </del> <ins> return localize('restrictedModeBannerMessageWorkspace', \"Restricted Mode is intended for safe code browsing. Trust this workspace to enable all features.\"); </ins> } }", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-7327b4a48eac7c15d78d49e287a95ca956fe50ced84ea5a10fb724945765e2c6", "text": "text: trusted ? `$(shield)` : `$(shield) ${text}`, ariaLabel: ariaLabel, tooltip: toolTip, <del> command: 'workbench.trust.manage', </del> <ins> command: MANAGE_TRUST_COMMAND_ID, </ins> backgroundColor, color };", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-f10a08ae24640811ce708bd7e3cad42fdb146c2c86371b00a9776a9264d66fbb", "query": "The recently remote indicate tooltip helps users to learn about the limited extension functionality when in virtual workspaces. That allows us to reserve the banner for information on the restricted mode and avoid the complicated sentences when restricted mode and virtual workspaces are on at the same time. While it is interesting information that is limited extension functionality when in virtual workspaces, it's IMO not that crucial to warrant a banner. Also there's nothing the user can do about it.\nFYI", "positive_passages": [{"docid": "doc-en-vscode-94ffcb7a411ceccc6c0f53724cc6ba9adb2952fe9c995812700ca52db0c998c4", "text": "} private updateWorkbenchIndicators(trusted: boolean): void { <del> const isInVirtualWorkspace = isVirtualWorkspace(this.workspaceContextService.getWorkspace()); </del> const isEmptyWorkspace = this.workspaceContextService.getWorkbenchState() === WorkbenchState.EMPTY; <del> const bannerItem = this.getBannerItem(isInVirtualWorkspace, !trusted); </del> <ins> const bannerItem = this.getBannerItem(!trusted); </ins> if (!isEmptyWorkspace || this.showIndicatorsInEmptyWindow) { this.updateStatusbarEntry(trusted); if (bannerItem) { <del> if (!isInVirtualWorkspace) { if (!trusted) { this.bannerService.show(bannerItem); } else { this.bannerService.hide(BANNER_RESTRICTED_MODE); } } else { </del> <ins> if (!trusted) { </ins> this.bannerService.show(bannerItem); <ins> } else { this.bannerService.hide(BANNER_RESTRICTED_MODE); </ins> } } }", "commid": "vscode_pr_125512"}], "negative_passages": []}
{"query_id": "q-en-vscode-1f90303c64f30e0b19fea8701836013282baf91b0f53e5234782594f82935b42", "query": "Since profiles are removed, the jupyter extension will show their \"run above/below\" commands unless we put them back in the cell toolbar by default, so we should just disable this setting until we have a jupyter profile available that disables it", "positive_passages": [{"docid": "doc-en-vscode-9b00584359cb0c1108cabb7cb17fd71dde5f6bc80a525c33991cef08facfebad", "text": "[ConsolidatedRunButton]: { description: nls.localize('notebook.consolidatedRunButton.description', \"Control whether extra actions are shown in a dropdown next to the run button.\"), type: 'boolean', <del> default: true, </del> <ins> default: false, </ins> tags: ['notebookLayout'] }, [NotebookCellEditorOptionsCustomizations]: editorOptionsCustomizationSchema", "commid": "vscode_pr_125552"}], "negative_passages": []}
{"query_id": "q-en-vscode-a5840eab3d3b2d5b756383939d428c580fa4b4adc338149692282fec6e9a86fe", "query": "Not sure if this is a German only problem <img width=\"440\" alt=\"capture\" src=\"https://user-\"\nThis is probably a generic issue. Command should not get translated. Is there a way to ignore a substring of the localization string so that it doesn't get translated? I guess we could use interpolation...\nThis is a generic problem. Here's pseudo language: !\nAny specific verification steps? I tried changing my display language (to German) but the workspace trust page doesn't seem localized yet: !\nVerified this by looking at the language packs in the vscode-loc repo. It's currently in English but translations take some time.", "positive_passages": [{"docid": "doc-en-vscode-c24652f9284a8d6f23fd5925a815a5b712f5f6fc05fdf299c0118ebf400c5045", "text": "[ localize('untrustedTasks', \"Tasks are disabled\"), localize('untrustedDebugging', \"Debugging is disabled\"), <del> localize('untrustedExtensions', \"[{0} extensions](command:{1}) are disabled or have limited functionality\", numExtensions, LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID) </del> <ins> localize('untrustedExtensions', \"[{0} extensions]({1}) are disabled or have limited functionality\", numExtensions, `command:${LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID}`) </ins> ] : [ localize('untrustedTasks', \"Tasks are disabled\"), localize('untrustedDebugging', \"Debugging is disabled\"), <del> numSettings ? localize('untrustedSettings', \"[{0} workspace settings](command:{1}) are not applied\", numSettings, 'settings.filterUntrusted') : localize('no untrustedSettings', \"Workspace settings requiring trust are not applied\"), localize('untrustedExtensions', \"[{0} extensions](command:{1}) are disabled or have limited functionality\", numExtensions, LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID) </del> <ins> numSettings ? localize('untrustedSettings', \"[{0} workspace settings]({1}) are not applied\", numSettings, 'command:settings.filterUntrusted') : localize('no untrustedSettings', \"Workspace settings requiring trust are not applied\"), localize('untrustedExtensions', \"[{0} extensions]({1}) are disabled or have limited functionality\", numExtensions, `command:${LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID}`) </ins> ]; this.renderLimitationsListElement(untrustedContainer, untrustedContainerItems, xListIcon.classNamesArray);", "commid": "vscode_pr_125768"}], "negative_passages": []}
{"query_id": "q-en-vscode-2f1fba3c2a4748113196c418a144be909f45663ba712680ca406cacfa67d01af", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Basically when i have a statusbar item (extension that contributes statusbar items), VS Code re-creates all of the statusbar items for all cells. This causes ALL statubar items in all cells to flicker (as its destroyed and re-created) & we also end up with duplicates. /cc Flickering UI Duplicate statusbar items See below (from latest VS Code Insiders, can also replicate in latest main branch) Note how we end up with two language pickers in statusbar. ! After the fix (re-use instead of re-creating & only create what we need): !\nThought I had squashed all of these. Thanks for the PR!\nThe power tools don't seem to provide line numbers anymore so I tried switching the language mode around to repro and couldn't so I'm not sure if that's good enough for verification\nI think it's sufficient to mess around with it and not see any dupes. And there were random reports of dupes earlier and I haven't heard that in awhile.", "positive_passages": [{"docid": "doc-en-vscode-5456ca84f37ec6a68271ec5823fc7e01fc33f5bc283afd0a13c8218f014f225e", "text": "import { disposableTimeout, Throttler } from 'vs/base/common/async'; import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; <del> import { ICellVisibilityChangeEvent, NotebookVisibleCellObserver } from 'vs/workbench/contrib/notebook/browser/contrib/statusBar/notebookVisibleCellObserver'; </del> <ins> import { NotebookVisibleCellObserver } from 'vs/workbench/contrib/notebook/browser/contrib/statusBar/notebookVisibleCellObserver'; </ins> import { ICellViewModel, INotebookEditor, INotebookEditorContribution } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; import { registerNotebookContribution } from 'vs/workbench/contrib/notebook/browser/notebookEditorExtensions'; <del> import { NotebookViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel'; </del> <ins> import { CellViewModel, NotebookViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel'; </ins> import { INotebookCellStatusBarService } from 'vs/workbench/contrib/notebook/common/notebookCellStatusBarService'; import { INotebookCellStatusBarItemList } from 'vs/workbench/contrib/notebook/common/notebookCommon';", "commid": "vscode_pr_125811"}], "negative_passages": []}
{"query_id": "q-en-vscode-2f1fba3c2a4748113196c418a144be909f45663ba712680ca406cacfa67d01af", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Basically when i have a statusbar item (extension that contributes statusbar items), VS Code re-creates all of the statusbar items for all cells. This causes ALL statubar items in all cells to flicker (as its destroyed and re-created) & we also end up with duplicates. /cc Flickering UI Duplicate statusbar items See below (from latest VS Code Insiders, can also replicate in latest main branch) Note how we end up with two language pickers in statusbar. ! After the fix (re-use instead of re-creating & only create what we need): !\nThought I had squashed all of these. Thanks for the PR!\nThe power tools don't seem to provide line numbers anymore so I tried switching the language mode around to repro and couldn't so I'm not sure if that's good enough for verification\nI think it's sufficient to mess around with it and not see any dupes. And there were random reports of dupes earlier and I haven't heard that in awhile.", "positive_passages": [{"docid": "doc-en-vscode-adf77a60671b7374cec9de1db29f462aa22e724482ec6d7c23dc5b1c270a783c", "text": "} private _updateEverything(): void { <del> this._visibleCells.forEach(cell => cell.dispose()); this._visibleCells.clear(); this._updateVisibleCells({ added: this._observer.visibleCells, removed: [] }); </del> <ins> const newCells = this._observer.visibleCells.filter(cell => !this._visibleCells.has(cell.handle)); const visibleCellHandles = new Set(this._observer.visibleCells.map(item => item.handle)); const currentCellHandles = Array.from(this._visibleCells.keys()); const removedCells = currentCellHandles.filter(handle => !visibleCellHandles.has(handle)); const itemsToUpdate = currentCellHandles.filter(handle => visibleCellHandles.has(handle)); this._updateVisibleCells({ added: newCells, removed: removedCells.map(handle => ({ handle })) }); itemsToUpdate.forEach(handle => this._visibleCells.get(handle)?.update()); </ins> } <del> private _updateVisibleCells(e: ICellVisibilityChangeEvent): void { </del> <ins> private _updateVisibleCells(e: { added: CellViewModel[]; removed: { handle: number }[]; }): void { </ins> const vm = this._notebookEditor.viewModel; if (!vm) { return;", "commid": "vscode_pr_125811"}], "negative_passages": []}
{"query_id": "q-en-vscode-2f1fba3c2a4748113196c418a144be909f45663ba712680ca406cacfa67d01af", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Basically when i have a statusbar item (extension that contributes statusbar items), VS Code re-creates all of the statusbar items for all cells. This causes ALL statubar items in all cells to flicker (as its destroyed and re-created) & we also end up with duplicates. /cc Flickering UI Duplicate statusbar items See below (from latest VS Code Insiders, can also replicate in latest main branch) Note how we end up with two language pickers in statusbar. ! After the fix (re-use instead of re-creating & only create what we need): !\nThought I had squashed all of these. Thanks for the PR!\nThe power tools don't seem to provide line numbers anymore so I tried switching the language mode around to repro and couldn't so I'm not sure if that's good enough for verification\nI think it's sufficient to mess around with it and not see any dupes. And there were random reports of dupes earlier and I haven't heard that in awhile.", "positive_passages": [{"docid": "doc-en-vscode-57ee8029513f313f1d2fb20dd5d9d0ad5068769a3846e17765d7cb0966048b2b", "text": "this._register(this._cell.model.onDidChangeOutputs(() => this._updateSoon())); } <ins> public update(): void { this._updateSoon(); } </ins> private _updateSoon(): void { // Wait a tick to make sure that the event is fired to the EH before triggering status bar providers this._register(disposableTimeout(() => {", "commid": "vscode_pr_125811"}], "negative_passages": []}
{"query_id": "q-en-vscode-2f1fba3c2a4748113196c418a144be909f45663ba712680ca406cacfa67d01af", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Basically when i have a statusbar item (extension that contributes statusbar items), VS Code re-creates all of the statusbar items for all cells. This causes ALL statubar items in all cells to flicker (as its destroyed and re-created) & we also end up with duplicates. /cc Flickering UI Duplicate statusbar items See below (from latest VS Code Insiders, can also replicate in latest main branch) Note how we end up with two language pickers in statusbar. ! After the fix (re-use instead of re-creating & only create what we need): !\nThought I had squashed all of these. Thanks for the PR!\nThe power tools don't seem to provide line numbers anymore so I tried switching the language mode around to repro and couldn't so I'm not sure if that's good enough for verification\nI think it's sufficient to mess around with it and not see any dupes. And there were random reports of dupes earlier and I haven't heard that in awhile.", "positive_passages": [{"docid": "doc-en-vscode-97c41061390cb376853acb2a2f0e1c9e8f89d652387183f1f909e2eb365052e5", "text": "override dispose() { super.dispose(); <ins> this._activeToken?.dispose(true); </ins> this._notebookViewModel.deltaCellStatusBarItems(this._currentItemIds, [{ handle: this._cell.handle, items: [] }]); this._currentItemLists.forEach(itemList => itemList.dispose && itemList.dispose());", "commid": "vscode_pr_125811"}], "negative_passages": []}
{"query_id": "q-en-vscode-3c9f4b9c19bd0d1ed688ec35a4d5f6ef0e78fac9c6b301e3b87a768a0f268d33", "query": "Version: 1.58.0-insider Commit: Date: 2021-06-16T05:18:57.982Z Electron: 12.0.11 Chrome: 89.0.4389.128 14.16.0 V8: 8.9.255.25-electron.0 OS: Linux x64 5.11.0-18-generic After starting up VS Code I got a modal dialog telling me about an unusual line delimiter. It didn't tell me about the file this is about. ! After accepting to fix, I saw where the problem was ! I find the dialog too heavy, especially on startup. I would need to see the code to find out what's the issue here. E.g. in our case, this is in a test, so might be intended Maybe have a warning triage next to 'LF' in the status bar? When I click ignore for this file, how can I unignore the file?\nI agree this is pretty weird. The prompt comes from a code editor contribution which executes only when a code editor widget is instantiated and shows the problematic file. I think that this normally works fine, but in this case I believe the problematic file was opened, the dialog was shown, and then the \"Release Notes\" editor opened under the prompt and changed the active editor from under the prompt. I agree with the feedback here, but I'm not sure what to do. Maybe we could make the \"Release Notes\" editor wait until all confirm dialogs have been closed before showing itself or that the workbench starts directly with that editor after a release? Regarding converting this to a passive indicator in the status bar: I don't think that would be wise. Having this unusual line terminator will lead to semantic tokens, jump to definition and all kind of language features to become off. Here is the background:\nMaybe instead of a modal dialog this could be shown somewhere in the editor area? Almost like the trust banner but instead of showing to the top of the window, showing right above the editor but still inside the editor? ! As for release notes, I think we are investigating to move away from using an editor and using something else but I cannot find the issue now. Arguably this can happen in other cases too I guess, e.g. when I open a file which loads slow and I manage to open another editor over it?\nWell, easiest fix is to add the file name into the dialog, I would argue then it doesn't really matter which editor is active.\nPR is up to change the dialog just a bit (): !", "positive_passages": [{"docid": "doc-en-vscode-2173b4f32918bf62f640f20889145e694c8ba428b7c9f3becb79ddb7d3c4bc36", "text": "import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { ITextModel } from 'vs/editor/common/model'; import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; <ins> import { basename } from 'vs/base/common/resources'; </ins> const ignoreUnusualLineTerminators = 'ignoreUnusualLineTerminators';", "commid": "vscode_pr_126650"}], "negative_passages": []}
{"query_id": "q-en-vscode-3c9f4b9c19bd0d1ed688ec35a4d5f6ef0e78fac9c6b301e3b87a768a0f268d33", "query": "Version: 1.58.0-insider Commit: Date: 2021-06-16T05:18:57.982Z Electron: 12.0.11 Chrome: 89.0.4389.128 14.16.0 V8: 8.9.255.25-electron.0 OS: Linux x64 5.11.0-18-generic After starting up VS Code I got a modal dialog telling me about an unusual line delimiter. It didn't tell me about the file this is about. ! After accepting to fix, I saw where the problem was ! I find the dialog too heavy, especially on startup. I would need to see the code to find out what's the issue here. E.g. in our case, this is in a test, so might be intended Maybe have a warning triage next to 'LF' in the status bar? When I click ignore for this file, how can I unignore the file?\nI agree this is pretty weird. The prompt comes from a code editor contribution which executes only when a code editor widget is instantiated and shows the problematic file. I think that this normally works fine, but in this case I believe the problematic file was opened, the dialog was shown, and then the \"Release Notes\" editor opened under the prompt and changed the active editor from under the prompt. I agree with the feedback here, but I'm not sure what to do. Maybe we could make the \"Release Notes\" editor wait until all confirm dialogs have been closed before showing itself or that the workbench starts directly with that editor after a release? Regarding converting this to a passive indicator in the status bar: I don't think that would be wise. Having this unusual line terminator will lead to semantic tokens, jump to definition and all kind of language features to become off. Here is the background:\nMaybe instead of a modal dialog this could be shown somewhere in the editor area? Almost like the trust banner but instead of showing to the top of the window, showing right above the editor but still inside the editor? ! As for release notes, I think we are investigating to move away from using an editor and using something else but I cannot find the issue now. Arguably this can happen in other cases too I guess, e.g. when I open a file which loads slow and I manage to open another editor over it?\nWell, easiest fix is to add the file name into the dialog, I would argue then it doesn't really matter which editor is active.\nPR is up to change the dialog just a bit (): !", "positive_passages": [{"docid": "doc-en-vscode-526542d6375fd6e3509de4c68cefe2bd9e400d51205c52495c1cecca24b57114", "text": "const result = await this._dialogService.confirm({ title: nls.localize('unusualLineTerminators.title', \"Unusual Line Terminators\"), message: nls.localize('unusualLineTerminators.message', \"Detected unusual line terminators\"), <del> detail: nls.localize('unusualLineTerminators.detail', \"This file contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.\"), primaryButton: nls.localize('unusualLineTerminators.fix', \"Fix this file\"), secondaryButton: nls.localize('unusualLineTerminators.ignore', \"Ignore problem for this file\") </del> <ins> detail: nls.localize('unusualLineTerminators.detail', \"The file '{0}' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.\", basename(model.uri)), primaryButton: nls.localize('unusualLineTerminators.fix', \"Remove Unusual Line Terminators\"), secondaryButton: nls.localize('unusualLineTerminators.ignore', \"Ignore\") </ins> }); if (!result.confirmed) {", "commid": "vscode_pr_126650"}], "negative_passages": []}
{"query_id": "q-en-vscode-b00afb299877fd218ce9e2286bafdb35d9e70ccb66e562ef2bd54f703ba96320", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The comments API doesn't have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It's very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways: In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: ! In the Comments panel, highlight the unresolved comments (or put them in bold), so that it's obvious to the user what comments they still have to go through. In the Comments panel, have a way to hide/filter the resolved comments. In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle. In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color). In the Editor, provide a way to go to the next unresolved comment (an alternative to ).\nLet's discuss the API change. IMO, the information should be part of a . On many levels, Comments seem similar to s. A diagnostic is a comment provided by a tool such as a compiler. A comment is typically provided by a human. Diagnostics have a severity field, which indicates how important is the problem. We need an equivalent for Comments, something that tells the user if an action is expected (e.g. they need to resolve it) or not. Once the user addresses the comment, the importance is reduced. simplistic solution is to add a boolean, e.g. . to , we can go for a two-state enum instead: to be more general: . We might consider having more fields here. In a code review, multiple users interact with the comments. The current VSCode user is not necessarily the person who needs to do something. For example, the user has just updated the comment and they wait for a response. So the third value could be used to mean \"it's not my turn\" or \"acknowledged, I'll come back later\". The benefit is that the user can use the list of \"unresolved\" issues as a TODO-list and publish the comments once it's empty.\nThank you very much for your proposal. and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.\nAll of the proposals in have merit. In a perfect world I would choose one of options 2 or 4; however, we have users of the comments API who's comments don't have a resolved/unresolved state. Option 3 circumvents that, but then we have the issue of what to show in the UI: a GitHub PR comment isn't high or low priority. Another proposal, similar to how comment reactions work:\nI see than left comments on the commit (). I like the approach of having an object for the state (instead of the proposed boolean/enum), it gives more flexibility and lets user create their own states. In my proposal, the information was attached to a thread, not to a single comment. Do we have use-cases where we want this information per comment? We might also want to control the gutter icon:\nGitHub comments are resolved per-thread, so no, no cases were we want it per comment. I'll move it to the thread.\nAfter much discussion, we have decided to proceed with the following: The main reasoning behind this is that resolved vs. unresolved comments should look the same to the user across a GitHub PR extension, an Azure Dev Ops PR extensions, and any other PR extension. There original concern around using \"resolved\" and \"unresolved\" is that maybe not all comment provider have those states (maybe they have \"viewed\" and \"unviewed\" states for example). To alleviate this, we'll see if we can avoid using \"resolved\"/\"unresolved\" language in the UI. If additional states are needed later, we can always add more to the API.\nI have a basic implementation of this working, with and themable colors. Before I finish up the pull request to send it out, I was wondering what the best practice is for providing defaults for these colors? In the mocks from we use a yellow for unresolved comments that is inspired by visuals of our internal tool. I am not sure if they match an established VS Code palette.\nawesome, looking forward to reviewing it! Generally, we try to avoid introducing a new color entirely for something like this. The best practice would be to look through the existing color values where we use yellow then use the same yellow, just like is done here where uses the same color as : We'll also do a UX review of this, so the color may end up changing anyway.\nI went for new colors as the comments are conceptually something different than e.g. editor warnings. Currently the comments in the editor use (default blue), so a theme, an extension, or the users themselves would not be able to style comments independently of peek views. I think it makes sense to base the default on another color like as in your example, so that themes which omit the new colors receive a reasonable default, but it seems like we would give up a lot of flexibility and also clarity if comment widget colors directly used something like internally?\nYes, basing the color on another is what I meant! I agree that we don't want to directly use another theme color.\nIf anyone is eager for this API to be finalized then please comment and let me know how it's working for you. Otherwise, I will plan to finalize later in 2022.\nThis would be very nice to have. We are using Github and especially larger PRs are hard to manage, if there are many comments (in Github as well as in VSCode)\nSo is there currently a way to filter resolved/unresolved comments in the sidebar? If not what can I modify currently to provide a visual distinction between resolved/unresolved?\nthere's a color difference on the icon, but that's currently it. This is the feature request you're looking for", "positive_passages": [{"docid": "doc-en-vscode-0f7744111ec32ac745200d0e49c4d3b8ac69f99a2c77780830ec24d6d8eb67aa", "text": "import { ExtHostDocuments } from 'vs/workbench/api/common/extHostDocuments'; import * as extHostTypeConverter from 'vs/workbench/api/common/extHostTypeConverters'; import * as types from 'vs/workbench/api/common/extHostTypes'; <del> import { checkProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; </del> import type * as vscode from 'vscode'; import { ExtHostCommentsShape, IMainContext, MainContext, CommentThreadChanges, CommentChanges } from './extHost.protocol'; import { ExtHostCommands } from './extHostCommands';", "commid": "vscode_pr_171068"}], "negative_passages": []}
{"query_id": "q-en-vscode-b00afb299877fd218ce9e2286bafdb35d9e70ccb66e562ef2bd54f703ba96320", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The comments API doesn't have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It's very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways: In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: ! In the Comments panel, highlight the unresolved comments (or put them in bold), so that it's obvious to the user what comments they still have to go through. In the Comments panel, have a way to hide/filter the resolved comments. In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle. In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color). In the Editor, provide a way to go to the next unresolved comment (an alternative to ).\nLet's discuss the API change. IMO, the information should be part of a . On many levels, Comments seem similar to s. A diagnostic is a comment provided by a tool such as a compiler. A comment is typically provided by a human. Diagnostics have a severity field, which indicates how important is the problem. We need an equivalent for Comments, something that tells the user if an action is expected (e.g. they need to resolve it) or not. Once the user addresses the comment, the importance is reduced. simplistic solution is to add a boolean, e.g. . to , we can go for a two-state enum instead: to be more general: . We might consider having more fields here. In a code review, multiple users interact with the comments. The current VSCode user is not necessarily the person who needs to do something. For example, the user has just updated the comment and they wait for a response. So the third value could be used to mean \"it's not my turn\" or \"acknowledged, I'll come back later\". The benefit is that the user can use the list of \"unresolved\" issues as a TODO-list and publish the comments once it's empty.\nThank you very much for your proposal. and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.\nAll of the proposals in have merit. In a perfect world I would choose one of options 2 or 4; however, we have users of the comments API who's comments don't have a resolved/unresolved state. Option 3 circumvents that, but then we have the issue of what to show in the UI: a GitHub PR comment isn't high or low priority. Another proposal, similar to how comment reactions work:\nI see than left comments on the commit (). I like the approach of having an object for the state (instead of the proposed boolean/enum), it gives more flexibility and lets user create their own states. In my proposal, the information was attached to a thread, not to a single comment. Do we have use-cases where we want this information per comment? We might also want to control the gutter icon:\nGitHub comments are resolved per-thread, so no, no cases were we want it per comment. I'll move it to the thread.\nAfter much discussion, we have decided to proceed with the following: The main reasoning behind this is that resolved vs. unresolved comments should look the same to the user across a GitHub PR extension, an Azure Dev Ops PR extensions, and any other PR extension. There original concern around using \"resolved\" and \"unresolved\" is that maybe not all comment provider have those states (maybe they have \"viewed\" and \"unviewed\" states for example). To alleviate this, we'll see if we can avoid using \"resolved\"/\"unresolved\" language in the UI. If additional states are needed later, we can always add more to the API.\nI have a basic implementation of this working, with and themable colors. Before I finish up the pull request to send it out, I was wondering what the best practice is for providing defaults for these colors? In the mocks from we use a yellow for unresolved comments that is inspired by visuals of our internal tool. I am not sure if they match an established VS Code palette.\nawesome, looking forward to reviewing it! Generally, we try to avoid introducing a new color entirely for something like this. The best practice would be to look through the existing color values where we use yellow then use the same yellow, just like is done here where uses the same color as : We'll also do a UX review of this, so the color may end up changing anyway.\nI went for new colors as the comments are conceptually something different than e.g. editor warnings. Currently the comments in the editor use (default blue), so a theme, an extension, or the users themselves would not be able to style comments independently of peek views. I think it makes sense to base the default on another color like as in your example, so that themes which omit the new colors receive a reasonable default, but it seems like we would give up a lot of flexibility and also clarity if comment widget colors directly used something like internally?\nYes, basing the color on another is what I meant! I agree that we don't want to directly use another theme color.\nIf anyone is eager for this API to be finalized then please comment and let me know how it's working for you. Otherwise, I will plan to finalize later in 2022.\nThis would be very nice to have. We are using Github and especially larger PRs are hard to manage, if there are many comments (in Github as well as in VSCode)\nSo is there currently a way to filter resolved/unresolved comments in the sidebar? If not what can I modify currently to provide a visual distinction between resolved/unresolved?\nthere's a color difference on the icon, but that's currently it. This is the feature request you're looking for", "positive_passages": [{"docid": "doc-en-vscode-d5d0d6e5d28f62bf69a3e079767722d25a8ea8295e39676d9da46e02a82cba12", "text": "private _state?: vscode.CommentThreadState; get state(): vscode.CommentThreadState { <del> checkProposedApiEnabled(this.extensionDescription, 'commentsResolvedState'); </del> return this._state!; } set state(newState: vscode.CommentThreadState) { <del> checkProposedApiEnabled(this.extensionDescription, 'commentsResolvedState'); </del> this._state = newState; this.modifications.state = newState; this._onDidUpdateCommentThread.fire();", "commid": "vscode_pr_171068"}], "negative_passages": []}
{"query_id": "q-en-vscode-b00afb299877fd218ce9e2286bafdb35d9e70ccb66e562ef2bd54f703ba96320", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The comments API doesn't have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It's very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways: In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: ! In the Comments panel, highlight the unresolved comments (or put them in bold), so that it's obvious to the user what comments they still have to go through. In the Comments panel, have a way to hide/filter the resolved comments. In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle. In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color). In the Editor, provide a way to go to the next unresolved comment (an alternative to ).\nLet's discuss the API change. IMO, the information should be part of a . On many levels, Comments seem similar to s. A diagnostic is a comment provided by a tool such as a compiler. A comment is typically provided by a human. Diagnostics have a severity field, which indicates how important is the problem. We need an equivalent for Comments, something that tells the user if an action is expected (e.g. they need to resolve it) or not. Once the user addresses the comment, the importance is reduced. simplistic solution is to add a boolean, e.g. . to , we can go for a two-state enum instead: to be more general: . We might consider having more fields here. In a code review, multiple users interact with the comments. The current VSCode user is not necessarily the person who needs to do something. For example, the user has just updated the comment and they wait for a response. So the third value could be used to mean \"it's not my turn\" or \"acknowledged, I'll come back later\". The benefit is that the user can use the list of \"unresolved\" issues as a TODO-list and publish the comments once it's empty.\nThank you very much for your proposal. and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.\nAll of the proposals in have merit. In a perfect world I would choose one of options 2 or 4; however, we have users of the comments API who's comments don't have a resolved/unresolved state. Option 3 circumvents that, but then we have the issue of what to show in the UI: a GitHub PR comment isn't high or low priority. Another proposal, similar to how comment reactions work:\nI see than left comments on the commit (). I like the approach of having an object for the state (instead of the proposed boolean/enum), it gives more flexibility and lets user create their own states. In my proposal, the information was attached to a thread, not to a single comment. Do we have use-cases where we want this information per comment? We might also want to control the gutter icon:\nGitHub comments are resolved per-thread, so no, no cases were we want it per comment. I'll move it to the thread.\nAfter much discussion, we have decided to proceed with the following: The main reasoning behind this is that resolved vs. unresolved comments should look the same to the user across a GitHub PR extension, an Azure Dev Ops PR extensions, and any other PR extension. There original concern around using \"resolved\" and \"unresolved\" is that maybe not all comment provider have those states (maybe they have \"viewed\" and \"unviewed\" states for example). To alleviate this, we'll see if we can avoid using \"resolved\"/\"unresolved\" language in the UI. If additional states are needed later, we can always add more to the API.\nI have a basic implementation of this working, with and themable colors. Before I finish up the pull request to send it out, I was wondering what the best practice is for providing defaults for these colors? In the mocks from we use a yellow for unresolved comments that is inspired by visuals of our internal tool. I am not sure if they match an established VS Code palette.\nawesome, looking forward to reviewing it! Generally, we try to avoid introducing a new color entirely for something like this. The best practice would be to look through the existing color values where we use yellow then use the same yellow, just like is done here where uses the same color as : We'll also do a UX review of this, so the color may end up changing anyway.\nI went for new colors as the comments are conceptually something different than e.g. editor warnings. Currently the comments in the editor use (default blue), so a theme, an extension, or the users themselves would not be able to style comments independently of peek views. I think it makes sense to base the default on another color like as in your example, so that themes which omit the new colors receive a reasonable default, but it seems like we would give up a lot of flexibility and also clarity if comment widget colors directly used something like internally?\nYes, basing the color on another is what I meant! I agree that we don't want to directly use another theme color.\nIf anyone is eager for this API to be finalized then please comment and let me know how it's working for you. Otherwise, I will plan to finalize later in 2022.\nThis would be very nice to have. We are using Github and especially larger PRs are hard to manage, if there are many comments (in Github as well as in VSCode)\nSo is there currently a way to filter resolved/unresolved comments in the sidebar? If not what can I modify currently to provide a visual distinction between resolved/unresolved?\nthere's a color difference on the icon, but that's currently it. This is the feature request you're looking for", "positive_passages": [{"docid": "doc-en-vscode-9767618989df8eb7db4b7a2bf5b4405d019ba8a9baaf43ada276c12801db7892", "text": "export const allApiProposals = Object.freeze({ authSession: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.authSession.d.ts', codiconDecoration: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.codiconDecoration.d.ts', <del> commentsResolvedState: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.commentsResolvedState.d.ts', </del> contribCommentEditorActionsMenu: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribCommentEditorActionsMenu.d.ts', contribCommentPeekContext: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribCommentPeekContext.d.ts', contribCommentThreadAdditionalMenu: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribCommentThreadAdditionalMenu.d.ts',", "commid": "vscode_pr_171068"}], "negative_passages": []}
{"query_id": "q-en-vscode-b00afb299877fd218ce9e2286bafdb35d9e70ccb66e562ef2bd54f703ba96320", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The comments API doesn't have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It's very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways: In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: ! In the Comments panel, highlight the unresolved comments (or put them in bold), so that it's obvious to the user what comments they still have to go through. In the Comments panel, have a way to hide/filter the resolved comments. In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle. In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color). In the Editor, provide a way to go to the next unresolved comment (an alternative to ).\nLet's discuss the API change. IMO, the information should be part of a . On many levels, Comments seem similar to s. A diagnostic is a comment provided by a tool such as a compiler. A comment is typically provided by a human. Diagnostics have a severity field, which indicates how important is the problem. We need an equivalent for Comments, something that tells the user if an action is expected (e.g. they need to resolve it) or not. Once the user addresses the comment, the importance is reduced. simplistic solution is to add a boolean, e.g. . to , we can go for a two-state enum instead: to be more general: . We might consider having more fields here. In a code review, multiple users interact with the comments. The current VSCode user is not necessarily the person who needs to do something. For example, the user has just updated the comment and they wait for a response. So the third value could be used to mean \"it's not my turn\" or \"acknowledged, I'll come back later\". The benefit is that the user can use the list of \"unresolved\" issues as a TODO-list and publish the comments once it's empty.\nThank you very much for your proposal. and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.\nAll of the proposals in have merit. In a perfect world I would choose one of options 2 or 4; however, we have users of the comments API who's comments don't have a resolved/unresolved state. Option 3 circumvents that, but then we have the issue of what to show in the UI: a GitHub PR comment isn't high or low priority. Another proposal, similar to how comment reactions work:\nI see than left comments on the commit (). I like the approach of having an object for the state (instead of the proposed boolean/enum), it gives more flexibility and lets user create their own states. In my proposal, the information was attached to a thread, not to a single comment. Do we have use-cases where we want this information per comment? We might also want to control the gutter icon:\nGitHub comments are resolved per-thread, so no, no cases were we want it per comment. I'll move it to the thread.\nAfter much discussion, we have decided to proceed with the following: The main reasoning behind this is that resolved vs. unresolved comments should look the same to the user across a GitHub PR extension, an Azure Dev Ops PR extensions, and any other PR extension. There original concern around using \"resolved\" and \"unresolved\" is that maybe not all comment provider have those states (maybe they have \"viewed\" and \"unviewed\" states for example). To alleviate this, we'll see if we can avoid using \"resolved\"/\"unresolved\" language in the UI. If additional states are needed later, we can always add more to the API.\nI have a basic implementation of this working, with and themable colors. Before I finish up the pull request to send it out, I was wondering what the best practice is for providing defaults for these colors? In the mocks from we use a yellow for unresolved comments that is inspired by visuals of our internal tool. I am not sure if they match an established VS Code palette.\nawesome, looking forward to reviewing it! Generally, we try to avoid introducing a new color entirely for something like this. The best practice would be to look through the existing color values where we use yellow then use the same yellow, just like is done here where uses the same color as : We'll also do a UX review of this, so the color may end up changing anyway.\nI went for new colors as the comments are conceptually something different than e.g. editor warnings. Currently the comments in the editor use (default blue), so a theme, an extension, or the users themselves would not be able to style comments independently of peek views. I think it makes sense to base the default on another color like as in your example, so that themes which omit the new colors receive a reasonable default, but it seems like we would give up a lot of flexibility and also clarity if comment widget colors directly used something like internally?\nYes, basing the color on another is what I meant! I agree that we don't want to directly use another theme color.\nIf anyone is eager for this API to be finalized then please comment and let me know how it's working for you. Otherwise, I will plan to finalize later in 2022.\nThis would be very nice to have. We are using Github and especially larger PRs are hard to manage, if there are many comments (in Github as well as in VSCode)\nSo is there currently a way to filter resolved/unresolved comments in the sidebar? If not what can I modify currently to provide a visual distinction between resolved/unresolved?\nthere's a color difference on the icon, but that's currently it. This is the feature request you're looking for", "positive_passages": [{"docid": "doc-en-vscode-e211fbd32416757e495c74ca1f223b98a00b7e9b058819e2314fea32d5e49c41", "text": "} /** <ins> * The state of a comment thread. */ export enum CommentThreadState { Unresolved = 0, Resolved = 1 } /** </ins> * A collection of {@link Comment comments} representing a conversation at a particular range in a document. */ export interface CommentThread {", "commid": "vscode_pr_171068"}], "negative_passages": []}
{"query_id": "q-en-vscode-b00afb299877fd218ce9e2286bafdb35d9e70ccb66e562ef2bd54f703ba96320", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The comments API doesn't have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It's very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways: In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: ! In the Comments panel, highlight the unresolved comments (or put them in bold), so that it's obvious to the user what comments they still have to go through. In the Comments panel, have a way to hide/filter the resolved comments. In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle. In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color). In the Editor, provide a way to go to the next unresolved comment (an alternative to ).\nLet's discuss the API change. IMO, the information should be part of a . On many levels, Comments seem similar to s. A diagnostic is a comment provided by a tool such as a compiler. A comment is typically provided by a human. Diagnostics have a severity field, which indicates how important is the problem. We need an equivalent for Comments, something that tells the user if an action is expected (e.g. they need to resolve it) or not. Once the user addresses the comment, the importance is reduced. simplistic solution is to add a boolean, e.g. . to , we can go for a two-state enum instead: to be more general: . We might consider having more fields here. In a code review, multiple users interact with the comments. The current VSCode user is not necessarily the person who needs to do something. For example, the user has just updated the comment and they wait for a response. So the third value could be used to mean \"it's not my turn\" or \"acknowledged, I'll come back later\". The benefit is that the user can use the list of \"unresolved\" issues as a TODO-list and publish the comments once it's empty.\nThank you very much for your proposal. and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.\nAll of the proposals in have merit. In a perfect world I would choose one of options 2 or 4; however, we have users of the comments API who's comments don't have a resolved/unresolved state. Option 3 circumvents that, but then we have the issue of what to show in the UI: a GitHub PR comment isn't high or low priority. Another proposal, similar to how comment reactions work:\nI see than left comments on the commit (). I like the approach of having an object for the state (instead of the proposed boolean/enum), it gives more flexibility and lets user create their own states. In my proposal, the information was attached to a thread, not to a single comment. Do we have use-cases where we want this information per comment? We might also want to control the gutter icon:\nGitHub comments are resolved per-thread, so no, no cases were we want it per comment. I'll move it to the thread.\nAfter much discussion, we have decided to proceed with the following: The main reasoning behind this is that resolved vs. unresolved comments should look the same to the user across a GitHub PR extension, an Azure Dev Ops PR extensions, and any other PR extension. There original concern around using \"resolved\" and \"unresolved\" is that maybe not all comment provider have those states (maybe they have \"viewed\" and \"unviewed\" states for example). To alleviate this, we'll see if we can avoid using \"resolved\"/\"unresolved\" language in the UI. If additional states are needed later, we can always add more to the API.\nI have a basic implementation of this working, with and themable colors. Before I finish up the pull request to send it out, I was wondering what the best practice is for providing defaults for these colors? In the mocks from we use a yellow for unresolved comments that is inspired by visuals of our internal tool. I am not sure if they match an established VS Code palette.\nawesome, looking forward to reviewing it! Generally, we try to avoid introducing a new color entirely for something like this. The best practice would be to look through the existing color values where we use yellow then use the same yellow, just like is done here where uses the same color as : We'll also do a UX review of this, so the color may end up changing anyway.\nI went for new colors as the comments are conceptually something different than e.g. editor warnings. Currently the comments in the editor use (default blue), so a theme, an extension, or the users themselves would not be able to style comments independently of peek views. I think it makes sense to base the default on another color like as in your example, so that themes which omit the new colors receive a reasonable default, but it seems like we would give up a lot of flexibility and also clarity if comment widget colors directly used something like internally?\nYes, basing the color on another is what I meant! I agree that we don't want to directly use another theme color.\nIf anyone is eager for this API to be finalized then please comment and let me know how it's working for you. Otherwise, I will plan to finalize later in 2022.\nThis would be very nice to have. We are using Github and especially larger PRs are hard to manage, if there are many comments (in Github as well as in VSCode)\nSo is there currently a way to filter resolved/unresolved comments in the sidebar? If not what can I modify currently to provide a visual distinction between resolved/unresolved?\nthere's a color difference on the icon, but that's currently it. This is the feature request you're looking for", "positive_passages": [{"docid": "doc-en-vscode-8ed41996c31606d89abd9d0087660ccdcfe91e31eae96bf61c5f38bc5f8a2e87", "text": "label?: string; /** <ins> * The optional state of a comment thread, which may affect how the comment is displayed. */ state?: CommentThreadState; /** </ins> * Dispose this comment thread. * * Once disposed, this comment thread will be removed from visible editors and Comment Panel when appropriate.", "commid": "vscode_pr_171068"}], "negative_passages": []}
{"query_id": "q-en-vscode-b00afb299877fd218ce9e2286bafdb35d9e70ccb66e562ef2bd54f703ba96320", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The comments API doesn't have the concept of resolved/unresolved threads, although most code review tools distinguish them. The current API allows us to surface this to the users, see However, this seems pretty limited. I find it difficult to identify all my unresolved comments. It's very easy to miss some of them. If the API had a boolean for unresolved comments, we could surface them in multiple ways: In the Comments panel, surface the number of unresolved comments, similar to what is done with Problems: ! In the Comments panel, highlight the unresolved comments (or put them in bold), so that it's obvious to the user what comments they still have to go through. In the Comments panel, have a way to hide/filter the resolved comments. In the Editor, consider consider using a different background color for unresolved comments. I currently use a different label for unresolved comments, but this is very subtle. In the gutter, use a different symbol for unresolved comments (e.g. or a diamond of another color). In the Editor, provide a way to go to the next unresolved comment (an alternative to ).\nLet's discuss the API change. IMO, the information should be part of a . On many levels, Comments seem similar to s. A diagnostic is a comment provided by a tool such as a compiler. A comment is typically provided by a human. Diagnostics have a severity field, which indicates how important is the problem. We need an equivalent for Comments, something that tells the user if an action is expected (e.g. they need to resolve it) or not. Once the user addresses the comment, the importance is reduced. simplistic solution is to add a boolean, e.g. . to , we can go for a two-state enum instead: to be more general: . We might consider having more fields here. In a code review, multiple users interact with the comments. The current VSCode user is not necessarily the person who needs to do something. For example, the user has just updated the comment and they wait for a response. So the third value could be used to mean \"it's not my turn\" or \"acknowledged, I'll come back later\". The benefit is that the user can use the list of \"unresolved\" issues as a TODO-list and publish the comments once it's empty.\nThank you very much for your proposal. and me have quickly discussed this and we believe this proposal makes good sense. We plan to start looking into it next milestone. Though no promises yet when this will land, we will know more in December when we start our investigation.\nAll of the proposals in have merit. In a perfect world I would choose one of options 2 or 4; however, we have users of the comments API who's comments don't have a resolved/unresolved state. Option 3 circumvents that, but then we have the issue of what to show in the UI: a GitHub PR comment isn't high or low priority. Another proposal, similar to how comment reactions work:\nI see than left comments on the commit (). I like the approach of having an object for the state (instead of the proposed boolean/enum), it gives more flexibility and lets user create their own states. In my proposal, the information was attached to a thread, not to a single comment. Do we have use-cases where we want this information per comment? We might also want to control the gutter icon:\nGitHub comments are resolved per-thread, so no, no cases were we want it per comment. I'll move it to the thread.\nAfter much discussion, we have decided to proceed with the following: The main reasoning behind this is that resolved vs. unresolved comments should look the same to the user across a GitHub PR extension, an Azure Dev Ops PR extensions, and any other PR extension. There original concern around using \"resolved\" and \"unresolved\" is that maybe not all comment provider have those states (maybe they have \"viewed\" and \"unviewed\" states for example). To alleviate this, we'll see if we can avoid using \"resolved\"/\"unresolved\" language in the UI. If additional states are needed later, we can always add more to the API.\nI have a basic implementation of this working, with and themable colors. Before I finish up the pull request to send it out, I was wondering what the best practice is for providing defaults for these colors? In the mocks from we use a yellow for unresolved comments that is inspired by visuals of our internal tool. I am not sure if they match an established VS Code palette.\nawesome, looking forward to reviewing it! Generally, we try to avoid introducing a new color entirely for something like this. The best practice would be to look through the existing color values where we use yellow then use the same yellow, just like is done here where uses the same color as : We'll also do a UX review of this, so the color may end up changing anyway.\nI went for new colors as the comments are conceptually something different than e.g. editor warnings. Currently the comments in the editor use (default blue), so a theme, an extension, or the users themselves would not be able to style comments independently of peek views. I think it makes sense to base the default on another color like as in your example, so that themes which omit the new colors receive a reasonable default, but it seems like we would give up a lot of flexibility and also clarity if comment widget colors directly used something like internally?\nYes, basing the color on another is what I meant! I agree that we don't want to directly use another theme color.\nIf anyone is eager for this API to be finalized then please comment and let me know how it's working for you. Otherwise, I will plan to finalize later in 2022.\nThis would be very nice to have. We are using Github and especially larger PRs are hard to manage, if there are many comments (in Github as well as in VSCode)\nSo is there currently a way to filter resolved/unresolved comments in the sidebar? If not what can I modify currently to provide a visual distinction between resolved/unresolved?\nthere's a color difference on the icon, but that's currently it. This is the feature request you're looking for", "positive_passages": [{"docid": "doc-en-vscode-cfad4513858c3c355cd2703263af128cbff813d8d45c8cb701d068a837948de4", "text": "<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'vscode' { // https://github.com/microsoft/vscode/issues/127473 /** * The state of a comment thread. */ export enum CommentThreadState { Unresolved = 0, Resolved = 1 } export interface CommentThread { /** * The optional state of a comment thread, which may affect how the comment is displayed. */ state?: CommentThreadState; } } </del>", "commid": "vscode_pr_171068"}], "negative_passages": []}
{"query_id": "q-en-vscode-372c921c8a1c4c34e84800215c2b9edada7e37d254f890c153e876b402cf3de2", "query": "According to the documentation, if calling show(true), the terminal will be made visible but it won't capture the keyboard focus. I also remember in the past this worked. For some months already I noticed that regardless of how I call show, the focus is always taken. Anything changed? Is there already an issue that you tracking for this? Am I doing anything wrong? Related to this, if we won't manage to fix this behavior, how can we make key bindings for commands to be recognized even when the terminal has the focus? For example, when having focus in the terminal, if I press F5 debugging will start. The terminal will not try to write something for \"F5\". But if I run another key combination that I defined for some extension command, the terminal will react to the key combination (will try to write something) and the command will not be triggered (unless focus is somewhere else). We have this issue in the CMake Tools repository and the user would be happy if we fix this problem either way.\nHey, I would like to work on this issue. Could you give me any pointers? Where should I start?\nthis one's a little involved as it needs an extension to trigger the issue, you'd be better off finding an issue with the help wanted label.\nOkay, thanks!\nTried this in an extension after making sure I had a terminal open: And the focus moved into the terminal.\ndid you have focus in the terminal before running that? preserve focus returns the focus to whatever was focused before. I'm unable to reproduce the problem using the exact code you mention above. Could you please include a gif? !\n!", "positive_passages": [{"docid": "doc-en-vscode-ab232485014b80355477aa850a8d45a0fe042b499c2061254c0f8ff03126c3db", "text": "} else { this._onDidChangeViewWelcomeState.fire(); } <del> if (!this._terminalService.activeInstance?.shellLaunchConfig.extHostTerminalId) { // showPanel is already called with !preserveFocus // when extension host terminals are created this._terminalGroupService.showPanel(true); } </del> <ins> // we don't know here whether or not it should be focused, so // defer focusing the panel to the focus() call // to prevent overriding preserveFocus for extensions this._terminalGroupService.showPanel(false); </ins> if (hadTerminals) { this._terminalGroupService.activeGroup?.setVisible(visible); }", "commid": "vscode_pr_138419"}], "negative_passages": []}
{"query_id": "q-en-vscode-372c921c8a1c4c34e84800215c2b9edada7e37d254f890c153e876b402cf3de2", "query": "According to the documentation, if calling show(true), the terminal will be made visible but it won't capture the keyboard focus. I also remember in the past this worked. For some months already I noticed that regardless of how I call show, the focus is always taken. Anything changed? Is there already an issue that you tracking for this? Am I doing anything wrong? Related to this, if we won't manage to fix this behavior, how can we make key bindings for commands to be recognized even when the terminal has the focus? For example, when having focus in the terminal, if I press F5 debugging will start. The terminal will not try to write something for \"F5\". But if I run another key combination that I defined for some extension command, the terminal will react to the key combination (will try to write something) and the command will not be triggered (unless focus is somewhere else). We have this issue in the CMake Tools repository and the user would be happy if we fix this problem either way.\nHey, I would like to work on this issue. Could you give me any pointers? Where should I start?\nthis one's a little involved as it needs an extension to trigger the issue, you'd be better off finding an issue with the help wanted label.\nOkay, thanks!\nTried this in an extension after making sure I had a terminal open: And the focus moved into the terminal.\ndid you have focus in the terminal before running that? preserve focus returns the focus to whatever was focused before. I'm unable to reproduce the problem using the exact code you mention above. Could you please include a gif? !\n!", "positive_passages": [{"docid": "doc-en-vscode-b7b7ba26ce529097207afeebbd32a545f085002ff97d030a237627f97e57c383", "text": "// Only focus the terminal if the activeElement has not changed since focus() was called // TODO hack if (document.activeElement === activeElement) { <del> this._focus(); </del> <ins> this._terminalGroupService.showPanel(true); </ins> } })); return; } <del> this._focus(); } private _focus() { this._terminalService.activeInstance?.focusWhenReady(); </del> <ins> this._terminalGroupService.showPanel(true); </ins> } override shouldShowWelcome(): boolean {", "commid": "vscode_pr_138419"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c304ccf8b4d6718dd269aa75efaa6678785255d4f24578ef7ef4bb2873e5e91", "query": "In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.\nTo verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says\nThe remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .", "positive_passages": [{"docid": "doc-en-vscode-c1c45fc5f2ee2fdb0edc03dcc1da3e14ac465899ce61607dadc8083923b909f2", "text": "globalStorageHome: URI; workspaceStorageHome: URI; useHostProxy?: boolean; <ins> skipWorkspaceStorageLock?: boolean; </ins> } export interface IStaticWorkspaceData {", "commid": "vscode_pr_128541"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c304ccf8b4d6718dd269aa75efaa6678785255d4f24578ef7ef4bb2873e5e91", "query": "In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.\nTo verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says\nThe remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .", "positive_passages": [{"docid": "doc-en-vscode-103708b467ed3a365ba4baf90934c97f322ab1e5cce0e5f639fe69b8922def24", "text": "return workspaceStorageURI; } <ins> if (this._environment.skipWorkspaceStorageLock) { this._logService.info(`Skipping acquiring lock for ${workspaceStorageURI.fsPath}.`); return workspaceStorageURI; } </ins> const workspaceStorageBase = workspaceStorageURI.fsPath; let attempt = 0; do {", "commid": "vscode_pr_128541"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c304ccf8b4d6718dd269aa75efaa6678785255d4f24578ef7ef4bb2873e5e91", "query": "In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.\nTo verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says\nThe remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .", "positive_passages": [{"docid": "doc-en-vscode-5db20d3f1d049b3e525fcc955c2367ec7c31a3ea7707614ec021ef77f3340aea", "text": "} // Run Extension Host as fork of current process <del> this._extensionHostProcess = fork(FileAccess.asFileUri('bootstrap-fork', require).fsPath, ['--type=extensionHost'], opts); </del> <ins> this._extensionHostProcess = fork(FileAccess.asFileUri('bootstrap-fork', require).fsPath, ['--type=extensionHost', '--skipWorkspaceStorageLock'], opts); </ins> // Catch all output coming from the extension host process type Output = { data: string, format: string[] };", "commid": "vscode_pr_128541"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c304ccf8b4d6718dd269aa75efaa6678785255d4f24578ef7ef4bb2873e5e91", "query": "In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.\nTo verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says\nThe remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .", "positive_passages": [{"docid": "doc-en-vscode-c69815ea1d23f6bffc7218cca544bcc93c0ec89409d98138303802556df831dc", "text": "import { realpath } from 'vs/base/node/extpath'; import { IHostUtils } from 'vs/workbench/api/common/extHostExtensionService'; import { RunOnceScheduler } from 'vs/base/common/async'; <ins> import { boolean } from 'vs/editor/common/config/editorOptions'; </ins> import 'vs/workbench/api/common/extHost.common.services'; import 'vs/workbench/api/node/extHost.node.services'; interface ParsedExtHostArgs { uriTransformerPath?: string; <ins> skipWorkspaceStorageLock?: boolean; </ins> useHostProxy?: string; }", "commid": "vscode_pr_128541"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c304ccf8b4d6718dd269aa75efaa6678785255d4f24578ef7ef4bb2873e5e91", "query": "In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.\nTo verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says\nThe remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .", "positive_passages": [{"docid": "doc-en-vscode-7e4d47ba0410eb4f1802696795afa14aff4ac50b4701eaddbd66dae86ba23acf", "text": "string: [ 'uriTransformerPath', 'useHostProxy' <ins> ], boolean: [ 'skipWorkspaceStorageLock' </ins> ] }) as ParsedExtHostArgs;", "commid": "vscode_pr_128541"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c304ccf8b4d6718dd269aa75efaa6678785255d4f24578ef7ef4bb2873e5e91", "query": "In some cases, when the extension host is unresponsive, a window reload can lead to the new extension host process not being able to acquire the lock for workspace storage, since it is still held on by the old (unresponsive) extension host process (). There are even greater concerns that the current way to resolve lock contention (i.e. generating a fresh workspace storage folder e.g. ) is problematic if extensions store very important data in these folders. e.g. suppose a lock cannot be acquired, the workspace storage folder is changed to , the extension writes very important data to , VS Code is closed and reopened the next day, when the extension will end up using as the workspace storage folder, missing out on the data written in (). As a low-risk band-aid, we can limit the acquiring of locks to only the remote extension host, where we have initially observed problems with multiple extension hosts sharing a single workspace storage folder, bringing the local extension host behavior back to what it was in 1.57.x and in the past.\nTo verify: open a remote window. look at the local extension host log and check that it says look at the remote extension host log and check that it says\nThe remote extension host log does not say , but instead . I guess that counts too. The local extension host reads .", "positive_passages": [{"docid": "doc-en-vscode-bb23b36570613b8765a53e81a14527fdf09e3b946b651aaef55cb148eb8a9d65", "text": "// setup things patchProcess(!!initData.environment.extensionTestsLocationURI); // to support other test frameworks like Jasmin that use process.exit (https://github.com/microsoft/vscode/issues/37708) initData.environment.useHostProxy = args.useHostProxy !== undefined ? args.useHostProxy !== 'false' : undefined; <ins> initData.environment.skipWorkspaceStorageLock = boolean(args.skipWorkspaceStorageLock, false); </ins> // host abstraction const hostUtils = new class NodeHost implements IHostUtils {", "commid": "vscode_pr_128541"}], "negative_passages": []}
{"query_id": "q-en-vscode-d211de706cf7a8ef5185cd6e2300d13ed03ad47a83c5a7498c328ee98f168761", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Code-OSS OS Version: Windows 10 Steps to Reproduce: IW from codelens IW is initially not pinned, and becomes pinned after the NotebookDocument is modified (e.g. sys info markdown cell is inserted)", "positive_passages": [{"docid": "doc-en-vscode-21c35d0d196a652012df6400a79221dd676b31ee83694708419ac9c6efad23b4", "text": "const editorInput = InteractiveEditorInput.create(accessor.get(IInstantiationService), notebookUri, inputUri); historyService.clearHistory(notebookUri); <del> await editorService.openEditor(editorInput, editorOptions, group); </del> <ins> await editorService.openEditor(editorInput, { ...editorOptions, pinned: true }, group); </ins> // Extensions must retain references to these URIs to manipulate the interactive editor return { notebookUri, inputUri }; }", "commid": "vscode_pr_128789"}], "negative_passages": []}
{"query_id": "q-en-vscode-15f1f091dd307b09c7941055e9f5af50df50cc953b4d0f80c5c011de60976025", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58+ OS Version: Windows Steps to Reproduce: with and . the browser launches, the server throws. This is due to: It should just be . I have a PR to fix this, but needed an issue to reference.", "positive_passages": [{"docid": "doc-en-vscode-f0324e639ed225e2e86e352fdefeb6b004d49ea0b365879f1c666d1a3951c300", "text": "if (args.verbose) { fancyLog(`${ansiColors.magenta('BuiltIn extensions')}: ${dedupedBuiltInExtensions.map(e => path.basename(e.extensionPath)).join(', ')}`); <del> fancyLog(`${ansiColors.magenta('Additional extensions')}: ${additionalBuiltinExtensions.map(e => path.basename(e.extensionLocation.path)).join(', ') || 'None'}`); </del> <ins> fancyLog(`${ansiColors.magenta('Additional extensions')}: ${additionalBuiltinExtensions.map(e => path.basename(e.path)).join(', ') || 'None'}`); </ins> } const secondaryHost = (", "commid": "vscode_pr_128872"}], "negative_passages": []}
{"query_id": "q-en-vscode-9953d7bb306d4192a9468e8ea1ac905232b0f3e7f1ded0b27f7ed291a6a752e0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: \"Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)\n+1\nduplicate of\nCan we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.\nCan reproduce the problem, it should say folder not file: ! !\nRepros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:\nSo the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !\nlet's wait until is back for that. I'm considering this verified for now\nProblem is back, looks a little different though: !\nI think the new problem is Windows only", "positive_passages": [{"docid": "doc-en-vscode-fcb3133adfcd0aabf198f292b896848fc766d7744789f28bce27966ddaac9f86", "text": "import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { XtermLinkMatcherHandler } from 'vs/workbench/contrib/terminal/browser/links/terminalLinkManager'; import { TerminalBaseLinkProvider } from 'vs/workbench/contrib/terminal/browser/links/terminalBaseLinkProvider'; <del> import { normalize } from 'vs/base/common/path'; </del> <ins> import { normalize, isAbsolute } from 'vs/base/common/path'; </ins> import { convertLinkRangeToBuffer, getXtermLineContent } from 'vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers'; import { isWindows } from 'vs/base/common/platform'; <ins> import { IFileService } from 'vs/platform/files/common/files'; import { URI } from 'vs/base/common/uri'; import { Schemas } from 'vs/base/common/network'; import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; </ins> const MAX_LENGTH = 2000;", "commid": "vscode_pr_138873"}], "negative_passages": []}
{"query_id": "q-en-vscode-9953d7bb306d4192a9468e8ea1ac905232b0f3e7f1ded0b27f7ed291a6a752e0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: \"Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)\n+1\nduplicate of\nCan we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.\nCan reproduce the problem, it should say folder not file: ! !\nRepros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:\nSo the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !\nlet's wait until is back for that. I'm considering this verified for now\nProblem is back, looks a little different though: !\nI think the new problem is Windows only", "positive_passages": [{"docid": "doc-en-vscode-03309347250162cfbea147ac601743128306a510ab15ef9ca8f73b30b22c2552", "text": "@IQuickInputService private readonly _quickInputService: IQuickInputService, @IWorkspaceContextService private readonly _workspaceContextService: IWorkspaceContextService, @ISearchService private readonly _searchService: ISearchService, <del> @IEditorService private readonly _editorService: IEditorService </del> <ins> @IEditorService private readonly _editorService: IEditorService, @IFileService private readonly _fileService: IFileService, @IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService </ins> ) { super(); }", "commid": "vscode_pr_138873"}], "negative_passages": []}
{"query_id": "q-en-vscode-9953d7bb306d4192a9468e8ea1ac905232b0f3e7f1ded0b27f7ed291a6a752e0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: \"Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)\n+1\nduplicate of\nCan we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.\nCan reproduce the problem, it should say folder not file: ! !\nRepros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:\nSo the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !\nlet's wait until is back for that. I'm considering this verified for now\nProblem is back, looks a little different though: !\nI think the new problem is Windows only", "positive_passages": [{"docid": "doc-en-vscode-2df1d60d5a51e2a1b00814db020711e2ff3bbfde29c1c9ea57a6b1d945db70db", "text": "} private async _activate(link: string) { <del> // Normalize the link and remove any leading ./ or ../ since quick access doesn't understand // that format </del> <ins> // Remove file:/// and any leading ./ or ../ since quick access doesn't understand that format link = link.replace(/^file:///?/, ''); </ins> link = normalize(link).replace(/^(.+[/])+/, ''); // Remove `:in` from the end which is how Ruby outputs stack traces", "commid": "vscode_pr_138873"}], "negative_passages": []}
{"query_id": "q-en-vscode-9953d7bb306d4192a9468e8ea1ac905232b0f3e7f1ded0b27f7ed291a6a752e0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: \"Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)\n+1\nduplicate of\nCan we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.\nCan reproduce the problem, it should say folder not file: ! !\nRepros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:\nSo the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !\nlet's wait until is back for that. I'm considering this verified for now\nProblem is back, looks a little different though: !\nI think the new problem is Windows only", "positive_passages": [{"docid": "doc-en-vscode-b26e935efb400f0512ab12d2f4bbea2201f0b312bfa21175a85c41a82ecd4549", "text": "}); const sanitizedLink = link.replace(/:d+(:d+)?$/, ''); <del> const results = await this._searchService.fileSearch( this._fileQueryBuilder.file(this._workspaceContextService.getWorkspace().folders, { // Remove optional :row:col from the link as openEditor supports it filePattern: sanitizedLink, maxResults: 2 }) ); // If there was exactly one match, open it if (results.results.length === 1) { </del> <ins> let exactMatch = await this._getExactMatch(sanitizedLink, link); if (exactMatch) { // If there was exactly one match, open it </ins> const match = link.match(/:(d+)?(:(d+))?$/); const startLineNumber = match?.[1]; const startColumn = match?.[3]; await this._editorService.openEditor({ <del> resource: results.results[0].resource, </del> <ins> resource: exactMatch, </ins> options: { pinned: true, revealIfOpened: true,", "commid": "vscode_pr_138873"}], "negative_passages": []}
{"query_id": "q-en-vscode-9953d7bb306d4192a9468e8ea1ac905232b0f3e7f1ded0b27f7ed291a6a752e0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: \"Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)\n+1\nduplicate of\nCan we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.\nCan reproduce the problem, it should say folder not file: ! !\nRepros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:\nSo the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !\nlet's wait until is back for that. I'm considering this verified for now\nProblem is back, looks a little different though: !\nI think the new problem is Windows only", "positive_passages": [{"docid": "doc-en-vscode-163a1493e750518b972dd6840fd369200b9b5c9d8353c857d7d180258e09446d", "text": "}); return; } // Fallback to searching quick access <del> this._quickInputService.quickAccess.show(link); </del> <ins> return this._quickInputService.quickAccess.show(link); } private async _getExactMatch(sanitizedLink: string, link: string): Promise<URI | undefined> { let exactResource: URI | undefined; if (isAbsolute(sanitizedLink)) { const scheme = this._environmentService.remoteAuthority ? Schemas.vscodeRemote : Schemas.file; const resource = URI.from({ scheme, path: sanitizedLink }); const fileStat = await this._fileService.resolve(resource); if (fileStat.isFile) { exactResource = resource; } } if (!exactResource) { const results = await this._searchService.fileSearch( this._fileQueryBuilder.file(this._workspaceContextService.getWorkspace().folders, { // Remove optional :row:col from the link as openEditor supports it filePattern: sanitizedLink, maxResults: 2 }) ); if (results.results.length === 1) { exactResource = results.results[0].resource; } } return exactResource; </ins> } }", "commid": "vscode_pr_138873"}], "negative_passages": []}
{"query_id": "q-en-vscode-9953d7bb306d4192a9468e8ea1ac905232b0f3e7f1ded0b27f7ed291a6a752e0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.2 OS Version: Linux x64 5.4.0-80-generic Steps to Reproduce: open a vscode window open the embedded vscode terminal any file path to a path that exists, but prepended with the uri 'file:///' prefix (example: file:////home/somedir) ctrl+click on that path error message appears: \"Unable to open 'somedir': File is a directory The expected behavior (opening the directory in vscode) works for regular paths (/home/somedir)\n+1\nduplicate of\nCan we get a little explanation of how this is a duplicate? Seems completely unrelated. This is incorrect handling of RFC 8089, RFC 3986 links while the other is failure to handle softlinks while using remote ssh. The issue here is file:// schema is treated as if it can only be a file while on the posix path it detects file vs directory.\nCan reproduce the problem, it should say folder not file: ! !\nRepros on Windows too. Same thing happens in the editor: ! Above should use 3 slashes:\nSo the link does work (tried it with multiple folders)... but I guess I expected the underline to include the bit. It's a nit and I don't feel too strongly about it, but thought I'd mention. !\nlet's wait until is back for that. I'm considering this verified for now\nProblem is back, looks a little different though: !\nI think the new problem is Windows only", "positive_passages": [{"docid": "doc-en-vscode-bc1071d792ad637592e1e60e0613582c6fa499fbe84e3be3524acfe48c14c78c", "text": "await configurationService.setUserConfiguration('terminal', { integrated: { wordSeparators: ' ' } }); await assertLink('', []); }); <ins> test('should support file scheme links', async () => { await configurationService.setUserConfiguration('terminal', { integrated: { wordSeparators: ' ' } }); await assertLink('file:///C:/users/test/file.txt ', [{ range: [[1, 1], [30, 1]], text: 'file:///C:/users/test/file.txt' }]); await assertLink('file:///C:/users/test/file.txt:1:10 ', [{ range: [[1, 1], [35, 1]], text: 'file:///C:/users/test/file.txt:1:10' }]); }); </ins> });", "commid": "vscode_pr_138873"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5b44040474a3f13e85aec9e4fe120b78cf45f781b20d5f1d8b19192013f1bb1", "query": "Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints\nWill fix this.", "positive_passages": [{"docid": "doc-en-vscode-0255b4d9e556fdd318193ba855d5788e70dea6687ff29f555324d62b9020a8dc", "text": "} if (e.element instanceof InstructionBreakpoint) { const disassemblyView = await this.editorService.openEditor(DisassemblyViewInput.instance); <del> (disassemblyView as DisassemblyView).goToAddress(e.element.instructionReference); </del> <ins> // Focus on double click (disassemblyView as DisassemblyView).goToAddress(e.element.instructionReference, e.browserEvent instanceof MouseEvent && e.browserEvent.detail === 2); </ins> } if (e.browserEvent instanceof MouseEvent && e.browserEvent.detail === 2 && e.element instanceof FunctionBreakpoint && e.element !== this.inputBoxData?.breakpoint) { // double click", "commid": "vscode_pr_129616"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5b44040474a3f13e85aec9e4fe120b78cf45f781b20d5f1d8b19192013f1bb1", "query": "Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints\nWill fix this.", "positive_passages": [{"docid": "doc-en-vscode-f0f1b8683e686e36c7d1350e38386fb55051becf6374f31b17aaa4de7ea94d62", "text": "multipleSelectionSupport: false, setRowLineHeight: false, openOnSingleClick: false, <del> accessibilityProvider: new AccessibilityProvider() </del> <ins> accessibilityProvider: new AccessibilityProvider(), mouseSupport: false </ins> } )) as WorkbenchTable<IDisassembledInstructionEntry>;", "commid": "vscode_pr_129616"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5b44040474a3f13e85aec9e4fe120b78cf45f781b20d5f1d8b19192013f1bb1", "query": "Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints\nWill fix this.", "positive_passages": [{"docid": "doc-en-vscode-28adc0b0c99beba28ac7f948d4dde05bd3e6c82086007c1467bec347394addd0", "text": "/** * Go to the address provided. If no address is provided, reveal the address of the currently focused stack frame. */ <del> goToAddress(address?: string): void { </del> <ins> goToAddress(address?: string, focus?: boolean): void { </ins> if (!this._disassembledInstructions) { return; }", "commid": "vscode_pr_129616"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5b44040474a3f13e85aec9e4fe120b78cf45f781b20d5f1d8b19192013f1bb1", "query": "Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints\nWill fix this.", "positive_passages": [{"docid": "doc-en-vscode-a4fea3101424d3a9d219e0eeebb9737a372bb84c99ebf417f21cc09c425d61f3", "text": "const bottomElement = Math.floor((this._disassembledInstructions.scrollTop + this._disassembledInstructions.renderHeight) / this.fontInfo.lineHeight); if (index > topElement && index < bottomElement) { // Inside the viewport, don't do anything here <del> return; </del> } else if (index <= topElement && index > topElement - 5) { // Not too far from top, review it at the top <del> return this._disassembledInstructions.reveal(index, 0); </del> <ins> this._disassembledInstructions.reveal(index, 0); </ins> } else if (index >= bottomElement && index < bottomElement + 5) { // Not too far from bottom, review it at the bottom <del> return this._disassembledInstructions.reveal(index, 1); </del> <ins> this._disassembledInstructions.reveal(index, 1); </ins> } else { // Far from the current viewport, reveal it <del> return this._disassembledInstructions.reveal(index, 0.5); </del> <ins> this._disassembledInstructions.reveal(index, 0.5); } if (focus) { this._disassembledInstructions.domFocus(); this._disassembledInstructions.setFocus([index]); </ins> } } else if (this._debugService.state === State.Stopped) { // Address is not provided or not in the table currently, clear the table // and reload if we are in the state where we can load disassembly. <del> return this.reloadDisassembly(address); </del> <ins> this.reloadDisassembly(address); </ins> } }", "commid": "vscode_pr_129616"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5b44040474a3f13e85aec9e4fe120b78cf45f781b20d5f1d8b19192013f1bb1", "query": "Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints\nWill fix this.", "positive_passages": [{"docid": "doc-en-vscode-d1fe484a34d903646882ec1392c98847f36d0a98dec2cf17953d02013bf67c60", "text": "this.loadDisassembledInstructions(targetAddress, -DisassemblyView.NUM_INSTRUCTIONS_TO_LOAD, DisassemblyView.NUM_INSTRUCTIONS_TO_LOAD * 2).then(() => { // on load, set the target instruction in the middle of the page. if (this._disassembledInstructions!.length > 0) { <del> this._disassembledInstructions!.reveal(Math.floor(this._disassembledInstructions!.length / 2), 0.5); </del> <ins> const targetIndex = Math.floor(this._disassembledInstructions!.length / 2); this._disassembledInstructions!.reveal(targetIndex, 0.5); // Always focus the target address on reload, or arrow key navigation would look terrible this._disassembledInstructions!.domFocus(); this._disassembledInstructions!.setFocus([targetIndex]); </ins> } }); }", "commid": "vscode_pr_129616"}], "negative_passages": []}
{"query_id": "q-en-vscode-5a8c907bf3fb964b95a48a4633de6f98df827949ca23279e7654975f314c9590", "query": "We only respect the setting when a is found: We should always support the separator.\n//cc\nWent ahead with a fix myself because I figured it is more involved: without formatting we cannot just add the separator so I ended up using the method that matches the config in that case on the relative path.\nThanks for the proper fix! I had couple of attempts but first failed when list of files in with stopped to work (apparently needed ) Second was but it produced different results for and . Haven't thought about using same normalization as in\nwhat are some verification steps for this issue?\nthanks for bringing this up. Steps from : different values for \"Copy relative path\" for some nested filed - separators should match selection (or system separator for ) I've checked latest version in and looks like fix doesn't work at this moment: apparently won't replace with ! Maybe it make sense to use ?\nis a valid character in filenames on POSIX so this is a bit tricky... I don't think we should ever convert it to on a POSIX system as that would represent a totally different resource.\nYep, in name is tricky but is it common case? Anyway: Alternative option will be to \"force\" path formatting which will work with and I'm assume it will always have as separator that later converted to if needed without causing problem with -that might replace from filenames This will be \"similar\" to missing formatting as would work with it as with path anyway. But then there will be inconsistency with : - relative as expected, expected separator- relative as expected, expected separator- - not expected but return full path (same as current behavior in ) as it's processed with , separator not supported at all. I'm not sure why returns full path but I guess it's incorrect setup for in web playground, as works OK for files in VS Code desktop.\nReopening with verification steps web on windows .copyRelativePathSeparator: a path from the memfs system that it still uses I can take this as I own label service from Going to push out as products are not affected.\nIt looks like the code that is typically doing this conversion when a formatting is there is this one: Maybe we can do something similar instead of and replace any of or with the separator.", "positive_passages": [{"docid": "doc-en-vscode-670735a3b267cc14e7675e2f21093f25e8122c0f9be54cac0587fc9346fe4158", "text": "// Without formatting we still need to support the separator // as provided in options (https://github.com/microsoft/vscode/issues/130019) if (!formatting && options.separator) { <del> switch (options.separator) { case paths.win32.sep: return paths.win32.normalize(label); case paths.posix.sep: return paths.posix.normalize(label); } </del> <ins> return label.replace(sepRegexp, options.separator); </ins> } return label;", "commid": "vscode_pr_132964"}], "negative_passages": []}
{"query_id": "q-en-vscode-5a8c907bf3fb964b95a48a4633de6f98df827949ca23279e7654975f314c9590", "query": "We only respect the setting when a is found: We should always support the separator.\n//cc\nWent ahead with a fix myself because I figured it is more involved: without formatting we cannot just add the separator so I ended up using the method that matches the config in that case on the relative path.\nThanks for the proper fix! I had couple of attempts but first failed when list of files in with stopped to work (apparently needed ) Second was but it produced different results for and . Haven't thought about using same normalization as in\nwhat are some verification steps for this issue?\nthanks for bringing this up. Steps from : different values for \"Copy relative path\" for some nested filed - separators should match selection (or system separator for ) I've checked latest version in and looks like fix doesn't work at this moment: apparently won't replace with ! Maybe it make sense to use ?\nis a valid character in filenames on POSIX so this is a bit tricky... I don't think we should ever convert it to on a POSIX system as that would represent a totally different resource.\nYep, in name is tricky but is it common case? Anyway: Alternative option will be to \"force\" path formatting which will work with and I'm assume it will always have as separator that later converted to if needed without causing problem with -that might replace from filenames This will be \"similar\" to missing formatting as would work with it as with path anyway. But then there will be inconsistency with : - relative as expected, expected separator- relative as expected, expected separator- - not expected but return full path (same as current behavior in ) as it's processed with , separator not supported at all. I'm not sure why returns full path but I guess it's incorrect setup for in web playground, as works OK for files in VS Code desktop.\nReopening with verification steps web on windows .copyRelativePathSeparator: a path from the memfs system that it still uses I can take this as I own label service from Going to push out as products are not affected.\nIt looks like the code that is typically doing this conversion when a formatting is there is this one: Maybe we can do something similar instead of and replace any of or with the separator.", "positive_passages": [{"docid": "doc-en-vscode-5f21f1084f95e331a9910334aca73feac42a3f2d46814a7728cfd12533ab2161", "text": "assert.strictEqual(generated, label); }); }); <ins> test('relative label with explicit path separator', () => { let generated = labelService.getUriLabel(URI.parse('myscheme://myauthority/some/folder/test.txt'), { relative: true, separator: '/' }); assert.strictEqual(generated, 'some/folder/test.txt'); generated = labelService.getUriLabel(URI.parse('myscheme://myauthority/some/folder/test.txt'), { relative: true, separator: '' }); assert.strictEqual(generated, 'somefoldertest.txt'); }); </ins> });", "commid": "vscode_pr_132964"}], "negative_passages": []}
{"query_id": "q-en-vscode-b34373be1648503ee64d033f74d6e142c212f9b722029bed8c8a7cbaf40ba2bc", "query": "! //cc\nWorks great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !\nRemoved the border radius for the expanding chevron: <img width=\"139\" alt=\"CleanShot 2021-09-13 at 15 40 09 src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-5d970e8195b180bbf215ee6cca0a48ac81cdec5d0de336dba5324cb35825e111", "text": "} .monaco-editor .find-widget .button { <del> width: 20px; height: 20px; </del> <ins> width: 16px; height: 16px; padding: 3px; border-radius: 5px; </ins> display: flex; flex: initial; margin-left: 3px;", "commid": "vscode_pr_131046"}], "negative_passages": []}
{"query_id": "q-en-vscode-b34373be1648503ee64d033f74d6e142c212f9b722029bed8c8a7cbaf40ba2bc", "query": "! //cc\nWorks great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !\nRemoved the border radius for the expanding chevron: <img width=\"139\" alt=\"CleanShot 2021-09-13 at 15 40 09 src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-557ff302c11c782da3d60c28287fed657d3736593959aca8db4a1d95591cf037", "text": "justify-content: center; } <ins> /* find in selection button */ .monaco-editor .find-widget .codicon-find-selection { width: 22px; height: 22px; padding: 3px; border-radius: 5px; } </ins> .monaco-editor .find-widget .button.left { margin-left: 0; margin-right: 3px;", "commid": "vscode_pr_131046"}], "negative_passages": []}
{"query_id": "q-en-vscode-b34373be1648503ee64d033f74d6e142c212f9b722029bed8c8a7cbaf40ba2bc", "query": "! //cc\nWorks great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !\nRemoved the border radius for the expanding chevron: <img width=\"139\" alt=\"CleanShot 2021-09-13 at 15 40 09 src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-7de46fca829ee2d7b0a900af2b0bbe475dea8b96355f9c0fd4e0d98d8bb924c5", "text": "import { FindReplaceState, FindReplaceStateChangedEvent } from 'vs/editor/contrib/find/findState'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; <del> import { contrastBorder, editorFindMatch, editorFindMatchBorder, editorFindMatchHighlight, editorFindMatchHighlightBorder, editorFindRangeHighlight, editorFindRangeHighlightBorder, editorWidgetBackground, editorWidgetBorder, editorWidgetResizeBorder, errorForeground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, focusBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { contrastBorder, editorFindMatch, editorFindMatchBorder, editorFindMatchHighlight, editorFindMatchHighlightBorder, editorFindRangeHighlight, editorFindRangeHighlightBorder, editorWidgetBackground, editorWidgetBorder, editorWidgetResizeBorder, errorForeground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, focusBorder, toolbarHoverBackground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { IColorTheme, IThemeService, registerThemingParticipant, ThemeIcon } from 'vs/platform/theme/common/themeService'; import { ContextScopedFindInput, ContextScopedReplaceInput } from 'vs/platform/browser/contextScopedHistoryWidget'; import { AccessibilitySupport } from 'vs/platform/accessibility/common/accessibility';", "commid": "vscode_pr_131046"}], "negative_passages": []}
{"query_id": "q-en-vscode-b34373be1648503ee64d033f74d6e142c212f9b722029bed8c8a7cbaf40ba2bc", "query": "! //cc\nWorks great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !\nRemoved the border radius for the expanding chevron: <img width=\"139\" alt=\"CleanShot 2021-09-13 at 15 40 09 src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-801bc2a0227f79dc246ecfd6c3897d4c9accbaba94ba536e2ea51e2b1cec4bb5", "text": "} } <ins> // Action bars const toolbarHoverBackgroundColor = theme.getColor(toolbarHoverBackground); if (toolbarHoverBackgroundColor) { collector.addRule(` .monaco-editor .find-widget .button:not(.disabled):hover, .monaco-editor .find-widget .codicon-find-selection:hover { background-color: ${toolbarHoverBackgroundColor} !important; } `); } </ins> // This rule is used to override the outline color for synthetic-focus find input. const focusOutline = theme.getColor(focusBorder); if (focusOutline) {", "commid": "vscode_pr_131046"}], "negative_passages": []}
{"query_id": "q-en-vscode-89fa0dc86ddf3d08be29750af027104b692ce66c9591f28fd5704b1c2ed9d153", "query": "Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width=\"679\" alt=\"Screen Shot 2021-08-23 at 11 19 37 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI would like to contribute to this. Can I help you with the issue?", "positive_passages": [{"docid": "doc-en-vscode-6cfdc6ccfa7a44a8b199b3277d3e9ffb00969b42846a80b7d15f970c4085ddfc", "text": "const media = stepToExpand.media; const mediaElement = $<HTMLImageElement>('img'); <ins> clearNode(this.stepMediaComponent); </ins> this.stepMediaComponent.appendChild(mediaElement); mediaElement.setAttribute('alt', media.altText); this.updateMediaSourceForColorMode(mediaElement, media.path);", "commid": "vscode_pr_187019"}], "negative_passages": []}
{"query_id": "q-en-vscode-89fa0dc86ddf3d08be29750af027104b692ce66c9591f28fd5704b1c2ed9d153", "query": "Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width=\"679\" alt=\"Screen Shot 2021-08-23 at 11 19 37 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI would like to contribute to this. Can I help you with the issue?", "positive_passages": [{"docid": "doc-en-vscode-3b3249de979fb0fe2d541f93b378a84db5a216f9ae21040007fd91bc7ab10849", "text": "this.container.classList.toggle('height-constrained', size.height <= 600); this.container.classList.toggle('width-constrained', size.width <= 400); this.container.classList.toggle('width-semi-constrained', size.width <= 800); <ins> this.categoriesPageScrollbar?.scanDomNode(); this.detailsPageScrollbar?.scanDomNode(); this.detailsScrollbar?.scanDomNode(); </ins> } private updateCategoryProgress() {", "commid": "vscode_pr_187019"}], "negative_passages": []}
{"query_id": "q-en-vscode-89fa0dc86ddf3d08be29750af027104b692ce66c9591f28fd5704b1c2ed9d153", "query": "Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width=\"679\" alt=\"Screen Shot 2021-08-23 at 11 19 37 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI would like to contribute to this. Can I help you with the issue?", "positive_passages": [{"docid": "doc-en-vscode-e2a997c880c904188eaa3e85535b9b6361a3d689f68c110444386dc596b1864e", "text": "<del> <svg viewBox=\"0 0 520 238\" fill=\"none\" xmlns=\"http://www.w3.org/2000/svg\"> <g> <rect width=\"520\" height=\"238\" fill=\"var(--vscode-breadcrumb-background, #1E1E1E)\" /> <g clip-path=\"url(#clip0_1_138)\"> <g> <rect width=\"520\" height=\"39\" fill=\"var(--vscode-breadcrumbPicker-background, #252526)\" /> <g clip-path=\"url(#clip1_1_138)\"> <g> <rect width=\"115.654\" height=\"39.2998\" fill=\"var(--vscode-breadcrumb-background, #1E1E1E)\" /> <rect x=\"13.4742\" y=\"15.7199\" width=\"88.7052\" height=\"7.85995\" rx=\"3.92998\" fill=\"var(--vscode-tab-inactiveBackground, #2D2D2D)\" /> </g> </g> <path d=\"M215.244 20.2222C212.699 20.2222 211.112 18.3813 211.112 15.4233C211.112 12.459 212.692 10.6182 215.238 10.6182C217.256 10.6182 218.818 11.9067 219.046 13.7412H217.631C217.364 12.605 216.444 11.8813 215.238 11.8813C213.594 11.8813 212.565 13.2461 212.565 15.4233C212.565 17.6006 213.594 18.959 215.244 18.959C216.457 18.959 217.377 18.3052 217.631 17.2642H219.046C218.792 19.0479 217.288 20.2222 215.244 20.2222ZM220.76 20V13.1064H222.074V14.1538H222.176C222.373 13.4746 223.141 12.9858 224.042 12.9858C224.245 12.9858 224.505 13.0049 224.651 13.0366V14.3188C224.537 14.2871 224.131 14.2427 223.89 14.2427C222.855 14.2427 222.125 14.9092 222.125 15.8804V20H220.76ZM230.32 18.1528H231.634C231.335 19.3716 230.218 20.1333 228.638 20.1333C226.657 20.1333 225.445 18.7686 225.445 16.5659C225.445 14.376 226.683 12.9731 228.631 12.9731C230.555 12.9731 231.716 14.2871 231.716 16.4453V16.915H226.835V16.9785C226.879 18.229 227.584 19.0161 228.676 19.0161C229.501 19.0161 230.066 18.7114 230.32 18.1528ZM228.625 14.084C227.616 14.084 226.911 14.8203 226.835 15.9312H230.326C230.294 14.814 229.634 14.084 228.625 14.084ZM235.265 20.1143C233.932 20.1143 232.96 19.3145 232.96 18.0576C232.96 16.8198 233.887 16.1025 235.531 16.001L237.404 15.8867V15.2837C237.404 14.5283 236.921 14.103 235.988 14.103C235.227 14.103 234.7 14.3887 234.547 14.8901H233.227C233.367 13.7285 234.484 12.9731 236.052 12.9731C237.785 12.9731 238.762 13.8364 238.762 15.2837V20H237.448V19.0225H237.34C236.928 19.7207 236.172 20.1143 235.265 20.1143ZM235.614 19.0161C236.642 19.0161 237.404 18.3433 237.404 17.4546V16.8579L235.715 16.9722C234.763 17.0356 234.332 17.3721 234.332 18.0005C234.332 18.6416 234.871 19.0161 235.614 19.0161ZM241.187 11.3672H242.552V13.1255H244.05V14.2173H242.552V17.8545C242.552 18.5972 242.85 18.9209 243.529 18.9209C243.739 18.9209 243.859 18.9082 244.05 18.8892V19.9746C243.828 20.0127 243.574 20.0444 243.307 20.0444C241.79 20.0444 241.187 19.5112 241.187 18.1846V14.2173H240.089V13.1255H241.187V11.3672ZM250.112 18.1528H251.426C251.127 19.3716 250.01 20.1333 248.43 20.1333C246.449 20.1333 245.237 18.7686 245.237 16.5659C245.237 14.376 246.475 12.9731 248.423 12.9731C250.347 12.9731 251.508 14.2871 251.508 16.4453V16.915H246.627V16.9785C246.671 18.229 247.376 19.0161 248.468 19.0161C249.293 19.0161 249.858 18.7114 250.112 18.1528ZM248.417 14.084C247.408 14.084 246.703 14.8203 246.627 15.9312H250.118C250.086 14.814 249.426 14.084 248.417 14.084ZM256.859 10.8403H260.446C262.236 10.8403 263.467 12.0718 263.467 13.8745C263.467 15.6392 262.198 16.8706 260.401 16.8706H258.281V20H256.859V10.8403ZM258.281 12.04V15.6772H260.071C261.296 15.6772 262.014 15.0234 262.014 13.8745C262.014 12.6875 261.322 12.04 260.071 12.04H258.281ZM265.143 20V13.1064H266.457V14.1538H266.559C266.755 13.4746 267.523 12.9858 268.425 12.9858C268.628 12.9858 268.888 13.0049 269.034 13.0366V14.3188C268.92 14.2871 268.514 14.2427 268.272 14.2427C267.238 14.2427 266.508 14.9092 266.508 15.8804V20H265.143ZM273.09 20.1333C271.065 20.1333 269.828 18.7812 269.828 16.5532C269.828 14.3315 271.072 12.9731 273.09 12.9731C275.103 12.9731 276.347 14.3252 276.347 16.5532C276.347 18.7812 275.109 20.1333 273.09 20.1333ZM273.09 18.9717C274.271 18.9717 274.944 18.083 274.944 16.5532C274.944 15.0171 274.271 14.1284 273.09 14.1284C271.903 14.1284 271.237 15.0171 271.237 16.5532C271.237 18.0894 271.903 18.9717 273.09 18.9717ZM278.479 20V14.2173H277.343V13.1255H278.479V12.3828C278.479 11.0117 279.178 10.3389 280.612 10.3389C280.923 10.3389 281.19 10.3643 281.425 10.4023V11.4307C281.298 11.4116 281.114 11.3989 280.898 11.3989C280.136 11.3989 279.825 11.748 279.825 12.4463V13.1255H281.368V14.2173H279.844V20H278.479ZM283.621 11.875C283.145 11.875 282.758 11.4878 282.758 11.0181C282.758 10.542 283.145 10.1548 283.621 10.1548C284.097 10.1548 284.484 10.542 284.484 11.0181C284.484 11.4878 284.097 11.875 283.621 11.875ZM282.942 20V13.1064H284.3V20H282.942ZM286.37 20V10.4023H287.734V20H286.37ZM294.317 18.1528H295.631C295.333 19.3716 294.215 20.1333 292.635 20.1333C290.654 20.1333 289.442 18.7686 289.442 16.5659C289.442 14.376 290.68 12.9731 292.628 12.9731C294.552 12.9731 295.713 14.2871 295.713 16.4453V16.915H290.832V16.9785C290.876 18.229 291.581 19.0161 292.673 19.0161C293.498 19.0161 294.063 18.7114 294.317 18.1528ZM292.622 14.084C291.613 14.084 290.908 14.8203 290.832 15.9312H294.323C294.292 14.814 293.631 14.084 292.622 14.084ZM298.411 20.0952C297.878 20.0952 297.478 19.6953 297.478 19.1812C297.478 18.667 297.878 18.2671 298.411 18.2671C298.951 18.2671 299.344 18.667 299.344 19.1812C299.344 19.6953 298.951 20.0952 298.411 20.0952ZM302.512 20.0952C301.979 20.0952 301.579 19.6953 301.579 19.1812C301.579 18.667 301.979 18.2671 302.512 18.2671C303.051 18.2671 303.445 18.667 303.445 19.1812C303.445 19.6953 303.051 20.0952 302.512 20.0952ZM306.612 20.0952C306.079 20.0952 305.679 19.6953 305.679 19.1812C305.679 18.667 306.079 18.2671 306.612 18.2671C307.152 18.2671 307.545 18.667 307.545 19.1812C307.545 19.6953 307.152 20.0952 306.612 20.0952Z\" fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\" /> </g> </g> <g filter=\"url(#filter0_d_1_138)\"> <rect width=\"425\" height=\"196\" transform=\"translate(47 24)\" fill=\"var(--vscode-breadcrumbPicker-background, #252526)\" /> <g> <g> <rect x=\"54.5\" y=\"31.5\" width=\"410\" height=\"25\" fill=\"var(--vscode-checkbox-background, #3C3C3C)\" /> <rect x=\"54.5\" y=\"31.5\" width=\"410\" height=\"25\" stroke=\"var(--vscode-focusBorder, #007FD4)\" /> </g> </g> <g> <g> <rect width=\"425\" height=\"24\" transform=\"translate(47 64)\" fill=\"var(--vscode-peekViewEditor-background, #062F4A)\" /> <path d=\"M65.9634 79.7749V81H60.1489V71.8403H65.9634V73.0654H61.5708V75.7441H65.7285V76.9248H61.5708V79.7749H65.9634ZM67.8613 81V74.1064H69.1753V75.2046H69.2769C69.5815 74.4302 70.2798 73.9731 71.2002 73.9731C72.146 73.9731 72.7998 74.4619 73.1045 75.2046H73.2124C73.5615 74.4619 74.355 73.9731 75.3135 73.9731C76.71 73.9731 77.5225 74.811 77.5225 76.2456V81H76.1577V76.5757C76.1577 75.6235 75.7134 75.1602 74.8184 75.1602C73.936 75.1602 73.3584 75.8076 73.3584 76.6392V81H72.019V76.436C72.019 75.6489 71.4985 75.1602 70.686 75.1602C69.8545 75.1602 69.2261 75.8647 69.2261 76.7661V81H67.8613ZM83.0259 73.9858C84.7842 73.9858 85.895 75.3633 85.895 77.5532C85.895 79.7305 84.7842 81.1143 83.0386 81.1143C82.0547 81.1143 81.2739 80.689 80.9121 79.959H80.8042V83.2979H79.4395V74.1064H80.7534V75.249H80.855C81.2739 74.4619 82.0864 73.9858 83.0259 73.9858ZM82.6387 79.9463C83.8003 79.9463 84.4922 79.0513 84.4922 77.5532C84.4922 76.0552 83.8003 75.1538 82.645 75.1538C81.4961 75.1538 80.7788 76.0742 80.7788 77.5532C80.7788 79.0259 81.4961 79.9463 82.6387 79.9463ZM88.0215 72.3672H89.3862V74.1255H90.8843V75.2173H89.3862V78.8545C89.3862 79.5972 89.6846 79.9209 90.3638 79.9209C90.5732 79.9209 90.6938 79.9082 90.8843 79.8892V80.9746C90.6621 81.0127 90.4082 81.0444 90.1416 81.0444C88.6245 81.0444 88.0215 80.5112 88.0215 79.1846V75.2173H86.9233V74.1255H88.0215V72.3672ZM93.1758 83.501C93.0615 83.501 92.7378 83.4883 92.6108 83.4692V82.3521C92.7188 82.3711 92.9282 82.3774 93.0552 82.3774C93.7026 82.3774 94.0708 82.1045 94.3057 81.3745L94.4072 81.019L91.9062 74.1064H93.3916L95.1245 79.6289H95.2324L96.959 74.1064H98.4062L95.8291 81.3174C95.2388 82.9741 94.585 83.501 93.1758 83.501ZM103.516 71.8403H107.103C108.893 71.8403 110.124 73.0718 110.124 74.8745C110.124 76.6392 108.854 77.8706 107.058 77.8706H104.938V81H103.516V71.8403ZM104.938 73.04V76.6772H106.728C107.953 76.6772 108.67 76.0234 108.67 74.8745C108.67 73.6875 107.979 73.04 106.728 73.04H104.938ZM111.8 81V74.1064H113.114V75.1538H113.215C113.412 74.4746 114.18 73.9858 115.082 73.9858C115.285 73.9858 115.545 74.0049 115.691 74.0366V75.3188C115.577 75.2871 115.17 75.2427 114.929 75.2427C113.895 75.2427 113.165 75.9092 113.165 76.8804V81H111.8ZM119.747 81.1333C117.722 81.1333 116.484 79.7812 116.484 77.5532C116.484 75.3315 117.729 73.9731 119.747 73.9731C121.759 73.9731 123.003 75.3252 123.003 77.5532C123.003 79.7812 121.766 81.1333 119.747 81.1333ZM119.747 79.9717C120.928 79.9717 121.601 79.083 121.601 77.5532C121.601 76.0171 120.928 75.1284 119.747 75.1284C118.56 75.1284 117.894 76.0171 117.894 77.5532C117.894 79.0894 118.56 79.9717 119.747 79.9717ZM125.136 81V75.2173H124V74.1255H125.136V73.3828C125.136 72.0117 125.834 71.3389 127.269 71.3389C127.58 71.3389 127.847 71.3643 128.082 71.4023V72.4307C127.955 72.4116 127.771 72.3989 127.555 72.3989C126.793 72.3989 126.482 72.748 126.482 73.4463V74.1255H128.024V75.2173H126.501V81H125.136ZM130.278 72.875C129.802 72.875 129.415 72.4878 129.415 72.0181C129.415 71.542 129.802 71.1548 130.278 71.1548C130.754 71.1548 131.141 71.542 131.141 72.0181C131.141 72.4878 130.754 72.875 130.278 72.875ZM129.599 81V74.1064H130.957V81H129.599ZM133.026 81V71.4023H134.391V81H133.026ZM140.974 79.1528H142.288C141.989 80.3716 140.872 81.1333 139.292 81.1333C137.311 81.1333 136.099 79.7686 136.099 77.5659C136.099 75.376 137.336 73.9731 139.285 73.9731C141.208 73.9731 142.37 75.2871 142.37 77.4453V77.915H137.489V77.9785C137.533 79.229 138.238 80.0161 139.33 80.0161C140.155 80.0161 140.72 79.7114 140.974 79.1528ZM139.279 75.084C138.27 75.084 137.565 75.8203 137.489 76.9312H140.98C140.948 75.814 140.288 75.084 139.279 75.084Z\" fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\" /> </g> <g> <g> <rect x=\"59\" y=\"98\" width=\"62.5\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\" /> <rect x=\"125.5\" y=\"98\" width=\"29\" height=\"6\" rx=\"3\" fill=\"var(--vscode-banner-iconForeground, #3794FF)\" fill-opacity=\"0.6\" /> <rect x=\"158.5\" y=\"98\" width=\"62.5\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\" /> </g> </g> <g> <path d=\"M60.1489 123.84H63.7354C65.5254 123.84 66.7568 125.072 66.7568 126.875C66.7568 128.639 65.4873 129.871 63.6909 129.871H61.5708V133H60.1489V123.84ZM61.5708 125.04V128.677H63.3608C64.5859 128.677 65.3032 128.023 65.3032 126.875C65.3032 125.688 64.6113 125.04 63.3608 125.04H61.5708ZM69.334 135.501C69.2197 135.501 68.896 135.488 68.769 135.469V134.352C68.877 134.371 69.0864 134.377 69.2134 134.377C69.8608 134.377 70.229 134.104 70.4639 133.375L70.5654 133.019L68.0645 126.106H69.5498L71.2827 131.629H71.3906L73.1172 126.106H74.5645L71.9873 133.317C71.397 134.974 70.7432 135.501 69.334 135.501ZM76.4434 124.367H77.8081V126.125H79.3062V127.217H77.8081V130.854C77.8081 131.597 78.1064 131.921 78.7856 131.921C78.9951 131.921 79.1157 131.908 79.3062 131.889V132.975C79.084 133.013 78.8301 133.044 78.5635 133.044C77.0464 133.044 76.4434 132.511 76.4434 131.185V127.217H75.3452V126.125H76.4434V124.367ZM80.9756 133V123.402H82.3276V127.205H82.4355C82.772 126.437 83.502 125.979 84.543 125.979C86.0156 125.979 86.9233 126.913 86.9233 128.544V133H85.5586V128.868C85.5586 127.731 85.0444 127.167 84.0796 127.167C82.9624 127.167 82.3403 127.884 82.3403 128.963V133H80.9756ZM91.7666 133.133C89.7417 133.133 88.5039 131.781 88.5039 129.553C88.5039 127.332 89.748 125.973 91.7666 125.973C93.7788 125.973 95.0229 127.325 95.0229 129.553C95.0229 131.781 93.7852 133.133 91.7666 133.133ZM91.7666 131.972C92.9473 131.972 93.6201 131.083 93.6201 129.553C93.6201 128.017 92.9473 127.128 91.7666 127.128C90.5796 127.128 89.9131 128.017 89.9131 129.553C89.9131 131.089 90.5796 131.972 91.7666 131.972ZM96.667 133V126.106H97.981V127.198H98.0825C98.4189 126.437 99.1045 125.973 100.146 125.973C101.688 125.973 102.539 126.894 102.539 128.538V133H101.174V128.861C101.174 127.719 100.691 127.16 99.6821 127.16C98.6729 127.16 98.0317 127.846 98.0317 128.957V133H96.667Z\" fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\" /> <path d=\"M60.1489 149.84H63.4561C66.1729 149.84 67.7661 151.516 67.7661 154.398C67.7661 157.312 66.1855 159 63.4561 159H60.1489V149.84ZM61.5708 151.065V157.775H63.2974C65.2144 157.775 66.3188 156.55 66.3188 154.417C66.3188 152.303 65.1953 151.065 63.2974 151.065H61.5708ZM72.457 159.133C70.4321 159.133 69.1943 157.781 69.1943 155.553C69.1943 153.332 70.4385 151.973 72.457 151.973C74.4692 151.973 75.7134 153.325 75.7134 155.553C75.7134 157.781 74.4756 159.133 72.457 159.133ZM72.457 157.972C73.6377 157.972 74.3105 157.083 74.3105 155.553C74.3105 154.017 73.6377 153.128 72.457 153.128C71.27 153.128 70.6035 154.017 70.6035 155.553C70.6035 157.089 71.27 157.972 72.457 157.972ZM83.21 154.322H81.8833C81.7246 153.649 81.166 153.135 80.252 153.135C79.1094 153.135 78.4111 154.036 78.4111 155.528C78.4111 157.051 79.1157 157.972 80.252 157.972C81.1152 157.972 81.7056 157.565 81.8833 156.816H83.21C83.0322 158.175 81.9658 159.133 80.2583 159.133C78.2461 159.133 77.0146 157.762 77.0146 155.528C77.0146 153.338 78.2397 151.973 80.252 151.973C81.9849 151.973 83.0322 152.982 83.21 154.322ZM93.6772 152.151L91.7158 159H90.3701L87.9009 149.84H89.3799L91.062 156.962H91.1509L93.0615 149.84H94.3818L96.3052 156.962H96.394L98.0698 149.84H99.5488L97.0732 159H95.7339L93.7661 152.151H93.6772ZM100.704 159V152.106H102.018V153.154H102.12C102.316 152.475 103.084 151.986 103.986 151.986C104.189 151.986 104.449 152.005 104.595 152.037V153.319C104.481 153.287 104.075 153.243 103.833 153.243C102.799 153.243 102.069 153.909 102.069 154.88V159H100.704ZM106.614 150.875C106.138 150.875 105.75 150.488 105.75 150.018C105.75 149.542 106.138 149.155 106.614 149.155C107.09 149.155 107.477 149.542 107.477 150.018C107.477 150.488 107.09 150.875 106.614 150.875ZM105.935 159V152.106H107.293V159H105.935ZM109.781 150.367H111.146V152.125H112.644V153.217H111.146V156.854C111.146 157.597 111.444 157.921 112.124 157.921C112.333 157.921 112.454 157.908 112.644 157.889V158.975C112.422 159.013 112.168 159.044 111.901 159.044C110.384 159.044 109.781 158.511 109.781 157.185V153.217H108.683V152.125H109.781V150.367ZM118.706 157.153H120.02C119.722 158.372 118.604 159.133 117.024 159.133C115.043 159.133 113.831 157.769 113.831 155.566C113.831 153.376 115.069 151.973 117.018 151.973C118.941 151.973 120.103 153.287 120.103 155.445V155.915H115.221V155.979C115.266 157.229 115.97 158.016 117.062 158.016C117.887 158.016 118.452 157.711 118.706 157.153ZM117.011 153.084C116.002 153.084 115.297 153.82 115.221 154.931H118.712C118.681 153.814 118.021 153.084 117.011 153.084ZM121.74 159V152.106H123.054V153.154H123.156C123.353 152.475 124.121 151.986 125.022 151.986C125.225 151.986 125.485 152.005 125.631 152.037V153.319C125.517 153.287 125.111 153.243 124.87 153.243C123.835 153.243 123.105 153.909 123.105 154.88V159H121.74Z\" fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\" /> </g> <g> <g> <rect x=\"59\" y=\"178\" width=\"26\" height=\"6\" rx=\"3\" fill=\"var(--vscode-banner-iconForeground, #3794FF)\" fill-opacity=\"0.6\" /> <rect x=\"89\" y=\"178\" width=\"164\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\" /> </g> </g> <g> <g> <rect x=\"59\" y=\"200\" width=\"46\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\" /> <rect x=\"109\" y=\"200\" width=\"29\" height=\"6\" rx=\"3\" fill=\"var(--vscode-banner-iconForeground, #3794FF)\" fill-opacity=\"0.6\" /> <rect x=\"142\" y=\"200\" width=\"46\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\" /> </g> </g> </g> </g> </g> <defs> <filter id=\"filter0_d_1_138\" x=\"31\" y=\"10\" width=\"457\" height=\"228\" filterUnits=\"userSpaceOnUse\" color-interpolation-filters=\"sRGB\"> <feFlood flood-opacity=\"0\" result=\"BackgroundImageFix\" /> <feColorMatrix in=\"SourceAlpha\" type=\"matrix\" values=\"0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 127 0\" result=\"hardAlpha\" /> <feOffset dy=\"2\" /> <feGaussianBlur stdDeviation=\"8\" /> <feColorMatrix type=\"matrix\" values=\"0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.36 0\" /> <feBlend mode=\"normal\" in2=\"BackgroundImageFix\" result=\"effect1_dropShadow_1_138\" /> <feBlend mode=\"normal\" in=\"SourceGraphic\" in2=\"effect1_dropShadow_1_138\" result=\"shape\" /> </filter> <clipPath id=\"clip0_1_138\"> <rect width=\"520\" height=\"238\" fill=\"var(--vscode-activityBar-activeBorder, #FFFFFF)\" /> </clipPath> <clipPath id=\"clip1_1_138\"> <rect width=\"115.654\" height=\"39.2998\" fill=\"var(--vscode-activityBar-activeBorder, #FFFFFF)\" /> </clipPath> </defs> </del> <ins> <svg fill=\"none\" viewBox=\"0 0 520 238\" xmlns=\"http://www.w3.org/2000/svg\"> <rect fill=\"var(--vscode-breadcrumb-background, #1E1E1E)\"/> <g clip-path=\"url(#c)\"> <rect width=\"520\" height=\"39\" fill=\"var(--vscode-breadcrumbPicker-background, #252526)\"/> <g clip-path=\"url(#b)\"> <rect width=\"115.65\" height=\"39.3\" fill=\"var(--vscode-breadcrumb-background, #1E1E1E)\"/> <rect x=\"13.474\" y=\"15.72\" width=\"88.705\" height=\"7.86\" rx=\"3.93\" fill=\"var(--vscode-tab-inactiveBackground, #2D2D2D)\"/> </g> <path d=\"m215.24 20.222c-2.545 0-4.132-1.8409-4.132-4.7989 0-2.9643 1.58-4.8051 4.126-4.8051 2.018 0 3.58 1.2885 3.808 3.123h-1.415c-0.267-1.1362-1.187-1.8599-2.393-1.8599-1.644 0-2.673 1.3648-2.673 3.542 0 2.1773 1.029 3.5357 2.679 3.5357 1.213 0 2.133-0.6538 2.387-1.6948h1.415c-0.254 1.7837-1.758 2.958-3.802 2.958zm5.516-0.2222v-6.8936h1.314v1.0474h0.102c0.197-0.6792 0.965-1.168 1.866-1.168 0.203 0 0.463 0.0191 0.609 0.0508v1.2822c-0.114-0.0317-0.52-0.0761-0.761-0.0761-1.035 0-1.765 0.6665-1.765 1.6377v4.1196h-1.365zm9.56-1.8472h1.314c-0.299 1.2188-1.416 1.9805-2.996 1.9805-1.981 0-3.193-1.3647-3.193-3.5674 0-2.1899 1.238-3.5928 3.186-3.5928 1.924 0 3.085 1.314 3.085 3.4722v0.4697h-4.881v0.0635c0.044 1.2505 0.749 2.0376 1.841 2.0376 0.825 0 1.39-0.3047 1.644-0.8633zm-1.695-4.0688c-1.009 0-1.714 0.7363-1.79 1.8472h3.491c-0.032-1.1172-0.692-1.8472-1.701-1.8472zm6.64 6.0303c-1.333 0-2.305-0.7998-2.305-2.0567 0-1.2378 0.927-1.9551 2.571-2.0566l1.873-0.1143v-0.603c0-0.7554-0.483-1.1807-1.416-1.1807-0.761 0-1.288 0.2857-1.441 0.7871h-1.32c0.14-1.1616 1.257-1.917 2.825-1.917 1.733 0 2.71 0.8633 2.71 2.3106v4.7163h-1.314v-0.9775h-0.108c-0.412 0.6982-1.168 1.0918-2.075 1.0918zm0.349-1.0982c1.028 0 1.79-0.6728 1.79-1.5615v-0.5967l-1.689 0.1143c-0.952 0.0634-1.383 0.3999-1.383 1.0283 0 0.6411 0.539 1.0156 1.282 1.0156zm5.573-7.6489h1.365v1.7583h1.498v1.0918h-1.498v3.6372c0 0.7427 0.298 1.0664 0.977 1.0664 0.21 0 0.33-0.0127 0.521-0.0317v1.0854c-0.222 0.0381-0.476 0.0698-0.743 0.0698-1.517 0-2.12-0.5332-2.12-1.8598v-3.9673h-1.098v-1.0918h1.098v-1.7583zm8.925 6.7856h1.314c-0.299 1.2188-1.416 1.9805-2.996 1.9805-1.981 0-3.193-1.3647-3.193-3.5674 0-2.1899 1.238-3.5928 3.186-3.5928 1.924 0 3.085 1.314 3.085 3.4722v0.4697h-4.881v0.0635c0.044 1.2505 0.749 2.0376 1.841 2.0376 0.825 0 1.39-0.3047 1.644-0.8633zm-1.695-4.0688c-1.009 0-1.714 0.7363-1.79 1.8472h3.491c-0.032-1.1172-0.692-1.8472-1.701-1.8472zm8.442-3.2437h3.587c1.79 0 3.021 1.2315 3.021 3.0342 0 1.7647-1.269 2.9961-3.066 2.9961h-2.12v3.1294h-1.422v-9.1597zm1.422 1.1997v3.6372h1.79c1.225 0 1.943-0.6538 1.943-1.8027 0-1.187-0.692-1.8345-1.943-1.8345h-1.79zm6.862 7.96v-6.8936h1.314v1.0474h0.102c0.196-0.6792 0.964-1.168 1.866-1.168 0.203 0 0.463 0.0191 0.609 0.0508v1.2822c-0.114-0.0317-0.52-0.0761-0.762-0.0761-1.034 0-1.764 0.6665-1.764 1.6377v4.1196h-1.365zm7.947 0.1333c-2.025 0-3.262-1.3521-3.262-3.5801 0-2.2217 1.244-3.5801 3.262-3.5801 2.013 0 3.257 1.3521 3.257 3.5801s-1.238 3.5801-3.257 3.5801zm0-1.1616c1.181 0 1.854-0.8887 1.854-2.4185 0-1.5361-0.673-2.4248-1.854-2.4248-1.187 0-1.853 0.8887-1.853 2.4248 0 1.5362 0.666 2.4185 1.853 2.4185zm5.389 1.0283v-5.7827h-1.136v-1.0918h1.136v-0.7427c0-1.3711 0.699-2.0439 2.133-2.0439 0.311 0 0.578 0.0254 0.813 0.0634v1.0284c-0.127-0.0191-0.311-0.0318-0.527-0.0318-0.762 0-1.073 0.3491-1.073 1.0474v0.6792h1.543v1.0918h-1.524v5.7827h-1.365zm5.142-8.125c-0.476 0-0.863-0.3872-0.863-0.8569 0-0.4761 0.387-0.8633 0.863-0.8633s0.863 0.3872 0.863 0.8633c0 0.4697-0.387 0.8569-0.863 0.8569zm-0.679 8.125v-6.8936h1.358v6.8936h-1.358zm3.428 0v-9.5977h1.364v9.5977h-1.364zm7.947-1.8472h1.314c-0.298 1.2188-1.416 1.9805-2.996 1.9805-1.981 0-3.193-1.3647-3.193-3.5674 0-2.1899 1.238-3.5928 3.186-3.5928 1.924 0 3.085 1.314 3.085 3.4722v0.4697h-4.881v0.0635c0.044 1.2505 0.749 2.0376 1.841 2.0376 0.825 0 1.39-0.3047 1.644-0.8633zm-1.695-4.0688c-1.009 0-1.714 0.7363-1.79 1.8472h3.491c-0.031-1.1172-0.692-1.8472-1.701-1.8472zm5.789 6.0112c-0.533 0-0.933-0.3999-0.933-0.914 0-0.5142 0.4-0.9141 0.933-0.9141 0.54 0 0.933 0.3999 0.933 0.9141 0 0.5141-0.393 0.914-0.933 0.914zm4.101 0c-0.533 0-0.933-0.3999-0.933-0.914 0-0.5142 0.4-0.9141 0.933-0.9141 0.539 0 0.933 0.3999 0.933 0.9141 0 0.5141-0.394 0.914-0.933 0.914zm4.1 0c-0.533 0-0.933-0.3999-0.933-0.914 0-0.5142 0.4-0.9141 0.933-0.9141 0.54 0 0.933 0.3999 0.933 0.9141 0 0.5141-0.393 0.914-0.933 0.914z\" fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\"/> </g> <g filter=\"url(#a)\"> <rect transform=\"translate(47 24)\" width=\"425\" height=\"196\" fill=\"var(--vscode-breadcrumbPicker-background, #252526)\"/> <rect x=\"54.5\" y=\"31.5\" width=\"410\" height=\"25\" fill=\"var(--vscode-checkbox-background, #3C3C3C)\"/> <rect x=\"54.5\" y=\"31.5\" width=\"410\" height=\"25\" stroke=\"var(--vscode-focusBorder, #007FD4)\"/> <rect transform=\"translate(47 64)\" width=\"425\" height=\"24\" fill=\"var(--vscode-peekViewEditor-background, #062F4A)\"/> <path d=\"m65.963 79.775v1.2251h-5.8145v-9.1597h5.8145v1.2251h-4.3926v2.6787h4.1577v1.1807h-4.1577v2.8501h4.3926zm1.8979 1.2251v-6.8936h1.314v1.0982h0.1016c0.3046-0.7744 1.0029-1.2315 1.9233-1.2315 0.9458 0 1.5996 0.4888 1.9043 1.2315h0.1079c0.3491-0.7427 1.1426-1.2315 2.1011-1.2315 1.3965 0 2.209 0.8379 2.209 2.2725v4.7544h-1.3648v-4.4243c0-0.9522-0.4443-1.4155-1.3393-1.4155-0.8824 0-1.46 0.6474-1.46 1.479v4.3608h-1.3394v-4.564c0-0.7871-0.5205-1.2758-1.333-1.2758-0.8315 0-1.4599 0.7045-1.4599 1.6059v4.2339h-1.3648zm15.165-7.0142c1.7583 0 2.8691 1.3775 2.8691 3.5674 0 2.1773-1.1108 3.5611-2.8564 3.5611-0.9839 0-1.7647-0.4253-2.1265-1.1553h-0.1079v3.3389h-1.3647v-9.1915h1.3139v1.1426h0.1016c0.4189-0.7871 1.2314-1.2632 2.1709-1.2632zm-0.3872 5.9605c1.1616 0 1.8535-0.895 1.8535-2.3931 0-1.498-0.6919-2.3994-1.8472-2.3994-1.1489 0-1.8662 0.9204-1.8662 2.3994 0 1.4727 0.7173 2.3931 1.8599 2.3931zm5.3828-7.5791h1.3647v1.7583h1.4981v1.0918h-1.4981v3.6372c0 0.7427 0.2984 1.0664 0.9776 1.0664 0.2094 0 0.33-0.0127 0.5205-0.0317v1.0854c-0.2222 0.0381-0.4761 0.0698-0.7427 0.0698-1.5171 0-2.1201-0.5332-2.1201-1.8598v-3.9673h-1.0982v-1.0918h1.0982v-1.7583zm5.1543 11.134c-0.1143 0-0.438-0.0127-0.565-0.0318v-1.1171c0.108 0.019 0.3174 0.0253 0.4444 0.0253 0.6474 0 1.0156-0.2729 1.2505-1.0029l0.1015-0.3555-2.501-6.9126h1.4854l1.7329 5.5225h0.1079l1.7266-5.5225h1.4472l-2.5771 7.211c-0.5903 1.6567-1.2441 2.1836-2.6533 2.1836zm10.34-11.661h3.587c1.79 0 3.021 1.2315 3.021 3.0342 0 1.7647-1.27 2.9961-3.066 2.9961h-2.12v3.1294h-1.422v-9.1597zm1.422 1.1997v3.6372h1.79c1.225 0 1.942-0.6538 1.942-1.8027 0-1.187-0.691-1.8345-1.942-1.8345h-1.79zm6.862 7.96v-6.8936h1.314v1.0474h0.101c0.197-0.6792 0.965-1.168 1.867-1.168 0.203 0 0.463 0.0191 0.609 0.0508v1.2822c-0.114-0.0317-0.521-0.0761-0.762-0.0761-1.034 0-1.764 0.6665-1.764 1.6377v4.1196h-1.365zm7.947 0.1333c-2.025 0-3.263-1.3521-3.263-3.5801 0-2.2217 1.245-3.5801 3.263-3.5801 2.012 0 3.256 1.3521 3.256 3.5801s-1.237 3.5801-3.256 3.5801zm0-1.1616c1.181 0 1.854-0.8887 1.854-2.4185 0-1.5361-0.673-2.4248-1.854-2.4248-1.187 0-1.853 0.8887-1.853 2.4248 0 1.5362 0.666 2.4185 1.853 2.4185zm5.389 1.0283v-5.7827h-1.136v-1.0918h1.136v-0.7427c0-1.3711 0.698-2.0439 2.133-2.0439 0.311 0 0.578 0.0254 0.813 0.0634v1.0284c-0.127-0.0191-0.311-0.0318-0.527-0.0318-0.762 0-1.073 0.3491-1.073 1.0474v0.6792h1.542v1.0918h-1.523v5.7827h-1.365zm5.142-8.125c-0.476 0-0.863-0.3872-0.863-0.8569 0-0.4761 0.387-0.8633 0.863-0.8633s0.863 0.3872 0.863 0.8633c0 0.4697-0.387 0.8569-0.863 0.8569zm-0.679 8.125v-6.8936h1.358v6.8936h-1.358zm3.427 0v-9.5977h1.365v9.5977h-1.365zm7.948-1.8472h1.314c-0.299 1.2188-1.416 1.9805-2.996 1.9805-1.981 0-3.193-1.3647-3.193-3.5674 0-2.1899 1.237-3.5928 3.186-3.5928 1.923 0 3.085 1.314 3.085 3.4722v0.4697h-4.881v0.0635c0.044 1.2505 0.749 2.0376 1.841 2.0376 0.825 0 1.39-0.3047 1.644-0.8633zm-1.695-4.0688c-1.009 0-1.714 0.7363-1.79 1.8472h3.491c-0.032-1.1172-0.692-1.8472-1.701-1.8472z\" fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\"/> <rect x=\"59\" y=\"98\" width=\"62.5\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\"/> <rect x=\"125.5\" y=\"98\" width=\"29\" height=\"6\" rx=\"3\" fill=\"var(--vscode-banner-iconForeground, #3794FF)\" fill-opacity=\".6\"/> <rect x=\"158.5\" y=\"98\" width=\"62.5\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\"/> <g fill=\"var(--vscode-quickInput-foreground, #FFFFFF)\"> <path d=\"m60.149 123.84h3.5865c1.79 0 3.0214 1.232 3.0214 3.035 0 1.764-1.2695 2.996-3.0659 2.996h-2.1201v3.129h-1.4219v-9.16zm1.4219 1.2v3.637h1.79c1.2251 0 1.9424-0.654 1.9424-1.802 0-1.187-0.6919-1.835-1.9424-1.835h-1.79zm7.7632 10.461c-0.1143 0-0.438-0.013-0.565-0.032v-1.117c0.108 0.019 0.3174 0.025 0.4444 0.025 0.6474 0 1.0156-0.273 1.2505-1.002l0.1015-0.356-2.5009-6.913h1.4853l1.7329 5.523h0.1079l1.7266-5.523h1.4473l-2.5772 7.211c-0.5903 1.657-1.2441 2.184-2.6533 2.184zm7.1094-11.134h1.3647v1.758h1.4981v1.092h-1.4981v3.637c0 0.743 0.2983 1.067 0.9775 1.067 0.2095 0 0.3301-0.013 0.5206-0.032v1.086c-0.2222 0.038-0.4761 0.069-0.7427 0.069-1.5171 0-2.1201-0.533-2.1201-1.859v-3.968h-1.0982v-1.092h1.0982v-1.758zm4.5322 8.633v-9.598h1.352v3.803h0.1079c0.3365-0.768 1.0665-1.226 2.1075-1.226 1.4726 0 2.3803 0.934 2.3803 2.565v4.456h-1.3647v-4.132c0-1.137-0.5142-1.701-1.479-1.701-1.1172 0-1.7393 0.717-1.7393 1.796v4.037h-1.3647zm10.791 0.133c-2.0249 0-3.2627-1.352-3.2627-3.58 0-2.221 1.2441-3.58 3.2627-3.58 2.0122 0 3.2563 1.352 3.2563 3.58s-1.2377 3.58-3.2563 3.58zm0-1.161c1.1807 0 1.8535-0.889 1.8535-2.419 0-1.536-0.6728-2.425-1.8535-2.425-1.187 0-1.8535 0.889-1.8535 2.425s0.6665 2.419 1.8535 2.419zm4.9004 1.028v-6.894h1.314v1.092h0.1015c0.3364-0.761 1.022-1.225 2.0635-1.225 1.542 0 2.393 0.921 2.393 2.565v4.462h-1.365v-4.139c0-1.142-0.483-1.701-1.4919-1.701-1.0092 0-1.6504 0.686-1.6504 1.797v4.043h-1.3647z\"/> <path d=\"m60.149 149.84h3.3072c2.7168 0 4.31 1.676 4.31 4.558 0 2.914-1.5806 4.602-4.31 4.602h-3.3072v-9.16zm1.4219 1.225v6.71h1.7266c1.917 0 3.0214-1.225 3.0214-3.358 0-2.114-1.1235-3.352-3.0214-3.352h-1.7266zm10.886 8.068c-2.0249 0-3.2627-1.352-3.2627-3.58 0-2.221 1.2442-3.58 3.2627-3.58 2.0122 0 3.2564 1.352 3.2564 3.58s-1.2378 3.58-3.2564 3.58zm0-1.161c1.1807 0 1.8535-0.889 1.8535-2.419 0-1.536-0.6728-2.425-1.8535-2.425-1.187 0-1.8535 0.889-1.8535 2.425s0.6665 2.419 1.8535 2.419zm10.753-3.65h-1.3267c-0.1587-0.673-0.7173-1.187-1.6313-1.187-1.1426 0-1.8409 0.901-1.8409 2.393 0 1.523 0.7046 2.444 1.8409 2.444 0.8632 0 1.4536-0.407 1.6313-1.156h1.3267c-0.1778 1.359-1.2442 2.317-2.9517 2.317-2.0122 0-3.2437-1.371-3.2437-3.605 0-2.19 1.2251-3.555 3.2374-3.555 1.7329 0 2.7802 1.009 2.958 2.349zm10.467-2.171-1.9614 6.849h-1.3457l-2.4692-9.16h1.479l1.6821 7.122h0.0889l1.9106-7.122h1.3203l1.9234 7.122h0.0888l1.6758-7.122h1.479l-2.4756 9.16h-1.3393l-1.9678-6.849h-0.0889zm7.0268 6.849v-6.894h1.314v1.048h0.102c0.196-0.679 0.964-1.168 1.866-1.168 0.203 0 0.463 0.019 0.609 0.051v1.282c-0.114-0.032-0.52-0.076-0.762-0.076-1.034 0-1.764 0.666-1.764 1.637v4.12h-1.365zm5.91-8.125c-0.476 0-0.864-0.387-0.864-0.857 0-0.476 0.388-0.863 0.864-0.863s0.863 0.387 0.863 0.863c0 0.47-0.387 0.857-0.863 0.857zm-0.679 8.125v-6.894h1.358v6.894h-1.358zm3.846-8.633h1.365v1.758h1.498v1.092h-1.498v3.637c0 0.743 0.298 1.067 0.978 1.067 0.209 0 0.33-0.013 0.52-0.032v1.086c-0.222 0.038-0.476 0.069-0.743 0.069-1.517 0-2.12-0.533-2.12-1.859v-3.968h-1.098v-1.092h1.098v-1.758zm8.925 6.786h1.314c-0.298 1.219-1.416 1.98-2.996 1.98-1.981 0-3.193-1.364-3.193-3.567 0-2.19 1.238-3.593 3.187-3.593 1.923 0 3.085 1.314 3.085 3.472v0.47h-4.882v0.064c0.045 1.25 0.749 2.037 1.841 2.037 0.825 0 1.39-0.305 1.644-0.863zm-1.695-4.069c-1.009 0-1.714 0.736-1.79 1.847h3.491c-0.031-1.117-0.691-1.847-1.701-1.847zm4.729 5.916v-6.894h1.314v1.048h0.102c0.197-0.679 0.965-1.168 1.866-1.168 0.203 0 0.463 0.019 0.609 0.051v1.282c-0.114-0.032-0.52-0.076-0.761-0.076-1.035 0-1.765 0.666-1.765 1.637v4.12h-1.365z\"/> </g> <rect x=\"59\" y=\"178\" width=\"26\" height=\"6\" rx=\"3\" fill=\"var(--vscode-banner-iconForeground, #3794FF)\" fill-opacity=\".6\"/> <rect x=\"89\" y=\"178\" width=\"164\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\"/> <rect x=\"59\" y=\"200\" width=\"46\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\"/> <rect x=\"109\" y=\"200\" width=\"29\" height=\"6\" rx=\"3\" fill=\"var(--vscode-banner-iconForeground, #3794FF)\" fill-opacity=\".6\"/> <rect x=\"142\" y=\"200\" width=\"46\" height=\"6\" rx=\"3\" fill=\"var(--vscode-editorOverviewRuler-commonContentForeground, #606060)\"/> </g> <defs> <filter id=\"a\" x=\"31\" y=\"10\" width=\"457\" height=\"228\" color-interpolation-filters=\"sRGB\" filterUnits=\"userSpaceOnUse\"> <feFlood flood-opacity=\"0\" result=\"BackgroundImageFix\"/> <feColorMatrix in=\"SourceAlpha\" result=\"hardAlpha\" values=\"0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 127 0\"/> <feOffset dy=\"2\"/> <feGaussianBlur stdDeviation=\"8\"/> <feColorMatrix values=\"0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.36 0\"/> <feBlend in2=\"BackgroundImageFix\" result=\"effect1_dropShadow_1_138\"/> <feBlend in=\"SourceGraphic\" in2=\"effect1_dropShadow_1_138\" result=\"shape\"/> </filter> <clipPath id=\"c\"> <rect width=\"520\" height=\"238\" fill=\"var(--vscode-activityBar-activeBorder, #FFFFFF)\"/> </clipPath> <clipPath id=\"b\"> <rect width=\"115.65\" height=\"39.3\" fill=\"var(--vscode-activityBar-activeBorder, #FFFFFF)\"/> </clipPath> </defs> </ins> </svg>", "commid": "vscode_pr_187019"}], "negative_passages": []}
{"query_id": "q-en-vscode-f40436ac8a948d027b0480a9929d9003241f561262ce79334bdafd91eed38f34", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VSCode have add a new keybinding for , so, remenber to add ctrl+i for toggleSuggestionDetails which is usiing the same let add this !", "positive_passages": [{"docid": "doc-en-vscode-4852ffef50fcb26cf7d4fdffebfa14906c65c090d0952bb5ff126e777acd0bff", "text": "weight: weight, kbExpr: EditorContextKeys.textInputFocus, primary: KeyMod.CtrlCmd | KeyCode.Space, <del> mac: { primary: KeyMod.WinCtrl | KeyCode.Space } </del> <ins> secondary: [KeyMod.CtrlCmd | KeyCode.KEY_I], mac: { primary: KeyMod.WinCtrl | KeyCode.Space, secondary: [KeyMod.CtrlCmd | KeyCode.KEY_I] } </ins> }, menuOpts: [{ menuId: suggestWidgetStatusbarMenu,", "commid": "vscode_pr_131976"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a8e0ee6c88486e58802cc1ffeb8ac582094f9b70676ddff011add1ab671237c", "query": "Issue Type: <bFeature Request</bWhen foldind HTML tags inside JSX code, the closing tag is hidden and sometimes this make the understanding of the code a little bit confusing. Also, copying the folded code becomes a bit difficult. I was wondering if its possilble to make it work like in HTML, where when you fold a tag it is possible to see both opening and closing tags. Imagine that we have this JSX code: When we fold the tag, it is displayed like this: In HTML the code will be like this, showing the closing tag: so its easier to copy the code and understand the structure VS Code version: Code 1.59.1 (, 2021-08-19T11:54:37.513Z) OS version: Linux x64 5.11.0-31-generic Restricted Mode: No <!-- generated by issue reporter --\nRelevant code:\nHi, would love to take this on as my first contribution!", "positive_passages": [{"docid": "doc-en-vscode-667d2e2653758e0165294206f4ffa62a660e2dbc2bda39f26724805c91f9366c", "text": "return new vscode.FoldingRange(start, end, kind); } <del> private static readonly foldEndPairCharacters = ['}', ']', ')', '`']; </del> <ins> private static readonly foldEndPairCharacters = ['}', ']', ')', '`', '>']; </ins> private adjustFoldingEnd(range: vscode.Range, document: vscode.TextDocument) { // workaround for #47240", "commid": "vscode_pr_132316"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-45566beae4a1b0349abc7ffaa16885aa916f9670f68b511e0b0abefbb695e408", "text": "return; } const title = this.getTooltip() ?? ''; <del> this.updateAriaLabel(); </del> <ins> this.updateAriaLabel(title); </ins> if (!this.options.hoverDelegate) { this.element.title = title; } else {", "commid": "vscode_pr_197965"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-ed77ab7bb1c941a1b85c7a8950cf273d43005d1c5dfefcd148b0ff989600d796", "text": "} } <del> protected updateAriaLabel(): void { </del> <ins> protected updateAriaLabel(title: string): void { </ins> if (this.element) { <del> const title = this.getTooltip() ?? ''; </del> this.element.setAttribute('aria-label', title); } }", "commid": "vscode_pr_197965"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-1362c88f3035659500dfb0f9bfc0d5cdfda931fb8d4101882609bfa4f38b5d27", "text": "} } <del> protected override updateAriaLabel(): void { </del> <ins> protected override updateAriaLabel(title: string): void { </ins> if (this.label) { <del> const title = this.getTooltip() ?? ''; </del> this.label.setAttribute('aria-label', title); <ins> this.label.title = title; </ins> } }", "commid": "vscode_pr_197965"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-f0abd91d315288ebff06c763e877d38371c693ba9be715bd8f112bc9f6ae6136", "text": "autoplayPolicy: 'user-gesture-required', // Enable experimental css highlight api https://chromestatus.com/feature/5436441440026624 // Refs https://github.com/microsoft/vscode/issues/140098 <del> enableBlinkFeatures: 'HighlightAPI', </del> <ins> enableBlinkFeatures: 'HighlightAPI, KeyboardAccessibleTooltip', </ins> ...overrides?.webPreferences, sandbox: true },", "commid": "vscode_pr_197965"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-86eb71fada9cce8e8d7bf7f20076f2995f249e1e542603e707766b31b1c21898", "text": "render(container: HTMLElement): void { // file/folder const label = this._labels.create(container); <ins> this._disposables.add(label.onDidRender(() => { container.title = container.children[0]?.ariaLabel ?? ''; })); </ins> label.setFile(this.element.uri, { hidePath: true, hideIcon: this.element.kind === FileKind.FOLDER || !this.options.showFileIcons,", "commid": "vscode_pr_197965"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-ec09e9f9240f548e2bd634e735c27fa64b40ac5c628a72776827ccd262473dfa", "text": "renderElement(node: ITreeNode<OutlineElement, FuzzyScore>, _index: number, template: DocumentSymbolTemplate): void { const { element } = node; const extraClasses = ['nowrap']; <ins> const title = localize('title.template', \"{0} ({1})\", element.symbol.name, symbolKindNames[element.symbol.kind]); </ins> const options: IIconLabelValueOptions = { matches: createMatches(node.filterData), labelEscapeNewLines: true, extraClasses, <del> title: localize('title.template', \"{0} ({1})\", element.symbol.name, symbolKindNames[element.symbol.kind]) </del> <ins> title </ins> }; <ins> template.container.title = title; </ins> if (this._configurationService.getValue(OutlineConfigKeys.icons)) { // add styles for the icons template.iconClass.className = '';", "commid": "vscode_pr_197965"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-6d1acd95a2a805c67fc3d6a1419a9f6615beb1fbdbfe782b7ecb30226053111d", "text": "hoverPreparation = toDispose; }; const mouseOverDomEmitter = dom.addDisposableListener(htmlElement, dom.EventType.MOUSE_OVER, onMouseOver, true); <ins> const onFocus = () => { if (hoverPreparation) { return; } const target: IHoverDelegateTarget = { targetElements: [htmlElement], dispose: () => { } }; const toDispose: DisposableStore = new DisposableStore(); const onBlur = () => hideHover(true, true); toDispose.add(dom.addDisposableListener(htmlElement, dom.EventType.BLUR, onBlur, true)); toDispose.add(triggerShowHover(hoverDelegate.delay, false, target)); hoverPreparation = toDispose; }; const focusDomEmitter = dom.addDisposableListener(htmlElement, dom.EventType.FOCUS, onFocus, true); </ins> const hover: ICustomHover = { show: focus => { hideHover(false, true); // terminate a ongoing mouse over preparation", "commid": "vscode_pr_199220"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc46fe919a87f6cc2de9a67c5b9e7482b0e14c1af5af262dc19377185788e455", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 (user setup) OS Version: Windows 10 Steps to Reproduce: through VS Code Search tab and tab through all the buttons . ( refresh , clear search results , etc. ) ( Search tab is just an example I can see the same behavior in all buttons) Expected : On the tab navigation to each of the button, the tooltip should be displayed. On escape the tooltip should be dismissed. Keyboard users will not know what is the use of the button through the icon for the button. Actual : User cannot see the tooltip when they tab into a button. They can only see the tooltip when they hover over. !\n, Hey, I search to see if there is something already open but couldn't find it. I hope it is not a duplicate.\nDup of Reasons why we are not changing this still hold which I mentioned Leaving this open for tracking purposes.\nGitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.3.3;#A11ySev3;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Keyboard;#CEACCReviewed;\nRemoving label because we got confirmation from the testing team that this can be moved to Severity 3. Reasoning why this is Severity 3 can be found\nHi , we met the same issue. In our Teams Toolkit extension, we have several buttons on tree items. When user tab to the buttons with keyboard, tooltip will not show: ! Accessibility team has raised a Sev2 bug to us for this issue. Is it possible to fix this?\nsame issue seen in bug\nIt can be done in one line due to a contribution by the Edge team to Chromium However, loads of tooltips don't show up, eg this toolbar (top right)- ! Maybe because is on an element which inherits the attribute from a parent element. This can be reproduced on as well.\nthanks for investigating. When I make that change, I don't see it working for any of the buttons. Which work for you?\nHi, iirc it worked on New Search Editor, Search (text box), Replace (text input) and the icons in the activity bar. By the way, I noticed then that is missing in the activity bar.\nwhen I test with the above change, it doesn't work for me for any of the buttons. I looked at the docs and it should be supported. Any clue why that would be?\nyou need to close and reopen after making the change. Reload Window wouldn't be enough. You can also visit in Edge and it should have the same behaviour.\nThanks, yeah, I run OSS to test, which should work, but doesn't.\nIt looks like we'd need to move all native hovers over to using custom ones to do this.\nI sent a draft PR and explained there in more detail what works and doesn't work. (Tested on Windows 10)\nI am reverting this for now because we don't want multiple tooltips showing up on hover. I'll try to investigate in December.\nRemoving these lines, IE the custom hover, fixes the issue, but I worry about making this change so close to the release: it looks to me like we are using custom hovers all over the place because we didn't have this flag enabled before. Do you think we can consider removing those in favor of the native ones?\nthe custom hovers are better for accessibility as they're exposed to the screen reader. The eventual plan is to move to custom hovers throughout the workbench. Generally if the custom hover is being used a should not be present.\nPartially blocked by\nisn't this separate to adopting it in different places? I would have expected us to need a focus handler to show the hover for that specific case\nThis can be closed when happens\nBen has adopted the custom hover in our base widgets, so this may now be easier than before?\nKai mentioned I should consider adding a delay like we have for mouse hovers here. I need to see if this is acceptable by accessibility standards.\nAFAICT, the WAI-ARIA guidelines do not specify that there cannot be a delay.\nit seems like this already works thanks to your changes\nWhen I tested on native Windows explorer, I saw a delay even when using keyboard, so it seems the same delay should apply for keyboard and mouse.\nCurrently the mouse and keyboard delays are exactly the same which is what we want. We do not have delays where we support instant hover such as navigating between action items on a toolbar/actionbar. FYI: pressing closes the hover\nawesome work!", "positive_passages": [{"docid": "doc-en-vscode-67d38e89b04c08c05abd3c2398485d5e21bfcb9365c7db0010961cd494ccc68a", "text": "}, dispose: () => { mouseOverDomEmitter.dispose(); <ins> focusDomEmitter.dispose(); </ins> hideHover(true, true); } };", "commid": "vscode_pr_199220"}], "negative_passages": []}
{"query_id": "q-en-vscode-7874fb157ca85f40a7c69380459fb3ad76de5cd2bbd54c826b73df634e861576", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !\nPlease let me know soon if we should release this with our Recovery Release tomorrow!\nThanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!\ncan you verify that the issue is fixed in todays insider build?\nAs he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-4ed13dde6bcc9873f6b590222e850bbc574db9342e75e7a3fbf8493cc9022851", "text": "} })); <ins> this._register(toDisposable(() => { this.cache.clear(); })); </ins> this._register(this.editor.onDidChangeCursorPosition((e) => { if (this.cache.value) { this.onDidChangeEmitter.fire();", "commid": "vscode_pr_132628"}], "negative_passages": []}
{"query_id": "q-en-vscode-7874fb157ca85f40a7c69380459fb3ad76de5cd2bbd54c826b73df634e861576", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !\nPlease let me know soon if we should release this with our Recovery Release tomorrow!\nThanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!\ncan you verify that the issue is fixed in todays insider build?\nAs he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-938ba28d8f76e0a34e354e4d7a6becf01bd72c3b3e154be4b771b02430bf6092", "text": "]); }); }); <ins> test('Do not reuse cache from previous session (#132516)', async function () { const provider = new MockInlineCompletionsProvider(); await withAsyncTestCodeEditorAndInlineCompletionsModel('', { fakeClock: true, provider, inlineSuggest: { enabled: true } }, async ({ editor, editorViewModel, model, context }) => { model.setActive(true); context.keyboardType('hellon'); context.cursorLeft(); provider.setReturnValue({ text: 'helloworld', range: new Range(1, 1, 1, 6) }, 1000); await timeout(2000); assert.deepStrictEqual(provider.getAndClearCallHistory(), [ { position: '(1,6)', text: 'hellon', triggerKind: 0, } ]); provider.setReturnValue({ text: 'helloworld', range: new Range(2, 1, 2, 6) }, 1000); context.cursorDown(); context.keyboardType('hello'); await timeout(100); context.cursorLeft(); // Cause the ghost text to update context.cursorRight(); await timeout(2000); assert.deepStrictEqual(provider.getAndClearCallHistory(), [ { position: '(2,6)', text: 'hellonhello', triggerKind: 0, } ]); assert.deepStrictEqual(context.getAndClearViewStates(), [ '', 'hello[world]n', 'hellon', 'hellonhello[world]', ]); }); }); </ins> }); async function withAsyncTestCodeEditorAndInlineCompletionsModel<T>(", "commid": "vscode_pr_132628"}], "negative_passages": []}
{"query_id": "q-en-vscode-7874fb157ca85f40a7c69380459fb3ad76de5cd2bbd54c826b73df634e861576", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !\nPlease let me know soon if we should release this with our Recovery Release tomorrow!\nThanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!\ncan you verify that the issue is fixed in todays insider build?\nAs he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-a7683e9df4b610ea92128e8658e0cff2d492f57d8454b36c373f520365bcb9ed", "text": "import { timeout } from 'vs/base/common/async'; import { CancellationToken } from 'vs/base/common/cancellation'; import { Disposable } from 'vs/base/common/lifecycle'; <del> import { CoreEditingCommands } from 'vs/editor/browser/controller/coreCommands'; </del> <ins> import { CoreEditingCommands, CoreNavigationCommands } from 'vs/editor/browser/controller/coreCommands'; </ins> import { Position } from 'vs/editor/common/core/position'; import { ITextModel } from 'vs/editor/common/model'; import { InlineCompletionsProvider, InlineCompletion, InlineCompletionContext } from 'vs/editor/common/modes';", "commid": "vscode_pr_132628"}], "negative_passages": []}
{"query_id": "q-en-vscode-7874fb157ca85f40a7c69380459fb3ad76de5cd2bbd54c826b73df634e861576", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !\nPlease let me know soon if we should release this with our Recovery Release tomorrow!\nThanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!\ncan you verify that the issue is fixed in todays insider build?\nAs he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!", "positive_passages": [{"docid": "doc-en-vscode-08bdfdd834fcab2a360696e44d150d0bfbcea71db82ac479ce303b869963aa97", "text": "this.editor.trigger('keyboard', 'type', { text }); } <ins> public cursorUp(): void { CoreNavigationCommands.CursorUp.runEditorCommand(null, this.editor, null); } public cursorRight(): void { CoreNavigationCommands.CursorRight.runEditorCommand(null, this.editor, null); } public cursorLeft(): void { CoreNavigationCommands.CursorLeft.runEditorCommand(null, this.editor, null); } public cursorDown(): void { CoreNavigationCommands.CursorDown.runEditorCommand(null, this.editor, null); } public cursorLineEnd(): void { CoreNavigationCommands.CursorLineEnd.runEditorCommand(null, this.editor, null); } </ins> public leftDelete(): void { CoreEditingCommands.DeleteLeft.runEditorCommand(null, this.editor, null); }", "commid": "vscode_pr_132628"}], "negative_passages": []}
{"query_id": "q-en-vscode-870921397260b1476160bfe686734efdcc1c1c23c42c255d6112dd0122eeeaea", "query": "<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.59.1 Extension version (available under the Extensions sidebar): v2021.8. OS and version: Linux x64 5.13.11-1-MANJARO Python version (& distribution if applicable, e.g. Anaconda): 3.9 Type of virtual environment used (N/A ...): virtualenvwrapper Relevant/affected Python-related VS Code extensions and their versions: pylance v2021.8.3, jupyter v2021.8., Visual Studio IntelliCode v1.2.14 Value of the setting: Pylance from the VS Code marketplace to see if that fixes your issue] Extension loads successfuly Extension does not load, console reports \"Unexpected token ' in JSON at position \" [NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue] the extension by clicking a .py file <!-- Note: If you think a GIF of what is happening would be helpful, consider tools like , or . --<details<summaryOutput for <codePython</codein the <codeOutput</codepanel (<codeView</code\u2192<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codePython</code) </summary<p</p</details\nLooks like you might have a bad update. Do the following to remove stale versions of the extension: Python extension (if you have pylance uninstall it first). all instances of VS Code. to, (on windows) or on Linux/Mac. any folder with the name starting with VS Code, and install Python extension (also pylance if you uninstalled it in step 1).\nI followed all steps, but nothing changed. should I try to install older version of python ext?\nHi Can you try installing an older version of the Python extension, and if it doesn't work can you try a different version of VS Code (either an old one or the Insiders build)?\nI've installed python extension , jupyter and no pylance. here's the log: As you said I'm going to install older version of vscode\nHi Did you try installing an older version of VS Code?\nFYI - This looks like some JSON stored via the became corrupt. The JSON is written a few lines lower, so it is unexpected that the value is corrupted. This might indicate some kind of bug in the storage layer. I don't remember writing that code, did you perhaps write that? Do you think it is so important such to fail extension activation when the JSON is corrupt, or should we catch that exception and return ?\nI would suggest to be more resilient in extension activation as you suggest and fallback to an empty object here if any error rises from but log it as error: This is the first time I hear about a problem with persisting data into SQLite. However, seeing makes me think that this is not an officially supported Linux distribution.\ncurious if you could share the following 2 files with me (via e-mail is fine: find it on ). Steps: open the VSCode window where this issue happens View Command Palette =Log Storage Database Contents Help Toggle Dev Tools Find the 2 paths for the DBs send both files to me\nI can still see the original issue in vscode-insiders v1.61.0-insider\nwhats the exact version you are on? And is it the issue that the extension fails to activate?\nVersion: 1.61.0-insider (user setup) Commit: Date: 2021-09-16T08:31:28.161Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: WindowsNT x64 10.0. python extension: v2021.9. Error 2021-09-16 17:51:12: Error discovering pytest tests: [SyntaxError: Unexpected token S in JSON at position at (<anonymous) at a.runTestDiscovery (PATH.vscode-insidersextensionsms-outclient) at runMicrotasks (<anonymous) at processTicksAndRejections () at async (index 0) at async _.refreshTestData (PATH.vscode-insidersextensionsms-outclient) at async v.refreshTestDataInternal (PATH.vscode-insidersextensionsms-outclient)] { stdout: '[{\"rootid\": \".\", \"root\": \"...\nI fixed the issue as reported in that extensions fail to activate when the contents in storage fail to get parsed. What you report here seems different to me. Looks like the python extension is calling on something that is not valid JSON? Have you asked the Python extension what this could be?\nI see, I'll create a new issue. thanks", "positive_passages": [{"docid": "doc-en-vscode-d9355bf30060e3d3008d3a5a7a777b9aa16fa8303f89f429d624571c2301c39a", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; import 'mocha'; import { ExtensionContext, extensions } from 'vscode'; suite('vscode API - globalState / workspaceState', () => { let extensionContext: ExtensionContext; suiteSetup(async () => { // Trigger extension activation and grab the context as some tests depend on it await extensions.getExtension('vscode.vscode-api-tests')?.activate(); extensionContext = (global as any).testExtensionContext; }); test.only('state', async () => { for (const state of [extensionContext.globalState, extensionContext.workspaceState]) { let keys = state.keys(); assert.strictEqual(keys.length, 0); let res = state.get('state.test.get', 'default'); assert.strictEqual(res, 'default'); await state.update('state.test.get', 'testvalue'); keys = state.keys(); assert.strictEqual(keys.length, 1); assert.strictEqual(keys[0], 'state.test.get'); res = state.get('state.test.get', 'default'); assert.strictEqual(res, 'testvalue'); await state.update('state.test.get', undefined); keys = state.keys(); assert.strictEqual(keys.length, 0); res = state.get('state.test.get', 'default'); assert.strictEqual(res, 'default'); } }); }); </ins>", "commid": "vscode_pr_133071"}], "negative_passages": []}
{"query_id": "q-en-vscode-870921397260b1476160bfe686734efdcc1c1c23c42c255d6112dd0122eeeaea", "query": "<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.59.1 Extension version (available under the Extensions sidebar): v2021.8. OS and version: Linux x64 5.13.11-1-MANJARO Python version (& distribution if applicable, e.g. Anaconda): 3.9 Type of virtual environment used (N/A ...): virtualenvwrapper Relevant/affected Python-related VS Code extensions and their versions: pylance v2021.8.3, jupyter v2021.8., Visual Studio IntelliCode v1.2.14 Value of the setting: Pylance from the VS Code marketplace to see if that fixes your issue] Extension loads successfuly Extension does not load, console reports \"Unexpected token ' in JSON at position \" [NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue] the extension by clicking a .py file <!-- Note: If you think a GIF of what is happening would be helpful, consider tools like , or . --<details<summaryOutput for <codePython</codein the <codeOutput</codepanel (<codeView</code\u2192<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codePython</code) </summary<p</p</details\nLooks like you might have a bad update. Do the following to remove stale versions of the extension: Python extension (if you have pylance uninstall it first). all instances of VS Code. to, (on windows) or on Linux/Mac. any folder with the name starting with VS Code, and install Python extension (also pylance if you uninstalled it in step 1).\nI followed all steps, but nothing changed. should I try to install older version of python ext?\nHi Can you try installing an older version of the Python extension, and if it doesn't work can you try a different version of VS Code (either an old one or the Insiders build)?\nI've installed python extension , jupyter and no pylance. here's the log: As you said I'm going to install older version of vscode\nHi Did you try installing an older version of VS Code?\nFYI - This looks like some JSON stored via the became corrupt. The JSON is written a few lines lower, so it is unexpected that the value is corrupted. This might indicate some kind of bug in the storage layer. I don't remember writing that code, did you perhaps write that? Do you think it is so important such to fail extension activation when the JSON is corrupt, or should we catch that exception and return ?\nI would suggest to be more resilient in extension activation as you suggest and fallback to an empty object here if any error rises from but log it as error: This is the first time I hear about a problem with persisting data into SQLite. However, seeing makes me think that this is not an officially supported Linux distribution.\ncurious if you could share the following 2 files with me (via e-mail is fine: find it on ). Steps: open the VSCode window where this issue happens View Command Palette =Log Storage Database Contents Help Toggle Dev Tools Find the 2 paths for the DBs send both files to me\nI can still see the original issue in vscode-insiders v1.61.0-insider\nwhats the exact version you are on? And is it the issue that the extension fails to activate?\nVersion: 1.61.0-insider (user setup) Commit: Date: 2021-09-16T08:31:28.161Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: WindowsNT x64 10.0. python extension: v2021.9. Error 2021-09-16 17:51:12: Error discovering pytest tests: [SyntaxError: Unexpected token S in JSON at position at (<anonymous) at a.runTestDiscovery (PATH.vscode-insidersextensionsms-outclient) at runMicrotasks (<anonymous) at processTicksAndRejections () at async (index 0) at async _.refreshTestData (PATH.vscode-insidersextensionsms-outclient) at async v.refreshTestDataInternal (PATH.vscode-insidersextensionsms-outclient)] { stdout: '[{\"rootid\": \".\", \"root\": \"...\nI fixed the issue as reported in that extensions fail to activate when the contents in storage fail to get parsed. What you report here seems different to me. Looks like the python extension is calling on something that is not valid JSON? Have you asked the Python extension what this could be?\nI see, I'll create a new issue. thanks", "positive_passages": [{"docid": "doc-en-vscode-6685798bf2ec6ac7451bcdd6a2f61d7fcf59b297186528ce77e4c28e5b2d80dc", "text": "import { extHostNamedCustomer } from 'vs/workbench/api/common/extHostCustomers'; import { IDisposable } from 'vs/base/common/lifecycle'; import { IExtensionIdWithVersion, IExtensionsStorageSyncService } from 'vs/platform/userDataSync/common/extensionsStorageSync'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> @extHostNamedCustomer(MainContext.MainThreadStorage) export class MainThreadStorage implements MainThreadStorageShape {", "commid": "vscode_pr_133071"}], "negative_passages": []}
{"query_id": "q-en-vscode-870921397260b1476160bfe686734efdcc1c1c23c42c255d6112dd0122eeeaea", "query": "<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.59.1 Extension version (available under the Extensions sidebar): v2021.8. OS and version: Linux x64 5.13.11-1-MANJARO Python version (& distribution if applicable, e.g. Anaconda): 3.9 Type of virtual environment used (N/A ...): virtualenvwrapper Relevant/affected Python-related VS Code extensions and their versions: pylance v2021.8.3, jupyter v2021.8., Visual Studio IntelliCode v1.2.14 Value of the setting: Pylance from the VS Code marketplace to see if that fixes your issue] Extension loads successfuly Extension does not load, console reports \"Unexpected token ' in JSON at position \" [NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue] the extension by clicking a .py file <!-- Note: If you think a GIF of what is happening would be helpful, consider tools like , or . --<details<summaryOutput for <codePython</codein the <codeOutput</codepanel (<codeView</code\u2192<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codePython</code) </summary<p</p</details\nLooks like you might have a bad update. Do the following to remove stale versions of the extension: Python extension (if you have pylance uninstall it first). all instances of VS Code. to, (on windows) or on Linux/Mac. any folder with the name starting with VS Code, and install Python extension (also pylance if you uninstalled it in step 1).\nI followed all steps, but nothing changed. should I try to install older version of python ext?\nHi Can you try installing an older version of the Python extension, and if it doesn't work can you try a different version of VS Code (either an old one or the Insiders build)?\nI've installed python extension , jupyter and no pylance. here's the log: As you said I'm going to install older version of vscode\nHi Did you try installing an older version of VS Code?\nFYI - This looks like some JSON stored via the became corrupt. The JSON is written a few lines lower, so it is unexpected that the value is corrupted. This might indicate some kind of bug in the storage layer. I don't remember writing that code, did you perhaps write that? Do you think it is so important such to fail extension activation when the JSON is corrupt, or should we catch that exception and return ?\nI would suggest to be more resilient in extension activation as you suggest and fallback to an empty object here if any error rises from but log it as error: This is the first time I hear about a problem with persisting data into SQLite. However, seeing makes me think that this is not an officially supported Linux distribution.\ncurious if you could share the following 2 files with me (via e-mail is fine: find it on ). Steps: open the VSCode window where this issue happens View Command Palette =Log Storage Database Contents Help Toggle Dev Tools Find the 2 paths for the DBs send both files to me\nI can still see the original issue in vscode-insiders v1.61.0-insider\nwhats the exact version you are on? And is it the issue that the extension fails to activate?\nVersion: 1.61.0-insider (user setup) Commit: Date: 2021-09-16T08:31:28.161Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: WindowsNT x64 10.0. python extension: v2021.9. Error 2021-09-16 17:51:12: Error discovering pytest tests: [SyntaxError: Unexpected token S in JSON at position at (<anonymous) at a.runTestDiscovery (PATH.vscode-insidersextensionsms-outclient) at runMicrotasks (<anonymous) at processTicksAndRejections () at async (index 0) at async _.refreshTestData (PATH.vscode-insidersextensionsms-outclient) at async v.refreshTestDataInternal (PATH.vscode-insidersextensionsms-outclient)] { stdout: '[{\"rootid\": \".\", \"root\": \"...\nI fixed the issue as reported in that extensions fail to activate when the contents in storage fail to get parsed. What you report here seems different to me. Looks like the python extension is calling on something that is not valid JSON? Have you asked the Python extension what this could be?\nI see, I'll create a new issue. thanks", "positive_passages": [{"docid": "doc-en-vscode-2f3c555b661ce5aa8a1e420cd23bc8fc5251cd61bbe2685283ecd2db322d7013", "text": "extHostContext: IExtHostContext, @IStorageService storageService: IStorageService, @IExtensionsStorageSyncService extensionsStorageSyncService: IExtensionsStorageSyncService, <ins> @ILogService private readonly _logService: ILogService </ins> ) { this._storageService = storageService; this._extensionsStorageSyncService = extensionsStorageSyncService;", "commid": "vscode_pr_133071"}], "negative_passages": []}
{"query_id": "q-en-vscode-870921397260b1476160bfe686734efdcc1c1c23c42c255d6112dd0122eeeaea", "query": "<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.59.1 Extension version (available under the Extensions sidebar): v2021.8. OS and version: Linux x64 5.13.11-1-MANJARO Python version (& distribution if applicable, e.g. Anaconda): 3.9 Type of virtual environment used (N/A ...): virtualenvwrapper Relevant/affected Python-related VS Code extensions and their versions: pylance v2021.8.3, jupyter v2021.8., Visual Studio IntelliCode v1.2.14 Value of the setting: Pylance from the VS Code marketplace to see if that fixes your issue] Extension loads successfuly Extension does not load, console reports \"Unexpected token ' in JSON at position \" [NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue] the extension by clicking a .py file <!-- Note: If you think a GIF of what is happening would be helpful, consider tools like , or . --<details<summaryOutput for <codePython</codein the <codeOutput</codepanel (<codeView</code\u2192<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codePython</code) </summary<p</p</details\nLooks like you might have a bad update. Do the following to remove stale versions of the extension: Python extension (if you have pylance uninstall it first). all instances of VS Code. to, (on windows) or on Linux/Mac. any folder with the name starting with VS Code, and install Python extension (also pylance if you uninstalled it in step 1).\nI followed all steps, but nothing changed. should I try to install older version of python ext?\nHi Can you try installing an older version of the Python extension, and if it doesn't work can you try a different version of VS Code (either an old one or the Insiders build)?\nI've installed python extension , jupyter and no pylance. here's the log: As you said I'm going to install older version of vscode\nHi Did you try installing an older version of VS Code?\nFYI - This looks like some JSON stored via the became corrupt. The JSON is written a few lines lower, so it is unexpected that the value is corrupted. This might indicate some kind of bug in the storage layer. I don't remember writing that code, did you perhaps write that? Do you think it is so important such to fail extension activation when the JSON is corrupt, or should we catch that exception and return ?\nI would suggest to be more resilient in extension activation as you suggest and fallback to an empty object here if any error rises from but log it as error: This is the first time I hear about a problem with persisting data into SQLite. However, seeing makes me think that this is not an officially supported Linux distribution.\ncurious if you could share the following 2 files with me (via e-mail is fine: find it on ). Steps: open the VSCode window where this issue happens View Command Palette =Log Storage Database Contents Help Toggle Dev Tools Find the 2 paths for the DBs send both files to me\nI can still see the original issue in vscode-insiders v1.61.0-insider\nwhats the exact version you are on? And is it the issue that the extension fails to activate?\nVersion: 1.61.0-insider (user setup) Commit: Date: 2021-09-16T08:31:28.161Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: WindowsNT x64 10.0. python extension: v2021.9. Error 2021-09-16 17:51:12: Error discovering pytest tests: [SyntaxError: Unexpected token S in JSON at position at (<anonymous) at a.runTestDiscovery (PATH.vscode-insidersextensionsms-outclient) at runMicrotasks (<anonymous) at processTicksAndRejections () at async (index 0) at async _.refreshTestData (PATH.vscode-insidersextensionsms-outclient) at async v.refreshTestDataInternal (PATH.vscode-insidersextensionsms-outclient)] { stdout: '[{\"rootid\": \".\", \"root\": \"...\nI fixed the issue as reported in that extensions fail to activate when the contents in storage fail to get parsed. What you report here seems different to me. Looks like the python extension is calling on something that is not valid JSON? Have you asked the Python extension what this could be?\nI see, I'll create a new issue. thanks", "positive_passages": [{"docid": "doc-en-vscode-84fc9e81451427a08e65a0191e314fb1da6bfe4c220b30a02971bc5adb9ac1f4", "text": "this._storageListener = this._storageService.onDidChangeValue(e => { const shared = e.scope === StorageScope.GLOBAL; if (shared && this._sharedStorageKeysToWatch.has(e.key)) { <del> try { this._proxy.$acceptValue(shared, e.key, this._getValue(shared, e.key)); } catch (error) { // ignore parsing errors that can happen } </del> <ins> this._proxy.$acceptValue(shared, e.key, this._getValue(shared, e.key)); </ins> } }); }", "commid": "vscode_pr_133071"}], "negative_passages": []}
{"query_id": "q-en-vscode-870921397260b1476160bfe686734efdcc1c1c23c42c255d6112dd0122eeeaea", "query": "<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.59.1 Extension version (available under the Extensions sidebar): v2021.8. OS and version: Linux x64 5.13.11-1-MANJARO Python version (& distribution if applicable, e.g. Anaconda): 3.9 Type of virtual environment used (N/A ...): virtualenvwrapper Relevant/affected Python-related VS Code extensions and their versions: pylance v2021.8.3, jupyter v2021.8., Visual Studio IntelliCode v1.2.14 Value of the setting: Pylance from the VS Code marketplace to see if that fixes your issue] Extension loads successfuly Extension does not load, console reports \"Unexpected token ' in JSON at position \" [NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue] the extension by clicking a .py file <!-- Note: If you think a GIF of what is happening would be helpful, consider tools like , or . --<details<summaryOutput for <codePython</codein the <codeOutput</codepanel (<codeView</code\u2192<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codePython</code) </summary<p</p</details\nLooks like you might have a bad update. Do the following to remove stale versions of the extension: Python extension (if you have pylance uninstall it first). all instances of VS Code. to, (on windows) or on Linux/Mac. any folder with the name starting with VS Code, and install Python extension (also pylance if you uninstalled it in step 1).\nI followed all steps, but nothing changed. should I try to install older version of python ext?\nHi Can you try installing an older version of the Python extension, and if it doesn't work can you try a different version of VS Code (either an old one or the Insiders build)?\nI've installed python extension , jupyter and no pylance. here's the log: As you said I'm going to install older version of vscode\nHi Did you try installing an older version of VS Code?\nFYI - This looks like some JSON stored via the became corrupt. The JSON is written a few lines lower, so it is unexpected that the value is corrupted. This might indicate some kind of bug in the storage layer. I don't remember writing that code, did you perhaps write that? Do you think it is so important such to fail extension activation when the JSON is corrupt, or should we catch that exception and return ?\nI would suggest to be more resilient in extension activation as you suggest and fallback to an empty object here if any error rises from but log it as error: This is the first time I hear about a problem with persisting data into SQLite. However, seeing makes me think that this is not an officially supported Linux distribution.\ncurious if you could share the following 2 files with me (via e-mail is fine: find it on ). Steps: open the VSCode window where this issue happens View Command Palette =Log Storage Database Contents Help Toggle Dev Tools Find the 2 paths for the DBs send both files to me\nI can still see the original issue in vscode-insiders v1.61.0-insider\nwhats the exact version you are on? And is it the issue that the extension fails to activate?\nVersion: 1.61.0-insider (user setup) Commit: Date: 2021-09-16T08:31:28.161Z Electron: 13.4.0 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: WindowsNT x64 10.0. python extension: v2021.9. Error 2021-09-16 17:51:12: Error discovering pytest tests: [SyntaxError: Unexpected token S in JSON at position at (<anonymous) at a.runTestDiscovery (PATH.vscode-insidersextensionsms-outclient) at runMicrotasks (<anonymous) at processTicksAndRejections () at async (index 0) at async _.refreshTestData (PATH.vscode-insidersextensionsms-outclient) at async v.refreshTestDataInternal (PATH.vscode-insidersextensionsms-outclient)] { stdout: '[{\"rootid\": \".\", \"root\": \"...\nI fixed the issue as reported in that extensions fail to activate when the contents in storage fail to get parsed. What you report here seems different to me. Looks like the python extension is calling on something that is not valid JSON? Have you asked the Python extension what this could be?\nI see, I'll create a new issue. thanks", "positive_passages": [{"docid": "doc-en-vscode-3a09c99c939dafdae633810f65f7b92df09895a71188e5b3206625209b874dc9", "text": "this._storageListener.dispose(); } <del> $getValue<T>(shared: boolean, key: string): Promise<T | undefined> { </del> <ins> async $getValue<T>(shared: boolean, key: string): Promise<T | undefined> { </ins> if (shared) { this._sharedStorageKeysToWatch.set(key, true); } <del> try { return Promise.resolve(this._getValue<T>(shared, key)); } catch (error) { return Promise.reject(error); } </del> <ins> return this._getValue<T>(shared, key); </ins> } private _getValue<T>(shared: boolean, key: string): T | undefined { const jsonValue = this._storageService.get(key, shared ? StorageScope.GLOBAL : StorageScope.WORKSPACE); <del> if (!jsonValue) { return undefined; </del> <ins> if (jsonValue) { try { return JSON.parse(jsonValue); } catch (error) { // Do not fail this call but log it for diagnostics // https://github.com/microsoft/vscode/issues/132777 this._logService.error(`[mainThreadStorage] unexpected error parsing storage contents (key: ${key}, shared: ${shared}): ${error}`); } </ins> } <del> return JSON.parse(jsonValue); </del> <ins> return undefined; </ins> } <del> $setValue(shared: boolean, key: string, value: object): Promise<void> { let jsonValue: string; try { jsonValue = JSON.stringify(value); // Extension state is synced separately through extensions this._storageService.store(key, jsonValue, shared ? StorageScope.GLOBAL : StorageScope.WORKSPACE, StorageTarget.MACHINE); } catch (err) { return Promise.reject(err); } return Promise.resolve(undefined); </del> <ins> async $setValue(shared: boolean, key: string, value: object): Promise<void> { this._storageService.store(key, JSON.stringify(value), shared ? StorageScope.GLOBAL : StorageScope.WORKSPACE, StorageTarget.MACHINE /* Extension state is synced separately through extensions */); </ins> } $registerExtensionStorageKeysToSync(extension: IExtensionIdWithVersion, keys: string[]): void {", "commid": "vscode_pr_133071"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-d7bd0d62fad1bb1dbbf45803807fe69bf3667c6090227f5f82dcac0b0def3297", "text": "import { extHostNamedCustomer } from 'vs/workbench/api/common/extHostCustomers'; import { revive } from 'vs/base/common/marshalling'; import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; <ins> import { SerializableObjectWithBuffers } from 'vs/workbench/services/extensions/common/proxyIdentifier'; </ins> @extHostNamedCustomer(MainContext.MainThreadCommands) export class MainThreadCommands implements MainThreadCommandsShape {", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-0f3e851d5ab32220f6308e28ffd733c623973869b6bf2fea297b01def6be3639", "text": "} } <del> async $executeCommand<T>(id: string, args: any[], retry: boolean): Promise<T | undefined> { </del> <ins> async $executeCommand<T>(id: string, args: any[] | SerializableObjectWithBuffers<any[]>, retry: boolean): Promise<T | undefined> { if (args instanceof SerializableObjectWithBuffers) { args = args.value; } </ins> for (let i = 0; i < args.length; i++) { args[i] = revive(args[i]); }", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-f9302cab5c35960093e5aa42488c8ddb6a1ceb25eede1aaa0455403cd3f9afb6", "text": "export interface MainThreadCommandsShape extends IDisposable { $registerCommand(id: string): void; $unregisterCommand(id: string): void; <del> $executeCommand<T>(id: string, args: any[], retry: boolean): Promise<T | undefined>; </del> <ins> $executeCommand<T>(id: string, args: any[] | SerializableObjectWithBuffers<any[]>, retry: boolean): Promise<T | undefined>; </ins> $getCommands(): Promise<string[]>; }", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-d5c9f91a8802a9344323b937db41128f69bf3d3bd1344f28c250bbd0a461a4ed", "text": "import { IExtHostRpcService } from 'vs/workbench/api/common/extHostRpcService'; import { ISelection } from 'vs/editor/common/core/selection'; import { TestItemImpl } from 'vs/workbench/api/common/extHostTestingPrivateApi'; <ins> import { VSBuffer } from 'vs/base/common/buffer'; import { SerializableObjectWithBuffers } from 'vs/workbench/services/extensions/common/proxyIdentifier'; </ins> interface CommandHandler { callback: Function;", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-e3ae7f27a60a062aa67d33e7d6722d3874d48f3b3e11903182354da65c40cfdb", "text": "if (Range.isIRange((obj as modes.Location).range) && URI.isUri((obj as modes.Location).uri)) { return extHostTypeConverter.location.to(obj); } <ins> if (obj instanceof VSBuffer) { return obj.buffer.buffer; } </ins> if (!Array.isArray(obj)) { return obj; }", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-72b4d1f6cced42f6b0558b4b72baa08072c7aa5b6f7049805d5d14d8ba125913", "text": "} else { // automagically convert some argument types <ins> let hasBuffers = false; </ins> const toArgs = cloneAndChange(args, function (value) { if (value instanceof extHostTypes.Position) { return extHostTypeConverter.Position.from(value);", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-e57d0f915098dbed35ddf9aee42888090ac7ce073a141eedc321fce95c379b97", "text": "return extHostTypeConverter.location.from(value); } else if (extHostTypes.NotebookRange.isNotebookRange(value)) { return extHostTypeConverter.NotebookRange.from(value); <ins> } else if (value instanceof ArrayBuffer) { hasBuffers = true; return VSBuffer.wrap(new Uint8Array(value)); } else if (value instanceof Uint8Array) { hasBuffers = true; return VSBuffer.wrap(value); </ins> } if (!Array.isArray(value)) { return value;", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-8192e3345186279377469531cd16c8a81ccb73a0a344a1e6540ed39061f95f99", "query": "Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...\nI see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this", "positive_passages": [{"docid": "doc-en-vscode-0c5cd6e31fbd51379613a840b1c2de90bc62edf667a5b0d443a6e537d30ebcf3", "text": "}); try { <del> const result = await this._proxy.$executeCommand<T>(id, toArgs, retry); </del> <ins> const result = await this._proxy.$executeCommand<T>(id, hasBuffers ? new SerializableObjectWithBuffers(toArgs) : toArgs, retry); </ins> return revive<any>(result); } catch (e) { // Rerun the command when it wasn't known, had arguments, and when retry", "commid": "vscode_pr_133200"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-67b62b6f0c27587b388485e5f4874f51f0be65c4f1737e4a1564450a02810507", "text": "constructor() { super({ id: 'editor.gotoPreviousFold', <del> label: nls.localize('gotoPreviousFold.label', \"Go to Previous Fold\"), alias: 'Go to Previous Fold', </del> <ins> label: nls.localize('gotoPreviousFold.label', \"Go to Previous Folding Range\"), alias: 'Go to Previous Folding Range', </ins> precondition: CONTEXT_FOLDING_ENABLED, kbOpts: { kbExpr: EditorContextKeys.editorTextFocus,", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-94472b4bd3f8f9d8b8023d16613bd1a0771ae79c329b72aec028bdeb16f960b0", "text": "constructor() { super({ id: 'editor.gotoNextFold', <del> label: nls.localize('gotoNextFold.label', \"Go to Next Fold\"), alias: 'Go to Next Fold', </del> <ins> label: nls.localize('gotoNextFold.label', \"Go to Next Folding Range\"), alias: 'Go to Next Folding Range', </ins> precondition: CONTEXT_FOLDING_ENABLED, kbOpts: { kbExpr: EditorContextKeys.editorTextFocus,", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-434d56c763af7b9c0447abb785b3a1d44653b6ed7291a902b209b0e46ad23239", "text": "*/ export function getPreviousFoldLine(lineNumber: number, foldingModel: FoldingModel): number | null { let foldingRegion = foldingModel.getRegionAtLine(lineNumber); <del> if (foldingRegion !== null) { </del> <ins> // If on the folding range start line, go to previous sibling. if (foldingRegion !== null && foldingRegion.startLineNumber === lineNumber) { </ins> // If current line is not the start of the current fold, go to top line of current fold. If not, go to previous fold. if (lineNumber !== foldingRegion.startLineNumber) { return foldingRegion.startLineNumber;", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-ccae3f58c0bd9cae9dda39bea00fef11d2cc946cfd88def3d5005c472aed4adf", "text": "if (foldingModel.regions.length > 0) { foldingRegion = foldingModel.regions.toRegion(foldingModel.regions.length - 1); while (foldingRegion !== null) { <del> // Found non-parent fold before current line. if (foldingRegion.parentIndex === -1 && foldingRegion.startLineNumber < lineNumber) { </del> <ins> // Found fold before current line. if (foldingRegion.startLineNumber < lineNumber) { </ins> return foldingRegion.startLineNumber; } if (foldingRegion.regionIndex > 0) {", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-beb7807cc366cf8822118b55af6d79912defc580fedf6dd7959f91c274ceeffc", "text": "*/ export function getNextFoldLine(lineNumber: number, foldingModel: FoldingModel): number | null { let foldingRegion = foldingModel.getRegionAtLine(lineNumber); <del> if (foldingRegion !== null) { </del> <ins> // If on the folding range start line, go to next sibling. if (foldingRegion !== null && foldingRegion.startLineNumber === lineNumber) { </ins> // Find max line number to stay within parent. let expectedParentIndex = foldingRegion.parentIndex; let maxLineNumber = 0;", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-317c72a597d81ed9df09cfee652d3d88937aca8d34f329e051678dd906c575c3", "text": "if (foldingModel.regions.length > 0) { foldingRegion = foldingModel.regions.toRegion(0); while (foldingRegion !== null) { <del> // Found non-parent fold after current line. if (foldingRegion.parentIndex === -1 && foldingRegion.startLineNumber > lineNumber) { </del> <ins> // Found fold after current line. if (foldingRegion.startLineNumber > lineNumber) { </ins> return foldingRegion.startLineNumber; } if (foldingRegion.regionIndex < foldingModel.regions.length) {", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-1a90f0c04eb67e8046cbc8216ec2088d876d50374d65dc6b2516429026cbac89", "query": "Issue Type: <bBug</ba JS file: Fold and place cursor after the opening of the class Bug Nothing happens VS Code version: Code - Insiders 1.61.0-insider (Universal) (, 2021-09-14T05:14:54.400Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.1.25 typescript-notebook2.0.3 gitlens11.6.0 tsl-problem-matcher0.4.0 EditorConfig0.16.4 codespaces1.0.5 vscode-pull-request-github-insiders2021.9. vscode-drawio1.6.2 vscode-postfix-ts1.9.4 latex-workshop8.20.2 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.3 vscode-azurefunctions1.5.1 vscode-azureresourcegroups0.4.0 vscode-docker1.16.1 vscode-language-pack-de1.60.3 vscode-edge-devtools1.3.0 python2021.10.-dev vscode-pylance2021.9.2-pre.1 jupyter2021.9. jupyter-keymap1.0.0 remote-containers0.194.0 remote-ssh0.65.7 remote-ssh-edit0.65.7 azure-account0.9.8 hexeditor1.8.2 js-debug-nightly2021.9.417 live-server0.2.8 vscode-github-issue-notebooks0.0.106 vscode-typescript-next4.5. vsliveshare1.0.4836 debugger-for-chrome4.13.0 vetur0.34.1 java0.81.0 code-spell-checker2.0.4 rest-book4.2.0 ayu1.0.5 luna-paint0.9.0 sort-lines1.9.0 vscodeintellicode1.2.14 vscode-java-debug0.35.0 vscode-java-dependency0.18.7 vscode-java-test0.31.3 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm trying to document this command but find its behavior difficult to understand and rather unpredictable This could be wrong, but I think it tries looking for the next fold above the current level. In the case above, that means that works if you are inside another method: But it doesn't work if you are in the class body I'd expect this command to work more like where it just jumps to the next folded location in the file\nFYI Got to next fold looks for the next fold of the same level. In the example above there's no such fold\nThanks for tagging me, The way I have fold jumping working is that it takes the cursor position and figures out what fold you are currently in. From there, it checks if you want the next previous or parent fold. Parent is pretty easy. It just gets the fold that's at level X - 1. For next and previous fold, they are implemented as the next or previous fold at the same level. The reason for that is because it makes it easy to find associated parts of the file. For example, if you are at an , , or fold, you can easily navigate to the other conditions. Similarly, in the above example, if you are on function , you can easily jump to the other functions that are defined. I don't think it's valuable to jump to the next or previous fold by file order. For example, in the below code it would not make sense to me to have jump to next fold go to b1, then c1, then c2, then a2. Please let me know if you want me to make any changes though.\nWe need a better label then: ?\nThat seems reasonable. Want me to do that? I probably shouldn't change the actually command ID though, right? That would break key bindings.\nThanks for the explanation. I agree that this should be renamed. Even with a better name though, I still find the behavior from my example confusing. When the cursor is inside the class body, I'd expect that the folding points for and would be siblings to the cursor's location (because they all have the same folding parent). Instead though we jump out of the class entirely\nOne other note on the name: maybe the command should call these something like instead of ? Conceptually I think of a as being code you've actually folded, but my understanding is that these commands actually jump between foldable lines in the file\nsounds good to me. I see how that's confusing, so I put together this JS sample to illustrate where the \"next fold\" is for different cursor positions: Cursor 2's next is straightforward since you're on a folding point. Cursor 3's next I think is reasonable. You are in a fold, so you find the folding point and go to the next of that. Cursor 1 and 5's next start getting a little weird, but following the same logic as cursor 3, it seems logical that is the folding point, so the next sibling is at . Cursor 4 is basically your original question. I agree that it gets a little confusing. The logic is the same as 1, 3, and 5, but visually, if you're between 2 folding points, I could understand the desire for it to go to those points. I think the confusion stems from using the command when you're not on a folding point line. If you are, I think it's easy to understand, but when you aren't, not so much. What do you think of the following? If you are on a folding point line, do what it does now. not, go to the next folding point sequentially. With those updates, the above example looks like this:\nWe don't use 'folding points' as a term. I suggest 'folding range'\nOk. What do you think of changing the implementation as I mentioned in my previous comment?\nYes I like the suggestion (I thumbed up it :-) )\nI wish I could turn on reaction notifications in GitHub. I implemented this in . I update the command from \"Fold\" to \"Folding Region\", but I did not add \"Sibling\". I hit a bit of a dilemma there. With the change, it's no longer necessarily a sibling. However, I can still see people getting confused by previous or next folding region command \"not working\" when you are on the first or last sibling folding region's start line. For example, in the above example, the previous command won't move you when you are at . I think that's really valuable. It lets you move up and down the different cases of branches without going past them. I wouldn't want to run previous at and end up at , then next brings me to . Any suggestions for that? I'm pretty sure nobody would want the command label to be \"Go to Previous Folding Range, but Stop at First Sibling\", but that's essentially what this does.\n/verified Looks to follow the logic set out by I used this example: When on line 8 it jumps nowhere is a little confusing, but that's because the next folding range is the current?\nThat's because it's the last sibling. The benefit is that you can move to previous and next sibling folding ranges without stepping out of them (at which point going to the next or previous sibling won't be the original set of siblings you were on). I agree, it's confusing, but I think it's valuable to do it this way.", "positive_passages": [{"docid": "doc-en-vscode-37057a35ff46e8cd29ce4ccc2dc3cb9ae8416d21a56d06a277ce10ad7c343876", "text": "assert.strictEqual(getPreviousFoldLine(9, foldingModel), 5); assert.strictEqual(getPreviousFoldLine(5, foldingModel), 3); assert.strictEqual(getPreviousFoldLine(3, foldingModel), null); <ins> // Test when not on a folding region start line. assert.strictEqual(getPreviousFoldLine(4, foldingModel), 3); assert.strictEqual(getPreviousFoldLine(7, foldingModel), 6); assert.strictEqual(getPreviousFoldLine(8, foldingModel), 6); </ins> // Test jump to next. assert.strictEqual(getNextFoldLine(3, foldingModel), 5); <del> assert.strictEqual(getNextFoldLine(4, foldingModel), 5); </del> assert.strictEqual(getNextFoldLine(5, foldingModel), 9); assert.strictEqual(getNextFoldLine(9, foldingModel), null); <ins> // Test when not on a folding region start line. assert.strictEqual(getNextFoldLine(4, foldingModel), 5); assert.strictEqual(getNextFoldLine(7, foldingModel), 9); assert.strictEqual(getNextFoldLine(8, foldingModel), 9); </ins> } finally { textModel.dispose();", "commid": "vscode_pr_133363"}], "negative_passages": []}
{"query_id": "q-en-vscode-7b2163386cd2405b1839e1d018c09f1c9490bca46a04cfda7b8bc2c351e7c6f5", "query": "This new capability allows the terminal to control when the tab description shows, so we can align the description in the terminal editor with how it shows up in a terminal panel tab.\nTo verify: Run a task, move the terminal to the editor area, check that the description shows up like it did in the panel In a terminal, change the directory, verify you see it in the tab description in the panel Move that to the terminal editor, make sure you see it there as well\nIs this tooltip the task description? <img width=\"486\" alt=\"image\" src=\"\"I think I'm a bit confused on how a task would be affected by a different terminal changing directories.\ndrag the terminal into the editor area and you should still see in the label of the tab.", "positive_passages": [{"docid": "doc-en-vscode-1813f7dbc24d0d2a0b3091fd101b45e82a8c2bc3d7b89f1e4343781228d69ebe", "text": "} override get capabilities(): EditorInputCapabilities { <del> return EditorInputCapabilities.Readonly | EditorInputCapabilities.Singleton | EditorInputCapabilities.CanDropIntoEditor; </del> <ins> return EditorInputCapabilities.Readonly | EditorInputCapabilities.Singleton | EditorInputCapabilities.CanDropIntoEditor | EditorInputCapabilities.ForceDescription; </ins> } setTerminalInstance(instance: ITerminalInstance): void {", "commid": "vscode_pr_197957"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-af8a4530d5f25fbf7e00ac940b9847da6ede5693d02bdab5055d6b6f5f99619f", "text": "async attachToProcess(id: number): Promise<void> { try { <del> this._throwIfNoPty(id).attach(); </del> <ins> await this._throwIfNoPty(id).attach(); </ins> this._logService.trace(`Persistent process reconnection \"${id}\"`); } catch (e) { this._logService.trace(`Persistent process reconnection \"${id}\" failed`, e.message); <ins> throw e; </ins> } }", "commid": "vscode_pr_152409"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-d9b864ef217598c42f7772bbcb41f6c2b6b9005cc3b8394b2fa852e2a64a7f35", "text": "})); } <del> attach(): void { </del> <ins> async attach(): Promise<void> { </ins> this._logService.trace('persistentTerminalProcess#attach', this._persistentProcessId); <ins> if (!this._disconnectRunner1.isScheduled() && !this._disconnectRunner2.isScheduled()) { // Something wrong happened if the disconnect runner is not canceled, this likely means // multiple windows attempted to attach. if (!await this._isOrphaned()) { throw new Error(`Cannot attach to persistent process \"${this._persistentProcessId}\", it is already adopted`); } this._logService.warn(`Persistent process \"${this._persistentProcessId}\": Process had no disconnect runners but was an orphan`); } </ins> this._disconnectRunner1.cancel(); this._disconnectRunner2.cancel(); }", "commid": "vscode_pr_152409"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-99b2ce21bc7609aee45af4620469fa6081e7ba3453ed072a2c46e83c2ddf4783", "text": "this._dimensions.rows = rows; this._isScreenReaderModeEnabled = isScreenReaderModeEnabled; <del> let newProcess: ITerminalChildProcess; </del> <ins> let newProcess: ITerminalChildProcess | undefined; </ins> if (shellLaunchConfig.customPtyImplementation) { this._processType = ProcessType.PsuedoTerminal;", "commid": "vscode_pr_152409"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-96a24fab0a71eade7874c07826757a793d9780b80b1c31082383783a89ed864e", "text": "if (result) { newProcess = result; } else { <del> this._logService.trace(`Attach to process failed for terminal ${shellLaunchConfig.attachPersistentProcess}`); return undefined; </del> <ins> // Warn and just create a new terminal if attach failed for some reason this._logService.warn(`Attach to process failed for terminal`, shellLaunchConfig.attachPersistentProcess); shellLaunchConfig.attachPersistentProcess = undefined; </ins> } <del> } else { </del> <ins> } if (!newProcess) { </ins> await this._terminalProfileResolverService.resolveShellLaunchConfig(shellLaunchConfig, { remoteAuthority: this.remoteAuthority, os: this.os", "commid": "vscode_pr_152409"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-0126c7472c33e10c44104aa1870220df441bc325d45a5ac2cffbcb82f426e395", "text": "if (result) { newProcess = result; } else { <del> this._logService.trace(`Attach to process failed for terminal ${shellLaunchConfig.attachPersistentProcess}`); return undefined; </del> <ins> // Warn and just create a new terminal if attach failed for some reason this._logService.warn(`Attach to process failed for terminal`, shellLaunchConfig.attachPersistentProcess); shellLaunchConfig.attachPersistentProcess = undefined; </ins> } <del> } else { </del> <ins> } if (!newProcess) { </ins> newProcess = await this._launchLocalProcess(backend, shellLaunchConfig, cols, rows, this.userHome, isScreenReaderModeEnabled, variableResolver); } if (!this._isDisposed) {", "commid": "vscode_pr_152409"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-9fb4ec0a1c5d0d0c15a0631120f747ea349ba8aba9b9fac4e25d7af9d0650b08", "text": "if (this._preLaunchInputQueue.length > 0 && this._process) { // Send any queued data that's waiting <del> newProcess.input(this._preLaunchInputQueue.join('')); </del> <ins> newProcess!.input(this._preLaunchInputQueue.join('')); </ins> this._preLaunchInputQueue.length = 0; } }),", "commid": "vscode_pr_152409"}], "negative_passages": []}
{"query_id": "q-en-vscode-b586eff4c4ffdef758fe6c5c822311b587ca798302ae78a50c8c40e0ec4be006", "query": "I just reloaded a window with my repo open, and it attached to a terminal which is already open in my repo, so now this terminal is open in two windows: ! The right window is the window that originally owned this terminal One thing about this terminal is that its cwd is some other folder outside of both workspaces, if that matters.\nI reloaded the left window again, and it reattached to the correct terminal. !\nJust so you know, this happens pretty often. I just reloaded a window and got some random terminal from another window. Let me know if I can collect any other info\nAlso hit this, I believe it was after restarting insiders for an update. !\nI was able to repro once out of many attempts. I wonder if there's a command to reload all windows to simulate what happens on update? Maybe then I'd see it?\nexiting the application (cmd+q) and reopening it is essentially what happens on update\nSomething similar just happened with the most recent insiders update, but now the terminals aren't synced, it's just that the working directory of one window's terminal is set to the other window's root instead of it's own. <img width=\"1440\" alt=\"image\" src=\"https://user-\"\nHappened again, accidentally ran a destructive command in the wrong directory :( cc is there any logging or something I can enable to help you get to the bottom of this?\nI spent awhile investigating. I don't understand what could be going on here because we store and reconnect to terminals according to the workspaceId. said that he thinks it's a race condition. Setting log level to trace and toggling the shared process would help when it reproes\nToday I had something new happen: had 3 VS Code windows open. reloaded window 1. 1 now shares a terminal with window 3! Totally different workspaces. No other windows were reloaded. No windows were closed. Is there a way I can disable terminal reconnect for local windows? I've also run destructive commands when this happens and I don't want to risk it.\nYep, it's not working atm for remote terminals, so:\nHello everyone, there is any plan to try to fix it in the nearest milestone?\nThis code that we for transferring terminals via dnd between windows looks suspicious\nHas anyone seen this in awhile? I cannot reproduce\nI don't remember seeing it recently\nOkay pls reopen if you see it again and I'll be happy to debug with anyone that can reproduce it\nSorry, I cursed myself because this happened again today but I probably won't have consistent repro steps. I reloaded the window with my vscode workspace and got a terminal from this extension sample which is also open in another window, although the terminal panel had not been made visible in that other window's session yet. I reloaded the window several more times and always got the right terminal after that. <img width=\"1049\" alt=\"image\" src=\"https://user-\"\nwe don't create a terminal until you open the panel, so what do you mean by the terminal had not been made visible yet?\nIn case it is important to the issue, I'm just saying that the drop-on-document terminal that was wrongly attached to the vscode window hadn't yet been attached to the drop-on-document window, because it was from some earlier session.\nI also used to see this periodically but I've had terminal reattach disabled to avoid it. Let me know if it will be helpful and I'll re-enable reattach!\nSame as\nYes it would be very helpful I spent 90 mins yesterday trying to reproduce to no avail. If you could enable trace logging too in case you repro, that might give the insight we need\nWe should review the code around terminal adoption of orphan processes, I suspect the issue is that it's not transactional.\nit appears we're only doing an orphan check on terminals that are in the workspace as set in the map\nI think somewhere all unadopted processes get taken by some window? Might not be remembering right though.\nIf you see this again after lands, please enable trace logging and get the output channel logs for Pty Host and Window.\nI was seeing this previously on occasion but haven't seen it over the last week so marking as verified\n+1 on no longer seeing it since re-enabling re-attach a few weeks ago.\nJust saw this again. The incorrect re-attach occurred on 1 July and I only noticed it today. Pty logs: Window logs\nThis seemed for a while like it'd stopped happening, but just ran into it again: In my case I'd just reloaded a single window.\nJust had this happen again, but once again I didn't have trace logging on. I'll try to leave it turned on for next time. Pty Host logs: Window logs:\nCould the needed log statement to troubleshoot this on the terminal side be converted to an log. That might help track down this bug sooner.\nthey're actually warnings already so they should show up:\nJust ran into this again. I have the same terminal restored in two distinct windows. I ran into this after restarting to update Insiders on macOS (I had 6 folders opened). The Pty Host log contains the following: https://user- Maybe might know if there's a way to easily simulate a restart caused by an update. Alternatively, maybe you can try changing a setting like which shows the restart prompt. I think this also leads to the terminals attaching incorrectly.\nMight be related to (maybe not as that's remote only?)\nthis is a little confusing to me. No reconnect is meant to happen on restart, when updating node-pty gets replaced so it can't be running, all processes are torn down and the pty host shuts down with the main process. Did you see this? !\nChanging this to always return isOrphan = true: I can get it to reconnect which is meant to be prevented by one of my other changes.\nIt's a little suspicious that the entry doesn't get deleted: That determines here which can bypass the orphan check:\nI can confirm that within the last two days (both before and after the upgrade to 1.70.0) it has happened to me both on window reload and on full VSCode restart.\nWhen I see this it also happen on restart.\ndo you see the history restored message when it happens on restart?\nYes, I see this every time when restarting to install a new version (Gear Restart to Update) or when changing the setting : <img width=\"473\" alt=\"image\" src=\"https://user-\"\nI'm 99.9% certain the answer is yes, but I will make sure to notice the next time it happens.\nOk, I figured this out. What a journey! Here is the fairly reliable repro: Clear state - Given 2 folders and Open folders and and close all terminals File Exit Setup for the process revive - Window : Open 3 terminals and type \"a\", \"b\", \"c\" into them respectively, this helps identify them to ensure they're in the correct order later Window : Open 3 terminals and type \"d\", \"e\", \"f\" into them respectively File Exit Process revive - Window and should revive the processes and have all terminals in the correct order they were created (this works) Process reconnect Reload window and window at the same time Window and should revive the processes and have all terminals in the correct order they were created :bug: Note that this is a timing issue and has a chance to not reproduce the problem. This is what is meant to happen when exiting and restarting the pty host process. Terminal processes are revived (aka. re-created) and their actual pty IDs for this pty host process are mapped to, starting at 1. Notice below how the new IDs start from 1, they just represent the order they are created in which shouldn't matter when reviving. After that, when reloading windows, terminal processes do not get revived but reconnected to. So an mapping is expected: What is happening and what is causing this bug as well as a related issue[^1] is that the revived pty ID is cached, so if reloading happens to use a that is mapped to a different pty ID in , it will reconnect to that one instead: The above results in: Then on reload the pty ID mapping occurs instead of being undefined, which causes a reconnect_ to the wrong pty. So in the above they get re-mapped, shuffling the order within a window and potentially connecting to a different window's ptys: ! [^1]: The folder's terminals may not get restored at with the warning \"Couldn't get layout info, a terminal was probably disconnected\" in the pty host output channel. This started happening due to one of the previous workarounds to prevent 2 windows attaching to the same pty.\nWow. Nice detective work! Thanks, looking forward to the fix.\nReported here\nI actually saw it again once earlier this week too. It does seem to happen significantly less often than it used to.\nI just ran into this again today. After a restart due to an update, I got a terminal from a folder showing up by itself in folder . Here's the only relevant content I found in my logs:\nI hit this today. Moving this forward to January 2023, since it probably was just lost in the queries by being assigned to August 2022.\nI've hit this once per day for the past several days. It seems to be occurring more frequently again.\nThis would probably be addressed if terminals moved into utility process and there was a message port per terminal:\nUsing the new pty host trace logging, this is what happens on a reload with a single terminal that will be reconnected, with the environment parts truncated:\nI believe this is now fixed as a part of I'm still not able to reproduce but the current theory is that the async isOrphan check that was removed in the PR was not only delaying reconnection by 4 seconds, but also causing a race where the wrong window could adopt it. Instead we no longer check whether it's an orphan and trust the saved workplace state to be correct.\nThanks for following up\nI haven't seen this in a long time. Not sure whether there is anything that can be done to verify it.\nI just ran into this now: had ~4 windows open: Window 1 is vscode-pull-request-github2 : terminals cwd were all in the workspace Window 2 is vscode-pull-request-github: terminals cwd were all in the workspace Window 3 is repo1: 2 terminals, both of which had a cwd outside the workspace Window 4 is vscode: terminals cwd were all in the workspace VS Code reattach: Window 1's terminals are correct Window 2 has reattached to one of Window 3's terminals and has lost it's original terminal Window 3's terminals are correct Window 4's terminals are correct. Pty logs from Window 2:\nthanks for the info! Looking into it\nI spent a few hours looking into this, here are my findings: This warning in the logs is common across recent failures: , I tried and tried but could not reproduce this on Insiders or OSS I'm adding more verbose logs to the info log level that gives me the old/new pty id mapping as well as dumping a bunch of info when the above error happens I looked into whether should be correct and while I found it could cause issues when the pty host restarts (), it seems like it should work after a restart I could the cwd being outside the workspace would make a difference as we don't even take that into account when reviving the proc () The management of would be a lot simpler if we moved the id to being a guid instead of a number, but that would be a shame as we then need to send the guid along the wire for pretty much every request to the pty host I looked into possible race conditions where could get stale/invalid values. Both a thorough review of the code and injecting timeouts (random, differing by window) into important calls didn't cause problems Current plan is to wait for to merge and await a repro with these logs present, then analyze them. I'll also likely be continuing to fiddle with terminal reconnection in debt week to improve perf further and reduce redundancies.\nI'll keep an eye out for this and try to maintain a setup similar that one that I just saw it with, but I have to say, this has gotten so much better. I almost never see it.\nI tried to repeat my setup before updating, and it did happen again. Setup: Window 1 is vscode-pull-request-github2 : terminal cwd is outside the workspace and on a different drive (C vs D) Window 2 is vscode-pull-request-github: terminals cwd were in the workspace Window 3 is repo1: terminal cws was in the workspace Window 4 is vscode: terminals cwd were all in the workspace After update: Window 1 is vscode-pull-request-github2 : has a new terminal Window 2 is vscode-pull-request-github: correct Window 3 is repo1: has attached to Window 2's terminal and now they share the same terminal Window 4 is vscode: correct Logs:\nThanks it seems there's some inconsistency with the layout info and the revived procs, so I suspect this silently error swallowing now: Added logs for that here: , I'll merge for July so you might not be able to test for a week but when you do please also grab the Terminal output log as this is renderer side.\nCross post\nWith logs in , I was able to reproduce the problem! ! The repro is very complicated, it is essentially trying to get into a state where 2+ windows have \"old pty ids\" that conflict with one another, and then increasing the latency of the pty host in order to force the race condition to show itself. these settings: default log level to trace all windows window 1 (W1) with folder A 1: Open 2 terminals 1: Close window 1: Open window 1: Open pty host log, you should see this: window 2 (W2) with folder B 2: Open 2 terminals 1: Close window 2: Close window VS Code (W2 should open) 2: Open pty host log, you should something like this: 2: Close window an external terminal and type another external terminal and type the commands in both terminals in quick succession 1|W2: Open pty host log, you should see something like this: The terminal with end up attaching to the wrong pty. The fix for this is simple, just add workspace ID as part of the key of the old id, so becomes . This should make conflicts impossible to occur.", "positive_passages": [{"docid": "doc-en-vscode-e94a721dc35019858a03bf16a0243ae01d6c685245c0ea19dc84f73ea9c92739", "text": "private async _expandTerminalInstance(t: ITerminalInstanceLayoutInfoById): Promise<IRawTerminalInstanceLayoutInfo<IProcessDetails | null>> { try { const revivedPtyId = this._revivedPtyIdMap.get(t.terminal)?.newId; <ins> this._revivedPtyIdMap.delete(t.terminal); </ins> const persistentProcessId = revivedPtyId ?? t.terminal; const persistentProcess = this._throwIfNoPty(persistentProcessId); const processDetails = persistentProcess && await this._buildProcessDetails(t.terminal, persistentProcess, revivedPtyId !== undefined);", "commid": "vscode_pr_157684"}], "negative_passages": []}
{"query_id": "q-en-vscode-d640502bdeccb11711a39bed6860c62002b3405fc8b8f1f4157eadcd63896b80", "query": "The <kbdToggle Size to Content Width</kbdcan only be toggled a few times, before freezing completely. Resizing terminal could reset it. https://user- Does this issue occur when all extensions are disabled?: Yes System info:\nplease see my explanation on\nThank you for your detailed explanation. I did test on the insider version, the blur seems to decreased with smaller canvas required but this freezing issue still happens all the time. Moreover, the issue is only on Linux so I'm not sure the explanation is quite sufficient to describe this. Let me know if there's anything I missed, thanks again.\nwhen you do this how long as the lines you're working with? ideally, we probably need an upper cap based on the environment's max canvas size (which would need some searching).\nIt's hard to say when the doesn't work as expected this time. Do you have any idea to get this revealed? https://user-\nwhen the width of the longest line is less than the width of the terminal, as is featured in your gif, toggling the width won't do anything (by design).\nthanks for your information, I did some tests again and got some conclusions: in the menu doesn't work, so I recorded with shortcut . IIt also freezes after the second as expected (bottom scrollbar indicates that): https://user- lines hidden when press are affected (still freezes after the second toggle): https://user- number 2 above seems to happen almost every line length: ! Let me know if I can do any more tests to provide more information.\nAs compared with how this works for windows/mac, linux is broken given the same text content !\nThis actually is working by design - when you copy and paste, it includes newline line endings that will indicate to the terminal that line isn't wrapped.\nbased on , it seems like we should go with the min value since we don't want to calculate this per platform/browser, so going with 8000\nI started on Windows to try to understand how works. It didn't appear to do anything on Windows. On linux, I can see the toggle happen, but there is no scroll bar.\nit will only happen if there are wrapped lines. so increase the line width or resize the terminal to be more narrow.\nthe scrollbar is very low on linux and i'm not sure why. I'll open an issue for that - separate from this one\nWindows !\nthanks, i'll make a new issue for that\nNow the same thing is happening on linux too. I will leave this for someone else to verify.\nThank you for getting back. I've tested with the insider build but it doesn't work, I've thought it was some sort of thing related to my particular machine, which confuses me these days. So it's good to track that again on a new issue. Most of behavior I have described in I don't spend much time on Windows so didn't test carefully. Let me know if there's anything else I can do.\nBecause of the way this feature works where it stretches the canvas to the size of the content we are limited by the canvas API. As a compromise I'm going to add a cap to the number of columns the terminal can take up.", "positive_passages": [{"docid": "doc-en-vscode-6046d0ff63969c62d93d97a6d35229ba98e17754d7a7a4d31d66c6cbad44524e", "text": "DefaultCols = 80, DefaultRows = 30, <del> MaxSupportedCols = 5000, MaxCanvasWidth = 8000 </del> <ins> MaxCanvasWidth = 4096 </ins> } let xtermConstructor: Promise<typeof XTermTerminal> | undefined;", "commid": "vscode_pr_200654"}], "negative_passages": []}
{"query_id": "q-en-vscode-d640502bdeccb11711a39bed6860c62002b3405fc8b8f1f4157eadcd63896b80", "query": "The <kbdToggle Size to Content Width</kbdcan only be toggled a few times, before freezing completely. Resizing terminal could reset it. https://user- Does this issue occur when all extensions are disabled?: Yes System info:\nplease see my explanation on\nThank you for your detailed explanation. I did test on the insider version, the blur seems to decreased with smaller canvas required but this freezing issue still happens all the time. Moreover, the issue is only on Linux so I'm not sure the explanation is quite sufficient to describe this. Let me know if there's anything I missed, thanks again.\nwhen you do this how long as the lines you're working with? ideally, we probably need an upper cap based on the environment's max canvas size (which would need some searching).\nIt's hard to say when the doesn't work as expected this time. Do you have any idea to get this revealed? https://user-\nwhen the width of the longest line is less than the width of the terminal, as is featured in your gif, toggling the width won't do anything (by design).\nthanks for your information, I did some tests again and got some conclusions: in the menu doesn't work, so I recorded with shortcut . IIt also freezes after the second as expected (bottom scrollbar indicates that): https://user- lines hidden when press are affected (still freezes after the second toggle): https://user- number 2 above seems to happen almost every line length: ! Let me know if I can do any more tests to provide more information.\nAs compared with how this works for windows/mac, linux is broken given the same text content !\nThis actually is working by design - when you copy and paste, it includes newline line endings that will indicate to the terminal that line isn't wrapped.\nbased on , it seems like we should go with the min value since we don't want to calculate this per platform/browser, so going with 8000\nI started on Windows to try to understand how works. It didn't appear to do anything on Windows. On linux, I can see the toggle happen, but there is no scroll bar.\nit will only happen if there are wrapped lines. so increase the line width or resize the terminal to be more narrow.\nthe scrollbar is very low on linux and i'm not sure why. I'll open an issue for that - separate from this one\nWindows !\nthanks, i'll make a new issue for that\nNow the same thing is happening on linux too. I will leave this for someone else to verify.\nThank you for getting back. I've tested with the insider build but it doesn't work, I've thought it was some sort of thing related to my particular machine, which confuses me these days. So it's good to track that again on a new issue. Most of behavior I have described in I don't spend much time on Windows so didn't test carefully. Let me know if there's anything else I can do.\nBecause of the way this feature works where it stretches the canvas to the size of the content we are limited by the canvas API. As a compromise I'm going to add a cap to the number of columns the terminal can take up.", "positive_passages": [{"docid": "doc-en-vscode-04ecf3a824bef768171cb944d9453d1f40b6c891dcdd60b2555ae022ba8eacf2", "text": "this._initDimensions(); await this._resize(); } else { <ins> const font = this.xterm ? this.xterm.getFont() : this._configHelper.getFont(dom.getWindow(this.domElement)); const maxColsForTexture = Math.floor(Constants.MaxCanvasWidth / (font.charWidth ?? 20)); </ins> // Fixed columns should be at least xterm.js' regular column count <del> const proposedCols = Math.max(this.maxCols, Math.min(this.xterm.getLongestViewportWrappedLineLength(), Constants.MaxSupportedCols)); </del> <ins> const proposedCols = Math.max(this.maxCols, Math.min(this.xterm.getLongestViewportWrappedLineLength(), maxColsForTexture)); </ins> // Don't switch to fixed dimensions if the content already fits as it makes the scroll // bar look bad being off the edge if (proposedCols > this.xterm.raw.cols) {", "commid": "vscode_pr_200654"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b2eebf7768ecd84d2fded79c3cc16263dc2cff5413c50ba8c039c8e6ee8bb15", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.61.0 Commit: Date: 2021-10-07T18:11:58.853Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Steps to Reproduce: the Terminal Sample from the vscode-extension-sample repository the a task that reuses a terminal. For example, I used a user task like: On the first run of the task the 'link' text will create a hover link correctly. If you re-run the task so the terminal has 2 (or more) runs of the task in the same terminal then the link will fail to detect correctly. Adding a breakpoint to there appears to be 1 call per execution of the task in the terminal. I think when the terminal is re-used it re-registers the link provider and if two link providers have overlapping links they both seem to fail (which is a known issue but due to this bug all link providers start failing if tasks are run multiple times).\nPutting a breakpoint in the registerLinkProvider call for xterm (here ) I see multiple copies of all of the link providers: <img width=\"574\" alt=\"Screen Shot 2021-10-12 at 9 15 30 AM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-372c66f15fb9f432d456173261d3ec74d5c17d3b8c2179599875b93da4991815", "text": "private _widgetManager: TerminalWidgetManager | undefined; private _processCwd: string | undefined; private _standardLinkProviders: ILinkProvider[] = []; <del> private _standardLinkProvidersDisposables: IDisposable[] = []; </del> <ins> private _linkProvidersDisposables: IDisposable[] = []; </ins> constructor( private _xterm: Terminal,", "commid": "vscode_pr_135419"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b2eebf7768ecd84d2fded79c3cc16263dc2cff5413c50ba8c039c8e6ee8bb15", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.61.0 Commit: Date: 2021-10-07T18:11:58.853Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Steps to Reproduce: the Terminal Sample from the vscode-extension-sample repository the a task that reuses a terminal. For example, I used a user task like: On the first run of the task the 'link' text will create a hover link correctly. If you re-run the task so the terminal has 2 (or more) runs of the task in the same terminal then the link will fail to detect correctly. Adding a breakpoint to there appears to be 1 call per execution of the task in the terminal. I think when the terminal is re-used it re-registers the link provider and if two link providers have overlapping links they both seem to fail (which is a known issue but due to this bug all link providers start failing if tasks are run multiple times).\nPutting a breakpoint in the registerLinkProvider call for xterm (here ) I see multiple copies of all of the link providers: <img width=\"574\" alt=\"Screen Shot 2021-10-12 at 9 15 30 AM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-840d232500a0da8af2bbd786b5a9b6b811acbc3314901cbc84eb3055510c8ff5", "text": "this._processCwd = processCwd; } <ins> private _clearLinkProviders(): void { dispose(this._linkProvidersDisposables); this._linkProvidersDisposables = []; } </ins> private _registerStandardLinkProviders(): void { <del> dispose(this._standardLinkProvidersDisposables); this._standardLinkProvidersDisposables = []; </del> for (const p of this._standardLinkProviders) { <del> this._standardLinkProvidersDisposables.push(this._xterm.registerLinkProvider(p)); </del> <ins> this._linkProvidersDisposables.push(this._xterm.registerLinkProvider(p)); </ins> } } registerExternalLinkProvider(instance: ITerminalInstance, linkProvider: ITerminalExternalLinkProvider): IDisposable { <ins> // Clear and re-register the standard link providers so they are a lower priority that the new one this._clearLinkProviders(); </ins> const wrappedLinkProvider = this._instantiationService.createInstance(TerminalExternalLinkProviderAdapter, this._xterm, instance, linkProvider, this._wrapLinkHandler.bind(this), this._tooltipCallback.bind(this)); const newLinkProvider = this._xterm.registerLinkProvider(wrappedLinkProvider); <del> // Re-register the standard link providers so they are a lower priority that the new one </del> <ins> this._linkProvidersDisposables.push(newLinkProvider); </ins> this._registerStandardLinkProviders(); return newLinkProvider; }", "commid": "vscode_pr_135419"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b2eebf7768ecd84d2fded79c3cc16263dc2cff5413c50ba8c039c8e6ee8bb15", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.61.0 Commit: Date: 2021-10-07T18:11:58.853Z Electron: 13.5.1 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Steps to Reproduce: the Terminal Sample from the vscode-extension-sample repository the a task that reuses a terminal. For example, I used a user task like: On the first run of the task the 'link' text will create a hover link correctly. If you re-run the task so the terminal has 2 (or more) runs of the task in the same terminal then the link will fail to detect correctly. Adding a breakpoint to there appears to be 1 call per execution of the task in the terminal. I think when the terminal is re-used it re-registers the link provider and if two link providers have overlapping links they both seem to fail (which is a known issue but due to this bug all link providers start failing if tasks are run multiple times).\nPutting a breakpoint in the registerLinkProvider call for xterm (here ) I see multiple copies of all of the link providers: <img width=\"574\" alt=\"Screen Shot 2021-10-12 at 9 15 30 AM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-5a7fbf9a21b0c0bb1d36e29c9ad1677cadf2377eced9272a81311398ce32219a", "text": "// Init winpty compat and link handler after process creation as they rely on the // underlying process OS this._processManager.onProcessReady((processTraits) => { <ins> // If links are ready, do not re-create the manager. if (this._areLinksReady) { return; } </ins> if (this._processManager.os === OperatingSystem.Windows) { xterm.setOption('windowsMode', processTraits.requiresWindowsMode || false); // Force line data to be sent when the cursor is moved, the main purpose for", "commid": "vscode_pr_135419"}], "negative_passages": []}
{"query_id": "q-en-vscode-08750695ba99529d470aa38a34c6ab020067dc4d7672375b99cef7cd046076b5", "query": "Issue Type: <bBug</bI'm using MacOS. After opening VSCode and getting into full-screen mode: If I use the integrated terminal of VSCode to create a new file, e.g.: VSCcode switches my screen to my previous workspace that causes interruption of work. Everytime I use to create a new file, I'll have to use + to move back to VSCode. VS Code version: Code 1.61.1 (, 2021-10-14T01:23:30.274Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ code-runner0.11.6 terminal0.0.10 go0.28.1 vscode-docker1.17.0 python2021.10. vscode-pylance2021.10.1 jupyter2021.9. jupyter-keymap1.0.0 jupyter-renderers1.0.3 remote-containers0.202.4 remote-ssh0.65.8 remote-ssh-edit0.65.8 remote-wsl0.58.2 vscode-remote-extensionpack0.21.0 vscode-yaml0.23.0 code-settings-sync3.4.3 open-in-browser2.0.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI am not sure if this could be a regression from the work we did to use the command.\nI just built a version without the open cmd fix, but still saw the behaviour. I'm wondering if it could actually be caused by changes made during Edit: It seems reverting both commits fixes the issue.\nIt is unrelated to my changes. When I simply change this line to always go into the of : It does not reproduce anymore. Looks like when we are using , macOS does not really know whether a new window opens or an existing one reused. I feel this is a pretty bad regression actually.\nI see that has fixed this bug and merged the PR. It seems like this is in (not sure what that means) but the issue still persists. I wonder when will this be fixed? In the next VSCode update? Thanks.\nIt should be fixed in our current latest stable release ().\nThanks, Just updated to today and I confirm that it's fixed.", "positive_passages": [{"docid": "doc-en-vscode-aa01e0cd45e769ed60f66979b1685b12534b80437cf660bc9af3c792ca34bf67", "text": "// similar to if the app was launched from the dock // https://github.com/microsoft/vscode/issues/102975 <del> const spawnArgs = ['-n'];\t\t\t\t// -n: launches even when opened already </del> <ins> // The following args are for the open command itself, rather than for VS Code: // -n creates a new instance. //    Without -n, the open command re-opens the existing instance as-is. // -g starts the new instance in the background. //    Later, Electron brings the instance to the foreground. //    This way, Mac does not automatically try to foreground the new instance, which causes //    focusing issues when the new instance only sends data to a previous instance and then closes. const spawnArgs = ['-n', '-g']; // -a opens the given application. </ins> spawnArgs.push('-a', process.execPath); // -a: opens a specific application if (verbose) {", "commid": "vscode_pr_135517"}], "negative_passages": []}
{"query_id": "q-en-vscode-45e7e3e7d1b48eca5c8b50f4449210f1f43157abcaef410b0fd38a713bb0ba81", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: n/a <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: latest OS Version: macOS 11.2.3 Steps to Reproduce: repo npm version < 14 or \u2265 17 to see this message message or just read the commit diff to see the problem\nfrom check is for \u2265 17 but error message says to use \u2264 17, thus exactly v17 is both valid and invalid", "positive_passages": [{"docid": "doc-en-vscode-440e6e4590e4f077b98af5825290436b35aca101af1e5edc62ad4361bdec62c4", "text": "const majorNodeVersion = parseInt(/^(d+)./.exec(process.versions.node)[1]); if (majorNodeVersion < 14 || majorNodeVersion >= 17) { <del> console.error('033[1;31m*** Please use node.js versions >=14 and <=17.033[0;0m'); </del> <ins> console.error('033[1;31m*** Please use node.js versions >=14 and <17.033[0;0m'); </ins> err = true; }", "commid": "vscode_pr_136794"}], "negative_passages": []}
{"query_id": "q-en-vscode-2edc0cb37ef6a48b076354894c97bd8edb74a7629c6824d3a46e00996d0ef335", "query": "Copied from My workaround is export VSCODEGITASKPASSEXTRAARGS=\"--title=foobar\" but the proper bugfix should happen in VSCode's GIT_ASKPASS implementation.\nI experience the same problem, from the moment been released. Working through remote ssh the git processes stay open, without anything happening.\nStill facing this issue on WSL.\nWill be fixed in upcoming 1.62.2. Meanwhile a workaround is to and then manually\nI can confirm that this is fixed after updating to 1.62.2 ().", "positive_passages": [{"docid": "doc-en-vscode-5164236bcef76bbde71a25203a161d84668753fbebf426ed75f52303fb1593ca", "text": "#!/bin/sh VSCODE_GIT_ASKPASS_PIPE=`mktemp` <del> ELECTRON_RUN_AS_NODE=\"1\" VSCODE_GIT_ASKPASS_PIPE=\"$VSCODE_GIT_ASKPASS_PIPE\" \"$VSCODE_GIT_ASKPASS_NODE\" \"$VSCODE_GIT_ASKPASS_EXTRA_ARGS\" \"$VSCODE_GIT_ASKPASS_MAIN\" $* </del> <ins> ELECTRON_RUN_AS_NODE=\"1\" VSCODE_GIT_ASKPASS_PIPE=\"$VSCODE_GIT_ASKPASS_PIPE\" \"$VSCODE_GIT_ASKPASS_NODE\" \"$VSCODE_GIT_ASKPASS_MAIN\" $VSCODE_GIT_ASKPASS_EXTRA_ARGS $* </ins> cat $VSCODE_GIT_ASKPASS_PIPE rm $VSCODE_GIT_ASKPASS_PIPE", "commid": "vscode_pr_136881"}], "negative_passages": []}
{"query_id": "q-en-vscode-7ee8a689957c63b06c39376634bb67232c9f4ed6b6d322dd895723c543110640", "query": "! It could be that I caused this, but I doubt it (injected text has nothing to do with the gutter, maybe they shared a CSS rule).\nI can reproduce but I'm not aware of any changes in that area from the debug side.\nI would like to work on this issue!\nBefore fixing anything we should do a \"git bisect\" to find the commit that broke this.\ncommit . it should\nthanks for pointing out the commit! If you like, you can provide a PR, that would be awesome!\nPR", "positive_passages": [{"docid": "doc-en-vscode-a69e9b2edc9d8ac9bd1ba2effb575d237ffd8d019e41998376d94ba452058f54", "text": "margin-top: -1px; } <ins> .codicon-debug-breakpoint.codicon-debug-stackframe-focused::after, .codicon-debug-breakpoint.codicon-debug-stackframe::after { content: 'eb8a'; position: absolute; } </ins> .monaco-editor .debug-top-stack-frame-column { font: normal normal normal 16px/1 codicon; text-rendering: auto;", "commid": "vscode_pr_137471"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb91c628ed3ba450656d846a909f78ebe8edb73e5daf542f1fd40ca65830333c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: git commit (1 Dec 2021), with openvscode-server patches until commit Browser: Firefox OS Version: Ubuntu 20.04 Steps to Reproduce: a freshly opened window, open or type some text in it. Try using Ctrl + Shift + Right, text should be selected at word boundaries. a terminal, then close it using command. using Ctrl + Shift + Right again. Expected: Text should be selected at word boundaries. Actual: No text is selected. Cursor doesn't move at all. This is the the same issue as filed at [1] and [2]. If it's reproducible in 3 server implementations (counting openvscode-server), then it's probably an upstream issue. Sadly I don't have an access to GitHub Codespaces, so I can't verify it with an \"official\" implementation [3]. You'll notice in keyboard troubleshooting log below the following 2 lines: It's been suggested in [1] that vscode might still think that is active despite the terminal is closed. Thus, a workaround I've been using is to have the following in (with default unbind): That is, wherever exists, augment it with . [3] I mean, doesn't have terminals. I've tried using Live Share; that doesn't change. See Keyboard shortcuts troubleshooting. The first keypress is before the terminal is opened. The other two are after it's closed. <details<pre[2021-12-03 01:36:00.490] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control [2021-12-03 01:36:00.503] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl') [2021-12-03 01:36:00.509] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:00.513] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift [2021-12-03 01:36:00.517] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift') [2021-12-03 01:36:00.521] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:00.808] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 37, key: ArrowLeft [2021-12-03 01:36:00.813] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 15 ('LeftArrow') [2021-12-03 01:36:00.817] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowLeft] [2021-12-03 01:36:00.821] [window] [info] [KeybindingService]:  From 2 keybinding entries, matched cursorWordLeftSelect, when: textInputFocus, source: built-in. [2021-12-03 01:36:01.146] [window] [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys. [2021-12-03 01:36:03.304] [window] [info] [KeybindingService]: | Resolving [KeyE] [2021-12-03 01:36:03.310] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:03.401] [window] [info] [KeybindingService]: | Resolving [KeyE] [2021-12-03 01:36:03.406] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:03.737] [window] [info] [KeybindingService]: | Resolving [KeyX] [2021-12-03 01:36:03.744] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:03.832] [window] [info] [KeybindingService]: | Resolving [KeyX] [2021-12-03 01:36:03.838] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.210] [window] [info] [KeybindingService]: | Resolving [KeyI] [2021-12-03 01:36:04.218] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.344] [window] [info] [KeybindingService]: | Resolving [KeyI] [2021-12-03 01:36:04.348] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.396] [window] [info] [KeybindingService]: | Resolving [KeyT] [2021-12-03 01:36:04.404] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.518] [window] [info] [KeybindingService]: | Resolving [KeyT] [2021-12-03 01:36:04.523] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.762] [window] [info] [KeybindingService]: | Resolving [Enter] [2021-12-03 01:36:04.769] [window] [info] [KeybindingService]:  From 20 keybinding entries, no when clauses matched the context. [2021-12-03 01:36:04.824] [window] [info] [KeybindingService]: | Resolving [Enter] [2021-12-03 01:36:04.827] [window] [info] [KeybindingService]:  From 20 keybinding entries, no when clauses matched the context. [2021-12-03 01:36:06.677] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control [2021-12-03 01:36:06.685] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl') [2021-12-03 01:36:06.689] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:06.692] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift [2021-12-03 01:36:06.696] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift') [2021-12-03 01:36:06.700] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:06.766] [window] [error] Cannot refresh property when process is undefined: [2021-12-03 01:36:07.142] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 37, key: ArrowLeft [2021-12-03 01:36:07.147] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 15 ('LeftArrow') [2021-12-03 01:36:07.151] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowLeft] [2021-12-03 01:36:07.155] [window] [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalHasBeenCreated terminalFocus && terminalProcessSupported, source: built-in. [2021-12-03 01:36:07.913] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 37, key: ArrowLeft [2021-12-03 01:36:07.920] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 15 ('LeftArrow') [2021-12-03 01:36:07.925] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowLeft] [2021-12-03 01:36:07.930] [window] [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalHasBeenCreated terminalFocus && terminalProcessSupported, source: built-in. [2021-12-03 01:36:08.344] [window] [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys. </pre</details\nI can't reproduce this issue in Firefox or Safari.\nyou mentioned Safari, which implied that you have macOS. Could you please re-try using Linux or Windows? macOS uses Command key for those keybindings, and so duplicated keybindings doesn't exist. Folks at cdr/code-server can't reproduce it on macOS either, but subsequently can reproduce it on Linux. Please re-open this issue.\ndoesn't reproduce for me there either !\nThat looks like Microsoft Edge, based on Chromium engine. Could you please try again on Firefox?\nI can reproduce this in Ubuntu/Firefox\nDoes not repro on Ubuntu/Edge\nCreated a PR with a workaround", "positive_passages": [{"docid": "doc-en-vscode-ba0873e34bd8c02677f4be38cd15dc695bdf8fd7442d1f0395fd0917f0b99753", "text": "import { XtermTerminal } from 'vs/workbench/contrib/terminal/browser/xterm/xtermTerminal'; import { escapeNonWindowsPath } from 'vs/platform/terminal/common/terminalEnvironment'; import { IWorkspaceTrustRequestService } from 'vs/platform/workspace/common/workspaceTrust'; <ins> import { isFirefox } from 'vs/base/browser/browser'; </ins> const enum Constants { /**", "commid": "vscode_pr_139615"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb91c628ed3ba450656d846a909f78ebe8edb73e5daf542f1fd40ca65830333c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: git commit (1 Dec 2021), with openvscode-server patches until commit Browser: Firefox OS Version: Ubuntu 20.04 Steps to Reproduce: a freshly opened window, open or type some text in it. Try using Ctrl + Shift + Right, text should be selected at word boundaries. a terminal, then close it using command. using Ctrl + Shift + Right again. Expected: Text should be selected at word boundaries. Actual: No text is selected. Cursor doesn't move at all. This is the the same issue as filed at [1] and [2]. If it's reproducible in 3 server implementations (counting openvscode-server), then it's probably an upstream issue. Sadly I don't have an access to GitHub Codespaces, so I can't verify it with an \"official\" implementation [3]. You'll notice in keyboard troubleshooting log below the following 2 lines: It's been suggested in [1] that vscode might still think that is active despite the terminal is closed. Thus, a workaround I've been using is to have the following in (with default unbind): That is, wherever exists, augment it with . [3] I mean, doesn't have terminals. I've tried using Live Share; that doesn't change. See Keyboard shortcuts troubleshooting. The first keypress is before the terminal is opened. The other two are after it's closed. <details<pre[2021-12-03 01:36:00.490] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control [2021-12-03 01:36:00.503] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl') [2021-12-03 01:36:00.509] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:00.513] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift [2021-12-03 01:36:00.517] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift') [2021-12-03 01:36:00.521] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:00.808] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 37, key: ArrowLeft [2021-12-03 01:36:00.813] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 15 ('LeftArrow') [2021-12-03 01:36:00.817] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowLeft] [2021-12-03 01:36:00.821] [window] [info] [KeybindingService]:  From 2 keybinding entries, matched cursorWordLeftSelect, when: textInputFocus, source: built-in. [2021-12-03 01:36:01.146] [window] [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys. [2021-12-03 01:36:03.304] [window] [info] [KeybindingService]: | Resolving [KeyE] [2021-12-03 01:36:03.310] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:03.401] [window] [info] [KeybindingService]: | Resolving [KeyE] [2021-12-03 01:36:03.406] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:03.737] [window] [info] [KeybindingService]: | Resolving [KeyX] [2021-12-03 01:36:03.744] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:03.832] [window] [info] [KeybindingService]: | Resolving [KeyX] [2021-12-03 01:36:03.838] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.210] [window] [info] [KeybindingService]: | Resolving [KeyI] [2021-12-03 01:36:04.218] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.344] [window] [info] [KeybindingService]: | Resolving [KeyI] [2021-12-03 01:36:04.348] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.396] [window] [info] [KeybindingService]: | Resolving [KeyT] [2021-12-03 01:36:04.404] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.518] [window] [info] [KeybindingService]: | Resolving [KeyT] [2021-12-03 01:36:04.523] [window] [info] [KeybindingService]:  No keybinding entries. [2021-12-03 01:36:04.762] [window] [info] [KeybindingService]: | Resolving [Enter] [2021-12-03 01:36:04.769] [window] [info] [KeybindingService]:  From 20 keybinding entries, no when clauses matched the context. [2021-12-03 01:36:04.824] [window] [info] [KeybindingService]: | Resolving [Enter] [2021-12-03 01:36:04.827] [window] [info] [KeybindingService]:  From 20 keybinding entries, no when clauses matched the context. [2021-12-03 01:36:06.677] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control [2021-12-03 01:36:06.685] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl') [2021-12-03 01:36:06.689] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:06.692] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift [2021-12-03 01:36:06.696] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift') [2021-12-03 01:36:06.700] [window] [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. [2021-12-03 01:36:06.766] [window] [error] Cannot refresh property when process is undefined: [2021-12-03 01:36:07.142] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 37, key: ArrowLeft [2021-12-03 01:36:07.147] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 15 ('LeftArrow') [2021-12-03 01:36:07.151] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowLeft] [2021-12-03 01:36:07.155] [window] [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalHasBeenCreated terminalFocus && terminalProcessSupported, source: built-in. [2021-12-03 01:36:07.913] [window] [info] [KeybindingService]: / Received keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 37, key: ArrowLeft [2021-12-03 01:36:07.920] [window] [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ArrowLeft, keyCode: 15 ('LeftArrow') [2021-12-03 01:36:07.925] [window] [info] [KeybindingService]: | Resolving ctrl+shift+[ArrowLeft] [2021-12-03 01:36:07.930] [window] [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalHasBeenCreated terminalFocus && terminalProcessSupported, source: built-in. [2021-12-03 01:36:08.344] [window] [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys. </pre</details\nI can't reproduce this issue in Firefox or Safari.\nyou mentioned Safari, which implied that you have macOS. Could you please re-try using Linux or Windows? macOS uses Command key for those keybindings, and so duplicated keybindings doesn't exist. Folks at cdr/code-server can't reproduce it on macOS either, but subsequently can reproduce it on Linux. Please re-open this issue.\ndoesn't reproduce for me there either !\nThat looks like Microsoft Edge, based on Chromium engine. Could you please try again on Firefox?\nI can reproduce this in Ubuntu/Firefox\nDoes not repro on Ubuntu/Edge\nCreated a PR with a workaround", "positive_passages": [{"docid": "doc-en-vscode-2e5997e72e3aa676a913cc92cf128f771724b9f5386e739ea7141fcc36b4c7a8", "text": "} this.xterm?.dispose(); <ins> // HACK: Workaround for Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=559561, // as 'blur' event in xterm.raw.textarea is not triggered on xterm.dispose() // See https://github.com/microsoft/vscode/issues/138358 if (isFirefox) { this._terminalFocusContextKey.reset(); this._terminalHasTextContextKey.reset(); this._onDidBlur.fire(this); } </ins> if (this._pressAnyKeyToCloseListener) { this._pressAnyKeyToCloseListener.dispose(); this._pressAnyKeyToCloseListener = undefined;", "commid": "vscode_pr_139615"}], "negative_passages": []}
{"query_id": "q-en-vscode-15dcf26c2075b273b564ff3e85db8e295e886cb9030a31891df53738e666b732", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes In make a new keybinding: Intellisense shows many arg keys that are inaccurate or not implemented. Here is what I get for intellisense: These appear to be the correct and implemented args to this command: Version: 1.63.0-insider (user setup) Commit: Date: 2021-12-02T05:15:40.605Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0.\nRelated:\nThis issue persists as of vscode I was going to open an bug issue mentioning that some params were not working... when in fact I was using the ones suggested by the intellisense e.g. instead of . A while back I opened: about how the command does not resolve variables whereas does. Also related I guess needs some love to be more consistent feature-wise with .", "positive_passages": [{"docid": "doc-en-vscode-9ae36a6e507f37bef46513cdb6f3e0d48ae7ba7de1c7998df2f834b941fa6827", "text": "properties: { searchString: { type: 'string' }, replaceString: { type: 'string' }, <del> regex: { type: 'boolean' }, regexOverride: { type: 'number', description: nls.localize('actions.find.isRegexOverride', 'Overrides \"Use Regular Expression\" flag.nThe flag will not be saved for the future.n0: Do Nothingn1: Truen2: False') }, wholeWord: { type: 'boolean' }, wholeWordOverride: { type: 'number', description: nls.localize('actions.find.wholeWordOverride', 'Overrides \"Match Whole Word\" flag.nThe flag will not be saved for the future.n0: Do Nothingn1: Truen2: False') }, matchCase: { type: 'boolean' }, matchCaseOverride: { type: 'number', description: nls.localize('actions.find.matchCaseOverride', 'Overrides \"Math Case\" flag.nThe flag will not be saved for the future.n0: Do Nothingn1: Truen2: False') }, </del> <ins> isRegex: { type: 'boolean' }, matchWholeWord: { type: 'boolean' }, isCaseSensitive: { type: 'boolean' }, </ins> preserveCase: { type: 'boolean' }, <del> preserveCaseOverride: { type: 'number', description: nls.localize('actions.find.preserveCaseOverride', 'Overrides \"Preserve Case\" flag.nThe flag will not be saved for the future.n0: Do Nothingn1: Truen2: False') }, </del> findInSelection: { type: 'boolean' }, } }", "commid": "vscode_pr_200998"}], "negative_passages": []}
{"query_id": "q-en-vscode-ef4a335dd35e6a2f2e5d9a244fe6f38cb4efe65ac13a1180d7ae1e016178d0c0", "query": "Issue Type: <bBug</b(sorry, these are not good steps because I can't figure out exactly what triggers this) a language pack installed (I have the german pack) a new workspace or reload VS Code Bug Sometimes I get a prompt to switch display languages. I select no but the prompt will come back again later I see this maybe once or twice a day and haven't figured out exactly what is causing it VS Code version: Code - Insiders 1.64.0-insider (Universal) (, 2021-12-14T13:26:59.630Z) OS version: Darwin x64 21.1.0 Restricted Mode: No <details<summaryExtensions (53)</summaryExtensionVersion ------ salesforce-soql-editor1.8.0 tsl-problem-matcher0.5.0 comment-tagged-templates0.3.1 docs-view0.0.9 emojisense0.9.0 folder-source-actions0.2.1 jsdoc-markdown-highlighting0.0.1 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-yaml-preamble0.1.0 test-ext0.0.1 vscode-eslint2.2.2 dendron0.73.0 dendron-paste-image1.1.0 typescript-notebook2.0.6 gitlens11.7.0 EditorConfig0.16.4 codespaces1.4.2 copilot1.7.4273 remotehub0.20.0 vscode-pull-request-github0.35. vscode-drawio1.6.3 vscode-postfix-ts1.9.4 latex-workshop8.22.0 vscode-platform-specific-sample1.15.0 vscode-platform-specific-sample1.5.0 vscode-memfs0.0.3 template-string-converter0.5.5 vscode-azurefunctions1.6.0 vscode-azureresourcegroups0.4.0 vscode-docker1.18.0 vscode-language-pack-de1.63.3 python2022.0.-dev vscode-pylance2021.12.2 jupyter2022.1. jupyter-keymap1.0.0 jupyter-renderers1.0.4 remote-containers0.209.6 remote-ssh0.70.0 remote-ssh-edit0.70.0 azure-account0.9.11 hexeditor1.8.2 js-debug-nightly2021.11.1217 live-server0.2.11 vscode-github-issue-notebooks0.0.113 vsliveshare1.0.5196 debugger-for-chrome4.13.0 vetur0.35.0 code-spell-checker2.0.13 rest-book5.0.1 ayu1.0.5 luna-paint0.11.0 sort-lines1.9.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nplease ping if you need help with this.\nHere's the code that seems to trigger this: Would extension updates also trigger this?\nand I looked into this with and we were shocked to see that background updating of an extension had an InstallOperation of \"Install\" and not \"Update\" Is this correct Easy repro steps: Using OSS with the marketplace Place a breakpoint on the line linked above ^ (or just at the top of ) Install an old version of a language pack No longer \"Ingore Updates\" Reload the window Your breakpoint will hit when the language pack updates to the latest version again and you'll notice the is set to (aka 2) instead of .\nYeah, it's a bug on my side that I am not propagating the operation properly. Sorry about that. Fixed.\nI did a lang pack install and used it for half a day and didn't seen any prompts to switch display language. Is there anything other way to verify this?\nI have the German language pack installed but haven't been using it. I haven't seen any prompts to switch to German recently so :+1:", "positive_passages": [{"docid": "doc-en-vscode-54d33b3bb5ee9b3c9c4a9ee115d1cb0d21960891ba8661edd42623f21ec187b8", "text": "readonly identifier = this.task.identifier; readonly source = this.task.source; <del> readonly operation = this.task.operation; </del> <ins> get operation() { return this.task.operation; } </ins> get verificationStatus() { return this.task.verificationStatus;", "commid": "vscode_pr_171529"}], "negative_passages": []}
{"query_id": "q-en-vscode-ecc8feb663b037847c3af0c8846b6fbac379b7ca1ffd1496fbd08c2d269d183f", "query": "I do not see the notification toast when I select \"New Terminal\" from command palette. But I see this issue that the OP reported I think: ! ! Originally posted by in\nI see this problem: Start a new terminal - full screen Drag to bottom or right = non-functional If you split the panel right, it is fine\nReproes only when you have more than one terminal in the editor area\nCan do it with a single terminal, clean open of VSCode (mac), no other windows. !\nThanks, I specifically meant when dragging and dropping into the panel.\n/verified second terminal is no longer blank", "positive_passages": [{"docid": "doc-en-vscode-4ba16176f52529c1aab5f17c74ed20e425eb5257a769a97f2d2a4b7099c98f14", "text": "this._container = undefined; } attachToElement(container: HTMLElement): Promise<void> | void { // The container did not change, do nothing if (this._container === container) {", "commid": "vscode_pr_139388"}], "negative_passages": []}
{"query_id": "q-en-vscode-ecc8feb663b037847c3af0c8846b6fbac379b7ca1ffd1496fbd08c2d269d183f", "query": "I do not see the notification toast when I select \"New Terminal\" from command palette. But I see this issue that the OP reported I think: ! ! Originally posted by in\nI see this problem: Start a new terminal - full screen Drag to bottom or right = non-functional If you split the panel right, it is fine\nReproes only when you have more than one terminal in the editor area\nCan do it with a single terminal, clean open of VSCode (mac), no other windows. !\nThanks, I specifically meant when dragging and dropping into the panel.\n/verified second terminal is no longer blank", "positive_passages": [{"docid": "doc-en-vscode-736e0ef7f1f6a95c6fca20424c725922e2db4ae0154386882bd3eb410103d55a", "text": "this._attachBarrier.open(); <del> this.xterm?.attachToElement(container); </del> // Attach has not occurred yet if (!this._wrapperElement) { return this._attachToElement(container); } <ins> this.xterm?.attachToElement(this._wrapperElement); </ins> // The container changed, reattach this._container = container;", "commid": "vscode_pr_139388"}], "negative_passages": []}
{"query_id": "q-en-vscode-f69e3f3483cccc800e588161a3b14bbe01a82cdc9ca476bceecf19cd0589fa94", "query": "allows extensions to disable the \"Open Preview\" button in markdown files. This option should also disable the \"Open Preview\" button in the context menus. ! Originally posted by in\n/verified In stable: ! In insiders: !", "positive_passages": [{"docid": "doc-en-vscode-6567a4b277d3c7d47903930382048de788a6ec15b7fada08c2e5003f92e9e455", "text": "\"explorer/context\": [ { \"command\": \"markdown.showPreview\", <del> \"when\": \"resourceLangId == markdown\", </del> <ins> \"when\": \"resourceLangId == markdown && !hasCustomMarkdownPreview\", </ins> \"group\": \"navigation\" } ], \"editor/title/context\": [ { \"command\": \"markdown.showPreview\", <del> \"when\": \"resourceLangId == markdown\", </del> <ins> \"when\": \"resourceLangId == markdown && !hasCustomMarkdownPreview\", </ins> \"group\": \"1_open\" } ],", "commid": "vscode_pr_139241"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-3969ea180157d9d8df4f8fdf700bf53494304d51864d5c382136a11a3a0e4459", "text": "'out-build/vs/base/node/ps.sh', // Terminal shell integration <del> 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish', </del> 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-env.zsh', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-profile.zsh', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-rc.zsh', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-login.zsh', <del> 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration.fish', </del> <ins> 'out-build/vs/workbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish', </ins> '!**/test/**' ];", "commid": "vscode_pr_183005"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-06a4ba449ee2037dcdb3d51be1362ddb9fcc5798e425dfc8e8a8ca1e1607bd8f", "text": "'out-build/vs/workbench/browser/media/*-theme.css', 'out-build/vs/workbench/contrib/debug/**/*.json', 'out-build/vs/workbench/contrib/externalTerminal/**/*.scpt', <del> 'out-build/vs/workbench/contrib/terminal/browser/media/*.fish', </del> <ins> 'out-build/vs/workbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/*.fish', </ins> 'out-build/vs/workbench/contrib/terminal/browser/media/*.ps1', 'out-build/vs/workbench/contrib/terminal/browser/media/*.sh', 'out-build/vs/workbench/contrib/terminal/browser/media/*.zsh',", "commid": "vscode_pr_183005"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-264e0f847adaf3b070c69aa9ff81bdb51b171f98ae114559e03bbba004560abb", "text": "// Usage: `[[ \"$TERM_PROGRAM\" == \"vscode\" ]] && . \"$(code --locate-shell-integration-path zsh)\"` case 'zsh': file = 'shellIntegration-rc.zsh'; break; // Usage: `string match -q \"$TERM_PROGRAM\" \"vscode\"; and . (code --locate-shell-integration-path fish)` <del> case 'fish': file = 'shellIntegration.fish'; break; </del> <ins> case 'fish': file = 'fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish'; break; </ins> default: throw new Error('Error using --locate-shell-integration-path: Invalid shell type'); } console.log(join(getAppRoot(), 'out', 'vs', 'workbench', 'contrib', 'terminal', 'browser', 'media', file));", "commid": "vscode_pr_183005"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-c9dfff49d85e3b526a3effcc23eee550147f8e939eebdec80d1e9e36b59f6fe6", "text": "// The injection mechanism used for fish is to add a custom dir to $XDG_DATA_DIRS which // is similar to $ZDOTDIR in zsh but contains a list of directories to run from. const oldDataDirs = env?.XDG_DATA_DIRS ?? '/usr/local/share:/usr/share'; <del> const newDataDir = path.join(appRoot, 'out/vs/workbench/contrib/xdg_data'); </del> <ins> const newDataDir = path.join(appRoot, 'out/vs/workbench/contrib/terminal/browser/media/fish_xdg_data'); </ins> envMixin['XDG_DATA_DIRS'] = `${oldDataDirs}:${newDataDir}`; addEnvMixinPathPrefix(options, envMixin); return { newArgs: undefined, envMixin };", "commid": "vscode_pr_183005"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-b68955c06c610121b75a5e04a7cb7151b185bca81f577ef3d588345df03babe4", "text": "<ins> # --------------------------------------------------------------------------------------------- #   Copyright (c) Microsoft Corporation. All rights reserved. #   Licensed under the MIT License. See License.txt in the project root for license information. # --------------------------------------------------------------------------------------------- # # Visual Studio Code terminal integration for fish # # Manual installation: # #   (1) Add the following to the end of `$__fish_config_dir/config.fish`: # #         string match -q \"$TERM_PROGRAM\" \"vscode\" #         and . (code --locate-shell-integration-path fish) # #   (2) Restart fish. # Don't run in scripts, other terminals, or more than once per session. status is-interactive and string match --quiet \"$TERM_PROGRAM\" \"vscode\" and ! set --query VSCODE_SHELL_INTEGRATION or exit set --global VSCODE_SHELL_INTEGRATION 1 # Apply any explicit path prefix (see #99878) if status --is-login; and set -q VSCODE_PATH_PREFIX fish_add_path -p $VSCODE_PATH_PREFIX end set -e VSCODE_PATH_PREFIX # Apply EnvironmentVariableCollections if needed if test -n \"$VSCODE_ENV_REPLACE\" set ITEMS (string split : $VSCODE_ENV_REPLACE) for B in $ITEMS set split (string split = $B) set -gx \"$split[1]\" (echo -e \"$split[2]\") end set -e VSCODE_ENV_REPLACE end if test -n \"$VSCODE_ENV_PREPEND\" set ITEMS (string split : $VSCODE_ENV_PREPEND) for B in $ITEMS set split (string split = $B) set -gx \"$split[1]\" (echo -e \"$split[2]\")\"$$split[1]\" # avoid -p as it adds a space end set -e VSCODE_ENV_PREPEND end if test -n \"$VSCODE_ENV_APPEND\" set ITEMS (string split : $VSCODE_ENV_APPEND) for B in $ITEMS set split (string split = $B) set -gx \"$split[1]\" \"$$split[1]\"(echo -e \"$split[2]\") # avoid -a as it adds a space end set -e VSCODE_ENV_APPEND end # Handle the shell integration nonce if set -q VSCODE_NONCE set -l __vsc_nonce $VSCODE_NONCE set -e VSCODE_NONCE end # Helper function function __vsc_esc -d \"Emit escape sequences for VS Code shell integration\" builtin printf \"e]633;%sa\" (string join \";\" $argv) end # Sent right before executing an interactive command. # Marks the beginning of command output. function __vsc_cmd_executed --on-event fish_preexec __vsc_esc C __vsc_esc E (__vsc_escape_value \"$argv\") $__vsc_nonce # Creates a marker to indicate a command was run. set --global _vsc_has_cmd end # Escape a value for use in the 'P' (\"Property\") or 'E' (\"Command Line\") sequences. # Backslashes are doubled and non-alphanumeric characters are hex encoded. function __vsc_escape_value # Escape backslashes and semi-colons echo $argv  | string replace --all '' ''  | string replace --all ';' 'x3b'  ; end # Sent right after an interactive command has finished executing. # Marks the end of command output. function __vsc_cmd_finished --on-event fish_postexec __vsc_esc D $status end # Sent when a command line is cleared or reset, but no command was run. # Marks the cleared line with neither success nor failure. function __vsc_cmd_clear --on-event fish_cancel __vsc_esc D end # Sent whenever a new fish prompt is about to be displayed. # Updates the current working directory. function __vsc_update_cwd --on-event fish_prompt __vsc_esc P Cwd=(__vsc_escape_value \"$PWD\") # If a command marker exists, remove it. # Otherwise, the commandline is empty and no command was run. if set --query _vsc_has_cmd set --erase _vsc_has_cmd else __vsc_cmd_clear end end # Sent at the start of the prompt. # Marks the beginning of the prompt (and, implicitly, a new line). function __vsc_fish_prompt_start __vsc_esc A end # Sent at the end of the prompt. # Marks the beginning of the user's command input. function __vsc_fish_cmd_start __vsc_esc B end function __vsc_fish_has_mode_prompt -d \"Returns true if fish_mode_prompt is defined and not empty\" functions fish_mode_prompt | string match -rvq '^ *(#|function |end$|$)' end # Preserve the user's existing prompt, to wrap in our escape sequences. functions --copy fish_prompt __vsc_fish_prompt # Preserve and wrap fish_mode_prompt (which appears to the left of the regular # prompt), but only if it's not defined as an empty function (which is the # officially documented way to disable that feature). if __vsc_fish_has_mode_prompt functions --copy fish_mode_prompt __vsc_fish_mode_prompt function fish_mode_prompt __vsc_fish_prompt_start __vsc_fish_mode_prompt end function fish_prompt __vsc_fish_prompt __vsc_fish_cmd_start end else # No fish_mode_prompt, so put everything in fish_prompt. function fish_prompt __vsc_fish_prompt_start __vsc_fish_prompt __vsc_fish_cmd_start end end </ins>", "commid": "vscode_pr_183005"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-c53309dc146adf555d3b750b111e5ae3862211a5320c19b812769cc9434ce7b8", "text": "<del> # --------------------------------------------------------------------------------------------- #   Copyright (c) Microsoft Corporation. All rights reserved. #   Licensed under the MIT License. See License.txt in the project root for license information. # --------------------------------------------------------------------------------------------- # # Visual Studio Code terminal integration for fish # # Manual installation: # #   (1) Add the following to the end of `$__fish_config_dir/config.fish`: # #         string match -q \"$TERM_PROGRAM\" \"vscode\" #         and . (code --locate-shell-integration-path fish) # #   (2) Restart fish. # Don't run in scripts, other terminals, or more than once per session. status is-interactive and string match --quiet \"$TERM_PROGRAM\" \"vscode\" and ! set --query VSCODE_SHELL_INTEGRATION or exit set --global VSCODE_SHELL_INTEGRATION 1 # Apply any explicit path prefix (see #99878) if status --is-login; and set -q VSCODE_PATH_PREFIX fish_add_path -p $VSCODE_PATH_PREFIX end set -e VSCODE_PATH_PREFIX # Apply EnvironmentVariableCollections if needed if test -n \"$VSCODE_ENV_REPLACE\" set ITEMS (string split : $VSCODE_ENV_REPLACE) for B in $ITEMS set split (string split = $B) set -gx \"$split[1]\" (echo -e \"$split[2]\") end set -e VSCODE_ENV_REPLACE end if test -n \"$VSCODE_ENV_PREPEND\" set ITEMS (string split : $VSCODE_ENV_PREPEND) for B in $ITEMS set split (string split = $B) set -gx \"$split[1]\" (echo -e \"$split[2]\")\"$$split[1]\" # avoid -p as it adds a space end set -e VSCODE_ENV_PREPEND end if test -n \"$VSCODE_ENV_APPEND\" set ITEMS (string split : $VSCODE_ENV_APPEND) for B in $ITEMS set split (string split = $B) set -gx \"$split[1]\" \"$$split[1]\"(echo -e \"$split[2]\") # avoid -a as it adds a space end set -e VSCODE_ENV_APPEND end # Handle the shell integration nonce if set -q VSCODE_NONCE set -l __vsc_nonce $VSCODE_NONCE set -e VSCODE_NONCE end # Helper function function __vsc_esc -d \"Emit escape sequences for VS Code shell integration\" builtin printf \"e]633;%sa\" (string join \";\" $argv) end # Sent right before executing an interactive command. # Marks the beginning of command output. function __vsc_cmd_executed --on-event fish_preexec __vsc_esc C __vsc_esc E (__vsc_escape_value \"$argv\") $__vsc_nonce # Creates a marker to indicate a command was run. set --global _vsc_has_cmd end # Escape a value for use in the 'P' (\"Property\") or 'E' (\"Command Line\") sequences. # Backslashes are doubled and non-alphanumeric characters are hex encoded. function __vsc_escape_value # Escape backslashes and semi-colons echo $argv  | string replace --all '' ''  | string replace --all ';' 'x3b'  ; end # Sent right after an interactive command has finished executing. # Marks the end of command output. function __vsc_cmd_finished --on-event fish_postexec __vsc_esc D $status end # Sent when a command line is cleared or reset, but no command was run. # Marks the cleared line with neither success nor failure. function __vsc_cmd_clear --on-event fish_cancel __vsc_esc D end # Sent whenever a new fish prompt is about to be displayed. # Updates the current working directory. function __vsc_update_cwd --on-event fish_prompt __vsc_esc P Cwd=(__vsc_escape_value \"$PWD\") # If a command marker exists, remove it. # Otherwise, the commandline is empty and no command was run. if set --query _vsc_has_cmd set --erase _vsc_has_cmd else __vsc_cmd_clear end end # Sent at the start of the prompt. # Marks the beginning of the prompt (and, implicitly, a new line). function __vsc_fish_prompt_start __vsc_esc A end # Sent at the end of the prompt. # Marks the beginning of the user's command input. function __vsc_fish_cmd_start __vsc_esc B end function __vsc_fish_has_mode_prompt -d \"Returns true if fish_mode_prompt is defined and not empty\" functions fish_mode_prompt | string match -rvq '^ *(#|function |end$|$)' end # Preserve the user's existing prompt, to wrap in our escape sequences. functions --copy fish_prompt __vsc_fish_prompt # Preserve and wrap fish_mode_prompt (which appears to the left of the regular # prompt), but only if it's not defined as an empty function (which is the # officially documented way to disable that feature). if __vsc_fish_has_mode_prompt functions --copy fish_mode_prompt __vsc_fish_mode_prompt function fish_mode_prompt __vsc_fish_prompt_start __vsc_fish_mode_prompt end function fish_prompt __vsc_fish_prompt __vsc_fish_cmd_start end else # No fish_mode_prompt, so put everything in fish_prompt. function fish_prompt __vsc_fish_prompt_start __vsc_fish_prompt __vsc_fish_cmd_start end end </del>", "commid": "vscode_pr_183005"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-423979297e3313782339699630764667b17fa7ecc5249a046229ec3c01742d79", "text": "case 'fish': { // The injection mechanism used for fish is to add a custom dir to $XDG_DATA_DIRS which // is similar to $ZDOTDIR in zsh but contains a list of directories to run from. <del> // const oldDataDirs = env?.XDG_DATA_DIRS ?? '/usr/local/share:/usr/share'; // const newDataDir = path.join(appRoot, 'out/vs/workbench/contrib/terminal/browser/media/fish_xdg_data'); // envMixin['XDG_DATA_DIRS'] = `${oldDataDirs}:${newDataDir}`; // addEnvMixinPathPrefix(options, envMixin); // return { newArgs: undefined, envMixin }; return undefined; </del> <ins> const oldDataDirs = env?.XDG_DATA_DIRS ?? '/usr/local/share:/usr/share'; const newDataDir = path.join(appRoot, 'out/vs/workbench/contrib/terminal/browser/media/fish_xdg_data'); envMixin['XDG_DATA_DIRS'] = `${oldDataDirs}:${newDataDir}`; addEnvMixinPathPrefix(options, envMixin); return { newArgs: undefined, envMixin }; </ins> } case 'pwsh': { if (!originalArgs || arePwshImpliedArgs(originalArgs)) {", "commid": "vscode_pr_185355"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-4af8efd9c1629ea77cfdf7cb050732eb17c68f01964c256261a95ff6224c32a4", "text": "__vsc_esc D end <ins> # Preserve the user's existing prompt, to wrap in our escape sequences. function __preserve_fish_prompt --on-event fish_prompt if functions --query fish_prompt if functions --query __vsc_fish_prompt # Erase the fallback so it can be set to the user's prompt functions --erase __vsc_fish_prompt end functions --copy fish_prompt __vsc_fish_prompt functions --erase __preserve_fish_prompt # Now __vsc_fish_prompt is guaranteed to be defined __init_vscode_shell_integration else if functions --query __vsc_fish_prompt # There is no fish_prompt set, so stick with the default functions --erase __preserve_fish_prompt # Now __vsc_fish_prompt is guaranteed to be defined __init_vscode_shell_integration else function __vsc_fish_prompt echo -n (whoami)@(prompt_hostname) (prompt_pwd) '~> ' end end end end __preserve_fish_prompt </ins> # Sent whenever a new fish prompt is about to be displayed. # Updates the current working directory. function __vsc_update_cwd --on-event fish_prompt", "commid": "vscode_pr_185355"}], "negative_passages": []}
{"query_id": "q-en-vscode-08dbf1052771baf9bcf7d59e03a9062edb3a6acc92337c5955b84d56bae7288d", "query": "Parent issue Update: Activate the fish shell integration by following these instructions: We're keeping this open until automatic injection is looked into.\nDeferring to focus on polishing how shell integration works in general\nFinal implementation details aside, fish's event handing will make at least some of this dead easy: Some will be more difficult, at least to deploy auto-magically, because fish's are the output of shell functions, not the contents of variables: So to transparently preserve the user's original prompt, like the bash script does, would require modifying a shell function on-the-fly, not just a variable. Yikes. That said, I put the above code, plus the following, in my own config\u2014 \u2014and I had all of VS Code's working perfectly with VS Code v1.70.0 + fish 3.5.1. It's only a proof of concept, but hopefully this saves somebody a few web searches down the line, at least. :)\nvery handy info thanks! The bash script handles both PS1 and PRONPT_COMMAND, might be able to wrap the function automatically in a similar way?\nWell, fish doesn't have either: if you want something to run right before the prompt displays, you put it in a function with . There is, alas, no event handler that runs after displaying the prompt but before accepting input (which is where you'd want ). There are also no events specific to the right-side prompt only. FWIW, there's also no equivalent in fish\u2014\"instead it leaves the lines indented to show that the commandline isn\u2019t complete yet\"\u2014but the lack of and sequences in the above didn't seem to have any noticeable impact on VS Code's ability to parse the terminal in my testing.\nah I see, I think this stuff should still work though. We actually don't currently use some of these positions and the 633 E sequence kind of removes the need for them all together. So if there are limitations like this we can just take note for the future, like when finalizing the sequences this month. The limitations imposed on us by the Windows backend are much more frustrating to deal with than this sounds If you want to put a PR out with just the script as a starting point (just the script) we could then give it a try and see if we can get it in as an experimental thing. I guess just manually installing until it's considered stable, plus the automatic injection was a handful for the other shells. You could also move the 633 A to just after 633 D, I'd expect that to work fine.\nI've been wanting to do this since last month, and comment finally motivated me to put up a fish plugin here: The trick I have seen in is that they wait for a event and then initialize the code, at which time the prompt function should be ready however they are defined.\nFYI those sequences may change as they are yet to be finalized ().\nNow that has reminded me fish can do e.g. (which I just... totally blanked on yesterday ), I think I could put together an experimental PR for this\u2014one that could be easily tweaked if/when the escape sequences are finalized.\nAlso thanks to a PR from the fish history file is now loaded so pulls from it when fish is active !\nthat would be fantastic\nThanks everyone! The script should be available in tomorrow's Insiders, see for manual install instructions (replace with ) I'll keep this issue open until we no longer consider it experimental.\nThe new function does not work properly in my case. My fish configuration uses a right prompt and shows the exit code of the command (green check mark). The exit code is always shown as good, even if the executed program returns a non-0 code. The right prompt is also misaligned. It is one line below where it is supposed to be. ! The status code issue seems to be caused by executing first, because this will overwrite and . The misaligned right prompt seems to relate to some newline shenanigans fish does. It removes the last newline from the prompt, but since is after the prompt it doesn't work any longer. I found these related links: , I change the above snippet to this it seems to work better for me.\nthanks for the report! Do you want to submit a PR or should I try out the fix?\nI am not interested in progressing this further or submitting a PR.\nno worries, thanks for reporting\nIsn't this already done? Or is this about automatic integration?\nI was keeping it open until the kinks were worked out, plus automatic injection would be great if it's possible. Not sure anyone has looked into it yet.\nshould we change the title of this issue or create a new one to capture automatic injection?\ni think the right way to add automatic injection would be to append a directory to that contains the integration script in a subdirectory (see )\nwe wouldn't be able to stick it in XDGDATADIRS though in case a user has a file there already. Changing XDGDATADIRS also seems dangerous and I think this would only work on Linux\nit sounds like you may be confused as to what XDGDATADIRS is so i whipped up a pr for this, with links to the relevant spec and fish docs. alternatively i'm confused as to what you might mean. XDGDATADIRS is a set of directories to search for data files, ordered by preference. we'd be adding a directory to the end of it so what a user may already have there is irrelevant, and our directory would be part of the vscode distribution so the user really shouldn't have any files in there. aside from that user things go in XDGDATAHOME, XDGDATADIRS is for system components. i'm not sure what danger you see there. we're adding another directory to find data files in; we're not preventing any other data files from being found. this is documented universal fish behavior on any system it supports. i linked the literal default fish configuration above that demonstrates this. also back when i last used a mac most tools did support the xdg base directories, including fish (and nix, which makes rather heavy use of XDGDATADIRS). the only ones that didn't still don't on linux (like electron ).\noh it's a list of dirs, I thought this was setting a single dir. And you're right we don't need to worry about Windows here. Thanks, will check out the PR soon\nSince the issue is now closed, is the problem reported here something you would still want to fix? It doesn't seem to be fixed on main so far.\nthanks for the reminder, I forked it off to\nTo verify: Make sure fish is installed on your system (macOS or Linux) Launch a fish shell and verify the shell integration decorations should up to the left of the terminal\nyep, works for me!\nUnfortunately this does not work in a newly-installed fish shell via homebrew on macOS. https://user- Pty host logs:\nwhat's your ? Also what is the output of ?\nworks for me with this info: !\ndid you manually install shell integration? This issue is about automatic injection, the update in the original issue was to help users manually activate it before this was done.\nYes I did\nand disabled automatic injection (set ) as you see in the screenshot. it also works for me in a subshell, so I know that i'm testing / verifying manual injection\nit also works for me with automatic injection\nis 3.6.0, and the shell integration path is\nLooking at the code it doesn't look like we actually copy a file to :\nhm, the path does appear to exist <img width=\"1045\" alt=\"image\" src=\"https://user-\"Manually executing it with results in an exit code of 1 and no output, however\nyeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt\nArgh, I had removed the manual integration but still have other FinalTerm-compatible shell integration and probably thought this was working because of that On 26. Jan 2023, at 18:19, Megan Rogge yeah I think what happened was I already had the injection config in my fish file when I tested automatic injection - likely from testing manual injection at one pt \u2014Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID:\nTo verify make sure you don't manually activate shell integration in your , then check with and without and make sure shell integration works and doesn't work respectively.\nWhen I open a terminal in the fish shell and run some commands, then run \"Run recent command\", the commands in the fish terminal don't show up, I assume that means it's not working for me\nworks for me: <img width=\"741\" alt=\"Screenshot 2023-05-30 at 2 43 13 pm\" src=\"\"Do you see the grey/blue/red dot?\nNo, I guess shell integration is not enabled in the fish profile, I'm not sure how to troubleshoot that.\nIs there supposed to be automatic integration in stable VSCode now? It doesn't seem to be working for me, but manual integration still does. Open and make sure it contains the manual integration code:\nhe's trying to test the newly fixed automatic injection in Insiders\ncan you run ? Also enabling trace logs and getting the pty host log when launching would be helpful (be mindful of any sensitive environment variables)\nHere's my pty host log which includes\nthis isn't working for me after I removed my !\nwhat do you mean by removed your XDGDATADIRS? weird, it's there so it should be run afaik. any idea what could be going wrong here wrt the XDGDATADIR auto activation?\nI think I had manually enabled fish shell integration which is why it was working. In order to undo that, to test automatic injection, I removed that directory. Then it didn't work\nIE my expectation was after undoing manual injection, it would work automatically. That wasn't the case.\nI had misunderstood how this injection works because it is different from that of and . Deleting my in the comment above was the reason I saw it not working. I now see it working. !\nsince it's working for and I we'll close this and include it in the release notes. It would be good to get to the bottom of your issue, we can track that in another issue? We can have a call to investigate when you're free if that works.\nSure, call any time\nNot really, sorry. Maybe the snap packaging interferes somehow? From your shell session, are and present?\nWe investigated, it ended up being the fish version being too old. After the update it worked great! Thanks for all the help\nThis isn't working for me in 1.79.0 (non-insider), as far as I can see the fish config is there but XDGDATADIRS isn't getting set. And looking at the code I found -- what happened?\nwe had to disable it because it was printing an error when starting up for someone on the team: For some reason was undefined at the time, it got set later, after our applied.\nLooking at again I believe this would happen when something we need, like , is configured in either or in a file with a basename that's sorted before the one we expose. The file is intentionally read last so people can override vendor configuration, so since we need to run after user configuration maybe providing vendor configuration is just not the way to go here\u2026 sorry Maybe instead we could invoke fish with ? That would ensure the integration happens after any configuration but before* interactive input. If I have the spoons and noone beats me to it I'll try to whip up a PR for that next week.\nOne way to make sure something runs after the user's but before interactive input is to put the necessary code in a self-erasing function tied to the , e.g.: This can be placed in the appropriate vendor-config directory as simply (e.g.) with no need to worry about sorting order. The function will be defined during startup, executed just before printing the first prompt, then immediately undefined so it doesn't run twice.\nI tried something like that thanks to your suggestion. It's not working atm and not sure why... lmk if you see what could be wrong here\nI think you also need to add to this function:\nRemoving verification-needed as this was covered by a test plan item.", "positive_passages": [{"docid": "doc-en-vscode-9d1793e75f8c9a0b88c75e45f78eb470f525e25fbb409e9886e650d96a4515e0", "text": "functions fish_mode_prompt | string match -rvq '^ *(#|function |end$|$)' end <del> # Preserve the user's existing prompt, to wrap in our escape sequences. functions --copy fish_prompt __vsc_fish_prompt </del> # Preserve and wrap fish_mode_prompt (which appears to the left of the regular # prompt), but only if it's not defined as an empty function (which is the # officially documented way to disable that feature). <del> if __vsc_fish_has_mode_prompt functions --copy fish_mode_prompt __vsc_fish_mode_prompt function fish_mode_prompt __vsc_fish_prompt_start __vsc_fish_mode_prompt end function fish_prompt __vsc_fish_prompt __vsc_fish_cmd_start end else # No fish_mode_prompt, so put everything in fish_prompt. function fish_prompt __vsc_fish_prompt_start __vsc_fish_prompt __vsc_fish_cmd_start </del> <ins> function __init_vscode_shell_integration if __vsc_fish_has_mode_prompt functions --copy fish_mode_prompt __vsc_fish_mode_prompt function fish_mode_prompt __vsc_fish_prompt_start __vsc_fish_mode_prompt end function fish_prompt __vsc_fish_prompt __vsc_fish_cmd_start end else # No fish_mode_prompt, so put everything in fish_prompt. function fish_prompt __vsc_fish_prompt_start __vsc_fish_prompt __vsc_fish_cmd_start end </ins> end end", "commid": "vscode_pr_185355"}], "negative_passages": []}
{"query_id": "q-en-vscode-a4469e191077243c3384bb1ea4ba932a08617c398431723d3a64ec787c9289de", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi! I want to solve this issue as a good-first-issue. Please help me if you can :) In Github there was a problem that README and issues don't work for RTL languages. () Then on November 16, 2021, Github announced that we fixed this problem: () But vscode does not support it yet. For example we see ) in github like this: ! But in vscode, we see the markdown preview like this: ! Feature or improvement request: Providing support for correctly previewing RTL languages texts.\nHi! Can you help me to solve this issue? (as a good-first-issue) I opened a pull request here:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-d6b0f888696eb1f0a88647c02b55386e9fdb88c4979dee98e4cdad972f0bfccd", "text": "resourceProvider: WebviewResourceProvider, ): Promise<MarkdownContentProviderOutput> { const rendered = await this.engine.render(markdownDocument, resourceProvider); <del> const html = `<div class=\"markdown-body\">${rendered.html}<div class=\"code-line\" data-line=\"${markdownDocument.lineCount}\"></div></div>`; </del> <ins> const html = `<div class=\"markdown-body\" dir=\"auto\">${rendered.html}<div class=\"code-line\" data-line=\"${markdownDocument.lineCount}\"></div></div>`; </ins> return { html, containingImages: rendered.containingImages", "commid": "vscode_pr_139644"}], "negative_passages": []}
{"query_id": "q-en-vscode-a4469e191077243c3384bb1ea4ba932a08617c398431723d3a64ec787c9289de", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi! I want to solve this issue as a good-first-issue. Please help me if you can :) In Github there was a problem that README and issues don't work for RTL languages. () Then on November 16, 2021, Github announced that we fixed this problem: () But vscode does not support it yet. For example we see ) in github like this: ! But in vscode, we see the markdown preview like this: ! Feature or improvement request: Providing support for correctly previewing RTL languages texts.\nHi! Can you help me to solve this issue? (as a good-first-issue) I opened a pull request here:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-e1c8b25de3a0d986357d558c1c90c3546f144db9b9bc749a5af8bc1bce45972c", "text": "if (token.map && token.type !== 'inline') { token.attrSet('data-line', String(token.map[0])); token.attrJoin('class', 'code-line'); <ins> token.attrJoin('dir', 'auto'); </ins> } } });", "commid": "vscode_pr_139644"}], "negative_passages": []}
{"query_id": "q-en-vscode-a4469e191077243c3384bb1ea4ba932a08617c398431723d3a64ec787c9289de", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Hi! I want to solve this issue as a good-first-issue. Please help me if you can :) In Github there was a problem that README and issues don't work for RTL languages. () Then on November 16, 2021, Github announced that we fixed this problem: () But vscode does not support it yet. For example we see ) in github like this: ! But in vscode, we see the markdown preview like this: ! Feature or improvement request: Providing support for correctly previewing RTL languages texts.\nHi! Can you help me to solve this issue? (as a good-first-issue) I opened a pull request here:\n/verified", "positive_passages": [{"docid": "doc-en-vscode-3058dede9555e96c4977514128e56770fa347a4c504507278e57c6b432293f40", "text": "return engine.parse(text.replace(UNICODE_NEWLINE_REGEX, ''), {}); } public resetSlugCount(): void { this._slugCount = new Map<string, number>(); }", "commid": "vscode_pr_139644"}], "negative_passages": []}
{"query_id": "q-en-vscode-83021b20165cc6a6c6fcc41ebb2d4d548c953544fc493f69519b9e7a01c08b75", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: stable and from sources Steps to Reproduce: server vscode in safari simple browser :bug: Observe icons don't load (icons load if disable Cross Origin Restrictions in develop menu is checked)\nHow are you running the server? I see the icons loading in but not on localhost using : ! This seems expected since Safari seems more strict about loading content from localhost in this case\nTry codespaces, it repros there too. (For running the server I use ) It works on serverless (i.e. and ) because they are served in a different way I think\nI'd also like to see it fixed. It's still reproducible on latest Safari version. <img width=\"290\" alt=\"image\" src=\"https://user-\"\nThis definitely seems like a webkit bug but I can't put together a minimal repo. The issue is the the codicon font face doesn't go through the service worker during loading despite it's parent css file being loaded by it: ! I also tried debugging the production code in codespaces but Safari's dev tools are pretty much unusable with our minified service worker Instead, I'm going to push a change that inlines the font in the css file to hopefully work around this issue\nLooks to be working in latest insiders !\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-c199ed605e87e5bcb4468e016a7f0a888b927da8d6298495333c5f34ae87ed25", "text": "*--------------------------------------------------------------------------------------------*/ // @ts-check const path = require('path'); <del> const fs = require('fs'); </del> const esbuild = require('esbuild'); const args = process.argv.slice(2);", "commid": "vscode_pr_176462"}], "negative_passages": []}
{"query_id": "q-en-vscode-83021b20165cc6a6c6fcc41ebb2d4d548c953544fc493f69519b9e7a01c08b75", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: stable and from sources Steps to Reproduce: server vscode in safari simple browser :bug: Observe icons don't load (icons load if disable Cross Origin Restrictions in develop menu is checked)\nHow are you running the server? I see the icons loading in but not on localhost using : ! This seems expected since Safari seems more strict about loading content from localhost in this case\nTry codespaces, it repros there too. (For running the server I use ) It works on serverless (i.e. and ) because they are served in a different way I think\nI'd also like to see it fixed. It's still reproducible on latest Safari version. <img width=\"290\" alt=\"image\" src=\"https://user-\"\nThis definitely seems like a webkit bug but I can't put together a minimal repo. The issue is the the codicon font face doesn't go through the service worker during loading despite it's parent css file being loaded by it: ! I also tried debugging the production code in codespaces but Safari's dev tools are pretty much unusable with our minified service worker Instead, I'm going to push a change that inlines the font in the css file to hopefully work around this issue\nLooks to be working in latest insiders !\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-6710494abf54e163a0c9fd0d0b1c517f2c5bc785c477911e6e83752de500a6a5", "text": "const outDir = path.join(outputRoot, 'media'); async function build() { <del> fs.copyFileSync( path.join(__dirname, 'node_modules', 'vscode-codicons', 'dist', 'codicon.css'), path.join(outDir, 'codicon.css')); fs.copyFileSync( path.join(__dirname, 'node_modules', 'vscode-codicons', 'dist', 'codicon.ttf'), path.join(outDir, 'codicon.ttf')); </del> await esbuild.build({ <del> entryPoints: [ path.join(srcDir, 'index.ts') ], </del> <ins> entryPoints: { 'index': path.join(srcDir, 'index.ts'), 'codicon': path.join(__dirname, 'node_modules', 'vscode-codicons', 'dist', 'codicon.css'), }, loader: { '.ttf': 'dataurl', }, </ins> bundle: true, minify: true, sourcemap: false,", "commid": "vscode_pr_176462"}], "negative_passages": []}
{"query_id": "q-en-vscode-83021b20165cc6a6c6fcc41ebb2d4d548c953544fc493f69519b9e7a01c08b75", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: stable and from sources Steps to Reproduce: server vscode in safari simple browser :bug: Observe icons don't load (icons load if disable Cross Origin Restrictions in develop menu is checked)\nHow are you running the server? I see the icons loading in but not on localhost using : ! This seems expected since Safari seems more strict about loading content from localhost in this case\nTry codespaces, it repros there too. (For running the server I use ) It works on serverless (i.e. and ) because they are served in a different way I think\nI'd also like to see it fixed. It's still reproducible on latest Safari version. <img width=\"290\" alt=\"image\" src=\"https://user-\"\nThis definitely seems like a webkit bug but I can't put together a minimal repo. The issue is the the codicon font face doesn't go through the service worker during loading despite it's parent css file being loaded by it: ! I also tried debugging the production code in codespaces but Safari's dev tools are pretty much unusable with our minified service worker Instead, I'm going to push a change that inlines the font in the css file to hopefully work around this issue\nLooks to be working in latest insiders !\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-b014c238147bbe6aaa15b657ae260473468de382263536f2ffc888ce232314d0", "text": "<meta http-equiv=\"Content-Security-Policy\" content=\" default-src 'none'; <del> font-src ${this._webviewPanel.webview.cspSource}; </del> <ins> font-src data:; </ins> style-src ${this._webviewPanel.webview.cspSource}; script-src 'nonce-${nonce}'; frame-src *;", "commid": "vscode_pr_176462"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ad0842faad09a4a06e94d511a030a70d7991a344f2ec89c7f08ab6a0621c713", "query": "Issue Type: <bBug</bthe Extensions tab enough text in the search box to cause scrolling back to the beginning of the search box Actual: The typed text overflows the right edge of the search box Expected: the typed text doesn't overflow the edge of the search box <img width=\"210\" alt=\"Screenshot 2022-01-09 at 18 00 24\" src=\"https://user-\"VS Code version: Code 1.63.2 (, 2021-12-15T09:38:17.605Z) OS version: Darwin arm64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-2b4273f43c7476e01021267da1c1c532eeb0c4e05c5afa3482378f182e115394", "text": "disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();", "commid": "vscode_pr_45"}], "negative_passages": []}
{"query_id": "q-en-vscode-88fa059c970fc39869b85d520497c1f457334bc821978b4605a005ec5eda8b54", "query": "The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)\nI am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.\nI think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.\nis this issue closed? or still needs help?\nIts still open and there is a PR which has to be reviewed.\nHello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?\nThanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/", "positive_passages": [{"docid": "doc-en-vscode-b6d24fc58ee66af9edc61b965c94b7b9f07a7f0d1363c25d1348c94245ed418d", "text": "const newRenderMode = e.altKey && e.ctrlKey ? altMode : defaultMode; if (newRenderMode !== this._activeRenderMode) { this._activeRenderMode = newRenderMode; <del> const ranges = this._getHintsRanges(); const copies = this._copyInlayHintsWithCurrentAnchor(this._editor.getModel()); this._updateHintsDecorators(ranges, copies); </del> <ins> const model = this._editor.getModel(); const copies = this._copyInlayHintsWithCurrentAnchor(model); this._updateHintsDecorators([model.getFullModelRange()], copies); </ins> scheduler.schedule(0); } }));", "commid": "vscode_pr_150133"}], "negative_passages": []}
{"query_id": "q-en-vscode-88fa059c970fc39869b85d520497c1f457334bc821978b4605a005ec5eda8b54", "query": "The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)\nI am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.\nI think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.\nis this issue closed? or still needs help?\nIts still open and there is a PR which has to be reviewed.\nHello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?\nThanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/", "positive_passages": [{"docid": "doc-en-vscode-441a800900325571e0033953aba7a031149bcff0856e2e63d364a15746a73201", "text": "} // return inlay hints but with an anchor that reflects \"updates\" <del> // that happens after receiving them, e.g adding new lines before a hint </del> <ins> // that happened after receiving them, e.g adding new lines before a hint </ins> private _copyInlayHintsWithCurrentAnchor(model: ITextModel): InlayHintItem[] { const items = new Map<InlayHintItem, InlayHintItem>(); for (const [id, obj] of this._decorationsMetadata) {", "commid": "vscode_pr_150133"}], "negative_passages": []}
{"query_id": "q-en-vscode-88fa059c970fc39869b85d520497c1f457334bc821978b4605a005ec5eda8b54", "query": "The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)\nI am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.\nI think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.\nis this issue closed? or still needs help?\nIts still open and there is a PR which has to be reviewed.\nHello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?\nThanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/", "positive_passages": [{"docid": "doc-en-vscode-b64684817e2d53d435f22a1ff8495944b9d7fd42f3088f0642d03f5aa95df186", "text": "const container = document.createElement('span'); container.classList.add('all-options'); parent.appendChild(container); <del> const action = new Action('all', localize('all', \"Show Quick Pick Options...\"), Codicon.chevronDown.classNames, true, () => { </del> <ins> const action = new Action('all', localize('all', \"Show Search Modes...\"), Codicon.chevronDown.classNames, true, () => { </ins> quickInputService.quickAccess.show('?'); }); const dropdown = new ActionViewItem(undefined, action, { icon: true, label: false, hoverDelegate });", "commid": "vscode_pr_150133"}], "negative_passages": []}
{"query_id": "q-en-vscode-88fa059c970fc39869b85d520497c1f457334bc821978b4605a005ec5eda8b54", "query": "The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)\nI am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.\nI think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.\nis this issue closed? or still needs help?\nIts still open and there is a PR which has to be reviewed.\nHello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?\nThanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/", "positive_passages": [{"docid": "doc-en-vscode-ca4ab6b62df407747f55251bedfaf29797ee16d4151b29a0cf166010d3f75c16", "text": "import 'vs/css!./media/extensionEditor'; import { localize } from 'vs/nls'; import * as arrays from 'vs/base/common/arrays'; <del> import { OS } from 'vs/base/common/platform'; </del> <ins> import { OS, locale } from 'vs/base/common/platform'; </ins> import { Event, Emitter } from 'vs/base/common/event'; import { Cache, CacheResult } from 'vs/base/common/cache'; import { Action, IAction } from 'vs/base/common/actions';", "commid": "vscode_pr_150133"}], "negative_passages": []}
{"query_id": "q-en-vscode-88fa059c970fc39869b85d520497c1f457334bc821978b4605a005ec5eda8b54", "query": "The 'Last updated' and 'released on' dates on the extension page use the American format. This is confusing to many people. ! I tried to Spanish and German, but the problem remains: ! ! Consider using a unambiguous date format such as yyyy-mm-dd (ISO 8601)\nI am not locating the datetime as a resource for localization, I'm assuming it is concatenated in runtime so not a loc issue. Please help if I'm mistaken.\nI think using the unambiguous date format is a good way forward. However, we could do something where en-US is displayed one way everything else is displayed the other way... but I don't think that is 100% accurate.\nis this issue closed? or still needs help?\nIts still open and there is a PR which has to be reviewed.\nHello, is this issue still open? I am new to contributing to GitHub projects and this seems like a good first issue for me. Is there a way to claim this issue? If I am able to work on this, do you have any advice for me in contributing for the first time?\nThanks for your interest. This is already being worked on. Please look for another good first and help wanted issues. Thanks/", "positive_passages": [{"docid": "doc-en-vscode-1becc7e76ad631ea7c3a8063929c4a9c463561f4096fde1e7b8d2e0b41cdd555", "text": "append(moreInfo, $('.more-info-entry', undefined, $('div', undefined, localize('release date', \"Released on\")), <del> $('div', undefined, new Date(gallery.releaseDate).toLocaleString(undefined, { hourCycle: 'h23' })) </del> <ins> $('div', undefined, new Date(gallery.releaseDate).toLocaleString(locale, { hourCycle: 'h23' })) </ins> ), $('.more-info-entry', undefined, $('div', undefined, localize('last updated', \"Last updated\")), <del> $('div', undefined, new Date(gallery.lastUpdated).toLocaleString(undefined, { hourCycle: 'h23' })) </del> <ins> $('div', undefined, new Date(gallery.lastUpdated).toLocaleString(locale, { hourCycle: 'h23' })) </ins> ) ); }", "commid": "vscode_pr_150133"}], "negative_passages": []}
{"query_id": "q-en-vscode-e36138300b3fe36a633132ce898a76b6012027220087a5d94898d0b3bd61a43a", "query": "<img width=\"600\" src=\"https://user-\"<img width=\"600\" src=\"https://user-\"<img width=\"600\" src=\"https://user-\"<img width=\"600\" src=\"https://user-\"IMO the labels should be consistent and we should use the icon + label as much as possible: !\nI like your idea of showing the icon + label. But would like to show it next to the version as they are coupled. Also showing an addition line for a pre-release extension in the hover seems redundant to me. So, I just icon to the existing label and this is how it looks: ! !", "positive_passages": [{"docid": "doc-en-vscode-2b4273f43c7476e01021267da1c1c532eeb0c4e05c5afa3482378f182e115394", "text": "disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();", "commid": "vscode_pr_45"}], "negative_passages": []}
{"query_id": "q-en-vscode-157a6f42988b6361cf5d0f517e4184111d68a664c99b36f8110cd61c275ebd2a", "query": "Testing On macOS Ensure the setting is not modified (default to ) Create two folders and , create file in Drag it to Undo There isn't any prompt of warning\nRenaming a file and undo doesn't warn either.\nThese are not destructive operations, correct? The original expectation was that all destructive operations would prompt, do you think that any operations at all should prompt?\nThe way I interpreter is it will warn is it prompts and tells you what's going to happen when you undo/redo as the undo/redo is focus based and it's likely to mis-trigger. I don't necessarily want to disable this feature (as it's convinient) but I want to be aware of what's going to change. Undo the dnd is one of them as I might miss where the file will be moved into (especially when I'm traversing in the undo stack).\nChanged the config around to better stratify this:", "positive_passages": [{"docid": "doc-en-vscode-2b4273f43c7476e01021267da1c1c532eeb0c4e05c5afa3482378f182e115394", "text": "disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();", "commid": "vscode_pr_45"}], "negative_passages": []}
{"query_id": "q-en-vscode-daf3c1b306cf014bc3ebb4be8fc45b9b4ea9b203cb3207c120c8aefda3b8d145", "query": "<img width=\"452\" alt=\"Screen Shot 2022-01-27 at 11 21 24 am\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-2b4273f43c7476e01021267da1c1c532eeb0c4e05c5afa3482378f182e115394", "text": "disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();", "commid": "vscode_pr_45"}], "negative_passages": []}
{"query_id": "q-en-vscode-802a85067a5676c0cf65026601cd1398cb5b601a6106927c7cb2f3db6f9a522b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.2 OS Version: Windows 10 Steps to Reproduce: a git repo in root of a drive (network share in my case) a change of a file to Source control a see file diff version is shown as empty command line shows diffs properly when git repo is located in some subfolder git diff works in VSCode properly\nVS Code Version: 1.67.2 OS Version: Windows 10 () I am also receiving this error, and I have pinpointed it in the Git Output, hopefully, it helps the path is missing the first character in the path for a specific file on the 'git show --textconv' lines 'ub-folder' vs 'sub-folder' If the command is run manually, with the correct path there are no issues Working (Non-root folder) [2022-06-01T06:49:42.910Z] git ls-tree -l HEAD -- fserverc$gitsharesub-folderMapper [229ms] [2022-06-01T06:49:42.991Z] git show --textconv HEAD:sub- [318ms] Not Working (Root folder) [2022-06-01T06:51:54.868Z] git ls-tree -l HEAD -- fservergitsharesub-folderMapper [226ms] [2022-06-01T06:51:54.897Z] git show --textconv HEAD:ub- [262ms]\nThe issue is in the file The following Line needs to be changed to As the current process is removing a specific length, when sometimes the variable for 'to' can contain a single slash or double slash (which the + 1 would handle the double slash) I recommend using the regex to effectively trim any leading slashes rather than a calculated length. I have a working file here I can provide further details if required as well.\nthank you very much for looking into this. I have looked at this today and while adopting a regex to remove the characters from the resulting path will work, I think that there is something else happening here that I would like to understand before making a fix. Debugging the issue I have noticed that when you open a folder from the root as described in this issue, the value of the parameter contains a trailing . This is why adding +1 to it, will actually remove an unwanted character. I will investigate this further and will get a fix in this week.\nQuick update on this issue. While the method can be improved, the root cause of the problem here is that returns a path that has a trailing character. This then results in the repository root being incorrect which can result in unexpected behaviour, diff editor not working being one example. This method already has code to handle mapped drives but it does not seem to handle this particular scenario. As we are in the process of shutting down for the next Stable release, I will be looking at fixing this issue sometimes next week. I will update the issue when the fix will be released in Insiders. Thanks for your patience.\nI believe I have tracked down the root cause of the issue to the call: Running the following tests clearly illustrate the problem. Notice that the second call contains a trailing . This particular behavior seems to be by design based on an old issue that I have found - One option that I have considered was to remove the trailing slash from the repository root but that does not seem to be a good option as there are Windows path that are only valid if they contain a trailing slash (ex: ). I am more inclined to tweak the implementation of to always use as that seems to be able to correctly handle directory paths with the trailing . what are your thoughts? Thanks!\nHi, I'm also having this issue, even on the insiders build. I disabled all installed extensions. Expected Git Output: Actual Git Output: The drive in question is a mapped network drive. Whenever I try to view the file diff, the previous file is blank. This problem applies to all files on the network drive, even ones in subdirectories. Let me know if there's any other information I should provide.\nI have file to track the problem that you have reported.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nYes\nI'll mark this issue as verified as part of . Please file a new issue if the bug continues to occur on the latest Stable and/or Insiders versions of VS Code.", "positive_passages": [{"docid": "doc-en-vscode-3ac3b9c8d981a793ab96a71387bcbd073737922ada63b6f6b30d38c47a290446", "text": "const repoPath = path.normalize(result.stdout.trimLeft().replace(/[rn]+$/, '')); if (isWindows) { <del> // On Git 2.25+ if you call `rev-parse --show-toplevel` on a mapped drive, instead of getting the mapped drive path back, you get the UNC path for the mapped drive. // So we will try to normalize it back to the mapped drive path, if possible </del> <ins> // On Git 2.25+ if you call `rev-parse --show-toplevel` on a mapped drive, instead of getting the mapped // drive path back, you get the UNC path for the mapped drive. So we will try to normalize it back to the // mapped drive path, if possible </ins> const repoUri = Uri.file(repoPath); const pathUri = Uri.file(repositoryPath); if (repoUri.authority.length !== 0 && pathUri.authority.length === 0) {", "commid": "vscode_pr_154342"}], "negative_passages": []}
{"query_id": "q-en-vscode-802a85067a5676c0cf65026601cd1398cb5b601a6106927c7cb2f3db6f9a522b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.64.2 OS Version: Windows 10 Steps to Reproduce: a git repo in root of a drive (network share in my case) a change of a file to Source control a see file diff version is shown as empty command line shows diffs properly when git repo is located in some subfolder git diff works in VSCode properly\nVS Code Version: 1.67.2 OS Version: Windows 10 () I am also receiving this error, and I have pinpointed it in the Git Output, hopefully, it helps the path is missing the first character in the path for a specific file on the 'git show --textconv' lines 'ub-folder' vs 'sub-folder' If the command is run manually, with the correct path there are no issues Working (Non-root folder) [2022-06-01T06:49:42.910Z] git ls-tree -l HEAD -- fserverc$gitsharesub-folderMapper [229ms] [2022-06-01T06:49:42.991Z] git show --textconv HEAD:sub- [318ms] Not Working (Root folder) [2022-06-01T06:51:54.868Z] git ls-tree -l HEAD -- fservergitsharesub-folderMapper [226ms] [2022-06-01T06:51:54.897Z] git show --textconv HEAD:ub- [262ms]\nThe issue is in the file The following Line needs to be changed to As the current process is removing a specific length, when sometimes the variable for 'to' can contain a single slash or double slash (which the + 1 would handle the double slash) I recommend using the regex to effectively trim any leading slashes rather than a calculated length. I have a working file here I can provide further details if required as well.\nthank you very much for looking into this. I have looked at this today and while adopting a regex to remove the characters from the resulting path will work, I think that there is something else happening here that I would like to understand before making a fix. Debugging the issue I have noticed that when you open a folder from the root as described in this issue, the value of the parameter contains a trailing . This is why adding +1 to it, will actually remove an unwanted character. I will investigate this further and will get a fix in this week.\nQuick update on this issue. While the method can be improved, the root cause of the problem here is that returns a path that has a trailing character. This then results in the repository root being incorrect which can result in unexpected behaviour, diff editor not working being one example. This method already has code to handle mapped drives but it does not seem to handle this particular scenario. As we are in the process of shutting down for the next Stable release, I will be looking at fixing this issue sometimes next week. I will update the issue when the fix will be released in Insiders. Thanks for your patience.\nI believe I have tracked down the root cause of the issue to the call: Running the following tests clearly illustrate the problem. Notice that the second call contains a trailing . This particular behavior seems to be by design based on an old issue that I have found - One option that I have considered was to remove the trailing slash from the repository root but that does not seem to be a good option as there are Windows path that are only valid if they contain a trailing slash (ex: ). I am more inclined to tweak the implementation of to always use as that seems to be able to correctly handle directory paths with the trailing . what are your thoughts? Thanks!\nHi, I'm also having this issue, even on the insiders build. I disabled all installed extensions. Expected Git Output: Actual Git Output: The drive in question is a mapped network drive. Whenever I try to view the file diff, the previous file is blank. This problem applies to all files on the network drive, even ones in subdirectories. Let me know if there's any other information I should provide.\nI have file to track the problem that you have reported.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nYes\nI'll mark this issue as verified as part of . Please file a new issue if the bug continues to occur on the latest Stable and/or Insiders versions of VS Code.", "positive_passages": [{"docid": "doc-en-vscode-4de055045257213920bfdb991d0acbd91e80d7edd9dfbd6a168d154797a5eed9", "text": "return path.normalize(pathUri.fsPath); } <ins> // On Windows, there are cases in which the normalized path for a mapped folder contains a trailing `` // character (ex: serverfolder) due to the implementation of `path.normalize()`. This behaviour is // by design as documented in https://github.com/nodejs/node/issues/1765. if (repoUri.authority.length !== 0) { return repoPath.replace(/$/, ''); } </ins> } return repoPath;", "commid": "vscode_pr_154342"}], "negative_passages": []}
{"query_id": "q-en-vscode-1f22cf7616d6a1efa5e982e948ba14a837a5a2f05f7c8261ffe6441eea2f1dce", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Use to create if exists in directory. Not just using latest commit to create .\nAre you using an extension which adds the ability to create a PR? If so, please report the issue on the extension repo. The Report Issue dialog from VS Code's Help menu may be able to assist you. /needsMoreInfo\nYes, after recheck,it's a feature of extension,which seems to be a builtin exttension.\nCan you give me the full name of the extension? Maybe a screenshot of it in the product? Or the view where you can create a PR?\nThe full name is exactly <img src=\"https://user-\" alt=\"drawing\" width=\"200\"/Here is I create Pr !\nI'd like to fix it. Any leads are appreciated.\nSure, this would be a great starting point:\nVerification: and clone a branch a change to and commit to push/publish that branch. Code should tell you you can't push to that repo and will offer to fork the repository, accept. should then ask you whether you'd like to create a PR, accept. You should get shown exactly 9 PR templates to choose from. Reference:\nI tried but after selecting a repository to fork (which then successfully creates a fork on Github) nothing is pushed without any error message. However, the developer console and the Git extension logs show this: ! It seems the source of the problem lies when calling : Maybe no rename occurs when calling (with no exception thrown).\nVery strange, can you easily reproduce? Delete your fork and try again.\nYes. I checked it several times and the results were the same.\nI did get the list of PR templates: ! However, I had no way to get back to the picker after taking that screenshot (which dismissed the picker). At minimum I feel we should use , since the Create PR functionality is not exposed as a command palette command, I am stuck. Additionally, after I selected a template to create the PR, nothing happened. Finally, it was unexpected that I get two popups to create a PR when the GitHub Pull Requests and Issues extension is installed: !\nYou mean no PR was created, right? Nonetheless, I think the Github extension needs more visible error messages (e.g., via notifications).\nYes, no PR was created (I checked on GitHub).\nCreated two issues from the discoveries. Thanks!\nActually three. Creating a PR just doesn't work at all anymore:\nFor step 4, when I try publishing the branch, I get the error \"Git: remote: Permission to joaomoreno/test-pr- denied to rzhao271.\" There is no option to create a fork: !\nIs the Github extension enabled for you?\nJust confirmed that it's enabled for me.\nCan you file a separate issue?\nVerification of this issue fails since the user is no longer prompted to create a PR as found in :/\nWait you hit this too? I totally can't repro, that's why I asked to follow up with a separate issue. We can move this to May just for verification sake.\nYeah I hit the same thing as\nI just tried testing this: On pushing the new branch, I get ! and then: !\nReopening due to comment but feel free to do what you want with this\nI got the same issue on the latest Insiders <img width=\"1202\" alt=\"image\" src=\"https://user-\"Command output: Remote URL:\nthis is\nMoving verification to July to account for", "positive_passages": [{"docid": "doc-en-vscode-dd95d7252679baff8400476752ff16f1357bd89d42a8417431e77ba849511289", "text": "return false; } <del> const match = /^(?:https://github.com/|git@github.com:)([^/]+)/([^/.]+)(?:.git)?$/i.exec(remoteUrl); </del> <ins> const match = /^(?:https://github.com/|git@github.com:)([^/]+)/([^/.]+)/i.exec(remoteUrl); </ins> if (!match) { return false; }", "commid": "vscode_pr_151072"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c83c36523a0597d3d39ddbada578e546e9260f8402984a2a9c40aef2b9b563e", "query": "Issue Type: <bBug</bmicrosoft/vscode-extension-samples the helloworld-sample folder , build, verift that its contributed \"Hello World\" command activates the extension and shows a notification. the vscode version references in in two places to use 1.43 minimum. code to activate function in , for example: , run, use \"Hello World\" command to activate. breakpoint on return line above. a folder. Explorer button or context menu to create a new file. Confirm that the event fires and your breakpoint is hit. from breakpoint. Explorer context menu to copy/paste or use drag/drop with modifier to drip as a copy. :bug: The event callback does not run, despite the API doc stating: Issue also exists in 1.64.2 VS Code version: Code - Insiders 1.65.0-insider (, 2022-02-21T05:15:17.930Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --\ncc\nthe extension host's event is only emitting from 's event, but the explorer is using the 's , which doesn't seem to talk to the working copy service. What do you think the fix here should be? (cc\nthe bulk edit service is using the for its operations. If you look at , there is a bunch of usages for that service. The working copy file service is a wrapper around the file service that ensures the relevant events are emitted and can be participated on. I suspect that for the copy/paste operation or drag/drop we are possibly not using the bulk edit service but the file service directly? I suggest to make a pass over all explorer code and look for raw usages of to replace with bulk edit service. I think that would even enable undo/redo properly.\nMy bad, the real bug is that this block: doesn't handle events. cc\nPragmatic fix would probably to treat the same as .", "positive_passages": [{"docid": "doc-en-vscode-ebd47da9b8fb86017e561da920c1cd8f8829a84545db7e2fd060fd652a882b65", "text": "this._onDidDeleteFile.fire(Object.freeze({ files: files.map(f => URI.revive(f.target)) })); break; case FileOperation.CREATE: <ins> case FileOperation.COPY: </ins> this._onDidCreateFile.fire(Object.freeze({ files: files.map(f => URI.revive(f.target)) })); break; default:", "commid": "vscode_pr_144329"}], "negative_passages": []}
{"query_id": "q-en-vscode-7c83c36523a0597d3d39ddbada578e546e9260f8402984a2a9c40aef2b9b563e", "query": "Issue Type: <bBug</bmicrosoft/vscode-extension-samples the helloworld-sample folder , build, verift that its contributed \"Hello World\" command activates the extension and shows a notification. the vscode version references in in two places to use 1.43 minimum. code to activate function in , for example: , run, use \"Hello World\" command to activate. breakpoint on return line above. a folder. Explorer button or context menu to create a new file. Confirm that the event fires and your breakpoint is hit. from breakpoint. Explorer context menu to copy/paste or use drag/drop with modifier to drip as a copy. :bug: The event callback does not run, despite the API doc stating: Issue also exists in 1.64.2 VS Code version: Code - Insiders 1.65.0-insider (, 2022-02-21T05:15:17.930Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --\ncc\nthe extension host's event is only emitting from 's event, but the explorer is using the 's , which doesn't seem to talk to the working copy service. What do you think the fix here should be? (cc\nthe bulk edit service is using the for its operations. If you look at , there is a bunch of usages for that service. The working copy file service is a wrapper around the file service that ensures the relevant events are emitted and can be participated on. I suspect that for the copy/paste operation or drag/drop we are possibly not using the bulk edit service but the file service directly? I suggest to make a pass over all explorer code and look for raw usages of to replace with bulk edit service. I think that would even enable undo/redo properly.\nMy bad, the real bug is that this block: doesn't handle events. cc\nPragmatic fix would probably to treat the same as .", "positive_passages": [{"docid": "doc-en-vscode-231a0bc571fafb7f2238ccbd46130352a9278465c29e331917fc497c32879e6f", "text": "case FileOperation.DELETE: return await this._fireWillEvent(this._onWillDeleteFile, { files: files.map(f => URI.revive(f.target)) }, timeout, token); case FileOperation.CREATE: <ins> case FileOperation.COPY: </ins> return await this._fireWillEvent(this._onWillCreateFile, { files: files.map(f => URI.revive(f.target)) }, timeout, token); } return undefined;", "commid": "vscode_pr_144329"}], "negative_passages": []}
{"query_id": "q-en-vscode-1836dfa7bb6b6ae89ddcf4de90013de7446b6e1d478e32ae4f1c555b357fed34", "query": "It seems something odd is appearing in our builds, specifically for our \"video\" svgs that has a link. The SVG doesn't contain anything crazy: Which throws the following error in the console: The strangest thing is in OSS everything looks fine but in the builds, the image is small and not centered. <img width=\"1089\" alt=\"CleanShot 2022-02-23 at 09 01 27 src=\"https://user-\"<img width=\"1024\" alt=\"CleanShot 2022-02-23 at 09 01 14 src=\"https://user-\"cc\nIs this new? cc any recent changes to CSP?\nI see this in Stable as well, so we likely never caught it\nThis is happening because the is being stripped out of this svg at some point during build.", "positive_passages": [{"docid": "doc-en-vscode-50d6d4f32e2069ad555e82698e1887ce1fde66d1931f67a2c6d5864ff4c8f53a", "text": "<del> <svg width=\"351\" height=\"225\" viewBox=\"0 0 351 225\" fill=\"none\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\"> </del> <ins> <svg viewBox=\"0 0 351 225\" fill=\"none\" xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\"> </ins> <g clip-path=\"url(#clip0_1103_9950)\"> <rect width=\"350.625\" height=\"225\" fill=\"#1E1E1E\" /> <rect width=\"350.625\" height=\"225\" fill=\"url(#paint0_radial_1103_9950)\" />", "commid": "vscode_pr_176143"}], "negative_passages": []}
{"query_id": "q-en-vscode-2c23da1b1f437c645fef2cd60880ff1da8dc136eedcbabff8ca3e86eb87af192", "query": "Just broke again:\nAdded a timeout to the initialize request which will tell me if that's the part that's timing out, but it's probably not. Any guess\nDuplicates", "positive_passages": [{"docid": "doc-en-vscode-88c803d04dca0adc97e43b50aacf424192d6411ba31d886d458081c17a2d7188", "text": "return new Promise((resolve, reject) => { debugAdapter.sendRequest('initialize', { adapterID: 'test' }, (result) => { resolve(result); <del> }); </del> <ins> }, 3000); </ins> }); }", "commid": "vscode_pr_149214"}], "negative_passages": []}
{"query_id": "q-en-vscode-9f9065c3e2676035d5fda9209406cbeac10568aee06b4ead89ec900984e33304", "query": "This video shows text in another cell being undone even though focus is in a different cell. Doesn't seem to matter whether \"Notebook: Undo Redo Per Cell\" is enabled or not ! This video shows that after a cell as been and text has been to it, Ctrl-Z can be used to remove it, but it cannot be redone. You've lost anything typed in that cell permanently. !\nMarking as important and a regression as I can't seem to figure out whether the \"per-cell\" setting is working the way it's intended or not.\nActually it appears that I may have disabled the \"per-cell\" setting a long time ago and didn't realize it. This may explain both behaviors above. I didn't realize that after changing that setting VS Code must be reloaded for the setting to take effect.\nSo removing \"important\" and \"regression\" for now. Let's just review what the behavior is that we want. It does seem problematic that if you have the setting off, that it doesn't seem possible to restore a cell you may have accidentally deleted. When the setting is on, Ctrl+z seems to work as expected.\nAfter internal discussion, re-marking as important. It's a data loss scenario if you have cell-level undo off.\nPossibly related to\nWith Cell Undo / Redo on (this is the default): Undoing and redoing text per cell works as expected Yes, with my testing Undoing and redoing add / remove of cell works as expected No, see bug 3 Undoing remove of cell via delete button No, see bug 4 With Cell Undo / Redo off: Undoing and redoing text per document works as expected No, see bug 1 Undoing and redoing add / remove of cell works as expected No, see bug 2 Undoing remove of cell via delete button No, see bug 4 Bugs: 1 Two cells in document. Changed from per cell to document mode. Typed in Cell A. Moved to the second cell, hit Undo. Instead of undoing the text, it blew away the second cell. Typing Redo did bring it back. I expected the typing in Cell A to be undone. Note, this bug I don't see after reloading the window. Might be that the setting change mid flow got the stack into a funny state? 2 Two cells in document. Shift-enter to run and add a new cell. Type in new cell. Ctrl-Z makes the typing go away and eventually the cell. When the cell is fully removed, redo will not restore it, so the typing is lost. Note, I can only replicate this will per cell turned off. With per cell turned on I first need to not be on the current cell to make it go away via Undo. But in that case I can make it go away with Undo and the text is restored with Redo. 3 However with per Cell on the cell + text does come back, but when it comes back it comes back without the per cell undo redo stack with per cell turned on: 4 When removing cell with the delete button, it cannot be restored with undo. This is true with either setting on. This is what I saw in my first pass. My personal ranking in importance would be like so 4 - Clear data loss. In both modes a cell is deleted and I can't get it back and the info in it. Easy to do and damaging. Effects both modes. 2 - Also clear data loss. I find this as a bit less important as I can only repro it with perCell off and I need to Ctrl-Z through the cell to get to the cell loss case so I've already removed what I typed in to the cell to get here. 3 () - Data loss here, but the data loss is not the actual code just the undo redo stack. So I'd vote for less important. 1 - I only reproed this when changing the perCell setting without a reload so an issue, but lesser importance.\nSome related issues:\nNote I'm going to use this issue specifically to resolve the issue where with perCell mode turned off you cannot restore a cell that was deleted with undo. The only specific scenarios in this fix are as follows: a notebook document a new cell (type something in it if you want) the cell using the delete button in the toolbar +Z (Run Undo) from a previous cell in the file the cell would not be restored, now it will be Scenario 2: the last cell in a notebook document shift-enter to run the cell and create a new cell some word in the new cell using Undo in that cell, it should walk back the words typed and eventually delete the cell start pressing Redo, it should restore the cell to the document then restore the words typed the cell would not be restored.\nthanks for the detailed investigation, they are insightful! For bug 1, you are correct that flipping the setting messed up with the undo/redo state. We register based on the setting which is not updated when we flip the setting. We might want to dispose it and register a new one when the setting changes. For bug 2, with your fix in, I can't reproduce it with the per cell setting off. Not sure if it's similar to bug 1. For bug 3, your comment is accurate. It's like a document and we don't persist them usually when a resource is gone. I wonder if we should fetch and \"save\" the undo/redo stack for the cell on the cell deletion element in the undo stack.\nReopening to cover the issues with flipping the setting. I'll close after that fix and will cover the bigger issue on persisting undo / redo per cell after delete.\n/verified? Still not sure this is working. Is per cell undo supposed to allow undo to affect other cells? Repro: to per cell undo in first cell in second cell +Z Expected it to only affect the current cell with focus. Actually it removes the typing in the first cell.\nOtherwise seems to behave more like I'd expect.", "positive_passages": [{"docid": "doc-en-vscode-3380db85ce5a7d026e2644c7f9fe12de4a3a003d3bfee2d4283578b638fc230e", "text": "super.dispose(); dispose(this._editorListeners); <del> this._undoRedoService.removeElements(this.uri); </del> <ins> // Only remove the undo redo stack if we map this cell uri to itself // If we are not in perCell mode, it will map to the full NotebookDocument and // we don't want to remove that entire document undo / redo stack when a cell is deleted if (this._undoRedoService.getUriComparisonKey(this.uri) === this.uri.toString()) { this._undoRedoService.removeElements(this.uri); } </ins> if (this._textModelRef) { this._textModelRef.dispose();", "commid": "vscode_pr_145335"}], "negative_passages": []}
{"query_id": "q-en-vscode-6caa0a8d7e73b07f06d6268a756e3d9de5b424453f93b7d9660ea3a7e3122655", "query": "Repro: in a terminal and select something ! We should hit ctrl+c beforehand () which should work properly on all shells\nWe should also do this when is clicked in the decoration's context menu\nI attempted this in but it was more complicated than I originally anticipated. Moving to backlog.", "positive_passages": [{"docid": "doc-en-vscode-33ede6b488c4e6c44de76200e14d59a3c9722b3585caaa1eb000fcc99083f549", "text": "readonly executingCommandObject: ITerminalCommand | undefined; /** The current cwd at the cursor's position. */ readonly cwd: string | undefined; <ins> /** * Whether a command is currently being input. If the a command is current not being input or * the state cannot reliably be detected the fallback of undefined will be used. */ readonly hasInput: boolean | undefined; </ins> readonly onCommandStarted: Event<ITerminalCommand>; readonly onCommandFinished: Event<ITerminalCommand>; readonly onCommandInvalidated: Event<ITerminalCommand[]>;", "commid": "vscode_pr_160992"}], "negative_passages": []}
{"query_id": "q-en-vscode-6caa0a8d7e73b07f06d6268a756e3d9de5b424453f93b7d9660ea3a7e3122655", "query": "Repro: in a terminal and select something ! We should hit ctrl+c beforehand () which should work properly on all shells\nWe should also do this when is clicked in the decoration's context menu\nI attempted this in but it was more complicated than I originally anticipated. Moving to backlog.", "positive_passages": [{"docid": "doc-en-vscode-f1341c7e72f8693510070c9e35966c60f0e71e7a36c481897126d1098f4c8e40", "text": "return undefined; } get cwd(): string | undefined { return this._cwd; } <ins> private get _isInputting(): boolean { return !!(this._currentCommand.commandStartMarker && !this._currentCommand.commandExecutedMarker); } get hasInput(): boolean | undefined { if (!this._isInputting || !this._currentCommand?.commandStartMarker) { return undefined; } if (this._terminal.buffer.active.baseY + this._terminal.buffer.active.cursorY === this._currentCommand.commandStartMarker?.line) { const line = this._terminal.buffer.active.getLine(this._terminal.buffer.active.cursorY)?.translateToString(true, this._currentCommand.commandStartX); if (line === undefined) { return undefined; } return line.length > 0; } return true; } </ins> private readonly _onCommandStarted = new Emitter<ITerminalCommand>(); readonly onCommandStarted = this._onCommandStarted.event;", "commid": "vscode_pr_160992"}], "negative_passages": []}
{"query_id": "q-en-vscode-6caa0a8d7e73b07f06d6268a756e3d9de5b424453f93b7d9660ea3a7e3122655", "query": "Repro: in a terminal and select something ! We should hit ctrl+c beforehand () which should work properly on all shells\nWe should also do this when is clicked in the decoration's context menu\nI attempted this in but it was more complicated than I originally anticipated. Moving to backlog.", "positive_passages": [{"docid": "doc-en-vscode-6ceb9c859c0a46f86bc7ef72d0c9468dff7fa2611479fbfcaefa19fe2bdd1842", "text": "} this._currentCommand.commandStartX = this._terminal.buffer.active.cursorX; this._currentCommand.commandStartMarker = options?.marker || this._terminal.registerMarker(0); <ins> // Clear executed as it must happen after command start this._currentCommand.commandExecutedMarker?.dispose(); this._currentCommand.commandExecutedMarker = undefined; this._currentCommand.commandExecutedX = undefined; for (const m of this._commandMarkers) { m.dispose(); } this._commandMarkers.length = 0; </ins> this._onCommandStarted.fire({ marker: options?.marker || this._currentCommand.commandStartMarker, markProperties: options?.markProperties } as ITerminalCommand); this._logService.debug('CommandDetectionCapability#handleCommandStart', this._currentCommand.commandStartX, this._currentCommand.commandStartMarker?.line); }", "commid": "vscode_pr_160992"}], "negative_passages": []}
{"query_id": "q-en-vscode-6caa0a8d7e73b07f06d6268a756e3d9de5b424453f93b7d9660ea3a7e3122655", "query": "Repro: in a terminal and select something ! We should hit ctrl+c beforehand () which should work properly on all shells\nWe should also do this when is clicked in the decoration's context menu\nI attempted this in but it was more complicated than I originally anticipated. Moving to backlog.", "positive_passages": [{"docid": "doc-en-vscode-439269ddac3cea3b10b9457ca7b4eb107c61eac4cb82a1352c3d8c5ef95c694a", "text": "import { showWithPinnedItems } from 'vs/platform/quickinput/browser/quickPickPin'; import { IStorageService } from 'vs/platform/storage/common/storage'; import { IContextKey } from 'vs/platform/contextkey/common/contextkey'; <ins> import { timeout } from 'vs/base/common/async'; </ins> export async function showRunRecentQuickPick( accessor: ServicesAccessor,", "commid": "vscode_pr_160992"}], "negative_passages": []}
{"query_id": "q-en-vscode-6caa0a8d7e73b07f06d6268a756e3d9de5b424453f93b7d9660ea3a7e3122655", "query": "Repro: in a terminal and select something ! We should hit ctrl+c beforehand () which should work properly on all shells\nWe should also do this when is clicked in the decoration's context menu\nI attempted this in but it was more complicated than I originally anticipated. Moving to backlog.", "positive_passages": [{"docid": "doc-en-vscode-7842f3f97d5cd8bd5598c7a8d7fb07980fcbcbd5f1733c806bb8bc02cd437171", "text": "} else { // command text = result.rawLabel; } <del> instance.sendText(text, !quickPick.keyMods.alt, true); </del> quickPick.hide(); <ins> runCommand(instance, text, !quickPick.keyMods.alt); </ins> if (quickPick.keyMods.alt) { instance.focus(); }", "commid": "vscode_pr_160992"}], "negative_passages": []}
{"query_id": "q-en-vscode-6caa0a8d7e73b07f06d6268a756e3d9de5b424453f93b7d9660ea3a7e3122655", "query": "Repro: in a terminal and select something ! We should hit ctrl+c beforehand () which should work properly on all shells\nWe should also do this when is clicked in the decoration's context menu\nI attempted this in but it was more complicated than I originally anticipated. Moving to backlog.", "positive_passages": [{"docid": "doc-en-vscode-198401ea0305579bbf77397a24263f4668459e73a6178ddca3936fa8980513e7", "text": "}); } <ins> async function runCommand(instance: ITerminalInstance, commandLine: string, addNewLine: boolean): Promise<void> { // Determine whether to send ETX (ctrl+c) before running the command. This should always // happen unless command detection can reliably say that a command is being entered and // there is no content in the prompt if (instance.capabilities.get(TerminalCapability.CommandDetection)?.hasInput !== false) { await instance.sendText('x03', false); // Wait a little before running the command to avoid the sequences being echoed while the ^C // is being evaluated await timeout(100); } // Use bracketed paste mode only when not running the command await instance.sendText(commandLine, addNewLine, !addNewLine); } </ins> class TerminalOutputProvider implements ITextModelContentProvider { static scheme = 'TERMINAL_OUTPUT';", "commid": "vscode_pr_160992"}], "negative_passages": []}
{"query_id": "q-en-vscode-42db0d76263239affccd24e6c9d9efea58be9033d629675f1cad9be8e05e7fcf", "query": "Open following url Install dialog is shown asking user to install and open extension <img width=\"275\" alt=\"image\" src=\"https://user-\"- After clicking on install, following prompt is shown <img width=\"454\" alt=\"image\" src=\"https://user-\"Second prompt seems to be unnecessary. It is expected to open the URL after installing", "positive_passages": [{"docid": "doc-en-vscode-a9ad458c3b316c695f2c46822f945e09d71e3cd0f36f06c72d2f28dea162d7a0", "text": "import { IWorkbenchExtensionEnablementService, EnablementState } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; import { areSameExtensions } from 'vs/platform/extensionManagement/common/extensionManagementUtil'; import { createDecorator, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; <del> import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; </del> <ins> import { INotificationService } from 'vs/platform/notification/common/notification'; </ins> import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import { IURLHandler, IURLService, IOpenURLOptions } from 'vs/platform/url/common/url'; import { IHostService } from 'vs/workbench/services/host/browser/host'; <del> import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; </del> <ins> import { IExtensionService, toExtensionDescription } from 'vs/workbench/services/extensions/common/extensions'; </ins> import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions'; import { registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { Registry } from 'vs/platform/registry/common/platform';", "commid": "vscode_pr_145035"}], "negative_passages": []}
{"query_id": "q-en-vscode-42db0d76263239affccd24e6c9d9efea58be9033d629675f1cad9be8e05e7fcf", "query": "Open following url Install dialog is shown asking user to install and open extension <img width=\"275\" alt=\"image\" src=\"https://user-\"- After clicking on install, following prompt is shown <img width=\"454\" alt=\"image\" src=\"https://user-\"Second prompt seems to be unnecessary. It is expected to open the URL after installing", "positive_passages": [{"docid": "doc-en-vscode-f848a3387d5c531364032c40b56b0184f2b53d9c3f00a31ab069656459b63f7c", "text": "const extension = await this.extensionService.getExtension(extensionId); if (!extension) { <del> await this.handleUnhandledURL(uri, { id: extensionId }); </del> <ins> await this.handleUnhandledURL(uri, { id: extensionId }, options); </ins> return true; }", "commid": "vscode_pr_145035"}], "negative_passages": []}
{"query_id": "q-en-vscode-42db0d76263239affccd24e6c9d9efea58be9033d629675f1cad9be8e05e7fcf", "query": "Open following url Install dialog is shown asking user to install and open extension <img width=\"275\" alt=\"image\" src=\"https://user-\"- After clicking on install, following prompt is shown <img width=\"454\" alt=\"image\" src=\"https://user-\"Second prompt seems to be unnecessary. It is expected to open the URL after installing", "positive_passages": [{"docid": "doc-en-vscode-afd1860a76fb7da3982ec7be59b52b3c5020d9a6d9e22404d593cbba563185b3", "text": "return await handler.handleURL(uri, options); } <del> private async handleUnhandledURL(uri: URI, extensionIdentifier: IExtensionIdentifier): Promise<void> { </del> <ins> private async handleUnhandledURL(uri: URI, extensionIdentifier: IExtensionIdentifier, options?: IOpenURLOptions): Promise<void> { </ins> const installedExtensions = await this.extensionManagementService.getInstalled(); <del> const extension = installedExtensions.filter(e => areSameExtensions(e.identifier, extensionIdentifier))[0]; // Extension is installed if (extension) { const enabled = this.extensionEnablementService.isEnabled(extension); // Extension is not running. Reload the window to handle. if (enabled) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/activate_extension/start', { extensionId: extensionIdentifier.id }); const result = await this.dialogService.confirm({ message: localize('reloadAndHandle', \"Extension '{0}' is not loaded. Would you like to reload the window to load the extension and open the URL?\", extension.manifest.displayName || extension.manifest.name), detail: `${extension.manifest.displayName || extension.manifest.name} (${extensionIdentifier.id}) wants to open a URL:nn${uri.toString()}`, primaryButton: localize('reloadAndOpen', \"&&Reload Window and Open\"), type: 'question' }); if (!result.confirmed) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/activate_extension/cancel', { extensionId: extensionIdentifier.id }); return; } this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/activate_extension/accept', { extensionId: extensionIdentifier.id }); await this.reloadAndHandle(uri); } // Extension is disabled. Enable the extension and reload the window to handle. else if (this.extensionEnablementService.canChangeEnablement(extension)) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/enable_extension/start', { extensionId: extensionIdentifier.id }); const result = await this.dialogService.confirm({ message: localize('enableAndHandle', \"Extension '{0}' is disabled. Would you like to enable the extension and reload the window to open the URL?\", extension.manifest.displayName || extension.manifest.name), detail: `${extension.manifest.displayName || extension.manifest.name} (${extensionIdentifier.id}) wants to open a URL:nn${uri.toString()}`, primaryButton: localize('enableAndReload', \"&&Enable and Open\"), type: 'question' }); if (!result.confirmed) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/enable_extension/cancel', { extensionId: extensionIdentifier.id }); return; } this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/enable_extension/accept', { extensionId: extensionIdentifier.id }); await this.extensionEnablementService.setEnablement([extension], EnablementState.EnabledGlobally); await this.reloadAndHandle(uri); } } </del> <ins> let extension = installedExtensions.find(e => areSameExtensions(e.identifier, extensionIdentifier)); </ins> // Extension is not installed <del> else { </del> <ins> if (!extension) { </ins> let galleryExtension: IGalleryExtension | undefined; try {", "commid": "vscode_pr_145035"}], "negative_passages": []}
{"query_id": "q-en-vscode-42db0d76263239affccd24e6c9d9efea58be9033d629675f1cad9be8e05e7fcf", "query": "Open following url Install dialog is shown asking user to install and open extension <img width=\"275\" alt=\"image\" src=\"https://user-\"- After clicking on install, following prompt is shown <img width=\"454\" alt=\"image\" src=\"https://user-\"Second prompt seems to be unnecessary. It is expected to open the URL after installing", "positive_passages": [{"docid": "doc-en-vscode-fb784ac084752e03b867606d1eebc947ad68cae222bb772a6be084d0e3c2f2bb", "text": "// Install the Extension and reload the window to handle. const result = await this.dialogService.confirm({ <del> message: localize('installAndHandle', \"Extension '{0}' is not installed. Would you like to install the extension and reload the window to open this URL?\", galleryExtension.displayName || galleryExtension.name), </del> <ins> message: localize('installAndHandle', \"Extension '{0}' is not installed. Would you like to install the extension and open this URL?\", galleryExtension.displayName || galleryExtension.name), </ins> detail: `${galleryExtension.displayName || galleryExtension.name} (${extensionIdentifier.id}) wants to open a URL:nn${uri.toString()}`, <del> primaryButton: localize('install', \"&&Install\"), </del> <ins> primaryButton: localize('install and open', \"&&Install and Open\"), </ins> type: 'question' });", "commid": "vscode_pr_145035"}], "negative_passages": []}
{"query_id": "q-en-vscode-42db0d76263239affccd24e6c9d9efea58be9033d629675f1cad9be8e05e7fcf", "query": "Open following url Install dialog is shown asking user to install and open extension <img width=\"275\" alt=\"image\" src=\"https://user-\"- After clicking on install, following prompt is shown <img width=\"454\" alt=\"image\" src=\"https://user-\"Second prompt seems to be unnecessary. It is expected to open the URL after installing", "positive_passages": [{"docid": "doc-en-vscode-7c1103ca92d7cdfbf52d244fd3e0375beaf291c514ad6eefd05ea9c8c5769a68", "text": "this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/install_extension/accept', { extensionId: extensionIdentifier.id }); try { <del> await this.progressService.withProgress({ </del> <ins> extension = await this.progressService.withProgress({ </ins> location: ProgressLocation.Notification, title: localize('Installing', \"Installing Extension '{0}'...\", galleryExtension.displayName || galleryExtension.name) }, () => this.extensionManagementService.installFromGallery(galleryExtension!)); <del> this.notificationService.prompt( Severity.Info, localize('reload', \"Would you like to reload the window and open the URL '{0}'?\", uri.toString()), [{ label: localize('Reload', \"Reload Window and Open\"), run: async () => { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/install_extension/reload', { extensionId: extensionIdentifier.id }); await this.reloadAndHandle(uri); } }], { sticky: true } ); </del> } catch (error) { this.notificationService.error(error); <ins> return; } } // Extension is installed but not enabled if (!this.extensionEnablementService.isEnabled(extension)) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/enable_extension/start', { extensionId: extensionIdentifier.id }); const result = await this.dialogService.confirm({ message: localize('enableAndHandle', \"Extension '{0}' is disabled. Would you like to enable the extension and open the URL?\", extension.manifest.displayName || extension.manifest.name), detail: `${extension.manifest.displayName || extension.manifest.name} (${extensionIdentifier.id}) wants to open a URL:nn${uri.toString()}`, primaryButton: localize('enableAndReload', \"&&Enable and Open\"), type: 'question' }); if (!result.confirmed) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/enable_extension/cancel', { extensionId: extensionIdentifier.id }); return; </ins> } <ins> this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/enable_extension/accept', { extensionId: extensionIdentifier.id }); await this.extensionEnablementService.setEnablement([extension], EnablementState.EnabledGlobally); } if (this.extensionService.canAddExtension(toExtensionDescription(extension))) { await this.waitUntilExtensionIsAdded(extensionIdentifier); await this.handleURL(uri, { ...options, trusted: true }); } /* Extension cannot be added and require window reload */ else { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/activate_extension/start', { extensionId: extensionIdentifier.id }); const result = await this.dialogService.confirm({ message: localize('reloadAndHandle', \"Extension '{0}' is not loaded. Would you like to reload the window to load the extension and open the URL?\", extension.manifest.displayName || extension.manifest.name), detail: `${extension.manifest.displayName || extension.manifest.name} (${extensionIdentifier.id}) wants to open a URL:nn${uri.toString()}`, primaryButton: localize('reloadAndOpen', \"&&Reload Window and Open\"), type: 'question' }); if (!result.confirmed) { this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/activate_extension/cancel', { extensionId: extensionIdentifier.id }); return; } this.telemetryService.publicLog2<ExtensionUrlHandlerEvent, ExtensionUrlHandlerClassification>('uri_invoked/activate_extension/accept', { extensionId: extensionIdentifier.id }); this.storageService.store(URL_TO_HANDLE, JSON.stringify(uri.toJSON()), StorageScope.WORKSPACE, StorageTarget.MACHINE); await this.hostService.reload(); </ins> } } <del> private async reloadAndHandle(url: URI): Promise<void> { this.storageService.store(URL_TO_HANDLE, JSON.stringify(url.toJSON()), StorageScope.WORKSPACE, StorageTarget.MACHINE); await this.hostService.reload(); </del> <ins> private async waitUntilExtensionIsAdded(extensionId: IExtensionIdentifier): Promise<void> { if (!(await this.extensionService.getExtension(extensionId.id))) { await new Promise<void>((c, e) => { const disposable = this.extensionService.onDidChangeExtensions(async () => { try { if (await this.extensionService.getExtension(extensionId.id)) { disposable.dispose(); c(); } } catch (error) { e(error); } }); }); } </ins> } // forget about all uris buffered more than 5 minutes ago", "commid": "vscode_pr_145035"}], "negative_passages": []}
{"query_id": "q-en-vscode-b447de76605ddd7c5f9f1dfc77b4163eb872d873838eb61b525d4bcc51121332", "query": "System info: macOs, Zsh, shell integration on. to vscode folder and hit tab it autocompletes to Hit tab again to autocomplete the names, it instead creates a big space and adds again. !\nNot sure if we're tracking this one yet but I've seen it too in pwsh/Windows.\nWorks fine in pwsh.\nIt only occurs for me when shell integration is on. I've had to disable it in the meantime\nMaybe I didn't see it on Windows actually. Happens on zsh/mac when pasting followed by enter/left: <img width=\"418\" alt=\"Screen Shot 2022-03-17 at 10 57 44 am\" src=\"https://user-\"\nOh I bet I know what's causing this, we need to wrap \"invisible\" parts of the prompt in and\nSimpler repro: tab <img width=\"242\" alt=\"Screen Shot 2022-03-17 at 11 08 21 am\" src=\"https://user-\"l", "positive_passages": [{"docid": "doc-en-vscode-f0922bbcb898853f97114f80507b6f27c40037c23a99ccb4d740d8bfa7a5cddd", "text": "update_prompt() { PRIOR_PROMPT=\"$PS1\" IN_COMMAND_EXECUTION=\"\" <del> PS1=\"$(prompt_start)$PREFIX$PS1$(prompt_end)\" PS2=\"$(continuation_start)$PS2$(continuation_end)\" </del> <ins> PS1=\"[$(prompt_start)]$PREFIX$PS1[$(prompt_end)]\" PS2=\"[$(continuation_start)]$PS2[$(continuation_end)]\" </ins> } precmd() {", "commid": "vscode_pr_145339"}], "negative_passages": []}
{"query_id": "q-en-vscode-b447de76605ddd7c5f9f1dfc77b4163eb872d873838eb61b525d4bcc51121332", "query": "System info: macOs, Zsh, shell integration on. to vscode folder and hit tab it autocompletes to Hit tab again to autocomplete the names, it instead creates a big space and adds again. !\nNot sure if we're tracking this one yet but I've seen it too in pwsh/Windows.\nWorks fine in pwsh.\nIt only occurs for me when shell integration is on. I've had to disable it in the meantime\nMaybe I didn't see it on Windows actually. Happens on zsh/mac when pasting followed by enter/left: <img width=\"418\" alt=\"Screen Shot 2022-03-17 at 10 57 44 am\" src=\"https://user-\"\nOh I bet I know what's causing this, we need to wrap \"invisible\" parts of the prompt in and\nSimpler repro: tab <img width=\"242\" alt=\"Screen Shot 2022-03-17 at 11 08 21 am\" src=\"https://user-\"l", "positive_passages": [{"docid": "doc-en-vscode-c112476ad3659ad509e2f8c5a026dae5d78025c6a283a8d182c70838f8f13864", "text": "update_prompt() { PRIOR_PROMPT=\"$PS1\" IN_COMMAND_EXECUTION=\"\" <del> PS1=\"$(prompt_start)$PREFIX$PS1$(prompt_end)\" PS2=\"$(continuation_start)$PS2$(continuation_end)\" </del> <ins> PS1=\"%{$(prompt_start)%}$PREFIX$PS1%{$(prompt_end)%}\" PS2=\"%{$(continuation_start)%}$PS2%{$(continuation_end)%}\" </ins> } precmd() {", "commid": "vscode_pr_145339"}], "negative_passages": []}
{"query_id": "q-en-vscode-d009257ae05865f01ab5015522d5fdd097a226b9f5448df12c96c545c01cfd0a", "query": "The original issue comes from Comment from Looks like there is some problem with the editor focus when the test message view is peeked out?\nI found a way to view test results and work with tests. When the tests are executed, I need to press CTRL+m for tab key to move between elements, then tab until the close button and after that panel with buttons to go to previous and next failure results there will be a tree with test results. That's accessible with NVDA, I am sure it's also accessible with Orca. Thank you for help all!\nThanks for the issue! at the moment we reveal the failed position and then focus the editor. Instead is it preferable to focus within the peek view like the references peeks do?\nyeah, it would be better if you focus inside the peek automatically for accessibility reasons. If you want, you can also differentiate if the command is triggered via keybinding, if yes then move focus, otherwise do not. This is what the editor hover does. Though I think it might be a bit confusing in this case, so I suggest to just pass focus inside the peek.\nThank you for such an active feedback! I also think that it would be more convenient if the focus moves directly to the peek instead of moving it to the editor with the selected line that can be easily deleted by accedent. Thank you!\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nhow about some verification steps unless resurfaces?\nSteps in the original post should still be accurate. Opening test peek output (for a failed test) via should focus and screen-read the peek view, rather than staying in the editor.", "positive_passages": [{"docid": "doc-en-vscode-507408a32dea6902aecd318c2970f889f060039715006da4b03387e7eb208df6", "text": "this.show(dto.revealLocation.range, TestingOutputPeek.lastHeightInLines || hintMessagePeekHeight(message)); this.editor.revealPositionNearTop(dto.revealLocation.range.getStartPosition(), ScrollType.Smooth); <del> this.editor.focus(); </del> return this.showInPlace(dto); }", "commid": "vscode_pr_148815"}], "negative_passages": []}
{"query_id": "q-en-vscode-d009257ae05865f01ab5015522d5fdd097a226b9f5448df12c96c545c01cfd0a", "query": "The original issue comes from Comment from Looks like there is some problem with the editor focus when the test message view is peeked out?\nI found a way to view test results and work with tests. When the tests are executed, I need to press CTRL+m for tab key to move between elements, then tab until the close button and after that panel with buttons to go to previous and next failure results there will be a tree with test results. That's accessible with NVDA, I am sure it's also accessible with Orca. Thank you for help all!\nThanks for the issue! at the moment we reveal the failed position and then focus the editor. Instead is it preferable to focus within the peek view like the references peeks do?\nyeah, it would be better if you focus inside the peek automatically for accessibility reasons. If you want, you can also differentiate if the command is triggered via keybinding, if yes then move focus, otherwise do not. This is what the editor hover does. Though I think it might be a bit confusing in this case, so I suggest to just pass focus inside the peek.\nThank you for such an active feedback! I also think that it would be more convenient if the focus moves directly to the peek instead of moving it to the editor with the selected line that can be easily deleted by accedent. Thank you!\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nhow about some verification steps unless resurfaces?\nSteps in the original post should still be accurate. Opening test peek output (for a failed test) via should focus and screen-read the peek view, rather than staying in the editor.", "positive_passages": [{"docid": "doc-en-vscode-20727827b0916643b99291a50f36bd677cdf73f7915549f949ddfa054d007849", "text": "this.tree.setFocus([messageNode]); this.tree.setSelection([messageNode]); <ins> this.tree.domFocus(); </ins> })); this._register(this.tree.onDidOpen(async e => {", "commid": "vscode_pr_148815"}], "negative_passages": []}
{"query_id": "q-en-vscode-690b5f793cb158ebd4860c099dc54fe404e7ef922cc6e3f92c53439f469e5382", "query": "The fix for at only replaces the first instance of in the string, not all of them. I suspect the regex needs on the end. <img width=\"1028\" alt=\"Screenshot 2022-03-17 at 14 46 58\" src=\"https://user-\" FYI :)\nheh, I found that and was going to change it, but GitHub fell over. I can easily add the , but it's not clear to me where/how to write a test against this class (which is actually the part that I get stuck on any time I want to contribute something). I can't find any similar tests in this area to use as a template.\n/verified", "positive_passages": [{"docid": "doc-en-vscode-05a583908c04e5e0e1cdd58388c34547a7b1cb377d4209d488544be30a6fe6c1", "text": "} } <del> const lineBreakRe = /r?ns*/; </del> <ins> const lineBreakRe = /r?ns*/g; </ins> class TestMessageDecoration implements ITestDecoration { public static readonly inlineClassName = 'test-message-inline-content';", "commid": "vscode_pr_145415"}], "negative_passages": []}
{"query_id": "q-en-vscode-27e000a7b793d7a6612df0d13caae90af2df96559af99f0a2bb60ae2212e72ce", "query": "Steps to Reproduce: command a language Settings file is opened. Settings Editor with language filter shall be opened given that the editor supports it.", "positive_passages": [{"docid": "doc-en-vscode-a6683143a80e747c291b3881716eb3932f3bb984233b5d378ad4674bdc72690e", "text": "if (pick) { const languageId = this.languageService.getLanguageIdByLanguageName(pick.label); if (typeof languageId === 'string') { <del> return this.preferencesService.openUserSettings({ jsonEditor: true, revealSetting: { key: `[${languageId}]`, edit: true } }); </del> <ins> return this.preferencesService.openLanguageSpecificSettings(languageId); </ins> } } return undefined;", "commid": "vscode_pr_146163"}], "negative_passages": []}
{"query_id": "q-en-vscode-27e000a7b793d7a6612df0d13caae90af2df96559af99f0a2bb60ae2212e72ce", "query": "Steps to Reproduce: command a language Settings file is opened. Settings Editor with language filter shall be opened given that the editor supports it.", "positive_passages": [{"docid": "doc-en-vscode-6cab5b7456da05210f9e1cb65a3a77d435ca351e4d68de65cf897968f297729d", "text": "return this.open(this.userSettingsResource, options); } <ins> openLanguageSpecificSettings(languageId: string, options: IOpenSettingsOptions = {}): Promise<IEditorPane | undefined> { if (this.shouldOpenJsonByDefault()) { options.query = undefined; options.revealSetting = { key: `[${languageId}]`, edit: true }; } else { options.query = `@lang:${languageId}${options.query ? ` ${options.query}` : ''}`; } options.target = options.target ?? ConfigurationTarget.USER_LOCAL; return this.open(this.userSettingsResource, options); } </ins> private open(settingsResource: URI, options: IOpenSettingsOptions): Promise<IEditorPane | undefined> { options = { ...options,", "commid": "vscode_pr_146163"}], "negative_passages": []}
{"query_id": "q-en-vscode-27e000a7b793d7a6612df0d13caae90af2df96559af99f0a2bb60ae2212e72ce", "query": "Steps to Reproduce: command a language Settings file is opened. Settings Editor with language filter shall be opened given that the editor supports it.", "positive_passages": [{"docid": "doc-en-vscode-4e03aa6e168b55766504f49b771cc99726b81ba39f43b2806cdf868f00b76a24", "text": "openFolderSettings(options: IOpenSettingsOptions & { folderUri: IOpenSettingsOptions['folderUri'] }): Promise<IEditorPane | undefined>; openGlobalKeybindingSettings(textual: boolean, options?: IKeybindingsEditorOptions): Promise<void>; openDefaultKeybindingsFile(): Promise<IEditorPane | undefined>; <ins> openLanguageSpecificSettings(language: string, options?: IOpenSettingsOptions): Promise<IEditorPane | undefined>; </ins> getEditableSettingsURI(configurationTarget: ConfigurationTarget, resource?: URI): Promise<URI | null>; createSplitJsonEditorInput(configurationTarget: ConfigurationTarget, resource: URI): EditorInput;", "commid": "vscode_pr_146163"}], "negative_passages": []}
{"query_id": "q-en-vscode-c762cfeda913fee3590284fced772f67355268f4ee7e677742a14c91c592dd0f", "query": "Forgot to respond and got closed due to inactivity. - We don't necessarily need them to read each item, but at the minimum screen reader users need to know that these buttons exist. Even a small announcement along the lines of \"tree items actions available on tab\" would suffice. Repost of:\nDoes this issue occur when all extensions are disabled?: Yes/No VS Code Version: 1.63.2 OS Version: Win11 Steps to Reproduce: a debug session in VSCode on Narrator keyboard and navigate focus to the debug target ! Expected Result: Narrator should announce all context, including action items associated with the treeitem Actual Result: Narrator announces just the tree item text and associated action buttons\nI am not convinced this should be announced. As Rob already mentioned on that issue the user can just press tab and focus onto the toolbar. We do not do this in other places that the parent element mentions all the children element inside it. Or the element that is about to get navigated to next. Let's leave this open for now to see if there is some feedback from users regarding this. For now I suggest no action.\nNot announcing anything does violate accessibility standard guidelines as visually impaired users who rely on screen readers wouldn't know that there are buttons associated with each tree item. I am filing this issue on behalf of the project where our products are required to meet accessibility standards and this component has been flagged as an accessibility violation. I understand that the prioritization might differ, but I wanted to give some context behind the issue.\nAgreed that \"they could just hit tab and find them\" is neither valid to fulfil our accessibility needs nor is it something we can expect from users who rely on navigating without seeing. As a quick fix, is there a chance to add an aria label to elements like these that announces \"more functionality available\" to explain to people that hitting tab will get them there?\n- Instead of adding extra announcements, we could also change the type of the component to be a tree grid/tree grid item. Screen reader users should expect more content on tab if they are on a tree grid item. Any thoughts on this solution?\nthanks for your creative suggestion, but a is something that is like a table and might not fit here. Check out the example here does it make sense that VS Code trees start using a role because each element might have extra content inside. How do Screen Readers treat vs ?\nThe suggestion came from the Edge Accessibility team. The core idea is that the existence of interactive buttons/content should be inherent based on the role of the element which is true for a tree grid item but not a tree item. As for screen reader behavior, treegrids are announced like tables, but they also state item position and level similar to a tree item. For instance, when you enter the grid, it will say: \"Entering table, 5x2... etc {contents of the row} expanded 1 of 3 level 1\" From this, the user will understand that there are additional cells with content to the right (maybe just one extra cell containing the toolbar with buttons) and also that they are in a tree structure.\nThanks for clarifying. Also are you suggesting that all trees in vscode have the role? Since every tree could have additional actions inside. What's the downside of using the role? Let's see what thinks when she finds time to reply. She is the author of Orca screen reader.\ntl;dr I think Tree Grid might be appropriate here. Long form: I definitely wouldn't expect interactive elements inside a normal tree view item. The two interaction models I've seen on those are: a) Put these items in the context menu. b) Have the user press Enter on the item to enter into a secondary layer where one would then tab through interactive elements. I first saw this in the old FireBug developer tools extension for Firefox, and later, while I was working at Mozilla, we also took this approach in the built-in developer tools in the HTML tree inspector. A tool bar with buttons etc. inside a tree item is certainly not Windows-Standard, and Windows standard is what most ARIA specs and authoring guidelines primarily derive from. Tree grids come more from the Linux side, where this is at least I saw them first in GNOME Nautilus. So yeah, I would lean towards a tree grid model where one would right arrow into the buttons for an item, if available, or tab to the toolbar, etc. We'd have to play with the aria-readonly property on this tree table, since some screen readers sometimes think they're editable when they're actually not, or vice versa.\nthanks for chiming in, I really appreciate your expertise. In VS Code it is pressing to get into the toolbar that is inside the tree element. Some follow up questions for everybody on this thread so we decide how to proceed further: about the Breakpoints view? This has the role and also has interactive elements inside each ? there some unintended consequences of going with the instead of the in all our trees? Or should we use the only if there are interactive elements inside? Example: Explorer does not have interactive elements, but Search does. We need to have a consistent experience across VS Code, thus these questions. fyi\nis a good question. I'll consult with our Accessibility team, but my initial thoughts are that we would need to change the role from a listitem. I'm not entirely sure if the best fit is a tree grid element or another role. wouldn't change all trees to treegrids as each role has its own set of implications and ignoring that would confuse screen reader users. If all these trees are derived from the same base class, I would add a constructor argument to differentiate treegrids and trees.\nLooping back for the first question - I believe a grid/grid cell role would be best for that kind of component.\nLet's assign to May as I would like to experiment with these changes at the start of a milestone\nI have changed the role for the whole CALLSTACK to be a for this use case and for each item to be a . So now as you say users should expect more content when they press tab. If users get delighted by this change I would be open to do this in more views.\nHey - I appreciate the fix! Unfortunately, the component that we're using in our extension is the . Would it be possible to port the same fix over to this component considering this is the actual component our accessibility team is flagging up?\nevery tree item has an field which your extension can use to manipulate the role or the label of each tree property. I suggest you try using that. For example you could try different roles, or to make the label more verbose as Christian Heilmann suggested here Allowing extensions to change the role of the whole custom tree is currently not possible, and if that is what you would need then I would have to discuss with Alex Ross who is currently on vacation and this would require API changes.", "positive_passages": [{"docid": "doc-en-vscode-ea2ddf4cb2c188789da1d5b19ee8a6c6af4e6713fd3aa0d0c854fdc9af6dfe7a", "text": "return localize({ comment: ['Debug is a noun in this context, not a verb.'], key: 'callStackAriaLabel' }, \"Debug Call Stack\"); } <ins> getWidgetRole(): string { // Use treegrid as a role since each element can have additional actions inside #146210 return 'treegrid'; } getRole(_element: CallStackItem): string | undefined { return 'row'; } </ins> getAriaLabel(element: CallStackItem): string { if (element instanceof Thread) { return localize({ key: 'threadAriaLabel', comment: ['Placeholders stand for the thread name and the thread state.For example \"Thread 1\" and \"Stopped'] }, \"Thread {0} {1}\", element.name, element.stateLabel);", "commid": "vscode_pr_148800"}], "negative_passages": []}
{"query_id": "q-en-vscode-19350a4955672e97c53887f5ff72423265704fbd2a35131cf3205a00ba0a6312", "query": "Hi ! I am running into an issue issue when using vscode 1.66 : when running pymc models there is a progress bar output which was working fine before the update and now the progress bar simply prints down :( See pic below ! This is how it prints in Jupyter notebooks (anaconda) and it was looking so in vscode 1.65.2 ! Here is the info about my session\nUpdate It actually works when I am not looking ie, I am not in that specific cell of the notebook \u00af()/\u00af !\nHere is a reproducible example: Code: Output: !\nI'm having a similar issue using enlighten progressbar. This likely started after a recent vscode update. A new progressbar is printed everytime it updates/redraws. I'm guessing this is the same issue. (This works/prints fine when run using jupyter-notebook on a web browser) !\nThank you for working so fast on this one! Looking forward for the next update/release !\nI couldn't verify this fix, using : !\nthanks, it's not being picked to the release branch yet.\nWorks for me too. !", "positive_passages": [{"docid": "doc-en-vscode-93bcff459065db5c31e92bc7de64c7dcc9d786c8fc8b596599b2e1518c1f668b", "text": "dispose(): void; } <ins> function clearContainer(container: HTMLElement) { while (container.firstChild) { container.removeChild(container.firstChild); } } </ins> function renderImage(outputInfo: OutputItem, element: HTMLElement): IDisposable {", "commid": "vscode_pr_146751"}], "negative_passages": []}
{"query_id": "q-en-vscode-19350a4955672e97c53887f5ff72423265704fbd2a35131cf3205a00ba0a6312", "query": "Hi ! I am running into an issue issue when using vscode 1.66 : when running pymc models there is a progress bar output which was working fine before the update and now the progress bar simply prints down :( See pic below ! This is how it prints in Jupyter notebooks (anaconda) and it was looking so in vscode 1.65.2 ! Here is the info about my session\nUpdate It actually works when I am not looking ie, I am not in that specific cell of the notebook \u00af()/\u00af !\nHere is a reproducible example: Code: Output: !\nI'm having a similar issue using enlighten progressbar. This likely started after a recent vscode update. A new progressbar is printed everytime it updates/redraws. I'm guessing this is the same issue. (This works/prints fine when run using jupyter-notebook on a web browser) !\nThank you for working so fast on this one! Looking forward for the next update/release !\nI couldn't verify this fix, using : !\nthanks, it's not being picked to the release branch yet.\nWorks for me too. !", "positive_passages": [{"docid": "doc-en-vscode-19ef89ae16b533395e9c63712662f4af2a58fe4ee613f8e9d6bbe07bbe5072ee", "text": "}; function renderHTML(outputInfo: OutputItem, container: HTMLElement): void { <ins> clearContainer(container); </ins> const htmlContent = outputInfo.text(); const element = document.createElement('div'); const trustedHtml = ttPolicy?.createHTML(htmlContent) ?? htmlContent;", "commid": "vscode_pr_146751"}], "negative_passages": []}
{"query_id": "q-en-vscode-19350a4955672e97c53887f5ff72423265704fbd2a35131cf3205a00ba0a6312", "query": "Hi ! I am running into an issue issue when using vscode 1.66 : when running pymc models there is a progress bar output which was working fine before the update and now the progress bar simply prints down :( See pic below ! This is how it prints in Jupyter notebooks (anaconda) and it was looking so in vscode 1.65.2 ! Here is the info about my session\nUpdate It actually works when I am not looking ie, I am not in that specific cell of the notebook \u00af()/\u00af !\nHere is a reproducible example: Code: Output: !\nI'm having a similar issue using enlighten progressbar. This likely started after a recent vscode update. A new progressbar is printed everytime it updates/redraws. I'm guessing this is the same issue. (This works/prints fine when run using jupyter-notebook on a web browser) !\nThank you for working so fast on this one! Looking forward for the next update/release !\nI couldn't verify this fix, using : !\nthanks, it's not being picked to the release branch yet.\nWorks for me too. !", "positive_passages": [{"docid": "doc-en-vscode-15734889420ff3645dd0854db443e788e149af48e6940dc0ac4564b12d4050d8", "text": "} function renderText(outputInfo: OutputItem, container: HTMLElement, ctx: RendererContext<void> & { readonly settings: { readonly lineLimit: number } }): void { <ins> clearContainer(container); </ins> const contentNode = document.createElement('div'); contentNode.classList.add('output-plaintext'); const text = outputInfo.text();", "commid": "vscode_pr_146751"}], "negative_passages": []}
{"query_id": "q-en-vscode-cde009137b0e09615d9f8c3522cdd2eb9025f65af4707e139ac320aa0b4216c4", "query": "System: Red Hat Enterprise Linux Workstation release 7.9 (Maipo) OS: Linux myhost 3.10.0-1160.36.2.el7.x8664 SMP Thu Jul 8 02:53:40 UTC 2021 x8664 x8664 x8664 GNU/Linux This began as an occasional annoyance and has escalated into a 100% reproducible annoyance. Using the latest snap install, during normal editing/debugging/etc. on local system. With increasing frequency, Ctrl-O/File-Open would completely freeze the UI with just a blinking cursor. Sometimes switching away and back would repaint part of the screen, increasingly not. Tried switching the output window to various things before attempting the file open (extension manager, main window, etc), but no output was observed before the freeze. Once the UI is frozen, only kill/killall seems to be able to get rid of it. Not sure if it means anything, but de-maximize and maximize still resize the window frame, although the contents aren't redrawn. Can't remember if that requires app cooperation or it that is a pure WM thing. Using snap installed code-insiders made no difference. Uninstalling snap versions and downloading 1.65.0 from the MS repo so far seems to have restored functionality (1.66.0 requires a glibc version unavailable for RHEL7). Haven't tried with (all) extensions disabled, but did disable everything I don't need constantly. One change in workflow recently seems suspiciously coordinated with the start of the issues - began using VS Code on another machine (nfs-mounted home folder, so shared settings/etc.) to attach to running containers (as container-specific user, to specific folder inside container), debug processes inside container, etc. Perhaps something got saved in the settings that is redirecting local File-Open to the remote-containers extension? Probably not, but the timing is mighty suspicious.\nInteresting. With 1.65.0 still running, snap installed the latest (1.66.0) again and ran it with: Ctrl-O still hung the 1.66.0 app. Apparently it isn't an extension.\nme is the same vscode is really disgusting\nyes, I ran into the same problem, vscode hangs when execute any open command, open folder or open a file\nSame for me on my Ubuntu 18.04 :-( Installed via tail of :\nAlso happening here, is there any known workaround at the moment to still open a folder? (Also seems to be related)\npoints to mismatched gtk library version loaded in the app process or others facing the issue, can you please follow the steps below and attach the generated profile\nThanks! Attached as requested above.\nIs the log cut off ? I don't see most the library loads that are required for startup.\nhmm, sorry, would be sufficient ? Because that is an only single output which I've got after execution. p.s. I am using managed PC and don't have permissions for :-(\nIn the past when I tried strace directly with snap packages and it would fail, hence I rely on the flag. Not sure if it works better now. No worries, I hope others hitting this issue might be able to provide the required trace. In the meantime, can you check if the issue exists with our debian package ?\nDebian package works well (with some strange behavior). Thanks for a temporary solution. Strange behavior -maybe because I've disconnected all my monitors, but Open Folder dialog opens in background, thus I have to bring it manually to the foreground (but it is better than hanging program anyway ;-))\nHere is the log I have with the instruction\nI am also having this problem with the latest update (though I never had the application hanging problem) on Ubuntu 18.04\nThanks for the log, it confirms the root issue. Snap bundle ships with a version of libgtk3 that gets loaded by the app for all gtk operations, can be seen with With Electron 14 there was a refactor in the file dialog implementation to support XDG portal specification and the gtk library that was trying to be loaded as part of this is not bundled within the snap and in which case will search the system library paths, if the library cannot be found then the old code path will be utilized that will use the alreaedy loaded gtk library in the process but incases where it is found from the system and gets loaded, if the version mismatches with the already loaded library in the process, it causes the above app freeze. This should be fixed in Electron to use the same calls as chromium ;l=79-82? to load the gtk library.\nso how should we solver it ?\nI've got the exact same problem. So, if this has been fixed in Electron 18 when can we expect an update to VSCode? Because I'm on 1.67.1 and the error still persists.\nThis issue is very annoying: ! Hope upgrade to electron18 as soon as possible\nThis issue started for me after installing . Not sure if that is helpful? After removing this package (and also running afterwards), the issue was gone.\nGot the newest version; but same error... Commit: Date: 2022-05-17T18:23:40.286Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 4.15.0-177-generic snap\nUpdate to Electron 18 is gonna take a bit longer, I will try to get the fix into Electron 17 as well. The issue is not yet addressed in our insiders and stable.\nLatest version (from 2 days ago) still has the same bug (Ubuntu 18.04). Does anyone have a workaround? Any way to install an older version? EDIT: Downloading the Linux 64 .deb from solved the issue for me.\nif you're just looking for a workaround, try the terminal command: or . It work's for me at least. But for a more solution maybe 's helps (I haven't tried it myself).\nSame issue. Ubuntu 18.04. Channel: latest/stable: 2022-05-18 (97). thank you for the workaround. Removed new snap version and installed 1.65.0. Solved for me.\nI was having a similar issue with vscode 1.67.2, non-snap on Ubuntu 20.04. After I noticed the issue I tried an apt upgrade, which didn't fix it. Downgrading to 1.65.2 fixed it for me. I am using i3 for window management.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification Steps: Install Ubuntu 18.04, images available from Install gtk3 <= 3.22, Install stable vscode from snap, Launch code and open the file explorer Verify application freezes Install insiders from snap, Launch code-insiders and open the file explorer Verify file explorer launches and application does not hang\ncan you help in verifying this since you have Ubuntu 18.04?\nHey , I can confirm that I get a dialog with the same setup and . Thanks! p.s. nevertheless, the strange behavior of dialog appearing in background remains the same as for previous solution using - but that is fine for now.", "positive_passages": [{"docid": "doc-en-vscode-6d25116e3c70fb724933a6d714591b394d6b9bdf340a1b59029df6542d36865f", "text": "disturl \"https://electronjs.org/headers\" <del> target \"17.4.6\" </del> <ins> target \"17.4.7\" </ins> runtime \"electron\" build_from_source \"true\"", "commid": "vscode_pr_151307"}], "negative_passages": []}
{"query_id": "q-en-vscode-cde009137b0e09615d9f8c3522cdd2eb9025f65af4707e139ac320aa0b4216c4", "query": "System: Red Hat Enterprise Linux Workstation release 7.9 (Maipo) OS: Linux myhost 3.10.0-1160.36.2.el7.x8664 SMP Thu Jul 8 02:53:40 UTC 2021 x8664 x8664 x8664 GNU/Linux This began as an occasional annoyance and has escalated into a 100% reproducible annoyance. Using the latest snap install, during normal editing/debugging/etc. on local system. With increasing frequency, Ctrl-O/File-Open would completely freeze the UI with just a blinking cursor. Sometimes switching away and back would repaint part of the screen, increasingly not. Tried switching the output window to various things before attempting the file open (extension manager, main window, etc), but no output was observed before the freeze. Once the UI is frozen, only kill/killall seems to be able to get rid of it. Not sure if it means anything, but de-maximize and maximize still resize the window frame, although the contents aren't redrawn. Can't remember if that requires app cooperation or it that is a pure WM thing. Using snap installed code-insiders made no difference. Uninstalling snap versions and downloading 1.65.0 from the MS repo so far seems to have restored functionality (1.66.0 requires a glibc version unavailable for RHEL7). Haven't tried with (all) extensions disabled, but did disable everything I don't need constantly. One change in workflow recently seems suspiciously coordinated with the start of the issues - began using VS Code on another machine (nfs-mounted home folder, so shared settings/etc.) to attach to running containers (as container-specific user, to specific folder inside container), debug processes inside container, etc. Perhaps something got saved in the settings that is redirecting local File-Open to the remote-containers extension? Probably not, but the timing is mighty suspicious.\nInteresting. With 1.65.0 still running, snap installed the latest (1.66.0) again and ran it with: Ctrl-O still hung the 1.66.0 app. Apparently it isn't an extension.\nme is the same vscode is really disgusting\nyes, I ran into the same problem, vscode hangs when execute any open command, open folder or open a file\nSame for me on my Ubuntu 18.04 :-( Installed via tail of :\nAlso happening here, is there any known workaround at the moment to still open a folder? (Also seems to be related)\npoints to mismatched gtk library version loaded in the app process or others facing the issue, can you please follow the steps below and attach the generated profile\nThanks! Attached as requested above.\nIs the log cut off ? I don't see most the library loads that are required for startup.\nhmm, sorry, would be sufficient ? Because that is an only single output which I've got after execution. p.s. I am using managed PC and don't have permissions for :-(\nIn the past when I tried strace directly with snap packages and it would fail, hence I rely on the flag. Not sure if it works better now. No worries, I hope others hitting this issue might be able to provide the required trace. In the meantime, can you check if the issue exists with our debian package ?\nDebian package works well (with some strange behavior). Thanks for a temporary solution. Strange behavior -maybe because I've disconnected all my monitors, but Open Folder dialog opens in background, thus I have to bring it manually to the foreground (but it is better than hanging program anyway ;-))\nHere is the log I have with the instruction\nI am also having this problem with the latest update (though I never had the application hanging problem) on Ubuntu 18.04\nThanks for the log, it confirms the root issue. Snap bundle ships with a version of libgtk3 that gets loaded by the app for all gtk operations, can be seen with With Electron 14 there was a refactor in the file dialog implementation to support XDG portal specification and the gtk library that was trying to be loaded as part of this is not bundled within the snap and in which case will search the system library paths, if the library cannot be found then the old code path will be utilized that will use the alreaedy loaded gtk library in the process but incases where it is found from the system and gets loaded, if the version mismatches with the already loaded library in the process, it causes the above app freeze. This should be fixed in Electron to use the same calls as chromium ;l=79-82? to load the gtk library.\nso how should we solver it ?\nI've got the exact same problem. So, if this has been fixed in Electron 18 when can we expect an update to VSCode? Because I'm on 1.67.1 and the error still persists.\nThis issue is very annoying: ! Hope upgrade to electron18 as soon as possible\nThis issue started for me after installing . Not sure if that is helpful? After removing this package (and also running afterwards), the issue was gone.\nGot the newest version; but same error... Commit: Date: 2022-05-17T18:23:40.286Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 4.15.0-177-generic snap\nUpdate to Electron 18 is gonna take a bit longer, I will try to get the fix into Electron 17 as well. The issue is not yet addressed in our insiders and stable.\nLatest version (from 2 days ago) still has the same bug (Ubuntu 18.04). Does anyone have a workaround? Any way to install an older version? EDIT: Downloading the Linux 64 .deb from solved the issue for me.\nif you're just looking for a workaround, try the terminal command: or . It work's for me at least. But for a more solution maybe 's helps (I haven't tried it myself).\nSame issue. Ubuntu 18.04. Channel: latest/stable: 2022-05-18 (97). thank you for the workaround. Removed new snap version and installed 1.65.0. Solved for me.\nI was having a similar issue with vscode 1.67.2, non-snap on Ubuntu 20.04. After I noticed the issue I tried an apt upgrade, which didn't fix it. Downgrading to 1.65.2 fixed it for me. I am using i3 for window management.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification Steps: Install Ubuntu 18.04, images available from Install gtk3 <= 3.22, Install stable vscode from snap, Launch code and open the file explorer Verify application freezes Install insiders from snap, Launch code-insiders and open the file explorer Verify file explorer launches and application does not hang\ncan you help in verifying this since you have Ubuntu 18.04?\nHey , I can confirm that I get a dialog with the same setup and . Thanks! p.s. nevertheless, the strange behavior of dialog appearing in background remains the same as for previous solution using - but that is fine for now.", "positive_passages": [{"docid": "doc-en-vscode-e7169fa967daabeb4802e7c0f2a0c09cae544cdfc4f452a11adddf014ce62385", "text": "\"git\": { \"name\": \"electron\", \"repositoryUrl\": \"https://github.com/electron/electron\", <del> \"commitHash\": \"3a1945bd6c62459a457bd8d0b922259234816e22\" </del> <ins> \"commitHash\": \"66dd03293be5c6c7a06e1517bb80100030973be6\" </ins> } }, \"isOnlyProductionDependency\": true, \"license\": \"MIT\", <del> \"version\": \"17.4.6\" </del> <ins> \"version\": \"17.4.7\" </ins> }, { \"component\": {", "commid": "vscode_pr_151307"}], "negative_passages": []}
{"query_id": "q-en-vscode-cde009137b0e09615d9f8c3522cdd2eb9025f65af4707e139ac320aa0b4216c4", "query": "System: Red Hat Enterprise Linux Workstation release 7.9 (Maipo) OS: Linux myhost 3.10.0-1160.36.2.el7.x8664 SMP Thu Jul 8 02:53:40 UTC 2021 x8664 x8664 x8664 GNU/Linux This began as an occasional annoyance and has escalated into a 100% reproducible annoyance. Using the latest snap install, during normal editing/debugging/etc. on local system. With increasing frequency, Ctrl-O/File-Open would completely freeze the UI with just a blinking cursor. Sometimes switching away and back would repaint part of the screen, increasingly not. Tried switching the output window to various things before attempting the file open (extension manager, main window, etc), but no output was observed before the freeze. Once the UI is frozen, only kill/killall seems to be able to get rid of it. Not sure if it means anything, but de-maximize and maximize still resize the window frame, although the contents aren't redrawn. Can't remember if that requires app cooperation or it that is a pure WM thing. Using snap installed code-insiders made no difference. Uninstalling snap versions and downloading 1.65.0 from the MS repo so far seems to have restored functionality (1.66.0 requires a glibc version unavailable for RHEL7). Haven't tried with (all) extensions disabled, but did disable everything I don't need constantly. One change in workflow recently seems suspiciously coordinated with the start of the issues - began using VS Code on another machine (nfs-mounted home folder, so shared settings/etc.) to attach to running containers (as container-specific user, to specific folder inside container), debug processes inside container, etc. Perhaps something got saved in the settings that is redirecting local File-Open to the remote-containers extension? Probably not, but the timing is mighty suspicious.\nInteresting. With 1.65.0 still running, snap installed the latest (1.66.0) again and ran it with: Ctrl-O still hung the 1.66.0 app. Apparently it isn't an extension.\nme is the same vscode is really disgusting\nyes, I ran into the same problem, vscode hangs when execute any open command, open folder or open a file\nSame for me on my Ubuntu 18.04 :-( Installed via tail of :\nAlso happening here, is there any known workaround at the moment to still open a folder? (Also seems to be related)\npoints to mismatched gtk library version loaded in the app process or others facing the issue, can you please follow the steps below and attach the generated profile\nThanks! Attached as requested above.\nIs the log cut off ? I don't see most the library loads that are required for startup.\nhmm, sorry, would be sufficient ? Because that is an only single output which I've got after execution. p.s. I am using managed PC and don't have permissions for :-(\nIn the past when I tried strace directly with snap packages and it would fail, hence I rely on the flag. Not sure if it works better now. No worries, I hope others hitting this issue might be able to provide the required trace. In the meantime, can you check if the issue exists with our debian package ?\nDebian package works well (with some strange behavior). Thanks for a temporary solution. Strange behavior -maybe because I've disconnected all my monitors, but Open Folder dialog opens in background, thus I have to bring it manually to the foreground (but it is better than hanging program anyway ;-))\nHere is the log I have with the instruction\nI am also having this problem with the latest update (though I never had the application hanging problem) on Ubuntu 18.04\nThanks for the log, it confirms the root issue. Snap bundle ships with a version of libgtk3 that gets loaded by the app for all gtk operations, can be seen with With Electron 14 there was a refactor in the file dialog implementation to support XDG portal specification and the gtk library that was trying to be loaded as part of this is not bundled within the snap and in which case will search the system library paths, if the library cannot be found then the old code path will be utilized that will use the alreaedy loaded gtk library in the process but incases where it is found from the system and gets loaded, if the version mismatches with the already loaded library in the process, it causes the above app freeze. This should be fixed in Electron to use the same calls as chromium ;l=79-82? to load the gtk library.\nso how should we solver it ?\nI've got the exact same problem. So, if this has been fixed in Electron 18 when can we expect an update to VSCode? Because I'm on 1.67.1 and the error still persists.\nThis issue is very annoying: ! Hope upgrade to electron18 as soon as possible\nThis issue started for me after installing . Not sure if that is helpful? After removing this package (and also running afterwards), the issue was gone.\nGot the newest version; but same error... Commit: Date: 2022-05-17T18:23:40.286Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 4.15.0-177-generic snap\nUpdate to Electron 18 is gonna take a bit longer, I will try to get the fix into Electron 17 as well. The issue is not yet addressed in our insiders and stable.\nLatest version (from 2 days ago) still has the same bug (Ubuntu 18.04). Does anyone have a workaround? Any way to install an older version? EDIT: Downloading the Linux 64 .deb from solved the issue for me.\nif you're just looking for a workaround, try the terminal command: or . It work's for me at least. But for a more solution maybe 's helps (I haven't tried it myself).\nSame issue. Ubuntu 18.04. Channel: latest/stable: 2022-05-18 (97). thank you for the workaround. Removed new snap version and installed 1.65.0. Solved for me.\nI was having a similar issue with vscode 1.67.2, non-snap on Ubuntu 20.04. After I noticed the issue I tried an apt upgrade, which didn't fix it. Downgrading to 1.65.2 fixed it for me. I am using i3 for window management.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification Steps: Install Ubuntu 18.04, images available from Install gtk3 <= 3.22, Install stable vscode from snap, Launch code and open the file explorer Verify application freezes Install insiders from snap, Launch code-insiders and open the file explorer Verify file explorer launches and application does not hang\ncan you help in verifying this since you have Ubuntu 18.04?\nHey , I can confirm that I get a dialog with the same setup and . Thanks! p.s. nevertheless, the strange behavior of dialog appearing in background remains the same as for previous solution using - but that is fine for now.", "positive_passages": [{"docid": "doc-en-vscode-fd5e157c3d1a7d80078e852fd51df21421547c149452fc2768d1cc4b58568b50", "text": "\"cssnano\": \"^4.1.11\", \"debounce\": \"^1.0.0\", \"deemon\": \"^1.4.0\", <del> \"electron\": \"17.4.6\", </del> <ins> \"electron\": \"17.4.7\", </ins> \"eslint\": \"8.7.0\", \"eslint-plugin-header\": \"3.1.1\", \"eslint-plugin-jsdoc\": \"^19.1.0\",", "commid": "vscode_pr_151307"}], "negative_passages": []}
{"query_id": "q-en-vscode-cde009137b0e09615d9f8c3522cdd2eb9025f65af4707e139ac320aa0b4216c4", "query": "System: Red Hat Enterprise Linux Workstation release 7.9 (Maipo) OS: Linux myhost 3.10.0-1160.36.2.el7.x8664 SMP Thu Jul 8 02:53:40 UTC 2021 x8664 x8664 x8664 GNU/Linux This began as an occasional annoyance and has escalated into a 100% reproducible annoyance. Using the latest snap install, during normal editing/debugging/etc. on local system. With increasing frequency, Ctrl-O/File-Open would completely freeze the UI with just a blinking cursor. Sometimes switching away and back would repaint part of the screen, increasingly not. Tried switching the output window to various things before attempting the file open (extension manager, main window, etc), but no output was observed before the freeze. Once the UI is frozen, only kill/killall seems to be able to get rid of it. Not sure if it means anything, but de-maximize and maximize still resize the window frame, although the contents aren't redrawn. Can't remember if that requires app cooperation or it that is a pure WM thing. Using snap installed code-insiders made no difference. Uninstalling snap versions and downloading 1.65.0 from the MS repo so far seems to have restored functionality (1.66.0 requires a glibc version unavailable for RHEL7). Haven't tried with (all) extensions disabled, but did disable everything I don't need constantly. One change in workflow recently seems suspiciously coordinated with the start of the issues - began using VS Code on another machine (nfs-mounted home folder, so shared settings/etc.) to attach to running containers (as container-specific user, to specific folder inside container), debug processes inside container, etc. Perhaps something got saved in the settings that is redirecting local File-Open to the remote-containers extension? Probably not, but the timing is mighty suspicious.\nInteresting. With 1.65.0 still running, snap installed the latest (1.66.0) again and ran it with: Ctrl-O still hung the 1.66.0 app. Apparently it isn't an extension.\nme is the same vscode is really disgusting\nyes, I ran into the same problem, vscode hangs when execute any open command, open folder or open a file\nSame for me on my Ubuntu 18.04 :-( Installed via tail of :\nAlso happening here, is there any known workaround at the moment to still open a folder? (Also seems to be related)\npoints to mismatched gtk library version loaded in the app process or others facing the issue, can you please follow the steps below and attach the generated profile\nThanks! Attached as requested above.\nIs the log cut off ? I don't see most the library loads that are required for startup.\nhmm, sorry, would be sufficient ? Because that is an only single output which I've got after execution. p.s. I am using managed PC and don't have permissions for :-(\nIn the past when I tried strace directly with snap packages and it would fail, hence I rely on the flag. Not sure if it works better now. No worries, I hope others hitting this issue might be able to provide the required trace. In the meantime, can you check if the issue exists with our debian package ?\nDebian package works well (with some strange behavior). Thanks for a temporary solution. Strange behavior -maybe because I've disconnected all my monitors, but Open Folder dialog opens in background, thus I have to bring it manually to the foreground (but it is better than hanging program anyway ;-))\nHere is the log I have with the instruction\nI am also having this problem with the latest update (though I never had the application hanging problem) on Ubuntu 18.04\nThanks for the log, it confirms the root issue. Snap bundle ships with a version of libgtk3 that gets loaded by the app for all gtk operations, can be seen with With Electron 14 there was a refactor in the file dialog implementation to support XDG portal specification and the gtk library that was trying to be loaded as part of this is not bundled within the snap and in which case will search the system library paths, if the library cannot be found then the old code path will be utilized that will use the alreaedy loaded gtk library in the process but incases where it is found from the system and gets loaded, if the version mismatches with the already loaded library in the process, it causes the above app freeze. This should be fixed in Electron to use the same calls as chromium ;l=79-82? to load the gtk library.\nso how should we solver it ?\nI've got the exact same problem. So, if this has been fixed in Electron 18 when can we expect an update to VSCode? Because I'm on 1.67.1 and the error still persists.\nThis issue is very annoying: ! Hope upgrade to electron18 as soon as possible\nThis issue started for me after installing . Not sure if that is helpful? After removing this package (and also running afterwards), the issue was gone.\nGot the newest version; but same error... Commit: Date: 2022-05-17T18:23:40.286Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 4.15.0-177-generic snap\nUpdate to Electron 18 is gonna take a bit longer, I will try to get the fix into Electron 17 as well. The issue is not yet addressed in our insiders and stable.\nLatest version (from 2 days ago) still has the same bug (Ubuntu 18.04). Does anyone have a workaround? Any way to install an older version? EDIT: Downloading the Linux 64 .deb from solved the issue for me.\nif you're just looking for a workaround, try the terminal command: or . It work's for me at least. But for a more solution maybe 's helps (I haven't tried it myself).\nSame issue. Ubuntu 18.04. Channel: latest/stable: 2022-05-18 (97). thank you for the workaround. Removed new snap version and installed 1.65.0. Solved for me.\nI was having a similar issue with vscode 1.67.2, non-snap on Ubuntu 20.04. After I noticed the issue I tried an apt upgrade, which didn't fix it. Downgrading to 1.65.2 fixed it for me. I am using i3 for window management.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification Steps: Install Ubuntu 18.04, images available from Install gtk3 <= 3.22, Install stable vscode from snap, Launch code and open the file explorer Verify application freezes Install insiders from snap, Launch code-insiders and open the file explorer Verify file explorer launches and application does not hang\ncan you help in verifying this since you have Ubuntu 18.04?\nHey , I can confirm that I get a dialog with the same setup and . Thanks! p.s. nevertheless, the strange behavior of dialog appearing in background remains the same as for previous solution using - but that is fine for now.", "positive_passages": [{"docid": "doc-en-vscode-95a98dcb9a1f81eb0946f8773d28b59c85c90583da8a4bbfebfc93ff07f4f4df", "text": "resolved \"https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.45.tgz#cf1144091d6683cbd45a231954a745f02fb24598\" integrity sha512-czF9eYVuOmlY/vxyMQz2rGlNSjZpxNQYBe1gmQv7al171qOIhgyO9k7D5AKlgeTCSPKk+LHhj5ZyIdmEub9oNg== <del> electron@17.4.6: version \"17.4.6\" resolved \"https://registry.yarnpkg.com/electron/-/electron-17.4.6.tgz#4837b3adb2636992a33da734a77794dd932fb05c\" integrity sha512-9aPjlyWoVxchD/iw5KcbQ7ZaC5ezxsObBrMbGjpdMmDL5dktI0EkT6x2l2CYPZCi4rQG/6qlPfTZJeVPIIwI2Q== </del> <ins> electron@17.4.7: version \"17.4.7\" resolved \"https://registry.yarnpkg.com/electron/-/electron-17.4.7.tgz#5ae9105f2ee28e6405c79c7101f0c956676da697\" integrity sha512-CMdUpd6oEwqbF7wcXwy9VNNXfTTbaeRg+zrGZciPzyzsEmJ9vzWcR1WpOxIQ4sIMjUyo1pFbvaD0VOgI2t4x3A== </ins> dependencies: \"@electron/get\" \"^1.13.0\" \"@types/node\" \"^14.6.2\"", "commid": "vscode_pr_151307"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b5fc75b29804529424fbb521708f13d785c0b8fb756f4503b0d4b6264ac8d55", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 (x64) OS Version: 10.0. Build (Window 10) Steps to Reproduce: VS Code (or use the shortcut ) the first miliseconds after opening a new instance of VS Code, a \"Window 7\"-like window frame layout appears, before the usual VS Code look shows up (see the attached GIF). The GIF below first shows the expected behavior, opening version 1.65.0, followed by the current behavior of version 1.66.0. ! The two executables were downloaded from: and\nRefs\nthat's the reason I went back to 1.65, frames are so annoying.\nHi just a small update: I've downloaded the latest VS Code Insiders and the problem now only appears when launching VS Code for the first time, but no longer when opening new windows from a running instance of it.\nThis issue persists in the new latest version release, .\nThe issue persists in today's release, .\nSince the related bug in the Electron repo has a label, and today's VSCode uses , I believe we will be experiencing this bug for months.\nThe upstream Electron issue is at The issue was introduced in Electron v14.0.0-beta.5 and the commit that introduced the issue is The PR fixes the issue where frameless resizable windows show Windows 7 frames during startup, but there's a larger issue that is still unresolved even with that PR. I also searched through the thousands of to see whether they had anything to do with the issue, but I didn't find anything relevant even after reverting several suspicious commits. Running with Electron v14.0.0-beta.5 or newer on Windows 10 reproduces the issue. The PR fixes the issue for frameless resizable windows by calling at an earlier stage of program initialization. Assume the window is frameless and resizable. Then, the program sets to earlier in , and the following occurs: is not run, meaning is not removed from the style set in Line 62. This style parameter is passed in to a call at . is not run. Instead, the block above is run, which adds a style to the style passed into the call. , because of these styles being passed in, after the window is shown, we get a single message, and no messages after. NC in this case refers to non-client area, which is the frame. DWM stands for desktop windows manager. After adding a long of 30 seconds to the call above, I was able to use Spy++ to log messages to that window and see the following: I have also attached full logs to the end of this comment. For frameless windows that cannot resize, even if we call earlier, because the program would pass in , for the and calls above, the style would not be in the styles sent to the calls. As a result, what I see in Spy++ is being toggled three times, and several calls that result in messages being emitted. Using Spy++, I confirmed that the calls have the flag set. I have searched the Chromium and Electron codebases for and (as well as ) to see why the frame might be rendering more often when is not passed in. However, I haven't found anything within the codebase itself. Searching Windows documentation, I found the following: causes to be sent. Reference: However, I'm not sure whether this could explain the difference in behaviour between resizable and non-resizable windows. can pass in or to send to the window, which is why I searched for those two constants within the codebase. Reference: Also, Chromium handles by returning at , which I assume causes the message to occur. Also, Electron calls at . I noticed that if I don't call there, the Windows 7 frame doesn't show up, but then the Electron window doesn't render with the proper style (see ). I also noticed that when the Windows 7 frame shows up, it has the style of whatever was passed into that specific call. For example, if I add to the call, then for a second I see a Windows 7 frame with applied. I also tried creating a minimal project in VS to reproduce the issue but wasn't successful. The frame that rendered seemed to have a Windows 10 style rather than a Windows 7 one. I also tried registering a listener in for the messages, and it did seem to get hit, though I couldn't do anything with it. There's also the mysterious , but I wasn't able to apply it to resolve the issue.\nThe PR that linked above (partially based on ) should resolve the issue for VS Code Insiders and hence close this issue, but there's still more I'd like to investigate, especially for frameless non-resizable windows. I some lines to log the hwnd and style passed into each relevant and call. One example of the styles that show up: There's also another window being created really early, but I don't think it influences the issue. Good scenario (meaning no frame showing) with set to and staying Bad scenario with set to then Bad scenario with set to and staying The call with style causes the Windows 7 frame to render, and its style corresponds to is actually the same style just with , once again showing how mysterious the constant is. While working on , I also noticed that changing the order of the calls seemed to fix the issue for frameless non-resizable windows. In particular, on the Electron side, in , if I first called to pretend that the window is resizable, and then called (where ) after the call around line 365, then the issue is resolved even for frameless non-resizable windows. However, this workaround delays the call to hundreds of lines later, and I wouldn't be surprised if it would cause a regression elsewhere. Just like in the log file of the good case of the previous comment, only shows up once, rather than three times. For completeness, here are the logs with the styles for this scenario, excluding the logs: In this case, the style never comes up! I also tried delaying the call and calling instead of , but that doesn't work because it fails to pass to the call as well as the first call, both of which need for the frame not to render: can be used to change the non-client (NC) rendering policy and hence result in a call. However, I did not find any references to within the Electron and Chromium codebases that were actually called when running my minimal repro.\nlets continue the investigation in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-6a748e482d7b184e8b2045d626d7da41df15a7a48ea52d6fc5ffe99ede0a87dd", "text": "disturl \"https://electronjs.org/headers\" <del> target \"19.0.11\" </del> <ins> target \"19.0.12\" </ins> runtime \"electron\" build_from_source \"true\"", "commid": "vscode_pr_158025"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b5fc75b29804529424fbb521708f13d785c0b8fb756f4503b0d4b6264ac8d55", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 (x64) OS Version: 10.0. Build (Window 10) Steps to Reproduce: VS Code (or use the shortcut ) the first miliseconds after opening a new instance of VS Code, a \"Window 7\"-like window frame layout appears, before the usual VS Code look shows up (see the attached GIF). The GIF below first shows the expected behavior, opening version 1.65.0, followed by the current behavior of version 1.66.0. ! The two executables were downloaded from: and\nRefs\nthat's the reason I went back to 1.65, frames are so annoying.\nHi just a small update: I've downloaded the latest VS Code Insiders and the problem now only appears when launching VS Code for the first time, but no longer when opening new windows from a running instance of it.\nThis issue persists in the new latest version release, .\nThe issue persists in today's release, .\nSince the related bug in the Electron repo has a label, and today's VSCode uses , I believe we will be experiencing this bug for months.\nThe upstream Electron issue is at The issue was introduced in Electron v14.0.0-beta.5 and the commit that introduced the issue is The PR fixes the issue where frameless resizable windows show Windows 7 frames during startup, but there's a larger issue that is still unresolved even with that PR. I also searched through the thousands of to see whether they had anything to do with the issue, but I didn't find anything relevant even after reverting several suspicious commits. Running with Electron v14.0.0-beta.5 or newer on Windows 10 reproduces the issue. The PR fixes the issue for frameless resizable windows by calling at an earlier stage of program initialization. Assume the window is frameless and resizable. Then, the program sets to earlier in , and the following occurs: is not run, meaning is not removed from the style set in Line 62. This style parameter is passed in to a call at . is not run. Instead, the block above is run, which adds a style to the style passed into the call. , because of these styles being passed in, after the window is shown, we get a single message, and no messages after. NC in this case refers to non-client area, which is the frame. DWM stands for desktop windows manager. After adding a long of 30 seconds to the call above, I was able to use Spy++ to log messages to that window and see the following: I have also attached full logs to the end of this comment. For frameless windows that cannot resize, even if we call earlier, because the program would pass in , for the and calls above, the style would not be in the styles sent to the calls. As a result, what I see in Spy++ is being toggled three times, and several calls that result in messages being emitted. Using Spy++, I confirmed that the calls have the flag set. I have searched the Chromium and Electron codebases for and (as well as ) to see why the frame might be rendering more often when is not passed in. However, I haven't found anything within the codebase itself. Searching Windows documentation, I found the following: causes to be sent. Reference: However, I'm not sure whether this could explain the difference in behaviour between resizable and non-resizable windows. can pass in or to send to the window, which is why I searched for those two constants within the codebase. Reference: Also, Chromium handles by returning at , which I assume causes the message to occur. Also, Electron calls at . I noticed that if I don't call there, the Windows 7 frame doesn't show up, but then the Electron window doesn't render with the proper style (see ). I also noticed that when the Windows 7 frame shows up, it has the style of whatever was passed into that specific call. For example, if I add to the call, then for a second I see a Windows 7 frame with applied. I also tried creating a minimal project in VS to reproduce the issue but wasn't successful. The frame that rendered seemed to have a Windows 10 style rather than a Windows 7 one. I also tried registering a listener in for the messages, and it did seem to get hit, though I couldn't do anything with it. There's also the mysterious , but I wasn't able to apply it to resolve the issue.\nThe PR that linked above (partially based on ) should resolve the issue for VS Code Insiders and hence close this issue, but there's still more I'd like to investigate, especially for frameless non-resizable windows. I some lines to log the hwnd and style passed into each relevant and call. One example of the styles that show up: There's also another window being created really early, but I don't think it influences the issue. Good scenario (meaning no frame showing) with set to and staying Bad scenario with set to then Bad scenario with set to and staying The call with style causes the Windows 7 frame to render, and its style corresponds to is actually the same style just with , once again showing how mysterious the constant is. While working on , I also noticed that changing the order of the calls seemed to fix the issue for frameless non-resizable windows. In particular, on the Electron side, in , if I first called to pretend that the window is resizable, and then called (where ) after the call around line 365, then the issue is resolved even for frameless non-resizable windows. However, this workaround delays the call to hundreds of lines later, and I wouldn't be surprised if it would cause a regression elsewhere. Just like in the log file of the good case of the previous comment, only shows up once, rather than three times. For completeness, here are the logs with the styles for this scenario, excluding the logs: In this case, the style never comes up! I also tried delaying the call and calling instead of , but that doesn't work because it fails to pass to the call as well as the first call, both of which need for the frame not to render: can be used to change the non-client (NC) rendering policy and hence result in a call. However, I did not find any references to within the Electron and Chromium codebases that were actually called when running my minimal repro.\nlets continue the investigation in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-744ebe4bf77b601b91d6c389b46887de3de2cbb5ab571106cf4553a914a3832f", "text": "\"git\": { \"name\": \"electron\", \"repositoryUrl\": \"https://github.com/electron/electron\", <del> \"commitHash\": \"a5cafd174d2027529d0b251e5b8e58da2b364e5b\" </del> <ins> \"commitHash\": \"b05ccd812e3bb3de5b1546a313e298961653e942\" </ins> } }, \"isOnlyProductionDependency\": true, \"license\": \"MIT\", <del> \"version\": \"19.0.11\" </del> <ins> \"version\": \"19.0.12\" </ins> }, { \"component\": {", "commid": "vscode_pr_158025"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b5fc75b29804529424fbb521708f13d785c0b8fb756f4503b0d4b6264ac8d55", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 (x64) OS Version: 10.0. Build (Window 10) Steps to Reproduce: VS Code (or use the shortcut ) the first miliseconds after opening a new instance of VS Code, a \"Window 7\"-like window frame layout appears, before the usual VS Code look shows up (see the attached GIF). The GIF below first shows the expected behavior, opening version 1.65.0, followed by the current behavior of version 1.66.0. ! The two executables were downloaded from: and\nRefs\nthat's the reason I went back to 1.65, frames are so annoying.\nHi just a small update: I've downloaded the latest VS Code Insiders and the problem now only appears when launching VS Code for the first time, but no longer when opening new windows from a running instance of it.\nThis issue persists in the new latest version release, .\nThe issue persists in today's release, .\nSince the related bug in the Electron repo has a label, and today's VSCode uses , I believe we will be experiencing this bug for months.\nThe upstream Electron issue is at The issue was introduced in Electron v14.0.0-beta.5 and the commit that introduced the issue is The PR fixes the issue where frameless resizable windows show Windows 7 frames during startup, but there's a larger issue that is still unresolved even with that PR. I also searched through the thousands of to see whether they had anything to do with the issue, but I didn't find anything relevant even after reverting several suspicious commits. Running with Electron v14.0.0-beta.5 or newer on Windows 10 reproduces the issue. The PR fixes the issue for frameless resizable windows by calling at an earlier stage of program initialization. Assume the window is frameless and resizable. Then, the program sets to earlier in , and the following occurs: is not run, meaning is not removed from the style set in Line 62. This style parameter is passed in to a call at . is not run. Instead, the block above is run, which adds a style to the style passed into the call. , because of these styles being passed in, after the window is shown, we get a single message, and no messages after. NC in this case refers to non-client area, which is the frame. DWM stands for desktop windows manager. After adding a long of 30 seconds to the call above, I was able to use Spy++ to log messages to that window and see the following: I have also attached full logs to the end of this comment. For frameless windows that cannot resize, even if we call earlier, because the program would pass in , for the and calls above, the style would not be in the styles sent to the calls. As a result, what I see in Spy++ is being toggled three times, and several calls that result in messages being emitted. Using Spy++, I confirmed that the calls have the flag set. I have searched the Chromium and Electron codebases for and (as well as ) to see why the frame might be rendering more often when is not passed in. However, I haven't found anything within the codebase itself. Searching Windows documentation, I found the following: causes to be sent. Reference: However, I'm not sure whether this could explain the difference in behaviour between resizable and non-resizable windows. can pass in or to send to the window, which is why I searched for those two constants within the codebase. Reference: Also, Chromium handles by returning at , which I assume causes the message to occur. Also, Electron calls at . I noticed that if I don't call there, the Windows 7 frame doesn't show up, but then the Electron window doesn't render with the proper style (see ). I also noticed that when the Windows 7 frame shows up, it has the style of whatever was passed into that specific call. For example, if I add to the call, then for a second I see a Windows 7 frame with applied. I also tried creating a minimal project in VS to reproduce the issue but wasn't successful. The frame that rendered seemed to have a Windows 10 style rather than a Windows 7 one. I also tried registering a listener in for the messages, and it did seem to get hit, though I couldn't do anything with it. There's also the mysterious , but I wasn't able to apply it to resolve the issue.\nThe PR that linked above (partially based on ) should resolve the issue for VS Code Insiders and hence close this issue, but there's still more I'd like to investigate, especially for frameless non-resizable windows. I some lines to log the hwnd and style passed into each relevant and call. One example of the styles that show up: There's also another window being created really early, but I don't think it influences the issue. Good scenario (meaning no frame showing) with set to and staying Bad scenario with set to then Bad scenario with set to and staying The call with style causes the Windows 7 frame to render, and its style corresponds to is actually the same style just with , once again showing how mysterious the constant is. While working on , I also noticed that changing the order of the calls seemed to fix the issue for frameless non-resizable windows. In particular, on the Electron side, in , if I first called to pretend that the window is resizable, and then called (where ) after the call around line 365, then the issue is resolved even for frameless non-resizable windows. However, this workaround delays the call to hundreds of lines later, and I wouldn't be surprised if it would cause a regression elsewhere. Just like in the log file of the good case of the previous comment, only shows up once, rather than three times. For completeness, here are the logs with the styles for this scenario, excluding the logs: In this case, the style never comes up! I also tried delaying the call and calling instead of , but that doesn't work because it fails to pass to the call as well as the first call, both of which need for the frame not to render: can be used to change the non-client (NC) rendering policy and hence result in a call. However, I did not find any references to within the Electron and Chromium codebases that were actually called when running my minimal repro.\nlets continue the investigation in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-92d76e3ccb4c3c5e4f1277d33dac138a018dd68799c7e178142d97c0830511a5", "text": "\"cssnano\": \"^4.1.11\", \"debounce\": \"^1.0.0\", \"deemon\": \"^1.4.0\", <del> \"electron\": \"19.0.11\", </del> <ins> \"electron\": \"19.0.12\", </ins> \"eslint\": \"8.7.0\", \"eslint-plugin-header\": \"3.1.1\", \"eslint-plugin-jsdoc\": \"^39.3.2\",", "commid": "vscode_pr_158025"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b5fc75b29804529424fbb521708f13d785c0b8fb756f4503b0d4b6264ac8d55", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 (x64) OS Version: 10.0. Build (Window 10) Steps to Reproduce: VS Code (or use the shortcut ) the first miliseconds after opening a new instance of VS Code, a \"Window 7\"-like window frame layout appears, before the usual VS Code look shows up (see the attached GIF). The GIF below first shows the expected behavior, opening version 1.65.0, followed by the current behavior of version 1.66.0. ! The two executables were downloaded from: and\nRefs\nthat's the reason I went back to 1.65, frames are so annoying.\nHi just a small update: I've downloaded the latest VS Code Insiders and the problem now only appears when launching VS Code for the first time, but no longer when opening new windows from a running instance of it.\nThis issue persists in the new latest version release, .\nThe issue persists in today's release, .\nSince the related bug in the Electron repo has a label, and today's VSCode uses , I believe we will be experiencing this bug for months.\nThe upstream Electron issue is at The issue was introduced in Electron v14.0.0-beta.5 and the commit that introduced the issue is The PR fixes the issue where frameless resizable windows show Windows 7 frames during startup, but there's a larger issue that is still unresolved even with that PR. I also searched through the thousands of to see whether they had anything to do with the issue, but I didn't find anything relevant even after reverting several suspicious commits. Running with Electron v14.0.0-beta.5 or newer on Windows 10 reproduces the issue. The PR fixes the issue for frameless resizable windows by calling at an earlier stage of program initialization. Assume the window is frameless and resizable. Then, the program sets to earlier in , and the following occurs: is not run, meaning is not removed from the style set in Line 62. This style parameter is passed in to a call at . is not run. Instead, the block above is run, which adds a style to the style passed into the call. , because of these styles being passed in, after the window is shown, we get a single message, and no messages after. NC in this case refers to non-client area, which is the frame. DWM stands for desktop windows manager. After adding a long of 30 seconds to the call above, I was able to use Spy++ to log messages to that window and see the following: I have also attached full logs to the end of this comment. For frameless windows that cannot resize, even if we call earlier, because the program would pass in , for the and calls above, the style would not be in the styles sent to the calls. As a result, what I see in Spy++ is being toggled three times, and several calls that result in messages being emitted. Using Spy++, I confirmed that the calls have the flag set. I have searched the Chromium and Electron codebases for and (as well as ) to see why the frame might be rendering more often when is not passed in. However, I haven't found anything within the codebase itself. Searching Windows documentation, I found the following: causes to be sent. Reference: However, I'm not sure whether this could explain the difference in behaviour between resizable and non-resizable windows. can pass in or to send to the window, which is why I searched for those two constants within the codebase. Reference: Also, Chromium handles by returning at , which I assume causes the message to occur. Also, Electron calls at . I noticed that if I don't call there, the Windows 7 frame doesn't show up, but then the Electron window doesn't render with the proper style (see ). I also noticed that when the Windows 7 frame shows up, it has the style of whatever was passed into that specific call. For example, if I add to the call, then for a second I see a Windows 7 frame with applied. I also tried creating a minimal project in VS to reproduce the issue but wasn't successful. The frame that rendered seemed to have a Windows 10 style rather than a Windows 7 one. I also tried registering a listener in for the messages, and it did seem to get hit, though I couldn't do anything with it. There's also the mysterious , but I wasn't able to apply it to resolve the issue.\nThe PR that linked above (partially based on ) should resolve the issue for VS Code Insiders and hence close this issue, but there's still more I'd like to investigate, especially for frameless non-resizable windows. I some lines to log the hwnd and style passed into each relevant and call. One example of the styles that show up: There's also another window being created really early, but I don't think it influences the issue. Good scenario (meaning no frame showing) with set to and staying Bad scenario with set to then Bad scenario with set to and staying The call with style causes the Windows 7 frame to render, and its style corresponds to is actually the same style just with , once again showing how mysterious the constant is. While working on , I also noticed that changing the order of the calls seemed to fix the issue for frameless non-resizable windows. In particular, on the Electron side, in , if I first called to pretend that the window is resizable, and then called (where ) after the call around line 365, then the issue is resolved even for frameless non-resizable windows. However, this workaround delays the call to hundreds of lines later, and I wouldn't be surprised if it would cause a regression elsewhere. Just like in the log file of the good case of the previous comment, only shows up once, rather than three times. For completeness, here are the logs with the styles for this scenario, excluding the logs: In this case, the style never comes up! I also tried delaying the call and calling instead of , but that doesn't work because it fails to pass to the call as well as the first call, both of which need for the frame not to render: can be used to change the non-client (NC) rendering policy and hence result in a call. However, I did not find any references to within the Electron and Chromium codebases that were actually called when running my minimal repro.\nlets continue the investigation in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-a4bf17629b8fa006d37baf2e13228eb7633bf5a30c6e257c3c0686bfa999f37e", "text": "constructor(modulePath: string, args?: string[] | undefined, options?: UtilityProcessOptions); postMessage(channel: string, message: any, transfer?: Electron.MessagePortMain[]): void; kill(signal?: number | string): boolean; <del> on(event: 'exit', listener: (code: number | undefined) => void): this; </del> <ins> on(event: 'exit', listener: (event: Electron.Event, code: number) => void): this; </ins> on(event: 'spawn', listener: () => void): this; } }", "commid": "vscode_pr_158025"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b5fc75b29804529424fbb521708f13d785c0b8fb756f4503b0d4b6264ac8d55", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 (x64) OS Version: 10.0. Build (Window 10) Steps to Reproduce: VS Code (or use the shortcut ) the first miliseconds after opening a new instance of VS Code, a \"Window 7\"-like window frame layout appears, before the usual VS Code look shows up (see the attached GIF). The GIF below first shows the expected behavior, opening version 1.65.0, followed by the current behavior of version 1.66.0. ! The two executables were downloaded from: and\nRefs\nthat's the reason I went back to 1.65, frames are so annoying.\nHi just a small update: I've downloaded the latest VS Code Insiders and the problem now only appears when launching VS Code for the first time, but no longer when opening new windows from a running instance of it.\nThis issue persists in the new latest version release, .\nThe issue persists in today's release, .\nSince the related bug in the Electron repo has a label, and today's VSCode uses , I believe we will be experiencing this bug for months.\nThe upstream Electron issue is at The issue was introduced in Electron v14.0.0-beta.5 and the commit that introduced the issue is The PR fixes the issue where frameless resizable windows show Windows 7 frames during startup, but there's a larger issue that is still unresolved even with that PR. I also searched through the thousands of to see whether they had anything to do with the issue, but I didn't find anything relevant even after reverting several suspicious commits. Running with Electron v14.0.0-beta.5 or newer on Windows 10 reproduces the issue. The PR fixes the issue for frameless resizable windows by calling at an earlier stage of program initialization. Assume the window is frameless and resizable. Then, the program sets to earlier in , and the following occurs: is not run, meaning is not removed from the style set in Line 62. This style parameter is passed in to a call at . is not run. Instead, the block above is run, which adds a style to the style passed into the call. , because of these styles being passed in, after the window is shown, we get a single message, and no messages after. NC in this case refers to non-client area, which is the frame. DWM stands for desktop windows manager. After adding a long of 30 seconds to the call above, I was able to use Spy++ to log messages to that window and see the following: I have also attached full logs to the end of this comment. For frameless windows that cannot resize, even if we call earlier, because the program would pass in , for the and calls above, the style would not be in the styles sent to the calls. As a result, what I see in Spy++ is being toggled three times, and several calls that result in messages being emitted. Using Spy++, I confirmed that the calls have the flag set. I have searched the Chromium and Electron codebases for and (as well as ) to see why the frame might be rendering more often when is not passed in. However, I haven't found anything within the codebase itself. Searching Windows documentation, I found the following: causes to be sent. Reference: However, I'm not sure whether this could explain the difference in behaviour between resizable and non-resizable windows. can pass in or to send to the window, which is why I searched for those two constants within the codebase. Reference: Also, Chromium handles by returning at , which I assume causes the message to occur. Also, Electron calls at . I noticed that if I don't call there, the Windows 7 frame doesn't show up, but then the Electron window doesn't render with the proper style (see ). I also noticed that when the Windows 7 frame shows up, it has the style of whatever was passed into that specific call. For example, if I add to the call, then for a second I see a Windows 7 frame with applied. I also tried creating a minimal project in VS to reproduce the issue but wasn't successful. The frame that rendered seemed to have a Windows 10 style rather than a Windows 7 one. I also tried registering a listener in for the messages, and it did seem to get hit, though I couldn't do anything with it. There's also the mysterious , but I wasn't able to apply it to resolve the issue.\nThe PR that linked above (partially based on ) should resolve the issue for VS Code Insiders and hence close this issue, but there's still more I'd like to investigate, especially for frameless non-resizable windows. I some lines to log the hwnd and style passed into each relevant and call. One example of the styles that show up: There's also another window being created really early, but I don't think it influences the issue. Good scenario (meaning no frame showing) with set to and staying Bad scenario with set to then Bad scenario with set to and staying The call with style causes the Windows 7 frame to render, and its style corresponds to is actually the same style just with , once again showing how mysterious the constant is. While working on , I also noticed that changing the order of the calls seemed to fix the issue for frameless non-resizable windows. In particular, on the Electron side, in , if I first called to pretend that the window is resizable, and then called (where ) after the call around line 365, then the issue is resolved even for frameless non-resizable windows. However, this workaround delays the call to hundreds of lines later, and I wouldn't be surprised if it would cause a regression elsewhere. Just like in the log file of the good case of the previous comment, only shows up once, rather than three times. For completeness, here are the logs with the styles for this scenario, excluding the logs: In this case, the style never comes up! I also tried delaying the call and calling instead of , but that doesn't work because it fails to pass to the call as well as the first call, both of which need for the frame not to render: can be used to change the non-client (NC) rendering policy and hence result in a call. However, I did not find any references to within the Electron and Chromium codebases that were actually called when running my minimal repro.\nlets continue the investigation in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-c06917c007fb09262873950f452cda4744035616dc97e7ae4a906271e35e41e9", "text": "this._register(Event.fromNodeEventEmitter<void>(this._process, 'spawn')(() => { this._logService.info(`UtilityProcess<${this.id}>: received spawn event.`); })); <del> this._register(Event.fromNodeEventEmitter<number | undefined>(this._process, 'exit')((code: number | undefined) => { code = code || 0; </del> <ins> const onExit = Event.fromNodeEventEmitter<number>(this._process, 'exit', (_, code: number) => code); this._register(onExit((code: number) => { </ins> this._logService.info(`UtilityProcess<${this.id}>: received exit event with code ${code}.`); this._hasExited = true; this._onExit.fire({ pid: this._process!.pid!, code, signal: '' });", "commid": "vscode_pr_158025"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b5fc75b29804529424fbb521708f13d785c0b8fb756f4503b0d4b6264ac8d55", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 (x64) OS Version: 10.0. Build (Window 10) Steps to Reproduce: VS Code (or use the shortcut ) the first miliseconds after opening a new instance of VS Code, a \"Window 7\"-like window frame layout appears, before the usual VS Code look shows up (see the attached GIF). The GIF below first shows the expected behavior, opening version 1.65.0, followed by the current behavior of version 1.66.0. ! The two executables were downloaded from: and\nRefs\nthat's the reason I went back to 1.65, frames are so annoying.\nHi just a small update: I've downloaded the latest VS Code Insiders and the problem now only appears when launching VS Code for the first time, but no longer when opening new windows from a running instance of it.\nThis issue persists in the new latest version release, .\nThe issue persists in today's release, .\nSince the related bug in the Electron repo has a label, and today's VSCode uses , I believe we will be experiencing this bug for months.\nThe upstream Electron issue is at The issue was introduced in Electron v14.0.0-beta.5 and the commit that introduced the issue is The PR fixes the issue where frameless resizable windows show Windows 7 frames during startup, but there's a larger issue that is still unresolved even with that PR. I also searched through the thousands of to see whether they had anything to do with the issue, but I didn't find anything relevant even after reverting several suspicious commits. Running with Electron v14.0.0-beta.5 or newer on Windows 10 reproduces the issue. The PR fixes the issue for frameless resizable windows by calling at an earlier stage of program initialization. Assume the window is frameless and resizable. Then, the program sets to earlier in , and the following occurs: is not run, meaning is not removed from the style set in Line 62. This style parameter is passed in to a call at . is not run. Instead, the block above is run, which adds a style to the style passed into the call. , because of these styles being passed in, after the window is shown, we get a single message, and no messages after. NC in this case refers to non-client area, which is the frame. DWM stands for desktop windows manager. After adding a long of 30 seconds to the call above, I was able to use Spy++ to log messages to that window and see the following: I have also attached full logs to the end of this comment. For frameless windows that cannot resize, even if we call earlier, because the program would pass in , for the and calls above, the style would not be in the styles sent to the calls. As a result, what I see in Spy++ is being toggled three times, and several calls that result in messages being emitted. Using Spy++, I confirmed that the calls have the flag set. I have searched the Chromium and Electron codebases for and (as well as ) to see why the frame might be rendering more often when is not passed in. However, I haven't found anything within the codebase itself. Searching Windows documentation, I found the following: causes to be sent. Reference: However, I'm not sure whether this could explain the difference in behaviour between resizable and non-resizable windows. can pass in or to send to the window, which is why I searched for those two constants within the codebase. Reference: Also, Chromium handles by returning at , which I assume causes the message to occur. Also, Electron calls at . I noticed that if I don't call there, the Windows 7 frame doesn't show up, but then the Electron window doesn't render with the proper style (see ). I also noticed that when the Windows 7 frame shows up, it has the style of whatever was passed into that specific call. For example, if I add to the call, then for a second I see a Windows 7 frame with applied. I also tried creating a minimal project in VS to reproduce the issue but wasn't successful. The frame that rendered seemed to have a Windows 10 style rather than a Windows 7 one. I also tried registering a listener in for the messages, and it did seem to get hit, though I couldn't do anything with it. There's also the mysterious , but I wasn't able to apply it to resolve the issue.\nThe PR that linked above (partially based on ) should resolve the issue for VS Code Insiders and hence close this issue, but there's still more I'd like to investigate, especially for frameless non-resizable windows. I some lines to log the hwnd and style passed into each relevant and call. One example of the styles that show up: There's also another window being created really early, but I don't think it influences the issue. Good scenario (meaning no frame showing) with set to and staying Bad scenario with set to then Bad scenario with set to and staying The call with style causes the Windows 7 frame to render, and its style corresponds to is actually the same style just with , once again showing how mysterious the constant is. While working on , I also noticed that changing the order of the calls seemed to fix the issue for frameless non-resizable windows. In particular, on the Electron side, in , if I first called to pretend that the window is resizable, and then called (where ) after the call around line 365, then the issue is resolved even for frameless non-resizable windows. However, this workaround delays the call to hundreds of lines later, and I wouldn't be surprised if it would cause a regression elsewhere. Just like in the log file of the good case of the previous comment, only shows up once, rather than three times. For completeness, here are the logs with the styles for this scenario, excluding the logs: In this case, the style never comes up! I also tried delaying the call and calling instead of , but that doesn't work because it fails to pass to the call as well as the first call, both of which need for the frame not to render: can be used to change the non-client (NC) rendering policy and hence result in a call. However, I did not find any references to within the Electron and Chromium codebases that were actually called when running my minimal repro.\nlets continue the investigation in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-211688f9b6445ba29dc408ced4f38234e620e22b06cc2c3b30909e8f90da9872", "text": "resolved \"https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.207.tgz#9c3310ebace2952903d05dcaba8abe3a4ed44c01\" integrity sha512-piH7MJDJp4rJCduWbVvmUd59AUne1AFBJ8JaRQvk0KzNTSUnZrVXHCZc+eg+CGE4OujkcLJznhGKD6tuAshj5Q== <del> electron@19.0.11: version \"19.0.11\" resolved \"https://registry.yarnpkg.com/electron/-/electron-19.0.11.tgz#0c0a52abc08694fd38916d9270baf45bb7752a27\" integrity sha512-GPM6C1Ze17/gR4koTE171MxrI5unYfFRgXQdkMdpWM2Cd55LMUrVa0QHCsfKpsaloufv9T65lsOn0uZuzCw5UA== </del> <ins> electron@19.0.12: version \"19.0.12\" resolved \"https://registry.yarnpkg.com/electron/-/electron-19.0.12.tgz#73d11cc2a3e4dbcd61fdc1c39561e7a7911046e9\" integrity sha512-GOvG0t2NCeJYIfmC3g/dnEAQ71k3nQDbRVqQhpi2YbsYMury0asGJwqnVAv2uZQEwCwSx4XOwOQARTFEG/msWw== </ins> dependencies: \"@electron/get\" \"^1.14.1\" \"@types/node\" \"^16.11.26\"", "commid": "vscode_pr_158025"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8f4d4fadcf77ec7771ecbe82e4bd47f3cabc428bc5247ef865f43bd3bf9d48b", "query": "Issue Type: <bBug</bSteps to Reproduce:  in a Markdown cell in Jupyter notebook. The monospace font used in Jupyter notebook () Markdown code blocks is not consistent with in the settings. ! This does not occur in a seperate Markdown () file. ! VS Code version: Code 1.66.0 (, 2022-03-30T05:50:14.623Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-c720007ccdc72622ab72c3a889267ef6fa4cd9c2426fa8879051a411fdc9373c", "text": "code { font-size: 1em; <ins> font-family: var(--vscode-editor-font-family); </ins> } pre code { <del> font-family: var(--vscode-editor-font-family); </del> line-height: 1.357em; white-space: pre-wrap; }", "commid": "vscode_pr_157554"}], "negative_passages": []}
{"query_id": "q-en-vscode-1c40a0cf3bdc81282a1dcb9225acbbb5a49c262a89a85cc00736106739af6ed2", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.0 OS: MacOS Monterey 12.3, Darwin x64 21.4.0 Steps to Reproduce: new new markdown cell, name it for instance or will only show and have deleted the 1) or 1. written manually\ncc -- It looks like this is being sanitized out of md strings. A markdown cell containing will be sanitized to render as . If the cell contains it will render as expected, only removing the html tags. It seems to be happening at the following:", "positive_passages": [{"docid": "doc-en-vscode-11abde32baee8d6666696670af8437afffdb5dac36ae9b19022f16fadef4ea75", "text": "if (token.type === 'heading') { yield { depth: token.depth, <del> text: renderMarkdownAsPlaintext({ value: token.text }).trim() </del> <ins> text: renderMarkdownAsPlaintext({ value: token.raw }).trim() </ins> }; } }", "commid": "vscode_pr_208050"}], "negative_passages": []}
{"query_id": "q-en-vscode-d87b1f134a1457a56104f60977bbf10d0624d85c64e1944a4860597c093b50ca", "query": "<img width=\"776\" alt=\"image\" src=\"https://user-\"I don't have stable reproduce, but this happens pretty often, especially I'm moving lines around.\nI don't think this is a bug of injected text: When there are not decorations, there cannot be any injected text. This looks like there are some orphaned decorations.\nDo you use the setting? Do you still see this with latest & greatest insiders?\nI'm using the setting but haven't seen it for a while since I reported the issue.\nLeaving this open, lets find steps\nIs it possible that this is caused by the recursive issue?\nCould be the case! The fix is to use it like this:\nOh, so inside the runner?\nYes, because change events are only send out after returns. Thus, is not reentrant anymore and will be assigned correctly.", "positive_passages": [{"docid": "doc-en-vscode-339361f00f817e15bad04e64bb616be2e160a6d341d9ac4eece88ed0679c0e37", "text": "} } } <del> const newDecorationIds = this._editor.deltaDecorations(decorationIdsToReplace, newDecorationsData.map(d => d.decoration)); for (let i = 0; i < newDecorationIds.length; i++) { const data = newDecorationsData[i]; this._decorationsMetadata.set(newDecorationIds[i], data); } </del> <ins> this._editor.changeDecorations(accessor => { const newDecorationIds = accessor.deltaDecorations(decorationIdsToReplace, newDecorationsData.map(d => d.decoration)); for (let i = 0; i < newDecorationIds.length; i++) { const data = newDecorationsData[i]; this._decorationsMetadata.set(newDecorationIds[i], data); } }); </ins> } private _fillInColors(props: CssProperties, hint: languages.InlayHint): void {", "commid": "vscode_pr_148712"}], "negative_passages": []}
{"query_id": "q-en-vscode-3323a8e37cea518fbd1faa54bc9d73b17468d0d8546e20217ee031ef7a477737", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In response to , I think this error should only be raised when a request actually fails. I have a network setup where my host operating system reports it doesn't have network connectivity, but it can actually reach the internet just fine through a configured proxy. I believe moving the online check to the would result in a more accurate error flow: Obligatory xkcd for my unique situation:\nAs mentioned by I expect shall provide right info whether VS Code can connect to internet or not. Is it possible to get this info from the error instead of ?", "positive_passages": [{"docid": "doc-en-vscode-3f1b8e222f7039ff75f529e5c6266d4006e1f9a159642879396bb2be12b77638", "text": "import { IRequestContext, IRequestOptions, OfflineError } from 'vs/base/parts/request/common/request'; export function request(options: IRequestOptions, token: CancellationToken): Promise<IRequestContext> { <del> if (!navigator.onLine) { throw new OfflineError(); } </del> if (options.proxyAuthorization) { options.headers = { ...(options.headers || {}),", "commid": "vscode_pr_172708"}], "negative_passages": []}
{"query_id": "q-en-vscode-3323a8e37cea518fbd1faa54bc9d73b17468d0d8546e20217ee031ef7a477737", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --In response to , I think this error should only be raised when a request actually fails. I have a network setup where my host operating system reports it doesn't have network connectivity, but it can actually reach the internet just fine through a configured proxy. I believe moving the online check to the would result in a more accurate error flow: Obligatory xkcd for my unique situation:\nAs mentioned by I expect shall provide right info whether VS Code can connect to internet or not. Is it possible to get this info from the error instead of ?", "positive_passages": [{"docid": "doc-en-vscode-40a5a56f5d71ec6e39b08518bdede24b38bb544ca72f1d113dae9ac47235fc8b", "text": "setRequestHeaders(xhr, options); xhr.responseType = 'arraybuffer'; <del> xhr.onerror = e => reject(new Error(xhr.statusText && ('XHR failed: ' + xhr.statusText) || 'XHR failed')); </del> <ins> xhr.onerror = e => reject( navigator.onLine ? new Error(xhr.statusText && ('XHR failed: ' + xhr.statusText) || 'XHR failed') : new OfflineError() ); </ins> xhr.onload = (e) => { resolve({ res: {", "commid": "vscode_pr_172708"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-185fa931f98e2ff42494b1d0092af60a6f4e102d5650b3ea378b015950b85af0", "text": "\"vscode-proxy-agent\": \"^0.12.0\", \"vscode-regexpp\": \"^3.1.0\", \"vscode-textmate\": \"7.0.1\", <del> \"xterm\": \"4.19.0-beta.24\", \"xterm-addon-search\": \"0.9.0-beta.21\", </del> <ins> \"xterm\": \"4.19.0-beta.25\", \"xterm-addon-search\": \"0.9.0-beta.22\", </ins> \"xterm-addon-serialize\": \"0.7.0-beta.12\", \"xterm-addon-unicode11\": \"0.4.0-beta.3\", <del> \"xterm-addon-webgl\": \"0.12.0-beta.28\", \"xterm-headless\": \"4.19.0-beta.24\", </del> <ins> \"xterm-addon-webgl\": \"0.12.0-beta.29\", \"xterm-headless\": \"4.19.0-beta.25\", </ins> \"yauzl\": \"^2.9.2\", \"yazl\": \"^2.4.3\" },", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-32a431e78be37cb943d52f877835907b847426e7efaaddae9a3ace34e23328e9", "text": "\"tas-client-umd\": \"0.1.4\", \"vscode-oniguruma\": \"1.6.1\", \"vscode-textmate\": \"7.0.1\", <del> \"xterm\": \"4.19.0-beta.24\", \"xterm-addon-search\": \"0.9.0-beta.21\", </del> <ins> \"xterm\": \"4.19.0-beta.25\", \"xterm-addon-search\": \"0.9.0-beta.22\", </ins> \"xterm-addon-unicode11\": \"0.4.0-beta.3\", <del> \"xterm-addon-webgl\": \"0.12.0-beta.28\" </del> <ins> \"xterm-addon-webgl\": \"0.12.0-beta.29\" </ins> } }", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-4fd1b01337749835dcd0184774d8ab5fe8b9c5122c70f379866431c4366fd9b5", "text": "resolved \"https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-7.0.1.tgz#8118a32b02735dccd14f893b495fa5389ad7de79\" integrity sha512-zQ5U/nuXAAMsh691FtV0wPz89nSkHbs+IQV8FDk+wew9BlSDhf4UmWGlWJfTR2Ti6xZv87Tj5fENzKf6Qk7aLw== <del> xterm-addon-search@0.9.0-beta.21: version \"0.9.0-beta.21\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.21.tgz#5348fe25676cdd89ce3be52ae62a316b6f266176\" integrity sha512-jh6kfRCpWRvZZkV9QghFYesSYHjybaLNEyYAD6uilZYfNHoGLa0zPgUkLOqoECL7K6rhBmSYOkKbc9MG4wNFMQ== </del> <ins> xterm-addon-search@0.9.0-beta.22: version \"0.9.0-beta.22\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.22.tgz#18f2eabda82709cdd64dee003879b586869e28a3\" integrity sha512-1I8W0bwjg6bUoNaESKHSkS9BN3Z9Xe44/zbUb6Un+pbb5Nun4LQvFwSLkAIdRrslxcbcHYIU/2Q7F1wCOWLbaA== </ins> xterm-addon-unicode11@0.4.0-beta.3: version \"0.4.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa\" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.28: version \"0.12.0-beta.28\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.28.tgz#252f88fd15816c23789659a0e2545682cf1eec9c\" integrity sha512-xpqZRYlyv+aNdDl46W2Hi2fxakNvdJDmWhOwGHPjOmex+kOYdBvVn4rRZmJ7xrKFuQVOfzb3SQCmpZ/njCpBJA== </del> <ins> xterm-addon-webgl@0.12.0-beta.29: version \"0.12.0-beta.29\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.29.tgz#7a508595c4521d14d7ed4315a121f9e3f230a0f0\" integrity sha512-NcZBsD0ar3ZpQX070hDIsyEBl/StRMNu6U+9crNpiD2rQVfkM1vcWkOv31Zlj3eu6/f8z5aStyZLRMCGFwiRbA== </ins> <del> xterm@4.19.0-beta.24: version \"4.19.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.24.tgz#12b62877d4cf133f4626db3a15f6ed267b3bbcb5\" integrity sha512-GydvC2ExdsfjkiXhUVuZtDhc89IZfyMLFgw/nwWHrvkyq4iCVsHbMloEObV3lZmv+0oRpcGtTiorfzdWGiHG0A== </del> <ins> xterm@4.19.0-beta.25: version \"4.19.0-beta.25\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.25.tgz#38f92d0fef1cfdb290ef8994449a04fa1a8c90a7\" integrity sha512-pDiMWKN1Cj4+X/K9Xegp0SA0ZDEGVqiq7RPSy8oZO2wo2rze1BF20PAZb3/RSp30eY5WyOKilKnck4yNOsPzHw== </ins>", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-03e97742a64c9088483106e3767fd6afa8adbbed1800674fb4f740b94a979314", "text": "resolved \"https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f\" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-search@0.9.0-beta.21: version \"0.9.0-beta.21\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.21.tgz#5348fe25676cdd89ce3be52ae62a316b6f266176\" integrity sha512-jh6kfRCpWRvZZkV9QghFYesSYHjybaLNEyYAD6uilZYfNHoGLa0zPgUkLOqoECL7K6rhBmSYOkKbc9MG4wNFMQ== </del> <ins> xterm-addon-search@0.9.0-beta.22: version \"0.9.0-beta.22\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.22.tgz#18f2eabda82709cdd64dee003879b586869e28a3\" integrity sha512-1I8W0bwjg6bUoNaESKHSkS9BN3Z9Xe44/zbUb6Un+pbb5Nun4LQvFwSLkAIdRrslxcbcHYIU/2Q7F1wCOWLbaA== </ins> xterm-addon-serialize@0.7.0-beta.12: version \"0.7.0-beta.12\"", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-5b0cf15afb4c151a5191547e90540041bc4c17b5cd1f78b3677a612d698a92c9", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa\" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.28: version \"0.12.0-beta.28\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.28.tgz#252f88fd15816c23789659a0e2545682cf1eec9c\" integrity sha512-xpqZRYlyv+aNdDl46W2Hi2fxakNvdJDmWhOwGHPjOmex+kOYdBvVn4rRZmJ7xrKFuQVOfzb3SQCmpZ/njCpBJA== </del> <ins> xterm-addon-webgl@0.12.0-beta.29: version \"0.12.0-beta.29\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.29.tgz#7a508595c4521d14d7ed4315a121f9e3f230a0f0\" integrity sha512-NcZBsD0ar3ZpQX070hDIsyEBl/StRMNu6U+9crNpiD2rQVfkM1vcWkOv31Zlj3eu6/f8z5aStyZLRMCGFwiRbA== </ins> <del> xterm-headless@4.19.0-beta.24: version \"4.19.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.24.tgz#17dab68ae1b2600b0926d4c47032599f3b2f24cc\" integrity sha512-Coq8gQ9f5/kNr1yhpXTZqatTOHOYDF4XVp93SM12vRROH64bM0rUMec6ukuTAd8DD97UOWYUgR+n7+xD0iTTSg== </del> <ins> xterm-headless@4.19.0-beta.25: version \"4.19.0-beta.25\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.25.tgz#a0a1b59f386c44458f06b8ced64e3567371cc983\" integrity sha512-UswSgymk3g9i6XTpFAasnqqIvWhi+AEWT+iO3kkjII6ll+dYEQgeZAv92EnCmeRHp11u5TP+IBAo8jy+aTYbtA== </ins> <del> xterm@4.19.0-beta.24: version \"4.19.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.24.tgz#12b62877d4cf133f4626db3a15f6ed267b3bbcb5\" integrity sha512-GydvC2ExdsfjkiXhUVuZtDhc89IZfyMLFgw/nwWHrvkyq4iCVsHbMloEObV3lZmv+0oRpcGtTiorfzdWGiHG0A== </del> <ins> xterm@4.19.0-beta.25: version \"4.19.0-beta.25\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.25.tgz#38f92d0fef1cfdb290ef8994449a04fa1a8c90a7\" integrity sha512-pDiMWKN1Cj4+X/K9Xegp0SA0ZDEGVqiq7RPSy8oZO2wo2rze1BF20PAZb3/RSp30eY5WyOKilKnck4yNOsPzHw== </ins> yallist@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-c8c3ec4661b754f2e6bbd2a19af6d95213f610d7bd22a1a25d50e9ec4035ef85", "text": "import { KeyCode } from 'vs/base/common/keyCodes'; import { FindReplaceState } from 'vs/editor/contrib/find/browser/findState'; import { IMessage as InputBoxMessage } from 'vs/base/browser/ui/inputbox/inputBox'; <del> import { SimpleButton, findPreviousMatchIcon, findNextMatchIcon } from 'vs/editor/contrib/find/browser/findWidget'; </del> <ins> import { SimpleButton, findPreviousMatchIcon, findNextMatchIcon, NLS_NO_RESULTS, NLS_MATCHES_LOCATION } from 'vs/editor/contrib/find/browser/findWidget'; </ins> import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextViewService } from 'vs/platform/contextview/browser/contextView'; import { editorWidgetBackground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, errorForeground } from 'vs/platform/theme/common/colorRegistry'; import { IColorTheme, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { ContextScopedFindInput } from 'vs/platform/history/browser/contextScopedHistoryWidget'; import { widgetClose } from 'vs/platform/theme/common/iconRegistry'; <ins> import * as strings from 'vs/base/common/strings'; </ins> const NLS_FIND_INPUT_LABEL = nls.localize('label.find', \"Find\"); const NLS_FIND_INPUT_\" = nls.localize('placeholder.find', \"Find\");", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-91f12faf963f671dc0cb75ebc61655b8ce12ea88d4da5895010fb2c1b8987de6", "text": "this._matchesCount.className = 'matchesCount'; } this._matchesCount.innerText = ''; <del> const label = count === undefined || count.resultCount === 0 ? `No Results` : `${count.resultIndex + 1} of ${count.resultCount}`; </del> <ins> let label; if (count?.resultCount === -1) { label = ''; } else { label = count === undefined || count.resultCount === 0 ? NLS_NO_RESULTS : strings.format(NLS_MATCHES_LOCATION, count.resultIndex + 1, count?.resultCount); } </ins> this._matchesCount.appendChild(document.createTextNode(label)); this._matchesCount.classList.toggle('no-results', !count || count.resultCount === 0); this._findInput?.domNode.insertAdjacentElement('afterend', this._matchesCount);", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-f24a9f52937e7a1cc027b73dcfcb55c0bea18f40fcdc83686fdb61eab1b8a109", "text": "dependencies: object-keys \"~0.4.0\" <del> xterm-addon-search@0.9.0-beta.21: version \"0.9.0-beta.21\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.21.tgz#5348fe25676cdd89ce3be52ae62a316b6f266176\" integrity sha512-jh6kfRCpWRvZZkV9QghFYesSYHjybaLNEyYAD6uilZYfNHoGLa0zPgUkLOqoECL7K6rhBmSYOkKbc9MG4wNFMQ== </del> <ins> xterm-addon-search@0.9.0-beta.22: version \"0.9.0-beta.22\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.9.0-beta.22.tgz#18f2eabda82709cdd64dee003879b586869e28a3\" integrity sha512-1I8W0bwjg6bUoNaESKHSkS9BN3Z9Xe44/zbUb6Un+pbb5Nun4LQvFwSLkAIdRrslxcbcHYIU/2Q7F1wCOWLbaA== </ins> xterm-addon-serialize@0.7.0-beta.12: version \"0.7.0-beta.12\"", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e54b4ef7b2508ae61299ebd0fd6ca2f0260fc1296885eb3c6be3631b8d7bce8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.67.0-insiders OS Version: macOS 12.3.1 Steps to Reproduce: the terminal scrollback to 30'000 for With version 1.65.0 this was not a problem, but there was no highlighting. It would be enough if I can disable the highlighting or disable the highlighting automatically if the history is longer than x lines. https://user-\nThat doesn't look or feel slow to me - can you elaborate on what the issue you're dealing with is?\nIs it Upstream or VSCode Core.\nHappens for me too, when you search then type abs quickly and it takes ~5-10 seconds for the letters to appear, same goes with erasing letters.\nSearch is fast now but matches info is not being shown -", "positive_passages": [{"docid": "doc-en-vscode-1915c79c07d9daf93eef235a01fec1e672becb6e2a1eebafcec8221b51a5f1bd", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa\" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== <del> xterm-addon-webgl@0.12.0-beta.28: version \"0.12.0-beta.28\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.28.tgz#252f88fd15816c23789659a0e2545682cf1eec9c\" integrity sha512-xpqZRYlyv+aNdDl46W2Hi2fxakNvdJDmWhOwGHPjOmex+kOYdBvVn4rRZmJ7xrKFuQVOfzb3SQCmpZ/njCpBJA== </del> <ins> xterm-addon-webgl@0.12.0-beta.29: version \"0.12.0-beta.29\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.29.tgz#7a508595c4521d14d7ed4315a121f9e3f230a0f0\" integrity sha512-NcZBsD0ar3ZpQX070hDIsyEBl/StRMNu6U+9crNpiD2rQVfkM1vcWkOv31Zlj3eu6/f8z5aStyZLRMCGFwiRbA== </ins> <del> xterm-headless@4.19.0-beta.24: version \"4.19.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.24.tgz#17dab68ae1b2600b0926d4c47032599f3b2f24cc\" integrity sha512-Coq8gQ9f5/kNr1yhpXTZqatTOHOYDF4XVp93SM12vRROH64bM0rUMec6ukuTAd8DD97UOWYUgR+n7+xD0iTTSg== </del> <ins> xterm-headless@4.19.0-beta.25: version \"4.19.0-beta.25\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.25.tgz#a0a1b59f386c44458f06b8ced64e3567371cc983\" integrity sha512-UswSgymk3g9i6XTpFAasnqqIvWhi+AEWT+iO3kkjII6ll+dYEQgeZAv92EnCmeRHp11u5TP+IBAo8jy+aTYbtA== </ins> <del> xterm@4.19.0-beta.24: version \"4.19.0-beta.24\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.24.tgz#12b62877d4cf133f4626db3a15f6ed267b3bbcb5\" integrity sha512-GydvC2ExdsfjkiXhUVuZtDhc89IZfyMLFgw/nwWHrvkyq4iCVsHbMloEObV3lZmv+0oRpcGtTiorfzdWGiHG0A== </del> <ins> xterm@4.19.0-beta.25: version \"4.19.0-beta.25\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.25.tgz#38f92d0fef1cfdb290ef8994449a04fa1a8c90a7\" integrity sha512-pDiMWKN1Cj4+X/K9Xegp0SA0ZDEGVqiq7RPSy8oZO2wo2rze1BF20PAZb3/RSp30eY5WyOKilKnck4yNOsPzHw== </ins> y18n@^3.2.1: version \"3.2.2\"", "commid": "vscode_pr_147879"}], "negative_passages": []}
{"query_id": "q-en-vscode-42c718140a5afd77c70ebf3ba6693021fae671eb3282267e93419cf005940e62", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.66.2 (Universal) Commit: Date: 2022-04-11T07:49:20.994Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Darwin x64 20.5.0 Steps to Reproduce: push a commit to a repo that user don't have permission message modal will show to ask user if they want to create a fork repo button create a fork for you user don't want to creat a fork, that's why they close it. <img width=\"504\" alt=\"Screen Shot 2022-04-29 at 11 18 18 PM\" src=\"https://user-\"I check the code, looks like github extention only check  to return. What I suggest If you think this were resonable, I will make a PR for it", "positive_passages": [{"docid": "doc-en-vscode-37c33e564799c5df09fdad754ccdb36611db458f986d468830babea60926324f", "text": "const no = localize('no', \"No\"); const answer = await window.showInformationMessage(localize('fork', \"You don't have permissions to push to '{0}/{1}' on GitHub. Would you like to create a fork and push to it instead?\", owner, repo), yes, no); <del> if (answer === no) { </del> <ins> if (answer !== yes) { </ins> return; }", "commid": "vscode_pr_148438"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f953b0304d2c4e027d873d43177cf90ac056d9ec62a1aad991a57a228bc95f", "query": "Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\ncould you post some steps to verify?\nI could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.\nVerified by code review\nunfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D", "positive_passages": [{"docid": "doc-en-vscode-351e7aad25a151c3bff94109b74537e91790bd30fe146ed31063f9312edaa68e", "text": "import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { ITextModel } from 'vs/editor/common/model'; import * as nls from 'vs/nls'; <del> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; </del> <ins> import { IConfirmationResult, IDialogService } from 'vs/platform/dialogs/common/dialogs'; </ins> const ignoreUnusualLineTerminators = 'ignoreUnusualLineTerminators';", "commid": "vscode_pr_164441"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f953b0304d2c4e027d873d43177cf90ac056d9ec62a1aad991a57a228bc95f", "query": "Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\ncould you post some steps to verify?\nI could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.\nVerified by code review\nunfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D", "positive_passages": [{"docid": "doc-en-vscode-c745152bd9e3fa02e99beeaec727ad251762544f3d2ca81749882012f32af295", "text": "public static readonly ID = 'editor.contrib.unusualLineTerminatorsDetector'; private _config: 'auto' | 'off' | 'prompt'; <ins> private _isPresentingDialog: boolean = false; </ins> constructor( private readonly _editor: ICodeEditor,", "commid": "vscode_pr_164441"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f953b0304d2c4e027d873d43177cf90ac056d9ec62a1aad991a57a228bc95f", "query": "Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\ncould you post some steps to verify?\nI could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.\nVerified by code review\nunfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D", "positive_passages": [{"docid": "doc-en-vscode-3bf7d955cb557223aa22ccbcf400285a3a9616014acf4267bfb9a9923c9c4c8a", "text": "return; } <del> const result = await this._dialogService.confirm({ title: nls.localize('unusualLineTerminators.title', \"Unusual Line Terminators\"), message: nls.localize('unusualLineTerminators.message', \"Detected unusual line terminators\"), detail: nls.localize('unusualLineTerminators.detail', \"The file '{0}' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.\", basename(model.uri)), primaryButton: nls.localize('unusualLineTerminators.fix', \"Remove Unusual Line Terminators\"), secondaryButton: nls.localize('unusualLineTerminators.ignore', \"Ignore\") }); </del> <ins> if (this._isPresentingDialog) { // we're currently showing the dialog, which is async. // avoid spamming the user return; } let result: IConfirmationResult; try { this._isPresentingDialog = true; result = await this._dialogService.confirm({ title: nls.localize('unusualLineTerminators.title', \"Unusual Line Terminators\"), message: nls.localize('unusualLineTerminators.message', \"Detected unusual line terminators\"), detail: nls.localize('unusualLineTerminators.detail', \"The file '{0}' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.\", basename(model.uri)), primaryButton: nls.localize('unusualLineTerminators.fix', \"Remove Unusual Line Terminators\"), secondaryButton: nls.localize('unusualLineTerminators.ignore', \"Ignore\") }); } finally { this._isPresentingDialog = false; } </ins> if (!result.confirmed) { // this model should be ignored", "commid": "vscode_pr_164441"}], "negative_passages": []}
{"query_id": "q-en-vscode-650bbc4c8e9ada8d78bf189114f4a66385d515c3edfd92bd9d50852dbcb8372e", "query": "Issue Type: <bBug</bWhen closing the Python interactive window the Terminal panel shows itself. ! VS Code version: Code 1.67.0 (, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <details<summaryExtensions (8)</summaryExtensionVersion ------ remotehub0.32.0 python2022.6.0 vscode-pylance2022.4.3 jupyter2022.4. jupyter-keymap1.0.0 jupyter-renderers1.0.6 remote-repositories0.6.0 markdown-all-in-one3.4.3 </details<!-- generated by issue reporter --\nwhat's the recommended approach to debug this? I'm not sure who is opening the terminal (but I know it's not notebook or iw as it's the editor tab close button)\nI debugged this, and determined that when the interactive window is closed, it updates a context key which hide a view container in the panel. this incorrectly triggers the panel to show.", "positive_passages": [{"docid": "doc-en-vscode-4fff5cdcc550edfc7624921e8422770be2aa555c7227340fc8e6783821f43fd4", "text": "contextKey.set(true); this.compositeBar.addComposite({ id: viewContainer.id, name: viewContainer.title, order: viewContainer.order, requestedIndex: viewContainer.requestedIndex }); <del> const activeComposite = this.getActiveComposite(); if (activeComposite === undefined || activeComposite.getId() === viewContainer.id) { this.compositeBar.activateComposite(viewContainer.id); </del> <ins> if (this.layoutService.isVisible(this.partId)) { const activeComposite = this.getActiveComposite(); if (activeComposite === undefined || activeComposite.getId() === viewContainer.id) { this.compositeBar.activateComposite(viewContainer.id); } </ins> } this.layoutCompositeBar();", "commid": "vscode_pr_149182"}], "negative_passages": []}
{"query_id": "q-en-vscode-5b3e6aa093bee289b961b50fa528c6abdfd41e5785d6c94381dc5f507d5b48e5", "query": "Open in two different tabs Make sure settings sync is OFF Change the theme in one tab Theme is not updated in other tab", "positive_passages": [{"docid": "doc-en-vscode-0e29f36735e0b1acccfcbabce24c790b01e1135eccb26d4a377b7d5b3fb9f2a3", "text": "// User data let userDataProvider; if (indexedDB) { <del> userDataProvider = new IndexedDBFileSystemProvider(logsPath.scheme, indexedDB, userDataStore, false); </del> <ins> userDataProvider = new IndexedDBFileSystemProvider(Schemas.vscodeUserData, indexedDB, userDataStore, true); </ins> this.registerDeveloperActions(<IndexedDBFileSystemProvider>userDataProvider); } else { logService.info('Using in-memory user data provider');", "commid": "vscode_pr_148927"}], "negative_passages": []}
{"query_id": "q-en-vscode-39a4725a0c341d8ddc71b304e8fcde4286286d236c54a060ae2386aa2e4ecbb8", "query": "The layout controls icons can be a bit of an eye sore when in the default state. One way to remedy this and to give a stronger indication of the state, we could swap icons based on their state. Would look something like this: https://user-\nthese icon are now in: - -", "positive_passages": [{"docid": "doc-en-vscode-b58800ba2a7c2aa0692ef325a8304bf89cbc541f3f033fca58b59af82390f230", "text": "public static readonly layoutStatusbar = new Codicon('layout-statusbar', { fontCharacter: 'ebf5' }); public static readonly layoutMenubar = new Codicon('layout-menubar', { fontCharacter: 'ebf6' }); public static readonly layoutCentered = new Codicon('layout-centered', { fontCharacter: 'ebf7' }); <ins> public static readonly layoutSidebarRightOff = new Codicon('layout-sidebar-right-off', { fontCharacter: 'ec00' }); public static readonly layoutPanelOff = new Codicon('layout-panel-off', { fontCharacter: 'ec01' }); public static readonly layoutSidebarLeftOff = new Codicon('layout-sidebar-left-off', { fontCharacter: 'ec02' }); </ins> public static readonly target = new Codicon('target', { fontCharacter: 'ebf8' }); public static readonly indent = new Codicon('indent', { fontCharacter: 'ebf9' }); public static readonly recordSmall = new Codicon('record-small', { fontCharacter: 'ebfa' });", "commid": "vscode_pr_149196"}], "negative_passages": []}
{"query_id": "q-en-vscode-5aa9783b069eb44359fd10e4cde8f2d02541ab9a59347957e5972f51697ae279", "query": "Many of these onDispose listeners get created:\nwe fixed this at one pt. !\nThey were in and\nhere's when we lost it\nwant to fix it since you're working on that PR?\nLet's hold off until it's done, this PR is complicated enough without merge problems\nit's a simple fix - literally adding to the conditional on line 218\nDid another review and haven't seen this issue since", "positive_passages": [{"docid": "doc-en-vscode-2b5420c92a4946e76b19a3bf9a3c1e925a81cd60873256d87aea1ebc2358a424", "text": "if (beforeCommandExecution && !this._placeholderDecoration) { this._placeholderDecoration = decoration; this._placeholderDecoration.onDispose(() => this._placeholderDecoration = undefined); <del> } else { </del> <ins> } else if (!this._decorations.get(decoration.marker.id)) { </ins> decoration.onDispose(() => this._decorations.delete(decoration.marker.id)); this._decorations.set(decoration.marker.id, {", "commid": "vscode_pr_149392"}], "negative_passages": []}
{"query_id": "q-en-vscode-b6cc1a8f1b83d4f46ea3c38401002ad8715f32f88cf4a12f6e1df31351ddbb79", "query": "Our presubmit tests started to fail consistently since our test setup picked up code 1.67.0 yesterday. Our test is basically doing first, run written with from after the extension tests succeed, run a check on the consistency between our file and documentation/settings info. After running the extension tests with 1.67.0, it looks like the second step that involves reading sees a differently formatted Actually, it's not only a differently formatted , but it includes a new property (, , ...) at the end. The test passes if I make the extension tests to use 1.66.2. We can work around by arranging our presubmit test order or rewriting our test logic to handle this. But, we want to understand what is going on behind the scene and why this modification is necessary. Thanks!\nthis looks suspicious...\nThis is designed and expected. It is the metadata VS Code stores per extension while installing that can be used later for other features like updating etc., So I would recommend your extension to handle this.\nthis has started breaking our extension's tests without warning, and moreover, the way it writes to it's modifying the whole file (looks like whitespace changes).\nhow have you gone about working around this breaking change? I'm trying to get a release out myself and am suddenly blocked\nWhelp, something else went on that broke my tests, but definitely noticed this too and will need to be careful about not committing the reformatted .\nSorry about the caused breakage. I am not sure what is your test doing, but I think it's not a good idea to depend on the content of , because VS Code uses it to write metadata about the extension. We do not remove any existing data but add more data.\nWhat's the recommended way of dealing with the property when testing an extension with set to a version-controlled source directory? Should the changes be committed or do extension authors have to take care of reverting it (which probably means parsing and clearing the property).\nI'm currently reverting it. Would love to know if we should do otherwise.\nReopening this to investigate if there is something changed on VS Code while running extension tests\nI wanted to re-report this issue, because it was previously misunderstood and closed. Of course I won\u2019t now this is open, but I already typed out reproduction steps. Perhaps they help. Steps to Reproduce: a git repository (this makes the issue more clear) a minimal VSCode extension with a test. The issue becomes more apparent if an existing extension name / publisher is used. .gitignore and commit we actually reproduce the bug. Run the extension tests Note that running tests has modified . Formatting is changed to use tabs, the final newline is stripped, and publisher metadata is to the file.\nTo verify: Create some hello world extension and open it's and change the and properties to an extension that already exists in Marketplace. Eg:Quit Code Insiders and Start from CLI with following arguments Make sure hello world extension's is not updated with property\nThis looks related to which didn't have anything to do with testing the extension, but only debugging it, and getting the same metadata written to an \"unsuspecting\" Will this fix handle this SO situation as well? The problem occurred very rarely so I couldn't give steps to reproduce, but I was only debugging and not running tests on the extension.\nYes\nI have learned more about my situation of getting this extra data when debugging an extension. It happens when the extension writes to the . I have a couple of extensions which allow the user to make settings that will be read and converted to commands. I files a separate issue:", "positive_passages": [{"docid": "doc-en-vscode-cac51cb5f0ad7c46fd2a86fee7d2d2fa77ddd2222b40fe8806d202d758513c9d", "text": "getTargetPlatform(): Promise<TargetPlatform>; <del> scanAllExtensions(systemScanOptions: ScanOptions, userScanOptions: ScanOptions): Promise<IScannedExtension[]>; </del> <ins> scanAllExtensions(systemScanOptions: ScanOptions, userScanOptions: ScanOptions, includeExtensionsUnderDev: boolean): Promise<IScannedExtension[]>; </ins> scanSystemExtensions(scanOptions: ScanOptions): Promise<IScannedExtension[]>; scanUserExtensions(scanOptions: ScanOptions): Promise<IScannedExtension[]>; scanExtensionsUnderDevelopment(scanOptions: ScanOptions, existingExtensions: IScannedExtension[]): Promise<IScannedExtension[]>;", "commid": "vscode_pr_158969"}], "negative_passages": []}
{"query_id": "q-en-vscode-b6cc1a8f1b83d4f46ea3c38401002ad8715f32f88cf4a12f6e1df31351ddbb79", "query": "Our presubmit tests started to fail consistently since our test setup picked up code 1.67.0 yesterday. Our test is basically doing first, run written with from after the extension tests succeed, run a check on the consistency between our file and documentation/settings info. After running the extension tests with 1.67.0, it looks like the second step that involves reading sees a differently formatted Actually, it's not only a differently formatted , but it includes a new property (, , ...) at the end. The test passes if I make the extension tests to use 1.66.2. We can work around by arranging our presubmit test order or rewriting our test logic to handle this. But, we want to understand what is going on behind the scene and why this modification is necessary. Thanks!\nthis looks suspicious...\nThis is designed and expected. It is the metadata VS Code stores per extension while installing that can be used later for other features like updating etc., So I would recommend your extension to handle this.\nthis has started breaking our extension's tests without warning, and moreover, the way it writes to it's modifying the whole file (looks like whitespace changes).\nhow have you gone about working around this breaking change? I'm trying to get a release out myself and am suddenly blocked\nWhelp, something else went on that broke my tests, but definitely noticed this too and will need to be careful about not committing the reformatted .\nSorry about the caused breakage. I am not sure what is your test doing, but I think it's not a good idea to depend on the content of , because VS Code uses it to write metadata about the extension. We do not remove any existing data but add more data.\nWhat's the recommended way of dealing with the property when testing an extension with set to a version-controlled source directory? Should the changes be committed or do extension authors have to take care of reverting it (which probably means parsing and clearing the property).\nI'm currently reverting it. Would love to know if we should do otherwise.\nReopening this to investigate if there is something changed on VS Code while running extension tests\nI wanted to re-report this issue, because it was previously misunderstood and closed. Of course I won\u2019t now this is open, but I already typed out reproduction steps. Perhaps they help. Steps to Reproduce: a git repository (this makes the issue more clear) a minimal VSCode extension with a test. The issue becomes more apparent if an existing extension name / publisher is used. .gitignore and commit we actually reproduce the bug. Run the extension tests Note that running tests has modified . Formatting is changed to use tabs, the final newline is stripped, and publisher metadata is to the file.\nTo verify: Create some hello world extension and open it's and change the and properties to an extension that already exists in Marketplace. Eg:Quit Code Insiders and Start from CLI with following arguments Make sure hello world extension's is not updated with property\nThis looks related to which didn't have anything to do with testing the extension, but only debugging it, and getting the same metadata written to an \"unsuspecting\" Will this fix handle this SO situation as well? The problem occurred very rarely so I couldn't give steps to reproduce, but I was only debugging and not running tests on the extension.\nYes\nI have learned more about my situation of getting this extra data when debugging an extension. It happens when the extension writes to the . I have a couple of extensions which allow the user to make settings that will be read and converted to commands. I files a separate issue:", "positive_passages": [{"docid": "doc-en-vscode-aa03121fb794f06a62a43b2b8b9bafe746287459430a6f8cde2b26bdaa1ffc5c", "text": "return this._targetPlatformPromise; } <del> async scanAllExtensions(systemScanOptions: ScanOptions, userScanOptions: ScanOptions): Promise<IScannedExtension[]> { </del> <ins> async scanAllExtensions(systemScanOptions: ScanOptions, userScanOptions: ScanOptions, includeExtensionsUnderDev: boolean): Promise<IScannedExtension[]> { </ins> const [system, user] = await Promise.all([ this.scanSystemExtensions(systemScanOptions), this.scanUserExtensions(userScanOptions), ]); <del> const development = await this.scanExtensionsUnderDevelopment(systemScanOptions, [...system, ...user]); </del> <ins> const development = includeExtensionsUnderDev ? await this.scanExtensionsUnderDevelopment(systemScanOptions, [...system, ...user]) : []; </ins> return this.dedupExtensions(system, user, development, await this.getTargetPlatform(), true); }", "commid": "vscode_pr_158969"}], "negative_passages": []}
{"query_id": "q-en-vscode-b6cc1a8f1b83d4f46ea3c38401002ad8715f32f88cf4a12f6e1df31351ddbb79", "query": "Our presubmit tests started to fail consistently since our test setup picked up code 1.67.0 yesterday. Our test is basically doing first, run written with from after the extension tests succeed, run a check on the consistency between our file and documentation/settings info. After running the extension tests with 1.67.0, it looks like the second step that involves reading sees a differently formatted Actually, it's not only a differently formatted , but it includes a new property (, , ...) at the end. The test passes if I make the extension tests to use 1.66.2. We can work around by arranging our presubmit test order or rewriting our test logic to handle this. But, we want to understand what is going on behind the scene and why this modification is necessary. Thanks!\nthis looks suspicious...\nThis is designed and expected. It is the metadata VS Code stores per extension while installing that can be used later for other features like updating etc., So I would recommend your extension to handle this.\nthis has started breaking our extension's tests without warning, and moreover, the way it writes to it's modifying the whole file (looks like whitespace changes).\nhow have you gone about working around this breaking change? I'm trying to get a release out myself and am suddenly blocked\nWhelp, something else went on that broke my tests, but definitely noticed this too and will need to be careful about not committing the reformatted .\nSorry about the caused breakage. I am not sure what is your test doing, but I think it's not a good idea to depend on the content of , because VS Code uses it to write metadata about the extension. We do not remove any existing data but add more data.\nWhat's the recommended way of dealing with the property when testing an extension with set to a version-controlled source directory? Should the changes be committed or do extension authors have to take care of reverting it (which probably means parsing and clearing the property).\nI'm currently reverting it. Would love to know if we should do otherwise.\nReopening this to investigate if there is something changed on VS Code while running extension tests\nI wanted to re-report this issue, because it was previously misunderstood and closed. Of course I won\u2019t now this is open, but I already typed out reproduction steps. Perhaps they help. Steps to Reproduce: a git repository (this makes the issue more clear) a minimal VSCode extension with a test. The issue becomes more apparent if an existing extension name / publisher is used. .gitignore and commit we actually reproduce the bug. Run the extension tests Note that running tests has modified . Formatting is changed to use tabs, the final newline is stripped, and publisher metadata is to the file.\nTo verify: Create some hello world extension and open it's and change the and properties to an extension that already exists in Marketplace. Eg:Quit Code Insiders and Start from CLI with following arguments Make sure hello world extension's is not updated with property\nThis looks related to which didn't have anything to do with testing the extension, but only debugging it, and getting the same metadata written to an \"unsuspecting\" Will this fix handle this SO situation as well? The problem occurred very rarely so I couldn't give steps to reproduce, but I was only debugging and not running tests on the extension.\nYes\nI have learned more about my situation of getting this extra data when debugging an extension. It happens when the extension writes to the . I have a couple of extensions which allow the user to make settings that will be read and converted to commands. I files a separate issue:", "positive_passages": [{"docid": "doc-en-vscode-12904f20072493b97ff6f14cb6fa67895825cdef54e5da85cfe7c6b62f51f610", "text": "const userScanOptions: ScanOptions = { includeInvalid: true, profileLocation }; let scannedExtensions: IScannedExtension[] = []; if (type === null || type === ExtensionType.System) { <del> scannedExtensions.push(...await this.extensionsScannerService.scanAllExtensions({ includeInvalid: true }, userScanOptions)); </del> <ins> scannedExtensions.push(...await this.extensionsScannerService.scanAllExtensions({ includeInvalid: true }, userScanOptions, false)); </ins> } else if (type === ExtensionType.User) { scannedExtensions.push(...await this.extensionsScannerService.scanUserExtensions(userScanOptions)); }", "commid": "vscode_pr_158969"}], "negative_passages": []}
{"query_id": "q-en-vscode-7cd1717f0adb959e353b65a36de95c3e195be26971f33c61434b4ab72bb4e51d", "query": "Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:\nActually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that \"You cannot rename this element\" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.\nI initially read the last part of the issue title as \u201cthanks, language service\u201d and thought the sarcasm was appropriate.\nI may steal that in the future :D\ncan you transfer this issue to VSCode if appropriate?\nDid this just start happening with the latest insiders?\nPossible introduced with\nYeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-469edf69b545b227b34eaa75f27426c41ce2062a504e30c27cc0172e57e4ae88", "text": "export default class TypeScriptServiceClient extends Disposable implements ITypeScriptServiceClient { private readonly pathSeparator: string; <ins> private readonly emptyAuthority = 'ts-nul-authority'; </ins> private readonly inMemoryResourcePrefix = '^'; private readonly workspaceState: vscode.Memento;", "commid": "vscode_pr_149125"}], "negative_passages": []}
{"query_id": "q-en-vscode-7cd1717f0adb959e353b65a36de95c3e195be26971f33c61434b4ab72bb4e51d", "query": "Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:\nActually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that \"You cannot rename this element\" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.\nI initially read the last part of the issue title as \u201cthanks, language service\u201d and thought the sarcasm was appropriate.\nI may steal that in the future :D\ncan you transfer this issue to VSCode if appropriate?\nDid this just start happening with the latest insiders?\nPossible introduced with\nYeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-cde8f4634d59ad9480fc6597f2c8cc81c6da11f248ca0714b40e7de2c9623331", "text": "{ return this.inMemoryResourcePrefix + '/' + resource.scheme <del> + '/' + resource.authority </del> <ins> + '/' + (resource.authority || this.emptyAuthority) </ins> + (resource.path.startsWith('/') ? resource.path : '/' + resource.path) + (resource.fragment ? '#' + resource.fragment : ''); }", "commid": "vscode_pr_149125"}], "negative_passages": []}
{"query_id": "q-en-vscode-7cd1717f0adb959e353b65a36de95c3e195be26971f33c61434b4ab72bb4e51d", "query": "Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:\nActually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that \"You cannot rename this element\" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.\nI initially read the last part of the issue title as \u201cthanks, language service\u201d and thought the sarcasm was appropriate.\nI may steal that in the future :D\ncan you transfer this issue to VSCode if appropriate?\nDid this just start happening with the latest insiders?\nPossible introduced with\nYeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-961702f063b902a051ef37f96f7e1f2033948e46b39ae89bdb8a83cd08193b5c", "text": "} if (filepath.startsWith(this.inMemoryResourcePrefix)) { <del> const parts = filepath.match(/^^/([^/]+)/(.+)$/); </del> <ins> const parts = filepath.match(/^^/([^/]+)/([^/]*)/(.+)$/); </ins> if (parts) { <del> const resource = vscode.Uri.parse(parts[1] + '://' + parts[2]); </del> <ins> const resource = vscode.Uri.parse(parts[1] + '://' + (parts[2] === this.emptyAuthority ? '' : parts[2]) + '/' + parts[3]); </ins> return this.bufferSyncSupport.toVsCodeResource(resource); } }", "commid": "vscode_pr_149125"}], "negative_passages": []}
{"query_id": "q-en-vscode-31ed2146dfe9e005e698767c65bc077a11108b4ce96372315ea4a4db037314fd", "query": "<img width=\"628\" alt=\"image\" src=\"https://user-\"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width=\"306\" alt=\"image\" src=\"https://user-\"\nThe \"Go to Review\" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?\nCatching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width=\"423\" alt=\"CleanShot 2022-04-18 at 09 09 03 src=\"https://user-\"\nThanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.\nVerified. I assume that Go to Review button is renamed to Start Review !\nThe Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.", "positive_passages": [{"docid": "doc-en-vscode-6265706ac384ae9b2ee8fbbcc036e2c5d4a74af73fb34ddf8bbdcadfd623863b", "text": "this._buttonElements.forEach(b => b.remove()); const groups = menu.getActions({ shouldForwardArgs: true }); <ins> let isPrimary: boolean = true; </ins> for (const group of groups) { const [, actions] = group; this._actions = actions; <del> actions.forEach(action => { const button = new Button(this.container); </del> <ins> for (const action of actions) { const button = new Button(this.container, { secondary: !isPrimary }); isPrimary = false; </ins> this._buttonElements.push(button.element); this._toDispose.add(button);", "commid": "vscode_pr_149159"}], "negative_passages": []}
{"query_id": "q-en-vscode-31ed2146dfe9e005e698767c65bc077a11108b4ce96372315ea4a4db037314fd", "query": "<img width=\"628\" alt=\"image\" src=\"https://user-\"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width=\"306\" alt=\"image\" src=\"https://user-\"\nThe \"Go to Review\" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?\nCatching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width=\"423\" alt=\"CleanShot 2022-04-18 at 09 09 03 src=\"https://user-\"\nThanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.\nVerified. I assume that Go to Review button is renamed to Start Review !\nThe Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.", "positive_passages": [{"docid": "doc-en-vscode-c28fb3aa6d4289adeffefcb23dcdc72e48c49d4f6f8034123a605e7adfec8b7d", "text": "button.enabled = action.enabled; button.label = action.label; <del> }); </del> <ins> } </ins> } }", "commid": "vscode_pr_149159"}], "negative_passages": []}
{"query_id": "q-en-vscode-31ed2146dfe9e005e698767c65bc077a11108b4ce96372315ea4a4db037314fd", "query": "<img width=\"628\" alt=\"image\" src=\"https://user-\"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width=\"306\" alt=\"image\" src=\"https://user-\"\nThe \"Go to Review\" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?\nCatching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width=\"423\" alt=\"CleanShot 2022-04-18 at 09 09 03 src=\"https://user-\"\nThanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.\nVerified. I assume that Go to Review button is renamed to Start Review !\nThe Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.", "positive_passages": [{"docid": "doc-en-vscode-2acc1c6c6e3dfd2b901852a00e778fb348be95410c2373b536132d4397e710a7", "text": "padding: 10px 0; } <del> .review-widget .body .edit-container .form-actions { display: flex; justify-content: flex-end; } </del> .review-widget .body .edit-textarea { height: 90px; margin: 5px 0 10px 0;", "commid": "vscode_pr_149159"}], "negative_passages": []}
{"query_id": "q-en-vscode-31ed2146dfe9e005e698767c65bc077a11108b4ce96372315ea4a4db037314fd", "query": "<img width=\"628\" alt=\"image\" src=\"https://user-\"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width=\"306\" alt=\"image\" src=\"https://user-\"\nThe \"Go to Review\" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?\nCatching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width=\"423\" alt=\"CleanShot 2022-04-18 at 09 09 03 src=\"https://user-\"\nThanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.\nVerified. I assume that Go to Review button is renamed to Start Review !\nThe Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.", "positive_passages": [{"docid": "doc-en-vscode-6f05de8dec5630a798c8407124e4bbac75bbd178834a3eecd21f284c4ced825f", "text": "margin-bottom: 5px; } <del> .review-widget .body .comment-form .monaco-text-button { </del> <ins> .review-widget .body .form-actions .monaco-text-button { </ins> float: right; }", "commid": "vscode_pr_149159"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-900724a6576ae9b662a4a86e66a109aa9c699e033a72398de935ed0625a34ddf", "text": "} } <del> async function runCell(accessor: ServicesAccessor, context: INotebookActionContext): Promise<void> { const editorGroupService = accessor.get(IEditorGroupsService); const group = editorGroupService.activeGroup; </del> <ins> async function runCell(editorGroupsService: IEditorGroupsService, context: INotebookActionContext): Promise<void> { const group = editorGroupsService.activeGroup; </ins> if (group) { if (group.activeEditor) {", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-5e84018ca5e195f028420ae8009d0fa0c975e12e69d112e9ce143d6aebeb3b33", "text": "} async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext | INotebookCellToolbarActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> if (context.ui) { await context.notebookEditor.focusNotebookCell(context.cell, 'container', { skipReveal: true }); } <del> return runCell(accessor, context); </del> <ins> return runCell(editorGroupsService, context); </ins> } });", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-5a07216f5daa1f3dc379535fc1e996330880d805cc9203561681c336bbba0438", "text": "} async runWithContext(accessor: ServicesAccessor, context: INotebookCommandContext | INotebookCellToolbarActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> if (context.ui) { await context.notebookEditor.focusNotebookCell(context.cell, 'container', { skipReveal: true }); } else {", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-2bb5fe77ad00dafab9d56ec1f30939e088b1550951896df7759e40301bdb915c", "text": "} } <del> await runCell(accessor, context); </del> <ins> await runCell(editorGroupsService, context); </ins> } });", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-39c3881d3147066d2796bc09024925e3e1772b7eba1e5416effcd1134a5c0828", "text": "} async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> const idx = context.notebookEditor.getCellIndex(context.cell); if (typeof idx !== 'number') { return;", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-09f707af2465c96e7bf1642b82f842e90f946a50b36439f56f6170a5887f2a56", "text": "} } <del> return runCell(accessor, context); </del> <ins> return runCell(editorGroupsService, context); </ins> } } });", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-8a2af520612c33b744f177057479a8438957a49bfbfd44c6c8eead8c37451908", "text": "} async runWithContext(accessor: ServicesAccessor, context: INotebookCellActionContext): Promise<void> { <ins> const editorGroupsService = accessor.get(IEditorGroupsService); </ins> const idx = context.notebookEditor.getCellIndex(context.cell); const languageService = accessor.get(ILanguageService); const newFocusMode = context.cell.focusMode === CellFocusMode.Editor ? 'editor' : 'container';", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-a85f47f55ad566a74deefde2d74d96054a86722f3f488c54bba2b6176f68dc3e", "query": "Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSnapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell\nI experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.\nSame here!\nSame.\nI was able to workaround this issue by using the command \"Notebook: Execute Cell\".\nsame\nVia the command palette? (Cmd/Ctrl+shift+p)?\nYep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.\nSame problem here too, thanks in advance for addressing!\nI fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.\nrun icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response\nHow can I activate the PR in Insiders?\nfix was already released for the VSC insiders build, update your installation\nwhen I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem", "positive_passages": [{"docid": "doc-en-vscode-b987e949b346351178de05fd757b9da86952d90d27fd9897c8813fbba7549385", "text": "if (context.cell.cellKind === CellKind.Markup) { context.cell.updateEditState(CellEditState.Preview, EXECUTE_CELL_INSERT_BELOW); } else { <del> runCell(accessor, context); </del> <ins> runCell(editorGroupsService, context); </ins> } } });", "commid": "vscode_pr_149298"}], "negative_passages": []}
{"query_id": "q-en-vscode-891709ebe6911a08cbd0113d977de7cafcb6b0c08f757110089c3849e75912df", "query": "Started seeing this yesterday: !\nThis seems to be related to my theme, probably same root cause as\nRepro for this is to set the following settings and try find in terminal:", "positive_passages": [{"docid": "doc-en-vscode-87a0064a3274e8a7081ab600f9cb609e256fb1b74305e05b7bf86faf987d591c", "text": "\"vscode-proxy-agent\": \"^0.12.0\", \"vscode-regexpp\": \"^3.1.0\", \"vscode-textmate\": \"7.0.1\", <del> \"xterm\": \"4.19.0-beta.47\", </del> <ins> \"xterm\": \"4.19.0-beta.49\", </ins> \"xterm-addon-search\": \"0.9.0-beta.37\", \"xterm-addon-serialize\": \"0.7.0-beta.12\", \"xterm-addon-unicode11\": \"0.4.0-beta.3\", \"xterm-addon-webgl\": \"0.12.0-beta.36\", <del> \"xterm-headless\": \"4.19.0-beta.47\", </del> <ins> \"xterm-headless\": \"4.19.0-beta.49\", </ins> \"yauzl\": \"^2.9.2\", \"yazl\": \"^2.4.3\" },", "commid": "vscode_pr_150045"}], "negative_passages": []}
{"query_id": "q-en-vscode-891709ebe6911a08cbd0113d977de7cafcb6b0c08f757110089c3849e75912df", "query": "Started seeing this yesterday: !\nThis seems to be related to my theme, probably same root cause as\nRepro for this is to set the following settings and try find in terminal:", "positive_passages": [{"docid": "doc-en-vscode-0dbdd63776128722025f61733c3ac588f441223c843064e0475913e4e1cdc23a", "text": "\"tas-client-umd\": \"0.1.5\", \"vscode-oniguruma\": \"1.6.1\", \"vscode-textmate\": \"7.0.1\", <del> \"xterm\": \"4.19.0-beta.47\", </del> <ins> \"xterm\": \"4.19.0-beta.49\", </ins> \"xterm-addon-search\": \"0.9.0-beta.37\", \"xterm-addon-unicode11\": \"0.4.0-beta.3\", \"xterm-addon-webgl\": \"0.12.0-beta.36\"", "commid": "vscode_pr_150045"}], "negative_passages": []}
{"query_id": "q-en-vscode-891709ebe6911a08cbd0113d977de7cafcb6b0c08f757110089c3849e75912df", "query": "Started seeing this yesterday: !\nThis seems to be related to my theme, probably same root cause as\nRepro for this is to set the following settings and try find in terminal:", "positive_passages": [{"docid": "doc-en-vscode-ac435fa8c2f150ac7641650dc438bc0ccd49ef41238db5fe9faef77a7cc4cddd", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1\" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm@4.19.0-beta.47: version \"4.19.0-beta.47\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.47.tgz#f5931201346a485e3bcb29d24e83583727e55707\" integrity sha512-c8EcCSWCHnFYNdRMTnJIpYTV9J2Ze7kdB1GhTcPO2ipMEsqaP/u6Ca8rgBWwV9HeEVfe4rGRqWW2qcSy4U9hMQ== </del> <ins> xterm@4.19.0-beta.49: version \"4.19.0-beta.49\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.49.tgz#96d0d748c97a2f0cfa4c6112bc4de8b0d5d559fe\" integrity sha512-qPhOeGtnB357mZOvfDckVlPDR7EDkSASQrB3aujhjgJlOiBBqcNRJcuSvF7v1DOho7xdEI9UQxiSiT5diHhMlg== </ins>", "commid": "vscode_pr_150045"}], "negative_passages": []}
{"query_id": "q-en-vscode-891709ebe6911a08cbd0113d977de7cafcb6b0c08f757110089c3849e75912df", "query": "Started seeing this yesterday: !\nThis seems to be related to my theme, probably same root cause as\nRepro for this is to set the following settings and try find in terminal:", "positive_passages": [{"docid": "doc-en-vscode-9c3ed7ab28b083064dc8e6791ef36a9bb7c591c7d385c27a46c1b060f18418f6", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1\" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.47: version \"4.19.0-beta.47\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.47.tgz#9d5af8145c42b9a6241a040bb244b877c149761b\" integrity sha512-chVTURPMNDEerQIsN4lIRotpXCfJsTHioZGQxDBNdktZO1gMXGvNxDjzsbsJg5ikLN5llz/HLDfXZrjCeb3elg== xterm@4.19.0-beta.47: version \"4.19.0-beta.47\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.47.tgz#f5931201346a485e3bcb29d24e83583727e55707\" integrity sha512-c8EcCSWCHnFYNdRMTnJIpYTV9J2Ze7kdB1GhTcPO2ipMEsqaP/u6Ca8rgBWwV9HeEVfe4rGRqWW2qcSy4U9hMQ== </del> <ins> xterm-headless@4.19.0-beta.49: version \"4.19.0-beta.49\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.49.tgz#8e4178620be9a9dee25a586ef992a6fc621a829a\" integrity sha512-uRnHpR2pv1MJPbE3sa7XbP6x0uHubAWVMbiD26e3a5ICtWJQVVpLojkA0t4qU7CoMX85pRL1rIclg9CKY0B0xA== xterm@4.19.0-beta.49: version \"4.19.0-beta.49\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.49.tgz#96d0d748c97a2f0cfa4c6112bc4de8b0d5d559fe\" integrity sha512-qPhOeGtnB357mZOvfDckVlPDR7EDkSASQrB3aujhjgJlOiBBqcNRJcuSvF7v1DOho7xdEI9UQxiSiT5diHhMlg== </ins> yallist@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_150045"}], "negative_passages": []}
{"query_id": "q-en-vscode-891709ebe6911a08cbd0113d977de7cafcb6b0c08f757110089c3849e75912df", "query": "Started seeing this yesterday: !\nThis seems to be related to my theme, probably same root cause as\nRepro for this is to set the following settings and try find in terminal:", "positive_passages": [{"docid": "doc-en-vscode-98dda5e34e8f6c15fbfe92f74439f5d0ac8fc7466d69cd37e441c8ecf6d2d7b6", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1\" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.47: version \"4.19.0-beta.47\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.47.tgz#9d5af8145c42b9a6241a040bb244b877c149761b\" integrity sha512-chVTURPMNDEerQIsN4lIRotpXCfJsTHioZGQxDBNdktZO1gMXGvNxDjzsbsJg5ikLN5llz/HLDfXZrjCeb3elg== xterm@4.19.0-beta.47: version \"4.19.0-beta.47\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.47.tgz#f5931201346a485e3bcb29d24e83583727e55707\" integrity sha512-c8EcCSWCHnFYNdRMTnJIpYTV9J2Ze7kdB1GhTcPO2ipMEsqaP/u6Ca8rgBWwV9HeEVfe4rGRqWW2qcSy4U9hMQ== </del> <ins> xterm-headless@4.19.0-beta.49: version \"4.19.0-beta.49\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.49.tgz#8e4178620be9a9dee25a586ef992a6fc621a829a\" integrity sha512-uRnHpR2pv1MJPbE3sa7XbP6x0uHubAWVMbiD26e3a5ICtWJQVVpLojkA0t4qU7CoMX85pRL1rIclg9CKY0B0xA== xterm@4.19.0-beta.49: version \"4.19.0-beta.49\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.49.tgz#96d0d748c97a2f0cfa4c6112bc4de8b0d5d559fe\" integrity sha512-qPhOeGtnB357mZOvfDckVlPDR7EDkSASQrB3aujhjgJlOiBBqcNRJcuSvF7v1DOho7xdEI9UQxiSiT5diHhMlg== </ins> y18n@^3.2.1: version \"3.2.2\"", "commid": "vscode_pr_150045"}], "negative_passages": []}
{"query_id": "q-en-vscode-8d8b074b9955e3a9d23386d38c4ec0dd14914bea01585fefe1561ea3eb22ebc9", "query": "insiders, new user data dir choose Light+ theme extensions viewlet, click on an extension Notice color contrast is off. The text can not be readable when an extension has selection and focus fyi !\nIt seems description color was introduced by Hence assigning to him.\nYeah looks like the new color isn't getting overridden in a focused/selected state. Thought I fixed this but I'll take a look", "positive_passages": [{"docid": "doc-en-vscode-3131a8110962fb13603852f248e787d46d0fc0ecbceaaf7b997641fd7ef7e570", "text": "color: var(--vscode-descriptionForeground); } <ins> .monaco-list-row.selected .extension-list-item > .details > .description{ color: unset; } </ins> .hc-black .extension-list-item > .details > .description, .hc-light .extension-list-item > .details > .description { color: unset;", "commid": "vscode_pr_150461"}], "negative_passages": []}
{"query_id": "q-en-vscode-12292fc211916cd321219bbc6f256940d22c15810d3e151e13fd7518dacf8217", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version:mac os monterey 12.3.1 Steps to Reproduce: to settings (command+,) for markdown drop <img width=\"719\" alt=\"Screen Shot 2022-05-20 at 11 55 58 AM\" src=\"https://user-\"\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nConfirmed on latest insiders Version: 1.68.0-insider Commit: Date: 2022-05-16T05:30:27.563Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin arm64 21.4.0 <img width=\"636\" alt=\"Screen Shot 2022-05-20 at 1 11 00 PM\" src=\"https://user-\"\nFixed as of\n<img width=\"967\" alt=\"image\" src=\"https://user-\"\nHey I see with the same fixes, already merged.\nYeah but it accidentally got reverted via This just brings your changes back in", "positive_passages": [{"docid": "doc-en-vscode-14c2a55c355b34599f4f36eef58dca3fad792523ddab0b694d3bd9168796c2f7", "text": "\"configuration.markdown.links.openLocation.currentGroup\": \"Open links in the active editor group.\", \"configuration.markdown.links.openLocation.beside\": \"Open links beside the active editor.\", \"configuration.markdown.suggest.paths.enabled.description\": \"Enable/disable path suggestions for markdown links\", <del> \"configuration.markdown.editor.drop.enabled\": \"Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbenck.experimental.editor.dropIntoEditor.enabled#`.\", </del> <ins> \"configuration.markdown.editor.drop.enabled\": \"Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbench.experimental.editor.dropIntoEditor.enabled#`.\", </ins> \"configuration.markdown.experimental.validate.enabled.description\": \"Enable/disable all error reporting in Markdown files.\", \"configuration.markdown.experimental.validate.referenceLinks.enabled.description\": \"Validate reference links in Markdown files, e.g. `[link][ref]`.  Requires enabling `#markdown.experimental.validate.enabled#`.\", \"configuration.markdown.experimental.validate.headerLinks.enabled.description\": \"Validate links to headers in Markdown files, e.g. `[link](#header)`. Requires enabling `#markdown.experimental.validate.enabled#`.\",", "commid": "vscode_pr_150042"}], "negative_passages": []}
{"query_id": "q-en-vscode-12292fc211916cd321219bbc6f256940d22c15810d3e151e13fd7518dacf8217", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version:mac os monterey 12.3.1 Steps to Reproduce: to settings (command+,) for markdown drop <img width=\"719\" alt=\"Screen Shot 2022-05-20 at 11 55 58 AM\" src=\"https://user-\"\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nConfirmed on latest insiders Version: 1.68.0-insider Commit: Date: 2022-05-16T05:30:27.563Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin arm64 21.4.0 <img width=\"636\" alt=\"Screen Shot 2022-05-20 at 1 11 00 PM\" src=\"https://user-\"\nFixed as of\n<img width=\"967\" alt=\"image\" src=\"https://user-\"\nHey I see with the same fixes, already merged.\nYeah but it accidentally got reverted via This just brings your changes back in", "positive_passages": [{"docid": "doc-en-vscode-3c3994a75e605a67853fe7a2520ff94bfe84096dc6341846e2f3132e619693e0", "text": "\"configuration.markdown.links.openLocation.currentGroup\": \"Open links in the active editor group.\", \"configuration.markdown.links.openLocation.beside\": \"Open links beside the active editor.\", \"configuration.markdown.suggest.paths.enabled.description\": \"Enable/disable path suggestions for markdown links\", <del> \"configuration.markdown.editor.drop.enabled\": \"Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbenck.experimental.editor.dropIntoEditor.enabled#`.\", </del> <ins> \"configuration.markdown.editor.drop.enabled\": \"Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbench.experimental.editor.dropIntoEditor.enabled#`.\", </ins> \"configuration.markdown.editor.pasteLinks.enabled\": \"Enable/disable pasting files into a Markdown editor inserts Markdown links.\", \"configuration.markdown.experimental.validate.enabled.description\": \"Enable/disable all error reporting in Markdown files.\", \"configuration.markdown.experimental.validate.referenceLinks.enabled.description\": \"Validate reference links in Markdown files, e.g. `[link][ref]`.  Requires enabling `#markdown.experimental.validate.enabled#`.\",", "commid": "vscode_pr_151108"}], "negative_passages": []}
{"query_id": "q-en-vscode-f6b7db2b91f75d881ca41460d2ea6429809ecc06fc2926c4c3c0e80bf9c89b79", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Love the new title control: ! My only problem is that I would often drag the window around by clicking and dragging the title bar. Since this takes up a large chunk of the title bar, I have less real estate to drag... but there's no reason the drag experience can't also apply to the area covered by the title control. Can the drag of the title control bubble up to the title bar so that dragging the window works?\nThere is a technical reason... Marking things as drag-region () swallows all events and you won't be able to click onto things anymore... I can try adding the style while dragging but it might not be possible <img width=\"113\" alt=\"Screenshot 2022-05-24 at 09 15 34\" src=\"https://user-\" that's more concerning here...\nYeah, I have tried to set the style during mouse down (with a delay) but that doesn't seem to have an effect Plan was to mark the element as app region drag when holding for 200ms\nrelated issue (which caused this)\nand more context - seems like a hard problem\nCan the top 1-2 pixels not be part of the drag element/target?\nyeah, it already should be like that, there is another PR in the works that increases the title bar height. with that merged, dragging be simpler again\nThe title bar height is now aligned with the height of editor tabs. This allows to drag the window when clicking on the space above/below the CC. https://user- That's the best I can do (and aligns with Slack etc). Set/unsetting the property while dragging isn't supported...\nTo verify: enable CC via make sure you can drag the app window with the regions above/below the CC (see )", "positive_passages": [{"docid": "doc-en-vscode-5d756c4bf9292bd92713edefdd03fb20bb8fabb5912d771f02e18ff23ada4583", "text": "}); } <del> MenuRegistry.appendMenuItem(MenuId.TitleMenu, { command: { id: NavigateBackwardsAction.ID, title: NavigateBackwardsAction.LABEL, icon: Codicon.arrowLeft } }); MenuRegistry.appendMenuItem(MenuId.TitleMenu, { command: { id: NavigateForwardAction.ID, title: NavigateForwardAction.LABEL, icon: Codicon.arrowRight } }); </del> <ins> MenuRegistry.appendMenuItem(MenuId.TitleMenu, { order: 1, command: { id: NavigateBackwardsAction.ID, title: NavigateBackwardsAction.LABEL, icon: Codicon.arrowLeft } }); MenuRegistry.appendMenuItem(MenuId.TitleMenu, { order: 2, command: { id: NavigateForwardAction.ID, title: NavigateForwardAction.LABEL, icon: Codicon.arrowRight } }); </ins> // Empty Editor Group Toolbar MenuRegistry.appendMenuItem(MenuId.EmptyEditorGroup, { command: { id: UNLOCK_GROUP_COMMAND_ID, title: localize('unlockGroupAction', \"Unlock Group\"), icon: Codicon.lock }, group: 'navigation', order: 10, when: ActiveEditorGroupLockedContext });", "commid": "vscode_pr_150255"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b5449b48164c461f9a59076b45138be4a7caf26057c3d68ff35f3907a1cf51d", "query": "I'm building a custom Insiders to test one of the changes. The Linux localization smoke test seems to be failing consistently Edit: This result is likely a false positive. I think I forgot to update the branch.", "positive_passages": [{"docid": "doc-en-vscode-4f00b880941978367c64e6ffba8cf33bdcf17a4fb8ef092f09c9a2f845dfba9e", "text": "// Shared before/after handling installAllHandlers(logger); <del> // skipped until translations are available https://github.com/microsoft/vscode/issues/150324 it.skip('starts with \"DE\" locale and verifies title and viewlets text is in German', async function () { </del> <ins> it('starts with \"DE\" locale and verifies title and viewlets text is in German', async function () { </ins> const app = this.app as Application; await app.workbench.extensions.openExtensionsViewlet();", "commid": "vscode_pr_153397"}], "negative_passages": []}
{"query_id": "q-en-vscode-ccecce1279b85eeabc523270163c39ae7e199d7f3d202dbef86486254533bf0d", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --! Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.2 OS Version: Windows 11 10.0. Build Steps to Reproduce: the new folder button in the explorer panel; the new folder \"**\", without the quotation marks; text from red dialog box under the folder name is now bold, except for \"The name \".\nProbably because of markdown\nThe text box doesn't turn red or bold, so considering that a success\nThe text box should still be red saying it's an invalid file name on windows. Just the text should not become bold\nI think the box is supposed to be red\nthe box did not turn red for me with a folder name of\nWas this on windows?\nno it's working for me on windows. it wasn't working on mac\n** just happens to be a valid file name on macOS , thanks for verifying!", "positive_passages": [{"docid": "doc-en-vscode-7d4ab017a1bf9f3a8c8ea10f83e08ce81402da194014ca2e6e749ed3b6252f84", "text": "// Check for invalid file name. if (names.some(folderName => !pathService.hasValidBasename(item.resource, os, folderName))) { <ins> // Escape * characters const escapedName = name.replace(/*/g, '*'); </ins> return { <del> content: nls.localize('invalidFileNameError', \"The name **{0}** is not valid as a file or folder name. Please choose a different name.\", trimLongName(name)), </del> <ins> content: nls.localize('invalidFileNameError', \"The name **{0}** is not valid as a file or folder name. Please choose a different name.\", trimLongName(escapedName)), </ins> severity: Severity.Error }; }", "commid": "vscode_pr_157108"}], "negative_passages": []}
{"query_id": "q-en-vscode-001fdf302ea99a38534c34c4593090a8e25eeddf7823e50a020fc5ed5f8413ae", "query": "Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?\nI'm taking this.\nI've just submitted the PR.\nLinks in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows\nI've just submitted another PR. Could you please check it?\nWith Insiders on , it still seems like nested links are getting detected: !\nLooks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix\nI'm still seeing on the latest Insiders on macOS.", "positive_passages": [{"docid": "doc-en-vscode-dd93a9914487cc0f1081ddddee63661aad891b533db71b699bf32b1551cfba22", "text": "/** * Matches `[text](link)` */ <del> const linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|([^s()]*?))+)s*(\"[^\"]*\"|'[^']*'|([^()]*))?s*)/g; </del> <ins> const linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]]|][^(])*])(s*)(([^s()]|([^s()]*?))+)s*(\"[^\"]*\"|'[^']*'|([^()]*))?s*)/g; </ins> /** * Matches `[text](<link>)` */ <del> const linkPatternAngle = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*<)(([^<>]|([^s()]*?))+)>s*(\"[^\"]*\"|'[^']*'|([^()]*))?s*)/g; </del> <ins> const linkPatternAngle = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]]|][^(])*])(s*<)(([^<>]|([^s()]*?))+)>s*(\"[^\"]*\"|'[^']*'|([^()]*))?s*)/g; </ins> /**", "commid": "vscode_pr_151610"}], "negative_passages": []}
{"query_id": "q-en-vscode-001fdf302ea99a38534c34c4593090a8e25eeddf7823e50a020fc5ed5f8413ae", "query": "Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?\nI'm taking this.\nI've just submitted the PR.\nLinks in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows\nI've just submitted another PR. Could you please check it?\nWith Insiders on , it still seems like nested links are getting detected: !\nLooks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix\nI'm still seeing on the latest Insiders on macOS.", "positive_passages": [{"docid": "doc-en-vscode-1b1af614609dfb00475e149cc3dc1a486b704cdabc8160d565aa0c3d586c122e", "text": "} }); <ins> test('Should ignore texts in brackets inside link title (#150921)', async () => { { const links = await getLinksForFile('[some [inner bracket pairs] in title](<link>)'); assertLinksEqual(links, [ new vscode.Range(0, 39, 0, 43), ]); } { const links = await getLinksForFile('[some [inner bracket pairs] in title](link)'); assertLinksEqual(links, [ new vscode.Range(0, 38, 0, 42) ]); } }); </ins> test('Should handle two links without space', async () => { const links = await getLinksForFile('a ([test](test)[test2](test2)) c'); assertLinksEqual(links, [", "commid": "vscode_pr_151610"}], "negative_passages": []}
{"query_id": "q-en-vscode-001fdf302ea99a38534c34c4593090a8e25eeddf7823e50a020fc5ed5f8413ae", "query": "Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?\nI'm taking this.\nI've just submitted the PR.\nLinks in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows\nI've just submitted another PR. Could you please check it?\nWith Insiders on , it still seems like nested links are getting detected: !\nLooks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix\nI'm still seeing on the latest Insiders on macOS.", "positive_passages": [{"docid": "doc-en-vscode-285dc653227adc9aebb60a10d0cfa492677909ab5a044d13fb7465170d2dd50b", "text": "private *getReferenceLinks(document: ITextDocument, noLinkRanges: NoLinkRanges): Iterable<MdLink> { const text = document.getText(); for (const match of text.matchAll(referenceLinkPattern)) { <del> const linkStart = document.positionAt(match.index ?? 0); </del> <ins> const linkStartOffset = (match.index ?? 0) + match[1].length; const linkStart = document.positionAt(linkStartOffset); </ins> if (noLinkRanges.contains(linkStart)) { continue; }", "commid": "vscode_pr_154819"}], "negative_passages": []}
{"query_id": "q-en-vscode-001fdf302ea99a38534c34c4593090a8e25eeddf7823e50a020fc5ed5f8413ae", "query": "Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?\nI'm taking this.\nI've just submitted the PR.\nLinks in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows\nI've just submitted another PR. Could you please check it?\nWith Insiders on , it still seems like nested links are getting detected: !\nLooks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix\nI'm still seeing on the latest Insiders on macOS.", "positive_passages": [{"docid": "doc-en-vscode-6f13d52b8a2de2d847a87cbc2ae49843e0aa4082710ba072bc2b201a58818219", "text": "let reference = match[4]; if (reference === '') { // [ref][], reference = match[3]; <del> const offset = ((match.index ?? 0) + match[1].length) + 1; </del> <ins> const offset = linkStartOffset + 1; </ins> hrefStart = document.positionAt(offset); hrefEnd = document.positionAt(offset + reference.length); } else if (reference) { // [text][ref] const pre = match[2]; <del> const offset = ((match.index ?? 0) + match[1].length) + pre.length; </del> <ins> const offset = linkStartOffset + pre.length; </ins> hrefStart = document.positionAt(offset); hrefEnd = document.positionAt(offset + reference.length); } else if (match[5]) { // [ref] reference = match[5]; <del> const offset = ((match.index ?? 0) + match[1].length) + 1; </del> <ins> const offset = linkStartOffset + 1; </ins> hrefStart = document.positionAt(offset); const line = getLine(document, hrefStart.line); // See if link looks like a checkbox", "commid": "vscode_pr_154819"}], "negative_passages": []}
{"query_id": "q-en-vscode-001fdf302ea99a38534c34c4593090a8e25eeddf7823e50a020fc5ed5f8413ae", "query": "Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?\nI'm taking this.\nI've just submitted the PR.\nLinks in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows\nI've just submitted another PR. Could you please check it?\nWith Insiders on , it still seems like nested links are getting detected: !\nLooks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix\nI'm still seeing on the latest Insiders on macOS.", "positive_passages": [{"docid": "doc-en-vscode-ccaa8e1173ec008e6edb8b5033ce5d1039eb0391e8e697d21475afed5a82cc8c", "text": "continue; } <del> const linkEnd = linkStart.translate(0, match[0].length); </del> <ins> const linkEnd = linkStart.translate(0, match[0].length - match[1].length); </ins> yield { kind: 'link', source: {", "commid": "vscode_pr_154819"}], "negative_passages": []}
{"query_id": "q-en-vscode-001fdf302ea99a38534c34c4593090a8e25eeddf7823e50a020fc5ed5f8413ae", "query": "Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?\nI'm taking this.\nI've just submitted the PR.\nLinks in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows\nI've just submitted another PR. Could you please check it?\nWith Insiders on , it still seems like nested links are getting detected: !\nLooks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix\nI'm still seeing on the latest Insiders on macOS.", "positive_passages": [{"docid": "doc-en-vscode-ec10242934a474eb8d2699b536853e6215ea6e0376b18761665d6c49228e6fd1", "text": "new vscode.Range(0, 35, 0, 39), ]); } <ins> { const links = await getLinksForFile(joinLines( `# h`, `[[a]](http://example.com)`, )); assertLinksEqual(links, [ new vscode.Range(1, 6, 1, 24), ]); } </ins> }); test('Should handle two links without space', async () => {", "commid": "vscode_pr_154819"}], "negative_passages": []}
{"query_id": "q-en-vscode-c3100f3c8ed39e8ff3216ef4ff13d5d441566d38fb2b310e40b7897a08b11b11", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce:\nOur C/C++ team has verified that our extension is correctly published to the marketplace with the correct binary -- our guess is that there is some VS Code or marketplace bug that is causing the wrong vsix to sometimes be installed.\nUsers are able to download/install our vsix manually from or so the bug appears to be with VS Code and/or the Remote WSL extension.\ncan you reproduce this problem? If yes can you file a new issue with reproducable steps? The issue is not 100% clear to us from this description. Thank you\nOur C/C++ team has not been able to reproduce the problem yet. I'm guessing there's some random or unusual requirement, maybe involving a previously cached installation when an upgrade from version 1.9.8 to 1.10.5 of our extension occurs. I'm not familiar with what sort of install logging would be important for users who repro it to get, which is why I was thinking the issue should be tracked by VS Code (or the Remote extension or marketplace) and not our team. I'm aware of 4 user reports -- there could be more reported against VS Code that I'm not aware of. We don't believe our extension's warning about the incorrect binary is the root issue, and just a symptom of some other system downloading the incorrect vsix for the user's OS (we ship 10 different vsix's).\nIf you can let us know what the remote OS is and what the TargetPlatform property is set to in the file that could help us identify the problem.\nyes getting more details here would be helpful. If you get a chance to repro the problem do let us know. Appreciate it!\nA user reports that our .vsixmanifest file shows TargetPlatform=\"win32-x64\" on a Linux-x64 remote machine (with Win-x64 host), which indicates that VS Code or the Remote extension or marketplace is somehow causing a download/install of the host platform's vsix instead of the remote one. I'm not familiar with what the next steps are in terms of diagnostics, but it seems like at least there should be an open VS Code (or Remote extension) bug to track this, since currently there are just 4 or so closed issues. See\nI'm the reporter of This is not the case for me as I have installed the C/C++ extension for the first time. I don't usually use VS Code but just tried it to reproduce another problem reported by a user. Also, as far as I remember, this is the first time for me to connect to a remote workspace using VS Code. Something that might be related is the version of VS Code. I think I have originally installed VS Code back in October 2021. After that, I hadn't updated the VS Code for a long time because I'm not using it. This time, I think I first tried to install the C/C++ extension with the old version of VS Code and failed. After that, I updated VS Code to the latest version from the main menu of the VS Code, which didn't solve the problem. I'm not sure if this is really related, but is it unsupported to update VS Code from an old version (8-month old) in a single update (i.e., without any intermediate versions)? For example, some migration steps to update the cache or database format would be skipped? We might be able to ask other reporters about their situations? (), (), (this issue): How's the situation? Did you experience the problem in the remote workspace such as in WSL? Have you recently updated VS Code? When have you updated VS Code previously?\nI am using the VS code(version 1.67) in Ubuntu 16.04 LTS (64 bit OS) which is hosted VM in Oracle VM virtual box. While trying to install C/C++ extension in the VS code, it was not proceeding and VS code suggested to download it from the website and install it via vsix. So, I have done the same. The installation of extension was successful but later during debugging, it has mentioned that wrong/incompatible binaries. please let me know if anymore information is required.\nI was not using remote workspace WSL. I am just trying to use VS code for client side code at my local VM.\ncc\nYour issue might be different? You installed the Linux x64 vsix, right? What is the TargetPlatform property set to in the .vscode[-insiders]/extensions/ms-vscode.cpptools-[version][os-description]/.vsixmanifest file? It should say \"linux-x64\". What version of the C/C++ extension are you installing? Our team is able to debug with the Linux x64 vsix so we don't know what could be going wrong yet.\nSorry that I am late to the party. It would be great if I can get summary of the issue? Does it happen to be reproducible?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nI have been thinking that you have checked the linked issues, but let me comment in case you haven't noticed them. I have already described the details about my situation in my initial report If needed, I can just copy and paste the comment to here. Nevertheless, I can answer additional questions about my situation if any. We may also find some information by the OP of this issue in\nMay I know if you have downloaded the VSIX that is compatible to the platform you are using? !\nIt's not me. The above comment is from In my case, I initially tried to install the extension from a VS Code client in Win 10 opened for the remote workspace (Ubuntu 20.04 / WSL2), which fails with the message of incompatible binaries. After the suggestion in , I have downloaded the VSIX from and installed it in the remote, which was successful unlike the case of I'm not sure which version has downloaded. !\nThe problem is, as I have reported in , VS Code seems to wrongly download the VSIX of in Ubuntu 20.04/WSL2 instead of the VSIX of . I have tried several times VS Code's install button with different configurations for both VS Code and VS Code Insiders, but all failed in the same way.\nGot it. Thanks for update. Can you please share us with a gif/video of what you are doing so that we can understand more about the issue? Can you please share us with the following logs after reproducing the issue? F1 Open View... Log (Window) F1 Open View... Log (Remote)\nI tried to upload it to here but couldn't do it due to the size limit. I have instead uploaded it to YouTube: Log (Window) I cannot find such a view. Instead, I see and : Log (Remote Server) Log (Remote Extension Host)\nWhich version of VS Code are you using? Instead of downloading from the installed section, can you please try searching for the extension, say by typing c++ in the search input and install? Does it work if you uninstall the extension and install again?\nAs I have reported in , I have confirmed the behavior in and . Further details are found in As it does not seem to reproduce in every environment, I guess some other factors in my environment causes the problem.\nI now noticed these additional comments. I'll try them when I get back home.\nThis installs the correct version of the extension. What is the correct way to uninstall the extension from the remote? (a) As explained in , I have already tried many times removing the remote extension---by deleting the directory as suggested in ---and installing it again. But they didn't change anything.(b) When I select the C/C++ extension from the installed section and press the [Unintall] button (see below), the remote extension is still located under , but the local extension instead seems to be uninstalled. ! (c) Also, when I type in the search input, select the C/C++ extension, and press the [Uninstall] button (see below), the remote extension is still there, and the local extension is instead uninstalled. !\nSo it means you are getting incompatible C++ extension when you use the button ? In both above screenshots, pressing Uninstall will uninstall locally as the extension seems to be installed locally. So, please try pressing uninstall button and install the extension again?\nYes. I had already tried that many times. The result doesn't change; It again installs an incompatible version as far as I use the button .\nCan you please provide following logs while trying this? Enable log level to trace - F1 Set Log Level Share F1 Open View... Log (Remote) Share F1 Open View... Log (Window)\nHere, I attach the logs: This time, (1) I first attempted to install the extension by pressing . (2) Then reopen the extension page, press and reloaded the VS Code. (3) Then, I again attempted to install the extension from the button. In the zip archive, the following files are included: --- This includes the log of in step (1) described above. --- This includes the log of in step (1). --- This includes the log of in step (3). --- This includes the log of in step (3). --- This includes the log of in step (3).\nThanks for the logs and I think I know the root cause of this issue. It seems in your case the extension is being copied from local client (Windows) to remote (WSL) and hence the bits are being incompatible. This happens if VS Code cannot find a matching installed extension in the Marketplace. In this case, VS Code falls back to copy the extension. Fixed it as follows: Before using the fallback to copy Try again to get the matching extension from the Marketplace In the fallback check if the local extension is compatible with the remote platform. This fix does not covers if you have manually installed an extension that does not exist in the Marketplace and is platform specific.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-d292bdcec8bcf94bde6b3e2b6702e656d84c7b1a9eceae663d0592e8d1db6741", "text": "import { dispose } from 'vs/base/common/lifecycle'; import { IExtension, ExtensionState, IExtensionsWorkbenchService, VIEWLET_ID, IExtensionsViewPaneContainer, IExtensionContainer, TOGGLE_IGNORE_EXTENSION_ACTION_ID, SELECT_INSTALL_VSIX_EXTENSION_COMMAND_ID, THEME_ACTIONS_GROUP, INSTALL_ACTIONS_GROUP } from 'vs/workbench/contrib/extensions/common/extensions'; import { ExtensionsConfigurationInitialContent } from 'vs/workbench/contrib/extensions/common/extensionsFileTemplate'; <del> import { IGalleryExtension, IExtensionGalleryService, ILocalExtension, InstallOptions, InstallOperation, TargetPlatformToString, ExtensionManagementErrorCode } from 'vs/platform/extensionManagement/common/extensionManagement'; </del> <ins> import { IGalleryExtension, IExtensionGalleryService, ILocalExtension, InstallOptions, InstallOperation, TargetPlatformToString, ExtensionManagementErrorCode, isTargetPlatformCompatible } from 'vs/platform/extensionManagement/common/extensionManagement'; </ins> import { IWorkbenchExtensionEnablementService, EnablementState, IExtensionManagementServerService, IExtensionManagementServer, IWorkbenchExtensionManagementService } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; import { ExtensionRecommendationReason, IExtensionIgnoredRecommendationsService, IExtensionRecommendationsService } from 'vs/workbench/services/extensionRecommendations/common/extensionRecommendations'; import { areSameExtensions, getExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil';", "commid": "vscode_pr_154936"}], "negative_passages": []}
{"query_id": "q-en-vscode-c3100f3c8ed39e8ff3216ef4ff13d5d441566d38fb2b310e40b7897a08b11b11", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce:\nOur C/C++ team has verified that our extension is correctly published to the marketplace with the correct binary -- our guess is that there is some VS Code or marketplace bug that is causing the wrong vsix to sometimes be installed.\nUsers are able to download/install our vsix manually from or so the bug appears to be with VS Code and/or the Remote WSL extension.\ncan you reproduce this problem? If yes can you file a new issue with reproducable steps? The issue is not 100% clear to us from this description. Thank you\nOur C/C++ team has not been able to reproduce the problem yet. I'm guessing there's some random or unusual requirement, maybe involving a previously cached installation when an upgrade from version 1.9.8 to 1.10.5 of our extension occurs. I'm not familiar with what sort of install logging would be important for users who repro it to get, which is why I was thinking the issue should be tracked by VS Code (or the Remote extension or marketplace) and not our team. I'm aware of 4 user reports -- there could be more reported against VS Code that I'm not aware of. We don't believe our extension's warning about the incorrect binary is the root issue, and just a symptom of some other system downloading the incorrect vsix for the user's OS (we ship 10 different vsix's).\nIf you can let us know what the remote OS is and what the TargetPlatform property is set to in the file that could help us identify the problem.\nyes getting more details here would be helpful. If you get a chance to repro the problem do let us know. Appreciate it!\nA user reports that our .vsixmanifest file shows TargetPlatform=\"win32-x64\" on a Linux-x64 remote machine (with Win-x64 host), which indicates that VS Code or the Remote extension or marketplace is somehow causing a download/install of the host platform's vsix instead of the remote one. I'm not familiar with what the next steps are in terms of diagnostics, but it seems like at least there should be an open VS Code (or Remote extension) bug to track this, since currently there are just 4 or so closed issues. See\nI'm the reporter of This is not the case for me as I have installed the C/C++ extension for the first time. I don't usually use VS Code but just tried it to reproduce another problem reported by a user. Also, as far as I remember, this is the first time for me to connect to a remote workspace using VS Code. Something that might be related is the version of VS Code. I think I have originally installed VS Code back in October 2021. After that, I hadn't updated the VS Code for a long time because I'm not using it. This time, I think I first tried to install the C/C++ extension with the old version of VS Code and failed. After that, I updated VS Code to the latest version from the main menu of the VS Code, which didn't solve the problem. I'm not sure if this is really related, but is it unsupported to update VS Code from an old version (8-month old) in a single update (i.e., without any intermediate versions)? For example, some migration steps to update the cache or database format would be skipped? We might be able to ask other reporters about their situations? (), (), (this issue): How's the situation? Did you experience the problem in the remote workspace such as in WSL? Have you recently updated VS Code? When have you updated VS Code previously?\nI am using the VS code(version 1.67) in Ubuntu 16.04 LTS (64 bit OS) which is hosted VM in Oracle VM virtual box. While trying to install C/C++ extension in the VS code, it was not proceeding and VS code suggested to download it from the website and install it via vsix. So, I have done the same. The installation of extension was successful but later during debugging, it has mentioned that wrong/incompatible binaries. please let me know if anymore information is required.\nI was not using remote workspace WSL. I am just trying to use VS code for client side code at my local VM.\ncc\nYour issue might be different? You installed the Linux x64 vsix, right? What is the TargetPlatform property set to in the .vscode[-insiders]/extensions/ms-vscode.cpptools-[version][os-description]/.vsixmanifest file? It should say \"linux-x64\". What version of the C/C++ extension are you installing? Our team is able to debug with the Linux x64 vsix so we don't know what could be going wrong yet.\nSorry that I am late to the party. It would be great if I can get summary of the issue? Does it happen to be reproducible?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nI have been thinking that you have checked the linked issues, but let me comment in case you haven't noticed them. I have already described the details about my situation in my initial report If needed, I can just copy and paste the comment to here. Nevertheless, I can answer additional questions about my situation if any. We may also find some information by the OP of this issue in\nMay I know if you have downloaded the VSIX that is compatible to the platform you are using? !\nIt's not me. The above comment is from In my case, I initially tried to install the extension from a VS Code client in Win 10 opened for the remote workspace (Ubuntu 20.04 / WSL2), which fails with the message of incompatible binaries. After the suggestion in , I have downloaded the VSIX from and installed it in the remote, which was successful unlike the case of I'm not sure which version has downloaded. !\nThe problem is, as I have reported in , VS Code seems to wrongly download the VSIX of in Ubuntu 20.04/WSL2 instead of the VSIX of . I have tried several times VS Code's install button with different configurations for both VS Code and VS Code Insiders, but all failed in the same way.\nGot it. Thanks for update. Can you please share us with a gif/video of what you are doing so that we can understand more about the issue? Can you please share us with the following logs after reproducing the issue? F1 Open View... Log (Window) F1 Open View... Log (Remote)\nI tried to upload it to here but couldn't do it due to the size limit. I have instead uploaded it to YouTube: Log (Window) I cannot find such a view. Instead, I see and : Log (Remote Server) Log (Remote Extension Host)\nWhich version of VS Code are you using? Instead of downloading from the installed section, can you please try searching for the extension, say by typing c++ in the search input and install? Does it work if you uninstall the extension and install again?\nAs I have reported in , I have confirmed the behavior in and . Further details are found in As it does not seem to reproduce in every environment, I guess some other factors in my environment causes the problem.\nI now noticed these additional comments. I'll try them when I get back home.\nThis installs the correct version of the extension. What is the correct way to uninstall the extension from the remote? (a) As explained in , I have already tried many times removing the remote extension---by deleting the directory as suggested in ---and installing it again. But they didn't change anything.(b) When I select the C/C++ extension from the installed section and press the [Unintall] button (see below), the remote extension is still located under , but the local extension instead seems to be uninstalled. ! (c) Also, when I type in the search input, select the C/C++ extension, and press the [Uninstall] button (see below), the remote extension is still there, and the local extension is instead uninstalled. !\nSo it means you are getting incompatible C++ extension when you use the button ? In both above screenshots, pressing Uninstall will uninstall locally as the extension seems to be installed locally. So, please try pressing uninstall button and install the extension again?\nYes. I had already tried that many times. The result doesn't change; It again installs an incompatible version as far as I use the button .\nCan you please provide following logs while trying this? Enable log level to trace - F1 Set Log Level Share F1 Open View... Log (Remote) Share F1 Open View... Log (Window)\nHere, I attach the logs: This time, (1) I first attempted to install the extension by pressing . (2) Then reopen the extension page, press and reloaded the VS Code. (3) Then, I again attempted to install the extension from the button. In the zip archive, the following files are included: --- This includes the log of in step (1) described above. --- This includes the log of in step (1). --- This includes the log of in step (3). --- This includes the log of in step (3). --- This includes the log of in step (3).\nThanks for the logs and I think I know the root cause of this issue. It seems in your case the extension is being copied from local client (Windows) to remote (WSL) and hence the bits are being incompatible. This happens if VS Code cannot find a matching installed extension in the Marketplace. In this case, VS Code falls back to copy the extension. Fixed it as follows: Before using the fallback to copy Try again to get the matching extension from the Marketplace In the fallback check if the local extension is compatible with the remote platform. This fix does not covers if you have manually installed an extension that does not exist in the Marketplace and is platform specific.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-4ca8cc8cb6abe6378320419038e4d26e44cec68e43e43e04c99ac014ce8ef51e", "text": "@IExtensionsWorkbenchService private readonly extensionsWorkbenchService: IExtensionsWorkbenchService, @IExtensionManagementServerService protected readonly extensionManagementServerService: IExtensionManagementServerService, @IExtensionManifestPropertiesService private readonly extensionManifestPropertiesService: IExtensionManifestPropertiesService, <ins> @IExtensionGalleryService private readonly extensionGalleryService: IExtensionGalleryService, </ins> ) { super(id, InstallInOtherServerAction.INSTALL_LABEL, InstallInOtherServerAction.Class, false); this.update();", "commid": "vscode_pr_154936"}], "negative_passages": []}
{"query_id": "q-en-vscode-c3100f3c8ed39e8ff3216ef4ff13d5d441566d38fb2b310e40b7897a08b11b11", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce:\nOur C/C++ team has verified that our extension is correctly published to the marketplace with the correct binary -- our guess is that there is some VS Code or marketplace bug that is causing the wrong vsix to sometimes be installed.\nUsers are able to download/install our vsix manually from or so the bug appears to be with VS Code and/or the Remote WSL extension.\ncan you reproduce this problem? If yes can you file a new issue with reproducable steps? The issue is not 100% clear to us from this description. Thank you\nOur C/C++ team has not been able to reproduce the problem yet. I'm guessing there's some random or unusual requirement, maybe involving a previously cached installation when an upgrade from version 1.9.8 to 1.10.5 of our extension occurs. I'm not familiar with what sort of install logging would be important for users who repro it to get, which is why I was thinking the issue should be tracked by VS Code (or the Remote extension or marketplace) and not our team. I'm aware of 4 user reports -- there could be more reported against VS Code that I'm not aware of. We don't believe our extension's warning about the incorrect binary is the root issue, and just a symptom of some other system downloading the incorrect vsix for the user's OS (we ship 10 different vsix's).\nIf you can let us know what the remote OS is and what the TargetPlatform property is set to in the file that could help us identify the problem.\nyes getting more details here would be helpful. If you get a chance to repro the problem do let us know. Appreciate it!\nA user reports that our .vsixmanifest file shows TargetPlatform=\"win32-x64\" on a Linux-x64 remote machine (with Win-x64 host), which indicates that VS Code or the Remote extension or marketplace is somehow causing a download/install of the host platform's vsix instead of the remote one. I'm not familiar with what the next steps are in terms of diagnostics, but it seems like at least there should be an open VS Code (or Remote extension) bug to track this, since currently there are just 4 or so closed issues. See\nI'm the reporter of This is not the case for me as I have installed the C/C++ extension for the first time. I don't usually use VS Code but just tried it to reproduce another problem reported by a user. Also, as far as I remember, this is the first time for me to connect to a remote workspace using VS Code. Something that might be related is the version of VS Code. I think I have originally installed VS Code back in October 2021. After that, I hadn't updated the VS Code for a long time because I'm not using it. This time, I think I first tried to install the C/C++ extension with the old version of VS Code and failed. After that, I updated VS Code to the latest version from the main menu of the VS Code, which didn't solve the problem. I'm not sure if this is really related, but is it unsupported to update VS Code from an old version (8-month old) in a single update (i.e., without any intermediate versions)? For example, some migration steps to update the cache or database format would be skipped? We might be able to ask other reporters about their situations? (), (), (this issue): How's the situation? Did you experience the problem in the remote workspace such as in WSL? Have you recently updated VS Code? When have you updated VS Code previously?\nI am using the VS code(version 1.67) in Ubuntu 16.04 LTS (64 bit OS) which is hosted VM in Oracle VM virtual box. While trying to install C/C++ extension in the VS code, it was not proceeding and VS code suggested to download it from the website and install it via vsix. So, I have done the same. The installation of extension was successful but later during debugging, it has mentioned that wrong/incompatible binaries. please let me know if anymore information is required.\nI was not using remote workspace WSL. I am just trying to use VS code for client side code at my local VM.\ncc\nYour issue might be different? You installed the Linux x64 vsix, right? What is the TargetPlatform property set to in the .vscode[-insiders]/extensions/ms-vscode.cpptools-[version][os-description]/.vsixmanifest file? It should say \"linux-x64\". What version of the C/C++ extension are you installing? Our team is able to debug with the Linux x64 vsix so we don't know what could be going wrong yet.\nSorry that I am late to the party. It would be great if I can get summary of the issue? Does it happen to be reproducible?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nI have been thinking that you have checked the linked issues, but let me comment in case you haven't noticed them. I have already described the details about my situation in my initial report If needed, I can just copy and paste the comment to here. Nevertheless, I can answer additional questions about my situation if any. We may also find some information by the OP of this issue in\nMay I know if you have downloaded the VSIX that is compatible to the platform you are using? !\nIt's not me. The above comment is from In my case, I initially tried to install the extension from a VS Code client in Win 10 opened for the remote workspace (Ubuntu 20.04 / WSL2), which fails with the message of incompatible binaries. After the suggestion in , I have downloaded the VSIX from and installed it in the remote, which was successful unlike the case of I'm not sure which version has downloaded. !\nThe problem is, as I have reported in , VS Code seems to wrongly download the VSIX of in Ubuntu 20.04/WSL2 instead of the VSIX of . I have tried several times VS Code's install button with different configurations for both VS Code and VS Code Insiders, but all failed in the same way.\nGot it. Thanks for update. Can you please share us with a gif/video of what you are doing so that we can understand more about the issue? Can you please share us with the following logs after reproducing the issue? F1 Open View... Log (Window) F1 Open View... Log (Remote)\nI tried to upload it to here but couldn't do it due to the size limit. I have instead uploaded it to YouTube: Log (Window) I cannot find such a view. Instead, I see and : Log (Remote Server) Log (Remote Extension Host)\nWhich version of VS Code are you using? Instead of downloading from the installed section, can you please try searching for the extension, say by typing c++ in the search input and install? Does it work if you uninstall the extension and install again?\nAs I have reported in , I have confirmed the behavior in and . Further details are found in As it does not seem to reproduce in every environment, I guess some other factors in my environment causes the problem.\nI now noticed these additional comments. I'll try them when I get back home.\nThis installs the correct version of the extension. What is the correct way to uninstall the extension from the remote? (a) As explained in , I have already tried many times removing the remote extension---by deleting the directory as suggested in ---and installing it again. But they didn't change anything.(b) When I select the C/C++ extension from the installed section and press the [Unintall] button (see below), the remote extension is still located under , but the local extension instead seems to be uninstalled. ! (c) Also, when I type in the search input, select the C/C++ extension, and press the [Uninstall] button (see below), the remote extension is still there, and the local extension is instead uninstalled. !\nSo it means you are getting incompatible C++ extension when you use the button ? In both above screenshots, pressing Uninstall will uninstall locally as the extension seems to be installed locally. So, please try pressing uninstall button and install the extension again?\nYes. I had already tried that many times. The result doesn't change; It again installs an incompatible version as far as I use the button .\nCan you please provide following logs while trying this? Enable log level to trace - F1 Set Log Level Share F1 Open View... Log (Remote) Share F1 Open View... Log (Window)\nHere, I attach the logs: This time, (1) I first attempted to install the extension by pressing . (2) Then reopen the extension page, press and reloaded the VS Code. (3) Then, I again attempted to install the extension from the button. In the zip archive, the following files are included: --- This includes the log of in step (1) described above. --- This includes the log of in step (1). --- This includes the log of in step (3). --- This includes the log of in step (3). --- This includes the log of in step (3).\nThanks for the logs and I think I know the root cause of this issue. It seems in your case the extension is being copied from local client (Windows) to remote (WSL) and hence the bits are being incompatible. This happens if VS Code cannot find a matching installed extension in the Marketplace. In this case, VS Code falls back to copy the extension. Fixed it as follows: Before using the fallback to copy Try again to get the matching extension from the Marketplace In the fallback check if the local extension is compatible with the remote platform. This fix does not covers if you have manually installed an extension that does not exist in the Marketplace and is platform specific.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-6a975e8c99af9ab5505a6d9539a487ac60892cbe01bd02b011ee63ac4689ed74", "text": "} override async run(): Promise<void> { <del> if (!this.extension) { </del> <ins> if (!this.extension?.local) { </ins> return; } <del> if (this.server) { this.extensionsWorkbenchService.open(this.extension); alert(localize('installExtensionStart', \"Installing extension {0} started. An editor is now open with more details on this extension\", this.extension.displayName)); if (this.extension.gallery) { await this.server.extensionManagementService.installFromGallery(this.extension.gallery, { installPreReleaseVersion: this.extension.local?.preRelease }); } else { const vsix = await this.extension.server!.extensionManagementService.zip(this.extension.local!); await this.server.extensionManagementService.install(vsix); } </del> <ins> if (!this.extension?.server) { return; } if (!this.server) { return; } this.extensionsWorkbenchService.open(this.extension); alert(localize('installExtensionStart', \"Installing extension {0} started. An editor is now open with more details on this extension\", this.extension.displayName)); const gallery = this.extension.gallery ?? (this.extensionGalleryService.isEnabled() && (await this.extensionGalleryService.getExtensions([this.extension.identifier], CancellationToken.None))[0]); if (gallery) { await this.server.extensionManagementService.installFromGallery(gallery, { installPreReleaseVersion: this.extension.local.preRelease }); return; } const targetPlatform = await this.server.extensionManagementService.getTargetPlatform(); if (!isTargetPlatformCompatible(this.extension.local.targetPlatform, [this.extension.local.targetPlatform], targetPlatform)) { throw new Error(localize('incompatible', \"Can't install '{0}' extension because it is not compatible.\", this.extension.identifier.id)); </ins> } <ins> const vsix = await this.extension.server.extensionManagementService.zip(this.extension.local); await this.server.extensionManagementService.install(vsix); </ins> } protected abstract getInstallLabel(): string;", "commid": "vscode_pr_154936"}], "negative_passages": []}
{"query_id": "q-en-vscode-c3100f3c8ed39e8ff3216ef4ff13d5d441566d38fb2b310e40b7897a08b11b11", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce:\nOur C/C++ team has verified that our extension is correctly published to the marketplace with the correct binary -- our guess is that there is some VS Code or marketplace bug that is causing the wrong vsix to sometimes be installed.\nUsers are able to download/install our vsix manually from or so the bug appears to be with VS Code and/or the Remote WSL extension.\ncan you reproduce this problem? If yes can you file a new issue with reproducable steps? The issue is not 100% clear to us from this description. Thank you\nOur C/C++ team has not been able to reproduce the problem yet. I'm guessing there's some random or unusual requirement, maybe involving a previously cached installation when an upgrade from version 1.9.8 to 1.10.5 of our extension occurs. I'm not familiar with what sort of install logging would be important for users who repro it to get, which is why I was thinking the issue should be tracked by VS Code (or the Remote extension or marketplace) and not our team. I'm aware of 4 user reports -- there could be more reported against VS Code that I'm not aware of. We don't believe our extension's warning about the incorrect binary is the root issue, and just a symptom of some other system downloading the incorrect vsix for the user's OS (we ship 10 different vsix's).\nIf you can let us know what the remote OS is and what the TargetPlatform property is set to in the file that could help us identify the problem.\nyes getting more details here would be helpful. If you get a chance to repro the problem do let us know. Appreciate it!\nA user reports that our .vsixmanifest file shows TargetPlatform=\"win32-x64\" on a Linux-x64 remote machine (with Win-x64 host), which indicates that VS Code or the Remote extension or marketplace is somehow causing a download/install of the host platform's vsix instead of the remote one. I'm not familiar with what the next steps are in terms of diagnostics, but it seems like at least there should be an open VS Code (or Remote extension) bug to track this, since currently there are just 4 or so closed issues. See\nI'm the reporter of This is not the case for me as I have installed the C/C++ extension for the first time. I don't usually use VS Code but just tried it to reproduce another problem reported by a user. Also, as far as I remember, this is the first time for me to connect to a remote workspace using VS Code. Something that might be related is the version of VS Code. I think I have originally installed VS Code back in October 2021. After that, I hadn't updated the VS Code for a long time because I'm not using it. This time, I think I first tried to install the C/C++ extension with the old version of VS Code and failed. After that, I updated VS Code to the latest version from the main menu of the VS Code, which didn't solve the problem. I'm not sure if this is really related, but is it unsupported to update VS Code from an old version (8-month old) in a single update (i.e., without any intermediate versions)? For example, some migration steps to update the cache or database format would be skipped? We might be able to ask other reporters about their situations? (), (), (this issue): How's the situation? Did you experience the problem in the remote workspace such as in WSL? Have you recently updated VS Code? When have you updated VS Code previously?\nI am using the VS code(version 1.67) in Ubuntu 16.04 LTS (64 bit OS) which is hosted VM in Oracle VM virtual box. While trying to install C/C++ extension in the VS code, it was not proceeding and VS code suggested to download it from the website and install it via vsix. So, I have done the same. The installation of extension was successful but later during debugging, it has mentioned that wrong/incompatible binaries. please let me know if anymore information is required.\nI was not using remote workspace WSL. I am just trying to use VS code for client side code at my local VM.\ncc\nYour issue might be different? You installed the Linux x64 vsix, right? What is the TargetPlatform property set to in the .vscode[-insiders]/extensions/ms-vscode.cpptools-[version][os-description]/.vsixmanifest file? It should say \"linux-x64\". What version of the C/C++ extension are you installing? Our team is able to debug with the Linux x64 vsix so we don't know what could be going wrong yet.\nSorry that I am late to the party. It would be great if I can get summary of the issue? Does it happen to be reproducible?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nI have been thinking that you have checked the linked issues, but let me comment in case you haven't noticed them. I have already described the details about my situation in my initial report If needed, I can just copy and paste the comment to here. Nevertheless, I can answer additional questions about my situation if any. We may also find some information by the OP of this issue in\nMay I know if you have downloaded the VSIX that is compatible to the platform you are using? !\nIt's not me. The above comment is from In my case, I initially tried to install the extension from a VS Code client in Win 10 opened for the remote workspace (Ubuntu 20.04 / WSL2), which fails with the message of incompatible binaries. After the suggestion in , I have downloaded the VSIX from and installed it in the remote, which was successful unlike the case of I'm not sure which version has downloaded. !\nThe problem is, as I have reported in , VS Code seems to wrongly download the VSIX of in Ubuntu 20.04/WSL2 instead of the VSIX of . I have tried several times VS Code's install button with different configurations for both VS Code and VS Code Insiders, but all failed in the same way.\nGot it. Thanks for update. Can you please share us with a gif/video of what you are doing so that we can understand more about the issue? Can you please share us with the following logs after reproducing the issue? F1 Open View... Log (Window) F1 Open View... Log (Remote)\nI tried to upload it to here but couldn't do it due to the size limit. I have instead uploaded it to YouTube: Log (Window) I cannot find such a view. Instead, I see and : Log (Remote Server) Log (Remote Extension Host)\nWhich version of VS Code are you using? Instead of downloading from the installed section, can you please try searching for the extension, say by typing c++ in the search input and install? Does it work if you uninstall the extension and install again?\nAs I have reported in , I have confirmed the behavior in and . Further details are found in As it does not seem to reproduce in every environment, I guess some other factors in my environment causes the problem.\nI now noticed these additional comments. I'll try them when I get back home.\nThis installs the correct version of the extension. What is the correct way to uninstall the extension from the remote? (a) As explained in , I have already tried many times removing the remote extension---by deleting the directory as suggested in ---and installing it again. But they didn't change anything.(b) When I select the C/C++ extension from the installed section and press the [Unintall] button (see below), the remote extension is still located under , but the local extension instead seems to be uninstalled. ! (c) Also, when I type in the search input, select the C/C++ extension, and press the [Uninstall] button (see below), the remote extension is still there, and the local extension is instead uninstalled. !\nSo it means you are getting incompatible C++ extension when you use the button ? In both above screenshots, pressing Uninstall will uninstall locally as the extension seems to be installed locally. So, please try pressing uninstall button and install the extension again?\nYes. I had already tried that many times. The result doesn't change; It again installs an incompatible version as far as I use the button .\nCan you please provide following logs while trying this? Enable log level to trace - F1 Set Log Level Share F1 Open View... Log (Remote) Share F1 Open View... Log (Window)\nHere, I attach the logs: This time, (1) I first attempted to install the extension by pressing . (2) Then reopen the extension page, press and reloaded the VS Code. (3) Then, I again attempted to install the extension from the button. In the zip archive, the following files are included: --- This includes the log of in step (1) described above. --- This includes the log of in step (1). --- This includes the log of in step (3). --- This includes the log of in step (3). --- This includes the log of in step (3).\nThanks for the logs and I think I know the root cause of this issue. It seems in your case the extension is being copied from local client (Windows) to remote (WSL) and hence the bits are being incompatible. This happens if VS Code cannot find a matching installed extension in the Marketplace. In this case, VS Code falls back to copy the extension. Fixed it as follows: Before using the fallback to copy Try again to get the matching extension from the Marketplace In the fallback check if the local extension is compatible with the remote platform. This fix does not covers if you have manually installed an extension that does not exist in the Marketplace and is platform specific.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-438168f3926e22e1277e2266931a59a7a90018688c247eb6b0a19da6f5c7b13c", "text": "@IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService, @IExtensionManagementServerService extensionManagementServerService: IExtensionManagementServerService, @IExtensionManifestPropertiesService extensionManifestPropertiesService: IExtensionManifestPropertiesService, <ins> @IExtensionGalleryService extensionGalleryService: IExtensionGalleryService, </ins> ) { <del> super(`extensions.remoteinstall`, extensionManagementServerService.remoteExtensionManagementServer, canInstallAnyWhere, extensionsWorkbenchService, extensionManagementServerService, extensionManifestPropertiesService); </del> <ins> super(`extensions.remoteinstall`, extensionManagementServerService.remoteExtensionManagementServer, canInstallAnyWhere, extensionsWorkbenchService, extensionManagementServerService, extensionManifestPropertiesService, extensionGalleryService); </ins> } protected getInstallLabel(): string {", "commid": "vscode_pr_154936"}], "negative_passages": []}
{"query_id": "q-en-vscode-c3100f3c8ed39e8ff3216ef4ff13d5d441566d38fb2b310e40b7897a08b11b11", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce:\nOur C/C++ team has verified that our extension is correctly published to the marketplace with the correct binary -- our guess is that there is some VS Code or marketplace bug that is causing the wrong vsix to sometimes be installed.\nUsers are able to download/install our vsix manually from or so the bug appears to be with VS Code and/or the Remote WSL extension.\ncan you reproduce this problem? If yes can you file a new issue with reproducable steps? The issue is not 100% clear to us from this description. Thank you\nOur C/C++ team has not been able to reproduce the problem yet. I'm guessing there's some random or unusual requirement, maybe involving a previously cached installation when an upgrade from version 1.9.8 to 1.10.5 of our extension occurs. I'm not familiar with what sort of install logging would be important for users who repro it to get, which is why I was thinking the issue should be tracked by VS Code (or the Remote extension or marketplace) and not our team. I'm aware of 4 user reports -- there could be more reported against VS Code that I'm not aware of. We don't believe our extension's warning about the incorrect binary is the root issue, and just a symptom of some other system downloading the incorrect vsix for the user's OS (we ship 10 different vsix's).\nIf you can let us know what the remote OS is and what the TargetPlatform property is set to in the file that could help us identify the problem.\nyes getting more details here would be helpful. If you get a chance to repro the problem do let us know. Appreciate it!\nA user reports that our .vsixmanifest file shows TargetPlatform=\"win32-x64\" on a Linux-x64 remote machine (with Win-x64 host), which indicates that VS Code or the Remote extension or marketplace is somehow causing a download/install of the host platform's vsix instead of the remote one. I'm not familiar with what the next steps are in terms of diagnostics, but it seems like at least there should be an open VS Code (or Remote extension) bug to track this, since currently there are just 4 or so closed issues. See\nI'm the reporter of This is not the case for me as I have installed the C/C++ extension for the first time. I don't usually use VS Code but just tried it to reproduce another problem reported by a user. Also, as far as I remember, this is the first time for me to connect to a remote workspace using VS Code. Something that might be related is the version of VS Code. I think I have originally installed VS Code back in October 2021. After that, I hadn't updated the VS Code for a long time because I'm not using it. This time, I think I first tried to install the C/C++ extension with the old version of VS Code and failed. After that, I updated VS Code to the latest version from the main menu of the VS Code, which didn't solve the problem. I'm not sure if this is really related, but is it unsupported to update VS Code from an old version (8-month old) in a single update (i.e., without any intermediate versions)? For example, some migration steps to update the cache or database format would be skipped? We might be able to ask other reporters about their situations? (), (), (this issue): How's the situation? Did you experience the problem in the remote workspace such as in WSL? Have you recently updated VS Code? When have you updated VS Code previously?\nI am using the VS code(version 1.67) in Ubuntu 16.04 LTS (64 bit OS) which is hosted VM in Oracle VM virtual box. While trying to install C/C++ extension in the VS code, it was not proceeding and VS code suggested to download it from the website and install it via vsix. So, I have done the same. The installation of extension was successful but later during debugging, it has mentioned that wrong/incompatible binaries. please let me know if anymore information is required.\nI was not using remote workspace WSL. I am just trying to use VS code for client side code at my local VM.\ncc\nYour issue might be different? You installed the Linux x64 vsix, right? What is the TargetPlatform property set to in the .vscode[-insiders]/extensions/ms-vscode.cpptools-[version][os-description]/.vsixmanifest file? It should say \"linux-x64\". What version of the C/C++ extension are you installing? Our team is able to debug with the Linux x64 vsix so we don't know what could be going wrong yet.\nSorry that I am late to the party. It would be great if I can get summary of the issue? Does it happen to be reproducible?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nI have been thinking that you have checked the linked issues, but let me comment in case you haven't noticed them. I have already described the details about my situation in my initial report If needed, I can just copy and paste the comment to here. Nevertheless, I can answer additional questions about my situation if any. We may also find some information by the OP of this issue in\nMay I know if you have downloaded the VSIX that is compatible to the platform you are using? !\nIt's not me. The above comment is from In my case, I initially tried to install the extension from a VS Code client in Win 10 opened for the remote workspace (Ubuntu 20.04 / WSL2), which fails with the message of incompatible binaries. After the suggestion in , I have downloaded the VSIX from and installed it in the remote, which was successful unlike the case of I'm not sure which version has downloaded. !\nThe problem is, as I have reported in , VS Code seems to wrongly download the VSIX of in Ubuntu 20.04/WSL2 instead of the VSIX of . I have tried several times VS Code's install button with different configurations for both VS Code and VS Code Insiders, but all failed in the same way.\nGot it. Thanks for update. Can you please share us with a gif/video of what you are doing so that we can understand more about the issue? Can you please share us with the following logs after reproducing the issue? F1 Open View... Log (Window) F1 Open View... Log (Remote)\nI tried to upload it to here but couldn't do it due to the size limit. I have instead uploaded it to YouTube: Log (Window) I cannot find such a view. Instead, I see and : Log (Remote Server) Log (Remote Extension Host)\nWhich version of VS Code are you using? Instead of downloading from the installed section, can you please try searching for the extension, say by typing c++ in the search input and install? Does it work if you uninstall the extension and install again?\nAs I have reported in , I have confirmed the behavior in and . Further details are found in As it does not seem to reproduce in every environment, I guess some other factors in my environment causes the problem.\nI now noticed these additional comments. I'll try them when I get back home.\nThis installs the correct version of the extension. What is the correct way to uninstall the extension from the remote? (a) As explained in , I have already tried many times removing the remote extension---by deleting the directory as suggested in ---and installing it again. But they didn't change anything.(b) When I select the C/C++ extension from the installed section and press the [Unintall] button (see below), the remote extension is still located under , but the local extension instead seems to be uninstalled. ! (c) Also, when I type in the search input, select the C/C++ extension, and press the [Uninstall] button (see below), the remote extension is still there, and the local extension is instead uninstalled. !\nSo it means you are getting incompatible C++ extension when you use the button ? In both above screenshots, pressing Uninstall will uninstall locally as the extension seems to be installed locally. So, please try pressing uninstall button and install the extension again?\nYes. I had already tried that many times. The result doesn't change; It again installs an incompatible version as far as I use the button .\nCan you please provide following logs while trying this? Enable log level to trace - F1 Set Log Level Share F1 Open View... Log (Remote) Share F1 Open View... Log (Window)\nHere, I attach the logs: This time, (1) I first attempted to install the extension by pressing . (2) Then reopen the extension page, press and reloaded the VS Code. (3) Then, I again attempted to install the extension from the button. In the zip archive, the following files are included: --- This includes the log of in step (1) described above. --- This includes the log of in step (1). --- This includes the log of in step (3). --- This includes the log of in step (3). --- This includes the log of in step (3).\nThanks for the logs and I think I know the root cause of this issue. It seems in your case the extension is being copied from local client (Windows) to remote (WSL) and hence the bits are being incompatible. This happens if VS Code cannot find a matching installed extension in the Marketplace. In this case, VS Code falls back to copy the extension. Fixed it as follows: Before using the fallback to copy Try again to get the matching extension from the Marketplace In the fallback check if the local extension is compatible with the remote platform. This fix does not covers if you have manually installed an extension that does not exist in the Marketplace and is platform specific.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-41d41c61f5f563151d76ba6da5bcc2cc2f310177c6a5f9da98fb0ef8cf3e732a", "text": "@IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService, @IExtensionManagementServerService extensionManagementServerService: IExtensionManagementServerService, @IExtensionManifestPropertiesService extensionManifestPropertiesService: IExtensionManifestPropertiesService, <ins> @IExtensionGalleryService extensionGalleryService: IExtensionGalleryService, </ins> ) { <del> super(`extensions.localinstall`, extensionManagementServerService.localExtensionManagementServer, false, extensionsWorkbenchService, extensionManagementServerService, extensionManifestPropertiesService); </del> <ins> super(`extensions.localinstall`, extensionManagementServerService.localExtensionManagementServer, false, extensionsWorkbenchService, extensionManagementServerService, extensionManifestPropertiesService, extensionGalleryService); </ins> } protected getInstallLabel(): string {", "commid": "vscode_pr_154936"}], "negative_passages": []}
{"query_id": "q-en-vscode-c3100f3c8ed39e8ff3216ef4ff13d5d441566d38fb2b310e40b7897a08b11b11", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce:\nOur C/C++ team has verified that our extension is correctly published to the marketplace with the correct binary -- our guess is that there is some VS Code or marketplace bug that is causing the wrong vsix to sometimes be installed.\nUsers are able to download/install our vsix manually from or so the bug appears to be with VS Code and/or the Remote WSL extension.\ncan you reproduce this problem? If yes can you file a new issue with reproducable steps? The issue is not 100% clear to us from this description. Thank you\nOur C/C++ team has not been able to reproduce the problem yet. I'm guessing there's some random or unusual requirement, maybe involving a previously cached installation when an upgrade from version 1.9.8 to 1.10.5 of our extension occurs. I'm not familiar with what sort of install logging would be important for users who repro it to get, which is why I was thinking the issue should be tracked by VS Code (or the Remote extension or marketplace) and not our team. I'm aware of 4 user reports -- there could be more reported against VS Code that I'm not aware of. We don't believe our extension's warning about the incorrect binary is the root issue, and just a symptom of some other system downloading the incorrect vsix for the user's OS (we ship 10 different vsix's).\nIf you can let us know what the remote OS is and what the TargetPlatform property is set to in the file that could help us identify the problem.\nyes getting more details here would be helpful. If you get a chance to repro the problem do let us know. Appreciate it!\nA user reports that our .vsixmanifest file shows TargetPlatform=\"win32-x64\" on a Linux-x64 remote machine (with Win-x64 host), which indicates that VS Code or the Remote extension or marketplace is somehow causing a download/install of the host platform's vsix instead of the remote one. I'm not familiar with what the next steps are in terms of diagnostics, but it seems like at least there should be an open VS Code (or Remote extension) bug to track this, since currently there are just 4 or so closed issues. See\nI'm the reporter of This is not the case for me as I have installed the C/C++ extension for the first time. I don't usually use VS Code but just tried it to reproduce another problem reported by a user. Also, as far as I remember, this is the first time for me to connect to a remote workspace using VS Code. Something that might be related is the version of VS Code. I think I have originally installed VS Code back in October 2021. After that, I hadn't updated the VS Code for a long time because I'm not using it. This time, I think I first tried to install the C/C++ extension with the old version of VS Code and failed. After that, I updated VS Code to the latest version from the main menu of the VS Code, which didn't solve the problem. I'm not sure if this is really related, but is it unsupported to update VS Code from an old version (8-month old) in a single update (i.e., without any intermediate versions)? For example, some migration steps to update the cache or database format would be skipped? We might be able to ask other reporters about their situations? (), (), (this issue): How's the situation? Did you experience the problem in the remote workspace such as in WSL? Have you recently updated VS Code? When have you updated VS Code previously?\nI am using the VS code(version 1.67) in Ubuntu 16.04 LTS (64 bit OS) which is hosted VM in Oracle VM virtual box. While trying to install C/C++ extension in the VS code, it was not proceeding and VS code suggested to download it from the website and install it via vsix. So, I have done the same. The installation of extension was successful but later during debugging, it has mentioned that wrong/incompatible binaries. please let me know if anymore information is required.\nI was not using remote workspace WSL. I am just trying to use VS code for client side code at my local VM.\ncc\nYour issue might be different? You installed the Linux x64 vsix, right? What is the TargetPlatform property set to in the .vscode[-insiders]/extensions/ms-vscode.cpptools-[version][os-description]/.vsixmanifest file? It should say \"linux-x64\". What version of the C/C++ extension are you installing? Our team is able to debug with the Linux x64 vsix so we don't know what could be going wrong yet.\nSorry that I am late to the party. It would be great if I can get summary of the issue? Does it happen to be reproducible?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nI have been thinking that you have checked the linked issues, but let me comment in case you haven't noticed them. I have already described the details about my situation in my initial report If needed, I can just copy and paste the comment to here. Nevertheless, I can answer additional questions about my situation if any. We may also find some information by the OP of this issue in\nMay I know if you have downloaded the VSIX that is compatible to the platform you are using? !\nIt's not me. The above comment is from In my case, I initially tried to install the extension from a VS Code client in Win 10 opened for the remote workspace (Ubuntu 20.04 / WSL2), which fails with the message of incompatible binaries. After the suggestion in , I have downloaded the VSIX from and installed it in the remote, which was successful unlike the case of I'm not sure which version has downloaded. !\nThe problem is, as I have reported in , VS Code seems to wrongly download the VSIX of in Ubuntu 20.04/WSL2 instead of the VSIX of . I have tried several times VS Code's install button with different configurations for both VS Code and VS Code Insiders, but all failed in the same way.\nGot it. Thanks for update. Can you please share us with a gif/video of what you are doing so that we can understand more about the issue? Can you please share us with the following logs after reproducing the issue? F1 Open View... Log (Window) F1 Open View... Log (Remote)\nI tried to upload it to here but couldn't do it due to the size limit. I have instead uploaded it to YouTube: Log (Window) I cannot find such a view. Instead, I see and : Log (Remote Server) Log (Remote Extension Host)\nWhich version of VS Code are you using? Instead of downloading from the installed section, can you please try searching for the extension, say by typing c++ in the search input and install? Does it work if you uninstall the extension and install again?\nAs I have reported in , I have confirmed the behavior in and . Further details are found in As it does not seem to reproduce in every environment, I guess some other factors in my environment causes the problem.\nI now noticed these additional comments. I'll try them when I get back home.\nThis installs the correct version of the extension. What is the correct way to uninstall the extension from the remote? (a) As explained in , I have already tried many times removing the remote extension---by deleting the directory as suggested in ---and installing it again. But they didn't change anything.(b) When I select the C/C++ extension from the installed section and press the [Unintall] button (see below), the remote extension is still located under , but the local extension instead seems to be uninstalled. ! (c) Also, when I type in the search input, select the C/C++ extension, and press the [Uninstall] button (see below), the remote extension is still there, and the local extension is instead uninstalled. !\nSo it means you are getting incompatible C++ extension when you use the button ? In both above screenshots, pressing Uninstall will uninstall locally as the extension seems to be installed locally. So, please try pressing uninstall button and install the extension again?\nYes. I had already tried that many times. The result doesn't change; It again installs an incompatible version as far as I use the button .\nCan you please provide following logs while trying this? Enable log level to trace - F1 Set Log Level Share F1 Open View... Log (Remote) Share F1 Open View... Log (Window)\nHere, I attach the logs: This time, (1) I first attempted to install the extension by pressing . (2) Then reopen the extension page, press and reloaded the VS Code. (3) Then, I again attempted to install the extension from the button. In the zip archive, the following files are included: --- This includes the log of in step (1) described above. --- This includes the log of in step (1). --- This includes the log of in step (3). --- This includes the log of in step (3). --- This includes the log of in step (3).\nThanks for the logs and I think I know the root cause of this issue. It seems in your case the extension is being copied from local client (Windows) to remote (WSL) and hence the bits are being incompatible. This happens if VS Code cannot find a matching installed extension in the Marketplace. In this case, VS Code falls back to copy the extension. Fixed it as follows: Before using the fallback to copy Try again to get the matching extension from the Marketplace In the fallback check if the local extension is compatible with the remote platform. This fix does not covers if you have manually installed an extension that does not exist in the Marketplace and is platform specific.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-0e5de99d34245385f37f44dab5fa9800cd0fb02ed53a75fd304fc3c26b5063fb", "text": "@IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService, @IExtensionManagementServerService extensionManagementServerService: IExtensionManagementServerService, @IExtensionManifestPropertiesService extensionManifestPropertiesService: IExtensionManifestPropertiesService, <ins> @IExtensionGalleryService extensionGalleryService: IExtensionGalleryService, </ins> ) { <del> super(`extensions.webInstall`, extensionManagementServerService.webExtensionManagementServer, false, extensionsWorkbenchService, extensionManagementServerService, extensionManifestPropertiesService); </del> <ins> super(`extensions.webInstall`, extensionManagementServerService.webExtensionManagementServer, false, extensionsWorkbenchService, extensionManagementServerService, extensionManifestPropertiesService, extensionGalleryService); </ins> } protected getInstallLabel(): string {", "commid": "vscode_pr_154936"}], "negative_passages": []}
{"query_id": "q-en-vscode-38103ad1ea0dbd54e281500cd8cff9c5b69e071f6fc1a434c494c51155640f91", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Win10 21H1 .1706 Steps to Reproduce: ! This is caused by When L122 , the element may have been created in the tree before. Thus, may be more than once and causes icon style conflict. ! A PR will be linked. Idea from After fix: !", "positive_passages": [{"docid": "doc-en-vscode-7860fec03bca45f55045d6c61eefd6c1b3e09285ff78495f6c00debfe878d999", "text": "renderElement(node: ITreeNode<Call, FuzzyScore>, _index: number, template: CallRenderingTemplate): void { const { element, filterData } = node; const deprecated = element.item.tags?.includes(SymbolTag.Deprecated); <ins> template.icon.className = ''; </ins> template.icon.classList.add('inline', ...CSSIcon.asClassNameArray(SymbolKinds.toIcon(element.item.kind))); template.label.setLabel( element.item.name,", "commid": "vscode_pr_152216"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-1becb7b7861d8dacba83f2d0e26bf8bf7f314fdfb31e61885344065e0d81f6b5", "text": "comment: ['The task command line or label'] }, 'Executing task: {0}', commandLine), { excludeLeadingNewLine: true }) + taskShellIntegrationOutputSequence; } <ins> } else { shellLaunchConfig.initialText = taskShellIntegrationStartSequence + taskShellIntegrationOutputSequence; </ins> } } else { const commandExecutable = (task.command.runtime !== RuntimeType.CustomExecution) ? CommandString.value(command) : undefined;", "commid": "vscode_pr_152676"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-22210c5c72a5725e9f89b37a45e98178657c9b75d6120a04829c01b68139b995", "text": "comment: ['The task command line or label'] }, 'Executing task: {0}', `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`), { excludeLeadingNewLine: true }) + taskShellIntegrationOutputSequence; } <ins> } else { shellLaunchConfig.initialText = taskShellIntegrationStartSequence + taskShellIntegrationOutputSequence; </ins> } }", "commid": "vscode_pr_152676"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-7489328e8673c65fd49d17923c07fdcce32ce64a5263bd16a6c800baf9969f29", "text": "/** * A string including ANSI escape sequences that will be written to the terminal emulator <del> * _before_ the terminal process has launched, a trailing n is added at the end of the string. * This allows for example the terminal instance to display a styled message as the first line * of the terminal. Use x1b over 033 or e for the escape control character. </del> <ins> * _before_ the terminal process has launched, when a string is specified, a trailing n is * added at the end. This allows for example the terminal instance to display a styled message * as the first line of the terminal. Use x1b over 033 or e for the escape control character. </ins> */ <del> initialText?: string; </del> <ins> initialText?: string | { text: string; trailingNewLine: boolean }; </ins> /** * Custom PTY/pseudoterminal process to use.", "commid": "vscode_pr_154513"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-f0e50956160f9a0d390fa9dc34c61a313fd758ba4e30b7fa10e74baa51bb5e31", "text": "executableEnv, options }; <del> const persistentProcess = new PersistentTerminalProcess(id, process, workspaceId, workspaceName, shouldPersist, cols, rows, processLaunchOptions, unicodeVersion, this._reconnectConstants, this._logService, isReviving ? shellLaunchConfig.initialText : undefined, rawReviveBuffer, shellLaunchConfig.icon, shellLaunchConfig.color, shellLaunchConfig.name, shellLaunchConfig.fixedDimensions); </del> <ins> const persistentProcess = new PersistentTerminalProcess(id, process, workspaceId, workspaceName, shouldPersist, cols, rows, processLaunchOptions, unicodeVersion, this._reconnectConstants, this._logService, isReviving && typeof shellLaunchConfig.initialText === 'string' ? shellLaunchConfig.initialText : undefined, rawReviveBuffer, shellLaunchConfig.icon, shellLaunchConfig.color, shellLaunchConfig.name, shellLaunchConfig.fixedDimensions); </ins> process.onDidChangeProperty(property => this._onDidChangeProperty.fire({ id, property })); process.onProcessExit(event => { persistentProcess.dispose();", "commid": "vscode_pr_154513"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-75eb04f349377ee4cc4deafd111b20805ea63e427fa9070d0a23e149625fec79", "text": "}, 'Executing task: {0}', commandLine), { excludeLeadingNewLine: true }) + this.taskShellIntegrationOutputSequence; } } else { <del> shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence + this.taskShellIntegrationOutputSequence; </del> <ins> shellLaunchConfig.initialText = { text: this.taskShellIntegrationStartSequence + this.taskShellIntegrationOutputSequence, trailingNewLine: false }; </ins> } } else { const commandExecutable = (task.command.runtime !== RuntimeType.CustomExecution) ? CommandString.value(command) : undefined;", "commid": "vscode_pr_154513"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-9aa8dd194895e38b214a653a15655a49aa9c27dd4605ca51a66a28139c2696f5", "text": "}, 'Executing task: {0}', `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`), { excludeLeadingNewLine: true }) + this.taskShellIntegrationOutputSequence; } } else { <del> shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence + this.taskShellIntegrationOutputSequence; </del> <ins> shellLaunchConfig.initialText = { text: this.taskShellIntegrationStartSequence + this.taskShellIntegrationOutputSequence, trailingNewLine: false }; </ins> } }", "commid": "vscode_pr_154513"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-9831830cf5954573ffa8df26cb82b12a6c862a80c0223c6016593be446948d56", "text": "// Write initial text, deferring onLineFeed listener when applicable to avoid firing // onLineData events containing initialText if (this._shellLaunchConfig.initialText) { <del> this.xterm.raw.writeln(this._shellLaunchConfig.initialText, () => { </del> <ins> this._writeInitialText(this.xterm, () => { </ins> lineDataEventAddon.onLineData(e => this._onLineData.fire(e)); }); } else {", "commid": "vscode_pr_154513"}], "negative_passages": []}
{"query_id": "q-en-vscode-307c4f65c291f0f0e695b35a3272e7b3199f95276205950a41909753dcb618e7", "query": "!\nworks in OSS !\nalso works for me in insider's\nworks for that exact task for me !\nIt's because of this: Here's the I was using:\nThis works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !", "positive_passages": [{"docid": "doc-en-vscode-b8c50d883da0d74b2820ee299f72e0cfefb4ae2c55cec6f1f8c93f7fd8c0856d", "text": "} } <ins> private _writeInitialText(xterm: XtermTerminal, callback?: () => void): void { if (!this._shellLaunchConfig.initialText) { callback?.(); return; } const text = typeof this._shellLaunchConfig.initialText === 'string' ? this._shellLaunchConfig.initialText : this._shellLaunchConfig.initialText?.text; if (typeof this._shellLaunchConfig.initialText === 'string') { xterm.raw.writeln(text, callback); } else { if (this._shellLaunchConfig.initialText.trailingNewLine) { xterm.raw.writeln(text, callback); } else { xterm.raw.write(text, callback); } } } </ins> async reuseTerminal(shell: IShellLaunchConfig, reset: boolean = false): Promise<void> { // Unsubscribe any key listener we may have. this._pressAnyKeyToCloseListener?.dispose(); this._pressAnyKeyToCloseListener = undefined; <del> if (this.xterm) { </del> <ins> const xterm = this.xterm; if (xterm) { </ins> if (!reset) { // Ensure new processes' output starts at start of new line <del> await new Promise<void>(r => this.xterm!.raw.write('nx1b[G', r)); </del> <ins> await new Promise<void>(r => xterm.raw.write('nx1b[G', r)); </ins> } // Print initialText if specified if (shell.initialText) { <del> await new Promise<void>(r => this.xterm!.raw.writeln(shell.initialText!, r)); </del> <ins> await new Promise<void>(r => this._writeInitialText(xterm, r)); </ins> } // Clean up waitOnExit state if (this._isExiting && this._shellLaunchConfig.waitOnExit) { <del> this.xterm.raw.options.disableStdin = false; </del> <ins> xterm.raw.options.disableStdin = false; </ins> this._isExiting = false; } if (reset) { <del> this.xterm.clearDecorations(); </del> <ins> xterm.clearDecorations(); </ins> } }", "commid": "vscode_pr_154513"}], "negative_passages": []}
{"query_id": "q-en-vscode-79021f7d920cfc0c4f26c624f0ce2f6c1ebf3d03ae7503a974e4b3fd30f631ab", "query": "Issue Type: <bBug</bWhen I drill down into the git menu and choose the option to , I really don't need the same confirmation dialog as when I just hit the top-level check mark in the source control pane. The dialog tells me ; this is an incorrect warning at this stage, since I clearly invoked it by choosing . I certainly don't want to choose the option in response to this warning, since it's a good warning to have when I accidentally hit the checkmark without staging any changes. VS Code version: Code 1.67.0 (, 2022-05-04T12:14:47.100Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-cbf143afb98aa38866c9fb648a1b2dc6f1438b0f19bf0602d3741870b2129d06", "text": "private async smartCommit( repository: Repository, getCommitMessage: () => Promise<string | undefined>, <del> opts?: CommitOptions </del> <ins> opts: CommitOptions </ins> ): Promise<boolean> { const config = workspace.getConfiguration('git', Uri.file(repository.root)); let promptToSaveFilesBeforeCommit = config.get<'always' | 'staged' | 'never'>('promptToSaveFilesBeforeCommit');", "commid": "vscode_pr_155486"}], "negative_passages": []}
{"query_id": "q-en-vscode-79021f7d920cfc0c4f26c624f0ce2f6c1ebf3d03ae7503a974e4b3fd30f631ab", "query": "Issue Type: <bBug</bWhen I drill down into the git menu and choose the option to , I really don't need the same confirmation dialog as when I just hit the top-level check mark in the source control pane. The dialog tells me ; this is an incorrect warning at this stage, since I clearly invoked it by choosing . I certainly don't want to choose the option in response to this warning, since it's a good warning to have when I accidentally hit the checkmark without staging any changes. VS Code version: Code 1.67.0 (, 2022-05-04T12:14:47.100Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-4cce2f44b7a38973809a2e5edc69fc9f3a585db137d99c893b28b3a036429770", "text": "} } <del> if (!opts) { opts = { all: noStagedChanges }; } else if (!opts.all && noStagedChanges && !opts.empty) { opts = { ...opts, all: true }; } </del> // no changes, and the user has not configured to commit all in this case <del> if (!noUnstagedChanges && noStagedChanges && !enableSmartCommit && !opts.empty) { </del> <ins> if (!noUnstagedChanges && noStagedChanges && !enableSmartCommit && !opts.empty && !opts.all) { </ins> const suggestSmartCommit = config.get<boolean>('suggestSmartCommit') === true; if (!suggestSmartCommit) {", "commid": "vscode_pr_155486"}], "negative_passages": []}
{"query_id": "q-en-vscode-79021f7d920cfc0c4f26c624f0ce2f6c1ebf3d03ae7503a974e4b3fd30f631ab", "query": "Issue Type: <bBug</bWhen I drill down into the git menu and choose the option to , I really don't need the same confirmation dialog as when I just hit the top-level check mark in the source control pane. The dialog tells me ; this is an incorrect warning at this stage, since I clearly invoked it by choosing . I certainly don't want to choose the option in response to this warning, since it's a good warning to have when I accidentally hit the checkmark without staging any changes. VS Code version: Code 1.67.0 (, 2022-05-04T12:14:47.100Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-8ebc8cefb848f50932b4dfea3393036a692b6533020a68ca85414df1bd42df50", "text": "} } <ins> if (opts.all === undefined) { opts = { all: noStagedChanges }; } else if (!opts.all && noStagedChanges && !opts.empty) { opts = { ...opts, all: true }; } </ins> // enable signing of commits if configured opts.signCommit = enableCommitSigning;", "commid": "vscode_pr_155486"}], "negative_passages": []}
{"query_id": "q-en-vscode-79021f7d920cfc0c4f26c624f0ce2f6c1ebf3d03ae7503a974e4b3fd30f631ab", "query": "Issue Type: <bBug</bWhen I drill down into the git menu and choose the option to , I really don't need the same confirmation dialog as when I just hit the top-level check mark in the source control pane. The dialog tells me ; this is an incorrect warning at this stage, since I clearly invoked it by choosing . I certainly don't want to choose the option in response to this warning, since it's a good warning to have when I accidentally hit the checkmark without staging any changes. VS Code version: Code 1.67.0 (, 2022-05-04T12:14:47.100Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-4a1cc3148c1ef7c67764c69eb9cec1b016220e09ba78174ba28849f68b3f89e3", "text": "return true; } <del> private async commitWithAnyInput(repository: Repository, opts?: CommitOptions): Promise<void> { </del> <ins> private async commitWithAnyInput(repository: Repository, opts: CommitOptions): Promise<void> { </ins> const message = repository.inputBox.value; const root = Uri.file(repository.root); const config = workspace.getConfiguration('git', root);", "commid": "vscode_pr_155486"}], "negative_passages": []}
{"query_id": "q-en-vscode-136c2424f906be6ab94f8e1c9e61719be3c7684ae7b5f8f21f3f07b8169c35c3", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows 10 Steps to Reproduce: When I open a terminal in VSCode the following warning is logged within a few seconds: . I take note of that this issue is not a duplicate of.\nA warning as in on the window output channel or devtools console? Do you use powerlevel10k or another complex prompt by chance?\nIt's in the devtools console. Not using any complex prompt. Just plain CMD.\nOh OK, that's unexpected if it's cmd, thanks for the info\nwe should probably do something like here", "positive_passages": [{"docid": "doc-en-vscode-2a31e927b71dea29e4dabec500cbcecea3aa7537d0e65ab14c36475de2cb9d5a", "text": "import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { ITerminalCommand, TerminalCapability } from 'vs/platform/terminal/common/capabilities/capabilities'; import { TerminalCapabilityStoreMultiplexer } from 'vs/platform/terminal/common/capabilities/terminalCapabilityStore'; <del> import { IProcessDataEvent, IProcessPropertyMap, IShellLaunchConfig, ITerminalDimensionsOverride, ITerminalLaunchError, ProcessPropertyType, TerminalIcon, TerminalLocation, TerminalSettingId, TerminalShellType, TitleEventSource, WindowsShellType } from 'vs/platform/terminal/common/terminal'; </del> <ins> import { IProcessDataEvent, IProcessPropertyMap, IShellLaunchConfig, ITerminalDimensionsOverride, ITerminalLaunchError, PosixShellType, ProcessPropertyType, TerminalIcon, TerminalLocation, TerminalSettingId, TerminalShellType, TitleEventSource, WindowsShellType } from 'vs/platform/terminal/common/terminal'; </ins> import { escapeNonWindowsPath } from 'vs/platform/terminal/common/terminalEnvironment'; import { activeContrastBorder, scrollbarSliderActiveBackground, scrollbarSliderBackground, scrollbarSliderHoverBackground } from 'vs/platform/theme/common/colorRegistry'; import { IColorTheme, ICssStyleCollector, IThemeService, registerThemingParticipant, ThemeIcon } from 'vs/platform/theme/common/themeService';", "commid": "vscode_pr_153139"}], "negative_passages": []}
{"query_id": "q-en-vscode-136c2424f906be6ab94f8e1c9e61719be3c7684ae7b5f8f21f3f07b8169c35c3", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows 10 Steps to Reproduce: When I open a terminal in VSCode the following warning is logged within a few seconds: . I take note of that this issue is not a duplicate of.\nA warning as in on the window output channel or devtools console? Do you use powerlevel10k or another complex prompt by chance?\nIt's in the devtools console. Not using any complex prompt. Just plain CMD.\nOh OK, that's unexpected if it's cmd, thanks for the info\nwe should probably do something like here", "positive_passages": [{"docid": "doc-en-vscode-a0a2393b0adf4e4c6320b0085158862577c6aabfd1e8f82bdb9aa7bbc8016350", "text": "rows: number; } <ins> const shellIntegrationSupportedShellTypes = [PosixShellType.Bash, PosixShellType.Zsh, PosixShellType.PowerShell, WindowsShellType.PowerShell]; </ins> const scrollbarHeight = 5; class TerminalOutputProvider implements ITextModelContentProvider {", "commid": "vscode_pr_153139"}], "negative_passages": []}
{"query_id": "q-en-vscode-136c2424f906be6ab94f8e1c9e61719be3c7684ae7b5f8f21f3f07b8169c35c3", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows 10 Steps to Reproduce: When I open a terminal in VSCode the following warning is logged within a few seconds: . I take note of that this issue is not a duplicate of.\nA warning as in on the window output channel or devtools console? Do you use powerlevel10k or another complex prompt by chance?\nIt's in the devtools console. Not using any complex prompt. Just plain CMD.\nOh OK, that's unexpected if it's cmd, thanks for the info\nwe should probably do something like here", "positive_passages": [{"docid": "doc-en-vscode-518edd70242ae0df76c80d483022abda65efa5e2077b23962a3403292ff5c71f", "text": "} get disableShellIntegrationReporting(): boolean { if (this._disableShellIntegrationReporting === undefined) { <del> this._disableShellIntegrationReporting = this.shellLaunchConfig.isFeatureTerminal || this.shellLaunchConfig.hideFromUser || this.shellLaunchConfig.executable === undefined; </del> <ins> this._disableShellIntegrationReporting = (this.shellLaunchConfig.hideFromUser || this.shellLaunchConfig.executable === undefined || this.shellType === undefined) || !shellIntegrationSupportedShellTypes.includes(this.shellType); </ins> } return this._disableShellIntegrationReporting; }", "commid": "vscode_pr_153139"}], "negative_passages": []}
{"query_id": "q-en-vscode-e45feea09e96ace341e3bc0ed905ee2f2e58ea75aa0d8bd1556078e4e42b056f", "query": "Issue Type: <bBug</bAfter upgrading to 1.68, text selection in the integrated terminal does not show selected text. This is purely a visual glitch, as I can still copy what I had selected on the terminal. My colleague has the same version but does not have this issue, so I'm wondering if it's an issue introduced through my update. VS Code version: Code 1.68.1 (, 2022-06-14T12:48:58.283Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ project-manager12.6.0 github-markdown-preview0.3.0 markdown-checkbox0.3.2 markdown-emoji0.2.1 markdown-footnotes0.0.7 markdown-mermaid1.14.0 markdown-preview-github-styles1.0.1 markdown-yaml-preamble0.1.0 keymapceditor-vsc0.7.7 gitignore0.7.0 doxdocgen1.4.0 transformer1.12.1 git-extension-pack0.1.3 githistory0.6.19 gitlens12.1.1 EditorConfig0.16.4 align-mode0.0.21 better-cpp-syntax1.15.18 cmake-language-support-vscode0.0.4 theme-karyfoundation-themes26.2.1 vscode-docker1.22.0 vscode-dotnet-runtime1.5.0 python2022.8.0 vscode-pylance2022.6.20 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.8 remote-containers0.238.2 remote-ssh0.82.1 remote-ssh-edit0.80.0 remote-wsl0.66.3 vscode-remote-extensionpack0.21.0 cmake-tools1.11.26 cpptools1.10.7 cpptools-extension-pack1.2.0 makefile-tools0.5.0 indent-rainbow8.3.1 vscode-pbtxt0.0.4 cmake0.0.17 vim1.22.2 clang-format1.9.0 vscode-open-in-github1.3.6 (5 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nSame issue, I'm using theme. When I switch to a different theme the selection is visible. Looks like a theme issue.\nCan you reproduce the issue in Insider's? I see selection in Insider's when using solarized light, but it does seem pretty light !\nI believe we're implementing solarized light correctly here and that's how it's meant to work. If you're not a fan of the low contrast selection you can change it with this setting: Otherwise change to a theme that you prefer. Let me know if I misunderstood and the selection is actually not visible (not just subtle).\nI was using the theme for a while and I was used to the low contrast on selection. It was quite ok on my screen TBH. Now there's no visible selection. Here I've selected \"Counting objects\". I've actually pasted it from the terminal instead of typing to be sure. ! I don't think this issue is ready for closing.\nDo you have any settings set and does changing help?\nI strive to work on defaults. No settings in Setting to true causes selected letters to become slightly lighter, but no background. \"si\" selected ! Not sure if it has anything to do with it, but the issue seems to have started after the recent update (via PPA on an ubuntu flavor). After updating I didn't restart immediately, but attempted to open an image and everything crashed. Restarted after that and noticed selection not working a bit later.\nSome more things to try: Does closing all windows and running fix it? If not, can you share your full file? Running the Generate color theme from current settings command will let us see if there's something weird going on with the theme\nConfirming this is only happening in Solarized Light\nDisabling GPU doesn't help <details</summary{ \"window.menuBarVisibility\": \"toggle\", \"editor.minimap.enabled\": false, \"[javascript]\": { \"editor.defaultFormatter\": \"vscode.typescript-language-features\" }, \"javascript.updateImportsOnFileMove.enabled\": \"always\", \"[json]\": { \"editor.defaultFormatter\": \"\" }, \"[typescript]\": { \"editor.defaultFormatter\": \"vscode.typescript-language-features\" }, \"\": \"stuff=\", \"explorer.confirmDelete\": false, \"explorer.confirmDragAndDrop\": false, \"[html]\": { \"editor.defaultFormatter\": \"\" }, \"[jsonc]\": { \"editor.defaultFormatter\": \"\" }, \"workbench.colorTheme\": \"Solarized Light\", \"editor.inlineSuggest.enabled\": true, \"editor.renderWhitespace\": \"none\", \"[css]\": { \"editor.defaultFormatter\": \"esbenp.prettier-vscode\" } } </details<details<summarycolor theme from current settings</summary</details\nI can't reproduce based on those settings so I'm a bit stumped on what to do with this one\nSo I checked the terminal background on the screenshot and it's which is exactly the same color as the default selection color. the dump I pasted above had in it, which seems odd. But since you didn't raise it, I'm assuming it's supposed to mean the actual background is the one of the panel inside which the terminal is working. What I also noticed about the terminal panel is it's no longer giving me the option to move it to the bottom of the window, which is odd, but most of all when I right-click, it no longer says \"move terminal right\" as an option, but \"move sidebar\". I checked, and means I will no longer see my selection. Conclusion is what ends up being the color behind terminal text. The theme should probably set terminal background or change the selection color as a fix. I wonder what else breaks because terminal is now a sidebar not something else.\nAh ok, thanks for looking into it. Because of this, setting the terminal background explicitly is a good solution for now. I doubt it happens in many other themes since contrast is usually pretty high but I'll check Solarized Dark as well when fixing.", "positive_passages": [{"docid": "doc-en-vscode-83916f7f3376c17d3be9987e500008c258662ea81b67fcd977bfa664bb089f79", "text": "\"terminal.ansiBrightMagenta\": \"#6c71c4\", \"terminal.ansiBrightCyan\": \"#93a1a1\", \"terminal.ansiBrightWhite\": \"#fdf6e3\", <ins> // Set terminal background explicitly, otherwise selection becomes invisible when the // terminal is in the side bar \"terminal.background\": \"#FDF6E3\", </ins> // Interactive Playground \"walkThrough.embeddedEditorBackground\": \"#00000014\" },", "commid": "vscode_pr_152973"}], "negative_passages": []}
{"query_id": "q-en-vscode-a53e0158841d8e6006a582f1cd47dcc570150faa1e7ec27d8a48d1e06762522d", "query": "Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-22T05:17:09.661Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. This is a follow up of Steps to Reproduce: the dnd sample: to the of some logs in : the extension multiple files to the dnd sample view, the uris in the data transfer are not split by line separators. // cc\nAre you dragging from the VS Code file explorer view, or your operating system's file explorer?\nSorry forgot to mention, it's from VS Code file explorer\nCan you check the actual value, not just the value printed by I debugged this and oddly while just prints: The actual value of is: In this case each file name is separated by a pair\nTested in: Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-23T05:16:43.681Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. It's still stored in one line: https://user- Is there anything I missed?\nThanks. Only happens on windows for me. Taking a look now\nI don't see us setting anywhere and suspect chrome is generating it automatically. See in for how this may happen Also we are possibly hitting\nNice find. I couldn't find us setting anywhere either.\nVerified on Windows and Linux in 1.69.0-insider (user setup) Commit: , 022-07-01T05:17:04.343Z", "positive_passages": [{"docid": "doc-en-vscode-efdb056c888d0081166ab7b85c1c3fffd5ab771e7f4f9dc02326b4909f04ad0d", "text": "DataTransfers.RESOURCES, ]); <del> export function addExternalEditorsDropData(dataTransfer: VSDataTransfer, dragEvent: DragEvent) { if (dragEvent.dataTransfer && !dataTransfer.has(Mimes.uriList)) { </del> <ins> export function addExternalEditorsDropData(dataTransfer: VSDataTransfer, dragEvent: DragEvent, overwriteUriList = false) { if (dragEvent.dataTransfer && (overwriteUriList || !dataTransfer.has(Mimes.uriList))) { </ins> const editorData = extractEditorsDropData(dragEvent) .filter(input => input.resource) .map(input => input.resource!.toString());", "commid": "vscode_pr_153758"}], "negative_passages": []}
{"query_id": "q-en-vscode-a53e0158841d8e6006a582f1cd47dcc570150faa1e7ec27d8a48d1e06762522d", "query": "Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-22T05:17:09.661Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. This is a follow up of Steps to Reproduce: the dnd sample: to the of some logs in : the extension multiple files to the dnd sample view, the uris in the data transfer are not split by line separators. // cc\nAre you dragging from the VS Code file explorer view, or your operating system's file explorer?\nSorry forgot to mention, it's from VS Code file explorer\nCan you check the actual value, not just the value printed by I debugged this and oddly while just prints: The actual value of is: In this case each file name is separated by a pair\nTested in: Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-23T05:16:43.681Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0. It's still stored in one line: https://user- Is there anything I missed?\nThanks. Only happens on windows for me. Taking a look now\nI don't see us setting anywhere and suspect chrome is generating it automatically. See in for how this may happen Also we are possibly hitting\nNice find. I couldn't find us setting anywhere either.\nVerified on Windows and Linux in 1.69.0-insider (user setup) Commit: , 022-07-01T05:17:04.343Z", "positive_passages": [{"docid": "doc-en-vscode-c359769341e30c8ba9bb3db3d8e0da7fce40d4e1ffb74c90344a12fd2fbdf41a", "text": "} const originalDataTransfer = toVSDataTransfer(originalEvent.dataTransfer); <del> addExternalEditorsDropData(originalDataTransfer, originalEvent); </del> <ins> addExternalEditorsDropData(originalDataTransfer, originalEvent, true); </ins> const outDataTransfer = new VSDataTransfer(); for (const [type, item] of originalDataTransfer.entries()) {", "commid": "vscode_pr_153758"}], "negative_passages": []}
{"query_id": "q-en-vscode-cab2e0ef1e1bf46cc1e3b8532da5219401213473fc68bf8dcc701b90332e0dd9", "query": "I think we should understand why execution time seems to get slower and slower the more cells there are. Check out this video, it looks as if things get slower and slower: ! Originally posted by in\nThis test is running the \"Run All\" command, not the \"run one cell\" command...", "positive_passages": [{"docid": "doc-en-vscode-09f42fdf900e692051f3816bc456f0cf73316cf4320b9da3b2dfaa8955dbb343", "text": "return notebook.cellAt(notebook.cellCount - 1); } <del> async function addCellAndRun(code: string, notebook: vscode.NotebookDocument) { </del> <ins> async function addCellAndRun(code: string, notebook: vscode.NotebookDocument, i: number) { </ins> const cell = await addCell(code, notebook); <del> await vscode.commands.executeCommand('notebook.execute'); </del> <ins> await vscode.commands.executeCommand('notebook.cell.execute', { start: i, end: i + 1 }); </ins> assert.strictEqual(cell.outputs.length, 1, 'execute failed'); return cell; }", "commid": "vscode_pr_153735"}], "negative_passages": []}
{"query_id": "q-en-vscode-cab2e0ef1e1bf46cc1e3b8532da5219401213473fc68bf8dcc701b90332e0dd9", "query": "I think we should understand why execution time seems to get slower and slower the more cells there are. Check out this video, it looks as if things get slower and slower: ! Originally posted by in\nThis test is running the \"Run All\" command, not the \"run one cell\" command...", "positive_passages": [{"docid": "doc-en-vscode-0dedbd6f8034be302ecbc468ddc3eb3e989e81c59d9c58a1d9f2ac6c0f9627ae", "text": "// Run and add a bunch of cells for (let i = 0; i < 10; i++) { <del> await addCellAndRun(`print ${i}`, notebookEditor.notebook); </del> <ins> await addCellAndRun(`print ${i}`, notebookEditor.notebook, i); </ins> } // Verify visible range has the last cell", "commid": "vscode_pr_153735"}], "negative_passages": []}
{"query_id": "q-en-vscode-3f21a9150845d74478db2abca52a0d1eaf3ce0a392e655e2fc18e02849775351", "query": "! Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-23T05:16:43.681Z Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.\nIt's actually allowed to have no scope (for the default fore/background), but the schema is too strict", "positive_passages": [{"docid": "doc-en-vscode-772a094a8032779c8de97e490e58491e417425f7bd636d36dcd553dad4530a7a", "text": "} }, required: [ <del> 'settings', 'scope' </del> <ins> 'settings' </ins> ], additionalProperties: false }", "commid": "vscode_pr_152977"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-080a40ed651034c18b69ddbfbfbb11a5e41bb114614b4824b3b3d0d566cd172e", "text": "} update(mode: OutputChannelUpdateMode, till?: number): void { <del> this.model.update(mode, till); </del> <ins> this.model.update(mode, till, true); </ins> } clear(): void {", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-a58d292c056891fad591ffc39c21ce286a7c266e16c9afa961c4ecb7ec20e0a9", "text": "export interface IOutputChannelModel extends IDisposable { readonly onDispose: Event<void>; append(output: string): void; <del> update(mode: OutputChannelUpdateMode, till?: number): void; </del> <ins> update(mode: OutputChannelUpdateMode, till: number | undefined, immediate: boolean): void; </ins> loadModel(): Promise<ITextModel>; clear(): void; replace(value: string): void;", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-104c73773cdca1d2df2f0b8a7153182aa26f93fccddf74e933381500436a88c3", "text": "} clear(): void { <del> this.update(OutputChannelUpdateMode.Clear, this.endOffset); </del> <ins> this.update(OutputChannelUpdateMode.Clear, this.endOffset, true); </ins> } <del> update(mode: OutputChannelUpdateMode, till?: number): void { </del> <ins> update(mode: OutputChannelUpdateMode, till: number | undefined, immediate: boolean): void { </ins> const loadModelPromise: Promise<any> = this.loadModelPromise ? this.loadModelPromise : Promise.resolve(); <del> loadModelPromise.then(() => this.doUpdate(mode, till)); </del> <ins> loadModelPromise.then(() => this.doUpdate(mode, till, immediate)); </ins> } loadModel(): Promise<ITextModel> {", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-9e90530fbd805fd54109e6e699d7034c5183116fe3cfc847cf8b6adcc9dae2d4", "text": "return this.model; } <del> private doUpdate(mode: OutputChannelUpdateMode, till?: number): void { </del> <ins> private doUpdate(mode: OutputChannelUpdateMode, till: number | undefined, immediate: boolean): void { </ins> if (mode === OutputChannelUpdateMode.Clear || mode === OutputChannelUpdateMode.Replace) { this.startOffset = this.endOffset = isNumber(till) ? till : this.endOffset; this.cancelModelUpdate();", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-a3102984a91c6159be1312bddb5de56afe988b24383840f8aac60d03926053f2", "text": "} else { <del> this.appendContent(this.model, token); </del> <ins> this.appendContent(this.model, immediate, token); </ins> } }", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-3ccc5b85e0f3c1108a09a0a2ade0fe2288e59b7ecab5ae5e9385e5bbdc6fc682", "text": "this.doUpdateModel(model, [EditOperation.delete(model.getFullModelRange())], VSBuffer.fromString('')); } <del> private async appendContent(model: ITextModel, token: CancellationToken): Promise<void> { </del> <ins> private async appendContent(model: ITextModel, immediate: boolean, token: CancellationToken): Promise<void> { </ins> this.appendThrottler.trigger(async () => { /* Abort if operation is cancelled */ if (token.isCancellationRequested) {", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-288ff2a315f087dc12dd75a14159b0dbcb7ce712c0c7fce3e5fff5aac0a20930", "text": "const lastLineMaxColumn = model.getLineMaxColumn(lastLine); const edits = [EditOperation.insert(new Position(lastLine, lastLineMaxColumn), contentToAppend.toString())]; this.doUpdateModel(model, edits, contentToAppend); <del> }); </del> <ins> }, immediate ? 0 : undefined); </ins> } private async replaceContent(model: ITextModel, token: CancellationToken): Promise<void> {", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-7d82728b4173b809af5585d3b9af26d6516bc805a95d415acbcd0a8d084ed850", "text": "if (!this.modelUpdateInProgress) { if (isNumber(size) && this.endOffset > size) { // Reset - Content is removed <del> this.update(OutputChannelUpdateMode.Clear, 0); </del> <ins> this.update(OutputChannelUpdateMode.Clear, 0, true); </ins> } } <del> this.update(OutputChannelUpdateMode.Append); </del> <ins> this.update(OutputChannelUpdateMode.Append, undefined, false /* Not needed to update immediately. Wait to collect more changes and update. */); </ins> } }", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-150d50b92c4e633dac1762f7b31bd2ceab9b84264deec4356f5c3f91fda587aa", "text": "override append(message: string): void { this.write(message); <del> this.update(OutputChannelUpdateMode.Append); </del> <ins> this.update(OutputChannelUpdateMode.Append, undefined, this.isVisible()); </ins> } override replace(message: string): void { const till = this._offset; this.write(message); <del> this.update(OutputChannelUpdateMode.Replace, till); </del> <ins> this.update(OutputChannelUpdateMode.Replace, till, true); </ins> } private write(content: string): void {", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-1df0e4569c894f4c77d6f955a5e474cfe3e80e866af92c2e2c2b5cf0cf179556", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (the issue is produced using CMake Tools extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.68.1 (user setup) Commit: Date: 2022-06-14T12:48:58.283Z Electron: 17.4.7 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: WindowsNT x64 6.3.9600 OS Version: Windows 8.1 When using the CMake Tools extension, the build output is shown in the \"Output\" tab. And when the build is going fast (when there are many build log lines per second), the Output doesn't update until the end of the build. See this video from https://user- The build output is not realtime. CMake Tools extension a project that builds fast (less than 200ms per build log line) main.c: Note: Build this CMake project using MSVC is faster and is more likely to reproduce the issue than building with clang/mingw. After severals tests, I've found that: The VSCode log file (inside is constantly updated as expected, this can be checked with bash using The code that prevent the actual log to be printed in the Output pane is here: This code uses from here (with a default delay of 300ms): Which uses from here: And if I read this correctly, this means that: Due to IPC between CMake Tools extension and the main Code thread, for every log line, is called, and every call to that function will reset the Delayer timer of 200ms. This means that as long as there are log lines every at most 200ms, the output pane won't be updated. Which cause the \"hang\" as seen in the above video. I guess that replacing the from to a would solve that issue ?\nHere are videos to compare the modification of using instead of for the variable in . Before modification (VSCode 1.68.1 unmodified): https://user- After modification (replaced the declaration of to , replaced call from to and removed call to ): https://user- The CPU usage is a bit higher, but the log is shown in realtime (the CPU is a intel i5 3230m from 2013). Closing the Output pane while building takes less CPU (around 48% instead of 53% (when not recording), when not building I'm at 6%).\nThanks for debugging it and coming up with the root cause. Your analysis is correct. But changing this to Throttler is not the right. We would still want to delay/debounce the updates if they do not need to be real time like log outputs. But for the output channels created by outputs we shall update the content immediately. Created a PR to fix it when immediate updates are needed like in this case.", "positive_passages": [{"docid": "doc-en-vscode-bf6355eab0d03fa52455024327f056c0e532a0cd9ab05721518a6e9da2dc5b25", "text": "this.outputChannelModel.then(outputChannelModel => outputChannelModel.append(output)); } <del> update(mode: OutputChannelUpdateMode, till?: number): void { this.outputChannelModel.then(outputChannelModel => outputChannelModel.update(mode, till)); </del> <ins> update(mode: OutputChannelUpdateMode, till: number | undefined, immediate: boolean): void { this.outputChannelModel.then(outputChannelModel => outputChannelModel.update(mode, till, immediate)); </ins> } loadModel(): Promise<ITextModel> {", "commid": "vscode_pr_154082"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-cb394fba311080c61385ed5f2bad004e730db73ff7e3c86bf506c71512943e33", "text": "if (uri === undefined) { return; } // Run the store action to get back a ref <del> const ref = await that.storeEditSession(); </del> <ins> const ref = await that.storeEditSession(false); </ins> // Append the ref to the URI if (ref !== undefined) {", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-b97c0e180805bd4ab503e4cc57e937721d45e615e04bd8aad5b0e812f13f9f8d", "text": "await that.progressService.withProgress({ location: ProgressLocation.Notification, title: localize('storing edit session', 'Storing edit session...') <del> }, async () => await that.storeEditSession()); </del> <ins> }, async () => await that.storeEditSession(true)); </ins> } })); }", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-84bfbb2cf2296c408c63933ddf421f703a47ad0de51518cf705122d510a4b258", "text": "} } <del> async storeEditSession(): Promise<string | undefined> { </del> <ins> async storeEditSession(fromStoreCommand: boolean): Promise<string | undefined> { </ins> const folders: Folder[] = []; <ins> let hasEdits = false; </ins> for (const repository of this.scmService.repositories) { // Look through all resource groups and compute which files were added/modified/deleted", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-de1e43e558cd6312f5b541c48432b385c24a14670915a240f32b8ab90729b6d0", "text": "} } catch { } <ins> hasEdits = true; </ins> if (await this.fileService.exists(uri)) { workingChanges.push({ type: ChangeType.Addition, fileType: FileType.File, contents: (await this.fileService.readFile(uri)).value.toString(), relativeFilePath: relativeFilePath }); } else {", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-f70a61783fa045a553fcf3688610e459dc31325c6f79712eb3b1ba30d4b68f09", "text": "folders.push({ workingChanges, name: name ?? '' }); } <ins> if (!hasEdits) { this.logService.info('Edit Sessions: Skipping storing edit session as there are no edits to store.'); if (fromStoreCommand) { this.notificationService.info(localize('no edits to store', 'Skipped storing edit session as there are no edits to store.')); } return undefined; } </ins> const data: EditSession = { folders, version: 1 }; try {", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-f7c49c97a5187b15969c70f2ae5d1a04a2a59535abad524666bd4f11a22fad3c", "text": "let instantiationService: TestInstantiationService; let sessionSyncContribution: SessionSyncContribution; let fileService: FileService; <ins> let sandbox: sinon.SinonSandbox; </ins> const disposables = new DisposableStore(); <del> setup(() => { </del> <ins> suiteSetup(() => { sandbox = sinon.createSandbox(); </ins> instantiationService = new TestInstantiationService(); // Set up filesystem", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-9dced8eb3aca9316c36af93cd6a9b6ab11f5329f3e93266ef0c1c7affffcb871", "text": "} }); <ins> // Stub repositories instantiationService.stub(ISCMService, '_repositories', new Map()); </ins> sessionSyncContribution = instantiationService.createInstance(SessionSyncContribution); });", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-b8a649f01bc468c45e56cd19f2c092ba4aaea9592525a822b18d88d965f49640", "text": "}; // Stub sync service to return edit session data <del> const sandbox = sinon.createSandbox(); </del> const readStub = sandbox.stub().returns({ editSession, ref: '0' }); instantiationService.stub(ISessionSyncWorkbenchService, 'read', readStub); <del> // Stub repositories instantiationService.stub(ISCMService, '_repositories', new Map()); </del> // Create root folder await fileService.createFolder(folderUri);", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-d461dd3a89cd01e17e97b93985fedfd5e8dcc0e5d85517d78c011a3b174dd6c8", "query": "Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.", "positive_passages": [{"docid": "doc-en-vscode-8ddeddfc5dac9884d953d4674a483cc816c020680e19c02638e1724d718b1a82", "text": "// Verify edit session was correctly applied assert.equal((await fileService.readFile(fileUri)).value.toString(), fileContents); }); <ins> test('Edit session not stored if there are no edits', async function () { const writeStub = sandbox.stub(); instantiationService.stub(ISessionSyncWorkbenchService, 'write', writeStub); // Create root folder await fileService.createFolder(folderUri); await sessionSyncContribution.storeEditSession(true); // Verify that we did not attempt to write the edit session assert.equal(writeStub.called, false); }); </ins> });", "commid": "vscode_pr_153599"}], "negative_passages": []}
{"query_id": "q-en-vscode-f554f35bf02f3dcdc6cae604424465893bced95c4796f6a11efa8bc8d3aa3ea4", "query": "Testing Have one profile with GitLens installed and other without. Notice how walkthrough shows up in Welcome page on profile without GitLens <img width=\"1653\" alt=\"image\" src=\"https://user-\"\nIt seems welcome page is not updating when extensions are removed. This has to be fixed in walk throughs / welcome page component. Not sure who owns this now. Can you please assign it to the corresponding owner?\nIt appears we are handling it correctly here\nI see is being invoked for gitlens extension when switching profiles, but I do not know why the walk through page is still showing it. I do not know the implementation of it. Can you please investigate from walk through component perspective first to see why it is still being shown?\nI disabled gitlens and used the button to reload the window. The walkthrough is no longer there. is that expected?\n!\nI changed profiles to the one with Gitlens still enabled and there's still no walkthrough\nHmmm I cannot repro this. Can you provide a gif? If I have the walkthrough open and reload my window the walkthrough page doesn't dissapear\nhttps://user-", "positive_passages": [{"docid": "doc-en-vscode-8c18f395cf27a8cc64f94ea0e3cd4a70bb3357fa0827dc644e55d29a6da79c3a", "text": "} extension.contributes?.walkthroughs?.forEach(section => { <del> const categoryID = extension.identifier.value + '#walkthrough#' + section.id; </del> <ins> const categoryID = extension.identifier.value + '#' + section.id; </ins> section.steps.forEach(step => { const fullyQualifiedID = extension.identifier.value + '#' + section.id + '#' + step.id; this.steps.delete(fullyQualifiedID);", "commid": "vscode_pr_155770"}], "negative_passages": []}
{"query_id": "q-en-vscode-4e74a7ca116f858aae6fa919a010473fa1bfc15bd5a1c4138497f655a4acb7da", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: =1.66.0 OS Version: iOS 14.3 Steps to Reproduce: Safari on iOS 14.3 to any vscode server (e.g. , or ) The Safari developer tools console shows the following error:\n. I see references to in the following commits: (soft reference) Thoughts?\nAs this has been supported since iOS 15, do we want to change this?\nThe changes introduced in completely break vs code for all devices below iOS/iPadOS 15, the other occurrences of don't seem to have any negative impact according to my testing (anything below 1.66.0 works). The fix I proposed in is a more elegant solution that supports all browsers and does not break anything.\nWe are generally only aiming for latest and greatest browser version. The use of seems small enough to justify a special case but we shouldn't target a lower version nor is there any guarantee that other things won't break, e.g \"fixing\" this might just reveal another bunch of blocker etc pp.\nSounds good, forwarding to to evaluate the PR.", "positive_passages": [{"docid": "doc-en-vscode-d9562a01123e0a8f9a8d2972499f619b8de7cda6241b6e0aca2a35dad44254d0", "text": "* @returns whether the provided parameter is of type `Buffer` or Uint8Array dervived type */ export function isTypedArray(obj: unknown): obj is Object { <ins> const TypedArray = Object.getPrototypeOf(Uint8Array); </ins> return typeof obj === 'object' <del> && (obj instanceof Uint8Array || obj instanceof Uint16Array || obj instanceof Uint32Array || obj instanceof Float32Array || obj instanceof Float64Array || obj instanceof Int8Array || obj instanceof Int16Array || obj instanceof Int32Array || obj instanceof BigInt64Array || obj instanceof BigUint64Array || obj instanceof Uint8ClampedArray); </del> <ins> && obj instanceof TypedArray; </ins> } /**", "commid": "vscode_pr_153929"}], "negative_passages": []}
{"query_id": "q-en-vscode-7e4d9c2d2cf7847cb935c99d0847c930a653b082b40d16a0de9e81eac543eecd", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0-insider OS Version: Windows 10 Steps to Reproduce: and install from VSIX the test-provider-sample from - this just sets instead of adding test cases. Testing panel and open outcome: shows \"expanded arrow\" but error message doesn't appear. Error appears in Developer Tools ! ! bootstrap- [uncaught exception]: TypeError: Cannot read properties of undefined (reading 'expand') onUnexpectedError @ bootstrap- (anonymous) @ bootstrap- emit @ node:events:390 window.onerror @ node:electron/js2c/rendererinit:73 platform1.globals.onerror @ bootstrap- TypeError: Cannot read properties of undefined (reading 'expand') at Object.getId (vscode-file://vscode-) at vscode-file://vscode- at (<anonymous) at IndexTreeModel.spliceSimple (vscode-file://vscode-) at IndexTreeModel.spliceSmart (vscode-file://vscode-) at (vscode-file://vscode-) at ObjectTreeModel.setChildren (vscode-file://vscode-) at ObjectTreeModel.setChildren (vscode-file://vscode-) at WorkbenchObjectTree.setChildren (vscode-file://vscode-) at NodeChangeList.applyTo (vscode-file://vscode-) at HierarchicalByLocationProjection.applyTo (vscode-file://vscode-) at TestingExplorerViewModel.applyProjectionChanges (vscode-file://vscode-) at (vscode-file://vscode-) at RunOnceScheduler.doRun (vscode-file://vscode-) at RunOnceScheduler.onTimeout (vscode-file://vscode-) onUnexpectedError @ bootstrap- (anonymous) @ bootstrap- emit @ node:events:390 window.onerror @ node:electron/js2c/rendererinit:73 platform1.globals.onerror @ Uncaught TypeError: Cannot read properties of undefined (reading 'expand') at Object.getId () at at (<anonymous) at IndexTreeModel.spliceSimple () at IndexTreeModel.spliceSmart () at () at ObjectTreeModel.setChildren () at ObjectTreeModel.setChildren () at WorkbenchObjectTree.setChildren () at NodeChangeList.applyTo () at HierarchicalByLocationProjection.applyTo () at TestingExplorerViewModel.applyProjectionChanges () at () at RunOnceScheduler.doRun () at RunOnceScheduler.onTimeout ()\nI submitted a PR\n/assign", "positive_passages": [{"docid": "doc-en-vscode-dc1441ca828f7b2b260d1cfe9bca7b10f49c45c4542faf571f068b7207e3266e", "text": "import { IIdentityProvider } from 'vs/base/browser/ui/list/list'; import { ObjectTree } from 'vs/base/browser/ui/tree/objectTree'; import { ITreeElement } from 'vs/base/browser/ui/tree/tree'; <del> import { IActionableTestTreeElement, TestExplorerTreeElement, TestItemTreeElement } from 'vs/workbench/contrib/testing/browser/explorerProjections/index'; </del> <ins> import { IActionableTestTreeElement, TestExplorerTreeElement, TestItemTreeElement, TestTreeErrorMessage } from 'vs/workbench/contrib/testing/browser/explorerProjections/index'; </ins> <del> export const testIdentityProvider: IIdentityProvider<TestItemTreeElement> = { </del> <ins> export const testIdentityProvider: IIdentityProvider<TestExplorerTreeElement> = { </ins> getId(element) { <del> return element.treeId + '0' + element.test.expand; </del> <ins> return element.treeId + '0' + (element instanceof TestTreeErrorMessage ? 'error' : element.test.expand); </ins> } };", "commid": "vscode_pr_153994"}], "negative_passages": []}
{"query_id": "q-en-vscode-edcdc425ddc4f2dbb17c58a947958b2506c05e5bbbb6a13268340b19d51eea6d", "query": "<img width=\"368\" alt=\"CleanShot 2022-07-18 at 08 28 16 src=\"https://user-\"\"Configure\" and \"Manage\" are really similar to each other and I had a hard time knowing which one opened what, which caused me to open the wrong one. \"Configure\" opens the settings UI with a query, and \"Manage\" opens a custom editor. My proposal would be to change \"Configure Workspace Trust\" to \"Workspace Trust Settings\" to make it explicit.\nI'd actually like to tweak your proposal to \"Manage Trusted Workspaces\" and \"Configure Workspace Trust Settings\"", "positive_passages": [{"docid": "doc-en-vscode-da3d3504c96158a0bdf8c9353ef0b83a5d419fee202123d99d176014c8781619", "text": "* Actions */ <del> // Configure Workspace Trust </del> <ins> // Configure Workspace Trust Settings </ins> const CONFIGURE_TRUST_COMMAND_ID = 'workbench.trust.configure'; const WORKSPACES_CATEGORY = { value: localize('workspacesCategory', \"Workspaces\"), original: 'Workspaces' };", "commid": "vscode_pr_168340"}], "negative_passages": []}
{"query_id": "q-en-vscode-edcdc425ddc4f2dbb17c58a947958b2506c05e5bbbb6a13268340b19d51eea6d", "query": "<img width=\"368\" alt=\"CleanShot 2022-07-18 at 08 28 16 src=\"https://user-\"\"Configure\" and \"Manage\" are really similar to each other and I had a hard time knowing which one opened what, which caused me to open the wrong one. \"Configure\" opens the settings UI with a query, and \"Manage\" opens a custom editor. My proposal would be to change \"Configure Workspace Trust\" to \"Workspace Trust Settings\" to make it explicit.\nI'd actually like to tweak your proposal to \"Manage Trusted Workspaces\" and \"Configure Workspace Trust Settings\"", "positive_passages": [{"docid": "doc-en-vscode-32fd590ad56ff005608bf09b3563e52facbe9e0ce4d5cb04ab72365f58f416ae", "text": "constructor() { super({ id: CONFIGURE_TRUST_COMMAND_ID, <del> title: { original: 'Configure Workspace Trust', value: localize('configureWorkspaceTrust', \"Configure Workspace Trust\") }, </del> <ins> title: { original: 'Configure Workspace Trust Settings', value: localize('configureWorkspaceTrustSettings', \"Configure Workspace Trust Settings\") }, </ins> precondition: ContextKeyExpr.and(WorkspaceTrustContext.IsEnabled, ContextKeyExpr.equals(`config.${WORKSPACE_TRUST_ENABLED}`, true)), category: WORKSPACES_CATEGORY, f1: true", "commid": "vscode_pr_168340"}], "negative_passages": []}
{"query_id": "q-en-vscode-c7e16f6e5c2bd51e334bf37702a1fae28e3bc2f713cd406dc3eaa03b4886c6ed", "query": "Repro: Using Open a Remote - WSL folder !\nThis would probably not be limited to the title, what about the hover over the tab?\nThe separators seem to be flipped: !\nI wonder if could have regressed this, is this a recent regression?\nI cannot reproduce, so this is some setting you have or some configuration most likely.\nIt might be remnants of the formatted caching bug?\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-4c384dace9f3bd8f1fc81e1d1014f657c109069c15a9c795082dd42c647d7c84", "text": "this.os = OS; this.userHome = pathService.defaultUriScheme === Schemas.file ? this.pathService.userHome({ preferLocal: true }) : undefined; <del> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters', storageService); </del> <ins> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters2', storageService); </ins> this.storedFormatters = memento.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); <del> this.formatters = this.storedFormatters?.formatters || []; </del> <ins> this.formatters = this.storedFormatters?.formatters?.slice() || []; </ins> // Remote environment is potentially long running this.resolveRemoteEnvironment();", "commid": "vscode_pr_157313"}], "negative_passages": []}
{"query_id": "q-en-vscode-c7e16f6e5c2bd51e334bf37702a1fae28e3bc2f713cd406dc3eaa03b4886c6ed", "query": "Repro: Using Open a Remote - WSL folder !\nThis would probably not be limited to the title, what about the hover over the tab?\nThe separators seem to be flipped: !\nI wonder if could have regressed this, is this a recent regression?\nI cannot reproduce, so this is some setting you have or some configuration most likely.\nIt might be remnants of the formatted caching bug?\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-40e416c6c9a664eec2c5fa923c62997adc8240112f8a6c6529a463ecb89398ac", "text": "test('label caching', () => { <del> const m = new Memento('cachedResourceLabelFormatters', storageService).getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); </del> <ins> const m = new Memento('cachedResourceLabelFormatters2', storageService).getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); </ins> const makeFormatter = (scheme: string): ResourceLabelFormatter => ({ formatting: { label: `${path} (${scheme})`, separator: '/' }, scheme }); assert.deepStrictEqual(m, {});", "commid": "vscode_pr_157313"}], "negative_passages": []}
{"query_id": "q-en-vscode-dccf5681783e4347602d9ddbbd53edfeb961647c2b5924b1e3a466986499d9a8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:\n/ , can you please point me to the GitHub page that corresponds to this page.\nThanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.\nYou are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?\nThanks for looping me in! Opened a PR in is the repo for", "positive_passages": [{"docid": "doc-en-vscode-9cc168f104db467eb91828eff8841d7519313c66f8d3ded9ad2df84b5277e69b", "text": "}, { \"name\": \"border-image-width\", <del> \"desc\": \"The four values of 'border-image-width' specify offsets that are used to divide the border image area into nine parts. They represent inward distances from the the top, right, bottom, and left sides of the area, respectively.\", </del> <ins> \"desc\": \"The four values of 'border-image-width' specify offsets that are used to divide the border image area into nine parts. They represent inward distances from the top, right, bottom, and left sides of the area, respectively.\", </ins> \"browsers\": \"FF13,IE11\", \"restriction\": \"length, percentage, number\", \"values\": []", "commid": "vscode_pr_61"}], "negative_passages": []}
{"query_id": "q-en-vscode-dccf5681783e4347602d9ddbbd53edfeb961647c2b5924b1e3a466986499d9a8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:\n/ , can you please point me to the GitHub page that corresponds to this page.\nThanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.\nYou are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?\nThanks for looping me in! Opened a PR in is the repo for", "positive_passages": [{"docid": "doc-en-vscode-47b44ec49c24b15eee7f14e84b6264d7d6082cbf576a744f6c6b7d21d792eb32", "text": "}, { \"name\": \"counter-increment\", <del> \"desc\": \"Counters are used with the 'counter()' and 'counters()' functions of the the 'content' property.\", </del> <ins> \"desc\": \"Counters are used with the 'counter()' and 'counters()' functions of the 'content' property.\", </ins> \"browsers\": \"C,FF1.5,IE8,O10.5,S3\", \"restriction\": \"identifier, integer\", \"values\": []", "commid": "vscode_pr_61"}], "negative_passages": []}
{"query_id": "q-en-vscode-dccf5681783e4347602d9ddbbd53edfeb961647c2b5924b1e3a466986499d9a8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:\n/ , can you please point me to the GitHub page that corresponds to this page.\nThanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.\nYou are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?\nThanks for looping me in! Opened a PR in is the repo for", "positive_passages": [{"docid": "doc-en-vscode-1fd1398245dae1e96ee3fed16a9af72db5370c879c16b2de112a2733a1060d03", "text": "\"values\": [ { \"name\": \"center\", <del> \"desc\": \"Places the center of the Grid Item's margin box at the center of the the Grid Item's column.\" </del> <ins> \"desc\": \"Places the center of the Grid Item's margin box at the center of the Grid Item's column.\" </ins> }, { \"name\": \"end\",", "commid": "vscode_pr_61"}], "negative_passages": []}
{"query_id": "q-en-vscode-dccf5681783e4347602d9ddbbd53edfeb961647c2b5924b1e3a466986499d9a8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:\n/ , can you please point me to the GitHub page that corresponds to this page.\nThanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.\nYou are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?\nThanks for looping me in! Opened a PR in is the repo for", "positive_passages": [{"docid": "doc-en-vscode-c6fe81f4d67bdd9f59410b4f23a624c41c0d78219ffa63fdaaa97e6b416e622b", "text": "\"values\": [ { \"name\": \"center\", <del> \"desc\": \"Places the center of the Grid Item's margin box at the center of the the Grid Item's row.\" </del> <ins> \"desc\": \"Places the center of the Grid Item's margin box at the center of the Grid Item's row.\" </ins> }, { \"name\": \"end\",", "commid": "vscode_pr_61"}], "negative_passages": []}
{"query_id": "q-en-vscode-1be7c11f61fe265e1bbb7a1b9915355cf7badcc4ad0e188eb02f5c38f065f2b8", "query": "The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in", "positive_passages": [{"docid": "doc-en-vscode-d218fa499eda32e6ecfd4c7bd76235aea33e3adf46223d01908019700de8001e", "text": "async performReplace(element: FolderMatch | FileMatch | Match): Promise<any> { // since multiple elements can be selected, we need to check the type of the FolderMatch/FileMatch/Match before we perform the replace. <del> const elementsToReplace = getElementsToOperateOnInfo(this.viewer, element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); </del> <ins> const opInfo = getElementsToOperateOnInfo(this.viewer, element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); const elementsToReplace = opInfo.elements; </ins> await Promise.all(elementsToReplace.map(async (elem) => { const parent = elem.parent();", "commid": "vscode_pr_156205"}], "negative_passages": []}
{"query_id": "q-en-vscode-1be7c11f61fe265e1bbb7a1b9915355cf7badcc4ad0e188eb02f5c38f065f2b8", "query": "The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in", "positive_passages": [{"docid": "doc-en-vscode-0727d458db9fb0fb35ae75548ddbd54ff9136760e098ec6208d268246ecd0c00", "text": "} override run(): Promise<any> { <del> const elementsToRemove = getElementsToOperateOnInfo(this.viewer, this.element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); </del> <ins> const opInfo = getElementsToOperateOnInfo(this.viewer, this.element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); const elementsToRemove = opInfo.elements; </ins> const currentBottomFocusElement = elementsToRemove[elementsToRemove.length - 1]; <del> const nextFocusElement = !currentBottomFocusElement || currentBottomFocusElement instanceof SearchResult || arrayContainsElementOrParent(currentBottomFocusElement, elementsToRemove) ? </del> <ins> const nextFocusElement = opInfo.mustReselect && (!currentBottomFocusElement || currentBottomFocusElement instanceof SearchResult || arrayContainsElementOrParent(currentBottomFocusElement, elementsToRemove)) ? </ins> this.getElementToFocusAfterRemoved(this.viewer, <any>currentBottomFocusElement) : null;", "commid": "vscode_pr_156205"}], "negative_passages": []}
{"query_id": "q-en-vscode-1be7c11f61fe265e1bbb7a1b9915355cf7badcc4ad0e188eb02f5c38f065f2b8", "query": "The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in", "positive_passages": [{"docid": "doc-en-vscode-78ede45b82dd5d74564d842792e329093c417864c18842c74eebbda58d054c92", "text": "}); }; <del> function getElementsToOperateOnInfo(viewer: WorkbenchObjectTree<RenderableMatch, void>, currElement: RenderableMatch, sortConfig: ISearchConfigurationProperties): RenderableMatch[] { </del> <ins> function getElementsToOperateOnInfo(viewer: WorkbenchObjectTree<RenderableMatch, void>, currElement: RenderableMatch, sortConfig: ISearchConfigurationProperties): { elements: RenderableMatch[]; mustReselect: boolean } { </ins> let elements: RenderableMatch[] = viewer.getSelection().filter((x): x is RenderableMatch => x !== null).sort((a, b) => searchComparer(a, b, sortConfig.sortOrder)); <ins> const mustReselect = elements.includes(currElement); // this indicates whether we need to re-focus/re-select on a remove. </ins> // if selection doesn't include multiple elements, just return current focus element. if (!(elements.length > 1 && elements.includes(currElement))) { elements = [currElement]; } <del> return elements; </del> <ins> return { elements, mustReselect }; </ins> }", "commid": "vscode_pr_156205"}], "negative_passages": []}
{"query_id": "q-en-vscode-faac39c896e32727c630ce119fcc94bb07a48d496c145cc231f36e3be41ef7d5", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1-dev OS Version: web Steps to Reproduce: a in to get editor gutter decorations for and changed lines. a file with a single line change e.g. a word in line 5. The line will show an indicator in the editor gutter for the changed line, which when clicked will open a Quick Diff peek view. a on the same line. The editor gutter will display the comment gutter icon (diamond inside rectangle), which when clicked will expand or collapse the comment on that line, and hide the indicator for the changed content in the same line, preventing the user from noticing that there is a change or opening Quick Diff to inspect it.\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nWith multi-line comments () the impact is likely higher. As the user is likely to make changes in close proximity to comments to address issues raised, this may disproportionately limit the utility of Quick Diff. cc\nI'm not seeing them overlap: ! Am I looking at the correct thing?\nThat's the correct thing and in your screenshot it appears to be fine. Not sure why we are seeing the comment indicators draw over the change indicators, but we are also on a slightly older version and I am not sure if there are any other local adjustments in this space that I was not aware of. I will check this again on plain VS Code, sorry for the noise.\nIn 1.70.0-insider, I see this: for a multi-line change across the comment range: <img width=\"688\" alt=\"Screen Shot 2022-07-26 at 16 06 34\" src=\"https://user-\"- for a single-line change on the same line as the comment range: <img width=\"715\" alt=\"Screen Shot 2022-07-26 at 16 07 07\" src=\"https://user-\"This is for a simple Git repository, with a small test extension populating the comments. Caveat might be that it's \"read-only\" in the sense that I don't set , not sure if that causes problems? I see and draw in the same location and the comment thread wins because it has .\nI suspect that not having the range provider is causing this. Will try to fix for July, but will likely move to August.\nI tried setting a range provider, here are my observations: The docs for are wrong: When not provided, users cannot leave any comments\u2014I think this is actually fine\u2014and the gutter indicators overlap, as described. When setting a that returns for all documents, the behavior is the same as above. When setting a that returns , i.e. an empty range, the gutter indicators seem to draw correctly. However this also unexpectedly allows the user to start a discussion on line 1. For our extension, we don't want to support adding new comments on any lines, but otherwise show and allow replying to comments populated by the extension via the API. The reason is that our extension focuses primarily on supporting the author of a change / pull request in addressing the comments left by code reviewers in an external code review tool, i.e. they will almost never start a comment thread from their side. Allowing commenting on all lines of the file currently appears to draw an extremely distracting indicator through the entire gutter () which we strongly wish to avoid without requiring usage of Zen Mode. If the visuals of this were more subtle () we would not mind allowing users to comment on the entire file, even though it remains a rather rare use case for our user base.\nThe problem described in the original issue is a bug, which I will fix, You shouldn't need to have a commenting range provider at all. It sounds like there is also a doc bug, and an empty range bug, which I'll also look at. Regarding Zen mode: since the last update commenting is off by default in Zen Mode, so you shouldn't see any comments there. You can always toggle it back on with the command Comments: Toggle Editor Commenting.\nThe linked PR will fix the hidden decoration bug and the doc bug. I'm hesitant to make any changes for the range, as this may be intentional behavior or behavior that some extensions rely on.\nI checked in Insiders today and this is now looking good for us, without setting . Thank you so much for the speedy fix!\nmarking as verified by author.", "positive_passages": [{"docid": "doc-en-vscode-9c8c460aae989c99fcbf87003697aa612fde992cda047582e72c2c23ad8d121a", "text": "const pendingCommentText = this._pendingCommentCache[e.owner] && this._pendingCommentCache[e.owner][thread.threadId!]; this.displayCommentThread(e.owner, thread, pendingCommentText); this._commentInfos.filter(info => info.owner === e.owner)[0].threads.push(thread); <ins> this.tryUpdateReservedSpace(); </ins> }); this._commentThreadRangeDecorator.update(this.editor, commentInfo); }));", "commid": "vscode_pr_156448"}], "negative_passages": []}
{"query_id": "q-en-vscode-faac39c896e32727c630ce119fcc94bb07a48d496c145cc231f36e3be41ef7d5", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1-dev OS Version: web Steps to Reproduce: a in to get editor gutter decorations for and changed lines. a file with a single line change e.g. a word in line 5. The line will show an indicator in the editor gutter for the changed line, which when clicked will open a Quick Diff peek view. a on the same line. The editor gutter will display the comment gutter icon (diamond inside rectangle), which when clicked will expand or collapse the comment on that line, and hide the indicator for the changed content in the same line, preventing the user from noticing that there is a change or opening Quick Diff to inspect it.\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nWith multi-line comments () the impact is likely higher. As the user is likely to make changes in close proximity to comments to address issues raised, this may disproportionately limit the utility of Quick Diff. cc\nI'm not seeing them overlap: ! Am I looking at the correct thing?\nThat's the correct thing and in your screenshot it appears to be fine. Not sure why we are seeing the comment indicators draw over the change indicators, but we are also on a slightly older version and I am not sure if there are any other local adjustments in this space that I was not aware of. I will check this again on plain VS Code, sorry for the noise.\nIn 1.70.0-insider, I see this: for a multi-line change across the comment range: <img width=\"688\" alt=\"Screen Shot 2022-07-26 at 16 06 34\" src=\"https://user-\"- for a single-line change on the same line as the comment range: <img width=\"715\" alt=\"Screen Shot 2022-07-26 at 16 07 07\" src=\"https://user-\"This is for a simple Git repository, with a small test extension populating the comments. Caveat might be that it's \"read-only\" in the sense that I don't set , not sure if that causes problems? I see and draw in the same location and the comment thread wins because it has .\nI suspect that not having the range provider is causing this. Will try to fix for July, but will likely move to August.\nI tried setting a range provider, here are my observations: The docs for are wrong: When not provided, users cannot leave any comments\u2014I think this is actually fine\u2014and the gutter indicators overlap, as described. When setting a that returns for all documents, the behavior is the same as above. When setting a that returns , i.e. an empty range, the gutter indicators seem to draw correctly. However this also unexpectedly allows the user to start a discussion on line 1. For our extension, we don't want to support adding new comments on any lines, but otherwise show and allow replying to comments populated by the extension via the API. The reason is that our extension focuses primarily on supporting the author of a change / pull request in addressing the comments left by code reviewers in an external code review tool, i.e. they will almost never start a comment thread from their side. Allowing commenting on all lines of the file currently appears to draw an extremely distracting indicator through the entire gutter () which we strongly wish to avoid without requiring usage of Zen Mode. If the visuals of this were more subtle () we would not mind allowing users to comment on the entire file, even though it remains a rather rare use case for our user base.\nThe problem described in the original issue is a bug, which I will fix, You shouldn't need to have a commenting range provider at all. It sounds like there is also a doc bug, and an empty range bug, which I'll also look at. Regarding Zen mode: since the last update commenting is off by default in Zen Mode, so you shouldn't see any comments there. You can always toggle it back on with the command Comments: Toggle Editor Commenting.\nThe linked PR will fix the hidden decoration bug and the doc bug. I'm hesitant to make any changes for the range, as this may be intentional behavior or behavior that some extensions rely on.\nI checked in Insiders today and this is now looking good for us, without setting . Thank you so much for the speedy fix!\nmarking as verified by author.", "positive_passages": [{"docid": "doc-en-vscode-68c7a70cdb8e13263b9a89a10d056093067714ce4d45e90a9a4325a2ea0c4ee3", "text": "return; } <del> private setComments(commentInfos: ICommentInfo[]): void { if (!this.editor || !this.commentService.isCommentingEnabled) { return; } this._commentInfos = commentInfos; </del> <ins> private tryUpdateReservedSpace() { </ins> let lineDecorationsWidth: number = this.editor.getLayoutInfo().decorationsWidth; <ins> const hasCommentsOrRanges = this._commentInfos.some(info => { const hasRanges = Boolean(info.commentingRanges && (Array.isArray(info.commentingRanges) ? info.commentingRanges : info.commentingRanges.ranges).length); return hasRanges || (info.threads.length > 0); }); </ins> <del> if (this._commentInfos.some(info => Boolean(info.commentingRanges && (Array.isArray(info.commentingRanges) ? info.commentingRanges : info.commentingRanges.ranges).length))) { </del> <ins> if (hasCommentsOrRanges) { </ins> this._workspaceHasCommenting.set(true); if (!this._commentingRangeSpaceReserved) { this._commentingRangeSpaceReserved = true;", "commid": "vscode_pr_156448"}], "negative_passages": []}
{"query_id": "q-en-vscode-faac39c896e32727c630ce119fcc94bb07a48d496c145cc231f36e3be41ef7d5", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1-dev OS Version: web Steps to Reproduce: a in to get editor gutter decorations for and changed lines. a file with a single line change e.g. a word in line 5. The line will show an indicator in the editor gutter for the changed line, which when clicked will open a Quick Diff peek view. a on the same line. The editor gutter will display the comment gutter icon (diamond inside rectangle), which when clicked will expand or collapse the comment on that line, and hide the indicator for the changed content in the same line, preventing the user from noticing that there is a change or opening Quick Diff to inspect it.\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nWith multi-line comments () the impact is likely higher. As the user is likely to make changes in close proximity to comments to address issues raised, this may disproportionately limit the utility of Quick Diff. cc\nI'm not seeing them overlap: ! Am I looking at the correct thing?\nThat's the correct thing and in your screenshot it appears to be fine. Not sure why we are seeing the comment indicators draw over the change indicators, but we are also on a slightly older version and I am not sure if there are any other local adjustments in this space that I was not aware of. I will check this again on plain VS Code, sorry for the noise.\nIn 1.70.0-insider, I see this: for a multi-line change across the comment range: <img width=\"688\" alt=\"Screen Shot 2022-07-26 at 16 06 34\" src=\"https://user-\"- for a single-line change on the same line as the comment range: <img width=\"715\" alt=\"Screen Shot 2022-07-26 at 16 07 07\" src=\"https://user-\"This is for a simple Git repository, with a small test extension populating the comments. Caveat might be that it's \"read-only\" in the sense that I don't set , not sure if that causes problems? I see and draw in the same location and the comment thread wins because it has .\nI suspect that not having the range provider is causing this. Will try to fix for July, but will likely move to August.\nI tried setting a range provider, here are my observations: The docs for are wrong: When not provided, users cannot leave any comments\u2014I think this is actually fine\u2014and the gutter indicators overlap, as described. When setting a that returns for all documents, the behavior is the same as above. When setting a that returns , i.e. an empty range, the gutter indicators seem to draw correctly. However this also unexpectedly allows the user to start a discussion on line 1. For our extension, we don't want to support adding new comments on any lines, but otherwise show and allow replying to comments populated by the extension via the API. The reason is that our extension focuses primarily on supporting the author of a change / pull request in addressing the comments left by code reviewers in an external code review tool, i.e. they will almost never start a comment thread from their side. Allowing commenting on all lines of the file currently appears to draw an extremely distracting indicator through the entire gutter () which we strongly wish to avoid without requiring usage of Zen Mode. If the visuals of this were more subtle () we would not mind allowing users to comment on the entire file, even though it remains a rather rare use case for our user base.\nThe problem described in the original issue is a bug, which I will fix, You shouldn't need to have a commenting range provider at all. It sounds like there is also a doc bug, and an empty range bug, which I'll also look at. Regarding Zen mode: since the last update commenting is off by default in Zen Mode, so you shouldn't see any comments there. You can always toggle it back on with the command Comments: Toggle Editor Commenting.\nThe linked PR will fix the hidden decoration bug and the doc bug. I'm hesitant to make any changes for the range, as this may be intentional behavior or behavior that some extensions rely on.\nI checked in Insiders today and this is now looking good for us, without setting . Thank you so much for the speedy fix!\nmarking as verified by author.", "positive_passages": [{"docid": "doc-en-vscode-a41ff9b4a97c76238e12a06e0a360638a4be21e64a0200dcfb013f6f00a849c4", "text": "}); } } <ins> } private setComments(commentInfos: ICommentInfo[]): void { if (!this.editor || !this.commentService.isCommentingEnabled) { return; } this._commentInfos = commentInfos; this.tryUpdateReservedSpace(); </ins> // create viewzones this.removeCommentWidgetsAndStoreCache();", "commid": "vscode_pr_156448"}], "negative_passages": []}
{"query_id": "q-en-vscode-faac39c896e32727c630ce119fcc94bb07a48d496c145cc231f36e3be41ef7d5", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1-dev OS Version: web Steps to Reproduce: a in to get editor gutter decorations for and changed lines. a file with a single line change e.g. a word in line 5. The line will show an indicator in the editor gutter for the changed line, which when clicked will open a Quick Diff peek view. a on the same line. The editor gutter will display the comment gutter icon (diamond inside rectangle), which when clicked will expand or collapse the comment on that line, and hide the indicator for the changed content in the same line, preventing the user from noticing that there is a change or opening Quick Diff to inspect it.\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nWith multi-line comments () the impact is likely higher. As the user is likely to make changes in close proximity to comments to address issues raised, this may disproportionately limit the utility of Quick Diff. cc\nI'm not seeing them overlap: ! Am I looking at the correct thing?\nThat's the correct thing and in your screenshot it appears to be fine. Not sure why we are seeing the comment indicators draw over the change indicators, but we are also on a slightly older version and I am not sure if there are any other local adjustments in this space that I was not aware of. I will check this again on plain VS Code, sorry for the noise.\nIn 1.70.0-insider, I see this: for a multi-line change across the comment range: <img width=\"688\" alt=\"Screen Shot 2022-07-26 at 16 06 34\" src=\"https://user-\"- for a single-line change on the same line as the comment range: <img width=\"715\" alt=\"Screen Shot 2022-07-26 at 16 07 07\" src=\"https://user-\"This is for a simple Git repository, with a small test extension populating the comments. Caveat might be that it's \"read-only\" in the sense that I don't set , not sure if that causes problems? I see and draw in the same location and the comment thread wins because it has .\nI suspect that not having the range provider is causing this. Will try to fix for July, but will likely move to August.\nI tried setting a range provider, here are my observations: The docs for are wrong: When not provided, users cannot leave any comments\u2014I think this is actually fine\u2014and the gutter indicators overlap, as described. When setting a that returns for all documents, the behavior is the same as above. When setting a that returns , i.e. an empty range, the gutter indicators seem to draw correctly. However this also unexpectedly allows the user to start a discussion on line 1. For our extension, we don't want to support adding new comments on any lines, but otherwise show and allow replying to comments populated by the extension via the API. The reason is that our extension focuses primarily on supporting the author of a change / pull request in addressing the comments left by code reviewers in an external code review tool, i.e. they will almost never start a comment thread from their side. Allowing commenting on all lines of the file currently appears to draw an extremely distracting indicator through the entire gutter () which we strongly wish to avoid without requiring usage of Zen Mode. If the visuals of this were more subtle () we would not mind allowing users to comment on the entire file, even though it remains a rather rare use case for our user base.\nThe problem described in the original issue is a bug, which I will fix, You shouldn't need to have a commenting range provider at all. It sounds like there is also a doc bug, and an empty range bug, which I'll also look at. Regarding Zen mode: since the last update commenting is off by default in Zen Mode, so you shouldn't see any comments there. You can always toggle it back on with the command Comments: Toggle Editor Commenting.\nThe linked PR will fix the hidden decoration bug and the doc bug. I'm hesitant to make any changes for the range, as this may be intentional behavior or behavior that some extensions rely on.\nI checked in Insiders today and this is now looking good for us, without setting . Thank you so much for the speedy fix!\nmarking as verified by author.", "positive_passages": [{"docid": "doc-en-vscode-8c156d830dbf4f44b6e24fa19ded96ace1533477cd8765a839cbd52017492df9", "text": "/** * Optional commenting range provider. Provide a list {@link Range ranges} which support commenting to any given resource uri. * <del> * If not provided, users can leave comments in any document opened in the editor. </del> <ins> * If not provided, users cannot leave any comments. </ins> */ commentingRangeProvider?: CommentingRangeProvider;", "commid": "vscode_pr_156448"}], "negative_passages": []}
{"query_id": "q-en-vscode-ab8f8a01304c1e789eadff48c6c398f5da96d90877b714987774e9df98990e4f", "query": "Remove Manual Folding Range doesn't work Originally posted by in select a range in the editor invoke . Selection turns into a folding range put the cursor at the beginning of the collapsed line invoke . Should remove the manual folding range\nIt works when the cursor is at the second column or to the right of that, but not when it's right at the beginning of the line, which is exactly where it is placed after running the create manual folding range command.", "positive_passages": [{"docid": "doc-en-vscode-9de6e6d507fa0512ea7ae1949b0222b666591248ff152d5cd21e96de58ffc62d", "text": "public removeManualRanges(ranges: ILineRange[]) { const newFoldingRanges: FoldRange[] = new Array(); <del> const containedBy = (foldRange: FoldRange) => { </del> <ins> const intersects = (foldRange: FoldRange) => { </ins> for (const range of ranges) { <del> if (range.startLineNumber <= foldRange.startLineNumber && range.endLineNumber >= foldRange.endLineNumber) { </del> <ins> if (!(range.startLineNumber > foldRange.endLineNumber || foldRange.startLineNumber > range.endLineNumber)) { </ins> return true; } }", "commid": "vscode_pr_156278"}], "negative_passages": []}
{"query_id": "q-en-vscode-ab8f8a01304c1e789eadff48c6c398f5da96d90877b714987774e9df98990e4f", "query": "Remove Manual Folding Range doesn't work Originally posted by in select a range in the editor invoke . Selection turns into a folding range put the cursor at the beginning of the collapsed line invoke . Should remove the manual folding range\nIt works when the cursor is at the second column or to the right of that, but not when it's right at the beginning of the line, which is exactly where it is placed after running the create manual folding range command.", "positive_passages": [{"docid": "doc-en-vscode-fddd86c9e7aa839fbb532395f4050694cb23d4df168e40bf027ec97d4e831bb9", "text": "}; for (let i = 0; i < this._regions.length; i++) { const foldRange = this._regions.toFoldRange(i); <del> if (!foldRange.isUserDefined && !foldRange.isRecovered || !containedBy(foldRange)) { </del> <ins> if (!foldRange.isUserDefined && !foldRange.isRecovered || !intersects(foldRange)) { </ins> newFoldingRanges.push(foldRange); } }", "commid": "vscode_pr_156278"}], "negative_passages": []}
{"query_id": "q-en-vscode-ab8f8a01304c1e789eadff48c6c398f5da96d90877b714987774e9df98990e4f", "query": "Remove Manual Folding Range doesn't work Originally posted by in select a range in the editor invoke . Selection turns into a folding range put the cursor at the beginning of the collapsed line invoke . Should remove the manual folding range\nIt works when the cursor is at the second column or to the right of that, but not when it's right at the beginning of the line, which is exactly where it is placed after running the create manual folding range command.", "positive_passages": [{"docid": "doc-en-vscode-57b8c1627ef25b315a65fb5d42169c7888765319f0cc14e6fa09d668e93c186a", "text": "if (selections) { const ranges: ILineRange[] = []; for (const selection of selections) { <del> let endLineNumber = selection.endLineNumber; if (selection.endColumn === 1) { --endLineNumber; } const startLineNumber = selection.startLineNumber; ranges.push(endLineNumber >= selection.startLineNumber ? { startLineNumber, endLineNumber } : { endLineNumber, startLineNumber }); </del> <ins> const { startLineNumber, endLineNumber } = selection; ranges.push(endLineNumber >= startLineNumber ? { startLineNumber, endLineNumber } : { endLineNumber, startLineNumber }); </ins> } foldingModel.removeManualRanges(ranges); foldingController.triggerFoldingModelChanged();", "commid": "vscode_pr_156493"}], "negative_passages": []}
{"query_id": "q-en-vscode-b416a3a4e8687848c3a4be1900c209ff2cbf372c8a05042fa782816f3209f9bf", "query": "Testing open the emoji picker (ctrl+cmd+space) drag an emoji into the code editor observe that nothing happens from adding a breakpoint, I can observe that  is never invoked I'm not sure what's wrong, the same steps work fine when loading the editor by itself in a browser using . https://user-\nSeems to require holding down shift at the moment even though there is no overlay saying this\nI cannot drop an emoji into the monaco playground and also not into the TS playground. It also does not work in However it works on stable and stable VS Code when holding Shift as Matt suggested. I also do not see the drop feedback in insiders, so this looks like a regression to me.\nSorry, I think I got confused because in my insiders I have configured , so I do not see the drop indicator. I see no difference in behaviour between VSCode stable and insiders, so it is not a regression as far as I can tell. I can confirm that pressing makes this work\nOn our playground it does not work either but I am not even seeing the drop indicator: !\nThe editor at is around 6 months old, so there it doesn't work at all, I acknowledge that. In my original screen recording I was running the editor from sources. I am quite certain this used to work at some time (when Matt first did the PR at ). I'll try bisecting to see if that points to anything. The initial bisect points to\npoints to\nIf I comment out the following lines, then dropping text from TextEdit works, otherwise it doesn't: https://user- https://user-\nThe safest fix seems to be reverting the fix for by commenting out the block of code. Will push that for July and then investigate a proper solution that also in August\nCan't seem to get this to work with the Windows emoji picker and the drag/drop extension sample. Does this only work on mac?\nI only tested on Mac and don't know if this is supported on windows. Can you drag emoji into other apps, such as notepad?\nDoesn't look like it. Will close and leave for someone on mac to verify then.", "positive_passages": [{"docid": "doc-en-vscode-3bc9242b768e57526a9cd0f6bb436bffdd62c3d7b7ec58a95c28650b4c5ae713", "text": "private registerListeners(): void { this._register(addDisposableListener(this.container, EventType.DRAG_ENTER, e => this.onDragEnter(e))); this._register(addDisposableListener(this.container, EventType.DRAG_LEAVE, () => this.onDragLeave())); <del> this._register(addDisposableListener(this.container, EventType.DRAG_OVER, e => { if (!this.overlay) { this.onDragEnter(e); } })); </del> [this.container, window].forEach(node => this._register(addDisposableListener(node as HTMLElement, EventType.DRAG_END, () => this.onDragEnd()))); }", "commid": "vscode_pr_156516"}], "negative_passages": []}
{"query_id": "q-en-vscode-c6d14084c993895fbf5ee18922a5cf198b5fad9ad4e6101471f1e710643c17b2", "query": "Testing In Remote-WSL + bash + subshell, if I run and then use the command decoration to rerun the command, it instead runs . !\nThis is also the reason may be replaced by ; we're sending the alias resolved command line instead of the raw command line as input.\nWe should also verify this doesn't happen with aliases in zsh\nfyi verifier, reproduces in normal in a non-subshell\nto reproduce: in a terminal to see the ones you've defined the part to the left of the command decoration menu, the command's alias (part to the right of ) is the input\nit does not\nthe alias value is also displayed in the quickpick atm\nI thought of an even better idea to what we talked about, we could use the old history method to supplement our current better method; if there are no problematic histcontrol settings and the latest history command changed between precious and now, assume it was an alias and use that?\ncould you verify this one when you get a chance?\nstill seems to repro in Remote-WSL ! Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-23T10:56:12.685Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes\nDoes show anything? My Ubuntu wsl shows in which case we cannot use that history method which is a known edge case that I don't think we can handle currently and is not worth tracking imo.\nYeah the output is . Is there a value I can change that to which would allow me to verify the fix?\nit can be set to the empty string or - set this in your which should run before shell integration\n<img width=\"278\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-c75abe7b1741f2550dcc2365a41bc18384a90655cd0ea507501625ccae169f22", "text": "builtin printf \"x1b]633;P;IsWindows=Truex07\" fi <ins> # Allow verifying $BASH_COMMAND doesn't have aliases resolved via history when the right HISTCONTROL # configuration is used if [[ \"$HISTCONTROL\" =~ .*(erasedups|ignoreboth|ignoredups).* ]]; then __vsc_history_verify=0 else __vsc_history_verify=1 fi </ins> __vsc_initialized=0 __vsc_original_PS1=\"$PS1\" __vsc_original_PS2=\"$PS2\"", "commid": "vscode_pr_158794"}], "negative_passages": []}
{"query_id": "q-en-vscode-c6d14084c993895fbf5ee18922a5cf198b5fad9ad4e6101471f1e710643c17b2", "query": "Testing In Remote-WSL + bash + subshell, if I run and then use the command decoration to rerun the command, it instead runs . !\nThis is also the reason may be replaced by ; we're sending the alias resolved command line instead of the raw command line as input.\nWe should also verify this doesn't happen with aliases in zsh\nfyi verifier, reproduces in normal in a non-subshell\nto reproduce: in a terminal to see the ones you've defined the part to the left of the command decoration menu, the command's alias (part to the right of ) is the input\nit does not\nthe alias value is also displayed in the quickpick atm\nI thought of an even better idea to what we talked about, we could use the old history method to supplement our current better method; if there are no problematic histcontrol settings and the latest history command changed between precious and now, assume it was an alias and use that?\ncould you verify this one when you get a chance?\nstill seems to repro in Remote-WSL ! Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-23T10:56:12.685Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes\nDoes show anything? My Ubuntu wsl shows in which case we cannot use that history method which is a known edge case that I don't think we can handle currently and is not worth tracking imo.\nYeah the output is . Is there a value I can change that to which would allow me to verify the fix?\nit can be set to the empty string or - set this in your which should run before shell integration\n<img width=\"278\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-5ce8a9d882ef3e82f11dacc9abd477a95d58f460c5fcc9be93800e4804fe7dc3", "text": "__vsc_preexec() { __vsc_initialized=1 if [[ ! \"$BASH_COMMAND\" =~ ^__vsc_prompt* ]]; then <del> __vsc_current_command=$BASH_COMMAND </del> <ins> # Use history if it's available to verify the command as BASH_COMMAND comes in with aliases # resolved if [ \"$__vsc_history_verify\" = \"1\" ]; then __vsc_current_command=\"$(builtin history 1 | sed -r 's/ *[0-9]+ +//')\" else __vsc_current_command=$BASH_COMMAND fi </ins> else __vsc_current_command=\"\" fi", "commid": "vscode_pr_158794"}], "negative_passages": []}
{"query_id": "q-en-vscode-70835ae054def748002807da15840af3c0f017b88d7c9a9e525d0801687491d1", "query": "Type: <bBug</bTesting down in a TypeScript function ! Note that, In the screenshot, is actually at line 1344, the gutter doesn't have enough space for 4 numbers. Also, the visual separation between sticky lines and normal lines looks too subtle for me. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-29T10:47:14.408Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ Bookmarks13.3.1 remotehub0.39. remote-containers0.243.0 remote-ssh0.85. remote-ssh-edit0.80.0 remote-wsl0.66.3 remote-repositories0.16.0 material-icon-theme4.19.0 material-theme3.15.2 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 copilot-nightly1.36.6347 js-debug-nightly2022.7.2717 abracadabra6.14.4 vscode-jest4.6.0 prisma4.1.0 code-spell-checker2.3.4 </details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-2f594709e103f4cdc8141614bb3615dfa343ce097e555612d005638fa9674784", "text": "import { OutlineModel, OutlineElement } from 'vs/editor/contrib/documentSymbols/browser/outlineModel'; import { CancellationToken, CancellationTokenSource, } from 'vs/base/common/cancellation'; import * as dom from 'vs/base/browser/dom'; <del> import { EditorLayoutInfo, EditorOption } from 'vs/editor/common/config/editorOptions'; </del> <ins> import { EditorLayoutInfo, EditorOption, RenderLineNumbersType } from 'vs/editor/common/config/editorOptions'; </ins> import { createStringBuilder } from 'vs/editor/common/core/stringBuilder'; import { RenderLineInput, renderViewLine } from 'vs/editor/common/viewLayout/viewLineRenderer'; import { SymbolKind } from 'vs/editor/common/languages';", "commid": "vscode_pr_156992"}], "negative_passages": []}
{"query_id": "q-en-vscode-70835ae054def748002807da15840af3c0f017b88d7c9a9e525d0801687491d1", "query": "Type: <bBug</bTesting down in a TypeScript function ! Note that, In the screenshot, is actually at line 1344, the gutter doesn't have enough space for 4 numbers. Also, the visual separation between sticky lines and normal lines looks too subtle for me. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-29T10:47:14.408Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ Bookmarks13.3.1 remotehub0.39. remote-containers0.243.0 remote-ssh0.85. remote-ssh-edit0.80.0 remote-wsl0.66.3 remote-repositories0.16.0 material-icon-theme4.19.0 material-theme3.15.2 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 copilot-nightly1.36.6347 js-debug-nightly2022.7.2717 abracadabra6.14.4 vscode-jest4.6.0 prisma4.1.0 code-spell-checker2.3.4 </details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-05f5e8ccec777a1ca098296a79a15ec2cd05a623fb092ca43b14ceeb5ba7746c", "text": "this._sessionStore.add(this._editor.onDidLayoutChange(() => this._onDidResize())); this._sessionStore.add(this._editor.onDidChangeModelContent(() => this._updateSoon.schedule())); this._sessionStore.add(this._languageFeaturesService.documentSymbolProvider.onDidChange(() => this._update(true))); <ins> const lineNumberOption = this._editor.getOption(EditorOption.lineNumbers); if (lineNumberOption.renderType === RenderLineNumbersType.Relative) { this._sessionStore.add(this._editor.onDidChangeCursorPosition(() => this._update(false))); } </ins> this._update(true); } }", "commid": "vscode_pr_156992"}], "negative_passages": []}
{"query_id": "q-en-vscode-70835ae054def748002807da15840af3c0f017b88d7c9a9e525d0801687491d1", "query": "Type: <bBug</bTesting down in a TypeScript function ! Note that, In the screenshot, is actually at line 1344, the gutter doesn't have enough space for 4 numbers. Also, the visual separation between sticky lines and normal lines looks too subtle for me. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-29T10:47:14.408Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2 <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ Bookmarks13.3.1 remotehub0.39. remote-containers0.243.0 remote-ssh0.85. remote-ssh-edit0.80.0 remote-wsl0.66.3 remote-repositories0.16.0 material-icon-theme4.19.0 material-theme3.15.2 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 copilot-nightly1.36.6347 js-debug-nightly2022.7.2717 abracadabra6.14.4 vscode-jest4.6.0 prisma4.1.0 code-spell-checker2.3.4 </details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-aa353922148fba5dcb07d5df21e0bc3e3794ac1c658787a850ddd1117c525612", "text": "} const innerLineNumberHTML = document.createElement('span'); <del> innerLineNumberHTML.innerText = this._lineNumber.toString(); </del> <ins> const lineNumberOption = this._editor.getOption(EditorOption.lineNumbers); if (lineNumberOption.renderType === RenderLineNumbersType.On || lineNumberOption.renderType === RenderLineNumbersType.Interval && this._lineNumber % 10 === 0) { innerLineNumberHTML.innerText = this._lineNumber.toString(); } else if (lineNumberOption.renderType === RenderLineNumbersType.Relative) { innerLineNumberHTML.innerText = Math.abs(this._lineNumber - this._editor.getPosition().lineNumber).toString(); } </ins> innerLineNumberHTML.className = 'sticky-line-number'; innerLineNumberHTML.style.lineHeight = `${lineHeight}px`; innerLineNumberHTML.style.width = `${layoutInfo.lineNumbersWidth}px`;", "commid": "vscode_pr_156992"}], "negative_passages": []}
{"query_id": "q-en-vscode-ffcc3d0bc7628edb583a43939fe66354490ff9fc9aca8f64353551569fef7ed3", "query": "Does this issue occur when all extensions are disabled?: No VS Code Version: 1.70.0 OS Version: Debian 10.8 Steps to Reproduce: a zsh shell with a framework like zim installed shell integration zsh Observe: This breaks all my integrations and I lose history, etc... Usually because default settings do things like\nIn WSL: Ubuntu-22.04, z4h (zsh for humans) is telling me my ZDOTDIR has been set to /tmp/vscode-zsh . I updated to VSCode 1.70.0 and noticed this. It's a shame because the shell integration worked so well in 1.69.x.\nI'll check this out tomorrow but it seems like a candidate for the recovery release. In the meantime you can disable shell integration in your settings and install it manually with these instructions:\nThis appears to be the only change around ZDOTDIR since 1.69:\nI will echo this has also broken my shell configuration to load an SDK for a certain VSCode workspace because it hijacks the early on and doesn't provide any hooks to work around that.\nI can reproduce this when using a non-login shell. That's because we reset the in the login rc file which only runs for login shells. Unrelated to the history change\nThanks.\nwe're planning on releasing the fix in the next couple of days\nit's already available in the\nto verify, set your to something in your . remove the login args from the profile. and verify that it's whatever you set.\nAs of 1.70.1, macOS 12.5, this is still broken for me:\nlooks like we should try to detect if this is used and disable shell integration\nFYI, I've tested on macOS, WSL/Win 11, and ChromeOS. On WSL and ChromeOS, ZDOTDIR is set to /tmp/vscode-zsh, but otherwise it's the same as on macOS. When I turn off Shell Integration in the settings and open a new Terminal instance, shell integration appears to work. So maybe has the right idea. And as I said earlier in the thread, this worked without issue on 1.69.x.\nsetting to worked for now\nI think zsh4humans uses powerlevel10k which disables shell integration (or will disable it in the next version?). I think to fix this we actually need to add or something similar similar inside this if statement: Alternatively, should this line be moved above the check? To test this without plugins, unsetting inside your rc should repro.\nI don't think that line can be moved above or will override the temporary we have set for vscode but think as you said, we need to also add it before returning when it's been disabled\nOr can we remove this: Either there or at the end of whatever injected zsh script that runs last.\nwe could remove it there for non-login shells. for login shells, it gets reset here and probably can remove line 6\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'm trying to set in my .zshrc, but it always ends up reset to my home directory, same behavior in stable/insiders. But I'm not sure whether there is something in my zsh config that does that.\nthe gets set in not your\nTried that, and it seems like ZDOTDIR ends up set to a tmp folder <img width=\"636\" alt=\"image\" src=\"https://user-\"\nnot sure then - it works for me - it's the only thing in my file though\nI encountered the same problem as I used the following version of Insider, which seems to be fixed in commit , but the problem is not fixed. `\nhey all, I've also run into this, not 100% sure though if it's exactly the same or \"just\" related. I use remote container extension with a Debian based container and ZDOTDIR env isn't respected as long as shellIntegration is enabled. Actually I was using regular code but tried insiders after reading the comments here, without any success. let me know if I should provide more details - I tried so many combinations I can't really exactly remember right now, but of course I'm happy to try something specific if it helps.\nIs this fix supposed to be live to the stable release now? If so, I am still having this issue when using zsh4humans.\nIt's not yet in stable. it should be fixed in insider's now though by\nIs this fix scheduled for the next stable version? and when would that be?\nyes, it will be next week", "positive_passages": [{"docid": "doc-en-vscode-e44d5a1f632b0968e9e24d829ef09cf7edeb69162e30d5c4f86e869b22e0ae6a", "text": "} add-zsh-hook precmd __vsc_precmd add-zsh-hook preexec __vsc_preexec <ins> if [[ $options[login] = off ]]; then ZDOTDIR=$USER_ZDOTDIR fi </ins>", "commid": "vscode_pr_157348"}], "negative_passages": []}
{"query_id": "q-en-vscode-ffcc3d0bc7628edb583a43939fe66354490ff9fc9aca8f64353551569fef7ed3", "query": "Does this issue occur when all extensions are disabled?: No VS Code Version: 1.70.0 OS Version: Debian 10.8 Steps to Reproduce: a zsh shell with a framework like zim installed shell integration zsh Observe: This breaks all my integrations and I lose history, etc... Usually because default settings do things like\nIn WSL: Ubuntu-22.04, z4h (zsh for humans) is telling me my ZDOTDIR has been set to /tmp/vscode-zsh . I updated to VSCode 1.70.0 and noticed this. It's a shame because the shell integration worked so well in 1.69.x.\nI'll check this out tomorrow but it seems like a candidate for the recovery release. In the meantime you can disable shell integration in your settings and install it manually with these instructions:\nThis appears to be the only change around ZDOTDIR since 1.69:\nI will echo this has also broken my shell configuration to load an SDK for a certain VSCode workspace because it hijacks the early on and doesn't provide any hooks to work around that.\nI can reproduce this when using a non-login shell. That's because we reset the in the login rc file which only runs for login shells. Unrelated to the history change\nThanks.\nwe're planning on releasing the fix in the next couple of days\nit's already available in the\nto verify, set your to something in your . remove the login args from the profile. and verify that it's whatever you set.\nAs of 1.70.1, macOS 12.5, this is still broken for me:\nlooks like we should try to detect if this is used and disable shell integration\nFYI, I've tested on macOS, WSL/Win 11, and ChromeOS. On WSL and ChromeOS, ZDOTDIR is set to /tmp/vscode-zsh, but otherwise it's the same as on macOS. When I turn off Shell Integration in the settings and open a new Terminal instance, shell integration appears to work. So maybe has the right idea. And as I said earlier in the thread, this worked without issue on 1.69.x.\nsetting to worked for now\nI think zsh4humans uses powerlevel10k which disables shell integration (or will disable it in the next version?). I think to fix this we actually need to add or something similar similar inside this if statement: Alternatively, should this line be moved above the check? To test this without plugins, unsetting inside your rc should repro.\nI don't think that line can be moved above or will override the temporary we have set for vscode but think as you said, we need to also add it before returning when it's been disabled\nOr can we remove this: Either there or at the end of whatever injected zsh script that runs last.\nwe could remove it there for non-login shells. for login shells, it gets reset here and probably can remove line 6\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'm trying to set in my .zshrc, but it always ends up reset to my home directory, same behavior in stable/insiders. But I'm not sure whether there is something in my zsh config that does that.\nthe gets set in not your\nTried that, and it seems like ZDOTDIR ends up set to a tmp folder <img width=\"636\" alt=\"image\" src=\"https://user-\"\nnot sure then - it works for me - it's the only thing in my file though\nI encountered the same problem as I used the following version of Insider, which seems to be fixed in commit , but the problem is not fixed. `\nhey all, I've also run into this, not 100% sure though if it's exactly the same or \"just\" related. I use remote container extension with a Debian based container and ZDOTDIR env isn't respected as long as shellIntegration is enabled. Actually I was using regular code but tried insiders after reading the comments here, without any success. let me know if I should provide more details - I tried so many combinations I can't really exactly remember right now, but of course I'm happy to try something specific if it helps.\nIs this fix supposed to be live to the stable release now? If so, I am still having this issue when using zsh4humans.\nIt's not yet in stable. it should be fixed in insider's now though by\nIs this fix scheduled for the next stable version? and when would that be?\nyes, it will be next week", "positive_passages": [{"docid": "doc-en-vscode-e44d5a1f632b0968e9e24d829ef09cf7edeb69162e30d5c4f86e869b22e0ae6a", "text": "} add-zsh-hook precmd __vsc_precmd add-zsh-hook preexec __vsc_preexec <ins> if [[ $options[login] = off ]]; then ZDOTDIR=$USER_ZDOTDIR fi </ins>", "commid": "vscode_pr_157520"}], "negative_passages": []}
{"query_id": "q-en-vscode-ffcc3d0bc7628edb583a43939fe66354490ff9fc9aca8f64353551569fef7ed3", "query": "Does this issue occur when all extensions are disabled?: No VS Code Version: 1.70.0 OS Version: Debian 10.8 Steps to Reproduce: a zsh shell with a framework like zim installed shell integration zsh Observe: This breaks all my integrations and I lose history, etc... Usually because default settings do things like\nIn WSL: Ubuntu-22.04, z4h (zsh for humans) is telling me my ZDOTDIR has been set to /tmp/vscode-zsh . I updated to VSCode 1.70.0 and noticed this. It's a shame because the shell integration worked so well in 1.69.x.\nI'll check this out tomorrow but it seems like a candidate for the recovery release. In the meantime you can disable shell integration in your settings and install it manually with these instructions:\nThis appears to be the only change around ZDOTDIR since 1.69:\nI will echo this has also broken my shell configuration to load an SDK for a certain VSCode workspace because it hijacks the early on and doesn't provide any hooks to work around that.\nI can reproduce this when using a non-login shell. That's because we reset the in the login rc file which only runs for login shells. Unrelated to the history change\nThanks.\nwe're planning on releasing the fix in the next couple of days\nit's already available in the\nto verify, set your to something in your . remove the login args from the profile. and verify that it's whatever you set.\nAs of 1.70.1, macOS 12.5, this is still broken for me:\nlooks like we should try to detect if this is used and disable shell integration\nFYI, I've tested on macOS, WSL/Win 11, and ChromeOS. On WSL and ChromeOS, ZDOTDIR is set to /tmp/vscode-zsh, but otherwise it's the same as on macOS. When I turn off Shell Integration in the settings and open a new Terminal instance, shell integration appears to work. So maybe has the right idea. And as I said earlier in the thread, this worked without issue on 1.69.x.\nsetting to worked for now\nI think zsh4humans uses powerlevel10k which disables shell integration (or will disable it in the next version?). I think to fix this we actually need to add or something similar similar inside this if statement: Alternatively, should this line be moved above the check? To test this without plugins, unsetting inside your rc should repro.\nI don't think that line can be moved above or will override the temporary we have set for vscode but think as you said, we need to also add it before returning when it's been disabled\nOr can we remove this: Either there or at the end of whatever injected zsh script that runs last.\nwe could remove it there for non-login shells. for login shells, it gets reset here and probably can remove line 6\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'm trying to set in my .zshrc, but it always ends up reset to my home directory, same behavior in stable/insiders. But I'm not sure whether there is something in my zsh config that does that.\nthe gets set in not your\nTried that, and it seems like ZDOTDIR ends up set to a tmp folder <img width=\"636\" alt=\"image\" src=\"https://user-\"\nnot sure then - it works for me - it's the only thing in my file though\nI encountered the same problem as I used the following version of Insider, which seems to be fixed in commit , but the problem is not fixed. `\nhey all, I've also run into this, not 100% sure though if it's exactly the same or \"just\" related. I use remote container extension with a Debian based container and ZDOTDIR env isn't respected as long as shellIntegration is enabled. Actually I was using regular code but tried insiders after reading the comments here, without any success. let me know if I should provide more details - I tried so many combinations I can't really exactly remember right now, but of course I'm happy to try something specific if it helps.\nIs this fix supposed to be live to the stable release now? If so, I am still having this issue when using zsh4humans.\nIt's not yet in stable. it should be fixed in insider's now though by\nIs this fix scheduled for the next stable version? and when would that be?\nyes, it will be next week", "positive_passages": [{"docid": "doc-en-vscode-e3d0d6b72c6613c80c46536bb862f5e608ac533eead3781c740ebfecb0a9d380", "text": "# Prevent the script recursing when setting up if [ -n \"$VSCODE_SHELL_INTEGRATION\" ]; then <ins> ZDOTDIR=$USER_ZDOTDIR </ins> builtin return fi", "commid": "vscode_pr_158132"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb38c5540de33ba66f351eeb068e2ac5ad3de6f4a176358feb3564d2e10790bf", "query": "Repro: folder test task, wait to finish another terminal test task again <img width=\"1344\" alt=\"Screen Shot 2022-08-07 at 11 40 14 am\" src=\"https://user-\"\nIn repo, ctrl+shift+b is focusing the terminal: !\nReproduces on webgl only\nGuessing it's related to canvas recreation:\nYep: !", "positive_passages": [{"docid": "doc-en-vscode-2f7df1e93f7570437d3bb23076cba06f77de1de2208b950b16fe5e7683306160", "text": "\"vscode-proxy-agent\": \"^0.12.0\", \"vscode-regexpp\": \"^3.1.0\", \"vscode-textmate\": \"7.0.1\", <del> \"xterm\": \"5.0.0-beta.32\", \"xterm-addon-canvas\": \"0.2.0-beta.15\", \"xterm-addon-search\": \"0.10.0-beta.3\", \"xterm-addon-serialize\": \"0.8.0-beta.3\", \"xterm-addon-unicode11\": \"0.4.0-beta.3\", \"xterm-addon-webgl\": \"0.13.0-beta.32\", </del> <ins> \"xterm\": \"5.0.0-beta.35\", \"xterm-addon-canvas\": \"0.2.0-beta.17\", \"xterm-addon-search\": \"0.10.0-beta.5\", \"xterm-addon-serialize\": \"0.8.0-beta.5\", \"xterm-addon-unicode11\": \"0.4.0-beta.5\", \"xterm-addon-webgl\": \"0.13.0-beta.35\", </ins> \"xterm-headless\": \"5.0.0-beta.5\", \"yauzl\": \"^2.9.2\", \"yazl\": \"^2.4.3\"", "commid": "vscode_pr_157790"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb38c5540de33ba66f351eeb068e2ac5ad3de6f4a176358feb3564d2e10790bf", "query": "Repro: folder test task, wait to finish another terminal test task again <img width=\"1344\" alt=\"Screen Shot 2022-08-07 at 11 40 14 am\" src=\"https://user-\"\nIn repo, ctrl+shift+b is focusing the terminal: !\nReproduces on webgl only\nGuessing it's related to canvas recreation:\nYep: !", "positive_passages": [{"docid": "doc-en-vscode-b2079e441e1eb79b5ba5d52e874817cc0c68af1abe4d2e21dcf38eea6fa88c38", "text": "\"tas-client-umd\": \"0.1.6\", \"vscode-oniguruma\": \"1.6.1\", \"vscode-textmate\": \"7.0.1\", <del> \"xterm\": \"5.0.0-beta.32\", \"xterm-addon-canvas\": \"0.2.0-beta.15\", \"xterm-addon-search\": \"0.10.0-beta.3\", \"xterm-addon-unicode11\": \"0.4.0-beta.3\", \"xterm-addon-webgl\": \"0.13.0-beta.32\" </del> <ins> \"xterm\": \"5.0.0-beta.35\", \"xterm-addon-canvas\": \"0.2.0-beta.17\", \"xterm-addon-search\": \"0.10.0-beta.5\", \"xterm-addon-unicode11\": \"0.4.0-beta.5\", \"xterm-addon-webgl\": \"0.13.0-beta.35\" </ins> } }", "commid": "vscode_pr_157790"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb38c5540de33ba66f351eeb068e2ac5ad3de6f4a176358feb3564d2e10790bf", "query": "Repro: folder test task, wait to finish another terminal test task again <img width=\"1344\" alt=\"Screen Shot 2022-08-07 at 11 40 14 am\" src=\"https://user-\"\nIn repo, ctrl+shift+b is focusing the terminal: !\nReproduces on webgl only\nGuessing it's related to canvas recreation:\nYep: !", "positive_passages": [{"docid": "doc-en-vscode-02a4b0f5d203113c6d6cda6f76869c5e9a3df4049b473e70cad689161c918fb5", "text": "resolved \"https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-7.0.1.tgz#8118a32b02735dccd14f893b495fa5389ad7de79\" integrity sha512-zQ5U/nuXAAMsh691FtV0wPz89nSkHbs+IQV8FDk+wew9BlSDhf4UmWGlWJfTR2Ti6xZv87Tj5fENzKf6Qk7aLw== <del> xterm-addon-canvas@0.2.0-beta.15: version \"0.2.0-beta.15\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.2.0-beta.15.tgz#de863e46410b1de357b153abf1984227777760e4\" integrity sha512-E1pNCDSVTINchwWLysZ9ZD/BPv1WLGV52xRHB00US1PHHELbhtvms+6dZ44WZEDXhtfpptRZ1VBx+QpvfJIuvw== xterm-addon-search@0.10.0-beta.3: version \"0.10.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.3.tgz#5194434d86105637c71f6f20139a9d0b5c1a956a\" integrity sha512-UeGm/ymnp7HUYJJtsP0D+bljOWbdk3MctcLJ+0jv8AmU6YlAzJFtouvYSQrD5SAMyht5CRsvjzFgqic9X02JYg== xterm-addon-unicode11@0.4.0-beta.3: version \"0.4.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa\" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== xterm-addon-webgl@0.13.0-beta.32: version \"0.13.0-beta.32\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.32.tgz#ae7335f788ae611733e03f6ca38280ab7b86d212\" integrity sha512-xOudNzYXaRh9QZ+IigXM5EB3bM8l3/F8F35EpJRYvvsylVxiB6Km8X8l7+nxlWt+uYdnHZs0ka2rvtL8kOP/uw== xterm@5.0.0-beta.32: version \"5.0.0-beta.32\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.0.0-beta.32.tgz#62bb9902429c0055fd2fd85c9eecfbf1756ed31c\" integrity sha512-OAM1GaBs/chK63Cr86XbVhfVCLLXLpNxxFrv3RK9xoyb9dwiY3gaMxK9jeGzTnrbGLWJb+k5nxaC0rx2YsHvUA== </del> <ins> xterm-addon-canvas@0.2.0-beta.17: version \"0.2.0-beta.17\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.2.0-beta.17.tgz#e84a86530b20bd3edcce16b4566f346cd186ab4d\" integrity sha512-2ukPdCA92VTFYQRE56ylzvI3cfaQYDWd/Mc4jlEItI6sV/EA5RnUbbP+2sFIx0JlmHK6nVYXXNY2p6QRB7MRew== xterm-addon-search@0.10.0-beta.5: version \"0.10.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.5.tgz#a2cb16bda4ddf8783b80433155ad94f5822271f8\" integrity sha512-kjog7cm1iEZ2XyQFVs3KAvoI2pKoX0cq2WWjL0FuXYXpKQ9vXmfrWSR7PiJ6zpTIRvr6UtaSGKhmZVHLNA79WA== xterm-addon-unicode11@0.4.0-beta.5: version \"0.4.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.5.tgz#3900e66f10d2e506133b61d7421aab6878d32665\" integrity sha512-+g+fuxAd/tkCEJ/jhdnebXKtdPrhsu4VKWNnB/3qM35GbuGQOasmYFYnKL+HYZMpbQ6YqeZcXTVg/wnCTttz0g== xterm-addon-webgl@0.13.0-beta.35: version \"0.13.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.35.tgz#98b5dc102583120de25c7c6e0f35cd34ab6bef98\" integrity sha512-powgeb3ifEZK7zWwLJuE8YRz/Z0UzDrrVA9NTx9mH7+vWxrGt9ZgroychoeCqZBvKMofiUM5vlf1oWdSmsMfzw== xterm@5.0.0-beta.35: version \"5.0.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.0.0-beta.35.tgz#3bbf5780c98aaaa6476e7590dff1d8f5014fce9d\" integrity sha512-tzJTel1E/FmB0VQDb44xApVB+ln+BifIbHD4V9x9Z3D9m1cMmPHy8J8efdILkn1TxXGlCl7VC35nG122Qq5exw== </ins>", "commid": "vscode_pr_157790"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb38c5540de33ba66f351eeb068e2ac5ad3de6f4a176358feb3564d2e10790bf", "query": "Repro: folder test task, wait to finish another terminal test task again <img width=\"1344\" alt=\"Screen Shot 2022-08-07 at 11 40 14 am\" src=\"https://user-\"\nIn repo, ctrl+shift+b is focusing the terminal: !\nReproduces on webgl only\nGuessing it's related to canvas recreation:\nYep: !", "positive_passages": [{"docid": "doc-en-vscode-3c37e5bc2a3cf0c3e224ea0e8666af1fc49dfdb98213ee7610b75059d381615e", "text": "resolved \"https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f\" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-canvas@0.2.0-beta.15: version \"0.2.0-beta.15\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.2.0-beta.15.tgz#de863e46410b1de357b153abf1984227777760e4\" integrity sha512-E1pNCDSVTINchwWLysZ9ZD/BPv1WLGV52xRHB00US1PHHELbhtvms+6dZ44WZEDXhtfpptRZ1VBx+QpvfJIuvw== xterm-addon-search@0.10.0-beta.3: version \"0.10.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.3.tgz#5194434d86105637c71f6f20139a9d0b5c1a956a\" integrity sha512-UeGm/ymnp7HUYJJtsP0D+bljOWbdk3MctcLJ+0jv8AmU6YlAzJFtouvYSQrD5SAMyht5CRsvjzFgqic9X02JYg== xterm-addon-serialize@0.8.0-beta.3: version \"0.8.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.8.0-beta.3.tgz#47ade3fedacbb75bd26e63cfe0120586623e0e4f\" integrity sha512-gvfempZCYuAhLqN4O6fA2TuoavPjOxFKlh8hLcOzPackiLUhwKr1jQpDXcnq8VgqUiGgb+XNZpPEbI0Q7EhTgA== xterm-addon-unicode11@0.4.0-beta.3: version \"0.4.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa\" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== xterm-addon-webgl@0.13.0-beta.32: version \"0.13.0-beta.32\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.32.tgz#ae7335f788ae611733e03f6ca38280ab7b86d212\" integrity sha512-xOudNzYXaRh9QZ+IigXM5EB3bM8l3/F8F35EpJRYvvsylVxiB6Km8X8l7+nxlWt+uYdnHZs0ka2rvtL8kOP/uw== </del> <ins> xterm-addon-canvas@0.2.0-beta.17: version \"0.2.0-beta.17\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.2.0-beta.17.tgz#e84a86530b20bd3edcce16b4566f346cd186ab4d\" integrity sha512-2ukPdCA92VTFYQRE56ylzvI3cfaQYDWd/Mc4jlEItI6sV/EA5RnUbbP+2sFIx0JlmHK6nVYXXNY2p6QRB7MRew== xterm-addon-search@0.10.0-beta.5: version \"0.10.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.5.tgz#a2cb16bda4ddf8783b80433155ad94f5822271f8\" integrity sha512-kjog7cm1iEZ2XyQFVs3KAvoI2pKoX0cq2WWjL0FuXYXpKQ9vXmfrWSR7PiJ6zpTIRvr6UtaSGKhmZVHLNA79WA== xterm-addon-serialize@0.8.0-beta.5: version \"0.8.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.8.0-beta.5.tgz#3d2f3be173f4f1c31ae7bf25179e8ecddf2b33b2\" integrity sha512-rkSUaO1XBcy3ipScZMA5PrOKu/DfXo8XC/V7hZlhMiBNbZKlbk2rFb3X0FB1f07hw7oEkHLjuIJEY5Qtxfe9/w== xterm-addon-unicode11@0.4.0-beta.5: version \"0.4.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.5.tgz#3900e66f10d2e506133b61d7421aab6878d32665\" integrity sha512-+g+fuxAd/tkCEJ/jhdnebXKtdPrhsu4VKWNnB/3qM35GbuGQOasmYFYnKL+HYZMpbQ6YqeZcXTVg/wnCTttz0g== xterm-addon-webgl@0.13.0-beta.35: version \"0.13.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.35.tgz#98b5dc102583120de25c7c6e0f35cd34ab6bef98\" integrity sha512-powgeb3ifEZK7zWwLJuE8YRz/Z0UzDrrVA9NTx9mH7+vWxrGt9ZgroychoeCqZBvKMofiUM5vlf1oWdSmsMfzw== </ins> xterm-headless@5.0.0-beta.5: version \"5.0.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.0.0-beta.5.tgz#e29b6c5081f31f887122b7263ba996b0c46b3c22\" integrity sha512-CMQ1+prBNF92oBMeZzc2rfTcmOaCGfwwSaoPYNTjyziZT6mZsEg7amajYkb0YAnqJ29MFm4kPGZbU78/dX4k2A== <del> xterm@5.0.0-beta.32: version \"5.0.0-beta.32\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.0.0-beta.32.tgz#62bb9902429c0055fd2fd85c9eecfbf1756ed31c\" integrity sha512-OAM1GaBs/chK63Cr86XbVhfVCLLXLpNxxFrv3RK9xoyb9dwiY3gaMxK9jeGzTnrbGLWJb+k5nxaC0rx2YsHvUA== </del> <ins> xterm@5.0.0-beta.35: version \"5.0.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.0.0-beta.35.tgz#3bbf5780c98aaaa6476e7590dff1d8f5014fce9d\" integrity sha512-tzJTel1E/FmB0VQDb44xApVB+ln+BifIbHD4V9x9Z3D9m1cMmPHy8J8efdILkn1TxXGlCl7VC35nG122Qq5exw== </ins> yallist@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_157790"}], "negative_passages": []}
{"query_id": "q-en-vscode-eb38c5540de33ba66f351eeb068e2ac5ad3de6f4a176358feb3564d2e10790bf", "query": "Repro: folder test task, wait to finish another terminal test task again <img width=\"1344\" alt=\"Screen Shot 2022-08-07 at 11 40 14 am\" src=\"https://user-\"\nIn repo, ctrl+shift+b is focusing the terminal: !\nReproduces on webgl only\nGuessing it's related to canvas recreation:\nYep: !", "positive_passages": [{"docid": "doc-en-vscode-7adf0388cba0a20bd9e3b2695af0408227b00f5219720132aec0460ab7dea69c", "text": "dependencies: object-keys \"~0.4.0\" <del> xterm-addon-canvas@0.2.0-beta.15: version \"0.2.0-beta.15\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.2.0-beta.15.tgz#de863e46410b1de357b153abf1984227777760e4\" integrity sha512-E1pNCDSVTINchwWLysZ9ZD/BPv1WLGV52xRHB00US1PHHELbhtvms+6dZ44WZEDXhtfpptRZ1VBx+QpvfJIuvw== xterm-addon-search@0.10.0-beta.3: version \"0.10.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.3.tgz#5194434d86105637c71f6f20139a9d0b5c1a956a\" integrity sha512-UeGm/ymnp7HUYJJtsP0D+bljOWbdk3MctcLJ+0jv8AmU6YlAzJFtouvYSQrD5SAMyht5CRsvjzFgqic9X02JYg== xterm-addon-serialize@0.8.0-beta.3: version \"0.8.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.8.0-beta.3.tgz#47ade3fedacbb75bd26e63cfe0120586623e0e4f\" integrity sha512-gvfempZCYuAhLqN4O6fA2TuoavPjOxFKlh8hLcOzPackiLUhwKr1jQpDXcnq8VgqUiGgb+XNZpPEbI0Q7EhTgA== xterm-addon-unicode11@0.4.0-beta.3: version \"0.4.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.3.tgz#f350184155fafd5ad0d6fbf31d13e6ca7dea1efa\" integrity sha512-FryZAVwbUjKTmwXnm1trch/2XO60F5JsDvOkZhzobV1hm10sFLVuZpFyHXiUx7TFeeFsvNP+S77LAtWoeT5z+Q== xterm-addon-webgl@0.13.0-beta.32: version \"0.13.0-beta.32\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.32.tgz#ae7335f788ae611733e03f6ca38280ab7b86d212\" integrity sha512-xOudNzYXaRh9QZ+IigXM5EB3bM8l3/F8F35EpJRYvvsylVxiB6Km8X8l7+nxlWt+uYdnHZs0ka2rvtL8kOP/uw== </del> <ins> xterm-addon-canvas@0.2.0-beta.17: version \"0.2.0-beta.17\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.2.0-beta.17.tgz#e84a86530b20bd3edcce16b4566f346cd186ab4d\" integrity sha512-2ukPdCA92VTFYQRE56ylzvI3cfaQYDWd/Mc4jlEItI6sV/EA5RnUbbP+2sFIx0JlmHK6nVYXXNY2p6QRB7MRew== xterm-addon-search@0.10.0-beta.5: version \"0.10.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.10.0-beta.5.tgz#a2cb16bda4ddf8783b80433155ad94f5822271f8\" integrity sha512-kjog7cm1iEZ2XyQFVs3KAvoI2pKoX0cq2WWjL0FuXYXpKQ9vXmfrWSR7PiJ6zpTIRvr6UtaSGKhmZVHLNA79WA== xterm-addon-serialize@0.8.0-beta.5: version \"0.8.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.8.0-beta.5.tgz#3d2f3be173f4f1c31ae7bf25179e8ecddf2b33b2\" integrity sha512-rkSUaO1XBcy3ipScZMA5PrOKu/DfXo8XC/V7hZlhMiBNbZKlbk2rFb3X0FB1f07hw7oEkHLjuIJEY5Qtxfe9/w== xterm-addon-unicode11@0.4.0-beta.5: version \"0.4.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.4.0-beta.5.tgz#3900e66f10d2e506133b61d7421aab6878d32665\" integrity sha512-+g+fuxAd/tkCEJ/jhdnebXKtdPrhsu4VKWNnB/3qM35GbuGQOasmYFYnKL+HYZMpbQ6YqeZcXTVg/wnCTttz0g== xterm-addon-webgl@0.13.0-beta.35: version \"0.13.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.13.0-beta.35.tgz#98b5dc102583120de25c7c6e0f35cd34ab6bef98\" integrity sha512-powgeb3ifEZK7zWwLJuE8YRz/Z0UzDrrVA9NTx9mH7+vWxrGt9ZgroychoeCqZBvKMofiUM5vlf1oWdSmsMfzw== </ins> xterm-headless@5.0.0-beta.5: version \"5.0.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.0.0-beta.5.tgz#e29b6c5081f31f887122b7263ba996b0c46b3c22\" integrity sha512-CMQ1+prBNF92oBMeZzc2rfTcmOaCGfwwSaoPYNTjyziZT6mZsEg7amajYkb0YAnqJ29MFm4kPGZbU78/dX4k2A== <del> xterm@5.0.0-beta.32: version \"5.0.0-beta.32\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.0.0-beta.32.tgz#62bb9902429c0055fd2fd85c9eecfbf1756ed31c\" integrity sha512-OAM1GaBs/chK63Cr86XbVhfVCLLXLpNxxFrv3RK9xoyb9dwiY3gaMxK9jeGzTnrbGLWJb+k5nxaC0rx2YsHvUA== </del> <ins> xterm@5.0.0-beta.35: version \"5.0.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.0.0-beta.35.tgz#3bbf5780c98aaaa6476e7590dff1d8f5014fce9d\" integrity sha512-tzJTel1E/FmB0VQDb44xApVB+ln+BifIbHD4V9x9Z3D9m1cMmPHy8J8efdILkn1TxXGlCl7VC35nG122Qq5exw== </ins> y18n@^3.2.1: version \"3.2.2\"", "commid": "vscode_pr_157790"}], "negative_passages": []}
{"query_id": "q-en-vscode-d492bf2b1f9b3e2eb9d93bbd24d50ffd453e825c1424dfdfa420c18606ee5486", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:\nwill you create a test plan item/verification steps for this feature?\nyes I will!", "positive_passages": [{"docid": "doc-en-vscode-770adf3916dbf851dcc8531b320bedd3c165fa10a0569d81bbea73a1f9e43d15", "text": "); } <del> async cloneRepository(url?: string, parentPath?: string, options: { recursive?: boolean } = {}): Promise<void> { </del> <ins> async cloneRepository(url?: string, parentPath?: string, options: { recursive?: boolean; ref?: string } = {}): Promise<void> { </ins> if (!url || typeof url !== 'string') { url = await pickRemoteSource({ providerLabel: provider => localize('clonefrom', \"Clone from {0}\", provider.name),", "commid": "vscode_pr_159481"}], "negative_passages": []}
{"query_id": "q-en-vscode-d492bf2b1f9b3e2eb9d93bbd24d50ffd453e825c1424dfdfa420c18606ee5486", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:\nwill you create a test plan item/verification steps for this feature?\nyes I will!", "positive_passages": [{"docid": "doc-en-vscode-9a76fb1743fbefae4f57573b0387195dd85ead2466738534723c5b24ca4dd8ea", "text": "(progress, token) => this.git.clone(url!, { parentPath: parentPath!, progress, recursive: options.recursive }, token) ); <ins> if (options.ref !== undefined) { const repository = this.model.getRepository(Uri.file(repositoryPath)); await repository?.checkout(options.ref); } </ins> const config = workspace.getConfiguration('git'); const openAfterClone = config.get<'always' | 'alwaysNewWindow' | 'whenNoFolderOpen' | 'prompt'>('openAfterClone');", "commid": "vscode_pr_159481"}], "negative_passages": []}
{"query_id": "q-en-vscode-d492bf2b1f9b3e2eb9d93bbd24d50ffd453e825c1424dfdfa420c18606ee5486", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:\nwill you create a test plan item/verification steps for this feature?\nyes I will!", "positive_passages": [{"docid": "doc-en-vscode-8f212f640d7d1049cdae28271c79c4d5b70f353c44ed37efcc305587455d96dd", "text": "} @command('git.clone') <del> async clone(url?: string, parentPath?: string): Promise<void> { await this.cloneRepository(url, parentPath); </del> <ins> async clone(url?: string, parentPath?: string, options?: { ref?: string }): Promise<void> { await this.cloneRepository(url, parentPath, options); </ins> } @command('git.cloneRecursive')", "commid": "vscode_pr_159481"}], "negative_passages": []}
{"query_id": "q-en-vscode-d492bf2b1f9b3e2eb9d93bbd24d50ffd453e825c1424dfdfa420c18606ee5486", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:\nwill you create a test plan item/verification steps for this feature?\nyes I will!", "positive_passages": [{"docid": "doc-en-vscode-ea706fcf088315ae659e34112a46cd80888a5e186edb481c5441b37be8ca22ba", "text": "private clone(uri: Uri): void { const data = querystring.parse(uri.query); <ins> const ref = data.ref; </ins> if (!data.url) { console.warn('Failed to open URI:', uri);", "commid": "vscode_pr_159481"}], "negative_passages": []}
{"query_id": "q-en-vscode-d492bf2b1f9b3e2eb9d93bbd24d50ffd453e825c1424dfdfa420c18606ee5486", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:\nwill you create a test plan item/verification steps for this feature?\nyes I will!", "positive_passages": [{"docid": "doc-en-vscode-d4d7df6bb8ae37aa976060f148003a9c170a69c1089d9872695d3957f0ffcb41", "text": "return; } <ins> if (ref !== undefined && typeof ref !== 'string') { console.warn('Failed to open URI:', uri); return; } </ins> let cloneUri: Uri; try { let rawUri = Array.isArray(data.url) ? data.url[0] : data.url;", "commid": "vscode_pr_159481"}], "negative_passages": []}
{"query_id": "q-en-vscode-d492bf2b1f9b3e2eb9d93bbd24d50ffd453e825c1424dfdfa420c18606ee5486", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:\nwill you create a test plan item/verification steps for this feature?\nyes I will!", "positive_passages": [{"docid": "doc-en-vscode-0407c6a7cd57d14d637a08f4c35ad642712c0933316379b6e28b8ba69d67a1ad", "text": "return; } <del> commands.executeCommand('git.clone', cloneUri.toString(true)); </del> <ins> commands.executeCommand('git.clone', cloneUri.toString(true), undefined, { ref: ref }); </ins> } dispose(): void {", "commid": "vscode_pr_159481"}], "negative_passages": []}
{"query_id": "q-en-vscode-97e398fc34a214628b76625de3e5ff265a3c817b7a72d7d5e7e5ff6d44f7243b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.\nOn , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.", "positive_passages": [{"docid": "doc-en-vscode-12bc8d2be47305aa9cd96a7b4fc875712e42fdbf886f33087794771bdbfad536", "text": "import { Disposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions, IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Registry } from 'vs/platform/registry/common/platform'; <del> import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; </del> <ins> import { ILifecycleService, LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; </ins> import { Action2, IAction2Options, MenuRegistry, registerAction2 } from 'vs/platform/actions/common/actions'; import { ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { localize } from 'vs/nls';", "commid": "vscode_pr_158428"}], "negative_passages": []}
{"query_id": "q-en-vscode-97e398fc34a214628b76625de3e5ff265a3c817b7a72d7d5e7e5ff6d44f7243b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.\nOn , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.", "positive_passages": [{"docid": "doc-en-vscode-4018a0218cb3879686a71bc49ffed128e4c0c258952aec076e7c80009764e506", "text": "@IQuickInputService private readonly quickInputService: IQuickInputService, @ICommandService private commandService: ICommandService, @IContextKeyService private readonly contextKeyService: IContextKeyService, <del> @IFileDialogService private readonly fileDialogService: IFileDialogService </del> <ins> @IFileDialogService private readonly fileDialogService: IFileDialogService, @ILifecycleService private readonly lifecycleService: ILifecycleService </ins> ) { super();", "commid": "vscode_pr_158428"}], "negative_passages": []}
{"query_id": "q-en-vscode-97e398fc34a214628b76625de3e5ff265a3c817b7a72d7d5e7e5ff6d44f7243b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.\nOn , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.", "positive_passages": [{"docid": "doc-en-vscode-b638ddfdb11c5f8e8f4450fc41e12e5f24f522f049ec88186b9c41503cad3f3b", "text": "this.shouldShowViewsContext = EDIT_SESSIONS_SHOW_VIEW.bindTo(this.contextKeyService); this._register(this.fileService.registerProvider(EditSessionsFileSystemProvider.SCHEMA, new EditSessionsFileSystemProvider(this.editSessionsWorkbenchService))); <ins> this.lifecycleService.onWillShutdown((e) => e.join(this.autoStoreEditSession(), { id: 'autoStoreEditSession', label: localize('autoStoreEditSession', 'Storing current edit session...') })); } private async autoStoreEditSession() { if (this.configurationService.getValue('workbench.experimental.editSessions.autoStore') === 'onShutdown') { await this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('store edit session', 'Storing edit session...') }, async () => this.storeEditSession(false)); } </ins> } private registerViews() {", "commid": "vscode_pr_158428"}], "negative_passages": []}
{"query_id": "q-en-vscode-97e398fc34a214628b76625de3e5ff265a3c817b7a72d7d5e7e5ff6d44f7243b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.\nOn , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.", "positive_passages": [{"docid": "doc-en-vscode-843b8f718c206403f137a07dea21a6b1bdfd024d8ffc34e854c213b0cf364029", "text": "Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfiguration({ ...workbenchConfigurationNodeBase, 'properties': { <ins> 'workbench.experimental.editSessions.autoStore': { enum: ['onShutdown', 'off'], enumDescriptions: [ localize('autoStore.onShutdown', \"Automatically store current edit session on window close.\"), localize('autoStore.off', \"Never attempt to automatically store an edit session.\") ], 'type': 'string', 'tags': ['experimental', 'usesOnlineServices'], 'default': 'off', 'markdownDescription': localize('autoStore', \"Controls whether to automatically store an available edit session for the current workspace.\"), }, </ins> 'workbench.experimental.editSessions.enabled': { 'type': 'boolean', 'tags': ['experimental', 'usesOnlineServices'],", "commid": "vscode_pr_158428"}], "negative_passages": []}
{"query_id": "q-en-vscode-97e398fc34a214628b76625de3e5ff265a3c817b7a72d7d5e7e5ff6d44f7243b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.\nOn , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.", "positive_passages": [{"docid": "doc-en-vscode-685709466499ffa2600dcbadccfb3fc895578531d8812b68cf5be2df40a5c999", "text": "import { Event } from 'vs/base/common/event'; import { IViewDescriptorService } from 'vs/workbench/common/views'; import { ITextModelService } from 'vs/editor/common/services/resolverService'; <ins> import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; </ins> const folderName = 'test-folder'; const folderUri = URI.file(`/${folderName}`);", "commid": "vscode_pr_158428"}], "negative_passages": []}
{"query_id": "q-en-vscode-97e398fc34a214628b76625de3e5ff265a3c817b7a72d7d5e7e5ff6d44f7243b", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. -- introduces which controls when we attempt to restore an edit session for the current workspace. The user still has to remember to store their edit session or use the explicit Continue Working On trigger. In order to make it harder to lose edit sessions across , , , and RemoteHub on desktop, we should introduce a setting with initial setting values and . When set to , we'll attempt to store the current edit session (if any) before a workbench unload. This will only really reliably work in desktop because in web we cannot run long running tasks in the onbeforeunload handler (, tracked in ). To mitigate this we should also explore introducing an option to continuously sync edit sessions. That first requires tolerance of edit sessions originating from multiple VS Code clients concurrently.\nOn , we do have a service worker which is used primarily for caching. Service workers can outlive their associated pages, and can be synchronously 'd to like other workers. Perhaps we can use that service worker (or a new one) to allow the workbench to send information to save before it unloads.", "positive_passages": [{"docid": "doc-en-vscode-be5bcf0d7f5857b3b5525829a3856886d3a83107e7d9528b83215fc290746630", "text": "// Stub out all services instantiationService.stub(IEditSessionsLogService, logService); instantiationService.stub(IFileService, fileService); <ins> instantiationService.stub(ILifecycleService, new class extends mock<ILifecycleService>() { override onWillShutdown = Event.None; }); </ins> instantiationService.stub(INotificationService, new TestNotificationService()); instantiationService.stub(IEditSessionsWorkbenchService, new class extends mock<IEditSessionsWorkbenchService>() { }); instantiationService.stub(IProgressService, ProgressService);", "commid": "vscode_pr_158428"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b23c7a024d9ad11836fa97458605797c7b8b8dd22bb52717ded766e16066b71", "query": "Looking into adding additional separators that are more common, so that all the additional refactorings are not just clumped under From comment: I was wondering if you would consider adding 2 code action classes that are I think quite common: (Inline) (Move) This would be super valuable for the extension that I'm developing (P42 JavaScript Assistant), but I think also for other extensions. Afaik the TS language server also has actions for example. Originally posted by in\nHey , the new code action widget looks great, and I really like the new code action grouping, I'm wondering if we can define custom code action groups besides the pre-defined groups. ! you can see the java extension contributes a code action (in the light bulb) named \"add Javadoc\" and it's now under \"More Actions...\" menu. If we can define a new group like \"Sources\" via extension, it would be great and more clear that we can put this action in that group.\nWe have an extension that publishes some code actions. With the latest VSCode, our actions are grouped under 'More Actions...' which in our context is not ideal. We would prefer to be able to define our own grouping for our actions (in extension parlance, I think this means to be able to create our own ). Thanks!", "positive_passages": [{"docid": "doc-en-vscode-eafd55f31d8aaa050ced447e46c82b51efb8e04b91da1b9d3b78df02f9c8f8dd", "text": "const codeActionGroups = Object.freeze<CodeActionGroup[]>([ { kind: CodeActionKind.QuickFix, title: localize('codeAction.widget.id.quickfix', 'Quick Fix...') }, <del> { kind: CodeActionKind.Extract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.Convert, title: localize('codeAction.widget.id.convert', 'Convert...'), icon: { codicon: Codicon.zap, color: 'var(--vscode-editorLightBulbAutoFix-foreground)' } }, { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: { codicon: Codicon.symbolArray } }, { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: { codicon: Codicon.lightBulb, color: 'var(--vscode-editorLightBulb-foreground)' } }, </del> <ins> { kind: CodeActionKind.RefactorExtract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move...'), icon: { codicon: Codicon.wrench } }, { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: { codicon: Codicon.symbolSnippet } }, { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: { codicon: Codicon.symbolFile } }, </ins> uncategorizedCodeActionGroup, ]);", "commid": "vscode_pr_161134"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b23c7a024d9ad11836fa97458605797c7b8b8dd22bb52717ded766e16066b71", "query": "Looking into adding additional separators that are more common, so that all the additional refactorings are not just clumped under From comment: I was wondering if you would consider adding 2 code action classes that are I think quite common: (Inline) (Move) This would be super valuable for the extension that I'm developing (P42 JavaScript Assistant), but I think also for other extensions. Afaik the TS language server also has actions for example. Originally posted by in\nHey , the new code action widget looks great, and I really like the new code action grouping, I'm wondering if we can define custom code action groups besides the pre-defined groups. ! you can see the java extension contributes a code action (in the light bulb) named \"add Javadoc\" and it's now under \"More Actions...\" menu. If we can define a new group like \"Sources\" via extension, it would be great and more clear that we can put this action in that group.\nWe have an extension that publishes some code actions. With the latest VSCode, our actions are grouped under 'More Actions...' which in our context is not ideal. We would prefer to be able to define our own grouping for our actions (in extension parlance, I think this means to be able to create our own ). Thanks!", "positive_passages": [{"docid": "doc-en-vscode-ffdf5c8bc10f00ee8d977e21a49c6674743156ee0b70e79905bb48690d075bc0", "text": "public static readonly Empty = new CodeActionKind(''); public static readonly QuickFix = new CodeActionKind('quickfix'); public static readonly Refactor = new CodeActionKind('refactor'); <del> public static readonly Extract = CodeActionKind.Refactor.append('extract'); public static readonly Convert = CodeActionKind.Refactor.append('rewrite'); </del> <ins> public static readonly RefactorExtract = CodeActionKind.Refactor.append('extract'); public static readonly RefactorInline = CodeActionKind.Refactor.append('inline'); public static readonly RefactorMove = CodeActionKind.Refactor.append('move'); public static readonly RefactorRewrite = CodeActionKind.Refactor.append('rewrite'); </ins> public static readonly Source = new CodeActionKind('source'); public static readonly SourceOrganizeImports = CodeActionKind.Source.append('organizeImports'); public static readonly SourceFixAll = CodeActionKind.Source.append('fixAll');", "commid": "vscode_pr_161134"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d7d626f08641d49130e53d471e8db79973401ce0a81e89ac9132f96ac78a05a", "query": "! Only seems to appear if I resize the terminal such that a is on its own line.\nCannot repro: !\nI can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.\nCouldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)\nIn tried on my mac and I still can't reproduce: !\nStill able to reproduce this, have passed repo steps regarding the private repo offline.\nStill struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width=\"852\" alt=\"Screenshot 2022-12-22 at 5 08 03 pm\" src=\"https://user-\"\nThis happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width=\"866\" alt=\"Screenshot 2022-12-22 at 5 12 44 pm\" src=\"https://user-\"\nThat one repro's upstream: <img width=\"793\" alt=\"Screenshot 2022-12-27 at 6 24 10 am\" src=\"https://user-\"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.\nCan still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.\nUpdate cannot repro when debugging. So odd\nUpdate again, I can repro this again in insiders. Not sure why debugging is different.\nStill can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width=\"632\" alt=\"Screenshot 2023-05-08 at 6 43 07 am\" src=\"https://user-\"OSS: <img width=\"637\" alt=\"Screenshot 2023-05-08 at 6 44 55 am\" src=\"https://user-\"OSS debugging: <img width=\"633\" alt=\"Screenshot 2023-05-08 at 6 46 16 am\" src=\"https://user-\"cat this file:", "positive_passages": [{"docid": "doc-en-vscode-99658f9f2c97b0751a8bfb4048b7db10a17b98555d94f5f83c07f8351bf4afa5", "text": "\"vscode-proxy-agent\": \"^0.12.0\", \"vscode-regexpp\": \"^3.1.0\", \"vscode-textmate\": \"8.0.0\", <del> \"xterm\": \"5.2.0-beta.2\", \"xterm-addon-canvas\": \"0.4.0-beta.1\", \"xterm-addon-search\": \"0.11.0-beta.7\", </del> <ins> \"xterm\": \"5.2.0-beta.10\", \"xterm-addon-canvas\": \"0.4.0-beta.6\", \"xterm-addon-search\": \"0.11.0\", </ins> \"xterm-addon-serialize\": \"0.9.0\", <del> \"xterm-addon-unicode11\": \"0.5.0-beta.5\", \"xterm-addon-webgl\": \"0.15.0-beta.1\", \"xterm-headless\": \"5.2.0-beta.2\", </del> <ins> \"xterm-addon-unicode11\": \"0.5.0\", \"xterm-addon-webgl\": \"0.15.0-beta.4\", \"xterm-headless\": \"5.2.0-beta.10\", </ins> \"yauzl\": \"^2.9.2\", \"yazl\": \"^2.4.3\" },", "commid": "vscode_pr_170122"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d7d626f08641d49130e53d471e8db79973401ce0a81e89ac9132f96ac78a05a", "query": "! Only seems to appear if I resize the terminal such that a is on its own line.\nCannot repro: !\nI can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.\nCouldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)\nIn tried on my mac and I still can't reproduce: !\nStill able to reproduce this, have passed repo steps regarding the private repo offline.\nStill struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width=\"852\" alt=\"Screenshot 2022-12-22 at 5 08 03 pm\" src=\"https://user-\"\nThis happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width=\"866\" alt=\"Screenshot 2022-12-22 at 5 12 44 pm\" src=\"https://user-\"\nThat one repro's upstream: <img width=\"793\" alt=\"Screenshot 2022-12-27 at 6 24 10 am\" src=\"https://user-\"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.\nCan still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.\nUpdate cannot repro when debugging. So odd\nUpdate again, I can repro this again in insiders. Not sure why debugging is different.\nStill can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width=\"632\" alt=\"Screenshot 2023-05-08 at 6 43 07 am\" src=\"https://user-\"OSS: <img width=\"637\" alt=\"Screenshot 2023-05-08 at 6 44 55 am\" src=\"https://user-\"OSS debugging: <img width=\"633\" alt=\"Screenshot 2023-05-08 at 6 46 16 am\" src=\"https://user-\"cat this file:", "positive_passages": [{"docid": "doc-en-vscode-f03a72782d778387b63d89a625f82fc16acd9fab4d03b3055016c296f2e68de9", "text": "\"tas-client-umd\": \"0.1.6\", \"vscode-oniguruma\": \"1.7.0\", \"vscode-textmate\": \"8.0.0\", <del> \"xterm\": \"5.2.0-beta.2\", \"xterm-addon-canvas\": \"0.4.0-beta.1\", \"xterm-addon-search\": \"0.11.0-beta.7\", \"xterm-addon-unicode11\": \"0.5.0-beta.5\", \"xterm-addon-webgl\": \"0.15.0-beta.1\" </del> <ins> \"xterm\": \"5.2.0-beta.10\", \"xterm-addon-canvas\": \"0.4.0-beta.6\", \"xterm-addon-search\": \"0.11.0\", \"xterm-addon-unicode11\": \"0.5.0\", \"xterm-addon-webgl\": \"0.15.0-beta.4\" </ins> } }", "commid": "vscode_pr_170122"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d7d626f08641d49130e53d471e8db79973401ce0a81e89ac9132f96ac78a05a", "query": "! Only seems to appear if I resize the terminal such that a is on its own line.\nCannot repro: !\nI can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.\nCouldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)\nIn tried on my mac and I still can't reproduce: !\nStill able to reproduce this, have passed repo steps regarding the private repo offline.\nStill struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width=\"852\" alt=\"Screenshot 2022-12-22 at 5 08 03 pm\" src=\"https://user-\"\nThis happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width=\"866\" alt=\"Screenshot 2022-12-22 at 5 12 44 pm\" src=\"https://user-\"\nThat one repro's upstream: <img width=\"793\" alt=\"Screenshot 2022-12-27 at 6 24 10 am\" src=\"https://user-\"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.\nCan still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.\nUpdate cannot repro when debugging. So odd\nUpdate again, I can repro this again in insiders. Not sure why debugging is different.\nStill can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width=\"632\" alt=\"Screenshot 2023-05-08 at 6 43 07 am\" src=\"https://user-\"OSS: <img width=\"637\" alt=\"Screenshot 2023-05-08 at 6 44 55 am\" src=\"https://user-\"OSS debugging: <img width=\"633\" alt=\"Screenshot 2023-05-08 at 6 46 16 am\" src=\"https://user-\"cat this file:", "positive_passages": [{"docid": "doc-en-vscode-33269929ee37a2b956e8538878e93d8c682a9b52e99f9943d5ef269703690103", "text": "resolved \"https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-8.0.0.tgz#2c7a3b1163ef0441097e0b5d6389cd5504b59e5d\" integrity sha512-AFbieoL7a5LMqcnOF04ji+rpXadgOXnZsxQr//r83kLPr7biP7am3g9zbaZIaBGwBRWeSvoMD4mgPdX3e4NWBg== <del> xterm-addon-canvas@0.4.0-beta.1: version \"0.4.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f\" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== xterm-addon-search@0.11.0-beta.7: version \"0.11.0-beta.7\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052\" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== xterm-addon-unicode11@0.5.0-beta.5: version \"0.5.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93\" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== xterm-addon-webgl@0.15.0-beta.1: version \"0.15.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796\" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== xterm@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787\" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </del> <ins> xterm-addon-canvas@0.4.0-beta.6: version \"0.4.0-beta.6\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.6.tgz#f8cb09ef980f1fa9d73f067e00f7a879c374ad68\" integrity sha512-x5OY0VOJxqvXdyXpW9aug3vaeQX/+r7TZk13MujReuJRLRAjCHaH6ep6g9ZOVlqa8VCBWPwmm/eXH05SGUbnQQ== xterm-addon-search@0.11.0: version \"0.11.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0.tgz#2a00ff7f9848f6140e7c4d1782486b0b18b06e0d\" integrity sha512-6U4uHXcQ7G5igsdaGqrJ9ehm7vep24bXqWxuy3AnIosXF2Z5uy2MvmYRyTGNembIqPV/x1YhBQ7uShtuqBHhOQ== xterm-addon-unicode11@0.5.0: version \"0.5.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0.tgz#41c0d96acc1e3bb6c6596eee64e163b6bca74be7\" integrity sha512-Jm4/g4QiTxiKiTbYICQgC791ubhIZyoIwxAIgOW8z8HWFNY+lwk+dwaKEaEeGBfM48Vk8fklsUW9u/PlenYEBg== xterm-addon-webgl@0.15.0-beta.4: version \"0.15.0-beta.4\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030\" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== xterm@5.2.0-beta.10: version \"5.2.0-beta.10\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.10.tgz#33e67a8397937dd8b731a2f315c67f4bd63f3c28\" integrity sha512-3zVxU/0XrUWpvOIU/KkXREweq7hCxNGFt4asT4D/SsRlRKYOnO+vooz1CjLO6USY++iHXicgf8PdgRDeYj5fFQ== </ins>", "commid": "vscode_pr_170122"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d7d626f08641d49130e53d471e8db79973401ce0a81e89ac9132f96ac78a05a", "query": "! Only seems to appear if I resize the terminal such that a is on its own line.\nCannot repro: !\nI can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.\nCouldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)\nIn tried on my mac and I still can't reproduce: !\nStill able to reproduce this, have passed repo steps regarding the private repo offline.\nStill struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width=\"852\" alt=\"Screenshot 2022-12-22 at 5 08 03 pm\" src=\"https://user-\"\nThis happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width=\"866\" alt=\"Screenshot 2022-12-22 at 5 12 44 pm\" src=\"https://user-\"\nThat one repro's upstream: <img width=\"793\" alt=\"Screenshot 2022-12-27 at 6 24 10 am\" src=\"https://user-\"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.\nCan still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.\nUpdate cannot repro when debugging. So odd\nUpdate again, I can repro this again in insiders. Not sure why debugging is different.\nStill can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width=\"632\" alt=\"Screenshot 2023-05-08 at 6 43 07 am\" src=\"https://user-\"OSS: <img width=\"637\" alt=\"Screenshot 2023-05-08 at 6 44 55 am\" src=\"https://user-\"OSS debugging: <img width=\"633\" alt=\"Screenshot 2023-05-08 at 6 46 16 am\" src=\"https://user-\"cat this file:", "positive_passages": [{"docid": "doc-en-vscode-04f993dabc3f82b897cb715c4f359a0c8b718b360829f34f46501e34200de83d", "text": "resolved \"https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f\" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-canvas@0.4.0-beta.1: version \"0.4.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f\" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </del> <ins> xterm-addon-canvas@0.4.0-beta.6: version \"0.4.0-beta.6\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.6.tgz#f8cb09ef980f1fa9d73f067e00f7a879c374ad68\" integrity sha512-x5OY0VOJxqvXdyXpW9aug3vaeQX/+r7TZk13MujReuJRLRAjCHaH6ep6g9ZOVlqa8VCBWPwmm/eXH05SGUbnQQ== </ins> <del> xterm-addon-search@0.11.0-beta.7: version \"0.11.0-beta.7\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052\" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== </del> <ins> xterm-addon-search@0.11.0: version \"0.11.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0.tgz#2a00ff7f9848f6140e7c4d1782486b0b18b06e0d\" integrity sha512-6U4uHXcQ7G5igsdaGqrJ9ehm7vep24bXqWxuy3AnIosXF2Z5uy2MvmYRyTGNembIqPV/x1YhBQ7uShtuqBHhOQ== </ins> xterm-addon-serialize@0.9.0: version \"0.9.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0.tgz#3eee5f5c34b16e48891ec59b213716bab2354bf4\" integrity sha512-qJju2YJFh8c8pbtCYtHaG7gDDHBpDJ4a4JQZvOzuiMxOjgeM1oCnFNjbhzMuK/fOUa59FmvIUGQyqn3WL9q7qw== <del> xterm-addon-unicode11@0.5.0-beta.5: version \"0.5.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93\" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== xterm-addon-webgl@0.15.0-beta.1: version \"0.15.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796\" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== xterm-headless@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.2.tgz#db8d4cc45a2bba062622d7784a2264030aa7d56d\" integrity sha512-aP3+K47bJu5AkdtekML5LZZUh/zAkDc5ONNFgQ+7eUBh7RkFy3JYRuaG5Nj3LbdkUMjWqQZXzc3BW5Vo9KQNgA== xterm@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787\" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </del> <ins> xterm-addon-unicode11@0.5.0: version \"0.5.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0.tgz#41c0d96acc1e3bb6c6596eee64e163b6bca74be7\" integrity sha512-Jm4/g4QiTxiKiTbYICQgC791ubhIZyoIwxAIgOW8z8HWFNY+lwk+dwaKEaEeGBfM48Vk8fklsUW9u/PlenYEBg== xterm-addon-webgl@0.15.0-beta.4: version \"0.15.0-beta.4\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030\" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== xterm-headless@5.2.0-beta.10: version \"5.2.0-beta.10\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.10.tgz#fc7b11b0395f6bb934b0c9373b412bc4d3247148\" integrity sha512-jjylqERzLWWrPLpehL1v0Y3JaZqQksoqE04g5H+tNceQemoBlIpbA5OgPrbcjz5xxFIR9mVWppFR7klWox5/Sg== xterm@5.2.0-beta.10: version \"5.2.0-beta.10\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.10.tgz#33e67a8397937dd8b731a2f315c67f4bd63f3c28\" integrity sha512-3zVxU/0XrUWpvOIU/KkXREweq7hCxNGFt4asT4D/SsRlRKYOnO+vooz1CjLO6USY++iHXicgf8PdgRDeYj5fFQ== </ins> yallist@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_170122"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d7d626f08641d49130e53d471e8db79973401ce0a81e89ac9132f96ac78a05a", "query": "! Only seems to appear if I resize the terminal such that a is on its own line.\nCannot repro: !\nI can still reproduce this? For example cat this file to your terminal Then drag until a quote is the only thing on one of the lines. This causes the link detection to detect everything below that quote.\nCouldn't repro on Windows but I do see some offset problem after the resizes: ! Probably an issue with reflow (mac/Linux)\nIn tried on my mac and I still can't reproduce: !\nStill able to reproduce this, have passed repo steps regarding the private repo offline.\nStill struggling to repro, I did notice sometimes it's off by 1 or 2 cells in either direction like this though: <img width=\"852\" alt=\"Screenshot 2022-12-22 at 5 08 03 pm\" src=\"https://user-\"\nThis happens because of line caching, hovering a wrapped line and then resizing it a little such that the line is still there, the line range will be off: <img width=\"866\" alt=\"Screenshot 2022-12-22 at 5 12 44 pm\" src=\"https://user-\"\nThat one repro's upstream: <img width=\"793\" alt=\"Screenshot 2022-12-27 at 6 24 10 am\" src=\"https://user-\"Since I can't repro your actual issue I'll fix this and see if that's the underlying issue.\nCan still repro this building OSS. Note you do not need to resize the terminal for this to occur if it's already the correct size when you run the task.\nUpdate cannot repro when debugging. So odd\nUpdate again, I can repro this again in insiders. Not sure why debugging is different.\nStill can't reproduce so closing as unactionable until there's a solid repro. Insiders: <img width=\"632\" alt=\"Screenshot 2023-05-08 at 6 43 07 am\" src=\"https://user-\"OSS: <img width=\"637\" alt=\"Screenshot 2023-05-08 at 6 44 55 am\" src=\"https://user-\"OSS debugging: <img width=\"633\" alt=\"Screenshot 2023-05-08 at 6 46 16 am\" src=\"https://user-\"cat this file:", "positive_passages": [{"docid": "doc-en-vscode-9ba68263addf26f1df913ba3adb615fa29a81e0c0ee3ee3841bbef09bdee1136", "text": "dependencies: object-keys \"~0.4.0\" <del> xterm-addon-canvas@0.4.0-beta.1: version \"0.4.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f\" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </del> <ins> xterm-addon-canvas@0.4.0-beta.6: version \"0.4.0-beta.6\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.6.tgz#f8cb09ef980f1fa9d73f067e00f7a879c374ad68\" integrity sha512-x5OY0VOJxqvXdyXpW9aug3vaeQX/+r7TZk13MujReuJRLRAjCHaH6ep6g9ZOVlqa8VCBWPwmm/eXH05SGUbnQQ== </ins> <del> xterm-addon-search@0.11.0-beta.7: version \"0.11.0-beta.7\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052\" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== </del> <ins> xterm-addon-search@0.11.0: version \"0.11.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0.tgz#2a00ff7f9848f6140e7c4d1782486b0b18b06e0d\" integrity sha512-6U4uHXcQ7G5igsdaGqrJ9ehm7vep24bXqWxuy3AnIosXF2Z5uy2MvmYRyTGNembIqPV/x1YhBQ7uShtuqBHhOQ== </ins> xterm-addon-serialize@0.9.0: version \"0.9.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0.tgz#3eee5f5c34b16e48891ec59b213716bab2354bf4\" integrity sha512-qJju2YJFh8c8pbtCYtHaG7gDDHBpDJ4a4JQZvOzuiMxOjgeM1oCnFNjbhzMuK/fOUa59FmvIUGQyqn3WL9q7qw== <del> xterm-addon-unicode11@0.5.0-beta.5: version \"0.5.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93\" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== xterm-addon-webgl@0.15.0-beta.1: version \"0.15.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796\" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== xterm-headless@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.2.tgz#db8d4cc45a2bba062622d7784a2264030aa7d56d\" integrity sha512-aP3+K47bJu5AkdtekML5LZZUh/zAkDc5ONNFgQ+7eUBh7RkFy3JYRuaG5Nj3LbdkUMjWqQZXzc3BW5Vo9KQNgA== xterm@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787\" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </del> <ins> xterm-addon-unicode11@0.5.0: version \"0.5.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0.tgz#41c0d96acc1e3bb6c6596eee64e163b6bca74be7\" integrity sha512-Jm4/g4QiTxiKiTbYICQgC791ubhIZyoIwxAIgOW8z8HWFNY+lwk+dwaKEaEeGBfM48Vk8fklsUW9u/PlenYEBg== xterm-addon-webgl@0.15.0-beta.4: version \"0.15.0-beta.4\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030\" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== xterm-headless@5.2.0-beta.10: version \"5.2.0-beta.10\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.10.tgz#fc7b11b0395f6bb934b0c9373b412bc4d3247148\" integrity sha512-jjylqERzLWWrPLpehL1v0Y3JaZqQksoqE04g5H+tNceQemoBlIpbA5OgPrbcjz5xxFIR9mVWppFR7klWox5/Sg== xterm@5.2.0-beta.10: version \"5.2.0-beta.10\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.10.tgz#33e67a8397937dd8b731a2f315c67f4bd63f3c28\" integrity sha512-3zVxU/0XrUWpvOIU/KkXREweq7hCxNGFt4asT4D/SsRlRKYOnO+vooz1CjLO6USY++iHXicgf8PdgRDeYj5fFQ== </ins> y18n@^3.2.1: version \"3.2.2\"", "commid": "vscode_pr_170122"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a0be80bd127cae7bcbd16f9df95ec4052115f8542e50920149321bc2b4fa98d", "query": "In the following dialog that appears: <img width=\"696\" alt=\"image\" src=\"https://user-\"in and opening a protocol url, the 'Install VS Code Insiders' button should route to a new link for installing insiders specifically rather than just Install VS Code Insiders should not dismiss the dialog, so that the user can return and try again cc\nlikely a separate issue: Was not sure how this modal was arrived at, so I clicked the remote indicator and I only saw an option to download VS Code - not Insider's as I'd expect. !\nI then did the flow and saw the dialogue. Clicking on the button took me to the Insider's download correctly. !", "positive_passages": [{"docid": "doc-en-vscode-6ea32e2d7652a782b826e11e25f18986c5cf17aec43ff614dad93f9e6b95259e", "text": "invokeProtocolHandler(); <del> // We cannot know whether the protocol handler succeeded. // Display guidance in case it did not, e.g. the app is not installed locally. if (matchesScheme(href, this.productService.urlProtocol)) { </del> <ins> const showProtocolUrlOpenedDialog = async () => { </ins> const showResult = await this.dialogService.show( Severity.Info, localize('openExternalDialogTitle', \"All done. You can close this tab now.\"),", "commid": "vscode_pr_159488"}], "negative_passages": []}
{"query_id": "q-en-vscode-8a0be80bd127cae7bcbd16f9df95ec4052115f8542e50920149321bc2b4fa98d", "query": "In the following dialog that appears: <img width=\"696\" alt=\"image\" src=\"https://user-\"in and opening a protocol url, the 'Install VS Code Insiders' button should route to a new link for installing insiders specifically rather than just Install VS Code Insiders should not dismiss the dialog, so that the user can return and try again cc\nlikely a separate issue: Was not sure how this modal was arrived at, so I clicked the remote indicator and I only saw an option to download VS Code - not Insider's as I'd expect. !\nI then did the flow and saw the dialogue. Clicking on the button took me to the Insider's download correctly. !", "positive_passages": [{"docid": "doc-en-vscode-9ed865a4a18c4912b8a2e5cb88653d43a2d714637debe13136fa892cf227a06e", "text": "if (showResult.choice === 0) { invokeProtocolHandler(); } else if (showResult.choice === 1) { <del> await this.openerService.open(URI.parse(`http://aka.ms/vscode-install`)); </del> <ins> // Route the user to the appropriate install link await this.openerService.open(URI.parse( this.productService.quality === 'stable' ? `http://aka.ms/vscode-install` : `http://aka.ms/vscode-install-insiders` )); // Re-show the dialog so that the user can come back after installing and try again showProtocolUrlOpenedDialog(); </ins> } <ins> }; // We cannot know whether the protocol handler succeeded. // Display guidance in case it did not, e.g. the app is not installed locally. if (matchesScheme(href, this.productService.urlProtocol)) { await showProtocolUrlOpenedDialog(); </ins> } }", "commid": "vscode_pr_159488"}], "negative_passages": []}
{"query_id": "q-en-vscode-0a1d03df981986debdbc681c23289ef8fb72b396102c2520bd690b5ac0a35867", "query": "Type: <bBug</bVSCode, create a folder named, for instance, \"XXXX\". that folder create another called .vscode .vscode create a file named with this content: VSCode sure the setting \"task.allowAutomaticTasks\" is not set or is set to its defautl value \"auto\". \"XXXX\" with VSCode. VSCode will run \"echo Hello\" without asking you whether you want to run tasks configured with \"runOn\": \"folderOpen\" or not. VS Code version: Code 1.70.2 (, 2022-08-16T05:35:13.448Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nThis happens because you have presumably opened a trusted workspace - which is now when we allow these to be run if the setting is \"auto\" for allow automatic task\nThe described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!\n! If I understood it correctly, the popup that supposedly asks you whether you want to run these tasks is not actually meant to appear ever because if the workspace is trusted it will be executed without asking you and if it is not trusted then it will just not exeute them instead of asking you. Doesn't it look kinda pointless to have in the description of the option of the configuration \"Prompt for permission for each folder\"? You are never prompted anyways.\nI this configuration and I am still not prompted anyways:\nNo I did not. Please next time ask the user if he did X before assuming it and closing the issue. I tried reproducing the problem with and without a trusted workspace and the problem persists anyways.\ni'll investigate this that shouldn't happen\nTasks will only run in trusted workspaces, so I will update the setting description to indicate that. Also need to fix the prompt not happening per folder.", "positive_passages": [{"docid": "doc-en-vscode-06489750a7aea2bb58399118610b6f2821f30bb050f69ccdb32e7bd61aae731c", "text": "} if (runSource === TaskRunSource.User) { const workspaceTasks = await this.getWorkspaceTasks(); <del> RunAutomaticTasks.promptForPermission(this, this._storageService, this._notificationService, this._workspaceTrustManagementService, this._openerService, this._configurationService, workspaceTasks); </del> <ins> RunAutomaticTasks.runWithPermission(this, this._storageService, this._notificationService, this._workspaceTrustManagementService, this._openerService, this._configurationService, workspaceTasks); </ins> } return executeTaskResult; } catch (error) {", "commid": "vscode_pr_159504"}], "negative_passages": []}
{"query_id": "q-en-vscode-0a1d03df981986debdbc681c23289ef8fb72b396102c2520bd690b5ac0a35867", "query": "Type: <bBug</bVSCode, create a folder named, for instance, \"XXXX\". that folder create another called .vscode .vscode create a file named with this content: VSCode sure the setting \"task.allowAutomaticTasks\" is not set or is set to its defautl value \"auto\". \"XXXX\" with VSCode. VSCode will run \"echo Hello\" without asking you whether you want to run tasks configured with \"runOn\": \"folderOpen\" or not. VS Code version: Code 1.70.2 (, 2022-08-16T05:35:13.448Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nThis happens because you have presumably opened a trusted workspace - which is now when we allow these to be run if the setting is \"auto\" for allow automatic task\nThe described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!\n! If I understood it correctly, the popup that supposedly asks you whether you want to run these tasks is not actually meant to appear ever because if the workspace is trusted it will be executed without asking you and if it is not trusted then it will just not exeute them instead of asking you. Doesn't it look kinda pointless to have in the description of the option of the configuration \"Prompt for permission for each folder\"? You are never prompted anyways.\nI this configuration and I am still not prompted anyways:\nNo I did not. Please next time ask the user if he did X before assuming it and closing the issue. I tried reproducing the problem with and without a trusted workspace and the problem persists anyways.\ni'll investigate this that shouldn't happen\nTasks will only run in trusted workspaces, so I will update the setting description to indicate that. Also need to fix the prompt not happening per folder.", "positive_passages": [{"docid": "doc-en-vscode-0c91216966cc3e0ffa8a305645bfc0caa28083b173a4b2b382d64f8f5c14de03", "text": "@ITaskService private readonly _taskService: ITaskService, @IConfigurationService private readonly _configurationService: IConfigurationService, @IWorkspaceTrustManagementService private readonly _workspaceTrustManagementService: IWorkspaceTrustManagementService, <del> @ILogService private readonly _logService: ILogService) { </del> <ins> @ILogService private readonly _logService: ILogService, @IStorageService private readonly _storageService: IStorageService, @IOpenerService private readonly _openerService: IOpenerService, @INotificationService private readonly _notificationService: INotificationService) { </ins> super(); this._tryRunTasks(); }", "commid": "vscode_pr_159504"}], "negative_passages": []}
{"query_id": "q-en-vscode-0a1d03df981986debdbc681c23289ef8fb72b396102c2520bd690b5ac0a35867", "query": "Type: <bBug</bVSCode, create a folder named, for instance, \"XXXX\". that folder create another called .vscode .vscode create a file named with this content: VSCode sure the setting \"task.allowAutomaticTasks\" is not set or is set to its defautl value \"auto\". \"XXXX\" with VSCode. VSCode will run \"echo Hello\" without asking you whether you want to run tasks configured with \"runOn\": \"folderOpen\" or not. VS Code version: Code 1.70.2 (, 2022-08-16T05:35:13.448Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nThis happens because you have presumably opened a trusted workspace - which is now when we allow these to be run if the setting is \"auto\" for allow automatic task\nThe described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!\n! If I understood it correctly, the popup that supposedly asks you whether you want to run these tasks is not actually meant to appear ever because if the workspace is trusted it will be executed without asking you and if it is not trusted then it will just not exeute them instead of asking you. Doesn't it look kinda pointless to have in the description of the option of the configuration \"Prompt for permission for each folder\"? You are never prompted anyways.\nI this configuration and I am still not prompted anyways:\nNo I did not. Please next time ask the user if he did X before assuming it and closing the issue. I tried reproducing the problem with and without a trusted workspace and the problem persists anyways.\ni'll investigate this that shouldn't happen\nTasks will only run in trusted workspaces, so I will update the setting description to indicate that. Also need to fix the prompt not happening per folder.", "positive_passages": [{"docid": "doc-en-vscode-ab8acf7bead72ffd385cc8b6fdf56c807f62aa570a9a540eaabf7c7b3b781fba", "text": "await Event.toPromise(Event.once(this._taskService.onDidChangeTaskSystemInfo)); } <del> this._logService.trace('RunAutomaticTasks: Checking if automatic tasks should run.'); const isFolderAutomaticAllowed = this._configurationService.getValue(ALLOW_AUTOMATIC_TASKS) !== 'off'; await this._workspaceTrustManagementService.workspaceTrustInitialized; const isWorkspaceTrusted = this._workspaceTrustManagementService.isWorkspaceTrusted(); // Only run if allowed. Prompting for permission occurs when a user first tries to run a task. if (isFolderAutomaticAllowed && isWorkspaceTrusted) { this._taskService.getWorkspaceTasks(TaskRunSource.FolderOpen).then(workspaceTaskResult => { const { tasks } = RunAutomaticTasks._findAutoTasks(this._taskService, workspaceTaskResult); this._logService.trace(`RunAutomaticTasks: Found ${tasks.length} automatic tasks tasks`); if (tasks.length > 0) { RunAutomaticTasks._runTasks(this._taskService, tasks); } }); } </del> <ins> const workspaceTasks = await this._taskService.getWorkspaceTasks(TaskRunSource.FolderOpen); this._logService.trace(`RunAutomaticTasks: Found ${workspaceTasks.size} automatic tasks`); await RunAutomaticTasks.runWithPermission(this._taskService, this._storageService, this._notificationService, this._workspaceTrustManagementService, this._openerService, this._configurationService, workspaceTasks); </ins> } private static _runTasks(taskService: ITaskService, tasks: Array<Task | Promise<Task | undefined>>) {", "commid": "vscode_pr_159504"}], "negative_passages": []}
{"query_id": "q-en-vscode-0a1d03df981986debdbc681c23289ef8fb72b396102c2520bd690b5ac0a35867", "query": "Type: <bBug</bVSCode, create a folder named, for instance, \"XXXX\". that folder create another called .vscode .vscode create a file named with this content: VSCode sure the setting \"task.allowAutomaticTasks\" is not set or is set to its defautl value \"auto\". \"XXXX\" with VSCode. VSCode will run \"echo Hello\" without asking you whether you want to run tasks configured with \"runOn\": \"folderOpen\" or not. VS Code version: Code 1.70.2 (, 2022-08-16T05:35:13.448Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nThis happens because you have presumably opened a trusted workspace - which is now when we allow these to be run if the setting is \"auto\" for allow automatic task\nThe described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!\n! If I understood it correctly, the popup that supposedly asks you whether you want to run these tasks is not actually meant to appear ever because if the workspace is trusted it will be executed without asking you and if it is not trusted then it will just not exeute them instead of asking you. Doesn't it look kinda pointless to have in the description of the option of the configuration \"Prompt for permission for each folder\"? You are never prompted anyways.\nI this configuration and I am still not prompted anyways:\nNo I did not. Please next time ask the user if he did X before assuming it and closing the issue. I tried reproducing the problem with and without a trusted workspace and the problem persists anyways.\ni'll investigate this that shouldn't happen\nTasks will only run in trusted workspaces, so I will update the setting description to indicate that. Also need to fix the prompt not happening per folder.", "positive_passages": [{"docid": "doc-en-vscode-c61657a7fb8879fcdb2fefab76efd26480c62607433bb7f74198206d30c3b0fd", "text": "return { tasks, taskNames, locations }; } <del> public static async promptForPermission(taskService: ITaskService, storageService: IStorageService, notificationService: INotificationService, workspaceTrustManagementService: IWorkspaceTrustManagementService, </del> <ins> public static async runWithPermission(taskService: ITaskService, storageService: IStorageService, notificationService: INotificationService, workspaceTrustManagementService: IWorkspaceTrustManagementService, </ins> openerService: IOpenerService, configurationService: IConfigurationService, workspaceTaskResult: Map<string, IWorkspaceFolderTaskResult>) { const isWorkspaceTrusted = workspaceTrustManagementService.isWorkspaceTrusted; <del> if (!isWorkspaceTrusted) { </del> <ins> if (!isWorkspaceTrusted || configurationService.getValue(ALLOW_AUTOMATIC_TASKS) === 'off') { </ins> return; } <del> if (configurationService.getValue(ALLOW_AUTOMATIC_TASKS) === 'off') { </del> <ins> const hasShownPromptForAutomaticTasks = storageService.getBoolean(HAS_PROMPTED_FOR_AUTOMATIC_TASKS, StorageScope.WORKSPACE, false); const { tasks, taskNames, locations } = RunAutomaticTasks._findAutoTasks(taskService, workspaceTaskResult); if (taskNames.length === 0) { </ins> return; } <del> const hasShownPromptForAutomaticTasks = storageService.getBoolean(HAS_PROMPTED_FOR_AUTOMATIC_TASKS, StorageScope.WORKSPACE, undefined); const { tasks, taskNames, locations } = RunAutomaticTasks._findAutoTasks(taskService, workspaceTaskResult); if (taskNames.length > 0) { if (configurationService.getValue(ALLOW_AUTOMATIC_TASKS) === 'on') { RunAutomaticTasks._runTasks(taskService, tasks); } else if (!hasShownPromptForAutomaticTasks) { // We have automatic tasks, prompt to allow. this._showPrompt(notificationService, storageService, openerService, configurationService, taskNames, locations).then(allow => { if (allow) { RunAutomaticTasks._runTasks(taskService, tasks); } }); } </del> <ins> if (configurationService.getValue(ALLOW_AUTOMATIC_TASKS) === 'on') { RunAutomaticTasks._runTasks(taskService, tasks); } else if (configurationService.getValue(ALLOW_AUTOMATIC_TASKS) === 'auto' && !hasShownPromptForAutomaticTasks) { // by default, only prompt once per folder // otherwise, this can be configured via the setting this._showPrompt(notificationService, storageService, openerService, configurationService, taskNames, locations).then(allow => { if (allow) { storageService.store(HAS_PROMPTED_FOR_AUTOMATIC_TASKS, true, StorageScope.WORKSPACE, StorageTarget.USER); RunAutomaticTasks._runTasks(taskService, tasks); } }); </ins> } }", "commid": "vscode_pr_159504"}], "negative_passages": []}
{"query_id": "q-en-vscode-0a1d03df981986debdbc681c23289ef8fb72b396102c2520bd690b5ac0a35867", "query": "Type: <bBug</bVSCode, create a folder named, for instance, \"XXXX\". that folder create another called .vscode .vscode create a file named with this content: VSCode sure the setting \"task.allowAutomaticTasks\" is not set or is set to its defautl value \"auto\". \"XXXX\" with VSCode. VSCode will run \"echo Hello\" without asking you whether you want to run tasks configured with \"runOn\": \"folderOpen\" or not. VS Code version: Code 1.70.2 (, 2022-08-16T05:35:13.448Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nThis happens because you have presumably opened a trusted workspace - which is now when we allow these to be run if the setting is \"auto\" for allow automatic task\nThe described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!\n! If I understood it correctly, the popup that supposedly asks you whether you want to run these tasks is not actually meant to appear ever because if the workspace is trusted it will be executed without asking you and if it is not trusted then it will just not exeute them instead of asking you. Doesn't it look kinda pointless to have in the description of the option of the configuration \"Prompt for permission for each folder\"? You are never prompted anyways.\nI this configuration and I am still not prompted anyways:\nNo I did not. Please next time ask the user if he did X before assuming it and closing the issue. I tried reproducing the problem with and without a trusted workspace and the problem persists anyways.\ni'll investigate this that shouldn't happen\nTasks will only run in trusted workspaces, so I will update the setting description to indicate that. Also need to fix the prompt not happening per folder.", "positive_passages": [{"docid": "doc-en-vscode-3b60675a43693fe096852e0fed70750457bf26a75eff200f5681ab88486f53ac", "text": "type: 'string', enum: ['on', 'auto', 'off'], enumDescriptions: [ <del> nls.localize('ttask.allowAutomaticTasks.on', \"Always\"), </del> <ins> nls.localize('task.allowAutomaticTasks.on', \"Always\"), </ins> nls.localize('task.allowAutomaticTasks.auto', \"Prompt for permission for each folder\"), nls.localize('task.allowAutomaticTasks.off', \"Never\"), ], <del> description: nls.localize('task.allowAutomaticTasks', \"Enable automatic tasks in the folder.\"), </del> <ins> description: nls.localize('task.allowAutomaticTasks', \"Enable automatic tasks in the folder - note that tasks won't run in an untrusted workspace.\"), </ins> default: 'auto', restricted: true },", "commid": "vscode_pr_159504"}], "negative_passages": []}
{"query_id": "q-en-vscode-451d99d9571387e9fa1af1388e2823bc1d3769998365025cc70850de4e58af40", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Noticed that SourcePawn extension has this feature, it should be enabled for built-in C/C++ preprocessor #if and #endif, just like for brackets [] () {} SourcePawn: ! C/C++: ! Could probably be done for other languages that have keywords rather than braces for opening and closing a block, e.g. Lua's if-then-end: !\nNot sure if this is editor or C/C++ language config / text mate.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nHello there,is this issue open?If so,could i work on this?\nShould make request to Just add as brackets to !\nThis change should be reverted if it can't be made work with all the other preprocessor statements that match the endif: #if, #ifdef, #ifndef, #else, #elif, #elifdef, #elifndef, see matching isn't required, but it shouldn't show the #endif as unmatched.\nit'll work fine with the rest of the #if's just #else etc won't work as vscode doesn't support inside/middle brackets but it won't cause any issues\nah..... one thing I forgot about ! bit of a deal breaker vscode would have to support 'transcendent' brackets similar problem to\nOh -- that seems like a different bug? ! -- The red }, not sure how you got the red {. It doesn't repro with VS Code (non-Insiders). Repro code is Should someone file a new bug on that or is it the same root issue?\nYeah, looks like the PR at fixes it though.\nThanks for reporting this! We will revert the PR as it causes too many unexpected issues. If you like to have this, you can configure the brackets to colorize in the user settings.\nOkay, I figured it out via The directives remain the unmatched color.\nWe closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!", "positive_passages": [{"docid": "doc-en-vscode-c96da73db5ae69b6a5e87cc75bde61c9dbfb6f5b1a6c3687d1079940be9c57bb", "text": "\"brackets\": [ [\"{\", \"}\"], [\"[\", \"]\"], <del> [\"(\", \")\"] </del> <ins> [\"(\", \")\"], [\"#if\",\"#endif\"], </ins> ], \"autoClosingPairs\": [ { \"open\": \"[\", \"close\": \"]\" },", "commid": "vscode_pr_159997"}], "negative_passages": []}
{"query_id": "q-en-vscode-9631f8492b6048a8f350d19b5b6ac991b790708e654b9c34f9a95674c1dfed87", "query": "<img width=\"584\" alt=\"image\" src=\"https://user-\"//cc for views\nI assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC\nTree row contents are outside of the tree's jurisdiction, but are in fact responsibility of the widget user.\nTimeline doesn't use the extension tree view and instead does it's own thing. I think works on timeline.\ncurious, do we have an understanding what caused this? it seems relatively recent?\nMight be related to . any ideas here?\nIt was caused by , can you check? I see a visual difference not only with the alignment but also the spacing: Before <img width=\"254\" alt=\"image\" src=\"https://user-\"After <img width=\"269\" alt=\"image\" src=\"https://user-\"\nit looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix.\n<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased", "positive_passages": [{"docid": "doc-en-vscode-e8ddca70157cc17d5c62e08224ed6d0e9dfe5c567308856d4ab7b3ecabd36e2b", "text": ".customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item { display: flex; <ins> align-items: center; </ins> height: 22px; line-height: 22px; flex: 1;", "commid": "vscode_pr_160212"}], "negative_passages": []}
{"query_id": "q-en-vscode-9631f8492b6048a8f350d19b5b6ac991b790708e654b9c34f9a95674c1dfed87", "query": "<img width=\"584\" alt=\"image\" src=\"https://user-\"//cc for views\nI assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC\nTree row contents are outside of the tree's jurisdiction, but are in fact responsibility of the widget user.\nTimeline doesn't use the extension tree view and instead does it's own thing. I think works on timeline.\ncurious, do we have an understanding what caused this? it seems relatively recent?\nMight be related to . any ideas here?\nIt was caused by , can you check? I see a visual difference not only with the alignment but also the spacing: Before <img width=\"254\" alt=\"image\" src=\"https://user-\"After <img width=\"269\" alt=\"image\" src=\"https://user-\"\nit looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix.\n<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased", "positive_passages": [{"docid": "doc-en-vscode-29a52e1162dfb9b4e5f495a280ac25ba5b158693cde37a01575dc44a18c78526", "text": "display: block; } <ins> .timeline-tree-view .monaco-list .monaco-list-row .custom-view-tree-node-item > .custom-view-tree-node-item-icon, </ins> .customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item > .custom-view-tree-node-item-resourceLabel > .custom-view-tree-node-item-icon { background-size: 16px; background-position: left center;", "commid": "vscode_pr_160797"}], "negative_passages": []}
{"query_id": "q-en-vscode-9631f8492b6048a8f350d19b5b6ac991b790708e654b9c34f9a95674c1dfed87", "query": "<img width=\"584\" alt=\"image\" src=\"https://user-\"//cc for views\nI assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC\nTree row contents are outside of the tree's jurisdiction, but are in fact responsibility of the widget user.\nTimeline doesn't use the extension tree view and instead does it's own thing. I think works on timeline.\ncurious, do we have an understanding what caused this? it seems relatively recent?\nMight be related to . any ideas here?\nIt was caused by , can you check? I see a visual difference not only with the alignment but also the spacing: Before <img width=\"254\" alt=\"image\" src=\"https://user-\"After <img width=\"269\" alt=\"image\" src=\"https://user-\"\nit looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix.\n<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased", "positive_passages": [{"docid": "doc-en-vscode-91b236a75ab5db4b329e1cb3a78ff4d92f216d9314dcc0392eabfd9714b9cb57", "text": ".customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item .custom-view-tree-node-item-resourceLabel::after { padding-right: 0px; <ins> margin-right: 4px; </ins> } .customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item .actions {", "commid": "vscode_pr_160797"}], "negative_passages": []}
{"query_id": "q-en-vscode-44cc400fb2d4e4825bebe52b7a47d8bef9b2ae1775c76f69bb9b0eb6b2387401", "query": "ox1D426 all char in a-z without m has unicode highlight. ! ps. Can I get a map table for unicode char and its common type?", "positive_passages": [{"docid": "doc-en-vscode-d34129f2af17023ebe1f121d18847c853bf9cb5c8803c480b46a3e8984de1c28", "text": "// Generated using https://github.com/hediet/vscode-unicode-data // Stored as key1, value1, key2, value2, ... return JSON.parse( <del> '{\"_common\":[8232,32,8233,32,5760,32,8192,32,8193,32,8194,32,8195,32,8196,32,8197,32,8198,32,8200,32,8201,32,8202,32,8287,32,8199,32,8239,32,2042,95,65101,95,65102,95,65103,95,8208,45,8209,45,8210,45,65112,45,1748,45,8259,45,727,45,8722,45,10134,45,11450,45,1549,44,1643,44,8218,44,184,44,42233,44,894,59,2307,58,2691,58,1417,58,1795,58,1796,58,5868,58,65072,58,6147,58,6153,58,8282,58,1475,58,760,58,42889,58,8758,58,720,58,42237,58,451,33,11601,33,660,63,577,63,2429,63,5038,63,42731,63,119149,46,8228,46,1793,46,1794,46,42510,46,68176,46,1632,46,1776,46,42232,46,1373,96,65287,96,8219,96,8242,96,1370,96,1523,96,8175,96,65344,96,900,96,8189,96,8125,96,8127,96,8190,96,697,96,884,96,712,96,714,96,715,96,756,96,699,96,701,96,700,96,702,96,42892,96,1497,96,2036,96,2037,96,5194,96,5836,96,94033,96,94034,96,65339,91,10088,40,10098,40,12308,40,64830,40,65341,93,10089,41,10099,41,12309,41,64831,41,10100,123,119060,123,10101,125,65342,94,8270,42,1645,42,8727,42,66335,42,5941,47,8257,47,8725,47,8260,47,9585,47,10187,47,10744,47,119354,47,12755,47,12339,47,11462,47,20031,47,12035,47,65340,92,65128,92,8726,92,10189,92,10741,92,10745,92,119311,92,119355,92,12756,92,20022,92,12034,92,42872,38,708,94,710,94,5869,43,10133,43,66203,43,8249,60,10094,60,706,60,119350,60,5176,60,5810,60,5120,61,11840,61,12448,61,42239,61,8250,62,10095,62,707,62,119351,62,5171,62,94015,62,8275,126,732,126,8128,126,8764,126,65372,124,65293,45,120784,50,120794,50,120804,50,120814,50,120824,50,130034,50,42842,50,423,50,1000,50,42564,50,5311,50,42735,50,119302,51,120785,51,120795,51,120805,51,120815,51,120825,51,130035,51,42923,51,540,51,439,51,42858,51,11468,51,1248,51,94011,51,71882,51,120786,52,120796,52,120806,52,120816,52,120826,52,130036,52,5070,52,71855,52,120787,53,120797,53,120807,53,120817,53,120827,53,130037,53,444,53,71867,53,120788,54,120798,54,120808,54,120818,54,120828,54,130038,54,11474,54,5102,54,71893,54,119314,55,120789,55,120799,55,120809,55,120819,55,120829,55,130039,55,66770,55,71878,55,2819,56,2538,56,2666,56,125131,56,120790,56,120800,56,120810,56,120820,56,120830,56,130040,56,547,56,546,56,66330,56,2663,57,2920,57,2541,57,3437,57,120791,57,120801,57,120811,57,120821,57,120831,57,130041,57,42862,57,11466,57,71884,57,71852,57,71894,57,9082,97,65345,97,119834,97,119886,97,119938,97,119990,97,120042,97,120094,97,120146,97,120198,97,120250,97,120302,97,120354,97,120406,97,120458,97,593,97,945,97,120514,97,120572,97,120630,97,120688,97,120746,97,65313,65,119808,65,119860,65,119912,65,119964,65,120016,65,120068,65,120120,65,120172,65,120224,65,120276,65,120328,65,120380,65,120432,65,913,65,120488,65,120546,65,120604,65,120662,65,120720,65,5034,65,5573,65,42222,65,94016,65,66208,65,119835,98,119887,98,119939,98,119991,98,120043,98,120095,98,120147,98,120199,98,120251,98,120303,98,120355,98,120407,98,120459,98,388,98,5071,98,5234,98,5551,98,65314,66,8492,66,119809,66,119861,66,119913,66,120017,66,120069,66,120121,66,120173,66,120225,66,120277,66,120329,66,120381,66,120433,66,42932,66,914,66,120489,66,120547,66,120605,66,120663,66,120721,66,5108,66,5623,66,42192,66,66178,66,66209,66,66305,66,65347,99,8573,99,119836,99,119888,99,119940,99,119992,99,120044,99,120096,99,120148,99,120200,99,120252,99,120304,99,120356,99,120408,99,120460,99,7428,99,1010,99,11429,99,43951,99,66621,99,128844,67,71922,67,71913,67,65315,67,8557,67,8450,67,8493,67,119810,67,119862,67,119914,67,119966,67,120018,67,120174,67,120226,67,120278,67,120330,67,120382,67,120434,67,1017,67,11428,67,5087,67,42202,67,66210,67,66306,67,66581,67,66844,67,8574,100,8518,100,119837,100,119889,100,119941,100,119993,100,120045,100,120097,100,120149,100,120201,100,120253,100,120305,100,120357,100,120409,100,120461,100,1281,100,5095,100,5231,100,42194,100,8558,68,8517,68,119811,68,119863,68,119915,68,119967,68,120019,68,120071,68,120123,68,120175,68,120227,68,120279,68,120331,68,120383,68,120435,68,5024,68,5598,68,5610,68,42195,68,8494,101,65349,101,8495,101,8519,101,119838,101,119890,101,119942,101,120046,101,120098,101,120150,101,120202,101,120254,101,120306,101,120358,101,120410,101,120462,101,43826,101,1213,101,8959,69,65317,69,8496,69,119812,69,119864,69,119916,69,120020,69,120072,69,120124,69,120176,69,120228,69,120280,69,120332,69,120384,69,120436,69,917,69,120492,69,120550,69,120608,69,120666,69,120724,69,11577,69,5036,69,42224,69,71846,69,71854,69,66182,69,119839,102,119891,102,119943,102,119995,102,120047,102,120099,102,120151,102,120203,102,120255,102,120307,102,120359,102,120411,102,120463,102,43829,102,42905,102,383,102,7837,102,1412,102,119315,70,8497,70,119813,70,119865,70,119917,70,120021,70,120073,70,120125,70,120177,70,120229,70,120281,70,120333,70,120385,70,120437,70,42904,70,988,70,120778,70,5556,70,42205,70,71874,70,71842,70,66183,70,66213,70,66853,70,65351,103,8458,103,119840,103,119892,103,119944,103,120048,103,120100,103,120152,103,120204,103,120256,103,120308,103,120360,103,120412,103,120464,103,609,103,7555,103,397,103,1409,103,119814,71,119866,71,119918,71,119970,71,120022,71,120074,71,120126,71,120178,71,120230,71,120282,71,120334,71,120386,71,120438,71,1292,71,5056,71,5107,71,42198,71,65352,104,8462,104,119841,104,119945,104,119997,104,120049,104,120101,104,120153,104,120205,104,120257,104,120309,104,120361,104,120413,104,120465,104,1211,104,1392,104,5058,104,65320,72,8459,72,8460,72,8461,72,119815,72,119867,72,119919,72,120023,72,120179,72,120231,72,120283,72,120335,72,120387,72,120439,72,919,72,120494,72,120552,72,120610,72,120668,72,120726,72,11406,72,5051,72,5500,72,42215,72,66255,72,731,105,9075,105,65353,105,8560,105,8505,105,8520,105,119842,105,119894,105,119946,105,119998,105,120050,105,120102,105,120154,105,120206,105,120258,105,120310,105,120362,105,120414,105,120466,105,120484,105,618,105,617,105,953,105,8126,105,890,105,120522,105,120580,105,120638,105,120696,105,120754,105,1110,105,42567,105,1231,105,43893,105,5029,105,71875,105,65354,106,8521,106,119843,106,119895,106,119947,106,119999,106,120051,106,120103,106,120155,106,120207,106,120259,106,120311,106,120363,106,120415,106,120467,106,1011,106,1112,106,65322,74,119817,74,119869,74,119921,74,119973,74,120025,74,120077,74,120129,74,120181,74,120233,74,120285,74,120337,74,120389,74,120441,74,42930,74,895,74,1032,74,5035,74,5261,74,42201,74,119844,107,119896,107,119948,107,120000,107,120052,107,120104,107,120156,107,120208,107,120260,107,120312,107,120364,107,120416,107,120468,107,8490,75,65323,75,119818,75,119870,75,119922,75,119974,75,120026,75,120078,75,120130,75,120182,75,120234,75,120286,75,120338,75,120390,75,120442,75,922,75,120497,75,120555,75,120613,75,120671,75,120729,75,11412,75,5094,75,5845,75,42199,75,66840,75,1472,108,8739,73,9213,73,65512,73,1633,108,1777,73,66336,108,125127,108,120783,73,120793,73,120803,73,120813,73,120823,73,130033,73,65321,73,8544,73,8464,73,8465,73,119816,73,119868,73,119920,73,120024,73,120128,73,120180,73,120232,73,120284,73,120336,73,120388,73,120440,73,65356,108,8572,73,8467,108,119845,108,119897,108,119949,108,120001,108,120053,108,120105,73,120157,73,120209,73,120261,73,120313,73,120365,73,120417,73,120469,73,448,73,120496,73,120554,73,120612,73,120670,73,120728,73,11410,73,1030,73,1216,73,1493,108,1503,108,1575,108,126464,108,126592,108,65166,108,65165,108,1994,108,11599,73,5825,73,42226,73,93992,73,66186,124,66313,124,119338,76,8556,76,8466,76,119819,76,119871,76,119923,76,120027,76,120079,76,120131,76,120183,76,120235,76,120287,76,120339,76,120391,76,120443,76,11472,76,5086,76,5290,76,42209,76,93974,76,71843,76,71858,76,66587,76,66854,76,65325,77,8559,77,8499,77,119820,77,119872,77,119924,77,120028,77,120080,77,120132,77,120184,77,120236,77,120288,77,120340,77,120392,77,120444,77,924,77,120499,77,120557,77,120615,77,120673,77,120731,77,1018,77,11416,77,5047,77,5616,77,5846,77,42207,77,66224,77,66321,77,119847,110,119899,110,119951,110,120003,110,120055,110,120107,110,120159,110,120211,110,120263,110,120315,110,120367,110,120419,110,120471,110,1400,110,1404,110,65326,78,8469,78,119821,78,119873,78,119925,78,119977,78,120029,78,120081,78,120185,78,120237,78,120289,78,120341,78,120393,78,120445,78,925,78,120500,78,120558,78,120616,78,120674,78,120732,78,11418,78,42208,78,66835,78,3074,111,3202,111,3330,111,3458,111,2406,111,2662,111,2790,111,3046,111,3174,111,3302,111,3430,111,3664,111,3792,111,4160,111,1637,111,1781,111,65359,111,8500,111,119848,111,119900,111,119952,111,120056,111,120108,111,120160,111,120212,111,120264,111,120316,111,120368,111,120420,111,120472,111,7439,111,7441,111,43837,111,959,111,120528,111,120586,111,120644,111,120702,111,120760,111,963,111,120532,111,120590,111,120648,111,120706,111,120764,111,11423,111,4351,111,1413,111,1505,111,1607,111,126500,111,126564,111,126596,111,65259,111,65260,111,65258,111,65257,111,1726,111,64428,111,64429,111,64427,111,64426,111,1729,111,64424,111,64425,111,64423,111,64422,111,1749,111,3360,111,4125,111,66794,111,71880,111,71895,111,66604,111,1984,79,2534,79,2918,79,12295,79,70864,79,71904,79,120782,79,120792,79,120802,79,120812,79,120822,79,130032,79,65327,79,119822,79,119874,79,119926,79,119978,79,120030,79,120082,79,120134,79,120186,79,120238,79,120290,79,120342,79,120394,79,120446,79,927,79,120502,79,120560,79,120618,79,120676,79,120734,79,11422,79,1365,79,11604,79,4816,79,2848,79,66754,79,42227,79,71861,79,66194,79,66219,79,66564,79,66838,79,9076,112,65360,112,119849,112,119901,112,119953,112,120005,112,120057,112,120109,112,120161,112,120213,112,120265,112,120317,112,120369,112,120421,112,120473,112,961,112,120530,112,120544,112,120588,112,120602,112,120646,112,120660,112,120704,112,120718,112,120762,112,120776,112,11427,112,65328,80,8473,80,119823,80,119875,80,119927,80,119979,80,120031,80,120083,80,120187,80,120239,80,120291,80,120343,80,120395,80,120447,80,929,80,120504,80,120562,80,120620,80,120678,80,120736,80,11426,80,5090,80,5229,80,42193,80,66197,80,119850,113,119902,113,119954,113,120006,113,120058,113,120110,113,120162,113,120214,113,120266,113,120318,113,120370,113,120422,113,120474,113,1307,113,1379,113,1382,113,8474,81,119824,81,119876,81,119928,81,119980,81,120032,81,120084,81,120188,81,120240,81,120292,81,120344,81,120396,81,120448,81,11605,81,119851,114,119903,114,119955,114,120007,114,120059,114,120111,114,120163,114,120215,114,120267,114,120319,114,120371,114,120423,114,120475,114,43847,114,43848,114,7462,114,11397,114,43905,114,119318,82,8475,82,8476,82,8477,82,119825,82,119877,82,119929,82,120033,82,120189,82,120241,82,120293,82,120345,82,120397,82,120449,82,422,82,5025,82,5074,82,66740,82,5511,82,42211,82,94005,82,65363,115,119852,115,119904,115,119956,115,120008,115,120060,115,120112,115,120164,115,120216,115,120268,115,120320,115,120372,115,120424,115,120476,115,42801,115,445,115,1109,115,43946,115,71873,115,66632,115,65331,83,119826,83,119878,83,119930,83,119982,83,120034,83,120086,83,120138,83,120190,83,120242,83,120294,83,120346,83,120398,83,120450,83,1029,83,1359,83,5077,83,5082,83,42210,83,94010,83,66198,83,66592,83,119853,116,119905,116,119957,116,120009,116,120061,116,120113,116,120165,116,120217,116,120269,116,120321,116,120373,116,120425,116,120477,116,8868,84,10201,84,128872,84,65332,84,119827,84,119879,84,119931,84,119983,84,120035,84,120087,84,120139,84,120191,84,120243,84,120295,84,120347,84,120399,84,120451,84,932,84,120507,84,120565,84,120623,84,120681,84,120739,84,11430,84,5026,84,42196,84,93962,84,71868,84,66199,84,66225,84,66325,84,119854,117,119906,117,119958,117,120010,117,120062,117,120114,117,120166,117,120218,117,120270,117,120322,117,120374,117,120426,117,120478,117,42911,117,7452,117,43854,117,43858,117,651,117,965,117,120534,117,120592,117,120650,117,120708,117,120766,117,1405,117,66806,117,71896,117,8746,85,8899,85,119828,85,119880,85,119932,85,119984,85,120036,85,120088,85,120140,85,120192,85,120244,85,120296,85,120348,85,120400,85,120452,85,1357,85,4608,85,66766,85,5196,85,42228,85,94018,85,71864,85,8744,118,8897,118,65366,118,8564,118,119855,118,119907,118,119959,118,120011,118,120063,118,120115,118,120167,118,120219,118,120271,118,120323,118,120375,118,120427,118,120479,118,7456,118,957,118,120526,118,120584,118,120642,118,120700,118,120758,118,1141,118,1496,118,71430,118,43945,118,71872,118,119309,86,1639,86,1783,86,8548,86,119829,86,119881,86,119933,86,119985,86,120037,86,120089,86,120141,86,120193,86,120245,86,120297,86,120349,86,120401,86,120453,86,1140,86,11576,86,5081,86,5167,86,42719,86,42214,86,93960,86,71840,86,66845,86,623,119,119856,119,119908,119,119960,119,120012,119,120064,119,120116,119,120168,119,120220,119,120272,119,120324,119,120376,119,120428,119,120480,119,7457,119,1121,119,1309,119,1377,119,71434,119,71438,119,71439,119,43907,119,71919,87,71910,87,119830,87,119882,87,119934,87,119986,87,120038,87,120090,87,120142,87,120194,87,120246,87,120298,87,120350,87,120402,87,120454,87,1308,87,5043,87,5076,87,42218,87,5742,120,10539,120,10540,120,10799,120,65368,120,8569,120,119857,120,119909,120,119961,120,120013,120,120065,120,120117,120,120169,120,120221,120,120273,120,120325,120,120377,120,120429,120,120481,120,5441,120,5501,120,5741,88,9587,88,66338,88,71916,88,65336,88,8553,88,119831,88,119883,88,119935,88,119987,88,120039,88,120091,88,120143,88,120195,88,120247,88,120299,88,120351,88,120403,88,120455,88,42931,88,935,88,120510,88,120568,88,120626,88,120684,88,120742,88,11436,88,11613,88,5815,88,42219,88,66192,88,66228,88,66327,88,66855,88,611,121,7564,121,65369,121,119858,121,119910,121,119962,121,120014,121,120066,121,120118,121,120170,121,120222,121,120274,121,120326,121,120378,121,120430,121,120482,121,655,121,7935,121,43866,121,947,121,8509,121,120516,121,120574,121,120632,121,120690,121,120748,121,1199,121,4327,121,71900,121,65337,89,119832,89,119884,89,119936,89,119988,89,120040,89,120092,89,120144,89,120196,89,120248,89,120300,89,120352,89,120404,89,120456,89,933,89,978,89,120508,89,120566,89,120624,89,120682,89,120740,89,11432,89,1198,89,5033,89,5053,89,42220,89,94019,89,71844,89,66226,89,119859,122,119911,122,119963,122,120015,122,120067,122,120119,122,120171,122,120223,122,120275,122,120327,122,120379,122,120431,122,120483,122,7458,122,43923,122,71876,122,66293,90,71909,90,65338,90,8484,90,8488,90,119833,90,119885,90,119937,90,119989,90,120041,90,120197,90,120249,90,120301,90,120353,90,120405,90,120457,90,918,90,120493,90,120551,90,120609,90,120667,90,120725,90,5059,90,42204,90,71849,90,65282,34,65284,36,65285,37,65286,38,65290,42,65291,43,65294,46,65295,47,65296,48,65297,49,65298,50,65299,51,65300,52,65301,53,65302,54,65303,55,65304,56,65305,57,65308,60,65309,61,65310,62,65312,64,65316,68,65318,70,65319,71,65324,76,65329,81,65330,82,65333,85,65334,86,65335,87,65343,95,65346,98,65348,100,65350,102,65355,107,65357,109,65358,110,65361,113,65362,114,65364,116,65365,117,65367,119,65370,122,65371,123,65373,125],\"_default\":[160,32,8211,45,65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"cs\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"de\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"es\":[8211,45,65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"fr\":[65374,126,65306,58,65281,33,8216,96,8245,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"it\":[160,32,8211,45,65374,126,65306,58,65281,33,8216,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"ja\":[8211,45,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65292,44,65307,59],\"ko\":[8211,45,65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"pl\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"pt-BR\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"qps-ploc\":[160,32,8211,45,65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"ru\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,305,105,921,73,1009,112,215,120,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"tr\":[160,32,8211,45,65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"zh-hans\":[65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65288,40,65289,41],\"zh-hant\":[8211,45,65374,126,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65307,59]}' </del> <ins> '{\"_common\":[8232,32,8233,32,5760,32,8192,32,8193,32,8194,32,8195,32,8196,32,8197,32,8198,32,8200,32,8201,32,8202,32,8287,32,8199,32,8239,32,2042,95,65101,95,65102,95,65103,95,8208,45,8209,45,8210,45,65112,45,1748,45,8259,45,727,45,8722,45,10134,45,11450,45,1549,44,1643,44,8218,44,184,44,42233,44,894,59,2307,58,2691,58,1417,58,1795,58,1796,58,5868,58,65072,58,6147,58,6153,58,8282,58,1475,58,760,58,42889,58,8758,58,720,58,42237,58,451,33,11601,33,660,63,577,63,2429,63,5038,63,42731,63,119149,46,8228,46,1793,46,1794,46,42510,46,68176,46,1632,46,1776,46,42232,46,1373,96,65287,96,8219,96,8242,96,1370,96,1523,96,8175,96,65344,96,900,96,8189,96,8125,96,8127,96,8190,96,697,96,884,96,712,96,714,96,715,96,756,96,699,96,701,96,700,96,702,96,42892,96,1497,96,2036,96,2037,96,5194,96,5836,96,94033,96,94034,96,65339,91,10088,40,10098,40,12308,40,64830,40,65341,93,10089,41,10099,41,12309,41,64831,41,10100,123,119060,123,10101,125,65342,94,8270,42,1645,42,8727,42,66335,42,5941,47,8257,47,8725,47,8260,47,9585,47,10187,47,10744,47,119354,47,12755,47,12339,47,11462,47,20031,47,12035,47,65340,92,65128,92,8726,92,10189,92,10741,92,10745,92,119311,92,119355,92,12756,92,20022,92,12034,92,42872,38,708,94,710,94,5869,43,10133,43,66203,43,8249,60,10094,60,706,60,119350,60,5176,60,5810,60,5120,61,11840,61,12448,61,42239,61,8250,62,10095,62,707,62,119351,62,5171,62,94015,62,8275,126,732,126,8128,126,8764,126,65372,124,65293,45,120784,50,120794,50,120804,50,120814,50,120824,50,130034,50,42842,50,423,50,1000,50,42564,50,5311,50,42735,50,119302,51,120785,51,120795,51,120805,51,120815,51,120825,51,130035,51,42923,51,540,51,439,51,42858,51,11468,51,1248,51,94011,51,71882,51,120786,52,120796,52,120806,52,120816,52,120826,52,130036,52,5070,52,71855,52,120787,53,120797,53,120807,53,120817,53,120827,53,130037,53,444,53,71867,53,120788,54,120798,54,120808,54,120818,54,120828,54,130038,54,11474,54,5102,54,71893,54,119314,55,120789,55,120799,55,120809,55,120819,55,120829,55,130039,55,66770,55,71878,55,2819,56,2538,56,2666,56,125131,56,120790,56,120800,56,120810,56,120820,56,120830,56,130040,56,547,56,546,56,66330,56,2663,57,2920,57,2541,57,3437,57,120791,57,120801,57,120811,57,120821,57,120831,57,130041,57,42862,57,11466,57,71884,57,71852,57,71894,57,9082,97,65345,97,119834,97,119886,97,119938,97,119990,97,120042,97,120094,97,120146,97,120198,97,120250,97,120302,97,120354,97,120406,97,120458,97,593,97,945,97,120514,97,120572,97,120630,97,120688,97,120746,97,65313,65,119808,65,119860,65,119912,65,119964,65,120016,65,120068,65,120120,65,120172,65,120224,65,120276,65,120328,65,120380,65,120432,65,913,65,120488,65,120546,65,120604,65,120662,65,120720,65,5034,65,5573,65,42222,65,94016,65,66208,65,119835,98,119887,98,119939,98,119991,98,120043,98,120095,98,120147,98,120199,98,120251,98,120303,98,120355,98,120407,98,120459,98,388,98,5071,98,5234,98,5551,98,65314,66,8492,66,119809,66,119861,66,119913,66,120017,66,120069,66,120121,66,120173,66,120225,66,120277,66,120329,66,120381,66,120433,66,42932,66,914,66,120489,66,120547,66,120605,66,120663,66,120721,66,5108,66,5623,66,42192,66,66178,66,66209,66,66305,66,65347,99,8573,99,119836,99,119888,99,119940,99,119992,99,120044,99,120096,99,120148,99,120200,99,120252,99,120304,99,120356,99,120408,99,120460,99,7428,99,1010,99,11429,99,43951,99,66621,99,128844,67,71922,67,71913,67,65315,67,8557,67,8450,67,8493,67,119810,67,119862,67,119914,67,119966,67,120018,67,120174,67,120226,67,120278,67,120330,67,120382,67,120434,67,1017,67,11428,67,5087,67,42202,67,66210,67,66306,67,66581,67,66844,67,8574,100,8518,100,119837,100,119889,100,119941,100,119993,100,120045,100,120097,100,120149,100,120201,100,120253,100,120305,100,120357,100,120409,100,120461,100,1281,100,5095,100,5231,100,42194,100,8558,68,8517,68,119811,68,119863,68,119915,68,119967,68,120019,68,120071,68,120123,68,120175,68,120227,68,120279,68,120331,68,120383,68,120435,68,5024,68,5598,68,5610,68,42195,68,8494,101,65349,101,8495,101,8519,101,119838,101,119890,101,119942,101,120046,101,120098,101,120150,101,120202,101,120254,101,120306,101,120358,101,120410,101,120462,101,43826,101,1213,101,8959,69,65317,69,8496,69,119812,69,119864,69,119916,69,120020,69,120072,69,120124,69,120176,69,120228,69,120280,69,120332,69,120384,69,120436,69,917,69,120492,69,120550,69,120608,69,120666,69,120724,69,11577,69,5036,69,42224,69,71846,69,71854,69,66182,69,119839,102,119891,102,119943,102,119995,102,120047,102,120099,102,120151,102,120203,102,120255,102,120307,102,120359,102,120411,102,120463,102,43829,102,42905,102,383,102,7837,102,1412,102,119315,70,8497,70,119813,70,119865,70,119917,70,120021,70,120073,70,120125,70,120177,70,120229,70,120281,70,120333,70,120385,70,120437,70,42904,70,988,70,120778,70,5556,70,42205,70,71874,70,71842,70,66183,70,66213,70,66853,70,65351,103,8458,103,119840,103,119892,103,119944,103,120048,103,120100,103,120152,103,120204,103,120256,103,120308,103,120360,103,120412,103,120464,103,609,103,7555,103,397,103,1409,103,119814,71,119866,71,119918,71,119970,71,120022,71,120074,71,120126,71,120178,71,120230,71,120282,71,120334,71,120386,71,120438,71,1292,71,5056,71,5107,71,42198,71,65352,104,8462,104,119841,104,119945,104,119997,104,120049,104,120101,104,120153,104,120205,104,120257,104,120309,104,120361,104,120413,104,120465,104,1211,104,1392,104,5058,104,65320,72,8459,72,8460,72,8461,72,119815,72,119867,72,119919,72,120023,72,120179,72,120231,72,120283,72,120335,72,120387,72,120439,72,919,72,120494,72,120552,72,120610,72,120668,72,120726,72,11406,72,5051,72,5500,72,42215,72,66255,72,731,105,9075,105,65353,105,8560,105,8505,105,8520,105,119842,105,119894,105,119946,105,119998,105,120050,105,120102,105,120154,105,120206,105,120258,105,120310,105,120362,105,120414,105,120466,105,120484,105,618,105,617,105,953,105,8126,105,890,105,120522,105,120580,105,120638,105,120696,105,120754,105,1110,105,42567,105,1231,105,43893,105,5029,105,71875,105,65354,106,8521,106,119843,106,119895,106,119947,106,119999,106,120051,106,120103,106,120155,106,120207,106,120259,106,120311,106,120363,106,120415,106,120467,106,1011,106,1112,106,65322,74,119817,74,119869,74,119921,74,119973,74,120025,74,120077,74,120129,74,120181,74,120233,74,120285,74,120337,74,120389,74,120441,74,42930,74,895,74,1032,74,5035,74,5261,74,42201,74,119844,107,119896,107,119948,107,120000,107,120052,107,120104,107,120156,107,120208,107,120260,107,120312,107,120364,107,120416,107,120468,107,8490,75,65323,75,119818,75,119870,75,119922,75,119974,75,120026,75,120078,75,120130,75,120182,75,120234,75,120286,75,120338,75,120390,75,120442,75,922,75,120497,75,120555,75,120613,75,120671,75,120729,75,11412,75,5094,75,5845,75,42199,75,66840,75,1472,108,8739,73,9213,73,65512,73,1633,108,1777,73,66336,108,125127,108,120783,73,120793,73,120803,73,120813,73,120823,73,130033,73,65321,73,8544,73,8464,73,8465,73,119816,73,119868,73,119920,73,120024,73,120128,73,120180,73,120232,73,120284,73,120336,73,120388,73,120440,73,65356,108,8572,73,8467,108,119845,108,119897,108,119949,108,120001,108,120053,108,120105,73,120157,73,120209,73,120261,73,120313,73,120365,73,120417,73,120469,73,448,73,120496,73,120554,73,120612,73,120670,73,120728,73,11410,73,1030,73,1216,73,1493,108,1503,108,1575,108,126464,108,126592,108,65166,108,65165,108,1994,108,11599,73,5825,73,42226,73,93992,73,66186,124,66313,124,119338,76,8556,76,8466,76,119819,76,119871,76,119923,76,120027,76,120079,76,120131,76,120183,76,120235,76,120287,76,120339,76,120391,76,120443,76,11472,76,5086,76,5290,76,42209,76,93974,76,71843,76,71858,76,66587,76,66854,76,65325,77,8559,77,8499,77,119820,77,119872,77,119924,77,120028,77,120080,77,120132,77,120184,77,120236,77,120288,77,120340,77,120392,77,120444,77,924,77,120499,77,120557,77,120615,77,120673,77,120731,77,1018,77,11416,77,5047,77,5616,77,5846,77,42207,77,66224,77,66321,77,119847,110,119899,110,119951,110,120003,110,120055,110,120107,110,120159,110,120211,110,120263,110,120315,110,120367,110,120419,110,120471,110,1400,110,1404,110,65326,78,8469,78,119821,78,119873,78,119925,78,119977,78,120029,78,120081,78,120185,78,120237,78,120289,78,120341,78,120393,78,120445,78,925,78,120500,78,120558,78,120616,78,120674,78,120732,78,11418,78,42208,78,66835,78,3074,111,3202,111,3330,111,3458,111,2406,111,2662,111,2790,111,3046,111,3174,111,3302,111,3430,111,3664,111,3792,111,4160,111,1637,111,1781,111,65359,111,8500,111,119848,111,119900,111,119952,111,120056,111,120108,111,120160,111,120212,111,120264,111,120316,111,120368,111,120420,111,120472,111,7439,111,7441,111,43837,111,959,111,120528,111,120586,111,120644,111,120702,111,120760,111,963,111,120532,111,120590,111,120648,111,120706,111,120764,111,11423,111,4351,111,1413,111,1505,111,1607,111,126500,111,126564,111,126596,111,65259,111,65260,111,65258,111,65257,111,1726,111,64428,111,64429,111,64427,111,64426,111,1729,111,64424,111,64425,111,64423,111,64422,111,1749,111,3360,111,4125,111,66794,111,71880,111,71895,111,66604,111,1984,79,2534,79,2918,79,12295,79,70864,79,71904,79,120782,79,120792,79,120802,79,120812,79,120822,79,130032,79,65327,79,119822,79,119874,79,119926,79,119978,79,120030,79,120082,79,120134,79,120186,79,120238,79,120290,79,120342,79,120394,79,120446,79,927,79,120502,79,120560,79,120618,79,120676,79,120734,79,11422,79,1365,79,11604,79,4816,79,2848,79,66754,79,42227,79,71861,79,66194,79,66219,79,66564,79,66838,79,9076,112,65360,112,119849,112,119901,112,119953,112,120005,112,120057,112,120109,112,120161,112,120213,112,120265,112,120317,112,120369,112,120421,112,120473,112,961,112,120530,112,120544,112,120588,112,120602,112,120646,112,120660,112,120704,112,120718,112,120762,112,120776,112,11427,112,65328,80,8473,80,119823,80,119875,80,119927,80,119979,80,120031,80,120083,80,120187,80,120239,80,120291,80,120343,80,120395,80,120447,80,929,80,120504,80,120562,80,120620,80,120678,80,120736,80,11426,80,5090,80,5229,80,42193,80,66197,80,119850,113,119902,113,119954,113,120006,113,120058,113,120110,113,120162,113,120214,113,120266,113,120318,113,120370,113,120422,113,120474,113,1307,113,1379,113,1382,113,8474,81,119824,81,119876,81,119928,81,119980,81,120032,81,120084,81,120188,81,120240,81,120292,81,120344,81,120396,81,120448,81,11605,81,119851,114,119903,114,119955,114,120007,114,120059,114,120111,114,120163,114,120215,114,120267,114,120319,114,120371,114,120423,114,120475,114,43847,114,43848,114,7462,114,11397,114,43905,114,119318,82,8475,82,8476,82,8477,82,119825,82,119877,82,119929,82,120033,82,120189,82,120241,82,120293,82,120345,82,120397,82,120449,82,422,82,5025,82,5074,82,66740,82,5511,82,42211,82,94005,82,65363,115,119852,115,119904,115,119956,115,120008,115,120060,115,120112,115,120164,115,120216,115,120268,115,120320,115,120372,115,120424,115,120476,115,42801,115,445,115,1109,115,43946,115,71873,115,66632,115,65331,83,119826,83,119878,83,119930,83,119982,83,120034,83,120086,83,120138,83,120190,83,120242,83,120294,83,120346,83,120398,83,120450,83,1029,83,1359,83,5077,83,5082,83,42210,83,94010,83,66198,83,66592,83,119853,116,119905,116,119957,116,120009,116,120061,116,120113,116,120165,116,120217,116,120269,116,120321,116,120373,116,120425,116,120477,116,8868,84,10201,84,128872,84,65332,84,119827,84,119879,84,119931,84,119983,84,120035,84,120087,84,120139,84,120191,84,120243,84,120295,84,120347,84,120399,84,120451,84,932,84,120507,84,120565,84,120623,84,120681,84,120739,84,11430,84,5026,84,42196,84,93962,84,71868,84,66199,84,66225,84,66325,84,119854,117,119906,117,119958,117,120010,117,120062,117,120114,117,120166,117,120218,117,120270,117,120322,117,120374,117,120426,117,120478,117,42911,117,7452,117,43854,117,43858,117,651,117,965,117,120534,117,120592,117,120650,117,120708,117,120766,117,1405,117,66806,117,71896,117,8746,85,8899,85,119828,85,119880,85,119932,85,119984,85,120036,85,120088,85,120140,85,120192,85,120244,85,120296,85,120348,85,120400,85,120452,85,1357,85,4608,85,66766,85,5196,85,42228,85,94018,85,71864,85,8744,118,8897,118,65366,118,8564,118,119855,118,119907,118,119959,118,120011,118,120063,118,120115,118,120167,118,120219,118,120271,118,120323,118,120375,118,120427,118,120479,118,7456,118,957,118,120526,118,120584,118,120642,118,120700,118,120758,118,1141,118,1496,118,71430,118,43945,118,71872,118,119309,86,1639,86,1783,86,8548,86,119829,86,119881,86,119933,86,119985,86,120037,86,120089,86,120141,86,120193,86,120245,86,120297,86,120349,86,120401,86,120453,86,1140,86,11576,86,5081,86,5167,86,42719,86,42214,86,93960,86,71840,86,66845,86,623,119,119856,119,119908,119,119960,119,120012,119,120064,119,120116,119,120168,119,120220,119,120272,119,120324,119,120376,119,120428,119,120480,119,7457,119,1121,119,1309,119,1377,119,71434,119,71438,119,71439,119,43907,119,71919,87,71910,87,119830,87,119882,87,119934,87,119986,87,120038,87,120090,87,120142,87,120194,87,120246,87,120298,87,120350,87,120402,87,120454,87,1308,87,5043,87,5076,87,42218,87,5742,120,10539,120,10540,120,10799,120,65368,120,8569,120,119857,120,119909,120,119961,120,120013,120,120065,120,120117,120,120169,120,120221,120,120273,120,120325,120,120377,120,120429,120,120481,120,5441,120,5501,120,5741,88,9587,88,66338,88,71916,88,65336,88,8553,88,119831,88,119883,88,119935,88,119987,88,120039,88,120091,88,120143,88,120195,88,120247,88,120299,88,120351,88,120403,88,120455,88,42931,88,935,88,120510,88,120568,88,120626,88,120684,88,120742,88,11436,88,11613,88,5815,88,42219,88,66192,88,66228,88,66327,88,66855,88,611,121,7564,121,65369,121,119858,121,119910,121,119962,121,120014,121,120066,121,120118,121,120170,121,120222,121,120274,121,120326,121,120378,121,120430,121,120482,121,655,121,7935,121,43866,121,947,121,8509,121,120516,121,120574,121,120632,121,120690,121,120748,121,1199,121,4327,121,71900,121,65337,89,119832,89,119884,89,119936,89,119988,89,120040,89,120092,89,120144,89,120196,89,120248,89,120300,89,120352,89,120404,89,120456,89,933,89,978,89,120508,89,120566,89,120624,89,120682,89,120740,89,11432,89,1198,89,5033,89,5053,89,42220,89,94019,89,71844,89,66226,89,119859,122,119911,122,119963,122,120015,122,120067,122,120119,122,120171,122,120223,122,120275,122,120327,122,120379,122,120431,122,120483,122,7458,122,43923,122,71876,122,66293,90,71909,90,65338,90,8484,90,8488,90,119833,90,119885,90,119937,90,119989,90,120041,90,120197,90,120249,90,120301,90,120353,90,120405,90,120457,90,918,90,120493,90,120551,90,120609,90,120667,90,120725,90,5059,90,42204,90,71849,90,65282,34,65284,36,65285,37,65286,38,65290,42,65291,43,65294,46,65295,47,65296,48,65297,49,65298,50,65299,51,65300,52,65301,53,65302,54,65303,55,65304,56,65305,57,65308,60,65309,61,65310,62,65312,64,65316,68,65318,70,65319,71,65324,76,65329,81,65330,82,65333,85,65334,86,65335,87,65343,95,65346,98,65348,100,65350,102,65355,107,65357,109,65358,110,65361,113,65362,114,65364,116,65365,117,65367,119,65370,122,65371,123,65373,125,119846,109],\"_default\":[160,32,8211,45,65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"cs\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"de\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"es\":[8211,45,65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"fr\":[65374,126,65306,58,65281,33,8216,96,8245,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"it\":[160,32,8211,45,65374,126,65306,58,65281,33,8216,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"ja\":[8211,45,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65292,44,65307,59],\"ko\":[8211,45,65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"pl\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"pt-BR\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"qps-ploc\":[160,32,8211,45,65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"ru\":[65374,126,65306,58,65281,33,8216,96,8217,96,8245,96,180,96,12494,47,305,105,921,73,1009,112,215,120,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"tr\":[160,32,8211,45,65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65288,40,65289,41,65292,44,65307,59,65311,63],\"zh-hans\":[65374,126,65306,58,65281,33,8245,96,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65288,40,65289,41],\"zh-hant\":[8211,45,65374,126,180,96,12494,47,1047,51,1073,54,1072,97,1040,65,1068,98,1042,66,1089,99,1057,67,1077,101,1045,69,1053,72,305,105,1050,75,921,73,1052,77,1086,111,1054,79,1009,112,1088,112,1056,80,1075,114,1058,84,215,120,1093,120,1061,88,1091,121,1059,89,65283,35,65307,59]}' </ins> ); });", "commid": "vscode_pr_175918"}], "negative_passages": []}
{"query_id": "q-en-vscode-5a0bdfba0ddaadae457c347f6ad435a7ae2b279f5eb00dff6d4714e80ef21451", "query": "<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.0-insider () With the C++ TestMate extension, the hierarchy of test executables and contained tests is no longer displayed correctly. This is a regression that was introduced with . Here's an example. Create a cpp file with the following content: and compile it using taken from . Then, set the config to point to the compiled executable. With VS Code v1.71.0 you get the expected browser content: <img width=\"581\" alt=\"image\" src=\"https://user-\"With the latest Insiders build, or any build from on, you get this instead: <img width=\"581\" alt=\"image\" src=\"https://user-\"Note how T1 is now a sibling of the executable, not a child. Also, the executable no longer has a play button. Cc: to since I'm not entirely sure if this is VS Code's fault, or if there's maybe something wrong with how the extension sets the URIs.\nI'm surprised would have anything to do with it, since that only touched decorations in the editor and not the core heirarchy...\nWell, I did bisect it to that commit...\nSome more information: test rediscovery is completely broken as well since that commit. I'm talking about the situation where you change the config and TestMate reevaluates which executables should show in the browser (I ). In that case, both the old and the new executable are displayed now, both with all their tests. This is reproducible and also started to happen with This is a very serious regression and makes C++ testing a lot harder. At the moment it only affects the Insiders build, but I would hate to see it become a regression in 1.72 if it's not addressed soon. again, I can't tell which of these problems are caused by VS Code or by the extension, so it would help a lot if you could have a look, too.\nI'm doing: where : results in: around: I hope it helped\nHuh, I'm very confused why that wasn't a compilation error. Thanks for the hint on the error message...\nWhen will it be this part of the downloadable insider to test it?\n<=24 hours after it's merged The bot will ping on this issue when it's ready\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-8b192abf075b4778ec63caff4c1b50794c583cb90aa359214dd18dca773fb2cf", "text": "constructor(controllerId: string, controllerLabel: string, editors: ExtHostDocumentsAndEditors) { super({ controllerId, <del> getDocumentVersion: (uri: URI) => editors.getDocument(uri)?.version, </del> <ins> getDocumentVersion: uri => uri && editors.getDocument(uri)?.version, </ins> getApiFor: getPrivateApiFor as (impl: TestItemImpl) => ITestItemApi<TestItemImpl>, getChildren: (item) => item.children as ITestChildrenLike<TestItemImpl>, root: new TestItemRootImpl(controllerId, controllerLabel),", "commid": "vscode_pr_161272"}], "negative_passages": []}
{"query_id": "q-en-vscode-bef2b9e14d760e0c1c7bf08f377861be42921b5affd2a287518732931e83373f", "query": "Chinese (Simplified) : <img width=\"321\" alt=\"image\" src=\"https://user-\"English : <img width=\"272\" alt=\"image\" src=\"https://user-\"\"Create Manual Folding Ranges from Selection\" is not in Command Palette when use Chinese (Simplified) VSCode Version: 1.71.0 (both macOS & Win10) Chinese (Simplified) Version: 1.71.\nThank you for your feedback. We are currently reviewing it (reference ).\nCould you please assist here? Thank you.\nThe problem is this label: should accept an  but it only accepts a string. deeper: and deeper:\nThe workaround is to use  to find this item.", "positive_passages": [{"docid": "doc-en-vscode-5fbcd444fb47f2033f4cd155f8247d44c1c812a3901742d7f6c87114151d2110", "text": "super({ id: 'editor.createFoldingRangeFromSelection', label: nls.localize('createManualFoldRange.label', \"Create Manual Folding Range from Selection\"), <del> alias: 'Create Folding Range from Selection', </del> <ins> alias: 'Create Manual Folding Range from Selection', </ins> precondition: CONTEXT_FOLDING_ENABLED, kbOpts: { kbExpr: EditorContextKeys.editorTextFocus,", "commid": "vscode_pr_160400"}], "negative_passages": []}
{"query_id": "q-en-vscode-7626d29388379293b7c84333d9f70151633147833415a93d614395b50f987580", "query": "GitHub Tags:#A11yMAS;#A11yTCS;#A11ySev2;#DesktopApp;#Win32;#Visual Studio Code Client;#BM-VisualStudioCodeClient-Win32-Aug2022;#WCAG1.3.1;#NVDA; #ScreenReader;#JAWS;#AILimited;#Element:Button; Application Name: Visual Studio Live Share Application version: 1.56.2 (user setup) Windows Version: Win10 VS Code a project (e.g., vsls-guestbook) in VSCode. till \u201csign in\u201d button. till \"Live share\" under Extensions and hit enter on the NVDA and tab to drop down 'Visual Studio live share work' screen. The label of the 'Visual Studio live share work\u2026.' is being read as 'folder section button' when the screen reader focus moves to it using tab key. Similar issue is observed with JAWS. The screen reader should read it as 'Visual Studio live share work button' when screen reader focus moves to it. People who uses screen reader may face difficulty while activating an object when the accessible label is different than that of the visible labels. https://user-\nlogged for primary bug\nI think this issue makes sense. In short - aria label of the explorer view should contain the name of the top folder. Currently it is just \"Folders\". So it should be dynamic. Assigning to\nActually not too sure how to fix this one. The section being read out is the static section name of the view pane We do have an aria label within that section header with the name of the folder which dynamically updates but that never gets focused. The pane registration is static and we don't know the folder name at that time\nthere's the  method in the . Update header should set the aria label of the header. And the explorer should call updateHeader every time the content of the header changes (which it might do already).\ncould you please the bug in open state the bug can be closed only by trusted tester after verification right now the fix is not present in the app Version: 1.72.0-insider (user setup) Commit: Date: 2022-09-23T05:17:37.024Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !\nplease look at the label that the VS Code bot has to the issue. It says \"unreleased\". Once the bot adds the label \"released\" that means the fix is present. We can not leave the issue open for the tester to close this since this does not align with the rest of our VS Code processes. In case the bug is not fixed after it is released, just comment on the issue and we will reopen it. Thanks!\nGitHubTags:#Closed;", "positive_passages": [{"docid": "doc-en-vscode-ed09d4f69412c45e4becc97e8e21e6abee0dab79c35c82507260635e31a41433", "text": "private _headerVisible = true; private _minimumBodySize: number; private _maximumBodySize: number; <del> private ariaHeaderLabel: string; </del> <ins> private _ariaHeaderLabel: string; </ins> private styles: IPaneStyles = {}; private animationTimer: number | undefined = undefined;", "commid": "vscode_pr_162951"}], "negative_passages": []}
{"query_id": "q-en-vscode-7626d29388379293b7c84333d9f70151633147833415a93d614395b50f987580", "query": "GitHub Tags:#A11yMAS;#A11yTCS;#A11ySev2;#DesktopApp;#Win32;#Visual Studio Code Client;#BM-VisualStudioCodeClient-Win32-Aug2022;#WCAG1.3.1;#NVDA; #ScreenReader;#JAWS;#AILimited;#Element:Button; Application Name: Visual Studio Live Share Application version: 1.56.2 (user setup) Windows Version: Win10 VS Code a project (e.g., vsls-guestbook) in VSCode. till \u201csign in\u201d button. till \"Live share\" under Extensions and hit enter on the NVDA and tab to drop down 'Visual Studio live share work' screen. The label of the 'Visual Studio live share work\u2026.' is being read as 'folder section button' when the screen reader focus moves to it using tab key. Similar issue is observed with JAWS. The screen reader should read it as 'Visual Studio live share work button' when screen reader focus moves to it. People who uses screen reader may face difficulty while activating an object when the accessible label is different than that of the visible labels. https://user-\nlogged for primary bug\nI think this issue makes sense. In short - aria label of the explorer view should contain the name of the top folder. Currently it is just \"Folders\". So it should be dynamic. Assigning to\nActually not too sure how to fix this one. The section being read out is the static section name of the view pane We do have an aria label within that section header with the name of the folder which dynamically updates but that never gets focused. The pane registration is static and we don't know the folder name at that time\nthere's the  method in the . Update header should set the aria label of the header. And the explorer should call updateHeader every time the content of the header changes (which it might do already).\ncould you please the bug in open state the bug can be closed only by trusted tester after verification right now the fix is not present in the app Version: 1.72.0-insider (user setup) Commit: Date: 2022-09-23T05:17:37.024Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !\nplease look at the label that the VS Code bot has to the issue. It says \"unreleased\". Once the bot adds the label \"released\" that means the fix is present. We can not leave the issue open for the tester to close this since this does not align with the rest of our VS Code processes. In case the bug is not fixed after it is released, just comment on the issue and we will reopen it. Thanks!\nGitHubTags:#Closed;", "positive_passages": [{"docid": "doc-en-vscode-f536377ea27301238139aaacec521184919c5886ccfccb239b136e3796558c58", "text": "private readonly _onDidChangeExpansionState = this._register(new Emitter<boolean>()); readonly onDidChangeExpansionState: Event<boolean> = this._onDidChangeExpansionState.event; <ins> get ariaHeaderLabel(): string { return this._ariaHeaderLabel; } set ariaHeaderLabel(newLabel: string) { this._ariaHeaderLabel = newLabel; this.header.setAttribute('aria-label', this.ariaHeaderLabel); } </ins> get draggableElement(): HTMLElement { return this.header; }", "commid": "vscode_pr_162951"}], "negative_passages": []}
{"query_id": "q-en-vscode-7626d29388379293b7c84333d9f70151633147833415a93d614395b50f987580", "query": "GitHub Tags:#A11yMAS;#A11yTCS;#A11ySev2;#DesktopApp;#Win32;#Visual Studio Code Client;#BM-VisualStudioCodeClient-Win32-Aug2022;#WCAG1.3.1;#NVDA; #ScreenReader;#JAWS;#AILimited;#Element:Button; Application Name: Visual Studio Live Share Application version: 1.56.2 (user setup) Windows Version: Win10 VS Code a project (e.g., vsls-guestbook) in VSCode. till \u201csign in\u201d button. till \"Live share\" under Extensions and hit enter on the NVDA and tab to drop down 'Visual Studio live share work' screen. The label of the 'Visual Studio live share work\u2026.' is being read as 'folder section button' when the screen reader focus moves to it using tab key. Similar issue is observed with JAWS. The screen reader should read it as 'Visual Studio live share work button' when screen reader focus moves to it. People who uses screen reader may face difficulty while activating an object when the accessible label is different than that of the visible labels. https://user-\nlogged for primary bug\nI think this issue makes sense. In short - aria label of the explorer view should contain the name of the top folder. Currently it is just \"Folders\". So it should be dynamic. Assigning to\nActually not too sure how to fix this one. The section being read out is the static section name of the view pane We do have an aria label within that section header with the name of the folder which dynamically updates but that never gets focused. The pane registration is static and we don't know the folder name at that time\nthere's the  method in the . Update header should set the aria label of the header. And the explorer should call updateHeader every time the content of the header changes (which it might do already).\ncould you please the bug in open state the bug can be closed only by trusted tester after verification right now the fix is not present in the app Version: 1.72.0-insider (user setup) Commit: Date: 2022-09-23T05:17:37.024Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !\nplease look at the label that the VS Code bot has to the issue. It says \"unreleased\". Once the bot adds the label \"released\" that means the fix is present. We can not leave the issue open for the tester to close this since this does not align with the rest of our VS Code processes. In case the bug is not fixed after it is released, just comment on the issue and we will reopen it. Thanks!\nGitHubTags:#Closed;", "positive_passages": [{"docid": "doc-en-vscode-365798fbed0d3a80c859d4ff285f813a7642e00f3df12895976834277ef093a4", "text": "super(); this._expanded = typeof options.expanded === 'undefined' ? true : !!options.expanded; this._orientation = typeof options.orientation === 'undefined' ? Orientation.VERTICAL : options.orientation; <del> this.ariaHeaderLabel = localize('viewSection', \"{0} Section\", options.title); </del> <ins> this._ariaHeaderLabel = localize('viewSection', \"{0} Section\", options.title); </ins> this._minimumBodySize = typeof options.minimumBodySize === 'number' ? options.minimumBodySize : this._orientation === Orientation.HORIZONTAL ? 200 : 120; this._maximumBodySize = typeof options.maximumBodySize === 'number' ? options.maximumBodySize : Number.POSITIVE_INFINITY;", "commid": "vscode_pr_162951"}], "negative_passages": []}
{"query_id": "q-en-vscode-7626d29388379293b7c84333d9f70151633147833415a93d614395b50f987580", "query": "GitHub Tags:#A11yMAS;#A11yTCS;#A11ySev2;#DesktopApp;#Win32;#Visual Studio Code Client;#BM-VisualStudioCodeClient-Win32-Aug2022;#WCAG1.3.1;#NVDA; #ScreenReader;#JAWS;#AILimited;#Element:Button; Application Name: Visual Studio Live Share Application version: 1.56.2 (user setup) Windows Version: Win10 VS Code a project (e.g., vsls-guestbook) in VSCode. till \u201csign in\u201d button. till \"Live share\" under Extensions and hit enter on the NVDA and tab to drop down 'Visual Studio live share work' screen. The label of the 'Visual Studio live share work\u2026.' is being read as 'folder section button' when the screen reader focus moves to it using tab key. Similar issue is observed with JAWS. The screen reader should read it as 'Visual Studio live share work button' when screen reader focus moves to it. People who uses screen reader may face difficulty while activating an object when the accessible label is different than that of the visible labels. https://user-\nlogged for primary bug\nI think this issue makes sense. In short - aria label of the explorer view should contain the name of the top folder. Currently it is just \"Folders\". So it should be dynamic. Assigning to\nActually not too sure how to fix this one. The section being read out is the static section name of the view pane We do have an aria label within that section header with the name of the folder which dynamically updates but that never gets focused. The pane registration is static and we don't know the folder name at that time\nthere's the  method in the . Update header should set the aria label of the header. And the explorer should call updateHeader every time the content of the header changes (which it might do already).\ncould you please the bug in open state the bug can be closed only by trusted tester after verification right now the fix is not present in the app Version: 1.72.0-insider (user setup) Commit: Date: 2022-09-23T05:17:37.024Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes !\nplease look at the label that the VS Code bot has to the issue. It says \"unreleased\". Once the bot adds the label \"released\" that means the fix is present. We can not leave the issue open for the tester to close this since this does not align with the rest of our VS Code processes. In case the bug is not fixed after it is released, just comment on the issue and we will reopen it. Thanks!\nGitHubTags:#Closed;", "positive_passages": [{"docid": "doc-en-vscode-9013013230358befc7265ccbeb92aa8c71884c92778a42ab8d187bb639bff3b7", "text": "const title = workspace.folders.map(folder => folder.name).join(); titleElement.textContent = this.name; titleElement.title = title; <del> titleElement.setAttribute('aria-label', nls.localize('explorerSection', \"Explorer Section: {0}\", this.name)); </del> <ins> this.ariaHeaderLabel = nls.localize('explorerSection', \"Explorer Section: {0}\", this.name); titleElement.setAttribute('aria-label', this.ariaHeaderLabel); </ins> }; this._register(this.contextService.onDidChangeWorkspaceName(setHeader));", "commid": "vscode_pr_162951"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-92f781ebac1b9c0325cd984e73fac1a92a85af329c13bae408ce8e2849e58790", "text": "NoPathFound = 'NoPathFound', UnknownPath = 'UnknownPath', EmptyCommitMessage = 'EmptyCommitMessage', <del> BranchFastForwardRejected = 'BranchFastForwardRejected' </del> <ins> BranchFastForwardRejected = 'BranchFastForwardRejected', TagConflict = 'TagConflict' </ins> }", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-fc95b1f3866fe940834f623b91d02d73aba15146b831546b0fba406c3b3aba5f", "text": "} } <ins> async fetchTags(options: { remote: string; tags: string[]; force?: boolean }): Promise<void> { const args = ['fetch']; const spawnOptions: SpawnOptions = { env: { 'GIT_HTTP_USER_AGENT': this.git.userAgent } }; args.push(options.remote); for (const tag of options.tags) { args.push(`refs/tags/${tag}:refs/tags/${tag}`); } if (options.force) { args.push('--force'); } await this.exec(args, spawnOptions); } </ins> async pull(rebase?: boolean, remote?: string, branch?: string, options: PullOptions = {}): Promise<void> { const args = ['pull'];", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-8d77b941a2d30cd658a303e4bbcaa815f65d3eacc588e7095ad6df4a9910dc0a", "text": "err.gitErrorCode = GitErrorCodes.CantLockRef; } else if (/cannot rebase onto multiple branches/i.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.CantRebaseMultipleBranches; <ins> } else if (/! [rejected].*(would clobber existing tag)/m.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.TagConflict; </ins> } throw err;", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-69d5f20550022be6974d4d91bec10bff4dcff9006cd2d1c8bd0f5c916cac41d7", "text": "import { Branch, Change, ForcePushMode, GitErrorCodes, LogOptions, Ref, RefType, Remote, Status, CommitOptions, BranchQuery, FetchOptions } from './api/git'; import { AutoFetcher } from './autofetch'; import { debounce, memoize, throttle } from './decorators'; <del> import { Commit, GitError, Repository as BaseRepository, Stash, Submodule, LogFileOptions } from './git'; </del> <ins> import { Commit, GitError, Repository as BaseRepository, Stash, Submodule, LogFileOptions, PullOptions } from './git'; </ins> import { StatusBarCommands } from './statusbar'; import { toGitUri } from './uri'; import { anyEvent, combinedDisposable, debounceEvent, dispose, EmptyDisposable, eventToPromise, filterEvent, find, IDisposable, isDescendant, onceEvent, pathEquals, relativePath } from './util';", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-f451f649558cfaba8ba8b12a8a17147f2292c9c04f5a146cec88db0788f4a06a", "text": "} if (await this.checkIfMaybeRebased(this.HEAD?.name)) { <del> await this.repository.pull(rebase, remote, branch, { unshallow, tags }); </del> <ins> this._pullAndHandleTagConflict(rebase, remote, branch, { unshallow, tags }); </ins> } }); }); } <ins> private async _pullAndHandleTagConflict(rebase?: boolean, remote?: string, branch?: string, options: PullOptions = {}): Promise<void> { try { await this.repository.pull(rebase, remote, branch, options); } catch (err) { if (err.gitErrorCode !== GitErrorCodes.TagConflict) { throw err; } // Handle tag(s) conflict if (await this.handleTagConflict(remote, err.stderr)) { await this.repository.pull(rebase, remote, branch, options); } } } </ins> @throttle async push(head: Branch, forcePushMode?: ForcePushMode): Promise<void> { let remote: string | undefined;", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-c6629f648fd1cd85147a70efb065c796fe84b335d286117208ac1b3e425af46c", "text": "} if (await this.checkIfMaybeRebased(this.HEAD?.name)) { <del> await this.repository.pull(rebase, remoteName, pullBranch, { tags, cancellationToken }); </del> <ins> this._pullAndHandleTagConflict(rebase, remoteName, pullBranch, { tags, cancellationToken }); </ins> } };", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-66692775fba94e9b061da2a96eb1379766c0115542a648e2472cb0e2f6847c69", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: MacOS 12.5.1 Steps to Reproduce: I'm not entirely sure how to repro this as the error doesn't really indicate the cause. What happens is, when I click \"Sync\" on Git, I get this modal warning: <img width=\"276\" alt=\"image\" src=\"https://user-\"And the Git log itself doesn't immediately have any signs of failure, no results for searching the word \"error\". It seems that some Git command failed internally but I'm not sure why the failure reason isn't part of this modal window. If the reason is in the Git log (which currently is quite large as I've had vscode open all day) then it's not immediately obvious which command caused this error. Shouldn't the error message be part of the alert dialogue that appeared?\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nthat does seem like a bug. If you are still able to reproduce the problem, could you please click on the \"Show Command Output\" button and share that? Thank you very much in advance!\nyeah it turns out I had some difference in tags between my local and the remote - I got an error about \"clobbering\" tags (?) overwriting I guess? when git-pulling with --tags via the terminal. I think what happened is myself and another team member ran our release script and generated the same tag on two different commits.\nthanks for the update. If you are able to come up with a set of repro steps that yowl be very helpful. Thanks!\nManaged to reproduce. This was done in a repository where I was a few commits behind the remote copy. I tagged the current commit which was with then pushed --tags pulled down the new commits from remote, my local is now I deleted the tag called which pointed to I a new tag, also called on now there's a tag called where the remote points to a different commit to my local, git cannot fix this itself I run and I see the error message: Now when you click ! in vscode, it runs in the background, and internally it hits this exact same error but the alert box that opens does not contain the actual error message: ! One observation: on Windows I've got this \"Show command output\" which when I click, it opens an editor with the full log so that's useful at least! On mac this didn't work, so maybe that's the actual bug here. Full log for reference:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nVerification steps: Use the repo steps from In case of a conflict in tags, we now display a dialog listing the tags that are conflicted <img width=\"273\" alt=\"image\" src=\"https://user-\"* Click on \"Replace Local Tag(s)\" and confirm that you are able to successfully sync\n/verified Amazing, awesome work!", "positive_passages": [{"docid": "doc-en-vscode-78e13388112afbbacf304b85876cdb8b515f9bb76c82f1cc565ae7c9fdab69eb", "text": "return config.get<boolean>('optimisticUpdate') === true; } <ins> private async handleTagConflict(remote: string | undefined, raw: string): Promise<boolean> { // Ensure there is a remote remote = remote ?? this.HEAD?.upstream?.remote; if (!remote) { throw new Error('Unable to resolve tag conflict due to missing remote.'); } // Extract tag names from message const tags: string[] = []; for (const match of raw.matchAll(/^ ! [rejected]s+([^s]+)s+->s+([^s]+)s+(would clobber existing tag)$/gm)) { if (match.length === 3) { tags.push(match[1]); } } if (tags.length === 0) { throw new Error(`Unable to extract tag names from error message: ${raw}`); } // Notification const replaceLocalTags = l10n.t('Replace Local Tag(s)'); const message = l10n.t('Unable to pull from remote repository due to conflicting tag(s): {0}. Would you like to resolve the conflict by replacing the local tag(s)?', tags.join(', ')); const choice = await window.showErrorMessage(message, { modal: true }, replaceLocalTags); if (choice !== replaceLocalTags) { return false; } // Force fetch tags await this.repository.fetchTags({ remote, tags, force: true }); return true; } </ins> public isBranchProtected(name: string = this.HEAD?.name ?? ''): boolean { return this.isBranchProtectedMatcher ? this.isBranchProtectedMatcher(name) : false; }", "commid": "vscode_pr_167278"}], "negative_passages": []}
{"query_id": "q-en-vscode-01c6ebd9d1711f2882750b7d4fedbaaa2444a639174fa0228882ad88c4dc3ede", "query": "Type: <bBug</bI saw the schema prompt for 'types' under terminal contribute, but setting it does not take effect. After checking the vscode source code and issue, I found that this contribution point has been removed. VS Code version: Code 1.71.0 (Universal) (, 2022-09-01T07:25:38.437Z) OS version: Darwin x64 21.4.0 Modes: Sandboxed: No Remote OS version: Linux x64 5.10.3+ <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\n!\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nRelated Links:\nAfter upgrading to , it still remain.", "positive_passages": [{"docid": "doc-en-vscode-84bbae1b0dc42a66c6e52b4dda51d3e789188600e47718384a4a581851412dab", "text": "description: nls.localize('vscode.extension.contributes.terminal', 'Contributes terminal functionality.'), type: 'object', properties: { <del> types: { type: 'array', description: nls.localize('vscode.extension.contributes.terminal.types', \"Defines additional terminal types that the user can create.\"), items: { type: 'object', required: ['command', 'title'], properties: { command: { description: nls.localize('vscode.extension.contributes.terminal.types.command', \"Command to execute when the user creates this type of terminal.\"), type: 'string', }, title: { description: nls.localize('vscode.extension.contributes.terminal.types.title', \"Title for this type of terminal.\"), type: 'string', }, icon: { description: nls.localize('vscode.extension.contributes.terminal.types.icon', \"A codicon, URI, or light and dark URIs to associate with this terminal type.\"), anyOf: [{ type: 'string', }, { type: 'object', properties: { light: { description: nls.localize('vscode.extension.contributes.terminal.types.icon.light', 'Icon path when a light theme is used'), type: 'string' }, dark: { description: nls.localize('vscode.extension.contributes.terminal.types.icon.dark', 'Icon path when a dark theme is used'), type: 'string' } } }] }, }, }, }, </del> profiles: { type: 'array', description: nls.localize('vscode.extension.contributes.terminal.profiles', \"Defines additional terminal profiles that the user can create.\"),", "commid": "vscode_pr_160863"}], "negative_passages": []}
{"query_id": "q-en-vscode-2af7595938df1edd965064c330b62302fbade74b1ee550cb4d3cefc0a7ebcec3", "query": "Here is my code snippet Trying to run this creates:\nI can't seem to reproduce this on code-web or\nI was using The only changes were these in\nI can still reproduce this in my code. I ran out of source to see what might cause the problem and here is a detailed stack trace: Might be some timing issue\nMore digging. Here are my findings: I do open the terminal from a debug adapter which brings the debugger viewlet to front right after I created the terminal if I wrap my code into a everything works fine\nany tip or fix for this. I improved the performance on my end and a 2 sec delay is now very bad. My Python execution in the Web is now < 500 ms.\nI need to reopen this. I tested it on todays insider and I still get\nBuild I used is: <img width=\"500\" alt=\"image\" src=\"https://user-\"\nI will compile steps today on how to reproduce this.\nSteps to reproduce: clone cd vscode-python-web-wasm git co dbaeumer/noTimeout npm install npm run compile npm run esbuild open VS Code run as a task or in the terminal run as a task or in the terminal click on the link in the tunnel terminal and press continue open a browser on Run command Use the link from the tunnel open developer tools open in the browser window From the play menu in the editor run Observe: you get the above exception and the terminal is not showing the output Run the action again Observe: the terminal reveals correctly and shows the output\nCan reproduce with those steps, the only thing missing was enabling workspace trust and reloading after installing the web extension\nDebugging this section: It's visible before so it doesn't do the extra open view, and not visible after it because the debug console steals the opened view.\nEven if this issue was fixed such that did not throw (eg. make an optionally synchronous version of or just try ), it would still set visible and then immediately show the debug console. So if you wanted to show the terminal, you would need to call it after the debug console shows (eg. via timeout as you have). I don't think this is an issue that needs to be fixed in the terminal, but rather you should either prevent whatever is showing the debug console as it happens some time after the terminal is created, or move the call to after the debug console shows. let me know if you disagree.\nIMO there are two different things: the fact that the terminal is not in front because the debug terminal comes to front. I do agree that this is something I should address the fact that the terminal seems broken (e.g. it doesn't render the output for the first created terminal). This I agrue is a bug in the terminal. IMO the terminal should function correctly after a create even if I don't call show. So if a user later on clicks on the terminal the output is shown correctly.\nthe second issue should be fixed by , it won't fix your problem though\nto understand it correctly. This will ensure that the terminal is functional after . I can then ensure that I bring the terminal to front () after the debugger is initialized.\nyeah, removing that await should ensure the view is visible so the element will be there to attach which means no exception that ruins the state.", "positive_passages": [{"docid": "doc-en-vscode-42b78a3a3d2e78b3fad159e417149ffbc63fccda773976badc3b9e24d7b1b895", "text": "await timeout(0); const instance = this.activeInstance; if (instance) { <ins> // HACK: Ensure the panel is still visible at this point as there may have been // a request since it was opened to show a different panel if (pane && !pane.isVisible()) { await this._viewsService.openView(TERMINAL_VIEW_ID, focus); } </ins> await instance.focusWhenReady(true); // HACK: as a workaround for https://github.com/microsoft/vscode/issues/134692, // this will trigger a forced refresh of the viewport to sync the viewport and scroll bar.", "commid": "vscode_pr_161615"}], "negative_passages": []}
{"query_id": "q-en-vscode-2af7595938df1edd965064c330b62302fbade74b1ee550cb4d3cefc0a7ebcec3", "query": "Here is my code snippet Trying to run this creates:\nI can't seem to reproduce this on code-web or\nI was using The only changes were these in\nI can still reproduce this in my code. I ran out of source to see what might cause the problem and here is a detailed stack trace: Might be some timing issue\nMore digging. Here are my findings: I do open the terminal from a debug adapter which brings the debugger viewlet to front right after I created the terminal if I wrap my code into a everything works fine\nany tip or fix for this. I improved the performance on my end and a 2 sec delay is now very bad. My Python execution in the Web is now < 500 ms.\nI need to reopen this. I tested it on todays insider and I still get\nBuild I used is: <img width=\"500\" alt=\"image\" src=\"https://user-\"\nI will compile steps today on how to reproduce this.\nSteps to reproduce: clone cd vscode-python-web-wasm git co dbaeumer/noTimeout npm install npm run compile npm run esbuild open VS Code run as a task or in the terminal run as a task or in the terminal click on the link in the tunnel terminal and press continue open a browser on Run command Use the link from the tunnel open developer tools open in the browser window From the play menu in the editor run Observe: you get the above exception and the terminal is not showing the output Run the action again Observe: the terminal reveals correctly and shows the output\nCan reproduce with those steps, the only thing missing was enabling workspace trust and reloading after installing the web extension\nDebugging this section: It's visible before so it doesn't do the extra open view, and not visible after it because the debug console steals the opened view.\nEven if this issue was fixed such that did not throw (eg. make an optionally synchronous version of or just try ), it would still set visible and then immediately show the debug console. So if you wanted to show the terminal, you would need to call it after the debug console shows (eg. via timeout as you have). I don't think this is an issue that needs to be fixed in the terminal, but rather you should either prevent whatever is showing the debug console as it happens some time after the terminal is created, or move the call to after the debug console shows. let me know if you disagree.\nIMO there are two different things: the fact that the terminal is not in front because the debug terminal comes to front. I do agree that this is something I should address the fact that the terminal seems broken (e.g. it doesn't render the output for the first created terminal). This I agrue is a bug in the terminal. IMO the terminal should function correctly after a create even if I don't call show. So if a user later on clicks on the terminal the output is shown correctly.\nthe second issue should be fixed by , it won't fix your problem though\nto understand it correctly. This will ensure that the terminal is functional after . I can then ensure that I bring the terminal to front () after the debugger is initialized.\nyeah, removing that await should ensure the view is visible so the element will be there to attach which means no exception that ruins the state.", "positive_passages": [{"docid": "doc-en-vscode-8d61414e37efa8d9c40a1f5f1b7e9bd6fefa169acbe53b624ba293bedcd933a0", "text": "if (pane && !pane.isVisible()) { await this._viewsService.openView(TERMINAL_VIEW_ID, focus); } <del> await instance.focusWhenReady(true); </del> <ins> // Do not await the focus as setVisible must be called immediately to ensure // something else didn't steal focus instance.focusWhenReady(true); </ins> // HACK: as a workaround for https://github.com/microsoft/vscode/issues/134692, // this will trigger a forced refresh of the viewport to sync the viewport and scroll bar. // This can likely be removed after https://github.com/xtermjs/xterm.js/issues/291 is", "commid": "vscode_pr_161989"}], "negative_passages": []}
{"query_id": "q-en-vscode-113b94828e758e4759fcd8aec852b804af8800bba09ffb69e440916e6c064b25", "query": "Locally I have an empty cell at the bottom of my notebook because I executed the last cell When I try to merge in a change that has new cells, I get a merge conflict that requires I open the ipynb in a text editor to resolve. !\nWe can explore how to handle this gracefully in the serializer.\nnot sure what needs to be done in the serializer here. can you provide more information, i would have thought this was purely an issue with merge conflicts.\nCan this please be solved? It's hard to work collaboratively within a team using Jupyter notebooks and VS Code if we can't sort out merge conflicts.\nI suggest there be an option to disable the notebook renderer temporarily in all editors. git operates at the text level and when merge conflict happens, it will likely produce a malformed JSON file. We now have an error message to notify users to fallback to text editor, but \"resolve in merge editor\" button still don't work. !\nNote: When there are merge conflicts, one will always have to open a plain text (json) editor to resolve the merge confligs I.e. its not possible to use Notebook UI to resolve merge conflicts (at least not yet) Steps to test Ensure you have merge conflicts in a Notebook document Open the SCM view, and click on the IPYNB file, and verify you can see the merge conflicts in plain text editor view Click on the button and verify you get the merge editor (again plain text), see here When you have merge conflicts, try opening the ipynb file from the explorer view, if this fails verify you are displayed with an error message with the option to open the file in plain text view", "positive_passages": [{"docid": "doc-en-vscode-9250a7d525109f5477d5f914af650308fd358059a2e9ca4aab24e3bcd0409087", "text": "import { Disposable, DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { ResourceMap } from 'vs/base/common/map'; import { Schemas } from 'vs/base/common/network'; <del> import { isEqual } from 'vs/base/common/resources'; </del> <ins> import { basename, isEqual } from 'vs/base/common/resources'; </ins> import { isDefined } from 'vs/base/common/types'; import { URI } from 'vs/base/common/uri'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility';", "commid": "vscode_pr_213602"}], "negative_passages": []}
{"query_id": "q-en-vscode-113b94828e758e4759fcd8aec852b804af8800bba09ffb69e440916e6c064b25", "query": "Locally I have an empty cell at the bottom of my notebook because I executed the last cell When I try to merge in a change that has new cells, I get a merge conflict that requires I open the ipynb in a text editor to resolve. !\nWe can explore how to handle this gracefully in the serializer.\nnot sure what needs to be done in the serializer here. can you provide more information, i would have thought this was purely an issue with merge conflicts.\nCan this please be solved? It's hard to work collaboratively within a team using Jupyter notebooks and VS Code if we can't sort out merge conflicts.\nI suggest there be an option to disable the notebook renderer temporarily in all editors. git operates at the text level and when merge conflict happens, it will likely produce a malformed JSON file. We now have an error message to notify users to fallback to text editor, but \"resolve in merge editor\" button still don't work. !\nNote: When there are merge conflicts, one will always have to open a plain text (json) editor to resolve the merge confligs I.e. its not possible to use Notebook UI to resolve merge conflicts (at least not yet) Steps to test Ensure you have merge conflicts in a Notebook document Open the SCM view, and click on the IPYNB file, and verify you can see the merge conflicts in plain text editor view Click on the button and verify you get the merge editor (again plain text), see here When you have merge conflicts, try opening the ipynb file from the explorer view, if this fails verify you are displayed with an error message with the option to open the file in plain text view", "positive_passages": [{"docid": "doc-en-vscode-a3c9654e926c9a146b2121700c9d3b39b96347b5e295cb0bea474d084c117840", "text": "import { NotebookOutputRendererInfo, NotebookStaticPreloadInfo as NotebookStaticPreloadInfo } from 'vs/workbench/contrib/notebook/common/notebookOutputRenderer'; import { NotebookEditorDescriptor, NotebookProviderInfo } from 'vs/workbench/contrib/notebook/common/notebookProvider'; import { INotebookSerializer, INotebookService, SimpleNotebookProviderInfo } from 'vs/workbench/contrib/notebook/common/notebookService'; <del> import { DiffEditorInputFactoryFunction, EditorInputFactoryFunction, EditorInputFactoryObject, IEditorResolverService, IEditorType, RegisteredEditorInfo, RegisteredEditorPriority, UntitledEditorInputFactoryFunction } from 'vs/workbench/services/editor/common/editorResolverService'; </del> <ins> import { DiffEditorInputFactoryFunction, EditorInputFactoryFunction, EditorInputFactoryObject, IEditorResolverService, IEditorType, RegisteredEditorInfo, RegisteredEditorPriority, UntitledEditorInputFactoryFunction, type MergeEditorInputFactoryFunction } from 'vs/workbench/services/editor/common/editorResolverService'; </ins> import { IExtensionService, isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; import { IExtensionPointUser } from 'vs/workbench/services/extensions/common/extensionsRegistry'; import { InstallRecommendedExtensionAction } from 'vs/workbench/contrib/extensions/browser/extensionsActions'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; import { INotebookDocument, INotebookDocumentService } from 'vs/workbench/services/notebook/common/notebookDocumentService'; <ins> import { MergeEditorInput } from 'vs/workbench/contrib/mergeEditor/browser/mergeEditorInput'; import type { EditorInputWithOptions, IResourceMergeEditorInput } from 'vs/workbench/common/editor'; </ins> export class NotebookProviderInfoStore extends Disposable {", "commid": "vscode_pr_213602"}], "negative_passages": []}
{"query_id": "q-en-vscode-113b94828e758e4759fcd8aec852b804af8800bba09ffb69e440916e6c064b25", "query": "Locally I have an empty cell at the bottom of my notebook because I executed the last cell When I try to merge in a change that has new cells, I get a merge conflict that requires I open the ipynb in a text editor to resolve. !\nWe can explore how to handle this gracefully in the serializer.\nnot sure what needs to be done in the serializer here. can you provide more information, i would have thought this was purely an issue with merge conflicts.\nCan this please be solved? It's hard to work collaboratively within a team using Jupyter notebooks and VS Code if we can't sort out merge conflicts.\nI suggest there be an option to disable the notebook renderer temporarily in all editors. git operates at the text level and when merge conflict happens, it will likely produce a malformed JSON file. We now have an error message to notify users to fallback to text editor, but \"resolve in merge editor\" button still don't work. !\nNote: When there are merge conflicts, one will always have to open a plain text (json) editor to resolve the merge confligs I.e. its not possible to use Notebook UI to resolve merge conflicts (at least not yet) Steps to test Ensure you have merge conflicts in a Notebook document Open the SCM view, and click on the IPYNB file, and verify you can see the merge conflicts in plain text editor view Click on the button and verify you get the merge editor (again plain text), see here When you have merge conflicts, try opening the ipynb file from the explorer view, if this fails verify you are displayed with an error message with the option to open the file in plain text view", "positive_passages": [{"docid": "doc-en-vscode-2e816ab56cd44252521561f8fb99819254bc16702a758e92e9bc43976060e627", "text": "const notebookDiffEditorInputFactory: DiffEditorInputFactoryFunction = ({ modified, original, label, description }) => { return { editor: NotebookDiffEditorInput.create(this._instantiationService, modified.resource!, label, description, original.resource!, notebookProviderInfo.id) }; }; <ins> const mergeEditorInputFactory: MergeEditorInputFactoryFunction = (mergeEditor: IResourceMergeEditorInput): EditorInputWithOptions => { return { editor: this._instantiationService.createInstance( MergeEditorInput, mergeEditor.base.resource, { uri: mergeEditor.input1.resource, title: mergeEditor.input1.label ?? basename(mergeEditor.input1.resource), description: mergeEditor.input1.description ?? '', detail: mergeEditor.input1.detail }, { uri: mergeEditor.input2.resource, title: mergeEditor.input2.label ?? basename(mergeEditor.input2.resource), description: mergeEditor.input2.description ?? '', detail: mergeEditor.input2.detail }, mergeEditor.result.resource ) }; }; </ins> const notebookFactoryObject: EditorInputFactoryObject = { createEditorInput: notebookEditorInputFactory, createDiffEditorInput: notebookDiffEditorInputFactory, createUntitledEditorInput: notebookUntitledEditorFactory, <ins> createMergeEditorInput: mergeEditorInputFactory </ins> }; const notebookCellFactoryObject: EditorInputFactoryObject = { createEditorInput: notebookEditorInputFactory,", "commid": "vscode_pr_213602"}], "negative_passages": []}
{"query_id": "q-en-vscode-6a70eab42509901c265c452297c694512c9cea70cf8b200746cf6d02bf654e1a", "query": "Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width=\"955\" alt=\"image\" src=\"https://user-\"\nIn web we probably cannot support the value.\nThis is still on\nI cannot reproduce this, just to be sure this is on the latest\nYes, reproduces even with caches disabled: !", "positive_passages": [{"docid": "doc-en-vscode-e74f519720a9238884d01ea8fc382b0625add9bc147820e8ec5c34f3b934c082", "text": "import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { EditSessionsDataViews } from 'vs/workbench/contrib/editSessions/browser/editSessionsViews'; import { EditSessionsFileSystemProvider } from 'vs/workbench/contrib/editSessions/browser/editSessionsFileSystemProvider'; <del> import { isNative } from 'vs/base/common/platform'; </del> <ins> import { isNative, isWeb } from 'vs/base/common/platform'; </ins> import { VirtualWorkspaceContext, WorkspaceFolderCountContext } from 'vs/workbench/common/contextkeys'; import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation'; import { equals } from 'vs/base/common/objects';", "commid": "vscode_pr_173386"}], "negative_passages": []}
{"query_id": "q-en-vscode-6a70eab42509901c265c452297c694512c9cea70cf8b200746cf6d02bf654e1a", "query": "Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width=\"955\" alt=\"image\" src=\"https://user-\"\nIn web we probably cannot support the value.\nThis is still on\nI cannot reproduce this, just to be sure this is on the latest\nYes, reproduces even with caches disabled: !", "positive_passages": [{"docid": "doc-en-vscode-e084679c83621e5bc68ab62b7632946b721326d9e1156dbcb6b64f8f5425781c", "text": "} private async autoStoreEditSession() { <del> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown') { </del> <ins> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown' && !isWeb) { </ins> const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window,", "commid": "vscode_pr_173386"}], "negative_passages": []}
{"query_id": "q-en-vscode-6a70eab42509901c265c452297c694512c9cea70cf8b200746cf6d02bf654e1a", "query": "Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width=\"955\" alt=\"image\" src=\"https://user-\"\nIn web we probably cannot support the value.\nThis is still on\nI cannot reproduce this, just to be sure this is on the latest\nYes, reproduces even with caches disabled: !", "positive_passages": [{"docid": "doc-en-vscode-bcb4e9f9eef2b71021b10cd842ec1a9f5fb256d68690781ec9736718ee1d319d", "text": "'type': 'string', 'tags': ['experimental', 'usesOnlineServices'], 'default': 'off', <del> 'markdownDescription': localize('autoStoreWorkingChangesDescription', \"Controls whether to automatically store available working changes in the cloud for the current workspace.\"), </del> <ins> 'markdownDescription': localize('autoStoreWorkingChangesDescription', \"Controls whether to automatically store available working changes in the cloud for the current workspace. This setting has no effect in the web.\"), </ins> }, 'workbench.cloudChanges.autoResume': { enum: ['onReload', 'off'],", "commid": "vscode_pr_173386"}], "negative_passages": []}
{"query_id": "q-en-vscode-6a70eab42509901c265c452297c694512c9cea70cf8b200746cf6d02bf654e1a", "query": "Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width=\"955\" alt=\"image\" src=\"https://user-\"\nIn web we probably cannot support the value.\nThis is still on\nI cannot reproduce this, just to be sure this is on the latest\nYes, reproduces even with caches disabled: !", "positive_passages": [{"docid": "doc-en-vscode-e03e74a166279ebc734a3ce54d66538999c1ac7a40d5deb6042b63edbcfef7ca", "text": "this.shouldShowViewsContext = EDIT_SESSIONS_SHOW_VIEW.bindTo(this.contextKeyService); this._register(this.fileService.registerProvider(EditSessionsFileSystemProvider.SCHEMA, new EditSessionsFileSystemProvider(this.editSessionsStorageService))); <del> this.lifecycleService.onWillShutdown((e) => e.join(this.autoStoreEditSession(), { id: 'autoStoreWorkingChanges', label: localize('autoStoreWorkingChanges', 'Storing current working changes...') })); </del> <ins> this.lifecycleService.onWillShutdown((e) => { if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown' && !isWeb) { e.join(this.autoStoreEditSession(), { id: 'autoStoreWorkingChanges', label: localize('autoStoreWorkingChanges', 'Storing current working changes...') }); } }); </ins> this._register(this.editSessionsStorageService.onDidSignIn(() => this.updateAccountsMenuBadge())); this._register(this.editSessionsStorageService.onDidSignOut(() => this.updateAccountsMenuBadge())); }", "commid": "vscode_pr_175075"}], "negative_passages": []}
{"query_id": "q-en-vscode-6a70eab42509901c265c452297c694512c9cea70cf8b200746cf6d02bf654e1a", "query": "Fyi there is no long running shutdown support on web, so this warning gets printed on unload: <img width=\"955\" alt=\"image\" src=\"https://user-\"\nIn web we probably cannot support the value.\nThis is still on\nI cannot reproduce this, just to be sure this is on the latest\nYes, reproduces even with caches disabled: !", "positive_passages": [{"docid": "doc-en-vscode-50330bfd25dffe4f5b0d8380ea566e320b1c95e73d9ecf8386037633ed5c948e", "text": "} private async autoStoreEditSession() { <del> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown' && !isWeb) { const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('store working changes', 'Storing working changes...') }, async () => this.storeEditSession(false, cancellationTokenSource.token), () => { cancellationTokenSource.cancel(); cancellationTokenSource.dispose(); }); } </del> <ins> const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window, type: 'syncing', title: localize('store working changes', 'Storing working changes...') }, async () => this.storeEditSession(false, cancellationTokenSource.token), () => { cancellationTokenSource.cancel(); cancellationTokenSource.dispose(); }); </ins> } private registerViews() {", "commid": "vscode_pr_175075"}], "negative_passages": []}
{"query_id": "q-en-vscode-196df7edebace878fea0c66587bb689df44b90c7ca6a237874288107c1449f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 OS Version: macOS Monterey 12.5.1 (21G83) Steps to Reproduce: file named the file to the title of the file's editor tab <img width=\"199\" alt=\"image\" src=\"https://user-\"Is still , not the new name . until reopen the file. But rename to is ok. Also reanme to is ok. Just rename to is not ok.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nrename to is not ok. rename to is ok. It seems that some intersting things work wrong here.\nCan you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.\nAs you see, nothing changed.\nHm yeah I think I see it too, the first rename works fine but then renaming back does not work, is that what you see?\nthis is a funny one and indeed a regression from our work to always go through the editor resolver when resolving editors and not go through the as a shortcut. Steps open an empty folder with 1 file open the file rename it from the explorer to verify the tab label updates rename it from the explorer to the label does not update Here is how it used to be the rename operation will eventually hit since this is a default text editor we would directly use we figure out that we have an existing editor input so we do not create a new one however we update its preferred resource this triggers a label change event that will update the tab label =this works every time you rename, irrespective of going back and forward of the name Here is how it is today we also end up in however we always now go to the editor resolver (which imho is good) the editor resolver however does not consider the input to be a new input after the first rename because the canonical resource is still how it was in the begining, it will do an early return as such, the inputs preferred resource is never updated Now I am actually not so sure how to fix this. I am a bit worried that updating the method to respect resource path casing may break other behaviour that relies on the current behaviour. Maybe the resolver should not be so clever to do an early return? Why do we do this?\nYeah maybe, I think it was to prevent creating too many inputs and calling unnecessary factories when things are not actually changing at all. I guess we could always remove the early return and see what breaks.\nAt least for text file editors, there is caching so that we do not end up with an editor input each time, but I think the same issue already exists today: if you do not have a tab as active and the editor resolver is used to bring up that editor, we would delegate the decision whether to create an editor input or not to the provider and so its up to the provider imho to do the caching.\nSorry, got caught up in other work and missed this. Will attempt a fix early in debt week for the November release as it is too risky to go in this late", "positive_passages": [{"docid": "doc-en-vscode-df17465ece9210b7e2ea8081783014b9cd28d73fdfa61ca13139591f7357a829", "text": "} let resource = EditorResourceAccessor.getCanonicalUri(untypedEditor, { supportSideBySide: SideBySideEditor.PRIMARY }); <del> const options = untypedEditor.options; </del> // If it was resolved before we await for the extensions to activate and then proceed with resolution or else the backing extensions won't be registered if (this.cache && resource && this.resourceMatchesCache(resource)) {", "commid": "vscode_pr_165083"}], "negative_passages": []}
{"query_id": "q-en-vscode-196df7edebace878fea0c66587bb689df44b90c7ca6a237874288107c1449f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 OS Version: macOS Monterey 12.5.1 (21G83) Steps to Reproduce: file named the file to the title of the file's editor tab <img width=\"199\" alt=\"image\" src=\"https://user-\"Is still , not the new name . until reopen the file. But rename to is ok. Also reanme to is ok. Just rename to is not ok.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nrename to is not ok. rename to is ok. It seems that some intersting things work wrong here.\nCan you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.\nAs you see, nothing changed.\nHm yeah I think I see it too, the first rename works fine but then renaming back does not work, is that what you see?\nthis is a funny one and indeed a regression from our work to always go through the editor resolver when resolving editors and not go through the as a shortcut. Steps open an empty folder with 1 file open the file rename it from the explorer to verify the tab label updates rename it from the explorer to the label does not update Here is how it used to be the rename operation will eventually hit since this is a default text editor we would directly use we figure out that we have an existing editor input so we do not create a new one however we update its preferred resource this triggers a label change event that will update the tab label =this works every time you rename, irrespective of going back and forward of the name Here is how it is today we also end up in however we always now go to the editor resolver (which imho is good) the editor resolver however does not consider the input to be a new input after the first rename because the canonical resource is still how it was in the begining, it will do an early return as such, the inputs preferred resource is never updated Now I am actually not so sure how to fix this. I am a bit worried that updating the method to respect resource path casing may break other behaviour that relies on the current behaviour. Maybe the resolver should not be so clever to do an early return? Why do we do this?\nYeah maybe, I think it was to prevent creating too many inputs and calling unnecessary factories when things are not actually changing at all. I guess we could always remove the early return and see what breaks.\nAt least for text file editors, there is caching so that we do not end up with an editor input each time, but I think the same issue already exists today: if you do not have a tab as active and the editor resolver is used to bring up that editor, we would delegate the decision whether to create an editor input or not to the provider and so its up to the provider imho to do the caching.\nSorry, got caught up in other work and missed this. Will attempt a fix early in debt week for the November release as it is too risky to go in this late", "positive_passages": [{"docid": "doc-en-vscode-110437e79bfbe569c8bd328aa747e0f88304af986c4ec84cf13e9589a715c4bd", "text": "return ResolvedStatus.NONE; } <del> // If it's the currently active editor we shouldn't do anything const activeEditor = group.activeEditor; const isActive = activeEditor ? activeEditor.matches(untypedEditor) : false; if (activeEditor && isActive) { return { editor: activeEditor, options, group }; } </del> const input = await this.doResolveEditor(untypedEditor, group, selectedEditor); if (conflictingDefault && input) { // Show the conflicting default dialog", "commid": "vscode_pr_165083"}], "negative_passages": []}
{"query_id": "q-en-vscode-196df7edebace878fea0c66587bb689df44b90c7ca6a237874288107c1449f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 OS Version: macOS Monterey 12.5.1 (21G83) Steps to Reproduce: file named the file to the title of the file's editor tab <img width=\"199\" alt=\"image\" src=\"https://user-\"Is still , not the new name . until reopen the file. But rename to is ok. Also reanme to is ok. Just rename to is not ok.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nrename to is not ok. rename to is ok. It seems that some intersting things work wrong here.\nCan you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.\nAs you see, nothing changed.\nHm yeah I think I see it too, the first rename works fine but then renaming back does not work, is that what you see?\nthis is a funny one and indeed a regression from our work to always go through the editor resolver when resolving editors and not go through the as a shortcut. Steps open an empty folder with 1 file open the file rename it from the explorer to verify the tab label updates rename it from the explorer to the label does not update Here is how it used to be the rename operation will eventually hit since this is a default text editor we would directly use we figure out that we have an existing editor input so we do not create a new one however we update its preferred resource this triggers a label change event that will update the tab label =this works every time you rename, irrespective of going back and forward of the name Here is how it is today we also end up in however we always now go to the editor resolver (which imho is good) the editor resolver however does not consider the input to be a new input after the first rename because the canonical resource is still how it was in the begining, it will do an early return as such, the inputs preferred resource is never updated Now I am actually not so sure how to fix this. I am a bit worried that updating the method to respect resource path casing may break other behaviour that relies on the current behaviour. Maybe the resolver should not be so clever to do an early return? Why do we do this?\nYeah maybe, I think it was to prevent creating too many inputs and calling unnecessary factories when things are not actually changing at all. I guess we could always remove the early return and see what breaks.\nAt least for text file editors, there is caching so that we do not end up with an editor input each time, but I think the same issue already exists today: if you do not have a tab as active and the editor resolver is used to bring up that editor, we would delegate the decision whether to create an editor input or not to the provider and so its up to the provider imho to do the caching.\nSorry, got caught up in other work and missed this. Will attempt a fix early in debt week for the November release as it is too risky to go in this late", "positive_passages": [{"docid": "doc-en-vscode-95e3a662befca518abd85ef5a564b99eae5cb0a8f1aee9fca9ccd94bbefd2de8", "text": "import { EditorActivation, IResourceEditorInput } from 'vs/platform/editor/common/editor'; import { URI } from 'vs/base/common/uri'; import { Event } from 'vs/base/common/event'; <del> import { DEFAULT_EDITOR_ASSOCIATION, EditorCloseContext, EditorsOrder, IEditorCloseEvent, EditorInputWithOptions, IEditorPane, IResourceDiffEditorInput, isEditorInputWithOptions, IUntitledTextResourceEditorInput, IUntypedEditorInput, SideBySideEditor } from 'vs/workbench/common/editor'; </del> <ins> import { DEFAULT_EDITOR_ASSOCIATION, EditorCloseContext, EditorsOrder, IEditorCloseEvent, EditorInputWithOptions, IEditorPane, IResourceDiffEditorInput, isEditorInputWithOptions, IUntitledTextResourceEditorInput, IUntypedEditorInput, SideBySideEditor, isEditorInput } from 'vs/workbench/common/editor'; </ins> import { workbenchInstantiationService, TestServiceAccessor, registerTestEditor, TestFileEditorInput, ITestInstantiationService, registerTestResourceEditor, registerTestSideBySideEditor, createEditorPart, registerTestFileEditor, TestTextFileEditor, TestSingletonFileEditorInput } from 'vs/workbench/test/browser/workbenchTestServices'; import { EditorService } from 'vs/workbench/services/editor/browser/editorService'; import { IEditorGroup, IEditorGroupsService, GroupDirection, GroupsArrangement } from 'vs/workbench/services/editor/common/editorGroupsService';", "commid": "vscode_pr_165083"}], "negative_passages": []}
{"query_id": "q-en-vscode-196df7edebace878fea0c66587bb689df44b90c7ca6a237874288107c1449f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 OS Version: macOS Monterey 12.5.1 (21G83) Steps to Reproduce: file named the file to the title of the file's editor tab <img width=\"199\" alt=\"image\" src=\"https://user-\"Is still , not the new name . until reopen the file. But rename to is ok. Also reanme to is ok. Just rename to is not ok.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nrename to is not ok. rename to is ok. It seems that some intersting things work wrong here.\nCan you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.\nAs you see, nothing changed.\nHm yeah I think I see it too, the first rename works fine but then renaming back does not work, is that what you see?\nthis is a funny one and indeed a regression from our work to always go through the editor resolver when resolving editors and not go through the as a shortcut. Steps open an empty folder with 1 file open the file rename it from the explorer to verify the tab label updates rename it from the explorer to the label does not update Here is how it used to be the rename operation will eventually hit since this is a default text editor we would directly use we figure out that we have an existing editor input so we do not create a new one however we update its preferred resource this triggers a label change event that will update the tab label =this works every time you rename, irrespective of going back and forward of the name Here is how it is today we also end up in however we always now go to the editor resolver (which imho is good) the editor resolver however does not consider the input to be a new input after the first rename because the canonical resource is still how it was in the begining, it will do an early return as such, the inputs preferred resource is never updated Now I am actually not so sure how to fix this. I am a bit worried that updating the method to respect resource path casing may break other behaviour that relies on the current behaviour. Maybe the resolver should not be so clever to do an early return? Why do we do this?\nYeah maybe, I think it was to prevent creating too many inputs and calling unnecessary factories when things are not actually changing at all. I guess we could always remove the early return and see what breaks.\nAt least for text file editors, there is caching so that we do not end up with an editor input each time, but I think the same issue already exists today: if you do not have a tab as active and the editor resolver is used to bring up that editor, we would delegate the decision whether to create an editor input or not to the provider and so its up to the provider imho to do the caching.\nSorry, got caught up in other work and missed this. Will attempt a fix early in debt week for the November release as it is too risky to go in this late", "positive_passages": [{"docid": "doc-en-vscode-7dfe658ab2cf8c2bff66d89357255cf0848ae8c8735c0a269319f024261828fa", "text": "async function openEditor(editor: EditorInputWithOptions | IUntypedEditorInput, group?: PreferredGroup): Promise<IEditorPane | undefined> { if (useOpenEditors) { <ins> // The type safety isn't super good here, so we assist with runtime checks // Open editors expects untyped or editor input with options, you cannot pass a typed editor input // without options if (!isEditorInputWithOptions(editor) && isEditorInput(editor)) { editor = { editor: editor, options: {} }; } </ins> const panes = await service.openEditors([editor], group); return panes[0]; }", "commid": "vscode_pr_165083"}], "negative_passages": []}
{"query_id": "q-en-vscode-196df7edebace878fea0c66587bb689df44b90c7ca6a237874288107c1449f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 OS Version: macOS Monterey 12.5.1 (21G83) Steps to Reproduce: file named the file to the title of the file's editor tab <img width=\"199\" alt=\"image\" src=\"https://user-\"Is still , not the new name . until reopen the file. But rename to is ok. Also reanme to is ok. Just rename to is not ok.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nrename to is not ok. rename to is ok. It seems that some intersting things work wrong here.\nCan you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.\nAs you see, nothing changed.\nHm yeah I think I see it too, the first rename works fine but then renaming back does not work, is that what you see?\nthis is a funny one and indeed a regression from our work to always go through the editor resolver when resolving editors and not go through the as a shortcut. Steps open an empty folder with 1 file open the file rename it from the explorer to verify the tab label updates rename it from the explorer to the label does not update Here is how it used to be the rename operation will eventually hit since this is a default text editor we would directly use we figure out that we have an existing editor input so we do not create a new one however we update its preferred resource this triggers a label change event that will update the tab label =this works every time you rename, irrespective of going back and forward of the name Here is how it is today we also end up in however we always now go to the editor resolver (which imho is good) the editor resolver however does not consider the input to be a new input after the first rename because the canonical resource is still how it was in the begining, it will do an early return as such, the inputs preferred resource is never updated Now I am actually not so sure how to fix this. I am a bit worried that updating the method to respect resource path casing may break other behaviour that relies on the current behaviour. Maybe the resolver should not be so clever to do an early return? Why do we do this?\nYeah maybe, I think it was to prevent creating too many inputs and calling unnecessary factories when things are not actually changing at all. I guess we could always remove the early return and see what breaks.\nAt least for text file editors, there is caching so that we do not end up with an editor input each time, but I think the same issue already exists today: if you do not have a tab as active and the editor resolver is used to bring up that editor, we would delegate the decision whether to create an editor input or not to the provider and so its up to the provider imho to do the caching.\nSorry, got caught up in other work and missed this. Will attempt a fix early in debt week for the November release as it is too risky to go in this late", "positive_passages": [{"docid": "doc-en-vscode-0bf5fa347a81642d4dbdf0ba2d0dd2d23a0ebd1b6cc2580b8fb1b7a092d41cf4", "text": "assert.ok(typedEditor instanceof TestFileEditorInput); assert.strictEqual(typedEditor?.resource?.toString(), untypedEditorReplacement.resource.toString()); <del> assert.strictEqual(editorFactoryCalled, 2); </del> <ins> assert.strictEqual(editorFactoryCalled, 3); </ins> assert.strictEqual(untitledEditorFactoryCalled, 0); assert.strictEqual(diffEditorFactoryCalled, 0);", "commid": "vscode_pr_165083"}], "negative_passages": []}
{"query_id": "q-en-vscode-196df7edebace878fea0c66587bb689df44b90c7ca6a237874288107c1449f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.2 OS Version: macOS Monterey 12.5.1 (21G83) Steps to Reproduce: file named the file to the title of the file's editor tab <img width=\"199\" alt=\"image\" src=\"https://user-\"Is still , not the new name . until reopen the file. But rename to is ok. Also reanme to is ok. Just rename to is not ok.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nrename to is not ok. rename to is ok. It seems that some intersting things work wrong here.\nCan you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.\nAs you see, nothing changed.\nHm yeah I think I see it too, the first rename works fine but then renaming back does not work, is that what you see?\nthis is a funny one and indeed a regression from our work to always go through the editor resolver when resolving editors and not go through the as a shortcut. Steps open an empty folder with 1 file open the file rename it from the explorer to verify the tab label updates rename it from the explorer to the label does not update Here is how it used to be the rename operation will eventually hit since this is a default text editor we would directly use we figure out that we have an existing editor input so we do not create a new one however we update its preferred resource this triggers a label change event that will update the tab label =this works every time you rename, irrespective of going back and forward of the name Here is how it is today we also end up in however we always now go to the editor resolver (which imho is good) the editor resolver however does not consider the input to be a new input after the first rename because the canonical resource is still how it was in the begining, it will do an early return as such, the inputs preferred resource is never updated Now I am actually not so sure how to fix this. I am a bit worried that updating the method to respect resource path casing may break other behaviour that relies on the current behaviour. Maybe the resolver should not be so clever to do an early return? Why do we do this?\nYeah maybe, I think it was to prevent creating too many inputs and calling unnecessary factories when things are not actually changing at all. I guess we could always remove the early return and see what breaks.\nAt least for text file editors, there is caching so that we do not end up with an editor input each time, but I think the same issue already exists today: if you do not have a tab as active and the editor resolver is used to bring up that editor, we would delegate the decision whether to create an editor input or not to the provider and so its up to the provider imho to do the caching.\nSorry, got caught up in other work and missed this. Will attempt a fix early in debt week for the November release as it is too risky to go in this late", "positive_passages": [{"docid": "doc-en-vscode-39c11c54a29583adc72bdefb8a83a08a809dd3b1fa86790b03ed163f7768c15b", "text": "assert.strictEqual(untitledEditorFactoryCalled, 0); assert.strictEqual(diffEditorFactoryCalled, 0); <del> assert.ok(!lastEditorFactoryEditor); </del> assert.ok(!lastUntitledEditorFactoryEditor); assert.ok(!lastDiffEditorFactoryEditor);", "commid": "vscode_pr_165083"}], "negative_passages": []}
{"query_id": "q-en-vscode-6fff1a019633c53127e2c4d13b6b6124bc396e22f3d352fe401b86c5dd7f2088", "query": "Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to\ngetOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?\nThe second one: !\nOh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.", "positive_passages": [{"docid": "doc-en-vscode-826dfff7574139e3b14d0154bc6f455b5218d77c96b2b5214fa6adda9a2259d1", "text": "addNewLine?: boolean; } <ins> /** * A matcher that runs on a sub-section of a terminal command's output */ </ins> export interface ITerminalOutputMatcher { <ins> /** * A string or regex to match against the unwrapped line. */ </ins> lineMatcher: string | RegExp; <del> anchor?: 'top' | 'bottom'; offset?: number; length?: number; </del> <ins> /** * Which side of the output to anchor the {@link offset} and {@link length} against. */ anchor: 'top' | 'bottom'; /** * How far from either the top or the bottom of the butter to start matching against. */ offset: number; /** * The number of rows to match against, this should be as small as possible for performance * reasons. */ length: number; </ins> } export interface IXtermTerminal {", "commid": "vscode_pr_161779"}], "negative_passages": []}
{"query_id": "q-en-vscode-6fff1a019633c53127e2c4d13b6b6124bc396e22f3d352fe401b86c5dd7f2088", "query": "Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to\ngetOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?\nThe second one: !\nOh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.", "positive_passages": [{"docid": "doc-en-vscode-e8c846d34fc3cc1b784302b422776210984d2c7a988e1b358ad83a413e99668c", "text": "export function gitSimilarCommand(): ITerminalContextualActionOptions { return { commandLineMatcher: GitCommandLineRegex, <del> outputMatcher: { lineMatcher: GitSimilarOutputRegex, anchor: 'bottom' }, </del> <ins> outputMatcher: { lineMatcher: GitSimilarOutputRegex, anchor: 'bottom', offset: 0, length: 3 }, </ins> actionName: (matchResult: ContextualMatchResult) => matchResult.outputMatch ? `Run git ${matchResult.outputMatch[1]}` : ``, exitStatus: false, getActions: (matchResult: ContextualMatchResult, command: ITerminalCommand) => {", "commid": "vscode_pr_161779"}], "negative_passages": []}
{"query_id": "q-en-vscode-6fff1a019633c53127e2c4d13b6b6124bc396e22f3d352fe401b86c5dd7f2088", "query": "Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to\ngetOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?\nThe second one: !\nOh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.", "positive_passages": [{"docid": "doc-en-vscode-dd2c9ef518e59a9b0758e9a6a99827531801c96ca39d36f4f169f5ae8d46b286", "text": "return { actionName: (matchResult: ContextualMatchResult) => matchResult.outputMatch ? `Free port ${matchResult.outputMatch[1]}` : '', commandLineMatcher: AnyCommandLineRegex, <del> outputMatcher: !isWindows ? { lineMatcher: FreePortOutputRegex, anchor: 'bottom' } : undefined, </del> <ins> // TODO: Support free port on Windows https://github.com/microsoft/vscode/issues/161775 outputMatcher: isWindows ? undefined : { lineMatcher: FreePortOutputRegex, anchor: 'bottom', offset: 0, length: 20 }, exitStatus: false, </ins> getActions: (matchResult: ContextualMatchResult, command: ITerminalCommand) => { const port = matchResult?.outputMatch?.[1]; if (!port) {", "commid": "vscode_pr_161779"}], "negative_passages": []}
{"query_id": "q-en-vscode-6fff1a019633c53127e2c4d13b6b6124bc396e22f3d352fe401b86c5dd7f2088", "query": "Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to\ngetOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?\nThe second one: !\nOh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.", "positive_passages": [{"docid": "doc-en-vscode-8e3e19d12b7f8baf7f8f410b7ea44edd2be83f9664ab4047e3006dd54b08e4ea", "text": "return { actionName: (matchResult: ContextualMatchResult) => matchResult.outputMatch ? `Git push ${matchResult.outputMatch[1]}` : '', commandLineMatcher: GitPushCommandLineRegex, <del> outputMatcher: { lineMatcher: GitPushOutputRegex, anchor: 'bottom' }, </del> <ins> outputMatcher: { lineMatcher: GitPushOutputRegex, anchor: 'bottom', offset: 0, length: 5 }, </ins> exitStatus: false, getActions: (matchResult: ContextualMatchResult, command: ITerminalCommand) => { const branch = matchResult?.outputMatch?.[1];", "commid": "vscode_pr_161779"}], "negative_passages": []}
{"query_id": "q-en-vscode-6fff1a019633c53127e2c4d13b6b6124bc396e22f3d352fe401b86c5dd7f2088", "query": "Open terminal and run command After it finishes, there is a freeze. Some times I see window is not responding dialog Now type command Freezes again Here is the profile that is captured while running command Here is the profile that is captured while running command I have set to\ngetOutputMatch can be too expensive: ! Is some quick fix not working on just a small line range?\nThe second one: !\nOh none of the quick fixes use offset or length currently. We should force that, otherwise the regex will run on every line.", "positive_passages": [{"docid": "doc-en-vscode-8120180bd8fefaf77e8a6aea12900fc0e1c689644fb964a8a8b0053dc2560548", "text": "return { actionName: (matchResult: ContextualMatchResult) => matchResult.outputMatch ? `Create PR for ${matchResult.outputMatch[1]}` : '', commandLineMatcher: GitPushCommandLineRegex, <del> outputMatcher: { lineMatcher: GitCreatePrOutputRegex, anchor: 'bottom' }, </del> <ins> outputMatcher: { lineMatcher: GitCreatePrOutputRegex, anchor: 'bottom', offset: 0, length: 5 }, </ins> exitStatus: true, getActions: (matchResult: ContextualMatchResult, command?: ITerminalCommand) => { if (!command) {", "commid": "vscode_pr_161779"}], "negative_passages": []}
{"query_id": "q-en-vscode-0f304df3e012dfddf2ec11d395c1c6fe615e6c731a4595deaa67b405e03c8a61", "query": "Testing clone a repo from within VS Code when done a notification is shown IMO a modal is the better choice of UI because this something I am awaiting and wanting to take action on <img width=\"1527\" alt=\"Screenshot 2022-09-27 at 11 15 02\" src=\"https://user-\"\nit makes sense to me. please let me know if you have any concerns. Thanks!\n, as having notifications snoozed always, I was missing this notification but I think it should be modal as it is part of a flow that I triggered.\nNo concerns with using a modal", "positive_passages": [{"docid": "doc-en-vscode-d18c765c773c225faca79de0d6370725fd55619a1f3be7fc708842bd8a8a077d", "text": "choices.push(addToWorkspace); } <del> const result = await window.showInformationMessage(message, ...choices); </del> <ins> const result = await window.showInformationMessage(message, { modal: true }, ...choices); </ins> action = result === open ? PostCloneAction.Open : result === openNewWindow ? PostCloneAction.OpenNewWindow", "commid": "vscode_pr_162306"}], "negative_passages": []}
{"query_id": "q-en-vscode-42949ae023af4ebdd70106c0934d31b7f23abe318b6a4edec46a74a11c436100", "query": "Testing The feature is called . But it does more than fetch, it also pulls. Fetch typically only 'downloads' commits, but does not update any branches. Maybe the proper name would be:", "positive_passages": [{"docid": "doc-en-vscode-2bb0a333f1cc4a0ae4455432823c24a3bd17b231baddcbb9fa3d82608a47081f", "text": "\"default\": false, \"description\": \"%config.rebaseWhenSync%\" }, <del> \"git.fetchBeforeCheckout\": { </del> <ins> \"git.pullBeforeCheckout\": { </ins> \"type\": \"boolean\", \"scope\": \"resource\", \"default\": false, <del> \"description\": \"%config.fetchBeforeCheckout%\" </del> <ins> \"description\": \"%config.pullBeforeCheckout%\" </ins> }, \"git.fetchOnPull\": { \"type\": \"boolean\",", "commid": "vscode_pr_162303"}], "negative_passages": []}
{"query_id": "q-en-vscode-42949ae023af4ebdd70106c0934d31b7f23abe318b6a4edec46a74a11c436100", "query": "Testing The feature is called . But it does more than fetch, it also pulls. Fetch typically only 'downloads' commits, but does not update any branches. Maybe the proper name would be:", "positive_passages": [{"docid": "doc-en-vscode-af6da6e122464c2f05810c1b64105a57f4afd0bb153801df738d6aa84c9d5b63", "text": "\"config.rebaseWhenSync\": \"Force git to use rebase when running the sync command.\", \"config.confirmEmptyCommits\": \"Always confirm the creation of empty commits for the 'Git: Commit Empty' command.\", \"config.fetchOnPull\": \"When enabled, fetch all branches when pulling. Otherwise, fetch just the current one.\", <del> \"config.fetchBeforeCheckout\": \"Controls whether a branch that does not have outgoing commits is fast-forwarded before it is checked out.\", </del> <ins> \"config.pullBeforeCheckout\": \"Controls whether a branch that does not have outgoing commits is fast-forwarded before it is checked out.\", </ins> \"config.pullTags\": \"Fetch all tags when pulling.\", \"config.pruneOnFetch\": \"Prune when fetching.\", \"config.autoStash\": \"Stash any changes before pulling and restore them after successful pull.\",", "commid": "vscode_pr_162303"}], "negative_passages": []}
{"query_id": "q-en-vscode-42949ae023af4ebdd70106c0934d31b7f23abe318b6a4edec46a74a11c436100", "query": "Testing The feature is called . But it does more than fetch, it also pulls. Fetch typically only 'downloads' commits, but does not update any branches. Maybe the proper name would be:", "positive_passages": [{"docid": "doc-en-vscode-8d566adb0e4c22b101dc4e42d7a6d15455b2a922cde55206a22b95e9501ee8cb", "text": "} const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); <del> const fetchBeforeCheckout = config.get<boolean>('fetchBeforeCheckout', false) === true; </del> <ins> const pullBeforeCheckout = config.get<boolean>('pullBeforeCheckout', false) === true; </ins> <del> if (fetchBeforeCheckout) { </del> <ins> if (pullBeforeCheckout) { </ins> await this.repository.fastForwardBranch(this.ref.name!); }", "commid": "vscode_pr_162303"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-642e3b3049333f2bf17d138841dfc1f1060b1d7e3228b450f84a82ff7f53037a", "text": "import { sha1Hex } from 'vs/base/browser/hash'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import { IActivityService, NumberBadge } from 'vs/workbench/services/activity/common/activity'; <ins> import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; </ins> registerSingleton(IEditSessionsLogService, EditSessionsLogService, InstantiationType.Delayed); registerSingleton(IEditSessionsStorageService, EditSessionsWorkbenchService, InstantiationType.Delayed);", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-e52064c1948d30ff080e387989e69a61a192aba4a60605bdc70b6eb37acbb6f4", "text": "@ILifecycleService private readonly lifecycleService: ILifecycleService, @IStorageService private readonly storageService: IStorageService, @IActivityService private readonly activityService: IActivityService, <ins> @IEditorService private readonly editorService: IEditorService, </ins> ) { super();", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-5f5437f9d91815532512bd3d470141ff08b7ca9eb8d433156dbf212f5638c9dd", "text": "// Run the store action to get back a ref let ref: string | undefined; if (shouldStoreEditSession) { <del> ref = await that.progressService.withProgress({ location: ProgressLocation.Notification, type: 'syncing', title: localize('store your edit session', 'Storing your edit session...') }, async () => that.storeEditSession(false)); </del> <ins> ref = await that.storeEditSession(false); </ins> } let uri = workspaceUri ?? await that.pickContinueEditSessionDestination();", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-28d6deb38d369d68d3e4da8b88b33f4031ecff37aedad2ba1a467ae03797335f", "text": "} else if (ref !== undefined) { this.notificationService.warn(localize('no edit session content for ref', 'Could not resume edit session contents for ID {0}.', ref)); } <del> this.logService.info(ref !== undefined ? `Aborting resuming edit session as no edit session content is available to be applied from ref ${ref}.` : `Aborting resuming edit session as no edit session content is available to be applied`); </del> <ins> this.logService.info(`Aborting resuming edit session as no edit session content is available to be applied from ref ${ref}.`); </ins> return; } const editSession = data.editSession;", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-cf1759c8a21e3aa1a96f37f9d63182598d462a38b114f53b451c51c2056fb16d", "text": "const folders: Folder[] = []; let hasEdits = false; <ins> // Save all saveable editors before building edit session contents await this.editorService.saveAll(); </ins> for (const repository of this.scmService.repositories) { // Look through all resource groups and compute which files were added/modified/deleted const trackedUris = this.getChangedResources(repository); // A URI might appear in more than one resource group", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-dea4790aa806eb8bf498203dfae7a7755b602c98fa6afaab36c58e4839ee2a00", "text": "import { ITextModelService } from 'vs/editor/common/services/resolverService'; import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; <ins> import { IEditorService, ISaveAllEditorsOptions } from 'vs/workbench/services/editor/common/editorService'; </ins> const folderName = 'test-folder'; const folderUri = URI.file(`/${folderName}`);", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-17810cff045cbfd93adfb40cd6fa1dd10ffaa4d38f9080f64446e04e32c47230", "query": "Testing I wonder if we should run the command to save all files (not untitled files) before triggering the \"Continue on\" fully? I think ensuring that dirty files are saved but also that the data was synced up before opening the workspace elsewhere would be best?\nI am not presented with any options after running the command - perhaps we shouldn't show that in the command palette unless there are some or add an action that helps me get some options? !\nShould we say here? !", "positive_passages": [{"docid": "doc-en-vscode-8f4d83ca2d6d186f02b93592bae946a84124406c6c6b06759d915c289dcd70e7", "text": "instantiationService.stub(ITextModelService, new class extends mock<ITextModelService>() { override registerTextModelContentProvider = () => ({ dispose: () => { } }); }); <ins> instantiationService.stub(IEditorService, new class extends mock<IEditorService>() { override saveAll = async (_options: ISaveAllEditorsOptions) => true; }); </ins> editSessionsContribution = instantiationService.createInstance(EditSessionsContribution); });", "commid": "vscode_pr_165246"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-5b95b6ae16b36eb592deb29fcf965caaf211a8d3b80e01c4f728fe5bb9ab385f", "text": "if (!state.conflicting && !state.isInputIncluded(inputNumber)) { result.push( !state.isInputIncluded(inputNumber) <del> ? command(localize('accept', \"$(pass) Accept {0}\", inputData.title), async () => { </del> <ins> ? command(localize('accept', \"Accept {0}\", inputData.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-2668ca55b045fbf14c5bc300ba3277ed2bca37a52ecfd4bc7c031e1923015a1e", "text": "); }); }) <del> : command(localize('remove', \"$(error) Remove {0}\", inputData.title), async () => { </del> <ins> : command(localize('remove', \"Remove {0}\", inputData.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-0537bbbee7c695b110a861ddfd89aa976f1282e467ae67bd0c32bc286ab60350", "text": "if (modifiedBaseRange.canBeCombined && state.isEmpty) { result.push( state.input1 && state.input2 <del> ? command(localize('removeBoth', \"$(error) Remove Both\"), async () => { </del> <ins> ? command(localize('removeBoth', \"Remove Both\"), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-c42cd26fe925cce6c01c53258137c995418d2b0adb5fa25b3c0c626751af573a", "text": "); }); }) <del> : command(localize('acceptBoth', \"$(pass) Accept Both\"), async () => { </del> <ins> : command(localize('acceptBoth', \"Accept Both\"), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-627dd81c3a96105a37d2dd3dadcc493975ba7138861d5f8d58b76ca8c8af1d42", "text": "const stateToggles: IContentWidgetAction[] = []; if (state.input1) { <del> result.push(command(localize('remove', \"$(error) Remove {0}\", model.input1.title), async () => { </del> <ins> result.push(command(localize('remove', \"Remove {0}\", model.input1.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-3bb2287dcd58e5341e6c17c53fc0dddbd80e3a3906a027b712c9cacd06360d7c", "text": "); } if (state.input2) { <del> result.push(command(localize('remove', \"$(error) Remove {0}\", model.input2.title), async () => { </del> <ins> result.push(command(localize('remove', \"Remove {0}\", model.input2.title), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-bdfa0c95fd34fa24c5f7a5d09a6e519b3eeca4a39454cae5f6d3f676272c629e", "query": "Testing I think the merge editor CodeLens actions are the only examples I've seen of icons being used\u2014not sure they are obvious/big enough to really be of much value here. Is there any prior art for using them? <img width=\"269\" alt=\"CleanShot 2022-09-27 at 11 42 19 src=\"https://user-\"<img width=\"244\" alt=\"CleanShot 2022-09-27 at 11 43 33 src=\"https://user-\"\nI can remove them. Personally I like them, as they give a non-textual clue about what is going to happen.\nWhy don't we start with the minimal text and then we can always choose to add them (or something else) back. Harder to remove things once they are in.", "positive_passages": [{"docid": "doc-en-vscode-62f43cf6fea052424114e8e903b78787c69a8134517de520281df10543128e76", "text": "if (state.conflicting) { result.push( <del> command(localize('resetToBase', \"$(error) Reset to base\"), async () => { </del> <ins> command(localize('resetToBase', \"Reset to base\"), async () => { </ins> transaction((tx) => { model.setState( modifiedBaseRange,", "commid": "vscode_pr_162345"}], "negative_passages": []}
{"query_id": "q-en-vscode-b69c0690c2519f95aab030c47bf64a8d481c1199112ca95b1da195b8ed08c5c0", "query": "Testing ! I would have expected it to be centered.... though this could just be this codicon.\nIs this happening with all codicons or just this one?\nI can see it for codicons. Fixing it", "positive_passages": [{"docid": "doc-en-vscode-a7e4790d0aa245ca2c2f8e1f4b78cbb4c0041c4609d0b925568be82b3caa161e", "text": "justify-content: center; align-items: center; font-size: 14px; <del> line-height: 16px; </del> border-radius: 8px; }", "commid": "vscode_pr_162209"}], "negative_passages": []}
{"query_id": "q-en-vscode-380ae46906e1f1854614e7d2d73ec22af60fd8b13a46d94af8892aad31338243", "query": "<img width=\"364\" alt=\"image\" src=\"https://user-\"I think this dialog could get some UX love. If we want to keep the very long primary button label, I would use title casing to be consistent with other dialog buttons. But I also think just having \"Accept Merge\" is fine, given the message in the dialog points out about the conflicts. //cc\nNow that I see this dialog: <img width=\"291\" alt=\"image\" src=\"https://user-\"I think we can align both How about: \"Accept with Conflicts\" using in the dialog \"The file contains unhandled conflicts\"\nPR:", "positive_passages": [{"docid": "doc-en-vscode-67861c4935479ef5bfdd07070b89c32f9878803f22fa45a7718d7dfff4c751de", "text": "*--------------------------------------------------------------------------------------------*/ import { Codicon } from 'vs/base/common/codicons'; <ins> import { basename } from 'vs/base/common/resources'; </ins> import { URI, UriComponents } from 'vs/base/common/uri'; import { localize } from 'vs/nls'; import { ILocalizedString } from 'vs/platform/action/common/action';", "commid": "vscode_pr_162418"}], "negative_passages": []}
{"query_id": "q-en-vscode-380ae46906e1f1854614e7d2d73ec22af60fd8b13a46d94af8892aad31338243", "query": "<img width=\"364\" alt=\"image\" src=\"https://user-\"I think this dialog could get some UX love. If we want to keep the very long primary button label, I would use title casing to be consistent with other dialog buttons. But I also think just having \"Accept Merge\" is fine, given the message in the dialog points out about the conflicts. //cc\nNow that I see this dialog: <img width=\"291\" alt=\"image\" src=\"https://user-\"I think we can align both How about: \"Accept with Conflicts\" using in the dialog \"The file contains unhandled conflicts\"\nPR:", "positive_passages": [{"docid": "doc-en-vscode-53f38d30850aa70100d26151f056486f2b1afb3ee8f371bcce688132b2995eb4", "text": "if (viewModel.model.unhandledConflictsCount.get() > 0) { const confirmResult = await dialogService.confirm({ type: 'info', <del> message: localize('mergeEditor.acceptMerge.unhandledConflicts', \"There are still unhandled conflicts. Are you sure you want to accept the merge?\"), primaryButton: localize('mergeEditor.acceptMerge.unhandledConflicts.accept', \"Complete merge with unhandled conflicts\"), </del> <ins> message: localize('mergeEditor.acceptMerge.unhandledConflicts.message', \"Do you want to complete the merge of {0}?\", basename(inputModel.resultUri)), detail: localize('mergeEditor.acceptMerge.unhandledConflicts.detail', \"The file contains unhandled conflicts.\"), primaryButton: localize('mergeEditor.acceptMerge.unhandledConflicts.accept', \"Complete with Conflicts\"), </ins> secondaryButton: localize('mergeEditor.acceptMerge.unhandledConflicts.cancel', \"Cancel\"), });", "commid": "vscode_pr_162418"}], "negative_passages": []}
{"query_id": "q-en-vscode-50cd005a8d9a954035057ba52a0af3720bbc4fb57bebdb8f9f47012b10bbaec3", "query": "Just wondering whether the \"Extensions\" output channel is actually used for anything? I have checked it when troubleshooting extensions many times and don't think I've ever actually seen any output in there\nThis is being used by debug adapter Feel free to remove it if you are not using.\nOh, wow No clue about that\nI guess it was introduced in , previously showed errors from all extensions, now I think those errors go to other general logs, and probably just this one usage got left behind. any idea if there was some discussion about this in the past? Or I will remove it\nnot aware of anyone using it. I think we can go ahead and remove it. fyi\nbit off-topic here but I was looking around for an issue around a \"combined\" log (showing the channel inline) - is there such a thing and I'm just missing it? that way I wouldn't have to click around into various logs when I'm trying to figure out what's going on with vscode - I realize I could tail the various files and write a script to make that more convenient I was also thinking maybe an extension could fill that need but then I saw\nI think there is an issue to open multiple output channels at once. Please search into our issues.\nthere are only 10 open issues tagged output - altho this issue is about output and got labeled debug instead - I looked at the debug tagged issues too and didn't see it - should I create one?\nHere is the similar request -", "positive_passages": [{"docid": "doc-en-vscode-80e61e980aa25e5c3306e3826133bda93a4fa844e99462e13f3013976a5e68b9", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { Promises } from 'vs/base/node/pfs'; </del> import * as cp from 'child_process'; <del> import * as stream from 'stream'; import * as nls from 'vs/nls'; </del> import * as net from 'net'; <del> import * as path from 'vs/base/common/path'; import * as strings from 'vs/base/common/strings'; </del> <ins> import * as stream from 'stream'; </ins> import * as objects from 'vs/base/common/objects'; <ins> import * as path from 'vs/base/common/path'; </ins> import * as platform from 'vs/base/common/platform'; <del> import { ExtensionsChannelId } from 'vs/platform/extensionManagement/common/extensionManagement'; import { IOutputService } from 'vs/workbench/services/output/common/output'; import { IDebugAdapterExecutable, IDebuggerContribution, IPlatformSpecificAdapterContribution, IDebugAdapterServer, IDebugAdapterNamedPipeServer } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import * as strings from 'vs/base/common/strings'; import { Promises } from 'vs/base/node/pfs'; import * as nls from 'vs/nls'; </ins> import { IExtensionDescription } from 'vs/platform/extensions/common/extensions'; <ins> import { IDebugAdapterExecutable, IDebugAdapterNamedPipeServer, IDebugAdapterServer, IDebuggerContribution, IPlatformSpecificAdapterContribution } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { AbstractDebugAdapter } from '../common/abstractDebugAdapter'; /**", "commid": "vscode_pr_162774"}], "negative_passages": []}
{"query_id": "q-en-vscode-50cd005a8d9a954035057ba52a0af3720bbc4fb57bebdb8f9f47012b10bbaec3", "query": "Just wondering whether the \"Extensions\" output channel is actually used for anything? I have checked it when troubleshooting extensions many times and don't think I've ever actually seen any output in there\nThis is being used by debug adapter Feel free to remove it if you are not using.\nOh, wow No clue about that\nI guess it was introduced in , previously showed errors from all extensions, now I think those errors go to other general logs, and probably just this one usage got left behind. any idea if there was some discussion about this in the past? Or I will remove it\nnot aware of anyone using it. I think we can go ahead and remove it. fyi\nbit off-topic here but I was looking around for an issue around a \"combined\" log (showing the channel inline) - is there such a thing and I'm just missing it? that way I wouldn't have to click around into various logs when I'm trying to figure out what's going on with vscode - I realize I could tail the various files and write a script to make that more convenient I was also thinking maybe an extension could fill that need but then I saw\nI think there is an issue to open multiple output channels at once. Please search into our issues.\nthere are only 10 open issues tagged output - altho this issue is about output and got labeled debug instead - I looked at the debug tagged issues too and didn't see it - should I create one?\nHere is the similar request -", "positive_passages": [{"docid": "doc-en-vscode-9bb1ede10fef4142ff6f563d16a7227d45d3980848465288f48f897a09a41ad8", "text": "private serverProcess: cp.ChildProcess | undefined; <del> constructor(private adapterExecutable: IDebugAdapterExecutable, private debugType: string, private readonly outputService?: IOutputService) { </del> <ins> constructor(private adapterExecutable: IDebugAdapterExecutable, private debugType: string) { </ins> super(); }", "commid": "vscode_pr_162774"}], "negative_passages": []}
{"query_id": "q-en-vscode-50cd005a8d9a954035057ba52a0af3720bbc4fb57bebdb8f9f47012b10bbaec3", "query": "Just wondering whether the \"Extensions\" output channel is actually used for anything? I have checked it when troubleshooting extensions many times and don't think I've ever actually seen any output in there\nThis is being used by debug adapter Feel free to remove it if you are not using.\nOh, wow No clue about that\nI guess it was introduced in , previously showed errors from all extensions, now I think those errors go to other general logs, and probably just this one usage got left behind. any idea if there was some discussion about this in the past? Or I will remove it\nnot aware of anyone using it. I think we can go ahead and remove it. fyi\nbit off-topic here but I was looking around for an issue around a \"combined\" log (showing the channel inline) - is there such a thing and I'm just missing it? that way I wouldn't have to click around into various logs when I'm trying to figure out what's going on with vscode - I realize I could tail the various files and write a script to make that more convenient I was also thinking maybe an extension could fill that need but then I saw\nI think there is an issue to open multiple output channels at once. Please search into our issues.\nthere are only 10 open issues tagged output - altho this issue is about output and got labeled debug instead - I looked at the debug tagged issues too and didn't see it - should I create one?\nHere is the similar request -", "positive_passages": [{"docid": "doc-en-vscode-2ca3fe90026a381abb18424567a4e4fc4fef5915860cb47d9745aebdc24e7c2c", "text": "this._onError.fire(error); }); <del> const outputService = this.outputService; if (outputService) { const sanitize = (s: string) => s.toString().replace(/r?n$/mg, ''); // this.serverProcess.stdout.on('data', (data: string) => { // \tconsole.log('%c' + sanitize(data), 'background: #ddd; font-style: italic;'); // }); this.serverProcess.stderr!.on('data', (data: string) => { const channel = outputService.getChannel(ExtensionsChannelId); channel?.append(sanitize(data)); }); } else { this.serverProcess.stderr!.resume(); } </del> <ins> this.serverProcess.stderr!.resume(); </ins> // finally connect to the DA this.connect(this.serverProcess.stdout!, this.serverProcess.stdin!);", "commid": "vscode_pr_162774"}], "negative_passages": []}
{"query_id": "q-en-vscode-40e26b0d6ceec9c7908e3ed799220b72e3364c904cb2b13b760a29009e4acc0a", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: n/a <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: (currently at ) OS Version: n/a Steps to Reproduce: the existing code in and turn it into a function that accepts a parameter: that function in , e.g. using . should error, but don't: - According to the error on , requires =1.10.1, but is only enforcing = 1 or = x.10. Granted, there is no yarn v3.10 yet, but there may be someday. And if it actually requires =1.10.1 (and not just =1.10.0) as the error states, it should enforce that as well.\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nRelated docs change:", "positive_passages": [{"docid": "doc-en-vscode-5c88b07536c95edd47b17ce0302a5f158647ae51ebdfd78a31a474c9407fa967", "text": "const fs = require('fs'); const cp = require('child_process'); const yarnVersion = cp.execSync('yarn -v', { encoding: 'utf8' }).trim(); <del> const parsedYarnVersion = /^(d+).(d+)./.exec(yarnVersion); </del> <ins> const parsedYarnVersion = /^(d+).(d+).(d+)/.exec(yarnVersion); </ins> const majorYarnVersion = parseInt(parsedYarnVersion[1]); const minorYarnVersion = parseInt(parsedYarnVersion[2]); <del> if (majorYarnVersion < 1 || minorYarnVersion < 10) { console.error('033[1;31m*** Please use yarn >=1.10.1.033[0;0m'); </del> <ins> const patchYarnVersion = parseInt(parsedYarnVersion[3]); if ( majorYarnVersion < 1 || majorYarnVersion === 1 && ( minorYarnVersion < 10 || (minorYarnVersion === 10 && patchYarnVersion < 1) ) || majorYarnVersion >= 2 ) { console.error('033[1;31m*** Please use yarn >=1.10.1 and <2.033[0;0m'); </ins> err = true; }", "commid": "vscode_pr_162610"}], "negative_passages": []}
{"query_id": "q-en-vscode-d87ee6f2e3fca592a7ab77b5da2be2eca2ad99db20718285a58a04f6354c2881", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.0 OS Version: Windows 10 Pro, 21H2, build: .2075 <brCommand links inside notifications were implemented as described here, or here , i.e. This is now possible using the following syntax: Originally posted by in The feature works great when a single command link is to a notification but fails when two (or more) are present, see the sample code below (2). <brSteps to Reproduce: a new blank extension (JS/TS) the following code to your extension's main entrypoint/command: Expected behavior is to see the notification with 2 command links and their titles but the following is rendered instead: <p align=\"center\"<img src=\"https://user-\" alt=\"notification-command\"</pNote: the provided commands and should be valid and registered for the commands links to work when actually being clicked but that is irrelevant and out of scope for the issue.\nThis looks like a parsing bug to me when converting markdown to HTML.\nBug actually seems to be in since notifications don't use full markdown:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified\n<p align=\"center\"<img src=\"https://user-\"</pIt now works as expected, great job, thanks!", "positive_passages": [{"docid": "doc-en-vscode-6d8c7b9ae9a3bd65d2bffe465f1a528373e709ce4e7015420553a60841b89292", "text": "} } <del> const LINK_REGEX = /[([^]]+)](((?:https?://|command:|file:)[^)s]+)(?: (\"|')([^3]+)(3))?)/gi; </del> <ins> const LINK_REGEX = /[([^]]+)](((?:https?://|command:|file:)[^)s]+)(?: ([\"'])(.+?)(3))?)/gi; </ins> export function parseLinkedText(text: string): LinkedText { const result: LinkedTextNode[] = [];", "commid": "vscode_pr_165867"}], "negative_passages": []}
{"query_id": "q-en-vscode-d87ee6f2e3fca592a7ab77b5da2be2eca2ad99db20718285a58a04f6354c2881", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.0 OS Version: Windows 10 Pro, 21H2, build: .2075 <brCommand links inside notifications were implemented as described here, or here , i.e. This is now possible using the following syntax: Originally posted by in The feature works great when a single command link is to a notification but fails when two (or more) are present, see the sample code below (2). <brSteps to Reproduce: a new blank extension (JS/TS) the following code to your extension's main entrypoint/command: Expected behavior is to see the notification with 2 command links and their titles but the following is rendered instead: <p align=\"center\"<img src=\"https://user-\" alt=\"notification-command\"</pNote: the provided commands and should be valid and registered for the commands links to work when actually being clicked but that is irrelevant and out of scope for the issue.\nThis looks like a parsing bug to me when converting markdown to HTML.\nBug actually seems to be in since notifications don't use full markdown:\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified\n<p align=\"center\"<img src=\"https://user-\"</pIt now works as expected, great job, thanks!", "positive_passages": [{"docid": "doc-en-vscode-6e55aa82940233f77b2843c8bd7b49fa54b01d8aa63cffc14aa777c91b26764e", "text": "'...' ]); }); <ins> test('Should match non-greedily', () => { assert.deepStrictEqual(parseLinkedText('a [link text 1](http://link.href \"title1\") b [link text 2](http://link.href \"title2\") c').nodes, [ 'a ', { label: 'link text 1', href: 'http://link.href', title: 'title1' }, ' b ', { label: 'link text 2', href: 'http://link.href', title: 'title2' }, ' c', ]); }); </ins> });", "commid": "vscode_pr_165867"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-e1391208a64e95d9799cd5edb8fe2e2f5c2ac2eabd630307d5e8da63444148c9", "text": "this.instantiationService.createInstance(ReloadAction), this.instantiationService.createInstance(ExtensionStatusLabelAction), this.instantiationService.createInstance(ActionWithDropDownAction, 'extensions.updateActions', '', <del> [[this.instantiationService.createInstance(UpdateAction)], [this.instantiationService.createInstance(SkipUpdateAction)]]), </del> <ins> [[this.instantiationService.createInstance(UpdateAction, true)], [this.instantiationService.createInstance(SkipUpdateAction)]]), </ins> this.instantiationService.createInstance(SetColorThemeAction), this.instantiationService.createInstance(SetFileIconThemeAction), this.instantiationService.createInstance(SetProductIconThemeAction),", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-d9200899201d56c962b7ad63f6a7b7bd49174a2069345e7aa4cc16435037f3fc", "text": "export class UpdateAction extends AbstractUpdateAction { constructor( <ins> private readonly verbose: boolean, </ins> @IExtensionsWorkbenchService override readonly extensionsWorkbenchService: IExtensionsWorkbenchService, @IInstantiationService protected readonly instantiationService: IInstantiationService, ) { super(`extensions.update`, localize('update', \"Update\"), extensionsWorkbenchService); } <ins> override update(): void { super.update(); if (this.extension) { this.label = this.verbose ? localize('update to', \"Update to v{0}\", this.extension.latestVersion) : localize('update', \"Update\"); } } </ins> override async run(): Promise<any> { if (!this.extension) { return;", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-4f86411acbd24b84c6ff9e5d8ac4378b08634d1ec4cefee22aff98c423f6bf9f", "text": "actionbar.onDidRun(({ error }) => error && this.notificationService.error(error)); const extensionStatusIconAction = this.instantiationService.createInstance(ExtensionStatusAction); <del> const reloadAction = this.instantiationService.createInstance(ReloadAction); </del> const actions = [ this.instantiationService.createInstance(ExtensionStatusLabelAction), this.instantiationService.createInstance(MigrateDeprecatedExtensionAction, true), <del> reloadAction, </del> <ins> this.instantiationService.createInstance(ReloadAction), </ins> this.instantiationService.createInstance(ActionWithDropDownAction, 'extensions.updateActions', '', <del> [[this.instantiationService.createInstance(UpdateAction)], [this.instantiationService.createInstance(SkipUpdateAction)]]), </del> <ins> [[this.instantiationService.createInstance(UpdateAction, false)], [this.instantiationService.createInstance(SkipUpdateAction)]]), </ins> this.instantiationService.createInstance(InstallDropdownAction), this.instantiationService.createInstance(InstallingLabelAction), this.instantiationService.createInstance(SetLanguageAction),", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-5fb382f923afc4f823d7d347ea8c70259903f9b253f2cb4cd941cfdd8105a661", "text": "this.instantiationService.createInstance(SwitchToPreReleaseVersionAction, true), this.instantiationService.createInstance(ManageExtensionAction) ]; <del> const extensionHoverWidget = this.instantiationService.createInstance(ExtensionHoverWidget, { target: root, position: this.options.hoverOptions.position }, extensionStatusIconAction, reloadAction); </del> <ins> const extensionHoverWidget = this.instantiationService.createInstance(ExtensionHoverWidget, { target: root, position: this.options.hoverOptions.position }, extensionStatusIconAction); </ins> const widgets = [ recommendationWidget,", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-6dd840100fee403212f3b14dce3fc07c8dca41fa59ddf1c8f1d07ec313fa6954", "text": "import { EnablementState, IExtensionManagementServerService } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; import { IExtensionIgnoredRecommendationsService, IExtensionRecommendationsService } from 'vs/workbench/services/extensionRecommendations/common/extensionRecommendations'; import { ILabelService } from 'vs/platform/label/common/label'; <del> import { extensionButtonProminentBackground, ExtensionStatusAction, ReloadAction } from 'vs/workbench/contrib/extensions/browser/extensionsActions'; </del> <ins> import { extensionButtonProminentBackground, ExtensionStatusAction } from 'vs/workbench/contrib/extensions/browser/extensionsActions'; </ins> import { IThemeService, ThemeIcon, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { EXTENSION_BADGE_REMOTE_BACKGROUND, EXTENSION_BADGE_REMOTE_FOREGROUND } from 'vs/workbench/common/theme'; import { Emitter, Event } from 'vs/base/common/event';", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-cb12542dec6d76589ec2701f73790d4d7e9572033b32fa612534d4279d4268fe", "text": "constructor( private readonly options: ExtensionHoverOptions, private readonly extensionStatusAction: ExtensionStatusAction, <del> private readonly reloadAction: ReloadAction, </del> @IExtensionsWorkbenchService private readonly extensionsWorkbenchService: IExtensionsWorkbenchService, @IHoverService private readonly hoverService: IHoverService, @IConfigurationService private readonly configurationService: IConfigurationService,", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-929c7e48871ff728190f22909017464dd0e97fbc1973b59fd6ef7060d5b5f4e1", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.\nLatest version is now shown in the hover. Update button in the extension editor shows the version.", "positive_passages": [{"docid": "doc-en-vscode-ce49d40d3844b64e83e82ac5a2daff21bbf8ad827af043eb122163ea4fcd7b77", "text": "markdown.appendText(`n`); } <ins> if (this.extension.outdated) { markdown.appendMarkdown(localize('updateRequired', \"Latest version:\")); markdown.appendMarkdown(`&nbsp;<span style=\"background-color:#8080802B;\">**&nbsp;_v${this.extension.latestVersion}_**&nbsp;</span>`); markdown.appendText(`n`); } </ins> const preReleaseMessage = ExtensionHoverWidget.getPreReleaseMessage(this.extension); const extensionRuntimeStatus = this.extensionsWorkbenchService.getExtensionStatus(this.extension); const extensionStatus = this.extensionStatusAction.status; <del> const reloadRequiredMessage = this.reloadAction.enabled ? this.reloadAction.tooltip : ''; </del> <ins> const reloadRequiredMessage = this.extension.reloadRequiredStatus; </ins> const recommendationMessage = this.getRecommendationMessage(this.extension); if (extensionRuntimeStatus || extensionStatus || reloadRequiredMessage || recommendationMessage || preReleaseMessage) {", "commid": "vscode_pr_164721"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5ce083f6b31876e779ec8d0951ba90255a923682d8b14e20e6b440bb1e7ec96", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.72.1 (Universal) Commit: OS Version: macOS 12.6. Steps to Reproduce: this file: sure it has a extension. all current instances of VS Code it with VS Code with all extensions disabled: around. In a few seconds the editor will lock up. This file has some extremely long lines, around ~65,000. I was under the impression though that VS Code stopped rendering at some cutoff, however. It appears the issue is the syntax highlighting for C#. If I open it as plain text, then I can no longer reproduce the behavior.\nHere is a reduced repro: By using the command, I could find that the oniguruma regex engine gets stuck trying to match the regex: which comes from As a workaround, you can reduce the limit for C# files from 20k to something smaller e.g.: We also have the option of reducing C#'s default. We already did that for javascript to 2500.", "positive_passages": [{"docid": "doc-en-vscode-c0e7e604e1e97520574d04521a80b13d05c85c060d6c589dc1ad7ffc5905fabd", "text": "\"update-grammar\": \"node ../node_modules/vscode-grammar-updater/bin dotnet/csharp-tmLanguage grammars/csharp.tmLanguage ./syntaxes/csharp.tmLanguage.json\" }, \"contributes\": { <ins> \"configurationDefaults\": { \"[csharp]\": { \"editor.maxTokenizationLineLength\": 2500 } }, </ins> \"languages\": [ { \"id\": \"csharp\",", "commid": "vscode_pr_166968"}], "negative_passages": []}
{"query_id": "q-en-vscode-b799770cc89c4d83dda5dbad899f906699c6866f6ae03aa60cfebed7ef34b54c", "query": "Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible\nwould you be willing to verify for completeness?\nWorks great!", "positive_passages": [{"docid": "doc-en-vscode-f4742dedbfd231f9201a9b77ab18ab67dfdb745e066caac1df5556c3e8d9d5ec", "text": "private expandedSize: number | undefined = undefined; private _headerVisible = true; <ins> private _bodyRendered = false; </ins> private _minimumBodySize: number; private _maximumBodySize: number; private _ariaHeaderLabel: string;", "commid": "vscode_pr_165187"}], "negative_passages": []}
{"query_id": "q-en-vscode-b799770cc89c4d83dda5dbad899f906699c6866f6ae03aa60cfebed7ef34b54c", "query": "Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible\nwould you be willing to verify for completeness?\nWorks great!", "positive_passages": [{"docid": "doc-en-vscode-cafae142b1e2a0e2a93428f02f8ab8b996ac440186427337dcabba32ca14a379", "text": "this.updateHeader(); if (expanded) { <ins> if (!this._bodyRendered) { this.renderBody(this.body); this._bodyRendered = true; } </ins> if (typeof this.animationTimer === 'number') { clearTimeout(this.animationTimer); }", "commid": "vscode_pr_165187"}], "negative_passages": []}
{"query_id": "q-en-vscode-b799770cc89c4d83dda5dbad899f906699c6866f6ae03aa60cfebed7ef34b54c", "query": "Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible\nwould you be willing to verify for completeness?\nWorks great!", "positive_passages": [{"docid": "doc-en-vscode-14c71187cd51bb21185d9bba1f75bac4b82a9a57bbd56bb3770919a9c2db8432", "text": "}); this.body = append(this.element, $('.pane-body')); <del> this.renderBody(this.body); </del> <ins> // Only render the body if it will be visible // Otherwise, render it when the pane is expanded if (!this._bodyRendered && this.isExpanded()) { this.renderBody(this.body); this._bodyRendered = true; } </ins> if (!this.isExpanded()) { this.body.remove();", "commid": "vscode_pr_165187"}], "negative_passages": []}
{"query_id": "q-en-vscode-c031b28303fffbe622cd54dc1be02a95cc469127d2905bbbe4384232c0d16f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the \"Current\" column overlaps into the \"Incoming\" column. Confirmed that it happens with the default theme as well. !\nPlease try out the latest insiders, this should be fixed.\nStill appears to be an issue in the latest insiders ! !", "positive_passages": [{"docid": "doc-en-vscode-b46d4e42431a153ccf72bbb74b98bf385f07608c388960179158c60b745a9426", "text": "readonly model = this.viewModel.map(m => /** @description model */ m?.model); protected readonly htmlElements = h('div.code-view', [ <del> h('div.title@header', [ </del> <ins> h('div.header@header', [ </ins> h('span.title@title'), h('span.description@description'), h('span.detail@detail'),", "commid": "vscode_pr_172924"}], "negative_passages": []}
{"query_id": "q-en-vscode-c031b28303fffbe622cd54dc1be02a95cc469127d2905bbbe4384232c0d16f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the \"Current\" column overlaps into the \"Incoming\" column. Confirmed that it happens with the default theme as well. !\nPlease try out the latest insiders, this should be fixed.\nStill appears to be an issue in the latest insiders ! !", "positive_passages": [{"docid": "doc-en-vscode-fd6415943202d2c6c7e1a8f2bbcb9d30ad943db2bba894f048fc319b5d20e046", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> .monaco-workbench .merge-editor .code-view>.title { </del> <ins> .monaco-workbench .merge-editor .code-view > .header { </ins> padding: 0 10px; height: 30px; display: flex; align-content: center; <ins> overflow: hidden; </ins> } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span { </ins> align-self: center; text-overflow: ellipsis; overflow: hidden;", "commid": "vscode_pr_172924"}], "negative_passages": []}
{"query_id": "q-en-vscode-c031b28303fffbe622cd54dc1be02a95cc469127d2905bbbe4384232c0d16f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the \"Current\" column overlaps into the \"Incoming\" column. Confirmed that it happens with the default theme as well. !\nPlease try out the latest insiders, this should be fixed.\nStill appears to be an issue in the latest insiders ! !", "positive_passages": [{"docid": "doc-en-vscode-071f64cf0563f6bc84f318090a0156027289869d949154d557a1d681a4ad35c3", "text": "white-space: nowrap; } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN.title { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span.title { </ins> flex-shrink: 0; } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN.description { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span.description { flex-shrink: 0; </ins> display: flex; font-size: 12px; align-items: center; color: var(--vscode-descriptionForeground); } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN.description .codicon { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span.description .codicon { </ins> font-size: 14px; color: var(--vscode-descriptionForeground); } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN.detail { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span.detail { </ins> margin-left: auto; <del> flex-shrink: 0; </del> font-size: 12px; color: var(--vscode-descriptionForeground); } <ins> .monaco-workbench .merge-editor .code-view > .header > span.detail .codicon { font-size: 13px; } </ins> /* for input1|2 -> align details to the left  */ <del> .monaco-workbench .merge-editor .code-view.input>.title>SPAN.detail::before { </del> <ins> .monaco-workbench .merge-editor .code-view.input > .header > span.detail::before { </ins> content: '\u2022'; opacity: .5; padding-right: 3px; } <del> .monaco-workbench .merge-editor .code-view.input>.title>SPAN.detail { </del> <ins> .monaco-workbench .merge-editor .code-view.input > .header > span.detail { </ins> margin-left: 0; } <del> .monaco-workbench .merge-editor .code-view.input>.title>SPAN.toolbar { </del> <ins> .monaco-workbench .merge-editor .code-view.input > .header > span.toolbar { flex-shrink: 0; </ins> margin-left: auto; } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN.detail .codicon { font-size: 13px; } .monaco-workbench .merge-editor .code-view>.container { </del> <ins> .monaco-workbench .merge-editor .code-view > .container { </ins> display: flex; flex-direction: row; } <del> .monaco-workbench .merge-editor .code-view>.container>.gutter { </del> <ins> .monaco-workbench .merge-editor .code-view > .container > .gutter { </ins> width: 24px; position: relative; overflow: hidden;", "commid": "vscode_pr_172924"}], "negative_passages": []}
{"query_id": "q-en-vscode-c031b28303fffbe622cd54dc1be02a95cc469127d2905bbbe4384232c0d16f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the \"Current\" column overlaps into the \"Incoming\" column. Confirmed that it happens with the default theme as well. !\nPlease try out the latest insiders, this should be fixed.\nStill appears to be an issue in the latest insiders ! !", "positive_passages": [{"docid": "doc-en-vscode-864c72addb7ed8235db3b34ce89459ea9eda256a6f23adebeedea75fa0b296f5", "text": "flex-grow: 0; } <del> .merge-editor-diff { </del> <ins> .monaco-workbench .merge-editor .merge-editor-diff { </ins> background-color: var(--vscode-mergeEditor-change-background); } <del> .merge-editor-diff-word { </del> <ins> .monaco-workbench .merge-editor .merge-editor-diff-word { </ins> background-color: var(--vscode-mergeEditor-change-word-background); } /* BEGIN: .merge-editor-block */ <del> .merge-editor-block:not(.handled) { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block:not(.handled) { </ins> background-color: var(--vscode-mergeEditor-conflict-unhandledUnfocused-background); } <del> .merge-editor-block:not(.handled):not(.focused) { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block:not(.handled):not(.focused) { </ins> border: 1px solid var(--vscode-mergeEditor-conflict-unhandledUnfocused-border); } <del> .merge-editor-block:not(.handled).focused { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block:not(.handled).focused { </ins> border: 2px solid var(--vscode-mergeEditor-conflict-unhandledFocused-border); } <del> .merge-editor-block.handled:not(.focused) { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block.handled:not(.focused) { </ins> border: 1px solid var(--vscode-mergeEditor-conflict-handledUnfocused-border); } <del> .merge-editor-block.handled:not(.focused).conflicting { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block.handled:not(.focused).conflicting { </ins> background-color: var(--vscode-mergeEditor-conflict-handledUnfocused-background); } <del> .merge-editor-block.handled.focused { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block.handled.focused { </ins> border: 1px solid var(--vscode-mergeEditor-conflict-handledFocused-border); } <del> .merge-editor-block.handled.focused.conflicting { </del> <ins> .monaco-workbench .merge-editor .merge-editor-block.handled.focused.conflicting { </ins> background-color: var(--vscode-mergeEditor-conflict-handledFocused-background); } <del> .merge-editor-simplified.input.i1, .merge-editor-block.use-simplified-decorations.input.i1 { </del> <ins> .monaco-workbench .merge-editor .merge-editor-simplified.input.i1, .merge-editor-block.use-simplified-decorations.input.i1 { </ins> background-color: var(--vscode-mergeEditor-conflict-input1-background); } <del> .merge-editor-simplified.input.i2, .merge-editor-block.use-simplified-decorations.input.i2 { </del> <ins> .monaco-workbench .merge-editor .merge-editor-simplified.input.i2, .merge-editor-block.use-simplified-decorations.input.i2 { </ins> background-color: var(--vscode-mergeEditor-conflict-input2-background); } /* END: .merge-editor-block */ <del> .gutter.monaco-editor>div { </del> <ins> .gutter.monaco-editor > div { </ins> position: absolute; }", "commid": "vscode_pr_172924"}], "negative_passages": []}
{"query_id": "q-en-vscode-c031b28303fffbe622cd54dc1be02a95cc469127d2905bbbe4384232c0d16f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the \"Current\" column overlaps into the \"Incoming\" column. Confirmed that it happens with the default theme as well. !\nPlease try out the latest insiders, this should be fixed.\nStill appears to be an issue in the latest insiders ! !", "positive_passages": [{"docid": "doc-en-vscode-33ecf54ea93a2de3d05cc6b48839302d82c7e0f102d908cbccd44bb493e9f3fe", "text": "color: var(--vscode-editorCodeLens-foreground) } <del> .merge-editor-conflict-actions>span, .merge-editor-conflict-actions>a { </del> <ins> .merge-editor-conflict-actions > span, .merge-editor-conflict-actions > a { </ins> user-select: none; -webkit-user-select: none; white-space: nowrap; } <del> .merge-editor-conflict-actions>a { </del> <ins> .merge-editor-conflict-actions > a { </ins> text-decoration: none; } <del> .merge-editor-conflict-actions>a:hover { </del> <ins> .merge-editor-conflict-actions > a:hover { </ins> cursor: pointer; color: var(--vscode-editorLink-activeForeground) !important; } <del> .merge-editor-conflict-actions>a:hover .codicon { </del> <ins> .merge-editor-conflict-actions > a:hover .codicon { </ins> color: var(--vscode-editorLink-activeForeground) !important; }", "commid": "vscode_pr_172924"}], "negative_passages": []}
{"query_id": "q-en-vscode-c031b28303fffbe622cd54dc1be02a95cc469127d2905bbbe4384232c0d16f29", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the \"Current\" column overlaps into the \"Incoming\" column. Confirmed that it happens with the default theme as well. !\nPlease try out the latest insiders, this should be fixed.\nStill appears to be an issue in the latest insiders ! !", "positive_passages": [{"docid": "doc-en-vscode-e2b2d53b419b92de7a59c19a69f225b546018635f3b9ff2d763f01b141249e56", "text": "color: var(--vscode-editorCodeLens-foreground); } <del> .merge-editor-conflict-actions>a:hover .codicon::before { </del> <ins> .merge-editor-conflict-actions > a:hover .codicon::before { </ins> cursor: pointer; }", "commid": "vscode_pr_172924"}], "negative_passages": []}
{"query_id": "q-en-vscode-23b95517cda23ccb26fb7baf74a5932155b983228ab6bda7048fbb17f4ddbfbf", "query": "These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers", "positive_passages": [{"docid": "doc-en-vscode-b51da0d20b091c6e2b00b32f6cf1507dae2edd2c25b69ccb785593e263dc543c", "text": "import { $, addDisposableListener, append, EventHelper, EventType } from 'vs/base/browser/dom'; import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { EventType as GestureEventType, Gesture } from 'vs/base/browser/touch'; <del> import { AnchorAlignment, IAnchor, IContextViewProvider } from 'vs/base/browser/ui/contextview/contextview'; </del> <ins> import { AnchorAlignment } from 'vs/base/browser/ui/contextview/contextview'; </ins> import { IMenuOptions } from 'vs/base/browser/ui/menu/menu'; import { ActionRunner, IAction } from 'vs/base/common/actions'; import { Emitter } from 'vs/base/common/event';", "commid": "vscode_pr_168681"}], "negative_passages": []}
{"query_id": "q-en-vscode-23b95517cda23ccb26fb7baf74a5932155b983228ab6bda7048fbb17f4ddbfbf", "query": "These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers", "positive_passages": [{"docid": "doc-en-vscode-62a9fa47ed62a501ff3bde5ef8b45f78de92bd8c6acae3e8e470b126d0388487", "text": "(container: HTMLElement): IDisposable | null; } <del> export interface IBaseDropdownOptions { </del> <ins> interface IBaseDropdownOptions { </ins> label?: string; labelRenderer?: ILabelRenderer; } <del> export class BaseDropdown extends ActionRunner { </del> <ins> class BaseDropdown extends ActionRunner { </ins> private _element: HTMLElement; private boxContainer?: HTMLElement; private _label?: HTMLElement;", "commid": "vscode_pr_168681"}], "negative_passages": []}
{"query_id": "q-en-vscode-23b95517cda23ccb26fb7baf74a5932155b983228ab6bda7048fbb17f4ddbfbf", "query": "These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers", "positive_passages": [{"docid": "doc-en-vscode-6816b767248a273cdb581a901c74003c17d3588b592961daaba3893b1e4ed2a8", "text": "} } <del> export interface IDropdownOptions extends IBaseDropdownOptions { contextViewProvider: IContextViewProvider; } export class Dropdown extends BaseDropdown { private contextViewProvider: IContextViewProvider; constructor(container: HTMLElement, options: IDropdownOptions) { super(container, options); this.contextViewProvider = options.contextViewProvider; } override show(): void { super.show(); this.element.classList.add('active'); this.contextViewProvider.showContextView({ getAnchor: () => this.getAnchor(), render: (container) => { return this.renderContents(container); }, onDOMEvent: (e, activeElement) => { this.onEvent(e, activeElement); }, onHide: () => this.onHide() }); } protected getAnchor(): HTMLElement | IAnchor { return this.element; } protected onHide(): void { this.element.classList.remove('active'); } override hide(): void { super.hide(); this.contextViewProvider?.hideContextView(); } protected renderContents(container: HTMLElement): IDisposable | null { return null; } } </del> export interface IActionProvider { getActions(): readonly IAction[]; }", "commid": "vscode_pr_168681"}], "negative_passages": []}
{"query_id": "q-en-vscode-8b1b4d2a8a6ca7efc70a35068c3c0e8536ce2790351acb19b59749b48ee156f0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for \"duplicate\". \"Explorer: Incremental Naming\" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the \"This window is not responding\" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set \"Explorer: Incremental Naming\" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user \"will be prompted to override the existing file\". So this might be the expected / intended result.", "positive_passages": [{"docid": "doc-en-vscode-5030d921068063403f153d3a9b4ae88498730a1f301a18b5f3848ece8a02fec0", "text": "} <del> export function findValidPasteFileTarget(explorerService: IExplorerService, targetFolder: ExplorerItem, fileToPaste: { resource: URI; isDirectory?: boolean; allowOverwrite: boolean }, incrementalNaming: 'simple' | 'smart' | 'disabled'): URI { let name = resources.basenameOrAuthority(fileToPaste.resource); </del> <ins> export async function findValidPasteFileTarget( explorerService: IExplorerService, fileService: IFileService, dialogService: IDialogService, targetFolder: ExplorerItem, fileToPaste: { resource: URI; isDirectory?: boolean; allowOverwrite: boolean }, incrementalNaming: 'simple' | 'smart' | 'disabled' ): Promise<URI | undefined> { let name = resources.basenameOrAuthority(fileToPaste.resource); </ins> let candidate = resources.joinPath(targetFolder.resource, name); <ins> // In the disabled case we must ask if it's ok to overwrite the file if it exists if (incrementalNaming === 'disabled') { const canOverwrite = await askForOverwrite(fileService, dialogService, candidate); if (!canOverwrite) { return; } } </ins> while (true && !fileToPaste.allowOverwrite) { if (!explorerService.findClosest(candidate)) { break;", "commid": "vscode_pr_165253"}], "negative_passages": []}
{"query_id": "q-en-vscode-8b1b4d2a8a6ca7efc70a35068c3c0e8536ce2790351acb19b59749b48ee156f0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for \"duplicate\". \"Explorer: Incremental Naming\" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the \"This window is not responding\" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set \"Explorer: Incremental Naming\" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user \"will be prompted to override the existing file\". So this might be the expected / intended result.", "positive_passages": [{"docid": "doc-en-vscode-f8d322776c162f209f72ea407996b100f5c6cec75fdaea729f721022b2eac157", "text": "target = element.isDirectory ? element : element.parent!; } <del> const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming); if (incrementalNaming === 'disabled') { const canOverwrite = await askForOverwrite(fileService, dialogService, targetFile); if (!canOverwrite) { return; } </del> <ins> const targetFile = await findValidPasteFileTarget( explorerService, fileService, dialogService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming ); if (!targetFile) { return undefined; </ins> } return { source: fileToPaste, target: targetFile };", "commid": "vscode_pr_165253"}], "negative_passages": []}
{"query_id": "q-en-vscode-8b1b4d2a8a6ca7efc70a35068c3c0e8536ce2790351acb19b59749b48ee156f0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for \"duplicate\". \"Explorer: Incremental Naming\" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the \"This window is not responding\" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set \"Explorer: Incremental Naming\" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user \"will be prompted to override the existing file\". So this might be the expected / intended result.", "positive_passages": [{"docid": "doc-en-vscode-f4cdebae8dd4ff74d129a545c1425203b44a132e566bddec78b72e541e489fe5", "text": "if (sourceTargetPairs.length >= 1) { // Move/Copy File if (pasteShouldMove) { <del> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target)); </del> <ins> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { overwrite: incrementalNaming === 'disabled' })); </ins> const options = { confirmBeforeUndo: configurationService.getValue<IFilesConfiguration>().explorer.confirmUndo === UndoConfirmLevel.Verbose, progressLabel: sourceTargetPairs.length > 1 ? nls.localize({ key: 'movingBulkEdit', comment: ['Placeholder will be replaced by the number of files being moved'] }, \"Moving {0} files\", sourceTargetPairs.length)", "commid": "vscode_pr_165253"}], "negative_passages": []}
{"query_id": "q-en-vscode-8b1b4d2a8a6ca7efc70a35068c3c0e8536ce2790351acb19b59749b48ee156f0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for \"duplicate\". \"Explorer: Incremental Naming\" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the \"This window is not responding\" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set \"Explorer: Incremental Naming\" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user \"will be prompted to override the existing file\". So this might be the expected / intended result.", "positive_passages": [{"docid": "doc-en-vscode-d9de2b0b52c1dbe5c6848dcee446dd383ed8da37924aa3475bd1ccccb18b56b9", "text": "// Reuse duplicate action when user copies const explorerConfig = this.configurationService.getValue<IFilesConfiguration>().explorer; <del> const resourceFileEdits = sources.map(({ resource, isDirectory }) => (new ResourceFileEdit(resource, findValidPasteFileTarget(this.explorerService, target, { resource, isDirectory, allowOverwrite: false }, explorerConfig.incrementalNaming), { copy: true }))); </del> <ins> const resourceFileEdits: ResourceFileEdit[] = []; for (const { resource, isDirectory } of sources) { const allowOverwrite = explorerConfig.incrementalNaming === 'disabled'; const newResource = await findValidPasteFileTarget(this.explorerService, this.fileService, this.dialogService, target, { resource, isDirectory, allowOverwrite }, explorerConfig.incrementalNaming ); if (!newResource) { continue; } const resourceEdit = new ResourceFileEdit(resource, newResource, { copy: true, overwrite: allowOverwrite }); resourceFileEdits.push(resourceEdit); } </ins> const labelSufix = getFileOrFolderLabelSufix(sources); await this.explorerService.applyBulkEdit(resourceFileEdits, { confirmBeforeUndo: explorerConfig.confirmUndo === UndoConfirmLevel.Default || explorerConfig.confirmUndo === UndoConfirmLevel.Verbose,", "commid": "vscode_pr_165253"}], "negative_passages": []}
{"query_id": "q-en-vscode-953073402dcf159d8212ce059bcae23824c1137fe80c111f2a9632e3b0bd31b6", "query": "I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:", "positive_passages": [{"docid": "doc-en-vscode-617f329fc517933f1052c2dd43555f013f54fe6de28dc39ef2b7cab2a3fc615d", "text": ".monaco-workbench .notebookOverlay .output { position: absolute; height: 0px; <del> font-size: var(--notebook-cell-output-font-size); </del> user-select: text; -webkit-user-select: text; cursor: auto;", "commid": "vscode_pr_165519"}], "negative_passages": []}
{"query_id": "q-en-vscode-953073402dcf159d8212ce059bcae23824c1137fe80c111f2a9632e3b0bd31b6", "query": "I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:", "positive_passages": [{"docid": "doc-en-vscode-b2df051d31a9540149ebf76237fdf7c81999bd26ba7b682fff408c1189ffdd4a", "text": "insertToolbarPosition, insertToolbarAlignment, fontSize, <ins> outputFontSize, </ins> focusIndicatorLeftMargin, focusIndicatorGap } = this._notebookOptions.getLayoutConfiguration();", "commid": "vscode_pr_165519"}], "negative_passages": []}
{"query_id": "q-en-vscode-953073402dcf159d8212ce059bcae23824c1137fe80c111f2a9632e3b0bd31b6", "query": "I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:", "positive_passages": [{"docid": "doc-en-vscode-1196e8f08e82634b7a135926660914bb558fa78af4680e48c98b7f05f406a89d", "text": "const fontFamily = this._generateFontFamily(); styleSheets.push(` <del> :root { --notebook-cell-output-font-size: ${fontSize}px; --notebook-cell-output-font-family: ${fontFamily}; </del> <ins> .notebook-editor { --notebook-cell-output-font-size: ${outputFontSize}px; </ins> --notebook-cell-input-preview-font-size: ${fontSize}px; --notebook-cell-input-preview-font-family: ${fontFamily}; }", "commid": "vscode_pr_165519"}], "negative_passages": []}
{"query_id": "q-en-vscode-3163dc249ee3ddf956edba92a2a8dca38d6191f8e114a8ebea190c85e64d7ef3", "query": "Type: <bBug</bThe experimental \"user profiles\" feature uses absolute paths which break when using a (which is done by creating a \"data/\" folder in VSC's root directory). These paths seem to be stored in \"data/user-\", at least in part. This makes VSC forget any extensions installed on the default profile as well as any other profiles. It also prevents VSC from finding the settings for any non-default profiles: When trying to edit the settings for a non-default profile, a new \"\" file is created where VSC expects the file to be. It displays an error message instead if the expected path is invalid (ex. portable installation's drive letter changed). Steps to Reproduce: a portable (.zip) version of VSCode and extract to a folder. an empty \"data/\" folder inside that folder. VSC and install any extension with the default profile. a second profile. Change some of its settings and install any extension. VSC and move the VSC folder to another location. VSC again. VS Code version: Code - Insiders 1.74.0-insider (, 2022-11-03T18:43:35.409Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-7da2793942d610d4d7dcde55ab81a650c5a23fe6c929e86247195b648eaef1e9", "text": "import { ILogService } from 'vs/platform/log/common/log'; import { IUserDataProfilesService } from 'vs/platform/userDataProfile/common/userDataProfile'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; <ins> import { isObject, isString } from 'vs/base/common/types'; import { Schemas } from 'vs/base/common/network'; </ins> interface IStoredProfileExtension { identifier: IExtensionIdentifier; <del> location: UriComponents; </del> <ins> location: UriComponents | string; </ins> version: string; metadata?: Metadata; }", "commid": "vscode_pr_169056"}], "negative_passages": []}
{"query_id": "q-en-vscode-3163dc249ee3ddf956edba92a2a8dca38d6191f8e114a8ebea190c85e64d7ef3", "query": "Type: <bBug</bThe experimental \"user profiles\" feature uses absolute paths which break when using a (which is done by creating a \"data/\" folder in VSC's root directory). These paths seem to be stored in \"data/user-\", at least in part. This makes VSC forget any extensions installed on the default profile as well as any other profiles. It also prevents VSC from finding the settings for any non-default profiles: When trying to edit the settings for a non-default profile, a new \"\" file is created where VSC expects the file to be. It displays an error message instead if the expected path is invalid (ex. portable installation's drive letter changed). Steps to Reproduce: a portable (.zip) version of VSCode and extract to a folder. an empty \"data/\" folder inside that folder. VSC and install any extension with the default profile. a second profile. Change some of its settings and install any extension. VSC and move the VSC folder to another location. VSC again. VS Code version: Code - Insiders 1.74.0-insider (, 2022-11-03T18:43:35.409Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-13aa78b475db18a6b51a8d0066851f13216c17f5ad63da64270b91bd2ff6445a", "text": "if (!Array.isArray(storedProfileExtensions)) { throw new Error(`Invalid extensions content in ${file.toString()}`); } <ins> // TODO @sandy081: Remove this migration after couple of releases let migrate = false; </ins> for (const e of storedProfileExtensions) { if (!isStoredProfileExtension(e)) { throw new Error(`Invalid extensions content in ${file.toString()}`); } <ins> let location: URI; if (isString(e.location)) { location = this.resolveExtensionLocation(file, e.location); } else { location = URI.revive(e.location); const relativePath = this.toRelativePath(file, location); if (relativePath) { migrate = true; e.location = relativePath; } } </ins> extensions.push({ identifier: e.identifier, <del> location: URI.revive(e.location), </del> <ins> location, </ins> version: e.version, metadata: e.metadata, }); } <ins> if (migrate) { await this.fileService.writeFile(file, VSBuffer.fromString(JSON.stringify(storedProfileExtensions))); } </ins> } // Update", "commid": "vscode_pr_169056"}], "negative_passages": []}
{"query_id": "q-en-vscode-3163dc249ee3ddf956edba92a2a8dca38d6191f8e114a8ebea190c85e64d7ef3", "query": "Type: <bBug</bThe experimental \"user profiles\" feature uses absolute paths which break when using a (which is done by creating a \"data/\" folder in VSC's root directory). These paths seem to be stored in \"data/user-\", at least in part. This makes VSC forget any extensions installed on the default profile as well as any other profiles. It also prevents VSC from finding the settings for any non-default profiles: When trying to edit the settings for a non-default profile, a new \"\" file is created where VSC expects the file to be. It displays an error message instead if the expected path is invalid (ex. portable installation's drive letter changed). Steps to Reproduce: a portable (.zip) version of VSCode and extract to a folder. an empty \"data/\" folder inside that folder. VSC and install any extension with the default profile. a second profile. Change some of its settings and install any extension. VSC and move the VSC folder to another location. VSC again. VS Code version: Code - Insiders 1.74.0-insider (, 2022-11-03T18:43:35.409Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-7e503f39bb4e896108c2e676a4bea383776a0a83ea8aceed78f0bf8e7a9d347b", "text": "const storedProfileExtensions: IStoredProfileExtension[] = extensions.map(e => ({ identifier: e.identifier, version: e.version, <del> location: e.location.toJSON(), </del> <ins> location: this.toRelativePath(file, e.location) ?? e.location.toJSON(), </ins> metadata: e.metadata })); await this.fileService.writeFile(file, VSBuffer.fromString(JSON.stringify(storedProfileExtensions)));", "commid": "vscode_pr_169056"}], "negative_passages": []}
{"query_id": "q-en-vscode-3163dc249ee3ddf956edba92a2a8dca38d6191f8e114a8ebea190c85e64d7ef3", "query": "Type: <bBug</bThe experimental \"user profiles\" feature uses absolute paths which break when using a (which is done by creating a \"data/\" folder in VSC's root directory). These paths seem to be stored in \"data/user-\", at least in part. This makes VSC forget any extensions installed on the default profile as well as any other profiles. It also prevents VSC from finding the settings for any non-default profiles: When trying to edit the settings for a non-default profile, a new \"\" file is created where VSC expects the file to be. It displays an error message instead if the expected path is invalid (ex. portable installation's drive letter changed). Steps to Reproduce: a portable (.zip) version of VSCode and extract to a folder. an empty \"data/\" folder inside that folder. VSC and install any extension with the default profile. a second profile. Change some of its settings and install any extension. VSC and move the VSC folder to another location. VSC again. VS Code version: Code - Insiders 1.74.0-insider (, 2022-11-03T18:43:35.409Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-66597a9318d757000a15b745e35ca488e7d39ed3c7b916245a4da5d1cd243a0a", "text": "}); } <ins> private toRelativePath(extensionsProfileLocation: URI, extensionLocation: URI): string | undefined { // Extension Profile location scheme is always vscode-userdata and Extension location scheme is always file // Hence we need to convert the Extension Profile location scheme to file to resolve the relative path const parent = this.uriIdentityService.extUri.dirname(extensionsProfileLocation).with({ scheme: Schemas.file }); if (this.uriIdentityService.extUri.isEqualOrParent(extensionLocation, parent)) { return this.uriIdentityService.extUri.relativePath(parent, extensionLocation); } return undefined; } private resolveExtensionLocation(extensionsProfileLocation: URI, path: string): URI { // Extension Profile location scheme is always vscode-userdata and Extension location scheme is always file // Hence we need to convert the Extension Profile location scheme to file to resolve extension location return this.uriIdentityService.extUri.joinPath(this.uriIdentityService.extUri.dirname(extensionsProfileLocation), path).with({ scheme: Schemas.file }); } </ins> private _migrationPromise: Promise<IStoredProfileExtension[] | undefined> | undefined; private async migrateFromOldDefaultProfileExtensionsLocation(): Promise<IStoredProfileExtension[] | undefined> { if (!this._migrationPromise) {", "commid": "vscode_pr_169056"}], "negative_passages": []}
{"query_id": "q-en-vscode-3163dc249ee3ddf956edba92a2a8dca38d6191f8e114a8ebea190c85e64d7ef3", "query": "Type: <bBug</bThe experimental \"user profiles\" feature uses absolute paths which break when using a (which is done by creating a \"data/\" folder in VSC's root directory). These paths seem to be stored in \"data/user-\", at least in part. This makes VSC forget any extensions installed on the default profile as well as any other profiles. It also prevents VSC from finding the settings for any non-default profiles: When trying to edit the settings for a non-default profile, a new \"\" file is created where VSC expects the file to be. It displays an error message instead if the expected path is invalid (ex. portable installation's drive letter changed). Steps to Reproduce: a portable (.zip) version of VSCode and extract to a folder. an empty \"data/\" folder inside that folder. VSC and install any extension with the default profile. a second profile. Change some of its settings and install any extension. VSC and move the VSC folder to another location. VSC again. VS Code version: Code - Insiders 1.74.0-insider (, 2022-11-03T18:43:35.409Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-344a1540c5cb1ae4406388b470174da1e76c7da7f93ea91bdcb4d9233285a987", "text": "} function isStoredProfileExtension(candidate: any): candidate is IStoredProfileExtension { <del> return typeof candidate === 'object' </del> <ins> return isObject(candidate) </ins> && isIExtensionIdentifier(candidate.identifier) <del> && isUriComponents(candidate.location) && candidate.version && typeof candidate.version === 'string'; </del> <ins> && (isUriComponents(candidate.location) || isString(candidate.location)) && candidate.version && isString(candidate.version); </ins> } function isUriComponents(thing: unknown): thing is UriComponents { if (!thing) { return false; } <del> return typeof (<any>thing).path === 'string' && typeof (<any>thing).scheme === 'string'; </del> <ins> return isString((<any>thing).path) && isString((<any>thing).scheme); </ins> }", "commid": "vscode_pr_169056"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-924a193e1c7a1cf47a7f7d70bb7cb7e688ef759ee16845a18c0cfccbe643b35c", "text": "private versionId = 0; private bufferSavedVersionId: number | undefined; private ignoreDirtyOnModelContentChange = false; <ins> private ignoreSaveFromSaveParticipants = false; </ins> private static readonly UNDO_REDO_SAVE_PARTICIPANTS_AUTO_SAVE_THROTTLE_THRESHOLD = 500; private lastModelContentChangeFromUndoRedo: number | undefined = undefined;", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-fa1afb1bbcb181c554c7b03061de8b1e45a6fe6a19bf5fa4b6d7ebbf8fd06d96", "text": "let versionId = this.versionId; this.trace(`doSave(${versionId}) - enter with versionId ${versionId}`); <ins> // Return early if saved from within save participant to break recursion // // Scenario: a save participant triggers a save() on the model if (this.ignoreSaveFromSaveParticipants) { this.trace(`doSave(${versionId}) - exit - refusing to save() recursively from save participant`); return; } </ins> // Lookup any running pending save for this versionId and return it if found // // Scenario: user invoked the save action multiple times quickly for the same contents", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-62e0eff17a5650faa795cd0ccd16d3606c17af90e56a3070fe1ad823163e859f", "text": "// Run save participants unless save was cancelled meanwhile if (!saveCancellation.token.isCancellationRequested) { <del> await this.textFileService.files.runSaveParticipants(this, { reason: options.reason ?? SaveReason.EXPLICIT }, saveCancellation.token); </del> <ins> this.ignoreSaveFromSaveParticipants = true; try { await this.textFileService.files.runSaveParticipants(this, { reason: options.reason ?? SaveReason.EXPLICIT }, saveCancellation.token); } finally { this.ignoreSaveFromSaveParticipants = false; } </ins> } } catch (error) { this.logService.error(`[text file model] runSaveParticipants(${versionId}) - resulted in an error: ${error.toString()}`, this.resource.toString());", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-b1c5278b53e79301d832f0912773b51057c44756e191110b74e8783dd244ab71", "text": "participant.dispose(); }); <del> test('Save Participant, calling save from within is unsupported but does not explode (sync save)', async function () { </del> <ins> test('Save Participant, calling save from within is unsupported but does not explode (sync save, no model change)', async function () { </ins> const model: TextFileEditorModel = instantiationService.createInstance(TextFileEditorModel, toResource.call(this, '/path/index_async.txt'), 'utf8', undefined); <del> await testSaveFromSaveParticipant(model, false); </del> <ins> await testSaveFromSaveParticipant(model, false, false, false); </ins> model.dispose(); }); <del> test('Save Participant, calling save from within is unsupported but does not explode (async save)', async function () { </del> <ins> test('Save Participant, calling save from within is unsupported but does not explode (async save, no model change)', async function () { </ins> const model: TextFileEditorModel = instantiationService.createInstance(TextFileEditorModel, toResource.call(this, '/path/index_async.txt'), 'utf8', undefined); <del> await testSaveFromSaveParticipant(model, true); </del> <ins> await testSaveFromSaveParticipant(model, true, false, false); </ins> model.dispose(); }); <del> async function testSaveFromSaveParticipant(model: TextFileEditorModel, async: boolean): Promise<void> { </del> <ins> test('Save Participant, calling save from within is unsupported but does not explode (sync save, model change)', async function () { const model: TextFileEditorModel = instantiationService.createInstance(TextFileEditorModel, toResource.call(this, '/path/index_async.txt'), 'utf8', undefined); </ins> <del> let breakLoop = false; </del> <ins> await testSaveFromSaveParticipant(model, false, true, false); </ins> <del> const participant = accessor.textFileService.files.addSaveParticipant({ participate: async model => { if (breakLoop) { return; } </del> <ins> model.dispose(); }); test('Save Participant, calling save from within is unsupported but does not explode (async save, model change)', async function () { const model: TextFileEditorModel = instantiationService.createInstance(TextFileEditorModel, toResource.call(this, '/path/index_async.txt'), 'utf8', undefined); await testSaveFromSaveParticipant(model, true, true, false); model.dispose(); }); test('Save Participant, calling save from within is unsupported but does not explode (force)', async function () { const model: TextFileEditorModel = instantiationService.createInstance(TextFileEditorModel, toResource.call(this, '/path/index_async.txt'), 'utf8', undefined); await testSaveFromSaveParticipant(model, false, false, true); </ins> <del> breakLoop = true; </del> <ins> model.dispose(); }); async function testSaveFromSaveParticipant(model: TextFileEditorModel, async: boolean, modelChange: boolean, force: boolean): Promise<void> { const disposable = accessor.textFileService.files.addSaveParticipant({ participate: async () => { </ins> if (async) { await timeout(10); } <del> const newSavePromise = model.save(); // assert that this is the same promise as the outer one assert.strictEqual(savePromise, newSavePromise); </del> <ins> if (modelChange) { model.updateTextEditorModel(createTextBufferFactory('bar')); const newSavePromise = model.save(force ? { force } : undefined); // assert that this is not the same promise as the outer one assert.notStrictEqual(savePromise, newSavePromise); await newSavePromise; } else { const newSavePromise = model.save(force ? { force } : undefined); // assert that this is the same promise as the outer one assert.strictEqual(savePromise, newSavePromise); await savePromise; } </ins> } }); await model.resolve(); model.updateTextEditorModel(createTextBufferFactory('foo')); <del> const savePromise = model.save(); </del> <ins> const savePromise = model.save(force ? { force } : undefined); </ins> await savePromise; <del> participant.dispose(); </del> <ins> disposable.dispose(); </ins> } test('backup and restore (simple)', async function () {", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-24cd4e8da8403aff78b984710390d4a1c9cbf8ce8814148ea760950612187697", "text": "private readonly saveSequentializer = new TaskSequentializer(); <ins> private ignoreSaveFromSaveParticipants = false; </ins> async save(options: IStoredFileWorkingCopySaveOptions = Object.create(null)): Promise<boolean> { if (!this.isResolved()) { return false;", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-ab7a5eba4257fe6d251eb6fa0cbb0e9b87a5dddf975640d1b21d24e9a5063345", "text": "let versionId = this.versionId; this.trace(`doSave(${versionId}) - enter with versionId ${versionId}`); <ins> // Return early if saved from within save participant to break recursion // // Scenario: a save participant triggers a save() on the working copy if (this.ignoreSaveFromSaveParticipants) { this.trace(`doSave(${versionId}) - exit - refusing to save() recursively from save participant`); return; } </ins> // Lookup any running pending save for this versionId and return it if found // // Scenario: user invoked the save action multiple times quickly for the same contents", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-6152280813182688c47806fbcfc5c9511e767df0adf40cadfd10909dfc4d2d7a", "text": "// Run save participants unless save was cancelled meanwhile if (!saveCancellation.token.isCancellationRequested) { <del> await this.workingCopyFileService.runSaveParticipants(this, { reason: options.reason ?? SaveReason.EXPLICIT }, saveCancellation.token); </del> <ins> this.ignoreSaveFromSaveParticipants = true; try { await this.workingCopyFileService.runSaveParticipants(this, { reason: options.reason ?? SaveReason.EXPLICIT }, saveCancellation.token); } finally { this.ignoreSaveFromSaveParticipants = false; } </ins> } } catch (error) { this.logService.error(`[stored file working copy] runSaveParticipants(${versionId}) - resulted in an error: ${error.toString()}`, this.resource.toString(), this.typeId);", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-3c31c721a0814a37fba1b5d116694c54f0932f0ba02c8657c9ed3da12883fd4f", "text": "import { basename } from 'vs/base/common/resources'; import { FileChangesEvent, FileChangeType, FileOperationError, FileOperationResult, NotModifiedSinceFileOperationError } from 'vs/platform/files/common/files'; import { SaveReason, SaveSourceRegistry } from 'vs/workbench/common/editor'; <del> import { Promises } from 'vs/base/common/async'; </del> <ins> import { Promises, timeout } from 'vs/base/common/async'; </ins> import { consumeReadable, consumeStream, isReadableStream } from 'vs/base/common/stream'; import { runWithFakedTimers } from 'vs/base/test/common/timeTravelScheduler';", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-d1f86c446cfbc5eb3989a54b125dafcec2da3fb31d8c506fd404cbe767d113c9", "query": "This is a follow-up from and describes the problem that save participants causing a save operation\nreproduced when undoing some fixes (applying the fix below)\nfyi", "positive_passages": [{"docid": "doc-en-vscode-9d39b44194930c372f17ea4568eeeb14d35b4dd7e58b4dd318a62225d969bcfe", "text": "assert.strictEqual(participationCounter, 1); }); <ins> test('Save Participant, calling save from within is unsupported but does not explode (sync save)', async function () { await workingCopy.resolve(); await testSaveFromSaveParticipant(workingCopy, false); }); test('Save Participant, calling save from within is unsupported but does not explode (async save)', async function () { await workingCopy.resolve(); await testSaveFromSaveParticipant(workingCopy, true); }); async function testSaveFromSaveParticipant(workingCopy: StoredFileWorkingCopy<TestStoredFileWorkingCopyModel>, async: boolean): Promise<void> { assert.strictEqual(accessor.workingCopyFileService.hasSaveParticipants, false); const disposable = accessor.workingCopyFileService.addSaveParticipant({ participate: async () => { if (async) { await timeout(10); } await workingCopy.save({ force: true }); } }); assert.strictEqual(accessor.workingCopyFileService.hasSaveParticipants, true); await workingCopy.save({ force: true }); disposable.dispose(); } </ins> test('revert', async () => { await workingCopy.resolve(); workingCopy.model?.updateContents('hello revert');", "commid": "vscode_pr_166434"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-1c95707d9b8cb6b49dd5308f73f4b04bb04bb4cdb916a7c1201dc0b8857c63e5", "text": "type KernelQuickPickItem = IQuickPickItem | InstallExtensionPick | KernelPick | SourcePick; const KERNEL_PICKER_UPDATE_DEBOUNCE = 200; <del> registerAction2(class extends Action2 { constructor() { super({ id: SELECT_KERNEL_ID, category: NOTEBOOK_ACTIONS_CATEGORY, title: { value: localize('notebookActions.selectKernel', \"Select Notebook Kernel\"), original: 'Select Notebook Kernel' }, // precondition: NOTEBOOK_IS_ACTIVE_EDITOR, icon: selectKernelIcon, f1: true, menu: [{ id: MenuId.EditorTitle, when: ContextKeyExpr.and( NOTEBOOK_IS_ACTIVE_EDITOR, ContextKeyExpr.notEquals('config.notebook.globalToolbar', true) ), group: 'navigation', order: -10 }, { id: MenuId.NotebookToolbar, when: ContextKeyExpr.equals('config.notebook.globalToolbar', true), group: 'status', order: -10 }, { id: MenuId.InteractiveToolbar, when: NOTEBOOK_KERNEL_COUNT.notEqualsTo(0), group: 'status', order: -10 }], description: { description: localize('notebookActions.selectKernel.args', \"Notebook Kernel Args\"), args: [ { name: 'kernelInfo', description: 'The kernel info', schema: { 'type': 'object', 'required': ['id', 'extension'], 'properties': { 'id': { 'type': 'string' }, 'extension': { 'type': 'string' }, 'notebookEditorId': { 'type': 'string' } } } } ] }, }); } async run(accessor: ServicesAccessor, context?: { id: string; extension: string } | { notebookEditorId: string } | { id: string; extension: string; notebookEditorId: string } | { ui?: boolean; notebookEditor?: NotebookEditorWidget } | undefined ): Promise<boolean> { const notebookKernelService = accessor.get(INotebookKernelService); const editorService = accessor.get(IEditorService); const productService = accessor.get(IProductService); const quickInputService = accessor.get(IQuickInputService); const labelService = accessor.get(ILabelService); const logService = accessor.get(ILogService); const paneCompositeService = accessor.get(IPaneCompositePartService); const extensionWorkbenchService = accessor.get(IExtensionsWorkbenchService); const extensionHostService = accessor.get(IExtensionService); </del> <ins> type KernelQuickPickContext = { id: string; extension: string } | { notebookEditorId: string } | { id: string; extension: string; notebookEditorId: string } | { ui?: boolean; notebookEditor?: NotebookEditorWidget }; interface IKernelPickerStrategy { showQuickPick(context?: KernelQuickPickContext): Promise<boolean>; } </ins> <del> let editor: INotebookEditor | undefined; if (context !== undefined && 'notebookEditorId' in context) { const editorId = context.notebookEditorId; const matchingEditor = editorService.visibleEditorPanes.find((editorPane) => { const notebookEditor = getNotebookEditorFromEditorPane(editorPane); return notebookEditor?.getId() === editorId; }); editor = getNotebookEditorFromEditorPane(matchingEditor); } else if (context !== undefined && 'notebookEditor' in context) { editor = context?.notebookEditor; } else { editor = getNotebookEditorFromEditorPane(editorService.activeEditorPane); } </del> <ins> class KernelPickerFlatStrategy implements IKernelPickerStrategy { constructor( private readonly _notebookKernelService: INotebookKernelService, private readonly _editorService: IEditorService, private readonly _productService: IProductService, private readonly _quickInputService: IQuickInputService, private readonly _labelService: ILabelService, private readonly _logService: ILogService, private readonly _paneCompositePartService: IPaneCompositePartService, private readonly _extensionWorkbenchService: IExtensionsWorkbenchService, private readonly _extensionService: IExtensionService, ) { } async showQuickPick(context?: KernelQuickPickContext): Promise<boolean> { const editor = this._getEditorFromContext(context); </ins> if (!editor || !editor.hasModel()) { return false;", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-d8b2508fa3eb345c85f2cdb6f45b95eeefdad7166b348d4640dec42b4b74b0e8", "text": "const notebook = editor.textModel; const scopedContextKeyService = editor.scopedContextKeyService; <del> const matchResult = notebookKernelService.getMatchingKernel(notebook); </del> <ins> const matchResult = this._notebookKernelService.getMatchingKernel(notebook); </ins> const { selected, all } = matchResult; if (selected && controllerId && selected.id === controllerId && ExtensionIdentifier.equals(selected.extension, extensionId)) {", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-a53daf6b304cd51422769cf6f8eab023dccf3a4788c6f1d97587dc8418154a41", "text": "} } if (!newKernel) { <del> logService.warn(`wanted kernel DOES NOT EXIST, wanted: ${wantedId}, all: ${all.map(k => k.id)}`); </del> <ins> this._logService.warn(`wanted kernel DOES NOT EXIST, wanted: ${wantedId}, all: ${all.map(k => k.id)}`); </ins> return false; } } if (newKernel) { <del> notebookKernelService.selectKernelForNotebook(newKernel, notebook); </del> <ins> this._notebookKernelService.selectKernelForNotebook(newKernel, notebook); </ins> return true; } <del> const quickPick = quickInputService.createQuickPick<KernelQuickPickItem>(); const quickPickItems = this._getKernelPickerQuickPickItems(notebook, matchResult, notebookKernelService, scopedContextKeyService); </del> <ins> const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>(); const quickPickItems = this._getKernelPickerQuickPickItems(notebook, matchResult, this._notebookKernelService, scopedContextKeyService); </ins> quickPick.items = quickPickItems; quickPick.canSelectMany = false; quickPick.placeholder = selected <del> ? localize('prompt.placeholder.change', \"Change kernel for '{0}'\", labelService.getUriLabel(notebook.uri, { relative: true })) : localize('prompt.placeholder.select', \"Select kernel for '{0}'\", labelService.getUriLabel(notebook.uri, { relative: true })); </del> <ins> ? localize('prompt.placeholder.change', \"Change kernel for '{0}'\", this._labelService.getUriLabel(notebook.uri, { relative: true })) : localize('prompt.placeholder.select', \"Select kernel for '{0}'\", this._labelService.getUriLabel(notebook.uri, { relative: true })); </ins> <del> quickPick.busy = notebookKernelService.getKernelDetectionTasks(notebook).length > 0; </del> <ins> quickPick.busy = this._notebookKernelService.getKernelDetectionTasks(notebook).length > 0; </ins> <del> const kernelDetectionTaskListener = notebookKernelService.onDidChangeKernelDetectionTasks(() => { quickPick.busy = notebookKernelService.getKernelDetectionTasks(notebook).length > 0; </del> <ins> const kernelDetectionTaskListener = this._notebookKernelService.onDidChangeKernelDetectionTasks(() => { quickPick.busy = this._notebookKernelService.getKernelDetectionTasks(notebook).length > 0; </ins> }); // run extension recommendataion task if quickPickItems is empty const extensionRecommendataionPromise = quickPickItems.length === 0 <del> ? createCancelablePromise(token => this._showInstallKernelExtensionRecommendation(notebook, quickPick, extensionWorkbenchService, token)) </del> <ins> ? createCancelablePromise(token => this._showInstallKernelExtensionRecommendation(notebook, quickPick, this._extensionWorkbenchService, token)) </ins> : undefined; const kernelChangeEventListener = Event.debounce<void, void>( Event.any( <del> notebookKernelService.onDidChangeSourceActions, notebookKernelService.onDidAddKernel, notebookKernelService.onDidRemoveKernel, notebookKernelService.onDidChangeNotebookAffinity </del> <ins> this._notebookKernelService.onDidChangeSourceActions, this._notebookKernelService.onDidAddKernel, this._notebookKernelService.onDidRemoveKernel, this._notebookKernelService.onDidChangeNotebookAffinity </ins> ), (last, _current) => last, KERNEL_PICKER_UPDATE_DEBOUNCE", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-91b7d71237e4572eb6c69191220cb0768771cf274b9fd88931ffaf8335b4a148", "text": "extensionRecommendataionPromise?.cancel(); const currentActiveItems = quickPick.activeItems; <del> const matchResult = notebookKernelService.getMatchingKernel(notebook); const quickPickItems = this._getKernelPickerQuickPickItems(notebook, matchResult, notebookKernelService, scopedContextKeyService); </del> <ins> const matchResult = this._notebookKernelService.getMatchingKernel(notebook); const quickPickItems = this._getKernelPickerQuickPickItems(notebook, matchResult, this._notebookKernelService, scopedContextKeyService); </ins> quickPick.keepScrollPosition = true; // recalcuate active items", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-a99aabf6c4a5406a2d4b1b8144c1bdc45356e822d853412dec3e3eed659a83ee", "text": "if (pick) { if (isKernelPick(pick)) { newKernel = pick.kernel; <del> notebookKernelService.selectKernelForNotebook(newKernel, notebook); </del> <ins> this._notebookKernelService.selectKernelForNotebook(newKernel, notebook); </ins> return true; } // actions if (pick.id === 'install') { await this._showKernelExtension( <del> paneCompositeService, extensionWorkbenchService, extensionHostService, </del> <ins> this._paneCompositePartService, this._extensionWorkbenchService, this._extensionService, </ins> notebook.viewType ); // suggestedExtension must be defined for this option to be shown, but still check to make TS happy } else if (isInstallExtensionPick(pick)) { await this._showKernelExtension( <del> paneCompositeService, extensionWorkbenchService, extensionHostService, </del> <ins> this._paneCompositePartService, this._extensionWorkbenchService, this._extensionService, </ins> notebook.viewType, pick.extensionId, <del> productService.quality !== 'stable' </del> <ins> this._productService.quality !== 'stable' </ins> ); } else if (isSourcePick(pick)) { // selected explicilty, it should trigger the execution?", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-13238c1c20c071bc5eacf89f14964b5d0a89da09f72ec87cf245335ce1ca5866", "text": "return false; } <ins> private _getEditorFromContext(context?: KernelQuickPickContext): INotebookEditor | undefined { let editor: INotebookEditor | undefined; if (context !== undefined && 'notebookEditorId' in context) { const editorId = context.notebookEditorId; const matchingEditor = this._editorService.visibleEditorPanes.find((editorPane) => { const notebookEditor = getNotebookEditorFromEditorPane(editorPane); return notebookEditor?.getId() === editorId; }); editor = getNotebookEditorFromEditorPane(matchingEditor); } else if (context !== undefined && 'notebookEditor' in context) { editor = context?.notebookEditor; } else { editor = getNotebookEditorFromEditorPane(this._editorService.activeEditorPane); } return editor; } </ins> private _getKernelPickerQuickPickItems( notebookTextModel: NotebookTextModel, matchResult: INotebookKernelMatchResult,", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-b67f13e26a1174c59c81ab0a6a3e2ee69ebd4f5449dbb06bec502d0c49883ca3", "text": "): QuickPickInput<KernelQuickPickItem>[] { const { selected, all, suggestions, hidden } = matchResult; <del> function toQuickPick(kernel: INotebookKernel) { const res = <KernelPick>{ kernel, picked: kernel.id === selected?.id, label: kernel.label, description: kernel.description, detail: kernel.detail }; if (kernel.id === selected?.id) { if (!res.description) { res.description = localize('current1', \"Currently Selected\"); } else { res.description = localize('current2', \"{0} - Currently Selected\", res.description); } } return res; } </del> const quickPickItems: QuickPickInput<KernelQuickPickItem>[] = []; if (all.length) { // Always display suggested kernels on the top. <del> if (suggestions.length) { quickPickItems.push({ type: 'separator', label: localize('suggestedKernels', \"Suggested\") }); quickPickItems.push(...suggestions.map(toQuickPick)); } </del> <ins> this._fillInSuggestions(quickPickItems, suggestions, selected); </ins> // Next display all of the kernels not marked as hidden grouped by categories or extensions. // If we don't have a kind, always display those at the bottom. <del> const picks = all.filter(item => (!suggestions.includes(item) && !hidden.includes(item))).map(toQuickPick); </del> <ins> const picks = all.filter(item => (!suggestions.includes(item) && !hidden.includes(item))).map(kernel => this._toQuickPick(kernel, selected)); </ins> const kernelsPerCategory = groupBy(picks, (a, b) => compareIgnoreCase(a.kernel.kind || 'z', b.kernel.kind || 'z')); kernelsPerCategory.forEach(items => { quickPickItems.push({", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-da626a15c28a8bfafd916ad63793e7b8ffd06780d6e27620340c03e0a6bce350", "text": "return quickPickItems; } <ins> private _toQuickPick(kernel: INotebookKernel, selected: INotebookKernel | undefined) { const res = <KernelPick>{ kernel, picked: kernel.id === selected?.id, label: kernel.label, description: kernel.description, detail: kernel.detail }; if (kernel.id === selected?.id) { if (!res.description) { res.description = localize('current1', \"Currently Selected\"); } else { res.description = localize('current2', \"{0} - Currently Selected\", res.description); } } return res; } private _fillInSuggestions(quickPickItems: QuickPickInput<KernelQuickPickItem>[], suggestions: INotebookKernel[], selected: INotebookKernel | undefined) { if (!suggestions.length) { return; } if (suggestions.length === 1 && suggestions[0].id === selected?.id) { quickPickItems.push({ type: 'separator', label: localize('selectedKernels', \"Selected\") }); // The title is already set to \"Selected\" so we don't need to set it again in description, thus passing in `undefined`. quickPickItems.push(this._toQuickPick(suggestions[0], undefined)); return; } quickPickItems.push({ type: 'separator', label: localize('suggestedKernels', \"Suggested\") }); quickPickItems.push(...suggestions.map(kernel => this._toQuickPick(kernel, selected))); } </ins> private async _showInstallKernelExtensionRecommendation( notebookTextModel: NotebookTextModel, quickPick: IQuickPick<KernelQuickPickItem>,", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-174c1b747e4a6321aafd6d86990eb408c872f21f75909fa9460e0f9577223b47", "text": "} } private async _getKernelRecommendationsQuickPickItems( notebookTextModel: NotebookTextModel, extensionWorkbenchService: IExtensionsWorkbenchService,", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-7dae061ba3d1638005fd09904c6784556e4ea65fa963baba0a94e2bcd5f9023e", "query": "Currently when there is one suggested kernel and that's the one users are using in current document, its presentation in kernel picker is weird <img width=\"601\" alt=\"image\" src=\"https://user-\"This can be simplified as a single \"Selected\" group at the very top <img width=\"601\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-ce4525e9015643822b170873658c2b23f7170d0919eda182cf59f3c7c596c3c3", "text": "const pascalCased = viewType.split(/[^a-z0-9]/ig).map(uppercaseFirstLetter).join(''); view?.search(`@tag:notebookKernel${pascalCased}`); } <ins> } registerAction2(class extends Action2 { constructor() { super({ id: SELECT_KERNEL_ID, category: NOTEBOOK_ACTIONS_CATEGORY, title: { value: localize('notebookActions.selectKernel', \"Select Notebook Kernel\"), original: 'Select Notebook Kernel' }, icon: selectKernelIcon, f1: true, menu: [{ id: MenuId.EditorTitle, when: ContextKeyExpr.and( NOTEBOOK_IS_ACTIVE_EDITOR, ContextKeyExpr.notEquals('config.notebook.globalToolbar', true) ), group: 'navigation', order: -10 }, { id: MenuId.NotebookToolbar, when: ContextKeyExpr.equals('config.notebook.globalToolbar', true), group: 'status', order: -10 }, { id: MenuId.InteractiveToolbar, when: NOTEBOOK_KERNEL_COUNT.notEqualsTo(0), group: 'status', order: -10 }], description: { description: localize('notebookActions.selectKernel.args', \"Notebook Kernel Args\"), args: [ { name: 'kernelInfo', description: 'The kernel info', schema: { 'type': 'object', 'required': ['id', 'extension'], 'properties': { 'id': { 'type': 'string' }, 'extension': { 'type': 'string' }, 'notebookEditorId': { 'type': 'string' } } } } ] }, }); } async run(accessor: ServicesAccessor, context?: KernelQuickPickContext): Promise<boolean> { const notebookKernelService = accessor.get(INotebookKernelService); const editorService = accessor.get(IEditorService); const productService = accessor.get(IProductService); const quickInputService = accessor.get(IQuickInputService); const labelService = accessor.get(ILabelService); const logService = accessor.get(ILogService); const paneCompositeService = accessor.get(IPaneCompositePartService); const extensionWorkbenchService = accessor.get(IExtensionsWorkbenchService); const extensionHostService = accessor.get(IExtensionService); const strategy = new KernelPickerFlatStrategy( notebookKernelService, editorService, productService, quickInputService, labelService, logService, paneCompositeService, extensionWorkbenchService, extensionHostService ); return await strategy.showQuickPick(context); } </ins> }); export class NotebooKernelActionViewItem extends ActionViewItem {", "commid": "vscode_pr_166420"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-5c2d418651da703bf7608c75002d615ed37d2b20a9c520d2e8726ddc4ee9fbcf", "text": "\"scopeName\": \"source.clojure\", \"path\": \"./syntaxes/clojure.tmLanguage.json\" } <del> ] </del> <ins> ], \"configurationDefaults\": { \"[clojure]\": { \"diffEditor.ignoreTrimWhitespace\": false } } </ins> }, \"repository\": { \"type\": \"git\",", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-53c59ee81162977813c414ae2c280570a912d5e2cb478c9c73b17f2d03d70aeb", "text": "\"language\": \"coffeescript\", \"path\": \"./snippets/coffeescript.code-snippets\" } <del> ] </del> <ins> ], \"configurationDefaults\": { \"[coffeescript]\": { \"diffEditor.ignoreTrimWhitespace\": false } } </ins> }, \"repository\": { \"type\": \"git\",", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-7e9bc174b596c846f039d3eae81f8d55e1426aec06bbe6dab79f07839bfddf36", "text": "\"language\": \"fsharp\", \"path\": \"./snippets/fsharp.code-snippets\" } <del> ] </del> <ins> ], \"configurationDefaults\": { \"[fsharp]\": { \"diffEditor.ignoreTrimWhitespace\": false } } </ins> }, \"repository\": { \"type\": \"git\",", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-85fbfe8b6687f72d22f912a48df9617c4e815bf6d0933001b599db61ca047904", "text": "\"configurationDefaults\": { \"[markdown]\": { \"editor.unicodeHighlight.ambiguousCharacters\": false, <del> \"editor.unicodeHighlight.invisibleCharacters\": false </del> <ins> \"editor.unicodeHighlight.invisibleCharacters\": false, \"diffEditor.ignoreTrimWhitespace\": false </ins> } } },", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-4ad0e1509659258d73a62287a1c7dd29b8bde40f3c547a2db807ccd106d6254f", "text": "\"scopeName\": \"text.pug\", \"path\": \"./syntaxes/pug.tmLanguage.json\" } <del> ] </del> <ins> ], \"configurationDefaults\": { \"[jade]\": { \"diffEditor.ignoreTrimWhitespace\": false } } </ins> }, \"repository\": { \"type\": \"git\",", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-d3193ddc91a2b145e307a4cd0df8e6aaac174b6a604e524525b4b767257190ea", "text": "\"scopeName\": \"source.regexp.python\", \"path\": \"./syntaxes/MagicRegExp.tmLanguage.json\" } <del> ] </del> <ins> ], \"configurationDefaults\": { \"[python]\": { \"diffEditor.ignoreTrimWhitespace\": false } } </ins> }, \"scripts\": { \"update-grammar\": \"node ../node_modules/vscode-grammar-updater/bin MagicStack/MagicPython grammars/MagicPython.tmLanguage ./syntaxes/MagicPython.tmLanguage.json grammars/MagicRegExp.tmLanguage ./syntaxes/MagicRegExp.tmLanguage.json\"", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-f77e558da8ced409736b73f8864b15364c02f867caa01ce911b58da192c1611e", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I love that vscode had pylance for python toolchain, this is frustrating when you have a language support but an editor default that does not show syntax error. Please reconsider these samples of scenarios, Python uses indentation to delimit code blocks, which is 2 or 4 leading whitespaces. YAML uses indentation to delimit nesting level, which is also 2 or 4 leading whitespaces. Python is afaik the majority in ML community, see e.g. has 98.0% of python code, both pytorch and tensorflow has a python frontend. YAML has grown popularity comparable to json as configuration tool, e.g. a majority of linter that supports also supports . Ignoring whitespace diff actually leads to syntax error and thus broken code, it is not just a visual difference. <!-- Describe the feature you'd like. --Make this default:\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-8ccc56493cb8e7e4ac308234227b10ede6ec081aad0c55b210b1c3b5ec76951d", "text": "\"[yaml]\": { \"editor.insertSpaces\": true, \"editor.tabSize\": 2, <del> \"editor.autoIndent\": \"advanced\" </del> <ins> \"editor.autoIndent\": \"advanced\", \"diffEditor.ignoreTrimWhitespace\": false </ins> }, \"[dockercompose]\": { \"editor.insertSpaces\": true,", "commid": "vscode_pr_169555"}], "negative_passages": []}
{"query_id": "q-en-vscode-e3bca3f89572df5e7d694e4050f429735c6f8bb501bac471e368639e242ff01a", "query": "Steps to repro: a new instance of VS Code (no extension installed) an ipynb file running a cell out of extension installation suggestion Cell is still \"running\" and cannot stop execution (Expected: Cell execution is stopped or can be stopped by clicking )", "positive_passages": [{"docid": "doc-en-vscode-e34839a1bee8fc568767736d508d74c4f369625675789bef85d37090c980f72f", "text": "} } })); <ins> disposables.add(quickPick.onDidHide(() => { quickPick.dispose(); resolve(false); })); </ins> this._calculdateKernelSources(editor).then(quickPickItems => { quickPick.items = quickPickItems; if (quickPick.items.length > 0) {", "commid": "vscode_pr_167085"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-2ca28915deefc5e824576bb32b7b0d6392f66b1f34b37364da2a166eca1fc0f3", "text": "import { memoize } from 'vs/base/common/decorators'; import { onUnexpectedError } from 'vs/base/common/errors'; import { MarkdownString } from 'vs/base/common/htmlContent'; <del> import { Disposable, dispose, disposeIfDisposable, IDisposable } from 'vs/base/common/lifecycle'; </del> <ins> import { dispose, disposeIfDisposable, IDisposable } from 'vs/base/common/lifecycle'; </ins> import * as env from 'vs/base/common/platform'; import severity from 'vs/base/common/severity'; import { noBreakWhitespace } from 'vs/base/common/strings';", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-7251472a096bff894390f1abd6e225d7f3b5bdcdc85c8681915b278ed3e944c8", "text": "return result; } <del> export class LazyBreakpointEditorContribution extends Disposable implements IBreakpointEditorContribution { private _contrib: IBreakpointEditorContribution | undefined; constructor(editor: ICodeEditor, @IInstantiationService instantiationService: IInstantiationService) { super(); const listener = editor.onDidChangeModel(() => { if (editor.hasModel()) { listener.dispose(); this._contrib = this._register(instantiationService.createInstance(BreakpointEditorContribution, editor)); } }); } showBreakpointWidget(lineNumber: number, column: number | undefined, context?: BreakpointWidgetContext | undefined): void { this._contrib?.showBreakpointWidget(lineNumber, column, context); } closeBreakpointWidget(): void { this._contrib?.closeBreakpointWidget(); } getContextMenuActionsAtPosition(lineNumber: number, model: ITextModel): IAction[] { return this._contrib?.getContextMenuActionsAtPosition(lineNumber, model) ?? []; } } class BreakpointEditorContribution implements IBreakpointEditorContribution { </del> <ins> export class BreakpointEditorContribution implements IBreakpointEditorContribution { </ins> private breakpointHintDecoration: string | null = null; private breakpointWidget: BreakpointWidget | undefined;", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-793660ff2bcc58a9a4acde334617b1a83df82590054ab713e8874065300764a3", "text": "import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { IModelDecorationOptions, IModelDeltaDecoration, OverviewRulerLane, TrackedRangeStickiness } from 'vs/editor/common/model'; import { localize } from 'vs/nls'; <del> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; </del> import { ILogService } from 'vs/platform/log/common/log'; import { registerColor } from 'vs/platform/theme/common/colorRegistry'; import { registerThemingParticipant, themeColorFromId, ThemeIcon } from 'vs/platform/theme/common/themeService';", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-e4435c7dc82ae38f630138b273305c17aa4478c8e88e1dd550815927d2dde7d1", "text": "return result; } <del> export class LazyCallStackEditorContribution extends Disposable { constructor(editor: ICodeEditor, @IInstantiationService instantiationService: IInstantiationService) { super(); const listener = editor.onDidChangeModel(() => { if (editor.hasModel()) { listener.dispose(); this._register(instantiationService.createInstance(CallStackEditorContribution, editor)); } }); } } class CallStackEditorContribution extends Disposable implements IEditorContribution { </del> <ins> export class CallStackEditorContribution extends Disposable implements IEditorContribution { </ins> private decorations = this.editor.createDecorationsCollection(); constructor(", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-ae303fc894cdff0887cfe261fb1984b6be205acbd00fb56582d4d7a666ede83e", "text": "import { Extensions as WorkbenchExtensions, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions'; import { EditorExtensions } from 'vs/workbench/common/editor'; import { Extensions as ViewExtensions, IViewContainersRegistry, IViewsRegistry, ViewContainer, ViewContainerLocation } from 'vs/workbench/common/views'; <del> import { LazyBreakpointEditorContribution } from 'vs/workbench/contrib/debug/browser/breakpointEditorContribution'; </del> <ins> import { BreakpointEditorContribution } from 'vs/workbench/contrib/debug/browser/breakpointEditorContribution'; </ins> import { BreakpointsView } from 'vs/workbench/contrib/debug/browser/breakpointsView'; <del> import { LazyCallStackEditorContribution } from 'vs/workbench/contrib/debug/browser/callStackEditorContribution'; </del> <ins> import { CallStackEditorContribution } from 'vs/workbench/contrib/debug/browser/callStackEditorContribution'; </ins> import { CallStackView } from 'vs/workbench/contrib/debug/browser/callStackView'; import { registerColors } from 'vs/workbench/contrib/debug/browser/debugColors'; import { ADD_CONFIGURATION_ID, CALLSTACK_BOTTOM_ID, CALLSTACK_BOTTOM_LABEL, CALLSTACK_DOWN_ID, CALLSTACK_DOWN_LABEL, CALLSTACK_TOP_ID, CALLSTACK_TOP_LABEL, CALLSTACK_UP_ID, CALLSTACK_UP_LABEL, CONTINUE_ID, CONTINUE_LABEL, COPY_STACK_TRACE_ID, DEBUG_COMMAND_CATEGORY, DEBUG_CONSOLE_QUICK_ACCESS_PREFIX, DEBUG_QUICK_ACCESS_PREFIX, DEBUG_RUN_COMMAND_ID, DEBUG_RUN_LABEL, DEBUG_START_COMMAND_ID, DEBUG_START_LABEL, DISCONNECT_AND_SUSPEND_ID, DISCONNECT_AND_SUSPEND_LABEL, DISCONNECT_ID, DISCONNECT_LABEL, EDIT_EXPRESSION_COMMAND_ID, FOCUS_REPL_ID, JUMP_TO_CURSOR_ID, NEXT_DEBUG_CONSOLE_ID, NEXT_DEBUG_CONSOLE_LABEL, OPEN_LOADED_SCRIPTS_LABEL, PAUSE_ID, PAUSE_LABEL, PREV_DEBUG_CONSOLE_ID, PREV_DEBUG_CONSOLE_LABEL, REMOVE_EXPRESSION_COMMAND_ID, RESTART_FRAME_ID, RESTART_LABEL, RESTART_SESSION_ID, SELECT_AND_START_ID, SELECT_AND_START_LABEL, SELECT_DEBUG_CONSOLE_ID, SELECT_DEBUG_CONSOLE_LABEL, SELECT_DEBUG_SESSION_ID, SELECT_DEBUG_SESSION_LABEL, SET_EXPRESSION_COMMAND_ID, SHOW_LOADED_SCRIPTS_ID, STEP_INTO_ID, STEP_INTO_LABEL, STEP_INTO_TARGET_ID, STEP_INTO_TARGET_LABEL, STEP_OUT_ID, STEP_OUT_LABEL, STEP_OVER_ID, STEP_OVER_LABEL, STOP_ID, STOP_LABEL, TERMINATE_THREAD_ID, TOGGLE_INLINE_BREAKPOINT_ID } from 'vs/workbench/contrib/debug/browser/debugCommands'; import { DebugConsoleQuickAccess } from 'vs/workbench/contrib/debug/browser/debugConsoleQuickAccess'; import { RunToCursorAction, SelectionToReplAction, SelectionToWatchExpressionsAction } from 'vs/workbench/contrib/debug/browser/debugEditorActions'; <del> import { LazyDebugEditorContribution } from 'vs/workbench/contrib/debug/browser/debugEditorContribution'; </del> <ins> import { DebugEditorContribution } from 'vs/workbench/contrib/debug/browser/debugEditorContribution'; </ins> import * as icons from 'vs/workbench/contrib/debug/browser/debugIcons'; import { DebugProgressContribution } from 'vs/workbench/contrib/debug/browser/debugProgress'; import { StartDebugQuickAccessProvider } from 'vs/workbench/contrib/debug/browser/debugQuickAccess';", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-6ee6cd1506edcb605e9a6154267b58ed738cc09d4d4064f9f371170c24919532", "text": "import { ADD_TO_WATCH_ID, BREAK_WHEN_VALUE_CHANGES_ID, BREAK_WHEN_VALUE_IS_ACCESSED_ID, BREAK_WHEN_VALUE_IS_READ_ID, COPY_EVALUATE_PATH_ID, COPY_VALUE_ID, SET_VARIABLE_ID, VariablesView, VIEW_MEMORY_ID } from 'vs/workbench/contrib/debug/browser/variablesView'; import { ADD_WATCH_ID, ADD_WATCH_LABEL, REMOVE_WATCH_EXPRESSIONS_COMMAND_ID, REMOVE_WATCH_EXPRESSIONS_LABEL, WatchExpressionsView } from 'vs/workbench/contrib/debug/browser/watchExpressionsView'; import { WelcomeView } from 'vs/workbench/contrib/debug/browser/welcomeView'; <del> import { BREAKPOINTS_VIEW_ID, BREAKPOINT_EDITOR_CONTRIBUTION_ID, CALLSTACK_VIEW_ID, CONTEXT_BREAKPOINTS_EXIST, CONTEXT_BREAK_WHEN_VALUE_CHANGES_SUPPORTED, CONTEXT_BREAK_WHEN_VALUE_IS_ACCESSED_SUPPORTED, CONTEXT_BREAK_WHEN_VALUE_IS_READ_SUPPORTED, CONTEXT_CALLSTACK_ITEM_TYPE, CONTEXT_CAN_VIEW_MEMORY, CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_HAS_DEBUGGED, CONTEXT_DEBUG_STATE, CONTEXT_DEBUG_UX, CONTEXT_FOCUSED_SESSION_IS_ATTACH, CONTEXT_IN_DEBUG_MODE, CONTEXT_JUMP_TO_CURSOR_SUPPORTED, CONTEXT_LOADED_SCRIPTS_SUPPORTED, CONTEXT_RESTART_FRAME_SUPPORTED, CONTEXT_SET_EXPRESSION_SUPPORTED, CONTEXT_SET_VARIABLE_SUPPORTED, CONTEXT_STACK_FRAME_SUPPORTS_RESTART, CONTEXT_STEP_INTO_TARGETS_SUPPORTED, CONTEXT_SUSPEND_DEBUGGEE_SUPPORTED, CONTEXT_TERMINATE_DEBUGGEE_SUPPORTED, CONTEXT_VARIABLE_EVALUATE_NAME_PRESENT, CONTEXT_VARIABLE_IS_READONLY, CONTEXT_WATCH_ITEM_TYPE, DEBUG_PANEL_ID, DISASSEMBLY_VIEW_ID, EDITOR_CONTRIBUTION_ID, getStateLabel, IDebugService, INTERNAL_CONSOLE_OPTIONS_SCHEMA, LOADED_SCRIPTS_VIEW_ID, REPL_VIEW_ID, State, VARIABLES_VIEW_ID, VIEWLET_ID, WATCH_VIEW_ID } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import { BREAKPOINTS_VIEW_ID, BREAKPOINT_EDITOR_CONTRIBUTION_ID, CALLSTACK_VIEW_ID, CONTEXT_BREAKPOINTS_EXIST, CONTEXT_BREAK_WHEN_VALUE_CHANGES_SUPPORTED, CONTEXT_BREAK_WHEN_VALUE_IS_ACCESSED_SUPPORTED, CONTEXT_BREAK_WHEN_VALUE_IS_READ_SUPPORTED, CONTEXT_CALLSTACK_ITEM_TYPE, CONTEXT_CAN_VIEW_MEMORY, CONTEXT_DEBUGGERS_AVAILABLE, CONTEXT_DEBUG_STATE, CONTEXT_DEBUG_UX, CONTEXT_FOCUSED_SESSION_IS_ATTACH, CONTEXT_HAS_DEBUGGED, CONTEXT_IN_DEBUG_MODE, CONTEXT_JUMP_TO_CURSOR_SUPPORTED, CONTEXT_LOADED_SCRIPTS_SUPPORTED, CONTEXT_RESTART_FRAME_SUPPORTED, CONTEXT_SET_EXPRESSION_SUPPORTED, CONTEXT_SET_VARIABLE_SUPPORTED, CONTEXT_STACK_FRAME_SUPPORTS_RESTART, CONTEXT_STEP_INTO_TARGETS_SUPPORTED, CONTEXT_SUSPEND_DEBUGGEE_SUPPORTED, CONTEXT_TERMINATE_DEBUGGEE_SUPPORTED, CONTEXT_VARIABLE_EVALUATE_NAME_PRESENT, CONTEXT_VARIABLE_IS_READONLY, CONTEXT_WATCH_ITEM_TYPE, DEBUG_PANEL_ID, DISASSEMBLY_VIEW_ID, EDITOR_CONTRIBUTION_ID, getStateLabel, IDebugService, INTERNAL_CONSOLE_OPTIONS_SCHEMA, LOADED_SCRIPTS_VIEW_ID, REPL_VIEW_ID, State, VARIABLES_VIEW_ID, VIEWLET_ID, WATCH_VIEW_ID } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { DebugContentProvider } from 'vs/workbench/contrib/debug/common/debugContentProvider'; import { DebugLifecycle } from 'vs/workbench/contrib/debug/common/debugLifecycle'; import { DisassemblyViewInput } from 'vs/workbench/contrib/debug/common/disassemblyViewInput';", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-bba0e790d0529a232409346d61d36c43c4fb166f59745caa64d1ac9e683b4eaf", "text": "helpEntries: [{ description: nls.localize('tasksQuickAccessHelp', \"Show All Debug Consoles\"), commandId: SELECT_DEBUG_CONSOLE_ID }] }); <del> registerEditorContribution('editor.contrib.callStack', LazyCallStackEditorContribution, EditorContributionInstantiation.Eager); registerEditorContribution(BREAKPOINT_EDITOR_CONTRIBUTION_ID, LazyBreakpointEditorContribution, EditorContributionInstantiation.Eager); registerEditorContribution(EDITOR_CONTRIBUTION_ID, LazyDebugEditorContribution, EditorContributionInstantiation.Eager); </del> <ins> registerEditorContribution('editor.contrib.callStack', CallStackEditorContribution, EditorContributionInstantiation.AfterFirstRender); registerEditorContribution(BREAKPOINT_EDITOR_CONTRIBUTION_ID, BreakpointEditorContribution, EditorContributionInstantiation.AfterFirstRender); registerEditorContribution(EDITOR_CONTRIBUTION_ID, DebugEditorContribution, EditorContributionInstantiation.BeforeFirstInteraction); </ins> const registerDebugCommandPaletteItem = (id: string, title: ICommandActionTitle, when?: ContextKeyExpression, precondition?: ContextKeyExpression) => { MenuRegistry.appendMenuItem(MenuId.CommandPalette, {", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-f877a4a543003f1ccfa4a66bc9514d7d09dc80d5a110324d31ee291a8886c801", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import * as nls from 'vs/nls'; import * as strings from 'vs/base/common/strings'; </del> <ins> import { addDisposableListener } from 'vs/base/browser/dom'; import { DomEmitter } from 'vs/base/browser/event'; import { IKeyboardEvent, StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { distinct, flatten } from 'vs/base/common/arrays'; </ins> import { RunOnceScheduler } from 'vs/base/common/async'; <del> import * as env from 'vs/base/common/platform'; </del> <ins> import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { memoize } from 'vs/base/common/decorators'; import { onUnexpectedExternalError } from 'vs/base/common/errors'; import { Event } from 'vs/base/common/event'; </ins> import { visit } from 'vs/base/common/json'; import { setProperty } from 'vs/base/common/jsonEdit'; <del> import { Constants } from 'vs/base/common/uint'; </del> import { KeyCode } from 'vs/base/common/keyCodes'; <del> import { IKeyboardEvent, StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { InlineValueContext } from 'vs/editor/common/languages'; import { StandardTokenType } from 'vs/editor/common/encodedTokenAttributes'; import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { distinct, flatten } from 'vs/base/common/arrays'; import { onUnexpectedExternalError } from 'vs/base/common/errors'; import { DEFAULT_WORD_REGEXP } from 'vs/editor/common/core/wordHelper'; import { ICodeEditor, IEditorMouseEvent, MouseTargetType, IPartialEditorMouseEvent } from 'vs/editor/browser/editorBrowser'; import { Range } from 'vs/editor/common/core/range'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { ICommandService } from 'vs/platform/commands/common/commands'; import { IDebugEditorContribution, IDebugService, State, IStackFrame, IDebugConfiguration, IExpression, IExceptionInfo, IDebugSession, CONTEXT_EXCEPTION_WIDGET_VISIBLE } from 'vs/workbench/contrib/debug/common/debug'; import { ExceptionWidget } from 'vs/workbench/contrib/debug/browser/exceptionWidget'; import { FloatingClickWidget } from 'vs/workbench/browser/codeeditor'; import { Position } from 'vs/editor/common/core/position'; </del> <ins> import { dispose, IDisposable } from 'vs/base/common/lifecycle'; import { basename } from 'vs/base/common/path'; import * as env from 'vs/base/common/platform'; import * as strings from 'vs/base/common/strings'; import { Constants } from 'vs/base/common/uint'; </ins> import { CoreEditingCommands } from 'vs/editor/browser/coreCommands'; <del> import { memoize } from 'vs/base/common/decorators'; import { IEditorHoverOptions, EditorOption } from 'vs/editor/common/config/editorOptions'; import { DebugHoverWidget } from 'vs/workbench/contrib/debug/browser/debugHover'; import { IModelDeltaDecoration, InjectedTextCursorStops, ITextModel } from 'vs/editor/common/model'; import { Disposable, dispose, IDisposable } from 'vs/base/common/lifecycle'; </del> <ins> import { ICodeEditor, IEditorMouseEvent, IPartialEditorMouseEvent, MouseTargetType } from 'vs/editor/browser/editorBrowser'; import { EditorOption, IEditorHoverOptions } from 'vs/editor/common/config/editorOptions'; </ins> import { EditOperation } from 'vs/editor/common/core/editOperation'; <del> import { basename } from 'vs/base/common/path'; </del> <ins> import { Position } from 'vs/editor/common/core/position'; import { Range } from 'vs/editor/common/core/range'; import { DEFAULT_WORD_REGEXP } from 'vs/editor/common/core/wordHelper'; import { StandardTokenType } from 'vs/editor/common/encodedTokenAttributes'; import { InlineValueContext } from 'vs/editor/common/languages'; import { IModelDeltaDecoration, InjectedTextCursorStops, ITextModel } from 'vs/editor/common/model'; import { IFeatureDebounceInformation, ILanguageFeatureDebounceService } from 'vs/editor/common/services/languageFeatureDebounce'; import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; </ins> import { ModesHoverController } from 'vs/editor/contrib/hover/browser/hover'; import { HoverStartMode, HoverStartSource } from 'vs/editor/contrib/hover/browser/hoverOperation'; <del> import { IHostService } from 'vs/workbench/services/host/browser/host'; import { Event } from 'vs/base/common/event'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; </del> <ins> import * as nls from 'vs/nls'; import { ICommandService } from 'vs/platform/commands/common/commands'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </ins> import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <del> import { Expression } from 'vs/workbench/contrib/debug/common/debugModel'; </del> <ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; </ins> import { registerColor } from 'vs/platform/theme/common/colorRegistry'; <del> import { addDisposableListener } from 'vs/base/browser/dom'; import { DomEmitter } from 'vs/base/browser/event'; import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; import { IFeatureDebounceInformation, ILanguageFeatureDebounceService } from 'vs/editor/common/services/languageFeatureDebounce'; </del> <ins> import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; import { FloatingClickWidget } from 'vs/workbench/browser/codeeditor'; import { DebugHoverWidget } from 'vs/workbench/contrib/debug/browser/debugHover'; import { ExceptionWidget } from 'vs/workbench/contrib/debug/browser/exceptionWidget'; import { CONTEXT_EXCEPTION_WIDGET_VISIBLE, IDebugConfiguration, IDebugEditorContribution, IDebugService, IDebugSession, IExceptionInfo, IExpression, IStackFrame, State } from 'vs/workbench/contrib/debug/common/debug'; import { Expression } from 'vs/workbench/contrib/debug/common/debugModel'; import { IHostService } from 'vs/workbench/services/host/browser/host'; </ins> const MAX_NUM_INLINE_VALUES = 100; // JS Global scope can have 700+ entries. We want to limit ourselves for perf reasons const MAX_INLINE_DECORATOR_LENGTH = 150; // Max string length of each inline decorator when debugging. If exceeded ... is added", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8b01bda7a395f2a0409efc2f6014a2ca5cce38f65d321bde45b3d20cba2901c", "query": "With I went over most editor contributions (50+) and adopted idle value instantiation where I could reason that they would still work correctly. But some editor contributions interact in more complex ways, sometimes with each other, and I wasn't sure. Hence, this issue. I would like to ask that all calls explicitly use . If a contribution uses eager, a reason should be written as a comment next to it. There are multiple options available: Some things to keep in mind when changing an editor contribution to something else than : the contribution will not be created necessarily before a text model is attached. Normally, a contribution is created so early, at a point when the editor has no models. So it is safe for a contribution to simply use to check if the contribution needs to do anything. When being instantiated later, it is possible that the contribution will be created at a time when the editor already has a model, so the contribution should be prepared to deal with that in the ctor. if a contribution needs to be activated via editor events (pasting, typing, mouse events), then most likely you can use . if a contribution is mostly driven by actions or commands, then the contribution will be instantiated when the first action that needs it is executed, so it is safe to use . if a contribution is only driven by actions or commands, it is safe to use . Anyways, here's the remaining list of contributions for which I wasn't sure what would be correct:\nReplacing me with who took over quick pick.", "positive_passages": [{"docid": "doc-en-vscode-26ffef3700679b9383f88f57e08e1dee7c16f7d1fa065e721e372253c734165d", "text": "return result; } <del> export class LazyDebugEditorContribution extends Disposable implements IDebugEditorContribution { private _contrib: IDebugEditorContribution | undefined; constructor(editor: ICodeEditor, @IInstantiationService instantiationService: IInstantiationService) { super(); const listener = editor.onDidChangeModel(() => { if (editor.hasModel()) { listener.dispose(); this._contrib = this._register(instantiationService.createInstance(DebugEditorContribution, editor)); } }); } showHover(position: Position, focus: boolean): Promise<void> { return this._contrib ? this._contrib.showHover(position, focus) : Promise.resolve(); } addLaunchConfiguration(): Promise<any> { return this._contrib ? this._contrib.addLaunchConfiguration() : Promise.resolve(); } closeExceptionWidget(): void { this._contrib?.closeExceptionWidget(); } } </del> export class DebugEditorContribution implements IDebugEditorContribution { private toDispose: IDisposable[];", "commid": "vscode_pr_170270"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8dd226da21c64a0a3cb8c0bbeb77839e471e6e1d494933f19e5c80f112768e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.73.1 (system setup) Commit: Date: 2022-11-09T04:27:29.066Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No OS Version: Windows 11 Steps to Reproduce: a volume in Window that contains a git repo directly in the root of the volume (in my case it is an NFS share hosted on my NAS, but this also happens if it is simply an empty disk drive too) the root directory in VS Code and go to the Source Control window that it shows the diffs, but all the folders contain the volume letter at the beginning of the folders/files and the diff previews don't work !\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI do see this message even though I created the volumes: !\nI think you can capture that in a new issue, but you should be able to open files from the diff if you trust the repo\nYes. You can open files. But since this is I removed my\nauthor-verification-requested's can still be verified by team members (and often are if we don't get responses in time for endgame). It's just a helpful label so the bot can post a message and start the process asking the author to do the verification.\nLooks good! It works for me! Thanks so much for fixing this! :) /verified", "positive_passages": [{"docid": "doc-en-vscode-f6e3f95c1f356706bb7380e83ccae963f48c6175ce07f921352c1b42a73006b7", "text": "import { EventEmitter } from 'events'; import * as iconv from '@vscode/iconv-lite-umd'; import * as filetype from 'file-type'; <del> import { assign, groupBy, IDisposable, toDisposable, dispose, mkdirp, readBytes, detectUnicodeEncoding, Encoding, onceEvent, splitInChunks, Limiter, Versions, isWindows } from './util'; </del> <ins> import { assign, groupBy, IDisposable, toDisposable, dispose, mkdirp, readBytes, detectUnicodeEncoding, Encoding, onceEvent, splitInChunks, Limiter, Versions, isWindows, pathEquals } from './util'; </ins> import { CancellationError, CancellationToken, ConfigurationChangeEvent, LogOutputChannel, Progress, Uri, workspace } from 'vscode'; import { detectEncoding } from './encoding'; import { Ref, RefType, Branch, Remote, ForcePushMode, GitErrorCodes, LogOptions, Change, Status, CommitOptions, RefQuery } from './api/git';", "commid": "vscode_pr_171749"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8dd226da21c64a0a3cb8c0bbeb77839e471e6e1d494933f19e5c80f112768e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.73.1 (system setup) Commit: Date: 2022-11-09T04:27:29.066Z Electron: 19.0.17 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No OS Version: Windows 11 Steps to Reproduce: a volume in Window that contains a git repo directly in the root of the volume (in my case it is an NFS share hosted on my NAS, but this also happens if it is simply an empty disk drive too) the root directory in VS Code and go to the Source Control window that it shows the diffs, but all the folders contain the volume letter at the beginning of the folders/files and the diff previews don't work !\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI do see this message even though I created the volumes: !\nI think you can capture that in a new issue, but you should be able to open files from the diff if you trust the repo\nYes. You can open files. But since this is I removed my\nauthor-verification-requested's can still be verified by team members (and often are if we don't get responses in time for endgame). It's just a helpful label so the bot can post a message and start the process asking the author to do the verification.\nLooks good! It works for me! Thanks so much for fixing this! :) /verified", "positive_passages": [{"docid": "doc-en-vscode-2db8fb1ef5f87085e22f16cdd940970cfefdb8bd6bdcd8e764fc6d257a6f69dc", "text": "), ); if (networkPath !== undefined) { <ins> // If the repository is at the root of the mapped drive then we // have to append `` (ex: D:) otherwise the path is not valid. const isDriveRoot = pathEquals(repoUri.fsPath, networkPath); </ins> return path.normalize( repoUri.fsPath.replace( networkPath, <del> `${letter.toLowerCase()}:${networkPath.endsWith('') ? '' : ''}` </del> <ins> `${letter.toLowerCase()}:${isDriveRoot || networkPath.endsWith('') ? '' : ''}` </ins> ), ); }", "commid": "vscode_pr_171749"}], "negative_passages": []}
{"query_id": "q-en-vscode-12bfae9c4d4eec713a1af163345aa0db82529ad30805cc072ec8862832ed9906", "query": "I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc\nSeems like this might have been a regression at some point. for relocating it back near the input.\nI like where it is now. To me it says \"the results are still populating\".\nThe reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)", "positive_passages": [{"docid": "doc-en-vscode-f916e54019c8f3075bdc40b158f161a163ba75e2d0ee04dca75d81699943ea13", "text": ".quick-input-titlebar { display: flex; align-items: center; <ins> border-top-left-radius: 5px; /* match border radius of quick input widget */ border-top-right-radius: 5px; </ins> } .quick-input-left-action-bar {", "commid": "vscode_pr_169039"}], "negative_passages": []}
{"query_id": "q-en-vscode-12bfae9c4d4eec713a1af163345aa0db82529ad30805cc072ec8862832ed9906", "query": "I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc\nSeems like this might have been a regression at some point. for relocating it back near the input.\nI like where it is now. To me it says \"the results are still populating\".\nThe reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)", "positive_passages": [{"docid": "doc-en-vscode-d36e4b1a7ead772623e97e58675b464535cd471188a2ef23e0367ed6769dc9e3", "text": ".quick-input-header { display: flex; <del> padding: 8px 6px 0px 6px; margin-bottom: -2px; </del> <ins> padding: 8px 6px 6px 6px; </ins> } .quick-input-widget.hidden-input .quick-input-header {", "commid": "vscode_pr_169039"}], "negative_passages": []}
{"query_id": "q-en-vscode-12bfae9c4d4eec713a1af163345aa0db82529ad30805cc072ec8862832ed9906", "query": "I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc\nSeems like this might have been a regression at some point. for relocating it back near the input.\nI like where it is now. To me it says \"the results are still populating\".\nThe reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)", "positive_passages": [{"docid": "doc-en-vscode-f7534d15aad921a2b48cbde11f4e56d2cfcfd4d85ed24d382fa3f4657fedde9f", "text": ".quick-input-list { line-height: 22px; <del> margin-top: 6px; padding: 1px; </del> } .quick-input-widget.hidden-input .quick-input-list {", "commid": "vscode_pr_169039"}], "negative_passages": []}
{"query_id": "q-en-vscode-12bfae9c4d4eec713a1af163345aa0db82529ad30805cc072ec8862832ed9906", "query": "I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc\nSeems like this might have been a regression at some point. for relocating it back near the input.\nI like where it is now. To me it says \"the results are still populating\".\nThe reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)", "positive_passages": [{"docid": "doc-en-vscode-fd6a17e38c0229fc578f32676a79efd7fdfe41b23162a403fc5d284015338e4e", "text": "const message = dom.append(extraContainer, $(`#${this.idPrefix}message.quick-input-message`)); <ins> const progressBar = new ProgressBar(container, this.styles.progressBar); progressBar.getContainer().classList.add('quick-input-progress'); </ins> const list = this._register(new QuickInputList(container, this.idPrefix + 'list', this.options)); this._register(list.onChangedAllVisibleChecked(checked => { checkAll.checked = checked;", "commid": "vscode_pr_169039"}], "negative_passages": []}
{"query_id": "q-en-vscode-12bfae9c4d4eec713a1af163345aa0db82529ad30805cc072ec8862832ed9906", "query": "I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc\nSeems like this might have been a regression at some point. for relocating it back near the input.\nI like where it is now. To me it says \"the results are still populating\".\nThe reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)", "positive_passages": [{"docid": "doc-en-vscode-4b0aa7b6335e1d349e4706a6b46d88937dc21cf94c4413b7eeabd4f11e034f85", "text": "} })); <del> const progressBar = new ProgressBar(container, this.styles.progressBar); progressBar.getContainer().classList.add('quick-input-progress'); </del> const focusTracker = dom.trackFocus(container); this._register(focusTracker); this._register(dom.addDisposableListener(container, dom.EventType.FOCUS, e => {", "commid": "vscode_pr_169039"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-f052e13ebf65e00b97240a6bd38fe94cc9305267a89b44447494d4d35ec828fd", "text": "class GitHubGistProfileContentHandler implements vscode.ProfileContentHandler { readonly name = vscode.l10n.t('GitHub'); <ins> readonly description = vscode.l10n.t('gist'); </ins> private _octokit: Promise<Octokit> | undefined; private getOctokit(): Promise<Octokit> {", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-62b3d18304d85150c41055099c59a916994daa3aa301101cfe206feef3ee4750", "text": "this.proxy = context.getProxy(ExtHostContext.ExtHostProfileContentHandlers); } <del> async $registerProfileContentHandler(id: string, name: string, extensionId: string): Promise<void> { </del> <ins> async $registerProfileContentHandler(id: string, name: string, description: string | undefined, extensionId: string): Promise<void> { </ins> this.registeredHandlers.set(id, this.userDataProfileImportExportService.registerProfileContentHandler(id, { name, <ins> description, </ins> extensionId, saveProfile: async (name: string, content: string, token: CancellationToken) => { const result = await this.proxy.$saveProfile(id, name, content, token);", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-7d5486742b84c6cf7d9dab530700e8c415ee94c0ac6605f0411a7ab909b5b046", "text": "} export interface MainThreadProfileContentHandlersShape { <del> $registerProfileContentHandler(id: string, name: string, extensionId: string): Promise<void>; </del> <ins> $registerProfileContentHandler(id: string, name: string, description: string | undefined, extensionId: string): Promise<void>; </ins> $unregisterProfileContentHandler(id: string): Promise<void>; }", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-22f844f38080cc34c8523d379623e08ac728c097874798e6c89f743dcabdafc7", "text": "} this.handlers.set(id, handler); <del> this.proxy.$registerProfileContentHandler(id, handler.name, extension.identifier.value); </del> <ins> this.proxy.$registerProfileContentHandler(id, handler.name, handler.description, extension.identifier.value); </ins> return toDisposable(() => { this.handlers.delete(id);", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-5db0443021811f811583757a4b10d72af597148b6944f524251fca5194c3254d", "text": "if (this.profileContentHandlers.size === 1) { return this.profileContentHandlers.values().next().value; } <del> const linkHandlers: { id: string; label: string }[] = []; const fileHandlers: { id: string; label: string }[] = []; for (const [id, profileContentHandler] of this.profileContentHandlers) { if (profileContentHandler.extensionId) { linkHandlers.push({ id, label: profileContentHandler.name }); } else { fileHandlers.push({ id, label: profileContentHandler.name }); } } </del> const options: QuickPickItem[] = []; <del> if (linkHandlers.length) { options.push({ label: localize('link', \"link\"), type: 'separator' }); options.push(...linkHandlers); } if (fileHandlers.length) { options.push({ label: localize('file', \"file\"), type: 'separator' }); options.push(...fileHandlers); </del> <ins> for (const [id, profileContentHandler] of this.profileContentHandlers) { options.push({ id, label: profileContentHandler.name, description: profileContentHandler.description }); </ins> } <del> const result = await this.quickInputService.pick(options, </del> <ins> const result = await this.quickInputService.pick(options.reverse(), </ins> { title: localize('select profile content handler', \"Export '{0}' profile as...\", name), hideInput: true", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-6ad0d7bead61ba79bcb0e04788a0d9ecc8f921c557b0d1701f2c4c4315b5c273", "text": "class FileUserDataProfileContentHandler implements IUserDataProfileContentHandler { readonly name = localize('local', \"Local\"); <ins> readonly description = localize('file', \"file\"); </ins> constructor( @IFileDialogService private readonly fileDialogService: IFileDialogService,", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-613e749f9e3a8f97432ab8108b54700d023cad008bbd76fdf29bd2f4832f7427", "text": "export interface IUserDataProfileContentHandler { readonly name: string; <ins> readonly description?: string; </ins> readonly extensionId?: string; saveProfile(name: string, content: string, token: CancellationToken): Promise<ISaveProfileResult | null>; readProfile(idOrUri: string | URI, token: CancellationToken): Promise<string | null>;", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2f991c13850fa839e51c8fbb7f9e068c6d748d2fb5ac1c4455ead84ccba22f8", "query": "Testing In the export flow, there's the step to \"Export as...\". The options are \"File\" and \"Github\" <img width=\"615\" alt=\"image\" src=\"https://user-\"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say \"Github Gist\" instead, or \"Export to\" instead of \"Export as\". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.\nIt was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.\nGood feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: \"GitHub\" and then \"gist\" as the description a bit to the right - QuickPick should support this.\nThere was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.\nI think adding as description would be good\n!\nLovely, tried it out. Verified.", "positive_passages": [{"docid": "doc-en-vscode-ee4dc25324e428bc4b429443755587b117bff2b8f1d577829536afc967d675fd", "text": "export interface ProfileContentHandler { readonly name: string; <ins> readonly description?: string; </ins> saveProfile(name: string, content: string, token: CancellationToken): Thenable<{ readonly id: string; readonly link: Uri } | null>; readProfile(idOrUri: string | Uri, token: CancellationToken): Thenable<string | null>; }", "commid": "vscode_pr_170110"}], "negative_passages": []}
{"query_id": "q-en-vscode-4fbb86983cf5a3247a1f2a66aa87d04290ba0a96fd76d7a192175fae85a86d76", "query": "My impression of the slowness that mentioned In stable and insiders, I think the run button shows up at about the same time. Around 7-9s from \"reload window\" to the run button appearing, hard to tell whether stable is slightly faster. But after it appears, and the preferred kernel has been discovered, I see \"Discovering Kernels\" for another 5s or more, which could lead to an impression of slowness if the user doesn't realize they can go ahead and run a cell at this point. Originally posted by in\n<img width=\"183\" alt=\"image\" src=\"https://user-\"When there is already a selected kernel, we should show the kernel name and a spinner if there are pending detection tasks.", "positive_passages": [{"docid": "doc-en-vscode-bac0c21232dbd4cac4ac33160f9313b7b3f87ca6273edb26b446dba651bcfd9f", "text": "static updateKernelStatusAction(notebook: NotebookTextModel, action: IAction, notebookKernelService: INotebookKernelService, scopedContextKeyService?: IContextKeyService) { const detectionTasks = notebookKernelService.getKernelDetectionTasks(notebook); if (detectionTasks.length) { <ins> const info = notebookKernelService.getMatchingKernel(notebook); </ins> action.enabled = true; <del> action.label = localize('kernels.detecting', \"Detecting Kernels\"); </del> action.class = ThemeIcon.asClassName(ThemeIcon.modify(executingStateIcon, 'spin')); <ins> if (info.selected) { action.label = info.selected.label; const kernelInfo = info.selected.description ?? info.selected.detail; action.tooltip = kernelInfo ? localize('kernels.selectedKernelAndKernelDetectionRunning', \"Selected Kernel: {0} (Kernel Detection Tasks Running)\", kernelInfo) : localize('kernels.detecting', \"Detecting Kernels\"); } else { action.label = localize('kernels.detecting', \"Detecting Kernels\"); } </ins> return; }", "commid": "vscode_pr_167761"}], "negative_passages": []}
{"query_id": "q-en-vscode-4fbb86983cf5a3247a1f2a66aa87d04290ba0a96fd76d7a192175fae85a86d76", "query": "My impression of the slowness that mentioned In stable and insiders, I think the run button shows up at about the same time. Around 7-9s from \"reload window\" to the run button appearing, hard to tell whether stable is slightly faster. But after it appears, and the preferred kernel has been discovered, I see \"Discovering Kernels\" for another 5s or more, which could lead to an impression of slowness if the user doesn't realize they can go ahead and run a cell at this point. Originally posted by in\n<img width=\"183\" alt=\"image\" src=\"https://user-\"When there is already a selected kernel, we should show the kernel name and a spinner if there are pending detection tasks.", "positive_passages": [{"docid": "doc-en-vscode-092ff5ba0135951ac92df5a834878be4f6691a9d29d4c88e66dcab3167147240", "text": "static updateKernelStatusAction(notebook: NotebookTextModel, action: IAction, notebookKernelService: INotebookKernelService) { const detectionTasks = notebookKernelService.getKernelDetectionTasks(notebook); if (detectionTasks.length) { <ins> const info = notebookKernelService.getMatchingKernel(notebook); </ins> action.enabled = true; <del> action.label = localize('kernels.detecting', \"Detecting Kernels\"); </del> action.class = ThemeIcon.asClassName(ThemeIcon.modify(executingStateIcon, 'spin')); <ins> if (info.selected) { action.label = info.selected.label; const kernelInfo = info.selected.description ?? info.selected.detail; action.tooltip = kernelInfo ? localize('kernels.selectedKernelAndKernelDetectionRunning', \"Selected Kernel: {0} (Kernel Detection Tasks Running)\", kernelInfo) : localize('kernels.detecting', \"Detecting Kernels\"); } else { action.label = localize('kernels.detecting', \"Detecting Kernels\"); } </ins> return; }", "commid": "vscode_pr_167761"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-6c33e1fb746c5fb7f96bf00a77f1861a19bdfd47e6a6ace29b05003810dfeab9", "text": "protected readonly _commandService: ICommandService ) { } <del> async showQuickPick(editor: IActiveNotebookEditor, wantedId?: string): Promise<boolean> { </del> <ins> async showQuickPick(editor: IActiveNotebookEditor, wantedId?: string, skipAutoRun?: boolean): Promise<boolean> { </ins> const notebook = editor.textModel; const scopedContextKeyService = editor.scopedContextKeyService; const matchResult = this._getMatchingResult(notebook);", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-857e0d45ad4e5cc81d2d1fb4bd7f04f80dd22814f9218291b62b3a4d1f771d39", "text": "const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>(); const quickPickItems = this._getKernelPickerQuickPickItems(notebook, matchResult, this._notebookKernelService, scopedContextKeyService); <del> if (quickPickItems.length === 1 && supportAutoRun(quickPickItems[0])) { return await this._handleQuickPick(editor, quickPickItems[0]); </del> <ins> if (quickPickItems.length === 1 && supportAutoRun(quickPickItems[0]) && !skipAutoRun) { return await this._handleQuickPick(editor, quickPickItems[0], quickPickItems as KernelQuickPickItem[]); </ins> } quickPick.items = quickPickItems;", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-11e0fd08eae939a3cca8af554866eff3124cf590e06c31869d1b82cc1e3480c6", "text": "quickPick.activeItems = activeItems; }, this); <del> const pick = await new Promise<KernelQuickPickItem | undefined>((resolve, reject) => { </del> <ins> const pick = await new Promise<{ selected: KernelQuickPickItem | undefined; items: KernelQuickPickItem[] }>((resolve, reject) => { </ins> quickPick.onDidAccept(() => { const item = quickPick.selectedItems[0]; if (item) { <del> resolve(item); </del> <ins> resolve({ selected: item, items: quickPick.items as KernelQuickPickItem[] }); </ins> } else { <del> resolve(undefined); </del> <ins> resolve({ selected: undefined, items: quickPick.items as KernelQuickPickItem[] }); </ins> } quickPick.hide();", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-f64bfce03ac17f4aea2caa279dfba1b41474e9a502c4ddb6cc5a24f69823b716", "text": "kernelDetectionTaskListener.dispose(); kernelChangeEventListener.dispose(); quickPick.dispose(); <del> resolve(undefined); </del> <ins> resolve({ selected: undefined, items: quickPick.items as KernelQuickPickItem[] }); </ins> }); quickPick.show(); }); <del> if (pick) { return await this._handleQuickPick(editor, pick); </del> <ins> if (pick.selected) { return await this._handleQuickPick(editor, pick.selected, pick.items); </ins> } return false;", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-89a76471e3e1e2dd8843f5e018ba1a519a01da86f872633f34a38902ee590e7c", "text": "scopedContextKeyService: IContextKeyService ): QuickPickInput<KernelQuickPickItem>[]; <del> protected async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem) { </del> <ins> protected async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem, quickPickItems: KernelQuickPickItem[]): Promise<boolean> { </ins> if (isKernelPick(pick)) { const newKernel = pick.kernel; this._selecteKernel(editor.textModel, newKernel);", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-daed1851a4459397dc2ab09d8d7dd1f0a55b658a3042e8de35f95e4bece45d89", "text": "}; } <del> protected override async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem): Promise<boolean> { </del> <ins> protected override async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem, items: KernelQuickPickItem[]): Promise<boolean> { </ins> if (pick.id === 'selectAnother') { <del> return this.displaySelectAnotherQuickPick(editor); </del> <ins> return this.displaySelectAnotherQuickPick(editor, items.length === 1 && items[0] === pick); </ins> } <del> return super._handleQuickPick(editor, pick); </del> <ins> return super._handleQuickPick(editor, pick, items); </ins> } <del> private async displaySelectAnotherQuickPick(editor: IActiveNotebookEditor) { </del> <ins> private async displaySelectAnotherQuickPick(editor: IActiveNotebookEditor, kernelListEmpty: boolean) { </ins> const notebook: NotebookTextModel = editor.textModel; const disposables = new DisposableStore(); return new Promise<boolean>(resolve => { // select from kernel sources const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>(); <del> quickPick.title = localize('selectAnotherKernel', \"Select Another Kernel\"); </del> <ins> quickPick.title = kernelListEmpty ? localize('select', \"Select Kernel\") : localize('selectAnotherKernel', \"Select Another Kernel\"); </ins> quickPick.busy = true; quickPick.buttons = [this._quickInputService.backButton]; quickPick.show();", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-70b5b84770c61e14336f9e58266c1e2575e856a8893c1ca8020e88b1ad3a3dab", "text": "disposables.add(quickPick.onDidTriggerButton(button => { if (button === this._quickInputService.backButton) { quickPick.hide(); <del> resolve(this.showQuickPick(editor)); </del> <ins> resolve(this.showQuickPick(editor, undefined, true)); </ins> } })); disposables.add(quickPick.onDidAccept(async () => {", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b3fa76f3edcfe637cbd34af81529848b8ee6199e63125b3166b0f0d50cc5afd2", "query": "Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again\nWas trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !", "positive_passages": [{"docid": "doc-en-vscode-6dbf305db594f7f294b2963b1ded459762b2873d5c2b4d003b838814853d9382", "text": "} resolve(true); } else { <del> return resolve(this.displaySelectAnotherQuickPick(editor)); </del> <ins> return resolve(this.displaySelectAnotherQuickPick(editor, false)); </ins> } } else if (isKernelPick(quickPick.selectedItems[0])) { await this._selecteKernel(notebook, quickPick.selectedItems[0].kernel);", "commid": "vscode_pr_169589"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-2409984ea30b81a42046e360c7af45ec220c19433a344e8d1a91ccdd8992dba6", "text": "const allRepositoriesLabel = l10n.t('All Repositories'); const allRepositoriesQuickPickItem: QuickPickItem = { label: allRepositoriesLabel }; <del> const repositoriesQuickPickItems: QuickPickItem[] = Array.from(this.model.unsafeRepositories.values()).sort().map(r => new UnsafeRepositoryItem(r)); </del> <ins> const repositoriesQuickPickItems: QuickPickItem[] = Array.from(this.model.unsafeRepositories.keys()).sort().map(r => new UnsafeRepositoryItem(r)); </ins> quickpick.items = this.model.unsafeRepositories.size === 1 ? [...repositoriesQuickPickItems] : [...repositoriesQuickPickItems, { label: '', kind: QuickPickItemKind.Separator }, allRepositoriesQuickPickItem];", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-5bdfa6134661896d059f294e319772fee5773a5fa777a498826971097f6231cd", "text": "if (repositoryItem.label === allRepositoriesLabel) { // All Repositories <del> unsafeRepositories.push(...this.model.unsafeRepositories.values()); </del> <ins> unsafeRepositories.push(...this.model.unsafeRepositories.keys()); </ins> } else { // One Repository unsafeRepositories.push((repositoryItem as UnsafeRepositoryItem).path);", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-834e25bc80afb6cb3810e197b84530b693a40fd90994c07338ba78e914a8baae", "text": "for (const unsafeRepository of unsafeRepositories) { // Mark as Safe <del> await this.git.addSafeDirectory(unsafeRepository); </del> <ins> await this.git.addSafeDirectory(this.model.unsafeRepositories.get(unsafeRepository)!); </ins> // Open Repository await this.model.openRepository(unsafeRepository);", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-70c32ab2e1b14d7511e47b36a3ecb7c0e6243fbcf04d61b796fe293770051d4d", "text": "} async addSafeDirectory(repositoryPath: string): Promise<void> { <del> // safe.directory only supports paths with `/` as separator repositoryPath = repositoryPath.replaceAll('', '/'); </del> await this.exec(repositoryPath, ['config', '--global', '--add', 'safe.directory', repositoryPath]); return; }", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-5844416cdb3a37d630a86982ba81a19e7f8a74ae799f2c8a601816b97af89076", "text": "constructor(public readonly repository: Repository, public readonly index: number) { } } <del> class UnsafeRepositorySet extends Set<string> { </del> <ins> /** * Key   - normalized path used in user interface * Value - path extracted from the output of the `git status` command *         used when calling `git config --global --add safe.directory` */ class UnsafeRepositoryMap extends Map<string, string> { </ins> constructor() { super(); this.updateContextKey(); } <del> override add(value: string): this { const result = super.add(value); </del> <ins> override set(key: string, value: string): this { const result = super.set(key, value); </ins> this.updateContextKey(); return result; } <del> override delete(value: string): boolean { const result = super.delete(value); </del> <ins> override delete(key: string): boolean { const result = super.delete(key); </ins> this.updateContextKey(); return result;", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-4ae6f242918a47f5454d517e3b26809d450b9dffde405c5b718cebaa891bff84", "text": "private showRepoOnHomeDriveRootWarning = true; private pushErrorHandlers = new Set<PushErrorHandler>(); <del> private _unsafeRepositories = new UnsafeRepositorySet(); get unsafeRepositories(): Set<string> { </del> <ins> private _unsafeRepositories = new UnsafeRepositoryMap(); get unsafeRepositories(): Map<string, string> { </ins> return this._unsafeRepositories; }", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-c897d74a4d7d935eec01ae1d9e1165591170364c6c9e87ccdd1bb333bda3f095", "text": "repository.status(); // do not await this, we want SCM to know about the repo asap } catch (ex) { // Handle unsafe repository <del> const match = /^fatal: detected dubious ownership in repository at '([^']+)'$/m.exec(ex.stderr); if (match && match.length === 2) { </del> <ins> const match = /^fatal: detected dubious ownership in repository at '([^']+)'[sS]*git config --global --add safe.directory '?([^'n]+)'?$/m.exec(ex.stderr); if (match && match.length === 3) { </ins> const unsafeRepositoryPath = path.normalize(match[1]); this.logger.trace(`Unsafe repository: ${unsafeRepositoryPath}`);", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b7fc99e331aa661d93a1cd429f915f23bbab78bed337add2356ec31afd5970ac", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.\ndo you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!\nHere is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(\nthank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.\nYou might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.\ncould you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?\nDepends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.\nthanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.", "positive_passages": [{"docid": "doc-en-vscode-b5f606dc3c79be416c63d0cf706482728a9d7cf7b731fb4715f7c228104529d2", "text": "this.showUnsafeRepositoryNotification(); } <del> this._unsafeRepositories.add(unsafeRepositoryPath); </del> <ins> this._unsafeRepositories.set(unsafeRepositoryPath, match[2]); </ins> return; }", "commid": "vscode_pr_168568"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5fef431cd83e674fb85525ab4ea866ef7d18599ee4c7e4de2bdd58debf18267", "query": "Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nMaybe related to /assign\nThis was an intentional change to disable the animation when typing/deleting. See\nokay, that makes perfect sense. closing.\nAlso having the same issue. Has there been a fix?\nWe have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?\nYes, I love the animating when typing.\nA good common ground could be that it becomes a setting to also have the caret animated while typing\nI've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled\nthank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.\nsee which is already fixed.", "positive_passages": [{"docid": "doc-en-vscode-20bd41d1fabcffef8025a941b97be3d9ceccfdbd93645eee634a7766039180cc", "text": "registerSimpleEditorSettingMigration('autoIndent', [[false, 'advanced'], [true, 'full']]); registerSimpleEditorSettingMigration('matchBrackets', [[true, 'always'], [false, 'never']]); registerSimpleEditorSettingMigration('renderFinalNewline', [[true, 'on'], [false, 'off']]); <ins> registerSimpleEditorSettingMigration('cursorSmoothCaretAnimation', [[true, 'on'], [false, 'off']]); </ins> registerEditorSettingMigration('autoClosingBrackets', (value, read, write) => { if (value === false) {", "commid": "vscode_pr_169113"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5fef431cd83e674fb85525ab4ea866ef7d18599ee4c7e4de2bdd58debf18267", "query": "Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nMaybe related to /assign\nThis was an intentional change to disable the animation when typing/deleting. See\nokay, that makes perfect sense. closing.\nAlso having the same issue. Has there been a fix?\nWe have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?\nYes, I love the animating when typing.\nA good common ground could be that it becomes a setting to also have the caret animated while typing\nI've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled\nthank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.\nsee which is already fixed.", "positive_passages": [{"docid": "doc-en-vscode-c2bcbeebfbf9eba9f4a2add54c9e06d723f1e4ae57e86bbff59a4824f1ad7094", "text": "private _readOnly: boolean; private _cursorBlinking: TextEditorCursorBlinkingStyle; private _cursorStyle: TextEditorCursorStyle; <del> private _cursorSmoothCaretAnimation: boolean; </del> <ins> private _cursorSmoothCaretAnimation: 'off' | 'explicit' | 'on'; </ins> private _selectionIsEmpty: boolean; private _isComposingInput: boolean;", "commid": "vscode_pr_169113"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5fef431cd83e674fb85525ab4ea866ef7d18599ee4c7e4de2bdd58debf18267", "query": "Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nMaybe related to /assign\nThis was an intentional change to disable the animation when typing/deleting. See\nokay, that makes perfect sense. closing.\nAlso having the same issue. Has there been a fix?\nWe have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?\nYes, I love the animating when typing.\nA good common ground could be that it becomes a setting to also have the caret animated while typing\nI've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled\nthank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.\nsee which is already fixed.", "positive_passages": [{"docid": "doc-en-vscode-9189211df9da4d00a89ebb13af92a7b7680b37c4d1fe83debfa9c57335382037", "text": "private _onCursorPositionChanged(position: Position, secondaryPositions: Position[], reason: CursorChangeReason): void { const pauseAnimation = ( this._secondaryCursors.length !== secondaryPositions.length <del> || reason !== CursorChangeReason.Explicit </del> <ins> || (this._cursorSmoothCaretAnimation === 'explicit' && reason !== CursorChangeReason.Explicit) </ins> ); this._primaryCursor.onCursorPositionChanged(position, pauseAnimation); this._updateBlinking();", "commid": "vscode_pr_169113"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5fef431cd83e674fb85525ab4ea866ef7d18599ee4c7e4de2bdd58debf18267", "query": "Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nMaybe related to /assign\nThis was an intentional change to disable the animation when typing/deleting. See\nokay, that makes perfect sense. closing.\nAlso having the same issue. Has there been a fix?\nWe have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?\nYes, I love the animating when typing.\nA good common ground could be that it becomes a setting to also have the caret animated while typing\nI've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled\nthank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.\nsee which is already fixed.", "positive_passages": [{"docid": "doc-en-vscode-cb1b935465490cc4b04b9e3f0a63880fca3beef67c4a3bc91735ac70a73af19e", "text": "_cursorBlinkingStyleFromString, { description: nls.localize('cursorBlinking', \"Control the cursor animation style.\") } )), <del> cursorSmoothCaretAnimation: register(new EditorBooleanOption( EditorOption.cursorSmoothCaretAnimation, 'cursorSmoothCaretAnimation', false, { description: nls.localize('cursorSmoothCaretAnimation', \"Controls whether the smooth caret animation should be enabled.\") } </del> <ins> cursorSmoothCaretAnimation: register(new EditorStringEnumOption( EditorOption.cursorSmoothCaretAnimation, 'cursorSmoothCaretAnimation', 'off' as 'off' | 'explicit' | 'on', ['off', 'explicit', 'on'] as const, { enumDescriptions: [ nls.localize('cursorSmoothCaretAnimation.off', \"Smooth caret animation is disabled.\"), nls.localize('cursorSmoothCaretAnimation.explicit', \"Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture.\"), nls.localize('cursorSmoothCaretAnimation.on', \"Smooth caret animation is always enabled.\") ], description: nls.localize('cursorSmoothCaretAnimation', \"Controls whether the smooth caret animation should be enabled.\") } </ins> )), cursorStyle: register(new EditorEnumOption( EditorOption.cursorStyle, 'cursorStyle',", "commid": "vscode_pr_169113"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5fef431cd83e674fb85525ab4ea866ef7d18599ee4c7e4de2bdd58debf18267", "query": "Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nMaybe related to /assign\nThis was an intentional change to disable the animation when typing/deleting. See\nokay, that makes perfect sense. closing.\nAlso having the same issue. Has there been a fix?\nWe have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?\nYes, I love the animating when typing.\nA good common ground could be that it becomes a setting to also have the caret animated while typing\nI've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled\nthank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.\nsee which is already fixed.", "positive_passages": [{"docid": "doc-en-vscode-f47f0ce2e098cde92a5790df62d1e7875c78e383ae1ad72bab31da896a213610", "text": "mouseStyle?: 'text' | 'default' | 'copy'; /** * Enable smooth caret animation. <del> * Defaults to false. </del> <ins> * Defaults to 'off'. </ins> */ <del> cursorSmoothCaretAnimation?: boolean; </del> <ins> cursorSmoothCaretAnimation?: 'off' | 'explicit' | 'on'; </ins> /** * Control the cursor style, either 'block' or 'line'. * Defaults to 'line'.", "commid": "vscode_pr_169113"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5fef431cd83e674fb85525ab4ea866ef7d18599ee4c7e4de2bdd58debf18267", "query": "Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nMaybe related to /assign\nThis was an intentional change to disable the animation when typing/deleting. See\nokay, that makes perfect sense. closing.\nAlso having the same issue. Has there been a fix?\nWe have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?\nYes, I love the animating when typing.\nA good common ground could be that it becomes a setting to also have the caret animated while typing\nI've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled\nthank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.\nsee which is already fixed.", "positive_passages": [{"docid": "doc-en-vscode-7eb8f2be72e4c58657a86a53395eba3a2b28e3b5715ba90ab3bef696e39ce67f", "text": "contextmenu: IEditorOption<EditorOption.contextmenu, boolean>; copyWithSyntaxHighlighting: IEditorOption<EditorOption.copyWithSyntaxHighlighting, boolean>; cursorBlinking: IEditorOption<EditorOption.cursorBlinking, TextEditorCursorBlinkingStyle>; <del> cursorSmoothCaretAnimation: IEditorOption<EditorOption.cursorSmoothCaretAnimation, boolean>; </del> <ins> cursorSmoothCaretAnimation: IEditorOption<EditorOption.cursorSmoothCaretAnimation, 'on' | 'off' | 'explicit'>; </ins> cursorStyle: IEditorOption<EditorOption.cursorStyle, TextEditorCursorStyle>; cursorSurroundingLines: IEditorOption<EditorOption.cursorSurroundingLines, number>; cursorSurroundingLinesStyle: IEditorOption<EditorOption.cursorSurroundingLinesStyle, 'default' | 'all'>;", "commid": "vscode_pr_169113"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c1f822479559b7df7ccfd7f3c06f1a7b6be18df9bfa92424aa9dfb14e2e32a2", "query": "We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item\nAfter discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -\nLooks great -verified", "positive_passages": [{"docid": "doc-en-vscode-9c965be5584133f0fe3f42751de13d6bca2559fb5fac5ab835de78ace1af587b", "text": "} private get profilesVisibilityPreference(): boolean { <del> return this.userDataProfilesService.isEnabled() && this.storageService.getBoolean(ProfilesActivityActionViewItem.PROFILES_VISIBILITY_PREFERENCE_KEY, StorageScope.PROFILE, this.userDataProfilesService.profiles.length > 1); </del> <ins> return this.userDataProfilesService.isEnabled() && this.storageService.getBoolean(ProfilesActivityActionViewItem.PROFILES_VISIBILITY_PREFERENCE_KEY, StorageScope.PROFILE, true); </ins> } private set profilesVisibilityPreference(value: boolean) {", "commid": "vscode_pr_169735"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c1f822479559b7df7ccfd7f3c06f1a7b6be18df9bfa92424aa9dfb14e2e32a2", "query": "We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item\nAfter discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -\nLooks great -verified", "positive_passages": [{"docid": "doc-en-vscode-704b0b9d5bda958d023d458b0c89b626cb96e14cbd6013dc4949e37112c6b517", "text": "import { ContextKeyExpr, IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IProductService } from 'vs/platform/product/common/productService'; import { Registry } from 'vs/platform/registry/common/platform'; <del> import { IUserDataProfilesService, PROFILES_ENABLEMENT_CONFIG } from 'vs/platform/userDataProfile/common/userDataProfile'; </del> <ins> import { IUserDataProfile, IUserDataProfilesService, PROFILES_ENABLEMENT_CONFIG } from 'vs/platform/userDataProfile/common/userDataProfile'; </ins> import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { RenameProfileAction } from 'vs/workbench/contrib/userDataProfile/browser/userDataProfileActions';", "commid": "vscode_pr_169735"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c1f822479559b7df7ccfd7f3c06f1a7b6be18df9bfa92424aa9dfb14e2e32a2", "query": "We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item\nAfter discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -\nLooks great -verified", "positive_passages": [{"docid": "doc-en-vscode-961587ed59450908f96159f1c0a297092391206aee8fd66f82120dd509efae82", "text": "import { CancellationToken } from 'vs/base/common/cancellation'; import { URI } from 'vs/base/common/uri'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace'; </del> <ins> import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; </ins> import { IWorkspaceTagsService } from 'vs/workbench/contrib/tags/common/workspaceTags'; import { getErrorMessage } from 'vs/base/common/errors'; <ins> const SelectProfileSubMenu = new MenuId('SelectProfile'); </ins> export class UserDataProfilesWorkbenchContribution extends Disposable implements IWorkbenchContribution { private readonly currentProfileContext: IContextKey<string>;", "commid": "vscode_pr_169735"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c1f822479559b7df7ccfd7f3c06f1a7b6be18df9bfa92424aa9dfb14e2e32a2", "query": "We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item\nAfter discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -\nLooks great -verified", "positive_passages": [{"docid": "doc-en-vscode-64bfaea5d881964daaf6d78f0ba99866f4c4ebf7180bc3c9308fc694d3ceab39", "text": "private registerActions(): void { this.registerManageProfilesSubMenu(); <ins> this.registerSelectProfileSubMenu(); this.registerProfilesActions(); this._register(this.userDataProfilesService.onDidChangeProfiles(() => this.registerProfilesActions())); </ins> this.registerCurrentProfilesActions(); this._register(Event.any(this.userDataProfileService.onDidChangeCurrentProfile, this.userDataProfileService.onDidUpdateCurrentProfile)(() => this.registerCurrentProfilesActions())); } private registerManageProfilesSubMenu(): void { <del> MenuRegistry.appendMenuItem(MenuId.GlobalActivity, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu, group: '5_settings', when: PROFILES_ENABLEMENT_CONTEXT, order: 1 }); </del> MenuRegistry.appendMenuItem(MenuId.MenubarPreferencesMenu, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu,", "commid": "vscode_pr_169735"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c1f822479559b7df7ccfd7f3c06f1a7b6be18df9bfa92424aa9dfb14e2e32a2", "query": "We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item\nAfter discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -\nLooks great -verified", "positive_passages": [{"docid": "doc-en-vscode-b52a6007b337fad4c64ca64f66a3d1296984db5dc5d04182c49d6de24cc55fd1", "text": "when: PROFILES_ENABLEMENT_CONTEXT, order: 1 }); <del> MenuRegistry.appendMenuItem(MenuId.AccountsContext, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu, group: '1_settings', </del> <ins> } private registerSelectProfileSubMenu(): IDisposable { const that = this; return MenuRegistry.appendMenuItem(ManageProfilesSubMenu, <ISubmenuItem>{ get title() { return localize('profile', \"Profile ({0})\", that.userDataProfileService.currentProfile.name); }, submenu: SelectProfileSubMenu, group: '0_profiles', </ins> when: PROFILES_ENABLEMENT_CONTEXT, }); } <del> private readonly currentprofileActionsDisposable = this._register(new MutableDisposable<DisposableStore>()); private registerCurrentProfilesActions(): void { this.currentprofileActionsDisposable.value = new DisposableStore(); this.currentprofileActionsDisposable.value.add(this.registerSwitchProfileForCurrentWindowAction()); this.currentprofileActionsDisposable.value.add(this.registerUpdateCurrentProfileShortNameAction()); this.currentprofileActionsDisposable.value.add(this.registerRenameCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerExportCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerImportProfileAction()); </del> <ins> private readonly profilesDisposable = this._register(new MutableDisposable<DisposableStore>()); private registerProfilesActions(): void { this.profilesDisposable.value = new DisposableStore(); for (const profile of this.userDataProfilesService.profiles) { this.profilesDisposable.value.add(this.registerProfileEntryAction(profile)); } </ins> } <del> private registerSwitchProfileForCurrentWindowAction(): IDisposable { </del> <ins> private registerProfileEntryAction(profile: IUserDataProfile): IDisposable { </ins> const that = this; <del> return registerAction2(class SwitchProfileForCurrentWindowAction extends Action2 { </del> <ins> return registerAction2(class ProfileEntryAction extends Action2 { </ins> constructor() { super({ <del> id: 'workbench.profiles.actions.switchProfile', title: { value: localize('switch profile for current', \"Switch Profile ({0})...\", that.userDataProfileService.currentProfile.name), original: `Switch Profile (${that.workspaceContextService.getWorkbenchState() === WorkbenchState.EMPTY ? localize('window', \"Window\") : localize('current workspace', \"Workspace\")})...` }, category: PROFILES_CATEGORY, f1: true, precondition: ContextKeyExpr.and(PROFILES_ENABLEMENT_CONTEXT, HAS_PROFILES_CONTEXT), </del> <ins> id: `workbench.profiles.actions.profileEntry.${profile.id}`, title: profile.name, toggled: ContextKeyExpr.equals(CURRENT_PROFILE_CONTEXT.key, profile.id), </ins> menu: [ { <del> id: ManageProfilesSubMenu, </del> <ins> id: SelectProfileSubMenu, </ins> group: '0_profiles', when: PROFILES_ENABLEMENT_CONTEXT, }", "commid": "vscode_pr_169735"}], "negative_passages": []}
{"query_id": "q-en-vscode-0c1f822479559b7df7ccfd7f3c06f1a7b6be18df9bfa92424aa9dfb14e2e32a2", "query": "We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item\nAfter discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -\nLooks great -verified", "positive_passages": [{"docid": "doc-en-vscode-2e1044128f9cac77aad1dad7011daf92762b5e71f827bba17a691964bc1d0ee9", "text": "}); } async run(accessor: ServicesAccessor) { <del> const quickInputService = accessor.get(IQuickInputService); const currentProfile = that.userDataProfileService.currentProfile; const result = await quickInputService.pick(that.userDataProfilesService.profiles.map(profile => ({ id: profile.id, label: currentProfile.id === profile.id ? `$(check) ${profile.name}` : profile.name, profile })), { placeHolder: localize('switch profile', \"Switch Profile\") }); if (result?.profile) { that.userDataProfileManagementService.switchProfile(result?.profile); </del> <ins> if (that.userDataProfileService.currentProfile.id !== profile.id) { return that.userDataProfileManagementService.switchProfile(profile); </ins> } } }); } <ins> private readonly currentprofileActionsDisposable = this._register(new MutableDisposable<DisposableStore>()); private registerCurrentProfilesActions(): void { this.currentprofileActionsDisposable.value = new DisposableStore(); this.currentprofileActionsDisposable.value.add(this.registerUpdateCurrentProfileShortNameAction()); this.currentprofileActionsDisposable.value.add(this.registerRenameCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerExportCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerImportProfileAction()); } </ins> private registerUpdateCurrentProfileShortNameAction(): IDisposable { const that = this; return registerAction2(class UpdateCurrentProfileShortName extends Action2 {", "commid": "vscode_pr_169735"}], "negative_passages": []}
{"query_id": "q-en-vscode-e28ed666496e39ffbc4b31969f62cfaa9f0f541da5286ea00c808d8a2cbac672", "query": "Example block quote in the extensions page. <img width=\"375\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-54eb14f9ef774eb0c67e2599ac12d8ff4e8d04edbaa1e8017e8fe59440144d1a", "text": "\"tab.unfocusedHoverBackground\": \"#6e76811a\", \"terminal.foreground\": \"#ffffffc5\", \"terminal.inactiveSelectionBackground\": \"#E5EBF1\", <del> \"textBlockQuote.background\": \"#010409\", </del> <ins> \"textBlockQuote.background\": \"#f8f8f8\", </ins> \"textBlockQuote.border\": \"#0000001a\", \"textCodeBlock.background\": \"#6e768166\", \"textLink.activeForeground\": \"#005FB8\",", "commid": "vscode_pr_168915"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca197bcb65a18fcb1c2d44a19ac3d9c307fae31c5c8c0881303f8cab3829fecc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider OS Version: Linux Hello, IMHO, the block cursor could use a different background. Default Dark+ Experimental (v2): ! ! Default Dark+: ! ! Default Dark+ Experimental (v2): with some cursor background color. For ex: ! ! ! ! Edit (one more option) (with color set to 's value, giving inverted cursor effect) ! ! Thanks", "positive_passages": [{"docid": "doc-en-vscode-8faf338f4a81a960b407ee88cbb4e218239bd85b220a7aa0e7487fc1714fcfd9", "text": "\"editor.background\": \"#1f1f1f\", \"editor.findMatchBackground\": \"#9e6a03\", \"editor.foreground\": \"#ffffffd3\", <del> \"editorCursor.foreground\": \"#0078d4\", </del> \"editorGroup.border\": \"#ffffff17\", \"editorGroupHeader.tabsBackground\": \"#181818\", \"editorGroupHeader.tabsBorder\": \"#ffffff15\",", "commid": "vscode_pr_171202"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca197bcb65a18fcb1c2d44a19ac3d9c307fae31c5c8c0881303f8cab3829fecc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider OS Version: Linux Hello, IMHO, the block cursor could use a different background. Default Dark+ Experimental (v2): ! ! Default Dark+: ! ! Default Dark+ Experimental (v2): with some cursor background color. For ex: ! ! ! ! Edit (one more option) (with color set to 's value, giving inverted cursor effect) ! ! Thanks", "positive_passages": [{"docid": "doc-en-vscode-d2c151e267c4388031532b2dc0a395dac62ecca29573a0989cb667124c798c7f", "text": "\"editor.foreground\": \"#000000e4\", \"editor.inactiveSelectionBackground\": \"#E5EBF1\", \"editor.selectionHighlightBackground\": \"#ADD6FF80\", <del> \"editorCursor.foreground\": \"#005FB8\", </del> \"editorGroup.border\": \"#0000001a\", \"editorGroupHeader.tabsBackground\": \"#f8f8f8\", \"editorGroupHeader.tabsBorder\": \"#0000001a\",", "commid": "vscode_pr_171202"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-326387404dfad283b7d9333637919ea6ab24d02e4ab7465fa5b221eab7a8803d", "text": "super(); } <ins> private _activeProvideLinkRequests: Map<number, Promise<TerminalLink[]>> = new Map(); </ins> async provideLinks(bufferLineNumber: number, callback: (links: ILink[] | undefined) => void) { <del> this._activeLinks?.forEach(l => l.dispose()); this._activeLinks = await this._provideLinks(bufferLineNumber); </del> <ins> let activeRequest = this._activeProvideLinkRequests.get(bufferLineNumber); if (activeRequest) { await activeRequest; callback(this._activeLinks); return; } if (this._activeLinks) { for (const link of this._activeLinks) { link.dispose(); } } activeRequest = this._provideLinks(bufferLineNumber); this._activeProvideLinkRequests.set(bufferLineNumber, activeRequest); this._activeLinks = await activeRequest; this._activeProvideLinkRequests.delete(bufferLineNumber); </ins> callback(this._activeLinks); }", "commid": "vscode_pr_169696"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-9404922018a2ca17be2bfb8c47c23586d803000fd1ef9711311a7846a636e980", "text": "\"vscode-proxy-agent\": \"^0.12.0\", \"vscode-regexpp\": \"^3.1.0\", \"vscode-textmate\": \"8.0.0\", <del> \"xterm\": \"5.1.0-beta.87\", \"xterm-addon-canvas\": \"0.3.0-beta.35\", </del> <ins> \"xterm\": \"5.2.0-beta.2\", \"xterm-addon-canvas\": \"0.4.0-beta.1\", </ins> \"xterm-addon-search\": \"0.11.0-beta.7\", <del> \"xterm-addon-serialize\": \"0.9.0-beta.3\", </del> <ins> \"xterm-addon-serialize\": \"0.9.0\", </ins> \"xterm-addon-unicode11\": \"0.5.0-beta.5\", <del> \"xterm-addon-webgl\": \"0.14.0-beta.50\", \"xterm-headless\": \"5.1.0-beta.87\", </del> <ins> \"xterm-addon-webgl\": \"0.15.0-beta.1\", \"xterm-headless\": \"5.2.0-beta.2\", </ins> \"yauzl\": \"^2.9.2\", \"yazl\": \"^2.4.3\" },", "commid": "vscode_pr_169697"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-68196f2587fde12b3e15fc1eef47525a37bdb246113cee2ebfbd1ec1a244b2f8", "text": "\"tas-client-umd\": \"0.1.6\", \"vscode-oniguruma\": \"1.7.0\", \"vscode-textmate\": \"8.0.0\", <del> \"xterm\": \"5.1.0-beta.87\", \"xterm-addon-canvas\": \"0.3.0-beta.35\", </del> <ins> \"xterm\": \"5.2.0-beta.2\", \"xterm-addon-canvas\": \"0.4.0-beta.1\", </ins> \"xterm-addon-search\": \"0.11.0-beta.7\", \"xterm-addon-unicode11\": \"0.5.0-beta.5\", <del> \"xterm-addon-webgl\": \"0.14.0-beta.50\" </del> <ins> \"xterm-addon-webgl\": \"0.15.0-beta.1\" </ins> } }", "commid": "vscode_pr_169697"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-51db84d46f933ad804632e7a53e63b58a871e63701d248db37241c823f1282f8", "text": "resolved \"https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-8.0.0.tgz#2c7a3b1163ef0441097e0b5d6389cd5504b59e5d\" integrity sha512-AFbieoL7a5LMqcnOF04ji+rpXadgOXnZsxQr//r83kLPr7biP7am3g9zbaZIaBGwBRWeSvoMD4mgPdX3e4NWBg== <del> xterm-addon-canvas@0.3.0-beta.35: version \"0.3.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5\" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version \"0.4.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f\" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version \"0.11.0-beta.7\"", "commid": "vscode_pr_169697"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-f3e1127eddf6a671165c7cbc57e67ae039b56ed251894204241e803e76b784a2", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93\" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version \"0.14.0-beta.50\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445\" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version \"0.15.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796\" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm@5.1.0-beta.87: version \"5.1.0-beta.87\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891\" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787\" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins>", "commid": "vscode_pr_169697"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-e56dbc224825efece0aa31f365be6f8c78d8699a16468f2ce783c08f0d6a7c06", "text": "resolved \"https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f\" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-canvas@0.3.0-beta.35: version \"0.3.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5\" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version \"0.4.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f\" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version \"0.11.0-beta.7\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052\" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== <del> xterm-addon-serialize@0.9.0-beta.3: version \"0.9.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0-beta.3.tgz#bb4ed416db5748bcbe55a4b6d4c2151368fdae74\" integrity sha512-LaFuowtdxNdeuLm+KmtsoR4mgPOLu/I9k0hlWXbzAd1okJhthwMH4Y6cuL0/pFk1AclP5s+L42glv8PV0GnVsg== </del> <ins> xterm-addon-serialize@0.9.0: version \"0.9.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0.tgz#3eee5f5c34b16e48891ec59b213716bab2354bf4\" integrity sha512-qJju2YJFh8c8pbtCYtHaG7gDDHBpDJ4a4JQZvOzuiMxOjgeM1oCnFNjbhzMuK/fOUa59FmvIUGQyqn3WL9q7qw== </ins> xterm-addon-unicode11@0.5.0-beta.5: version \"0.5.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93\" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version \"0.14.0-beta.50\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445\" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version \"0.15.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796\" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm-headless@5.1.0-beta.87: version \"5.1.0-beta.87\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.87.tgz#6eb3114bbe006088ce1aab063f14ce87b93c1001\" integrity sha512-/LEyLBkyAMy5r2iGur1CW0UsCGu1oEuskAccokbwOGS5Ad/uPZUDQUAuCmfSSX3gauz5TBqBPLYIRdY0u0DEJg== </del> <ins> xterm-headless@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.2.tgz#db8d4cc45a2bba062622d7784a2264030aa7d56d\" integrity sha512-aP3+K47bJu5AkdtekML5LZZUh/zAkDc5ONNFgQ+7eUBh7RkFy3JYRuaG5Nj3LbdkUMjWqQZXzc3BW5Vo9KQNgA== </ins> <del> xterm@5.1.0-beta.87: version \"5.1.0-beta.87\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891\" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787\" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins> yallist@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_169697"}], "negative_passages": []}
{"query_id": "q-en-vscode-843bf7a1f1cdd297eaeab34aeeee63ea76f44b994bbe1e363163f7277df74030", "query": "I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:\nTerminal output: !\nThis was caused by , it may fixable on the VS Code side though.\nRepro: vscode repo : over a link and keep it there into the terminal ! ! ! !\nSomething is not getting disposed, I verified that the number of times each link detector is called increases\n!\nCan repro upstream:", "positive_passages": [{"docid": "doc-en-vscode-54109ea5c6781a9702e96bd8caa482cca733400c1b81cf6c5bd7fecf45591f9b", "text": "dependencies: object-keys \"~0.4.0\" <del> xterm-addon-canvas@0.3.0-beta.35: version \"0.3.0-beta.35\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5\" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version \"0.4.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f\" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version \"0.11.0-beta.7\" resolved \"https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052\" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== <del> xterm-addon-serialize@0.9.0-beta.3: version \"0.9.0-beta.3\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0-beta.3.tgz#bb4ed416db5748bcbe55a4b6d4c2151368fdae74\" integrity sha512-LaFuowtdxNdeuLm+KmtsoR4mgPOLu/I9k0hlWXbzAd1okJhthwMH4Y6cuL0/pFk1AclP5s+L42glv8PV0GnVsg== </del> <ins> xterm-addon-serialize@0.9.0: version \"0.9.0\" resolved \"https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0.tgz#3eee5f5c34b16e48891ec59b213716bab2354bf4\" integrity sha512-qJju2YJFh8c8pbtCYtHaG7gDDHBpDJ4a4JQZvOzuiMxOjgeM1oCnFNjbhzMuK/fOUa59FmvIUGQyqn3WL9q7qw== </ins> xterm-addon-unicode11@0.5.0-beta.5: version \"0.5.0-beta.5\" resolved \"https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93\" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version \"0.14.0-beta.50\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445\" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version \"0.15.0-beta.1\" resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796\" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm-headless@5.1.0-beta.87: version \"5.1.0-beta.87\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.87.tgz#6eb3114bbe006088ce1aab063f14ce87b93c1001\" integrity sha512-/LEyLBkyAMy5r2iGur1CW0UsCGu1oEuskAccokbwOGS5Ad/uPZUDQUAuCmfSSX3gauz5TBqBPLYIRdY0u0DEJg== </del> <ins> xterm-headless@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.2.tgz#db8d4cc45a2bba062622d7784a2264030aa7d56d\" integrity sha512-aP3+K47bJu5AkdtekML5LZZUh/zAkDc5ONNFgQ+7eUBh7RkFy3JYRuaG5Nj3LbdkUMjWqQZXzc3BW5Vo9KQNgA== </ins> <del> xterm@5.1.0-beta.87: version \"5.1.0-beta.87\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891\" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version \"5.2.0-beta.2\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787\" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins> y18n@^3.2.1: version \"3.2.2\"", "commid": "vscode_pr_169697"}], "negative_passages": []}
{"query_id": "q-en-vscode-b6e4fee69a290bffdb841f012de480a211a127e700be60a5d289710122250459", "query": "Light Theme the Extensions view the Extension item in the list -all letters turn black, the contrast is not good !\nLooks like these buttons are inheriting the codicon styling, and as a result, the color. I removed it from Light+ V2 to reset it back to null. Ideally this button wouldn't use codicon styling cc", "positive_passages": [{"docid": "doc-en-vscode-57a1be4e899eb2e70091ae711b27281a381569df79f19c1a0b75a00aa763fed5", "text": "\"keybindingLabel.foreground\": \"#000000e4\", \"list.activeSelectionBackground\": \"#e8e8e8\", \"list.activeSelectionForeground\": \"#000000\", <del> \"list.activeSelectionIconForeground\": \"#000000\", </del> \"list.hoverBackground\": \"#f2f2f2\", \"menu.border\": \"#D4D4D4\", \"notebook.cellBorderColor\": \"#E8E8E8\",", "commid": "vscode_pr_171201"}], "negative_passages": []}
{"query_id": "q-en-vscode-1dc6594cccf9d207b81311ef2b399b7133107228ba73e7232babd11be6526bd9", "query": "<img width=\"1754\" alt=\"iShot2022-12-2811 40 36\" src=\"https://user-\"\nEasy repro: ! ! Likely Windows only.\nIt's an encoding issue in pwsh's shell integration cwd detection\nNo, my MacBook has this problem too.\nyep the fix was for pwsh on all platforms\nUpdated 1.74.3 today, but found that this bug still exists, do you want to wait for the next version to fix it?\nthe fix is in 1.75.0 (insiders only atm)\nThanks.", "positive_passages": [{"docid": "doc-en-vscode-9f7f16dde84644d74d45382bccfb295a4592c4d1712dcb556657f793e5289c8b", "text": "function Global:__VSCode-Escape-Value([string]$value) { # NOTE: In PowerShell v6.1+, this can be written `$value -replace '\u2026', { \u2026 }` instead of `[regex]::Replace`. # Replace any non-alphanumeric characters. <del> [regex]::Replace($value, '[^a-zA-Z0-9]', { param($match) # Backslashes must be doubled. if ($match.Value -eq '') { '' } else { # Any other characters are encoded as their UTF-8 hex values. -Join ( [System.Text.Encoding]::UTF8.GetBytes($match.Value) | ForEach-Object { 'x{0:x2}' -f $_ } ) } </del> <ins> [regex]::Replace($value, '[n;]', { param($match) # Encode the (ascii) matches as `x<hex>` -Join ( [System.Text.Encoding]::UTF8.GetBytes($match.Value) | ForEach-Object { 'x{0:x2}' -f $_ } ) </ins> }) }", "commid": "vscode_pr_170164"}], "negative_passages": []}
{"query_id": "q-en-vscode-39be89cc3025cad97b328842caf895a0f99b01e53512e276f93a4085e04f50d4", "query": "When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.\ncan you update to the latest Insiders from today and try again?\nSure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-\nYes, more fallout from , apologies", "positive_passages": [{"docid": "doc-en-vscode-e9774c055fc589b7700f1b4c5b22f0c0bbf884e0e3c282d2a914aec8027c022c", "text": "return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const focus = e.index; if (typeof focus === 'undefined') {", "commid": "vscode_pr_171027"}], "negative_passages": []}
{"query_id": "q-en-vscode-39be89cc3025cad97b328842caf895a0f99b01e53512e276f93a4085e04f50d4", "query": "When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.\ncan you update to the latest Insiders from today and try again?\nSure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-\nYes, more fallout from , apologies", "positive_passages": [{"docid": "doc-en-vscode-48b08373f90d25a2fcbc7790891be79ca6615eb2890538a823d13845bef63710", "text": "this.list.setSelection([focus], e.browserEvent); } <del> e.browserEvent.preventDefault(); </del> this._onPointer.fire(e); }", "commid": "vscode_pr_171027"}], "negative_passages": []}
{"query_id": "q-en-vscode-39be89cc3025cad97b328842caf895a0f99b01e53512e276f93a4085e04f50d4", "query": "When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.\ncan you update to the latest Insiders from today and try again?\nSure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-\nYes, more fallout from , apologies", "positive_passages": [{"docid": "doc-en-vscode-c2c5be8398a7de4b3304c94b7ebe87f2f939b3caa470ed5374ae6a024edd4888", "text": "return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const focus = this.list.getFocus(); this.list.setSelection(focus, e.browserEvent); <del> e.browserEvent.preventDefault(); </del> } private changeSelection(e: IListMouseEvent<T> | IListTouchEvent<T>): void {", "commid": "vscode_pr_171027"}], "negative_passages": []}
{"query_id": "q-en-vscode-39be89cc3025cad97b328842caf895a0f99b01e53512e276f93a4085e04f50d4", "query": "When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.\ncan you update to the latest Insiders from today and try again?\nSure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-\nYes, more fallout from , apologies", "positive_passages": [{"docid": "doc-en-vscode-8d4fa3fad9f12bdaf1cab0dd87bed95937f6afe64dfbe7816b92ffc1793843a6", "text": "return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const node = e.element; if (!node) {", "commid": "vscode_pr_171027"}], "negative_passages": []}
{"query_id": "q-en-vscode-39be89cc3025cad97b328842caf895a0f99b01e53512e276f93a4085e04f50d4", "query": "When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.\ncan you update to the latest Insiders from today and try again?\nSure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-\nYes, more fallout from , apologies", "positive_passages": [{"docid": "doc-en-vscode-75015a649366ca53d0fe1e5ea37a47786e2079e20839eb0075aece6a7d0e573a", "text": "return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> super.onDoubleClick(e); } }", "commid": "vscode_pr_171027"}], "negative_passages": []}
{"query_id": "q-en-vscode-f87b764e56af7fda90e2f1ab491c9cb168af223c177a4684c98ce8fb4b68f10b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-10T05:21:34.436Z Electron: 19.1.9 Chromium: 102.0.5005.194 16.14.2 V8: 10.2.154.23-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes Steps to Reproduce: an existing workspace folder with git a few branches with commits to switch branches list of branches does not display the recent branches on top the same workspace folder in vscode stable and the order is as expected", "positive_passages": [{"docid": "doc-en-vscode-b2a094c90a06fd026a77e13bd66f78ca8dc1b57dfb58daffa1f9af0ed437969d", "text": "} async getRefs(query: RefQuery = {}, cancellationToken?: CancellationToken): Promise<Ref[]> { <del> return await this.run(Operation.GetRefs, () => { return this.repository.getRefs(query, cancellationToken); }); </del> <ins> const config = workspace.getConfiguration('git'); let defaultSort = config.get<'alphabetically' | 'committerdate'>('branchSortOrder'); if (defaultSort !== 'alphabetically' && defaultSort !== 'committerdate') { defaultSort = 'alphabetically'; } query = { ...query, sort: query?.sort ?? defaultSort }; return await this.run(Operation.GetRefs, () => this.repository.getRefs(query, cancellationToken)); </ins> } async getRemoteRefs(remote: string, opts?: { heads?: boolean; tags?: boolean }): Promise<Ref[]> {", "commid": "vscode_pr_171058"}], "negative_passages": []}
{"query_id": "q-en-vscode-f87b764e56af7fda90e2f1ab491c9cb168af223c177a4684c98ce8fb4b68f10b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-10T05:21:34.436Z Electron: 19.1.9 Chromium: 102.0.5005.194 16.14.2 V8: 10.2.154.23-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes Steps to Reproduce: an existing workspace folder with git a few branches with commits to switch branches list of branches does not display the recent branches on top the same workspace folder in vscode stable and the order is as expected", "positive_passages": [{"docid": "doc-en-vscode-465ab9e69a861bfe44abb565873331e7430d263034be636de606fcff528fe375", "text": "this._sourceControl.commitTemplate = commitTemplate; // Execute cancellable long-running operations <del> const config = workspace.getConfiguration('git'); let sort = config.get<'alphabetically' | 'committerdate'>('branchSortOrder') || 'alphabetically'; if (sort !== 'alphabetically' && sort !== 'committerdate') { sort = 'alphabetically'; } </del> const [resourceGroups, refs] = await Promise.all([ this.getStatus(cancellationToken), <del> this.repository.getRefs({ sort }, cancellationToken)]); </del> <ins> this.getRefs({}, cancellationToken)]); </ins> this._refs = refs!; this._updateResourceGroupsState(resourceGroups);", "commid": "vscode_pr_171058"}], "negative_passages": []}
{"query_id": "q-en-vscode-a806dab862282045fea2961170f5824d084f06d4e07f53f462aec5184843bb27", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 insider OS Version: Windows 11 Version 10.0. Build Steps to Reproduce: perfectly clean VSCode Insider version any folder and create/open .md file like this: Preview to the side ! on the second title (L5) then vertical white line appears on the left ! I click on the secound line, the top title is highlighted normally ! when I directly click on the first line, the vertical line doesn't appear !", "positive_passages": [{"docid": "doc-en-vscode-e3c0f29ac559cee548d8414e32e6ca6cc11138ed3edc08070e5ae33b7ad60b7d", "text": "return (documentVersion: number) => { if (!cachedElements || documentVersion !== cachedVersion) { cachedVersion = documentVersion; <del> cachedElements = [{ element: document.body, line: 0 }]; </del> <ins> cachedElements = [{ element: document.body, line: -1 }]; </ins> for (const element of document.getElementsByClassName(codeLineClass)) { const line = +element.getAttribute('data-line')!; if (isNaN(line)) {", "commid": "vscode_pr_172175"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-babc2483bd4be47e197ad8bb59a880c53f23df9c9a458044a89ca6ee89b7fe22", "text": "} switch (e.data.type) { <del> case 'setScale': </del> <ins> case 'setScale': { </ins> updateScale(e.data.scale); break; <del> case 'setActive': </del> <ins> } case 'setActive': { </ins> setActive(e.data.value); break; <del> case 'zoomIn': </del> <ins> } case 'zoomIn': { </ins> zoomIn(); break; <del> case 'zoomOut': </del> <ins> } case 'zoomOut': { </ins> zoomOut(); break; <ins> } case 'copyImage': { copyImage(); break; } </ins> } }); <ins> document.addEventListener('copy', () => { copyImage(); }); async function copyImage() { try { await navigator.clipboard.write([new ClipboardItem({ 'image/png': fetch(image.src).then(request => request.blob()) })]); } catch (e) { console.error(e); } } </ins> }());", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-e9247180ecc7db49287794578e52b411072a5c8df1b640ba783400577616b853", "text": "\"command\": \"imagePreview.zoomOut\", \"title\": \"%command.zoomOut%\", \"category\": \"Image Preview\" <ins> }, { \"command\": \"imagePreview.copyImage\", \"title\": \"%command.copyImage%\", \"category\": \"Image Preview\" </ins> } ], \"menus\": {", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-63652886e976b7fed13090ebbb27c50c703750611abccd9278a86c9848fae676", "text": "\"command\": \"imagePreview.zoomOut\", \"when\": \"activeCustomEditorId == 'imagePreview.previewEditor'\", \"group\": \"1_imagePreview\" <ins> }, { \"command\": \"imagePreview.copyImage\", \"when\": \"false\" } ], \"webview/context\": [ { \"command\": \"imagePreview.copyImage\", \"when\": \"webviewId == 'imagePreview.previewEditor'\" </ins> } ] }", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-f71d07e96eac20a3ad6ffe07103e52cb4649701add3242082e039a417383c5ff", "text": "\"customEditor.imagePreview.displayName\": \"Image Preview\", \"customEditor.videoPreview.displayName\": \"Video Preview\", \"command.zoomIn\": \"Zoom in\", <del> \"command.zoomOut\": \"Zoom out\" </del> <ins> \"command.zoomOut\": \"Zoom out\", \"command.copyImage\": \"Copy\" </ins> }", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-6d0cd14315747d8b3a21e87ebe84b5143ca33f56c99a814f04cb6d46ca7860f5", "text": "<meta http-equiv=\"Content-Security-Policy\" content=\"default-src 'none'; img-src data: ${cspSource}; media-src ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';\"> <meta id=\"settings\" data-settings=\"${escapeAttribute(JSON.stringify(settings))}\"> </head> <del> <body class=\"container loading\"> </del> <ins> <body class=\"container loading\" data-vscode-context='{ \"preventDefaultContextMenuItems\": true }'> </ins> <div class=\"loading-indicator\"></div> <div class=\"loading-error\"> <p>${vscode.l10n.t(\"An error occurred while loading the audio file.\")}</p>", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-9ea4e6620b736fa018543f1f633390a2dfd7fdba7a985a43219d012c2fecc6dd", "text": "} } <ins> public copyImage() { if (this.previewState === PreviewState.Active) { this.webviewEditor.reveal(); this.webviewEditor.webview.postMessage({ type: 'copyImage' }); } } </ins> protected override updateState() { super.updateState();", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-eb59abf54782fc43bb27492ce78a06c6473bae3a0a9cbcacdeed16676f558410", "text": "<link rel=\"stylesheet\" href=\"${escapeAttribute(this.extensionResource('media', 'imagePreview.css'))}\" type=\"text/css\" media=\"screen\" nonce=\"${nonce}\"> <del> <meta http-equiv=\"Content-Security-Policy\" content=\"default-src 'none'; img-src data: ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';\"> </del> <ins> <meta http-equiv=\"Content-Security-Policy\" content=\"default-src 'none'; img-src data: ${cspSource}; connect-src ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';\"> </ins> <meta id=\"image-preview-settings\" data-settings=\"${escapeAttribute(JSON.stringify(settings))}\"> </head> <del> <body class=\"container image scale-to-fit loading\"> </del> <ins> <body class=\"container image scale-to-fit loading\" data-vscode-context='{ \"preventDefaultContextMenuItems\": true }'> </ins> <div class=\"loading-indicator\"></div> <div class=\"image-load-error\"> <p>${vscode.l10n.t(\"An error occurred while loading the image.\")}</p>", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-d4c1658344c2381df277e21beeeeb83d429eff02c3ceaa5be77ed08978cd160d", "text": "previewManager.activePreview?.zoomOut(); })); <ins> disposables.push(vscode.commands.registerCommand('imagePreview.copyImage', () => { previewManager.activePreview?.copyImage(); })); </ins> return vscode.Disposable.from(...disposables); }", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-1187b902fa9f4fe0d81d6c857764a2e78453fd6697429ce68535e4b13d6811b6", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?\nHey I would like to work on this issue.\nassign this to me\nAre these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width=\"950\" alt=\"image\" src=\"https://user-\"\nI would like to wokr on this issue.\nI would like to try solving this issue.\nYou right-click an image and select \"copy\", then you click a folder in VSCode's explorer and select \"paste\". The image should be pasted into that folder but it doesn't.\nI would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-\nAfter a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.\nWhat about adding a handler :\nHere's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?\nPasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor", "positive_passages": [{"docid": "doc-en-vscode-daf44df7e28dd5ce5795a5e868745a704eeb4d20e64b5ce9b235d0ccc2ad321f", "text": "<meta http-equiv=\"Content-Security-Policy\" content=\"default-src 'none'; img-src data: ${cspSource}; media-src ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';\"> <meta id=\"settings\" data-settings=\"${escapeAttribute(JSON.stringify(settings))}\"> </head> <del> <body class=\"loading\"> </del> <ins> <body class=\"loading\" data-vscode-context='{ \"preventDefaultContextMenuItems\": true }'> </ins> <div class=\"loading-indicator\"></div> <div class=\"loading-error\"> <p>${vscode.l10n.t(\"An error occurred while loading the video file.\")}</p>", "commid": "vscode_pr_180269"}], "negative_passages": []}
{"query_id": "q-en-vscode-96dcf093e3cdef8d6dc308f53733fe0e52f73534987c26c442df46e820eab5d7", "query": "Type: <bBug</ba TS file at the language status item in the status bar Bug The bracket icon is instead rendered as a pie chart icon <img width=\"222\" alt=\"Screenshot 2023-01-18 at 1 28 37 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-18T08:53:10.224Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nLooks like the id for got duplicated:", "positive_passages": [{"docid": "doc-en-vscode-7aa3d9adf11077640a807974d7d43fb0c73bc0b5ff0801ab37bd7ab0565e63eb", "text": "italic: register('italic', 0xeb0d), jersey: register('jersey', 0xeb0e), json: register('json', 0xeb0f), <ins> bracket: register('bracket', 0xeb0f), </ins> kebabVertical: register('kebab-vertical', 0xeb10), key: register('key', 0xeb11), law: register('law', 0xeb12),", "commid": "vscode_pr_171680"}], "negative_passages": []}
{"query_id": "q-en-vscode-96dcf093e3cdef8d6dc308f53733fe0e52f73534987c26c442df46e820eab5d7", "query": "Type: <bBug</ba TS file at the language status item in the status bar Bug The bracket icon is instead rendered as a pie chart icon <img width=\"222\" alt=\"Screenshot 2023-01-18 at 1 28 37 PM\" src=\"https://user-\"VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-18T08:53:10.224Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --\nLooks like the id for got duplicated:", "positive_passages": [{"docid": "doc-en-vscode-85d6ab755ac40dc0adf9a9b07d4dba3c7165c03bd13ef2c3e28b7a238a348b85", "text": "graphLine: register('graph-line', 0xebe2), graphScatter: register('graph-scatter', 0xebe3), pieChart: register('pie-chart', 0xebe4), <del> bracket: register('bracket', 0xebe4), </del> bracketDot: register('bracket-dot', 0xebe5), bracketError: register('bracket-error', 0xebe6), lockSmall: register('lock-small', 0xebe7),", "commid": "vscode_pr_171680"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-fa2248dcaf3ad21bba4c0f8b6ca6c184fd827809358f6944f65d162a906e3d0e", "text": "} /** <ins> * A regex that extracts the link suffix which contains line and column information. The link suffix * must terminate at the end of line. */ const linkSuffixRegexEol = new Lazy<RegExp>(() => generateLinkSuffixRegex(true)); /** </ins> * A regex that extracts the link suffix which contains line and column information. */ <del> const linkSuffixRegexEol = new Lazy<RegExp>(() => { </del> <ins> const linkSuffixRegex = new Lazy<RegExp>(() => generateLinkSuffixRegex(false)); function generateLinkSuffixRegex(eolOnly: boolean) { </ins> let ri = 0; let ci = 0; function l(): string {", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-838f10777ecac702c26e2f84e0ba35b2b03806e1ad3abc14d120112869812213", "text": "return `(?<col${ci++}>d+)`; } <ins> const eolSuffix = eolOnly ? '$' : ''; </ins> // The comments in the regex below use real strings/numbers for better readability, here's // the legend: // - Path = foo", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-d74cef3b68de1bf26612e2a3669fc3e8ad799f755b6950de5b30a2229a229754", "text": "// foo:339 // foo:339:12 // foo 339 <del> // foo 339:12                    [#140780] </del> <ins> // foo 339:12                        [#140780] </ins> // \"foo\",339 // \"foo\",339:12 <del> `(?::| |['\"],)${l()}(:${c()})?$`, // The quotes below are optional [#171652] // \"foo\", line 339                [#40468] </del> <ins> `(?::| |['\"],)${l()}(:${c()})?` + eolSuffix, // The quotes below are optional     [#171652] // \"foo\", line 339                   [#40468] </ins> // \"foo\", line 339, col 12 // \"foo\", line 339, column 12 // \"foo\":line 339", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-2fbc1c3fe680cdbae94cde47f0777dcc577bf3e3097bdabaa7bb3a2d385be39e", "text": "// \"foo\" on line 339, col 12 // \"foo\" on line 339, column 12 // \"foo\" line 339 column 12 <del> `['\"]?(?:,? |: ?| on )line ${l()}(,? col(?:umn)? ${c()})?$`, // foo(339) // foo(339,12) // foo(339, 12) // foo (339) //   ... // foo: (339) //   ... `:? ?[[(]${l()}(?:, ?${c()})?[])]$`, ]; const suffixClause = lineAndColumnRegexClauses // Join all clauses together .join('|') // Convert spaces to allow the non-breaking space char (ascii 160) .replace(/ /g, `[${'u00A0'} ]`); return new RegExp(`(${suffixClause})`); }); const linkSuffixRegex = new Lazy<RegExp>(() => { let ri = 0; let ci = 0; function l(): string { return `(?<row${ri++}>d+)`; } function c(): string { return `(?<col${ci++}>d+)`; } const lineAndColumnRegexClauses = [ // foo:339 // foo:339:12 // foo 339 // foo 339:12                    [#140780] // \"foo\",339 // \"foo\",339:12 `(?::| |['\"],)${l()}(:${c()})?`, // The quotes below are optional [#171652] // foo, line 339                [#40468] // foo, line 339, col 12 // foo, line 339, column 12 // \"foo\":line 339 // \"foo\":line 339, col 12 // \"foo\":line 339, column 12 // \"foo\": line 339 // \"foo\": line 339, col 12 // \"foo\": line 339, column 12 // \"foo\" on line 339 // \"foo\" on line 339, col 12 // \"foo\" on line 339, column 12 // \"foo\" line 339 column 12 `['\"]?(?:,? |: ?| on )line ${l()}(,? col(?:umn)? ${c()})?`, </del> <ins> // \"foo\", line 339, character 12     [#171880] // \"foo\", line 339, characters 12-13 [#171880] // \"foo\", lines 339-340              [#171880] `['\"]?(?:,? |: ?| on )lines? ${l()}(?:-d+)?(?:,? (?:col(?:umn)?|characters?) ${c()}(?:-d+)?)?` + eolSuffix, </ins> // foo(339) // foo(339,12) // foo(339, 12)", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-64229af32684a43bf7257f9fd9aeb99dfe045d0b522487ad4105436e702f6489", "text": "//   ... // foo: (339) //   ... <del> `:? ?[[(]${l()}(?:, ?${c()})?[])]`, </del> <ins> `:? ?[[(]${l()}(?:, ?${c()})?[])]` + eolSuffix, </ins> ]; const suffixClause = lineAndColumnRegexClauses", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-4a9baf236ed989d74b200f0f613719638502d9dcea5f620a41c996863d91b0d8", "text": "// Convert spaces to allow the non-breaking space char (ascii 160) .replace(/ /g, `[${'u00A0'} ]`); <del> return new RegExp(`(${suffixClause})`, 'g'); }); </del> <ins> return new RegExp(`(${suffixClause})`, eolOnly ? undefined : 'g'); } </ins> /** * Removes the optional link suffix which contains line and column information.", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-031dac191f99d8ebfc4e8a91b424e267ec09aec1efe4696c66e0b8aa23663e2a", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width=\"736\" alt=\"Screenshot 2023-01-19 at 10 06 47 PM\" src=\"https://user-\"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the \"File \"\", line 588, characters 50-75\" is not recognized.\nyeah looks like we don't support that case atm, though this one comes close\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!\nThe situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.\nwhat's Insiders? EDIT: the beta,\nI'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!\nis that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly\nForking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.\nThank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is \"in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2\" (subject to off-by-one errors, I don't remember how the characters are counted).\nOh ok, that makes sense\nFYI the row/col end part of the link should work when is merged", "positive_passages": [{"docid": "doc-en-vscode-c7e166c618007c6ebba1713e3a8d5b12618a6417d54759298119e9afaf15e375", "text": "{ link: 'foo: [339,12]', prefix: undefined, suffix: ': [339,12]', hasRow: true, hasCol: true }, { link: 'foo: [339, 12]', prefix: undefined, suffix: ': [339, 12]', hasRow: true, hasCol: true }, <ins> // OCaml-style { link: '\"foo\", line 339, character 12', prefix: '\"', suffix: '\", line 339, character 12', hasRow: true, hasCol: true }, { link: '\"foo\", line 339, characters 12-13', prefix: '\"', suffix: '\", line 339, characters 12-13', hasRow: true, hasCol: true }, { link: '\"foo\", lines 339-340', prefix: '\"', suffix: '\", lines 339-340', hasRow: true, hasCol: false }, </ins> // Non-breaking space { link: 'foou00A0339:12', prefix: undefined, suffix: 'u00A0339:12', hasRow: true, hasCol: true }, { link: '\"foo\" on line 339,u00A0column 12', prefix: '\"', suffix: '\" on line 339,u00A0column 12', hasRow: true, hasCol: true },", "commid": "vscode_pr_178291"}], "negative_passages": []}
{"query_id": "q-en-vscode-b060b73725b28ef75b2c0526a97266009d3101d50234e8426669eb5aae620ffe", "query": "Click on an error: <img width=\"595\" alt=\"image\" src=\"https://user-\"\nWhat I see when running from sources: !\nin insiders. try with \"Notification Tester\" extension.\nThe problem is that the css rule that adds the icon color looses against the color from the list. !\nFix in", "positive_passages": [{"docid": "doc-en-vscode-93850b640d2a84826d36110864bd7b6956f1fac823e6ff4c36c8a037a15d9cf3", "text": "/* Icons */ .monaco-workbench > .notifications-toasts .codicon.codicon-error { <del> color: var(--vscode-notificationsErrorIcon-foreground); </del> <ins> color: var(--vscode-notificationsErrorIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-toasts .codicon.codicon-warning { <del> color: var(--vscode-notificationsWarningIcon-foreground); </del> <ins> color: var(--vscode-notificationsWarningIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-toasts .codicon.codicon-info { <del> color: var(--vscode-notificationsInfoIcon-foreground); </del> <ins> color: var(--vscode-notificationsInfoIcon-foreground) !important; </ins> }", "commid": "vscode_pr_172076"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0db6a3caa0ab000093a5da0625be8e96d62772759a8d9647b2ddc51e394b92d", "query": "Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed \"echo hello\" in terminal, but there was no read-aloud feedback.\nsince the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type\nAw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.\nThanks for clarifying. I was confused by: Now I understand\nI can repro this not working in the latest stable VS Code as well. I type and it does not read\n-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.\nI have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it\n-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = \"textbox\" for this testing). works, just add textbox role and see if it works.\nthanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago\nin version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message \"too much output to announce for the command for example.\nalso just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it\nnavigation mode also works in 1.72\nthe element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width=\"935\" alt=\"Screenshot 2023-01-23 at 2 53 35 PM\" src=\"https://user-\"<img width=\"1247\" alt=\"Screenshot 2023-01-23 at 2 53 15 PM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-04aad68971841084628b195deb949cee28b1c348a6a70220edf5a94960994b71", "text": "\"vscode-proxy-agent\": \"^0.12.0\", \"vscode-regexpp\": \"^3.1.0\", \"vscode-textmate\": \"8.0.0\", <del> \"xterm\": \"5.2.0-beta.19\", </del> <ins> \"xterm\": \"5.2.0-beta.20\", </ins> \"xterm-addon-canvas\": \"0.4.0-beta.7\", \"xterm-addon-search\": \"0.11.0\", \"xterm-addon-serialize\": \"0.9.0\", \"xterm-addon-unicode11\": \"0.5.0\", \"xterm-addon-webgl\": \"0.15.0-beta.4\", <del> \"xterm-headless\": \"5.2.0-beta.19\", </del> <ins> \"xterm-headless\": \"5.2.0-beta.20\", </ins> \"yauzl\": \"^2.9.2\", \"yazl\": \"^2.4.3\" },", "commid": "vscode_pr_172191"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0db6a3caa0ab000093a5da0625be8e96d62772759a8d9647b2ddc51e394b92d", "query": "Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed \"echo hello\" in terminal, but there was no read-aloud feedback.\nsince the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type\nAw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.\nThanks for clarifying. I was confused by: Now I understand\nI can repro this not working in the latest stable VS Code as well. I type and it does not read\n-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.\nI have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it\n-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = \"textbox\" for this testing). works, just add textbox role and see if it works.\nthanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago\nin version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message \"too much output to announce for the command for example.\nalso just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it\nnavigation mode also works in 1.72\nthe element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width=\"935\" alt=\"Screenshot 2023-01-23 at 2 53 35 PM\" src=\"https://user-\"<img width=\"1247\" alt=\"Screenshot 2023-01-23 at 2 53 15 PM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-4e680871b2996bf3c380daca101f89c205bc6e3f133204bba9c57307aac51957", "text": "\"tas-client-umd\": \"0.1.6\", \"vscode-oniguruma\": \"1.7.0\", \"vscode-textmate\": \"8.0.0\", <del> \"xterm\": \"5.2.0-beta.19\", </del> <ins> \"xterm\": \"5.2.0-beta.20\", </ins> \"xterm-addon-canvas\": \"0.4.0-beta.7\", \"xterm-addon-search\": \"0.11.0\", \"xterm-addon-unicode11\": \"0.5.0\",", "commid": "vscode_pr_172191"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0db6a3caa0ab000093a5da0625be8e96d62772759a8d9647b2ddc51e394b92d", "query": "Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed \"echo hello\" in terminal, but there was no read-aloud feedback.\nsince the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type\nAw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.\nThanks for clarifying. I was confused by: Now I understand\nI can repro this not working in the latest stable VS Code as well. I type and it does not read\n-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.\nI have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it\n-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = \"textbox\" for this testing). works, just add textbox role and see if it works.\nthanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago\nin version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message \"too much output to announce for the command for example.\nalso just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it\nnavigation mode also works in 1.72\nthe element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width=\"935\" alt=\"Screenshot 2023-01-23 at 2 53 35 PM\" src=\"https://user-\"<img width=\"1247\" alt=\"Screenshot 2023-01-23 at 2 53 15 PM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-987941462df9acfaeafd7100ada53f3ad6085f435c2351b31d113c415a6cbcd6", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030\" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm@5.2.0-beta.19: version \"5.2.0-beta.19\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0\" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm@5.2.0-beta.20: version \"5.2.0-beta.20\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64\" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins>", "commid": "vscode_pr_172191"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0db6a3caa0ab000093a5da0625be8e96d62772759a8d9647b2ddc51e394b92d", "query": "Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed \"echo hello\" in terminal, but there was no read-aloud feedback.\nsince the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type\nAw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.\nThanks for clarifying. I was confused by: Now I understand\nI can repro this not working in the latest stable VS Code as well. I type and it does not read\n-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.\nI have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it\n-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = \"textbox\" for this testing). works, just add textbox role and see if it works.\nthanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago\nin version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message \"too much output to announce for the command for example.\nalso just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it\nnavigation mode also works in 1.72\nthe element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width=\"935\" alt=\"Screenshot 2023-01-23 at 2 53 35 PM\" src=\"https://user-\"<img width=\"1247\" alt=\"Screenshot 2023-01-23 at 2 53 15 PM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-cbdaf7ff264e679897a1bc6c6cb107751e973b787d0e75212d0898b36166452c", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030\" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm-headless@5.2.0-beta.19: version \"5.2.0-beta.19\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.19.tgz#7603ffe76d42882bf72820791f8d2ba2074d7ace\" integrity sha512-MKaObf5tdeEPXfRyhWkvNbiJ4oE57rL4eDV68iXm/0yYHgW3oQf3QO1d4SMGIxWYVx70AulY6EP2VswuInXImg== xterm@5.2.0-beta.19: version \"5.2.0-beta.19\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0\" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm-headless@5.2.0-beta.20: version \"5.2.0-beta.20\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.20.tgz#5827ac8977b5ae3246cc217dccdd6eaeac01b66e\" integrity sha512-D1y4CIRvA8Izo7tAWShbyKTnxVteAy+N1j9Q+xvzcVxsGA4DLa8U7Gr2KXs3e/cjgkDcVHbbYCn7iWEyNTFvWw== xterm@5.2.0-beta.20: version \"5.2.0-beta.20\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64\" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins> yallist@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_172191"}], "negative_passages": []}
{"query_id": "q-en-vscode-d0db6a3caa0ab000093a5da0625be8e96d62772759a8d9647b2ddc51e394b92d", "query": "Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed \"echo hello\" in terminal, but there was no read-aloud feedback.\nsince the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type\nAw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.\nThanks for clarifying. I was confused by: Now I understand\nI can repro this not working in the latest stable VS Code as well. I type and it does not read\n-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.\nI have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it\n-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = \"textbox\" for this testing). works, just add textbox role and see if it works.\nthanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago\nin version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message \"too much output to announce for the command for example.\nalso just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it\nnavigation mode also works in 1.72\nthe element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width=\"935\" alt=\"Screenshot 2023-01-23 at 2 53 35 PM\" src=\"https://user-\"<img width=\"1247\" alt=\"Screenshot 2023-01-23 at 2 53 15 PM\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-36102639b96dfb80a28c69f9efc5d04915655fabc0a8c3766685a66bbcb44b71", "text": "resolved \"https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030\" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm-headless@5.2.0-beta.19: version \"5.2.0-beta.19\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.19.tgz#7603ffe76d42882bf72820791f8d2ba2074d7ace\" integrity sha512-MKaObf5tdeEPXfRyhWkvNbiJ4oE57rL4eDV68iXm/0yYHgW3oQf3QO1d4SMGIxWYVx70AulY6EP2VswuInXImg== xterm@5.2.0-beta.19: version \"5.2.0-beta.19\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0\" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm-headless@5.2.0-beta.20: version \"5.2.0-beta.20\" resolved \"https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.20.tgz#5827ac8977b5ae3246cc217dccdd6eaeac01b66e\" integrity sha512-D1y4CIRvA8Izo7tAWShbyKTnxVteAy+N1j9Q+xvzcVxsGA4DLa8U7Gr2KXs3e/cjgkDcVHbbYCn7iWEyNTFvWw== xterm@5.2.0-beta.20: version \"5.2.0-beta.20\" resolved \"https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64\" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins> y18n@^3.2.1: version \"3.2.2\"", "commid": "vscode_pr_172191"}], "negative_passages": []}
{"query_id": "q-en-vscode-c231bfb75a13f610033e82464976c1d47d6610a1ebb62c0529fdcbab30ba98a8", "query": "Testing No matter whether I use or set it to some other keybinding, I cannot seem to invoke this command with a keyboard shortcut--only from the command palette.\nI cannot repro on mac, windows, or linux, could you pls run and provide me with the logs? The terminal has to be focused btw for it to work\nYeah the terminal was focused in my testing. Weirdly enough, seems to work now--definitely wasn't working before though.\nI've run into this as well. Here's the output when turned on Toggle Keyboard Shortcuts Troubleshooting: 2023-01-24 19:45:48.902 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:48.925 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:48.925 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.404 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.405 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.405 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.435 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.482 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.483 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.513 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.514 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.514 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.544 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.545 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.545 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.577 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.577 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.578 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.608 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.608 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.609 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.641 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.642 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.642 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.643 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.643 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.673 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.673 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.674 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.674 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.675 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.703 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.703 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.704 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.735 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.736 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.736 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.767 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.768 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.768 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.798 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.799 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.799 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.844 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.844 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.845 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.845 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.845 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.877 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.877 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.878 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.878 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.879 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.907 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.908 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.909 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.909 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.910 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.916 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.917 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:49.917 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.063 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.063 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:50.063 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.483 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:50.484 [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys.\nThis was on my Surface with Windows 11. I wonder if it has to do with needing to press the Windows function key to get my F1 key? I need to do Shift + Function + F1 as without the Function key, F1 is the screen dimmer. Alt+Function+F1 works for showing the regular accessibility help. I wonder what that code is doing to work?\nThis is expected as to use , the function key needs to be activated. in the terminal does funny things on Windows/Linux, which is why we went with instead here\nOn Windows, when I set the keybinding to , it's not a valid chord and the result from the keybinding service is . That's true even when I set the weight for our action to be greater than workbench contrib. It doesn't work even when I set . Thus, we need to stick with here and the function key has to be used before pressing . !\nshift+f1 isn't working for me", "positive_passages": [{"docid": "doc-en-vscode-e89c6a49cb25467f2046dd86778c63f48d0a53cb5e015d0a3e5b1078f4a25ad4", "text": "primary: KeyMod.Alt | KeyCode.F1, weight: KeybindingWeight.WorkbenchContrib, linux: { <del> primary: KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Shift | KeyCode.F1] }, win: { primary: KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Shift | KeyCode.F1] </del> <ins> primary: KeyMod.Alt | KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Alt | KeyCode.F1] </ins> }, when: TerminalContextKeys.focus }", "commid": "vscode_pr_172409"}], "negative_passages": []}
{"query_id": "q-en-vscode-c231bfb75a13f610033e82464976c1d47d6610a1ebb62c0529fdcbab30ba98a8", "query": "Testing No matter whether I use or set it to some other keybinding, I cannot seem to invoke this command with a keyboard shortcut--only from the command palette.\nI cannot repro on mac, windows, or linux, could you pls run and provide me with the logs? The terminal has to be focused btw for it to work\nYeah the terminal was focused in my testing. Weirdly enough, seems to work now--definitely wasn't working before though.\nI've run into this as well. Here's the output when turned on Toggle Keyboard Shortcuts Troubleshooting: 2023-01-24 19:45:48.902 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:48.925 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:48.925 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.404 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.405 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.405 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.435 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.482 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.483 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.513 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.514 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.514 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.544 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.545 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.545 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.577 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.577 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.578 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.608 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.608 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.609 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.641 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.642 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.642 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.643 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.643 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.673 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.673 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.674 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.674 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.675 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.703 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.703 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.704 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.735 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.736 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.736 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.767 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.768 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.768 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.798 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.799 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.799 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.844 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.844 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.845 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.845 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.845 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.877 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.877 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.878 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.878 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.879 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.907 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.908 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.909 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.909 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.910 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.916 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.917 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:49.917 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.063 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.063 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:50.063 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.483 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:50.484 [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys.\nThis was on my Surface with Windows 11. I wonder if it has to do with needing to press the Windows function key to get my F1 key? I need to do Shift + Function + F1 as without the Function key, F1 is the screen dimmer. Alt+Function+F1 works for showing the regular accessibility help. I wonder what that code is doing to work?\nThis is expected as to use , the function key needs to be activated. in the terminal does funny things on Windows/Linux, which is why we went with instead here\nOn Windows, when I set the keybinding to , it's not a valid chord and the result from the keybinding service is . That's true even when I set the weight for our action to be greater than workbench contrib. It doesn't work even when I set . Thus, we need to stick with here and the function key has to be used before pressing . !\nshift+f1 isn't working for me", "positive_passages": [{"docid": "doc-en-vscode-b054f69127e29d662a95e5b20f15bf967ae1a9d65886b55ee7e4100e57020090", "text": "TerminalCommandId.SelectNextPageSuggestion, TerminalCommandId.AcceptSelectedSuggestion, TerminalCommandId.HideSuggestWidget, <ins> TerminalCommandId.ShowTerminalAccessibilityHelp, </ins> 'editor.action.toggleTabFocusMode', 'notifications.hideList', 'notifications.hideToasts',", "commid": "vscode_pr_172409"}], "negative_passages": []}
{"query_id": "q-en-vscode-fd967569376c8bdeacefce2493b4222e43671953cc943f52af122cc37d7e5df8", "query": "Testing Here is the description of this setting Controls whether the suggest widget becomes active when triggered via quick suggest or trigger characters. Note that the widget is always active when explicitly invoked, e.g via Ctrl+Space. It was not clear to me what active means. After trying around I figured out that its about the default selection of the first suggestion in the widget. Setting itself calls rather than . Hence I would recommend to explain in the description that this setting is about controlling the selection of the suggestion. Like Controls the selection of the options in the suggest widget when triggered via quick suggest or trigger characters. Note that the first suggestion is always selected when explicitly invoked, e.g via Ctrl+Space.\nIt's not always the first suggestion - there is yet another setting to define what element is default-\"selected\". The problem is that technically this isn't selection (because selecting inserts the item) and also not focus (because focus remains in the editor). I used selection mode because that's how VS calls it but I understand the issue and I open for a better setting name and better description. Maybe we should just talk about focus?\nI think keeping selection isn't bad but maybe the working should say \"Controls whether a suggestion is selected when triggered via quick suggest or trigger characters...\"", "positive_passages": [{"docid": "doc-en-vscode-0af901288d386c4d4f53a7d703cd05f30589a87a31eac818a4468b53534c475b", "text": "type: 'string', enum: ['always', 'never', 'whenTriggerCharacter', 'whenQuickSuggestion'], enumDescriptions: [ <del> nls.localize('suggest.insertMode.always', \"Always activate the suggest widget when triggering IntelliSense automatically.\"), nls.localize('suggest.insertMode.never', \"Never activate the suggest widget when triggering IntelliSense automatically.\"), nls.localize('suggest.insertMode.whenTriggerCharacter', \"Activate the suggest widget only when triggering IntelliSense from a trigger character.\"), nls.localize('suggest.insertMode.whenQuickSuggestion', \"Activate the suggest widget only when triggering IntelliSense as you type.\"), </del> <ins> nls.localize('suggest.insertMode.always', \"Always select a suggestion when automatically triggering IntelliSense.\"), nls.localize('suggest.insertMode.never', \"Never select a suggestion when automatically triggering IntelliSense.\"), nls.localize('suggest.insertMode.whenTriggerCharacter', \"Select a suggestion only when triggering IntelliSense from a trigger character.\"), nls.localize('suggest.insertMode.whenQuickSuggestion', \"Select a suggestion only when triggering IntelliSense as you type.\"), </ins> ], default: defaults.selectionMode, <del> markdownDescription: nls.localize('suggest.selectionMode', \"Controls whether the suggest widget becomes active when triggered via quick suggest or trigger characters. Note that the widget is always active when explicitly invoked, e.g via `Ctrl+Space`.\") </del> <ins> markdownDescription: nls.localize('suggest.selectionMode', \"Controls whether a suggestion is selected when the widget shows. Note that this only applies to automatically triggered suggestions (`#editor.quickSuggestions#` and `#editor.suggestOnTriggerCharacters#`) and that a suggestion is always selected when explicitly invoked, e.g via `Ctrl+Space`.\") </ins> }, 'editor.suggest.snippetsPreventQuickSuggestions': { type: 'boolean',", "commid": "vscode_pr_172381"}], "negative_passages": []}
{"query_id": "q-en-vscode-10323f00ea42182c6e909934260dce4dac1b875da80b2bb8664523dc7a6018dd", "query": "I took one of the suggested results from intellisense and it inserted a literal star symbol into my code ]()\nI also have been seeing this since yesterday, using JS specifically The star has always been present in the intellisense list, but never included in the text filled in.\nAlso reproduced this behaviour while verifying another issue !\nThis issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the for VS Code. See also our . If you don't know which extension is causing the problem, you can run from the command palette (F1) to help identify the problem extension. Happy Coding!\nCaused by IntelliCode:\nThis issue only occurs in Insiders, and does not occur in Stable. Downgrading to an older version of the extension also does not fix the issue. Therefore, I'm wondering whether the completions API implementation changed. the IntelliCode extension (VisualStudioExptTeam.vscodeintellicode). a new JS file. and wait for the IntelliCode completions to show up. If they don't show up, backspace and try again. The IntelliCode completions will have a star in front of them. one of the IntelliCode completions. :bug: In Insiders, the star character is to the editor.\nI've disabled Microsoft Intellicode (AI-assisted development, ID: VisualStudioExptTeam.vscodeintellicode) until they fix it back. All good for know.\nThis is somehow happening in the TypeScript extension. In the UI, when inserting the completion, we have an insert text with a leading . So, the UI is doing what it is told to do. <img width=\"1403\" alt=\"Screenshot 2023-01-27 at 09 30 21\" src=\"https://user-\"Seemingly, in the TS extension the right data is received but somehow a wrong API completion is generated <img width=\"628\" alt=\"Screenshot 2023-01-27 at 09 34 39\" src=\"https://user-\"\nMostly likely regressed via\nConfirmed. This is the faulty statement The OR-statement binds stronger than the ternary operator and therefore the label always replaces the insertText", "positive_passages": [{"docid": "doc-en-vscode-1927d3ccad168524a50c8f55f4518150caecabcf83ed6f963a4acaf9aa73a269", "text": "this.filterText = this.getFilterText(completionContext.line, tsEntry.insertText); if (completionContext.isMemberCompletion && completionContext.dotAccessorContext && !(this.insertText instanceof vscode.SnippetString)) { <del> this.filterText = completionContext.dotAccessorContext.text + (this.insertText || typeof this.label === 'string' ? this.label : this.label.label); </del> <ins> this.filterText = completionContext.dotAccessorContext.text + (this.insertText || this.textLabel); </ins> if (!this.range) { const replacementRange = this.getFuzzyWordRange(); if (replacementRange) {", "commid": "vscode_pr_172616"}], "negative_passages": []}
{"query_id": "q-en-vscode-677a06efac0f276e33f42f3f0e6296060c2cf5a03933492136801ec8db10519b", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider OS Version: Windows 11 (21H2, .1455) Steps to Reproduce: editor with CSS/SCSS syntax CSS block e.g. to use Emmet CSS completion with abbreviation of more than 1 character that no Emmet completions are provided Emmet completions seem to only be provided for single-character abbreviations: ! For multi-character abbreviations, I am not getting any results from Emmet at all: ! A of the issue suggests that it was introduced in commit as part of More testing shows some weird behaviour when providing completions, with them showing sometimes but not always when expected: Type - text is - Emmet suggests Type - text is - no suggestions Type - text is - no suggestions Type - text is - Emmet suggests Backspace - text is - Emmet suggests Backspace - text is - Emmet suggests", "positive_passages": [{"docid": "doc-en-vscode-86fa8324eb239803f48f11d077cf302c818a4e3cdefad277faf563cb2eb9541e", "text": "}); } <del> return new vscode.CompletionList(newItems); </del> <ins> return new vscode.CompletionList(newItems, true); </ins> }); } }", "commid": "vscode_pr_172581"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e166690d63c4b0c575e4de6106a94dcb1a58be52bae29a178963b9d7f67a963", "query": "off the hot exit and auto save settings an interactive window, run a cell vscode :bug: confirmation pop-up to save the IW", "positive_passages": [{"docid": "doc-en-vscode-743ed1495a7c002ef21ec70ff99b30df704faaff91db4338c5bf08e4c8ccf93a", "text": "import { NotebookTextModel } from 'vs/workbench/contrib/notebook/common/model/notebookTextModel'; import { ICellDto2, INotebookEditorModel, INotebookLoadOptions, IResolvedNotebookEditorModel, NotebookCellsChangeType, NotebookData } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { INotebookSerializer, INotebookService, SimpleNotebookProviderInfo } from 'vs/workbench/contrib/notebook/common/notebookService'; <ins> import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; </ins> import { IFileWorkingCopyManager } from 'vs/workbench/services/workingCopy/common/fileWorkingCopyManager'; import { IStoredFileWorkingCopy, IStoredFileWorkingCopyModel, IStoredFileWorkingCopyModelContentChangedEvent, IStoredFileWorkingCopyModelFactory, IStoredFileWorkingCopySaveEvent, StoredFileWorkingCopyState } from 'vs/workbench/services/workingCopy/common/storedFileWorkingCopy'; import { IUntitledFileWorkingCopy, IUntitledFileWorkingCopyModel, IUntitledFileWorkingCopyModelContentChangedEvent, IUntitledFileWorkingCopyModelFactory } from 'vs/workbench/services/workingCopy/common/untitledFileWorkingCopy';", "commid": "vscode_pr_172595"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e166690d63c4b0c575e4de6106a94dcb1a58be52bae29a178963b9d7f67a963", "query": "off the hot exit and auto save settings an interactive window, run a cell vscode :bug: confirmation pop-up to save the IW", "positive_passages": [{"docid": "doc-en-vscode-d03e742739736bb614ad89fcff20882d6018fb5c6eab060728af3f65acd71f55", "text": "private readonly _hasAssociatedFilePath: boolean, readonly viewType: string, private readonly _workingCopyManager: IFileWorkingCopyManager<NotebookFileWorkingCopyModel, NotebookFileWorkingCopyModel>, <del> @IFileService private readonly _fileService: IFileService </del> <ins> @IFileService private readonly _fileService: IFileService, @ILifecycleService lifecycleService: ILifecycleService </ins> ) { super(); <ins> if (this.viewType === 'interactive') { lifecycleService.onBeforeShutdown(async e => e.veto(this.onBeforeShutdown(), 'veto.InteractiveWindow')); } } private async onBeforeShutdown() { if (this._workingCopy?.isDirty()) { await this._workingCopy.save(); } return false; </ins> } override dispose(): void {", "commid": "vscode_pr_172595"}], "negative_passages": []}
{"query_id": "q-en-vscode-68e7bc6834d333497bcbdc92c50dffcf0fe0e4c02c95682ba79abeef4c62c84b", "query": "In virtual workspaces, the file dialog has a button. There's no such dialog in remote windows--the file dialog always shows the remote filesystem. This is an issue for continuing from a GitHub codespace to a local desktop clone when the user is in VS Code desktop. Suggestion: when in a virtual or remote window on desktop, always have the 'Show Local' option in the file dialog.\nOh interesting--there is a Show Local in the Open Folder flow, but not when the git extension invokes the file dialog: <img width=\"671\" alt=\"image\" src=\"https://user-\"\nI see this was an intentional decision for extension access to the simple file dialog in a remote window in for However that makes it hard to go from a remote window to a local one from extension land. Is this something that we can expose to extensions via a new proposed api option for the file dialog?\nDuplicate of , which is an API request to expose \"show local\".\nReopening this to track adoption of in the Continue On flow.\nSteps: Open a codespace in VS Code desktop From the remote indicator, choose Continue in Local Clone Ensure that the repo gets cloned successfully to your local machine", "positive_passages": [{"docid": "doc-en-vscode-a6987ea1d64a1f5a2532dff79cad53f417bb3ede57d0ce2da98b6d3174b82543", "text": "if (uri !== undefined) { // Launch desktop client if currently in web <ins> let target = `${env.uriScheme}://vscode.git/clone?url=${encodeURIComponent(uri)}`; </ins> if (env.uiKind === UIKind.Web) { <del> let target = `${env.uriScheme}://vscode.git/clone?url=${encodeURIComponent(uri)}`; </del> if (ref !== undefined) { target += `&ref=${encodeURIComponent(ref)}`; } return Uri.parse(target); } <del> // If already in desktop client, directly clone </del> <ins> // If already in desktop client but in a remote window, we need to force a new window // so that the git extension can access the local filesystem for cloning if (env.remoteName !== undefined) { target += `&windowId=_blank`; return Uri.parse(target); } // Otherwise, directly clone </ins> void this.clone(uri, undefined, { ref: ref }); } }", "commid": "vscode_pr_187301"}], "negative_passages": []}
{"query_id": "q-en-vscode-8d52cfbaa433d11f7535f7310cb399d634bc640d2011209449e7c92033b9b822", "query": "Type: <bBug</btypescript server keeps crashing after the latest update VSCODE ! I can reproduce this with all the extensions disabled. LOG: ! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-03T05:23:17.202Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ ng-template15.1.0 atlascode3.0.1 vscode-markdownlint0.49.0 vscode-eslint2.2.6 githistory0.6.19 gitlens13.2.0 prettier-vscode9.10.4 vscode-yaml1.11.0 sonarlint-vscode3.14.0 code-spell-checker2.16.0 vscode-stylelint1.2.3 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nPlease try collecting the TS Server log from the crashed instance: VS Code and reproduce the problem the section of the output panel the very top, find the first line that prints to path to the semantic error log file. It should look something like: That file contains the typescript logs. Look through that log file for the first error or stack trace you see. If you can share the log, I can also take a look to see if anything stands out\n, for some reason the log file location is shown as [Object object] (as pointed out by the pink arrow), I checked in the folder pointed out by the red arrow and the folder is empty. ! I have checked this for multiple folder I could see in the log prompt but all of them are empty.\na Microsoft member created same/duplicate issue , in case this could help with the debugging\nConfirming that I also see when using verbose setting and all the log files are empty for me, which is also noted and shown on microsoft/vscode.\nFor me the directory under the object object is also empty, is that the case with you?\nYes, same.\nshould be fixed in the next insider release: microsoft/vscode\nthe object object issue is resolved, however, the file pointed by the log still does not exist. can you give it a try if you can see the logs?\ni did some commenting in the file and found that commenting out setting stops the repeated crash. Note: I am not sure why I have /enabled this setting in the first place.\nOh wow, exactly the same for me. I also do not remember ever setting , but it was in my and removing it fixes the crash for me too!\nAlso confirming that with latest update is fixed but log directories are still empty. I've closed my bug as a duplicate of this one since it's pretty clear these are the same issue now. Are you able to repro using is Also do you know if this would ever have been set on user's behalf, which could impact the severity here if lots of people would have this in their settings?\nThanks and I can confirm that enabling cause the server to crash on windows. Oddly I don't see it on Mac. The server is likely crashing before logging can start too, which is why the log files don't exist I'm not sure how this setting got enabled for you. It's only meant for detailed performance investigations and should never be turned on automatically\nYay, thank you and", "positive_passages": [{"docid": "doc-en-vscode-0da10ffef4e5f9f5c21f086278b7c6b5e7af00db7f48113dbd4d0e81235d84d1", "text": "if (configuration.enableTsServerTracing) { if (tsServerTraceDirectory) { <del> this._logger.info(`<${kind}> Trace directory: ${tsServerTraceDirectory}`); </del> <ins> this._logger.info(`<${kind}> Trace directory: ${tsServerTraceDirectory.fsPath}`); </ins> } else { this._logger.error(`<${kind}> Could not create trace directory`); }", "commid": "vscode_pr_173856"}], "negative_passages": []}
{"query_id": "q-en-vscode-8d52cfbaa433d11f7535f7310cb399d634bc640d2011209449e7c92033b9b822", "query": "Type: <bBug</btypescript server keeps crashing after the latest update VSCODE ! I can reproduce this with all the extensions disabled. LOG: ! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-03T05:23:17.202Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ ng-template15.1.0 atlascode3.0.1 vscode-markdownlint0.49.0 vscode-eslint2.2.6 githistory0.6.19 gitlens13.2.0 prettier-vscode9.10.4 vscode-yaml1.11.0 sonarlint-vscode3.14.0 code-spell-checker2.16.0 vscode-stylelint1.2.3 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nPlease try collecting the TS Server log from the crashed instance: VS Code and reproduce the problem the section of the output panel the very top, find the first line that prints to path to the semantic error log file. It should look something like: That file contains the typescript logs. Look through that log file for the first error or stack trace you see. If you can share the log, I can also take a look to see if anything stands out\n, for some reason the log file location is shown as [Object object] (as pointed out by the pink arrow), I checked in the folder pointed out by the red arrow and the folder is empty. ! I have checked this for multiple folder I could see in the log prompt but all of them are empty.\na Microsoft member created same/duplicate issue , in case this could help with the debugging\nConfirming that I also see when using verbose setting and all the log files are empty for me, which is also noted and shown on microsoft/vscode.\nFor me the directory under the object object is also empty, is that the case with you?\nYes, same.\nshould be fixed in the next insider release: microsoft/vscode\nthe object object issue is resolved, however, the file pointed by the log still does not exist. can you give it a try if you can see the logs?\ni did some commenting in the file and found that commenting out setting stops the repeated crash. Note: I am not sure why I have /enabled this setting in the first place.\nOh wow, exactly the same for me. I also do not remember ever setting , but it was in my and removing it fixes the crash for me too!\nAlso confirming that with latest update is fixed but log directories are still empty. I've closed my bug as a duplicate of this one since it's pretty clear these are the same issue now. Are you able to repro using is Also do you know if this would ever have been set on user's behalf, which could impact the severity here if lots of people would have this in their settings?\nThanks and I can confirm that enabling cause the server to crash on windows. Oddly I don't see it on Mac. The server is likely crashing before logging can start too, which is why the log files don't exist I'm not sure how this setting got enabled for you. It's only meant for detailed performance investigations and should never be turned on automatically\nYay, thank you and", "positive_passages": [{"docid": "doc-en-vscode-4e2c9756286e3e2cc9762112d21c7d8eb1c64215bbea50e077a568c7cb554434", "text": "if (configuration.enableTsServerTracing && !isWeb()) { tsServerTraceDirectory = this._logDirectoryProvider.getNewLogDirectory(); if (tsServerTraceDirectory) { <del> args.push('--traceDirectory', tsServerTraceDirectory.path); </del> <ins> args.push('--traceDirectory', tsServerTraceDirectory.fsPath); </ins> } }", "commid": "vscode_pr_173856"}], "negative_passages": []}
{"query_id": "q-en-vscode-6d54c3215fd52e53057e440cc30c5d5f00e312cce7b969c2c99c286108d26cf5", "query": "Bug The the following entry in its : This seems to cause the python extension to be activated whenever a json file is opened, even though the extension does not provide any json language support This was possibly caused by the move to automatic activation events\nI think my initial implementation of implicit activation was perhaps too naive. There seem to be a few issues: It's possible to have a language configuration extension that doesn't contribute any code, and we would now attempt to activate such an extension (this is a noop if there is no main/browser entrypoint in , but results in unnecessary activation if all that's required is a language configuration) the bigger issue is that an extension which contributes extensions, filenames, filenamePatterns, firstLine, or mimeTypes for a language will now get activated anytime the language appears I think it's maybe reasonable to preserve the existing implicit activation behavior if an alias is defined for all of the others, we shouldn't infer , or we should perhaps keep track of the filenames/filenamePatterns etc and activate the extension with the language contribution matching the specified pattern? I know of at least two extensions which are impacted by the current behavior MakeCode Python\n:+1: This makes good sense to me. We will infer only for the one which is the \"main\" language definition, and the best evidence of that is the alias property. I wouldn't do anything beyond that (i.e. tracking filenames, patterns, etc.)\nWould the presence of the property be better evidence of a contribution being the main language definition?\ninjection based syntax highlighting can still have a configuration file", "positive_passages": [{"docid": "doc-en-vscode-b5a2b68ebcd7053458140bd6519bc72c1ae98356409e653c2623405cbf9c0648", "text": "const languageContributions = findNodeAtLocation(tree, ['contributes', 'languages']); languageContributions?.children?.forEach(child => { const id = findNodeAtLocation(child, ['id']); <del> if (id && id.type === 'string') { </del> <ins> const configuration = findNodeAtLocation(child, ['configuration']); if (id && id.type === 'string' && configuration && configuration.type === 'string') { </ins> activationEvents.add(`onLanguage:${id.value}`); } });", "commid": "vscode_pr_179287"}], "negative_passages": []}
{"query_id": "q-en-vscode-6d54c3215fd52e53057e440cc30c5d5f00e312cce7b969c2c99c286108d26cf5", "query": "Bug The the following entry in its : This seems to cause the python extension to be activated whenever a json file is opened, even though the extension does not provide any json language support This was possibly caused by the move to automatic activation events\nI think my initial implementation of implicit activation was perhaps too naive. There seem to be a few issues: It's possible to have a language configuration extension that doesn't contribute any code, and we would now attempt to activate such an extension (this is a noop if there is no main/browser entrypoint in , but results in unnecessary activation if all that's required is a language configuration) the bigger issue is that an extension which contributes extensions, filenames, filenamePatterns, firstLine, or mimeTypes for a language will now get activated anytime the language appears I think it's maybe reasonable to preserve the existing implicit activation behavior if an alias is defined for all of the others, we shouldn't infer , or we should perhaps keep track of the filenames/filenamePatterns etc and activate the extension with the language contribution matching the specified pattern? I know of at least two extensions which are impacted by the current behavior MakeCode Python\n:+1: This makes good sense to me. We will infer only for the one which is the \"main\" language definition, and the best evidence of that is the alias property. I wouldn't do anything beyond that (i.e. tracking filenames, patterns, etc.)\nWould the presence of the property be better evidence of a contribution being the main language definition?\ninjection based syntax highlighting can still have a configuration file", "positive_passages": [{"docid": "doc-en-vscode-0367c9fd0d0f8af09c85a6810028ad4bc7c71e16166505ac44eabd27bc035f6b", "text": "}, activationEventsGenerator: (languageContributions, result) => { for (const languageContribution of languageContributions) { <del> if (languageContribution.id) { </del> <ins> if (languageContribution.id && languageContribution.configuration) { </ins> result.push(`onLanguage:${languageContribution.id}`); } }", "commid": "vscode_pr_179287"}], "negative_passages": []}
{"query_id": "q-en-vscode-a1c99d95745e67e4b48bdb8017e023e8c4d67e4a3209690a69bb8d5db159952d", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.1 OS Version: MacOS Ventura 13.2 (22D49) I'm using VS Code to debug an attached Node app. The problem is that each time that I restart the Node app, new pseudo targets are to the \"Select Debug Console\" dropdown of the debug console. Problem started in 1.75.0. In prior versions, only the \"Server\" target would appear after restarts (I'm debugging in multiple target environment, so the dropdown is always visible). Since 1.75.0 (and .1), two new targets are to this list (webpack + ) after each restart. Here's how this dropdown looks like after 3 restarts: <img width=\"431\" alt=\"Screenshot 2023-02-09 at 12 39 52 PM\" src=\"https://user-\"A similar issue happens when attempting to debug a React app - each reattach adds a new pseudo target to the list. The targets that are to the debug dropdown are \"stale\" - switching to one of these pseudo items shows an empty debug console. Steps to Reproduce: debugging a JS app that is connected via the attach debug mode the debug console the app using the \"restart\" icon on the debug panel on the Select Debug Console dropdown, and observe new pseudo targets have been to the list (and on each subsequent restart) I tested the same configuration with VSCode 1.74.3, and the problem does not appear.\nI noticed this, I haven't looked into it at all but wondering whether it's related somehow to\nThis is a pain, I often restart my server process and I just see this slowly building list of old server processes. I don't need to keep their logs behind, it just clogs the doprdown. <img width=\"309\" alt=\"Screenshot 2023-02-22 at 8 48 24 pm\" src=\"https://user-\"\nignore my last comment... I found the setting Debug \u203a Console: Close On End was 'off' by default. Turning it on resolved the problem\nYea this looks expected since we have a process ID as part of the session name, so they get unique terminals. Could argue we shouldn't... but we do, and I've found it handy on more than one occasion\nThe problem persists after turning on Debug \u203a Console: Close On End (on version 1.75.1). When the said option is on, the terminal/console pane indeed closes when debug stops, but when I restart the process, the pane re-shows with the \"select debug console\" dropdown populated with the terminated processes. In any case, the problem surfaced in 1.75.0 so I still think there's a bug (or undocumented fix) that contributes to this issue. May I suggest to re-open the issue?\nfollowing up - this is still an issue and there's no fix nor a workaround. Can you please re-open the issue so that someone can give it a second look?\nYep, thanks for the ping. This was hanging out in my notification queue but forgot to reopen it", "positive_passages": [{"docid": "doc-en-vscode-bf93d70278b9273898f6dcef59d859ff3ce7677ee334d5afd09de4004be5d60e", "text": "const parent = this._options.parentSession; if (parent) { toDispose.add(parent.onDidEndAdapter(() => { <del> // copy the parent repl and get a new detached repl for this child if (!this.hasSeparateRepl()) { </del> <ins> // copy the parent repl and get a new detached repl for this child, and // remove its parent, if it's still running if (!this.hasSeparateRepl() && this.raw?.isInShutdown === false) { </ins> this.repl = this.repl.clone(); replListener.value = this.repl.onDidChangeElements(() => this._onDidChangeREPLElements.fire()); <ins> this.parentSession = undefined; </ins> } <del> this.parentSession = undefined; </del> })); } }", "commid": "vscode_pr_178607"}], "negative_passages": []}
{"query_id": "q-en-vscode-a1c99d95745e67e4b48bdb8017e023e8c4d67e4a3209690a69bb8d5db159952d", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.1 OS Version: MacOS Ventura 13.2 (22D49) I'm using VS Code to debug an attached Node app. The problem is that each time that I restart the Node app, new pseudo targets are to the \"Select Debug Console\" dropdown of the debug console. Problem started in 1.75.0. In prior versions, only the \"Server\" target would appear after restarts (I'm debugging in multiple target environment, so the dropdown is always visible). Since 1.75.0 (and .1), two new targets are to this list (webpack + ) after each restart. Here's how this dropdown looks like after 3 restarts: <img width=\"431\" alt=\"Screenshot 2023-02-09 at 12 39 52 PM\" src=\"https://user-\"A similar issue happens when attempting to debug a React app - each reattach adds a new pseudo target to the list. The targets that are to the debug dropdown are \"stale\" - switching to one of these pseudo items shows an empty debug console. Steps to Reproduce: debugging a JS app that is connected via the attach debug mode the debug console the app using the \"restart\" icon on the debug panel on the Select Debug Console dropdown, and observe new pseudo targets have been to the list (and on each subsequent restart) I tested the same configuration with VSCode 1.74.3, and the problem does not appear.\nI noticed this, I haven't looked into it at all but wondering whether it's related somehow to\nThis is a pain, I often restart my server process and I just see this slowly building list of old server processes. I don't need to keep their logs behind, it just clogs the doprdown. <img width=\"309\" alt=\"Screenshot 2023-02-22 at 8 48 24 pm\" src=\"https://user-\"\nignore my last comment... I found the setting Debug \u203a Console: Close On End was 'off' by default. Turning it on resolved the problem\nYea this looks expected since we have a process ID as part of the session name, so they get unique terminals. Could argue we shouldn't... but we do, and I've found it handy on more than one occasion\nThe problem persists after turning on Debug \u203a Console: Close On End (on version 1.75.1). When the said option is on, the terminal/console pane indeed closes when debug stops, but when I restart the process, the pane re-shows with the \"select debug console\" dropdown populated with the terminated processes. In any case, the problem surfaced in 1.75.0 so I still think there's a bug (or undocumented fix) that contributes to this issue. May I suggest to re-open the issue?\nfollowing up - this is still an issue and there's no fix nor a workaround. Can you please re-open the issue so that someone can give it a second look?\nYep, thanks for the ping. This was hanging out in my notification queue but forgot to reopen it", "positive_passages": [{"docid": "doc-en-vscode-bcf6cbdd05e6bf341f322c68219e7b545c083018dde80e10bb3417017fc37240", "text": "this.debugAdapter.onRequest(request => this.dispatchRequest(request)); } <ins> get isInShutdown() { return this.inShutdown; } </ins> get onDidExitAdapter(): Event<AdapterEndEvent> { return this._onDidExitAdapter.event; }", "commid": "vscode_pr_178607"}], "negative_passages": []}
{"query_id": "q-en-vscode-7fea204166958b4d06550a1334b0481916acdcf2c8ac7417270e2addcdf68fdb", "query": "This is a legit error about a bad URI that came from a debug adapter but I guess we shouldn't send telemetry", "positive_passages": [{"docid": "doc-en-vscode-93582fb2857f6a71b5b15d024e0432f95c6063ab9deadbb6595879461a73ae5c", "text": "if (typeof raw.sourceReference === 'number' && raw.sourceReference > 0) { return URI.from({ scheme: DEBUG_SCHEME, <del> path, </del> <ins> path: path?.replace(/^/+/g, '/'), // #174054 </ins> query: `session=${sessionId}&ref=${raw.sourceReference}` }); }", "commid": "vscode_pr_201032"}], "negative_passages": []}
{"query_id": "q-en-vscode-264d912b505a074aa81e978455fa20a2d29dee3486c7e63af91fb024ed0ced49", "query": "Shell integration offers many improvements to the terminal experience and makes it more accessible via commands like . reported that he and many others use which does not have shell integration. Should we include a hint in the help menu that the experience could be better when we detect a screen reader & ?\nI think this will improve the discoverability! Voting for this idea.\nOn windows, Create a terminal - via for example. run . Verify that you see a message about migrating to use powershell.", "positive_passages": [{"docid": "doc-en-vscode-d81a6dd02eac22c5714199434077955f017ac850b1fb28468897e7c442ae5029", "text": "const newWithProfile = nls.localize('newWithProfile', 'The Create New Terminal (With Profile) ({0}) command allows for easy terminal creation using a specific profile.'); const newWithProfileNoKb = nls.localize('newWithProfileNoKb', 'The Create New Terminal (With Profile) command allows for easy terminal creation using a specific profile and is currently not triggerable by a keybinding.'); const accessibilitySettings = nls.localize('accessibilitySettings', 'Access accessibility settings such as `terminal.integrated.tabFocusMode` via the Preferences: Open Accessibility Settings command.'); <ins> const commandPrompt = nls.localize('commandPromptMigration', \"Consider using powershell instead of command prompt for an improved experience\"); </ins> class AccessibilityHelpWidget extends Widget implements ITerminalWidget { readonly id = 'help'; private _container: HTMLElement | undefined;", "commid": "vscode_pr_175585"}], "negative_passages": []}
{"query_id": "q-en-vscode-264d912b505a074aa81e978455fa20a2d29dee3486c7e63af91fb024ed0ced49", "query": "Shell integration offers many improvements to the terminal experience and makes it more accessible via commands like . reported that he and many others use which does not have shell integration. Should we include a hint in the help menu that the experience could be better when we detect a screen reader & ?\nI think this will improve the discoverability! Voting for this idea.\nOn windows, Create a terminal - via for example. run . Verify that you see a message about migrating to use powershell.", "positive_passages": [{"docid": "doc-en-vscode-3a92ab84c71eae5e5ceffb2f4b7f0eab5b92631b9ddc0ace96e848e1c14bd070", "text": "private readonly _markdownRenderer: MarkdownRenderer; constructor( <del> instance: ITerminalInstance, </del> <ins> private readonly _instance: ITerminalInstance, </ins> @IKeybindingService private readonly _keybindingService: IKeybindingService, @IInstantiationService instantiationService: IInstantiationService, @IOpenerService private readonly _openerService: IOpenerService ) { super(); <del> this._hasShellIntegration = instance.xterm?.shellIntegration.status === ShellIntegrationStatus.VSCode; </del> <ins> this._hasShellIntegration = _instance.xterm?.shellIntegration.status === ShellIntegrationStatus.VSCode; </ins> this._domNode = createFastDomNode(document.createElement('div')); this._contentDomNode = createFastDomNode(document.createElement('div')); this._contentDomNode.setClassName('terminal-accessibility-help');", "commid": "vscode_pr_175585"}], "negative_passages": []}
{"query_id": "q-en-vscode-264d912b505a074aa81e978455fa20a2d29dee3486c7e63af91fb024ed0ced49", "query": "Shell integration offers many improvements to the terminal experience and makes it more accessible via commands like . reported that he and many others use which does not have shell integration. Should we include a hint in the help menu that the experience could be better when we detect a screen reader & ?\nI think this will improve the discoverability! Voting for this idea.\nOn windows, Create a terminal - via for example. run . Verify that you see a message about migrating to use powershell.", "positive_passages": [{"docid": "doc-en-vscode-9d2002f45b229436351578b1d1098c7368abd211a1da7586cb10c15fc0a0a931", "text": "this._register(dom.addStandardDisposableListener(this._contentDomNode.domNode, 'keydown', (e) => { if (e.keyCode === KeyCode.Escape) { this.hide(); <del> instance.focus(); </del> <ins> _instance.focus(); </ins> } })); <del> this._register(instance.onDidFocus(() => this.hide())); </del> <ins> this._register(_instance.onDidFocus(() => this.hide())); </ins> this._markdownRenderer = this._register(instantiationService.createInstance(MarkdownRenderer, {})); }", "commid": "vscode_pr_175585"}], "negative_passages": []}
{"query_id": "q-en-vscode-264d912b505a074aa81e978455fa20a2d29dee3486c7e63af91fb024ed0ced49", "query": "Shell integration offers many improvements to the terminal experience and makes it more accessible via commands like . reported that he and many others use which does not have shell integration. Should we include a hint in the help menu that the experience could be better when we detect a screen reader & ?\nI think this will improve the discoverability! Voting for this idea.\nOn windows, Create a terminal - via for example. run . Verify that you see a message about migrating to use powershell.", "positive_passages": [{"docid": "doc-en-vscode-f2ff2dddbec1d31712c06fe608587bb3685299b56ba9ab68b1cf7a67fa8441c0", "text": "private _buildContent(): void { const content = []; content.push(this._descriptionForCommand(TerminalCommandId.FocusAccessibleBuffer, focusAccessibleBufferNls, focusAccessibleBufferNoKb)); <ins> if (this._instance.shellType === WindowsShellType.CommandPrompt) { content.push(commandPrompt); } </ins> if (this._hasShellIntegration) { content.push(shellIntegration); content.push('- ' + this._descriptionForCommand(TerminalCommandId.RunRecentCommand, runRecentCommand, runRecentCommandNoKb) + 'n- ' + this._descriptionForCommand(TerminalCommandId.GoToRecentDirectory, goToRecent, goToRecentNoKb));", "commid": "vscode_pr_175585"}], "negative_passages": []}
{"query_id": "q-en-vscode-4b570fd5d2243b92601d3d3097bb7aed72d75cc268154861f06a2c05a706cd75", "query": "In our menu, we should mention setting\nI actually think we should more broadly mention how to find accessibility settings here -", "positive_passages": [{"docid": "doc-en-vscode-58945a2112ba6d15f5840bae6f644458abcea58995604020426e312cfddc594c", "text": "const dismiss = nls.localize('dismiss', \"You can dismiss this dialog by pressing Escape or focusing elsewhere.\"); const openDetectedLink = nls.localize('openDetectedLink', 'The Open Detected Link ({0}) command enables screen readers to easily open links found in the terminal.'); const openDetectedLinkNoKb = nls.localize('openDetectedLinkNoKb', 'The Open Detected Link command enables screen readers to easily open links found in the terminal and is currently not triggerable by a keybinding.'); <ins> const newWithProfile = nls.localize('newWithProfile', 'The Create New Terminal (With Profile) ({0}) command allows for easy terminal creation using a specific profile.'); const newWithProfileNoKb = nls.localize('newWithProfileNoKb', 'The Create New Terminal (With Profile) command command allows for easy terminal creation using a specific profile and is currently not triggerable by a keybinding.'); const accessibilitySettings = nls.localize('accessibilitySettings', 'Access accessibility settings such as `terminal.integrated.tabFocusMode` via the Preferences: Open Accessibility Settings command.'); </ins> class AccessibilityHelpWidget extends Widget implements ITerminalWidget { readonly id = 'help';", "commid": "vscode_pr_174726"}], "negative_passages": []}
{"query_id": "q-en-vscode-4b570fd5d2243b92601d3d3097bb7aed72d75cc268154861f06a2c05a706cd75", "query": "In our menu, we should mention setting\nI actually think we should more broadly mention how to find accessibility settings here -", "positive_passages": [{"docid": "doc-en-vscode-324d2e451a670d271998f12213eae62a72c87c87560283751bffea7ac0c75335", "text": "content.push('- ' + this._descriptionForCommand(TerminalCommandId.RunRecentCommand, runRecentCommand, runRecentCommandNoKb) + 'n- ' + this._descriptionForCommand(TerminalCommandId.GoToRecentDirectory, goToRecent, goToRecentNoKb)); } content.push(this._descriptionForCommand(TerminalCommandId.OpenDetectedLink, openDetectedLink, openDetectedLinkNoKb)); <ins> content.push(this._descriptionForCommand(TerminalCommandId.NewWithProfile, newWithProfile, newWithProfileNoKb)); content.push(accessibilitySettings); </ins> content.push(readMoreLink, dismiss); const element = renderElementAsMarkdown(this._markdownRenderer, this._openerService, content.join('nn'), this._register(new DisposableStore())); const anchorElements = element.querySelectorAll('a');", "commid": "vscode_pr_174726"}], "negative_passages": []}
{"query_id": "q-en-vscode-7864defa3c4002e55525a8e5df98722442be9b9007db2106bd069c3c28118b71", "query": "It should be outside of the output region <img width=\"962\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-3fc132c40639be9de7acfd4ec71548cca0d5bcc3c9f66ff9049baf44552fa2c9", "text": ".traceback.wordWrap span { white-space: pre-wrap; } <del> .output > .scrollable { </del> <ins> .output .scrollable { </ins> overflow-y: scroll; max-height: var(--notebook-cell-output-max-height); border: var(--vscode-editorWidget-border);", "commid": "vscode_pr_174639"}], "negative_passages": []}
{"query_id": "q-en-vscode-7864defa3c4002e55525a8e5df98722442be9b9007db2106bd069c3c28118b71", "query": "It should be outside of the output region <img width=\"962\" alt=\"image\" src=\"https://user-\"", "positive_passages": [{"docid": "doc-en-vscode-a6d2cfcbe59353de1425c1aae7c74cba3d9daf2f4562761470a7a8b9a4783eb5", "text": "} function scrollableArrayOfString(id: string, buffer: string[], container: HTMLElement, trustHtml: boolean) { <del> container.classList.add('scrollable'); </del> <ins> const scrollableDiv = document.createElement('div'); scrollableDiv.classList.add('scrollable'); </ins> if (buffer.length > 5000) { container.appendChild(generateViewMoreElement(id, false)); } <del> const div = document.createElement('div'); container.appendChild(div); div.appendChild(handleANSIOutput(buffer.slice(0, 5000).join('n'), trustHtml)); </del> <ins> container.appendChild(scrollableDiv); scrollableDiv.appendChild(handleANSIOutput(buffer.slice(0, 5000).join('n'), trustHtml)); </ins> } export function insertOutput(id: string, outputs: string[], linesLimit: number, scrollable: boolean, container: HTMLElement, trustHtml: boolean) {", "commid": "vscode_pr_174639"}], "negative_passages": []}
{"query_id": "q-en-vscode-7cea5538de366b50ffbed225d86acdb960f0ceb68e95311592cd5f8601e5678a", "query": "Testing have search view open drag the explorer icon onto it the explorer (and npm script) views show the explorer icon stays in the activity bar, the view is empty https://user-", "positive_passages": [{"docid": "doc-en-vscode-a496df927a59b4e7b68d87132ab14a1775356385fe9aa554f2b2498d4d8f63b8", "text": "storageId: 'workbench.explorer.views.state', icon: explorerViewIcon, alwaysUseContainerInfo: true, <ins> hideIfEmpty: true, </ins> order: 0, openCommandActionDescriptor: { id: VIEWLET_ID,", "commid": "vscode_pr_175132"}], "negative_passages": []}
{"query_id": "q-en-vscode-62de6bf46835644b07dc9b38de6902e89ab63a3cdb325bfb7df5730727ec0ff8", "query": "Testing Have the following code in an notebook cell. Run the code Scroll the output. Notice as your scroll reaches the top you can continue scrolling and it will scroll the whole notebook file. This is unexpected and I think no other widget in VS Code behaves this way. I suggest instead the following strategy when scrolling: If a mouse is in the Cell then scrolling it will only scroll that cell. You can not scroll the large notebook while the mouse is in the cell. Same way you can not scroll the Cell with the mouse unless the mouse is in the cell IMHO this is what makes the current experience feel weird.\nWe don't often have nested scrollable elements in VS Code workbench and also this is how browsers handle nested scrolling. Current behavior feels right to me. I can see the value of scrolling only when the focus is inside/on the output, there is a catch with that though, users need to move cursor to outside of the cell output to scroll the notebook, and the hit area for that is very narrow most of the time.\nThanks for providing more info. But what other UI element scrolls like the notebook does right now - so that you can scroll the element until it hits the end, and then if you continue scrolling that the outer element starts scrolling? This really felt unnatural to me, but I might have missed this pattern in other parts of the workbench. Or what do other Notebooks products do in this case?\nthe peek view actually behaves this way. That's the only other nested scrollable element that I know of.\nThanks! If I am the only user that it complaining feel free to close this one as designed :)\nI tried using notebook in VSCode again last week, and came to GitHub to open this exact issue. I feel this scroll is extremely unintuitive. Here's an example. A cell is outputting more lines than , so we're currently viewing it's last line. I want to scroll to top. I speed scroll up, but this reaches the top and keeps scrolling the notebook, so now I'm all the way up. I have to scroll back down to my cell. If I go fast, I might miss it. If I go slowly, some other cell's output might catch my scroll and scroll that to bottom, before the notebook scrolls again. Same happens to my cell. I need to be frustratingly precise to scroll this output to the top. Here's a recording to illustrate (I hope you can see it, recorded on MacOS, encoded as AV1; can add YT link if not viewable here): It took me 15 seconds to manage to get that top. And I knew exactly what I wanted to achieve, for the sake of the video. Now here's the same experience in native Jupyter Notebook (exact same notebook and cell). First, I can easily toggle the output scrolling. If untoggled, the output scrolls natively with the notebook, and since it expands downwards, without the notebook jumping, I can immediately see the top, which is right next to the cell. Then I toggle the scrolling again, to illustrate the behaviour compared to VSCode. I initiate scrolling inside the output area, and so only that area is scrolled. No matter the speed, or direction, I can easily reach the top or bottom as many times as I need, without losing context of my notebook. If I do want to scroll the notebook, I need to scroll outside the output area. This is easy because the cell does not take the whole width. This is in relation to what said above: Yes, but the cell does not need to take the complete visible width. In native notebook, cell's width is limited, and there's still plenty of space for code. But even if the cell does take the entire width, the user can initiate the scrolling outside the output area, i.e. over a cell. In this case, it scrolls the notebook, and never the outputs. The outputs do not steal the scrolling from the notebook, like it happens in VSCode. So: scroll initiated on cell or outside the cells area -scrolls notebook only, never output scroll initated in scrollable output area -scrolls only that output area, never the notebook\nshould we reopen this? What do you think?\nsure, that's a reasonable request. It would be inconsistent with how the peek view scroll works, but the possibility for many scrollable regions makes these cases more noticeable in notebooks. - one thing that might help - you can toggle output scrollability per output in vscode as well with , by default\nI have the same issue. The usability of the scrollable element suffers greatly due to the current crazy behavior - when the scrolling inertia reaches the end of the scrollable output and scrolls the whole notebook! If different users want different behavior, this can be an option in the settings, e.g.: current behavior behavior like in the native Jupyter Notebook (in the video above), i.e. the notebook never scrolls if the pointer is inside the scrollable element there may be a 3rd option: the scroll that reaches the end of scrollable area doesn't scroll the notebook, but the subsequent scrolls in the same direction (even if the mouse pointer is inside the scrollable area) - scroll the notebook\nfor verification, please check with a mouse wheel and scrolling with a trackpad, since they behave quite differently. Hitting the boundary of the inner scrollable region will prevent further scrolling for that same scroll action. After a short pause you should then be able to scroll the outer region since the inner region can't be scrolled any further. (similar behavior to a browser)\nVerified on trackpad. Still have to verify with a mouse wheel.\nverified on mouse! there was a pause/delay, but wonder if there should be a larger delay - I find that sometimes I spam scroll and it moved up a little quicker than I anticipated. if it matches browser tho, should be all good ~\nhello , thank you a lot for the work on this issue! I hate to say this, but I think it's not solved: It looks like only a certain \"scroll length\" is ignored, and the rest of the scroll inertia is still applied. Here I do: one fast scroll (as you see, the notebook moves) then I scroll back down then one fast (a bit slower) scroll (the notebook moves) Only if the scroll isn't fast enough the \"scroll length\" will be small enough to be completely ignored. <br /Here I do: one long scroll - all the way until the end of the video: <br /The behavior in the native jupyter notebook is certainly different. Here I do: one fast scroll - different than in VSCode (the notebook doesn't move) one long scroll- different than in VSCode (the notebook doesn't move) one after-scroll (the notebook moves as expected) Could this issue please be re-opened?\nwhich version of vscode was this on?\nVersion: 1.88.0 (Universal) Commit: Date: 2024-04-03T13:28:18.899Z (1 day ago) Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.3.0\nok, yeah. looks like I broke the behavior with a related bugfix\nVersion: 1.89.0 - still isn't completely fixed: If I scroll hard enough, the notebook scrolls.", "positive_passages": [{"docid": "doc-en-vscode-635495ca396b526a54311a9c758d41b78bc3a8f5823d4d43549de35e55636295", "text": "} }; <del> function scrollWillGoToParent(event: WheelEvent) { </del> <ins> let scrollTimeout: any /* NodeJS.Timeout */ | undefined; let scrolledElement: Element | undefined; function flagRecentlyScrolled(node: Element) { scrolledElement = node; node.setAttribute('recentlyScrolled', 'true'); clearTimeout(scrollTimeout); scrollTimeout = setTimeout(() => { scrolledElement?.removeAttribute('recentlyScrolled'); }, 300); } function eventTargetShouldHandleScroll(event: WheelEvent) { </ins> for (let node = event.target as Node | null; node; node = node.parentNode) { if (!(node instanceof Element) || node.id === 'container' || node.classList.contains('cell_container') || node.classList.contains('markup') || node.classList.contains('output_container')) { return false; } <ins> if (node.hasAttribute('recentlyScrolled') && scrolledElement === node) { flagRecentlyScrolled(node); return true; } </ins> // scroll up if (event.deltaY < 0 && node.scrollTop > 0) { // there is still some content to scroll <ins> flagRecentlyScrolled(node); </ins> return true; }", "commid": "vscode_pr_206642"}], "negative_passages": []}
{"query_id": "q-en-vscode-62de6bf46835644b07dc9b38de6902e89ab63a3cdb325bfb7df5730727ec0ff8", "query": "Testing Have the following code in an notebook cell. Run the code Scroll the output. Notice as your scroll reaches the top you can continue scrolling and it will scroll the whole notebook file. This is unexpected and I think no other widget in VS Code behaves this way. I suggest instead the following strategy when scrolling: If a mouse is in the Cell then scrolling it will only scroll that cell. You can not scroll the large notebook while the mouse is in the cell. Same way you can not scroll the Cell with the mouse unless the mouse is in the cell IMHO this is what makes the current experience feel weird.\nWe don't often have nested scrollable elements in VS Code workbench and also this is how browsers handle nested scrolling. Current behavior feels right to me. I can see the value of scrolling only when the focus is inside/on the output, there is a catch with that though, users need to move cursor to outside of the cell output to scroll the notebook, and the hit area for that is very narrow most of the time.\nThanks for providing more info. But what other UI element scrolls like the notebook does right now - so that you can scroll the element until it hits the end, and then if you continue scrolling that the outer element starts scrolling? This really felt unnatural to me, but I might have missed this pattern in other parts of the workbench. Or what do other Notebooks products do in this case?\nthe peek view actually behaves this way. That's the only other nested scrollable element that I know of.\nThanks! If I am the only user that it complaining feel free to close this one as designed :)\nI tried using notebook in VSCode again last week, and came to GitHub to open this exact issue. I feel this scroll is extremely unintuitive. Here's an example. A cell is outputting more lines than , so we're currently viewing it's last line. I want to scroll to top. I speed scroll up, but this reaches the top and keeps scrolling the notebook, so now I'm all the way up. I have to scroll back down to my cell. If I go fast, I might miss it. If I go slowly, some other cell's output might catch my scroll and scroll that to bottom, before the notebook scrolls again. Same happens to my cell. I need to be frustratingly precise to scroll this output to the top. Here's a recording to illustrate (I hope you can see it, recorded on MacOS, encoded as AV1; can add YT link if not viewable here): It took me 15 seconds to manage to get that top. And I knew exactly what I wanted to achieve, for the sake of the video. Now here's the same experience in native Jupyter Notebook (exact same notebook and cell). First, I can easily toggle the output scrolling. If untoggled, the output scrolls natively with the notebook, and since it expands downwards, without the notebook jumping, I can immediately see the top, which is right next to the cell. Then I toggle the scrolling again, to illustrate the behaviour compared to VSCode. I initiate scrolling inside the output area, and so only that area is scrolled. No matter the speed, or direction, I can easily reach the top or bottom as many times as I need, without losing context of my notebook. If I do want to scroll the notebook, I need to scroll outside the output area. This is easy because the cell does not take the whole width. This is in relation to what said above: Yes, but the cell does not need to take the complete visible width. In native notebook, cell's width is limited, and there's still plenty of space for code. But even if the cell does take the entire width, the user can initiate the scrolling outside the output area, i.e. over a cell. In this case, it scrolls the notebook, and never the outputs. The outputs do not steal the scrolling from the notebook, like it happens in VSCode. So: scroll initiated on cell or outside the cells area -scrolls notebook only, never output scroll initated in scrollable output area -scrolls only that output area, never the notebook\nshould we reopen this? What do you think?\nsure, that's a reasonable request. It would be inconsistent with how the peek view scroll works, but the possibility for many scrollable regions makes these cases more noticeable in notebooks. - one thing that might help - you can toggle output scrollability per output in vscode as well with , by default\nI have the same issue. The usability of the scrollable element suffers greatly due to the current crazy behavior - when the scrolling inertia reaches the end of the scrollable output and scrolls the whole notebook! If different users want different behavior, this can be an option in the settings, e.g.: current behavior behavior like in the native Jupyter Notebook (in the video above), i.e. the notebook never scrolls if the pointer is inside the scrollable element there may be a 3rd option: the scroll that reaches the end of scrollable area doesn't scroll the notebook, but the subsequent scrolls in the same direction (even if the mouse pointer is inside the scrollable area) - scroll the notebook\nfor verification, please check with a mouse wheel and scrolling with a trackpad, since they behave quite differently. Hitting the boundary of the inner scrollable region will prevent further scrolling for that same scroll action. After a short pause you should then be able to scroll the outer region since the inner region can't be scrolled any further. (similar behavior to a browser)\nVerified on trackpad. Still have to verify with a mouse wheel.\nverified on mouse! there was a pause/delay, but wonder if there should be a larger delay - I find that sometimes I spam scroll and it moved up a little quicker than I anticipated. if it matches browser tho, should be all good ~\nhello , thank you a lot for the work on this issue! I hate to say this, but I think it's not solved: It looks like only a certain \"scroll length\" is ignored, and the rest of the scroll inertia is still applied. Here I do: one fast scroll (as you see, the notebook moves) then I scroll back down then one fast (a bit slower) scroll (the notebook moves) Only if the scroll isn't fast enough the \"scroll length\" will be small enough to be completely ignored. <br /Here I do: one long scroll - all the way until the end of the video: <br /The behavior in the native jupyter notebook is certainly different. Here I do: one fast scroll - different than in VSCode (the notebook doesn't move) one long scroll- different than in VSCode (the notebook doesn't move) one after-scroll (the notebook moves as expected) Could this issue please be re-opened?\nwhich version of vscode was this on?\nVersion: 1.88.0 (Universal) Commit: Date: 2024-04-03T13:28:18.899Z (1 day ago) Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.3.0\nok, yeah. looks like I broke the behavior with a related bugfix\nVersion: 1.89.0 - still isn't completely fixed: If I scroll hard enough, the notebook scrolls.", "positive_passages": [{"docid": "doc-en-vscode-71c52a126e22a782475b4c24bffe3b941fb05840dcde759aff97bcfcf57bfe12", "text": "continue; } <ins> flagRecentlyScrolled(node); </ins> return true; } }", "commid": "vscode_pr_206642"}], "negative_passages": []}
{"query_id": "q-en-vscode-62de6bf46835644b07dc9b38de6902e89ab63a3cdb325bfb7df5730727ec0ff8", "query": "Testing Have the following code in an notebook cell. Run the code Scroll the output. Notice as your scroll reaches the top you can continue scrolling and it will scroll the whole notebook file. This is unexpected and I think no other widget in VS Code behaves this way. I suggest instead the following strategy when scrolling: If a mouse is in the Cell then scrolling it will only scroll that cell. You can not scroll the large notebook while the mouse is in the cell. Same way you can not scroll the Cell with the mouse unless the mouse is in the cell IMHO this is what makes the current experience feel weird.\nWe don't often have nested scrollable elements in VS Code workbench and also this is how browsers handle nested scrolling. Current behavior feels right to me. I can see the value of scrolling only when the focus is inside/on the output, there is a catch with that though, users need to move cursor to outside of the cell output to scroll the notebook, and the hit area for that is very narrow most of the time.\nThanks for providing more info. But what other UI element scrolls like the notebook does right now - so that you can scroll the element until it hits the end, and then if you continue scrolling that the outer element starts scrolling? This really felt unnatural to me, but I might have missed this pattern in other parts of the workbench. Or what do other Notebooks products do in this case?\nthe peek view actually behaves this way. That's the only other nested scrollable element that I know of.\nThanks! If I am the only user that it complaining feel free to close this one as designed :)\nI tried using notebook in VSCode again last week, and came to GitHub to open this exact issue. I feel this scroll is extremely unintuitive. Here's an example. A cell is outputting more lines than , so we're currently viewing it's last line. I want to scroll to top. I speed scroll up, but this reaches the top and keeps scrolling the notebook, so now I'm all the way up. I have to scroll back down to my cell. If I go fast, I might miss it. If I go slowly, some other cell's output might catch my scroll and scroll that to bottom, before the notebook scrolls again. Same happens to my cell. I need to be frustratingly precise to scroll this output to the top. Here's a recording to illustrate (I hope you can see it, recorded on MacOS, encoded as AV1; can add YT link if not viewable here): It took me 15 seconds to manage to get that top. And I knew exactly what I wanted to achieve, for the sake of the video. Now here's the same experience in native Jupyter Notebook (exact same notebook and cell). First, I can easily toggle the output scrolling. If untoggled, the output scrolls natively with the notebook, and since it expands downwards, without the notebook jumping, I can immediately see the top, which is right next to the cell. Then I toggle the scrolling again, to illustrate the behaviour compared to VSCode. I initiate scrolling inside the output area, and so only that area is scrolled. No matter the speed, or direction, I can easily reach the top or bottom as many times as I need, without losing context of my notebook. If I do want to scroll the notebook, I need to scroll outside the output area. This is easy because the cell does not take the whole width. This is in relation to what said above: Yes, but the cell does not need to take the complete visible width. In native notebook, cell's width is limited, and there's still plenty of space for code. But even if the cell does take the entire width, the user can initiate the scrolling outside the output area, i.e. over a cell. In this case, it scrolls the notebook, and never the outputs. The outputs do not steal the scrolling from the notebook, like it happens in VSCode. So: scroll initiated on cell or outside the cells area -scrolls notebook only, never output scroll initated in scrollable output area -scrolls only that output area, never the notebook\nshould we reopen this? What do you think?\nsure, that's a reasonable request. It would be inconsistent with how the peek view scroll works, but the possibility for many scrollable regions makes these cases more noticeable in notebooks. - one thing that might help - you can toggle output scrollability per output in vscode as well with , by default\nI have the same issue. The usability of the scrollable element suffers greatly due to the current crazy behavior - when the scrolling inertia reaches the end of the scrollable output and scrolls the whole notebook! If different users want different behavior, this can be an option in the settings, e.g.: current behavior behavior like in the native Jupyter Notebook (in the video above), i.e. the notebook never scrolls if the pointer is inside the scrollable element there may be a 3rd option: the scroll that reaches the end of scrollable area doesn't scroll the notebook, but the subsequent scrolls in the same direction (even if the mouse pointer is inside the scrollable area) - scroll the notebook\nfor verification, please check with a mouse wheel and scrolling with a trackpad, since they behave quite differently. Hitting the boundary of the inner scrollable region will prevent further scrolling for that same scroll action. After a short pause you should then be able to scroll the outer region since the inner region can't be scrolled any further. (similar behavior to a browser)\nVerified on trackpad. Still have to verify with a mouse wheel.\nverified on mouse! there was a pause/delay, but wonder if there should be a larger delay - I find that sometimes I spam scroll and it moved up a little quicker than I anticipated. if it matches browser tho, should be all good ~\nhello , thank you a lot for the work on this issue! I hate to say this, but I think it's not solved: It looks like only a certain \"scroll length\" is ignored, and the rest of the scroll inertia is still applied. Here I do: one fast scroll (as you see, the notebook moves) then I scroll back down then one fast (a bit slower) scroll (the notebook moves) Only if the scroll isn't fast enough the \"scroll length\" will be small enough to be completely ignored. <br /Here I do: one long scroll - all the way until the end of the video: <br /The behavior in the native jupyter notebook is certainly different. Here I do: one fast scroll - different than in VSCode (the notebook doesn't move) one long scroll- different than in VSCode (the notebook doesn't move) one after-scroll (the notebook moves as expected) Could this issue please be re-opened?\nwhich version of vscode was this on?\nVersion: 1.88.0 (Universal) Commit: Date: 2024-04-03T13:28:18.899Z (1 day ago) Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.3.0\nok, yeah. looks like I broke the behavior with a related bugfix\nVersion: 1.89.0 - still isn't completely fixed: If I scroll hard enough, the notebook scrolls.", "positive_passages": [{"docid": "doc-en-vscode-3b59681b9922192daa4eebee3d7562575052f2d7073e4f3c205dd1f3f29e1046", "text": "} const handleWheel = (event: WheelEvent & { wheelDeltaX?: number; wheelDeltaY?: number; wheelDelta?: number }) => { <del> if (event.defaultPrevented || scrollWillGoToParent(event)) { </del> <ins> if (event.defaultPrevented || eventTargetShouldHandleScroll(event)) { </ins> return; } postNotebookMessage<webviewMessages.IWheelMessage>('did-scroll-wheel', {", "commid": "vscode_pr_206642"}], "negative_passages": []}
{"query_id": "q-en-vscode-62de6bf46835644b07dc9b38de6902e89ab63a3cdb325bfb7df5730727ec0ff8", "query": "Testing Have the following code in an notebook cell. Run the code Scroll the output. Notice as your scroll reaches the top you can continue scrolling and it will scroll the whole notebook file. This is unexpected and I think no other widget in VS Code behaves this way. I suggest instead the following strategy when scrolling: If a mouse is in the Cell then scrolling it will only scroll that cell. You can not scroll the large notebook while the mouse is in the cell. Same way you can not scroll the Cell with the mouse unless the mouse is in the cell IMHO this is what makes the current experience feel weird.\nWe don't often have nested scrollable elements in VS Code workbench and also this is how browsers handle nested scrolling. Current behavior feels right to me. I can see the value of scrolling only when the focus is inside/on the output, there is a catch with that though, users need to move cursor to outside of the cell output to scroll the notebook, and the hit area for that is very narrow most of the time.\nThanks for providing more info. But what other UI element scrolls like the notebook does right now - so that you can scroll the element until it hits the end, and then if you continue scrolling that the outer element starts scrolling? This really felt unnatural to me, but I might have missed this pattern in other parts of the workbench. Or what do other Notebooks products do in this case?\nthe peek view actually behaves this way. That's the only other nested scrollable element that I know of.\nThanks! If I am the only user that it complaining feel free to close this one as designed :)\nI tried using notebook in VSCode again last week, and came to GitHub to open this exact issue. I feel this scroll is extremely unintuitive. Here's an example. A cell is outputting more lines than , so we're currently viewing it's last line. I want to scroll to top. I speed scroll up, but this reaches the top and keeps scrolling the notebook, so now I'm all the way up. I have to scroll back down to my cell. If I go fast, I might miss it. If I go slowly, some other cell's output might catch my scroll and scroll that to bottom, before the notebook scrolls again. Same happens to my cell. I need to be frustratingly precise to scroll this output to the top. Here's a recording to illustrate (I hope you can see it, recorded on MacOS, encoded as AV1; can add YT link if not viewable here): It took me 15 seconds to manage to get that top. And I knew exactly what I wanted to achieve, for the sake of the video. Now here's the same experience in native Jupyter Notebook (exact same notebook and cell). First, I can easily toggle the output scrolling. If untoggled, the output scrolls natively with the notebook, and since it expands downwards, without the notebook jumping, I can immediately see the top, which is right next to the cell. Then I toggle the scrolling again, to illustrate the behaviour compared to VSCode. I initiate scrolling inside the output area, and so only that area is scrolled. No matter the speed, or direction, I can easily reach the top or bottom as many times as I need, without losing context of my notebook. If I do want to scroll the notebook, I need to scroll outside the output area. This is easy because the cell does not take the whole width. This is in relation to what said above: Yes, but the cell does not need to take the complete visible width. In native notebook, cell's width is limited, and there's still plenty of space for code. But even if the cell does take the entire width, the user can initiate the scrolling outside the output area, i.e. over a cell. In this case, it scrolls the notebook, and never the outputs. The outputs do not steal the scrolling from the notebook, like it happens in VSCode. So: scroll initiated on cell or outside the cells area -scrolls notebook only, never output scroll initated in scrollable output area -scrolls only that output area, never the notebook\nshould we reopen this? What do you think?\nsure, that's a reasonable request. It would be inconsistent with how the peek view scroll works, but the possibility for many scrollable regions makes these cases more noticeable in notebooks. - one thing that might help - you can toggle output scrollability per output in vscode as well with , by default\nI have the same issue. The usability of the scrollable element suffers greatly due to the current crazy behavior - when the scrolling inertia reaches the end of the scrollable output and scrolls the whole notebook! If different users want different behavior, this can be an option in the settings, e.g.: current behavior behavior like in the native Jupyter Notebook (in the video above), i.e. the notebook never scrolls if the pointer is inside the scrollable element there may be a 3rd option: the scroll that reaches the end of scrollable area doesn't scroll the notebook, but the subsequent scrolls in the same direction (even if the mouse pointer is inside the scrollable area) - scroll the notebook\nfor verification, please check with a mouse wheel and scrolling with a trackpad, since they behave quite differently. Hitting the boundary of the inner scrollable region will prevent further scrolling for that same scroll action. After a short pause you should then be able to scroll the outer region since the inner region can't be scrolled any further. (similar behavior to a browser)\nVerified on trackpad. Still have to verify with a mouse wheel.\nverified on mouse! there was a pause/delay, but wonder if there should be a larger delay - I find that sometimes I spam scroll and it moved up a little quicker than I anticipated. if it matches browser tho, should be all good ~\nhello , thank you a lot for the work on this issue! I hate to say this, but I think it's not solved: It looks like only a certain \"scroll length\" is ignored, and the rest of the scroll inertia is still applied. Here I do: one fast scroll (as you see, the notebook moves) then I scroll back down then one fast (a bit slower) scroll (the notebook moves) Only if the scroll isn't fast enough the \"scroll length\" will be small enough to be completely ignored. <br /Here I do: one long scroll - all the way until the end of the video: <br /The behavior in the native jupyter notebook is certainly different. Here I do: one fast scroll - different than in VSCode (the notebook doesn't move) one long scroll- different than in VSCode (the notebook doesn't move) one after-scroll (the notebook moves as expected) Could this issue please be re-opened?\nwhich version of vscode was this on?\nVersion: 1.88.0 (Universal) Commit: Date: 2024-04-03T13:28:18.899Z (1 day ago) Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.3.0\nok, yeah. looks like I broke the behavior with a related bugfix\nVersion: 1.89.0 - still isn't completely fixed: If I scroll hard enough, the notebook scrolls.", "positive_passages": [{"docid": "doc-en-vscode-64c844d5624118189173de521f5ccaa26eb18c80e4e40f40cca346d12f8ed0c8", "text": "} if (node.hasAttribute('recentlyScrolled')) { <del> if (lastTimeScrolled && Date.now() - lastTimeScrolled > 300) { </del> <ins> if (lastTimeScrolled && Date.now() - lastTimeScrolled > 400) { </ins> // it has been a while since we actually scrolled <del> // if scroll velocity increases, it's likely a new scroll event if (!!previousDelta && deltaY < 0 && deltaY < previousDelta - 2) { </del> <ins> // if scroll velocity increases significantly, it's likely a new scroll event if (!!previousDelta && deltaY < 0 && deltaY < previousDelta - 8) { </ins> clearTimeout(scrollTimeout); scrolledElement?.removeAttribute('recentlyScrolled'); return false; <del> } else if (!!previousDelta && deltaY > 0 && deltaY > previousDelta + 2) { </del> <ins> } else if (!!previousDelta && deltaY > 0 && deltaY > previousDelta + 8) { </ins> clearTimeout(scrollTimeout); scrolledElement?.removeAttribute('recentlyScrolled'); return false;", "commid": "vscode_pr_209674"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51fa4b5edf4cbb18338595b53abe51b8c5d4642f288a0e7227b94d14a513eef", "query": "Testing into the editor. status bar still says \"Tab Moves Focus\". I think I'd only expect it to say that when I'm focused in the terminal.\nIf you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this\nI never toggled it at all, this was just using the settings.", "positive_passages": [{"docid": "doc-en-vscode-fde9adc357e2c717f7e689d3e971de6f5d349833f5b1603817f17c8f571bfe2e", "text": "private _tabFocusTerminal: boolean = false; private _tabFocusEditor: boolean = false; <del> private readonly _onDidChangeTabFocus = new Emitter<boolean>(); public readonly onDidChangeTabFocus: Event<boolean> = this._onDidChangeTabFocus.event; </del> <ins> private readonly _onDidChangeTabFocus = new Emitter<void>(); public readonly onDidChangeTabFocus: Event<void> = this._onDidChangeTabFocus.event; </ins> public getTabFocusMode(context: TabFocusContext): boolean { return context === TabFocusContext.Terminal ? this._tabFocusTerminal : this._tabFocusEditor; } public setTabFocusMode(tabFocusMode: boolean, context: TabFocusContext): void { <del> if ((context === TabFocusContext.Terminal && this._tabFocusTerminal === tabFocusMode) || (context === TabFocusContext.Editor && this._tabFocusEditor === tabFocusMode)) { return; } </del> if (context === TabFocusContext.Terminal) { this._tabFocusTerminal = tabFocusMode; } else { this._tabFocusEditor = tabFocusMode; } <del> this._onDidChangeTabFocus.fire(this._tabFocusTerminal); </del> <ins> this._onDidChangeTabFocus.fire(); </ins> } }", "commid": "vscode_pr_175135"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51fa4b5edf4cbb18338595b53abe51b8c5d4642f288a0e7227b94d14a513eef", "query": "Testing into the editor. status bar still says \"Tab Moves Focus\". I think I'd only expect it to say that when I'm focused in the terminal.\nIf you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this\nI never toggled it at all, this was just using the settings.", "positive_passages": [{"docid": "doc-en-vscode-d06c905bbafc0618cc255e4fc9c7b45c2f29f4a791815a08a9f37511a51ae2e0", "text": "private readonly languageElement = this._register(new MutableDisposable<IStatusbarEntryAccessor>()); private readonly metadataElement = this._register(new MutableDisposable<IStatusbarEntryAccessor>()); private readonly currentProblemStatus: ShowCurrentMarkerInStatusbarContribution = this._register(this.instantiationService.createInstance(ShowCurrentMarkerInStatusbarContribution)); <ins> private _previousViewContext: 'terminal' | 'editor' | undefined; </ins> private readonly state = new State(); private readonly activeEditorListeners = this._register(new DisposableStore()); private readonly delayedRender = this._register(new MutableDisposable());", "commid": "vscode_pr_175135"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51fa4b5edf4cbb18338595b53abe51b8c5d4642f288a0e7227b94d14a513eef", "query": "Testing into the editor. status bar still says \"Tab Moves Focus\". I think I'd only expect it to say that when I'm focused in the terminal.\nIf you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this\nI never toggled it at all, this was just using the settings.", "positive_passages": [{"docid": "doc-en-vscode-f707fd00cc8d4842d3257ad34327da4e27413cbb6c6d1f1300a4cf6594293a70", "text": "this._register(this.textFileService.untitled.onDidChangeEncoding(model => this.onResourceEncodingChange(model.resource))); this._register(this.textFileService.files.onDidChangeEncoding(model => this.onResourceEncodingChange((model.resource)))); this._register(Event.runAndSubscribe(TabFocus.onDidChangeTabFocus, () => this.onTabFocusModeChange())); <ins> const viewKey = new Set<string>(); viewKey.add('focusedView'); this._register(this.contextKeyService.onDidChangeContext((c) => { if (c.affectsSome(viewKey)) { const terminalFocus = this.contextKeyService.getContextKeyValue('focusedView') === 'terminal'; const context = terminalFocus ? 'terminal' : 'editor'; if (this._previousViewContext === context) { return; } this._previousViewContext = context; this.onTabFocusModeChange(); } })); </ins> } private registerCommands(): void {", "commid": "vscode_pr_175135"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51fa4b5edf4cbb18338595b53abe51b8c5d4642f288a0e7227b94d14a513eef", "query": "Testing into the editor. status bar still says \"Tab Moves Focus\". I think I'd only expect it to say that when I'm focused in the terminal.\nIf you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this\nI never toggled it at all, this was just using the settings.", "positive_passages": [{"docid": "doc-en-vscode-3055ad44f7eb9a19cc25aea2431c7d8c2b0a9917c90cf10ef83147e3d1ba03d8", "text": "import { Schemas } from 'vs/base/common/network'; import { TabFocus, TabFocusContext } from 'vs/editor/browser/config/tabFocus'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; <del> import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </del> import { ILabelService } from 'vs/platform/label/common/label'; import { TerminalSettingId } from 'vs/platform/terminal/common/terminal'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions';", "commid": "vscode_pr_175135"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51fa4b5edf4cbb18338595b53abe51b8c5d4642f288a0e7227b94d14a513eef", "query": "Testing into the editor. status bar still says \"Tab Moves Focus\". I think I'd only expect it to say that when I'm focused in the terminal.\nIf you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this\nI never toggled it at all, this was just using the settings.", "positive_passages": [{"docid": "doc-en-vscode-36cd6812d2d9edbc285f794dd554cc10654205aaddee0e29b0b1dfd9b81e9547", "text": "@ITerminalService terminalService: ITerminalService, @ITerminalEditorService terminalEditorService: ITerminalEditorService, @ITerminalGroupService terminalGroupService: ITerminalGroupService, <del> @IConfigurationService configurationService: IConfigurationService, @IContextKeyService contextKeyService: IContextKeyService </del> <ins> @IConfigurationService configurationService: IConfigurationService </ins> ) { super();", "commid": "vscode_pr_175135"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51fa4b5edf4cbb18338595b53abe51b8c5d4642f288a0e7227b94d14a513eef", "query": "Testing into the editor. status bar still says \"Tab Moves Focus\". I think I'd only expect it to say that when I'm focused in the terminal.\nIf you toggled it to on in the editor before focusing the terminal, then this is expected. We remember the toggled state for each context until the window is reloaded and it gets reset to the configured value I realize that's kind of confusing and was not how I initially implemented this\nI never toggled it at all, this was just using the settings.", "positive_passages": [{"docid": "doc-en-vscode-c2ce0397ec5c6d6287affc13340af71fe6f0ba7f56787850785381dc590bca68", "text": "} }); <del> const viewKey = new Set<string>(); viewKey.add('focusedView'); </del> TabFocus.setTabFocusMode(configurationService.getValue('editor.tabFocusMode'), TabFocusContext.Editor); TabFocus.setTabFocusMode(configurationService.getValue(TerminalSettingId.TabFocusMode), TabFocusContext.Terminal); <del> this._register(contextKeyService.onDidChangeContext((c) => { if (c.affectsSome(viewKey)) { if (contextKeyService.getContextKeyValue('focusedView') === 'terminal') { TabFocus.setTabFocusMode(configurationService.getValue(TerminalSettingId.TabFocusMode), TabFocusContext.Terminal); } else { TabFocus.setTabFocusMode(configurationService.getValue('editor.tabFocusMode'), TabFocusContext.Editor); } } })); </del> } }", "commid": "vscode_pr_175135"}], "negative_passages": []}
{"query_id": "q-en-vscode-744c330ea245c8d0a9e32c6ea7681487e3ff21f7dbc7eb2c50fccf4286194969", "query": "has indicated that the diff inserted / modified audio cues are hard to differentiate and that the sounds are not as fast / singular toned as they should be\nwhat do you think of this?\nI agree with the suggestion. At least for me it is very difficult to identify the difference between the sounds used.\nSounds good -- will start on this asap.\nI don't hear the cues as often anymore. I also noticed that when using up/down keys on the right diff editor, no audio cue shows up for a deleted section. Example with .gitignore file: Left: Right:\nI can reproduce\nit's getting to the line I expect it to (see logs) but no sound is produced - thoughts? https://user-", "positive_passages": [{"docid": "doc-en-vscode-e7ea7586170cb9a256be8365f20a5d7a8595f165c961e329ceb4f31c3168280d", "text": "switch (changeType) { case ChangeType.Add: audioCueService.playAudioCue(AudioCue.diffLineInserted, true); <ins> break; </ins> case ChangeType.Delete: audioCueService.playAudioCue(AudioCue.diffLineDeleted, true); <ins> break; </ins> case ChangeType.Modify: audioCueService.playAudioCue(AudioCue.diffLineModified, true); <ins> break; </ins> } }", "commid": "vscode_pr_179041"}], "negative_passages": []}
{"query_id": "q-en-vscode-744c330ea245c8d0a9e32c6ea7681487e3ff21f7dbc7eb2c50fccf4286194969", "query": "has indicated that the diff inserted / modified audio cues are hard to differentiate and that the sounds are not as fast / singular toned as they should be\nwhat do you think of this?\nI agree with the suggestion. At least for me it is very difficult to identify the difference between the sounds used.\nSounds good -- will start on this asap.\nI don't hear the cues as often anymore. I also noticed that when using up/down keys on the right diff editor, no audio cue shows up for a deleted section. Example with .gitignore file: Left: Right:\nI can reproduce\nit's getting to the line I expect it to (see logs) but no sound is produced - thoughts? https://user-", "positive_passages": [{"docid": "doc-en-vscode-eacc8a76793d7ea1aecece3932050b8b30a9fc51db2488015e8402bb94bafc6f", "text": "const sound = this.sounds.get(url); if (sound) { sound.volume = this.getVolumeInPercent() / 100; <ins> sound.currentTime = 0; </ins> await sound.play(); } else { const playedSound = await playAudio(url, this.getVolumeInPercent() / 100);", "commid": "vscode_pr_181042"}], "negative_passages": []}
{"query_id": "q-en-vscode-33df85bb83bbf91c35af74a09c41a5273693d10a1d53e8b2955000e6f5a1793a", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.1 OS Version: macOS 13 Steps to Reproduce: the following settings to : suggestions still show up: <img width=\"766\" alt=\"image\" src=\"https://user-\"\nwhat you are looking at is the hover. to disable that use this setting\nHi, I want to remove the three dots, disabling hovering doesn't help, these two settings , now they don't, a recent update broke that, please reopen this and take a look .\nOh, you mean \"hint\" diagnostics. Forwarding to for comment\nThanks for fowarding, I got the term from the : !", "positive_passages": [{"docid": "doc-en-vscode-888f39ea49bab4394093ee4ef388e321a86c09caa46d7f62ad74873555f44cdd", "text": "function areLanguageDiagnosticSettingsEqual(currentSettings: LanguageDiagnosticSettings, newSettings: LanguageDiagnosticSettings): boolean { return currentSettings.validate === newSettings.validate <del> && currentSettings.enableSuggestions && currentSettings.enableSuggestions; </del> <ins> && currentSettings.enableSuggestions === newSettings.enableSuggestions; </ins> } class DiagnosticSettings {", "commid": "vscode_pr_175567"}], "negative_passages": []}
{"query_id": "q-en-vscode-104dea625e402c73d732441cd028d1f5ba47926ac357fc12f5ea076001c6db82", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Windows 11 OS Version: 1.75.1 Steps to Reproduce: Using the following settings: ! ! a typescript file within a method/function following gets output (might have to navigate through some of the suggestions) even though snippets are off: !\nThanks for the patience. I cannot reproduce, please share more of your settings that might influence this. Also share data in a copy-paste friendly way (text over images)\nHere are the settings that I am using to reproduce (all extensions disabled ): Once typing and going to the 3rd suggestion, I get this as a suggestion: !\nThanks for clarifying, looks like we aren't passing the filter here:\nI can't figure out how to get that ghost text to show up for suggestions to verify this. I've never seen that ghost text for anything but copilot completions Do I need a suggestion provider extension?\nYou are right. I made a refactoring after this fix and that broke this feature Thanks for the diligence on this one!\nTo verify, use the steps from Make sure no snippets completions are ghost-texted with and that they are when the setting is set accordingly\nI still cannot get snippet completions to show up\nYou need to say what you are trying because I do see them working just fine <img width=\"922\" alt=\"Screenshot 2024-01-26 at 18 14 32\" src=\"\"\nThis works correctly for me now, no snippets with , and they do show up without it.\nBang on. The whole point is that the -setting is honored also for ghost suggestions\n: <img width=\"1792\" alt=\"Screenshot 2024-01-26 at 9 19 47 AM\" src=\"\"\nthis is about ghost text, please see and the comment linked from there\nthere was a syntax error in my file, so the settings did not get applied. Now it works", "positive_passages": [{"docid": "doc-en-vscode-ca8620e5a4384c905ea8c918ea5743db82e22d19ee7afdadfd9d55da90e52ec4", "text": "import { CancellationToken } from 'vs/base/common/cancellation'; import { FuzzyScore } from 'vs/base/common/filters'; import { Iterable } from 'vs/base/common/iterator'; <del> import { RefCountedDisposable } from 'vs/base/common/lifecycle'; </del> <ins> import { Disposable, RefCountedDisposable } from 'vs/base/common/lifecycle'; </ins> import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; import { EditorOption } from 'vs/editor/common/config/editorOptions';", "commid": "vscode_pr_203418"}], "negative_passages": []}
{"query_id": "q-en-vscode-104dea625e402c73d732441cd028d1f5ba47926ac357fc12f5ea076001c6db82", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Windows 11 OS Version: 1.75.1 Steps to Reproduce: Using the following settings: ! ! a typescript file within a method/function following gets output (might have to navigate through some of the suggestions) even though snippets are off: !\nThanks for the patience. I cannot reproduce, please share more of your settings that might influence this. Also share data in a copy-paste friendly way (text over images)\nHere are the settings that I am using to reproduce (all extensions disabled ): Once typing and going to the 3rd suggestion, I get this as a suggestion: !\nThanks for clarifying, looks like we aren't passing the filter here:\nI can't figure out how to get that ghost text to show up for suggestions to verify this. I've never seen that ghost text for anything but copilot completions Do I need a suggestion provider extension?\nYou are right. I made a refactoring after this fix and that broke this feature Thanks for the diligence on this one!\nTo verify, use the steps from Make sure no snippets completions are ghost-texted with and that they are when the setting is set accordingly\nI still cannot get snippet completions to show up\nYou need to say what you are trying because I do see them working just fine <img width=\"922\" alt=\"Screenshot 2024-01-26 at 18 14 32\" src=\"\"\nThis works correctly for me now, no snippets with , and they do show up without it.\nBang on. The whole point is that the -setting is honored also for ghost suggestions\n: <img width=\"1792\" alt=\"Screenshot 2024-01-26 at 9 19 47 AM\" src=\"\"\nthis is about ghost text, please see and the comment linked from there\nthere was a syntax error in my file, so the settings did not get applied. Now it works", "positive_passages": [{"docid": "doc-en-vscode-831395b627add55b302823ead26aa6f87b6d07bdb53b3480f93b9c8a3c3786d2", "text": "} <del> export class SuggestInlineCompletions implements InlineCompletionsProvider<InlineCompletionResults> { </del> <ins> export class SuggestInlineCompletions extends Disposable implements InlineCompletionsProvider<InlineCompletionResults> { </ins> private _lastResult?: InlineCompletionResults;", "commid": "vscode_pr_203418"}], "negative_passages": []}
{"query_id": "q-en-vscode-104dea625e402c73d732441cd028d1f5ba47926ac357fc12f5ea076001c6db82", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Windows 11 OS Version: 1.75.1 Steps to Reproduce: Using the following settings: ! ! a typescript file within a method/function following gets output (might have to navigate through some of the suggestions) even though snippets are off: !\nThanks for the patience. I cannot reproduce, please share more of your settings that might influence this. Also share data in a copy-paste friendly way (text over images)\nHere are the settings that I am using to reproduce (all extensions disabled ): Once typing and going to the 3rd suggestion, I get this as a suggestion: !\nThanks for clarifying, looks like we aren't passing the filter here:\nI can't figure out how to get that ghost text to show up for suggestions to verify this. I've never seen that ghost text for anything but copilot completions Do I need a suggestion provider extension?\nYou are right. I made a refactoring after this fix and that broke this feature Thanks for the diligence on this one!\nTo verify, use the steps from Make sure no snippets completions are ghost-texted with and that they are when the setting is set accordingly\nI still cannot get snippet completions to show up\nYou need to say what you are trying because I do see them working just fine <img width=\"922\" alt=\"Screenshot 2024-01-26 at 18 14 32\" src=\"\"\nThis works correctly for me now, no snippets with , and they do show up without it.\nBang on. The whole point is that the -setting is honored also for ghost suggestions\n: <img width=\"1792\" alt=\"Screenshot 2024-01-26 at 9 19 47 AM\" src=\"\"\nthis is about ghost text, please see and the comment linked from there\nthere was a syntax error in my file, so the settings did not get applied. Now it works", "positive_passages": [{"docid": "doc-en-vscode-654916cf12b0cd91faa4b5a4c45f3f1c4e0cc74bedee563a192573b9c4b6f213", "text": "@IClipboardService private readonly _clipboardService: IClipboardService, @ISuggestMemoryService private readonly _suggestMemoryService: ISuggestMemoryService, @ICodeEditorService private readonly _editorService: ICodeEditorService, <del> ) { } </del> <ins> ) { super(); this._store.add(_languageFeatureService.inlineCompletionsProvider.register('*', this)); } </ins> async provideInlineCompletions(model: ITextModel, position: Position, context: InlineCompletionContext, token: CancellationToken): Promise<InlineCompletionResults | undefined> {", "commid": "vscode_pr_203418"}], "negative_passages": []}
{"query_id": "q-en-vscode-104dea625e402c73d732441cd028d1f5ba47926ac357fc12f5ea076001c6db82", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Windows 11 OS Version: 1.75.1 Steps to Reproduce: Using the following settings: ! ! a typescript file within a method/function following gets output (might have to navigate through some of the suggestions) even though snippets are off: !\nThanks for the patience. I cannot reproduce, please share more of your settings that might influence this. Also share data in a copy-paste friendly way (text over images)\nHere are the settings that I am using to reproduce (all extensions disabled ): Once typing and going to the 3rd suggestion, I get this as a suggestion: !\nThanks for clarifying, looks like we aren't passing the filter here:\nI can't figure out how to get that ghost text to show up for suggestions to verify this. I've never seen that ghost text for anything but copilot completions Do I need a suggestion provider extension?\nYou are right. I made a refactoring after this fix and that broke this feature Thanks for the diligence on this one!\nTo verify, use the steps from Make sure no snippets completions are ghost-texted with and that they are when the setting is set accordingly\nI still cannot get snippet completions to show up\nYou need to say what you are trying because I do see them working just fine <img width=\"922\" alt=\"Screenshot 2024-01-26 at 18 14 32\" src=\"\"\nThis works correctly for me now, no snippets with , and they do show up without it.\nBang on. The whole point is that the -setting is honored also for ghost suggestions\n: <img width=\"1792\" alt=\"Screenshot 2024-01-26 at 9 19 47 AM\" src=\"\"\nthis is about ghost text, please see and the comment linked from there\nthere was a syntax error in my file, so the settings did not get applied. Now it works", "positive_passages": [{"docid": "doc-en-vscode-b2d9d5898ee6c603766061339c4aafa5b76e58028c6244e2e3c40ab21ca73273", "text": "test('Aggressive inline completions when typing within line #146948', async function () { <del> const completions: SuggestInlineCompletions = insta.createInstance(SuggestInlineCompletions); </del> <ins> const completions: SuggestInlineCompletions = disposables.add(insta.createInstance(SuggestInlineCompletions)); </ins> { // (1,3), end of word -> suggestions", "commid": "vscode_pr_203418"}], "negative_passages": []}
{"query_id": "q-en-vscode-104dea625e402c73d732441cd028d1f5ba47926ac357fc12f5ea076001c6db82", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Windows 11 OS Version: 1.75.1 Steps to Reproduce: Using the following settings: ! ! a typescript file within a method/function following gets output (might have to navigate through some of the suggestions) even though snippets are off: !\nThanks for the patience. I cannot reproduce, please share more of your settings that might influence this. Also share data in a copy-paste friendly way (text over images)\nHere are the settings that I am using to reproduce (all extensions disabled ): Once typing and going to the 3rd suggestion, I get this as a suggestion: !\nThanks for clarifying, looks like we aren't passing the filter here:\nI can't figure out how to get that ghost text to show up for suggestions to verify this. I've never seen that ghost text for anything but copilot completions Do I need a suggestion provider extension?\nYou are right. I made a refactoring after this fix and that broke this feature Thanks for the diligence on this one!\nTo verify, use the steps from Make sure no snippets completions are ghost-texted with and that they are when the setting is set accordingly\nI still cannot get snippet completions to show up\nYou need to say what you are trying because I do see them working just fine <img width=\"922\" alt=\"Screenshot 2024-01-26 at 18 14 32\" src=\"\"\nThis works correctly for me now, no snippets with , and they do show up without it.\nBang on. The whole point is that the -setting is honored also for ghost suggestions\n: <img width=\"1792\" alt=\"Screenshot 2024-01-26 at 9 19 47 AM\" src=\"\"\nthis is about ghost text, please see and the comment linked from there\nthere was a syntax error in my file, so the settings did not get applied. Now it works", "positive_passages": [{"docid": "doc-en-vscode-60c9a0dc75a8f384010bc6807766438e3f2b3a784f3e199701817e6943c85f18", "text": "}); test('Snippets show in inline suggestions even though they are turned off #175190', async function () { <del> const completions: SuggestInlineCompletions = insta.createInstance(SuggestInlineCompletions); </del> <ins> const completions: SuggestInlineCompletions = disposables.add(insta.createInstance(SuggestInlineCompletions)); </ins> { // unfiltered", "commid": "vscode_pr_203418"}], "negative_passages": []}
{"query_id": "q-en-vscode-8930793755f1c4ae56cf6cb249bf4fe8c31f9ccea886a086e4b063576ddd19f8", "query": "With new API type was but that type isn't used anywhere and looks like a leftover. We should remove it before releasing stable.\nfyi\nMy bad, I must have it and forgot to remove it.\nThanks for the quick turnaround", "positive_passages": [{"docid": "doc-en-vscode-cf46f9dd71b31c500f50016df7aed0801de541253ef988195babe31e6a1134e6", "text": "/** * Value-object describing what options formatting should use. */ <del> export interface SortingOptions { /** * Size of a tab in spaces. */ tabSize: number; /** * Prefer spaces over tabs. */ insertSpaces: boolean; /** * Signature for further properties. */ [key: string]: boolean | number | string; } /** * Value-object describing what options formatting should use. */ </del> export interface FormattingOptions { /**", "commid": "vscode_pr_175248"}], "negative_passages": []}
{"query_id": "q-en-vscode-13951b5ada64e89fd36815eec81d9376eab029c6930e06f4e854d862ddf89fa5", "query": "With Dark High Contrast theme, everything is clear except for warning and errors... Error is shown with an orange x: ! While warnings are exclamation mark in blaring red: ! I mean there's no two ways about it... RED is error, RED+certain amount of yellow(orange is fine) is warning.", "positive_passages": [{"docid": "doc-en-vscode-341936ae3190a582d42a57f038f05b28bf7fcd32dca35cc98f89654c10bc3242", "text": "export const editorErrorBorder = registerColor('editorError.border', { dark: null, light: null, hcDark: Color.fromHex('#E47777').transparent(0.8), hcLight: '#B5200D' }, nls.localize('errorBorder', 'Border color of error boxes in the editor.')); export const editorWarningBackground = registerColor('editorWarning.background', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('editorWarning.background', 'Background color of warning text in the editor. The color must not be opaque so as not to hide underlying decorations.'), true); <del> export const editorWarningForeground = registerColor('editorWarning.foreground', { dark: '#CCA700', light: '#BF8803', hcDark: '#FFD37', hcLight: '#895503' }, nls.localize('editorWarning.foreground', 'Foreground color of warning squigglies in the editor.')); </del> <ins> export const editorWarningForeground = registerColor('editorWarning.foreground', { dark: '#CCA700', light: '#BF8803', hcDark: '#FFD370', hcLight: '#895503' }, nls.localize('editorWarning.foreground', 'Foreground color of warning squigglies in the editor.')); </ins> export const editorWarningBorder = registerColor('editorWarning.border', { dark: null, light: null, hcDark: Color.fromHex('#FFCC00').transparent(0.8), hcLight: '#' }, nls.localize('warningBorder', 'Border color of warning boxes in the editor.')); export const editorInfoBackground = registerColor('editorInfo.background', { dark: null, light: null, hcDark: null, hcLight: null }, nls.localize('editorInfo.background', 'Background color of info text in the editor. The color must not be opaque so as not to hide underlying decorations.'), true);", "commid": "vscode_pr_175755"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ad2c481df3ee90235717ba42568f7d54f5c80d87266e062a0ed14b5a8867f25", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: macOS 11.6.2 Version: 1.76.0 Commit: Date: 2023-03-01T10:23:45.993Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 20.6.0 Sandboxed: No Summary When creating a profile with a name such as \"Typescript / Javascript\", the following happens: When exporting as a Gist, no result dialog shows (\"there was trouble\" / \"created profile successfully\") and a validation error is outputted in the logs When exporting to a local file, the text after the last forward slash is set as the filename. With the above example, it'd be \" \" To reproduce: a profile: Settings cog -\"Profile ([...])\" the profile: Select \"Export Profile...\" -\"Export\" the \"name the profile\" step, enter a name with a forward slash in like so: \"Typescript / Javascript\" either method for exporting: gist or local Expected results: If you select local: a system save prompt with the name you entered pre-set in the filename field If you select gist: A success dialog with a link to the website prefilled with your config Actual results: If you select local: only the text after the last forward slash is in the filename field If you select gist: No dialog shows. The following error is in the \"output\" window, under \"Window\": I can only test this on a macOS device, I haven't tried this on a Windows or other Linux device and I feel like (with the area in mind - filesystems etc) these issues could manifest differently or not even be an issue there. I'm assuming validation on the inputbox for the name will be required because filesystems (and Gist? not sure) don't typically support forward slashes in file names. Thanks and if you're reading this, have a great weekend :)\nGists do no accept in the name. Replaced with .", "positive_passages": [{"docid": "doc-en-vscode-61a2ab4c378c431acd21743a932eb2639459a800fa53c26121fda96d6f565aab", "text": "try { const userDataProfilesExportState = disposables.add(this.instantiationService.createInstance(UserDataProfileExportState, this.userDataProfileService.currentProfile)); const barrier = new Barrier(); <del> const exportAction = new BarrierAction(barrier, new Action('export', localize('export', \"Export\"), undefined, true, () => { </del> <ins> const exportAction = new BarrierAction(barrier, new Action('export', localize('export', \"Export\"), undefined, true, async () => { </ins> exportAction.enabled = false; <del> return this.doExportProfile(userDataProfilesExportState); })); const closeAction = new BarrierAction(barrier, new Action('close', localize('close', \"Close\"))); </del> <ins> try { await this.doExportProfile(userDataProfilesExportState); } catch (error) { this.notificationService.error(error); throw error; } }), this.notificationService); const closeAction = new BarrierAction(barrier, new Action('close', localize('close', \"Close\")), this.notificationService); </ins> await this.showProfilePreviewView(EXPORT_PROFILE_PREVIEW_VIEW, userDataProfilesExportState.profile.name, exportAction, closeAction, true, userDataProfilesExportState); disposables.add(this.userDataProfileService.onDidChangeCurrentProfile(e => barrier.open())); await barrier.wait();", "commid": "vscode_pr_177723"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ad2c481df3ee90235717ba42568f7d54f5c80d87266e062a0ed14b5a8867f25", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: macOS 11.6.2 Version: 1.76.0 Commit: Date: 2023-03-01T10:23:45.993Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 20.6.0 Sandboxed: No Summary When creating a profile with a name such as \"Typescript / Javascript\", the following happens: When exporting as a Gist, no result dialog shows (\"there was trouble\" / \"created profile successfully\") and a validation error is outputted in the logs When exporting to a local file, the text after the last forward slash is set as the filename. With the above example, it'd be \" \" To reproduce: a profile: Settings cog -\"Profile ([...])\" the profile: Select \"Export Profile...\" -\"Export\" the \"name the profile\" step, enter a name with a forward slash in like so: \"Typescript / Javascript\" either method for exporting: gist or local Expected results: If you select local: a system save prompt with the name you entered pre-set in the filename field If you select gist: A success dialog with a link to the website prefilled with your config Actual results: If you select local: only the text after the last forward slash is in the filename field If you select gist: No dialog shows. The following error is in the \"output\" window, under \"Window\": I can only test this on a macOS device, I haven't tried this on a Windows or other Linux device and I feel like (with the area in mind - filesystems etc) these issues could manifest differently or not even be an issue there. I'm assuming validation on the inputbox for the name will be required because filesystems (and Gist? not sure) don't typically support forward slashes in file names. Thanks and if you're reading this, have a great weekend :)\nGists do no accept in the name. Replaced with .", "positive_passages": [{"docid": "doc-en-vscode-9de7296003f74e7516fd106f975735fabd6d56025e65229aff3c3f052f02f84d", "text": "if (!profileContentHandler) { return; } <del> const saveResult = await profileContentHandler.saveProfile(profile.name, JSON.stringify(profile), CancellationToken.None); </del> <ins> const saveResult = await profileContentHandler.saveProfile(profile.name.replace('/', '-'), JSON.stringify(profile), CancellationToken.None); </ins> if (!saveResult) { return; }", "commid": "vscode_pr_177723"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ad2c481df3ee90235717ba42568f7d54f5c80d87266e062a0ed14b5a8867f25", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: macOS 11.6.2 Version: 1.76.0 Commit: Date: 2023-03-01T10:23:45.993Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 20.6.0 Sandboxed: No Summary When creating a profile with a name such as \"Typescript / Javascript\", the following happens: When exporting as a Gist, no result dialog shows (\"there was trouble\" / \"created profile successfully\") and a validation error is outputted in the logs When exporting to a local file, the text after the last forward slash is set as the filename. With the above example, it'd be \" \" To reproduce: a profile: Settings cog -\"Profile ([...])\" the profile: Select \"Export Profile...\" -\"Export\" the \"name the profile\" step, enter a name with a forward slash in like so: \"Typescript / Javascript\" either method for exporting: gist or local Expected results: If you select local: a system save prompt with the name you entered pre-set in the filename field If you select gist: A success dialog with a link to the website prefilled with your config Actual results: If you select local: only the text after the last forward slash is in the filename field If you select gist: No dialog shows. The following error is in the \"output\" window, under \"Window\": I can only test this on a macOS device, I haven't tried this on a Windows or other Linux device and I feel like (with the area in mind - filesystems etc) these issues could manifest differently or not even be an issue there. I'm assuming validation on the inputbox for the name will be required because filesystems (and Gist? not sure) don't typically support forward slashes in file names. Thanks and if you're reading this, have a great weekend :)\nGists do no accept in the name. Replaced with .", "positive_passages": [{"docid": "doc-en-vscode-3435bd375814dd9179f914914eee4cd841a1db786fe31eae3bc4ad5eec5d4344", "text": ": importAction; const secondaryAction = isWeb ? importAction <del> : new BarrierAction(barrier, new Action('close', localize('close', \"Close\"))); </del> <ins> : new BarrierAction(barrier, new Action('close', localize('close', \"Close\")), this.notificationService); </ins> const view = await this.showProfilePreviewView(IMPORT_PROFILE_PREVIEW_VIEW, importedProfile.name, primaryAction, secondaryAction, false, userDataProfileImportState); const message = new MarkdownString();", "commid": "vscode_pr_177723"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ad2c481df3ee90235717ba42568f7d54f5c80d87266e062a0ed14b5a8867f25", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: macOS 11.6.2 Version: 1.76.0 Commit: Date: 2023-03-01T10:23:45.993Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 20.6.0 Sandboxed: No Summary When creating a profile with a name such as \"Typescript / Javascript\", the following happens: When exporting as a Gist, no result dialog shows (\"there was trouble\" / \"created profile successfully\") and a validation error is outputted in the logs When exporting to a local file, the text after the last forward slash is set as the filename. With the above example, it'd be \" \" To reproduce: a profile: Settings cog -\"Profile ([...])\" the profile: Select \"Export Profile...\" -\"Export\" the \"name the profile\" step, enter a name with a forward slash in like so: \"Typescript / Javascript\" either method for exporting: gist or local Expected results: If you select local: a system save prompt with the name you entered pre-set in the filename field If you select gist: A success dialog with a link to the website prefilled with your config Actual results: If you select local: only the text after the last forward slash is in the filename field If you select gist: No dialog shows. The following error is in the \"output\" window, under \"Window\": I can only test this on a macOS device, I haven't tried this on a Windows or other Linux device and I feel like (with the area in mind - filesystems etc) these issues could manifest differently or not even be an issue there. I'm assuming validation on the inputbox for the name will be required because filesystems (and Gist? not sure) don't typically support forward slashes in file names. Thanks and if you're reading this, have a great weekend :)\nGists do no accept in the name. Replaced with .", "positive_passages": [{"docid": "doc-en-vscode-4aee1b1e45a8aa54775f482473a97ed655124eeb7b96febb550e70f671e0e26d", "text": "if (userDataProfileImportState.isEmpty()) { await importAction.run(); } else { <del> await this.showProfilePreviewView(IMPORT_PROFILE_PREVIEW_VIEW, profileTemplate.name, importAction, new BarrierAction(barrier, new Action('cancel', localize('cancel', \"Cancel\"))), false, userDataProfileImportState); </del> <ins> await this.showProfilePreviewView(IMPORT_PROFILE_PREVIEW_VIEW, profileTemplate.name, importAction, new BarrierAction(barrier, new Action('cancel', localize('cancel', \"Cancel\")), this.notificationService), false, userDataProfileImportState); </ins> } await barrier.wait(); await this.hideProfilePreviewView(IMPORT_PROFILE_PREVIEW_VIEW);", "commid": "vscode_pr_177723"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ad2c481df3ee90235717ba42568f7d54f5c80d87266e062a0ed14b5a8867f25", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: macOS 11.6.2 Version: 1.76.0 Commit: Date: 2023-03-01T10:23:45.993Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 20.6.0 Sandboxed: No Summary When creating a profile with a name such as \"Typescript / Javascript\", the following happens: When exporting as a Gist, no result dialog shows (\"there was trouble\" / \"created profile successfully\") and a validation error is outputted in the logs When exporting to a local file, the text after the last forward slash is set as the filename. With the above example, it'd be \" \" To reproduce: a profile: Settings cog -\"Profile ([...])\" the profile: Select \"Export Profile...\" -\"Export\" the \"name the profile\" step, enter a name with a forward slash in like so: \"Typescript / Javascript\" either method for exporting: gist or local Expected results: If you select local: a system save prompt with the name you entered pre-set in the filename field If you select gist: A success dialog with a link to the website prefilled with your config Actual results: If you select local: only the text after the last forward slash is in the filename field If you select gist: No dialog shows. The following error is in the \"output\" window, under \"Window\": I can only test this on a macOS device, I haven't tried this on a Windows or other Linux device and I feel like (with the area in mind - filesystems etc) these issues could manifest differently or not even be an issue there. I'm assuming validation on the inputbox for the name will be required because filesystems (and Gist? not sure) don't typically support forward slashes in file names. Thanks and if you're reading this, have a great weekend :)\nGists do no accept in the name. Replaced with .", "positive_passages": [{"docid": "doc-en-vscode-cd72ca88796a1617ac75a61548eadefd9259e787a94744bc8534a63a985e2491", "text": "location: IMPORT_PROFILE_PREVIEW_VIEW, }, () => importProfileFn()); } <del> })); </del> <ins> }), this.notificationService); </ins> return importAction; }", "commid": "vscode_pr_177723"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ad2c481df3ee90235717ba42568f7d54f5c80d87266e062a0ed14b5a8867f25", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.76.0 OS Version: macOS 11.6.2 Version: 1.76.0 Commit: Date: 2023-03-01T10:23:45.993Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin x64 20.6.0 Sandboxed: No Summary When creating a profile with a name such as \"Typescript / Javascript\", the following happens: When exporting as a Gist, no result dialog shows (\"there was trouble\" / \"created profile successfully\") and a validation error is outputted in the logs When exporting to a local file, the text after the last forward slash is set as the filename. With the above example, it'd be \" \" To reproduce: a profile: Settings cog -\"Profile ([...])\" the profile: Select \"Export Profile...\" -\"Export\" the \"name the profile\" step, enter a name with a forward slash in like so: \"Typescript / Javascript\" either method for exporting: gist or local Expected results: If you select local: a system save prompt with the name you entered pre-set in the filename field If you select gist: A success dialog with a link to the website prefilled with your config Actual results: If you select local: only the text after the last forward slash is in the filename field If you select gist: No dialog shows. The following error is in the \"output\" window, under \"Window\": I can only test this on a macOS device, I haven't tried this on a Windows or other Linux device and I feel like (with the area in mind - filesystems etc) these issues could manifest differently or not even be an issue there. I'm assuming validation on the inputbox for the name will be required because filesystems (and Gist? not sure) don't typically support forward slashes in file names. Thanks and if you're reading this, have a great weekend :)\nGists do no accept in the name. Replaced with .", "positive_passages": [{"docid": "doc-en-vscode-810b66960388b40e0521ae85fe0f55d0bb60b3fcc9519a82c32ef60ceac6c962", "text": "} class BarrierAction extends Action { <del> constructor(barrier: Barrier, action: Action) { </del> <ins> constructor(barrier: Barrier, action: Action, notificationService: INotificationService) { </ins> super(action.id, action.label, action.class, action.enabled, async () => { <del> await action.run(); </del> <ins> try { await action.run(); } catch (error) { notificationService.error(error); throw error; } </ins> barrier.open(); }); }", "commid": "vscode_pr_177723"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-f12d57e2a9806e30d6a09eecdb3c5e33132bf42b01404a866729bd21f9476f89", "text": "*--------------------------------------------------------------------------------------------*/ import { networkInterfaces } from 'os'; <del> import * as errors from 'vs/base/common/errors'; </del> import { TernarySearchTree } from 'vs/base/common/ternarySearchTree'; import * as uuid from 'vs/base/common/uuid'; import { getMac } from 'vs/base/node/macAddress';", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-7ac14a174eda1c27468639679fa585051f76549934b6f0b81541fa6db1302977", "text": "}; let machineId: Promise<string>; <del> export async function getMachineId(): Promise<string> { </del> <ins> export async function getMachineId(errorLogger: (error: any) => void): Promise<string> { </ins> if (!machineId) { machineId = (async () => { <del> const id = await getMacMachineId(); </del> <ins> const id = await getMacMachineId(errorLogger); </ins> return id || uuid.generateUuid(); // fallback, generate a UUID })();", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-4dc4f7ad2baab40e678c2369d6eb42788cb3e4a1bd743e58e51cda8d215b66e7", "text": "return machineId; } <del> async function getMacMachineId(): Promise<string | undefined> { </del> <ins> async function getMacMachineId(errorLogger: (error: any) => void): Promise<string | undefined> { </ins> try { const crypto = await import('crypto'); const macAddress = getMac(); return crypto.createHash('sha256').update(macAddress, 'utf8').digest('hex'); } catch (err) { <del> errors.onUnexpectedError(err); </del> <ins> errorLogger(err); </ins> return undefined; } }", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-3e4a88dacf8f2b6e6e19aa9d772f62e3dafd76c8360d062577f2624f166cfe01", "text": "flakySuite('ID', () => { test('getMachineId', async function () { <del> const id = await getMachineId(); </del> <ins> const errors = []; const id = await getMachineId(err => errors.push(err)); </ins> assert.ok(id); <ins> assert.strictEqual(errors.length, 0); </ins> }); test('getMac', async () => {", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-fe809c58a21f5b5375a68e005b2857443d0ef12f546b23503a40d68a4643c7e1", "text": "// Resolve unique machine ID this.logService.trace('Resolving machine identifier...'); <del> const machineId = await resolveMachineId(this.stateService); </del> <ins> const machineId = await resolveMachineId(this.stateService, this.logService); </ins> this.logService.trace(`Resolved machine identifier: ${machineId}`); // Shared process", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-da2fcd7a4da9c6421ae6132be991899d4c9596114b29b2aed3624ca16a932c4d", "text": "commonProperties: (async () => { let machineId: string | undefined = undefined; try { <del> machineId = await resolveMachineId(stateService); </del> <ins> machineId = await resolveMachineId(stateService, logService); </ins> } catch (error) { if (error.code !== 'ENOENT') { logService.error(error);", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-4a845f5d79a9dc3d60026a3b9f68128db10b6430c06e9198cc326f9b943dbe85", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> import { IStateService } from 'vs/platform/state/node/state'; import { machineIdKey } from 'vs/platform/telemetry/common/telemetry'; import { resolveMachineId as resolveNodeMachineId } from 'vs/platform/telemetry/node/telemetryUtils'; <del> export async function resolveMachineId(stateService: IStateService) { </del> <ins> export async function resolveMachineId(stateService: IStateService, logService: ILogService) { </ins> // Call the node layers implementation to avoid code duplication <del> const machineId = await resolveNodeMachineId(stateService); </del> <ins> const machineId = await resolveNodeMachineId(stateService, logService); </ins> stateService.setItem(machineIdKey, machineId); return machineId; }", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-5999991c9e3c48b6c4cc46f1736badf05248341eea1f3399b8538f4c148b043b", "text": "import { isMacintosh } from 'vs/base/common/platform'; import { getMachineId } from 'vs/base/node/id'; <ins> import { ILogService } from 'vs/platform/log/common/log'; </ins> import { IStateReadService } from 'vs/platform/state/node/state'; import { machineIdKey } from 'vs/platform/telemetry/common/telemetry'; <del> export async function resolveMachineId(stateService: IStateReadService) { </del> <ins> export async function resolveMachineId(stateService: IStateReadService, logService: ILogService) { </ins> // We cache the machineId for faster lookups // and resolve it only once initially if not cached or we need to replace the macOS iBridge device let machineId = stateService.getItem<string>(machineIdKey); if (typeof machineId !== 'string' || (isMacintosh && machineId === '6c9d2bc8f91b89624add29c0abeae7fb42bf539fa1cdb2e3e57cd668fa9bcead')) { <del> machineId = await getMachineId(); </del> <ins> machineId = await getMachineId(logService.error.bind(logService)); </ins> } return machineId;", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-137565c159f314e7a078e00efb6193b758ffc0c58f2f0fb1e2916c54271b07c7", "text": "} const { installSourcePath } = this.environmentMainService; <del> const machineId = await resolveMachineId(this.stateService); </del> <ins> const machineId = await resolveMachineId(this.stateService, this.logService); </ins> const config: ITelemetryServiceConfig = { appenders,", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc8ae37aef3d5895ce7e62b4d022acccad1a66b1bb7e9130e4828ff78c72cb4c", "query": "When fails to get a mac address it still returns a generated mac id, but uses to log the error. That's a bit risky as it rely on VS Code to already have installed a . The default handler throws an exception in a timeout that can crash the process. (see issue ) IMO the better way would be to pass a logger to , e.g. the -move to -add to\nif you support the idea I can provide a PR\nthat all sounds fine to me, thanks for looking into this. I didn't know this could cause a crash since it had been in desktop for so long.", "positive_passages": [{"docid": "doc-en-vscode-080686b33db4a62f27f25b9f4043135062ab82679abd1d7485d66f6202d94e63", "text": "const [, , machineId] = await Promise.all([ configurationService.initialize(), userDataProfilesService.init(), <del> getMachineId() </del> <ins> getMachineId(logService.error.bind(logService)) </ins> ]); const extensionHostStatusService = new ExtensionHostStatusService();", "commid": "vscode_pr_176512"}], "negative_passages": []}
{"query_id": "q-en-vscode-2595a45cae82741b7de76961e5852ab571ecb3f4f8dbe5fc83d0fb60aef06852", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Is it possible to have a setting that would automatically replace the local tags rather than always prompting? Thx\nEven, I am also looking for a similar functionality.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n+1\nWe are now \"moving\" a tag to track the last successful build in our CI/CD process for users who don't have a lot of CI/CD or Git experience. We want them to naturally see the tag slide up as the team makes changes and the server succeeds in processing them. It's very jarring to have this modal pop up and have no way of hiding it.\nTomorrow's (2024-02-14) VS Code Insiders release has an updated dialog that has an \"Always Replace Local Tag(s)\" button. Pressing the button will toggle the so if you wish you can proactively enable this setting in your users/workspace/folder settings. Please give it a try and let me know if you run into any issues. Thanks! <img width=\"265\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-1bf219f5afd57329853a7abfb11910742bc28ae203a01b2316c9b7a94559d8e1", "text": "\"default\": false, \"description\": \"%config.followTagsWhenSync%\" }, <ins> \"git.replaceTagsWhenPull\": { \"type\": \"boolean\", \"scope\": \"resource\", \"default\": false, \"description\": \"%config.replaceTagsWhenPull%\" }, </ins> \"git.promptToSaveFilesBeforeStash\": { \"type\": \"string\", \"enum\": [", "commid": "vscode_pr_205148"}], "negative_passages": []}
{"query_id": "q-en-vscode-2595a45cae82741b7de76961e5852ab571ecb3f4f8dbe5fc83d0fb60aef06852", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Is it possible to have a setting that would automatically replace the local tags rather than always prompting? Thx\nEven, I am also looking for a similar functionality.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n+1\nWe are now \"moving\" a tag to track the last successful build in our CI/CD process for users who don't have a lot of CI/CD or Git experience. We want them to naturally see the tag slide up as the team makes changes and the server succeeds in processing them. It's very jarring to have this modal pop up and have no way of hiding it.\nTomorrow's (2024-02-14) VS Code Insiders release has an updated dialog that has an \"Always Replace Local Tag(s)\" button. Pressing the button will toggle the so if you wish you can proactively enable this setting in your users/workspace/folder settings. Please give it a try and let me know if you run into any issues. Thanks! <img width=\"265\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-5de6e624af6ae7ecea38eb8e1f0e8a33512e936f3e33693ed4846c46e922ee98", "text": "\"config.decorations.enabled\": \"Controls whether Git contributes colors and badges to the Explorer and the Open Editors view.\", \"config.enableStatusBarSync\": \"Controls whether the Git Sync command appears in the status bar.\", \"config.followTagsWhenSync\": \"Push all annotated tags when running the sync command.\", <ins> \"config.replaceTagsWhenPull\": \"Automatically replace the local tags with the remote tags in case of a conflict when running the pull command.\", </ins> \"config.promptToSaveFilesBeforeStash\": \"Controls whether Git should check for unsaved files before stashing changes.\", \"config.promptToSaveFilesBeforeStash.always\": \"Check for any unsaved files.\", \"config.promptToSaveFilesBeforeStash.staged\": \"Check only for unsaved staged files.\",", "commid": "vscode_pr_205148"}], "negative_passages": []}
{"query_id": "q-en-vscode-2595a45cae82741b7de76961e5852ab571ecb3f4f8dbe5fc83d0fb60aef06852", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Is it possible to have a setting that would automatically replace the local tags rather than always prompting? Thx\nEven, I am also looking for a similar functionality.\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n+1\nWe are now \"moving\" a tag to track the last successful build in our CI/CD process for users who don't have a lot of CI/CD or Git experience. We want them to naturally see the tag slide up as the team makes changes and the server succeeds in processing them. It's very jarring to have this modal pop up and have no way of hiding it.\nTomorrow's (2024-02-14) VS Code Insiders release has an updated dialog that has an \"Always Replace Local Tag(s)\" button. Pressing the button will toggle the so if you wish you can proactively enable this setting in your users/workspace/folder settings. Please give it a try and let me know if you run into any issues. Thanks! <img width=\"265\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-6a68a3ccca25290a6ac7207bc7763d43c27095e8505834f816a4f6721ac9b71c", "text": "throw new Error(`Unable to extract tag names from error message: ${raw}`); } <del> // Notification const replaceLocalTags = l10n.t('Replace Local Tag(s)'); const message = l10n.t('Unable to pull from remote repository due to conflicting tag(s): {0}. Would you like to resolve the conflict by replacing the local tag(s)?', tags.join(', ')); const choice = await window.showErrorMessage(message, { modal: true }, replaceLocalTags); </del> <ins> const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const replaceTagsWhenPull = config.get<boolean>('replaceTagsWhenPull', false) === true; if (!replaceTagsWhenPull) { // Notification const replaceLocalTags = l10n.t('Replace Local Tag(s)'); const replaceLocalTagsAlways = l10n.t('Always Replace Local Tag(s)'); const message = l10n.t('Unable to pull from remote repository due to conflicting tag(s): {0}. Would you like to resolve the conflict by replacing the local tag(s)?', tags.join(', ')); const choice = await window.showErrorMessage(message, { modal: true }, replaceLocalTags, replaceLocalTagsAlways); if (choice !== replaceLocalTags && choice !== replaceLocalTagsAlways) { return false; } </ins> <del> if (choice !== replaceLocalTags) { return false; </del> <ins> if (choice === replaceLocalTagsAlways) { await config.update('replaceTagsWhenPull', true, true); } </ins> } // Force fetch tags", "commid": "vscode_pr_205148"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-8508de0d71eac319669e4bbd9f776495632bb94c0b6c3713a8decbfa8220655d", "text": "import { IExtension, ExtensionState, IExtensionsWorkbenchService, VIEWLET_ID, IExtensionsViewPaneContainer, IExtensionContainer, TOGGLE_IGNORE_EXTENSION_ACTION_ID, SELECT_INSTALL_VSIX_EXTENSION_COMMAND_ID, THEME_ACTIONS_GROUP, INSTALL_ACTIONS_GROUP } from 'vs/workbench/contrib/extensions/common/extensions'; import { ExtensionsConfigurationInitialContent } from 'vs/workbench/contrib/extensions/common/extensionsFileTemplate'; import { IGalleryExtension, IExtensionGalleryService, ILocalExtension, InstallOptions, InstallOperation, TargetPlatformToString, ExtensionManagementErrorCode } from 'vs/platform/extensionManagement/common/extensionManagement'; <del> import { IWorkbenchExtensionEnablementService, EnablementState, IExtensionManagementServerService, IExtensionManagementServer, IWorkbenchExtensionManagementService } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; </del> <ins> import { IWorkbenchExtensionEnablementService, EnablementState, IExtensionManagementServerService, IExtensionManagementServer } from 'vs/workbench/services/extensionManagement/common/extensionManagement'; </ins> import { ExtensionRecommendationReason, IExtensionIgnoredRecommendationsService, IExtensionRecommendationsService } from 'vs/workbench/services/extensionRecommendations/common/extensionRecommendations'; import { areSameExtensions, getExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil'; import { ExtensionType, ExtensionIdentifier, IExtensionDescription, IExtensionManifest, isLanguagePackExtension, getWorkspaceSupportTypeMessage, TargetPlatform } from 'vs/platform/extensions/common/extensions';", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-cf3402c9678051dcbe5b10bd6b38b83e0a487425f0b342360dd97206547778f7", "text": "import { IActionViewItemOptions, ActionViewItem } from 'vs/base/browser/ui/actionbar/actionViewItems'; import { EXTENSIONS_CONFIG, IExtensionsConfigContent } from 'vs/workbench/services/extensionRecommendations/common/workspaceExtensionsConfig'; import { getErrorMessage, isCancellationError } from 'vs/base/common/errors'; <del> import { IUserDataSyncEnablementService, SyncResource } from 'vs/platform/userDataSync/common/userDataSync'; </del> <ins> import { IUserDataSyncEnablementService } from 'vs/platform/userDataSync/common/userDataSync'; </ins> import { ActionWithDropdownActionViewItem, IActionWithDropdownActionViewItemOptions } from 'vs/base/browser/ui/dropdown/dropdownActionViewItem'; import { IContextMenuProvider } from 'vs/base/browser/contextmenu'; import { ILogService } from 'vs/platform/log/common/log';", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-4b75f3ed7e934238aa399b132a2e21e559795c9ab1d0bfe4950f7adbb47a2e8a", "text": "buttons: [{ label: localize('install anyway', \"Install Anyway\"), run: () => { <del> const installAction = this.installOptions?.isMachineScoped ? this.instantiationService.createInstance(InstallAction, { donotVerifySignature: true }) : this.instantiationService.createInstance(InstallAndSyncAction, { donotVerifySignature: true }); </del> <ins> const installAction = this.instantiationService.createInstance(InstallAction, { donotVerifySignature: true }); </ins> installAction.extension = this.extension; return installAction.run(); }", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-bedcef089ae0d9189475dc161bf660da677141f175e4f88603def4590826cc3f", "text": "promptChoices.push({ label: localize('install release version', \"Install Release Version\"), run: () => { <del> const installAction = this.installOptions?.isMachineScoped ? this.instantiationService.createInstance(InstallAction, { installPreReleaseVersion: !!this.installOptions.installPreReleaseVersion }) : this.instantiationService.createInstance(InstallAndSyncAction, { installPreReleaseVersion: !!this.installOptions?.installPreReleaseVersion }); </del> <ins> const installAction = this.instantiationService.createInstance(InstallAction, { installPreReleaseVersion: !!this.installOptions?.installPreReleaseVersion }); </ins> installAction.extension = this.extension; return installAction.run(); }", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-a3ae48019b0dc26f9e394165c36a24cbbf760847d11ba31ed8a3418f2416f7d8", "text": "} } <del> export abstract class AbstractInstallAction extends ExtensionAction { </del> <ins> export class InstallAction extends ExtensionAction { </ins> static readonly Class = `${ExtensionAction.LABEL_ACTION_CLASS} prominent install`;", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-f93827e1f239caae147e03f20198b9eaafd76f605832b72d84bb52b0f27f86e7", "text": "} private readonly updateThrottler = new Throttler(); <ins> public readonly options: InstallOptions; </ins> constructor( <del> id: string, readonly options: InstallOptions, cssClass: string, </del> <ins> options: InstallOptions, </ins> @IExtensionsWorkbenchService private readonly extensionsWorkbenchService: IExtensionsWorkbenchService, @IInstantiationService private readonly instantiationService: IInstantiationService, @IExtensionService private readonly runtimeExtensionService: IExtensionService,", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-e2dff1acafc1620f4c43035f2f7e88501941db638d2d0274793fdb617c96a8dc", "text": "@IPreferencesService private readonly preferencesService: IPreferencesService, @ITelemetryService private readonly telemetryService: ITelemetryService, ) { <del> super(id, localize('install', \"Install\"), cssClass, false); </del> <ins> super('extensions.install', localize('install', \"Install\"), InstallAction.Class, false); this.options = { ...options, isMachineScoped: false }; </ins> this.update(); this._register(this.labelService.onDidChangeFormatters(() => this.updateLabel(), this)); }", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-94dd53f10d09558a2c7b66f88f66787f0e5a20dacccc7a3302a392818e16710d", "text": "} private async install(extension: IExtension): Promise<IExtension | undefined> { <del> const installOptions = this.getInstallOptions(); </del> try { <del> return await this.extensionsWorkbenchService.install(extension, installOptions); </del> <ins> return await this.extensionsWorkbenchService.install(extension, this.options); </ins> } catch (error) { <del> await this.instantiationService.createInstance(PromptExtensionInstallFailureAction, extension, extension.latestVersion, InstallOperation.Install, installOptions, error).run(); </del> <ins> await this.instantiationService.createInstance(PromptExtensionInstallFailureAction, extension, extension.latestVersion, InstallOperation.Install, this.options, error).run(); </ins> return undefined; } }", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-8d14d59e199de7522db822b2f8a720c37d0f0ccff50798549ad83d452b19e713", "text": "return localize('install', \"Install\"); } <del> protected getInstallOptions(): InstallOptions { return this.options; } } export class InstallAction extends AbstractInstallAction { constructor( options: InstallOptions, @IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService, @IInstantiationService instantiationService: IInstantiationService, @IExtensionService runtimeExtensionService: IExtensionService, @IWorkbenchThemeService workbenchThemeService: IWorkbenchThemeService, @ILabelService labelService: ILabelService, @IDialogService dialogService: IDialogService, @IPreferencesService preferencesService: IPreferencesService, @IExtensionManagementServerService private readonly extensionManagementServerService: IExtensionManagementServerService, @IWorkbenchExtensionManagementService private readonly workbenchExtensionManagementService: IWorkbenchExtensionManagementService, @IUserDataSyncEnablementService protected readonly userDataSyncEnablementService: IUserDataSyncEnablementService, @ITelemetryService telemetryService: ITelemetryService, ) { super(`extensions.install`, options, InstallAction.Class, extensionsWorkbenchService, instantiationService, runtimeExtensionService, workbenchThemeService, labelService, dialogService, preferencesService, telemetryService); this.updateLabel(); this._register(labelService.onDidChangeFormatters(() => this.updateLabel(), this)); this._register(Event.any(userDataSyncEnablementService.onDidChangeEnablement, Event.filter(userDataSyncEnablementService.onDidChangeResourceEnablement, e => e[0] === SyncResource.Extensions))(() => this.update())); } override getLabel(primary?: boolean): string { const baseLabel = super.getLabel(primary); const donotSyncLabel = localize('do no sync', \"Do not sync\"); const isMachineScoped = this.getInstallOptions().isMachineScoped; // When remote connection exists if (this._manifest && this.extensionManagementServerService.remoteExtensionManagementServer) { const server = this.workbenchExtensionManagementService.getExtensionManagementServerToInstall(this._manifest); if (server === this.extensionManagementServerService.remoteExtensionManagementServer) { const host = this.extensionManagementServerService.remoteExtensionManagementServer.label; return isMachineScoped ? localize({ key: 'install extension in remote and do not sync', comment: [ 'First placeholder is install action label.', 'Second placeholder is the name of the action to install an extension in remote server and do not sync it. Placeholder is for the name of remote server.', 'Third placeholder is do not sync label.', ] }, \"{0} in {1} ({2})\", baseLabel, host, donotSyncLabel) : localize({ key: 'install extension in remote', comment: [ 'First placeholder is install action label.', 'Second placeholder is the name of the action to install an extension in remote server and do not sync it. Placeholder is for the name of remote server.', ] }, \"{0} in {1}\", baseLabel, host); } return isMachineScoped ? localize('install extension locally and do not sync', \"{0} Locally ({1})\", baseLabel, donotSyncLabel) : localize('install extension locally', \"{0} Locally\", baseLabel); } return isMachineScoped ? `${baseLabel} (${donotSyncLabel})` : baseLabel; } protected override getInstallOptions(): InstallOptions { return { ...super.getInstallOptions(), isMachineScoped: this.userDataSyncEnablementService.isEnabled() && this.userDataSyncEnablementService.isResourceEnabled(SyncResource.Extensions) }; } } export class InstallAndSyncAction extends AbstractInstallAction { constructor( options: InstallOptions, @IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService, @IInstantiationService instantiationService: IInstantiationService, @IExtensionService runtimeExtensionService: IExtensionService, @IWorkbenchThemeService workbenchThemeService: IWorkbenchThemeService, @ILabelService labelService: ILabelService, @IDialogService dialogService: IDialogService, @IPreferencesService preferencesService: IPreferencesService, @IProductService productService: IProductService, @IUserDataSyncEnablementService private readonly userDataSyncEnablementService: IUserDataSyncEnablementService, @ITelemetryService telemetryService: ITelemetryService, ) { super('extensions.installAndSync', options, AbstractInstallAction.Class, extensionsWorkbenchService, instantiationService, runtimeExtensionService, workbenchThemeService, labelService, dialogService, preferencesService, telemetryService); this.tooltip = localize({ key: 'install everywhere tooltip', comment: ['Placeholder is the name of the product. Eg: Visual Studio Code or Visual Studio Code - Insiders'] }, \"Install this extension in all your synced {0} instances\", productService.nameLong); this._register(Event.any(userDataSyncEnablementService.onDidChangeEnablement, Event.filter(userDataSyncEnablementService.onDidChangeResourceEnablement, e => e[0] === SyncResource.Extensions))(() => this.update())); } protected override async computeAndUpdateEnablement(): Promise<void> { await super.computeAndUpdateEnablement(); if (this.enabled) { this.enabled = this.userDataSyncEnablementService.isEnabled() && this.userDataSyncEnablementService.isResourceEnabled(SyncResource.Extensions); } } protected override getInstallOptions(): InstallOptions { return { ...super.getInstallOptions(), isMachineScoped: false }; } </del> } export class InstallDropdownAction extends ActionWithDropDownAction { set manifest(manifest: IExtensionManifest | null) { <del> this.extensionActions.forEach(a => (<AbstractInstallAction>a).manifest = manifest); </del> <ins> this.extensionActions.forEach(a => (<InstallAction>a).manifest = manifest); </ins> this.update(); }", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e01bf6d9d7366c304d6d9b9d5d612800c785fcaa5a509b424cb0567abc225e0", "query": "Look at telemetry and if not a lot of users are using the Install and Do not Sync extension action remove the action to simplify the Extension Install flow. is the action name. fyi\nOk was run on 59K distinct machines. For comparison extensionGallery:install was executed on 10.4M machines. So Do not Sync is used in 0.5% of cases. I think it is fine if we remove it - we keep it somewhere but not so prominent. what do you think?\nAny suggestions?\nWe already have the \"Sync Extension\" check in the Extension context menu when it is installed - this is great. ! And we already have the \"Sync Extension\" check in the same context menu when it is not installed. Just currently if I click this, there is no effect. So ideally the experience would be that I can uncheck this before installing the extension. And thus we need no new actions. !\nLets try this in insiders already and see if we get any hit back.\nAwesome - thanks!", "positive_passages": [{"docid": "doc-en-vscode-8e305f9f29bc24a3803468d3367bd1cd806c4ca392098bc07bbe693f1704ddcb", "text": ") { super(`extensions.installActions`, '', [ [ <del> instantiationService.createInstance(InstallAndSyncAction, { installPreReleaseVersion: extensionsWorkbenchService.preferPreReleases }), instantiationService.createInstance(InstallAndSyncAction, { installPreReleaseVersion: !extensionsWorkbenchService.preferPreReleases }), ], [ </del> instantiationService.createInstance(InstallAction, { installPreReleaseVersion: extensionsWorkbenchService.preferPreReleases }), instantiationService.createInstance(InstallAction, { installPreReleaseVersion: !extensionsWorkbenchService.preferPreReleases }), ] ]); } <del> protected override getLabel(action: AbstractInstallAction): string { </del> <ins> protected override getLabel(action: InstallAction): string { </ins> return action.getLabel(true); }", "commid": "vscode_pr_184524"}], "negative_passages": []}
{"query_id": "q-en-vscode-9dc824441c4cd0f1c561e9981ecf3ab8dec13949c3d0dd672abea8ffd80f249f", "query": "repro: in settings notebook search filter to look at outputs all editors for something that only appears in outputs on the result and wait for the results to convert to rich notebook results list focus has shifted !\nHi - I'm attempting to replicate this bug, but cannot generate the output from a notebook because my build (Code - OSS Dev) crashes when I select a kernel for my notebook with the message . I am getting the extension form How were you able to get the Jupyter notebook running in your build?\nI installed the Jupyter extension via the vsix that is in the marketplace install page.\nThank you for the reply! I still run into the same error after installing the extensions from vsix when I select the kernel. Console output\nHmm, I'm not sure why this would happen. Since this is not really related to this issue directly, could you file a new issue?\nI believe the issue is related to this line in folderMatch.allDownstreamFileMatches() is returning a set of notebook files that excludes the parent file of the current selection.", "positive_passages": [{"docid": "doc-en-vscode-9e67a65fdb5092542bc65cc279546adaaf541a5af6b89534487ca3550effd104", "text": "const range = match.range(); const matchText = match.text().substr(0, range.endColumn + 150); if (replace) { <del> return nls.localize('replacePreviewResultAria', \"'{0}' at column {1} replace {2} with {3}\", matchText, range.startColumn + 1, matchString, match.replaceString); </del> <ins> return nls.localize('replacePreviewResultAria', \"'{0}' at column {1} replace {2} with {3}\", matchText, range.startColumn, matchString, match.replaceString); </ins> } <del> return nls.localize('searchResultAria', \"'{0}' at column {1} found {2}\", matchText, range.startColumn + 1, matchString); </del> <ins> return nls.localize('searchResultAria', \"'{0}' at column {1} found {2}\", matchText, range.startColumn, matchString); </ins> } return null; }", "commid": "vscode_pr_182564"}], "negative_passages": []}
{"query_id": "q-en-vscode-9dc824441c4cd0f1c561e9981ecf3ab8dec13949c3d0dd672abea8ffd80f249f", "query": "repro: in settings notebook search filter to look at outputs all editors for something that only appears in outputs on the result and wait for the results to convert to rich notebook results list focus has shifted !\nHi - I'm attempting to replicate this bug, but cannot generate the output from a notebook because my build (Code - OSS Dev) crashes when I select a kernel for my notebook with the message . I am getting the extension form How were you able to get the Jupyter notebook running in your build?\nI installed the Jupyter extension via the vsix that is in the marketplace install page.\nThank you for the reply! I still run into the same error after installing the extensions from vsix when I select the kernel. Console output\nHmm, I'm not sure why this would happen. Since this is not really related to this issue directly, could you file a new issue?\nI believe the issue is related to this line in folderMatch.allDownstreamFileMatches() is returning a set of notebook files that excludes the parent file of the current selection.", "positive_passages": [{"docid": "doc-en-vscode-f9dd0419addeb286b3d3ab75d8013d5458ef452ea0a05301b01299fd159b5bcc", "text": "if (editorWidget) { // Ensure that the editor widget is binded. If if is, then this should return immediately. // Otherwise, it will bind the widget. <del> await elemParent.bindNotebookEditorWidget(editorWidget); </del> <ins> elemParent.bindNotebookEditorWidget(editorWidget); </ins> await elemParent.updateMatchesForEditorWidget(); const matchIndex = oldParentMatches.findIndex(e => e.id() === element.id());", "commid": "vscode_pr_182564"}], "negative_passages": []}
{"query_id": "q-en-vscode-9dc824441c4cd0f1c561e9981ecf3ab8dec13949c3d0dd672abea8ffd80f249f", "query": "repro: in settings notebook search filter to look at outputs all editors for something that only appears in outputs on the result and wait for the results to convert to rich notebook results list focus has shifted !\nHi - I'm attempting to replicate this bug, but cannot generate the output from a notebook because my build (Code - OSS Dev) crashes when I select a kernel for my notebook with the message . I am getting the extension form How were you able to get the Jupyter notebook running in your build?\nI installed the Jupyter extension via the vsix that is in the marketplace install page.\nThank you for the reply! I still run into the same error after installing the extensions from vsix when I select the kernel. Console output\nHmm, I'm not sure why this would happen. Since this is not really related to this issue directly, could you file a new issue?\nI believe the issue is related to this line in folderMatch.allDownstreamFileMatches() is returning a set of notebook files that excludes the parent file of the current selection.", "positive_passages": [{"docid": "doc-en-vscode-64d7003dc9da03ae2625f38ec24cac679b9501dc3dd29ad688468d7a920512ab", "text": "if (!this.tree.getFocus().includes(match) || !this.tree.getSelection().includes(match)) { this.tree.setSelection([match], getSelectionKeyboardEvent()); <ins> this.tree.setFocus([match]); </ins> } }", "commid": "vscode_pr_182564"}], "negative_passages": []}
{"query_id": "q-en-vscode-73c37e0f1ee0c5bf67111db26ab9ad711dbc67380439fd93d72c2a2e99dd43de", "query": "a notebook and run a cell that produces an output long enough to scroll, e.g within the output element :bug: the output element scrolls to the top to select the first link", "positive_passages": [{"docid": "doc-en-vscode-b259379d88947d548f1371c53856300a1b43485f283b81dd2306eac4e4a64258", "text": "return; } <del> this._webview.focusOutput(cell.id, this._webviewFocused); </del> <ins> if (!options?.skipReveal) { this._webview.focusOutput(cell.id, this._webviewFocused); } </ins> cell.updateEditState(CellEditState.Preview, 'focusNotebookCell'); cell.focusMode = CellFocusMode.Output;", "commid": "vscode_pr_177867"}], "negative_passages": []}
{"query_id": "q-en-vscode-e40b6524ed9fdcd78f57d7149e0bc311c0e8a945760391672fda1d8ee4cc1ff5", "query": "Testing Up / down, go to top / bottom always targets the editor's scroll position, not the cell's scroll position. (Related: )\nIt actually only navigates the input cells. I can then tab into the input cell, but not the output cell. I think for accessibility there would have to be a way to focus the output cell, so that can be scrolled too?\nI also see this, page up/down, ctrl+home/end act strangely\nWe didn't update when clauses for arrow keys and page down/ups so when the focus is inside the scrollable output, it scrolls both the output and the editor.", "positive_passages": [{"docid": "doc-en-vscode-657532f66cb4a39ed9f19597666123d71fe4791bb23095ea26ddb8f72808a1ba", "text": "if (e.ctrlKey || e.shiftKey) { return; } <del> if (e.code === 'ArrowDown' || e.code === 'End' || e.code === 'ArrowUp' || e.code === 'Home') { </del> <ins> if (e.code === 'ArrowDown' || e.code === 'ArrowUp' || e.code === 'End' || e.code === 'Home' || e.code === 'PageUp' || e.code === 'PageDown') { </ins> // These should change the scroll position, not adjust the selected cell in the notebook e.stopPropagation(); }", "commid": "vscode_pr_192472"}], "negative_passages": []}
{"query_id": "q-en-vscode-79437a7c3a99b97b275e43220f32a59e7a837c303ce73a2efa170de38b78a303", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.76.2 Commit: Date: 2023-03-14T17:57:21.103Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Linux x64 5.19.0-38-generic Sandboxed: No Steps to Reproduce: a git diff view and delete one of the lines. the right pointing arrow in the diff view. https://user-\nI cannot reproduce this. Do you see any errors in developer tools? Does this reproduce with any file and with any change or is it specific to this particular file? https://user-\nI can't reproduce it anymore either. I just updated to 1.77.0. Maybe it just happened to get fixed in that version? I can still reproduce though.\nHmm no I can still reproduce it in 1.77.0.\nFound it! Seems like the issue only occurs after line 99\nHmm and another requirement is that the file has 1000 lines in total or more I think.\nI cannot reproduce. I tried with a file which has 1353 lines and I do an edit at line 600. Do you see any errors in Developer Tools (Help Toggle Developer Tools)? https://user-\nI don't think the devtools console contains anything of interest: WARN Via '' extension 'ms-' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension '' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension 'ms-toolsai.jupyter' wants API proposal 'notebookControllerKind' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. ERR Extension 'github.copilot-nightly' appears in but enables LESS API proposals than the extension wants. (LOSES): inlineCompletionsAdditions, interactive (WINS): inlineCompletionsAdditions INFO [perf] Render performance baseline is 62ms I've found that the line 100 rule doesn't completely hold for me either, when make the right panel very big it becomes clickable again.\nSo far my hypothesis is that you need a long word wrapped line above the one you're trying to reset. But honestly I'm not sure anymore at this point. https://user-\nHooray, this reproduces when using word wrapping! The root cause is that some properties on the mouse event are not converted from view coordinates to model coordinates. This reproduces with the following word wrapped .txt file:\nSeems like I can still reproduce (with and w/o word-wrapping): https://user- https://user-\nI ran git bisect and I had to skip a few commits due to build problems, but I believe this is caused by The first bad commit could be any of:\nSo merging the PR will make the arrows work but will also bring back the issue of also setting breakpoints? That is unfortunate but I think I'd rather have the arrows working.\n:+1: I think it's better to go back to the state we had in 1.77 and the risk is minimal as it is a simple revert.", "positive_passages": [{"docid": "doc-en-vscode-60f6d1f38d49ec8de034c04718a2451acf5bdeb21e63aed00aa11e1100d3e753", "text": "*--------------------------------------------------------------------------------------------*/ import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent'; <del> import { IEditorMouseEvent, IMouseTarget, IPartialEditorMouseEvent } from 'vs/editor/browser/editorBrowser'; </del> <ins> import { IEditorMouseEvent, IMouseTarget, IMouseTargetViewZoneData, IPartialEditorMouseEvent, MouseTargetType } from 'vs/editor/browser/editorBrowser'; </ins> import { ICoordinatesConverter } from 'vs/editor/common/viewModel'; import { IMouseWheelEvent } from 'vs/base/browser/mouseEvent'; <ins> import { Position } from 'vs/editor/common/core/position'; </ins> export interface EventCallback<T> { (event: T): void;", "commid": "vscode_pr_179387"}], "negative_passages": []}
{"query_id": "q-en-vscode-79437a7c3a99b97b275e43220f32a59e7a837c303ce73a2efa170de38b78a303", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.76.2 Commit: Date: 2023-03-14T17:57:21.103Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Linux x64 5.19.0-38-generic Sandboxed: No Steps to Reproduce: a git diff view and delete one of the lines. the right pointing arrow in the diff view. https://user-\nI cannot reproduce this. Do you see any errors in developer tools? Does this reproduce with any file and with any change or is it specific to this particular file? https://user-\nI can't reproduce it anymore either. I just updated to 1.77.0. Maybe it just happened to get fixed in that version? I can still reproduce though.\nHmm no I can still reproduce it in 1.77.0.\nFound it! Seems like the issue only occurs after line 99\nHmm and another requirement is that the file has 1000 lines in total or more I think.\nI cannot reproduce. I tried with a file which has 1353 lines and I do an edit at line 600. Do you see any errors in Developer Tools (Help Toggle Developer Tools)? https://user-\nI don't think the devtools console contains anything of interest: WARN Via '' extension 'ms-' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension '' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension 'ms-toolsai.jupyter' wants API proposal 'notebookControllerKind' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. ERR Extension 'github.copilot-nightly' appears in but enables LESS API proposals than the extension wants. (LOSES): inlineCompletionsAdditions, interactive (WINS): inlineCompletionsAdditions INFO [perf] Render performance baseline is 62ms I've found that the line 100 rule doesn't completely hold for me either, when make the right panel very big it becomes clickable again.\nSo far my hypothesis is that you need a long word wrapped line above the one you're trying to reset. But honestly I'm not sure anymore at this point. https://user-\nHooray, this reproduces when using word wrapping! The root cause is that some properties on the mouse event are not converted from view coordinates to model coordinates. This reproduces with the following word wrapped .txt file:\nSeems like I can still reproduce (with and w/o word-wrapping): https://user- https://user-\nI ran git bisect and I had to skip a few commits due to build problems, but I believe this is caused by The first bad commit could be any of:\nSo merging the PR will make the arrows work but will also bring back the issue of also setting breakpoints? That is unfortunate but I think I'd rather have the arrows working.\n:+1: I think it's better to go back to the state we had in 1.77 and the risk is minimal as it is a simple revert.", "positive_passages": [{"docid": "doc-en-vscode-e99842a76293ef3a5f2509dca8733542f60e3592cc3a8c22e49dfdbeb0eed11a", "text": "if (result.range) { result.range = coordinatesConverter.convertViewRangeToModelRange(result.range); } <ins> if (result.type === MouseTargetType.GUTTER_VIEW_ZONE || result.type === MouseTargetType.CONTENT_VIEW_ZONE) { result.detail = this.convertViewToModelViewZoneData(result.detail, coordinatesConverter); } </ins> return result; } <ins> private static convertViewToModelViewZoneData(data: IMouseTargetViewZoneData, coordinatesConverter: ICoordinatesConverter): IMouseTargetViewZoneData { return { viewZoneId: data.viewZoneId, positionBefore: data.positionBefore ? coordinatesConverter.convertViewPositionToModelPosition(data.positionBefore) : data.positionBefore, positionAfter: data.positionAfter ? coordinatesConverter.convertViewPositionToModelPosition(data.positionAfter) : data.positionAfter, position: coordinatesConverter.convertViewPositionToModelPosition(data.position), afterLineNumber: coordinatesConverter.convertViewPositionToModelPosition(new Position(data.afterLineNumber, 1)).lineNumber, }; } </ins> }", "commid": "vscode_pr_179387"}], "negative_passages": []}
{"query_id": "q-en-vscode-79437a7c3a99b97b275e43220f32a59e7a837c303ce73a2efa170de38b78a303", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.76.2 Commit: Date: 2023-03-14T17:57:21.103Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Linux x64 5.19.0-38-generic Sandboxed: No Steps to Reproduce: a git diff view and delete one of the lines. the right pointing arrow in the diff view. https://user-\nI cannot reproduce this. Do you see any errors in developer tools? Does this reproduce with any file and with any change or is it specific to this particular file? https://user-\nI can't reproduce it anymore either. I just updated to 1.77.0. Maybe it just happened to get fixed in that version? I can still reproduce though.\nHmm no I can still reproduce it in 1.77.0.\nFound it! Seems like the issue only occurs after line 99\nHmm and another requirement is that the file has 1000 lines in total or more I think.\nI cannot reproduce. I tried with a file which has 1353 lines and I do an edit at line 600. Do you see any errors in Developer Tools (Help Toggle Developer Tools)? https://user-\nI don't think the devtools console contains anything of interest: WARN Via '' extension 'ms-' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension '' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension 'ms-toolsai.jupyter' wants API proposal 'notebookControllerKind' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. ERR Extension 'github.copilot-nightly' appears in but enables LESS API proposals than the extension wants. (LOSES): inlineCompletionsAdditions, interactive (WINS): inlineCompletionsAdditions INFO [perf] Render performance baseline is 62ms I've found that the line 100 rule doesn't completely hold for me either, when make the right panel very big it becomes clickable again.\nSo far my hypothesis is that you need a long word wrapped line above the one you're trying to reset. But honestly I'm not sure anymore at this point. https://user-\nHooray, this reproduces when using word wrapping! The root cause is that some properties on the mouse event are not converted from view coordinates to model coordinates. This reproduces with the following word wrapped .txt file:\nSeems like I can still reproduce (with and w/o word-wrapping): https://user- https://user-\nI ran git bisect and I had to skip a few commits due to build problems, but I believe this is caused by The first bad commit could be any of:\nSo merging the PR will make the arrows work but will also bring back the issue of also setting breakpoints? That is unfortunate but I think I'd rather have the arrows working.\n:+1: I think it's better to go back to the state we had in 1.77 and the risk is minimal as it is a simple revert.", "positive_passages": [{"docid": "doc-en-vscode-452180f34d137b7091cbee97716b653f45e26ea5755fc01a0a07197b7d24ae14", "text": "})); // Revert change when an arrow is clicked. <del> this._register(editor.onMouseUp(event => { </del> <ins> this._register(editor.onMouseDown(event => { </ins> if (!event.event.rightButton && event.target.position && event.target.element?.className.includes('arrow-revert-change')) { const lineNumber = event.target.position.lineNumber; const viewZone = event.target as editorBrowser.IMouseTargetViewZone | undefined;", "commid": "vscode_pr_181040"}], "negative_passages": []}
{"query_id": "q-en-vscode-79437a7c3a99b97b275e43220f32a59e7a837c303ce73a2efa170de38b78a303", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.76.2 Commit: Date: 2023-03-14T17:57:21.103Z Electron: 19.1.11 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Linux x64 5.19.0-38-generic Sandboxed: No Steps to Reproduce: a git diff view and delete one of the lines. the right pointing arrow in the diff view. https://user-\nI cannot reproduce this. Do you see any errors in developer tools? Does this reproduce with any file and with any change or is it specific to this particular file? https://user-\nI can't reproduce it anymore either. I just updated to 1.77.0. Maybe it just happened to get fixed in that version? I can still reproduce though.\nHmm no I can still reproduce it in 1.77.0.\nFound it! Seems like the issue only occurs after line 99\nHmm and another requirement is that the file has 1000 lines in total or more I think.\nI cannot reproduce. I tried with a file which has 1353 lines and I do an edit at line 600. Do you see any errors in Developer Tools (Help Toggle Developer Tools)? https://user-\nI don't think the devtools console contains anything of interest: WARN Via '' extension 'ms-' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension '' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. WARN Via '' extension 'ms-toolsai.jupyter' wants API proposal 'notebookControllerKind' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check '') or was abandoned. ERR Extension 'github.copilot-nightly' appears in but enables LESS API proposals than the extension wants. (LOSES): inlineCompletionsAdditions, interactive (WINS): inlineCompletionsAdditions INFO [perf] Render performance baseline is 62ms I've found that the line 100 rule doesn't completely hold for me either, when make the right panel very big it becomes clickable again.\nSo far my hypothesis is that you need a long word wrapped line above the one you're trying to reset. But honestly I'm not sure anymore at this point. https://user-\nHooray, this reproduces when using word wrapping! The root cause is that some properties on the mouse event are not converted from view coordinates to model coordinates. This reproduces with the following word wrapped .txt file:\nSeems like I can still reproduce (with and w/o word-wrapping): https://user- https://user-\nI ran git bisect and I had to skip a few commits due to build problems, but I believe this is caused by The first bad commit could be any of:\nSo merging the PR will make the arrows work but will also bring back the issue of also setting breakpoints? That is unfortunate but I think I'd rather have the arrows working.\n:+1: I think it's better to go back to the state we had in 1.77 and the risk is minimal as it is a simple revert.", "positive_passages": [{"docid": "doc-en-vscode-4860dd2155ca44c9e98341088196d8a2c3998b3f62297379593219789fbb678d", "text": "} })); <del> this._register(editor.onMouseUp((e: IEditorMouseEvent) => { </del> <ins> this._register(editor.onMouseDown((e: IEditorMouseEvent) => { </ins> if (!e.event.rightButton) { return; }", "commid": "vscode_pr_181040"}], "negative_passages": []}
{"query_id": "q-en-vscode-704fcd20e716d777ebd1ef37b2a7ff0dff13bdaec1f7de37d146e0eb9f0eca7d", "query": "It seems the extension's raw is used for the text here. To combat this I had to restate my extension's name in the extension description, which probably isn't the desired approach. I think ideally the extension name would be featured prominently, and the extension description would be below it or something. <img width=\"1040\" alt=\"image\" src=\"https://user-\"<img width=\"777\" alt=\"image\" src=\"https://user-\"Demo:", "positive_passages": [{"docid": "doc-en-vscode-143c5bc34cf57388bda692209d427267c77f662bc0853026c9421b02463037d6", "text": "// group controllers by extension for (const group of groupBy(others, (a, b) => a.extension.value === b.extension.value ? 0 : 1)) { const extension = this._extensionService.extensions.find(extension => extension.identifier.value === group[0].extension.value); <del> const source = extension?.description ?? group[0].extension.value; </del> <ins> const source = extension?.displayName ?? extension?.description ?? group[0].extension.value; </ins> if (group.length > 1) { quickPickItems.push({ label: source,", "commid": "vscode_pr_181379"}], "negative_passages": []}
{"query_id": "q-en-vscode-12c44807288efb7a18784394a3ec1d113c8d5eb29abadf9481002b7899c243be", "query": "Type: <bBug</bdark v2 theme files from the explorer and drag then in to an editor bug There's no background to the dragged element label so it blends into the editor text ! VS Code version: Code - Insiders 1.78.0-insider (Universal) (, 2023-04-17T12:50:42.586Z) OS version: Darwin x64 22.4.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (51)</summaryExtensionVersion ------ tsl-problem-matcher0.6.2 comment-tagged-templates0.3.2 docs-view0.0.11 emojisense0.9.1 folder-source-actions0.2.1 markdown-mermaid1.18.1 vscode-eslint2.4.0 kusto0.4.3 typescript-notebook2.0.6 EditorConfig0.16.4 codespaces1.14.5 copilot-nightly1.82.24 vscode-pull-request-github0.63. vscode-drawio1.6.6 vscode-postfix-ts1.12.1 search-editor-apply-changes0.1.1 latex-workshop9.8.2 vscode-tree-sitter-query0.0.1 vscode-position1.1.2 template-string-converter0.6.1 vscode-docker1.25.0 vscode-language-pack-de1.77. vscode-language-pack-zh-hans1.77. isort2023.9. python2023.7. vscode-pylance2023.4.21 jupyter2023.4. jupyter-keymap1.1.0 jupyter-renderers1.0.15 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.290.0 remote-ssh0.101. remote-ssh-edit0.84.0 azure-account0.11.3 cpptools1.15.2 hexeditor1.9.11 js-debug-nightly2023.4.1317 live-server0.5. remote-explorer0.5. remote-server1.1. test-adapter-converter0.1.7 vscode-github-issue-notebooks0.0.128 vscode-js-profile-flame1.0.5 vscode-marketplace-extension-browser0.0.7 vsliveshare1.0.5857 code-spell-checker2.20.4 ayu1.0.5 luna-paint0.16.0 sort-lines1.9.1 fast-arrow1.0.8 (2 theme extensions excluded) </details<!-- generated by issue reporter --\nI believe the background normally comes from this line:", "positive_passages": [{"docid": "doc-en-vscode-733eff6abd8902430e904f4c3818053d04b1bf9392bae817980794ad4ffcea31", "text": "\"inputOption.activeBackground\": \"#2489db82\", \"inputOption.activeBorder\": \"#2488db\", \"keybindingLabel.foreground\": \"#cccccc\", <del> \"list.activeSelectionBackground\": \"#ffffff0f\", </del> <ins> \"list.activeSelectionBackground\": \"#323232\", </ins> \"list.activeSelectionIconForeground\": \"#ffffff\", \"list.activeSelectionForeground\": \"#ffffff\", \"menu.background\": \"#1f1f1f\",", "commid": "vscode_pr_180170"}], "negative_passages": []}
{"query_id": "q-en-vscode-93428c09150e33551d9e3374851265fddbaf87abd8d110f1f8b0ae0ec694836e", "query": "This throws the exception below. This happens when logging objects without prototypes, e.g . Instead of the property access should be used", "positive_passages": [{"docid": "doc-en-vscode-3e0c1dd43b0f79ae9abd687c093ee396200308fe35111b3e612c86c372b5312f", "text": "return cloneAndChange(data, value => { // If it's a trusted value it means it's okay to skip cleaning so we don't clean it <del> if (value instanceof TelemetryTrustedValue || value.hasOwnProperty('isTrustedTelemetryValue')) { </del> <ins> if (value instanceof TelemetryTrustedValue || Object.hasOwnProperty.call(value, 'isTrustedTelemetryValue')) { </ins> return value.value; }", "commid": "vscode_pr_180226"}], "negative_passages": []}
{"query_id": "q-en-vscode-e94eb279bb36621a7c3a24e185aa4a067cf39142079ff34b2dcdd99acc75d2c4", "query": "Open a file with multiple changed regions in git Move cursor inside/next to some change Run \"Show Next Change\" (alt+f3) It reveals and shows a different change- I think it always shows the last one in the editor. It should show the next one after the cursor position I can press it multiple times to cycle through changes, and that's correct, but it always starts with the last change\nI'd like to fix this for April, but it looks like the change could be risky. I will fix it for May.\nFound a low risk fix.\nThis works, thanks! But one thing that my muscle memory is unsure about, did this command previously move the cursor? I'm noticing that if I press it multiple times, then press escape, the view moves back to the place where I started, when I'm expecting this to be like a \"navigate\" action. I can open a new issue, or if it's always worked like this, it's fine\nI went back to 1.74 to check, and it didn't move the cursor there. \"Go to Next Change\" will move the cursor though.", "positive_passages": [{"docid": "doc-en-vscode-7509d2e9c74abfffe9254e1d88b5e80edac1f30453ed14f82ebf89976bc03bf6", "text": "} let index: number; <del> if (this.editor.hasModel() && (typeof lineNumber === 'number')) { </del> <ins> if (this.editor.hasModel() && (typeof lineNumber === 'number' || !this.widget.provider)) { </ins> index = this.model.findNextClosestChange(typeof lineNumber === 'number' ? lineNumber : this.editor.getPosition().lineNumber, true, this.widget.provider); } else { const providerChanges: number[] = this.model.mapChanges.get(this.widget.provider) ?? this.model.mapChanges.values().next().value;", "commid": "vscode_pr_180951"}], "negative_passages": []}
{"query_id": "q-en-vscode-e94eb279bb36621a7c3a24e185aa4a067cf39142079ff34b2dcdd99acc75d2c4", "query": "Open a file with multiple changed regions in git Move cursor inside/next to some change Run \"Show Next Change\" (alt+f3) It reveals and shows a different change- I think it always shows the last one in the editor. It should show the next one after the cursor position I can press it multiple times to cycle through changes, and that's correct, but it always starts with the last change\nI'd like to fix this for April, but it looks like the change could be risky. I will fix it for May.\nFound a low risk fix.\nThis works, thanks! But one thing that my muscle memory is unsure about, did this command previously move the cursor? I'm noticing that if I press it multiple times, then press escape, the view moves back to the place where I started, when I'm expecting this to be like a \"navigate\" action. I can open a new issue, or if it's always worked like this, it's fine\nI went back to 1.74 to check, and it didn't move the cursor there. \"Go to Next Change\" will move the cursor though.", "positive_passages": [{"docid": "doc-en-vscode-1fd5dba1029fcc0c4b08f279842bc96f15dbe708761d3cefd3424f11ee261ef7", "text": "const possibleChangesLength = possibleChanges.length; if (inclusive) { <del> if ((getModifiedEndLineNumber(change.change) >= lineNumber) && (change.change.modifiedStartLineNumber <= lineNumber)) { </del> <ins> if (getModifiedEndLineNumber(change.change) >= lineNumber) { </ins> if (preferredProvider && change.label !== preferredProvider) { possibleChanges.push(i); } else {", "commid": "vscode_pr_180951"}], "negative_passages": []}
{"query_id": "q-en-vscode-cace4044cc91e38b64563a0bc5ba25beee08bad88c04eefce72174ab1ed2f086", "query": "Testing !\nLooking through the code, it seems that it comes from returning multiple from my for the search editor. The problem is with the functionality that allows certain lines to be underlined for mouse definition hover. Instead of underlining the lines individually, it underlines the whole range starting with the start of the first range and ends at the end of the last range. cc\nI think the underlines are by the go to definition feature and not by the link provider. Do you think the API is used incorrectly or is there an issue on the UI side?\nThe UI receives two locations for the definition request. To draw the underline it merges both into a combined range. Looks like it doesn't check if the origin ranges actually contains the position at which the request has been made - I am unsure if that's on purpose or not. So, there might be something in the UI side to fix but the extension also return bogous data. It looks like it return all results when being asks for the definition . That's not how it is intended to work and either a the file itself should be used or no definition should be provided <img width=\"1461\" alt=\"Screenshot 2023-06-13 at 15 32 19\" src=\"\"\nI'm not sure if I understand this correctly. What is the position at which the request had been made and what would be wrong with this being the origin? Makes sense. I haven't actually editing anything in this extension before, so I'll take another look at what was intended when it was first implemented.\nI'm taking another look at this and I have a few questions about the API. I think that the original intention of using a definition provider was this: so that double-clicking the filename in the search editor would pop up references to the code snippets that are directly below it. Given this, I'm wondering: If I want multiple references listed like this, do I get the provider to return more than one and they would all have the same ? What is the difference between the and ? I read the docs and I don't know the difference between the full target range and the span.\nThe has two ends - the origin at which it starts and its target to where it goes. The origin defaults to the word at the current position (cursor) but can be refined if that isn't good enough. The two target ranges are the whole target and its focal point, think of a function where the whole function (comment, signature, body) is and its name is - when navigation a definition link the cursor is placed at the target selection range but the whole targetRange is reveal and/or highlighted etc.", "positive_passages": [{"docid": "doc-en-vscode-f712be3bbd8a507b478070ea097df0db60269746074588b4e974eb015c70e35d", "text": "const lineResult = parseSearchResults(document, token)[position.line]; if (!lineResult) { return []; } if (lineResult.type === 'file') { <del> return lineResult.allLocations; </del> <ins> return lineResult.allLocations.map(l => ({ ...l, originSelectionRange: lineResult.location.originSelectionRange })); </ins> } const location = lineResult.locations.find(l => l.originSelectionRange.contains(position));", "commid": "vscode_pr_187091"}], "negative_passages": []}
{"query_id": "q-en-vscode-30e8fafc0fdf52ff2a56459be98f72faaef60b1c63f58b313a904ce6659cf485", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --. However, it is very long and explicit and thus decreases readability: I would like to request a new variable, , that would be its shorter alias that also stands out visually due to no alphanumeric characters: This is inspired by .\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-cb1409c85f8dbacabddc716fc3d5bd87909ec85cb3f4cf7e28aaebc25fec8b76", "text": "{ label: 'fileBasename', detail: vscode.l10n.t(\"The current opened file's basename\") }, { label: 'fileBasenameNoExtension', detail: vscode.l10n.t(\"The current opened file's basename with no file extension\") }, { label: 'defaultBuildTask', detail: vscode.l10n.t(\"The name of the default build task. If there is not a single default build task then a quick pick is shown to choose the build task.\") }, <del> { label: 'pathSeparator', detail: vscode.l10n.t(\"The character used by the operating system to separate components in file paths\") }, </del> <ins> { label: 'pathSeparator', detail: vscode.l10n.t(\"The character used by the operating system to separate components in file paths. Is also aliased to '/'.\") }, </ins> { label: 'extensionInstallFolder', detail: vscode.l10n.t(\"The path where an an extension is installed.\"), param: 'publisher.extension' }, ].map(variable => ({ label: `${${variable.label}}`,", "commid": "vscode_pr_200750"}], "negative_passages": []}
{"query_id": "q-en-vscode-30e8fafc0fdf52ff2a56459be98f72faaef60b1c63f58b313a904ce6659cf485", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --. However, it is very long and explicit and thus decreases readability: I would like to request a new variable, , that would be its shorter alias that also stands out visually due to no alphanumeric characters: This is inspired by .\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-49d531929e72db87273e75423f546c3954b724b0deabb32bfa6ad051cf1239bf", "text": "FileDirnameBasename = 'fileDirnameBasename', ExecPath = 'execPath', ExecInstallFolder = 'execInstallFolder', <del> PathSeparator = 'pathSeparator' </del> <ins> PathSeparator = 'pathSeparator', PathSeparatorAlias = '/' </ins> } export class VariableError extends Error {", "commid": "vscode_pr_200750"}], "negative_passages": []}
{"query_id": "q-en-vscode-30e8fafc0fdf52ff2a56459be98f72faaef60b1c63f58b313a904ce6659cf485", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --. However, it is very long and explicit and thus decreases readability: I would like to request a new variable, , that would be its shorter alias that also stands out visually due to no alphanumeric characters: This is inspired by .\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\n<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-06d47b894628238b53ae8e367146406abf2d70eb3863bef969d87df647725c42", "text": "return match; } case 'pathSeparator': <ins> case '/': </ins> return paths.sep; default:", "commid": "vscode_pr_200750"}], "negative_passages": []}
{"query_id": "q-en-vscode-676b9494f037cb52d5bfb14a80f715fc8b7083909cdfd610c7cc34e2f7cd9227", "query": "Testing I'm not clear on what unforwarding a port means so this maybe expected, but we do detect that the process is no longer running but it still appears in the list: !\ncan you please provide the steps you used to get here? If port forwarding is properly set (setting + reload) then yes, the port should be unforwarded and no longer appear in the list.\nRun the above Python script in integrated terminal when using Remote-SSH, it should start appearing in the list along with process ID under \"Running process\" column. Kill process using in a separate terminal.\nAlso confirming I made sure this was done as well.\nThank you for the steps!\nWhen verifying, please test that the port is unforwarded with both and are used.\nThe port is not unforwarded when is used. It is however unforwarded when is used. I'm testing with the vscode-remote-try-node repo and the default launch config.\nThe fix works for me though, with the original Python script I provided.\nI'm not able to reproduce this. It's possible for what you describe to occur if the process is terminated before we have a chance notice that it's running. If you see this again can you please set the log level to debug, repro, and share logs from Remote Extension Host and Window? Closing again for testing.\nI am unable to reproduce the issue with vscode-remote-try-node on Codespaces or Dev Containers, though it did take a bit longer for the port to close on Codespaces. Marking as verified.", "positive_passages": [{"docid": "doc-en-vscode-2ece2bc39e4341941355dcb20d49180c53fe68bae97cc5679e626d700c5cc091", "text": "import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Extensions, IViewContainersRegistry, IViewsRegistry, ViewContainer, ViewContainerLocation } from 'vs/workbench/common/views'; <del> import { Attributes, AutoTunnelSource, IRemoteExplorerService, makeAddress, mapHasAddressLocalhostOrAllInterfaces, OnPortForward, PORT_AUTO_FORWARD_SETTING, PORT_AUTO_SOURCE_SETTING, PORT_AUTO_SOURCE_SETTING_HYBRID, PORT_AUTO_SOURCE_SETTING_OUTPUT, PORT_AUTO_SOURCE_SETTING_PROCESS, TUNNEL_VIEW_CONTAINER_ID, TUNNEL_VIEW_ID, TunnelSource } from 'vs/workbench/services/remote/common/remoteExplorerService'; </del> <ins> import { Attributes, AutoTunnelSource, IRemoteExplorerService, makeAddress, mapHasAddressLocalhostOrAllInterfaces, OnPortForward, PORT_AUTO_FORWARD_SETTING, PORT_AUTO_SOURCE_SETTING, PORT_AUTO_SOURCE_SETTING_HYBRID, PORT_AUTO_SOURCE_SETTING_OUTPUT, PORT_AUTO_SOURCE_SETTING_PROCESS, Tunnel, TUNNEL_VIEW_CONTAINER_ID, TUNNEL_VIEW_ID, TunnelSource } from 'vs/workbench/services/remote/common/remoteExplorerService'; </ins> import { forwardedPortsViewEnabled, ForwardPortAction, OpenPortInBrowserAction, TunnelPanel, TunnelPanelDescriptor, TunnelViewModel, OpenPortInPreviewAction, openPreviewEnabledContext } from 'vs/workbench/contrib/remote/browser/tunnelView'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';", "commid": "vscode_pr_181005"}], "negative_passages": []}
{"query_id": "q-en-vscode-676b9494f037cb52d5bfb14a80f715fc8b7083909cdfd610c7cc34e2f7cd9227", "query": "Testing I'm not clear on what unforwarding a port means so this maybe expected, but we do detect that the process is no longer running but it still appears in the list: !\ncan you please provide the steps you used to get here? If port forwarding is properly set (setting + reload) then yes, the port should be unforwarded and no longer appear in the list.\nRun the above Python script in integrated terminal when using Remote-SSH, it should start appearing in the list along with process ID under \"Running process\" column. Kill process using in a separate terminal.\nAlso confirming I made sure this was done as well.\nThank you for the steps!\nWhen verifying, please test that the port is unforwarded with both and are used.\nThe port is not unforwarded when is used. It is however unforwarded when is used. I'm testing with the vscode-remote-try-node repo and the default launch config.\nThe fix works for me though, with the original Python script I provided.\nI'm not able to reproduce this. It's possible for what you describe to occur if the process is terminated before we have a chance notice that it's running. If you see this again can you please set the log level to debug, repro, and share logs from Remote Extension Host and Window? Closing again for testing.\nI am unable to reproduce the issue with vscode-remote-try-node on Codespaces or Dev Containers, though it did take a bit longer for the port to close on Codespaces. Marking as verified.", "positive_passages": [{"docid": "doc-en-vscode-236cee824857dc43545fef1a0dd47e0eee3702fd8f169fdf2dd3d54833308c34", "text": "private async handleCandidateUpdate(removed: Map<string, { host: string; port: number }>) { const removedPorts: number[] = []; <del> let autoForwarded: Set<string>; </del> <ins> let autoForwarded: Map<string, string | Tunnel>; </ins> if (this.unforwardOnly) { <del> autoForwarded = new Set(); </del> <ins> autoForwarded = new Map(); </ins> for (const entry of this.remoteExplorerService.tunnelModel.forwarded.entries()) { if (entry[1].source.source === TunnelSource.Auto) { <del> autoForwarded.add(entry[0]); </del> <ins> autoForwarded.set(entry[0], entry[1]); </ins> } } } else { <del> autoForwarded = this.autoForwarded; </del> <ins> autoForwarded = new Map(this.autoForwarded.entries()); </ins> } for (const removedPort of removed) { const key = removedPort[0]; <del> const value = removedPort[1]; if (autoForwarded.has(key)) { </del> <ins> let value = removedPort[1]; const forwardedValue = mapHasAddressLocalhostOrAllInterfaces(autoForwarded, value.host, value.port); if (forwardedValue) { if (typeof forwardedValue === 'string') { this.autoForwarded.delete(key); } else { value = { host: forwardedValue.remoteHost, port: forwardedValue.remotePort }; } </ins> await this.remoteExplorerService.close(value); <del> autoForwarded.delete(key); </del> removedPorts.push(value.port); } else if (this.notifiedOnly.has(key)) { this.notifiedOnly.delete(key);", "commid": "vscode_pr_181005"}], "negative_passages": []}
{"query_id": "q-en-vscode-11deda212084da3276f17e7ae5973646a969f209612445eebe6e665861aa6f8e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the \"Developer: Set Log Level...\" command and set it to \"Trace\" there's no \"Telemetry\" channel there, only Extension Telemetry: !\nDo you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.\nWhere do you register Telemetry logger in codespaces, is it in server or on client side?\nIt's registered client side.\nMay I know where it is registered in sources?\nCan you please check if this code is being executed in the codespace?\nIt seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.\nCan you please provide me steps to enable this locally from sources?\nSent instructions offline\nStill not seeing the telemetry output channel in Codespaces (on desktop if it matters)\nActually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.", "positive_passages": [{"docid": "doc-en-vscode-7ba1efe201105b120ebf6ec4deced8f57b26aab02c3fb37258c908ab4ff754ef", "text": "import { IWorkbenchConstructionOptions, IWorkbench, ITunnel } from 'vs/workbench/browser/web.api'; import { BrowserStorageService } from 'vs/workbench/services/storage/browser/storageService'; import { IStorageService } from 'vs/platform/storage/common/storage'; <del> import { BufferLogger } from 'vs/platform/log/common/bufferLog'; import { FileLoggerService } from 'vs/platform/log/common/fileLog'; </del> import { toLocalISOString } from 'vs/base/common/date'; import { isWorkspaceToOpen, isFolderToOpen } from 'vs/platform/window/common/window'; import { getSingleFolderWorkspaceIdentifier, getWorkspaceIdentifier } from 'vs/workbench/services/workspaces/browser/workspaces';", "commid": "vscode_pr_182486"}], "negative_passages": []}
{"query_id": "q-en-vscode-11deda212084da3276f17e7ae5973646a969f209612445eebe6e665861aa6f8e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the \"Developer: Set Log Level...\" command and set it to \"Trace\" there's no \"Telemetry\" channel there, only Extension Telemetry: !\nDo you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.\nWhere do you register Telemetry logger in codespaces, is it in server or on client side?\nIt's registered client side.\nMay I know where it is registered in sources?\nCan you please check if this code is being executed in the codespace?\nIt seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.\nCan you please provide me steps to enable this locally from sources?\nSent instructions offline\nStill not seeing the telemetry output channel in Codespaces (on desktop if it matters)\nActually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.", "positive_passages": [{"docid": "doc-en-vscode-e42fe947547b6a2d5437329bce1c24b1b77a77952fbc2b4439f7d97ccf5bfc8b", "text": "import { IStoredWorkspace } from 'vs/platform/workspaces/common/workspaces'; import { UserDataProfileInitializer } from 'vs/workbench/services/userDataProfile/browser/userDataProfileInit'; import { UserDataSyncInitializer } from 'vs/workbench/services/userDataSync/browser/userDataSyncInit'; <ins> import { BufferLogger } from 'vs/platform/log/common/bufferLog'; import { FileLoggerService } from 'vs/platform/log/common/fileLog'; </ins> export class BrowserMain extends Disposable {", "commid": "vscode_pr_182486"}], "negative_passages": []}
{"query_id": "q-en-vscode-11deda212084da3276f17e7ae5973646a969f209612445eebe6e665861aa6f8e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the \"Developer: Set Log Level...\" command and set it to \"Trace\" there's no \"Telemetry\" channel there, only Extension Telemetry: !\nDo you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.\nWhere do you register Telemetry logger in codespaces, is it in server or on client side?\nIt's registered client side.\nMay I know where it is registered in sources?\nCan you please check if this code is being executed in the codespace?\nIt seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.\nCan you please provide me steps to enable this locally from sources?\nSent instructions offline\nStill not seeing the telemetry output channel in Codespaces (on desktop if it matters)\nActually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.", "positive_passages": [{"docid": "doc-en-vscode-477f57759f7109be89f7fa1b9df71382c5dfa3d22fd3236242fb6338b6ad9341", "text": "const environmentService = new BrowserWorkbenchEnvironmentService(workspace.id, logsPath, this.configuration, productService); serviceCollection.set(IBrowserWorkbenchEnvironmentService, environmentService); <del> // Log const logLevel = getLogLevel(environmentService); const bufferLogger = new BufferLogger(logLevel); const otherLoggers: ILogger[] = [new ConsoleLogger(logLevel)]; </del> <ins> // Files const fileLogger = new BufferLogger(); const fileService = this._register(new FileService(fileLogger)); serviceCollection.set(IWorkbenchFileService, fileService); // Logger const loggerService = new FileLoggerService(getLogLevel(environmentService), logsPath, fileService); serviceCollection.set(ILoggerService, loggerService); // Log Service const otherLoggers: ILogger[] = [new ConsoleLogger(loggerService.getLogLevel())]; </ins> if (environmentService.isExtensionDevelopment && !!environmentService.extensionTestsLocationURI) { <del> otherLoggers.push(new ConsoleLogInAutomationLogger(logLevel)); </del> <ins> otherLoggers.push(new ConsoleLogInAutomationLogger(loggerService.getLogLevel())); </ins> } <del> const logService = new LogService(bufferLogger, otherLoggers); </del> <ins> const logger = loggerService.createLogger(environmentService.logFile, { id: windowLogId, name: localize('rendererLog', \"Window\") }); const logService = new LogService(logger, otherLoggers); </ins> serviceCollection.set(ILogService, logService); <ins> // Set the logger of the fileLogger after the log service is ready. // This is to avoid cyclic dependency fileLogger.logger = logService; // Register File System Providers depending on IndexedDB support // Register them early because they are needed for the profiles initialization await this.registerIndexedDBFileSystemProviders(environmentService, fileService, logService, loggerService, logsPath); </ins> // Remote const connectionToken = environmentService.options.connectionToken || getCookieValue(connectionTokenCookieName); const remoteAuthorityResolverService = new RemoteAuthorityResolverService(!environmentService.expectsResolverExtension, connectionToken, this.configuration.resourceUriProvider, productService, logService);", "commid": "vscode_pr_182486"}], "negative_passages": []}
{"query_id": "q-en-vscode-11deda212084da3276f17e7ae5973646a969f209612445eebe6e665861aa6f8e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the \"Developer: Set Log Level...\" command and set it to \"Trace\" there's no \"Telemetry\" channel there, only Extension Telemetry: !\nDo you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.\nWhere do you register Telemetry logger in codespaces, is it in server or on client side?\nIt's registered client side.\nMay I know where it is registered in sources?\nCan you please check if this code is being executed in the codespace?\nIt seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.\nCan you please provide me steps to enable this locally from sources?\nSent instructions offline\nStill not seeing the telemetry output channel in Codespaces (on desktop if it matters)\nActually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.", "positive_passages": [{"docid": "doc-en-vscode-38900e1d4b8b1c5bb7ffe3a16ab0ca4d6425b79936fcdec15eeb7aa27f2f7b62", "text": "// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! <del> // Files const fileService = this._register(new FileService(logService)); serviceCollection.set(IWorkbenchFileService, fileService); // Logger const loggerService = new FileLoggerService(logLevel, logsPath, fileService); serviceCollection.set(ILoggerService, loggerService); // Register File System Providers depending on IndexedDB support // Register them early because they are needed for the profiles initialization await this.registerIndexedDBFileSystemProviders(environmentService, fileService, bufferLogger, logService, loggerService, logsPath); </del> // URI Identity const uriIdentityService = new UriIdentityService(fileService); serviceCollection.set(IUriIdentityService, uriIdentityService);", "commid": "vscode_pr_182486"}], "negative_passages": []}
{"query_id": "q-en-vscode-11deda212084da3276f17e7ae5973646a969f209612445eebe6e665861aa6f8e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the \"Developer: Set Log Level...\" command and set it to \"Trace\" there's no \"Telemetry\" channel there, only Extension Telemetry: !\nDo you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.\nWhere do you register Telemetry logger in codespaces, is it in server or on client side?\nIt's registered client side.\nMay I know where it is registered in sources?\nCan you please check if this code is being executed in the codespace?\nIt seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.\nCan you please provide me steps to enable this locally from sources?\nSent instructions offline\nStill not seeing the telemetry output channel in Codespaces (on desktop if it matters)\nActually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.", "positive_passages": [{"docid": "doc-en-vscode-73fad4b7ab0c0bfd059d14d34ebd4e011972a200f78b3ab187b5c5772e70f6f8", "text": "} } <del> private async registerIndexedDBFileSystemProviders(environmentService: IWorkbenchEnvironmentService, fileService: IWorkbenchFileService, bufferLogger: BufferLogger, logService: ILogService, loggerService: ILoggerService, logsPath: URI): Promise<void> { </del> <ins> private async registerIndexedDBFileSystemProviders(environmentService: IWorkbenchEnvironmentService, fileService: IWorkbenchFileService, logService: ILogService, loggerService: ILoggerService, logsPath: URI): Promise<void> { </ins> // IndexedDB is used for logging and user data let indexedDB: IndexedDB | undefined; const userDataStore = 'vscode-userdata-store';", "commid": "vscode_pr_182486"}], "negative_passages": []}
{"query_id": "q-en-vscode-11deda212084da3276f17e7ae5973646a969f209612445eebe6e665861aa6f8e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Codespaces Visual Studio Code - Insiders Version: 1.78.0-insider Commit: Date: 2023-05-02T11:17:01.989Z (10 hrs ago) Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36 Edg/112.0.1722.68 Steps to Reproduce: a GitHub Codespace from an existing repo the \"Developer: Set Log Level...\" command and set it to \"Trace\" there's no \"Telemetry\" channel there, only Extension Telemetry: !\nDo you have any ideas I assume there would be nothing special needing to be done for codespaces, I register this output channel the same as the extension one and the same as the other output channels.\nWhere do you register Telemetry logger in codespaces, is it in server or on client side?\nIt's registered client side.\nMay I know where it is registered in sources?\nCan you please check if this code is being executed in the codespace?\nIt seems to be missing from web too. I can confirm when debugging the web bits locally it is called and registered, but nothing shows up in the output channel list.\nCan you please provide me steps to enable this locally from sources?\nSent instructions offline\nStill not seeing the telemetry output channel in Codespaces (on desktop if it matters)\nActually this is a bug in web, but I can confirm that this is working for me in both web and desktop. Wondering if you have any additional steps to repro.", "positive_passages": [{"docid": "doc-en-vscode-28fb7f7b377082c781d5eb1f0eb507baefb8041daf35e50ad87f45dc7441cc01", "text": "fileService.registerProvider(logsPath.scheme, new InMemoryFileSystemProvider()); } <del> bufferLogger.logger = loggerService.createLogger(environmentService.logFile, { id: windowLogId, name: localize('rendererLog', \"Window\") }); </del> // User data let userDataProvider; if (indexedDB) {", "commid": "vscode_pr_182486"}], "negative_passages": []}
{"query_id": "q-en-vscode-09a72e874684dad8cc5dd31490588928394c8a10a2c906033055e8faea3d1361", "query": "Type a multiline commit message Scroll away Scroll back When the row gets rerendered (I assume) it is sized to one line. If I type a newline in this box, the size gets fixed !\nPossibly a regression introduced with", "positive_passages": [{"docid": "doc-en-vscode-bf9390b5643f23e0e908cebc9bac1cc47d33a3dae6cbb114fda2ebc227365959", "text": "const inputWidget = this.instantiationService.createInstance(SCMInputWidget, inputElement, this.overflowWidgetsDomNode); templateDisposable.add(inputWidget); <del> return { inputWidget, elementDisposables: templateDisposable.add(new DisposableStore()), templateDisposable }; </del> <ins> return { inputWidget, elementDisposables: new DisposableStore(), templateDisposable }; </ins> } renderElement(node: ITreeNode<ISCMInput, FuzzyScore>, index: number, templateData: InputTemplate): void {", "commid": "vscode_pr_182477"}], "negative_passages": []}
{"query_id": "q-en-vscode-09a72e874684dad8cc5dd31490588928394c8a10a2c906033055e8faea3d1361", "query": "Type a multiline commit message Scroll away Scroll back When the row gets rerendered (I assume) it is sized to one line. If I type a newline in this box, the size gets fixed !\nPossibly a regression introduced with", "positive_passages": [{"docid": "doc-en-vscode-9f2abb109954f88e60c6af70f87cb39d88a260ad76a4bf1a9f72333ed477f916", "text": "// Remember widget this.inputWidgets.set(input, templateData.inputWidget); <del> templateData.elementDisposables.add({ dispose: () => this.inputWidgets.delete(input) }); </del> <ins> templateData.elementDisposables.add({ dispose: () => { this.inputWidgets.delete(input); this.contentHeights.delete(input); } }); </ins> // Widget cursor selections const selections = this.editorSelections.get(input);", "commid": "vscode_pr_182477"}], "negative_passages": []}
{"query_id": "q-en-vscode-42bc6141ee42ee35ba8524ed53d2a8131a908425e5300413f67fc0e66089a761", "query": "Just saw , this goes against the design. It's meant to only add the status if it doesn't already exist, if the status changed then it should use a different id and/or remove the old status first.\nI'm not clear on the solution. There're a limited number of Terminal Status IDs: In this case status ID hasn't changed, it's still , only the description which comes with it has updated.\nworking on it, I'll send a PR to you in a bit\nValidate still doesn't happen.", "positive_passages": [{"docid": "doc-en-vscode-3c558a74c4255f2382439b55f8be6a63cd3b31710548a9d5809a8c8d7c61d25b", "text": "/** * Adds a status to the list. <ins> * @param status The status object. Ideally a single status object that does not change will be * shared as this call will no-op if the status is already set (checked by by object reference). </ins> * @param duration An optional duration in milliseconds of the status, when specified the status * will remove itself when the duration elapses unless the status gets re-added. */", "commid": "vscode_pr_182067"}], "negative_passages": []}
{"query_id": "q-en-vscode-42bc6141ee42ee35ba8524ed53d2a8131a908425e5300413f67fc0e66089a761", "query": "Just saw , this goes against the design. It's meant to only add the status if it doesn't already exist, if the status changed then it should use a different id and/or remove the old status first.\nI'm not clear on the solution. There're a limited number of Terminal Status IDs: In this case status ID hasn't changed, it's still , only the description which comes with it has updated.\nworking on it, I'll send a PR to you in a bit\nValidate still doesn't happen.", "positive_passages": [{"docid": "doc-en-vscode-c7499190d868aff2172f63ad0f0481bcb33259da4ed4d57240a5f6c4a04c3eee", "text": "const timeout = window.setTimeout(() => this.remove(status), duration); this._statusTimeouts.set(status.id, timeout); } <ins> const existingStatus = this._statuses.get(status.id); if (existingStatus && existingStatus !== status) { this._onDidRemoveStatus.fire(existingStatus); this._statuses.delete(existingStatus.id); } </ins> if (!this._statuses.has(status.id)) { const oldPrimary = this.primary; this._statuses.set(status.id, status);", "commid": "vscode_pr_182067"}], "negative_passages": []}
{"query_id": "q-en-vscode-42bc6141ee42ee35ba8524ed53d2a8131a908425e5300413f67fc0e66089a761", "query": "Just saw , this goes against the design. It's meant to only add the status if it doesn't already exist, if the status changed then it should use a different id and/or remove the old status first.\nI'm not clear on the solution. There're a limited number of Terminal Status IDs: In this case status ID hasn't changed, it's still , only the description which comes with it has updated.\nworking on it, I'll send a PR to you in a bit\nValidate still doesn't happen.", "positive_passages": [{"docid": "doc-en-vscode-17435e88ee9141f1aacf0089e72c674c233cc48254d4b6de936baa26222339f6", "text": "if (oldPrimary !== newPrimary) { this._onDidChangePrimaryStatus.fire(newPrimary); } <del> } else { this._statuses.set(status.id, status); // It maybe the case that status hasn't changed, there isn't a good way to check this based on // `ITerminalStatus`, so just fire the event anyway. this._onDidAddStatus.fire(status); </del> } }", "commid": "vscode_pr_182067"}], "negative_passages": []}
{"query_id": "q-en-vscode-42bc6141ee42ee35ba8524ed53d2a8131a908425e5300413f67fc0e66089a761", "query": "Just saw , this goes against the design. It's meant to only add the status if it doesn't already exist, if the status changed then it should use a different id and/or remove the old status first.\nI'm not clear on the solution. There're a limited number of Terminal Status IDs: In this case status ID hasn't changed, it's still , only the description which comes with it has updated.\nworking on it, I'll send a PR to you in a bit\nValidate still doesn't happen.", "positive_passages": [{"docid": "doc-en-vscode-7250e169021d1820be1226cbe175396aa5ee90e71778c8a875d26dd5abc8eee4", "text": "strictEqual(list.statuses[1].icon!.id, Codicon.zap.id, 'zap~spin should have animation removed only'); }); <ins> test('add should fire onDidRemoveStatus if same status id with a different object reference was added', () => { const eventCalls: string[] = []; list.onDidAddStatus(() => eventCalls.push('add')); list.onDidRemoveStatus(() => eventCalls.push('remove')); list.add({ id: 'test', severity: Severity.Info }); list.add({ id: 'test', severity: Severity.Info }); deepStrictEqual(eventCalls, [ 'add', 'remove', 'add' ]); }); </ins> test('remove', () => { list.add({ id: 'info', severity: Severity.Info }); list.add({ id: 'warning', severity: Severity.Warning });", "commid": "vscode_pr_182067"}], "negative_passages": []}
{"query_id": "q-en-vscode-f5e9079860545d2f297cbb711c57d914420489068b403e02fafa232be518886d", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.78.1 (system setup) Commit: Date: 2023-05-04T09:48:08.683Z Electron: 22.5.1 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: WindowsNT x64 10.0. Sandboxed: No Steps to Reproduce: a workspace at a UNC path that isn't set in security.allowedUNCHosts. \"Yes\" when prompted to temporarily allow working from that host. changes to one or more files without_ saving them. VSCode without closing the workspace (may require specific settings to automatically re-open the previous workspace). time, click the \"Learn More\" button when prompted to allow working from that host. Note that any unsaved editors remain, but the rest of the workspace is not loaded as though the user clicked the \"No\" button. I'd argue that \"Learn More\" doesn't constitute a decision from the user and shouldn't proceed as though it was. Depending on the nature of the changes, this may cause a problem for safely saving those changes because if the user tries to re-open the workspace, they are asked to either save or close these orphaned editors. Perhaps a link among the text in the dialogue box would be more appropriate than a button which closes the box.\nI agree that the dialog should not close and/or make a decision when you click \"Learn More\". Unfortunately the dialog closes when you press that button, so best I can do is to open it again asking the same question.", "positive_passages": [{"docid": "doc-en-vscode-8ba9e76512695e2b359f57c3cdd2c2b4399b25e809726f8713db9827f1345e5d", "text": "if (response === 2) { shell.openExternal('https://aka.ms/vscode-windows-unc'); <ins> return this.onUNCHostNotAllowed(path, options); // keep showing the dialog until decision (https://github.com/microsoft/vscode/issues/181956) </ins> } return undefined;", "commid": "vscode_pr_182009"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f56ca1579a3bba4a861f652757bf3656d9f7f98f4ccaa08349a3cdab7723d19", "query": "Run the command . Nothing happens Can we show the dev tools or open an output view that gets focus? From describing a user how to help us debugging an issue with storage:\nThe action also runs in browsers where we cannot open devtools automatically. We cannot use the output view because we actually show a real table: <img width=\"1394\" alt=\"image\" src=\"\"But we can inform the user via dialog.\nFor the other action \"Log working copies\" I will reveal the window log where it is logged to.", "positive_passages": [{"docid": "doc-en-vscode-d28fcf89f98ca5c078be46680f6306a2b5f01cad240f7fad2dd9281592aeba61", "text": "import { Categories } from 'vs/platform/action/common/actionCommonCategories'; import { IWorkingCopyBackupService } from 'vs/workbench/services/workingCopy/common/workingCopyBackup'; import { ResolutionResult, ResultKind } from 'vs/platform/keybinding/common/keybindingResolver'; <ins> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; import { IOutputService } from 'vs/workbench/services/output/common/output'; import { windowLogId } from 'vs/workbench/services/log/common/logConstants'; </ins> class InspectContextKeysAction extends Action2 {", "commid": "vscode_pr_182711"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f56ca1579a3bba4a861f652757bf3656d9f7f98f4ccaa08349a3cdab7723d19", "query": "Run the command . Nothing happens Can we show the dev tools or open an output view that gets focus? From describing a user how to help us debugging an issue with storage:\nThe action also runs in browsers where we cannot open devtools automatically. We cannot use the output view because we actually show a real table: <img width=\"1394\" alt=\"image\" src=\"\"But we can inform the user via dialog.\nFor the other action \"Log working copies\" I will reveal the window log where it is logged to.", "positive_passages": [{"docid": "doc-en-vscode-b64d867e054a980b3d234ac75fb0de2b0376e05836ac03b83433d98a7ea4bdf6", "text": "} run(accessor: ServicesAccessor): void { <del> accessor.get(IStorageService).log(); </del> <ins> const storageService = accessor.get(IStorageService); const dialogService = accessor.get(IDialogService); storageService.log(); dialogService.info(localize('storageLogDialogMessage', \"The storage database contents have been logged to the developer tools.\"), localize('storageLogDialogDetails', \"Open developer tools from the menu and select the Console tab.\")); </ins> } }", "commid": "vscode_pr_182711"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f56ca1579a3bba4a861f652757bf3656d9f7f98f4ccaa08349a3cdab7723d19", "query": "Run the command . Nothing happens Can we show the dev tools or open an output view that gets focus? From describing a user how to help us debugging an issue with storage:\nThe action also runs in browsers where we cannot open devtools automatically. We cannot use the output view because we actually show a real table: <img width=\"1394\" alt=\"image\" src=\"\"But we can inform the user via dialog.\nFor the other action \"Log working copies\" I will reveal the window log where it is logged to.", "positive_passages": [{"docid": "doc-en-vscode-59569725db512f96f2d790481e914e5fbff62d2cae62f646687fdfd3bd546639", "text": "const workingCopyService = accessor.get(IWorkingCopyService); const workingCopyBackupService = accessor.get(IWorkingCopyBackupService); const logService = accessor.get(ILogService); <ins> const outputService = accessor.get(IOutputService); </ins> const backups = await workingCopyBackupService.getBackups();", "commid": "vscode_pr_182711"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f56ca1579a3bba4a861f652757bf3656d9f7f98f4ccaa08349a3cdab7723d19", "query": "Run the command . Nothing happens Can we show the dev tools or open an output view that gets focus? From describing a user how to help us debugging an issue with storage:\nThe action also runs in browsers where we cannot open devtools automatically. We cannot use the output view because we actually show a real table: <img width=\"1394\" alt=\"image\" src=\"\"But we can inform the user via dialog.\nFor the other action \"Log working copies\" I will reveal the window log where it is logged to.", "positive_passages": [{"docid": "doc-en-vscode-71e30c3dbd054bcaa5b51d64d5d71d4903ff794c6f9ce8472151c4ed76116eaf", "text": "]; logService.info(msg.join('n')); <ins> outputService.showChannel(windowLogId, true); </ins> } }", "commid": "vscode_pr_182711"}], "negative_passages": []}
{"query_id": "q-en-vscode-b357c1cf982282ba4c9b9b2862b6dabd72092f9e0dd2c394e3ba892be0768d79", "query": "Type: <bFeature Request</bDepending on the extension we are using, when code suggestion information appears, it is not read by screen readers. Steps to reproduce. Install the codeium extension. Open any project, and start typing or commenting the code; You will hear a sound when a hint appears, but this hint is not read by screen readers like nvda. I suggest that it is possible to activate a configuration in vscode, so that this type of information can be transmitted to screen readers. VS Code version: Code - Insiders 1.79.0-insider (, 2023-05-20T01:18:53.811Z) OS version: Windows_NT x64 10.0. Modes: Remote OS version: Linux x64 5.15.90.1-microsoft-standard-WSL2 <!-- generated by issue reporter --\nI can reproduce. We must not be getting the line content here\nI would like to inform you that I also tested it with the copilot and when listening to the sound that a suggestion was given, the screen readers also do not read.\nYou need to set to and it will work for copilot\ndo you think we should now set that to by default?\nNice defined it and it actually worked for the copilot. My suggestion is that it would not be possible for these settings to go to the accessibility feature? I know that it makes sense to stay where they are because it has to do with the editor, but they are difficult to find, or maybe we have some dock where all the accessibility features are and their respective paths where they should be activated, you get the idea.\nYes, we actually have help menus now for the copilot chat view / interactive editor session. When you focus those inputs, using reveals/focuses the help menu for each. I think for this case, we should enable inline suggestion by default\nSorry, just found out that by enabling the setting, it also worked for codeium. Should I then close this issue?\nI think we should enable this by default, so will use this issue to track that\nI agree with the idea setting the inline suggestion announcement to TRUE by default as it is now stable.\nVerified the setting default is flipped", "positive_passages": [{"docid": "doc-en-vscode-f27fb48b975ceb9dd0759ddcbcd0ee03fdc89518901ea5338584d9859a24df6a", "text": "EditorOption.ariaLabel, 'ariaLabel', nls.localize('editorViewAccessibleLabel', \"Editor content\") )), screenReaderAnnounceInlineSuggestion: register(new EditorBooleanOption( <del> EditorOption.screenReaderAnnounceInlineSuggestion, 'screenReaderAnnounceInlineSuggestion', false, </del> <ins> EditorOption.screenReaderAnnounceInlineSuggestion, 'screenReaderAnnounceInlineSuggestion', true, </ins> { description: nls.localize('screenReaderAnnounceInlineSuggestion', \"Control whether inline suggestions are announced by a screen reader.\"), tags: ['accessibility']", "commid": "vscode_pr_183965"}], "negative_passages": []}
{"query_id": "q-en-vscode-2645e96ffbffa25f484dbbd387b3977b7e4b5bf654e19a27cf22efebba5bea1e", "query": "Type: <bBug</bOpen terminal Use Terminal Copy Selecton as HTML command () after selecting text in terminal Expected: Selected text in the terminal is copied as html, so formatting (such as color) is kept. I am then able to paste this text elsewhere, outside of VS Code. Actual: [object event] notifcation] & text isn't copied to clipboard at all, clipboard contents remain unchanged VS Code version: Code 1.78.2 (, 2023-05-10T14:39:26.248Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ npm-intellisense1.4.4 vscode-eslint2.4.0 vscode-npm-script0.3.29 prettier-vscode9.12.0 npm1.3.0 vscode-ansi1.1.6 python2023.8.0 vscode-pylance2023.5.30 jupyter2023.4. jupyter-keymap1.1.0 jupyter-renderers1.0.15 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 vscode-react-native1.11.0 vscode-react-native-preview2023.5.821 es7-react-js-snippets1.9.3 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nThis was working at some pt, not sure why it doesn't anymore\nCan reproduce: ! It's also a little weird having in the precondition as that makes it never show up in the command palette (I'm guessing that's set to false when the terminal is blurred?)\nSomething's wrong with getting the serialize addon: !", "positive_passages": [{"docid": "doc-en-vscode-218929e60f9861f65451950ce872126db14715dbd94d6a1e1bdc664b030ab4a7", "text": "'xterm-addon-canvas': `${baseNodeModulesPath}/xterm-addon-canvas/lib/xterm-addon-canvas.js`, 'xterm-addon-image': `${baseNodeModulesPath}/xterm-addon-image/lib/xterm-addon-image.js`, 'xterm-addon-search': `${baseNodeModulesPath}/xterm-addon-search/lib/xterm-addon-search.js`, <ins> 'xterm-addon-serialize': `${baseNodeModulesPath}/xterm-addon-serialize/lib/xterm-addon-serialize.js`, </ins> 'xterm-addon-unicode11': `${baseNodeModulesPath}/xterm-addon-unicode11/lib/xterm-addon-unicode11.js`, 'xterm-addon-webgl': `${baseNodeModulesPath}/xterm-addon-webgl/lib/xterm-addon-webgl.js`, '@vscode/iconv-lite-umd': `${baseNodeModulesPath}/@vscode/iconv-lite-umd/lib/iconv-lite-umd.js`,", "commid": "vscode_pr_183351"}], "negative_passages": []}
{"query_id": "q-en-vscode-5a778359675011b9bbacc0d6bcfddb9fb2749ad85f6fe3afbec1768b2af1a7a0", "query": "Testing I might be doing something wrong, my contribution: I see no status entry that I can click on. I also tried with an existing command such as . ! Extension code is a hello world: Full :\nnot implemented", "positive_passages": [{"docid": "doc-en-vscode-5c9aebbe602fa2496232a2c0ff29e53b5e056e4ad7dcfb1085571baab4d1d1dd", "text": "entryId, name: item.entry.name, text: item.entry.text, <del> command: typeof item.entry.command === 'string' ? item.entry.command : undefined, </del> <ins> command: typeof item.entry.command === 'string' ? item.entry.command : typeof item.entry.command === 'object' ? item.entry.command.id : undefined, </ins> priority: item.priority, alignLeft: item.alignment === StatusbarAlignment.LEFT };", "commid": "vscode_pr_183914"}], "negative_passages": []}
{"query_id": "q-en-vscode-5a778359675011b9bbacc0d6bcfddb9fb2749ad85f6fe3afbec1768b2af1a7a0", "query": "Testing I might be doing something wrong, my contribution: I see no status entry that I can click on. I also tried with an existing command such as . ! Extension code is a hello world: Full :\nnot implemented", "positive_passages": [{"docid": "doc-en-vscode-ae2484f3fefb68c8f492b0b8a5a8eb8aa1fd8c2ee6c044f1feaca33514ccf46f", "text": "ExtensionIdentifier.toKey(entry.description.identifier), candidate.name ?? entry.description.displayName ?? entry.description.name, candidate.text, <del> undefined, undefined, undefined, undefined, </del> <ins> undefined, candidate.command ? { id: candidate.command, title: candidate.name } : undefined, undefined, undefined, </ins> candidate.alignment === 'left', candidate.priority, undefined", "commid": "vscode_pr_183914"}], "negative_passages": []}
{"query_id": "q-en-vscode-275dc3fc73a4554b5b6346060c5956ddf5165b70d2279a8a5017eef7bf1b3236", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No. Related to extension api <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Macintosh; Intel Mac OS X 1340 Getting a session for a Microsoft account for the default tenant, and also getting a session for the account but for a specific tenant results in two items for the same account appearing in the Accounts menu. <img width=\"546\" alt=\"image\" src=\"\"Steps to Reproduce: First call with the following scopes: . And another call to with these scopes: I want to point out that the account objects on the returned sessions are actually different: <br<details<summaryMicrosoft Authentication provider logs</summary<p</p</detailscc:\nThese accounts aren't duplicate, they are sessions that exist for each signed-in tenant. I think the best solution would be to change the account label to . This would match what the Azure portal does. <img width=\"201\" alt=\"image\" src=\"\"I think this is an important change to make because this really doesn't look good and is confusing to users. Especially when users are trying to sign out. The screenshot below is after I sign in with a single Microsoft account that has 4 tenants. Having 4 tenants is not uncommon. <img width=\"515\" alt=\"image\" src=\"\"\nYeah this goes back to that \"technically they're different accounts because they're in different tenants\" thing. I'm inclined to agree with you and dedupe per-label.\nAlthough that would present better, I think deduping on the label wouldn't be great unless you made the label more standard across tenants. In that case, I think changing the label to be just email would be best. Then all of these sessions in my example screenshot could be grouped as one. If you deduped per-label with the current labelling it would show two accounts, one that represents 3 tenants, and another representing another single tenant. That would still be pretty confusing. IMO there's two options: Dedupe by email and hide all tenant related stuff. Signing out of that account removes all sessions associated with that email, regardless of tenant. Don't dedupe at all, instead include the tenant display name in the label as .\nsays this works!", "positive_passages": [{"docid": "doc-en-vscode-f57e004fd27a62eca19123e315abf8a0d196f1f9ffcb404e685be8ccb6548203", "text": "throw e; } <del> let label; if (claims.name && claims.email) { label = `${claims.name} - ${claims.email}`; } else { label = claims.email ?? claims.unique_name ?? claims.preferred_username ?? 'user@example.com'; } </del> const id = `${claims.tid}/${(claims.oid ?? (claims.altsecid ?? '' + claims.ipd ?? ''))}`; const sessionId = existingId || `${id}/${randomUUID()}`; this._logger.trace(`[${scopeData.scopeStr}] '${sessionId}' Token response parsed successfully.`);", "commid": "vscode_pr_193727"}], "negative_passages": []}
{"query_id": "q-en-vscode-275dc3fc73a4554b5b6346060c5956ddf5165b70d2279a8a5017eef7bf1b3236", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No. Related to extension api <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Macintosh; Intel Mac OS X 1340 Getting a session for a Microsoft account for the default tenant, and also getting a session for the account but for a specific tenant results in two items for the same account appearing in the Accounts menu. <img width=\"546\" alt=\"image\" src=\"\"Steps to Reproduce: First call with the following scopes: . And another call to with these scopes: I want to point out that the account objects on the returned sessions are actually different: <br<details<summaryMicrosoft Authentication provider logs</summary<p</p</detailscc:\nThese accounts aren't duplicate, they are sessions that exist for each signed-in tenant. I think the best solution would be to change the account label to . This would match what the Azure portal does. <img width=\"201\" alt=\"image\" src=\"\"I think this is an important change to make because this really doesn't look good and is confusing to users. Especially when users are trying to sign out. The screenshot below is after I sign in with a single Microsoft account that has 4 tenants. Having 4 tenants is not uncommon. <img width=\"515\" alt=\"image\" src=\"\"\nYeah this goes back to that \"technically they're different accounts because they're in different tenants\" thing. I'm inclined to agree with you and dedupe per-label.\nAlthough that would present better, I think deduping on the label wouldn't be great unless you made the label more standard across tenants. In that case, I think changing the label to be just email would be best. Then all of these sessions in my example screenshot could be grouped as one. If you deduped per-label with the current labelling it would show two accounts, one that represents 3 tenants, and another representing another single tenant. That would still be pretty confusing. IMO there's two options: Dedupe by email and hide all tenant related stuff. Signing out of that account removes all sessions associated with that email, regardless of tenant. Don't dedupe at all, instead include the tenant display name in the label as .\nsays this works!", "positive_passages": [{"docid": "doc-en-vscode-e1114950e43ff12ef85837341c6b61b4855a0d3ab9145b921fa563a72b5dac7f", "text": "scope: scopeData.scopeStr, sessionId, account: { <del> label, </del> <ins> label: claims.email ?? claims.preferred_username ?? claims.unique_name ?? 'user@example.com', </ins> id, type: claims.tid === MSA_TID || claims.tid === MSA_PASSTHRU_TID ? MicrosoftAccountType.MSA : MicrosoftAccountType.AAD }", "commid": "vscode_pr_193727"}], "negative_passages": []}
{"query_id": "q-en-vscode-275dc3fc73a4554b5b6346060c5956ddf5165b70d2279a8a5017eef7bf1b3236", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No. Related to extension api <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Macintosh; Intel Mac OS X 1340 Getting a session for a Microsoft account for the default tenant, and also getting a session for the account but for a specific tenant results in two items for the same account appearing in the Accounts menu. <img width=\"546\" alt=\"image\" src=\"\"Steps to Reproduce: First call with the following scopes: . And another call to with these scopes: I want to point out that the account objects on the returned sessions are actually different: <br<details<summaryMicrosoft Authentication provider logs</summary<p</p</detailscc:\nThese accounts aren't duplicate, they are sessions that exist for each signed-in tenant. I think the best solution would be to change the account label to . This would match what the Azure portal does. <img width=\"201\" alt=\"image\" src=\"\"I think this is an important change to make because this really doesn't look good and is confusing to users. Especially when users are trying to sign out. The screenshot below is after I sign in with a single Microsoft account that has 4 tenants. Having 4 tenants is not uncommon. <img width=\"515\" alt=\"image\" src=\"\"\nYeah this goes back to that \"technically they're different accounts because they're in different tenants\" thing. I'm inclined to agree with you and dedupe per-label.\nAlthough that would present better, I think deduping on the label wouldn't be great unless you made the label more standard across tenants. In that case, I think changing the label to be just email would be best. Then all of these sessions in my example screenshot could be grouped as one. If you deduped per-label with the current labelling it would show two accounts, one that represents 3 tenants, and another representing another single tenant. That would still be pretty confusing. IMO there's two options: Dedupe by email and hide all tenant related stuff. Signing out of that account removes all sessions associated with that email, regardless of tenant. Don't dedupe at all, instead include the tenant display name in the label as .\nsays this works!", "positive_passages": [{"docid": "doc-en-vscode-da33159f2d7fdb0ab8e01dfebddd69ab63ec3d32911a782294f3e07ee2b12414", "text": "if (account.canSignOut) { const signOutAction = disposables.add(new Action('signOut', localize('signOut', \"Sign Out\"), undefined, true, async () => { const allSessions = await this.authenticationService.getSessions(providerId); <del> const sessionsForAccount = allSessions.filter(s => s.account.id === account.id); </del> <ins> const sessionsForAccount = allSessions.filter(s => s.account.label === account.label); </ins> return await this.authenticationService.removeAccountSessions(providerId, account.label, sessionsForAccount); })); providerSubMenuActions.push(signOutAction);", "commid": "vscode_pr_193727"}], "negative_passages": []}
{"query_id": "q-en-vscode-275dc3fc73a4554b5b6346060c5956ddf5165b70d2279a8a5017eef7bf1b3236", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No. Related to extension api <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.0-insider OS Version: Macintosh; Intel Mac OS X 1340 Getting a session for a Microsoft account for the default tenant, and also getting a session for the account but for a specific tenant results in two items for the same account appearing in the Accounts menu. <img width=\"546\" alt=\"image\" src=\"\"Steps to Reproduce: First call with the following scopes: . And another call to with these scopes: I want to point out that the account objects on the returned sessions are actually different: <br<details<summaryMicrosoft Authentication provider logs</summary<p</p</detailscc:\nThese accounts aren't duplicate, they are sessions that exist for each signed-in tenant. I think the best solution would be to change the account label to . This would match what the Azure portal does. <img width=\"201\" alt=\"image\" src=\"\"I think this is an important change to make because this really doesn't look good and is confusing to users. Especially when users are trying to sign out. The screenshot below is after I sign in with a single Microsoft account that has 4 tenants. Having 4 tenants is not uncommon. <img width=\"515\" alt=\"image\" src=\"\"\nYeah this goes back to that \"technically they're different accounts because they're in different tenants\" thing. I'm inclined to agree with you and dedupe per-label.\nAlthough that would present better, I think deduping on the label wouldn't be great unless you made the label more standard across tenants. In that case, I think changing the label to be just email would be best. Then all of these sessions in my example screenshot could be grouped as one. If you deduped per-label with the current labelling it would show two accounts, one that represents 3 tenants, and another representing another single tenant. That would still be pretty confusing. IMO there's two options: Dedupe by email and hide all tenant related stuff. Signing out of that account removes all sessions associated with that email, regardless of tenant. Don't dedupe at all, instead include the tenant display name in the label as .\nsays this works!", "positive_passages": [{"docid": "doc-en-vscode-a77f1c8bd857b97085af1b0b96ff872fddb15f55a69660d25570ef23b4c79ac8", "text": "private async addOrUpdateAccount(providerId: string, account: AuthenticationSessionAccount): Promise<void> { let accounts = this.groupedAccounts.get(providerId); <del> if (accounts) { const existingAccount = accounts.find(a => a.id === account.id); if (existingAccount) { // Update the label if it has changed if (existingAccount.label !== account.label) { existingAccount.label = account.label; } return; } } else { </del> <ins> if (!accounts) { </ins> accounts = []; this.groupedAccounts.set(providerId, accounts); } const sessionFromEmbedder = await this.sessionFromEmbedder.value; <del> // If the session stored from the embedder allows sign out, then we can treat it and all others as sign out-able let canSignOut = !!sessionFromEmbedder?.canSignOut; if (!canSignOut) { if (sessionFromEmbedder?.id) { const sessions = (await this.authenticationService.getSessions(providerId)).filter(s => s.account.id === account.id); canSignOut = !sessions.some(s => s.id === sessionFromEmbedder.id); } else { // The default if we don't have a session from the embedder is to allow sign out canSignOut = true; } </del> <ins> let canSignOut = true; if ( sessionFromEmbedder\t\t\t\t\t\t\t\t\t\t\t\t// if we have a session from the embedder && !sessionFromEmbedder.canSignOut\t\t\t\t\t\t\t\t// and that session says we can't sign out && (await this.authenticationService.getSessions(providerId))\t// and that session is associated with the account we are adding/updating .some(s => s.id === sessionFromEmbedder.id && s.account.id === account.id ) ) { canSignOut = false; </ins> } <del> accounts.push({ ...account, canSignOut }); </del> <ins> const existingAccount = accounts.find(a => a.label === account.label); if (existingAccount) { // if we have an existing account and we discover that we // can't sign out of it, update the account to mark it as \"can't sign out\" if (!canSignOut) { existingAccount.canSignOut = canSignOut; } } else { accounts.push({ ...account, canSignOut }); } </ins> } private removeAccount(providerId: string, account: AuthenticationSessionAccount): void {", "commid": "vscode_pr_193727"}], "negative_passages": []}
{"query_id": "q-en-vscode-80b2a0669bd1806a7decaccff7b567d78f32ce753864545435eac49e64b8d909", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --", "positive_passages": [{"docid": "doc-en-vscode-9120e7133451b2006ff58dacf2cd08d7f9a3fd3126d01add961f82e9a505f8e6", "text": "\"ts-loader\": \"^9.4.2\", \"ts-node\": \"^10.9.1\", \"tsec\": \"0.1.4\", <del> \"typescript\": \"^5.2.0-dev.20230524\", </del> <ins> \"typescript\": \"^5.2.0-dev.20230602\", </ins> \"typescript-formatter\": \"7.1.0\", \"underscore\": \"^1.12.1\", \"util\": \"^0.12.4\",", "commid": "vscode_pr_184216"}], "negative_passages": []}
{"query_id": "q-en-vscode-80b2a0669bd1806a7decaccff7b567d78f32ce753864545435eac49e64b8d909", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --", "positive_passages": [{"docid": "doc-en-vscode-cc1f0c6af42de75b918cf39e267f173717bde57d893c34db333493667cce29d3", "text": "resolved \"https://registry.yarnpkg.com/typescript/-/typescript-4.8.4.tgz#c464abca159669597be5f96b8943500b238e60e6\" integrity sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ== <del> typescript@^5.2.0-dev.20230524: version \"5.2.0-dev.20230524\" resolved \"https://registry.yarnpkg.com/typescript/-/typescript-5.2.0-dev.20230524.tgz#c2714b82f5ef8c63328a253692ae0b8c244c86d6\" integrity sha512-1XzSUJCt31jm7jIZ3vBKzK46ZxnmqX2VdVg/dur9AIaz9WmidrABs7F8H8d4onpIV8RYD/L6xW6MXR5EHjl+LA== </del> <ins> typescript@^5.2.0-dev.20230602: version \"5.2.0-dev.20230602\" resolved \"https://registry.yarnpkg.com/typescript/-/typescript-5.2.0-dev.20230602.tgz#01e2055aa8d8bde4431947c0c048c07c23cc6027\" integrity sha512-LenKdxmkwzZRmEKzShAq83TvEuvCGR8pCYBe0VpUTuJ7NMSK4r2yV2GTmJrSqtk8IoJAmc+PfymMQIfwX1JGQQ== </ins> typical@^4.0.0: version \"4.0.0\"", "commid": "vscode_pr_184216"}], "negative_passages": []}
{"query_id": "q-en-vscode-80b2a0669bd1806a7decaccff7b567d78f32ce753864545435eac49e64b8d909", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --", "positive_passages": [{"docid": "doc-en-vscode-5590250057f5b7adc63fef81e7ef26de565ad6729694f81777993c1587dd0384", "text": "})); } <ins> stopWebviewFind() { this._notebookEditor.findStop(); } </ins> override dispose() { this.clearDecorations(); super.dispose();", "commid": "vscode_pr_184219"}], "negative_passages": []}
{"query_id": "q-en-vscode-80b2a0669bd1806a7decaccff7b567d78f32ce753864545435eac49e64b8d909", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --", "positive_passages": [{"docid": "doc-en-vscode-94685dd68e49b769dac6f32bd7983e24521f468e876112443f7ea5f0c141101f", "text": "this._notebookUpdateScheduler.schedule(); }) ?? null; <ins> this._findMatchDecorationModel?.stopWebviewFind(); </ins> this._findMatchDecorationModel?.dispose(); this._findMatchDecorationModel = new FindMatchDecorationModel(this._notebookEditorWidget); }", "commid": "vscode_pr_184219"}], "negative_passages": []}
{"query_id": "q-en-vscode-80b2a0669bd1806a7decaccff7b567d78f32ce753864545435eac49e64b8d909", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --", "positive_passages": [{"docid": "doc-en-vscode-f4adf5e431fd8d8e89f5696b68c7a19a4bbca6838dc3b27501bb848cf9c1aa8a", "text": "} if (this._findMatchDecorationModel) { <ins> this._findMatchDecorationModel?.stopWebviewFind(); </ins> this._findMatchDecorationModel?.dispose(); this._findMatchDecorationModel = undefined; }", "commid": "vscode_pr_184219"}], "negative_passages": []}
{"query_id": "q-en-vscode-80b2a0669bd1806a7decaccff7b567d78f32ce753864545435eac49e64b8d909", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --", "positive_passages": [{"docid": "doc-en-vscode-dcb125d3a0714bfc15dafd14114a7291015a0cf62943c4249d2865a3bfd8a1dd", "text": "get title(): string { const firstRequestMessage = this._requests[0]?.message; <del> if (typeof firstRequestMessage === 'string') { return firstRequestMessage; } else if (firstRequestMessage) { return firstRequestMessage.message; } else { return ''; } </del> <ins> const message = typeof firstRequestMessage === 'string' ? firstRequestMessage : firstRequestMessage?.message ?? ''; return message.split('n')[0].substring(0, 50); </ins> } constructor(", "commid": "vscode_pr_184377"}], "negative_passages": []}
{"query_id": "q-en-vscode-bb14521cc7280bf65fceafefc8af4c6ed19b818f0a71d8ed25da5b623979b81d", "query": "Type: <bBug</bIn previous VS Code version 1.78 when I pressed if inline suggest was visible with suggest widget it hides only inline suggest, if I press again same shortcut it then hides suggest widget. Now with 1.79 it hides both inline suggest and suggest widget. KeybindingService logs: My custom shortcuts to hide inline suggest & suggest widget: I even tried to add to clause and still it hides both. VS Code version: Code 1.79.0 (, 2023-06-07T14:31:03.317Z) OS version: Darwin arm64 22.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ vscode-eslint2.4.0 gitlens13.6.0 prettier-vscode9.13.0 copilot1.88.132 vscode-graphql0.8.13 vscode-graphql-syntax1.2.0 symbols0.0.11 vscode-react-native1.11.0 vscode-thunder-client2.7.6 vscode-fileutils3.10.1 vim1.25.2 quokka-vscode1.0.543 (1 theme extensions excluded) </details<!-- generated by issue reporter --\nfull text search doesn't reveal the context key anymore. Has that been removed/renamed?\nIt is\nsorry I was writing that instead of copy-pasting. Already updated the issue.\nDoes it work when you swap the keybinding configurations? (Like literally exchange the positions in the file)\nStill the same issue even if I swap places :(\nSo, its either the or context key. Can you investigate with the F1 Inspect Context Key Tools to see if those context keys are set. Note that it will print context keys on the console of DevTools\n<details<summaryContext keys</summary</details\nas you can see is and is , but even though inline suggest was visible it returned false.\nSame in the monaco, if the suggest widget is visible, the inlineSuggestWidgetVisible will always be false no matter there is any ghost text or not\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nNow I see us hiding the suggest widget first and the inline suggest second, is that expected? This is true regardless of what order I declare the keybindings in (I do have the Vim extension installed)\nIt should hide first inline suggestions and second time you press it, it should hide suggest widget. Try to swap places of keybindings to see if it fixes it (order maybe matters?). Because previously this is how it worked (in 1.78, but regression was introduced in 1.79). EDIT: Oh I see you mentioned that order doesn't matter. Try to add in clause for command (I hope it works).\nis it fixed for you on the latest insider builds The following does not work for me either\nIt works! !\nGreat, thanks for confirming!", "positive_passages": [{"docid": "doc-en-vscode-7464e1578b0b6a0d328fb749304d3ca5f0dc9c6d1c61db7bd27322d718e283f0", "text": "const model = this.model.read(reader); const suggestion = model?.selectedInlineCompletion.read(reader); const ghostText = model?.ghostText.read(reader); <del> const selectedSuggestItem = model?.selectedSuggestItem.read(reader); this.inlineCompletionVisible.set(selectedSuggestItem === undefined && ghostText !== undefined && !ghostText.isEmpty()); </del> <ins> this.inlineCompletionVisible.set(ghostText !== undefined && !ghostText.isEmpty()); </ins> if (ghostText && suggestion) { this.suppressSuggestions.set(suggestion.inlineCompletion.source.inlineCompletions.suppressSuggestions);", "commid": "vscode_pr_187306"}], "negative_passages": []}
{"query_id": "q-en-vscode-7787d36d058aed318bd0d8155ac5956aa8980409962c550377bc13f97baf3fb7", "query": "Steps to Reproduce: Copilot Chat the file in VS Code +i It takes like 2s for the UI to show up. One time when I was doing a lot with VS Code it took so long (like 10s) that I thought I didn't have the extension installed. Not sure if this is on the UI side or the extension side, but even still, I think the UI should be instant (even if it's perceived fastness) since all I'm seeing is an input box that I will type in.\nI have done a bunch of tricks, most importantly to showing the UI while asking the extension to create a session. Also the UI is more lazily created which helps. However, once there are changes the bottleneck is setting up the embedded diff editor. There isn't much I can do about it <img width=\"726\" alt=\"Screenshot 2023-06-15 at 16 10 35\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-294e5aa0e8e7ddaecb30bce7b4662b41da173a940be3ca2b060d2cf90c5ce42c", "text": "*--------------------------------------------------------------------------------------------*/ import { Event } from 'vs/base/common/event'; <ins> import { Lazy } from 'vs/base/common/lazy'; </ins> import { IDisposable } from 'vs/base/common/lifecycle'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { IBulkEditService } from 'vs/editor/browser/services/bulkEditService';", "commid": "vscode_pr_185041"}], "negative_passages": []}
{"query_id": "q-en-vscode-7787d36d058aed318bd0d8155ac5956aa8980409962c550377bc13f97baf3fb7", "query": "Steps to Reproduce: Copilot Chat the file in VS Code +i It takes like 2s for the UI to show up. One time when I was doing a lot with VS Code it took so long (like 10s) that I thought I didn't have the extension installed. Not sure if this is on the UI side or the extension side, but even still, I think the UI should be instant (even if it's perceived fastness) since all I'm seeing is an input box that I will type in.\nI have done a bunch of tricks, most importantly to showing the UI while asking the extension to create a session. Also the UI is more lazily created which helps. However, once there are changes the bottleneck is setting up the embedded diff editor. There isn't much I can do about it <img width=\"726\" alt=\"Screenshot 2023-06-15 at 16 10 35\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-f2c0b2c5bc13426904a3664c7d248e855da7e115e13854deb84e385586cc0475", "text": "export class LivePreviewStrategy extends LiveStrategy { <del> private readonly _diffZone: InlineChatLivePreviewWidget; private readonly _previewZone: InlineChatFileCreatePreviewWidget; </del> <ins> private readonly _diffZone: Lazy<InlineChatLivePreviewWidget>; private readonly _previewZone: Lazy<InlineChatFileCreatePreviewWidget>; </ins> constructor( session: Session,", "commid": "vscode_pr_185041"}], "negative_passages": []}
{"query_id": "q-en-vscode-7787d36d058aed318bd0d8155ac5956aa8980409962c550377bc13f97baf3fb7", "query": "Steps to Reproduce: Copilot Chat the file in VS Code +i It takes like 2s for the UI to show up. One time when I was doing a lot with VS Code it took so long (like 10s) that I thought I didn't have the extension installed. Not sure if this is on the UI side or the extension side, but even still, I think the UI should be instant (even if it's perceived fastness) since all I'm seeing is an input box that I will type in.\nI have done a bunch of tricks, most importantly to showing the UI while asking the extension to create a session. Also the UI is more lazily created which helps. However, once there are changes the bottleneck is setting up the embedded diff editor. There isn't much I can do about it <img width=\"726\" alt=\"Screenshot 2023-06-15 at 16 10 35\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-0f25af9419e2e74ae95b890dbe8d72a4e60e4c8ca877314fa4fb29e252f66e4c", "text": ") { super(session, editor, widget, contextKeyService, storageService, bulkEditService, editorWorkerService, instaService); <del> this._diffZone = instaService.createInstance(InlineChatLivePreviewWidget, editor, session); this._previewZone = instaService.createInstance(InlineChatFileCreatePreviewWidget, editor); </del> <ins> this._diffZone = new Lazy(() => instaService.createInstance(InlineChatLivePreviewWidget, editor, session)); this._previewZone = new Lazy(() => instaService.createInstance(InlineChatFileCreatePreviewWidget, editor)); </ins> } override dispose(): void { <del> this._diffZone.hide(); this._diffZone.dispose(); this._previewZone.hide(); this._previewZone.dispose(); </del> <ins> this._diffZone.rawValue?.hide(); this._diffZone.rawValue?.dispose(); this._previewZone.rawValue?.hide(); this._previewZone.rawValue?.dispose(); </ins> super.dispose(); }", "commid": "vscode_pr_185041"}], "negative_passages": []}
{"query_id": "q-en-vscode-7787d36d058aed318bd0d8155ac5956aa8980409962c550377bc13f97baf3fb7", "query": "Steps to Reproduce: Copilot Chat the file in VS Code +i It takes like 2s for the UI to show up. One time when I was doing a lot with VS Code it took so long (like 10s) that I thought I didn't have the extension installed. Not sure if this is on the UI side or the extension side, but even still, I think the UI should be instant (even if it's perceived fastness) since all I'm seeing is an input box that I will type in.\nI have done a bunch of tricks, most importantly to showing the UI while asking the extension to create a session. Also the UI is more lazily created which helps. However, once there are changes the bottleneck is setting up the embedded diff editor. There isn't much I can do about it <img width=\"726\" alt=\"Screenshot 2023-06-15 at 16 10 35\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-78e9539dfa204f51106172131aad874f52674232a0e605b14990898df774f07a", "text": "this._updateSummaryMessage(); if (this._diffEnabled) { <del> this._diffZone.show(); </del> <ins> this._diffZone.value.show(); </ins> } if (response.singleCreateFileEdit) { <del> this._previewZone.showCreation(this._session.wholeRange.value, response.singleCreateFileEdit.uri, await Promise.all(response.singleCreateFileEdit.edits)); </del> <ins> this._previewZone.value.showCreation(this._session.wholeRange.value, response.singleCreateFileEdit.uri, await Promise.all(response.singleCreateFileEdit.edits)); </ins> } else { <del> this._previewZone.hide(); </del> <ins> this._previewZone.value.hide(); </ins> } } override async undoChanges(response: EditResponse): Promise<void> { <del> this._diffZone.lockToDiff(); </del> <ins> this._diffZone.value.lockToDiff(); </ins> super.undoChanges(response); } protected override _doToggleDiff(): void { const scrollState = StableEditorScrollState.capture(this._editor); if (this._diffEnabled) { <del> this._diffZone.show(); </del> <ins> this._diffZone.value.show(); </ins> } else { <del> this._diffZone.hide(); </del> <ins> this._diffZone.value.hide(); </ins> } scrollState.restore(this._editor); } override hasFocus(): boolean { <del> return super.hasFocus() || this._diffZone.hasFocus() || this._previewZone.hasFocus(); </del> <ins> return super.hasFocus() || this._diffZone.value.hasFocus() || this._previewZone.value.hasFocus(); </ins> } }", "commid": "vscode_pr_185041"}], "negative_passages": []}
{"query_id": "q-en-vscode-3a0747fc036365f55261de533b65b35ee433c52a76c702b38a5f73491e51707c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes, actually this issue has nothing to do with extensions <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.79.1 (user setup) Commit: Date: 2023-06-12T16:14:05.102Z Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: Connect to WSL(Ubuntu ) Profiles =Show Contents... <img width=\"286\" alt=\"image\" src=\"\"As you can see, the extensions of the profile are duplicated. The reason I found is I installed the extensions in WSL again. Maybe It's not a bug. But, the profile should distinguish between extensions installed in the host and WSL. Maybe like this: ESLint - host Disabled ESLint - WSL So that I know which place I install the extension and its enabled/disabled status. When I open the detail page of the duplicated extensions, both of them display an \"Extension is enabled on 'WSL: Ubuntu-22.04'\" message. What I expect is: The extension is installed and enabled on the host, the message should be \"Extension is enabled\". The extension is installed and enabled on the WSL, the message should be \"Extension is enabled on 'WSL: Ubuntu-22.04'\". Does it make sense?\nRelated on Stack Overflow: . Let me know if there's any debugging steps or details you'd like be to solicit from people in my answer there.\n/duplicate\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nwhat's it a duplicate of?\nI am sorry, I remembered this bug and thought there is an issue already, but there is not. Reopened it.\nI guess duplicate only shows for extensions installed in both local VS Code and remote hosts. !\nFixed: Contents show only one instance of the extension", "positive_passages": [{"docid": "doc-en-vscode-f5a6558e251edbaea4efde306a8dc03cb890a7424926ef025a1db92973a9bffa", "text": "async getLocalExtensions(profile: IUserDataProfile): Promise<IProfileExtension[]> { return this.withProfileScopedServices(profile, async (extensionEnablementService) => { <del> const result: Array<IProfileExtension & { displayName?: string }> = []; </del> <ins> const result = new Map<string, IProfileExtension & { displayName?: string }>(); </ins> const installedExtensions = await this.extensionManagementService.getInstalled(undefined, profile.extensionsResource); const disabledExtensions = extensionEnablementService.getDisabledExtensions(); for (const extension of installedExtensions) {", "commid": "vscode_pr_212668"}], "negative_passages": []}
{"query_id": "q-en-vscode-3a0747fc036365f55261de533b65b35ee433c52a76c702b38a5f73491e51707c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes, actually this issue has nothing to do with extensions <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.79.1 (user setup) Commit: Date: 2023-06-12T16:14:05.102Z Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: Connect to WSL(Ubuntu ) Profiles =Show Contents... <img width=\"286\" alt=\"image\" src=\"\"As you can see, the extensions of the profile are duplicated. The reason I found is I installed the extensions in WSL again. Maybe It's not a bug. But, the profile should distinguish between extensions installed in the host and WSL. Maybe like this: ESLint - host Disabled ESLint - WSL So that I know which place I install the extension and its enabled/disabled status. When I open the detail page of the duplicated extensions, both of them display an \"Extension is enabled on 'WSL: Ubuntu-22.04'\" message. What I expect is: The extension is installed and enabled on the host, the message should be \"Extension is enabled\". The extension is installed and enabled on the WSL, the message should be \"Extension is enabled on 'WSL: Ubuntu-22.04'\". Does it make sense?\nRelated on Stack Overflow: . Let me know if there's any debugging steps or details you'd like be to solicit from people in my answer there.\n/duplicate\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nwhat's it a duplicate of?\nI am sorry, I remembered this bug and thought there is an issue already, but there is not. Reopened it.\nI guess duplicate only shows for extensions installed in both local VS Code and remote hosts. !\nFixed: Contents show only one instance of the extension", "positive_passages": [{"docid": "doc-en-vscode-6bdf54251a78089e0349f21545f976048f921cd3b71e23d7c552ad151acaf8b1", "text": "continue; } } <ins> const existing = result.get(identifier.id.toLowerCase()); if (existing?.disabled) { // Remove the duplicate disabled extension result.delete(identifier.id.toLowerCase()); } </ins> const profileExtension: IProfileExtension = { identifier, displayName: extension.manifest.displayName }; if (disabled) { profileExtension.disabled = true;", "commid": "vscode_pr_212668"}], "negative_passages": []}
{"query_id": "q-en-vscode-3a0747fc036365f55261de533b65b35ee433c52a76c702b38a5f73491e51707c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes, actually this issue has nothing to do with extensions <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.79.1 (user setup) Commit: Date: 2023-06-12T16:14:05.102Z Electron: 22.5.7 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: Connect to WSL(Ubuntu ) Profiles =Show Contents... <img width=\"286\" alt=\"image\" src=\"\"As you can see, the extensions of the profile are duplicated. The reason I found is I installed the extensions in WSL again. Maybe It's not a bug. But, the profile should distinguish between extensions installed in the host and WSL. Maybe like this: ESLint - host Disabled ESLint - WSL So that I know which place I install the extension and its enabled/disabled status. When I open the detail page of the duplicated extensions, both of them display an \"Extension is enabled on 'WSL: Ubuntu-22.04'\" message. What I expect is: The extension is installed and enabled on the host, the message should be \"Extension is enabled\". The extension is installed and enabled on the WSL, the message should be \"Extension is enabled on 'WSL: Ubuntu-22.04'\". Does it make sense?\nRelated on Stack Overflow: . Let me know if there's any debugging steps or details you'd like be to solicit from people in my answer there.\n/duplicate\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nwhat's it a duplicate of?\nI am sorry, I remembered this bug and thought there is an issue already, but there is not. Reopened it.\nI guess duplicate only shows for extensions installed in both local VS Code and remote hosts. !\nFixed: Contents show only one instance of the extension", "positive_passages": [{"docid": "doc-en-vscode-35f648d14d4ef0dc06bb38e5012ef9ac5390796c0b2d6d7e8ec7a958bbcea327", "text": "if (!profileExtension.version && preRelease) { profileExtension.preRelease = true; } <del> result.push(profileExtension); </del> <ins> result.set(profileExtension.identifier.id.toLowerCase(), profileExtension); </ins> } <del> return result; </del> <ins> return [...result.values()]; </ins> }); }", "commid": "vscode_pr_212668"}], "negative_passages": []}
{"query_id": "q-en-vscode-e3719f72d237b4a4422394b52588f731696eecef6944c94a5ee81dd8f580e7ea", "query": "Add the possibility to persist the content hover sizes\nTo test, please read the following. Currently the implementation of the persistance mechanism of the content hover works as follows: The content hover has a default maximum size which is defined as follows: const defaultMaxHeight = (().height / 4, 250); const defaultMaxWidth = (().width 0.66, 500); Whenever the content hover is resized, the last hover dimensions are stored. Next time the content hover is shown, the maximum dimensions are updated as follows: const currentMaxHeight = (().height / 4, 250, lastHeight); const currentMaxWidth = (().width 0.66, 500, lastWidth); The content hover is rendered naturally within these constraints. If the lastHeight and lastWidth are smaller than the default max dimensions, then the current max dimensions are unchanged. Therefore the next rendering of the content hover will be the same as the initial rendering. Test that the content hover works according to these constraints. There is some discussion going on about how to better implement a persistance mechanism. We could also persist the size for example on a per-token basis in the editor. Let me know what you think is best!\nDo you have an example of how it should work? Regardless of how I resize it, it is not remembered.\nYou may see an example of how it works here. The content hover is resized to a bigger size in the gif. The current max width is increased to a higher value and at the next rendering of the content hover, the widget takes on a bigger size. To see this behavior you should choose a content hover where the content does not fit in the visible widget, where there is a horizontal scrollbar. I opened an issue for persisting the content hover on a per-token basis here: as an alternative idea.", "positive_passages": [{"docid": "doc-en-vscode-686b4bdf470c4e6f1bbc984b651a0c12e126f8cd269ee012162fde49f018d45d", "text": "export class ContentHoverWidget extends ResizableContentWidget { public static ID = 'editor.contrib.resizableContentHoverWidget'; <ins> private static _lastDimensions: dom.Dimension = new dom.Dimension(0, 0); </ins> private _visibleData: ContentHoverVisibleData | undefined; private _positionPreference: ContentWidgetPositionPreference | undefined;", "commid": "vscode_pr_187557"}], "negative_passages": []}
{"query_id": "q-en-vscode-e3719f72d237b4a4422394b52588f731696eecef6944c94a5ee81dd8f580e7ea", "query": "Add the possibility to persist the content hover sizes\nTo test, please read the following. Currently the implementation of the persistance mechanism of the content hover works as follows: The content hover has a default maximum size which is defined as follows: const defaultMaxHeight = (().height / 4, 250); const defaultMaxWidth = (().width 0.66, 500); Whenever the content hover is resized, the last hover dimensions are stored. Next time the content hover is shown, the maximum dimensions are updated as follows: const currentMaxHeight = (().height / 4, 250, lastHeight); const currentMaxWidth = (().width 0.66, 500, lastWidth); The content hover is rendered naturally within these constraints. If the lastHeight and lastWidth are smaller than the default max dimensions, then the current max dimensions are unchanged. Therefore the next rendering of the content hover will be the same as the initial rendering. Test that the content hover works according to these constraints. There is some discussion going on about how to better implement a persistance mechanism. We could also persist the size for example on a per-token basis in the editor. Let me know what you think is best!\nDo you have an example of how it should work? Regardless of how I resize it, it is not remembered.\nYou may see an example of how it works here. The content hover is resized to a bigger size in the gif. The current max width is increased to a higher value and at the next rendering of the content hover, the widget takes on a bigger size. To see this behavior you should choose a content hover where the content does not fit in the visible widget, where there is a horizontal scrollbar. I opened an issue for persisting the content hover on a per-token basis here: as an alternative idea.", "positive_passages": [{"docid": "doc-en-vscode-9e40620c70868c76488a8583ddcaf9f243f5ff28ac41d863fb4c7a9fcc8b9545", "text": "} protected override _resize(size: dom.Dimension): void { <ins> ContentHoverWidget._lastDimensions = new dom.Dimension(size.width, size.height); </ins> this._setAdjustedHoverWidgetDimensions(size); this._resizableNode.layout(size.height, size.width); this._setResizableNodeMaxDimensions();", "commid": "vscode_pr_187557"}], "negative_passages": []}
{"query_id": "q-en-vscode-e3719f72d237b4a4422394b52588f731696eecef6944c94a5ee81dd8f580e7ea", "query": "Add the possibility to persist the content hover sizes\nTo test, please read the following. Currently the implementation of the persistance mechanism of the content hover works as follows: The content hover has a default maximum size which is defined as follows: const defaultMaxHeight = (().height / 4, 250); const defaultMaxWidth = (().width 0.66, 500); Whenever the content hover is resized, the last hover dimensions are stored. Next time the content hover is shown, the maximum dimensions are updated as follows: const currentMaxHeight = (().height / 4, 250, lastHeight); const currentMaxWidth = (().width 0.66, 500, lastWidth); The content hover is rendered naturally within these constraints. If the lastHeight and lastWidth are smaller than the default max dimensions, then the current max dimensions are unchanged. Therefore the next rendering of the content hover will be the same as the initial rendering. Test that the content hover works according to these constraints. There is some discussion going on about how to better implement a persistance mechanism. We could also persist the size for example on a per-token basis in the editor. Let me know what you think is best!\nDo you have an example of how it should work? Regardless of how I resize it, it is not remembered.\nYou may see an example of how it works here. The content hover is resized to a bigger size in the gif. The current max width is increased to a higher value and at the next rendering of the content hover, the widget takes on a bigger size. To see this behavior you should choose a content hover where the content does not fit in the visible widget, where there is a horizontal scrollbar. I opened an issue for persisting the content hover on a per-token basis here: as an alternative idea.", "positive_passages": [{"docid": "doc-en-vscode-9581f591e68f2d1564acc04e55da66542aee3ba81f3070d119fdca98310fd8a9", "text": "} private _layout(): void { <del> const height = Math.max(this._editor.getLayoutInfo().height / 4, 250); </del> <ins> const height = Math.max(this._editor.getLayoutInfo().height / 4, 250, ContentHoverWidget._lastDimensions.height); const width = Math.max(this._editor.getLayoutInfo().width * 0.66, 500, ContentHoverWidget._lastDimensions.width); </ins> const { fontSize, lineHeight } = this._editor.getOption(EditorOption.fontInfo); const contentsDomNode = this._hover.contentsDomNode; contentsDomNode.style.fontSize = `${fontSize}px`; contentsDomNode.style.lineHeight = `${lineHeight / fontSize}`; <del> this._setContentsDomNodeMaxDimensions(Math.max(this._editor.getLayoutInfo().width * 0.66, 500), height); </del> <ins> this._setContentsDomNodeMaxDimensions(width, height); </ins> } private _updateFont(): void {", "commid": "vscode_pr_187557"}], "negative_passages": []}
{"query_id": "q-en-vscode-e3719f72d237b4a4422394b52588f731696eecef6944c94a5ee81dd8f580e7ea", "query": "Add the possibility to persist the content hover sizes\nTo test, please read the following. Currently the implementation of the persistance mechanism of the content hover works as follows: The content hover has a default maximum size which is defined as follows: const defaultMaxHeight = (().height / 4, 250); const defaultMaxWidth = (().width 0.66, 500); Whenever the content hover is resized, the last hover dimensions are stored. Next time the content hover is shown, the maximum dimensions are updated as follows: const currentMaxHeight = (().height / 4, 250, lastHeight); const currentMaxWidth = (().width 0.66, 500, lastWidth); The content hover is rendered naturally within these constraints. If the lastHeight and lastWidth are smaller than the default max dimensions, then the current max dimensions are unchanged. Therefore the next rendering of the content hover will be the same as the initial rendering. Test that the content hover works according to these constraints. There is some discussion going on about how to better implement a persistance mechanism. We could also persist the size for example on a per-token basis in the editor. Let me know what you think is best!\nDo you have an example of how it should work? Regardless of how I resize it, it is not remembered.\nYou may see an example of how it works here. The content hover is resized to a bigger size in the gif. The current max width is increased to a higher value and at the next rendering of the content hover, the widget takes on a bigger size. To see this behavior you should choose a content hover where the content does not fit in the visible widget, where there is a horizontal scrollbar. I opened an issue for persisting the content hover on a per-token basis here: as an alternative idea.", "positive_passages": [{"docid": "doc-en-vscode-bfa77206b03bc9e0a2cf68d02f24076e83aad853581ce32cce2d2203368630c3", "text": "} private _updateContentsDomNodeMaxDimensions() { <del> const width = Math.max(this._editor.getLayoutInfo().width * 0.66, 500); const height = Math.max(this._editor.getLayoutInfo().height / 4, 250); </del> <ins> const height = Math.max(this._editor.getLayoutInfo().height / 4, 250, ContentHoverWidget._lastDimensions.height); const width = Math.max(this._editor.getLayoutInfo().width * 0.66, 500, ContentHoverWidget._lastDimensions.width); </ins> this._setContentsDomNodeMaxDimensions(width, height); }", "commid": "vscode_pr_187557"}], "negative_passages": []}
{"query_id": "q-en-vscode-728954f4d98ab1937e4b27d9df95d96321b1739eec71ddf49f5f816f1a61b82b", "query": "Testing I started the Troubleshoot issue flow and it took a long time to create my initial profile. All I had was a status bar item which took me a while to discover (I actually thought something else went wrong). I would love to see and editor / web view better guiding me through that process by: listing the steps and adding check marks when done showing me the number of bisects still necessary giving me a final report.\n<img width=\"258\" alt=\"capture\" src=\"\"\nWe should also have a UI to always stop the process (see ) for a situation where this is useful\nI now see that there is a notification for each step. This makes it better, so may be a simple thing to do is to show a notificatio with progress when the profile is created instead of a simple status bar item.\nActually, setting up the trouble shooting profile should be fast and instant.\nWas not for me :-(\nFollowing notification is shown now !", "positive_passages": [{"docid": "doc-en-vscode-247ec37c61bfac48b31f262694677dee85cd811061dec3e92653e6b470264dc5", "text": "} const originalProfile = this.userDataProfileService.currentProfile; <del> await this.userDataProfileImportExportService.createTemporaryProfile(this.userDataProfileService.currentProfile, localize('troubleshoot issue', \"Troubleshoot Issue\"), true); </del> <ins> await this.userDataProfileImportExportService.createTroubleshootProfile(); </ins> this.state = new TroubleShootState(TroubleshootStage.EXTENSIONS, originalProfile.id); await this.resume(); }", "commid": "vscode_pr_186602"}], "negative_passages": []}
{"query_id": "q-en-vscode-728954f4d98ab1937e4b27d9df95d96321b1739eec71ddf49f5f816f1a61b82b", "query": "Testing I started the Troubleshoot issue flow and it took a long time to create my initial profile. All I had was a status bar item which took me a while to discover (I actually thought something else went wrong). I would love to see and editor / web view better guiding me through that process by: listing the steps and adding check marks when done showing me the number of bisects still necessary giving me a final report.\n<img width=\"258\" alt=\"capture\" src=\"\"\nWe should also have a UI to always stop the process (see ) for a situation where this is useful\nI now see that there is a notification for each step. This makes it better, so may be a simple thing to do is to show a notificatio with progress when the profile is created instead of a simple status bar item.\nActually, setting up the trouble shooting profile should be fast and instant.\nWas not for me :-(\nFollowing notification is shown now !", "positive_passages": [{"docid": "doc-en-vscode-a19f26e71765d7620033a370980a16fca7a4d1b8dd90533bf29867fcca74aead", "text": "} } <del> async createTemporaryProfile(profile: IUserDataProfile, name: string, extensionsDisabled: boolean): Promise<void> { const userDataProfilesExportState = this.instantiationService.createInstance(UserDataProfileExportState, profile, extensionsDisabled); </del> <ins> async createTroubleshootProfile(): Promise<void> { const userDataProfilesExportState = this.instantiationService.createInstance(UserDataProfileExportState, this.userDataProfileService.currentProfile, true); </ins> try { <del> const profileTemplate = await userDataProfilesExportState.getProfileTemplate(name, undefined); await this.importAndSwitch(profileTemplate, true, true, extensionsDisabled, localize('import', \"Create Profile\")); </del> <ins> const profileTemplate = await userDataProfilesExportState.getProfileTemplate(localize('troubleshoot issue', \"Troubleshoot Issue\"), undefined); await this.progressService.withProgress({ location: ProgressLocation.Notification, delay: 1000, sticky: true, }, progress => this.importAndSwitchWithProgress(profileTemplate, true, true, true, message => progress.report({ message: localize('troubleshoot profile progress', \"Setting up Troubleshoot Profile: {0}\", message) }))); </ins> } finally { userDataProfilesExportState.dispose(); }", "commid": "vscode_pr_186602"}], "negative_passages": []}
{"query_id": "q-en-vscode-728954f4d98ab1937e4b27d9df95d96321b1739eec71ddf49f5f816f1a61b82b", "query": "Testing I started the Troubleshoot issue flow and it took a long time to create my initial profile. All I had was a status bar item which took me a while to discover (I actually thought something else went wrong). I would love to see and editor / web view better guiding me through that process by: listing the steps and adding check marks when done showing me the number of bisects still necessary giving me a final report.\n<img width=\"258\" alt=\"capture\" src=\"\"\nWe should also have a UI to always stop the process (see ) for a situation where this is useful\nI now see that there is a notification for each step. This makes it better, so may be a simple thing to do is to show a notificatio with progress when the profile is created instead of a simple status bar item.\nActually, setting up the trouble shooting profile should be fast and instant.\nWas not for me :-(\nFollowing notification is shown now !", "positive_passages": [{"docid": "doc-en-vscode-a78fe55fddde68f194ac630096be0941c50e8bd7eb3773d4306d4fbce08675bd", "text": "command: showWindowLogActionId, }, async (progress) => { progress.report({ message: localize('Importing profile', \"{0} ({1})...\", title, profileTemplate.name) }); <del> const profile = await this.getProfileToImport(profileTemplate, temporaryProfile); if (!profile) { return undefined; } </del> <ins> return this.importAndSwitchWithProgress(profileTemplate, temporaryProfile, extensions, extensionsDisabled, message => progress.report({ message: `${title} (${profileTemplate.name}): ${message}` })); }); } </ins> <del> if (profileTemplate.settings) { progress.report({ message: localize('progress settings', \"{0} ({1}): Applying Settings...\", title, profileTemplate.name) }); await this.instantiationService.createInstance(SettingsResource).apply(profileTemplate.settings, profile); } if (profileTemplate.keybindings) { progress.report({ message: localize('progress keybindings', \"{0} ({1}): Applying Keyboard Shortcuts...\", title, profileTemplate.name) }); await this.instantiationService.createInstance(KeybindingsResource).apply(profileTemplate.keybindings, profile); } if (profileTemplate.tasks) { progress.report({ message: localize('progress tasks', \"{0} ({1}): Applying Tasks...\", title, profileTemplate.name) }); await this.instantiationService.createInstance(TasksResource).apply(profileTemplate.tasks, profile); } if (profileTemplate.snippets) { progress.report({ message: localize('progress snippets', \"{0} ({1}): Applying Snippets...\", title, profileTemplate.name) }); await this.instantiationService.createInstance(SnippetsResource).apply(profileTemplate.snippets, profile); } if (profileTemplate.globalState) { progress.report({ message: localize('progress global state', \"{0} ({1}): Applying State...\", title, profileTemplate.name) }); await this.instantiationService.createInstance(GlobalStateResource).apply(profileTemplate.globalState, profile); } if (profileTemplate.extensions && extensions) { progress.report({ message: localize('progress extensions', \"{0} ({1}): Applying Extensions...\", title, profileTemplate.name) }); await this.instantiationService.createInstance(ExtensionsResource, extensionsDisabled).apply(profileTemplate.extensions, profile); } </del> <ins> private async importAndSwitchWithProgress(profileTemplate: IUserDataProfileTemplate, temporaryProfile: boolean, extensions: boolean, extensionsDisabled: boolean, progress: (message: string) => void): Promise<IUserDataProfile | undefined> { const profile = await this.getProfileToImport(profileTemplate, temporaryProfile); if (!profile) { return undefined; } </ins> <del> progress.report({ message: localize('switching profile', \"{0} ({1}): Applying...\", title, profileTemplate.name) }); await this.userDataProfileManagementService.switchProfile(profile); return profile; }); </del> <ins> if (profileTemplate.settings) { progress(localize('progress settings', \"Applying Settings...\")); await this.instantiationService.createInstance(SettingsResource).apply(profileTemplate.settings, profile); } if (profileTemplate.keybindings) { progress(localize('progress keybindings', \"{0}ying Keyboard Shortcuts...\")); await this.instantiationService.createInstance(KeybindingsResource).apply(profileTemplate.keybindings, profile); } if (profileTemplate.tasks) { progress(localize('progress tasks', \"Applying Tasks...\")); await this.instantiationService.createInstance(TasksResource).apply(profileTemplate.tasks, profile); } if (profileTemplate.snippets) { progress(localize('progress snippets', \"Applying Snippets...\")); await this.instantiationService.createInstance(SnippetsResource).apply(profileTemplate.snippets, profile); } if (profileTemplate.globalState) { progress(localize('progress global state', \"Applying State...\")); await this.instantiationService.createInstance(GlobalStateResource).apply(profileTemplate.globalState, profile); } if (profileTemplate.extensions && extensions) { progress(localize('progress extensions', \"Applying Extensions...\")); await this.instantiationService.createInstance(ExtensionsResource, extensionsDisabled).apply(profileTemplate.extensions, profile); } progress(localize('switching profile', \" Applying...\")); await this.userDataProfileManagementService.switchProfile(profile); return profile; </ins> } private async resolveProfileContent(resource: URI): Promise<string | null> {", "commid": "vscode_pr_186602"}], "negative_passages": []}
{"query_id": "q-en-vscode-728954f4d98ab1937e4b27d9df95d96321b1739eec71ddf49f5f816f1a61b82b", "query": "Testing I started the Troubleshoot issue flow and it took a long time to create my initial profile. All I had was a status bar item which took me a while to discover (I actually thought something else went wrong). I would love to see and editor / web view better guiding me through that process by: listing the steps and adding check marks when done showing me the number of bisects still necessary giving me a final report.\n<img width=\"258\" alt=\"capture\" src=\"\"\nWe should also have a UI to always stop the process (see ) for a situation where this is useful\nI now see that there is a notification for each step. This makes it better, so may be a simple thing to do is to show a notificatio with progress when the profile is created instead of a simple status bar item.\nActually, setting up the trouble shooting profile should be fast and instant.\nWas not for me :-(\nFollowing notification is shown now !", "positive_passages": [{"docid": "doc-en-vscode-d00e285236d5284d269633f3f1cab5978a6fa90e6a0f665bc43273f2d80935ec", "text": "importProfile(uri: URI, options?: IProfileImportOptions): Promise<void>; showProfileContents(): Promise<void>; createFromCurrentProfile(name: string): Promise<void>; <del> createTemporaryProfile(from: IUserDataProfile, name: string, extensionsDisabled: boolean): Promise<void>; </del> <ins> createTroubleshootProfile(): Promise<void>; </ins> setProfile(profile: IUserDataProfileTemplate): Promise<void>; }", "commid": "vscode_pr_186602"}], "negative_passages": []}
{"query_id": "q-en-vscode-38ffe00e5885c437eac3c1605f469a7d9b0e40c558c34bda699424d08884f987", "query": "Testing After clicking the \"Install\" entry in the quick pick, there's progress for a few moments, then the quick pick flashes back to showing all the previous entries again, before finally landing on the setup options for the remote extension. !", "positive_passages": [{"docid": "doc-en-vscode-b6ec4ee0598b280e7d57b8c820f08781861d3a8b1c6d3ece51751dc3020e587a", "text": "return markdownTooltip; } <del> private async installAndRunStartCommand(metadata: RemoteExtensionMetadata) { const extensionId = metadata.id; </del> <ins> private async installExtension(extensionId: string) { </ins> const galleryExtension = (await this.extensionGalleryService.getExtensions([{ id: extensionId }], CancellationToken.None))[0]; await this.extensionManagementService.installFromGallery(galleryExtension, {", "commid": "vscode_pr_186461"}], "negative_passages": []}
{"query_id": "q-en-vscode-38ffe00e5885c437eac3c1605f469a7d9b0e40c558c34bda699424d08884f987", "query": "Testing After clicking the \"Install\" entry in the quick pick, there's progress for a few moments, then the quick pick flashes back to showing all the previous entries again, before finally landing on the setup options for the remote extension. !", "positive_passages": [{"docid": "doc-en-vscode-c112455f6872d40e93474829eabee48e37862dd04548663313f18ea2f6b92863", "text": "donotIncludePackAndDependencies: false, context: { [EXTENSION_INSTALL_SKIP_WALKTHROUGH_CONTEXT]: true } }); <ins> } private async runRemoteStartCommand(extensionId: string, startCommand: string) { // check to ensure the extension is installed </ins> await retry(async () => { <del> const ext = await this.extensionService.getExtension(metadata.id); </del> <ins> const ext = await this.extensionService.getExtension(extensionId); </ins> if (!ext) { throw Error('Failed to find installed remote extension'); } return ext; }, 300, 10); <del> this.commandService.executeCommand(metadata.startCommand); </del> <ins> this.commandService.executeCommand(startCommand); </ins> this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', { id: 'remoteInstallAndRun', detail: extensionId,", "commid": "vscode_pr_186461"}], "negative_passages": []}
{"query_id": "q-en-vscode-38ffe00e5885c437eac3c1605f469a7d9b0e40c558c34bda699424d08884f987", "query": "Testing After clicking the \"Install\" entry in the quick pick, there's progress for a few moments, then the quick pick flashes back to showing all the previous entries again, before finally landing on the setup options for the remote extension. !", "positive_passages": [{"docid": "doc-en-vscode-4f25e262a5a801395ea3107bd337e13324f3871878e5e2ea6c3dd64a1d1df6ce", "text": "quickPick.items = []; quickPick.busy = true; quickPick.placeholder = nls.localize('remote.startActions.installingExtension', 'Installing extension... '); <del> await this.installAndRunStartCommand(remoteExtension); </del> <ins> await this.installExtension(remoteExtension.id); quickPick.hide(); await this.runRemoteStartCommand(remoteExtension.id, remoteExtension.startCommand); </ins> } else { this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', {", "commid": "vscode_pr_186461"}], "negative_passages": []}
{"query_id": "q-en-vscode-38ffe00e5885c437eac3c1605f469a7d9b0e40c558c34bda699424d08884f987", "query": "Testing After clicking the \"Install\" entry in the quick pick, there's progress for a few moments, then the quick pick flashes back to showing all the previous entries again, before finally landing on the setup options for the remote extension. !", "positive_passages": [{"docid": "doc-en-vscode-309b573190c2c6cd78bc06cf3bf5382307c186742a7811857701a7e5406000d3", "text": "from: 'remote indicator' }); this.commandService.executeCommand(commandId); <ins> quickPick.hide(); </ins> } <del> quickPick.hide(); </del> } }));", "commid": "vscode_pr_186461"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-8437340617c8dbe2f9caff6d47ab2244373bb04ac62d024803d78eafe2d22912", "text": "import { ActionBar } from 'vs/base/browser/ui/actionbar/actionbar'; import { AriaRole } from 'vs/base/browser/ui/aria/aria'; import { HoverPosition } from 'vs/base/browser/ui/hover/hoverWidget'; <del> import { IHoverWidget } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate'; </del> <ins> import { IHoverDelegate, IHoverWidget } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate'; </ins> import { IconLabel, IIconLabelValueOptions } from 'vs/base/browser/ui/iconLabel/iconLabel'; import { KeybindingLabel } from 'vs/base/browser/ui/keybindingLabel/keybindingLabel'; import { IListRenderer, IListVirtualDelegate } from 'vs/base/browser/ui/list/list';", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-15045212ae1adb985dd5e2a8fc3e8807a07166ca51eaca1baa1a5c83120b06f9", "text": "static readonly ID = 'listelement'; <del> constructor(private readonly themeService: IThemeService) { } </del> <ins> constructor( private readonly themeService: IThemeService, private readonly hoverDelegate: IHoverDelegate | undefined, ) { } </ins> get templateId() { return ListElementRenderer.ID;", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-e9ac5b93684f1c1ae195ca7eb0ca00ce25979955d0f1427c463b4824206d14c3", "text": "const row2 = dom.append(rows, $('.quick-input-list-row')); // Label <del> data.label = new IconLabel(row1, { supportHighlights: true, supportDescriptionHighlights: true, supportIcons: true }); </del> <ins> data.label = new IconLabel(row1, { supportHighlights: true, supportDescriptionHighlights: true, supportIcons: true, hoverDelegate: this.hoverDelegate }); </ins> data.toDisposeTemplate.push(data.label); data.icon = <HTMLInputElement>dom.prepend(data.label.element, $('.quick-input-list-icon'));", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-8f2f934be0df7d90f74966b02fd4edb9dbd65625681133d13373c4749296bcae", "text": "// Detail const detailContainer = dom.append(row2, $('.quick-input-list-label-meta')); <del> data.detail = new IconLabel(detailContainer, { supportHighlights: true, supportIcons: true }); </del> <ins> data.detail = new IconLabel(detailContainer, { supportHighlights: true, supportIcons: true, hoverDelegate: this.hoverDelegate }); </ins> data.toDisposeTemplate.push(data.detail); // Separator data.separator = dom.append(data.entry, $('.quick-input-list-separator')); // Actions <del> data.actionBar = new ActionBar(data.entry); </del> <ins> data.actionBar = new ActionBar(data.entry, this.hoverDelegate ? { hoverDelegate: this.hoverDelegate } : undefined); </ins> data.actionBar.domNode.classList.add('quick-input-list-entry-action-bar'); data.toDisposeTemplate.push(data.actionBar);", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-483a5f910553d5264aab9519100de4ab9b8d72862cc73ad3408bbf7ab8fb1374", "text": "// Label const options: IIconLabelValueOptions = { matches: labelHighlights || [], <del> descriptionTitle: element.saneDescription, </del> <ins> // If we have a tooltip, we want that to be shown and not any other hover descriptionTitle: element.saneTooltip ? undefined : element.saneDescription, </ins> descriptionMatches: descriptionHighlights || [], labelEscapeNewLines: true };", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-497acc3c8bbfb98acaf89985513bb5b0f66d2043cfc516932a40678199d742c5", "text": "data.detail.element.style.display = ''; data.detail.setLabel(element.saneDetail, undefined, { matches: detailHighlights, <del> title: element.saneDetail, </del> <ins> // If we have a tooltip, we want that to be shown and not any other hover title: element.saneTooltip ? undefined : element.saneDetail, </ins> labelEscapeNewLines: true }); } else {", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-4f62249deb06b79a9b62cf00830bf0e35a89313e2c0867c6e3168293ab78d63c", "query": "Testing Format of keybindings is particularly ugly ! !\nDoes this question accept PR from outsiders?\nyes. VS Code does accept PRs!\nThanks!, and I'm going to refer to styles for other widgets, or if we already have styles we like?\nIt's more complicated than just styles, sadly. We need to use our rich hovers instead of the native hovers... thankfully we did some work recently to plumb a all the way down to the QuickPick. To fix the title bar buttons, you can probably add the hover delegate in into the options of these s: The list will be harder has the buttons get created here: but we can be iterative here and focus on the title bar buttons first. the other issue that has to be addressed is that Monaco: currently doesn't have a HoverDelegate implementation here: so either we need to implement a HoverDelegate in the \"standalone\" code (aka Monaco) or we need to pass in the right value to tell quick pick to not use a hover delegate and use native hovers instead. So yeah... it's a bit more complicated than styles unfortunately\nSorry to reply late, thank you for your help! I will start learning the relevant code here over the weekend, hope it goes well!\nIt is very convenient to create rich hover based on the clues you provide!(Please ignore his style and content) I'm using method for the time being to set the style: I would like to ask for help, is it the right choice to use this method? If yes, I will continue to improve ps:For Monaco, I haven't started looking at the relevant code, but I will as soon as possible !\nOn the VS Code (non-Monaco side) we already pass a hover delegate in here: So you should be able to just reuse that instead of\nI adapted the title bar, but the buttons in the menu options cannot be easily adapted because they are not available e.g. 'Learn More' in screenshot, next I'm going to learn monaco-related code, for monaco's tabbar, do you know which pages can be easily called show?\nwe can start with just fixing the title bar buttons if you'd like and then fix the Learn More ones later. We can be iterative :) We still for sure need this before that PR of yours comes in: from\nThanks for your help, I'll go investigate the monaco related code, but it may be later, I'm also stuck with this issue\nIf you use Node 18, you shouldn't see that issue.\nIt works for me, I would also like to ask for a simple question: In addition to calling api, is there any scenario in vscode that directly runs monaco? I'm trying to find a link to a monaco input call, but failing\nGood question. Here are the steps for running Monaco: What I would recommend is maybe temporarily adding a button to an existing quick pick like the command palette: add a line like: and don't forget to import it:\nThank you for your patience! I will start learning the code\nI investigated the existing code and found some problem if I wanted to implement a HoverDelegate in the \"standalone\" code: We need to use related code, but they are in the , and should not be import this layer, do we need to re-implement a standalone with hover? or lower the code hierarchy to the level, I'm not sure if the conclusion I got is correct, so I still need to ask you for help, thanks!\nso before, I provided a default implementation of the here that does nothing: I think what we should do is remove that and allow to be /optional. If it's don't pass it in to the s so that the native hover is used as fallback.\nIt's better to handle it this way, otherwise it's really difficult to achieve the current situation (especially for me), I'll submit the PR later\nI submitted an initial PR, but I'm not sure if I missed some details, and found that one of the tests timed out\nVerification on macOS would be easiest I think: Open up a few pickers Hover over different components: description detail quick pick buttons quick pick item buttons None of them should be using native hovers. They should all be using custom hovers.\nIs there anything I can do to help? Do we need to replace everything that needs to be replaced with a custom hover,I'm willing to submit a PR to modify these if I can\nIt's already done! Now we verify everything is working as expected before :)\nAre these the old tooltips or the new ones? <img width=\"275\" alt=\"image\" src=\"\"<img width=\"306\" alt=\"image\" src=\"\"This is what I'm seeing.\nYes those look like custom\nActually, the keybinding one isn't... let me capture this in another issue as the class doesn't actually support a hover delegate.", "positive_passages": [{"docid": "doc-en-vscode-d3e1e2dd10d270d10f51cdee3cf9de5396ec33a242d77e4b00c60b97ac7a76d8", "text": "this.container = dom.append(this.parent, $('.quick-input-list')); const delegate = new ListElementDelegate(); const accessibilityProvider = new QuickInputAccessibilityProvider(); <del> this.list = options.createList('QuickInput', this.container, delegate, [new ListElementRenderer(themeService)], { </del> <ins> this.list = options.createList('QuickInput', this.container, delegate, [new ListElementRenderer(themeService, options.hoverDelegate)], { </ins> identityProvider: { getId: element => { // always prefer item over separator because if item is defined, it must be the main item type", "commid": "vscode_pr_201339"}], "negative_passages": []}
{"query_id": "q-en-vscode-f5188758fd86b319997cfccdc2e73e4bc44b316249fc9527b5a772731215afc6", "query": "Testing Steps: Open locally cloned vscode repo with any branch Welcome page Connect to... Continue Working in Nothing happens after this for me... but I do see the commands get run:", "positive_passages": [{"docid": "doc-en-vscode-4725c033a49f6c0b5bb1e8d966419dee081b8d495716d29f43a56e48122b164c", "text": "async function copyVscodeDevLink(gitAPI: GitAPI, useSelection: boolean, context: LinkContext, includeRange = true) { try { <del> const permalink = await getLink(gitAPI, useSelection, getVscodeDevHost(), 'headlink', context, includeRange); </del> <ins> const permalink = await getLink(gitAPI, useSelection, true, getVscodeDevHost(), 'headlink', context, includeRange); </ins> if (permalink) { return vscode.env.clipboard.writeText(permalink); }", "commid": "vscode_pr_186410"}], "negative_passages": []}
{"query_id": "q-en-vscode-f5188758fd86b319997cfccdc2e73e4bc44b316249fc9527b5a772731215afc6", "query": "Testing Steps: Open locally cloned vscode repo with any branch Welcome page Connect to... Continue Working in Nothing happens after this for me... but I do see the commands get run:", "positive_passages": [{"docid": "doc-en-vscode-a115e68b66c5e297a32dee2f3baffbece641c17322e8c5328169b18f8c938249", "text": "async function openVscodeDevLink(gitAPI: GitAPI): Promise<vscode.Uri | undefined> { try { <del> const headlink = await getLink(gitAPI, true, getVscodeDevHost(), 'headlink'); </del> <ins> const headlink = await getLink(gitAPI, true, false, getVscodeDevHost(), 'headlink'); </ins> return headlink ? vscode.Uri.parse(headlink) : undefined; } catch (err) { if (!(err instanceof vscode.CancellationError)) {", "commid": "vscode_pr_186410"}], "negative_passages": []}
{"query_id": "q-en-vscode-f5188758fd86b319997cfccdc2e73e4bc44b316249fc9527b5a772731215afc6", "query": "Testing Steps: Open locally cloned vscode repo with any branch Welcome page Connect to... Continue Working in Nothing happens after this for me... but I do see the commands get run:", "positive_passages": [{"docid": "doc-en-vscode-21117b14ee470a137f0d1f496f4c12e0e2b1827b7328bc121103d2fc541bb231", "text": "return path.split('/').map((segment) => encodeURIComponent(segment)).join('/'); } <del> export async function getLink(gitAPI: GitAPI, useSelection: boolean, hostPrefix?: string, linkType: 'permalink' | 'headlink' = 'permalink', context?: LinkContext, useRange?: boolean): Promise<string | undefined> { </del> <ins> export async function getLink(gitAPI: GitAPI, useSelection: boolean, shouldEnsurePublished: boolean, hostPrefix?: string, linkType: 'permalink' | 'headlink' = 'permalink', context?: LinkContext, useRange?: boolean): Promise<string | undefined> { </ins> hostPrefix = hostPrefix ?? 'https://github.com'; const fileAndPosition = getFileAndPosition(context); if (!fileAndPosition) {", "commid": "vscode_pr_186410"}], "negative_passages": []}
{"query_id": "q-en-vscode-f5188758fd86b319997cfccdc2e73e4bc44b316249fc9527b5a772731215afc6", "query": "Testing Steps: Open locally cloned vscode repo with any branch Welcome page Connect to... Continue Working in Nothing happens after this for me... but I do see the commands get run:", "positive_passages": [{"docid": "doc-en-vscode-1d94d97f1672be82b05db7e5ef3390a9625846302fe9c03a291c8e96d9aec45e", "text": "return; } <del> await ensurePublished(gitRepo, uri); </del> <ins> if (shouldEnsurePublished) { await ensurePublished(gitRepo, uri); } </ins> let repo: { owner: string; repo: string } | undefined; gitRepo.state.remotes.find(remote => {", "commid": "vscode_pr_186410"}], "negative_passages": []}
{"query_id": "q-en-vscode-86a5e254ec04ff63f12018c36480856b84f87cd9ab0822f01c8b1df6641a0dd0", "query": "Testing a file +enter to run cell in interactive window window GitHub Copilot classic installed and signed in something into the input box and ctrl+enter, this opens a third editor group with multiple synthesized Copilot solutions (feature from GitHub Copilot) close that editor :bug: now there is an empty third editor group which really shouldn't happen AFAIK, also there is screen cheese, it shouldn't really be possible for Copilot to cause this kind of layout issue <img width=\"1256\" alt=\"image\" src=\"\"<img width=\"1245\" alt=\"image\" src=\"\"\nI assigned you for grid layout and I assigned you for editor layout, please feel free to unassign if this isn't relevant to you\nempty editor groups are not a bug per-se, if you configure , groups will remain open when the last editor closes. Also, empty groups can explicitly be created, e.g. via . However, the fact that you cannot get rid of the empty group when you press the X button sounds like an issue to me. When you try to close, is there anything printed to the console?\nOhhhhhhhhhhh good bug! There is definitely splitview/gridview breakage here.\nWait. I could repro once... but not anymore. Can you still repro?\nYes I reproed twice\nI cannot see anything in logs when clicking on the X unfortunately (fwiw, I do not have that setting configured) When I repro this, here's what's in the log (this happens right after closing the last editor in a group that results in the group not also being closed)\nI wonder if this could possibly be a regression from the auto-sizing feature you did?\nWe just need to be able to repro on demand so we can attempt to repro on a version before my changes to confirm this. But I can't seem to repro no more. Can you ?\nI cannot reproduce this, I never get an empty editor group. This is with fresh user data dir and extensions dir.\nif you have a reliable repro that you can share, including your settings if any. Here is what I do: !\nI did some more messing around and was able to repro a similar problem ! <details</details\nOK, I have a trivial and consistent repro. TLDR it looks like the interactive window does not play nice with split view. an interactive window (you can even do this with the Jupyter: Create Interactive Window command) the Settings UI the Settings UI onto the right of the interactive window :bug: the split view is very unhappy Logs <details</details\nThis also repros for notebooks opened in the second group Right click a .ipynb file -open to the side open another editor and drag it to the right side of the first\nOh wow. So it looks like the call to throws an exception when done in the interactive window and that means the Grid will indeed be unhappy!\nfor surrounding some of the calls with .\nArguably, the grid/splitview should also protect itself...\nYeah, maybe. There could be other cases.\nI can't repro any of these now but it would probably help for to verify too\nI still do not have a functional cursor/trackpad so cannot drag/drop maybe you can verify?\nVerified it's working great", "positive_passages": [{"docid": "doc-en-vscode-8115eddd5d25a018e72b577e7adf7965127b60d8ca0227cba716bda6983036b5", "text": "} } <del> for (let i = (renderActions.length - 1); i !== 0; i--) { </del> <ins> for (let i = (renderActions.length - 1); i > 0; i--) { </ins> const temp = renderActions[i]; if (temp.size === 0) { continue;", "commid": "vscode_pr_186562"}], "negative_passages": []}
{"query_id": "q-en-vscode-da41ba48ed14558a25e684926033067367175b751e475ebb8861c9d997cee53e", "query": "The steps are simple: settings editor in one group untitled editor in the group next to it sizes are equal drag the untitled editor to the left of the settings editor the sizes end up not to be equal. Insiders ! Stable ! Maybe this is related to the settings editor wanting a larger size? I can reproduce this in a small window size (the default one when you open a fresh user data dir).", "positive_passages": [{"docid": "doc-en-vscode-f803cf6606640b7ad709b93d8c66d76683347f88a3890c802f56a873f7984091", "text": "const data = this.editorTransfer.getData(DraggedEditorIdentifier.prototype); if (Array.isArray(data)) { const draggedEditor = data[0].identifier; <del> const targetGroup = ensureTargetGroup(); </del> const sourceGroup = this.accessor.getGroup(draggedEditor.groupId); if (sourceGroup) { <del> if (sourceGroup === targetGroup) { return; </del> <ins> const copyEditor = this.isCopyOperation(event, draggedEditor); let targetGroup: IEditorGroupView | undefined = undefined; // Optimization: if we move the last editor of an editor group // and we are configured to close empty editor groups, we can // rather move the entire editor group according to the direction if (this.editorGroupService.partOptions.closeEmptyGroups && sourceGroup.count === 1 && typeof splitDirection === 'number' && !copyEditor) { targetGroup = this.accessor.moveGroup(sourceGroup, this.groupView, splitDirection); </ins> } <del> // Open in target group const options = fillActiveEditorViewState(sourceGroup, draggedEditor.editor, { pinned: true,\t\t\t\t\t\t\t\t\t\t// always pin dropped editor sticky: sourceGroup.isSticky(draggedEditor.editor),\t// preserve sticky state }); </del> <ins> // In any other case do a normal move/copy operation else { targetGroup = ensureTargetGroup(); if (sourceGroup === targetGroup) { return; } </ins> <del> const copyEditor = this.isCopyOperation(event, draggedEditor); if (!copyEditor) { sourceGroup.moveEditor(draggedEditor.editor, targetGroup, options); } else { sourceGroup.copyEditor(draggedEditor.editor, targetGroup, options); </del> <ins> // Open in target group const options = fillActiveEditorViewState(sourceGroup, draggedEditor.editor, { pinned: true,\t\t\t\t\t\t\t\t\t\t// always pin dropped editor sticky: sourceGroup.isSticky(draggedEditor.editor),\t// preserve sticky state }); if (!copyEditor) { sourceGroup.moveEditor(draggedEditor.editor, targetGroup, options); } else { sourceGroup.copyEditor(draggedEditor.editor, targetGroup, options); } </ins> } // Ensure target has focus", "commid": "vscode_pr_186609"}], "negative_passages": []}
{"query_id": "q-en-vscode-eac08b53244e0ccaab0c3fcc12feae9c8daa489519af38491923977e4da7fd35", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 (user setup) OS Version: Windows 10 22H2 To fix the issue please update the native-is-elevated package. It was fixed two months ago.\nCould you maybe verify using our insiders? You can give our preview releases a try from:\nIt seems working properly now. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-ba6ab063da7bda3b7128428786a23326781a4c1c3b2ce0249e7cff58bb80d556", "text": "\"jschardet\": \"3.0.0\", \"keytar\": \"7.9.0\", \"minimist\": \"^1.2.6\", <del> \"native-is-elevated\": \"0.6.0\", </del> <ins> \"native-is-elevated\": \"0.7.0\", </ins> \"native-keymap\": \"^3.3.2\", \"native-watchdog\": \"^1.4.1\", \"node-pty\": \"1.1.0-beta1\",", "commid": "vscode_pr_186715"}], "negative_passages": []}
{"query_id": "q-en-vscode-eac08b53244e0ccaab0c3fcc12feae9c8daa489519af38491923977e4da7fd35", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 (user setup) OS Version: Windows 10 22H2 To fix the issue please update the native-is-elevated package. It was fixed two months ago.\nCould you maybe verify using our insiders? You can give our preview releases a try from:\nIt seems working properly now. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-2ba8d883dff4c47bd3cefd095c25a6970c226e981a98d0b5e9cc49056b589c72", "text": "resolved \"https://registry.yarnpkg.com/napi-build-utils/-/napi-build-utils-1.0.2.tgz#b1fddc0b2c46e380a0b7a76f984dd47c41a13806\" integrity sha512-ONmRUqK7zj7DWX0D9ADe03wbwOBZxNAfF20PlGfCWQcD3+/MakShIHrMqx9YwPTfxDdF1zLeL+RGZiR9kGMLdg== <del> native-is-elevated@0.6.0: version \"0.6.0\" resolved \"https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.6.0.tgz#9fd9c9c53bfd87d6e6af15a5d6bcb8e592b7ec79\" integrity sha512-HW1wDo4WYZC7W68kaS0cs7FtDTrcFoAY1APc4SlU4Un/FuL7pjilXFEteBCA58EWClKk0912JLIoekOJ/NohnQ== </del> <ins> native-is-elevated@0.7.0: version \"0.7.0\" resolved \"https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.7.0.tgz#77499639e232edad1886403969e2bf236294e7af\" integrity sha512-tp8hUqK7vexBiyIWKMvmRxdG6kqUtO+3eay9iB0i16NYgvCqE5wMe1Y0guHilpkmRgvVXEWNW4et1+qqcwpLBA== </ins> native-keymap@^3.3.2: version \"3.3.3\"", "commid": "vscode_pr_186715"}], "negative_passages": []}
{"query_id": "q-en-vscode-1412d412cd4a313dc84d27d05cfdbff654551319233a1d5a9415d896f023111b", "query": "in VS Code :bug: sticky scroll has no syntax highlighting <img width=\"691\" alt=\"image\" src=\"\"\nHey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.\nIt appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.", "positive_passages": [{"docid": "doc-en-vscode-769bf99d125a4a70ee879259e44b45f6995d45e795e13b9ecf1ab88d653d8b1c", "text": "import * as dom from 'vs/base/browser/dom'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; import { createTrustedTypesPolicy } from 'vs/base/browser/trustedTypes'; <del> import { equals } from 'vs/base/common/arrays'; </del> import { Disposable, DisposableStore } from 'vs/base/common/lifecycle'; import 'vs/css!./stickyScroll'; import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition } from 'vs/editor/browser/editorBrowser';", "commid": "vscode_pr_187933"}], "negative_passages": []}
{"query_id": "q-en-vscode-1412d412cd4a313dc84d27d05cfdbff654551319233a1d5a9415d896f023111b", "query": "in VS Code :bug: sticky scroll has no syntax highlighting <img width=\"691\" alt=\"image\" src=\"\"\nHey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.\nIt appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.", "positive_passages": [{"docid": "doc-en-vscode-173418e851d6c69e53c9c3b2fa17fc0592198b2f08dbffaa5b943635d3e5cd95", "text": "readonly lineNumbers: number[], readonly lastLineRelativePosition: number ) { } <del> public equals(other: StickyScrollWidgetState | undefined): boolean { return !!other && this.lastLineRelativePosition === other.lastLineRelativePosition && equals(this.lineNumbers, other.lineNumbers); } </del> } const _ttPolicy = createTrustedTypesPolicy('stickyScrollViewLayer', { createHTML: value => value });", "commid": "vscode_pr_187933"}], "negative_passages": []}
{"query_id": "q-en-vscode-1412d412cd4a313dc84d27d05cfdbff654551319233a1d5a9415d896f023111b", "query": "in VS Code :bug: sticky scroll has no syntax highlighting <img width=\"691\" alt=\"image\" src=\"\"\nHey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.\nIt appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.", "positive_passages": [{"docid": "doc-en-vscode-1a6794144c2358cd6adcb9dbf20d134d681f14f74c592cd2f22bb672028ef540", "text": "private _lastLineRelativePosition: number = 0; private _hoverOnLine: number = -1; private _hoverOnColumn: number = -1; <del> private _state: StickyScrollWidgetState | undefined; </del> constructor( private readonly _editor: ICodeEditor", "commid": "vscode_pr_187933"}], "negative_passages": []}
{"query_id": "q-en-vscode-1412d412cd4a313dc84d27d05cfdbff654551319233a1d5a9415d896f023111b", "query": "in VS Code :bug: sticky scroll has no syntax highlighting <img width=\"691\" alt=\"image\" src=\"\"\nHey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.\nIt appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.", "positive_passages": [{"docid": "doc-en-vscode-839c328769b10b34bdf3011a36ef5ed66cc77ce3c5ae9c3f7a9ff29e88a0cfe1", "text": "} setState(state: StickyScrollWidgetState): void { <del> if (state.equals(this._state)) { return; } this._state = state; </del> dom.clearNode(this._rootDomNode); this._disposableStore.clear(); this._lineNumbers.length = 0;", "commid": "vscode_pr_187933"}], "negative_passages": []}
{"query_id": "q-en-vscode-410da19bea9edf7e8fb3319105d95875cd56ae01f78bb7a233af56866e8440aa", "query": "create a folder with a task that uses: update an extension and use \"Reload window\" or use Reload window directly from the command pallette observe that the task now runs twice: <img width=\"328\" alt=\"image\" src=\"\"\nLikely a regression from one of the task fixes this iteration.\nNot able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nThis problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks\nIt seems for Alex's repro steps to work, the terminal panel needs to be hidden\nWhen the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first", "positive_passages": [{"docid": "doc-en-vscode-f7fc4e1be384b888b0bb220a91036edbc25df001f2d9be3c5473ca26f03ac1b7", "text": "private _onDidChangeTaskSystemInfo: Emitter<void> = new Emitter(); private _willRestart: boolean = false; public onDidChangeTaskSystemInfo: Event<void> = this._onDidChangeTaskSystemInfo.event; <ins> private _onDidReconnectToTasks: Emitter<void> = new Emitter(); public onDidReconnectToTasks: Event<void> = this._onDidReconnectToTasks.event; </ins> constructor( @IConfigurationService private readonly _configurationService: IConfigurationService,", "commid": "vscode_pr_192918"}], "negative_passages": []}
{"query_id": "q-en-vscode-410da19bea9edf7e8fb3319105d95875cd56ae01f78bb7a233af56866e8440aa", "query": "create a folder with a task that uses: update an extension and use \"Reload window\" or use Reload window directly from the command pallette observe that the task now runs twice: <img width=\"328\" alt=\"image\" src=\"\"\nLikely a regression from one of the task fixes this iteration.\nNot able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nThis problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks\nIt seems for Alex's repro steps to work, the terminal panel needs to be hidden\nWhen the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first", "positive_passages": [{"docid": "doc-en-vscode-d0be11384bcf6dc9d5b0f4712a0994bf98b114b98cdc900e9f218766069b7c91", "text": "} this.getWorkspaceTasks(TaskRunSource.Reconnect).then(async () => { this._tasksReconnected = await this._reconnectTasks(); <ins> this._onDidReconnectToTasks.fire(); </ins> }); }", "commid": "vscode_pr_192918"}], "negative_passages": []}
{"query_id": "q-en-vscode-410da19bea9edf7e8fb3319105d95875cd56ae01f78bb7a233af56866e8440aa", "query": "create a folder with a task that uses: update an extension and use \"Reload window\" or use Reload window directly from the command pallette observe that the task now runs twice: <img width=\"328\" alt=\"image\" src=\"\"\nLikely a regression from one of the task fixes this iteration.\nNot able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nThis problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks\nIt seems for Alex's repro steps to work, the terminal panel needs to be hidden\nWhen the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first", "positive_passages": [{"docid": "doc-en-vscode-3d1ad84ed92f1e682a04d35639f3a39a7ff0901e316f21c79872ac59b0dd6547", "text": "} if (executeResult.kind === TaskExecuteKind.Active) { const active = executeResult.active; <ins> if (active && active.same && runSource === TaskRunSource.FolderOpen) { // ignore, the task is already active, likely from being reconnected. this._logService.debug('Ignoring task that is already active', executeResult.task); return executeResult.promise; } </ins> if (active && active.same) { if (this._taskSystem?.isTaskVisible(executeResult.task)) { const message = nls.localize('TaskSystem.activeSame.noBackground', 'The task '{0}' is already active.', executeResult.task.getQualifiedLabel());", "commid": "vscode_pr_192918"}], "negative_passages": []}
{"query_id": "q-en-vscode-410da19bea9edf7e8fb3319105d95875cd56ae01f78bb7a233af56866e8440aa", "query": "create a folder with a task that uses: update an extension and use \"Reload window\" or use Reload window directly from the command pallette observe that the task now runs twice: <img width=\"328\" alt=\"image\" src=\"\"\nLikely a regression from one of the task fixes this iteration.\nNot able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nThis problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks\nIt seems for Alex's repro steps to work, the terminal panel needs to be hidden\nWhen the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first", "positive_passages": [{"docid": "doc-en-vscode-12e4fd38ace4f9562d1e68a8c601d27c545f03c5fcb84ad4a7ffcb4f4ab6c3a4", "text": "@IWorkspaceTrustManagementService private readonly _workspaceTrustManagementService: IWorkspaceTrustManagementService, @ILogService private readonly _logService: ILogService) { super(); <del> if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } </del> <ins> this._taskService.onDidReconnectToTasks((() => { if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } })); </ins> this._register(this._workspaceTrustManagementService.onDidChangeTrust(async trusted => { if (trusted) { await this._tryRunTasks();", "commid": "vscode_pr_192918"}], "negative_passages": []}
{"query_id": "q-en-vscode-410da19bea9edf7e8fb3319105d95875cd56ae01f78bb7a233af56866e8440aa", "query": "create a folder with a task that uses: update an extension and use \"Reload window\" or use Reload window directly from the command pallette observe that the task now runs twice: <img width=\"328\" alt=\"image\" src=\"\"\nLikely a regression from one of the task fixes this iteration.\nNot able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nThis problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks\nIt seems for Alex's repro steps to work, the terminal panel needs to be hidden\nWhen the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first", "positive_passages": [{"docid": "doc-en-vscode-3f08ec0882a7b50480186a32eb6f13df100a6965bdfb21fae5f263bd0b81a062", "text": "export interface ITaskService { readonly _serviceBrand: undefined; onDidStateChange: Event<ITaskEvent>; <ins> onDidReconnectToTasks: Event<void>; </ins> supportsMultipleTaskExecutions: boolean; configureAction(): Action;", "commid": "vscode_pr_192918"}], "negative_passages": []}
{"query_id": "q-en-vscode-a33c6a421580bb944b5a732d9b3e726099e14b789462f88aed6d66c17f11b00e", "query": "Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.\nI cannot find your reversed P, nonetheless, with diff version 2 and removed \"ignore leading/trailing whitespace\", I get this: <img width=\"1384\" alt=\"image\" src=\"\"and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width=\"551\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-372fda74f98576d348cdc9370aa0027376dc6073c0aff7c0c287223f443888b3", "text": "} }; observable.addObserver(observer); <ins> observable.reportChanges(); </ins> return { dispose() { observable.removeObserver(observer);", "commid": "vscode_pr_188196"}], "negative_passages": []}
{"query_id": "q-en-vscode-a33c6a421580bb944b5a732d9b3e726099e14b789462f88aed6d66c17f11b00e", "query": "Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.\nI cannot find your reversed P, nonetheless, with diff version 2 and removed \"ignore leading/trailing whitespace\", I get this: <img width=\"1384\" alt=\"image\" src=\"\"and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width=\"551\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-50fd00ea3a88b3d5961ac9722030ca53ec418084227005496c3efaefdc8b32ab", "text": "*--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; <del> import { Emitter } from 'vs/base/common/event'; </del> <ins> import { Emitter, Event } from 'vs/base/common/event'; </ins> import { ISettableObservable, autorun, derived, ITransaction, observableFromEvent, observableValue, transaction, keepAlive } from 'vs/base/common/observable'; import { BaseObservable, IObservable, IObserver } from 'vs/base/common/observableImpl/base';", "commid": "vscode_pr_188196"}], "negative_passages": []}
{"query_id": "q-en-vscode-a33c6a421580bb944b5a732d9b3e726099e14b789462f88aed6d66c17f11b00e", "query": "Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.\nI cannot find your reversed P, nonetheless, with diff version 2 and removed \"ignore leading/trailing whitespace\", I get this: <img width=\"1384\" alt=\"image\" src=\"\"and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width=\"551\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-f117cefe0ec727f9da83837d91167b365398d911fdf571d7ea13c77843ed206a", "text": "myObservable2.set(1, tx); }); }); <ins> test('bug: fromObservableLight doesnt subscribe', () => { const log = new Log(); const myObservable = new LoggingObservableValue('myObservable', 0, log); const myDerived = derived('myDerived', reader => { const val = myObservable.read(reader); log.log(`myDerived.computed(myObservable2: ${val})`); return val % 10; }); const e = Event.fromObservableLight(myDerived); log.log('event created'); e(() => { log.log('event fired'); }); myObservable.set(1, undefined); assert.deepStrictEqual(log.getAndClearEntries(), [ 'event created', 'myObservable.firstObserverAdded', 'myObservable.get', 'myDerived.computed(myObservable2: 0)', 'myObservable.set (value 1)', 'myObservable.get', 'myDerived.computed(myObservable2: 1)', 'event fired', ]); }); </ins> }); export class LoggingObserver implements IObserver {", "commid": "vscode_pr_188196"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-75f31200e8e7b00fe7238548a71443249b99abdfea8a2aab811d8dc87030c07c", "text": "private _isInLayout: boolean = false; <del> private readonly _viewContext: ViewContext; </del> private _webviewElement: FastDomNode<HTMLElement> | null = null; get webviewElement() {", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-f200cc85e92b8aeb6be73d5b45300bcd3d94df50a970dde4aaceb45b73433407", "text": ") { super(listUser, container, delegate, renderers, options, contextKeyService, listService, configurationService, instantiationService); NOTEBOOK_CELL_LIST_FOCUSED.bindTo(this.contextKeyService).set(true); <del> this._viewContext = viewContext; </del> this._previousFocusedElements = this.getFocusedElements(); this._localDisposableStore.add(this.onDidChangeFocus((e) => { this._previousFocusedElements.forEach(element => {", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-8f1fb7e624851529f034463f4120e96ae1a01bd0849d0d2b2b1f0977410fb0a5", "text": "const scrollHeight = this.view.scrollHeight; const scrollTop = this.getViewScrollTop(); const wrapperBottom = this.getViewScrollBottom(); <del> const topInsertToolbarHeight = this._viewContext.notebookOptions.computeTopInsertToolbarHeight(this.viewModel?.viewType); this.view.setScrollTop(scrollHeight - (wrapperBottom - scrollTop) - topInsertToolbarHeight); </del> <ins> this.view.setScrollTop(scrollHeight - (wrapperBottom - scrollTop)); </ins> } //#region Reveal Cell synchronously", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-74c6231d9272d27abe361ae88dc7c495b29a73a8be77a1bf8bc09c1ebf8f48f0", "text": "} getViewScrollBottom() { <del> const topInsertToolbarHeight = this._viewContext.notebookOptions.computeTopInsertToolbarHeight(this.viewModel?.viewType); return this.getViewScrollTop() + this.view.renderHeight - topInsertToolbarHeight; </del> <ins> return this.getViewScrollTop() + this.view.renderHeight; </ins> } setCellEditorSelection(cell: ICellViewModel, range: Range) {", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-ce7f7e11c24f50e1f720a0a3bc1971b5c3f79d6fff6ee59b02bdd1085ac6d7fb", "text": "import * as assert from 'assert'; import { DisposableStore } from 'vs/base/common/lifecycle'; <del> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </del> import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; import { CellKind } from 'vs/workbench/contrib/notebook/common/notebookCommon'; <del> import { INotebookExecutionStateService } from 'vs/workbench/contrib/notebook/common/notebookExecutionStateService'; import { NotebookOptions } from 'vs/workbench/contrib/notebook/browser/notebookOptions'; </del> import { createNotebookCellList, setupInstantiationService, withTestNotebook } from 'vs/workbench/contrib/notebook/test/browser/testNotebookEditor'; suite('NotebookCellList', () => { let disposables: DisposableStore; let instantiationService: TestInstantiationService; <del> let notebookDefaultOptions: NotebookOptions; let topInsertToolbarHeight: number; </del> suiteSetup(() => { disposables = new DisposableStore(); instantiationService = setupInstantiationService(disposables); <del> notebookDefaultOptions = new NotebookOptions(instantiationService.get(IConfigurationService), instantiationService.get(INotebookExecutionStateService), false); topInsertToolbarHeight = notebookDefaultOptions.computeTopInsertToolbarHeight(); </del> }); suiteTeardown(() => disposables.dispose());", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-b31fcff52d614dbbb3f2bd0d9dd900c460382dafcfee4af9fb9abda79fd6019e", "text": "cellList.attachViewModel(viewModel); // render height 210, it can render 3 full cells and 1 partial cell <del> cellList.layout(210 + topInsertToolbarHeight, 100); </del> <ins> cellList.layout(210, 100); </ins> // scroll a bit, scrollTop to bottom: 5, 215 cellList.scrollTop = 5;", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-b51d4861dfb9e8e9142a9010223b5c890d686575ad590ac0340dfe07e2e97e07", "query": "enough cells in the interactive window that it needs to scroll \"interactiveWindow.alwaysScrollOnNewCell\": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible", "positive_passages": [{"docid": "doc-en-vscode-d9089b7d206a7bc86151e64569717f2e5bbdd6b3367fda7237bdd08272c50740", "text": "cellList.attachViewModel(viewModel); // render height 210, it can render 3 full cells and 1 partial cell <del> cellList.layout(210 + topInsertToolbarHeight, 100); </del> <ins> cellList.layout(210, 100); </ins> // init scrollTop and scrollBottom assert.deepStrictEqual(cellList.scrollTop, 0);", "commid": "vscode_pr_188726"}], "negative_passages": []}
{"query_id": "q-en-vscode-3264427872058f981b3aba5683e498e4f676c17083bdd63172525e3e8546ff13", "query": "Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?\nMy notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.\nthe looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated", "positive_passages": [{"docid": "doc-en-vscode-f165b81e7f28164bc7b1a8c7055bd40024185f88e1f0413b38cfc045797e87f7", "text": "if (this._isVisible) { const notificationsList = assertIsDefined(this.notificationsList); <del> // Make visible and focus first notificationsList.show(true /* focus */); </del> <ins> // Make visible notificationsList.show(); // Focus first </ins> notificationsList.focusFirst(); return; // already visible", "commid": "vscode_pr_188973"}], "negative_passages": []}
{"query_id": "q-en-vscode-3264427872058f981b3aba5683e498e4f676c17083bdd63172525e3e8546ff13", "query": "Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?\nMy notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.\nthe looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated", "positive_passages": [{"docid": "doc-en-vscode-b195a9b98e80890c980cc6d12007d5d17708c1edd5753f30f02e7902e63f7f03", "text": "import { NotificationsListDelegate, NotificationRenderer } from 'vs/workbench/browser/parts/notifications/notificationsViewer'; import { CopyNotificationMessageAction } from 'vs/workbench/browser/parts/notifications/notificationsActions'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; <del> import { assertIsDefined, assertAllDefined } from 'vs/base/common/types'; </del> <ins> import { assertAllDefined } from 'vs/base/common/types'; </ins> import { NotificationFocusedContext } from 'vs/workbench/common/contextkeys'; import { Disposable } from 'vs/base/common/lifecycle'; import { AriaRole } from 'vs/base/browser/ui/aria/aria';", "commid": "vscode_pr_188973"}], "negative_passages": []}
{"query_id": "q-en-vscode-3264427872058f981b3aba5683e498e4f676c17083bdd63172525e3e8546ff13", "query": "Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?\nMy notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.\nthe looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated", "positive_passages": [{"docid": "doc-en-vscode-eb0031e9fadb3bbe4e030d7c271ebe670135e3687174d5cc00e7d8c974a155ab", "text": "super(); } <del> show(focus?: boolean): void { </del> <ins> show(): void { </ins> if (this.isVisible) { <del> if (focus) { const list = assertIsDefined(this.list); list.domFocus(); } </del> return; // already visible }", "commid": "vscode_pr_188973"}], "negative_passages": []}
{"query_id": "q-en-vscode-3264427872058f981b3aba5683e498e4f676c17083bdd63172525e3e8546ff13", "query": "Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?\nMy notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.\nthe looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated", "positive_passages": [{"docid": "doc-en-vscode-b7f3e6d47d285dad43f0a9b7ec50016e580f727aba8364af68d83ca332f43c85", "text": "// Make visible this.isVisible = true; <del> // Focus if (focus) { const list = assertIsDefined(this.list); list.domFocus(); } </del> } private createNotificationsList(): void {", "commid": "vscode_pr_188973"}], "negative_passages": []}
{"query_id": "q-en-vscode-3264427872058f981b3aba5683e498e4f676c17083bdd63172525e3e8546ff13", "query": "Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?\nMy notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.\nthe looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated", "positive_passages": [{"docid": "doc-en-vscode-fedd75f9172a6d6fc8da4bce5fa7894b4edeb0ba5bc04b39f7c01dede229a120", "text": "} focusFirst(): void { <del> if (!this.isVisible || !this.list) { return; // hidden </del> <ins> if (!this.list) { return; // not created yet </ins> } this.list.focusFirst();", "commid": "vscode_pr_188973"}], "negative_passages": []}
{"query_id": "q-en-vscode-3264427872058f981b3aba5683e498e4f676c17083bdd63172525e3e8546ff13", "query": "Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?\nMy notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.\nthe looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated", "positive_passages": [{"docid": "doc-en-vscode-5362e0c4cae0d0c211f89e6a34f2d6ba57dee7c97251f163315f876c713e4e57", "text": "} hasFocus(): boolean { <del> if (!this.isVisible || !this.listContainer) { return false; // hidden </del> <ins> if (!this.listContainer) { return false; // not created yet </ins> } return isAncestor(document.activeElement, this.listContainer);", "commid": "vscode_pr_188973"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e3590a2603f950e5cb488560456c5ed8f9ede729adf7ef86141758b1fecef81", "query": "a md file: between the html elements bug This inserts markdown syntax even though markdown typically isn't supported inside of html like this:\nLikely requires a proper markdown parser to fix\nI don't know if this is the expected result, since I don't see any difference pasting in the tags. I tried using two versions of .\nThanks for testing. I think there's still a bug with . In this case it should likely not paste as a markdown link. Somewhat weird case because it's the pasting itself that makes the html span multiple lines. With the newlines it's two entirely separate html blocks according to markdown", "positive_passages": [{"docid": "doc-en-vscode-53cf6ac67afacd1dfbbafaea9b846740031c1f9de77cb803bb85eb3b35c0ba9e", "text": "} } <ins> const textTokenTypes = new Set(['paragraph_open', 'inline', 'heading_open', 'ordered_list_open', 'bullet_list_open', 'list_item_open', 'blockquote_open']); </ins> async function shouldSmartPasteForSelection( parser: IMdParser, document: ITextDocument,", "commid": "vscode_pr_203476"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e3590a2603f950e5cb488560456c5ed8f9ede729adf7ef86141758b1fecef81", "query": "a md file: between the html elements bug This inserts markdown syntax even though markdown typically isn't supported inside of html like this:\nLikely requires a proper markdown parser to fix\nI don't know if this is the expected result, since I don't see any difference pasting in the tags. I tried using two versions of .\nThanks for testing. I think there's still a bug with . In this case it should likely not paste as a markdown link. Somewhat weird case because it's the pasting itself that makes the html span multiple lines. With the newlines it's two entirely separate html blocks according to markdown", "positive_passages": [{"docid": "doc-en-vscode-3deff7abfcf244c2010e10908147fc40496a1a56d1cd0ad4855ba8c371b93f27", "text": "if (token.isCancellationRequested) { return false; } <del> for (const token of tokens) { if (token.map && token.map[0] <= selectedRange.start.line && token.map[1] > selectedRange.start.line) { if (!['paragraph_open', 'inline', 'heading_open', 'ordered_list_open', 'bullet_list_open', 'list_item_open', 'blockquote_open'].includes(token.type)) { </del> <ins> for (let i = 0; i < tokens.length; i++) { const token = tokens[i]; if (!token.map) { continue; } if (token.map[0] <= selectedRange.start.line && token.map[1] > selectedRange.start.line) { if (!textTokenTypes.has(token.type)) { return false; } } // Special case for html such as: // // <b> // | // </b> // // In this case pasting will cause the html block to be created even though the cursor is not currently inside a block if (token.type === 'html_block' && token.map[1] === selectedRange.start.line) { const nextToken = tokens.at(i + 1); // The next token does not need to be a html_block, but it must be on the next line if (nextToken?.map?.[0] === selectedRange.end.line + 1) { </ins> return false; } }", "commid": "vscode_pr_203476"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e3590a2603f950e5cb488560456c5ed8f9ede729adf7ef86141758b1fecef81", "query": "a md file: between the html elements bug This inserts markdown syntax even though markdown typically isn't supported inside of html like this:\nLikely requires a proper markdown parser to fix\nI don't know if this is the expected result, since I don't see any difference pasting in the tags. I tried using two versions of .\nThanks for testing. I think there's still a bug with . In this case it should likely not paste as a markdown link. Somewhat weird case because it's the pasting itself that makes the html span multiple lines. With the newlines it's two entirely separate html blocks according to markdown", "positive_passages": [{"docid": "doc-en-vscode-aabd82a1d0c0bb136fae1a23e247f0d14eed4896e954d67087fb234afbd586e7", "text": "<del> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; import 'mocha'; import * as vscode from 'vscode'; import { InMemoryDocument } from '../client/inMemoryDocument'; import { PasteUrlAsMarkdownLink, findValidUriInText, shouldInsertMarkdownLinkByDefault } from '../languageFeatures/copyFiles/pasteUrlProvider'; import { createInsertUriListEdit } from '../languageFeatures/copyFiles/shared'; import { createNewMarkdownEngine } from './engine'; import { noopToken } from '../util/cancellation'; function makeTestDoc(contents: string) { return new InMemoryDocument(vscode.Uri.file('test.md'), contents); } suite('createEditAddingLinksForUriList', () => { test('Markdown Link Pasting should occur for a valid link (end to end)', async () => { // createEditAddingLinksForUriList -> checkSmartPaste -> tryGetUriListSnippet -> createUriListSnippet -> createLinkSnippet const result = createInsertUriListEdit( new InMemoryDocument(vscode.Uri.file('test.md'), 'hello world!'), [new vscode.Range(0, 0, 0, 12)], 'https://www.microsoft.com/'); // need to check the actual result -> snippet value assert.strictEqual(result?.label, 'Insert Markdown Link'); }); suite('validateLink', () => { test('Markdown pasting should occur for a valid link', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/'), 'https://www.microsoft.com/'); }); test('Markdown pasting should occur for a valid link preceded by a new line', () => { assert.strictEqual( findValidUriInText('rnhttps://www.microsoft.com/'), 'https://www.microsoft.com/'); }); test('Markdown pasting should occur for a valid link followed by a new line', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/rn'), 'https://www.microsoft.com/'); }); test('Markdown pasting should not occur for a valid hostname and invalid protool', () => { assert.strictEqual( findValidUriInText('invalid:www.microsoft.com'), undefined); }); test('Markdown pasting should not occur for plain text', () => { assert.strictEqual( findValidUriInText('hello world!'), undefined); }); test('Markdown pasting should not occur for plain text including a colon', () => { assert.strictEqual( findValidUriInText('hello: world!'), undefined); }); test('Markdown pasting should not occur for plain text including a slashes', () => { assert.strictEqual( findValidUriInText('helloworld!'), undefined); }); test('Markdown pasting should not occur for a link followed by text', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/ hello world!'), undefined); }); test('Markdown pasting should occur for a link preceded or followed by spaces', () => { assert.strictEqual( findValidUriInText('     https://www.microsoft.com/     '), 'https://www.microsoft.com/'); }); test('Markdown pasting should not occur for a link with an invalid scheme', () => { assert.strictEqual( findValidUriInText('hello:www.microsoft.com'), undefined); }); test('Markdown pasting should not occur for multiple links being pasted', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/rnhttps://www.microsoft.com/rnhttps://www.microsoft.com/rnhttps://www.microsoft.com/'), undefined); }); test('Markdown pasting should not occur for multiple links with spaces being pasted', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/    rnhttps://www.microsoft.com/rnhttps://www.microsoft.com/rn hello rnhttps://www.microsoft.com/'), undefined); }); test('Markdown pasting should not occur for just a valid uri scheme', () => { assert.strictEqual( findValidUriInText('https://'), undefined); }); }); suite('createInsertUriListEdit', () => { test('Should create snippet with < > when pasted link has an mismatched parentheses', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.mic(rosoft.com'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](<https://www.mic(rosoft.com>)'); }); test('Should create Markdown link snippet when pasteAsMarkdownLink is true', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.microsoft.com'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.microsoft.com)'); }); test('Should use an unencoded URI string in Markdown link when passing in an external browser link', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.microsoft.com'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.microsoft.com)'); }); test('Should not decode an encoded URI string when passing in an external browser link', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.microsoft.com/%20'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.microsoft.com/%20)'); }); test('Should not encode an unencoded URI string when passing in an external browser link', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.example.com/path?query=value&another=value#fragment'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.example.com/path?query=value&another=value#fragment)'); }); }); suite('shouldInsertMarkdownLinkByDefault', () => { test('Smart should be enabled for selected plain text', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('hello world'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 12)], noopToken), true); }); test('Smart should be enabled in headers', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('# title'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 2, 0, 2)], noopToken), true); }); test('Smart should be enabled in lists', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('1. text'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 3, 0, 3)], noopToken), true); }); test('Smart should be enabled in blockquotes', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('> text'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 3, 0, 3)], noopToken), true); }); test('Smart should be disabled in indented code blocks', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('    code'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 4, 0, 4)], noopToken), false); }); test('Smart should be disabled in fenced code blocks', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('```rnrn```'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 5)], noopToken), false); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('~~~rnrn~~~'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 5)], noopToken), false); }); test('Smart should be disabled in math blocks', async () => { const katex = (await import('@vscode/markdown-it-katex')).default; const engine = createNewMarkdownEngine(); (await engine.getEngine(undefined)).use(katex); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(engine, makeTestDoc('$$rnrn$$'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 5)], noopToken), false); }); test('Smart should be disabled in link definitions', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[ref]: http://example.com'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 4, 0, 6)], noopToken), false); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[ref]: '), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 7, 0, 7)], noopToken), false); }); test('Smart should be disabled in html blocks', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('<p>nan</p>'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(1, 0, 1, 0)], noopToken), false); }); test('Smart should be disabled in Markdown links', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[a](bcdef)'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 4, 0, 6)], noopToken), false); }); test('Smart should be disabled in Markdown images', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('![a](bcdef)'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 10)], noopToken), false); }); test('Smart should be disabled in inline code', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('``'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 1, 0, 1)], noopToken), false); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('``'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 0, 0, 0)], noopToken), false); }); test('Smart should be disabled in inline math', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('$$'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 1, 0, 1)], noopToken), false); }); test('Smart should be enabled for empty selection', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('xyz'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 0, 0, 0)], noopToken), true); }); test('SmartWithSelection should disable for empty selection', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('xyz'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 0)], noopToken), false); }); test('Smart should disable for selected link', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('https://www.microsoft.com'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 25)], noopToken), false); }); test('Smart should disable for selected link with trailing whitespace', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('   https://www.microsoft.com  '), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 30)], noopToken), false); }); test('Should evaluate pasteAsMarkdownLink as true for a link pasted in square brackets', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[abc]'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 1, 0, 4)], noopToken), true); }); test('Should evaluate pasteAsMarkdownLink as false for selected whitespace and new lines', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('   rnrn'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 7)], noopToken), false); }); }); }); </del>", "commid": "vscode_pr_203476"}], "negative_passages": []}
{"query_id": "q-en-vscode-5e3590a2603f950e5cb488560456c5ed8f9ede729adf7ef86141758b1fecef81", "query": "a md file: between the html elements bug This inserts markdown syntax even though markdown typically isn't supported inside of html like this:\nLikely requires a proper markdown parser to fix\nI don't know if this is the expected result, since I don't see any difference pasting in the tags. I tried using two versions of .\nThanks for testing. I think there's still a bug with . In this case it should likely not paste as a markdown link. Somewhat weird case because it's the pasting itself that makes the html span multiple lines. With the newlines it's two entirely separate html blocks according to markdown", "positive_passages": [{"docid": "doc-en-vscode-fafde711d76c883aed05342af9865141d0ac7a22c70ef526bb77ab9ce1dce484", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; import 'mocha'; import * as vscode from 'vscode'; import { InMemoryDocument } from '../client/inMemoryDocument'; import { PasteUrlAsMarkdownLink, findValidUriInText, shouldInsertMarkdownLinkByDefault } from '../languageFeatures/copyFiles/pasteUrlProvider'; import { createInsertUriListEdit } from '../languageFeatures/copyFiles/shared'; import { createNewMarkdownEngine } from './engine'; import { noopToken } from '../util/cancellation'; function makeTestDoc(contents: string) { return new InMemoryDocument(vscode.Uri.file('test.md'), contents); } suite('createEditAddingLinksForUriList', () => { test('Markdown Link Pasting should occur for a valid link (end to end)', async () => { // createEditAddingLinksForUriList -> checkSmartPaste -> tryGetUriListSnippet -> createUriListSnippet -> createLinkSnippet const result = createInsertUriListEdit( new InMemoryDocument(vscode.Uri.file('test.md'), 'hello world!'), [new vscode.Range(0, 0, 0, 12)], 'https://www.microsoft.com/'); // need to check the actual result -> snippet value assert.strictEqual(result?.label, 'Insert Markdown Link'); }); suite('validateLink', () => { test('Markdown pasting should occur for a valid link', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/'), 'https://www.microsoft.com/'); }); test('Markdown pasting should occur for a valid link preceded by a new line', () => { assert.strictEqual( findValidUriInText('rnhttps://www.microsoft.com/'), 'https://www.microsoft.com/'); }); test('Markdown pasting should occur for a valid link followed by a new line', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/rn'), 'https://www.microsoft.com/'); }); test('Markdown pasting should not occur for a valid hostname and invalid protool', () => { assert.strictEqual( findValidUriInText('invalid:www.microsoft.com'), undefined); }); test('Markdown pasting should not occur for plain text', () => { assert.strictEqual( findValidUriInText('hello world!'), undefined); }); test('Markdown pasting should not occur for plain text including a colon', () => { assert.strictEqual( findValidUriInText('hello: world!'), undefined); }); test('Markdown pasting should not occur for plain text including a slashes', () => { assert.strictEqual( findValidUriInText('helloworld!'), undefined); }); test('Markdown pasting should not occur for a link followed by text', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/ hello world!'), undefined); }); test('Markdown pasting should occur for a link preceded or followed by spaces', () => { assert.strictEqual( findValidUriInText('     https://www.microsoft.com/     '), 'https://www.microsoft.com/'); }); test('Markdown pasting should not occur for a link with an invalid scheme', () => { assert.strictEqual( findValidUriInText('hello:www.microsoft.com'), undefined); }); test('Markdown pasting should not occur for multiple links being pasted', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/rnhttps://www.microsoft.com/rnhttps://www.microsoft.com/rnhttps://www.microsoft.com/'), undefined); }); test('Markdown pasting should not occur for multiple links with spaces being pasted', () => { assert.strictEqual( findValidUriInText('https://www.microsoft.com/    rnhttps://www.microsoft.com/rnhttps://www.microsoft.com/rn hello rnhttps://www.microsoft.com/'), undefined); }); test('Markdown pasting should not occur for just a valid uri scheme', () => { assert.strictEqual( findValidUriInText('https://'), undefined); }); }); suite('createInsertUriListEdit', () => { test('Should create snippet with < > when pasted link has an mismatched parentheses', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.mic(rosoft.com'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](<https://www.mic(rosoft.com>)'); }); test('Should create Markdown link snippet when pasteAsMarkdownLink is true', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.microsoft.com'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.microsoft.com)'); }); test('Should use an unencoded URI string in Markdown link when passing in an external browser link', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.microsoft.com'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.microsoft.com)'); }); test('Should not decode an encoded URI string when passing in an external browser link', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.microsoft.com/%20'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.microsoft.com/%20)'); }); test('Should not encode an unencoded URI string when passing in an external browser link', () => { const edit = createInsertUriListEdit(makeTestDoc(''), [new vscode.Range(0, 0, 0, 0)], 'https://www.example.com/path?query=value&another=value#fragment'); assert.strictEqual(edit?.edits?.[0].snippet.value, '[${1:text}](https://www.example.com/path?query=value&another=value#fragment)'); }); }); suite('shouldInsertMarkdownLinkByDefault', () => { test('Smart should be enabled for selected plain text', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('hello world'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 12)], noopToken), true); }); test('Smart should be enabled in headers', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('# title'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 2, 0, 2)], noopToken), true); }); test('Smart should be enabled in lists', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('1. text'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 3, 0, 3)], noopToken), true); }); test('Smart should be enabled in blockquotes', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('> text'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 3, 0, 3)], noopToken), true); }); test('Smart should be disabled in indented code blocks', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('    code'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 4, 0, 4)], noopToken), false); }); test('Smart should be disabled in fenced code blocks', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('```rnrn```'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 5)], noopToken), false); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('~~~rnrn~~~'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 5)], noopToken), false); }); test('Smart should be disabled in math blocks', async () => { const katex = (await import('@vscode/markdown-it-katex')).default; const engine = createNewMarkdownEngine(); (await engine.getEngine(undefined)).use(katex); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(engine, makeTestDoc('$$rnrn$$'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 5)], noopToken), false); }); test('Smart should be disabled in link definitions', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[ref]: http://example.com'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 4, 0, 6)], noopToken), false); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[ref]: '), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 7, 0, 7)], noopToken), false); }); test('Smart should be disabled in html blocks', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('<p>nan</p>'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(1, 0, 1, 0)], noopToken), false); }); test('Smart should be disabled in html blocks where paste creates the block', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('<p>nn</p>'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(1, 0, 1, 0)], noopToken), false, 'Between two html tags should be treated as html block'); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('<p>nntext'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(1, 0, 1, 0)], noopToken), false, 'Between opening html tag and text should be treated as html block'); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('<p>nnn</p>'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(1, 0, 1, 0)], noopToken), true, 'Extra new line after paste should not be treated as html block'); }); test('Smart should be disabled in Markdown links', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[a](bcdef)'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 4, 0, 6)], noopToken), false); }); test('Smart should be disabled in Markdown images', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('![a](bcdef)'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 5, 0, 10)], noopToken), false); }); test('Smart should be disabled in inline code', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('``'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 1, 0, 1)], noopToken), false); assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('``'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 0, 0, 0)], noopToken), false); }); test('Smart should be disabled in inline math', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('$$'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 1, 0, 1)], noopToken), false); }); test('Smart should be enabled for empty selection', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('xyz'), PasteUrlAsMarkdownLink.Smart, [new vscode.Range(0, 0, 0, 0)], noopToken), true); }); test('SmartWithSelection should disable for empty selection', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('xyz'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 0)], noopToken), false); }); test('Smart should disable for selected link', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('https://www.microsoft.com'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 25)], noopToken), false); }); test('Smart should disable for selected link with trailing whitespace', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('   https://www.microsoft.com  '), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 30)], noopToken), false); }); test('Should evaluate pasteAsMarkdownLink as true for a link pasted in square brackets', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('[abc]'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 1, 0, 4)], noopToken), true); }); test('Should evaluate pasteAsMarkdownLink as false for selected whitespace and new lines', async () => { assert.strictEqual( await shouldInsertMarkdownLinkByDefault(createNewMarkdownEngine(), makeTestDoc('   rnrn'), PasteUrlAsMarkdownLink.SmartWithSelection, [new vscode.Range(0, 0, 0, 7)], noopToken), false); }); }); }); </ins>", "commid": "vscode_pr_203476"}], "negative_passages": []}
{"query_id": "q-en-vscode-8c5c6d1e8fee1c98bcbc0cbc9bb7de9f86eeae7070041dfb62326405babb4048", "query": "I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.\nI am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations\nI have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.\nThanks for the fix. Using is the right thing here.", "positive_passages": [{"docid": "doc-en-vscode-801259d4b82e94090b65139bf070cdb5ad937d7d115f211a2870f54e7a2982b2", "text": "import { resolveMarketplaceHeaders } from 'vs/platform/externalServices/common/marketplace'; import { IStorageService } from 'vs/platform/storage/common/storage'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <ins> import { StopWatch } from 'vs/base/common/stopwatch'; </ins> const CURRENT_TARGET_PLATFORM = isWeb ? TargetPlatform.WEB : getTargetPlatform(platform, arch); const ACTIVITY_HEADER_NAME = 'X-Market-Search-Activity-Id';", "commid": "vscode_pr_190595"}], "negative_passages": []}
{"query_id": "q-en-vscode-8c5c6d1e8fee1c98bcbc0cbc9bb7de9f86eeae7070041dfb62326405babb4048", "query": "I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.\nI am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations\nI have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.\nThanks for the fix. Using is the right thing here.", "positive_passages": [{"docid": "doc-en-vscode-64ec1e47dd83b024e1bac908347ccb539cc177e662a8d338ec8b1c4caa228277", "text": "} if (needAllVersions.size) { <del> const startTime = new Date().getTime(); </del> <ins> const stopWatch = new StopWatch(); </ins> const query = new Query() .withFlags(flags & ~Flags.IncludeLatestVersionOnly, Flags.IncludeVersions) .withPage(1, needAllVersions.size) .withFilter(FilterType.ExtensionId, ...needAllVersions.keys()); const { extensions } = await this.queryGalleryExtensions(query, criteria, token); this.telemetryService.publicLog2<GalleryServiceAdditionalQueryEvent, GalleryServiceAdditionalQueryClassification>('galleryService:additionalQuery', { <del> duration: new Date().getTime() - startTime, </del> <ins> duration: stopWatch.elapsed(), </ins> count: needAllVersions.size }); for (const extension of extensions) {", "commid": "vscode_pr_190595"}], "negative_passages": []}
{"query_id": "q-en-vscode-8c5c6d1e8fee1c98bcbc0cbc9bb7de9f86eeae7070041dfb62326405babb4048", "query": "I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.\nI am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations\nI have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.\nThanks for the fix. Using is the right thing here.", "positive_passages": [{"docid": "doc-en-vscode-8c7758ba2feaa0e305d23dc691632cfd1897f9d270e780ede9489d248c410d75", "text": "'Content-Length': String(data.length), }; <del> const startTime = new Date().getTime(); </del> <ins> const stopWatch = new StopWatch(); </ins> let context: IRequestContext | undefined, error: any, total: number = 0; try {", "commid": "vscode_pr_190595"}], "negative_passages": []}
{"query_id": "q-en-vscode-8c5c6d1e8fee1c98bcbc0cbc9bb7de9f86eeae7070041dfb62326405babb4048", "query": "I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.\nI am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations\nI have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.\nThanks for the fix. Using is the right thing here.", "positive_passages": [{"docid": "doc-en-vscode-70c688729d9296d4934801e2a6b820a2ae0cc83d97d6e1b9ce442c0499339f0c", "text": "this.telemetryService.publicLog2<GalleryServiceQueryEvent, GalleryServiceQueryClassification>('galleryService:query', { ...query.telemetryData, requestBodySize: String(data.length), <del> duration: new Date().getTime() - startTime, </del> <ins> duration: stopWatch.elapsed(), </ins> success: !!context && isSuccess(context), responseBodySize: context?.res.headers['Content-Length'], statusCode: context ? String(context.res.statusCode) : undefined,", "commid": "vscode_pr_190595"}], "negative_passages": []}
{"query_id": "q-en-vscode-1f9597c016a777ae7ca006363d28931ef8b2c26beed843804ec6f3a5a4aa10e3", "query": "Type: <bBug</bOn Mac, in terminal, press Option+F1. It says: Go to Next Command (Command+DownArrow) Go to Previous Command (Command+UpArrow) This has been recently updated as: Option+Up/DownArrows. VS Code version: Code - Insiders 1.81.0-insider (Universal) (, 2023-07-28T12:09:45.183Z) OS version: Darwin arm64 22.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (90)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 dscodegpt2.1.15 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.294 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 chatgpt1.1.2 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nYes reported this, but I cannot find that issue, so we'll track it here. This is because of this line", "positive_passages": [{"docid": "doc-en-vscode-788c19b9ffbfc4af233557a352f4b580f52dd0d78ebc9a2e459ba02c6e871938", "text": "} } <del> this._currentContent = message + provider.provideContent() + readMoreLink + disableHelpHint + localize('exit-tip', 'nnExit this dialog via the Escape key.'); </del> <ins> this._currentContent = message + provider.provideContent() + readMoreLink + disableHelpHint + localize('exit-tip', 'nExit this dialog via the Escape key.'); </ins> this._updateContextKeys(provider, true); this._getTextModel(URI.from({ path: `accessible-view-${provider.verbositySettingKey}`, scheme: 'accessible-view', fragment: this._currentContent })).then((model) => {", "commid": "vscode_pr_191329"}], "negative_passages": []}
{"query_id": "q-en-vscode-1f9597c016a777ae7ca006363d28931ef8b2c26beed843804ec6f3a5a4aa10e3", "query": "Type: <bBug</bOn Mac, in terminal, press Option+F1. It says: Go to Next Command (Command+DownArrow) Go to Previous Command (Command+UpArrow) This has been recently updated as: Option+Up/DownArrows. VS Code version: Code - Insiders 1.81.0-insider (Universal) (, 2023-07-28T12:09:45.183Z) OS version: Darwin arm64 22.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (90)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 dscodegpt2.1.15 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.294 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 chatgpt1.1.2 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nYes reported this, but I cannot find that issue, so we'll track it here. This is because of this line", "positive_passages": [{"docid": "doc-en-vscode-1968aedbcd49959320380073405135f55c7b86ae2c91e8f88aa0db7630c517bb", "text": "_xterm: Pick<IXtermTerminal, 'getFont' | 'shellIntegration'> & { raw: Terminal }, @IInstantiationService _instantiationService: IInstantiationService, @IKeybindingService private readonly _keybindingService: IKeybindingService, <del> @IAccessibilityService private readonly _accessibilityService: IAccessibilityService, </del> @IContextKeyService private readonly _contextKeyService: IContextKeyService, <del> @ICommandService private readonly _commandService: ICommandService </del> <ins> @ICommandService private readonly _commandService: ICommandService, @IAccessibilityService private readonly _accessibilityService: IAccessibilityService </ins> ) { super(); this._hasShellIntegration = _xterm.shellIntegration.status === ShellIntegrationStatus.VSCode; } private _descriptionForCommand(commandId: string, msg: string, noKbMsg: string): string { <del> const kb = this._keybindingService.lookupKeybindings(commandId); switch (kb.length) { case 0: return format(noKbMsg, commandId); case 1: return format(msg, kb[0].getAriaLabel()); </del> <ins> if (commandId === TerminalCommandId.RunRecentCommand) { const kb = this._keybindingService.lookupKeybindings(commandId); // Run recent command has multiple keybindings. lookupKeybinding just returns the first one regardless of the when context. // Thus, we have to check if accessibility mode is enabled to determine which keybinding to use. return this._accessibilityService.isScreenReaderOptimized() ? format(msg, kb[1].getAriaLabel()) : format(msg, kb[0].getAriaLabel()); </ins> } <del> // Run recent command has multiple keybindings. lookupKeybinding just returns the first one regardless of the when context. // Thus, we have to check if accessibility mode is enabled to determine which keybinding to use. return this._accessibilityService.isScreenReaderOptimized() ? format(msg, kb[1].getAriaLabel()) : format(msg, kb[0].getAriaLabel()); </del> <ins> const kb = this._keybindingService.lookupKeybinding(commandId, this._contextKeyService)?.getAriaLabel(); return !kb ? format(noKbMsg, commandId) : format(msg, kb); </ins> } provideContent(): string {", "commid": "vscode_pr_191329"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-50b174417338e58a0a1eb139873483eee709854dd1503d809c2cb358a4df30d0", "text": "import { getNotificationFromContext } from 'vs/workbench/browser/parts/notifications/notificationsCommands'; import { IListService, WorkbenchList } from 'vs/platform/list/browser/listService'; import { NotificationFocusedContext } from 'vs/workbench/common/contextkeys'; <del> import { IAccessibleViewService, AccessibleViewService, IAccessibleContentProvider, IAccessibleViewOptions, AccessibleViewType, accessibleViewIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; </del> <ins> import { IAccessibleViewService, AccessibleViewService, IAccessibleContentProvider, IAccessibleViewOptions, AccessibleViewType } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; </ins> import { IHoverService } from 'vs/workbench/services/hover/browser/hover'; import { alert } from 'vs/base/browser/ui/aria/aria';", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-76eb602c58f6ca0dfef670c9225cf5be0ff449d399fda3e516f7df3b63c9a9e4", "text": "const accessibleViewService = accessor.get(IAccessibleViewService); accessibleViewService.next(); return true; <del> }, accessibleViewIsShown)); </del> <ins> })); </ins> this._register(AccessibleViewPreviousAction.addImplementation(95, 'previous', accessor => { const accessibleViewService = accessor.get(IAccessibleViewService); accessibleViewService.previous(); return true; <del> }, accessibleViewIsShown)); </del> <ins> })); </ins> } }", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-e6691f3871bbb67b293176017ddcb9aea375483edc8b1893344448bb8a9a5641", "text": "import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { MenuId } from 'vs/platform/actions/common/actions'; <ins> import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; export const accessibilityHelpIsShown = new RawContextKey<boolean>('accessibilityHelpIsShown', false, true); export const accessibleViewIsShown = new RawContextKey<boolean>('accessibleViewIsShown', false, true); </ins> export const enum AccessibilityVerbositySettingId { Terminal = 'accessibility.verbosity.terminal',", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-d99da5da9199c039b5f79d927e309bdf60cb5401fbb83af4cc5e6d6b9853150e", "text": "export const AccessibleViewNextAction = registerCommand(new MultiCommand({ id: 'editor.action.accessibleViewNext', <del> precondition: undefined, </del> <ins> precondition: accessibleViewIsShown, </ins> kbOpts: { primary: KeyMod.Alt | KeyCode.BracketRight, weight: KeybindingWeight.WorkbenchContrib", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-d9a7705f53973a285e08ed076dd38d846cb5ba8273d375fac4a1950eecca470c", "text": "export const AccessibleViewPreviousAction = registerCommand(new MultiCommand({ id: 'editor.action.accessibleViewPrevious', <del> precondition: undefined, </del> <ins> precondition: accessibleViewIsShown, </ins> kbOpts: { primary: KeyMod.Alt | KeyCode.BracketLeft, weight: KeybindingWeight.WorkbenchContrib", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-05897fdf589a825c184ae47cd4dbbb4e3b7b9349b750e1148d251911bd471e36", "text": "import { localize } from 'vs/nls'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; <del> import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; </del> <ins> import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> import { IContextViewDelegate, IContextViewService } from 'vs/platform/contextview/browser/contextView'; import { IInstantiationService, createDecorator } from 'vs/platform/instantiation/common/instantiation'; import { IOpenerService } from 'vs/platform/opener/common/opener';", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-3328c23433d641a663e945557a86cae0b391357958617e9ffd3ab53838ba92c5", "text": "import { getSimpleEditorOptions } from 'vs/workbench/contrib/codeEditor/browser/simpleEditorOptions'; import { CodeActionController } from 'vs/editor/contrib/codeAction/browser/codeActionController'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; <del> import { AccessibilityVerbositySettingId, AccessibleViewAction, AccessibleViewNextAction, AccessibleViewPreviousAction } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution'; </del> <ins> import { AccessibilityVerbositySettingId, AccessibleViewAction, AccessibleViewNextAction, AccessibleViewPreviousAction, accessibilityHelpIsShown, accessibleViewIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution'; </ins> import { ILayoutService } from 'vs/platform/layout/browser/layoutService'; const enum DIMENSIONS {", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-e4f8ee7f90ace168db36a0baa2cf29826e4c607dd0b01cd83bc89cc28dd30200", "text": "type: AccessibleViewType; } <del> export const accessibilityHelpIsShown = new RawContextKey<boolean>('accessibilityHelpIsShown', false, true); export const accessibleViewIsShown = new RawContextKey<boolean>('accessibleViewIsShown', false, true); </del> class AccessibleView extends Disposable { private _editorWidget: CodeEditorWidget; private _accessiblityHelpIsShown: IContextKey<boolean>;", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-0ec5e90d0da4f19dbf80923af86da866d5b91847144ef2aaf3afd2cbd4e7d69c", "query": "Type: <bBug</bIn editor, I can't use and alt+[` do not have specific \"when\" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-1141e8b1e9decaca75f3c0fa48a86f89aa44e5cfe2cf5249309fd4a0002e1ee7", "text": "import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { Action2, registerAction2 } from 'vs/platform/actions/common/actions'; <del> import { accessibilityHelpIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; </del> <ins> import { accessibilityHelpIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution'; </ins> import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { alert } from 'vs/base/browser/ui/aria/aria';", "commid": "vscode_pr_189317"}], "negative_passages": []}
{"query_id": "q-en-vscode-4a320aff411b7422c9aa446360dfb02e89617720f5b2824e39f39b2ce7cc3a1d", "query": "When exporting a profile, a SR user has to navigate the whole list to reach the button. We should either move the button to the top or have a keybinding/command which does this. cc <img width=\"293\" alt=\"Screenshot 2023-07-31 at 11 30 34 AM\" src=\"\"\nIs not the tab should take to Export button when the complete tree is focused instead of focusing the check box?\nI'm not following\nTry to get into the state where Tree is focused not any of the elements of the Tree. For eg: <img width=\"662\" alt=\"image\" src=\"\"See the outline focusing the tree. Press <tabnow. This should focus the Export button right?\ncorrect - pressing tab when my screen looks like the above causes focus to be lost rather than going to the button.\nTab at this state is taking focus to the checkbox in the tree. IMO checkbox should be focused when the row is focused and you tab then. Is it possible to change this behaviour?", "positive_passages": [{"docid": "doc-en-vscode-5577d48a7907a7559d15b6a92cb2515854cf7cf3c010104b78e93786b517ad45", "text": "this.setHover(node.checkbox); this.setAccessibilityInformation(node.checkbox); this.toggle.domNode.classList.add(TreeItemCheckbox.checkboxClass); <ins> this.toggle.domNode.tabIndex = 1; </ins> DOM.append(this.checkboxContainer, this.toggle.domNode); this.registerListener(node); }", "commid": "vscode_pr_192413"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8ca427bd04e8840f3540c7359e7eaecdf34e00106bcbdf9f0cf5cf5ef32ac1c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --I have multiple profiles in VS Code and I disable everything I don't need in each of them, including built-in extensions that I will never use with a particular profile. After the successful installation of the latest version I wanted to try the new option; while it works for user-installed extensions, it fails for built-in extensions, read more below. Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: , 22H2 (.2070) Steps to Reproduce: the extensions view built-in extensions only the cog icon on any (enabled) extension on error will occur (see attached screenshot) <div align=\"center\"<img src=\"\" alt=\"Error in VS Code\"</div<brNote: all extensions are present at the provided folder shown in the error message.\nSame for me but on MacOS Ventura 13.5 (22G74)\nCan you see if the extension is maybe uninstalled when you follow your steps? That could hint to\n/duplicate\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nUnfortunately the latest patch release: and the mentioned didn't fix it, here's the error screenshot again, in the latest version. Also, I've opened the folder itself where the extension is located, while VS Code complains it doesn't exist. <div align=\"center\"<img src=\"\" alt=\"Error in VS Code\"</div\nThis action should not be shown on builtin extensions because they are available for all profiles by default.", "positive_passages": [{"docid": "doc-en-vscode-037f1bb2922e2fe77c165b25b32acefd33f398fd2cf187afa17648ece4609210", "text": "} async toggleAppliationScope(extension: ILocalExtension, fromProfileLocation: URI): Promise<ILocalExtension> { <del> if (isApplicationScopedExtension(extension.manifest)) { </del> <ins> if (isApplicationScopedExtension(extension.manifest) || extension.isBuiltin) { </ins> return extension; }", "commid": "vscode_pr_191209"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8ca427bd04e8840f3540c7359e7eaecdf34e00106bcbdf9f0cf5cf5ef32ac1c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --I have multiple profiles in VS Code and I disable everything I don't need in each of them, including built-in extensions that I will never use with a particular profile. After the successful installation of the latest version I wanted to try the new option; while it works for user-installed extensions, it fails for built-in extensions, read more below. Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: , 22H2 (.2070) Steps to Reproduce: the extensions view built-in extensions only the cog icon on any (enabled) extension on error will occur (see attached screenshot) <div align=\"center\"<img src=\"\" alt=\"Error in VS Code\"</div<brNote: all extensions are present at the provided folder shown in the error message.\nSame for me but on MacOS Ventura 13.5 (22G74)\nCan you see if the extension is maybe uninstalled when you follow your steps? That could hint to\n/duplicate\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nUnfortunately the latest patch release: and the mentioned didn't fix it, here's the error screenshot again, in the latest version. Also, I've opened the folder itself where the extension is located, while VS Code complains it doesn't exist. <div align=\"center\"<img src=\"\" alt=\"Error in VS Code\"</div\nThis action should not be shown on builtin extensions because they are available for all profiles by default.", "positive_passages": [{"docid": "doc-en-vscode-56a9a7628fe737d415271dff8bf45499b86083c92b7d86a27fcda43b89faa7ef", "text": "menu: { id: MenuId.ExtensionContext, group: '2_configure', <del> when: ContextKeyExpr.and(ContextKeyExpr.equals('extensionStatus', 'installed'), ContextKeyExpr.has('isDefaultApplicationScopedExtension').negate()), </del> <ins> when: ContextKeyExpr.and(ContextKeyExpr.equals('extensionStatus', 'installed'), ContextKeyExpr.has('isDefaultApplicationScopedExtension').negate(), ContextKeyExpr.has('isBuiltinExtension').negate()), </ins> order: 3 }, run: async (accessor: ServicesAccessor, id: string) => {", "commid": "vscode_pr_191209"}], "negative_passages": []}
{"query_id": "q-en-vscode-f8ca427bd04e8840f3540c7359e7eaecdf34e00106bcbdf9f0cf5cf5ef32ac1c", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --I have multiple profiles in VS Code and I disable everything I don't need in each of them, including built-in extensions that I will never use with a particular profile. After the successful installation of the latest version I wanted to try the new option; while it works for user-installed extensions, it fails for built-in extensions, read more below. Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: , 22H2 (.2070) Steps to Reproduce: the extensions view built-in extensions only the cog icon on any (enabled) extension on error will occur (see attached screenshot) <div align=\"center\"<img src=\"\" alt=\"Error in VS Code\"</div<brNote: all extensions are present at the provided folder shown in the error message.\nSame for me but on MacOS Ventura 13.5 (22G74)\nCan you see if the extension is maybe uninstalled when you follow your steps? That could hint to\n/duplicate\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nUnfortunately the latest patch release: and the mentioned didn't fix it, here's the error screenshot again, in the latest version. Also, I've opened the folder itself where the extension is located, while VS Code complains it doesn't exist. <div align=\"center\"<img src=\"\" alt=\"Error in VS Code\"</div\nThis action should not be shown on builtin extensions because they are available for all profiles by default.", "positive_passages": [{"docid": "doc-en-vscode-277b4808e4bc24f10ecef6c20642056045c0a42aa24a8f9f06efe899204affbf", "text": "} async toggleApplyExtensionToAllProfiles(extension: IExtension): Promise<void> { <del> if (!extension.local || isApplicationScopedExtension(extension.local.manifest)) { </del> <ins> if (!extension.local || isApplicationScopedExtension(extension.local.manifest) || extension.isBuiltin) { </ins> return; } await this.extensionManagementService.toggleAppliationScope(extension.local, this.userDataProfileService.currentProfile.extensionsResource);", "commid": "vscode_pr_191209"}], "negative_passages": []}
{"query_id": "q-en-vscode-675414227f107a2c150aefd121272c46f698c38baec0a8b6391df12d7c498744", "query": "VS Code Version: 1.82.0-insider OS Version: Ubuntu 22.04 The path is missing the first character in the path for a specific file on the 'git show --textconv' lines 'ub-folder' vs 'sub-folder' If the command is run manually, with the correct path there are no issues Working (Non-root folder) 2023-08-03 19:10:33.264 [info] git show --textconv [4ms] 2023-08-03 19:10:33.267 [info] git ls-tree -l HEAD -- [4ms] Not Working (Root folder) 2023-08-03 19:12:26.351 [info] git show --textconv [20ms] 2023-08-03 19:12:26.386 [info] git ls-tree -l HEAD -- [35ms] Expected (Root folder) 2023-08-03 19:12:26.351 [info] git show --textconv [20ms] 2023-08-03 19:12:26.386 [info] git ls-tree -l HEAD -- [35ms] Originally posted by in\ncould you please share repro steps that I could use to reproduce this? Or the complete contents of the git output window would also help. I have a suspicion where the issue is but I need the logs to reproduce and fix the issue. Thanks!\nHello Ladislau Szomoru, open vsc go to Source Control (Ctrl+Shift+G) look under \"Staged Changes\" and click on notice left side is always empty and right side shows entire file changed. Thanks, Gregory Porras", "positive_passages": [{"docid": "doc-en-vscode-4a1c516fcfcc2c745215d91437573b43ee2e3e35e7a65c12cd7819aac98b926f", "text": "* Given the `repository.root` compute the relative path while trying to preserve * the casing of the resource URI. The `repository.root` segment of the path can * have a casing mismatch if the folder/workspace is being opened with incorrect <del> * casing. </del> <ins> * casing which is why we attempt to use substring() before relative(). </ins> */ export function relativePath(from: string, to: string): string { <del> // On Windows, there are cases in which `from` is a path that contains a trailing `` character // (ex: C:, serverfolder) due to the implementation of `path.normalize()`. This behavior is // by design as documented in https://github.com/nodejs/node/issues/1765. if (isWindows) { from = from.replace(/$/, ''); </del> <ins> // There are cases in which the `from` path may contain a trailing separator at // the end (ex: \"C:\", \"serverfolder\" (Windows) or \"/\" (Linux/macOS)) which // is by design as documented in https://github.com/nodejs/node/issues/1765. If // the trailing separator is missing, we add it. if (from.charAt(from.length - 1) !== sep) { from += sep; </ins> } if (isDescendant(from, to) && from.length < to.length) { <del> return to.substring(from.length + 1); </del> <ins> return to.substring(from.length); </ins> } // Fallback to `path.relative`", "commid": "vscode_pr_194653"}], "negative_passages": []}
{"query_id": "q-en-vscode-c85ca10952f0a7826830bd9b55e7c758f7e121927baf124ba9b2c522d85e0e48", "query": "hover over editor tabs observe some kind of shadow dropping over the text\nThis only reproduces with set to and tabs enabled in general. Hovering over any tab shows the white shadow at the end of the label. With this setting, every tab label has a element to draw a linear gradient (): <img width=\"400\" alt=\"image\" src=\"\"A tab itself is a container of a label and the toolbar with the close button. The close button is set to to not take more space than needed. When you hover, the toolbar is made visible, actually pushing the element into view having the described effect: <img width=\"504\" alt=\"image\" src=\"\"I actually think this is an OK behaviour for when the tab is small enough that the label cannot full show, and that was the intention. However, it is a bit strange that this would happen even for a tab that shows fully and has enough space. If someone wants to chime in to take a look with a reasonably small change, opening for help wanted. But may decide to close out of scope as this does not seem like it was ever a regression.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-c054f6d43ab079e1cca77adcd9f2536f89d6674b7ebb2a70472f20930a18f972", "text": "padding-right: 5px; /* with tab sizing shrink/fixed and badges, we want a right-padding because the close button is hidden */ } <ins> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-shrink:not(.tab-actions-left):not(.tab-actions-off) .tab-label { padding-right: 5px; /* ensure that the gradient does not show when tab actions show https://github.com/microsoft/vscode/issues/189625*/ } </ins> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sticky-compact:not(.has-icon) .monaco-icon-label { text-align: center; /* ensure that sticky-compact tabs without icon have label centered */ }", "commid": "vscode_pr_191165"}], "negative_passages": []}
{"query_id": "q-en-vscode-2622bd5333f2982b2147f7e6abe3aef23eba3778f16c149c23fb9658f28a854c", "query": "Insiders 1.82.0 Looks like the command center and associated toolbar buttons aren't functioning when clicked. Weirdly it seems like I can sometimes(?) get a hover state but it doesn't always work. Repeated clicks minimizes the window which makes me think the events are going straight to the titlebar and being handled as such.\nI can reproduce\nMaybe an Electron 25 update regression with draggable regions and custom title bar? //cc\nlooks like behavior on macOS is now aligned with windows and linux, the region no longer emits events. Behavior changed with this commit and verified with the following fiddle Looks like we would need to revert this change to align with Windows and Linux.\nYeah, looks like drag and click isn't working for macOS anymore. It always seems like an oversight/bug but a wanted one. To enable clicking again I have the for the CC even for mac. On the downside it means that the window cannot be repositioned from the CC anymore\nSlack is the same, you cannot drag from their command center either.", "positive_passages": [{"docid": "doc-en-vscode-80310d798c953093ba07c7484f17c57b8b5aea07d917f585268af5be884ac17a", "text": "/* Window Title Menu */ .monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center { z-index: 2500; <del> } /* MacOS Desktop supports click event despite `drag` and therefore we don't need to clear it */ .monaco-workbench:not(.mac) .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center, .monaco-workbench.mac.web .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center { </del> -webkit-app-region: no-drag; }", "commid": "vscode_pr_190025"}], "negative_passages": []}
{"query_id": "q-en-vscode-d76d100c5224a990325d3aab14c8cb3479b49b208574f7c2d16c60ad761e1e9c", "query": "Settings: !\nHow it should be: <img width=\"442\" alt=\"image\" src=\"\"\nHm, strange. I haven't made any changes here lately. I'm noting that is not having an effect on the foreground color used on the tree within Explorer. It does however affect other lists like the one used in the quick pick. I also noticed the terminal tabs tree flicker to use that red before being stomped on again. Not sure what's going on here yet.\nLooks like this is from\nGotcha I might just revert the change and switch it to something more specific - I didn't consider all the other applications of the list widget and checking other themes (it was okay in a couple of the themes I checked)", "positive_passages": [{"docid": "doc-en-vscode-dcec5a6927fe9b34130d941baec2a6557c2a2b016abfc1c956a5e2814eb0cb31", "text": "} if (styles.listFocusForeground) { <del> content.push(`.monaco-list${suffix}:focus .monaco-list-row.focused:not(.monaco-list-row.action.option-disabled) { color: ${styles.listFocusForeground}; }`); </del> <ins> content.push(`.monaco-list${suffix}:focus .monaco-list-row.focused { color: ${styles.listFocusForeground}; }`); </ins> } if (styles.listActiveSelectionBackground) {", "commid": "vscode_pr_190077"}], "negative_passages": []}
{"query_id": "q-en-vscode-d76d100c5224a990325d3aab14c8cb3479b49b208574f7c2d16c60ad761e1e9c", "query": "Settings: !\nHow it should be: <img width=\"442\" alt=\"image\" src=\"\"\nHm, strange. I haven't made any changes here lately. I'm noting that is not having an effect on the foreground color used on the tree within Explorer. It does however affect other lists like the one used in the quick pick. I also noticed the terminal tabs tree flicker to use that red before being stomped on again. Not sure what's going on here yet.\nLooks like this is from\nGotcha I might just revert the change and switch it to something more specific - I didn't consider all the other applications of the list widget and checking other themes (it was okay in a couple of the themes I checked)", "positive_passages": [{"docid": "doc-en-vscode-0b1481ab4b862ca96cafd8a3db3841fabb5e583fbee378e7c92c5ecddcb1ff20", "text": "} .action-widget .monaco-list-row.action.option-disabled, <ins> .action-widget .monaco-list:focus .monaco-list-row.focused.action.option-disabled, </ins> .action-widget .monaco-list-row.action.option-disabled .codicon { color: var(--vscode-disabledForeground); } .action-widget .monaco-list-row.action:not(.option-disabled) .codicon { color: inherit; }", "commid": "vscode_pr_190077"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6a3ad66f199c7a003b3991fd53ad846afe8ada7ebf848ac3a4b5e26c973c6e0", "query": "Type: <bPerformance Issue</bIn a bash terminal with Shell Integration, execute the following command, which is 5k characters long: On both my machines (Linux native and Windows + RemoteSSH), this commande takes 1s to execute. Make it 10k characters and it takes 4s. At 15k, it takes 8s. I'm using bash version 4.4.23 (the one shipped on SLES15 SP4). It appears to be related to the Bash Shell Integration, specifically the function located . This can even be reproduced outside of VSCode, in plain bash. Just define this function in a shell and execute it with a long argument. As a workaround, it is possible to disable Shell Integration in the settings and open new terminals. With a newer bash 5.2 built by myself, performances are better, but still non-negligible: 5k: 0.5s, 10k: 1.5s, 15k: 3.5s. Note: I get similar numbers with a bash 4.4 compiled by myself, so better performances with newer bash might just be related to different compilation options/optimizations. VS Code version: Code 1.81.1 (, 2023-08-09T22:18:39.991Z) OS version: Linux x64 5.14.21-.24.28-default Modes: <details<summarySystem Info</summary </details<details<summaryProcess Info</summary</details<details<summaryWorkspace Info</summary</details<details<summaryExtensions (1)</summaryExtensionVersion ------ remote-ssh0.90.1 </details<!-- generated by issue reporter --\nThanks for the report, hopefully a bash expert will spot this and help optimize the function\nUnfortunately this still seems to be quite slow for me. Normal bash runs quicky (). Bash in VS Code has had a core stuck at 100% CPU for a few minutes now with no signs of letting up... <img width=\"790\" alt=\"image\" src=\"\"Doing some binary searching, it's \"fast\" until the echo hits 1989 characters (a total command length of 2001 characters), at which point it stalls as above\nActually, it seems any command over 2000 characters in bash stalls and takes a long time to run. Doesn't have to be an echo. It seems like time taken is somewhat exponential, 2001 characters take 21s to run for me while 2100 characters jumps that up to 29s. That seems to be the point at which we use a 'fast' implementation. In reality this seems much slower on macOS at least\nHi. Could you check that whether you have command and on your system? Since I actually provided two fast impl in the PR, I would like to know which is problemetic for subsequent troubleshooting. Edit: never mind. I have reproduced the hang and propose another fix.", "positive_passages": [{"docid": "doc-en-vscode-d0db92d32b9b8e8627831b82697a866eb2328d1206f7dca35a6dbe23a32c4c92", "text": "builtin printf '%s' \"${terms[2]:-}\" } <ins> __vsc_escape_value_fast() { builtin local LC_ALL=C out out=${1///} out=${out//;/x3b} builtin printf '%sn' \"${out}\" } </ins> # The property (P) and command (E) codes embed values which require escaping. # Backslashes are doubled. Non-alphanumeric characters are converted to escaped hex. __vsc_escape_value() { <ins> # If the input being too large, switch to the faster function if [ \"${#1}\" -ge 2000 ]; then __vsc_escape_value_fast \"$1\" builtin return fi </ins> # Process text byte by byte, not by codepoint. builtin local LC_ALL=C str=\"${1}\" i byte token out=''", "commid": "vscode_pr_194459"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-c55f7796d1528d0c96fd9f29120b53daad784c34f94f7812a76b7d8f59ffbe42", "text": "disturl \"https://electronjs.org/headers\" <del> target \"25.9.2\" ms_build_id \"24603566\" </del> <ins> target \"25.9.4\" ms_build_id \"25127168\" </ins> runtime \"electron\" build_from_source \"true\"", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-35241f6053a51f18d249c33095d0e43353ff28524e2c3310c2eafda799a697b9", "text": "<del> 2606d6745056d248fe7ba21e6a30467d3ea80d2689c5fa6d2a35acf1b4a72ddd *chromedriver-v25.9.2-darwin-arm64.zip 22a86732b9e6c2afc07021ea0adeb92cdbaaa8751843c0d5170b5e96550685e7 *chromedriver-v25.9.2-darwin-x64.zip f5f42513bb55c7c1098e669d12488844ca2e63cd0d3a375db2eab517975c130c *chromedriver-v25.9.2-linux-arm64.zip 28a5613f7e4b117a65ec2882b124bf1d388f1c4fb86b228acadc297601faa6fd *chromedriver-v25.9.2-linux-armv7l.zip 7d01d537383df4b1653647e14fb768d27879943596a87b57ae3f171aa2aaf5d1 *chromedriver-v25.9.2-linux-x64.zip 3fac66fe45b4a5dcd9a4784d66bd8087d0dee5fccf06cb3f34e78f8bef3f0f8f *chromedriver-v25.9.2-mas-arm64.zip a15fc80fac243330f15a7ff7cc834c50c79833e81b871cc45f7239bf1743b4ac *chromedriver-v25.9.2-mas-x64.zip f0a354e01e277b14422e34f8af9c8c43ae975c6fb69a2e61ef275b6ec919f2ab *chromedriver-v25.9.2-win32-arm64.zip 570a6b5bc485bfea9681c97b79832d5d5bcafdd993c13dc4ab11558e3a27c554 *chromedriver-v25.9.2-win32-ia32.zip 4134f539ac304c65dfca9812b0d3943ea64d886989eba8f62828718b106c4eee *chromedriver-v25.9.2-win32-x64.zip 835418b9274c76503542c986d63bb9d98f071c702170536bdd62c1760589e01e *electron-api.json fd9f5b1439445acc69441ef66cc47f56c5c0848dec5f6daf91a476073e72a756 *electron-v25.9.2-darwin-arm64-dsym-snapshot.zip de29ef2a4c7b76281b1cf3ac9e6047a9275cc60167c6cd60509f2eb2a3258842 *electron-v25.9.2-darwin-arm64-dsym.zip 732f51802f2902ca08c3a06a45fe23820b1effbeb3ebd39fcae9fce5a1e0b25d *electron-v25.9.2-darwin-arm64-symbols.zip ab82efb59077a85fd20264f8ad0dedc4c8b0b2fc9d2948ed9461425faf5e35f6 *electron-v25.9.2-darwin-arm64.zip fb924b4dd0d781a14114e54fa556ca326c60665b674712c59163e7b44db675d8 *electron-v25.9.2-darwin-x64-dsym-snapshot.zip 197fc3e120e54578658e2f10b5fcec1d2004f1637d4bee116ff1e12b0c5a1429 *electron-v25.9.2-darwin-x64-dsym.zip 57d0a0f55726524ff843a040e516e425c3537a4602ab8c23120433fbc51470fb *electron-v25.9.2-darwin-x64-symbols.zip 0fe310e2ed13a97cd9c28fb0cf806338cd2e720083e6d1b13d60ba4cedb8f295 *electron-v25.9.2-darwin-x64.zip eb1a31ccd6a89a21538a8b1f0b5d3b77e1fe946b898319e1832cb9dc3abcd753 *electron-v25.9.2-linux-arm64-debug.zip b5b128bed0a09955ad5bb91fa9f5ab9155a547f787ad580bcd5bf409bb697ff6 *electron-v25.9.2-linux-arm64-symbols.zip 0b2d48a29d79fcd21d72d05fdb7638dd2fd257cf0d4cf9bd32f182b2634de466 *electron-v25.9.2-linux-arm64.zip eb1a31ccd6a89a21538a8b1f0b5d3b77e1fe946b898319e1832cb9dc3abcd753 *electron-v25.9.2-linux-armv7l-debug.zip 43f1f4c1475335719ba8f1f7f036a084fb22b5faa908bf4f7d30a96d5d9c159d *electron-v25.9.2-linux-armv7l-symbols.zip 4ea3ee3ad41c69454d9a12518eeff1ec5dbd841c8200dc8652e6c0b101d1259c *electron-v25.9.2-linux-armv7l.zip 1a8daf1f9e155d7143d16367e54e4e3b8e9d71ad580b44c8dfba0cb4e7a1c640 *electron-v25.9.2-linux-x64-debug.zip 803f32ca345d8974cc074dc177e06c62f8bcc98d4a39eccb676b7d302b8fc466 *electron-v25.9.2-linux-x64-symbols.zip aab65a562723e04eadbdee1251a749756b366dc1c5014bcc987c21c0a523fe2f *electron-v25.9.2-linux-x64.zip fd9f5b1439445acc69441ef66cc47f56c5c0848dec5f6daf91a476073e72a756 *electron-v25.9.2-mas-arm64-dsym-snapshot.zip 0ec88ec7bd2b7cb2e5e6b94f13df7d8c22433637004a473370e0959cb01f78cc *electron-v25.9.2-mas-arm64-dsym.zip 398a0575c1974565af99b6759a74967c0709bc101059542a00bfe64a1210a86f *electron-v25.9.2-mas-arm64-symbols.zip 17f86ad33f9fc2ca5eaac5ef87604e65b1eefba5a51d4ad58e70018fdfb84ac6 *electron-v25.9.2-mas-arm64.zip db61b29802ee1f598a3e61211a281656f16e70ae84041e6b2b5dd8ecae43cd67 *electron-v25.9.2-mas-x64-dsym-snapshot.zip 2f76620eb7d632335f7620f5d3713af5e59c98bdb0b323269c2319b7164fcaac *electron-v25.9.2-mas-x64-dsym.zip ea226c8d049e527d84ec5058474fd4e64476e6924fef42b1dbea774925f59064 *electron-v25.9.2-mas-x64-symbols.zip 51b9d192ccb7612211ca9cc8ddb373a86f791d38b369337ad099a133e9d9807a *electron-v25.9.2-mas-x64.zip 53b39857303191ea2f26dda06461e6e612ca0ed799bdf0c26a1a63ff89f7ea1b *electron-v25.9.2-win32-arm64-pdb.zip 49199591c69fbeb68dd57252a3d8525babe79ab98447ad639f2d0c3e63aba4b6 *electron-v25.9.2-win32-arm64-symbols.zip e7b968fc53cc7a10a4ccb5133af045968479685ebb9617f06817f03667fdd425 *electron-v25.9.2-win32-arm64-toolchain-profile.zip 6abd0a6697d7fe8b6add4d1017a01a0ac756d16da5bfa077bd373a685b529bd8 *electron-v25.9.2-win32-arm64.zip cc5c67b027c679eb86882c2ec267d38fafcc5127b49e8a060002541253e2b26b *electron-v25.9.2-win32-ia32-pdb.zip 2cd8aab8aa4eadfce90c8ba6565a77689db1efe55b7eaafedede3b08e8c41f53 *electron-v25.9.2-win32-ia32-symbols.zip e7b968fc53cc7a10a4ccb5133af045968479685ebb9617f06817f03667fdd425 *electron-v25.9.2-win32-ia32-toolchain-profile.zip ac2aebe7d7b21351256fb3b60219269e75ff33f8c3cfbbca682c3622d1943b94 *electron-v25.9.2-win32-ia32.zip 000b506bab92c92e0ff8428033fc7e1c15049437606794c4bec84a66eb29b6cd *electron-v25.9.2-win32-x64-pdb.zip fd40d04de0ef4a04dd720505f03a6d209a38387fe05493869f441037aa950e4d *electron-v25.9.2-win32-x64-symbols.zip e7b968fc53cc7a10a4ccb5133af045968479685ebb9617f06817f03667fdd425 *electron-v25.9.2-win32-x64-toolchain-profile.zip de3fc45f4fa5572d6dbb4f21580e75d3b6429a6b3b833a962c810e7e199b8573 *electron-v25.9.2-win32-x64.zip c3f22fbf99713bb44546278ef1456e4fc9a83d33bf038f6752fea12c7a721337 *electron.d.ts 2a088f4c227405783466e456e69154193a730130f5cc39520091abc8993977bc *ffmpeg-v25.9.2-darwin-arm64.zip 4da4197282a9a31379d2194d1072888b9ed3200663e322df2759b971725a2915 *ffmpeg-v25.9.2-darwin-x64.zip bd52d57ff97fb56ac01a3482af905d04f0d4e9c13c53858c6d9f99957eca82da *ffmpeg-v25.9.2-linux-arm64.zip 9b3d09177fa1e63e2a6beecfa70aeec30aeb5c1873ff21128a68051c4e23f95d *ffmpeg-v25.9.2-linux-armv7l.zip 39c3e411873262873edff4b9f4b5d9973fb3cab8f700d6ff665872dab3b39eb3 *ffmpeg-v25.9.2-linux-x64.zip 861287a6cb0f546c0e39f49a2b28f5575d66fbddb26486584cc7802e84402339 *ffmpeg-v25.9.2-mas-arm64.zip bcc8315a9e07394510c96ffca20720e3cdb2a4aecc75798bfca8fd60417782aa *ffmpeg-v25.9.2-mas-x64.zip 0ebfe5a72aaf0a9af81ffbcba03763f4baa142c93c31b50ad0145365366f0076 *ffmpeg-v25.9.2-win32-arm64.zip d8e7ea1268145d3481a74152ced8ae677ca5b174f06eb874a6ce0005ff0d471c *ffmpeg-v25.9.2-win32-ia32.zip d1f499b957377c3822c43eadf3bc32e7cb04b52fb2fd51ba22f14cd61ef01727 *ffmpeg-v25.9.2-win32-x64.zip 86a0df1394e741feb21a891747775911d5c2f9cd940662826b33c309275abb7c *hunspell_dictionaries.zip 4c4bab279b39c4e463dcb3a897e256e5e4f088e6e6495f6aea10e26703ecafc3 *libcxx-objects-v25.9.2-linux-arm64.zip d2b6349a89c9fce3ccc0a9a430b059eb18cd3967dbbe34bfcae54b3f58cd462a *libcxx-objects-v25.9.2-linux-armv7l.zip e8d4b1a3228c0709dc54d780bd4d33727fff30c38f8e00409a6eaf54a69e5869 *libcxx-objects-v25.9.2-linux-x64.zip 7679259e7cb02140806cc616d012102462d671ae07c4673ad0c2c9a6716444a6 *libcxx_headers.zip b1683af6708bceaa966e5168fda51223fa51e09549abc90f5744d500f9260c92 *libcxxabi_headers.zip 4fed33611a889d0100a6fbf4253cf9dcb9fbe3c42f7c86d8886d460a9a9cf8e6 *mksnapshot-v25.9.2-darwin-arm64.zip 5e1daea6393bd977a70020c36f1e4ee4e416c8c4eafe2b27b38292e4acb1764b *mksnapshot-v25.9.2-darwin-x64.zip 92ff719eb83df7f107d4dd3970122333f4bde194292c568b5c0a5ea4684bc9f1 *mksnapshot-v25.9.2-linux-arm64-x64.zip e621d50652f2afa49f47ab7cccd07f7d29ef60f694a0e70d4e6434ddd07cf282 *mksnapshot-v25.9.2-linux-armv7l-x64.zip 012c24dd59f7b5b4322e53c12bb6450a7b15bc6800042fcf3804ba14685f8188 *mksnapshot-v25.9.2-linux-x64.zip 62e880bf8594b1d83926984c252d86990f1386655bd1375afc0fd3054018adef *mksnapshot-v25.9.2-mas-arm64.zip 0742e1bfcbe171199f0a333fddbf401a61777928d462b852d21fec2822b2c46e *mksnapshot-v25.9.2-mas-x64.zip b019e6e117e13238465d1758274ebbaf7ccb999921dcb11ef1e3a9a5a6df952b *mksnapshot-v25.9.2-win32-arm64-x64.zip bc7196f1fd2ba3aedc6c16e96e455d280155dfc493a0d0f6ce7bffe645e39e1e *mksnapshot-v25.9.2-win32-ia32.zip 2d152f09969d69439e831b4212e77ea157a9e4b3a9b3ad55d4f2efcc547c25eb *mksnapshot-v25.9.2-win32-x64.zip </del>  No newline at end of file <ins> 004cb2a93a7094449675ac49998f1c1572dd74b7839039332525f44a2a4d6905 *chromedriver-v25.9.4-darwin-arm64.zip e578c2b7c88ae066664c0562ca77f776d419a6ae5045383df9718e743147f880 *chromedriver-v25.9.4-darwin-x64.zip 7c0f030cf143d682ae838e078d560b76b5f0af8c65d67f6026167c0a04c8f60b *chromedriver-v25.9.4-linux-arm64.zip 320026f620bdd708aff88c97ee9bf40d2fbad4fce4be0be3c8252876c9a629ec *chromedriver-v25.9.4-linux-armv7l.zip 65d4473294f024e4ba56a72ba9f87bec51207a7c924fda998acf499e5db4da9c *chromedriver-v25.9.4-linux-x64.zip 191ba934dace5851f60ec5cdb040202dacebf837ae6b8483649cc85da698ffeb *chromedriver-v25.9.4-mas-arm64.zip 1da9b56db091b1825cb3913de5eb12e30bb55f55023e044bed9e6d1518ab86f7 *chromedriver-v25.9.4-mas-x64.zip 3efd22a6d4500603f629f5c58af44570909df6871eccc9d17c01d04ab17ca47e *chromedriver-v25.9.4-win32-arm64.zip cd8b4be4d491f39aebc97102e2a48e43260eff693163c1526f1fb0b401ec0a81 *chromedriver-v25.9.4-win32-ia32.zip 03df2f38e3a07f70b766a5f0a9548acf8b35148dcb97d12e0479fd527da423e3 *chromedriver-v25.9.4-win32-x64.zip f1c4c82db5b9649d7e9cdb4c482a76ded439f6b11267f4b5eb869616a7f8244a *electron-api.json ac61c1f78f4bebf74073b4dbca356bc3aef6b44b4b069f8f2bfdb03d562e50f9 *electron-v25.9.4-darwin-arm64-dsym-snapshot.zip 54424b0db7f38794dbc5aff1bf3a20fc93f0f35a03fce8eaaf523bbc075fef83 *electron-v25.9.4-darwin-arm64-dsym.zip 1d816ad4c6a6e198d8ae6bb49698982f0f0298a605db09d46d3d4509c16a84a1 *electron-v25.9.4-darwin-arm64-symbols.zip 8022153ed1437a5785a0f819d14f41ae1026c1c5c1406d535a32c2a0ec1e4ba3 *electron-v25.9.4-darwin-arm64.zip 1a76a3c9ef80989488ed5a5cb9d4f54d284f79931f98907e6dbe3437271b33c0 *electron-v25.9.4-darwin-x64-dsym-snapshot.zip 92b14aa0a6dbbf9dd4829464ecea4ee77536f6c45cd393aa00b502eb5d72e480 *electron-v25.9.4-darwin-x64-dsym.zip 0bd268108df307e6d7770fea8882b5072ced5da23a0914e3e660e26c80314174 *electron-v25.9.4-darwin-x64-symbols.zip 4a3b55cfdb3fedbe188f51c552ffa1f9d17d145926990ca914faccbb72634ee6 *electron-v25.9.4-darwin-x64.zip 59bde360b480228cb166836d678682146d6f4cf9c8e6a534087c974e827b11bb *electron-v25.9.4-linux-arm64-debug.zip c8a2174ddfa18eeb326c830cbaf944931038de422d7e8492a9a5680dd54c77eb *electron-v25.9.4-linux-arm64-symbols.zip 119481d318dec273434f9f4f43fb808ff66858cc0da1f17deccc6b08a99fbb83 *electron-v25.9.4-linux-arm64.zip 59bde360b480228cb166836d678682146d6f4cf9c8e6a534087c974e827b11bb *electron-v25.9.4-linux-armv7l-debug.zip f791ce6c4bfe8ae7a00df9ac9dad766ce5ac4e502092b02c0361327a84ac07a8 *electron-v25.9.4-linux-armv7l-symbols.zip 2ef1673f4c6b943b35dc1dd3379aae7534f2456c91eabc704e2db35012aac706 *electron-v25.9.4-linux-armv7l.zip ff0e6cd86b963d87edd02202284e1fd29842f5fa85b4ca7a21ab753507ab3a9d *electron-v25.9.4-linux-x64-debug.zip add83741ede569ec1ed243aea8a77d782674a59c62221a4b9bd07507af62441e *electron-v25.9.4-linux-x64-symbols.zip 84f92675e3a9616cc163de673ebfafaad3c2976dc500612875a23849bc3661ce *electron-v25.9.4-linux-x64.zip ac61c1f78f4bebf74073b4dbca356bc3aef6b44b4b069f8f2bfdb03d562e50f9 *electron-v25.9.4-mas-arm64-dsym-snapshot.zip a76831375f19b4d48766211026446f2b073247c1e1a29edb52683caa0d0fc349 *electron-v25.9.4-mas-arm64-dsym.zip 5a8a82ac24fdd31389391a157509b0a45e23d7e70236968b7b4a2130d930d04f *electron-v25.9.4-mas-arm64-symbols.zip c7e47d78ee8fc6d9112a38977cf1ebbec31cdf06b8a0540f120e7a69500c56f7 *electron-v25.9.4-mas-arm64.zip 94253d587d9ed00b1741a64ca36e32fe8bc60cc32df48675bef89af081c4f0ec *electron-v25.9.4-mas-x64-dsym-snapshot.zip bf6e83d683c7fb88e21b93d4926b1e3dc9151f94e1bb4635ae2b77992b2c6598 *electron-v25.9.4-mas-x64-dsym.zip 4b9758d4a74e21f66eedb95392d098e057e509a1f0eecc09729fa36747918838 *electron-v25.9.4-mas-x64-symbols.zip 6e26f31b8088563b2cc4d1552d9ff00e61bc7ef1b95b7cfe404564f84b5b210d *electron-v25.9.4-mas-x64.zip c6fe73f028eff3dfdd6408b8762b5e0d2a67b3bd110b5910d1bec1fa85da8a5a *electron-v25.9.4-win32-arm64-pdb.zip ccccad00e4e16048743d5252023665b74ab804a7482606dc0dc9ad01f94c988b *electron-v25.9.4-win32-arm64-symbols.zip e7b968fc53cc7a10a4ccb5133af045968479685ebb9617f06817f03667fdd425 *electron-v25.9.4-win32-arm64-toolchain-profile.zip 667c212b51400bfd1ab78a83d2adcdd6c9624a71b1a6892432e38ce9658d8093 *electron-v25.9.4-win32-arm64.zip 320dab9a57c4f0efa1ecadb4a07ec15adecaa913ef62524cacaa9f011292571f *electron-v25.9.4-win32-ia32-pdb.zip 2875e171ebba7fc12be3133cabbd38cdca30d3cedbb89a1e1e11270380b4afc5 *electron-v25.9.4-win32-ia32-symbols.zip e7b968fc53cc7a10a4ccb5133af045968479685ebb9617f06817f03667fdd425 *electron-v25.9.4-win32-ia32-toolchain-profile.zip 18b11abf7b1f2f4568c3cf5dc9a2a0fc5349b6e3f40ecb91e086b030f254510d *electron-v25.9.4-win32-ia32.zip a4b49fee1139071eb33c014ed8ac49cf83065a6d95255c44acc78c3922c56185 *electron-v25.9.4-win32-x64-pdb.zip 1712567ed6b050501a974e33a9a46cd806965d73b36ec8e18346d49022f74a8a *electron-v25.9.4-win32-x64-symbols.zip e7b968fc53cc7a10a4ccb5133af045968479685ebb9617f06817f03667fdd425 *electron-v25.9.4-win32-x64-toolchain-profile.zip 03abc9d5b2b28b440e9e5b0fc61806e3f3c2888dac5d5939957726bd68955113 *electron-v25.9.4-win32-x64.zip 706c40b11144551b2da43cdfd191c2e3e2bf0d7600b8d2751f3a806f72d0ede2 *electron.d.ts 859e7f8f6b6faf1fd004ef335ccff6f25f18c17f1aa63031e0af238899513958 *ffmpeg-v25.9.4-darwin-arm64.zip 3b63d30acb2bc5cdcc94ac2dc9e69e0919bf5038d3fd61f822c183280684cc4e *ffmpeg-v25.9.4-darwin-x64.zip bd52d57ff97fb56ac01a3482af905d04f0d4e9c13c53858c6d9f99957eca82da *ffmpeg-v25.9.4-linux-arm64.zip 9b3d09177fa1e63e2a6beecfa70aeec30aeb5c1873ff21128a68051c4e23f95d *ffmpeg-v25.9.4-linux-armv7l.zip edc7b1c9f1a0733f109a2c0375a4e40c5bfe0bf28b7f06dcc76e1ada0aa2f125 *ffmpeg-v25.9.4-linux-x64.zip dae4d7857e7cf2d1333ce522ed3c8e3639a95432015a649a6cc3d064ddc076eb *ffmpeg-v25.9.4-mas-arm64.zip b2d9a72f57a18c68c30cbbde305ba91e740656746e37d5ce22e8895e7ec36a74 *ffmpeg-v25.9.4-mas-x64.zip 7ebbd70835b6bbd1d12e432a2b0df4fb5fccd4039c6b5125401069b1c0ff6f0e *ffmpeg-v25.9.4-win32-arm64.zip 128499e322306bf4900106d1120e28d93cafd7af5c5052109f2739360c7e212a *ffmpeg-v25.9.4-win32-ia32.zip 00a2e9d9b783899662b430feb5fb030e89ae7682ef4e3bf8eb4c8ecbfd435b84 *ffmpeg-v25.9.4-win32-x64.zip 1b9943e151314644652f738afa309d1d4f3cb18fc505e568c1f80e66e0ccf1b3 *hunspell_dictionaries.zip 631aac564c555332dbf9d7acdcce6852c594cd84d3afd3056e738c64f4b1cb1b *libcxx-objects-v25.9.4-linux-arm64.zip 4ad907d1b04bb93aba78b086ffdf16e2c0aa23f5a3901ad23ab4fd1aa46e80a3 *libcxx-objects-v25.9.4-linux-armv7l.zip c8950fb9555c33015cb0d2299dfb2b35daa1c0c7d392bf53a96f570b8c064c93 *libcxx-objects-v25.9.4-linux-x64.zip aaafbf6dfc756d3244d6085c419eec5dc3aa7b12face8a0bab1733aed3e7f3e7 *libcxx_headers.zip c571e713663bdc68f5956e45b975b89bd23cc2e401a1161321167d224b1dea3d *libcxxabi_headers.zip cf42b5f0e4e6500b89ab8313267a459584be8a175cc6c7e20c1fee50277c65f4 *mksnapshot-v25.9.4-darwin-arm64.zip 6f1b74306d691214218e2894f813af1d0fde5e6ded31ad94c1ad4f44b4582b29 *mksnapshot-v25.9.4-darwin-x64.zip 9a0e09332db556357288b46738a409269cc4c83816396c70fd5b518548eb884d *mksnapshot-v25.9.4-linux-arm64-x64.zip 80692a923553ae0172f5a981ff44d7194a307d826be5c39473f2555c1af4a025 *mksnapshot-v25.9.4-linux-armv7l-x64.zip 6dfb2d094b96f8507b4984ad8dcb14c56a8df5cd5bf89533ff6c7714009da4a0 *mksnapshot-v25.9.4-linux-x64.zip 50c800e3aa75997ec377e3d91682f9f4b49dd4e95555dd9acbbdd083d73718ac *mksnapshot-v25.9.4-mas-arm64.zip 81ea7704f3453c6d8e55525dd7e2999664e45002dab70dd250b2194b6ddccc7c *mksnapshot-v25.9.4-mas-x64.zip e817d7637498531c4de3bcbdfbd45a6255f04e349b2aa8ffdf454817f2c78b54 *mksnapshot-v25.9.4-win32-arm64-x64.zip f61be226a7c303d1b2502561de5093b0a9d364ae6d0a3b51d9c1d8b793ac97ef *mksnapshot-v25.9.4-win32-ia32.zip 73c65b7356aa3d703ca8ca43ec2436ee9c9475ce8b27b71b4313c0b3d4d76e10 *mksnapshot-v25.9.4-win32-x64.zip </ins>  No newline at end of file", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-4fe437fec34d60493a45c0b3a3acc0698f633fe64c4f8ce4684570f7205eb648", "text": "\"git\": { \"name\": \"electron\", \"repositoryUrl\": \"https://github.com/electron/electron\", <del> \"commitHash\": \"468c4af6611c88762b7ba6c4400c5022895457c2\" </del> <ins> \"commitHash\": \"bb6a7d443b4f00680d05cc703b4d7ae180fdde03\" </ins> } }, \"isOnlyProductionDependency\": true, \"license\": \"MIT\", <del> \"version\": \"25.9.2\" </del> <ins> \"version\": \"25.9.4\" </ins> }, { \"component\": {", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-5f4bb8ce0efdd6bc95242875e06e8452e22417309b867ec953f4d06073d83653", "text": "{ \"name\": \"code-oss-dev\", \"version\": \"1.85.0\", <del> \"distro\": \"cbc81496e34eafbc771b8f008e6a742d755968c9\", </del> <ins> \"distro\": \"210db50a0928d4857ed3d511ddb5612b947e0fef\", </ins> \"author\": { \"name\": \"Microsoft Corporation\" },", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-52ec9474fa05ebf970f81fe03254f9362c91820cc81034828d5b2028d7bf0b18", "text": "\"cssnano\": \"^4.1.11\", \"debounce\": \"^1.0.0\", \"deemon\": \"^1.8.0\", <del> \"electron\": \"25.9.2\", </del> <ins> \"electron\": \"25.9.4\", </ins> \"eslint\": \"8.36.0\", \"eslint-plugin-header\": \"3.1.1\", \"eslint-plugin-jsdoc\": \"^46.5.0\",", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-f8e1d6f3de0551af8fede95a211e65d6808caab34fa3a174645e57606dfafa4a", "text": "disturl \"https://nodejs.org/dist\" target \"18.15.0\" <del> ms_build_id \"234519\" </del> <ins> ms_build_id \"243295\" </ins> runtime \"node\" build_from_source \"true\"", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-d7b15518f07871e888e116ad184cfe0194725fd7bac54383341290f79c768d1f", "query": "Workaround This is an issue in Chromium itself. For now there are the following two workarounds: ### <blockQuote</blockQuote1. ### <blockQuote</blockQuote## Bug <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. -- <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --1. ### VS Code Version Per: affected version is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.82.0-insider Commit | Date | 2023-08-11T17:10:45.392Z Electron | 25.4.0 ElectronBuildId | Chromium | 114.0.5735.248 | 18.15.0 V8 | 11.4.183.27-electron.0 OS | Linux x64 6.4.9-1-default </blockQuoteHowever, per: that , that is: <blockQuoteType | Data ----------------|----------------------------------------- Version | 1.81.1 Commit | Date | 2023-08-09T22:18:39.991Z Electron | 22.3.18 ElectronBuildId | Chromium | 108.0.5359.215 | 16.17.1 V8 | 10.8.168.25-electron.0 OS | Linux x64 6.4.9-1-default snap ### OS Version <blockQuote</blockQuote</details## Steps to Reproduce 1. The GUI is invisible: the menubar continues to operate correctly.\n82 updated to Electron 25 and doesn't work on older OS.\nI'm using cpe:/o:opensuse:tumbleweed:, which updated 2600 packages yesterday (which I have installed) yet this problem remains. Nobody in their right mind would consider that to be old. Additionally, I am using which means that no independent part of the OS should be considered old. This is the most bleeding edge system for miles. Regardless, should I perhaps open a linked issue at\nOh, sorry, I thought it's an old OS issue. Before reporting in the electron repo, what is Help Toggle Developer Tools bringing up? Have you tried to do a clean reinstall of VSCode Insider? Perhaps it was just a bad build. Or, alternatively, you could try to download the latest Insider installer and install over your existing broken version (which I assume it's 3-4 days older than what you'd get right now) - that should effectively update it.\nNo problem. Thanks. Apologies for being curt. ! ! Appears that it's reproducible.\nVery strange, indeed. I'm out of ideas. Would be interesting to be able to test with a previous Insider version, but for that you would need to have the old package and disable automatic updates. Electron was updated from 22 to 25 on August 8, so the last version with Electron 22 is the Insider from August 7, which is also the last version that I've tested and still working on Windows 7. Anything after that doesn't start anymore on Win 7. I'm not sure whether the Electron update on August 8 is causing your issue, though...\ndoes the log file explain anything? To me, it seemed a little too verbose to be of much use. I can try other methods to get relevant diagnostic data if you are able to instruct me.\nI see many GPU-related errors, such as: Errors: link failed but did not provide an info log [(48)] (checkLinkStatus): Program link or binary loading failed with no info log. [(81)] Skia shader compilation error Found these: So it's definitely something related to the new Chromium included in Electron 25 and these issues seem relatively recent. The first link recommends to disable hardware acceleration, you could try searching how to do that from command line in the new Insider. Unfortunately, I don't have the time to dig deeper right now.\nper , do you know whether VSCode contains a directory? I haven't been able to locate it.\nremediates the problem. Because indeed this issue is dependent upon , before this update is rolled out, there needs to be remediating measures (or the update needs to be temporarily halted) lest it break a great many peoples' installations.\nCan you please take a look at this? It's Chromium/Electron 25 related, so I immediately thought of you. Please see the response just above for a possible solution. Thanks!\nThanks for investigating the issue, given there are workarounds in place this is not necessarily a release blocker. I will wait for chromium to address this issue and backport the fix to Electron 25.\ncould a patch at least be to the affected releases to delete the relevant directory? Surely users shall be affected otherwise? I doubt we can expect them to diagnose a known issue if the solution is so simple.\nWe don't want to delete the GPUCache for all users and the affected scenario described in is not possible to detect from the application layer. I think the best I can do is to add this issue to the release notes and document the workarounds for visibility.\nWhy?\nIt will have impact on startup performance, for now I would wait to see the impact of this issue across our users and decide on a fix forward. The upstream issue has also been open for a while now, signifying its low impact.\nJust happened again. !\nThis is mentioned in the 1.82 release notes I guess the issue remains in 1.83-insiders, haven't tried it yet.\nIt appears weird to me that solely VSCode appears to be affected by this (on my system) because Discord has been very happily updating frequently, and obviously has its own Electron-provided directory. !\nRelated on Stack Overflow: Related on Reddit: ,\nGot this installed via fedora yesterday This wasted quiet some time on my end, as I first went searching for changes to fedora itself and finding this issue on vscode wasn't trivial.\nLeaving this here for future me, as I now have that problem on a different PC\nThis also happens for other Electron based programs like Element and also chromium and firefox. see\nI'd disagree, . It doesn't read like pragmatism - more like \"didn't want to do a good fix\". Startup time after the workaround felt normal. Super aggravating that this wasn't resolved with a one-time installation task to clear the GPU cache. Hard to know the aggregate cost incurred by people encountering this issue, but \"not small\" is probably an underestimation. Linked-issue count wouldn't be a good proxy for that metric, in that product-support's practice as shown in seems to be linking to the known-issue buried in the release notes, not to this issue. Sorry for the flames, but there you have it. When one's coding environment gets fsck'd, it's no fun, and erodes trust. Please consider.\nI, for one, find great enjoyment in my coding environments.\nThis issue has reemerged with the latest version 1.82.3 for Ubuntu 20.04.1: Removing after the upgrade still works to get vscode running\nIt occurs for me almost every update of the package. It's ridiculous.\nSame.\nAs mentioned before, this is caused by the new update in VSCode I have personally reverted to until this issue is properly solved\nI was under the impression from the chromium bug that this is one time change and not required for every startup. I see that you are using snap version of VSCode, can you check if you are required to delete the cache for every start using the instead ?\nI must rectify my comment: with the snap of version v1.82.1, it was required to clear the cache every startup, with v1.82.2 I don't remember having to do it, while with v1.82.3 it was needed only once on upgrade. I will edit my previous comment to fix it.\nWe had a runtime version bump between to , which seems like a trigger in the snap case. Can you setup deb package, we will have release this week. It would be good to confirm if updating requires to clear the cache in the deb package as well.\nFor what it's worth, I haven't encountered it on the rpm again\nI've tried the following: removing v1.82.3 (snap) and installing v1.82.3 (deb) did require clearing the cache. removing v1.82.3 (deb) and installing v1.82.2 (deb) did not require removing the GPUCache. upgrading v1.82.2 (deb) to v1.82.3 (deb) using apt did not require removing the GPUCache. hope it helps\nI'm not using the snap any more. I use the package provided directly by Microsoft from\nEncountered this problem on Fedora 39, probably after upgrading my vscode rpm which is currently on version 1.82.3. Problem disappeared after running .\nNot with VSCode specifically: but when updating to electron v28 alpha, had this issue. Also solved with (or just deleting the entire Electron dir within ).\nAlso ran into this, thanks for this workaround, it worked.\nI also ran into the issue in VSCodium (which is a special build script for this source code) after an upgrade to 1.83.1 on Debian Trixie and XFCE 4.18. The worked like a charm (which is the equivalent folder on Debian for VSCodium). I did find that I only ran into the issue on my RX 550 (Lexa) and not my Radeon RX 580 (Polaris); I found that the bug disappeared when running the program with appended to it to run it on the latter graphics card.\nThis has happened a second time in 1.83.1.\nGot it again on fedora using the rpm on a system, where I already dropped the cache once Version 1.83.1\nJust installed an update with no vscode update but had a mesa update. VSCode broke again. I assume this is going to happen every time a mesa update is installed (I'm assuming because of what others are stating, could be something other than mesa but seems to be the biggest suspect).\nGetting it after every mesa update. But may be \"GPUCache\" need some harder refresh or detection of brockage?\nThis issue has been fixed upstream via . It might take a while before it trickles downstream though, since it needs to be picked up by Electron first before it can go into VSCode. I did attempt cherry-picking the commit and generating a local build and it seemed to fix the issue.\nThe commit is fairly trivial and can probably be safely backported to all supported Electron trees. This is a very widespread issue, affecting virtually every Electron app running on Linux. It would be great to get the fix as widely disseminated as possible considering how slow the app ecosystem is to update versions. Is there a linked Electron issue for this? Do we need to create one if not or does the Electron project accept drive-by backport PRs?\nI haven't found any linked Electron issues yet. Based on , since the patch is temporary, has been committed upstream, and will eventually be removed, I think the Electron folks will accept the patch. However, do take note that the commit has dependencies on previous commits. On my working local build, I have these 3 commits cherry-picked in chronological order: Therefore, if anyone is going to bring this up to the Electron team, all 3 patches would need to be merged. Add the patch files to the and append the filenames of said patch files to the . Depending on the Electron build version, there might also be some merge conflicts. Based on my experience, those conflicts should be resolvable, but I did not test all of the older Electron major version release branches. For each branch, we would need to double-check if the 2 dependency commits are already included in their respective Chromium version or not.\nThank you for the backporting work to Electron versions 25-28 over the past few days. Downstream applications should now be able to pick those fixes up. Once VSCode picks up the fix, we should be able to close this issue.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nI'll verify when the next release reaches me on openSUSE.\nby chance, were you able to verify the fix for the issue yet?\nthe time period hasn't been quite long enough to be certain. This usually occurs on an update or after approximately two months. However, VSCode did update recently, and this didn't occur (not that it was guaranteed). Consequently, if upstream has fixed the issue, and we're using the patched version, because it hasn't appeared yet, I'll keep this completed until it occurs (and we can reasonably consider this complete).\nConsidering the issue as verified on 1.85.x. 1.86.0 will go out in around a week. Feel free to comment on this issue thread if the issue comes up again after that.", "positive_passages": [{"docid": "doc-en-vscode-d4391a1b30225f9aa28a27b55a88b559a479ee740cfc386e709df301f380af76", "text": "resolved \"https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.207.tgz#9c3310ebace2952903d05dcaba8abe3a4ed44c01\" integrity sha512-piH7MJDJp4rJCduWbVvmUd59AUne1AFBJ8JaRQvk0KzNTSUnZrVXHCZc+eg+CGE4OujkcLJznhGKD6tuAshj5Q== <del> electron@25.9.2: version \"25.9.2\" resolved \"https://registry.yarnpkg.com/electron/-/electron-25.9.2.tgz#12be98fbcff485c94ff99df21e0727797a45364a\" integrity sha512-hVBN5rsrL99BKNHvzMeYy2PkAmewuIobu4U3o3EzVz4MDoLmMfW4yTH5GZ4RbJrpokoEky5IzGtRR/ggPzL6Fw== </del> <ins> electron@25.9.4: version \"25.9.4\" resolved \"https://registry.yarnpkg.com/electron/-/electron-25.9.4.tgz#1935b6fbfd8ad920719a4136d867021496703884\" integrity sha512-5pDU8a7o7ZIPTZHAqjflGMq764Favdsc271KXrAT3oWvFTHs5Ve9+IOt5EUVPrwvC2qRWKpCIEM47WzwkTlENQ== </ins> dependencies: \"@electron/get\" \"^2.0.0\" \"@types/node\" \"^18.11.18\"", "commid": "vscode_pr_198142"}], "negative_passages": []}
{"query_id": "q-en-vscode-06ae6fc82d2ce6609f5f67300cd120610af61afa72a4c7bda50c3d4628d004f2", "query": "Type: <bBug</bPort forwarding over ssh is not working using vscode-insiders. It is working using vscode. How to replicate: some http server on the remote the port to be forwarded and select http as a protocol opening in browser / doing a curl from your local machine the request is stuck pending VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-21T05:32:43.957Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 6.1.38-59.109.amzn2023.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (54)</summaryExtensionVersion ------ Handlebars0.4.1 vsc-python-indent1.18.0 dotenv1.0.1 remote-containers0.305.0 remote-ssh0.105.1 remote-ssh-edit0.86.0 remote-wsl0.81.0 vscode-remote-extensionpack0.24.0 remote-explorer0.4.1 remote-server1.4.2 material-icon-theme4.29.0 indent-one-space1.0.0 vscode-todo-highlight1.0.5 nugetpackagemanagergui2.0.6 Handlebars0.4.1 vue-peek1.0.2 vscode-markdownlint0.51.0 vscode-eslint2.4.2 gitlens2023.8.1905 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-jest-runner0.4.66 copilot1.104.347 copilot-chat0.7. vscode-github-actions0.26.1 todo-tree0.0.226 terraform2.27. vscode-test-explorer2.21.1 vscode-nuget-package-manager1.1.6 roslynator4.4.0 vsc-python-indent1.18.0 vscode-python-test-adapter0.7.1 dotenv1.0.1 vscode-scss0.10.0 vscode-docker1.26.0 csharp2.0.376 vscode-dotnet-runtime1.7.0 black-formatter2023.5. flake82023.7. isort2023.11. python2023.15. vscode-pylance2023.8.31 test-adapter-converter0.1.8 indent-rainbow8.3.1 material-icon-theme4.29.0 prisma5.1.0 vscode-scss-formatter3.0.0 indent-one-space1.0.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-conventional-commits1.25.0 volar1.8.8 vscode-typescript-vue-plugin1.8.8 vscode-todo-highlight1.0.5 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI can reproduce this with SSH, but not with Dev Containers. have there been any changes to SSH recently that might cause this?\nHappened to me yesterday too. Spend a lot of time rebooting my machine and killing processes until I tried regular vscode to find that port forwarding was working fine there. What is weird though is that the browser just hangs. Nothing happens if you try localhost:4000. There is no error it just hangs but if I try a port that isn't being used like localhost:5000 then the browser says that there is a connection error\nI can reproduce\nI have tried the latest version And I still cannot connect to my react dev server using port forwarding into my ssh remote\nI still have this issue in the latest version: To reproduce: node script . a request from client side: side receives only the first chunk: After this, the request gets stuck and never ends. In my case, the issue mostly affects small requests. A 10kb request always has the issue, but a 100kb request seems to be consistently fine. Size of the response also seems to be important. I connected to a distant server (with a ping of ~300 ms), but there doesn't seem to be any problem with the connection itself.\nFixed on the next Insiders. Good find, it was a latent issue that never got hit before. Root causing it was fun\nDoes this need to be verified with Remote-SSH specifically?\nYes, it requires remote SSH. You can verify this issue and at the same time by following Dador's instructions\nserver: <img width=\"319\" alt=\"image\" src=\"\"client: <img width=\"688\" alt=\"image\" src=\"\"Looks verified in latest insiders\nSorry, it does not work for me. To reproduce: Repository at After starting the devcontainer on a remote ssh-host, launch task \"Serve\". Then access http://localhost:4000.\nare you using the latest VS Code insiders?\nJust updated:\nI'm not able to reproduce that, and I doubt it's related to this issue since Containers does not use the code path in question.\nSo, different bug, same behaviour? It worked in insiders before, it still works in stable... it does not work anymore in the current insiders. Does that mean the next release will also no longer work? Edit: Just to make sure there's no misunderstanding: My devcontainer is running on a remote ssh server.\nMost likely. Sharing any contents in the Console (from the \"Developer: Toggle Developer Tools\" command) and the \"Shared\" log from the Output panel would be useful in diagnosing the issue.\nPreparing a new issue!", "positive_passages": [{"docid": "doc-en-vscode-b19a1dcf73436ba0790b4e6f2c412063ebe53b0b75f1602b2cbdb476d2ef6a8f", "text": "import { IRemoteSocketFactoryService } from 'vs/platform/remote/common/remoteSocketFactoryService'; import { ISignService } from 'vs/platform/sign/common/sign'; import { AbstractTunnelService, ISharedTunnelsService, ITunnelProvider, ITunnelService, RemoteTunnel, TunnelPrivacyId, isAllInterfaces, isLocalhost, isPortPrivileged, isTunnelProvider } from 'vs/platform/tunnel/common/tunnel'; <ins> import { VSBuffer } from 'vs/base/common/buffer'; </ins> async function createRemoteTunnel(options: IConnectionOptions, defaultTunnelHost: string, tunnelRemoteHost: string, tunnelRemotePort: number, tunnelLocalPort?: number): Promise<RemoteTunnel> { let readyTunnel: NodeRemoteTunnel | undefined;", "commid": "vscode_pr_191228"}], "negative_passages": []}
{"query_id": "q-en-vscode-06ae6fc82d2ce6609f5f67300cd120610af61afa72a4c7bda50c3d4628d004f2", "query": "Type: <bBug</bPort forwarding over ssh is not working using vscode-insiders. It is working using vscode. How to replicate: some http server on the remote the port to be forwarded and select http as a protocol opening in browser / doing a curl from your local machine the request is stuck pending VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-21T05:32:43.957Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 6.1.38-59.109.amzn2023.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (54)</summaryExtensionVersion ------ Handlebars0.4.1 vsc-python-indent1.18.0 dotenv1.0.1 remote-containers0.305.0 remote-ssh0.105.1 remote-ssh-edit0.86.0 remote-wsl0.81.0 vscode-remote-extensionpack0.24.0 remote-explorer0.4.1 remote-server1.4.2 material-icon-theme4.29.0 indent-one-space1.0.0 vscode-todo-highlight1.0.5 nugetpackagemanagergui2.0.6 Handlebars0.4.1 vue-peek1.0.2 vscode-markdownlint0.51.0 vscode-eslint2.4.2 gitlens2023.8.1905 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-jest-runner0.4.66 copilot1.104.347 copilot-chat0.7. vscode-github-actions0.26.1 todo-tree0.0.226 terraform2.27. vscode-test-explorer2.21.1 vscode-nuget-package-manager1.1.6 roslynator4.4.0 vsc-python-indent1.18.0 vscode-python-test-adapter0.7.1 dotenv1.0.1 vscode-scss0.10.0 vscode-docker1.26.0 csharp2.0.376 vscode-dotnet-runtime1.7.0 black-formatter2023.5. flake82023.7. isort2023.11. python2023.15. vscode-pylance2023.8.31 test-adapter-converter0.1.8 indent-rainbow8.3.1 material-icon-theme4.29.0 prisma5.1.0 vscode-scss-formatter3.0.0 indent-one-space1.0.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-conventional-commits1.25.0 volar1.8.8 vscode-typescript-vue-plugin1.8.8 vscode-todo-highlight1.0.5 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI can reproduce this with SSH, but not with Dev Containers. have there been any changes to SSH recently that might cause this?\nHappened to me yesterday too. Spend a lot of time rebooting my machine and killing processes until I tried regular vscode to find that port forwarding was working fine there. What is weird though is that the browser just hangs. Nothing happens if you try localhost:4000. There is no error it just hangs but if I try a port that isn't being used like localhost:5000 then the browser says that there is a connection error\nI can reproduce\nI have tried the latest version And I still cannot connect to my react dev server using port forwarding into my ssh remote\nI still have this issue in the latest version: To reproduce: node script . a request from client side: side receives only the first chunk: After this, the request gets stuck and never ends. In my case, the issue mostly affects small requests. A 10kb request always has the issue, but a 100kb request seems to be consistently fine. Size of the response also seems to be important. I connected to a distant server (with a ping of ~300 ms), but there doesn't seem to be any problem with the connection itself.\nFixed on the next Insiders. Good find, it was a latent issue that never got hit before. Root causing it was fun\nDoes this need to be verified with Remote-SSH specifically?\nYes, it requires remote SSH. You can verify this issue and at the same time by following Dador's instructions\nserver: <img width=\"319\" alt=\"image\" src=\"\"client: <img width=\"688\" alt=\"image\" src=\"\"Looks verified in latest insiders\nSorry, it does not work for me. To reproduce: Repository at After starting the devcontainer on a remote ssh-host, launch task \"Serve\". Then access http://localhost:4000.\nare you using the latest VS Code insiders?\nJust updated:\nI'm not able to reproduce that, and I doubt it's related to this issue since Containers does not use the code path in question.\nSo, different bug, same behaviour? It worked in insiders before, it still works in stable... it does not work anymore in the current insiders. Does that mean the next release will also no longer work? Edit: Just to make sure there's no misunderstanding: My devcontainer is running on a remote ssh server.\nMost likely. Sharing any contents in the Console (from the \"Developer: Toggle Developer Tools\" command) and the \"Shared\" log from the Output panel would be useful in diagnosing the issue.\nPreparing a new issue!", "positive_passages": [{"docid": "doc-en-vscode-b13fb89600829fb55415a125276e3cffba058fc05edb0548ddc616bc7481f8bc", "text": "remoteSocket.onClose(() => localSocket.destroy()); remoteSocket.onEnd(() => localSocket.end()); remoteSocket.onData(d => localSocket.write(d.buffer)); <ins> localSocket.on('data', d => remoteSocket.write(VSBuffer.wrap(d))); </ins> localSocket.resume(); }", "commid": "vscode_pr_191228"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-aef9e78ae46db1c21fdda94dc0fdede34f52eb10fcf8f612a210a6458fa1d3da", "text": "import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { ISemanticSimilarityService } from 'vs/workbench/services/semanticSimilarity/common/semanticSimilarityService'; <ins> import { IAiRelatedInformationService, RelatedInformationType, SettingInformationResult } from 'vs/workbench/services/aiRelatedInformation/common/aiRelatedInformation'; </ins> export interface IEndpointDetails { urlBase?: string;", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-b69a2bd006da62aff3a8e3b513b1d813f97cb4d2ac99fd40367fa603d9c1d265", "text": "private settingsRecord: Record<string, ISetting> = {}; private currentPreferencesModel: ISettingsEditorModel | undefined; <del> constructor(private readonly semanticSimilarityService: ISemanticSimilarityService) { } </del> <ins> constructor( private readonly aiRelatedInformationService: IAiRelatedInformationService, private readonly semanticSimilarityService: ISemanticSimilarityService ) { } </ins> updateModel(preferencesModel: ISettingsEditorModel) { if (preferencesModel === this.currentPreferencesModel) {", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-92ec65de9f9a29cbc12cf565ca23eaaecf7dfa9a6994aa9c48ec88019dc4436c", "text": "this.settingKeys = []; this.settingsRecord = {}; <del> if (!this.semanticSimilarityService.isEnabled() || !this.currentPreferencesModel) { </del> <ins> if ( !this.currentPreferencesModel || (!this.semanticSimilarityService.isEnabled() && !this.aiRelatedInformationService.isEnabled()) ) { </ins> return; }", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-bc85faa8f9bd378b1fb49834adeb6a4001bd9e969ad4172e59be13759ffe18d3", "text": "constructor( @ISemanticSimilarityService private readonly semanticSimilarityService: ISemanticSimilarityService, <ins> @IAiRelatedInformationService private readonly aiRelatedInformationService: IAiRelatedInformationService </ins> ) { <del> this._keysProvider = new RemoteSearchKeysProvider(semanticSimilarityService); </del> <ins> this._keysProvider = new RemoteSearchKeysProvider(aiRelatedInformationService, semanticSimilarityService); </ins> } setFilter(filter: string) {", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-c6bdea6656e934c13660d009fcc5417515f4c736a4502374720c44377be9a180", "text": "} async searchModel(preferencesModel: ISettingsEditorModel, token?: CancellationToken | undefined): Promise<ISearchResult | null> { <del> if (!this.semanticSimilarityService.isEnabled() || !this._filter) { </del> <ins> if ( !this._filter || (!this.semanticSimilarityService.isEnabled() && !this.aiRelatedInformationService.isEnabled())) { </ins> return null; } this._keysProvider.updateModel(preferencesModel); <ins> const filterMatches = this.aiRelatedInformationService.isEnabled() ? await this.getAiRelatedInformationItems(token) : this.semanticSimilarityService.isEnabled() ? await this.getSemanticSimilarityItems(token) : []; return { filterMatches }; } // TODO: Remove this when all semantic similarity providers are migrated to aiRelatedInformationService private async getSemanticSimilarityItems(token?: CancellationToken | undefined) { </ins> const settingKeys = this._keysProvider.getSettingKeys(); const settingsRecord = this._keysProvider.getSettingsRecord();", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-5604f2f27fe202ca615c22a5153e4468b995065c68f3cd62f58daf30e4594955", "text": "}); numOfSmartPicks++; } <del> return { filterMatches }; </del> <ins> return filterMatches; } private async getAiRelatedInformationItems(token?: CancellationToken | undefined) { const settingsRecord = this._keysProvider.getSettingsRecord(); const filterMatches: ISettingMatch[] = []; const relatedInformation = await this.aiRelatedInformationService.getRelatedInformation(this._filter, [RelatedInformationType.SettingInformation], token ?? CancellationToken.None) as SettingInformationResult[]; relatedInformation.sort((a, b) => b.weight - a.weight); for (const info of relatedInformation) { if (info.weight < RemoteSearchProvider.SEMANTIC_SIMILARITY_THRESHOLD || filterMatches.length === RemoteSearchProvider.SEMANTIC_SIMILARITY_MAX_PICKS) { break; } const pick = info.setting; filterMatches.push({ setting: settingsRecord[pick], matches: [settingsRecord[pick].range], matchType: SettingMatchType.RemoteMatch, score: info.weight }); } return filterMatches; </ins> } }", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-37da515d4aec5a35134ff55d0d230521e6caefa8fe183707f83fcf145e417f06", "text": "command: string; } <ins> export interface SettingInformationResult extends RelatedInformationResult { type: RelatedInformationType.SettingInformation; setting: string; } </ins> export interface IAiRelatedInformationService { readonly _serviceBrand: undefined;", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-754cc54d99cc2e82dd57732356d979d8f275ffd007fa36e9e76e24563af567dd", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /\nCopyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *\n-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }", "positive_passages": [{"docid": "doc-en-vscode-9637b602b3bbfcb4b244b407e896b1dbde50ad10d34cab53c328e02b48417494", "text": "import { StopWatch } from 'vs/base/common/stopwatch'; import { ILogService } from 'vs/platform/log/common/log'; <ins> /** * @deprecated Use `IAiRelatedInformationService` instead. */ </ins> export const ISemanticSimilarityService = createDecorator<ISemanticSimilarityService>('ISemanticSimilarityService'); <ins> /** * @deprecated Use `IAiRelatedInformationService` instead. */ </ins> export interface ISemanticSimilarityService { readonly _serviceBrand: undefined;", "commid": "vscode_pr_191017"}], "negative_passages": []}
{"query_id": "q-en-vscode-543d523950ff922cd1f0eb1d9ab4f7b684d5aecdb2975a8270ca13d03d011fed", "query": "Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !\nAfter delete and undo: !", "positive_passages": [{"docid": "doc-en-vscode-03bf0006338602df8577ab6cfe80dedadcaea0449accb29ab5c07e18cf2c4f94", "text": "private _readConfiguration() { const options = this._editor.getOption(EditorOption.stickyScroll); if (options.enabled === false) { this._editor.removeOverlayWidget(this._stickyScrollWidget); this._sessionStore.clear();", "commid": "vscode_pr_191072"}], "negative_passages": []}
{"query_id": "q-en-vscode-543d523950ff922cd1f0eb1d9ab4f7b684d5aecdb2975a8270ca13d03d011fed", "query": "Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !\nAfter delete and undo: !", "positive_passages": [{"docid": "doc-en-vscode-baf4306134df6e8a7e300c1ccc5411a18f5e4bf95534a95d7ad2c3254ec033c3", "text": "} private _renderStickyScroll() { <del> if (!(this._editor.hasModel())) { </del> <ins> const model = this._editor.getModel(); if (!model || model.isTooLargeForTokenization()) { this._stickyScrollWidget.setState(undefined); </ins> return; } <del> const model = this._editor.getModel(); </del> const stickyLineVersion = this._stickyLineCandidateProvider.getVersionId(); if (stickyLineVersion === undefined || stickyLineVersion === model.getVersionId()) { this._widgetState = this.findScrollWidgetState();", "commid": "vscode_pr_191072"}], "negative_passages": []}
{"query_id": "q-en-vscode-543d523950ff922cd1f0eb1d9ab4f7b684d5aecdb2975a8270ca13d03d011fed", "query": "Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !\nAfter delete and undo: !", "positive_passages": [{"docid": "doc-en-vscode-bf9d07f22cdf1d2627ba7ef3a5950bdcacf99663d754b81f452867f95a3ed773", "text": "return this._lineNumbers; } <del> setState(state: StickyScrollWidgetState): void { dom.clearNode(this._lineNumbersDomNode); dom.clearNode(this._linesDomNode); </del> <ins> setState(state: StickyScrollWidgetState | undefined): void { this._clearStickyWidget(); if (!state) { return; } </ins> this._stickyLines = []; const editorLineHeight = this._editor.getOption(EditorOption.lineHeight); const futureWidgetHeight = state.startLineNumbers.length * editorLineHeight + state.lastLineRelativePosition;", "commid": "vscode_pr_191072"}], "negative_passages": []}
{"query_id": "q-en-vscode-543d523950ff922cd1f0eb1d9ab4f7b684d5aecdb2975a8270ca13d03d011fed", "query": "Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !\nAfter delete and undo: !", "positive_passages": [{"docid": "doc-en-vscode-4d8e855b60663640e81d33ee2ceff6fb277f60067426429292671207e180567e", "text": "this._rootDomNode.style.width = `${layoutInfo.width - layoutInfo.minimap.minimapCanvasOuterWidth - layoutInfo.verticalScrollbarWidth}px`; } <ins> private _clearStickyWidget() { dom.clearNode(this._lineNumbersDomNode); dom.clearNode(this._linesDomNode); this._rootDomNode.style.display = 'none'; } </ins> private _renderRootNode(): void { if (!this._editor._getViewModel()) {", "commid": "vscode_pr_191072"}], "negative_passages": []}
{"query_id": "q-en-vscode-543d523950ff922cd1f0eb1d9ab4f7b684d5aecdb2975a8270ca13d03d011fed", "query": "Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !\nAfter delete and undo: !", "positive_passages": [{"docid": "doc-en-vscode-1f1d70fae993b5735ed9dc37d6727f34be8cea056ce516e76a72dace79b89d8a", "text": "const editorLineHeight = this._editor.getOption(EditorOption.lineHeight); const widgetHeight: number = this._lineNumbers.length * editorLineHeight + this._lastLineRelativePosition; <del> this._rootDomNode.style.display = widgetHeight > 0 ? 'block' : 'none'; </del> <ins> if (widgetHeight === 0) { this._clearStickyWidget(); return; } this._rootDomNode.style.display = 'block'; </ins> this._lineNumbersDomNode.style.height = `${widgetHeight}px`; this._linesDomNodeScrollable.style.height = `${widgetHeight}px`; this._rootDomNode.style.height = `${widgetHeight}px`;", "commid": "vscode_pr_191072"}], "negative_passages": []}
{"query_id": "q-en-vscode-543d523950ff922cd1f0eb1d9ab4f7b684d5aecdb2975a8270ca13d03d011fed", "query": "Repro: a perf profile a ~100mb TypeScript file (duplicate the contents of a large TS file to make this) perf profile ! It doesn't end up working properly anyway: !\nAfter delete and undo: !", "positive_passages": [{"docid": "doc-en-vscode-fdb4ea15a082fa1a36c5dcdaf5c2e6f248be467f114e172aba4e5189f045eaf6", "text": "'Variable 0 will be a file name.' ] }, <del> \"{0}: tokenization, wrapping and folding have been turned off for this large file in order to reduce memory usage and avoid freezing or crashing.\", </del> <ins> \"{0}: tokenization, wrapping, folding and sticky scroll have been turned off for this large file in order to reduce memory usage and avoid freezing or crashing.\", </ins> path.basename(model.uri.path) );", "commid": "vscode_pr_191072"}], "negative_passages": []}
{"query_id": "q-en-vscode-f46c7a0aa053035c19e67a4692da9b3918f0c511f4b47f34e79057b8096e3dcb", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.1 OS Version: server 2022 Steps to Reproduce: is a system install. Users login using redirected appdata folders launch code with appdata redirected to a unc path or can launch 'code --user-data-dir servershare$code' error Unable to write program user data , code trying to write to c:share$ Users do not have access to write to c: grant full control to root of C: and launch code a new folder is created c:share$ file created c:share$codeUserglobalStorage is created and code launches does not use the unc path while all other files are written to servershare$code fine with version 1.79.2\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nbased on the above steps looks like the sqlite database is not using the unc path, passing the issue to you.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nSame issue. installed 1.82.0-insider build. Still creates the in the wrong location.\nexcellent finding! I think this is a regression from partitioning state per profile. Specifically: When using , UNC paths only work for scheme but now I think we have as scheme. I am not sure when we made that flip.\nI think this is spreading to a lot more places, the code is very old and was always assuming scheme to be used, which will not work anymore if a UNC path is used: I think we will have to make a pass over usage and find those that potentially use a non-file scheme...\nI think I start to understand the issue better, it seems quite specific to global storage only, the other in the seem to be mainly of scheme. I believe this started with moving out of the environment service and into the profile service:\nThe change to scheme started happening from this change - - I started using this scheme for all user data to adopt atomic write. Since I had reverted atomic write for user data in this commit - - I can revert to use file scheme for user data on main. But going forward, I will bring back user data scheme and probably we should our file service and uri identitiy utilities instead of using fspath and path join.\nbut there is a point where our file service is no longer in charge: when we hand of a to SQLite3 module, we really have to give it a proper path that is a UNC path if the user picked a UNC location. So just using will not help here, we need to find a way that is not breaking UNC paths in all places where we need it.\nThats right, I also observed that we browsing the storage code. May be we should convert this back to file scheme before using in those places?\nyes, doing seems right to me, even though ugly. Curious: with your custom file system provider on , are you converting back to a URI and then handing the off to the disk file system provider? Or do you convert one level above on the level of the file service? Asking, because I wonder if there is already a bug in your provider where we potentially loose UNC paths.\nThinking a bit more about this, I wonder if should statically allow us to register a scheme to behave like a scheme. Because, we do take an existing well defined of scheme and turn that into . This in turn means, every client that deals with such a would need to ensure that the scheme is converted back to before using the . That seems fragile. If we could tell to treat like a scheme, maybe the change would be easier and less fragile?\nIMO this is as ugly as using on URI, because it can cause issues anytime. Even if you know the scheme of the URI converting to file scheme is always safe. Here is the conversion logic: This is handled in the FSP of vscode-userdata. I just change the scheme and pass it to the native FSP.", "positive_passages": [{"docid": "doc-en-vscode-eb14f2578ca4ada6a2f29614777df455d572e64f496ea675bc5f1d5756fa6f75", "text": "import { memoize } from 'vs/base/common/decorators'; import { join } from 'vs/base/common/path'; import { isLinux } from 'vs/base/common/platform'; <ins> import { URI } from 'vs/base/common/uri'; </ins> import { createStaticIPCHandle } from 'vs/base/parts/ipc/node/ipc.net'; import { IEnvironmentService, INativeEnvironmentService } from 'vs/platform/environment/common/environment'; import { NativeEnvironmentService } from 'vs/platform/environment/node/environmentService';", "commid": "vscode_pr_191607"}], "negative_passages": []}
{"query_id": "q-en-vscode-f46c7a0aa053035c19e67a4692da9b3918f0c511f4b47f34e79057b8096e3dcb", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.1 OS Version: server 2022 Steps to Reproduce: is a system install. Users login using redirected appdata folders launch code with appdata redirected to a unc path or can launch 'code --user-data-dir servershare$code' error Unable to write program user data , code trying to write to c:share$ Users do not have access to write to c: grant full control to root of C: and launch code a new folder is created c:share$ file created c:share$codeUserglobalStorage is created and code launches does not use the unc path while all other files are written to servershare$code fine with version 1.79.2\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nbased on the above steps looks like the sqlite database is not using the unc path, passing the issue to you.\nCan you try to reproduce with our nightly insider builds? You can give our preview releases a try from:\nSame issue. installed 1.82.0-insider build. Still creates the in the wrong location.\nexcellent finding! I think this is a regression from partitioning state per profile. Specifically: When using , UNC paths only work for scheme but now I think we have as scheme. I am not sure when we made that flip.\nI think this is spreading to a lot more places, the code is very old and was always assuming scheme to be used, which will not work anymore if a UNC path is used: I think we will have to make a pass over usage and find those that potentially use a non-file scheme...\nI think I start to understand the issue better, it seems quite specific to global storage only, the other in the seem to be mainly of scheme. I believe this started with moving out of the environment service and into the profile service:\nThe change to scheme started happening from this change - - I started using this scheme for all user data to adopt atomic write. Since I had reverted atomic write for user data in this commit - - I can revert to use file scheme for user data on main. But going forward, I will bring back user data scheme and probably we should our file service and uri identitiy utilities instead of using fspath and path join.\nbut there is a point where our file service is no longer in charge: when we hand of a to SQLite3 module, we really have to give it a proper path that is a UNC path if the user picked a UNC location. So just using will not help here, we need to find a way that is not breaking UNC paths in all places where we need it.\nThats right, I also observed that we browsing the storage code. May be we should convert this back to file scheme before using in those places?\nyes, doing seems right to me, even though ugly. Curious: with your custom file system provider on , are you converting back to a URI and then handing the off to the disk file system provider? Or do you convert one level above on the level of the file service? Asking, because I wonder if there is already a bug in your provider where we potentially loose UNC paths.\nThinking a bit more about this, I wonder if should statically allow us to register a scheme to behave like a scheme. Because, we do take an existing well defined of scheme and turn that into . This in turn means, every client that deals with such a would need to ensure that the scheme is converted back to before using the . That seems fragile. If we could tell to treat like a scheme, maybe the change would be easier and less fragile?\nIMO this is as ugly as using on URI, because it can cause issues anytime. Even if you know the scheme of the URI converting to file scheme is always safe. Here is the conversion logic: This is handled in the FSP of vscode-userdata. I just change the scheme and pass it to the native FSP.", "positive_passages": [{"docid": "doc-en-vscode-acbb8bd801fa0aefbd2b5df1da2d66f6a294ddcbdc9b3b9bbabc2f4879b8601e", "text": "@memoize get useCodeCache(): boolean { return !!this.codeCachePath; } <ins> @memoize override get userRoamingDataHome(): URI { return this.appSettingsHome; } </ins> unsetSnapExportedVariables() { if (!isLinux) { return;", "commid": "vscode_pr_191607"}], "negative_passages": []}
{"query_id": "q-en-vscode-c825587e90b7d7c54319184cfefdb0db68cd162cfff9ac4421ffdb20125997d0", "query": "It should be just \"Copy Output\", the \"to Clipboard\" is obvious? This then aligns with other copy actions across the product Testing", "positive_passages": [{"docid": "doc-en-vscode-801d980c19cc1ea63b432cd85831472eb6f32e38359326795ea5dc2320d058cb", "text": "\"title\": \"%cleanInvalidImageAttachment.title%\" }, { <del> \"command\": \"notebook.cellOutput.copyToClipboard\", \"title\": \"%copyOutputToClipboard.title%\" </del> <ins> \"command\": \"notebook.cellOutput.copy\", \"title\": \"%copyCellOutput.title%\" </ins> } ], \"notebooks\": [", "commid": "vscode_pr_191816"}], "negative_passages": []}
{"query_id": "q-en-vscode-c825587e90b7d7c54319184cfefdb0db68cd162cfff9ac4421ffdb20125997d0", "query": "It should be just \"Copy Output\", the \"to Clipboard\" is obvious? This then aligns with other copy actions across the product Testing", "positive_passages": [{"docid": "doc-en-vscode-1a2d03669e47d228c0a11ccd184e96b98919c4c7960ed47b82b977e5e754b7dd", "text": "], \"webview/context\": [ { <del> \"command\": \"notebook.cellOutput.copyToClipboard\", </del> <ins> \"command\": \"notebook.cellOutput.copy\", </ins> \"when\": \"webviewId == 'notebook.output' && webviewSection == 'image'\" } ]", "commid": "vscode_pr_191816"}], "negative_passages": []}
{"query_id": "q-en-vscode-c825587e90b7d7c54319184cfefdb0db68cd162cfff9ac4421ffdb20125997d0", "query": "It should be just \"Copy Output\", the \"to Clipboard\" is obvious? This then aligns with other copy actions across the product Testing", "positive_passages": [{"docid": "doc-en-vscode-66a3e28e23b92bd6d9c0026b36348b6554b8ceafb5e0283953bcce55f09c8d5c", "text": "\"newUntitledIpynb.shortTitle\": \"Jupyter Notebook\", \"openIpynbInNotebookEditor.title\": \"Open IPYNB File In Notebook Editor\", \"cleanInvalidImageAttachment.title\": \"Clean Invalid Image Attachment Reference\", <del> \"copyOutputToClipboard.title\": \"Copy Output to Clipboard\", </del> <ins> \"copyCellOutput.title\": \"Copy Output\", </ins> \"markdownAttachmentRenderer.displayName\": { \"message\": \"Markdown-It ipynb Cell Attachment renderer\", \"comment\": [", "commid": "vscode_pr_191816"}], "negative_passages": []}
{"query_id": "q-en-vscode-c825587e90b7d7c54319184cfefdb0db68cd162cfff9ac4421ffdb20125997d0", "query": "It should be just \"Copy Output\", the \"to Clipboard\" is obvious? This then aligns with other copy actions across the product Testing", "positive_passages": [{"docid": "doc-en-vscode-61fb63b08d8c87ac320723a3011fed0a6836fb33aca35d7ec57db2fccef936c6", "text": "import { CellKind } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { CodeCellViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/codeCellViewModel'; <del> export const COPY_OUTPUT_COMMAND_ID = 'notebook.cellOutput.copyToClipboard'; </del> <ins> export const COPY_OUTPUT_COMMAND_ID = 'notebook.cellOutput.copy'; </ins> registerAction2(class CopyCellOutputAction extends Action2 { constructor() { super({ id: COPY_OUTPUT_COMMAND_ID, <del> title: localize('notebookActions.copyOutput', \"Copy Output to Clipboard\"), </del> <ins> title: localize('notebookActions.copyOutput', \"Copy Output\"), </ins> menu: { id: MenuId.NotebookOutputToolbar, when: NOTEBOOK_CELL_HAS_OUTPUTS", "commid": "vscode_pr_191816"}], "negative_passages": []}
{"query_id": "q-en-vscode-8e2347e6b4e880b13466128570a1637f9375286dadd85e033d935773cb2a047b", "query": "Testing open execute a cell that shows issues select copy output no output is copied I'd except that this \"just works\", at least for its text/markdown output representation", "positive_passages": [{"docid": "doc-en-vscode-29dee07a6f203193a8c35400dd9de48d84c4d14468e1945f63f2f874ace86a17", "text": "'application/x.notebook.stream', 'application/vnd.code.notebook.stderr', 'application/x.notebook.stderr', <del> 'text/plain' </del> <ins> 'text/plain', 'text/markdown', 'application/json' </ins> ];", "commid": "vscode_pr_191829"}], "negative_passages": []}
{"query_id": "q-en-vscode-cacb02222ea2c836493115c2595fb18e6b7429c4a0a8a2b485d5b2929c248a7b", "query": "Going through the error logs showed the error below . No steps but it is rooted at this line\nverification - Perform a few actions in a notebook, add cells, run cells, close/reopen the tab, run more cells Open the dev tools and ensure the error is not in the console", "positive_passages": [{"docid": "doc-en-vscode-bd36ebd200b6ad15f5d7abbc01bdd3e92977464a64f80dc4520a57268f781a1a", "text": "this._loadState(); this._register(this._storageService.onWillSaveState(() => this._saveState())); this._register(this._storageService.onDidChangeValue(StorageScope.WORKSPACE, NotebookKernelHistoryService.STORAGE_KEY, this._register(new DisposableStore()))(() => { <del> this._restoreState(); </del> <ins> this._loadState(); </ins> })); }", "commid": "vscode_pr_194815"}], "negative_passages": []}
{"query_id": "q-en-vscode-cacb02222ea2c836493115c2595fb18e6b7429c4a0a8a2b485d5b2929c248a7b", "query": "Going through the error logs showed the error below . No steps but it is rooted at this line\nverification - Perform a few actions in a notebook, add cells, run cells, close/reopen the tab, run more cells Open the dev tools and ensure the error is not in the console", "positive_passages": [{"docid": "doc-en-vscode-286e3c8244b3b962690609cc286e66c6a86ad9063d015bc5c9cca1a9e165aa62", "text": "} } <del> private _restoreState(): void { const serialized = this._storageService.get(NotebookKernelHistoryService.STORAGE_KEY, StorageScope.WORKSPACE); if (serialized) { try { for (const [viewType, kernels] of JSON.parse(serialized)) { const linkedMap = this._mostRecentKernelsMap[viewType] ?? new LinkedMap<string, string>(); for (const entry of kernels.entries) { linkedMap.set(entry, entry, Touch.AsOld); } this._mostRecentKernelsMap[viewType] = linkedMap; } } catch (e) { console.error('Deserialize notebook kernel history failed', e); } } } </del> private _loadState(): void { const serialized = this._storageService.get(NotebookKernelHistoryService.STORAGE_KEY, StorageScope.WORKSPACE); if (serialized) {", "commid": "vscode_pr_194815"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-633d4c3f67a744d4fa8a73ff997d1eb56bcccf1e712a930c24387422488b361b", "text": "import { workspace, window, languages, commands, ExtensionContext, extensions, Uri, ColorInformation, Diagnostic, StatusBarAlignment, TextEditor, TextDocument, FormattingOptions, CancellationToken, FoldingRange, <del> ProviderResult, TextEdit, Range, Position, Disposable, CompletionItem, CompletionList, CompletionContext, Hover, MarkdownString, FoldingContext, DocumentSymbol, SymbolInformation, l10n, TextEditorOptions </del> <ins> ProviderResult, TextEdit, Range, Position, Disposable, CompletionItem, CompletionList, CompletionContext, Hover, MarkdownString, FoldingContext, DocumentSymbol, SymbolInformation, l10n </ins> } from 'vscode'; import { LanguageClientOptions, RequestType, NotificationType, FormattingOptions as LSPFormattingOptions,", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-4fabef0af7507fa467e3ed075ed4bc6e5abc885577ece8c54ea0f8b4f3e36e72", "text": "export namespace SettingIds { export const enableFormatter = 'json.format.enable'; export const enableKeepLines = 'json.format.keepLines'; <del> export const enableSortOnSave = 'json.sortOnSave.enable'; </del> export const enableValidation = 'json.validate.enable'; export const enableSchemaDownload = 'json.schemaDownload.enable'; export const maxItemsComputed = 'json.maxItemsComputed';", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-e250b5d04f2cd12b888f9a128c7d4ddeda71cb5143bda700121df2fbdb1ad777", "text": "window.showInformationMessage(l10n.t('JSON schema cache cleared.')); })); <del> toDispose.push(workspace.onWillSaveTextDocument(event => { const sortOnSave = workspace.getConfiguration().get<boolean>(SettingIds.enableSortOnSave); const document = event.document; if (sortOnSave && (document.languageId === 'json' || document.languageId === 'jsonc')) { const documentOptions = getOptionsForDocument(document); const textEditsPromise = getSortTextEdits(document, documentOptions?.tabSize, documentOptions?.insertSpaces); event.waitUntil(textEditsPromise); } })); </del> toDispose.push(commands.registerCommand('json.sort', async () => {", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-1ad463eb6de4f25d173c36033b1774619dcd1c21276899adc4aafeeaf1cf4d09", "text": "function isSchemaResolveError(d: Diagnostic) { return d.code === /* SchemaResolveError */ 0x300; } <del> function getOptionsForDocument(document: TextDocument): TextEditorOptions | undefined { for (const editor of window.visibleTextEditors) { if (editor.document.uri.toString() === document.uri.toString()) { return editor.options; } } return; } </del>", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-59f374578101a91a42748b09e403825911116af59c24d108bf7952854434d499", "text": "\"default\": false, \"description\": \"%json.format.keepLines.desc%\" }, <del> \"json.sortOnSave.enable\": { \"type\": \"boolean\", \"scope\": \"window\", \"default\": false, \"description\": \"%json.sortOnSave.enable.desc%\" }, </del> \"json.trace.server\": { \"type\": \"string\", \"scope\": \"window\",", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-91cec486ab75689743047353b7b99d6d86ac1d4f3be3a1de2257d86febc50116", "text": "\"json.schemas.schema.desc\": \"The schema definition for the given URL. The schema only needs to be provided to avoid accesses to the schema URL.\", \"json.format.enable.desc\": \"Enable/disable default JSON formatter\", \"json.format.keepLines.desc\" : \"Keep all existing new lines when formatting.\", <del> \"json.sortOnSave.enable.desc\": \"Enable/disable default sorting on save\", </del> \"json.validate.enable.desc\": \"Enable/disable JSON validation.\", \"json.tracing.desc\": \"Traces the communication between VS Code and the JSON language server.\", \"json.colorDecorators.enable.desc\": \"Enables or disables color decorators\",", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-232c98c14ceb74f894862c2bcab41fcf9d91003d8d49a065888249e72a9d05b5", "text": "import { Connection, TextDocuments, InitializeParams, InitializeResult, NotificationType, RequestType, <del> DocumentRangeFormattingRequest, Disposable, ServerCapabilities, TextDocumentSyncKind, TextEdit, DocumentFormattingRequest, TextDocumentIdentifier, FormattingOptions, Diagnostic </del> <ins> DocumentRangeFormattingRequest, Disposable, ServerCapabilities, TextDocumentSyncKind, TextEdit, DocumentFormattingRequest, TextDocumentIdentifier, FormattingOptions, Diagnostic, CodeAction, CodeActionKind </ins> } from 'vscode-languageserver'; import { runSafe, runSafeAsync } from './utils/runner';", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-4db652586d1154e5f0e5ecf414c673702e6b3b0e7cd834661f8241aaa3ffcc87", "text": "import { TextDocument, JSONDocument, JSONSchema, getLanguageService, DocumentLanguageSettings, SchemaConfiguration, ClientCapabilities, Range, Position, SortOptions } from 'vscode-json-languageservice'; import { getLanguageModelCache } from './languageModelCache'; import { Utils, URI } from 'vscode-uri'; <ins> import * as l10n from '@vscode/l10n'; </ins> type ISchemaAssociations = Record<string, string[]>;", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-4dc458e1836f48c7d06b61f69fc0291276d89dc74985f59354eb24793837c28a", "text": "documentSelector: null, interFileDependencies: false, workspaceDiagnostics: false <del> } </del> <ins> }, codeActionProvider: true </ins> }; return { capabilities };", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-e765ae9f5dd77ecb03bce7bda78475c151b7ba16fa08fd974931a2fe5440973e", "query": "Testing Should be exposed using a code action (specifically a source action) instead of as a setting? Some advantages: We can reuse the existing setting instead of adding a new one Sorting will play nicer with other source actions since users can configure the order in which the actions run Users can trigger source actions through the context menu or with keybindings\nHey that's a good idea! I'll discuss it with the team. What do you think ?\nYes, makes sense!", "positive_passages": [{"docid": "doc-en-vscode-8a9a4e56ad8ce33455f951cce1c450af1ed5df6f1bcb22cc05a857468c74388d", "text": "}, [], `Error while computing document symbols for ${documentSymbolParams.textDocument.uri}`, token); }); <ins> connection.onCodeAction((codeActionParams, token) => { return runSafeAsync(runtime, async () => { const document = documents.get(codeActionParams.textDocument.uri); if (document) { const sortCodeAction = CodeAction.create('Sort JSON', CodeActionKind.Source.concat('.sort', '.json')); sortCodeAction.command = { command: 'json.sort', title: l10n.t('Sort JSON') }; return [sortCodeAction]; } return []; }, [], `Error while computing code actions for ${codeActionParams.textDocument.uri}`, token); }); </ins> function onFormat(textDocument: TextDocumentIdentifier, range: Range | undefined, options: FormattingOptions): TextEdit[] { options.keepLines = keepLinesEnabled;", "commid": "vscode_pr_191809"}], "negative_passages": []}
{"query_id": "q-en-vscode-9dc8a982d530b5654ce8132aeaa3be42b9ddc1db953d2f91b882048cb5951b0f", "query": "Type: <bBug</bI am developing a VS code debugger extension by inheriting from DebugSession class. I implement disassembleRequest method to support disassembly view. But now there is a strange bug which I am not sure whether it is the bug of VS code or not. When disassembly view is firstly open, it shows wrong addresses and instructions. But after I scroll mouse up and down to manually refresh disassembly view, it shows correct addresses and instructions. So it seems it is a refresh issue. I have inspected the returned data to VS code and I am sure data is correct. BTW, if the returned data deos not contain source information, then the address and data is correct. I also post a question in stackoverflow: The question contains two picutures which should be able to describe my issue. Thanks! VS Code version: Code 1.82.0 (, 2023-09-06T22:07:07.438Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ biosdbgv44.1.2 vscode-eslint2.4.2 workspace-storage-cleanup1.1.5 isort2023.10.1 python2023.16.0 vscode-pylance2023.9.10 cpptools1.17.5 hexeditor1.9.12 memory-viewer0.0.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nCould you try this in the latest VS Code Insiders build? A bunch of disassembly view fixes just went in\nI test on the latest VS code insiders 1.83.0, and the issue still exists. Please see below pictures When disassembly view is firstly open: ! After scroll mouse up and down to refresh disassembly view: !\nCan you please either share your extension/a reproduction, or share a log of the DAP messages sent and received by your debugger?\nHi Connor, I have sent disassembly message to your email Thanks! Bill Zhang\nHi Connor, below is the implementation of disassembleRequest: protected async disassembleRequest(response: DebugProtocol.DisassembleResponse, args: DebugProtocol.DisassembleArguments) { try { const baseAddress = args.memoryReference; const offset = 0; const instructionOffset = args.instructionOffset 0; const instructionCount = args.instructionCount; const input = { baseAddress: baseAddress, offset: offset, instructionOffset: instructionOffset, instructionCount: instructionCount }; const instructionList: BIOSDBGInstruction[] = []; const output = await callRpcMethod(\"Disassemble\", input); for (const item of output) { const addressHex = '0x' + item.address; const instruction = new BIOSDBGInstruction(addressHex, item.instruction, item.instructionBytes); if (item.sourcePath !== \"\" && item.lineNumber 0) { instruction.location = this.createSource(item.sourcePath); = item.lineNumber; } (instruction); } = { instructions: instructionList }; } finally { this.sendResponse(response); } }\nYep, got it, thanks. My plate is full right now but I'll look into this within the next couple weeks.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nTested with 1.84.0-insiders, it seems that this issue is fixed. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-e0b31b961c9e8c53fa12aba4a234702bc9145f16f66efd884e604b907c0f9ff5", "text": "const startN = binarySearch2(da.length, i => Number(da.row(i).address - firstAddr)); const start = startN < 0 ? ~startN : startN; const endN = binarySearch2(da.length, i => Number(da.row(i).address - lastAddr)); <del> const end = endN < 0 ? ~endN : endN; </del> <ins> const end = endN < 0 ? ~endN : endN + 1; </ins> const toDelete = end - start; // Go through everything we're about to add, and only show the source", "commid": "vscode_pr_194937"}], "negative_passages": []}
{"query_id": "q-en-vscode-9dc8a982d530b5654ce8132aeaa3be42b9ddc1db953d2f91b882048cb5951b0f", "query": "Type: <bBug</bI am developing a VS code debugger extension by inheriting from DebugSession class. I implement disassembleRequest method to support disassembly view. But now there is a strange bug which I am not sure whether it is the bug of VS code or not. When disassembly view is firstly open, it shows wrong addresses and instructions. But after I scroll mouse up and down to manually refresh disassembly view, it shows correct addresses and instructions. So it seems it is a refresh issue. I have inspected the returned data to VS code and I am sure data is correct. BTW, if the returned data deos not contain source information, then the address and data is correct. I also post a question in stackoverflow: The question contains two picutures which should be able to describe my issue. Thanks! VS Code version: Code 1.82.0 (, 2023-09-06T22:07:07.438Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ biosdbgv44.1.2 vscode-eslint2.4.2 workspace-storage-cleanup1.1.5 isort2023.10.1 python2023.16.0 vscode-pylance2023.9.10 cpptools1.17.5 hexeditor1.9.12 memory-viewer0.0.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nCould you try this in the latest VS Code Insiders build? A bunch of disassembly view fixes just went in\nI test on the latest VS code insiders 1.83.0, and the issue still exists. Please see below pictures When disassembly view is firstly open: ! After scroll mouse up and down to refresh disassembly view: !\nCan you please either share your extension/a reproduction, or share a log of the DAP messages sent and received by your debugger?\nHi Connor, I have sent disassembly message to your email Thanks! Bill Zhang\nHi Connor, below is the implementation of disassembleRequest: protected async disassembleRequest(response: DebugProtocol.DisassembleResponse, args: DebugProtocol.DisassembleArguments) { try { const baseAddress = args.memoryReference; const offset = 0; const instructionOffset = args.instructionOffset 0; const instructionCount = args.instructionCount; const input = { baseAddress: baseAddress, offset: offset, instructionOffset: instructionOffset, instructionCount: instructionCount }; const instructionList: BIOSDBGInstruction[] = []; const output = await callRpcMethod(\"Disassemble\", input); for (const item of output) { const addressHex = '0x' + item.address; const instruction = new BIOSDBGInstruction(addressHex, item.instruction, item.instructionBytes); if (item.sourcePath !== \"\" && item.lineNumber 0) { instruction.location = this.createSource(item.sourcePath); = item.lineNumber; } (instruction); } = { instructions: instructionList }; } finally { this.sendResponse(response); } }\nYep, got it, thanks. My plate is full right now but I'll look into this within the next couple weeks.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nTested with 1.84.0-insiders, it seems that this issue is fixed. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-a70bd2bf106628148c7f4e84188dc6fa302aecb20e53adcc805644f83fee6191", "text": "let textModel: ITextModel | undefined = undefined; const sourceSB = new StringBuilder(10000); const ref = await this.textModelService.createModelReference(sourceURI); <ins> if (templateData.currentElement.element !== element) { return; // avoid a race, #192831 } </ins> textModel = ref.object.textEditorModel; templateData.cellDisposable.push(ref);", "commid": "vscode_pr_194937"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-cbfaacd6e89d6a47ddca00864788724ea3a06df52cfa83d094ba953a5ca04692", "text": "rename(title?: string): Promise<void>; /** <del> * Triggers a quick pick to change the icon of this terminal. </del> <ins> * Sets or triggers a quick pick to change the icon of this terminal. </ins> */ <del> changeIcon(): Promise<void>; </del> <ins> changeIcon(icon?: TerminalIcon): Promise<TerminalIcon | undefined>; </ins> /** <del> * Triggers a quick pick to change the color of the associated terminal tab icon. </del> <ins> * Sets or triggers a quick pick to change the color of the associated terminal tab icon. </ins> */ <del> changeColor(): Promise<void>; </del> <ins> changeColor(color?: string): Promise<string | undefined>; </ins> /** * Triggers a quick pick that displays recent commands or cwds. Selecting one will", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-fa5a0fef2cca73974b6fc896f0d1038b081ab50a61066054ee3510290293ab1e", "text": "import { INotificationService, Severity } from 'vs/platform/notification/common/notification'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { IPickOptions, IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput'; <del> import { ITerminalProfile, TerminalExitReason, TerminalLocation, TerminalSettingId } from 'vs/platform/terminal/common/terminal'; </del> <ins> import { ITerminalProfile, TerminalExitReason, TerminalIcon, TerminalLocation, TerminalSettingId } from 'vs/platform/terminal/common/terminal'; </ins> import { IWorkspaceContextService, IWorkspaceFolder } from 'vs/platform/workspace/common/workspace'; import { PICK_WORKSPACE_FOLDER_COMMAND_ID } from 'vs/workbench/browser/actions/workspaceCommands'; import { CLOSE_EDITOR_COMMAND_ID } from 'vs/workbench/browser/parts/editor/editorCommands';", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-305b5cafd341837cffb873ec3f106b04b7b5d390b41ca10c0561e99669d3b2b1", "text": "title: terminalStrings.changeIcon, f1: false, precondition: ContextKeyExpr.and(ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), TerminalContextKeys.tabsSingularSelection), <del> run: (c, accessor) => getSelectedInstances(accessor)?.[0].changeIcon() </del> <ins> run: async (c, accessor) => { let icon: TerminalIcon | undefined; for (const terminal of getSelectedInstances(accessor) ?? []) { icon = await terminal.changeIcon(icon); } } </ins> }); registerTerminalAction({", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-642331a1b38d1370eb8096c5a03579f6c39e5891037cdde92eb2ab4a67baf0bf", "text": "title: terminalStrings.changeColor, f1: false, precondition: ContextKeyExpr.and(ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), TerminalContextKeys.tabsSingularSelection), <del> run: (c, accessor) => getSelectedInstances(accessor)?.[0].changeColor() </del> <ins> run: async (c, accessor) => { let color: string | undefined; for (const terminal of getSelectedInstances(accessor) ?? []) { color = await terminal.changeColor(color); } } </ins> }); registerTerminalAction({", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-ef2cd241fa1538a139fb259893ed104573b193fc43f20496c0d904002b88d9b9", "text": "run: (c, accessor) => accessor.get(ICommandService).executeCommand(CLOSE_EDITOR_COMMAND_ID) }); <del> registerContextualInstanceAction({ </del> <ins> registerTerminalAction({ </ins> id: TerminalCommandId.KillActiveTab, title: terminalStrings.kill, f1: false,", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-82bcfa594f5cbc21ccc3ffff524d2eefc399659287d195a5b3be9505df9318ec", "text": "weight: KeybindingWeight.WorkbenchContrib, when: TerminalContextKeys.tabsFocus }, <del> run: (instance, c) => c.service.safeDisposeTerminal(instance), runAfter: (instances, c) => c.groupService.focusTabs() </del> <ins> run: async (c, accessor) => { for (const terminal of getSelectedInstances(accessor) ?? []) { c.service.safeDisposeTerminal(terminal); } c.groupService.focusTabs(); } </ins> }); registerTerminalAction({", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-4e0840efa5f545e9d390c9025159151341096c43ed4a959103c22abee9bf64e3", "text": "} } <del> async changeIcon() { </del> <ins> async changeIcon(icon?: TerminalIcon): Promise<TerminalIcon | undefined> { if (icon) { this._icon = icon; this._onIconChanged.fire({ instance: this, userInitiated: true }); return icon; } </ins> type Item = IQuickPickItem & { icon: TerminalIcon }; const items: Item[] = []; for (const icon of getAllCodicons()) {", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-a518b4b7bcfee6cd55642bf8e3fbd3cb1a5927663bbd07ebea58ae432c107113", "text": "if (result) { this._icon = result.icon; this._onIconChanged.fire({ instance: this, userInitiated: true }); <ins> return this._icon; </ins> } <ins> return; </ins> } <del> async changeColor() { </del> <ins> async changeColor(color?: string): Promise<string | undefined> { if (color) { this.shellLaunchConfig.color = color; this._onIconChanged.fire({ instance: this, userInitiated: true }); return color; } </ins> const icon = this._getIcon(); if (!icon) { return;", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-030a6ab80cf93ee5b2bb97e7539a80db4cdae79edf4d2036f8c30e8b129e8218", "query": "Repro: Open multiple terminals Select multiple terminal tabs Right click and change color Change color only a single terminal is changed Real context stored with the action was done recently as part of Related:\n/duplicate\nTracking each action separately\nThanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!\nI'm not sure this is worth fixing as color is meant to differentiate between tabs. Same for the icon/ renaming.\nyou might want multiple red though, right now it doesn't work as expected. We were actually doing this wrong by querying which tabs were selected also, after we get the actual instances this was triggered on passed into the action, so we can probably remove the special tab instance command as part of this.", "positive_passages": [{"docid": "doc-en-vscode-916478a5c51c094ce8978f289191f4bc3118fd2e099d1565c06fe1d023691859", "text": "quickPick.hide(); colorStyleDisposable.dispose(); <ins> return result?.id; </ins> } selectPreviousSuggestion(): void {", "commid": "vscode_pr_197962"}], "negative_passages": []}
{"query_id": "q-en-vscode-53b96a7dd1fe897bfdb4ef810197dbaca883bcf9726908c98a5d91edb62dfef1", "query": "Testing ! Option + Down/Up arrow in terminal is not navigating between commands. These are working only in accessibility view. In terminal the keybindings are cmd + Down/Up arrow.\nI'm experiencing the same issue testing on Windows 11.\nThis text should say in the accessible view - the keybinding is meant to work there, not in the terminal.\nsame issue! All the other commands work fine, arrows/screen reader work fine in the quick pick after command is run. I am wondering though if the keybinding for prev/next commands might be too generic?\nEveryone, the prev/next commands must be run in the terminal's accessible view - not the terminal. Can you pls test that? I plan to make that clear by tweaking the dialog's text.\nYes, it worked in the terminal accessible view for me (as it sounds like it did for too).\nWorked fine for me too! Sorry for the mixup\nThanks definitely see why you were confused though, so will fix that\nto verify, open the accessibility help dialog by focusing a terminal and using . verify that the specify that they're to be applied in the terminal accessible view.", "positive_passages": [{"docid": "doc-en-vscode-93102b865e1ce704ae87d1c4d07dcfa91599185ccc8e9f2c39235edc5145def4", "text": "const keys = ['audioCues.diffLineDeleted', 'audioCues.diffLineInserted', 'audioCues.diffLineModified']; const content = [ localize('msg1', \"You are in a diff editor.\"), <del> localize('msg2', \"View the next {0} or previous {1} diff in diff review mode that is optimized for screen readers.\", next, previous), </del> <ins> localize('msg2', \"View the next ({0}) or previous ({1}) diff in diff review mode that is optimized for screen readers.\", next, previous), </ins> localize('msg3', \"To control which audio cues should be played, the following settings can be configured: {0}.\", keys.join(', ')), ]; const commentCommandInfo = getCommentCommandInfo(keybindingService, contextKeyService, codeEditor);", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-53b96a7dd1fe897bfdb4ef810197dbaca883bcf9726908c98a5d91edb62dfef1", "query": "Testing ! Option + Down/Up arrow in terminal is not navigating between commands. These are working only in accessibility view. In terminal the keybindings are cmd + Down/Up arrow.\nI'm experiencing the same issue testing on Windows 11.\nThis text should say in the accessible view - the keybinding is meant to work there, not in the terminal.\nsame issue! All the other commands work fine, arrows/screen reader work fine in the quick pick after command is run. I am wondering though if the keybinding for prev/next commands might be too generic?\nEveryone, the prev/next commands must be run in the terminal's accessible view - not the terminal. Can you pls test that? I plan to make that clear by tweaking the dialog's text.\nYes, it worked in the terminal accessible view for me (as it sounds like it did for too).\nWorked fine for me too! Sorry for the mixup\nThanks definitely see why you were confused though, so will fix that\nto verify, open the accessibility help dialog by focusing a terminal and using . verify that the specify that they're to be applied in the terminal accessible view.", "positive_passages": [{"docid": "doc-en-vscode-fafe265892e3d9cb83c57b3312b194aa2a7acd6782c98bd6b30d3dfc6d43402d", "text": "import { killTerminalIcon, newTerminalIcon } from 'vs/workbench/contrib/terminal/browser/terminalIcons'; import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; import { Iterable } from 'vs/base/common/iterator'; <del> import { AccessibleViewProviderId, accessibleViewCurrentProviderId, accessibleViewOnLastLine } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </del> <ins> import { AccessibleViewProviderId, accessibleViewCurrentProviderId, accessibleViewIsShown, accessibleViewOnLastLine } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </ins> export const switchTerminalActionViewItemSeparator = 'u2500u2500u2500u2500u2500u2500u2500u2500u2500'; export const switchTerminalShowTabsTitle = localize('showTerminalTabs', \"Show Tabs\");", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-53b96a7dd1fe897bfdb4ef810197dbaca883bcf9726908c98a5d91edb62dfef1", "query": "Testing ! Option + Down/Up arrow in terminal is not navigating between commands. These are working only in accessibility view. In terminal the keybindings are cmd + Down/Up arrow.\nI'm experiencing the same issue testing on Windows 11.\nThis text should say in the accessible view - the keybinding is meant to work there, not in the terminal.\nsame issue! All the other commands work fine, arrows/screen reader work fine in the quick pick after command is run. I am wondering though if the keybinding for prev/next commands might be too generic?\nEveryone, the prev/next commands must be run in the terminal's accessible view - not the terminal. Can you pls test that? I plan to make that clear by tweaking the dialog's text.\nYes, it worked in the terminal accessible view for me (as it sounds like it did for too).\nWorked fine for me too! Sorry for the mixup\nThanks definitely see why you were confused though, so will fix that\nto verify, open the accessibility help dialog by focusing a terminal and using . verify that the specify that they're to be applied in the terminal accessible view.", "positive_passages": [{"docid": "doc-en-vscode-fdff3fb11dfbc4b215bd7703dc85f1406ecc09a4bb4b8b85814efbf094cf596a", "text": "keybinding: [ { primary: KeyMod.CtrlCmd | KeyCode.KeyR, <del> when: ContextKeyExpr.and(TerminalContextKeys.focus, CONTEXT_ACCESSIBILITY_MODE_ENABLED), </del> <ins> when: ContextKeyExpr.and(CONTEXT_ACCESSIBILITY_MODE_ENABLED, ContextKeyExpr.or(TerminalContextKeys.focus, ContextKeyExpr.and(accessibleViewIsShown, accessibleViewCurrentProviderId.isEqualTo(AccessibleViewProviderId.Terminal)))), </ins> weight: KeybindingWeight.WorkbenchContrib }, {", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-53b96a7dd1fe897bfdb4ef810197dbaca883bcf9726908c98a5d91edb62dfef1", "query": "Testing ! Option + Down/Up arrow in terminal is not navigating between commands. These are working only in accessibility view. In terminal the keybindings are cmd + Down/Up arrow.\nI'm experiencing the same issue testing on Windows 11.\nThis text should say in the accessible view - the keybinding is meant to work there, not in the terminal.\nsame issue! All the other commands work fine, arrows/screen reader work fine in the quick pick after command is run. I am wondering though if the keybinding for prev/next commands might be too generic?\nEveryone, the prev/next commands must be run in the terminal's accessible view - not the terminal. Can you pls test that? I plan to make that clear by tweaking the dialog's text.\nYes, it worked in the terminal accessible view for me (as it sounds like it did for too).\nWorked fine for me too! Sorry for the mixup\nThanks definitely see why you were confused though, so will fix that\nto verify, open the accessibility help dialog by focusing a terminal and using . verify that the specify that they're to be applied in the terminal accessible view.", "positive_passages": [{"docid": "doc-en-vscode-ba6486d4bbedda74204080562147ab6c484ee312f35610adb76e98714e768933", "text": "if (this._hasShellIntegration) { const shellIntegrationCommandList = []; shellIntegrationCommandList.push(localize('shellIntegration', \"The terminal has a feature called shell integration that offers an enhanced experience and provides useful commands for screen readers such as:\")); <del> shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToNextCommand, localize('goToNextCommand', 'Go to Next Command ({0})'), localize('goToNextCommandNoKb', 'Go to Next Command is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToPreviousCommand, localize('goToPreviousCommand', 'Go to Previous Command ({0})'), localize('goToPreviousCommandNoKb', 'Go to Previous Command is currently not triggerable by a keybinding.'))); </del> <ins> shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToNextCommand, localize('goToNextCommand', 'Go to Next Command ({0}) in the accessible view'), localize('goToNextCommandNoKb', 'Go to Next Command in the accessible view is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToPreviousCommand, localize('goToPreviousCommand', 'Go to Previous Command ({0}) in the accessible view'), localize('goToPreviousCommandNoKb', 'Go to Previous Command in the accessible view is currently not triggerable by a keybinding.'))); </ins> shellIntegrationCommandList.push('- ' + this._descriptionForCommand(AccessibilityCommandId.GoToSymbol, localize('goToSymbol', 'Go to Symbol ({0})'), localize('goToSymbolNoKb', 'Go to symbol is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.RunRecentCommand, localize('runRecentCommand', 'Run Recent Command ({0})'), localize('runRecentCommandNoKb', 'Run Recent Command is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.GoToRecentDirectory, localize('goToRecentDirectory', 'Go to Recent Directory ({0})'), localize('goToRecentDirectoryNoKb', 'Go to Recent Directory is currently not triggerable by a keybinding.')));", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-2bfc8e03e596255fcc7ff5ba90c3abddbf23c092156c1bc76ea588ca016aaa66", "query": "Testing Start from , on a repo: The git extension will associate as the most likely candidate for 's base. But since does have an upstream, , which, at the point was created, was pointing to the same commit as itself... wouldn't be a better base candidate instead?\nI think that this makes sense to me however would you favour the remote branch (origin/foo) just because it points to the same commit as when was created or should it be a general rule that if a remote is present, we would favour it?\nWill mark this and look out for additional feedback.\nThough more about this and since we are adding and actions to the incoming node, it does make sense for it to be an upstream branch. Marking the issue as \"bug\" so that it gets verified during endgame.", "positive_passages": [{"docid": "doc-en-vscode-f999f0974bc97d5098006c476560626a1272b50a8bc7ed3a4ff30108f6a3435c", "text": "async getBranchBase(ref: string): Promise<Branch | undefined> { const branch = await this.getBranch(ref); <del> const branchMergeBaseConfigKey = `branch.${branch.name}.vscode-merge-base`; </del> <ins> const branchUpstream = await this.getUpstreamBranch(branch); </ins> <del> // Upstream if (branch.upstream) { return await this.getBranch(`refs/remotes/${branch.upstream.remote}/${branch.upstream.name}`); </del> <ins> if (branchUpstream) { return branchUpstream; </ins> } // Git config <ins> const mergeBaseConfigKey = `branch.${branch.name}.vscode-merge-base`; </ins> try { <del> const mergeBase = await this.getConfig(branchMergeBaseConfigKey); if (mergeBase !== '') { const mergeBaseBranch = await this.getBranch(mergeBase); return mergeBaseBranch; </del> <ins> const mergeBase = await this.getConfig(mergeBaseConfigKey); const branchFromConfig = mergeBase !== '' ? await this.getBranch(mergeBase) : undefined; if (branchFromConfig) { return branchFromConfig; </ins> } } catch (err) { } // Reflog const branchFromReflog = await this.getBranchBaseFromReflog(ref); <del> if (branchFromReflog) { await this.setConfig(branchMergeBaseConfigKey, branchFromReflog.name!); return branchFromReflog; </del> <ins> const branchFromReflogUpstream = branchFromReflog ? await this.getUpstreamBranch(branchFromReflog) : undefined; if (branchFromReflogUpstream) { await this.setConfig(mergeBaseConfigKey, `${branchFromReflogUpstream.remote}/${branchFromReflogUpstream.name}`); return branchFromReflogUpstream; </ins> } // Default branch const defaultBranch = await this.getDefaultBranch(); if (defaultBranch) { <del> await this.setConfig(branchMergeBaseConfigKey, defaultBranch.name!); </del> <ins> await this.setConfig(mergeBaseConfigKey, `${defaultBranch.remote}/${defaultBranch.name}`); </ins> return defaultBranch; }", "commid": "vscode_pr_202586"}], "negative_passages": []}
{"query_id": "q-en-vscode-2bfc8e03e596255fcc7ff5ba90c3abddbf23c092156c1bc76ea588ca016aaa66", "query": "Testing Start from , on a repo: The git extension will associate as the most likely candidate for 's base. But since does have an upstream, , which, at the point was created, was pointing to the same commit as itself... wouldn't be a better base candidate instead?\nI think that this makes sense to me however would you favour the remote branch (origin/foo) just because it points to the same commit as when was created or should it be a general rule that if a remote is present, we would favour it?\nWill mark this and look out for additional feedback.\nThough more about this and since we are adding and actions to the incoming node, it does make sense for it to be an upstream branch. Marking the issue as \"bug\" so that it gets verified during endgame.", "positive_passages": [{"docid": "doc-en-vscode-903ab2188e813d8d0d55daecc7e050882276f12eb709f9b8648c29a02f0bbc2f", "text": "return undefined; } <ins> private async getUpstreamBranch(branch: Branch): Promise<Branch | undefined> { if (!branch.upstream) { return undefined; } try { const upstreamBranch = await this.getBranch(`refs/remotes/${branch.upstream.remote}/${branch.upstream.name}`); return upstreamBranch; } catch (err) { this.logger.warn(`Failed to get branch details for 'refs/remotes/${branch.upstream.remote}/${branch.upstream.name}': ${err.message}.`); return undefined; } } </ins> async getRefs(query: RefQuery = {}, cancellationToken?: CancellationToken): Promise<Ref[]> { const config = workspace.getConfiguration('git'); let defaultSort = config.get<'alphabetically' | 'committerdate'>('branchSortOrder');", "commid": "vscode_pr_202586"}], "negative_passages": []}
{"query_id": "q-en-vscode-73b27c76ffea4b0dfbdae8a0614ae24e6af0a118ad5323d0144419ec6729ef6f", "query": "Testing Testing on Windows 11. opens terminal accessibility help dialog correctly: ! Explore options, decide I want to try Run Recent Command () to open terminal accessible view, opens correctly: ! Try I don't observe anything happen - but maybe I'm misunderstanding what should happen or how I should set this command up?\nSorry this was not clear. Perhaps I should specify which commands only apply when focus is in the terminal? Perhaps that should also work when the focus is in the accessible view... I will think about that.\nTo verify, focus a terminal in screen reader mode. open the terminal accessibility help dialog with and check which keybinding to use for . open the terminal accessible view by focusing the terminal and using use that key binding. make sure it runs whichever command you select.\nI think I'm still missing something in my understanding. Steps I took: Open VS Code repo in latest VS Code Insiders Toggle screen reader mode so that I'm Screen Reader Optimized Open and focus terminal , the terminal accessibility help dialog opens I note that will run recent command, and will get me to previous commands Open terminal accessible view by focusing terminal and using to get to a previous command (this worked well) Once I've gotten to a previous command I'd like to run, I try but again don't observe anything happened: !\nApologies, Brigit, it appears there's an old bug resurfacing in which the keybinding is not listed correctly in this dialog. On windows, run recent command is invoked with when in screen reader mode. On mac, with screen reader mode, it's .\nReopening to fix that\nAh yay, worked well for me, thank you! I'll hold off on labeling as if you'd also like to use this issue to track fixing the keybinding bug.\nActually, I think I'll reopen that other issue. Since the issue was the command not working, it would be great if you'd verify this and I'll link the other . Thanks\nhere's the issue where we're tracking that", "positive_passages": [{"docid": "doc-en-vscode-93102b865e1ce704ae87d1c4d07dcfa91599185ccc8e9f2c39235edc5145def4", "text": "const keys = ['audioCues.diffLineDeleted', 'audioCues.diffLineInserted', 'audioCues.diffLineModified']; const content = [ localize('msg1', \"You are in a diff editor.\"), <del> localize('msg2', \"View the next {0} or previous {1} diff in diff review mode that is optimized for screen readers.\", next, previous), </del> <ins> localize('msg2', \"View the next ({0}) or previous ({1}) diff in diff review mode that is optimized for screen readers.\", next, previous), </ins> localize('msg3', \"To control which audio cues should be played, the following settings can be configured: {0}.\", keys.join(', ')), ]; const commentCommandInfo = getCommentCommandInfo(keybindingService, contextKeyService, codeEditor);", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-73b27c76ffea4b0dfbdae8a0614ae24e6af0a118ad5323d0144419ec6729ef6f", "query": "Testing Testing on Windows 11. opens terminal accessibility help dialog correctly: ! Explore options, decide I want to try Run Recent Command () to open terminal accessible view, opens correctly: ! Try I don't observe anything happen - but maybe I'm misunderstanding what should happen or how I should set this command up?\nSorry this was not clear. Perhaps I should specify which commands only apply when focus is in the terminal? Perhaps that should also work when the focus is in the accessible view... I will think about that.\nTo verify, focus a terminal in screen reader mode. open the terminal accessibility help dialog with and check which keybinding to use for . open the terminal accessible view by focusing the terminal and using use that key binding. make sure it runs whichever command you select.\nI think I'm still missing something in my understanding. Steps I took: Open VS Code repo in latest VS Code Insiders Toggle screen reader mode so that I'm Screen Reader Optimized Open and focus terminal , the terminal accessibility help dialog opens I note that will run recent command, and will get me to previous commands Open terminal accessible view by focusing terminal and using to get to a previous command (this worked well) Once I've gotten to a previous command I'd like to run, I try but again don't observe anything happened: !\nApologies, Brigit, it appears there's an old bug resurfacing in which the keybinding is not listed correctly in this dialog. On windows, run recent command is invoked with when in screen reader mode. On mac, with screen reader mode, it's .\nReopening to fix that\nAh yay, worked well for me, thank you! I'll hold off on labeling as if you'd also like to use this issue to track fixing the keybinding bug.\nActually, I think I'll reopen that other issue. Since the issue was the command not working, it would be great if you'd verify this and I'll link the other . Thanks\nhere's the issue where we're tracking that", "positive_passages": [{"docid": "doc-en-vscode-fafe265892e3d9cb83c57b3312b194aa2a7acd6782c98bd6b30d3dfc6d43402d", "text": "import { killTerminalIcon, newTerminalIcon } from 'vs/workbench/contrib/terminal/browser/terminalIcons'; import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; import { Iterable } from 'vs/base/common/iterator'; <del> import { AccessibleViewProviderId, accessibleViewCurrentProviderId, accessibleViewOnLastLine } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </del> <ins> import { AccessibleViewProviderId, accessibleViewCurrentProviderId, accessibleViewIsShown, accessibleViewOnLastLine } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </ins> export const switchTerminalActionViewItemSeparator = 'u2500u2500u2500u2500u2500u2500u2500u2500u2500'; export const switchTerminalShowTabsTitle = localize('showTerminalTabs', \"Show Tabs\");", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-73b27c76ffea4b0dfbdae8a0614ae24e6af0a118ad5323d0144419ec6729ef6f", "query": "Testing Testing on Windows 11. opens terminal accessibility help dialog correctly: ! Explore options, decide I want to try Run Recent Command () to open terminal accessible view, opens correctly: ! Try I don't observe anything happen - but maybe I'm misunderstanding what should happen or how I should set this command up?\nSorry this was not clear. Perhaps I should specify which commands only apply when focus is in the terminal? Perhaps that should also work when the focus is in the accessible view... I will think about that.\nTo verify, focus a terminal in screen reader mode. open the terminal accessibility help dialog with and check which keybinding to use for . open the terminal accessible view by focusing the terminal and using use that key binding. make sure it runs whichever command you select.\nI think I'm still missing something in my understanding. Steps I took: Open VS Code repo in latest VS Code Insiders Toggle screen reader mode so that I'm Screen Reader Optimized Open and focus terminal , the terminal accessibility help dialog opens I note that will run recent command, and will get me to previous commands Open terminal accessible view by focusing terminal and using to get to a previous command (this worked well) Once I've gotten to a previous command I'd like to run, I try but again don't observe anything happened: !\nApologies, Brigit, it appears there's an old bug resurfacing in which the keybinding is not listed correctly in this dialog. On windows, run recent command is invoked with when in screen reader mode. On mac, with screen reader mode, it's .\nReopening to fix that\nAh yay, worked well for me, thank you! I'll hold off on labeling as if you'd also like to use this issue to track fixing the keybinding bug.\nActually, I think I'll reopen that other issue. Since the issue was the command not working, it would be great if you'd verify this and I'll link the other . Thanks\nhere's the issue where we're tracking that", "positive_passages": [{"docid": "doc-en-vscode-fdff3fb11dfbc4b215bd7703dc85f1406ecc09a4bb4b8b85814efbf094cf596a", "text": "keybinding: [ { primary: KeyMod.CtrlCmd | KeyCode.KeyR, <del> when: ContextKeyExpr.and(TerminalContextKeys.focus, CONTEXT_ACCESSIBILITY_MODE_ENABLED), </del> <ins> when: ContextKeyExpr.and(CONTEXT_ACCESSIBILITY_MODE_ENABLED, ContextKeyExpr.or(TerminalContextKeys.focus, ContextKeyExpr.and(accessibleViewIsShown, accessibleViewCurrentProviderId.isEqualTo(AccessibleViewProviderId.Terminal)))), </ins> weight: KeybindingWeight.WorkbenchContrib }, {", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-73b27c76ffea4b0dfbdae8a0614ae24e6af0a118ad5323d0144419ec6729ef6f", "query": "Testing Testing on Windows 11. opens terminal accessibility help dialog correctly: ! Explore options, decide I want to try Run Recent Command () to open terminal accessible view, opens correctly: ! Try I don't observe anything happen - but maybe I'm misunderstanding what should happen or how I should set this command up?\nSorry this was not clear. Perhaps I should specify which commands only apply when focus is in the terminal? Perhaps that should also work when the focus is in the accessible view... I will think about that.\nTo verify, focus a terminal in screen reader mode. open the terminal accessibility help dialog with and check which keybinding to use for . open the terminal accessible view by focusing the terminal and using use that key binding. make sure it runs whichever command you select.\nI think I'm still missing something in my understanding. Steps I took: Open VS Code repo in latest VS Code Insiders Toggle screen reader mode so that I'm Screen Reader Optimized Open and focus terminal , the terminal accessibility help dialog opens I note that will run recent command, and will get me to previous commands Open terminal accessible view by focusing terminal and using to get to a previous command (this worked well) Once I've gotten to a previous command I'd like to run, I try but again don't observe anything happened: !\nApologies, Brigit, it appears there's an old bug resurfacing in which the keybinding is not listed correctly in this dialog. On windows, run recent command is invoked with when in screen reader mode. On mac, with screen reader mode, it's .\nReopening to fix that\nAh yay, worked well for me, thank you! I'll hold off on labeling as if you'd also like to use this issue to track fixing the keybinding bug.\nActually, I think I'll reopen that other issue. Since the issue was the command not working, it would be great if you'd verify this and I'll link the other . Thanks\nhere's the issue where we're tracking that", "positive_passages": [{"docid": "doc-en-vscode-ba6486d4bbedda74204080562147ab6c484ee312f35610adb76e98714e768933", "text": "if (this._hasShellIntegration) { const shellIntegrationCommandList = []; shellIntegrationCommandList.push(localize('shellIntegration', \"The terminal has a feature called shell integration that offers an enhanced experience and provides useful commands for screen readers such as:\")); <del> shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToNextCommand, localize('goToNextCommand', 'Go to Next Command ({0})'), localize('goToNextCommandNoKb', 'Go to Next Command is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToPreviousCommand, localize('goToPreviousCommand', 'Go to Previous Command ({0})'), localize('goToPreviousCommandNoKb', 'Go to Previous Command is currently not triggerable by a keybinding.'))); </del> <ins> shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToNextCommand, localize('goToNextCommand', 'Go to Next Command ({0}) in the accessible view'), localize('goToNextCommandNoKb', 'Go to Next Command in the accessible view is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.AccessibleBufferGoToPreviousCommand, localize('goToPreviousCommand', 'Go to Previous Command ({0}) in the accessible view'), localize('goToPreviousCommandNoKb', 'Go to Previous Command in the accessible view is currently not triggerable by a keybinding.'))); </ins> shellIntegrationCommandList.push('- ' + this._descriptionForCommand(AccessibilityCommandId.GoToSymbol, localize('goToSymbol', 'Go to Symbol ({0})'), localize('goToSymbolNoKb', 'Go to symbol is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.RunRecentCommand, localize('runRecentCommand', 'Run Recent Command ({0})'), localize('runRecentCommandNoKb', 'Run Recent Command is currently not triggerable by a keybinding.'))); shellIntegrationCommandList.push('- ' + this._descriptionForCommand(TerminalCommandId.GoToRecentDirectory, localize('goToRecentDirectory', 'Go to Recent Directory ({0})'), localize('goToRecentDirectoryNoKb', 'Go to Recent Directory is currently not triggerable by a keybinding.')));", "commid": "vscode_pr_194211"}], "negative_passages": []}
{"query_id": "q-en-vscode-b2b8be862e69fbdac021ed008b04b6febdf2092b9c752203d7d456aa6f47c6ca", "query": "When there are multiple debug sessions, the dropdown action item shows in the debug toolbar here as a button that doesn't do anything. You can see it in the gif in We could just hide that item when this setting is set\nI believe it focuses the Call Stack view but only when paused and when having the view active. Tho, I do agree that we shouldn't have it there to begin with.", "positive_passages": [{"docid": "doc-en-vscode-06d79c4566cef6116f47d36c2152e5e97030a0f35c763da1d5763f95c6a5036a", "text": "@IKeybindingService private _keybindingService: IKeybindingService, @IInstantiationService private _instaService: IInstantiationService, ) { <del> super(undefined, _submenu.actions[0], options); </del> <ins> super(undefined, _submenu.actions.find(action => action.id === 'workbench.action.quickOpenWithModes') ?? _submenu.actions[0], options); </ins> } override render(container: HTMLElement): void {", "commid": "vscode_pr_194260"}], "negative_passages": []}
{"query_id": "q-en-vscode-b2b8be862e69fbdac021ed008b04b6febdf2092b9c752203d7d456aa6f47c6ca", "query": "When there are multiple debug sessions, the dropdown action item shows in the debug toolbar here as a button that doesn't do anything. You can see it in the gif in We could just hide that item when this setting is set\nI believe it focuses the Call Stack view but only when paused and when having the view active. Tho, I do agree that we shouldn't have it there to begin with.", "positive_passages": [{"docid": "doc-en-vscode-17dfc967e5a380e8b25061cc72c1186d03bf7b991c0a6e70db0e6a1320e73cd2", "text": "}); <ins> const CONTEXT_TOOLBAR_COMMAND_CENTER = ContextKeyExpr.equals('config.debug.toolBarLocation', 'commandCenter'); </ins> MenuRegistry.appendMenuItem(MenuId.CommandCenterCenter, { submenu: MenuId.DebugToolBar, title: 'Debug', icon: Codicon.debug, order: 1, <del> when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, ContextKeyExpr.equals('config.debug.toolBarLocation', 'commandCenter')) </del> <ins> when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, CONTEXT_TOOLBAR_COMMAND_CENTER) </ins> }); registerDebugToolBarItem(CONTINUE_ID, CONTINUE_LABEL, 10, icons.debugContinue, CONTEXT_DEBUG_STATE.isEqualTo('stopped'));", "commid": "vscode_pr_194260"}], "negative_passages": []}
{"query_id": "q-en-vscode-b2b8be862e69fbdac021ed008b04b6febdf2092b9c752203d7d456aa6f47c6ca", "query": "When there are multiple debug sessions, the dropdown action item shows in the debug toolbar here as a button that doesn't do anything. You can see it in the gif in We could just hide that item when this setting is set\nI believe it focuses the Call Stack view but only when paused and when having the view active. Tho, I do agree that we shouldn't have it there to begin with.", "positive_passages": [{"docid": "doc-en-vscode-f4fa6a3d039f534629938ddb219184980860462697e4cb25b3ab6f0e8952c659", "text": "registerDebugToolBarItem(RESTART_SESSION_ID, RESTART_LABEL, 60, icons.debugRestart); registerDebugToolBarItem(STEP_BACK_ID, localize('stepBackDebug', \"Step Back\"), 50, icons.debugStepBack, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_DEBUG_STATE.isEqualTo('stopped')); registerDebugToolBarItem(REVERSE_CONTINUE_ID, localize('reverseContinue', \"Reverse\"), 55, icons.debugReverseContinue, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_DEBUG_STATE.isEqualTo('stopped')); <del> registerDebugToolBarItem(FOCUS_SESSION_ID, FOCUS_SESSION_LABEL, 100, Codicon.listTree, CONTEXT_MULTI_SESSION_DEBUG); </del> <ins> registerDebugToolBarItem(FOCUS_SESSION_ID, FOCUS_SESSION_LABEL, 100, Codicon.listTree, ContextKeyExpr.and(CONTEXT_MULTI_SESSION_DEBUG, CONTEXT_TOOLBAR_COMMAND_CENTER.negate())); </ins> MenuRegistry.appendMenuItem(MenuId.DebugToolBarStop, { group: 'navigation',", "commid": "vscode_pr_194260"}], "negative_passages": []}
{"query_id": "q-en-vscode-0e7c1535eb07a9293d68df512fe1017236d924581e1dead8085bb6f6db7a959f", "query": "Type: <bBug</bclone repro from and open project folder run the repro extension from vscode open two folders in the workspace (these will not be touched by the repro code, the problem was encounterd in multi-folder workspace and this just reproduces that environment) run command after some time popup with error will appear Expected beahvior: the loop running the dummy task will keep running indefinitely This seems to be caused by using in combination with changes of the workspace folders. When the loop in the repro is changed to only keep writing the file and running the tasks the problem never appears VS Code version: Code - Insiders 1.82.0-insider (, 2023-09-01T11:05:38.381Z) OS version: Linux x64 4.19.0-18-amd64 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (0)</summaryExtensionVersion ------ </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm not seeing the task you said to run in that folder !\nThe repro steps say to run command , not a task. The command runs the task itself via the API. Here is the command in the command pallette ! And here is the error it produces ! Please try the repro steps again and let me know if you still can't see what I show in the screenshots\nI get this error, which is interesting because the workspace contains two folders. !\nFrom the screenshot it seems like you have one workspace folder containing two file system folders - that still means the workspace is a single root workspace You need to have a multi-root workspace by calling I hope the terminology I use is correct, it is taken from this doc\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-e043e7de33435c3cf4b039647ac47744affa6961c453b3e0ac8251d3d99eab66", "text": "} public async $OnDidEndTask(execution: tasks.ITaskExecutionDTO): Promise<void> { <ins> if (!this._taskExecutionPromises.has(execution.id)) { // Event already fired by the main thread // See https://github.com/microsoft/vscode/commit/aaf73920aeae171096d205efb2c58804a32b6846 return; } </ins> const _execution = await this.getTaskExecution(execution); this._taskExecutionPromises.delete(execution.id); this._taskExecutions.delete(execution.id);", "commid": "vscode_pr_200872"}], "negative_passages": []}
{"query_id": "q-en-vscode-0e7c1535eb07a9293d68df512fe1017236d924581e1dead8085bb6f6db7a959f", "query": "Type: <bBug</bclone repro from and open project folder run the repro extension from vscode open two folders in the workspace (these will not be touched by the repro code, the problem was encounterd in multi-folder workspace and this just reproduces that environment) run command after some time popup with error will appear Expected beahvior: the loop running the dummy task will keep running indefinitely This seems to be caused by using in combination with changes of the workspace folders. When the loop in the repro is changed to only keep writing the file and running the tasks the problem never appears VS Code version: Code - Insiders 1.82.0-insider (, 2023-09-01T11:05:38.381Z) OS version: Linux x64 4.19.0-18-amd64 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (0)</summaryExtensionVersion ------ </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI'm not seeing the task you said to run in that folder !\nThe repro steps say to run command , not a task. The command runs the task itself via the API. Here is the command in the command pallette ! And here is the error it produces ! Please try the repro steps again and let me know if you still can't see what I show in the screenshots\nI get this error, which is interesting because the workspace contains two folders. !\nFrom the screenshot it seems like you have one workspace folder containing two file system folders - that still means the workspace is a single root workspace You need to have a multi-root workspace by calling I hope the terminology I use is correct, it is taken from this doc\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-0c1fc519c425c4dae49d2ba42472a68ad4d2e42377cd3629241f5b21171e4305", "text": "if (result) { return result; } <del> const createdResult: Promise<TaskExecutionImpl> = new Promise((resolve, reject) => { function resolvePromiseWithCreatedTask(that: ExtHostTaskBase, execution: tasks.ITaskExecutionDTO, taskToCreate: vscode.Task | types.Task | undefined) { if (!taskToCreate) { reject('Unexpected: Task does not exist.'); } else { resolve(new TaskExecutionImpl(that, execution.id, taskToCreate)); } } if (task) { resolvePromiseWithCreatedTask(this, execution, task); } else { TaskDTO.to(execution.task, this._workspaceProvider, this._providedCustomExecutions2) .then(task => resolvePromiseWithCreatedTask(this, execution, task)); } }); this._taskExecutionPromises.set(execution.id, createdResult); return createdResult.then(executionCreatedResult => { this._taskExecutions.set(execution.id, executionCreatedResult); return executionCreatedResult; }, rejected => { return Promise.reject(rejected); </del> <ins> let executionPromise: Promise<TaskExecutionImpl>; if (!task) { executionPromise = TaskDTO.to(execution.task, this._workspaceProvider, this._providedCustomExecutions2).then(t => { if (!t) { throw new ErrorNoTelemetry('Unexpected: Task does not exist.'); } return new TaskExecutionImpl(this, execution.id, t); }); } else { executionPromise = Promise.resolve(new TaskExecutionImpl(this, execution.id, task)); } this._taskExecutionPromises.set(execution.id, executionPromise); return executionPromise.then(taskExecution => { this._taskExecutions.set(execution.id, taskExecution); return taskExecution; </ins> }); }", "commid": "vscode_pr_200872"}], "negative_passages": []}
{"query_id": "q-en-vscode-067966accdde69a221a242943413f234d83bfe3e59d5b557f5735e20c51b8bde", "query": "I have a setting in my settings. Everytime I reload, I see a setting being . This keeps on happening, the old setting is never removed. ! Not sure if this should be a candidate. does this code look right to you? Or does migration also need to remove the old setting?\nIf you want to remove the old setting you should explicitly mention that in the migration like below\nCan the migration function be made in a way that people do not forget this?", "positive_passages": [{"docid": "doc-en-vscode-b2e6bfc899ea1aeb08b79af31e71217a80b6b80e902df6e372c59843a2614ea6", "text": "key: 'workbench.editor.untitled.hint', migrateFn: (value, _accessor) => ([ [emptyTextEditorHintSetting, { value }], <ins> ['workbench.editor.untitled.hint', { value: undefined }] </ins> ]) }, { key: 'accessibility.verbosity.untitledHint', migrateFn: (value, _accessor) => ([ [AccessibilityVerbositySettingId.EmptyEditorHint, { value }], <ins> ['accessibility.verbosity.untitledHint', { value: undefined }] </ins> ]) }]);", "commid": "vscode_pr_194732"}], "negative_passages": []}
{"query_id": "q-en-vscode-c793515b2104700e173ebd3f165ac1f88f28696d2461a0b424ac39625c508b5b", "query": "I'm pretty sure some of these keybindings aren't ever enabled with their context key requirements, e.g. I don't think the inline chat can be focused in a markdown cell that isn't in edit mode. Nor will cursor navigation mode be true while edit mode is false.", "positive_passages": [{"docid": "doc-en-vscode-2083b2a96734c20df50c9d5cdd36c532a95e7d77a7a14a285b8f8ba19ff8b27f", "text": "import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { Registry } from 'vs/platform/registry/common/platform'; import { InlineChatController } from 'vs/workbench/contrib/inlineChat/browser/inlineChatController'; <del> import { CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_INNER_CURSOR_LAST } from 'vs/workbench/contrib/inlineChat/common/inlineChat'; </del> import { INotebookActionContext, INotebookCellActionContext, NotebookAction, NotebookCellAction, NOTEBOOK_EDITOR_WIDGET_ACTION_WEIGHT, findTargetCellEditor } from 'vs/workbench/contrib/notebook/browser/controller/coreActions'; import { CellEditState } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; import { CellKind, NOTEBOOK_EDITOR_CURSOR_BOUNDARY } from 'vs/workbench/contrib/notebook/common/notebookCommon';", "commid": "vscode_pr_202883"}], "negative_passages": []}
{"query_id": "q-en-vscode-c793515b2104700e173ebd3f165ac1f88f28696d2461a0b424ac39625c508b5b", "query": "I'm pretty sure some of these keybindings aren't ever enabled with their context key requirements, e.g. I don't think the inline chat can be focused in a markdown cell that isn't in edit mode. Nor will cursor navigation mode be true while edit mode is false.", "positive_passages": [{"docid": "doc-en-vscode-b7933b0c8a831c11471ed60661c86e9a43003c5e2476739e2b9b4e8a073eb097", "text": "weight: KeybindingWeight.WorkbenchContrib }, { <del> when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate(), ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), ContextKeyExpr.and( ContextKeyExpr.has(InputFocusedContextKey), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('top'), NOTEBOOK_EDITOR_CURSOR_BOUNDARY.notEqualsTo('none'), ), CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_INNER_CURSOR_LAST, EditorContextKeys.isEmbeddedDiffEditor.negate() ), primary: KeyCode.DownArrow, weight: KeybindingWeight.EditorCore }, { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate(), ContextKeyExpr.equals('config.notebook.navigation.allowNavigateToSurroundingCells', true), ContextKeyExpr.and( NOTEBOOK_CELL_TYPE.isEqualTo('markup'), NOTEBOOK_CELL_MARKDOWN_EDIT_MODE.isEqualTo(false), NOTEBOOK_CURSOR_NAVIGATION_MODE), CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_INNER_CURSOR_LAST, EditorContextKeys.isEmbeddedDiffEditor.negate() ), primary: KeyCode.DownArrow, weight: KeybindingWeight.EditorCore }, { </del> when: NOTEBOOK_EDITOR_FOCUSED, primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, },", "commid": "vscode_pr_202883"}], "negative_passages": []}
{"query_id": "q-en-vscode-c793515b2104700e173ebd3f165ac1f88f28696d2461a0b424ac39625c508b5b", "query": "I'm pretty sure some of these keybindings aren't ever enabled with their context key requirements, e.g. I don't think the inline chat can be focused in a markdown cell that isn't in edit mode. Nor will cursor navigation mode be true while edit mode is false.", "positive_passages": [{"docid": "doc-en-vscode-92e85cc174502767cc46433e47b44f8186428d56e92fa30bff0d3a41dd589655", "text": "super({ id: NOTEBOOK_FOCUS_PREVIOUS_EDITOR, title: localize('cursorMoveUp', 'Focus Previous Cell Editor'), <del> precondition: CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate(), </del> keybinding: [ { when: ContextKeyExpr.and(", "commid": "vscode_pr_202883"}], "negative_passages": []}
{"query_id": "q-en-vscode-c84b261302b84e0f7d7d67668fb0dce24a354a4aa3a974d0de99311432eecf29", "query": "Type: <bBug</bCC Copilot inline suggestion Accessible View (alt+F2) for the suggestion : this opens a side-by-side copilot suggestion panel instead of accepting the suggestion. I think we need to go back to the original keybindings: for accepting suggestion; for submitting a request. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-12T05:37:35.298Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.26.0 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.126.0 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.20 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.318.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.1117 powershell2023.9.5 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.19 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.5 shinyuieditor0.5.0 quarto1.103.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nGood catch. I couldn't test yesterday as inline completions weren't working for me. I think that we can just increase the weight of this keybinding rather than change it back.\nThat keybinding will still work when one is not in the accessible view. LMK if that sounds good to you.\n-- We then reassign the default keybindings for the following: : This is currently . : This is currently .\nWe cannot change the extension contributed ones, so I was suggesting overriding it when in the accessible view. I cannot get inline completions to work in oss atm, so cannot test any of these changes until that works and am leaning toward just reverting the change.", "positive_passages": [{"docid": "doc-en-vscode-43f856c376c0ba52f50b05e6158e6778eb2a3673b514dbeee3b595947b4b78f6", "text": "id: AccessibilityCommandId.AccessibleViewAcceptInlineCompletion, precondition: ContextKeyExpr.and(accessibleViewIsShown, ContextKeyExpr.equals(accessibleViewCurrentProviderId.key, AccessibleViewProviderId.InlineCompletions)), keybinding: { <del> primary: KeyMod.CtrlCmd | KeyCode.Enter, mac: { primary: KeyMod.WinCtrl | KeyCode.Enter }, </del> <ins> primary: KeyMod.CtrlCmd | KeyCode.Slash, mac: { primary: KeyMod.WinCtrl | KeyCode.Slash }, </ins> weight: KeybindingWeight.WorkbenchContrib }, icon: Codicon.check,", "commid": "vscode_pr_195591"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b69fb8b5614cf4459203c2af60ccc40eec5a9921c797b022244663518920aba", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a \"Formatting with autopep8\" message in the status bar even though that formatter extension isn't installed! However manually triggering \"Format Cell\" does use black.", "positive_passages": [{"docid": "doc-en-vscode-a342902debad9d4a38d5bc5c7c7833b924e2f73675f2c95ac6d4028b4d664746", "text": "return undefined; } <ins> export async function getDocumentFormattingEditsWithSelectedProvider( workerService: IEditorWorkerService, languageFeaturesService: ILanguageFeaturesService, editorOrModel: ITextModel | IActiveCodeEditor, mode: FormattingMode, token: CancellationToken, ): Promise<TextEdit[] | undefined> { const model = isCodeEditor(editorOrModel) ? editorOrModel.getModel() : editorOrModel; const provider = getRealAndSyntheticDocumentFormattersOrdered(languageFeaturesService.documentFormattingEditProvider, languageFeaturesService.documentRangeFormattingEditProvider, model); const selected = await FormattingConflicts.select(provider, model, mode, FormattingKind.File); if (selected) { const rawEdits = await Promise.resolve(selected.provideDocumentFormattingEdits(model, model.getOptions(), token)).catch(onUnexpectedExternalError); return await workerService.computeMoreMinimalEdits(model.uri, rawEdits); } return undefined; } </ins> export function getOnTypeFormattingEdits( workerService: IEditorWorkerService, languageFeaturesService: ILanguageFeaturesService,", "commid": "vscode_pr_212185"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b69fb8b5614cf4459203c2af60ccc40eec5a9921c797b022244663518920aba", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a \"Formatting with autopep8\" message in the status bar even though that formatter extension isn't installed! However manually triggering \"Format Cell\" does use black.", "positive_passages": [{"docid": "doc-en-vscode-058058659a52e15f49d14807c1257e1d1833c142cbc52f6033721e2e1cbde175", "text": "import { IEditorWorkerService } from 'vs/editor/common/services/editorWorker'; import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; import { ITextModelService } from 'vs/editor/common/services/resolverService'; <del> import { FormattingMode, formatDocumentWithSelectedProvider, getDocumentFormattingEditsUntilResult } from 'vs/editor/contrib/format/browser/format'; </del> <ins> import { FormattingMode, formatDocumentWithSelectedProvider, getDocumentFormattingEditsWithSelectedProvider } from 'vs/editor/contrib/format/browser/format'; </ins> import { Action2, MenuId, registerAction2 } from 'vs/platform/actions/common/actions'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';", "commid": "vscode_pr_212185"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b69fb8b5614cf4459203c2af60ccc40eec5a9921c797b022244663518920aba", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a \"Formatting with autopep8\" message in the status bar even though that formatter extension isn't installed! However manually triggering \"Format Cell\" does use black.", "positive_passages": [{"docid": "doc-en-vscode-ff5d484fddee5feb41cab304e8b1f6f15cfa417838ea68f97db5815635c77a67", "text": "const model = ref.object.textEditorModel; <del> const formatEdits = await getDocumentFormattingEditsUntilResult( </del> <ins> const formatEdits = await getDocumentFormattingEditsWithSelectedProvider( </ins> editorWorkerService, languageFeaturesService, model, <del> model.getOptions(), </del> <ins> FormattingMode.Explicit, </ins> CancellationToken.None );", "commid": "vscode_pr_212185"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b69fb8b5614cf4459203c2af60ccc40eec5a9921c797b022244663518920aba", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a \"Formatting with autopep8\" message in the status bar even though that formatter extension isn't installed! However manually triggering \"Format Cell\" does use black.", "positive_passages": [{"docid": "doc-en-vscode-c4be8aa3f71fee6896f1cafa8fdc8fb7056333044f76531fdb42cc2a9ebfab34", "text": "const model = ref.object.textEditorModel; <del> // todo: eventually support cancellation. potential leak if cell deleted mid execution const formatEdits = await getDocumentFormattingEditsUntilResult( </del> <ins> const formatEdits = await getDocumentFormattingEditsWithSelectedProvider( </ins> this.editorWorkerService, this.languageFeaturesService, model, <del> model.getOptions(), </del> <ins> FormattingMode.Silent, </ins> CancellationToken.None );", "commid": "vscode_pr_212185"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b69fb8b5614cf4459203c2af60ccc40eec5a9921c797b022244663518920aba", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a \"Formatting with autopep8\" message in the status bar even though that formatter extension isn't installed! However manually triggering \"Format Cell\" does use black.", "positive_passages": [{"docid": "doc-en-vscode-97be8befb9ea59af08a893c33c2215fd407381e0afb3cf0b0a2de2d0891ab368", "text": "import { ITextModelService } from 'vs/editor/common/services/resolverService'; import { ApplyCodeActionReason, applyCodeAction, getCodeActions } from 'vs/editor/contrib/codeAction/browser/codeAction'; import { CodeActionKind, CodeActionTriggerSource } from 'vs/editor/contrib/codeAction/common/types'; <del> import { getDocumentFormattingEditsUntilResult } from 'vs/editor/contrib/format/browser/format'; </del> <ins> import { FormattingMode, getDocumentFormattingEditsWithSelectedProvider } from 'vs/editor/contrib/format/browser/format'; </ins> import { SnippetController2 } from 'vs/editor/contrib/snippet/browser/snippetController2'; import { localize } from 'vs/nls'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';", "commid": "vscode_pr_212185"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b69fb8b5614cf4459203c2af60ccc40eec5a9921c797b022244663518920aba", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: 12.6.9 Steps to Reproduce: or the Python and Black Vscode extensions a new notebook and execute any cell or save it You'll a \"Formatting with autopep8\" message in the status bar even though that formatter extension isn't installed! However manually triggering \"Format Cell\" does use black.", "positive_passages": [{"docid": "doc-en-vscode-380bc29b9ac58355725ae93a4851c60607cabfa2eb6782b082078c7fbc0b6199", "text": "const model = ref.object.textEditorModel; <del> const formatEdits = await getDocumentFormattingEditsUntilResult( </del> <ins> const formatEdits = await getDocumentFormattingEditsWithSelectedProvider( </ins> this.editorWorkerService, this.languageFeaturesService, model, <del> model.getOptions(), </del> <ins> FormattingMode.Silent, </ins> token );", "commid": "vscode_pr_212185"}], "negative_passages": []}
{"query_id": "q-en-vscode-4fc668b21de0762b5103ecfa0ddf505044447a39d12f3afa2cf659d88d977f8c", "query": "When using the new diff editor with enabled, I very rarely get to the right editor position whenever I click the top action, above the editor.\nYou mean go to reference is broken?\ndiff editors have an action to open the original file (I think contributed from SCM?). When clicking that, expectation is that the current view state of the diff editors right hand side applies to the opening editor so that you stay in exactly the same view state (for example: the selection and viewport). <img width=\"140\" alt=\"image\" src=\"\"\nI really like the collapsed diff editor but this is a very frustrating regression from it which makes me want to shut it off. The issue is 100% reproducible in my usual workflow and I encounter this issue many times per hour.\nI can reproduce. The \"Open File\" command is a mystery to me. Debugging shows me that is called twice, but both times with unhelpful stack traces: ! ! The second invocation sets . However, there is no reveal mechanism.\nFurther investigation showed that the \"Open File\" action is actually implemented in the git extension (even when comparing two files on disk) :/ Which I think is very questionable design, as it should be a core diff editor feature.", "positive_passages": [{"docid": "doc-en-vscode-34f3ff9e6a4a3fade78b7d6c4e623eafd8a4666797a20f8d774c212ccb4bc544", "text": "const activeTextEditor = window.activeTextEditor; // Must extract these now because opening a new document will change the activeTextEditor reference <del> const previousVisibleRange = activeTextEditor?.visibleRanges[0]; </del> <ins> const previousVisibleRanges = activeTextEditor?.visibleRanges; </ins> const previousURI = activeTextEditor?.document.uri; const previousSelection = activeTextEditor?.selection;", "commid": "vscode_pr_206100"}], "negative_passages": []}
{"query_id": "q-en-vscode-4fc668b21de0762b5103ecfa0ddf505044447a39d12f3afa2cf659d88d977f8c", "query": "When using the new diff editor with enabled, I very rarely get to the right editor position whenever I click the top action, above the editor.\nYou mean go to reference is broken?\ndiff editors have an action to open the original file (I think contributed from SCM?). When clicking that, expectation is that the current view state of the diff editors right hand side applies to the opening editor so that you stay in exactly the same view state (for example: the selection and viewport). <img width=\"140\" alt=\"image\" src=\"\"\nI really like the collapsed diff editor but this is a very frustrating regression from it which makes me want to shut it off. The issue is 100% reproducible in my usual workflow and I encounter this issue many times per hour.\nI can reproduce. The \"Open File\" command is a mystery to me. Debugging shows me that is called twice, but both times with unhelpful stack traces: ! ! The second invocation sets . However, there is no reveal mechanism.\nFurther investigation showed that the \"Open File\" action is actually implemented in the git extension (even when comparing two files on disk) :/ Which I think is very questionable design, as it should be a core diff editor feature.", "positive_passages": [{"docid": "doc-en-vscode-bd186ad61f02c884bb2be526095574b3de2f02eae2c20b1a390e9574d11c4541", "text": "opts.selection = previousSelection; const editor = await window.showTextDocument(document, opts); // This should always be defined but just in case <del> if (previousVisibleRange) { editor.revealRange(previousVisibleRange); </del> <ins> if (previousVisibleRanges && previousVisibleRanges.length > 0) { let rangeToReveal = previousVisibleRanges[0]; if (previousSelection && previousVisibleRanges.length > 1) { // In case of multiple visible ranges, find the one that intersects with the selection rangeToReveal = previousVisibleRanges.find(r => r.intersection(previousSelection)) ?? rangeToReveal; } editor.revealRange(rangeToReveal); </ins> } } }", "commid": "vscode_pr_206100"}], "negative_passages": []}
{"query_id": "q-en-vscode-eee78ebf28cc36cf950f1df662f400aeab8185f297b4433aede4e45abe2b0fa7", "query": "From We should fix block styling in Markdown previews in main as well, from discussing with we want to make the styling consistent across chat, settings UI, and extension webviews\nThe three greys look different to me. I'm unsure whether those are the colours I should be comparing. !\nTo verify this you just need to confirm that there is a background for blocks, since it used to just be a brownish foreground color.", "positive_passages": [{"docid": "doc-en-vscode-afae73ddf9aa419f2c4f2b09c82b3fcb8fc085ac9747a73df75f021b1edd9d80", "text": "<meta charset=\"UTF-8\"> <meta http-equiv=\"Content-Security-Policy\" <del> content=\"default-src 'none'; script-src 'sha256-QA1gXilHYAUFCvp7MpjgcmyBCFzSKV0SpiecMU8aUVc=' 'self'; frame-src 'self'; style-src 'unsafe-inline';\"> </del> <ins> content=\"default-src 'none'; script-src 'sha256-Ne5nVg2ZDLxLh1eqzYd1sGbOz022xlokwv+X6+HR1hw=' 'self'; frame-src 'self'; style-src 'unsafe-inline';\"> </ins> <!-- Disable pinch zooming --> <meta name=\"viewport\"", "commid": "vscode_pr_197153"}], "negative_passages": []}
{"query_id": "q-en-vscode-eee78ebf28cc36cf950f1df662f400aeab8185f297b4433aede4e45abe2b0fa7", "query": "From We should fix block styling in Markdown previews in main as well, from discussing with we want to make the styling consistent across chat, settings UI, and extension webviews\nThe three greys look different to me. I'm unsure whether those are the colours I should be comparing. !\nTo verify this you just need to confirm that there is a background for blocks, since it used to just be a brownish foreground color.", "positive_passages": [{"docid": "doc-en-vscode-b889257ea3e910644773bef2805ee425caa89b8e378f2a46410ed4a1d8de9463", "text": "} code { <ins> font-family: var(--monaco-monospace-font); </ins> color: var(--vscode-textPreformat-foreground); <ins> font-size: 12px; background-color: var(--vscode-textPreformat-background); padding: 1px 3px; border-radius: 4px; </ins> } blockquote {", "commid": "vscode_pr_197153"}], "negative_passages": []}
{"query_id": "q-en-vscode-edf042f76eac2a42137494a9c681e29b6a34b9c213e62aa062d718bef0efbfce", "query": "Type: <bBug</bWhat does this mean / do? ! VS Code version: Code 1.84.0 (, 2023-11-01T11:29:04.398Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nApparently from by and present since 1.78.\nthis should only be showing up for the quick pick item hovers, not the actions which have a small amount of content.", "positive_passages": [{"docid": "doc-en-vscode-aa306162814c4c4237a7dcc5f950e0b29230af88d0b0260f52b5f8cc92bdbd16", "text": ") { } showHover(options: IHoverDelegateOptions, focus?: boolean): IHoverWidget | undefined { <ins> // Only show the hover hint if the content is of a decent size const showHoverHint = ( options.content instanceof HTMLElement ? options.content.textContent ?? '' : typeof options.content === 'string' ? options.content : options.content.value ).length > 20; </ins> return this.hoverService.showHover({ ...options, persistence: { hideOnKeyDown: false, }, appearance: { <del> showHoverHint: true, </del> <ins> showHoverHint, </ins> skipFadeInAnimation: true, }, }, focus);", "commid": "vscode_pr_197365"}], "negative_passages": []}
{"query_id": "q-en-vscode-74f591f463fb6cb4fe16fc49486bb34ce2698d4420f81d1e0c1d4d8472c5b71f", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src=\"\" alt=\"drawing\" width=\"600\"/Currently, we can control when to show the inline suggestion toolbar by setting to \"always\" or \"onHover\", which are defined as follows: \"always\": show the inline suggestion toolbar whenever an inline suggestion is shown, and \"onHover\": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option \"never\" as follows \"never\": do not show the inline suggestion toolbar.\nI think this should be very easy to implement. Up for a PR?\nI would like to take this.\nAny ideas why this setting isn't in the Settings JSON file? .\nThank you so much for accepting the request and for the contribution!", "positive_passages": [{"docid": "doc-en-vscode-9ac1aa7b0f68c1c1c785e3532b066b502e846badd3974e7f5b705694fa26946f", "text": "*/ mode?: 'prefix' | 'subword' | 'subwordSmart'; <del> showToolbar?: 'always' | 'onHover'; </del> <ins> showToolbar?: 'always' | 'onHover' | 'never'; </ins> suppressSuggestions?: boolean;", "commid": "vscode_pr_198227"}], "negative_passages": []}
{"query_id": "q-en-vscode-74f591f463fb6cb4fe16fc49486bb34ce2698d4420f81d1e0c1d4d8472c5b71f", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src=\"\" alt=\"drawing\" width=\"600\"/Currently, we can control when to show the inline suggestion toolbar by setting to \"always\" or \"onHover\", which are defined as follows: \"always\": show the inline suggestion toolbar whenever an inline suggestion is shown, and \"onHover\": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option \"never\" as follows \"never\": do not show the inline suggestion toolbar.\nI think this should be very easy to implement. Up for a PR?\nI would like to take this.\nAny ideas why this setting isn't in the Settings JSON file? .\nThank you so much for accepting the request and for the contribution!", "positive_passages": [{"docid": "doc-en-vscode-3202015e2aaecaf1a6b98b3173d236ea57ad53c15ef463a6852416553f951ebd", "text": "'editor.inlineSuggest.showToolbar': { type: 'string', default: defaults.showToolbar, <del> enum: ['always', 'onHover'], </del> <ins> enum: ['always', 'onHover', 'never'], </ins> enumDescriptions: [ nls.localize('inlineSuggest.showToolbar.always', \"Show the inline suggestion toolbar whenever an inline suggestion is shown.\"), nls.localize('inlineSuggest.showToolbar.onHover', \"Show the inline suggestion toolbar when hovering over an inline suggestion.\"), <ins> nls.localize('inlineSuggest.showToolbar.never', \"Never show the inline suggestion toolbar.\"), </ins> ], description: nls.localize('inlineSuggest.showToolbar', \"Controls when to show the inline suggestion toolbar.\"), },", "commid": "vscode_pr_198227"}], "negative_passages": []}
{"query_id": "q-en-vscode-74f591f463fb6cb4fe16fc49486bb34ce2698d4420f81d1e0c1d4d8472c5b71f", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src=\"\" alt=\"drawing\" width=\"600\"/Currently, we can control when to show the inline suggestion toolbar by setting to \"always\" or \"onHover\", which are defined as follows: \"always\": show the inline suggestion toolbar whenever an inline suggestion is shown, and \"onHover\": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option \"never\" as follows \"never\": do not show the inline suggestion toolbar.\nI think this should be very easy to implement. Up for a PR?\nI would like to take this.\nAny ideas why this setting isn't in the Settings JSON file? .\nThank you so much for accepting the request and for the contribution!", "positive_passages": [{"docid": "doc-en-vscode-42547131d0b64fe403448c62af05fe9429c9e7f3be0af7b11447fd3ca0f8bc0f", "text": "return { enabled: boolean(input.enabled, this.defaultValue.enabled), mode: stringSet(input.mode, this.defaultValue.mode, ['prefix', 'subword', 'subwordSmart']), <del> showToolbar: stringSet(input.showToolbar, this.defaultValue.showToolbar, ['always', 'onHover']), </del> <ins> showToolbar: stringSet(input.showToolbar, this.defaultValue.showToolbar, ['always', 'onHover', 'never']), </ins> suppressSuggestions: boolean(input.suppressSuggestions, this.defaultValue.suppressSuggestions), keepOnBlur: boolean(input.keepOnBlur, this.defaultValue.keepOnBlur), };", "commid": "vscode_pr_198227"}], "negative_passages": []}
{"query_id": "q-en-vscode-74f591f463fb6cb4fe16fc49486bb34ce2698d4420f81d1e0c1d4d8472c5b71f", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src=\"\" alt=\"drawing\" width=\"600\"/Currently, we can control when to show the inline suggestion toolbar by setting to \"always\" or \"onHover\", which are defined as follows: \"always\": show the inline suggestion toolbar whenever an inline suggestion is shown, and \"onHover\": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option \"never\" as follows \"never\": do not show the inline suggestion toolbar.\nI think this should be very easy to implement. Up for a PR?\nI would like to take this.\nAny ideas why this setting isn't in the Settings JSON file? .\nThank you so much for accepting the request and for the contribution!", "positive_passages": [{"docid": "doc-en-vscode-44d78c2edcc0ec7967c87a0b6a1d9a2c30dbcd47457855fe57aa555740f22357", "text": "} computeSync(anchor: HoverAnchor, lineDecorations: IModelDecoration[]): InlineCompletionsHover[] { <del> if (this._editor.getOption(EditorOption.inlineSuggest).showToolbar === 'always') { </del> <ins> if (this._editor.getOption(EditorOption.inlineSuggest).showToolbar !== 'onHover') { </ins> return []; }", "commid": "vscode_pr_198227"}], "negative_passages": []}
{"query_id": "q-en-vscode-74f591f463fb6cb4fe16fc49486bb34ce2698d4420f81d1e0c1d4d8472c5b71f", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --<img src=\"\" alt=\"drawing\" width=\"600\"/Currently, we can control when to show the inline suggestion toolbar by setting to \"always\" or \"onHover\", which are defined as follows: \"always\": show the inline suggestion toolbar whenever an inline suggestion is shown, and \"onHover\": show the inline suggestion toolbar when hovering over an inline suggestion. For the new feature, I suggest to add an option \"never\" as follows \"never\": do not show the inline suggestion toolbar.\nI think this should be very easy to implement. Up for a PR?\nI would like to take this.\nAny ideas why this setting isn't in the Settings JSON file? .\nThank you so much for accepting the request and for the contribution!", "positive_passages": [{"docid": "doc-en-vscode-14c1f6d1a8871125a16dcb2baca238f214e2694d67e4840d05da5f64f2d3854b", "text": "* Defaults to `prefix`. */ mode?: 'prefix' | 'subword' | 'subwordSmart'; <del> showToolbar?: 'always' | 'onHover'; </del> <ins> showToolbar?: 'always' | 'onHover' | 'never'; </ins> suppressSuggestions?: boolean; /** * Does not clear active inline suggestions when the editor loses focus.", "commid": "vscode_pr_198227"}], "negative_passages": []}
{"query_id": "q-en-vscode-d3b3b427b4aac4066ffdbd96672215454832f3231413098e24f31bed8a6bde90", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --extension is used to specify the syntax highlighting for popular languages, such as TypeScript: Currently, the workaround is to push the settings file to Git: In addition, extension is also . It would be nice if VSCode could support these aliases to YAML natively.\nIf you want to make a PR, that would be great!\nI made a PR, I hope it's good, because I have no experience with the codebase:", "positive_passages": [{"docid": "doc-en-vscode-d680ceeb344098c0b88f76ade55ca6c5f3d5c3dd1ab7207ca1adbc25a04e9885", "text": "\".eyaml\", \".eyml\", \".yaml\", <del> \".cff\" </del> <ins> \".cff\", \".yaml-tmlanguage\", \".yaml-tmpreferences\", \".yaml-tmtheme\" </ins> ], \"firstLine\": \"^#cloud-config\", \"configuration\": \"./language-configuration.json\"", "commid": "vscode_pr_198300"}], "negative_passages": []}
{"query_id": "q-en-vscode-8424e64f7f04e5a3e167a53e1a531440b3b0cfd3347cf5a8e7351413cf3108e4", "query": "open test explorer notice that the input has the wrong background color, e.g it has two background colors <img width=\"455\" alt=\"Screenshot 2023-11-15 at 14 29 05\" src=\"\"\nWhat theme are you using? I can see the slight difference in your screenshot, but inspecting things I'm not seeing any backgrounds being applied to that action / menu bar\nLike, any light theme?\nStill confused on the latest Insiders for me in e.g. solarized light: <img width=\"725\" alt=\"image\" src=\"\"Does it reproduce on a fresh user-data-dir for you? If so, are you able to do a quick devtools inspect and give a hint as to what styling is being applied that makes monaco input have a different background color?\nI see. It doesn't show with an empty profile but I also don't have any setting that screams test explorer background color\nCould you bisect your user settings or share them so I can play around?\nThis seems to be because I have the test explorer in the secondary sidebar. There is some settings that controls this but I have no clue which one it is <img width=\"2188\" alt=\"Screenshot 2023-12-12 at 18 02 53\" src=\"\"\nCSS is fun", "positive_passages": [{"docid": "doc-en-vscode-a816d3e365b345db24b7d8169a1f59442f14715b52750862b7760c58543a6804", "text": ".suggest-input-container .monaco-editor, .suggest-input-container .monaco-editor .lines-content { <del> background: none; </del> <ins> background: none !important; </ins> }", "commid": "vscode_pr_200699"}], "negative_passages": []}
{"query_id": "q-en-vscode-2256a1ff645c18e4f4601a1c67ae4f3984976510185bf59ae09c98fd4356d011", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --The direct symptom is in the site , but the investigation went through (which the site uses) and ends up here. Steps to Reproduce: to This shows the \"LLVM Opt Pipeline Viewer\" (1) which is a diff pane created by monaco's (2). It's contents change based on the user selection in from the 'passes' list (3). ! see normal operation in action: click in order the passes \"SROAPass\" (first one) and \"Greedy Register Allocator\". Diffs are shown properly: ! reproduce the bug, click in order the passes \"SROAPass\", then \"Debug Variable Analysis\" (one above Greedy) and finally \"Greedy Register Allocator\". First, text diffs are not being decorated despite being present: ! and second, a console shows the error: Preliminary investigation directs attention to these lines in 's : In the (not so rare) problematic scenario, and are non-empty but is, so the code enters the loop and crashes immediately. I suspect something broke in PR , but not sure.\nA monaco-playground link with a small standalone repro for the problem: This creates a diffView and populates both sides with an offending text (specifically, one with non-empty \"unchangedRegions\"). After two seconds it sets the left pane to the same text as it currently has, but this time the decorations disappear and a console error message as above appears. Perhaps this tidbit would be helpful: It seems that upon entering , contains ids that were already invalidated - i.e., do not appear in : ! And so returns only nulls and the resulting array is empty. My current guess is these decoration-IDs invalidation is too early, and should be moved to after .\nThank you for the prompt fix!\nPlease, please, please, include inline diff view in your testing. I use inline view 99.9% of the time, side by side very rarely. Regardless, I hope this Thank you for your work.\nI saw this problem again today.\nCan you please share the output of the dev console? Thanks!", "positive_passages": [{"docid": "doc-en-vscode-29f9f7599619b0878d9e7e3e7702ef73404b3fd7f0bad6545714bdf0586c03d0", "text": "const lastUnchangedRegions = this._unchangedRegions.get(); const lastUnchangedRegionsOrigRanges = lastUnchangedRegions.originalDecorationIds .map(id => model.original.getDecorationRange(id)) <del> .filter(r => !!r) .map(r => LineRange.fromRange(r!)); </del> <ins> .map(r => r ? LineRange.fromRange(r) : undefined); </ins> const lastUnchangedRegionsModRanges = lastUnchangedRegions.modifiedDecorationIds .map(id => model.modified.getDecorationRange(id)) <del> .filter(r => !!r) .map(r => LineRange.fromRange(r!)); </del> <ins> .map(r => r ? LineRange.fromRange(r) : undefined); </ins> const originalDecorationIds = model.original.deltaDecorations( lastUnchangedRegions.originalDecorationIds,", "commid": "vscode_pr_198536"}], "negative_passages": []}
{"query_id": "q-en-vscode-2256a1ff645c18e4f4601a1c67ae4f3984976510185bf59ae09c98fd4356d011", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --The direct symptom is in the site , but the investigation went through (which the site uses) and ends up here. Steps to Reproduce: to This shows the \"LLVM Opt Pipeline Viewer\" (1) which is a diff pane created by monaco's (2). It's contents change based on the user selection in from the 'passes' list (3). ! see normal operation in action: click in order the passes \"SROAPass\" (first one) and \"Greedy Register Allocator\". Diffs are shown properly: ! reproduce the bug, click in order the passes \"SROAPass\", then \"Debug Variable Analysis\" (one above Greedy) and finally \"Greedy Register Allocator\". First, text diffs are not being decorated despite being present: ! and second, a console shows the error: Preliminary investigation directs attention to these lines in 's : In the (not so rare) problematic scenario, and are non-empty but is, so the code enters the loop and crashes immediately. I suspect something broke in PR , but not sure.\nA monaco-playground link with a small standalone repro for the problem: This creates a diffView and populates both sides with an offending text (specifically, one with non-empty \"unchangedRegions\"). After two seconds it sets the left pane to the same text as it currently has, but this time the decorations disappear and a console error message as above appears. Perhaps this tidbit would be helpful: It seems that upon entering , contains ids that were already invalidated - i.e., do not appear in : ! And so returns only nulls and the resulting array is empty. My current guess is these decoration-IDs invalidation is too early, and should be moved to after .\nThank you for the prompt fix!\nPlease, please, please, include inline diff view in your testing. I use inline view 99.9% of the time, side by side very rarely. Regardless, I hope this Thank you for your work.\nI saw this problem again today.\nCan you please share the output of the dev console? Thanks!", "positive_passages": [{"docid": "doc-en-vscode-80b76359016454812e5b46161c7442a05b4ee389dd91cc61724d3833549fb94f", "text": "for (const r of newUnchangedRegions) { for (let i = 0; i < lastUnchangedRegions.regions.length; i++) { <del> if (r.originalUnchangedRange.intersectsStrict(lastUnchangedRegionsOrigRanges[i]) && r.modifiedUnchangedRange.intersectsStrict(lastUnchangedRegionsModRanges[i])) { </del> <ins> if (lastUnchangedRegionsOrigRanges[i] && r.originalUnchangedRange.intersectsStrict(lastUnchangedRegionsOrigRanges[i]!) && lastUnchangedRegionsModRanges[i] && r.modifiedUnchangedRange.intersectsStrict(lastUnchangedRegionsModRanges[i]!)) { </ins> r.setHiddenModifiedRange(lastUnchangedRegions.regions[i].getHiddenModifiedRange(undefined), tx); break; }", "commid": "vscode_pr_198536"}], "negative_passages": []}
{"query_id": "q-en-vscode-46def8806d89a618843f9f1dfaf8d93e021078e82e976f453e115949c7d91aaf", "query": "Initially noticed by : <img width=\"780\" alt=\"Screenshot 2023-11-17 at 13 53 45\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-c9a2a49da2e4fb8effe799c088a0dcbf0ffbbd2b383bb0132f240b23e0fc5768", "text": "import { MarkdownString } from 'vs/base/common/htmlContent'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { LOCALIZED_START_INLINE_CHAT_STRING } from 'vs/workbench/contrib/inlineChat/browser/inlineChatActions'; <del> import { IBreakpoint, IDebugService } from 'vs/workbench/contrib/debug/common/debug'; </del> <ins> import { IBreakpoint, IDebugService, IDebugSession } from 'vs/workbench/contrib/debug/common/debug'; </ins> import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences'; import { URI } from 'vs/base/common/uri';", "commid": "vscode_pr_198531"}], "negative_passages": []}
{"query_id": "q-en-vscode-46def8806d89a618843f9f1dfaf8d93e021078e82e976f453e115949c7d91aaf", "query": "Initially noticed by : <img width=\"780\" alt=\"Screenshot 2023-11-17 at 13 53 45\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-742037b57d61fdb4e2a993332d5dc1a0438a15b7cd0f4da1d0bb2e4e7c8b3bcb", "text": "private _gutterDecorationID: string | undefined; private _inlineChatKeybinding: string | undefined; private _hasInlineChatSession: boolean = false; <ins> private _hasActiveDebugSession: boolean = false; private _debugSessions: Set<IDebugSession> = new Set(); </ins> private readonly _localToDispose = new DisposableStore(); private readonly _gutterDecorationOpaque: IModelDecorationOptions; private readonly _gutterDecorationTransparent: IModelDecorationOptions;", "commid": "vscode_pr_198531"}], "negative_passages": []}
{"query_id": "q-en-vscode-46def8806d89a618843f9f1dfaf8d93e021078e82e976f453e115949c7d91aaf", "query": "Initially noticed by : <img width=\"780\" alt=\"Screenshot 2023-11-17 at 13 53 45\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-f132cb5504d2aa7a0c5c1f2091e46f8ca25657b8e3f837003f11f5e0995ba970", "text": "this._onEnablementOrModelChanged(); } })); <ins> this._register(this._debugService.onWillNewSession((session) => { this._debugSessions.add(session); if (!this._hasActiveDebugSession) { this._hasActiveDebugSession = true; this._onEnablementOrModelChanged(); } })); this._register(this._debugService.onDidEndSession((session) => { this._debugSessions.delete(session); if (this._debugSessions.size === 0) { this._hasActiveDebugSession = false; this._onEnablementOrModelChanged(); } })); </ins> this._register(this._inlineChatService.onDidChangeProviders(() => this._onEnablementOrModelChanged())); this._register(this._editor.onDidChangeModel(() => this._onEnablementOrModelChanged())); this._register(this._keybindingService.onDidUpdateKeybindings(() => {", "commid": "vscode_pr_198531"}], "negative_passages": []}
{"query_id": "q-en-vscode-46def8806d89a618843f9f1dfaf8d93e021078e82e976f453e115949c7d91aaf", "query": "Initially noticed by : <img width=\"780\" alt=\"Screenshot 2023-11-17 at 13 53 45\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-0aa87ab32187c350880bccabd9bcb4c3915baa0a80f9a61d021c99c961e133d7", "text": "private _onEnablementOrModelChanged(): void { // cancels the scheduler, removes editor listeners / removes decoration this._localToDispose.clear(); <del> if (!this._editor.hasModel() || this._hasInlineChatSession || this._showGutterIconMode() === ShowGutterIcon.Never || !this._hasProvider()) { </del> <ins> if (!this._editor.hasModel() || this._hasActiveDebugSession || this._hasInlineChatSession || this._showGutterIconMode() === ShowGutterIcon.Never || !this._hasProvider()) { </ins> return; } const editor = this._editor;", "commid": "vscode_pr_198531"}], "negative_passages": []}
{"query_id": "q-en-vscode-073abd1b2d64730abaf4a717b0d97ed9d09fb124bf7bca74db826d5c59e995ec", "query": "Type: <bBug</bWhen reviewing outgoing changes for my tracking fork of microsoft/vscode after merging upstream/main into my local copy today. ! Also, based on I was surprised to see the magnifying glass icon still being used for \"View Changes\". VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-22T05:35:23.085Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\n/assign\nI'm very sure this is a duplicate of\nThis sounds like there was no insiders for today. Can you check you are running the build from today? The PR just got merged yesterday.\nYes, this is today's. The new codicon appears in the Timeline view, just not in the incoming/outgoing party of Source Control view: !\nIt does for me: !\nAh, we're not talking about the same thing. My screenshot is of the feature recently by and controlled by the and settings. It comes from here:\nare you able to reproduce this consistently? Could you provide steps that that I should use to try to reproduce the issue? Thanks!\nin said it was probably a known issue. Ever since Insiders got that fix I haven't had any problems opening multi-diff for outgoing changes that get listed after I merge from upstream/main into my local main prior to pushing them to origin/main (my tracking repo). So I'm closing this one.\nthanks for the update!\nHmm, just happened to me again with today's Insiders: ! Reopening. I'll hold back from pushing the local changes that I merged in from upstream/main in case there are places you'd like me to look for clues while I can repro it.\nDevtools console:\nIt's this one: ! And specifically which is of course binary: ! I guess the multi diff editor needs to handle this case gracefully instead of failing to show the diffs for the other files.\nthanks! could you please take a look? Thanks!\nAhh, because it is a binary file...", "positive_passages": [{"docid": "doc-en-vscode-52202734345b48c1b3b4f6db99c6092fa2efeccdadbd07779e023c5323d699ed", "text": "*--------------------------------------------------------------------------------------------*/ import { LazyStatefulPromise, raceTimeout } from 'vs/base/common/async'; <ins> import { onUnexpectedError } from 'vs/base/common/errors'; </ins> import { IDisposable, DisposableStore, toDisposable } from 'vs/base/common/lifecycle'; import { deepClone } from 'vs/base/common/objects'; <del> import { isObject } from 'vs/base/common/types'; </del> <ins> import { isDefined, isObject } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import { ConstLazyPromise, IDocumentDiffItem, IMultiDiffEditorModel } from 'vs/editor/browser/widget/multiDiffEditorWidget/model'; import { MultiDiffEditorViewModel } from 'vs/editor/browser/widget/multiDiffEditorWidget/multiDiffEditorViewModel';", "commid": "vscode_pr_199036"}], "negative_passages": []}
{"query_id": "q-en-vscode-073abd1b2d64730abaf4a717b0d97ed9d09fb124bf7bca74db826d5c59e995ec", "query": "Type: <bBug</bWhen reviewing outgoing changes for my tracking fork of microsoft/vscode after merging upstream/main into my local copy today. ! Also, based on I was surprised to see the magnifying glass icon still being used for \"View Changes\". VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-22T05:35:23.085Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\n/assign\nI'm very sure this is a duplicate of\nThis sounds like there was no insiders for today. Can you check you are running the build from today? The PR just got merged yesterday.\nYes, this is today's. The new codicon appears in the Timeline view, just not in the incoming/outgoing party of Source Control view: !\nIt does for me: !\nAh, we're not talking about the same thing. My screenshot is of the feature recently by and controlled by the and settings. It comes from here:\nare you able to reproduce this consistently? Could you provide steps that that I should use to try to reproduce the issue? Thanks!\nin said it was probably a known issue. Ever since Insiders got that fix I haven't had any problems opening multi-diff for outgoing changes that get listed after I merge from upstream/main into my local main prior to pushing them to origin/main (my tracking repo). So I'm closing this one.\nthanks for the update!\nHmm, just happened to me again with today's Insiders: ! Reopening. I'll hold back from pushing the local changes that I merged in from upstream/main in case there are places you'd like me to look for clues while I can repro it.\nDevtools console:\nIt's this one: ! And specifically which is of course binary: ! I guess the multi diff editor needs to handle this case gracefully instead of failing to show the diffs for the other files.\nthanks! could you please take a look? Thanks!\nAhh, because it is a binary file...", "positive_passages": [{"docid": "doc-en-vscode-5f25271696f3359afb75bc52ea5fc9568928e91ad6a9ea94e97a4df1d4b8d254", "text": "import { EditorInput } from 'vs/workbench/common/editor/editorInput'; import { ILanguageSupport } from 'vs/workbench/services/textfile/common/textfiles'; <ins> /* hot-reload:patch-prototype-methods */ </ins> export class MultiDiffEditorInput extends EditorInput implements ILanguageSupport { static readonly ID: string = 'workbench.input.multiDiffEditor';", "commid": "vscode_pr_199036"}], "negative_passages": []}
{"query_id": "q-en-vscode-073abd1b2d64730abaf4a717b0d97ed9d09fb124bf7bca74db826d5c59e995ec", "query": "Type: <bBug</bWhen reviewing outgoing changes for my tracking fork of microsoft/vscode after merging upstream/main into my local copy today. ! Also, based on I was surprised to see the magnifying glass icon still being used for \"View Changes\". VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-22T05:35:23.085Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\n/assign\nI'm very sure this is a duplicate of\nThis sounds like there was no insiders for today. Can you check you are running the build from today? The PR just got merged yesterday.\nYes, this is today's. The new codicon appears in the Timeline view, just not in the incoming/outgoing party of Source Control view: !\nIt does for me: !\nAh, we're not talking about the same thing. My screenshot is of the feature recently by and controlled by the and settings. It comes from here:\nare you able to reproduce this consistently? Could you provide steps that that I should use to try to reproduce the issue? Thanks!\nin said it was probably a known issue. Ever since Insiders got that fix I haven't had any problems opening multi-diff for outgoing changes that get listed after I merge from upstream/main into my local main prior to pushing them to origin/main (my tracking repo). So I'm closing this one.\nthanks for the update!\nHmm, just happened to me again with today's Insiders: ! Reopening. I'll hold back from pushing the local changes that I merged in from upstream/main in case there are places you'd like me to look for clues while I can repro it.\nDevtools console:\nIt's this one: ! And specifically which is of course binary: ! I guess the multi diff editor needs to handle this case gracefully instead of failing to show the diffs for the other files.\nthanks! could you please take a look? Thanks!\nAhh, because it is a binary file...", "positive_passages": [{"docid": "doc-en-vscode-28d9f5e2db60f089961a12bbb06bd392b46589b635c590f49b2564b01c7f987d", "text": "private async _createModel(): Promise<IMultiDiffEditorModel & IDisposable> { const store = new DisposableStore(); <del> const rs = await Promise.all(this.resources.map(async r => ({ originalRef: r.original ? store.add(await this._textModelService.createModelReference(r.original)) : undefined, originalModel: !r.original ? store.add(this._modelService.createModel('', null)) : undefined, modifiedRef: r.modified ? store.add(await this._textModelService.createModelReference(r.modified)) : undefined, modifiedModel: !r.modified ? store.add(this._modelService.createModel('', null)) : undefined, title: r.resource.fsPath, }))); </del> <ins> const rs = (await Promise.all(this.resources.map(async r => { try { return { originalRef: r.original ? store.add(await this._textModelService.createModelReference(r.original)) : undefined, originalModel: !r.original ? store.add(this._modelService.createModel('', null)) : undefined, modifiedRef: r.modified ? store.add(await this._textModelService.createModelReference(r.modified)) : undefined, modifiedModel: !r.modified ? store.add(this._modelService.createModel('', null)) : undefined, title: r.resource.fsPath, }; } catch (e) { // e.g. \"File seems to be binary and cannot be opened as text\" console.error(e); onUnexpectedError(e); return undefined; } }))).filter(isDefined); </ins> const textResourceConfigurationService = this._textResourceConfigurationService;", "commid": "vscode_pr_199036"}], "negative_passages": []}
{"query_id": "q-en-vscode-2e9d383c5976acada63f922762a0b07bc9335ed1836a8fbdd78308908feede8a", "query": "Type: <bBug</bA corrupted file is stored in CachedExtensionVSIXs and never re-downloaded, preventing extension from being installed until the file is manually deleted. Repro: Attempt to install an extension while the Azure DevOps service is not available and returning errors. Result in this comment: The corrupted vsix contains the following HTML instead of zipped data ! Shared Output: VS Code version: Code 1.84.2 (, 2023-11-09T10:52:57.054Z) OS version: Darwin arm64 23.1.0 Modes: Connection to 'SSH: ox' could not be established Canceled <details<summarySystem Info</summary Connection to 'SSH: ox' could not be established Canceled </details<details<summaryExtensions (31)</summaryExtensionVersion ------ vscode-ron0.11.0 vscode-eslint2.4.2 prettier-vscode10.1.0 kotlin0.2.32 copilot1.139.0 copilot-chat0.10.2 copilot-labs0.17.1121 vscode-github-actions0.26.2 better-cpp-syntax1.17.2 vscode-peacock4.2.2 vscode-clangd0.1.25 membrane1.6.1 vscode-dotnet-runtime2.0.0 vscode-postgresql0.3.0 remote-containers0.321.0 remote-ssh0.107.1 remote-ssh-edit0.86.0 cpptools-extension-pack1.3.0 hexeditor1.9.12 makefile-tools0.7.0 remote-explorer0.4.1 proto0.0.4 vscode-yaml1.14.0 vscode-gitweblinks2.9.3 rust-analyzer0.3.1748 even-better-toml0.19.2 shellcheck0.35.0 es6-string-html2.12.1 vscode-lldb1.10.0 vim1.27.1 clang-format1.9.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\ncc who was looking into this in\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nbumping to see if this issue is still occurring and if the fix has been verified!\nIt's somewhat fixed. You can try again and the second time it will work. But the error message that appears doesn't indicate that. perhaps it should retry at least once if the zip is corrupted before showing this error? Note the bottom right popup asking to manually download where a retry could've sufficed. <img width=\"1304\" alt=\"Screenshot 2023-12-06 at 6 14 41 PM\" src=\"\"\nThanks for the feedback. This bug is to fix not to cache corrupted VSIXs and please validate that. Regarding trying again, I do not think we should be showing this as this might be random.\nVerifying with a code review", "positive_passages": [{"docid": "doc-en-vscode-521b32210990218ed1225d3d5de862a1a99704c9c0c5d0ca1d78863d109bbdff", "text": "this.logService.trace(`Extension signature verification details for ${extension.identifier.id} ${extension.version}:n${sigError.output}`); } if (verificationStatus === ExtensionSignaturetErrorCode.PackageIsInvalidZip || verificationStatus === ExtensionSignaturetErrorCode.SignatureArchiveIsInvalidZip) { <ins> try { // Delete the downloaded vsix before throwing the error await this.delete(location); } catch (error) { this.logService.error(error); } </ins> throw new ExtensionManagementError(CorruptZipMessage, ExtensionManagementErrorCode.CorruptZip); } } finally {", "commid": "vscode_pr_199673"}], "negative_passages": []}
{"query_id": "q-en-vscode-c76ae30243c20ea79405025e773725ca755400e740e3a58ab269469838f62ca4", "query": "Repro: an editor to a new window (or as many as you want) the original window that still contains the editor that all windows with the copied editor have input lag ! Version: 1.85.0-insider (user setup) Commit: Date: 2023-12-01T19:00:37.339Z Electron: 25.9.6 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0.\nA regression from", "positive_passages": [{"docid": "doc-en-vscode-d912d787afffbf493156d34e23c22318dd0f0674ae1c0865b56ed409f3eb54ed", "text": "public static INSTANCE = new EditorRenderingCoordinator(); private _coordinatedRenderings: ICoordinatedRendering[] = []; <del> private _animationFrameRunner: IDisposable | null = null; </del> <ins> private _animationFrameRunners = new Map<CodeWindow, IDisposable>(); </ins> private constructor() { }", "commid": "vscode_pr_199933"}], "negative_passages": []}
{"query_id": "q-en-vscode-c76ae30243c20ea79405025e773725ca755400e740e3a58ab269469838f62ca4", "query": "Repro: an editor to a new window (or as many as you want) the original window that still contains the editor that all windows with the copied editor have input lag ! Version: 1.85.0-insider (user setup) Commit: Date: 2023-12-01T19:00:37.339Z Electron: 25.9.6 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0.\nA regression from", "positive_passages": [{"docid": "doc-en-vscode-75af694cf92928097a6e2babfbc74be073e3bdda2f7735acaaa8d27248adc9ae", "text": "this._coordinatedRenderings.splice(renderingIndex, 1); if (this._coordinatedRenderings.length === 0) { <del> // There are no more renderings to coordinate => cancel animation frame if (this._animationFrameRunner !== null) { this._animationFrameRunner.dispose(); this._animationFrameRunner = null; </del> <ins> // There are no more renderings to coordinate => cancel animation frames for (const [_, disposable] of this._animationFrameRunners) { disposable.dispose(); </ins> } <ins> this._animationFrameRunners.clear(); </ins> } } }; } private _scheduleRender(window: CodeWindow): void { <del> if (this._animationFrameRunner === null) { </del> <ins> if (!this._animationFrameRunners.has(window)) { </ins> const runner = () => { <del> this._animationFrameRunner = null; </del> <ins> this._animationFrameRunners.delete(window); </ins> this._onRenderScheduled(); }; <del> this._animationFrameRunner = dom.runAtThisOrScheduleAtNextAnimationFrame(window, runner, 100); </del> <ins> this._animationFrameRunners.set(window, dom.runAtThisOrScheduleAtNextAnimationFrame(window, runner, 100)); </ins> } }", "commid": "vscode_pr_199933"}], "negative_passages": []}
{"query_id": "q-en-vscode-8796a40bb5afbcf45bee0b0be4543f578a0b4da953d0c4378f48ef0dd09779fb", "query": "Type: <bFeature Request</bThe notification suggesting a plugin has a cog with an option \"Don't show again\". It's however not clear whether this suppresses suggesting the specific plugin, or any plugin. Either this message should be clarified (\"Don't show this plugin again\") or a second option should be . VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\n<img width=\"485\" alt=\"image\" src=\"\"<img width=\"478\" alt=\"image\" src=\"\"\nThank you.", "positive_passages": [{"docid": "doc-en-vscode-5d08c397a0efef3e2dba162480dd029d315f0af858b46c145bd87f4d6e1bb998", "text": "const ignoreImportantExtensionRecommendationStorageKey = 'extensionsAssistant/importantRecommendationsIgnore'; const donotShowWorkspaceRecommendationsStorageKey = 'extensionsAssistant/workspaceRecommendationsIgnore'; <del> const choiceNever = localize('neverShowAgain', \"Don't Show Again\"); </del> type RecommendationsNotificationActions = { onDidInstallRecommendedExtensions(extensions: IExtension[]): void;", "commid": "vscode_pr_202638"}], "negative_passages": []}
{"query_id": "q-en-vscode-8796a40bb5afbcf45bee0b0be4543f578a0b4da953d0c4378f48ef0dd09779fb", "query": "Type: <bFeature Request</bThe notification suggesting a plugin has a cog with an option \"Don't show again\". It's however not clear whether this suppresses suggesting the specific plugin, or any plugin. Either this message should be clarified (\"Don't show this plugin again\") or a second option should be . VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\n<img width=\"485\" alt=\"image\" src=\"\"<img width=\"478\" alt=\"image\" src=\"\"\nThank you.", "positive_passages": [{"docid": "doc-en-vscode-7f219a446bd0697330742a2679eaef97d8f6cb6352315ddcb1f6ecd2c06a031d", "text": "searchValue = source === RecommendationSource.WORKSPACE ? '@recommended' : extensions.map(extensionId => `@id:${extensionId.identifier.id}`).join(' '); } <ins> const donotShowAgainLabel = source === RecommendationSource.WORKSPACE ? localize('donotShowAgain', \"Don't Show Again for this Repository\") : extensions.length > 1 ? localize('donotShowAgainExtension', \"Don't Show Again for these Extensions\") : localize('donotShowAgainExtensionSingle', \"Don't Show Again for this Extension\"); </ins> return raceCancellablePromises([ <del> this._registerP(this.showRecommendationsNotification(extensions, message, searchValue, source, recommendationsNotificationActions)), </del> <ins> this._registerP(this.showRecommendationsNotification(extensions, message, searchValue, donotShowAgainLabel, source, recommendationsNotificationActions)), </ins> this._registerP(this.waitUntilRecommendationsAreInstalled(extensions)) ]); } <del> private showRecommendationsNotification(extensions: IExtension[], message: string, searchValue: string, source: RecommendationSource, </del> <ins> private showRecommendationsNotification(extensions: IExtension[], message: string, searchValue: string, donotShowAgainLabel: string, source: RecommendationSource, </ins> { onDidInstallRecommendedExtensions, onDidShowRecommendedExtensions, onDidCancelRecommendedExtensions, onDidNeverShowRecommendedExtensionsAgain }: RecommendationsNotificationActions): CancelablePromise<RecommendationsNotificationResult> { return createCancelablePromise<RecommendationsNotificationResult>(async token => { let accepted = false;", "commid": "vscode_pr_202638"}], "negative_passages": []}
{"query_id": "q-en-vscode-8796a40bb5afbcf45bee0b0be4543f578a0b4da953d0c4378f48ef0dd09779fb", "query": "Type: <bFeature Request</bThe notification suggesting a plugin has a cog with an option \"Don't show again\". It's however not clear whether this suppresses suggesting the specific plugin, or any plugin. Either this message should be clarified (\"Don't show this plugin again\") or a second option should be . VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\n<img width=\"485\" alt=\"image\" src=\"\"<img width=\"478\" alt=\"image\" src=\"\"\nThank you.", "positive_passages": [{"docid": "doc-en-vscode-3e8199fb6929836b54d75800bbf3f8f4dfaeac600e83e1f0cfe65be8c93dcb8b", "text": "this.runAction(this.instantiationService.createInstance(SearchExtensionsAction, searchValue)); } }, { <del> label: choiceNever, </del> <ins> label: donotShowAgainLabel, </ins> isSecondary: true, run: () => { onDidNeverShowRecommendedExtensionsAgain(extensions);", "commid": "vscode_pr_202638"}], "negative_passages": []}
{"query_id": "q-en-vscode-f61e7c5187cb4ac2d0d955ba5cb054a0ed489faab959708a6c6315d6cd6854c7", "query": "or VS Code Desktop something to make the autocompletion menu appear. the dash key (-) multiple times to zoom in a lot. Only the text in the menu gets larger while the html elements stay the same size. ! The html should resize with the text appropriately. Zooming in first and then revealing the menu produces the correct sizes on everything. It's possible that \"\" is the incorrect command to call in this case. Perhaps a list of commands could be provided?\nTo verify bind a keybinding to Editor Zoom In/out trigger suggest while it shows, use the editor zoom keybindings", "positive_passages": [{"docid": "doc-en-vscode-612df9a4ab3e9548fd25f39b263b2e75b32afe9b0adc745ae3c33bdcfd094403", "text": "applyStatusBarStyle(); applyIconStyle(); } <ins> if (this._completionModel && (e.hasChanged(EditorOption.fontInfo) || e.hasChanged(EditorOption.suggestFontSize) || e.hasChanged(EditorOption.suggestLineHeight))) { this._list.splice(0, this._list.length, this._completionModel.items); } </ins> })); this._ctxSuggestWidgetVisible = SuggestContext.Visible.bindTo(_contextKeyService);", "commid": "vscode_pr_200632"}], "negative_passages": []}
{"query_id": "q-en-vscode-f61e7c5187cb4ac2d0d955ba5cb054a0ed489faab959708a6c6315d6cd6854c7", "query": "or VS Code Desktop something to make the autocompletion menu appear. the dash key (-) multiple times to zoom in a lot. Only the text in the menu gets larger while the html elements stay the same size. ! The html should resize with the text appropriately. Zooming in first and then revealing the menu produces the correct sizes on everything. It's possible that \"\" is the incorrect command to call in this case. Perhaps a list of commands could be provided?\nTo verify bind a keybinding to Editor Zoom In/out trigger suggest while it shows, use the editor zoom keybindings", "positive_passages": [{"docid": "doc-en-vscode-af29876667373a81280f3ba263af05babeb1f9de6d48b91a86d7eeee8c268047", "text": "readonly detailsLabel: HTMLElement; readonly readMore: HTMLElement; readonly disposables: DisposableStore; <ins> readonly configureFont: () => void; </ins> } export class ItemRenderer implements IListRenderer<CompletionItem, ISuggestionTemplateData> {", "commid": "vscode_pr_200632"}], "negative_passages": []}
{"query_id": "q-en-vscode-f61e7c5187cb4ac2d0d955ba5cb054a0ed489faab959708a6c6315d6cd6854c7", "query": "or VS Code Desktop something to make the autocompletion menu appear. the dash key (-) multiple times to zoom in a lot. Only the text in the menu gets larger while the html elements stay the same size. ! The html should resize with the text appropriately. Zooming in first and then revealing the menu produces the correct sizes on everything. It's possible that \"\" is the incorrect command to call in this case. Perhaps a list of commands could be provided?\nTo verify bind a keybinding to Editor Zoom In/out trigger suggest while it shows, use the editor zoom keybindings", "positive_passages": [{"docid": "doc-en-vscode-e6058421ddd6a0ca3b79ce109db4916e4a965271cea1d769e91a40d0b04f3ee5", "text": "readMore.style.width = lineHeightPx; }; <del> configureFont(); disposables.add(this._editor.onDidChangeConfiguration(e => { if (e.hasChanged(EditorOption.fontInfo) || e.hasChanged(EditorOption.suggestFontSize) || e.hasChanged(EditorOption.suggestLineHeight)) { configureFont(); } })); return { root, left, right, icon, colorspan, iconLabel, iconContainer, parametersLabel, qualifierLabel, detailsLabel, readMore, disposables }; </del> <ins> return { root, left, right, icon, colorspan, iconLabel, iconContainer, parametersLabel, qualifierLabel, detailsLabel, readMore, disposables, configureFont }; </ins> } renderElement(element: CompletionItem, index: number, data: ISuggestionTemplateData): void { <ins> data.configureFont(); </ins> const { completion } = element; data.root.id = getAriaId(index); data.colorspan.style.backgroundColor = '';", "commid": "vscode_pr_200632"}], "negative_passages": []}
{"query_id": "q-en-vscode-177dcaaacbb35d31f983e15f144a8f72e9bd0f12e20de289e14f805fa13cec31", "query": "Type: <bBug</bWhen first opening vscode or reloading the window several context keys are set to incorrect values. These values may eventually be corrected when focusing another editor and returning to the original one. The keys I have noticed with this issue are: It can be a little tricky to catch some of them misbehaving. It depends on which editors you have open and how they are arranged. ! Steps to repro: Open 2 editors Focus the first editor Pin it Record context keys Reload window Record context keys Diff the two sets of context keys and notice they are not the same VS Code version: Code - Insiders 1.86.0-insider (, 2023-12-18T05:36:59.983Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nBen, maybe you could check for the ones in editor area since you recently fixed some issues there. Maybe its a regression?\nThe following context keys were not being updated on reload: Updating them now on reload\nThis seems to apply to a few additional context keys outside of . Just a heads up in case closing the issue was accidental.", "positive_passages": [{"docid": "doc-en-vscode-073e8c7afdb57f1591c1a9a96daff19f2636c8d93cb5486e43483dec8a054cb1", "text": "}; // Update group contexts based on group changes <del> this._register(this.onDidModelChange(e => { </del> <ins> const updateGroupContextKeys = (e: IGroupModelChangeEvent) => { </ins> switch (e.kind) { case GroupModelChangeKind.GROUP_LOCKED: groupLockedContext.set(this.isLocked);", "commid": "vscode_pr_201277"}], "negative_passages": []}
{"query_id": "q-en-vscode-177dcaaacbb35d31f983e15f144a8f72e9bd0f12e20de289e14f805fa13cec31", "query": "Type: <bBug</bWhen first opening vscode or reloading the window several context keys are set to incorrect values. These values may eventually be corrected when focusing another editor and returning to the original one. The keys I have noticed with this issue are: It can be a little tricky to catch some of them misbehaving. It depends on which editors you have open and how they are arranged. ! Steps to repro: Open 2 editors Focus the first editor Pin it Record context keys Reload window Record context keys Diff the two sets of context keys and notice they are not the same VS Code version: Code - Insiders 1.86.0-insider (, 2023-12-18T05:36:59.983Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nBen, maybe you could check for the ones in editor area since you recently fixed some issues there. Maybe its a regression?\nThe following context keys were not being updated on reload: Updating them now on reload\nThis seems to apply to a few additional context keys outside of . Just a heads up in case closing the issue was accidental.", "positive_passages": [{"docid": "doc-en-vscode-291e667dea4e7c881c2f55c75b301ada257a99ffb09b8bbc6d4024943c289d91", "text": "// Group editors count context groupEditorsCountContext.set(this.count); <del> })); </del> <ins> }; this._register(this.onDidModelChange(e => updateGroupContextKeys(e))); </ins> // Track the active editor and update context key that reflects // the dirty state of this editor <del> this._register(this.onDidActiveEditorChange(() => { observeActiveEditor(); })); </del> <ins> this._register(this.onDidActiveEditorChange(() => observeActiveEditor())); </ins> // Update context keys on startup observeActiveEditor(); <ins> updateGroupContextKeys({ kind: GroupModelChangeKind.EDITOR_ACTIVE }); updateGroupContextKeys({ kind: GroupModelChangeKind.GROUP_LOCKED }); </ins> } private registerContainerListeners(): void {", "commid": "vscode_pr_201277"}], "negative_passages": []}
{"query_id": "q-en-vscode-7f5c7c09ebd3688f57599a13e4f271c776e7a59992adec2e94fbd4cf170c5773", "query": "Testing The setting says \" speech recognized\" which reads a bit weird. Maybe leave \"speech\" away or says \"Controls whether the editor listens for the 'Hey Code' phrase and what to do with it\"\nBonus points for mentioning that this happens all locally\nYeah, I think I will go with this:", "positive_passages": [{"docid": "doc-en-vscode-442c1369af3c824a52cd259ff783b2b8d466a6b67eac22d3ee47769ee079473a", "text": "localize('voice.keywordActivation.inlineChat', \"Keyword activation is enabled and listening for 'Hey Code' to start a voice chat session in the active editor.\"), localize('voice.keywordActivation.chatInContext', \"Keyword activation is enabled and listening for 'Hey Code' to start a voice chat session in the active editor or view depending on keyboard focus.\") ], <del> 'description': localize('voice.keywordActivation', \"Controls whether the phrase 'Hey Code' should be speech recognized to start a voice chat session.\"), </del> <ins> 'description': localize('voice.keywordActivation', \"Controls whether the keyword phrase 'Hey Code' is recognized to start a voice chat session. Enabling this will start recording from the microphone but the audio is processed locally and never sent to a server.\"), </ins> 'default': 'off', 'tags': ['accessibility', 'FeatureInsight'] }", "commid": "vscode_pr_203226"}], "negative_passages": []}
{"query_id": "q-en-vscode-1492fb87a722a807492361a64f9c71b86f3b912556e882408fa257257f0b8481", "query": "]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.3; #Color Contrast; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise 22H2 Build .3007 Visual Studio Code Insiders editor ctrl+P or Tab till go and press ENTER then TAB till Go to File. that Color contrast ratio of the \"search files by name\" placeholder text is \"2.283:1\" which is less than 4.5:1. Color contrast ratio of the \"search files by name\" placeholder text is \"2.283:1\" which is less than 4.5:1. Similar issue is also observed throughout the application. Color contrast ratio of the \"search files by name\" placeholder text should be greater than or equals to 4.5:1. Low vision users will not be able to see the placeholder text if color contrast ratio will be less than 4.5:1. ! !\nI can't reproduce this one. With the Dark Modern theme I see a background value for inputs of which passes the 3:1 ratio with the placeholder foreground of .\nMisread that the ratio should be 4.5:1. This I can fix.\nVerified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is fixed. Hence Closing the bug. please find attachment for reference. !", "positive_passages": [{"docid": "doc-en-vscode-7088851ee058556f88f463031b2ac532a391f591bbabe4572f2e6d478b31837c", "text": "\"input.background\": \"#313131\", \"input.border\": \"#3C3C3C\", \"input.foreground\": \"#CCCCCC\", <del> \"input.placeholderForeground\": \"#818181\", </del> <ins> \"input.placeholderForeground\": \"#989898\", </ins> \"inputOption.activeBackground\": \"#2489DB82\", \"inputOption.activeBorder\": \"#2488DB\", \"keybindingLabel.foreground\": \"#CCCCCC\",", "commid": "vscode_pr_203988"}], "negative_passages": []}
{"query_id": "q-en-vscode-1492fb87a722a807492361a64f9c71b86f3b912556e882408fa257257f0b8481", "query": "]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.3; #Color Contrast; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise 22H2 Build .3007 Visual Studio Code Insiders editor ctrl+P or Tab till go and press ENTER then TAB till Go to File. that Color contrast ratio of the \"search files by name\" placeholder text is \"2.283:1\" which is less than 4.5:1. Color contrast ratio of the \"search files by name\" placeholder text is \"2.283:1\" which is less than 4.5:1. Similar issue is also observed throughout the application. Color contrast ratio of the \"search files by name\" placeholder text should be greater than or equals to 4.5:1. Low vision users will not be able to see the placeholder text if color contrast ratio will be less than 4.5:1. ! !\nI can't reproduce this one. With the Dark Modern theme I see a background value for inputs of which passes the 3:1 ratio with the placeholder foreground of .\nMisread that the ratio should be 4.5:1. This I can fix.\nVerified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is fixed. Hence Closing the bug. please find attachment for reference. !", "positive_passages": [{"docid": "doc-en-vscode-11e53b1a2005272e51bf5574aefba21101c4a682b3885257ec8bdabaa68e5a43", "text": "\"input.background\": \"#FFFFFF\", \"input.border\": \"#CECECE\", \"input.foreground\": \"#3B3B3B\", <del> \"input.placeholderForeground\": \"#868686\", </del> <ins> \"input.placeholderForeground\": \"#767676\", </ins> \"inputOption.activeBackground\": \"#BED6ED\", \"inputOption.activeBorder\": \"#005FB8\", \"inputOption.activeForeground\": \"#000000\",", "commid": "vscode_pr_203988"}], "negative_passages": []}
{"query_id": "q-en-vscode-695f3a2fe516e031595ac3af498d99e3d0cb4a5759515394cffb777827988cd6", "query": "Type: <bBug</bSince updating to 1.86, when I open a git diff in VSCode, I see the latest version of the file on both sides, showing no differences (except that word wrap is off on the left & on on the right... it's on everywhere else)... if I stage a file, open the diff, then unstage the file, then I see the correct diff like I've always seen before likely related: the new +- buttons next to Changes & Staged Changes show the same behavior (although while playing with it, I did have one time where I saw the correct diff on the first file) at one point I restarted VSCode, which seemed to resolve the issue, but it was only temporary. once I started editing files again the issue returned not sure if it's relevant or not, but... in all cases, the changes were saved to disk... the git change indicators in the left gutter of open files are not affected by this issue, they continue to work as the always have, showing up as I edit, clearing when I stage the change VS Code version: Code 1.86.0 (, 2024-01-31T10:28:19.990Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ vscode-icalendar1.0.1 vscode-m3u1.0.0 vscode-caniuse0.5.0 case-change1.0.2 rtf2.7.0 spellright3.0.122 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-mermaid1.21.0 markdown-yaml-preamble0.1.0 vscode-tldr1.0.0 gitignore0.9.0 vscode-markdownlint0.54.0 vscode-eslint2.4.4 rushcore1.0.2 rushnav1.0.2 githistory0.6.20 xml2.5.1 escaping-characters1.0.0 EditorConfig0.16.4 vscode-macros1.4.1 git-project-manager1.8.2 url-encode1.1.0 shell-format7.2.5 matlab3.0.2 vscode-pull-request-github0.80.0 gc-excelviewer4.2.58 vscode-markdown-footnote1.0.0 vscode-favorites1.11.0 rest-client0.25.1 path-autocomplete1.25.0 mediawiki2.1.0 anki1.3.1 markdown-katex0.1.4 vscode-peacock4.2.2 gpg1.1.1 zotero0.1.11 markdown-shortcuts0.12.0 debugpy2024.0.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 azure-account0.11.6 azurecli0.6.0 hexeditor1.9.13 live-server0.4.13 vscode-yaml1.14.0 vscode-zipexplorer0.3.1 pdf1.2.2 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-icons12.7.0 org-mode1.0.0 JavaScriptSnippets1.8.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nPlease use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.\nI can duplicate this in Insiders with no extensions loaded (... however, that opening & closing revealed more details I didn't realize previously... I only see the buggy behavior with changes made in this session... if I close & reopen VSCode, changes that were staged before VSCode opened render correctly... new changes stop rendering when they're staged (and when I say \"stop rendering\" I mean no red & green highlights, because both sides of the diff tab contain the new code) & start rendering again when the app is restarted (or I switch between Release & Insiders) side notes: I'm no longer seeing the no word wrap on the left in VSCode (& I never saw it in Insiders), so not sure what was up with that... I know that there are often visual artifacts in one side of the diff editor (e.g. valid relative paths get yellow squiggles on one side but not the other), so guess I'll put this one in that category... who cares? I'll see that in the main editor, I just want the diff in the diff viewer I forgot to try Insiders before I submitted because it was so obvious that only 1 thing changed, but I'll try to remember that just to make sure it hasn't been fixed already... but, I don't appreciate being asked to go on a wild goose chase bisecting extensions\none more thing I just noticed... prior to 1.86, if I stages a file, then made additional changes, so that the file is now in the Source Control panel twice... the 2 diff buttons would open 2 separate diffs, one with the staged changes & 1 with unstaged... now I get only one (with the unstaged changes) also, it makes no sense that the bot removed the label, unless there's been another Release since 1.86, and the Releases page still shows that as the newest version\nI've had this issue since February too. Strangely enough, I started an Extension Bisect, stopped straight away (intending to restart) and now I don't have the issue. \u00af(\u00b0_o)/\u00af\nI'm hitting this too on two completely different machines (Windows and Linux). The issue is if you click the diff button on a staged file just after staging it, for some reason it opens the working tree diff (which has no differences). If you reload the window so it starts with the file already staged then the button correctly opens the index diff. I reproduced this with no extensions enabled. I think the reason this enormous bug has gone unnoticed for so long (I only just looked into it because I assumed that surely they would fix something as broken as this...), is that it only happens if you have this setting: Do you guys have that set?\nyes, I do have that setting... and if I comment it out, I see the correct behavior\nSorry for not getting back to you on this. Could any of you experiencing this issue provide a screen recording illustrating the issue ()? Thank you very much in advance!\nUgh I can't seem to reproduce it at the moment - sometimes it does work, but I haven't found the exact pattern. So you'll have to use your imagination, but basically you click the diff button for a file (two circles connected by arrows) and it opens a diff view but there are no differences between the files on the left and right of the view. Next time it happens I'll try to record it.\nAre you able to reproduce the issue if you disable the setting? Thanks!\nDidn't seem to make any difference - I still can't reproduce it, sorry. What does that setting actually do? It doesn't seem to make any difference to behaviour and I don't understand the description: ! The Source Control view still automatically updates even if I have that off.\nif I add to my settings I can repro, without it I can't repro... just recorded with gitcap, waiting for it to render so I can get a link\nvideo was way over GitHub's 10MB limit... so dropped it in my OneDrive & tried to include it as an image... !Auy35hyaQsjmnpB70oGx2DvOlOjaXg?e=YLgT5J!\ncould you please re-upload the recording as it looks like it is not available at the link any more. Thanks!\ni will try tonight... on vacay this week, so might need to wait until I'm back on the work PC Monday\nany news on the recording? Thank you!\nwith in settings (without it I see expected behavior) !\nthanks again! I have a fix but it will not make the cut for the August 2024 release so it will be in the September 2024 release.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nFriendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.\nVerification steps: VS Code Insiders to a file, modify it and save it the Source Control view and click on \"Open Changes\" action Confirm that the diff is rendered correctly on the \"Stage Changes\" action on \"Open Changes\" action Confirm that the diff is rendered correctly", "positive_passages": [{"docid": "doc-en-vscode-2e46aba0ff5233a919dec8f0c0e1d13b39297f8be81fe326c03a823cce1565f4", "text": "return -1; } <ins> if (result !== 0) { return result; } </ins> if (a.multiFileDiffEditorModifiedUri && b.multiFileDiffEditorModifiedUri) { result = comparePaths(a.multiFileDiffEditorModifiedUri.fsPath, b.multiFileDiffEditorModifiedUri.fsPath, true); } else if (a.multiFileDiffEditorModifiedUri) {", "commid": "vscode_pr_227197"}], "negative_passages": []}
{"query_id": "q-en-vscode-695f3a2fe516e031595ac3af498d99e3d0cb4a5759515394cffb777827988cd6", "query": "Type: <bBug</bSince updating to 1.86, when I open a git diff in VSCode, I see the latest version of the file on both sides, showing no differences (except that word wrap is off on the left & on on the right... it's on everywhere else)... if I stage a file, open the diff, then unstage the file, then I see the correct diff like I've always seen before likely related: the new +- buttons next to Changes & Staged Changes show the same behavior (although while playing with it, I did have one time where I saw the correct diff on the first file) at one point I restarted VSCode, which seemed to resolve the issue, but it was only temporary. once I started editing files again the issue returned not sure if it's relevant or not, but... in all cases, the changes were saved to disk... the git change indicators in the left gutter of open files are not affected by this issue, they continue to work as the always have, showing up as I edit, clearing when I stage the change VS Code version: Code 1.86.0 (, 2024-01-31T10:28:19.990Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (55)</summaryExtensionVersion ------ vscode-icalendar1.0.1 vscode-m3u1.0.0 vscode-caniuse0.5.0 case-change1.0.2 rtf2.7.0 spellright3.0.122 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-mermaid1.21.0 markdown-yaml-preamble0.1.0 vscode-tldr1.0.0 gitignore0.9.0 vscode-markdownlint0.54.0 vscode-eslint2.4.4 rushcore1.0.2 rushnav1.0.2 githistory0.6.20 xml2.5.1 escaping-characters1.0.0 EditorConfig0.16.4 vscode-macros1.4.1 git-project-manager1.8.2 url-encode1.1.0 shell-format7.2.5 matlab3.0.2 vscode-pull-request-github0.80.0 gc-excelviewer4.2.58 vscode-markdown-footnote1.0.0 vscode-favorites1.11.0 rest-client0.25.1 path-autocomplete1.25.0 mediawiki2.1.0 anki1.3.1 markdown-katex0.1.4 vscode-peacock4.2.2 gpg1.1.1 zotero0.1.11 markdown-shortcuts0.12.0 debugpy2024.0.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 azure-account0.11.6 azurecli0.6.0 hexeditor1.9.13 live-server0.4.13 vscode-yaml1.14.0 vscode-zipexplorer0.3.1 pdf1.2.2 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-icons12.7.0 org-mode1.0.0 JavaScriptSnippets1.8.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nPlease use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.\nI can duplicate this in Insiders with no extensions loaded (... however, that opening & closing revealed more details I didn't realize previously... I only see the buggy behavior with changes made in this session... if I close & reopen VSCode, changes that were staged before VSCode opened render correctly... new changes stop rendering when they're staged (and when I say \"stop rendering\" I mean no red & green highlights, because both sides of the diff tab contain the new code) & start rendering again when the app is restarted (or I switch between Release & Insiders) side notes: I'm no longer seeing the no word wrap on the left in VSCode (& I never saw it in Insiders), so not sure what was up with that... I know that there are often visual artifacts in one side of the diff editor (e.g. valid relative paths get yellow squiggles on one side but not the other), so guess I'll put this one in that category... who cares? I'll see that in the main editor, I just want the diff in the diff viewer I forgot to try Insiders before I submitted because it was so obvious that only 1 thing changed, but I'll try to remember that just to make sure it hasn't been fixed already... but, I don't appreciate being asked to go on a wild goose chase bisecting extensions\none more thing I just noticed... prior to 1.86, if I stages a file, then made additional changes, so that the file is now in the Source Control panel twice... the 2 diff buttons would open 2 separate diffs, one with the staged changes & 1 with unstaged... now I get only one (with the unstaged changes) also, it makes no sense that the bot removed the label, unless there's been another Release since 1.86, and the Releases page still shows that as the newest version\nI've had this issue since February too. Strangely enough, I started an Extension Bisect, stopped straight away (intending to restart) and now I don't have the issue. \u00af(\u00b0_o)/\u00af\nI'm hitting this too on two completely different machines (Windows and Linux). The issue is if you click the diff button on a staged file just after staging it, for some reason it opens the working tree diff (which has no differences). If you reload the window so it starts with the file already staged then the button correctly opens the index diff. I reproduced this with no extensions enabled. I think the reason this enormous bug has gone unnoticed for so long (I only just looked into it because I assumed that surely they would fix something as broken as this...), is that it only happens if you have this setting: Do you guys have that set?\nyes, I do have that setting... and if I comment it out, I see the correct behavior\nSorry for not getting back to you on this. Could any of you experiencing this issue provide a screen recording illustrating the issue ()? Thank you very much in advance!\nUgh I can't seem to reproduce it at the moment - sometimes it does work, but I haven't found the exact pattern. So you'll have to use your imagination, but basically you click the diff button for a file (two circles connected by arrows) and it opens a diff view but there are no differences between the files on the left and right of the view. Next time it happens I'll try to record it.\nAre you able to reproduce the issue if you disable the setting? Thanks!\nDidn't seem to make any difference - I still can't reproduce it, sorry. What does that setting actually do? It doesn't seem to make any difference to behaviour and I don't understand the description: ! The Source Control view still automatically updates even if I have that off.\nif I add to my settings I can repro, without it I can't repro... just recorded with gitcap, waiting for it to render so I can get a link\nvideo was way over GitHub's 10MB limit... so dropped it in my OneDrive & tried to include it as an image... !Auy35hyaQsjmnpB70oGx2DvOlOjaXg?e=YLgT5J!\ncould you please re-upload the recording as it looks like it is not available at the link any more. Thanks!\ni will try tonight... on vacay this week, so might need to wait until I'm back on the work PC Monday\nany news on the recording? Thank you!\nwith in settings (without it I see expected behavior) !\nthanks again! I have a fix but it will not make the cut for the August 2024 release so it will be in the September 2024 release.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nFriendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.\nVerification steps: VS Code Insiders to a file, modify it and save it the Source Control view and click on \"Open Changes\" action Confirm that the diff is rendered correctly on the \"Stage Changes\" action on \"Open Changes\" action Confirm that the diff is rendered correctly", "positive_passages": [{"docid": "doc-en-vscode-7d29362cd34d530bb6c9f3e07b7f62fb5c289f70bccd1d65a795178db7f1beeb", "text": "} else if (b.multiFileDiffEditorModifiedUri) { return -1; } <ins> if (result !== 0) { return result; } </ins> if (a.multiDiffEditorOriginalUri && b.multiDiffEditorOriginalUri) { result = comparePaths(a.multiDiffEditorOriginalUri.fsPath, b.multiDiffEditorOriginalUri.fsPath, true); } else if (a.multiDiffEditorOriginalUri) {", "commid": "vscode_pr_227197"}], "negative_passages": []}
{"query_id": "q-en-vscode-9ad36cd7c3cbf176e3f42eaeb6c74b2bfaba03debdd3d1dedc1f0e1076160fb3", "query": "<img width=\"431\" alt=\"image\" src=\"\"The debug view uses monospace font by default other than the workbench font", "positive_passages": [{"docid": "doc-en-vscode-29aff51c8c32727b0ccb3bc73e923c27df1629b9d58a21df2e4bcfb92c501d7a", "text": "protected override renderBody(container: HTMLElement): void { super.renderBody(container); <ins> this.element.classList.add('debug-pane'); </ins> this.tree = <WorkbenchAsyncDataTree<INotebookScope, INotebookVariableElement>>this.instantiationService.createInstance( WorkbenchAsyncDataTree,", "commid": "vscode_pr_205030"}], "negative_passages": []}
{"query_id": "q-en-vscode-940a961707ac5f80b9f156d060c160f2389b926b48aad2aa6014544b899ebfca", "query": "Enable Write a long commit message that triggers validation Hover over the diagnostic squiggle <img width=\"405\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-db8c0215826c40b6db5c4bcf0bda843569fd34897afcfdb604083e4769c587ae", "text": "private renderMarkerStatusbar(context: IEditorHoverRenderContext, markerHover: MarkerHover, disposables: DisposableStore): void { if (markerHover.marker.severity === MarkerSeverity.Error || markerHover.marker.severity === MarkerSeverity.Warning || markerHover.marker.severity === MarkerSeverity.Info) { <del> context.statusBar.addAction({ label: nls.localize('view problem', \"View Problem\"), commandId: NextMarkerAction.ID, run: () => { context.hide(); MarkerController.get(this._editor)?.showAtMarker(markerHover.marker); this._editor.focus(); } }); </del> <ins> const markerController = MarkerController.get(this._editor); if (markerController) { context.statusBar.addAction({ label: nls.localize('view problem', \"View Problem\"), commandId: NextMarkerAction.ID, run: () => { context.hide(); markerController.showAtMarker(markerHover.marker); this._editor.focus(); } }); } </ins> } if (!this._editor.getOption(EditorOption.readOnly)) {", "commid": "vscode_pr_204986"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ee2e8d83910813ba82917dd319082cecfc29b4915d99b9df5f5596170bd4ba7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nThanks a lot!", "positive_passages": [{"docid": "doc-en-vscode-0c8944efc7c9bf8bfba90a866c12a6b9fcb226786952d0104e16ee7311c8af36", "text": "import { getWindow, runWhenWindowIdle } from 'vs/base/browser/dom'; import { onUnexpectedError } from 'vs/base/common/errors'; <del> import { Disposable, DisposableMap } from 'vs/base/common/lifecycle'; </del> <ins> import { Disposable, DisposableMap, IDisposable } from 'vs/base/common/lifecycle'; </ins> import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { EditorContributionInstantiation, IEditorContributionDescription } from 'vs/editor/browser/editorExtensions'; import { IEditorContribution } from 'vs/editor/common/editorCommon';", "commid": "vscode_pr_205488"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ee2e8d83910813ba82917dd319082cecfc29b4915d99b9df5f5596170bd4ba7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nThanks a lot!", "positive_passages": [{"docid": "doc-en-vscode-e0fc57c95867bd8a03d77b4ed4f133cfab135b36f6d64347976c4e634ca323dd", "text": "this._instantiateSome(EditorContributionInstantiation.BeforeFirstInteraction); } <del> public onAfterModelAttached(): void { this._register(runWhenWindowIdle(getWindow(this._editor?.getDomNode()), () => { </del> <ins> public onAfterModelAttached(): IDisposable { return runWhenWindowIdle(getWindow(this._editor?.getDomNode()), () => { </ins> this._instantiateSome(EditorContributionInstantiation.AfterFirstRender); <del> }, 50)); </del> <ins> }, 50); </ins> } private _instantiateSome(instantiation: EditorContributionInstantiation): void {", "commid": "vscode_pr_205488"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ee2e8d83910813ba82917dd319082cecfc29b4915d99b9df5f5596170bd4ba7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nThanks a lot!", "positive_passages": [{"docid": "doc-en-vscode-06603e3a1e03e707befd8d5a5fa1f33352ea1260e2288f34a902f2e2bfe8c332", "text": "private readonly _overflowWidgetsDomNode: HTMLElement | undefined; private readonly _id: number; private readonly _configuration: IEditorConfiguration; <ins> private _contributionsDisposable: IDisposable | undefined; </ins> protected readonly _actions = new Map<string, editorCommon.IEditorAction>();", "commid": "vscode_pr_205488"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ee2e8d83910813ba82917dd319082cecfc29b4915d99b9df5f5596170bd4ba7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nThanks a lot!", "positive_passages": [{"docid": "doc-en-vscode-bee1383b9bcb670a9e1da340caacc5b49ba4dd1252bf938bf10504bc0fab6bab", "text": "this._onDidChangeModel.fire(e); this._postDetachModelCleanup(detachedModel); <del> this._contributions.onAfterModelAttached(); </del> <ins> this._contributionsDisposable = this._contributions.onAfterModelAttached(); </ins> } private _removeDecorationTypes(): void {", "commid": "vscode_pr_205488"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ee2e8d83910813ba82917dd319082cecfc29b4915d99b9df5f5596170bd4ba7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nThanks a lot!", "positive_passages": [{"docid": "doc-en-vscode-9b0a657bc5d3f06ead719e72cbdde49ccb6df746f08a0377f0e89ebef2b38393", "text": "} private _detachModel(): ITextModel | null { <ins> this._contributionsDisposable?.dispose(); this._contributionsDisposable = undefined; </ins> if (!this._modelData) { return null; }", "commid": "vscode_pr_205488"}], "negative_passages": []}
{"query_id": "q-en-vscode-6ee2e8d83910813ba82917dd319082cecfc29b4915d99b9df5f5596170bd4ba7", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nThanks a lot!", "positive_passages": [{"docid": "doc-en-vscode-77983ad180f0923ed7c2c94d8f28306f803cf184cdd27e5d967336eadaab1838", "text": "if (this._bannerDomNode && this._domElement.contains(this._bannerDomNode)) { this._domElement.removeChild(this._bannerDomNode); } return model; }", "commid": "vscode_pr_205488"}], "negative_passages": []}
{"query_id": "q-en-vscode-ba9e610aaad8c4df3322d938125598143ddc1aebd9f3e32f010313018244b9ed", "query": "In VS Code action items inside inputs are vertically aligned to top, in the Chat features they are centered in the middle. This happens when putting in a lot of text or pressing Shift+Enter. Panel: <img width=\"425\" alt=\"image\" src=\"\"Inline: <img width=\"608\" alt=\"image\" src=\"\"Quick: <img width=\"621\" alt=\"image\" src=\"\"For Inline and Quick the action items to the right of the input box should also stick to the top.\nSeems like we have a mix of top-aligned and overflow w/ scroll (see below). But I agree that we should be consistent as much as possible. But it does feel like a chat send button should generally but aligned to the bottom, no? We may even consider rendering the toolbar on its own row once we're into multiple lines. That would ensure the text isn't forced to fill a tiny space now that we have 2+ icons. Here's how Teams does it as an example: ! ! ! !\nWould be awesome if the text could wrap around it, especially in the narrow search widget case, I've always wanted that but I think it would be a pain to implement.\nDon't have a strong opinion about top or bottom, I think each can be justified on a case-by-case basis. but middle looks weird. :) For example, inline Chat may want to do top alignment as the icons would align with those outside the input field (poppet and close) Bottom would help with the wrapping.", "positive_passages": [{"docid": "doc-en-vscode-f94cc7287ef00a847743ccb7f1129853ab57365fe162864bf487ff297cf3e53e", "text": "position: relative; padding: 0 6px; margin-bottom: 4px; <del> align-items: center; </del> <ins> align-items: flex-end; </ins> justify-content: space-between; }", "commid": "vscode_pr_207662"}], "negative_passages": []}
{"query_id": "q-en-vscode-ba9e610aaad8c4df3322d938125598143ddc1aebd9f3e32f010313018244b9ed", "query": "In VS Code action items inside inputs are vertically aligned to top, in the Chat features they are centered in the middle. This happens when putting in a lot of text or pressing Shift+Enter. Panel: <img width=\"425\" alt=\"image\" src=\"\"Inline: <img width=\"608\" alt=\"image\" src=\"\"Quick: <img width=\"621\" alt=\"image\" src=\"\"For Inline and Quick the action items to the right of the input box should also stick to the top.\nSeems like we have a mix of top-aligned and overflow w/ scroll (see below). But I agree that we should be consistent as much as possible. But it does feel like a chat send button should generally but aligned to the bottom, no? We may even consider rendering the toolbar on its own row once we're into multiple lines. That would ensure the text isn't forced to fill a tiny space now that we have 2+ icons. Here's how Teams does it as an example: ! ! ! !\nWould be awesome if the text could wrap around it, especially in the narrow search widget case, I've always wanted that but I think it would be a pain to implement.\nDon't have a strong opinion about top or bottom, I think each can be justified on a case-by-case basis. but middle looks weird. :) For example, inline Chat may want to do top alignment as the icons would align with those outside the input field (poppet and close) Bottom would help with the wrapping.", "positive_passages": [{"docid": "doc-en-vscode-0005f7662b50a0376687cf82b2c38eef3d15c114c08d782dd04ae8edf5c16235", "text": ".interactive-session .interactive-input-part .interactive-execute-toolbar { height: 22px; <ins> /* It's bottom-aligned, make it appear centered within the container */ margin-bottom: 7px; </ins> } .interactive-session .interactive-input-part .interactive-execute-toolbar .codicon-debug-stop {", "commid": "vscode_pr_207662"}], "negative_passages": []}
{"query_id": "q-en-vscode-ba9e610aaad8c4df3322d938125598143ddc1aebd9f3e32f010313018244b9ed", "query": "In VS Code action items inside inputs are vertically aligned to top, in the Chat features they are centered in the middle. This happens when putting in a lot of text or pressing Shift+Enter. Panel: <img width=\"425\" alt=\"image\" src=\"\"Inline: <img width=\"608\" alt=\"image\" src=\"\"Quick: <img width=\"621\" alt=\"image\" src=\"\"For Inline and Quick the action items to the right of the input box should also stick to the top.\nSeems like we have a mix of top-aligned and overflow w/ scroll (see below). But I agree that we should be consistent as much as possible. But it does feel like a chat send button should generally but aligned to the bottom, no? We may even consider rendering the toolbar on its own row once we're into multiple lines. That would ensure the text isn't forced to fill a tiny space now that we have 2+ icons. Here's how Teams does it as an example: ! ! ! !\nWould be awesome if the text could wrap around it, especially in the narrow search widget case, I've always wanted that but I think it would be a pain to implement.\nDon't have a strong opinion about top or bottom, I think each can be justified on a case-by-case basis. but middle looks weird. :) For example, inline Chat may want to do top alignment as the icons would align with those outside the input field (poppet and close) Bottom would help with the wrapping.", "positive_passages": [{"docid": "doc-en-vscode-f24d5fefd3aeae384eb037219faf2ec3cdce8c77e4d9ced5690767e8e67f3d48", "text": "} .quick-input-widget .interactive-session .interactive-input-part .interactive-execute-toolbar { <del> bottom: 1px; </del> <ins> margin-bottom: 1px; </ins> } .quick-input-widget .interactive-session .interactive-input-and-execute-toolbar {", "commid": "vscode_pr_207662"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-80126c824c66a0123d0fd258e700645bee6744234032ceadc9bd0acc59b92128", "text": "private _sessionCtor: CancelablePromise<void> | undefined; private _activeSession?: Session; private _warmupRequestCts?: CancellationTokenSource; <ins> private _activeRequestCts?: CancellationTokenSource; </ins> private readonly _ctxHasActiveRequest: IContextKey<boolean>; private readonly _ctxCellWidgetFocused: IContextKey<boolean>; private readonly _ctxUserDidEdit: IContextKey<boolean>;", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-1bd1ffe0ef61396eff5dde6e87b95ae91bbd5ae1e9c36f88069bd47a521ddb58", "text": "} async acceptInput() { <del> assertType(this._activeSession); </del> assertType(this._widget); <ins> await this._sessionCtor; assertType(this._activeSession); </ins> this._warmupRequestCts?.dispose(true); this._warmupRequestCts = undefined; this._activeSession.addInput(new SessionPrompt(this._widget.inlineChatWidget.value));", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-2aaf5d0a2622034386021cbed918b886050efd435ba57be5660309db839479dd", "text": "//TODO: update progress in a newly inserted cell below the widget instead of the fake editor <del> const requestCts = new CancellationTokenSource(); </del> <ins> this._activeRequestCts?.cancel(); this._activeRequestCts = new CancellationTokenSource(); </ins> const progressEdits: TextEdit[][] = []; const progressiveEditsQueue = new Queue(); const progressiveEditsClock = StopWatch.create(); const progressiveEditsAvgDuration = new MovingAverage(); <del> const progressiveEditsCts = new CancellationTokenSource(requestCts.token); </del> <ins> const progressiveEditsCts = new CancellationTokenSource(this._activeRequestCts.token); </ins> let progressiveChatResponse: IInlineChatMessageAppender | undefined; const progress = new AsyncProgress<IInlineChatProgressItem>(async data => { // console.log('received chunk', data, request); <del> if (requestCts.token.isCancellationRequested) { </del> <ins> if (this._activeRequestCts?.token.isCancellationRequested) { </ins> return; }", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-cd7750e4669d5454f1265f5acf86217b9238891afc24c2228e5c841fe2f3a34c", "text": "} }); <del> const task = this._activeSession.provider.provideResponse(this._activeSession.session, request, progress, requestCts.token); </del> <ins> const task = this._activeSession.provider.provideResponse(this._activeSession.session, request, progress, this._activeRequestCts.token); </ins> let response: ReplyResponse | ErrorResponse | EmptyResponse; try {", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-3a7a49b887b9364ccb952aed0571e524bae8edfb8d8a2f994ad9f8e41b3c81ef", "text": "this._widget?.inlineChatWidget.updateInfo(!this._activeSession.lastExchange ? localize('thinking', \"Thinkingu2026\") : ''); this._ctxHasActiveRequest.set(true); <del> const reply = await raceCancellationError(Promise.resolve(task), requestCts.token); </del> <ins> const reply = await raceCancellationError(Promise.resolve(task), this._activeRequestCts.token); </ins> if (progressiveEditsQueue.size > 0) { // we must wait for all edits that came in via progress to complete await Event.toPromise(progressiveEditsQueue.onDrained);", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-c17fb9372a4a731489485dc13288f8882bbf8b172d6580f2c5932458e48c00c5", "text": "this._widget?.inlineChatWidget.updateInfo(''); this._widget?.inlineChatWidget.updateToolbar(true); <del> this._activeSession.addExchange(new SessionExchange(this._activeSession.lastInput, response)); </del> <ins> this._activeSession?.addExchange(new SessionExchange(this._activeSession.lastInput, response)); </ins> this._ctxLastResponseType.set(response instanceof ReplyResponse ? response.raw.type : undefined); }", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-464cc3ca4d54ac01634733d95c572a66710ca6eacbb0b840dc2de7283312b6d2", "query": "use generate cell in notebooks make a request while the request is active press stop a bunch of errors are printed\nIt seems not wise at all to maintain my own *chatcontroller. I'd love to look into how do I ensure I reuse the most of Inline Chat Controller later.\nIs the generate cell feature just with using ctrl+i from within a cell body? Not sure how I can trigger it.", "positive_passages": [{"docid": "doc-en-vscode-3cbf9721fbc2a6b43c480762b66b60d3ce544b119765d708361ed50fa8f7bb0b", "text": "this._strategy?.cancel(); } <del> if (this._activeSession) { this._inlineChatSessionService.releaseSession(this._activeSession); } this._activeSession = undefined; </del> <ins> this._activeRequestCts?.cancel(); </ins> } discard() { this._strategy?.cancel(); <ins> this._activeRequestCts?.cancel(); </ins> this._widget?.discardChange(); this.dismiss(); }", "commid": "vscode_pr_206012"}], "negative_passages": []}
{"query_id": "q-en-vscode-1979159571b638dddbfc213cb87b906f00cf409433bbfb5074a8d2a5e331c865", "query": "This only applies in a multi-root workspace. With just 1 view: ! With N views: ! I think we should use the workspace label here. to you recall why this code is there:", "positive_passages": [{"docid": "doc-en-vscode-0639877be9be2ef51604d318569e773a1d80c2e474af0a4f69e949af684304d3", "text": "const titleElement = container.querySelector('.title') as HTMLElement; const setHeader = () => { <del> const workspace = this.contextService.getWorkspace(); const title = workspace.folders.map(folder => folder.name).join(); </del> titleElement.textContent = this.name; <del> this.updateTitle(title); </del> <ins> this.updateTitle(this.name); </ins> this.ariaHeaderLabel = nls.localize('explorerSection', \"Explorer Section: {0}\", this.name); titleElement.setAttribute('aria-label', this.ariaHeaderLabel); };", "commid": "vscode_pr_206370"}], "negative_passages": []}
{"query_id": "q-en-vscode-afcded0d1c0e0fddd41fb47ed2a34f04fdcf1ae731e1c3cb87ff707fcb6184bc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Windows 10 / macOS Sonoma Steps to Reproduce: at least three windows the command least one of the windows will show a strange close icon, instead of the regular one, like the image below ! I reproduced the same error on Windows, and it also presented a strange icon, but it was a different one. A small vertical rectangle, like that missing unicode chars. I tested the on Insiders release, at least on MacOS, and didn't notice the error. I didn't have the opportunity to test in Insiders on Windows yet. I'll update the issue later with more details. Thank you\nare you using a product icon extension?\nNevermind, a regression from , fyi\nHi , Glad to know you could find the fix. Let me know if you need me to verify it when released. Thank you\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-510df6601433346cfbfdfbd9891411e8ef86b0cecf3dd312e5a1ab92d341fa3b", "text": ".monaco-workbench .interactive-input-part .monaco-action-bar .action-label.codicon-loading.codicon-modifier-spin:not(.disabled)::before, .monaco-workbench .inline-chat .monaco-action-bar .action-label.codicon-loading.codicon-modifier-spin:not(.disabled)::before { content: \"ec1c\"; <ins> font-family: 'codicon'; </ins> } /*", "commid": "vscode_pr_206404"}], "negative_passages": []}
{"query_id": "q-en-vscode-afcded0d1c0e0fddd41fb47ed2a34f04fdcf1ae731e1c3cb87ff707fcb6184bc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Windows 10 / macOS Sonoma Steps to Reproduce: at least three windows the command least one of the windows will show a strange close icon, instead of the regular one, like the image below ! I reproduced the same error on Windows, and it also presented a strange icon, but it was a different one. A small vertical rectangle, like that missing unicode chars. I tested the on Insiders release, at least on MacOS, and didn't notice the error. I didn't have the opportunity to test in Insiders on Windows yet. I'll update the issue later with more details. Thank you\nare you using a product icon extension?\nNevermind, a regression from , fyi\nHi , Glad to know you could find the fix. Let me know if you need me to verify it when released. Thank you\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-7cae5c309f6b5288aeb8985da440057c54e61fcb3fa38d8634f3db4075c92965", "text": ".monaco-workbench.reduce-motion .interactive-input-part .monaco-action-bar .action-label.codicon-loading.codicon-modifier-spin:not(.disabled)::before, .monaco-workbench.reduce-motion .inline-chat .monaco-action-bar .action-label.codicon-loading.codicon-modifier-spin:not(.disabled)::before { content: \"ead7\"; <ins> font-family: 'codicon'; </ins> }", "commid": "vscode_pr_206404"}], "negative_passages": []}
{"query_id": "q-en-vscode-afcded0d1c0e0fddd41fb47ed2a34f04fdcf1ae731e1c3cb87ff707fcb6184bc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Windows 10 / macOS Sonoma Steps to Reproduce: at least three windows the command least one of the windows will show a strange close icon, instead of the regular one, like the image below ! I reproduced the same error on Windows, and it also presented a strange icon, but it was a different one. A small vertical rectangle, like that missing unicode chars. I tested the on Insiders release, at least on MacOS, and didn't notice the error. I didn't have the opportunity to test in Insiders on Windows yet. I'll update the issue later with more details. Thank you\nare you using a product icon extension?\nNevermind, a regression from , fyi\nHi , Glad to know you could find the fix. Let me know if you need me to verify it when released. Thank you\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-4ecdcc97cc04840d906c98049022c54669803aee31fbb3e822e5b6e78dfa1360", "text": ".quick-input-list .quick-input-list-entry.has-actions:hover .quick-input-list-entry-action-bar .action-label.dirty-anything::before { content: \"ea76\"; /* Close icon flips between black dot and \"X\" for dirty open editors */ <ins> font-family: 'codicon'; </ins> }", "commid": "vscode_pr_206404"}], "negative_passages": []}
{"query_id": "q-en-vscode-afcded0d1c0e0fddd41fb47ed2a34f04fdcf1ae731e1c3cb87ff707fcb6184bc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Windows 10 / macOS Sonoma Steps to Reproduce: at least three windows the command least one of the windows will show a strange close icon, instead of the regular one, like the image below ! I reproduced the same error on Windows, and it also presented a strange icon, but it was a different one. A small vertical rectangle, like that missing unicode chars. I tested the on Insiders release, at least on MacOS, and didn't notice the error. I didn't have the opportunity to test in Insiders on Windows yet. I'll update the issue later with more details. Thank you\nare you using a product icon extension?\nNevermind, a regression from , fyi\nHi , Glad to know you could find the fix. Let me know if you need me to verify it when released. Thank you\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-4ba30a6d4209a4462fd74f57a3cbb2d0ae65c21f989e4acf335d29baa1601887", "text": "}; private readonly closeDirtyWindowAction: IQuickInputButton = { <del> iconClass: 'dirty-window ' + Codicon.closeDirty, </del> <ins> iconClass: 'dirty-window ' + ThemeIcon.asClassName(Codicon.closeDirty), </ins> tooltip: localize('close', \"Close Window\"), alwaysVisible: true };", "commid": "vscode_pr_206404"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-d2389d42f6ebedd88c25f3c061ce29fa814e6388f14a3d0d1bf6c0185037ccb2", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { DisposableStore } from 'vs/base/common/lifecycle'; import { ExtHostContext, IExtHostEditorTabsShape, MainContext, IEditorTabDto, IEditorTabGroupDto, MainThreadEditorTabsShape, AnyInputDto, TabInputKind, TabModelOperationKind, TextDiffInputDto } from 'vs/workbench/api/common/extHost.protocol'; import { extHostNamedCustomer, IExtHostContext } from 'vs/workbench/services/extensions/common/extHostCustomers'; </del> <ins> import { Event } from 'vs/base/common/event'; import { DisposableMap, DisposableStore } from 'vs/base/common/lifecycle'; import { isEqual } from 'vs/base/common/resources'; import { URI } from 'vs/base/common/uri'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { ILogService } from 'vs/platform/log/common/log'; import { AnyInputDto, ExtHostContext, IEditorTabDto, IEditorTabGroupDto, IExtHostEditorTabsShape, MainContext, MainThreadEditorTabsShape, TabInputKind, TabModelOperationKind, TextDiffInputDto } from 'vs/workbench/api/common/extHost.protocol'; </ins> import { EditorResourceAccessor, GroupModelChangeKind, SideBySideEditor } from 'vs/workbench/common/editor'; import { DiffEditorInput } from 'vs/workbench/common/editor/diffEditorInput'; <ins> import { isGroupEditorMoveEvent } from 'vs/workbench/common/editor/editorGroupModel'; </ins> import { EditorInput } from 'vs/workbench/common/editor/editorInput'; <del> import { columnToEditorGroup, EditorGroupColumn, editorGroupToColumn } from 'vs/workbench/services/editor/common/editorGroupColumn'; import { GroupDirection, IEditorGroup, IEditorGroupsService, preferredSideBySideGroupDirection } from 'vs/workbench/services/editor/common/editorGroupsService'; import { IEditorsChangeEvent, IEditorService, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService'; </del> <ins> import { SideBySideEditorInput } from 'vs/workbench/common/editor/sideBySideEditorInput'; </ins> import { AbstractTextResourceEditorInput } from 'vs/workbench/common/editor/textResourceEditorInput'; <del> import { NotebookEditorInput } from 'vs/workbench/contrib/notebook/common/notebookEditorInput'; </del> <ins> import { ChatEditorInput } from 'vs/workbench/contrib/chat/browser/chatEditorInput'; </ins> import { CustomEditorInput } from 'vs/workbench/contrib/customEditor/browser/customEditorInput'; <del> import { URI } from 'vs/base/common/uri'; import { WebviewInput } from 'vs/workbench/contrib/webviewPanel/browser/webviewEditorInput'; import { TerminalEditorInput } from 'vs/workbench/contrib/terminal/browser/terminalEditorInput'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { SideBySideEditorInput } from 'vs/workbench/common/editor/sideBySideEditorInput'; import { isEqual } from 'vs/base/common/resources'; import { isGroupEditorMoveEvent } from 'vs/workbench/common/editor/editorGroupModel'; </del> import { InteractiveEditorInput } from 'vs/workbench/contrib/interactive/browser/interactiveEditorInput'; import { MergeEditorInput } from 'vs/workbench/contrib/mergeEditor/browser/mergeEditorInput'; <del> import { ILogService } from 'vs/platform/log/common/log'; import { ChatEditorInput } from 'vs/workbench/contrib/chat/browser/chatEditorInput'; </del> import { MultiDiffEditorInput } from 'vs/workbench/contrib/multiDiffEditor/browser/multiDiffEditorInput'; <ins> import { NotebookEditorInput } from 'vs/workbench/contrib/notebook/common/notebookEditorInput'; import { TerminalEditorInput } from 'vs/workbench/contrib/terminal/browser/terminalEditorInput'; import { WebviewInput } from 'vs/workbench/contrib/webviewPanel/browser/webviewEditorInput'; import { columnToEditorGroup, EditorGroupColumn, editorGroupToColumn } from 'vs/workbench/services/editor/common/editorGroupColumn'; import { GroupDirection, IEditorGroup, IEditorGroupsService, preferredSideBySideGroupDirection } from 'vs/workbench/services/editor/common/editorGroupsService'; import { IEditorsChangeEvent, IEditorService, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService'; import { extHostNamedCustomer, IExtHostContext } from 'vs/workbench/services/extensions/common/extHostCustomers'; </ins> interface TabInfo { tab: IEditorTabDto;", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-2d1a67907e976bfa84cadb9ce5baaf25430ce7709364b03cdfe11780101e95f9", "text": "private readonly _groupLookup: Map<number, IEditorTabGroupDto> = new Map(); // Lookup table for finding tab by id private readonly _tabInfoLookup: Map<string, TabInfo> = new Map(); <ins> // Tracks the currently open MultiDiffEditorInputs to listen to resource changes private readonly _multiDiffEditorInputListeners: DisposableMap<MultiDiffEditorInput> = new DisposableMap(); </ins> constructor( extHostContext: IExtHostContext,", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-af033cf2bfec9addc29296cecfdbb0ce53f2be258bfd927b42a64d8a8a24d925", "text": "} })); <ins> this._dispoables.add(this._multiDiffEditorInputListeners); </ins> // Structural group changes (add, remove, move, etc) are difficult to patch. // Since they happen infrequently we just rebuild the entire model this._dispoables.add(this._editorGroupsService.onDidAddGroup(() => this._createTabsModel()));", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-ceef130bbad110df0b98b06c4e3f90d152fb4eb66f5f9332f1652157ff339193", "text": "if (editor instanceof MultiDiffEditorInput) { const diffEditors: TextDiffInputDto[] = []; <del> for (const resource of (editor?.initialResources ?? [])) { </del> <ins> for (const resource of (editor?.resources.get() ?? [])) { </ins> if (resource.original && resource.modified) { diffEditors.push({ kind: TabInputKind.TextDiffInput,", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-814d984e5bbbb02d307042b830a4faf6830bc682eb8b9fd9ee17ff149fd51db1", "text": "const tabObject = this._buildTabObject(group, editorInput, editorIndex); tabs.splice(editorIndex, 0, tabObject); // Update lookup <del> this._tabInfoLookup.set(this._generateTabId(editorInput, groupId), { group, editorInput, tab: tabObject }); </del> <ins> const tabId = this._generateTabId(editorInput, groupId); this._tabInfoLookup.set(tabId, { group, editorInput, tab: tabObject }); if (editorInput instanceof MultiDiffEditorInput) { this._multiDiffEditorInputListeners.set(editorInput, Event.fromObservableLight(editorInput.resources)(() => { const tabInfo = this._tabInfoLookup.get(tabId); if (!tabInfo) { return; } tabInfo.tab = this._buildTabObject(group, editorInput, editorIndex); this._proxy.$acceptTabOperation({ groupId, index: editorIndex, tabDto: tabInfo.tab, kind: TabModelOperationKind.TAB_UPDATE }); })); } </ins> this._proxy.$acceptTabOperation({ groupId,", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-93fe33ef4f1fb457d5e8a882f075c0834215e8f828eb8b4d65658184118e9357", "text": "// Update lookup this._tabInfoLookup.delete(removedTab[0]?.id ?? ''); <ins> if (removedTab[0]?.input instanceof MultiDiffEditorInput) { this._multiDiffEditorInputListeners.deleteAndDispose(removedTab[0]?.input); } </ins> this._proxy.$acceptTabOperation({ groupId, index: editorIndex,", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-2c07a293d2da65ee202d3c7855ca53412caa20c5001b3d230072c16e0ecd43b7", "text": "this._register(autorun((reader) => { /** @description Updates name */ <del> const resources = this._resources.read(reader); </del> <ins> const resources = this.resources.read(reader); </ins> const label = this.label ?? localize('name', \"Multi Diff Editor\"); if (resources) { this._name = label + localize({", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-fc455764b5224924451d69c4e1cf5baacddd3f9113c5b0e9a9f458fd4e089aff", "query": "To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see ) May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be\nWhen you listen for tab changes the input of the tab is currently .\nNot sure if this is or\nRelated:\nThanks!\nReopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff This will probably complicate your use case. pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.\nCan you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes", "positive_passages": [{"docid": "doc-en-vscode-8c493a9394a27e84d1c3da01cd7cd15ec2da87ee6ae848b0419de233a98c129c", "text": "return false; } <del> private readonly _resources = derived(this, reader => this._resolvedSource.cachedPromiseResult.read(reader)?.data?.resources.read(reader)); private readonly _isDirtyObservables = mapObservableArrayCached(this, this._resources.map(r => r ?? []), res => { </del> <ins> public readonly resources = derived(this, reader => this._resolvedSource.cachedPromiseResult.read(reader)?.data?.resources.read(reader)); private readonly _isDirtyObservables = mapObservableArrayCached(this, this.resources.map(r => r ?? []), res => { </ins> const isModifiedDirty = res.modified ? isUriDirty(this._textFileService, res.modified) : constObservable(false); const isOriginalDirty = res.original ? isUriDirty(this._textFileService, res.original) : constObservable(false); return derived(reader => /** @description modifiedDirty||originalDirty */ isModifiedDirty.read(reader) || isOriginalDirty.read(reader));", "commid": "vscode_pr_210094"}], "negative_passages": []}
{"query_id": "q-en-vscode-843390bd9a8f1b9d6d9e4d70fcd873f166774f12f114faa191915edd19ab406e", "query": "This error appears in the insiders dev tools all the time (FYI Cannot read properties of undefined (reading 'includes'): TypeError: Cannot read properties of undefined (reading 'includes') at at at at at at at at at at at", "positive_passages": [{"docid": "doc-en-vscode-d443a949ab8674c609fb128c3329f8fe72614b027147b98c8187cf4bdb33bde0", "text": "}, 500, false, true)(async (markerEvent) => { markerChanged?.dispose(); markerChanged = undefined; <del> if (!markerEvent.includes(modelEvent.uri) || (this.markerService.read({ resource: modelEvent.uri }).length !== 0)) { </del> <ins> if (!markerEvent || !markerEvent.includes(modelEvent.uri) || (this.markerService.read({ resource: modelEvent.uri }).length !== 0)) { </ins> return; } const oldLines = Array.from(this.lines);", "commid": "vscode_pr_206461"}], "negative_passages": []}
{"query_id": "q-en-vscode-8553d62cc4c61e9b22dc895befa9d6b47a4fad4cf3716fc97ce0ebb65c532543", "query": "Type: <bBug</bIn the below image, clicking the link Learn More brings you to However, that section (id) does not exist on The link is most likely supposed to go to ! VS Code version: Code 1.87.2 (, 2024-03-08T15:20:17.278Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.4.0-173-generic <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ yang0.1.3 jupyter-keymap1.1.2 remote-containers0.348.0 remote-ssh0.109.0 remote-ssh-edit0.86.0 remote-wsl0.86.0 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.1 vscode-openapi4.25.1 vscode-fish1.0.38 ruff2024.16.0 vale-vscode0.18.5 vscode-markdownlint0.54.0 gitlens14.9.0 prettier-vscode10.1.0 code-runner0.12.1 go0.41.1 restructuredtext189.3.0 direnv0.17.0 vscode-azureresourcegroups0.8.4 vscode-cosmosdb0.20.1 vscode-docker1.29.0 vscode-kubernetes-tools1.3.15 python2024.2.1 azure-account0.11.6 vscode-yaml1.14.0 code-spell-checker3.0.1 even-better-toml0.19.2 shellcheck0.37.0 simple-rst1.5.4 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-eaae8340ee03ed3e6ba74bc509d6be376702b6d256e50fd5aea3c4329ba1ac2d", "text": "if (this.extensionManagementServerService.localExtensionManagementServer === this.extension.server) { if (this.extensionManifestPropertiesService.prefersExecuteOnWorkspace(this.extension.local.manifest)) { if (this.extensionManagementServerService.remoteExtensionManagementServer) { <del> message = new MarkdownString(`${localize('Install in remote server to enable', \"This extension is disabled in this workspace because it is defined to run in the Remote Extension Host. Please install the extension in '{0}' to enable.\", this.extensionManagementServerService.remoteExtensionManagementServer.label)} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`); </del> <ins> message = new MarkdownString(`${localize('Install in remote server to enable', \"This extension is disabled in this workspace because it is defined to run in the Remote Extension Host. Please install the extension in '{0}' to enable.\", this.extensionManagementServerService.remoteExtensionManagementServer.label)} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`); </ins> } } }", "commid": "vscode_pr_209984"}], "negative_passages": []}
{"query_id": "q-en-vscode-8553d62cc4c61e9b22dc895befa9d6b47a4fad4cf3716fc97ce0ebb65c532543", "query": "Type: <bBug</bIn the below image, clicking the link Learn More brings you to However, that section (id) does not exist on The link is most likely supposed to go to ! VS Code version: Code 1.87.2 (, 2024-03-08T15:20:17.278Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.4.0-173-generic <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ yang0.1.3 jupyter-keymap1.1.2 remote-containers0.348.0 remote-ssh0.109.0 remote-ssh-edit0.86.0 remote-wsl0.86.0 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.1 vscode-openapi4.25.1 vscode-fish1.0.38 ruff2024.16.0 vale-vscode0.18.5 vscode-markdownlint0.54.0 gitlens14.9.0 prettier-vscode10.1.0 code-runner0.12.1 go0.41.1 restructuredtext189.3.0 direnv0.17.0 vscode-azureresourcegroups0.8.4 vscode-cosmosdb0.20.1 vscode-docker1.29.0 vscode-kubernetes-tools1.3.15 python2024.2.1 azure-account0.11.6 vscode-yaml1.14.0 code-spell-checker3.0.1 even-better-toml0.19.2 shellcheck0.37.0 simple-rst1.5.4 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-dc8597f2c272d46b078e2a00f6a67ffb9af1ae65b2121ac73e259be368bbc7c6", "text": "else if (this.extensionManagementServerService.remoteExtensionManagementServer === this.extension.server) { if (this.extensionManifestPropertiesService.prefersExecuteOnUI(this.extension.local.manifest)) { if (this.extensionManagementServerService.localExtensionManagementServer) { <del> message = new MarkdownString(`${localize('Install in local server to enable', \"This extension is disabled in this workspace because it is defined to run in the Local Extension Host. Please install the extension locally to enable.\", this.extensionManagementServerService.remoteExtensionManagementServer.label)} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`); </del> <ins> message = new MarkdownString(`${localize('Install in local server to enable', \"This extension is disabled in this workspace because it is defined to run in the Local Extension Host. Please install the extension locally to enable.\", this.extensionManagementServerService.remoteExtensionManagementServer.label)} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`); </ins> } else if (isWeb) { <del> message = new MarkdownString(`${localize('Defined to run in desktop', \"This extension is disabled because it is defined to run only in {0} for the Desktop.\", this.productService.nameLong)} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`); </del> <ins> message = new MarkdownString(`${localize('Defined to run in desktop', \"This extension is disabled because it is defined to run only in {0} for the Desktop.\", this.productService.nameLong)} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`); </ins> } } } // Extension on Web Server else if (this.extensionManagementServerService.webExtensionManagementServer === this.extension.server) { <del> message = new MarkdownString(`${localize('Cannot be enabled', \"This extension is disabled because it is not supported in {0} for the Web.\", this.productService.nameLong)} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`); </del> <ins> message = new MarkdownString(`${localize('Cannot be enabled', \"This extension is disabled because it is not supported in {0} for the Web.\", this.productService.nameLong)} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`); </ins> } if (message) { this.updateStatus({ icon: warningIcon, message }, true);", "commid": "vscode_pr_209984"}], "negative_passages": []}
{"query_id": "q-en-vscode-8553d62cc4c61e9b22dc895befa9d6b47a4fad4cf3716fc97ce0ebb65c532543", "query": "Type: <bBug</bIn the below image, clicking the link Learn More brings you to However, that section (id) does not exist on The link is most likely supposed to go to ! VS Code version: Code 1.87.2 (, 2024-03-08T15:20:17.278Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.4.0-173-generic <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ yang0.1.3 jupyter-keymap1.1.2 remote-containers0.348.0 remote-ssh0.109.0 remote-ssh-edit0.86.0 remote-wsl0.86.0 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.1 vscode-openapi4.25.1 vscode-fish1.0.38 ruff2024.16.0 vale-vscode0.18.5 vscode-markdownlint0.54.0 gitlens14.9.0 prettier-vscode10.1.0 code-runner0.12.1 go0.41.1 restructuredtext189.3.0 direnv0.17.0 vscode-azureresourcegroups0.8.4 vscode-cosmosdb0.20.1 vscode-docker1.29.0 vscode-kubernetes-tools1.3.15 python2024.2.1 azure-account0.11.6 vscode-yaml1.14.0 code-spell-checker3.0.1 even-better-toml0.19.2 shellcheck0.37.0 simple-rst1.5.4 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --", "positive_passages": [{"docid": "doc-en-vscode-ec4ae4a0edf1445caa3698317b69bbc52ca4a092ea2dbaa1e47a00875c416a58", "text": "const runningExtensionServer = runningExtension ? this.extensionManagementServerService.getExtensionManagementServer(toExtension(runningExtension)) : null; if (this.extension.server === this.extensionManagementServerService.localExtensionManagementServer && runningExtensionServer === this.extensionManagementServerService.remoteExtensionManagementServer) { if (this.extensionManifestPropertiesService.prefersExecuteOnWorkspace(this.extension.local.manifest)) { <del> this.updateStatus({ icon: infoIcon, message: new MarkdownString(`${localize('enabled remotely', \"This extension is enabled in the Remote Extension Host because it prefers to run there.\")} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`) }, true); </del> <ins> this.updateStatus({ icon: infoIcon, message: new MarkdownString(`${localize('enabled remotely', \"This extension is enabled in the Remote Extension Host because it prefers to run there.\")} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`) }, true); </ins> } return; } if (this.extension.server === this.extensionManagementServerService.remoteExtensionManagementServer && runningExtensionServer === this.extensionManagementServerService.localExtensionManagementServer) { if (this.extensionManifestPropertiesService.prefersExecuteOnUI(this.extension.local.manifest)) { <del> this.updateStatus({ icon: infoIcon, message: new MarkdownString(`${localize('enabled locally', \"This extension is enabled in the Local Extension Host because it prefers to run there.\")} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`) }, true); </del> <ins> this.updateStatus({ icon: infoIcon, message: new MarkdownString(`${localize('enabled locally', \"This extension is enabled in the Local Extension Host because it prefers to run there.\")} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`) }, true); </ins> } return; } if (this.extension.server === this.extensionManagementServerService.remoteExtensionManagementServer && runningExtensionServer === this.extensionManagementServerService.webExtensionManagementServer) { if (this.extensionManifestPropertiesService.canExecuteOnWeb(this.extension.local.manifest)) { <del> this.updateStatus({ icon: infoIcon, message: new MarkdownString(`${localize('enabled in web worker', \"This extension is enabled in the Web Worker Extension Host because it prefers to run there.\")} [${localize('learn more', \"Learn More\")}](https://aka.ms/vscode-remote/developing-extensions/architecture)`) }, true); </del> <ins> this.updateStatus({ icon: infoIcon, message: new MarkdownString(`${localize('enabled in web worker', \"This extension is enabled in the Web Worker Extension Host because it prefers to run there.\")} [${localize('learn more', \"Learn More\")}](https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds)`) }, true); </ins> } return; }", "commid": "vscode_pr_209984"}], "negative_passages": []}
{"query_id": "q-en-vscode-40af96f7134978390c597c339cac56189c9da928eea9a3b961093fd717e497b4", "query": "Type: <bBug</bCC command works only from inside the Accessible View; it does not work when invokved from the code block area of the Copilot Chat View. VS Code version: Code - Insiders 1.88.0-insider (, 2024-03-25T05:49:32.344Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (119)</summaryExtensionVersion ------ vscode-openapi4.25.1 zotenote1.0.1 android-dev-ext1.4.0 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.122 mermaid-markdown-syntax-highlighting1.6.0 doxdocgen1.4.0 vscode-markdownlint0.53.0 vscode-eslint2.4.4 vscode-quick-select0.2.9 vscode-deno3.35.1 gitlens14.6.1 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-firefox-debug2.9.10 shell-format7.2.5 vscode-google-translate1.4.13 codespaces1.16.17 copilot1.175.784 copilot-chat0.14. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.85. cloudcode2.6.0 overleaf-workshop0.11.0 cslpreview0.2.2 easy-snippet0.7.5 path-autocomplete1.25.0 latex-workshop9.19.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 commitlint2.5.1 language-julia1.75.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 git-graph1.30.0 azure-dev0.8.1 vscode-azureappservice0.25.2 vscode-azurecontainerapps0.6.1 vscode-azurefunctions1.14.0 vscode-azureresourcegroups0.8.3 vscode-azurestaticwebapps0.12.2 vscode-azurestorage0.15.3 vscode-azurevirtualmachines0.6.5 vscode-cosmosdb0.21.0 vscode-docker1.29.0 vscode-edge-devtools2.1.5 black-formatter2024.1. debugpy2024.3. flake82023.10.0 isort2023.13. python2024.3. vscode-pylance2023.12.103 jupyter2024.1. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.352.0 remote-ssh0.110. remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.25.0 azure-account0.11.6 azure-repos0.38.0 cmake-tools1.17.17 cpptools1.19.9 cpptools-extension-pack1.3.0 js-debug-nightly2024.3.2217 powershell2024.3.1 remote-explorer0.5. remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-node-azure-pack1.2.0 vscode-selfhost-test-provider0.3.25 vscode-serial-monitor0.11.0 vscode-speech0.7. vscode-speech-language-pack-ko-kr0.1.0 vsliveshare1.0.5918 windows-ai-studio0.2.4 autodocstring0.6.1 pandocciter0.10.4 shiny-python0.1.6 shinyuieditor0.5.0 quarto1.111.0 r-debugger0.5.4 java1.28.1 vscode-xml0.26.1 vscode-yaml1.14.0 r2.8.2 multi-command1.6.0 vscode-deepl1.1.1 abc-music0.4.0 lua3.7.4 latex-utilities0.4.13 cmake0.0.17 vscode-terminal-here0.2.4 windows-terminal0.7.0 errorlens3.16.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-conventional-commits1.25.0 vscode-arduino0.6. vscode-java-debug0.56.2 vscode-java-dependency0.23.5 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.44.0 zotero-cite0.8.2 markdown-all-in-one3.6.2 grammarly0.25.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nI see this when I try that !\nLooks like we should be overriding that or going with a different keybinding.\nNote that this also doesn't work when in the accessible view. I believe has somehow worked around that by tweaking his keybindings / clauses.\nYou are correct. I had to tweak around my keybindings to make it work.", "positive_passages": [{"docid": "doc-en-vscode-a0baef3ca65fb115124aad870e42d25ffbf437fda7e823ef3500132fca6509f7", "text": "when: ContextKeyExpr.or(ContextKeyExpr.and(CONTEXT_IN_CHAT_SESSION, CONTEXT_IN_CHAT_INPUT.negate()), accessibleViewInCodeBlock), primary: KeyMod.CtrlCmd | KeyCode.Enter, mac: { primary: KeyMod.WinCtrl | KeyCode.Enter }, <del> weight: KeybindingWeight.WorkbenchContrib </del> <ins> weight: KeybindingWeight.ExternalExtension + 1 </ins> }, }); }", "commid": "vscode_pr_208824"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-a9d59131cf46400b80583e2986bde3d6e86dd5624b9cbaec6e5b264423c9ef86", "text": "// Only allow history navigation when the input is empty. // (If this model change happened as a result of a history navigation, this is canceled out by a call in this.navigateHistory) const model = this._inputEditor.getModel(); <del> const inputHasText = !!model && model.getValueLength() > 0; </del> <ins> const inputHasText = !!model && model.getValue().trim().length > 0; </ins> this.inputEditorHasText.set(inputHasText); // If the user is typing on a history entry, then reset the onHistoryEntry flag so that history navigation can be disabled", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-213edcbfd60e604800c5478c94b798f0566ca70d7bf6fd04e76f572836be4a13", "text": "import { editorBackground, editorForeground, inputBackground } from 'vs/platform/theme/common/colorRegistry'; import { ChatModel } from 'vs/workbench/contrib/chat/common/chatModel'; import { Range } from 'vs/editor/common/core/range'; <ins> import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> export class InlineChatContentWidget implements IContentWidget {", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-6c9e2c448f21a061e3f65c4d8dcdeaeb418727ede9bbaa3f31fc6d01986b42b1", "text": "constructor( private readonly _editor: ICodeEditor, @IInstantiationService instaService: IInstantiationService, <ins> @IContextKeyService contextKeyService: IContextKeyService, </ins> ) { this._defaultChatModel = this._store.add(instaService.createInstance(ChatModel, `inlineChatDefaultModel/editorContentWidgetPlaceholder`, undefined)); <del> this._widget = instaService.createInstance( </del> <ins> const scopedInstaService = instaService.createChild( new ServiceCollection([ IContextKeyService, this._store.add(contextKeyService.createScoped(this._domNode)) ]) ); this._widget = scopedInstaService.createInstance( </ins> ChatWidget, ChatAgentLocation.Editor, { resource: true },", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-553cdb2693b3104f418e8a9dfe566da9be48025ec517c31f7996c782a5598558", "text": "} return false; }); <del> if (refer && slashCommandLike) { </del> <ins> if (refer && slashCommandLike && !this._session.lastExchange) { </ins> this._log('[IE] seeing refer command, continuing outside editor', this._session.provider.extensionId); // cancel this request", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-d219e66ad4415dfae6ef19bb42d5fcc3cdd16c00b7252535f1669b0aeb4ab1a7", "text": "// if agent has a refer command, massage the input to include the agent name await this._instaService.invokeFunction(sendRequest, massagedInput); <del> if (!this._session.lastExchange) { // DONE when there wasn't any exchange yet. We used the inline chat only as trampoline return State.ACCEPT; } return State.WAIT_FOR_INPUT; </del> <ins> return State.ACCEPT; </ins> } this._session.addInput(new SessionPrompt(input, this._nextAttempt, this._nextWithIntentDetection));", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-701f70f962a8d01810aea68ab3d841ed74973638abfe8269f43c2ccc67c9522a", "text": "import { IChatService } from 'vs/workbench/contrib/chat/common/chatService'; import { setupCustomHover } from 'vs/base/browser/ui/hover/updatableHoverWidget'; import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; <ins> import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; </ins> export interface InlineChatWidgetViewState {", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-f9d0b3f95a946121eb7566d0df2fd4fa9c407367d3a8a9c42fed9b627a389c1c", "text": "this._store.add(this._progressBar); let allowRequests = false; <del> this._chatWidget = _instantiationService.createInstance( </del> <ins> const scopedInstaService = _instantiationService.createChild( new ServiceCollection([ IContextKeyService, this._store.add(_contextKeyService.createScoped(this._elements.chatWidget)) ]) ); this._chatWidget = scopedInstaService.createInstance( </ins> ChatWidget, location, { resource: true },", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-2a7d82f0398dcb7f813230cd40ea603af7c8931f18997537eec8310d3c9cd366", "text": "get contentHeight(): number { const data = { followUpsHeight: getTotalHeight(this._elements.followUps), <del> chatWidgetHeight: this._chatWidget.contentHeight, </del> <ins> chatWidgetContentHeight: this._chatWidget.contentHeight, </ins> progressHeight: getTotalHeight(this._elements.progress), statusHeight: getTotalHeight(this._elements.status), extraHeight: this._getExtraHeight() }; <del> const result = data.progressHeight + data.chatWidgetHeight + data.followUpsHeight + data.statusHeight + data.extraHeight; // console.log(`InlineChat#contentHeight ${result}`, data); </del> <ins> const result = data.progressHeight + data.chatWidgetContentHeight + data.followUpsHeight + data.statusHeight + data.extraHeight; </ins> return result; } <ins> get minHeight(): number { // The chat widget is variable height and supports scrolling. It // should be at least 100px high and at most the content height. let value = this.contentHeight; value -= this._chatWidget.contentHeight; value += Math.min(100, this._chatWidget.contentHeight); return value; } </ins> protected _getExtraHeight(): number { return 12 /* padding */ + 2 /*border*/ + 12 /*shadow*/; }", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-5ab02c50f216a1448bfc72642e331b5a7b7f3af8a352bb4534467ffe32d78354", "text": "const chatContentHeight = this.widget.contentHeight; const editorHeight = this.editor.getLayoutInfo().height; <del> const contentHeight = Math.min(chatContentHeight, editorHeight * 0.42); </del> <ins> const contentHeight = Math.min(chatContentHeight, Math.max(this.widget.minHeight, editorHeight * 0.42)); </ins> const heightInLines = contentHeight / this.editor.getOption(EditorOption.lineHeight); <del> // console.log('ZONE#_computeHeightInLines', { chatContentHeight, editorHeight, contentHeight, heightInLines }); </del> return heightInLines; }", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-ca2e1986b82b6a9002b4ff66253e1f6e10b6828f40a13a300bf503a592e5ea1e", "query": "Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)\nbecause of\nTo verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget", "positive_passages": [{"docid": "doc-en-vscode-e0d6ec75a27def70ffd77f4bee33576177b4f81b95dd55704d1c558936d157d1", "text": "z-index: 3; } <ins> .monaco-workbench .zone-widget.inline-chat-widget .interactive-session { max-width: unset; } </ins> .monaco-workbench .zone-widget-container.inside-selection { background-color: var(--vscode-inlineChat-regionHighlight); }", "commid": "vscode_pr_208769"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2c2c5a84340dab02d8b6b2137e1005eb7e8e9d9d94df50a190f294f687f5f4e", "query": "Testing ! !\ndoesn't reproduce in the panel chat\nI somehow suffer from this change which explicitly targets some monaco tokens...\nThis isn't nice but there's actually no other way to override the foreground color of an editor- because typically you have syntax highlighting. We do this for all the other \"input box\"-style editors. I think I opened a feature request when I did this. We should align this rule with your rule for coloring the decoration so that it can override it properly.\nlabeling so it gets verified\nThanks\nin the latest insider's, still seeing this ! !\nThere is two separate issues with different steps. There is a difference between rendering of slash command and normal prompt text. the only useful/visible information in the original issue description is slash commands (please use words and not images to describe issues!). For verification you have not used slash commands but normal prompt text which is a different case. Please file a separate issue, use words/steps and don't rely on screen captures with just white on white text\nSteps to reproduce/verify use HC light and dark theme open inline chat and type a slash command, e.d make sure the command is readable when selecting its text", "positive_passages": [{"docid": "doc-en-vscode-fc3ebe59b618fd0e6674a8b817b99b12ed16bf541983273a4b803645532b3c27", "text": "background-color: var(--vscode-chat-list-background); } <ins> .interactive-item-container.interactive-request .header .monaco-toolbar { /* Take the partially-transparent background color override for request rows */ background-color: inherit; } </ins> .interactive-item-container .header .monaco-toolbar .checked.action-label, .interactive-item-container .header .monaco-toolbar .checked.action-label:hover { color: var(--vscode-inputOption-activeForeground) !important;", "commid": "vscode_pr_208846"}], "negative_passages": []}
{"query_id": "q-en-vscode-a2c2c5a84340dab02d8b6b2137e1005eb7e8e9d9d94df50a190f294f687f5f4e", "query": "Testing ! !\ndoesn't reproduce in the panel chat\nI somehow suffer from this change which explicitly targets some monaco tokens...\nThis isn't nice but there's actually no other way to override the foreground color of an editor- because typically you have syntax highlighting. We do this for all the other \"input box\"-style editors. I think I opened a feature request when I did this. We should align this rule with your rule for coloring the decoration so that it can override it properly.\nlabeling so it gets verified\nThanks\nin the latest insider's, still seeing this ! !\nThere is two separate issues with different steps. There is a difference between rendering of slash command and normal prompt text. the only useful/visible information in the original issue description is slash commands (please use words and not images to describe issues!). For verification you have not used slash commands but normal prompt text which is a different case. Please file a separate issue, use words/steps and don't rely on screen captures with just white on white text\nSteps to reproduce/verify use HC light and dark theme open inline chat and type a slash command, e.d make sure the command is readable when selecting its text", "positive_passages": [{"docid": "doc-en-vscode-8bde806856c2e8e14f905a5950b37218b3d623c4f5fc29eb91f5b5216807c4d4", "text": "background-color: var(--vscode-inlineChat-regionHighlight); } <del> .monaco-workbench .inline-chat-slash-command { </del> <ins> .monaco-workbench .interactive-session .interactive-input-and-execute-toolbar .monaco-editor .inline-chat-slash-command { </ins> background-color: var(--vscode-chat-slashCommandBackground); <del> color: var(--vscode-chat-slashCommandForeground); </del> <ins> color: var(--vscode-chat-slashCommandForeground); /* Overrides the foreground color rule in chat.css */ </ins> border-radius: 4px; padding: 1px; }", "commid": "vscode_pr_208846"}], "negative_passages": []}
{"query_id": "q-en-vscode-98d5fa281e19d6f511ddce1049b52e1a6a3f7a7be75621528527bf90379b73cd", "query": "Testing In the screenshot below, \"Chat: Insert at Cursor\" should be \"Chat: Insert into New File\" !", "positive_passages": [{"docid": "doc-en-vscode-133e39753973de07a9696f5e4012a6ffc6488cb68bf454cd6d8967b54f7f647e", "text": "private _getAccessibleViewHelpDialogContent(providerHasSymbols?: boolean): string { const navigationHint = this._getNavigationHint(); const goToSymbolHint = this._getGoToSymbolHint(providerHasSymbols); <del> const toolbarHint = localize('toolbar', \"Navigate to the toolbar (Shift+Tab)).\"); </del> <ins> const toolbarHint = localize('toolbar', \"Navigate to the toolbar (Shift+Tab).\"); </ins> const chatHints = this._getChatHints(); let hint = localize('intro', \"In the accessible view, you can:n\");", "commid": "vscode_pr_208795"}], "negative_passages": []}
{"query_id": "q-en-vscode-98d5fa281e19d6f511ddce1049b52e1a6a3f7a7be75621528527bf90379b73cd", "query": "Testing In the screenshot below, \"Chat: Insert at Cursor\" should be \"Chat: Insert into New File\" !", "positive_passages": [{"docid": "doc-en-vscode-4644216db7e285ef1b862ad2a7bb71cd8055aec0d4c0764530e3329c1aaa0a19", "text": "if (insertIntoNewFileKb) { hint += localize('insertIntoNewFile', \" - Insert the code block into a new file ({0}).n\", insertIntoNewFileKb); } else { <del> hint += localize('insertIntoNewFileNoKb', \" - Insert the code block into a new file by configuring a keybinding for the Chat: Insert at Cursor command.n\"); </del> <ins> hint += localize('insertIntoNewFileNoKb', \" - Insert the code block into a new file by configuring a keybinding for the Chat: Insert into New File command.n\"); </ins> } if (runInTerminalKb) { hint += localize('runInTerminal', \" - Run the code block in the terminal ({0}).n\", runInTerminalKb);", "commid": "vscode_pr_208795"}], "negative_passages": []}
{"query_id": "q-en-vscode-98d5fa281e19d6f511ddce1049b52e1a6a3f7a7be75621528527bf90379b73cd", "query": "Testing In the screenshot below, \"Chat: Insert at Cursor\" should be \"Chat: Insert into New File\" !", "positive_passages": [{"docid": "doc-en-vscode-bde7c44d649f74df2ff08a02da0750a0cded7b55f0e472fe6028f8de02816951", "text": "let goToSymbolHint = ''; if (providerHasSymbols) { if (goToSymbolKb) { <del> goToSymbolHint = localize('goToSymbolHint', 'Go to a symbol ({0})', goToSymbolKb); </del> <ins> goToSymbolHint = localize('goToSymbolHint', 'Go to a symbol ({0}).', goToSymbolKb); </ins> } else { goToSymbolHint = localize('goToSymbolHintNoKb', 'To go to a symbol, configure a keybinding for the command Go To Symbol in Accessible View'); }", "commid": "vscode_pr_208795"}], "negative_passages": []}
{"query_id": "q-en-vscode-72ec8f969b723bd59fe2c7795d7b87a43ee9efda6a763a593be576b2ad4fd7fa", "query": "Testing to filter e.g. Python Notice the non-extension entries remain at top Maybe this was by design, but I don't understand it. If I type python, don't I want to quickly select a python related entry?", "positive_passages": [{"docid": "doc-en-vscode-aa68ca59708b094c378528c0f2835438a9bea1d193bb034b024775962e6dc9ba", "text": "// Add default items const productLabel = this.productService.nameLong; const marketPlaceLabel = localize(\"reportExtensionMarketplace\", \"Extension Marketplace\"); <del> issuePicksConst.push( { label: productLabel, ariaLabel: productLabel, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.VSCode }) }, { label: marketPlaceLabel, ariaLabel: marketPlaceLabel, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.Marketplace }) }, { type: 'separator', label: localize('extensions', \"Extensions\") } ); </del> <ins> const productFilter = matchesFuzzy(filter, productLabel, true); const marketPlaceFilter = matchesFuzzy(filter, marketPlaceLabel, true); // Add product pick if product filter matches if (productFilter) { issuePicksConst.push({ label: productLabel, ariaLabel: productLabel, highlights: { label: productFilter }, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.VSCode }) }); } // Add marketplace pick if marketplace filter matches if (marketPlaceFilter) { issuePicksConst.push({ label: marketPlaceLabel, ariaLabel: marketPlaceLabel, highlights: { label: marketPlaceFilter }, accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter', { issueSource: IssueSource.Marketplace }) }); } issuePicksConst.push({ type: 'separator', label: localize('extensions', \"Extensions\") }); </ins> // creates menu from contributed const menu = this.menuService.createMenu(MenuId.IssueReporter, this.contextKeyService);", "commid": "vscode_pr_208741"}], "negative_passages": []}
{"query_id": "q-en-vscode-42793c308828bd72ea66e76f96e92e509502fc4219828df390e69e98a8ebbb5d", "query": "Note that both of these scenarios used to work. In the terminal inine chat, run a command like which yields just a chat message response. Try to tab to it. one cannot Run a command like which yields a code block response. Try to use to go from the input box to a code block response and vice versa. one cannot\nNote that the keybindings are important because it's annoying as a SR /keyboard only user to have to tab through a bunch of things to reach the response.\nThis works for me, I do the following with success cmd+i, paste , press Enter wait for the response press tab repeatedly and reach the response\nthe tabbing part works for me in today's insider's\nI'm able to spam Ctrl+Up on Windows to focus between the inputbox and the chat response, but I'm not able to spam Ctrl+Down to do the same. I'm unable to use either shortcut to focus from the inputbox directly into a code block within the chat response. Let me know if the behaviour is as expected or if there's some other steps I can follow.\nI haven't tried windows yet. This won't directly focus the code editor, just the response.\nthis works on mac, could you pls try on windows?\nThe behavior seems wrong now and is quite disorienting: Input: ctrl+up will focus the response list ctrl+down will focus the response list Response list: ctrl+up does nothing ctrl+down does nothing Response code block: ctrl+up focuses the input ctrl+down focuses the response list I would expect: Input: ctrl+up does nothing ctrl+down will focus the response code block Response list: ctrl+up focuses the input Not sure? Response code block: ctrl+up focuses the input ctrl+down focuses the next code block, otherwise not sure\nThis issue was about cmdCtrl+up/down going between the response list and the input. This is unexpected, but unlikely to be attempted by the user IMO. Input: ctrlCmd+up will focus the response list This works on mac. Not sure why it doesn't on windows. Response list: ctrlCmd+up does nothing I didn't implement this yet, but can in April. Response code block: ctrl+up focuses the input ctrl+down focuses the response list\nverified that this does work. I'm making a new issue about focusing the code block(s) and the bug with in the input focusing the list", "positive_passages": [{"docid": "doc-en-vscode-e0d52b4df496469cca120a633e7349a3ffb182754f973349d4a6361fe9ced381", "text": "return; } const contr = TerminalChatController.activeChatWidget || TerminalChatController.get(activeInstance); <del> contr?.chatWidget?.focusResponse(); </del> <ins> contr?.chatWidget?.inlineChatWidget.chatWidget.focusLastMessage(); </ins> } });", "commid": "vscode_pr_208781"}], "negative_passages": []}
{"query_id": "q-en-vscode-42793c308828bd72ea66e76f96e92e509502fc4219828df390e69e98a8ebbb5d", "query": "Note that both of these scenarios used to work. In the terminal inine chat, run a command like which yields just a chat message response. Try to tab to it. one cannot Run a command like which yields a code block response. Try to use to go from the input box to a code block response and vice versa. one cannot\nNote that the keybindings are important because it's annoying as a SR /keyboard only user to have to tab through a bunch of things to reach the response.\nThis works for me, I do the following with success cmd+i, paste , press Enter wait for the response press tab repeatedly and reach the response\nthe tabbing part works for me in today's insider's\nI'm able to spam Ctrl+Up on Windows to focus between the inputbox and the chat response, but I'm not able to spam Ctrl+Down to do the same. I'm unable to use either shortcut to focus from the inputbox directly into a code block within the chat response. Let me know if the behaviour is as expected or if there's some other steps I can follow.\nI haven't tried windows yet. This won't directly focus the code editor, just the response.\nthis works on mac, could you pls try on windows?\nThe behavior seems wrong now and is quite disorienting: Input: ctrl+up will focus the response list ctrl+down will focus the response list Response list: ctrl+up does nothing ctrl+down does nothing Response code block: ctrl+up focuses the input ctrl+down focuses the response list I would expect: Input: ctrl+up does nothing ctrl+down will focus the response code block Response list: ctrl+up focuses the input Not sure? Response code block: ctrl+up focuses the input ctrl+down focuses the next code block, otherwise not sure\nThis issue was about cmdCtrl+up/down going between the response list and the input. This is unexpected, but unlikely to be attempted by the user IMO. Input: ctrlCmd+up will focus the response list This works on mac. Not sure why it doesn't on windows. Response list: ctrlCmd+up does nothing I didn't implement this yet, but can in April. Response code block: ctrl+up focuses the input ctrl+down focuses the response list\nverified that this does work. I'm making a new issue about focusing the code block(s) and the bug with in the input focusing the list", "positive_passages": [{"docid": "doc-en-vscode-c5833c6d7d88b5cf3665a9f45e10da6d4027cc37a9f460bf392de197bf3c41d1", "text": "focus(): void { this._inlineChatWidget.focus(); } <del> focusResponse(): void { const responseElement = this._inlineChatWidget.domNode.querySelector(ChatElementSelectors.ResponseEditor) || this._inlineChatWidget.domNode.querySelector(ChatElementSelectors.ResponseMessage); if (responseElement instanceof HTMLElement) { responseElement.focus(); } } </del> hasFocus(): boolean { return this._inlineChatWidget.hasFocus(); }", "commid": "vscode_pr_208781"}], "negative_passages": []}
{"query_id": "q-en-vscode-42793c308828bd72ea66e76f96e92e509502fc4219828df390e69e98a8ebbb5d", "query": "Note that both of these scenarios used to work. In the terminal inine chat, run a command like which yields just a chat message response. Try to tab to it. one cannot Run a command like which yields a code block response. Try to use to go from the input box to a code block response and vice versa. one cannot\nNote that the keybindings are important because it's annoying as a SR /keyboard only user to have to tab through a bunch of things to reach the response.\nThis works for me, I do the following with success cmd+i, paste , press Enter wait for the response press tab repeatedly and reach the response\nthe tabbing part works for me in today's insider's\nI'm able to spam Ctrl+Up on Windows to focus between the inputbox and the chat response, but I'm not able to spam Ctrl+Down to do the same. I'm unable to use either shortcut to focus from the inputbox directly into a code block within the chat response. Let me know if the behaviour is as expected or if there's some other steps I can follow.\nI haven't tried windows yet. This won't directly focus the code editor, just the response.\nthis works on mac, could you pls try on windows?\nThe behavior seems wrong now and is quite disorienting: Input: ctrl+up will focus the response list ctrl+down will focus the response list Response list: ctrl+up does nothing ctrl+down does nothing Response code block: ctrl+up focuses the input ctrl+down focuses the response list I would expect: Input: ctrl+up does nothing ctrl+down will focus the response code block Response list: ctrl+up focuses the input Not sure? Response code block: ctrl+up focuses the input ctrl+down focuses the next code block, otherwise not sure\nThis issue was about cmdCtrl+up/down going between the response list and the input. This is unexpected, but unlikely to be attempted by the user IMO. Input: ctrlCmd+up will focus the response list This works on mac. Not sure why it doesn't on windows. Response list: ctrlCmd+up does nothing I didn't implement this yet, but can in April. Response code block: ctrl+up focuses the input ctrl+down focuses the response list\nverified that this does work. I'm making a new issue about focusing the code block(s) and the bug with in the input focusing the list", "positive_passages": [{"docid": "doc-en-vscode-cd5ef6f992eaa6f242a567d86b91b7aa7e1d07665ea4919211cb81f6ccd62e42", "text": "} } <del> const enum ChatElementSelectors { ResponseEditor = '.chatMessageContent textarea', ResponseMessage = '.chatMessageContent', } </del>", "commid": "vscode_pr_208781"}], "negative_passages": []}
{"query_id": "q-en-vscode-2264476a1dac391001bc378390866d76ef33e8c89269f000807bb802a9dcdf5f", "query": "using Default Light + theme run peek references <img width=\"978\" alt=\"Screenshot 2024-03-26 at 17 30 37\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-152dc9768ab59bc818d898d59aa8475657ab16943eacc30d2bccdd3b2e287a97", "text": "// Import the effects we need import { Color } from 'vs/base/common/color'; <del> import { registerColor, darken, lighten, ifDefinedThenElse, transparent } from 'vs/platform/theme/common/colorUtils'; </del> <ins> import { registerColor, darken, lighten, transparent } from 'vs/platform/theme/common/colorUtils'; </ins> // Import the colors we need import { foreground, contrastBorder, activeContrastBorder, focusBorder, iconForeground } from 'vs/platform/theme/common/colors/baseColors';", "commid": "vscode_pr_208835"}], "negative_passages": []}
{"query_id": "q-en-vscode-2264476a1dac391001bc378390866d76ef33e8c89269f000807bb802a9dcdf5f", "query": "using Default Light + theme run peek references <img width=\"978\" alt=\"Screenshot 2024-03-26 at 17 30 37\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-09c85d9a9413e438c936812e6195745fdae187982ad65a69b920df6fa4474c98", "text": "nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.')); export const listFocusHighlightForeground = registerColor('list.focusHighlightForeground', <del> { dark: listHighlightForeground, light: ifDefinedThenElse(listActiveSelectionBackground, listHighlightForeground, '#BBE7FF'), hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </del> <ins> { dark: listHighlightForeground, light: listHighlightForeground, hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </ins> nls.localize('listFocusHighlightForeground', 'List/Tree foreground color of the match highlights on actively focused items when searching inside the list/tree.')); export const listInvalidItemForeground = registerColor('list.invalidItemForeground',", "commid": "vscode_pr_208835"}], "negative_passages": []}
{"query_id": "q-en-vscode-10a9e53cc9b04e2915d3890970ecd46a58487f7a3fe7b91d92a0e88bee273a42", "query": "Sometimes the default width for inline chat seems very wide: <img width=\"854\" alt=\"image\" src=\"\"Maybe it could grow while typing and or allow to be resized.\ndecided against dynamic and going with a more reasonable default width of 360px", "positive_passages": [{"docid": "doc-en-vscode-9e8c122f65de67ae5af0850ca12b5b49e20b7b037ed7032d71097d505bcac0fb", "text": "import { Emitter, Event } from 'vs/base/common/event'; import { DisposableStore } from 'vs/base/common/lifecycle'; import { IPosition, Position } from 'vs/editor/common/core/position'; <del> import { clamp } from 'vs/base/common/numbers'; </del> import { renderLabelWithIcons } from 'vs/base/browser/ui/iconLabel/iconLabels'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { inlineChatBackground } from 'vs/workbench/contrib/inlineChat/common/inlineChat';", "commid": "vscode_pr_208890"}], "negative_passages": []}
{"query_id": "q-en-vscode-10a9e53cc9b04e2915d3890970ecd46a58487f7a3fe7b91d92a0e88bee273a42", "query": "Sometimes the default width for inline chat seems very wide: <img width=\"854\" alt=\"image\" src=\"\"Maybe it could grow while typing and or allow to be resized.\ndecided against dynamic and going with a more reasonable default width of 360px", "positive_passages": [{"docid": "doc-en-vscode-527495b3e599b83e172b863e4b1a676b25bfddf0fe4238020cc73a20cca985d2", "text": "import { Range } from 'vs/editor/common/core/range'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <ins> import { EditorOption } from 'vs/editor/common/config/editorOptions'; </ins> export class InlineChatContentWidget implements IContentWidget {", "commid": "vscode_pr_208890"}], "negative_passages": []}
{"query_id": "q-en-vscode-10a9e53cc9b04e2915d3890970ecd46a58487f7a3fe7b91d92a0e88bee273a42", "query": "Sometimes the default width for inline chat seems very wide: <img width=\"854\" alt=\"image\" src=\"\"Maybe it could grow while typing and or allow to be resized.\ndecided against dynamic and going with a more reasonable default width of 360px", "positive_passages": [{"docid": "doc-en-vscode-4d36a54833e8e305166bd8b583374f485b48773ad4b8a3e56201fc3e41bbdcdf", "text": "beforeRender(): IDimension | null { <del> const contentWidth = this._editor.getLayoutInfo().contentWidth; const minWidth = Math.round(contentWidth * 0.38); const maxWidth = Math.round(contentWidth * 0.82); const width = clamp(220, minWidth, maxWidth); </del> <ins> const maxHeight = this._widget.input.inputEditor.getOption(EditorOption.lineHeight) * 5; </ins> const inputEditorHeight = this._widget.inputEditor.getContentHeight(); <del> this._widget.inputEditor.layout(new dom.Dimension(width, inputEditorHeight)); </del> <ins> this._widget.inputEditor.layout(new dom.Dimension(360, Math.min(maxHeight, inputEditorHeight))); </ins> // const actualHeight = this._widget.inputPartHeight; // return new dom.Dimension(width, actualHeight);", "commid": "vscode_pr_208890"}], "negative_passages": []}
{"query_id": "q-en-vscode-10a9e53cc9b04e2915d3890970ecd46a58487f7a3fe7b91d92a0e88bee273a42", "query": "Sometimes the default width for inline chat seems very wide: <img width=\"854\" alt=\"image\" src=\"\"Maybe it could grow while typing and or allow to be resized.\ndecided against dynamic and going with a more reasonable default width of 360px", "positive_passages": [{"docid": "doc-en-vscode-cfe6fb0d125ff628441cc490e9ee8a64199d2ab1a9fe6ea662937ef9e6b7d23f", "text": "display: none; } <ins> .monaco-workbench .inline-chat-content-widget.interactive-session .interactive-session { max-width: unset; } </ins> .monaco-workbench .inline-chat-content-widget.interactive-session .interactive-input-part .interactive-execute-toolbar { margin-bottom: 1px; }", "commid": "vscode_pr_208890"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b3bcf8125e6046d0ce0379f938f8a06f6f3f4a225ed7202bbb948ac7d9c2cc0", "query": "Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers", "positive_passages": [{"docid": "doc-en-vscode-31c09db20231d7c77f81acb98437e1ac75aa3f7fa365fd15fbb241731b520cb3", "text": "import { Codicon } from 'vs/base/common/codicons'; import { ThemeIcon } from 'vs/base/common/themables'; import { onUnexpectedExternalError } from 'vs/base/common/errors'; <del> import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; </del> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; <del> import { ClickAction, KeyDownAction } from 'vs/base/browser/ui/hover/hoverWidget'; </del> <ins> import { ClickAction, HoverPosition, KeyDownAction } from 'vs/base/browser/ui/hover/hoverWidget'; </ins> import { KeyCode } from 'vs/base/common/keyCodes'; <del> import { IHoverService } from 'vs/platform/hover/browser/hover'; </del> <ins> import { IHoverService, WorkbenchHoverDelegate } from 'vs/platform/hover/browser/hover'; </ins> import { AsyncIterableObject } from 'vs/base/common/async'; import { LanguageFeatureRegistry } from 'vs/editor/common/languageFeatureRegistry'; import { getHoverProviderResultsAsAsyncIterable } from 'vs/editor/contrib/hover/browser/getHover';", "commid": "vscode_pr_211095"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b3bcf8125e6046d0ce0379f938f8a06f6f3f4a225ed7202bbb948ac7d9c2cc0", "query": "Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers", "positive_passages": [{"docid": "doc-en-vscode-202c05379be24bf77ad357f8c0581156bcd76644567a176ce717c08dfbf61d18", "text": "this._openerService, this._keybindingService, this._hoverService, <ins> this._configurationService, </ins> context.onContentsChanged ); return this._renderedHoverParts;", "commid": "vscode_pr_211095"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b3bcf8125e6046d0ce0379f938f8a06f6f3f4a225ed7202bbb948ac7d9c2cc0", "query": "Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers", "positive_passages": [{"docid": "doc-en-vscode-5d1625cd8c8ece55b692ec35f88f0ba7d064ae361dfd18f9b7068bcb5560d8ef", "text": "private readonly _openerService: IOpenerService, private readonly _keybindingService: IKeybindingService, private readonly _hoverService: IHoverService, <ins> private readonly _configurationService: IConfigurationService, </ins> private readonly _onFinishedRendering: () => void, ) { super();", "commid": "vscode_pr_211095"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b3bcf8125e6046d0ce0379f938f8a06f6f3f4a225ed7202bbb948ac7d9c2cc0", "query": "Testing Sometimes when I hovered over the button it would show the hover of that button over the button. When moving down to the button it would close the editor hover sometimes because the mouse would move over the hover. This could be solved by setting an anchor for the and hovers", "positive_passages": [{"docid": "doc-en-vscode-b36959b3687b7c02b130976e8f75200c967c0ebab3c9ce0d63d89a39e3253cf5", "text": "const isActionIncrease = action === HoverVerbosityAction.Increase; const actionElement = dom.append(container, $(ThemeIcon.asCSSSelector(isActionIncrease ? increaseHoverVerbosityIcon : decreaseHoverVerbosityIcon))); actionElement.tabIndex = 0; <ins> const hoverDelegate = new WorkbenchHoverDelegate('mouse', false, { target: container, position: { hoverPosition: HoverPosition.LEFT } }, this._configurationService, this._hoverService); </ins> if (isActionIncrease) { const kb = this._keybindingService.lookupKeybinding(INCREASE_HOVER_VERBOSITY_ACTION_ID); <del> store.add(this._hoverService.setupUpdatableHover(getDefaultHoverDelegate('mouse'), actionElement, kb ? </del> <ins> store.add(this._hoverService.setupUpdatableHover(hoverDelegate, actionElement, kb ? </ins> nls.localize('increaseVerbosityWithKb', \"Increase Verbosity ({0})\", kb.getLabel()) : nls.localize('increaseVerbosity', \"Increase Verbosity\"))); } else { const kb = this._keybindingService.lookupKeybinding(DECREASE_HOVER_VERBOSITY_ACTION_ID); <del> store.add(this._hoverService.setupUpdatableHover(getDefaultHoverDelegate('mouse'), actionElement, kb ? </del> <ins> store.add(this._hoverService.setupUpdatableHover(hoverDelegate, actionElement, kb ? </ins> nls.localize('decreaseVerbosityWithKb', \"Decrease Verbosity ({0})\", kb.getLabel()) : nls.localize('decreaseVerbosity', \"Decrease Verbosity\"))); }", "commid": "vscode_pr_211095"}], "negative_passages": []}
{"query_id": "q-en-vscode-9f9a2900d3e204a4e6bf9ef9e08bfcf3f07630a552f4ea1831b605479d08fa5c", "query": "Testing The keybinding does not work on windows due to quick open. Also the keybinding collides with the command. I wonder if this could be solved without registering keybindings. One idea could be that when the hover is focused the user could just use and on the keyboard to increase and decrease the hover (possibly also arrow keys could work). Make sure to mention in the hover of the increase and decrease actions what the keybinding or keyboard key is.\nThat's a very good point. I think we would still want ideally the + and - to be linked to keybindings so they can be configured by the user. I'll remove the keybindings, so they can simply be set by the users if they so wish. The current code already renders the keybindings if they are set: Perhaps they are not fetched correctly in your case because of the keybinding collisions. !", "positive_passages": [{"docid": "doc-en-vscode-c11233c3b7dd8c4aab312314f9c3131cf1c9c5cafd70c40eca753d06034550c0", "text": "comment: ['Label for action that will increase the hover verbosity level.'] }, \"Increase Hover Verbosity Level\"), alias: 'Increase Hover Verbosity Level', <del> precondition: EditorContextKeys.hoverFocused, kbOpts: { kbExpr: EditorContextKeys.hoverFocused, primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KeyK, KeyMod.CtrlCmd | KeyCode.KeyP), weight: KeybindingWeight.EditorContrib } </del> <ins> precondition: EditorContextKeys.hoverFocused </ins> }); }", "commid": "vscode_pr_211091"}], "negative_passages": []}
{"query_id": "q-en-vscode-9f9a2900d3e204a4e6bf9ef9e08bfcf3f07630a552f4ea1831b605479d08fa5c", "query": "Testing The keybinding does not work on windows due to quick open. Also the keybinding collides with the command. I wonder if this could be solved without registering keybindings. One idea could be that when the hover is focused the user could just use and on the keyboard to increase and decrease the hover (possibly also arrow keys could work). Make sure to mention in the hover of the increase and decrease actions what the keybinding or keyboard key is.\nThat's a very good point. I think we would still want ideally the + and - to be linked to keybindings so they can be configured by the user. I'll remove the keybindings, so they can simply be set by the users if they so wish. The current code already renders the keybindings if they are set: Perhaps they are not fetched correctly in your case because of the keybinding collisions. !", "positive_passages": [{"docid": "doc-en-vscode-745f6400915ef6633982c9d54ad1233e6991ec67bad23305cb0c86e59d71b5a4", "text": "comment: ['Label for action that will decrease the hover verbosity level.'] }, \"Decrease Hover Verbosity Level\"), alias: 'Decrease Hover Verbosity Level', <del> precondition: EditorContextKeys.hoverFocused, kbOpts: { kbExpr: EditorContextKeys.hoverFocused, primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KeyK, KeyMod.CtrlCmd | KeyCode.KeyM), weight: KeybindingWeight.EditorContrib } </del> <ins> precondition: EditorContextKeys.hoverFocused </ins> }); }", "commid": "vscode_pr_211091"}], "negative_passages": []}
{"query_id": "q-en-vscode-09df075b28b8eb7a9ac0a8e21ba4da59b1f907ad5bd92ad6c06d7a7ab4a68f6b", "query": "Testing on Linux I have 2 monitors: primary and secondary. I opened VS Code and maximized it on my secondary monitor. Then I dragged an aux window out and maximized it on my primary monitor. After closing and reopening VS Code, the maximized state of both my main window and my aux window were restored, but both were on my secondary monitor. The aux window was on top. I'm using Remote Desktop + Hyper V, so maybe something is going on there: Remote Desktop from Windows to another Windows machine. Hyper V to an Ubuntu VM.\nLooks like which monitor is primary and which is secondary doesn't seem to matter as the same thing happens when swap the windows that aux and main are on.\nI also experienced a variant of this: Main VS Code window maximized in primary monitor, 1 aux window maximized in primary monitor, 1 aux window maximized in secondary monitor Close VS Code Reopen VS Code All 3 windows (main and aux) are restored to max, but they're all restored to my primary monitor I'm testing on Windows 11 Insiders.", "positive_passages": [{"docid": "doc-en-vscode-cb56d0920fe5dfedb599bd5d513c36c38a8c274fdf41e24d0c7e526ceb147102", "text": "const fullscreen = isFullscreen(this.window); return { ...state, <del> bounds: this.maximized ? undefined : state.bounds, // ignore if maximized (fullscreen is not yet supported!) </del> <ins> bounds: state.bounds, </ins> mode: this.maximized ? AuxiliaryWindowMode.Maximized : fullscreen ? AuxiliaryWindowMode.Fullscreen : AuxiliaryWindowMode.Normal }; }", "commid": "vscode_pr_211141"}], "negative_passages": []}
{"query_id": "q-en-vscode-cfe4b11a46225c0283b9344c7675890f59bc9163d2e3057fbba92ef1ce9c181b", "query": "Testing Steps: Use Windows PowerShell (not PowerShell Core) Turn on the terminal intellisense Type stuff is to the terminal", "positive_passages": [{"docid": "doc-en-vscode-81eefda8aaace5df75035196d329701ec65d45a4cb3493a158e0841522f46b70", "text": "$completionPrefix = $commandLine # Get completions <del> $result = \"`e]633;Completions\" </del> <ins> $result = \"$([char]0x1b)]633;Completions\" </ins> if ($completionPrefix.Length -gt 0) { # Get and send completions $completions = TabExpansion2 -inputScript $completionPrefix -cursorColumn $cursorIndex", "commid": "vscode_pr_211135"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b4614531cc1d93b5bcd5001cc2e7db64b0d262e186b4269d7346a9fbbb8ce3e", "query": "Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro\na notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese\n!\nThanks I can replicate this issue.\nGiving the issue back to Aaron to verify. My Python install's a bit broken.", "positive_passages": [{"docid": "doc-en-vscode-f1f8f74d0c634936cfebec2c944c5316f944d984e1096d60b92ec7554117bb8e", "text": "import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IMarkerService } from 'vs/platform/markers/common/markers'; import { IThemeService } from 'vs/platform/theme/common/themeService'; <del> import { IActiveNotebookEditor, ICellViewModel, INotebookEditor, type INotebookViewCellsUpdateEvent } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; </del> <ins> import { IActiveNotebookEditor, ICellViewModel, INotebookEditor } from 'vs/workbench/contrib/notebook/browser/notebookBrowser'; </ins> import { CellKind, NotebookCellsChangeType, NotebookSetting } from 'vs/workbench/contrib/notebook/common/notebookCommon'; import { INotebookExecutionStateService, NotebookExecutionType } from 'vs/workbench/contrib/notebook/common/notebookExecutionStateService'; import { OutlineChangeEvent, OutlineConfigKeys, OutlineTarget } from 'vs/workbench/services/outline/browser/outline';", "commid": "vscode_pr_211205"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b4614531cc1d93b5bcd5001cc2e7db64b0d262e186b4269d7346a9fbbb8ce3e", "query": "Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro\na notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese\n!\nThanks I can replicate this issue.\nGiving the issue back to Aaron to verify. My Python install's a bit broken.", "positive_passages": [{"docid": "doc-en-vscode-a93ed1c4087f85ef36b109245f6c3cd88536f7182fbdb6bb03bed5dd763c03b6", "text": "private _uri: URI | undefined; private _entries: OutlineEntry[] = []; get entries(): OutlineEntry[] { <ins> if (this.delayedOutlineRecompute.isTriggered()) { this.delayedOutlineRecompute.cancel(); this._recomputeState(); } </ins> return this._entries; }", "commid": "vscode_pr_211205"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b4614531cc1d93b5bcd5001cc2e7db64b0d262e186b4269d7346a9fbbb8ce3e", "query": "Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro\na notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese\n!\nThanks I can replicate this issue.\nGiving the issue back to Aaron to verify. My Python install's a bit broken.", "positive_passages": [{"docid": "doc-en-vscode-94d5105b7e53d7146bbcfdcdf6ceac71f6e2be50143ded5cc29aa020ba7cec86", "text": "readonly outlineKind = 'notebookCells'; get activeElement(): OutlineEntry | undefined { <ins> if (this.delayedOutlineRecompute.isTriggered()) { this.delayedOutlineRecompute.cancel(); this._recomputeState(); } </ins> return this._activeEntry; } private readonly _outlineEntryFactory: NotebookOutlineEntryFactory; <del> private readonly delayRecomputeActive: () => void; </del> <ins> private readonly delayedOutlineRecompute: Delayer<void>;; </ins> constructor( private readonly _editor: INotebookEditor, private readonly _target: OutlineTarget,", "commid": "vscode_pr_211205"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b4614531cc1d93b5bcd5001cc2e7db64b0d262e186b4269d7346a9fbbb8ce3e", "query": "Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro\na notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese\n!\nThanks I can replicate this issue.\nGiving the issue back to Aaron to verify. My Python install's a bit broken.", "positive_passages": [{"docid": "doc-en-vscode-dcbad39a53f6a006c56f71c6f603aac7ba714d36b01a5cb0b018745368f634f1", "text": "@IConfigurationService private readonly _configurationService: IConfigurationService, ) { this._outlineEntryFactory = new NotebookOutlineEntryFactory(notebookExecutionStateService); <del> const delayerRecomputeActive = this._disposables.add(new Delayer(10)); this.delayRecomputeActive = () => delayerRecomputeActive.trigger(() => this._recomputeActive()); this._disposables.add(Event.debounce<void, void>( _editor.onDidChangeSelection, (last, _current) => last, 200 )(() => { this.delayRecomputeActive(); </del> <ins> const delayerRecomputeActive = this._disposables.add(new Delayer(200)); this._disposables.add(_editor.onDidChangeSelection(() => { delayerRecomputeActive.trigger(() => this._recomputeActive()); </ins> }, this)) <del> this._disposables.add(Event.debounce<INotebookViewCellsUpdateEvent, INotebookViewCellsUpdateEvent>( _editor.onDidChangeViewCells, (last, _current) => last ?? _current, 200 )(() => { this.delayRecomputeActive(); }, this) ); </del> // .3s of a delay is sufficient, 100-200s is too quick and will unnecessarily block the ui thread. // Given we're only updating the outline when the user types, we can afford to wait a bit. <del> const delayer = this._disposables.add(new Delayer<void>(300)); const delayedRecompute = () => delayer.trigger(() => this._recomputeState()); </del> <ins> this.delayedOutlineRecompute = this._disposables.add(new Delayer<void>(300)); const delayedRecompute = () => { delayerRecomputeActive.cancel(); // Active is always recomputed after a recomputing the outline state. this.delayedOutlineRecompute.trigger(() => this._recomputeState()); }; </ins> this._disposables.add(_configurationService.onDidChangeConfiguration(e => { if (e.affectsConfiguration(NotebookSetting.outlineShowMarkdownHeadersOnly) ||", "commid": "vscode_pr_211205"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b4614531cc1d93b5bcd5001cc2e7db64b0d262e186b4269d7346a9fbbb8ce3e", "query": "Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro\na notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese\n!\nThanks I can replicate this issue.\nGiving the issue back to Aaron to verify. My Python install's a bit broken.", "positive_passages": [{"docid": "doc-en-vscode-c87b7f808ff00cb36b96a0770cfa86efa15fc7c094975d54dc0610e325ece8a4", "text": "return; } disposable.add(this._editor.textModel.onDidChangeContent(contentChanges => { <del> if (contentChanges.rawEvents.some(c => c.kind === NotebookCellsChangeType.ChangeCellContent)) { </del> <ins> if (contentChanges.rawEvents.some(c => c.kind === NotebookCellsChangeType.ChangeCellContent || c.kind === NotebookCellsChangeType.ChangeCellInternalMetadata || c.kind === NotebookCellsChangeType.Move || c.kind === NotebookCellsChangeType.ModelChange)) { </ins> delayedRecompute(); } }));", "commid": "vscode_pr_211205"}], "negative_passages": []}
{"query_id": "q-en-vscode-2b4614531cc1d93b5bcd5001cc2e7db64b0d262e186b4269d7346a9fbbb8ce3e", "query": "Testing ! This happened when updating the file on disk outside of vscode, I'll try to find a consistent repro\na notebook with several markdown headers in insiders the same notebook in stable and add a header :bug: outline in insiders is not updated (stable does update when doing this in reverse) a different markdown header in insiders :bug: screencheese\n!\nThanks I can replicate this issue.\nGiving the issue back to Aaron to verify. My Python install's a bit broken.", "positive_passages": [{"docid": "doc-en-vscode-3b03d01e3ff874ed5608096a8ac25143dd0048cac302662eea4054794ba81c14", "text": "} })); <del> this.delayRecomputeActive(); </del> <ins> this._recomputeActive(); </ins> } private _recomputeActive(): { changeEventTriggered: boolean } {", "commid": "vscode_pr_211205"}], "negative_passages": []}
{"query_id": "q-en-vscode-a9ec82f7ae288934849e0387bcb67ffb3fc8f1e0e9d46fa1be32b8202241a34c", "query": "It seems that works workspace-relative unless an absolute glob pattern is used. I would clarify that from the settings description.", "positive_passages": [{"docid": "doc-en-vscode-8682e210d66303fee61ac713115c9ee26354564e2688635739f869de6cbcdcc5", "text": "let customEditorLabelDescription = localize('workbench.editor.label.patterns', \"Controls the rendering of the editor label. Each __Item__ is a pattern that matches a file path. Both relative and absolute file paths are supported. In case multiple patterns match, the longest matching path will be picked. Each __Value__ is the template for the rendered editor when the __Item__ matches. Variables are substituted based on the context:\"); customEditorLabelDescription += 'n- ' + [ localize('workbench.editor.label.dirname', \"`${dirname}`: name of the folder in which the file is located (e.g. `root/folder/file.txt -> folder`).\"), <del> localize('workbench.editor.label.nthdirname', \"`${dirname(N)}`: name of the nth parent folder in which the file is located (e.g. `N=1: root/folder/file.txt -> root`).\"), </del> <ins> localize('workbench.editor.label.nthdirname', \"`${dirname(N)}`: name of the nth parent folder in which the file is located (e.g. `N=1: root/folder/file.txt -> root`). Folders can be picked from the start of the path by using negative numbers (e.g. `N=-1: root/folder/file.txt -> root`). If the __Item__ is an absolute pattern path, the first folder (`N=-1`) refers to the first folder in the absoulte path, otherwise it corresponds to the workspace folder.\"), </ins> localize('workbench.editor.label.filename', \"`${filename}`: name of the file without the file extension (e.g. `root/folder/file.txt -> file`).\"), localize('workbench.editor.label.extname', \"`${extname}`: the file extension (e.g. `root/folder/file.txt -> txt`).\"), ].join('n- '); // intentionally concatenated to not produce a string that is too long for translations", "commid": "vscode_pr_211263"}], "negative_passages": []}
{"query_id": "q-en-vscode-3e49ee3b192fb54089a25de8f37350a01f63a07e449e305e8320b523b90bd597", "query": "Type: <bBug</ban existing remote project an embedded terminal in VSC \"PORTS\" tab shows 51 ports This is a vanilla-flavored nodejs service that uses one dedicated port determined by the remote environment (an AWS EC2 instance running Rocky Linux) -- and that dedicated port is not opened until the service is started. I expect at most 2-3 ports to be open at any one time. VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-477.27.1.el88.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-explorer0.4.3 java1.30.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 vscode-java-debug0.57.0 vscode-java-dependency0.23.6 vscode-java-pack0.26.0 vscode-java-test0.41.1 vscode-maven0.44.0 markdown-pdf1.5.0 </details<!-- generated by issue reporter --\nCan you connect to your remote then share the following: the value of the setting the value of the setting A screen shot of the Ports view\nI appreciate your prompt attention, thanks for looking at this. As you can see in the attached \"Ports view\", this morning there were 53 open ports at startup. I've attached a screenshot of the \"Settings\" view (searching for \"remote.autoForwardPorts\") and the \"Ports view\". I looked in the local \"\" (in ) and see no settings with the two names you requested. I similarly found nothing in the relevant \"\" file(s) on the remote server. Hopefully the attached screenshot of the \"Settings\" view provides the information you requested. ! Settings ! Ports view\nis it possible you at some point ran something that listened on each of those ports? By default, VS Code will auto forward ports, but with the setting set to , which is what you have, we don't know when to stop forwarding the port. We also restore ports (setting ). I think the best thing we can do is change the default for SSH for to , which will let us know when to stop forwarding. I've made the appropriate PRs to get that changed.\nIf something ran that was listening on those ports, it was unknown to me. I don't knowingly do anything with ports on the local (Windows 10 pro) system. I manage multiple ports on the remote system, but each has a 4-digit port number. An aspect that may be of interest is that the startup behavior seems to be specific to this remote folder (). When I use VSC to open a sibling on the remote host (), the embedded terminal shows no forwarded ports at all. Screenshots below show this behavior. ! Startup VSC on ~/tms/backend/gate ! Ports view on ~/tms/backend/gate\nWe restore ports based on the folder, so it makes sense that you're seeing different ports depending on which folder you have open.\nHmm. It seems likely that at some point something was running and listening on those ports, otherwise we wouldn't have found them and auto forwarded them. I think the change to use by default that I mentioned above will resolve your issue in the future, but for now, I would suggest you unforward all those ports and set to .\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-0154b6ae531ca6fdcccd9949562c2cabb716c7363aa2225fa338be8dc6947877", "text": "import { MainThreadTunnelServiceShape, MainContext, ExtHostContext, ExtHostTunnelServiceShape, CandidatePortSource, PortAttributesSelector, TunnelDto } from 'vs/workbench/api/common/extHost.protocol'; import { TunnelDtoConverter } from 'vs/workbench/api/common/extHostTunnelService'; import { extHostNamedCustomer, IExtHostContext } from 'vs/workbench/services/extensions/common/extHostCustomers'; <del> import { IRemoteExplorerService, PORT_AUTO_FORWARD_SETTING, PORT_AUTO_SOURCE_SETTING, PORT_AUTO_SOURCE_SETTING_OUTPUT } from 'vs/workbench/services/remote/common/remoteExplorerService'; </del> <ins> import { IRemoteExplorerService, PORT_AUTO_FORWARD_SETTING, PORT_AUTO_SOURCE_SETTING, PORT_AUTO_SOURCE_SETTING_HYBRID, PORT_AUTO_SOURCE_SETTING_OUTPUT } from 'vs/workbench/services/remote/common/remoteExplorerService'; </ins> import { ITunnelProvider, ITunnelService, TunnelCreationOptions, TunnelProviderFeatures, TunnelOptions, RemoteTunnel, ProvidedPortAttributes, PortAttributesProvider, TunnelProtocol } from 'vs/platform/tunnel/common/tunnel'; import { Disposable } from 'vs/base/common/lifecycle'; import type { TunnelDescription } from 'vs/platform/remote/common/remoteAuthorityResolver';", "commid": "vscode_pr_211696"}], "negative_passages": []}
{"query_id": "q-en-vscode-3e49ee3b192fb54089a25de8f37350a01f63a07e449e305e8320b523b90bd597", "query": "Type: <bBug</ban existing remote project an embedded terminal in VSC \"PORTS\" tab shows 51 ports This is a vanilla-flavored nodejs service that uses one dedicated port determined by the remote environment (an AWS EC2 instance running Rocky Linux) -- and that dedicated port is not opened until the service is started. I expect at most 2-3 ports to be open at any one time. VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-477.27.1.el88.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-explorer0.4.3 java1.30.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 vscode-java-debug0.57.0 vscode-java-dependency0.23.6 vscode-java-pack0.26.0 vscode-java-test0.41.1 vscode-maven0.44.0 markdown-pdf1.5.0 </details<!-- generated by issue reporter --\nCan you connect to your remote then share the following: the value of the setting the value of the setting A screen shot of the Ports view\nI appreciate your prompt attention, thanks for looking at this. As you can see in the attached \"Ports view\", this morning there were 53 open ports at startup. I've attached a screenshot of the \"Settings\" view (searching for \"remote.autoForwardPorts\") and the \"Ports view\". I looked in the local \"\" (in ) and see no settings with the two names you requested. I similarly found nothing in the relevant \"\" file(s) on the remote server. Hopefully the attached screenshot of the \"Settings\" view provides the information you requested. ! Settings ! Ports view\nis it possible you at some point ran something that listened on each of those ports? By default, VS Code will auto forward ports, but with the setting set to , which is what you have, we don't know when to stop forwarding the port. We also restore ports (setting ). I think the best thing we can do is change the default for SSH for to , which will let us know when to stop forwarding. I've made the appropriate PRs to get that changed.\nIf something ran that was listening on those ports, it was unknown to me. I don't knowingly do anything with ports on the local (Windows 10 pro) system. I manage multiple ports on the remote system, but each has a 4-digit port number. An aspect that may be of interest is that the startup behavior seems to be specific to this remote folder (). When I use VSC to open a sibling on the remote host (), the embedded terminal shows no forwarded ports at all. Screenshots below show this behavior. ! Startup VSC on ~/tms/backend/gate ! Ports view on ~/tms/backend/gate\nWe restore ports based on the folder, so it makes sense that you're seeing different ports depending on which folder you have open.\nHmm. It seems likely that at some point something was running and listening on those ports, otherwise we wouldn't have found them and auto forwarded them. I think the change to use by default that I mentioned above will resolve your issue in the future, but for now, I would suggest you unforward all those ports and set to .\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-d4940ff8a9f293e6d556c08e88c609ecdd0ad9304da5fe5e910cb5b5b4ca7123", "text": ".registerDefaultConfigurations([{ overrides: { 'remote.autoForwardPortsSource': PORT_AUTO_SOURCE_SETTING_OUTPUT } }]); break; } <ins> case CandidatePortSource.Hybrid: { Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration) .registerDefaultConfigurations([{ overrides: { 'remote.autoForwardPortsSource': PORT_AUTO_SOURCE_SETTING_HYBRID } }]); break; } </ins> default: // Do nothing, the defaults for these settings should be used. } }).catch(() => {", "commid": "vscode_pr_211696"}], "negative_passages": []}
{"query_id": "q-en-vscode-3e49ee3b192fb54089a25de8f37350a01f63a07e449e305e8320b523b90bd597", "query": "Type: <bBug</ban existing remote project an embedded terminal in VSC \"PORTS\" tab shows 51 ports This is a vanilla-flavored nodejs service that uses one dedicated port determined by the remote environment (an AWS EC2 instance running Rocky Linux) -- and that dedicated port is not opened until the service is started. I expect at most 2-3 ports to be open at any one time. VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-477.27.1.el88.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-explorer0.4.3 java1.30.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 vscode-java-debug0.57.0 vscode-java-dependency0.23.6 vscode-java-pack0.26.0 vscode-java-test0.41.1 vscode-maven0.44.0 markdown-pdf1.5.0 </details<!-- generated by issue reporter --\nCan you connect to your remote then share the following: the value of the setting the value of the setting A screen shot of the Ports view\nI appreciate your prompt attention, thanks for looking at this. As you can see in the attached \"Ports view\", this morning there were 53 open ports at startup. I've attached a screenshot of the \"Settings\" view (searching for \"remote.autoForwardPorts\") and the \"Ports view\". I looked in the local \"\" (in ) and see no settings with the two names you requested. I similarly found nothing in the relevant \"\" file(s) on the remote server. Hopefully the attached screenshot of the \"Settings\" view provides the information you requested. ! Settings ! Ports view\nis it possible you at some point ran something that listened on each of those ports? By default, VS Code will auto forward ports, but with the setting set to , which is what you have, we don't know when to stop forwarding the port. We also restore ports (setting ). I think the best thing we can do is change the default for SSH for to , which will let us know when to stop forwarding. I've made the appropriate PRs to get that changed.\nIf something ran that was listening on those ports, it was unknown to me. I don't knowingly do anything with ports on the local (Windows 10 pro) system. I manage multiple ports on the remote system, but each has a 4-digit port number. An aspect that may be of interest is that the startup behavior seems to be specific to this remote folder (). When I use VSC to open a sibling on the remote host (), the embedded terminal shows no forwarded ports at all. Screenshots below show this behavior. ! Startup VSC on ~/tms/backend/gate ! Ports view on ~/tms/backend/gate\nWe restore ports based on the folder, so it makes sense that you're seeing different ports depending on which folder you have open.\nHmm. It seems likely that at some point something was running and listening on those ports, otherwise we wouldn't have found them and auto forwarded them. I think the change to use by default that I mentioned above will resolve your issue in the future, but for now, I would suggest you unforward all those ports and set to .\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-6520aee1c642ba7860041e15fe507de0686024c94866b8d20903335d739dce3f", "text": "export enum CandidatePortSource { None = 0, Process = 1, <del> Output = 2 </del> <ins> Output = 2, Hybrid = 3 </ins> } export interface PortAttributesSelector {", "commid": "vscode_pr_211696"}], "negative_passages": []}
{"query_id": "q-en-vscode-3e49ee3b192fb54089a25de8f37350a01f63a07e449e305e8320b523b90bd597", "query": "Type: <bBug</ban existing remote project an embedded terminal in VSC \"PORTS\" tab shows 51 ports This is a vanilla-flavored nodejs service that uses one dedicated port determined by the remote environment (an AWS EC2 instance running Rocky Linux) -- and that dedicated port is not opened until the service is started. I expect at most 2-3 ports to be open at any one time. VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-477.27.1.el88.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-explorer0.4.3 java1.30.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 vscode-java-debug0.57.0 vscode-java-dependency0.23.6 vscode-java-pack0.26.0 vscode-java-test0.41.1 vscode-maven0.44.0 markdown-pdf1.5.0 </details<!-- generated by issue reporter --\nCan you connect to your remote then share the following: the value of the setting the value of the setting A screen shot of the Ports view\nI appreciate your prompt attention, thanks for looking at this. As you can see in the attached \"Ports view\", this morning there were 53 open ports at startup. I've attached a screenshot of the \"Settings\" view (searching for \"remote.autoForwardPorts\") and the \"Ports view\". I looked in the local \"\" (in ) and see no settings with the two names you requested. I similarly found nothing in the relevant \"\" file(s) on the remote server. Hopefully the attached screenshot of the \"Settings\" view provides the information you requested. ! Settings ! Ports view\nis it possible you at some point ran something that listened on each of those ports? By default, VS Code will auto forward ports, but with the setting set to , which is what you have, we don't know when to stop forwarding the port. We also restore ports (setting ). I think the best thing we can do is change the default for SSH for to , which will let us know when to stop forwarding. I've made the appropriate PRs to get that changed.\nIf something ran that was listening on those ports, it was unknown to me. I don't knowingly do anything with ports on the local (Windows 10 pro) system. I manage multiple ports on the remote system, but each has a 4-digit port number. An aspect that may be of interest is that the startup behavior seems to be specific to this remote folder (). When I use VSC to open a sibling on the remote host (), the embedded terminal shows no forwarded ports at all. Screenshots below show this behavior. ! Startup VSC on ~/tms/backend/gate ! Ports view on ~/tms/backend/gate\nWe restore ports based on the folder, so it makes sense that you're seeing different ports depending on which folder you have open.\nHmm. It seems likely that at some point something was running and listening on those ports, otherwise we wouldn't have found them and auto forwarded them. I think the change to use by default that I mentioned above will resolve your issue in the future, but for now, I would suggest you unforward all those ports and set to .\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-528a21ad11cf2a937b2f27f46d150d87a760c79d64bc5b036854eb78429ed037", "text": "export enum CandidatePortSource { None = 0, Process = 1, <del> Output = 2 </del> <ins> Output = 2, Hybrid = 3 </ins> } export type ResolverResult = (ResolvedAuthority | ManagedResolvedAuthority) & ResolvedOptions & TunnelInformation;", "commid": "vscode_pr_211696"}], "negative_passages": []}
{"query_id": "q-en-vscode-983a2412360bf360239b2635de19c65e7d279019a863783e1993b8211599ef0a", "query": "Using the workspace TS version, 5.5.0-dev.: ! ! !\nClosing for verification", "positive_passages": [{"docid": "doc-en-vscode-66fb7e59b8e59c5407fc9f8867ca0808bbce385aaca277ea9240561a63fd1714", "text": "} private toSymbolInformation(item: Proto.NavtoItem): vscode.SymbolInformation | undefined { <del> if (!item.containerName || item.kind === 'alias') { </del> <ins> if (item.kind === 'alias' && !item.containerName) { </ins> return; }", "commid": "vscode_pr_211681"}], "negative_passages": []}
{"query_id": "q-en-vscode-983a2412360bf360239b2635de19c65e7d279019a863783e1993b8211599ef0a", "query": "Using the workspace TS version, 5.5.0-dev.: ! ! !\nClosing for verification", "positive_passages": [{"docid": "doc-en-vscode-66fb7e59b8e59c5407fc9f8867ca0808bbce385aaca277ea9240561a63fd1714", "text": "} private toSymbolInformation(item: Proto.NavtoItem): vscode.SymbolInformation | undefined { <del> if (!item.containerName || item.kind === 'alias') { </del> <ins> if (item.kind === 'alias' && !item.containerName) { </ins> return; }", "commid": "vscode_pr_211682"}], "negative_passages": []}
{"query_id": "q-en-vscode-60423e83be56488c703bd71c34d8e30f5cef00ec4234f02ec4b079e89f7afe5f", "query": "I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi\nI haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nYes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks", "positive_passages": [{"docid": "doc-en-vscode-8b4292944fab3b7d5666ed78c66b76ffd60321b405fe732ca207dccb334ba23d", "text": "\"--vscode-editorStickyScroll-scrollableWidth\", \"--vscode-editorStickyScroll-foldingOpacityTransition\", \"--window-border-color\", <ins> \"--vscode-parameterHintsWidget-editorFontFamily\", \"--vscode-parameterHintsWidget-editorFontFamilyDefault\", </ins> \"--workspace-trust-check-color\", \"--workspace-trust-selected-color\", \"--workspace-trust-unselected-color\",", "commid": "vscode_pr_221737"}], "negative_passages": []}
{"query_id": "q-en-vscode-60423e83be56488c703bd71c34d8e30f5cef00ec4234f02ec4b079e89f7afe5f", "query": "I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi\nI haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nYes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks", "positive_passages": [{"docid": "doc-en-vscode-f7eef1aaa71038b26e6df21d4084a51f62571cb3940617d338b03e1438588a92", "text": "border-bottom: 1px solid var(--vscode-editorHoverWidget-border); } <ins> .monaco-editor .parameter-hints-widget .code { font-family: var(--vscode-parameterHintsWidget-editorFontFamily), var(--vscode-parameterHintsWidget-editorFontFamilyDefault); } </ins> .monaco-editor .parameter-hints-widget .docs { padding: 0 10px 0 5px; white-space: pre-wrap;", "commid": "vscode_pr_221737"}], "negative_passages": []}
{"query_id": "q-en-vscode-60423e83be56488c703bd71c34d8e30f5cef00ec4234f02ec4b079e89f7afe5f", "query": "I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi\nI haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nYes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks", "positive_passages": [{"docid": "doc-en-vscode-36274fdfa3a2c10ba7918a20c584c09c496607c7e8f66dbf9dba58a480057d81", "text": "import { assertIsDefined } from 'vs/base/common/types'; import 'vs/css!./parameterHints'; import { ContentWidgetPositionPreference, ICodeEditor, IContentWidget, IContentWidgetPosition } from 'vs/editor/browser/editorBrowser'; <del> import { EditorOption } from 'vs/editor/common/config/editorOptions'; </del> <ins> import { EDITOR_FONT_DEFAULTS, EditorOption } from 'vs/editor/common/config/editorOptions'; </ins> import * as languages from 'vs/editor/common/languages'; import { ILanguageService } from 'vs/editor/common/languages/language'; import { IMarkdownRenderResult, MarkdownRenderer } from 'vs/editor/browser/widget/markdownRenderer/browser/markdownRenderer';", "commid": "vscode_pr_221737"}], "negative_passages": []}
{"query_id": "q-en-vscode-60423e83be56488c703bd71c34d8e30f5cef00ec4234f02ec4b079e89f7afe5f", "query": "I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi\nI haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nYes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks", "positive_passages": [{"docid": "doc-en-vscode-5e1e865d622bd3fd8019a1ea03b926e3e8bb40af66d69db70cc3716f490fcbcd", "text": "if (!this.domNodes) { return; } const fontInfo = this.editor.getOption(EditorOption.fontInfo); <del> this.domNodes.element.style.fontSize = `${fontInfo.fontSize}px`; this.domNodes.element.style.lineHeight = `${fontInfo.lineHeight / fontInfo.fontSize}`; </del> <ins> const element = this.domNodes.element; element.style.fontSize = `${fontInfo.fontSize}px`; element.style.lineHeight = `${fontInfo.lineHeight / fontInfo.fontSize}`; element.style.setProperty('--vscode-parameterHintsWidget-editorFontFamily', fontInfo.fontFamily); element.style.setProperty('--vscode-parameterHintsWidget-editorFontFamilyDefault', EDITOR_FONT_DEFAULTS.fontFamily); </ins> }; updateFont();", "commid": "vscode_pr_221737"}], "negative_passages": []}
{"query_id": "q-en-vscode-60423e83be56488c703bd71c34d8e30f5cef00ec4234f02ec4b079e89f7afe5f", "query": "I got the default font rendered in the parameter hint widget. It looks alien compared to the rest of the hover widget UI. Steps: chat sample line 21 type the following: will see the parameter hints with a weird font (default system?) ! fyi\nI haven't been able to reproduce this Are you still seeing this issue? Does it only show up with specific functions?\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!\nYes, I still see this. I see this for all parameter hovers. I have nailed this down to be due to this setting I got a new mac, so most likely I do not have Fira Code installed. So the Editor seems to fall back nicely to a good default font, and Parameter Hints falls back to a non coding font. Which looks like the gist of this bug. I will reopen this so you can chime in. Thanks", "positive_passages": [{"docid": "doc-en-vscode-2237ed03c16995bd666d2f3670f112cea7ce58e59eec0d1a6dfd63b14ce8aed0", "text": "} const code = dom.append(this.domNodes.signature, $('.code')); <del> const fontInfo = this.editor.getOption(EditorOption.fontInfo); code.style.fontSize = `${fontInfo.fontSize}px`; code.style.fontFamily = fontInfo.fontFamily; </del> const hasParameters = signature.parameters.length > 0; const activeParameterIndex = signature.activeParameter ?? hints.activeParameter;", "commid": "vscode_pr_221737"}], "negative_passages": []}
{"query_id": "q-en-vscode-d6305dbdac5bb11146f404bab10b4c3c6209dd2b96dba4b35069942b6d6f191b", "query": "Type: <bBug</bThe terminal in VSCode - insiders is unable to display special characters in terminals after latest update How it looks in VSCode: ! How it looks in VSCode - insiders ! The font settings are the exact same for both versions VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-03T05:49:15.006Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (40)</summaryExtensionVersion ------ better-comments3.0.2 TabOut0.2.2 Bookmarks13.5.0 doxdocgen1.4.0 githistory0.6.20 gitlens14.9.1 copilot1.184.0 copilot-chat0.14.1 latex-workshop9.20.1 rainbow-csv3.11.0 git-graph1.30.0 autopep82024.0.0 debugpy2024.4.0 isort2023.10.1 pylint2023.10.1 python2024.4.1 vscode-pylance2024.4.1 jupyter2024.4.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 tensorboard2023.10. vscode-jupyter-cell-tags0.1.9 vscode-jupyter-powertoys0.1.1 vscode-jupyter-slideshow0.1.6 remote-wsl0.88.2 cpptools1.20.3 cpptools-extension-pack1.3.0 hexeditor1.10.0 vsliveshare1.0.5918 autodocstring0.6.1 advanced-new-file1.2.2 material-icon-theme5.1.0 r-debugger0.5.4 r2.8.2 markdown-preview-enhanced0.8.13 errorlens3.17.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 markdown-all-in-one3.6.2 material-theme3.17.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\ncan you share your Also are you using Windows PowerShell () or pwsh 6+? Could you get the version of that via ?\nSame issue for us using bash 5.0.17(1) so might not be pwsh dependent. Terminal prompt now not showing special characters on latest insiders update 1.90.0 e.g. x1b[01x3b34m~/code/project1x1b[00m (main))\nactually got a fix in for bash in\nWhere can i get the The powershell version is: 7.4.2\nI have the same exact problem, and the following suggestion finally fixed it on my end:\nI am not sure I understand what the comment is trying to say. I am supposed to replace my with the one from commit and \nI agree, the instructions could have been clearer. The commit selection does seem a bit random, but what I did was clicking 'Browse files' on the commit and found the from that repository version. Here's a link to get there directly: \nIt was pushed to the official build. I'm having this issue and I dont rememeber ever joining any kind of insider program.\nRelated on Stack Overflow:\nthank you so much! This was what fixed it for me after trying everything yesterday. Some more clarity or directions from the dev side would have been nice, but now its back to normal after all!\nThanks replacing the shellintegration.ps1 from this commit fixed it for me. The location of the file is:\nIn addition to the semi-permanent solution above, I have found that you can simply type (for PowerShell 7) or (for PowerShell 5) in the terminal, and it will launch a brand new, yet identical terminal in the current working directory - but without the gibberish.\nFYI, I see this in the regular code branch Version: 1.90.0 (user setup) Commit: Date: 2024-06-04T19:33:54.889Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. !\nTo verify: oh-my-posh a PowerShell terminal oh-my-posh, you should not see the escapes as shown above\nSame issue here. oh-my-posh, powershell, issue only with vscode, windows term looks as intended. !\nThis should be fixed in v1.90.2 which was just released\nCan confirm as fixed. Thanks for the work!\nconfirm as fixed and work well without needing to disable setting! !\nLooks good again!\nLooks good to me too!!\nThis morning, I updated my VS Code, activated the setting, but I am still experiencing the same issue (especially when I try to clear the terminal with CTRL+L). I am using Windows 10 Pro for Workstations x64, AMD Ryzen 5 5600X 6-Core Processor, and Nvidia 720 GPU. !\nStill same issue\nwhat shell/prompt is that?\nIt's the PowerShell from the Microsoft Store. Special characters appear when I press Ctrl + L to clear the terminal. I also have the same problem in Git Bash, but it happens when I execute a command. In both cases, I am using Oh My Posh. !\nI was also having a related? problem with PowerShell integration since the 1.90 release. The recent 1.90.2 update has changed the outcome a little, but not fixed it. I get output like the below when I open a new pwsh terminal, and often the terminal stops responding after executing a command or two. I have this PowerShell profile. I thought any of PSFzf, zoxide, or the encoding settings could be the culprit, so I tried removing each one. Oddly, removing any combination of them doesn't fix the problem, but completely blanking out the file fixes it (second image below). It all worked fine in vscode prior to 1.90. ! !\nyou have the experimental suggest setting enabled, disabling that will fix it. What version of PowerShell is that you're using? Currently in Insiders we force suggest to be disabled on Windows PowerShell (5), but if you're experiencing it in a latter version maybe we need to disable it in older versions of Windows too.\nAre you referring to a different setting? (I was wrong; see below.) (Not sure if it's relevant, but PowerShell suggestions do work in Windows Terminal.) ! !\nOOPS, I did have an old version of that setting in my , and removing it did indeed fix the problem. Thank you.\nIs there a separate issue tracking this behavior with ? I do not use OhMyPosh and am still getting the same behavior with VSCode . ! The workaround of invoking from within the VSCode terminal does work.", "positive_passages": [{"docid": "doc-en-vscode-aa2ec2755c1ecbda6d06e0c528ba2575d3315ebdc5fe4edba302d85f2427ac2c", "text": "function Global:__VSCode-Escape-Value([string]$value) { # NOTE: In PowerShell v6.1+, this can be written `$value -replace '\u2026', { \u2026 }` instead of `[regex]::Replace`. # Replace any non-alphanumeric characters. <del> [regex]::Replace($value, \"[$([char]0x1b)n;]\", { param($match) </del> <ins> [regex]::Replace($value, \"[$([char]0x00)-$([char]0x1f)n;]\", { param($match) </ins> # Encode the (ascii) matches as `x<hex>` -Join ( [System.Text.Encoding]::UTF8.GetBytes($match.Value) | ForEach-Object { 'x{0:x2}' -f $_ }", "commid": "vscode_pr_215452"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-28feaa5f2856eb735efa88c094d8a6cc318fc72a1ff277d3e9dac637090f33b7", "text": "this._scanDevelopedExtensions(language, extensionDevelopmentPath) ]); <del> return dedupExtensions(builtinExtensions, [...installedExtensions, ...workspaceInstalledExtensions], developedExtensions, this._logService); </del> <ins> return dedupExtensions(builtinExtensions, installedExtensions, workspaceInstalledExtensions, developedExtensions, this._logService); </ins> } private async _scanDevelopedExtensions(language: string, extensionDevelopmentPaths?: string[]): Promise<IExtensionDescription[]> {", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-bdf662e9828d41f212b53d8f2d8466fe81749e21dda6fadbb2e6775565e7ee4e", "text": "all.push(...await this.workbenchExtensionManagementService.getInstalledWorkspaceExtensions(true)); } <del> // dedup user and system extensions by giving priority to user extensions. </del> <ins> // dedup workspace, user and system extensions by giving priority to workspace first and then to user extension. </ins> const installed = groupByExtension(all, r => r.identifier).reduce((result, extensions) => { <del> const extension = extensions.length === 1 ? extensions[0] : extensions.find(e => e.type === ExtensionType.User) || extensions.find(e => e.type === ExtensionType.System); result.push(extension!); </del> <ins> if (extensions.length === 1) { result.push(extensions[0]); } else { let workspaceExtension: ILocalExtension | undefined, userExtension: ILocalExtension | undefined, systemExtension: ILocalExtension | undefined; for (const extension of extensions) { if (extension.isWorkspaceScoped) { workspaceExtension = extension; } else if (extension.type === ExtensionType.User) { userExtension = extension; } else { systemExtension = extension; } } const extension = workspaceExtension ?? userExtension ?? systemExtension; if (extension) { result.push(extension); } } </ins> return result; }, []);", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-5f97b3168f93ddb309042b9e27e25b2d729193c445576b9f657c1e852ee5ec81", "text": "if (isUninstalled) { const canRemoveRunningExtension = runningExtension && this.extensionService.canRemoveExtension(runningExtension); <del> const isSameExtensionRunning = runningExtension && (!extension.server || extension.server === this.extensionManagementServerService.getExtensionManagementServer(toExtension(runningExtension))); </del> <ins> const isSameExtensionRunning = runningExtension && (!extension.server || extension.server === this.extensionManagementServerService.getExtensionManagementServer(toExtension(runningExtension))) && (!extension.resourceExtension || this.uriIdentityService.extUri.isEqual(extension.resourceExtension.location, runningExtension.extensionLocation)); </ins> if (!canRemoveRunningExtension && isSameExtensionRunning && !runningExtension.isUnderDevelopment) { return { action: reloadAction, reason: nls.localize('postUninstallTooltip', \"Please {0} to complete the uninstallation of this extension.\", reloadActionLabel) }; }", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-70e0baa0cc2b081e10c3d12dca206f57f8727df73c940ba7984bf74aecbf86d4", "text": "} catch (error) { this._logService.error(error); } <del> return dedupExtensions(system, user, development, this._logService); </del> <ins> return dedupExtensions(system, user, [], development, this._logService); </ins> } protected async _resolveExtensionsDefault() {", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-48161b0a87db917879e03853a23466f6f0b6fabca4c44d6cf76b4ecaa6fd7a1d", "text": "import * as semver from 'vs/base/common/semver/semver'; // TODO: @sandy081 merge this with deduping in extensionsScannerService.ts <del> export function dedupExtensions(system: IExtensionDescription[], user: IExtensionDescription[], development: IExtensionDescription[], logService: ILogService): IExtensionDescription[] { </del> <ins> export function dedupExtensions(system: IExtensionDescription[], user: IExtensionDescription[], workspace: IExtensionDescription[], development: IExtensionDescription[], logService: ILogService): IExtensionDescription[] { </ins> const result = new ExtensionIdentifierMap<IExtensionDescription>(); system.forEach((systemExtension) => { const extension = result.get(systemExtension.identifier);", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-a98268eddac17eaa891719ab04a17e23b89dd7fde69aa04218278f30213f06b0", "text": "} result.set(userExtension.identifier, userExtension); }); <ins> workspace.forEach(workspaceExtension => { const extension = result.get(workspaceExtension.identifier); if (extension) { logService.warn(localize('overwritingWithWorkspaceExtension', \"Overwriting {0} with Workspace Extension {1}.\", extension.extensionLocation.fsPath, workspaceExtension.extensionLocation.fsPath)); } result.set(workspaceExtension.identifier, workspaceExtension); }); </ins> development.forEach(developedExtension => { logService.info(localize('extensionUnderDevelopment', \"Loading development extension at {0}\", developedExtension.extensionLocation.fsPath)); const extension = result.get(developedExtension.identifier);", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-0b4b0c370edb18abb66d67bce6e09dfa4cbb0f7e1a194a675d909b86ef376007", "query": "This extension wants me to install it, also has a reload, and has a restart button. The restart button doesn't do anything. This is just in the VS Code repo <img width=\"476\" alt=\"image\" src=\"\"\nCan you please share the following file F1 Open Extensions Folder Share file\nWhat do you see in Installed Extensions view? Also What version of that extension is running in Running Extensions editor - F1 Show Running Extensions? Is there a message when you hover on Restart Extensions button?\nInstalled <img width=\"470\" alt=\"image\" src=\"\"Running view <img width=\"917\" alt=\"image\" src=\"\"Hover of restart <img width=\"470\" alt=\"image\" src=\"\"Ok, so it does appear I have this extension installed. And it wants me to restart it to uninstall it? And then to install it as a workspace extension? Clicking the restart button doesn't do anything and I didn't request the extension be uninstalled\nThis issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!", "positive_passages": [{"docid": "doc-en-vscode-acf691024cf6f98c45d8bf765b19333389ce511cca6772b89425e1c683eba412", "text": "} const system = scannedSystemExtensions.map(e => toExtensionDescriptionFromScannedExtension(e, false)); <del> const userGlobal = scannedUserExtensions.map(e => toExtensionDescriptionFromScannedExtension(e, false)); const userWorkspace = workspaceExtensions.map(e => toExtensionDescription(e, false)); </del> <ins> const user = scannedUserExtensions.map(e => toExtensionDescriptionFromScannedExtension(e, false)); const workspace = workspaceExtensions.map(e => toExtensionDescription(e, false)); </ins> const development = scannedDevelopedExtensions.map(e => toExtensionDescriptionFromScannedExtension(e, true)); <del> const r = dedupExtensions(system, [...userGlobal, ...userWorkspace], development, this._logService); </del> <ins> const r = dedupExtensions(system, user, workspace, development, this._logService); </ins> if (!hasErrors) { const disposable = this._extensionsScannerService.onDidChangeCache(() => {", "commid": "vscode_pr_213801"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-a31f2fa3cf2b3db7db98846e62bb2b5df16730c2d3e798d23e9634248f247a00", "text": "class MenuInfoSnapshot { protected _menuGroups: MenuItemGroup[] = []; <ins> private _allMenuIds: Set<MenuId> = new Set(); </ins> private _structureContextKeys: Set<string> = new Set(); private _preconditionContextKeys: Set<string> = new Set(); private _toggledContextKeys: Set<string> = new Set();", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-67d295337ae555ba352881fcd00949dfd3ff3d7ddbca56a3f34c656f86db6af5", "text": "protected readonly _collectContextKeysForSubmenus: boolean, ) { this.refresh(); <ins> this._allMenuIds.add(_id); } get allMenuIds(): ReadonlySet<MenuId> { return this._allMenuIds; </ins> } get structureContextKeys(): ReadonlySet<string> {", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-6e4d86950ba79cafd097e23284108cac1cb22869843ad3dfb5bab75d3e663aaa", "text": "// reset this._menuGroups.length = 0; <ins> this._allMenuIds.clear(); </ins> this._structureContextKeys.clear(); this._preconditionContextKeys.clear(); this._toggledContextKeys.clear();", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-f8010690adbc8b754ccf78afa75295f30e26757836d383ef57d1e36bd7a15f1e", "text": "} group[1].push(item); <del> // keep keys for eventing this._collectContextKeys(item); </del> <ins> // keep keys and submenu ids for eventing this._collectContextKeysAndSubmenuIds(item); </ins> } }", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-8b56a7c98a3fab0ed4750a1830ffd087957e2c4db6717965037ffdef6f03f0dc", "text": "return menuItems; } <del> private _collectContextKeys(item: IMenuItem | ISubmenuItem): void { </del> <ins> private _collectContextKeysAndSubmenuIds(item: IMenuItem | ISubmenuItem): void { </ins> MenuInfoSnapshot._fillInKbExprKeys(item.when, this._structureContextKeys);", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-e92b8b8fd92187d8f37a1a70681667523f6dfcb874f3de6f1791f489e699fbc3", "text": "} else if (this._collectContextKeysForSubmenus) { // recursively collect context keys from submenus so that this // menu fires events when context key changes affect submenus <del> MenuRegistry.getMenuItems(item.submenu).forEach(this._collectContextKeys, this); </del> <ins> MenuRegistry.getMenuItems(item.submenu).forEach(this._collectContextKeysAndSubmenuIds, this); this._allMenuIds.add(item.submenu); </ins> } }", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-34653015ac83502049a1315f79dfd2bb91a8a1ea7b985075069e81894f34273e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: macOS Sonoma 14.1.2 arm64 This issue coming from Cc Flutter extension from marketplace /Create Flutter project in Vscode the app by clicking the run button inside the IDE until the app is running on platform (eg emulators) ## Expected behavior Hot reload button will appear :zap: <img width=\"405\" alt=\"Screenshot 2024-05-07 at 12 09 20 PM\" src=\"\"Hot reload button doesn't appear <img width=\"537\" alt=\"Screenshot 2024-05-07 at 12 06 06 PM\" src=\"\"Toggle brings back the Hot Reload Button\nHey are you able to repro this? I set up a test extension that contributes a command the same way that the Dart extension does, and it works fine for me. I can try in the Dart extension too, but I'm wondering whether it's a fluke for this user or something that happens regularly.\nAh nevermind, I guess I do have a repro using js-debug\nHey I can't figure out how this is supposed to work in the command center. It seems that we don't listen to updates of the debug submenu inside the command center. Easy repro steps Put debug toolbar in the CC Start debugging something with node Run \"Take Performance Profile\" The red button to stop profiling doesn't appear in the debug toolbar unless I do something like move it\nWeird, we should receive events and redraw the menu because of the -flag.\nDebugged this for awhile, and I don't know how it's supposed to work, but it basically doesn't load the context keys for extension-contributed menu items because nothing is prompting the CommandCenter menu to reload context keys for submenu items after the menu extension contrib point is handled. create a Menu for CommandCenter, and it has a MenuInfo: picks up the context keys for whatever exists at that moment, and we don't have the extension menu items yet we process the menus extension point and add those items to the MenuRegistry for the DebugToolbar But at this point, something needs to bubble this up to the CommandCenter. It doesn't know that its submenus are changing. The Menu should fire onDidChange at that moment, and I don't see how that would happen. And, the CommandCenter Menu should call somewhere in there. Something is definitely missing. I didn't debug the normal submenu case but I'm guessing the inlined rendering of CommandCenter's submenus is related somehow, I assume in a normal case the context keys for submenus would get updated in some other way. Maybe when you're back we can jump on a call and I can show you what I'm seeing.", "positive_passages": [{"docid": "doc-en-vscode-474a87df4f57e30c6b0e0cc842e99ac6fa27da4e3a61922999d7e4a539e7a95d", "text": "}, options.eventDebounceDelay); this._disposables.add(rebuildMenuSoon); this._disposables.add(MenuRegistry.onDidChangeMenu(e => { <del> if (e.has(id)) { rebuildMenuSoon.schedule(); </del> <ins> for (const id of this._menuInfo.allMenuIds) { if (e.has(id)) { rebuildMenuSoon.schedule(); break; } </ins> } }));", "commid": "vscode_pr_225624"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-0e1fbccbbed5c2bc8308c3401492e24a28962613128d16a61f360e90c88d6ca0", "text": "\"sourceMap\": false, \"allowJs\": true, \"resolveJsonModule\": true, <ins> \"isolatedModules\": true, </ins> \"outDir\": \"../out/vs\", \"types\": [ \"mocha\",", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-1a1597c0e488bc64b22baec800e8820dc035819ec0b1f12619651dc1e5216708", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> declare const enum LoaderEventType { </del> <ins> declare enum LoaderEventType { </ins> LoaderAvailable = 1, BeginLoadingScript = 10,", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-ea8462f4958143dcf5e0b29a435e32d0fb6b31d834337c0f7e9440e2d6d5f77f", "text": "import { CommandOptions, ForkOptions, Source, SuccessData, TerminateResponse, TerminateResponseCode } from 'vs/base/common/processes'; import * as Types from 'vs/base/common/types'; import * as pfs from 'vs/base/node/pfs'; <del> export { CommandOptions, ForkOptions, SuccessData, Source, TerminateResponse, TerminateResponseCode }; </del> <ins> export { type CommandOptions, type ForkOptions, type SuccessData, Source, type TerminateResponse, TerminateResponseCode }; </ins> export type ValueCallback<T> = (value: T | Promise<T>) => void; export type ErrorCallback = (error?: any) => void;", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-8b39f324b6bdada3b1d4e7b1e932f7b4bada18cb856215108786c718b0e6e89c", "text": "import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { workbenchConfigurationNodeBase, Extensions as WorkbenchExtensions, IConfigurationMigrationRegistry, ConfigurationKeyValuePairs, ConfigurationMigration } from 'vs/workbench/common/configuration'; import { AccessibilitySignal } from 'vs/platform/accessibilitySignal/browser/accessibilitySignalService'; <del> import { ISpeechService, SPEECH_LANGUAGES, SPEECH_LANGUAGE_CONFIG } from 'vs/workbench/contrib/speech/common/speechService'; </del> <ins> import { AccessibilityVoiceSettingId, ISpeechService, SPEECH_LANGUAGES } from 'vs/workbench/contrib/speech/common/speechService'; </ins> import { Disposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Event } from 'vs/base/common/event';", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-928ce03302356416ab96e43dc94a0103e228974de628bc45846a8b1c6d0b609e", "text": "}); } <del> export const enum AccessibilityVoiceSettingId { SpeechTimeout = 'accessibility.voice.speechTimeout', AutoSynthesize = 'accessibility.voice.autoSynthesize', SpeechLanguage = SPEECH_LANGUAGE_CONFIG } </del> <ins> export { AccessibilityVoiceSettingId } </ins> export const SpeechTimeoutDefault = 1200; export class DynamicSpeechAccessibilityConfiguration extends Disposable implements IWorkbenchContribution {", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-35f2e170c22fa40ffe1282f62e8b8746da2e74299e15b87b807ece674be840e3", "text": "export const INLINE_CHAT_ID = 'interactiveEditor'; export const INTERACTIVE_EDITOR_ACCESSIBILITY_HELP_ID = 'interactiveEditorAccessiblityHelp'; <ins> export const enum EditMode { Live = 'live', Preview = 'preview' } </ins> export const CTX_INLINE_CHAT_HAS_PROVIDER = new RawContextKey<boolean>('inlineChatHasProvider', false, localize('inlineChatHasProvider', \"Whether a provider for interactive editors exists\")); export const CTX_INLINE_CHAT_VISIBLE = new RawContextKey<boolean>('inlineChatVisible', false, localize('inlineChatVisible', \"Whether the interactive editor input is visible\")); export const CTX_INLINE_CHAT_FOCUSED = new RawContextKey<boolean>('inlineChatFocused', false, localize('inlineChatFocused', \"Whether the interactive editor input is focused\"));", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-333a5b7c87789154a9e139312c6770ed03f5058b1cbb29708047127ceb123a48", "text": "// settings <del> export const enum EditMode { Live = 'live', Preview = 'preview' } </del> Registry.as<IConfigurationMigrationRegistry>(ExtensionsMigration.ConfigurationMigration).registerConfigurationMigrations( [{", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-76e34a586d1d061f3333629985570a5cb1d7393f96be88f12406c5c4e9c3fe81", "text": "recognizeKeyword(token: CancellationToken): Promise<KeywordRecognitionStatus>; } <del> export const SPEECH_LANGUAGE_CONFIG = 'accessibility.voice.speechLanguage'; </del> <ins> export const enum AccessibilityVoiceSettingId { SpeechTimeout = 'accessibility.voice.speechTimeout', AutoSynthesize = 'accessibility.voice.autoSynthesize', SpeechLanguage = 'accessibility.voice.speechLanguage', } export const SPEECH_LANGUAGE_CONFIG = AccessibilityVoiceSettingId.SpeechLanguage; </ins> export const SPEECH_LANGUAGES = { ['da-DK']: {", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-73d4e35c02a330b2e5dac712eda77630aabbbd8ddb1586684b687abd470df115", "query": "<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Related For migrating towards ESM in VSCode, it seems the tsconfig option could be useful, ensuring that imports are compatible with ESM. For example, this typescript code transpiled to javascript would cause a runtime error because of the export: The rule would enforce a type only import for : Enabling the tsconfig option in VSCode, it seems these files would need to adjusted:\nWe reverted this because we learnt, albeit very late, that it has disabled inlining of const enums. See", "positive_passages": [{"docid": "doc-en-vscode-29afb8326ecf402e257d02a8263465be8d33b4a1e1372365af46521098dedd8f", "text": "import { IStringDictionary } from 'vs/base/common/collections'; import { RawContextKey, ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; <del> export { ITaskSummary, Task, ITaskTerminateResponse as TaskTerminateResponse }; </del> <ins> export type { ITaskSummary, Task, ITaskTerminateResponse as TaskTerminateResponse }; </ins> export const CustomExecutionSupportedContext = new RawContextKey<boolean>('customExecutionSupported', false, nls.localize('tasks.customExecutionSupported', \"Whether CustomExecution tasks are supported. Consider using in the when clause of a 'taskDefinition' contribution.\")); export const ShellExecutionSupportedContext = new RawContextKey<boolean>('shellExecutionSupported', false, nls.localize('tasks.shellExecutionSupported', \"Whether ShellExecution tasks are supported. Consider using in the when clause of a 'taskDefinition' contribution.\"));", "commid": "vscode_pr_212913"}], "negative_passages": []}
{"query_id": "q-en-vscode-6813a974b05f1eeb892f0d06d8de86d228e913091f4794b77f8c67242cc72864", "query": "Personal preference - I do not like the border around the attached context. Does not align with the rest of the UI. Do we really need the border? Have we tried this without the border? ! fyi\nYeah, I've tried this because I don't love the weight it adds either. It does cause some weirdness when there are follow ups and lots of pills. But I'll keep playing with it to see if I can get to a place where we don't need it. !\nThank you David!", "positive_passages": [{"docid": "doc-en-vscode-66f749b1f88b34bed7415dc42f4d4301ed8882e528169ff6bc5e8e39d4bd0810", "text": "} .interactive-session .chat-attached-context { <del> padding: 8px 8px 13px; margin-right: -3px; margin-top: 4px; margin-bottom: -4px; border: 1px solid var(--vscode-input-border, var(--vscode-input-background, transparent)); border-radius: 6px 6px 0px 0px; </del> <ins> padding: 8px 0; border-radius: 6px; </ins> display: flex; gap: 4px; flex-wrap: wrap; } .interactive-session .chat-attached-context .chat-attached-context-attachment { <del> padding: 3px; border: 1px solid var(--vscode-input-border, var(--vscode-input-background, transparent)); </del> <ins> padding: 2px; border: 1px solid var(--vscode-chat-requestBorder, var(--vscode-input-background, transparent)); </ins> border-radius: 5px; <del> height: 20px; </del> <ins> height: 18px; </ins> } .interactive-session-followups {", "commid": "vscode_pr_212745"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b50d94adc5b62c5f9230ad6a43eb46ea5273c698acc22d3b3eda22bcb96e03a", "query": "Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39. cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nare you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:\nHappened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.\nI need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)", "positive_passages": [{"docid": "doc-en-vscode-b87fb3a86ffb2d3af3a94eb01aab0ec0d68cd7e59dedab9370f3018079879dd3", "text": "switch (state) { case VoiceChatSessionState.GettingReady: contextVoiceChatGettingReady.set(true); <del> contextVoiceChatInProgress.set(undefined); </del> <ins> contextVoiceChatInProgress.reset(); </ins> break; case VoiceChatSessionState.Started: <del> contextVoiceChatGettingReady.set(false); </del> <ins> contextVoiceChatGettingReady.reset(); </ins> contextVoiceChatInProgress.set(context); break; case VoiceChatSessionState.Stopped: <del> contextVoiceChatGettingReady.set(false); contextVoiceChatInProgress.set(undefined); </del> <ins> contextVoiceChatGettingReady.reset(); contextVoiceChatInProgress.reset(); </ins> break; } };", "commid": "vscode_pr_213049"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b50d94adc5b62c5f9230ad6a43eb46ea5273c698acc22d3b3eda22bcb96e03a", "query": "Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39. cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nare you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:\nHappened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.\nI need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)", "positive_passages": [{"docid": "doc-en-vscode-79a786d2d20c6785a96d6ae069f228a3da9687a2600187df6f4bb6a9aab60cbf", "text": "f1: true, keybinding: { weight: KeybindingWeight.WorkbenchContrib + 100, <del> primary: KeyCode.Escape </del> <ins> primary: KeyCode.Escape, when: AnyScopedVoiceChatInProgress </ins> }, icon: spinningLoading, precondition: GlobalVoiceChatInProgress, // need global context here because of `f1: true`", "commid": "vscode_pr_213049"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b50d94adc5b62c5f9230ad6a43eb46ea5273c698acc22d3b3eda22bcb96e03a", "query": "Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39. cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nare you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:\nHappened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.\nI need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)", "positive_passages": [{"docid": "doc-en-vscode-8f56d0edb476c91473cbe2c8a6e4785ece6a535f8bed70c4e9676a18d9b2a89c", "text": "disposables.add(controller.onDidHideChat(() => this.stop())); const scopedChatToSpeechInProgress = ScopedChatSynthesisInProgress.bindTo(controller.contextKeyService); <del> disposables.add(toDisposable(() => scopedChatToSpeechInProgress.set(false))); </del> <ins> disposables.add(toDisposable(() => scopedChatToSpeechInProgress.reset())); </ins> disposables.add(session.onDidChange(e => { switch (e.status) {", "commid": "vscode_pr_213049"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b50d94adc5b62c5f9230ad6a43eb46ea5273c698acc22d3b3eda22bcb96e03a", "query": "Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39. cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nare you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:\nHappened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.\nI need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)", "positive_passages": [{"docid": "doc-en-vscode-ff110e805419c2bac0d55375bb15969f55d7ec84892de12798be71bab8fa7622", "text": "scopedChatToSpeechInProgress.set(true); break; case TextToSpeechStatus.Stopped: <del> scopedChatToSpeechInProgress.set(false); </del> <ins> scopedChatToSpeechInProgress.reset(); </ins> break; } }));", "commid": "vscode_pr_213049"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b50d94adc5b62c5f9230ad6a43eb46ea5273c698acc22d3b3eda22bcb96e03a", "query": "Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39. cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nare you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:\nHappened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.\nI need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)", "positive_passages": [{"docid": "doc-en-vscode-e498145a17b09023bfd29450e5766175b5294d0f637504cac414e20555c277e3", "text": "keybinding: { weight: KeybindingWeight.WorkbenchContrib + 100, primary: KeyCode.Escape, <ins> when: ScopedChatSynthesisInProgress </ins> }, menu: [ {", "commid": "vscode_pr_213049"}], "negative_passages": []}
{"query_id": "q-en-vscode-1b50d94adc5b62c5f9230ad6a43eb46ea5273c698acc22d3b3eda22bcb96e03a", "query": "Type: <bBug</bI ccould not close inline chats or quick picks anymore. Looks like captured all esc shortcuts. I had used voice input during the session. VS Code version: Code - Insiders 1.90.0-insider (, 2024-05-17T17:53:51.447Z) OS version: Darwin x64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (64)</summaryExtensionVersion ------ html-snippets0.2.1 tsl-problem-matcher0.6.2 emojisense0.10.0 github-markdown-preview0.3.0 markdown-checkbox0.4.0 markdown-emoji0.3.0 markdown-footnotes0.1.1 markdown-mermaid1.23.0 markdown-preview-github-styles2.0.4 markdown-yaml-preamble0.1.0 mermaid-markdown-syntax-highlighting1.6.3 vscode-tailwindcss0.11.68 esbuild-problem-matchers0.0.3 vscode-eslint2.4.4 kusto0.4.4 EditorConfig0.16.4 prettier-vscode10.4.0 auto-close-tag0.5.15 auto-rename-tag0.1.10 codespaces1.16.22 copilot1.194.885 copilot-chat0.16. copilot-nes0.0.1 remotehub0.63. vscode-github-actions0.26.2 vscode-pull-request-github0.89. headwind1.7.0 debug-tracker-vscode0.0.15 peripheral-viewer1.4.6 vscode-azureresourcegroups0.9.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.5 debugpy2024.7. isort2023.13. python2024.7. vscode-pylance2024.5.101 jupyter2024.4. jupyter-keymap1.1.2 jupyter-renderers1.0.17 remote-containers0.366.0 remote-ssh0.112. remote-ssh-edit0.86.0 remote-wsl0.88.2 anycode0.0.73 azure-repos0.39. cpptools1.20.5 live-server0.4.13 remote-repositories0.40.0 remote-server1.6. vscode-github-issue-notebooks0.0.130 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.9. vscode-typescript-next5.5. prisma5.14.0 vscode-xml0.26.1 vscode-yaml1.14.0 kuskus-kusto-syntax-highlighting2.0.2 svg-preview2.8.3 pdf1.2.2 vscode-mdx1.8.5 volar2.0.10 gitblame10.11.0 markdown-all-in-one3.6.2 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --\nare you certain its that command? It is only enabled when a voice chat session is active. When you set the log level to trace, please check what is printed when you trigger in the chat widget:\nHappened again on a different machines. The main step of the STR seems to be using voice input (I mostly demo the hold down key usage) Both times I did troubleshooting and it pointed to the stop listening command.\nI need some steps to reproduce that you lead you to the issue and the precise location in the UI where this happens (globally anywhere or when you are in a chat input field?)", "positive_passages": [{"docid": "doc-en-vscode-ec9913e937cd11d1a6ffafc08f082208e80c286be798fa4b1b484a4dbf35d1af", "text": "enable: true }, ProgressLocation.Notification); } finally { <del> InstallingSpeechProvider.bindTo(contextKeyService).set(false); </del> <ins> InstallingSpeechProvider.bindTo(contextKeyService).reset(); </ins> } }", "commid": "vscode_pr_213049"}], "negative_passages": []}
{"query_id": "q-en-vscode-4cd351ef524827adf54c037f56382ff26166e337d50ced4f34d516f3db6bc62d", "query": "a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !", "positive_passages": [{"docid": "doc-en-vscode-b809ac73a59be249a65afe19e6b08e1c0919f328b3a2f0e95e761954174a7ff2", "text": "import { AccessibleViewType, AdvancedContentProvider, ExtensionContentProvider } from 'vs/platform/accessibility/browser/accessibleView'; import { ContextKeyExpression } from 'vs/platform/contextkey/common/contextkey'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; <ins> import { alert } from 'vs/base/browser/ui/aria/aria'; </ins> export interface IAccessibleViewImplentation { type: AccessibleViewType;", "commid": "vscode_pr_213097"}], "negative_passages": []}
{"query_id": "q-en-vscode-4cd351ef524827adf54c037f56382ff26166e337d50ced4f34d516f3db6bc62d", "query": "a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !", "positive_passages": [{"docid": "doc-en-vscode-157749104a20fcdfdd6d884c642c63b1fb0d932c08bf0576ecb6b12ebf3f9f20", "text": "inBlock = true; startLine = i + 1; languageId = line.substring(3).trim(); <del> } else if (inBlock && line.startsWith('```')) { </del> <ins> } else if (inBlock && line.endsWith('```')) { </ins> inBlock = false; const endLine = i; const code = lines.slice(startLine, endLine).join('n');", "commid": "vscode_pr_213097"}], "negative_passages": []}
{"query_id": "q-en-vscode-4cd351ef524827adf54c037f56382ff26166e337d50ced4f34d516f3db6bc62d", "query": "a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !", "positive_passages": [{"docid": "doc-en-vscode-76a3f93864d264f62ba649e59518fa72087ca6ccab24561ff817c01cf4e29288", "text": "menu: { ...accessibleViewMenu, <del> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewSupportsNavigation), </del> <ins> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewContainsCodeBlocks), </ins> }, title: localize('editor.action.accessibleViewNextCodeBlock', \"Accessible View: Next Code Block\") });", "commid": "vscode_pr_213097"}], "negative_passages": []}
{"query_id": "q-en-vscode-4cd351ef524827adf54c037f56382ff26166e337d50ced4f34d516f3db6bc62d", "query": "a chat request that yields no code blocks the response with the keyboard in screen reader mode left and right arrows are in toolbar !", "positive_passages": [{"docid": "doc-en-vscode-009d58127a12e830fb1a7a1f7198c0c1a79807faebc6713e93265ea09f2c7763", "text": "icon: Codicon.arrowLeft, menu: { ...accessibleViewMenu, <del> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewSupportsNavigation), </del> <ins> when: ContextKeyExpr.and(accessibleViewIsShown, accessibleViewContainsCodeBlocks), </ins> }, title: localize('editor.action.accessibleViewPreviousCodeBlock', \"Accessible View: Previous Code Block\") });", "commid": "vscode_pr_213097"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-1d83358d0b080a38ba63ee9d84879c3e9b1a19888bb025a74e4feacfd215606c", "text": "*--------------------------------------------------------------------------------------------*/ import * as DOM from '../../../../../../base/browser/dom.js'; <del> import { ICellViewModel } from '../../notebookBrowser.js'; </del> <ins> import { ICellViewModel, INotebookEditorDelegate } from '../../notebookBrowser.js'; </ins> import { CellContentPart } from '../cellPart.js'; export class CellDecorations extends CellContentPart { constructor( <ins> readonly notebookEditor: INotebookEditorDelegate, </ins> readonly rootContainer: HTMLElement, readonly decorationContainer: HTMLElement, ) {", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-c86e577376cff81681a88835ab2a5813c0090604df83c6d3efa4a420c2c9ecf5", "text": "})); generateCellTopDecorations(); <ins> this.registerDecorations(); } private registerDecorations() { if (!this.currentCell) { return; } this.cellDisposables.add(this.currentCell.onCellDecorationsChanged((e) => { e.added.forEach(options => { if (options.className && this.currentCell) { this.rootContainer.classList.add(options.className); this.notebookEditor.deltaCellContainerClassNames(this.currentCell.id, [options.className], []); } if (options.outputClassName && this.currentCell) { this.notebookEditor.deltaCellContainerClassNames(this.currentCell.id, [options.outputClassName], []); } }); e.removed.forEach(options => { if (options.className && this.currentCell) { this.rootContainer.classList.remove(options.className); this.notebookEditor.deltaCellContainerClassNames(this.currentCell.id, [], [options.className]); } if (options.outputClassName && this.currentCell) { this.notebookEditor.deltaCellContainerClassNames(this.currentCell.id, [], [options.outputClassName]); } }); })); this.currentCell.getCellDecorations().forEach(options => { if (options.className && this.currentCell) { this.rootContainer.classList.add(options.className); this.notebookEditor.deltaCellContainerClassNames(this.currentCell.id, [options.className], []); } if (options.outputClassName && this.currentCell) { this.notebookEditor.deltaCellContainerClassNames(this.currentCell.id, [options.outputClassName], []); } }); </ins> } }", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-2b3a6412859ba0cab4a4c0f4d43c60d1591577d6e5166724755e1705d95396a6", "text": "this.registerNotebookEditorListeners(); this.registerViewCellLayoutChange(); this.registerCellEditorEventListeners(); <del> this.registerDecorations(); </del> this.registerMouseListener(); this._register(Event.any(this.viewCell.onDidStartExecution, this.viewCell.onDidStopExecution)((e) => {", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-c13498a07887955c6ab8f123d7f104a890f9e96924480240bf6f74df46760bc6", "text": "})); } <del> private registerDecorations() { // Apply decorations this._register(this.viewCell.onCellDecorationsChanged((e) => { e.added.forEach(options => { if (options.className) { this.templateData.rootContainer.classList.add(options.className); } if (options.outputClassName) { this.notebookEditor.deltaCellContainerClassNames(this.viewCell.id, [options.outputClassName], []); } }); e.removed.forEach(options => { if (options.className) { this.templateData.rootContainer.classList.remove(options.className); } if (options.outputClassName) { this.notebookEditor.deltaCellContainerClassNames(this.viewCell.id, [], [options.outputClassName]); } }); })); this.viewCell.getCellDecorations().forEach(options => { if (options.className) { this.templateData.rootContainer.classList.add(options.className); } if (options.outputClassName) { this.notebookEditor.deltaCellContainerClassNames(this.viewCell.id, [options.outputClassName], []); } }); } </del> private registerMouseListener() { this._register(this.templateData.editor.onMouseDown(e => { // prevent default on right mouse click, otherwise it will trigger unexpected focus changes", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-2563176b73a975a00629fa9e545b8c280480a1bb655d15412f4366110ba7ee21", "text": "this.relayoutCell(); } <del> this.applyDecorations(); </del> this.viewUpdate(); this.layoutCellParts();", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-72e9d26e6ea0a0567e728b8f5893f54025f2168320a0751065b08c66a44e07bc", "text": "this.templateData.container.classList.toggle('cell-editor-focus', this.viewCell.focusMode === CellFocusMode.Editor); } <del> private applyDecorations() { // apply decorations this._register(this.viewCell.onCellDecorationsChanged((e) => { e.added.forEach(options => { if (options.className) { this.notebookEditor.deltaCellContainerClassNames(this.viewCell.id, [options.className], []); this.templateData.rootContainer.classList.add(options.className); } }); e.removed.forEach(options => { if (options.className) { this.notebookEditor.deltaCellContainerClassNames(this.viewCell.id, [], [options.className]); this.templateData.rootContainer.classList.remove(options.className); } }); })); this.viewCell.getCellDecorations().forEach(options => { if (options.className) { this.notebookEditor.deltaCellContainerClassNames(this.viewCell.id, [options.className], []); this.templateData.rootContainer.classList.add(options.className); } }); } </del> override dispose() { this._isDisposed = true;", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-a1864a60b2b4fe7958fce7054d6b74ab393a14a30b5cc5e34f488d3c07870d78", "text": "templateDisposables.add(scopedInstaService.createInstance(CellEditorStatusBar, this.notebookEditor, container, editorPart, undefined)), templateDisposables.add(new CellFocusIndicator(this.notebookEditor, titleToolbar, focusIndicatorTop, focusIndicatorLeft, focusIndicatorRight, focusIndicatorBottom)), templateDisposables.add(new FoldedCellHint(this.notebookEditor, DOM.append(container, $('.notebook-folded-hint')), this._notebookExecutionStateService)), <del> templateDisposables.add(new CellDecorations(rootContainer, decorationContainer)), </del> <ins> templateDisposables.add(new CellDecorations(this.notebookEditor, rootContainer, decorationContainer)), </ins> templateDisposables.add(scopedInstaService.createInstance(CellComments, this.notebookEditor, cellCommentPartContainer)), templateDisposables.add(new CollapsedCellInput(this.notebookEditor, cellInputCollapsedContainer)), templateDisposables.add(new CellFocusPart(container, undefined, this.notebookEditor)),", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-8f15b41c612e0b891d167d6872caf0347e51603463d2abc4d4bb5f9f30414b08", "query": "Testing I select a set of cells with Shift+Click, and I hit Ctrl+F to open the find widget. The cells are then highlighted as such: <img width=\"981\" alt=\"image\" src=\"\"I scroll down a full page length, and then scroll back up. The cells are now highlighted as such, with no click or type input on my part: <img width=\"980\" alt=\"image\" src=\"\"It appears that the Code cells lost their yellow highlight.", "positive_passages": [{"docid": "doc-en-vscode-578919f250d27bca6612c92d3ef004935f3097fb411c32f5f3e4074165d6bc91", "text": "templateDisposables.add(scopedInstaService.createInstance(CellChatPart, this.notebookEditor, cellChatPart)), templateDisposables.add(scopedInstaService.createInstance(CellEditorStatusBar, this.notebookEditor, container, editorPart, editor)), templateDisposables.add(scopedInstaService.createInstance(CellProgressBar, editorPart, cellInputCollapsedContainer)), <del> templateDisposables.add(new CellDecorations(rootContainer, decorationContainer)), </del> <ins> templateDisposables.add(new CellDecorations(this.notebookEditor, rootContainer, decorationContainer)), </ins> templateDisposables.add(scopedInstaService.createInstance(CellComments, this.notebookEditor, cellCommentPartContainer)), templateDisposables.add(scopedInstaService.createInstance(CellExecutionPart, this.notebookEditor, executionOrderLabel)), templateDisposables.add(scopedInstaService.createInstance(CollapsedCellOutput, this.notebookEditor, cellOutputCollapsedContainer)),", "commid": "vscode_pr_230177"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-e0f740a8821da58a80fe6a38b334bb6d490f0f62e7f16b2c5a63271dfac3dfc0", "text": "public visible: boolean = false; constructor( <del> readonly id: string, readonly name: string, </del> <ins> readonly id: string, readonly name: string, readonly resource: URI, </ins> protected readonly logger: ILogger, protected readonly proxy: MainThreadOutputServiceShape, readonly extension: IExtensionDescription,", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-97357e6470df583fdf40c8b2d849cfdc87e3ee70847e6ae6890b8a128a4f5a1e", "text": "const file = this.extHostFileSystemInfo.extUri.joinPath(outputDir, `${this.namePool++}-${name.replace(/[/:*?\"<>|]/g, '')}.log`); const logger = this.loggerService.createLogger(file, { logLevel: 'always', donotRotate: true, donotUseFormatters: true, hidden: true }); const id = await this.proxy.$register(name, file, languageId, extension.identifier.value); <del> return new ExtHostOutputChannel(id, name, logger, this.proxy, extension); </del> <ins> return new ExtHostOutputChannel(id, name, file, logger, this.proxy, extension); </ins> } private async doCreateLogOutputChannel(name: string, logLevel: LogLevel | undefined, extension: IExtensionDescription): Promise<ExtHostLogOutputChannel> {", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-a51e142b15659505bddfee89397d0d1abd0b1c57c597ddcb78e72e3f1a3b7bb6", "text": "const file = this.extHostFileSystemInfo.extUri.joinPath(extensionLogDir, `${fileName}.log`); const id = `${extension.identifier.value}.${fileName}`; const logger = this.loggerService.createLogger(file, { id, name, logLevel, extensionId: extension.identifier.value }); <del> return new ExtHostLogOutputChannel(id, name, logger, this.proxy, extension); </del> <ins> return new ExtHostLogOutputChannel(id, name, file, logger, this.proxy, extension); </ins> } private createExtensionLogDirectory(extension: IExtensionDescription): Thenable<URI> {", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-b550008d1ef75f694ad3e5f65175fa942233a7ed0de3af16b4ccfd98bd186314", "text": "throw new Error('Channel has been closed'); } }; <ins> const that = this; </ins> return { get name(): string { return name; }, append(value: string): void {", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-33938a84456817fe32ef4db47cff92c7b9d8f0961bc07898629a1e572af0075a", "text": "}, dispose(): void { disposed = true; <del> channelPromise.then(channel => channel.dispose()); </del> <ins> channelPromise.then(channel => { that.channels.delete(channel.id); that.loggerService.deregisterLogger(channel.resource); channel.dispose(); }); </ins> } }; }", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-3a93c58d878aa97c414ffc509cf77d0b7bea550a74655cebdcf0291c3db46504", "text": "onDidChangeLogLevel.fire(newLogLevel); } channelPromise.then(channel => { <del> disposables.add(channel); </del> if (channel.logLevel !== logLevel) { setLogLevel(channel.logLevel); } disposables.add(channel.onDidChangeLogLevel(e => setLogLevel(e))); }); <ins> const outputChannel = this.createExtHostOutputChannel(name, channelPromise); </ins> return { <del> ...this.createExtHostOutputChannel(name, channelPromise), </del> <ins> ...outputChannel, </ins> get logLevel() { return logLevel; }, onDidChangeLogLevel: onDidChangeLogLevel.event, trace(value: string, ...args: any[]): void {", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-152706d9665dca6843fc9b42ea1119e41090ed2ae167150b2bc1f98cfb2e7154", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.90.0-insider Commit: Date: 2024-05-31T01:05:41.342Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.90.0-insider Chrome/122.0.6261.156 Electron/29.4.0 Safari/537.36 Steps to Reproduce: There is no test-log-channel in the output panel.\nThanks for reporting this I have the exact same issue. In the meantime I have a workaround: I was surprised this does not throw, usually if you create something that was not previously disposed, it will throw an error like \"command was already registered\" or \"notebook controller already exists\". I am currently commenting out my line in my extension. It's not ideal though.\nPR fixing it", "positive_passages": [{"docid": "doc-en-vscode-870f284209f04d9f102d291df0b0dd2d00e25f32a3624a205ab16a7dd2d44c7c", "text": "}, dispose(): void { disposables.dispose(); <ins> outputChannel.dispose(); </ins> } }; }", "commid": "vscode_pr_225709"}], "negative_passages": []}
{"query_id": "q-en-vscode-9ec27be45c6eafb19b0393c40ccb61fdd34d2c4153338a50fcab734c694be597", "query": "Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.\nSee and for similar/duplicates.\nshould be fixed by\nThanks for the fix!", "positive_passages": [{"docid": "doc-en-vscode-bfc92911a5ff41051ee59a8d32703c6d229eb5b758fb0ffc52852b441c10f97e", "text": "public getEditOperations(model: ITextModel, builder: IEditOperationBuilder): void { <ins> const getLanguageId = () => { return model.getLanguageId(); }; const getLanguageIdAtPosition = (lineNumber: number, column: number) => { return model.getLanguageIdAtPosition(lineNumber, column); }; </ins> const modelLineCount = model.getLineCount(); if (this._isMovingDown && this._selection.endLineNumber === modelLineCount) {", "commid": "vscode_pr_214577"}], "negative_passages": []}
{"query_id": "q-en-vscode-9ec27be45c6eafb19b0393c40ccb61fdd34d2c4153338a50fcab734c694be597", "query": "Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.\nSee and for similar/duplicates.\nshould be fixed by\nThanks for the fix!", "positive_passages": [{"docid": "doc-en-vscode-9a74962cf0c0f876b5dca169787e7dab8bba8c5bc8649aada33159daa1bc13d0", "text": "const { tabSize, indentSize, insertSpaces } = model.getOptions(); const indentConverter = this.buildIndentConverter(tabSize, indentSize, insertSpaces); <del> const virtualModel: IVirtualModel = { tokenization: { getLineTokens: (lineNumber: number) => { return model.tokenization.getLineTokens(lineNumber); }, getLanguageId: () => { return model.getLanguageId(); }, getLanguageIdAtPosition: (lineNumber: number, column: number) => { return model.getLanguageIdAtPosition(lineNumber, column); }, }, getLineContent: null as unknown as (lineNumber: number) => string, }; </del> if (s.startLineNumber === s.endLineNumber && model.getLineMaxColumn(s.startLineNumber) === 1) { // Current line is empty", "commid": "vscode_pr_214577"}], "negative_passages": []}
{"query_id": "q-en-vscode-9ec27be45c6eafb19b0393c40ccb61fdd34d2c4153338a50fcab734c694be597", "query": "Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.\nSee and for similar/duplicates.\nshould be fixed by\nThanks for the fix!", "positive_passages": [{"docid": "doc-en-vscode-2fb39690cf65d2ecadc3966dc105f68f69090f1b854fa6dd39f62a4576a9e49a", "text": "insertingText = newIndentation + this.trimStart(movingLineText); } else { // no enter rule matches, let's check indentatin rules then. <del> virtualModel.getLineContent = (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.getLineContent(movingLineNumber); } else { return model.getLineContent(lineNumber); } </del> <ins> const virtualModel: IVirtualModel = { tokenization: { getLineTokens: (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.tokenization.getLineTokens(movingLineNumber); } else { return model.tokenization.getLineTokens(lineNumber); } }, getLanguageId, getLanguageIdAtPosition, }, getLineContent: (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.getLineContent(movingLineNumber); } else { return model.getLineContent(lineNumber); } }, </ins> }; const indentOfMovingLine = getGoodIndentForLine( this._autoIndent,", "commid": "vscode_pr_214577"}], "negative_passages": []}
{"query_id": "q-en-vscode-9ec27be45c6eafb19b0393c40ccb61fdd34d2c4153338a50fcab734c694be597", "query": "Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.\nSee and for similar/duplicates.\nshould be fixed by\nThanks for the fix!", "positive_passages": [{"docid": "doc-en-vscode-5b6dba97109038589b558b1e29a15746ab1a15b1fac8968dcc55b0fb33e57b79", "text": "} } else { // it doesn't match onEnter rules, let's check indentation rules then. <del> virtualModel.getLineContent = (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return insertingText; } else if (lineNumber >= s.startLineNumber + 1 && lineNumber <= s.endLineNumber + 1) { return model.getLineContent(lineNumber - 1); } else { return model.getLineContent(lineNumber); } </del> <ins> const virtualModel: IVirtualModel = { tokenization: { getLineTokens: (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return model.tokenization.getLineTokens(movingLineNumber); } else if (lineNumber >= s.startLineNumber + 1 && lineNumber <= s.endLineNumber + 1) { return model.tokenization.getLineTokens(lineNumber - 1); } else { return model.tokenization.getLineTokens(lineNumber); } }, getLanguageId, getLanguageIdAtPosition, }, getLineContent: (lineNumber: number) => { if (lineNumber === s.startLineNumber) { return insertingText; } else if (lineNumber >= s.startLineNumber + 1 && lineNumber <= s.endLineNumber + 1) { return model.getLineContent(lineNumber - 1); } else { return model.getLineContent(lineNumber); } }, </ins> }; const newIndentatOfMovingBlock = getGoodIndentForLine(", "commid": "vscode_pr_214577"}], "negative_passages": []}
{"query_id": "q-en-vscode-9ec27be45c6eafb19b0393c40ccb61fdd34d2c4153338a50fcab734c694be597", "query": "Have the following code Move line request down via Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.\nSee and for similar/duplicates.\nshould be fixed by\nThanks for the fix!", "positive_passages": [{"docid": "doc-en-vscode-a97e0d866d0bc54564c864aa796bb67010451dddea5ae7ba4618b735097e5134", "text": "builder.addEditOperation(new Range(s.endLineNumber, model.getLineMaxColumn(s.endLineNumber), s.endLineNumber, model.getLineMaxColumn(s.endLineNumber)), 'n' + movingLineText); if (this.shouldAutoIndent(model, s)) { <del> virtualModel.getLineContent = (lineNumber: number) => { if (lineNumber === movingLineNumber) { return model.getLineContent(s.startLineNumber); } else { return model.getLineContent(lineNumber); } </del> <ins> const virtualModel: IVirtualModel = { tokenization: { getLineTokens: (lineNumber: number) => { if (lineNumber === movingLineNumber) { return model.tokenization.getLineTokens(s.startLineNumber); } else { return model.tokenization.getLineTokens(lineNumber); } }, getLanguageId, getLanguageIdAtPosition, }, getLineContent: (lineNumber: number) => { if (lineNumber === movingLineNumber) { return model.getLineContent(s.startLineNumber); } else { return model.getLineContent(lineNumber); } }, </ins> }; const ret = this.matchEnterRule(model, indentConverter, tabSize, s.startLineNumber, s.startLineNumber - 2);", "commid": "vscode_pr_214577"}], "negative_passages": []}
{"query_id": "q-en-vscode-59f7159d969af40d87a736a2ed2afd8723eb3be98979441122c98b4ec426f327", "query": "Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nMakes sense cc\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nwould you, yourself, enable this? I worry about turning off regions.\nI don\u2019t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).\nThat makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,\nYes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.\ndo you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.\nThat happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.\nI use a separate sound card for my screen reader.\nwhat are some verification steps for this issue?\nenable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response\nI am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.\nSorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.", "positive_passages": [{"docid": "doc-en-vscode-81e6cd8a097f8e51d18aa98c2735b5a0942f2f2a35872dd9ce85c5f54a627bed", "text": "'enumItemLabels': languagesSorted.map(key => languages[key].name) }, [AccessibilityVoiceSettingId.AutoSynthesize]: { <del> 'type': 'boolean', </del> <ins> 'type': 'string', 'enum': ['on', 'off', 'auto'], 'enumDescriptions': [ localize('accessibility.voice.autoSynthesize.on', \"Enable the feature. When a screen reader is enabled, note that this will disable aria updates.\"), localize('accessibility.voice.autoSynthesize.off', \"Disable the feature.\"), localize('accessibility.voice.autoSynthesize.auto', \"When a screen reader is detected, disable the feature. Otherwise, enable the feature.\") ], </ins> 'markdownDescription': localize('autoSynthesize', \"Whether a textual response should automatically be read out aloud when speech was used as input. For example in a chat session, a response is automatically synthesized when voice was used as chat request.\"), <del> 'default': this.productService.quality !== 'stable', // TODO@bpasero decide on a default </del> <ins> 'default': this.productService.quality !== 'stable' ? 'auto' : 'off', // TODO@bpasero decide on a default </ins> 'tags': ['accessibility'] } }", "commid": "vscode_pr_224958"}], "negative_passages": []}
{"query_id": "q-en-vscode-59f7159d969af40d87a736a2ed2afd8723eb3be98979441122c98b4ec426f327", "query": "Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nMakes sense cc\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nwould you, yourself, enable this? I worry about turning off regions.\nI don\u2019t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).\nThat makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,\nYes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.\ndo you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.\nThat happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.\nI use a separate sound card for my screen reader.\nwhat are some verification steps for this issue?\nenable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response\nI am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.\nSorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.", "positive_passages": [{"docid": "doc-en-vscode-2edf4b29ea81fc4a810c2341584a616e926d703e4b09134f8180cad02158c837", "text": "Registry.as<IConfigurationMigrationRegistry>(WorkbenchExtensions.ConfigurationMigration) .registerConfigurationMigrations([{ <ins> key: AccessibilityVoiceSettingId.AutoSynthesize, migrateFn: (value: boolean) => { let newValue: string | undefined; if (value === true) { newValue = 'on'; } else if (value === false) { newValue = 'off'; } return [ [AccessibilityVoiceSettingId.AutoSynthesize, { value: newValue }], ]; } }]); Registry.as<IConfigurationMigrationRegistry>(WorkbenchExtensions.ConfigurationMigration) .registerConfigurationMigrations([{ </ins> key: 'accessibility.signals.chatResponsePending', migrateFn: (value, accessor) => { return [", "commid": "vscode_pr_224958"}], "negative_passages": []}
{"query_id": "q-en-vscode-59f7159d969af40d87a736a2ed2afd8723eb3be98979441122c98b4ec426f327", "query": "Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nMakes sense cc\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nwould you, yourself, enable this? I worry about turning off regions.\nI don\u2019t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).\nThat makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,\nYes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.\ndo you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.\nThat happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.\nI use a separate sound card for my screen reader.\nwhat are some verification steps for this issue?\nenable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response\nI am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.\nSorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.", "positive_passages": [{"docid": "doc-en-vscode-5b9f88bd22879d96de3dea71d56ad6439169314015d6dafbcf99b1e0e7c2b191", "text": "import { IChatResponseViewModel } from 'vs/workbench/contrib/chat/common/chatViewModel'; import { renderStringAsPlaintext } from 'vs/base/browser/markdownRenderer'; import { MarkdownString } from 'vs/base/common/htmlContent'; <ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { AccessibilityVoiceSettingId } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </ins> const CHAT_RESPONSE_PENDING_ALLOWANCE_MS = 4000; export class ChatAccessibilityService extends Disposable implements IChatAccessibilityService {", "commid": "vscode_pr_224958"}], "negative_passages": []}
{"query_id": "q-en-vscode-59f7159d969af40d87a736a2ed2afd8723eb3be98979441122c98b4ec426f327", "query": "Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nMakes sense cc\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nwould you, yourself, enable this? I worry about turning off regions.\nI don\u2019t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).\nThat makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,\nYes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.\ndo you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.\nThat happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.\nI use a separate sound card for my screen reader.\nwhat are some verification steps for this issue?\nenable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response\nI am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.\nSorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.", "positive_passages": [{"docid": "doc-en-vscode-88e5885f7a2b6511022c6fed66e58b581028a39dc97b10c22726847153c0f368", "text": "private _requestId: number = 0; <del> constructor(@IAccessibilitySignalService private readonly _accessibilitySignalService: IAccessibilitySignalService, @IInstantiationService private readonly _instantiationService: IInstantiationService) { </del> <ins> constructor( @IAccessibilitySignalService private readonly _accessibilitySignalService: IAccessibilitySignalService, @IInstantiationService private readonly _instantiationService: IInstantiationService, @IConfigurationService private readonly _configurationService: IConfigurationService ) { </ins> super(); } acceptRequest(): number {", "commid": "vscode_pr_224958"}], "negative_passages": []}
{"query_id": "q-en-vscode-59f7159d969af40d87a736a2ed2afd8723eb3be98979441122c98b4ec426f327", "query": "Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nMakes sense cc\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nwould you, yourself, enable this? I worry about turning off regions.\nI don\u2019t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).\nThat makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,\nYes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.\ndo you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.\nThat happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.\nI use a separate sound card for my screen reader.\nwhat are some verification steps for this issue?\nenable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response\nI am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.\nSorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.", "positive_passages": [{"docid": "doc-en-vscode-bde1951d6d35d65e575e2004a89fc814892b05161c85b07580a21c6ea435cf55", "text": "} const errorDetails = isPanelChat && response.errorDetails ? ` ${response.errorDetails.message}` : ''; const plainTextResponse = renderStringAsPlaintext(new MarkdownString(responseContent)); <del> status(plainTextResponse + errorDetails); </del> <ins> if (this._configurationService.getValue(AccessibilityVoiceSettingId.AutoSynthesize) !== 'on') { status(plainTextResponse + errorDetails); } </ins> } }", "commid": "vscode_pr_224958"}], "negative_passages": []}
{"query_id": "q-en-vscode-59f7159d969af40d87a736a2ed2afd8723eb3be98979441122c98b4ec426f327", "query": "Type: <bFeature Request</bCC setting is ignored when accessibility mode is on. While screen reader's TTS can auto-announce Chat response, some users may want to use this new synthesizer. so, we may want to turn off aria-live when this setting is on. Another consideration is that some low-vision users, who don't necessarily use SR, have turned on the a11y mode and they still want to benefit from this auto-synthesize setting. VS Code version: Code - Insiders 1.91.0-insider (, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --\nMakes sense cc\n<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!\nwould you, yourself, enable this? I worry about turning off regions.\nI don\u2019t know whether I would turn this on permanently, but would like to try this out definitely to see if it gives me any new experience. I may be able to manage to listen to two different TTS simultaneously (one for Copilot; SR TTS for my own drive).\nThat makes sense. It would be great if you could try it out. You can do this now by using the action in the toolbar,\nYes, I have tried this, but this is a manual trigger which does not give me the same experience as the auto-read-aloud.\ndo you mute NVDA speech and use a braille device when you want to use voice input? or do you use a separate speaker/headphones? When testing this experience, the screen reader's speech is getting recorded by the mic and used as chat input for me unless I mute VoiceOver speech.\nThat happens when microphone is too sensitive. SR users need to mute their speech synthesizer or they need to use a different sound card or headset.\nI use a separate sound card for my screen reader.\nwhat are some verification steps for this issue?\nenable screen reader mode, adjust the setting to on, run a chat request, (make sure volume is up), hear the response\nI am still unsure what to test and what I should hear. I followed the steps and didn't hear the chat response. I only heard it when talking to chat in the first place.\nSorry - in order to hear the response, I forgot that you have to use voice input to the chat. So pls try that with screen reader mode enabled and that setting on.", "positive_passages": [{"docid": "doc-en-vscode-bc429f7faf4dbc58adac8feb3d2d54925f825cc52417c687cccf846bff881a4e", "text": "if (!response) { return; } <del> if ( !this.accessibilityService.isScreenReaderOptimized() && // do not auto synthesize when screen reader is active this.configurationService.getValue<boolean>(AccessibilityVoiceSettingId.AutoSynthesize) === true ) { </del> <ins> const autoSynthesize = this.configurationService.getValue<'on' | 'off' | 'auto'>(AccessibilityVoiceSettingId.AutoSynthesize); if (autoSynthesize === 'on' || autoSynthesize === 'auto' && !this.accessibilityService.isScreenReaderOptimized()) { </ins> let context: IVoiceChatSessionController | 'focused'; if (controller.context === 'inline') { // TODO@bpasero this is ugly, but the lightweight inline chat turns into", "commid": "vscode_pr_224958"}], "negative_passages": []}
{"query_id": "q-en-vscode-81a7b3d891e25531a500cbcb321379f831d522eb85b1cde200d4e3c40f9c5d76", "query": "When I use the command line code --install-extension {id} Cannot find the installed extension Vscode - userdata: $HOME /. Vscode/extensions/extensions. The json. This error only appears in version 1.90.0, but does not exist if you go back to version 1.89.0.\nThis only happened the first time, and it worked the second time I executed the command line to install the plugin. So did everyone else around\nAre you still seeing this issue? If so can you please provide steps to reproduce?\nMy plug-in is a private plug-in that updates through the code command. When I released the updated version of the plug-in, I used the code command to update it, and there would be an error the first time, and it would be successful the second time, which was stable. !\nTLDR: The issue happens when a version that was installed before is installed again I have pretty much the same scenario. A private extension that uses to update itself when a new version is available. This is the error that's logged: I do have an entry for my extension in the file though: I did some testing on a bare project to understand the failure mechanism. What I found out is that if a particular version of the extension is installed before (for example during my testing before I release the extension) then upgrading/downgrading to that version will fail. Using following steps I can reproduce this issue reliably: 1- Create a bare project: 2- Package the extension: 3- Increment the version number, and package again: 4- Install the first package: 5- Update to second package: So far everything is in order. The problem begins when we try to install any of those packages again: 6- Downgrade to first package: At this point the neither 0.0.1 nor 0.0.2 is shown as installed. So installing any of them will be successful. this explains why you're always getting the error on the first, but the second round is successful. 7- Install the first package again: 8- Update to second package again: Tested this with Windows and WSL Ubuntu. Happens only on WSL Ubuntu in my case.\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\nLooks like this is working now in the latest VS Code Insiders. Tried with WSL: And using the latest stable (which doesn't have the fix yet) I can repro the errors that describes.", "positive_passages": [{"docid": "doc-en-vscode-1a17b20d1893f83e03c8bd39c43f8483beeef13404fb5b535672b63df9c69394", "text": "throw new Error(nls.localize('restartCode', \"Please restart VS Code before reinstalling {0}.\", this.manifest.displayName || this.manifest.name)); } } <del> } else { // Remove the extension with same version if it is already uninstalled. // Installing a VSIX extension shall replace the existing extension always. const existingWithSameVersion = await this.unsetIfUninstalled(this.extensionKey); if (existingWithSameVersion) { try { await this.extensionsScanner.removeExtension(existingWithSameVersion, 'existing'); } catch (e) { throw new Error(nls.localize('restartCode', \"Please restart VS Code before reinstalling {0}.\", this.manifest.displayName || this.manifest.name)); } </del> <ins> } // Remove the extension with same version if it is already uninstalled. // Installing a VSIX extension shall replace the existing extension always. const existingWithSameVersion = await this.unsetIfUninstalled(this.extensionKey); if (existingWithSameVersion) { try { await this.extensionsScanner.removeExtension(existingWithSameVersion, 'existing'); } catch (e) { throw new Error(nls.localize('restartCode', \"Please restart VS Code before reinstalling {0}.\", this.manifest.displayName || this.manifest.name)); </ins> } }", "commid": "vscode_pr_216828"}], "negative_passages": []}
{"query_id": "q-en-vscode-b5e6bf8c1cfb1c5bc7da550b96891cadf6b6f4e48760a0934bd1fb2445f2effc", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.0 OS Version: Darwin arm64 23.5.0 (macOS Sonoma 14.5) Follow the section of the Then, in the the first step (after connecting to the container) is to run: Yarn install should complete successfully, and should run the app. We get the following error: <img width=\"803\" alt=\"yarn-install-failure\" src=\"\"According to the we're using . 20 is the current LTS, and 18 hasn't been in active support since October last year. We can use the node 20 version of the typescript dev container image: . For context: there was a compatibility issue with and node 20, as noted in the issue when we switched to the node 18 image: But it seems like this was resolved in : And we're on , so it should be fine\nI've linked a PR with a fix. As suggested the last time this issue popped up: a CI test for the dev container could be useful.", "positive_passages": [{"docid": "doc-en-vscode-e2d9e432d2ab4340239637b83f2b9e3341929cbf0aa5b5bc046ff5531f602be4", "text": "<del> FROM mcr.microsoft.com/devcontainers/typescript-node:18-bookworm </del> <ins> FROM mcr.microsoft.com/devcontainers/typescript-node:20-bookworm </ins> ADD install-vscode.sh /root/ RUN /root/install-vscode.sh", "commid": "vscode_pr_215434"}], "negative_passages": []}
{"query_id": "q-en-vscode-6505a73ae3352243af3eabd2c49ba0b015e6440a54c219b94203d74cfcba36d9", "query": "have a squiggle open inline chat for it the UI flickers when coming up\nI believe the is the same underlying cause as Drilling into this and it seems that setting follow up always triggers a layout with the \"old\" dimensions which isn't going fit. I believe that explains why the editor is looking so weirdly. It only gets very little height left IMO setting follow up should only trigger a content heigh change event so that the owner can issue a relayout but should not attempt to relayout with the existing dimensions. (maybe unless the number of follow up has changed in which case the content height didn't change...) <img width=\"1412\" alt=\"Screenshot 2024-06-18 at 16 47 47\" src=\"\"\ntried this is a notebook and it felt very jittery still (but in a regular file it was fine) should I create a new issue for this? Seems to be due to the inline fix dialog getting placed in one spot then immediately moved <img width=\"1273\" alt=\"Screenshot 2024-06-26 at 10 31 06 AM\" src=\"\"<img width=\"938\" alt=\"Screenshot 2024-06-26 at 10 31 01 AM\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-8308148dd8425b64ba1d1bb130a3704426a7cf6a5733ef622433e5a5c5a8bd80", "text": "if (items && items.length > 0) { this.followupsDisposables.add(this.instantiationService.createInstance<typeof ChatFollowups<IChatFollowup>, ChatFollowups<IChatFollowup>>(ChatFollowups, this.followupsContainer, items, this.location, undefined, followup => this._onDidAcceptFollowup.fire({ followup, response }))); } <ins> this._onDidChangeHeight.fire(); </ins> } get contentHeight(): number {", "commid": "vscode_pr_216506"}], "negative_passages": []}
{"query_id": "q-en-vscode-6505a73ae3352243af3eabd2c49ba0b015e6440a54c219b94203d74cfcba36d9", "query": "have a squiggle open inline chat for it the UI flickers when coming up\nI believe the is the same underlying cause as Drilling into this and it seems that setting follow up always triggers a layout with the \"old\" dimensions which isn't going fit. I believe that explains why the editor is looking so weirdly. It only gets very little height left IMO setting follow up should only trigger a content heigh change event so that the owner can issue a relayout but should not attempt to relayout with the existing dimensions. (maybe unless the number of follow up has changed in which case the content height didn't change...) <img width=\"1412\" alt=\"Screenshot 2024-06-18 at 16 47 47\" src=\"\"\ntried this is a notebook and it felt very jittery still (but in a regular file it was fine) should I create a new issue for this? Seems to be due to the inline fix dialog getting placed in one spot then immediately moved <img width=\"1273\" alt=\"Screenshot 2024-06-26 at 10 31 06 AM\" src=\"\"<img width=\"938\" alt=\"Screenshot 2024-06-26 at 10 31 01 AM\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-4649301b97e22cb04dab12bff36d55f765e25ab9a4a045cc165e92507a802c9e", "text": "this._store.add(this._widget); this._widget.render(this._inputContainer); this._widget.setModel(this._defaultChatModel, {}); <del> this._store.add(this._widget.inputEditor.onDidContentSizeChange(() => _editor.layoutContentWidget(this))); </del> <ins> this._store.add(this._widget.onDidChangeContentHeight(() => _editor.layoutContentWidget(this))); </ins> this._domNode.tabIndex = -1; this._domNode.className = 'inline-chat-content-widget interactive-session';", "commid": "vscode_pr_216506"}], "negative_passages": []}
{"query_id": "q-en-vscode-3827f05d231ae0d4132032e8528b92eefcc8109004cc4f4882d761ae97dce73e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.1 x64 OS Version: Ubuntu 24.04 (Updates 14 Jun 2024) I get the error on a fresh installation of Ubuntu 24.04 and VSCode 1.90.1 Everything works fine with VSCode version . Steps to Reproduce: latest version of Ubuntu 24.04. command. command.\nIn my case the issue occurred when doing , also on Ubuntu (20.04) and also on vscode 1.90.1 Here is a temp workaround to revert to vscode 1.89.1, if that's useful to anyone:\nHi Having same issue on remote VM Ubuntu 20.04 Install errors with Solved by using the flag", "positive_passages": [{"docid": "doc-en-vscode-1386dca9c6f63db62a17f17617fc52ae3dcb2786110813c4f51abbb183001e5f", "text": "disturl \"https://electronjs.org/headers\" target \"29.4.0\" <del> ms_build_id \"9593362\" </del> <ins> ms_build_id \"9728852\" </ins> runtime \"electron\" build_from_source \"true\"", "commid": "vscode_pr_216661"}], "negative_passages": []}
{"query_id": "q-en-vscode-3827f05d231ae0d4132032e8528b92eefcc8109004cc4f4882d761ae97dce73e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.1 x64 OS Version: Ubuntu 24.04 (Updates 14 Jun 2024) I get the error on a fresh installation of Ubuntu 24.04 and VSCode 1.90.1 Everything works fine with VSCode version . Steps to Reproduce: latest version of Ubuntu 24.04. command. command.\nIn my case the issue occurred when doing , also on Ubuntu (20.04) and also on vscode 1.90.1 Here is a temp workaround to revert to vscode 1.89.1, if that's useful to anyone:\nHi Having same issue on remote VM Ubuntu 20.04 Install errors with Solved by using the flag", "positive_passages": [{"docid": "doc-en-vscode-6c08daa9d042539e50840af151cdd8846ce9369a2a3cbbe925a9684887bb3cd7", "text": "{ \"name\": \"code-oss-dev\", \"version\": \"1.91.0\", <del> \"distro\": \"170beceb9849568b8f7159757bc3fc3964af1986\", </del> <ins> \"distro\": \"361fc45f5932b161db29080d5b19bc5afb9baae6\", </ins> \"author\": { \"name\": \"Microsoft Corporation\" },", "commid": "vscode_pr_216661"}], "negative_passages": []}
{"query_id": "q-en-vscode-3827f05d231ae0d4132032e8528b92eefcc8109004cc4f4882d761ae97dce73e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.1 x64 OS Version: Ubuntu 24.04 (Updates 14 Jun 2024) I get the error on a fresh installation of Ubuntu 24.04 and VSCode 1.90.1 Everything works fine with VSCode version . Steps to Reproduce: latest version of Ubuntu 24.04. command. command.\nIn my case the issue occurred when doing , also on Ubuntu (20.04) and also on vscode 1.90.1 Here is a temp workaround to revert to vscode 1.89.1, if that's useful to anyone:\nHi Having same issue on remote VM Ubuntu 20.04 Install errors with Solved by using the flag", "positive_passages": [{"docid": "doc-en-vscode-5305d7a1167035fba4c05f3910bd8e6a9c79e7670ac1c9d97906747b2a420093", "text": "wait_for_async_execs <del> exec \"$@\" \"--no-sandbox\" </del> <ins> exec \"$@\" </ins>", "commid": "vscode_pr_216661"}], "negative_passages": []}
{"query_id": "q-en-vscode-3827f05d231ae0d4132032e8528b92eefcc8109004cc4f4882d761ae97dce73e", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.90.1 x64 OS Version: Ubuntu 24.04 (Updates 14 Jun 2024) I get the error on a fresh installation of Ubuntu 24.04 and VSCode 1.90.1 Everything works fine with VSCode version . Steps to Reproduce: latest version of Ubuntu 24.04. command. command.\nIn my case the issue occurred when doing , also on Ubuntu (20.04) and also on vscode 1.90.1 Here is a temp workaround to revert to vscode 1.89.1, if that's useful to anyone:\nHi Having same issue on remote VM Ubuntu 20.04 Install errors with Solved by using the flag", "positive_passages": [{"docid": "doc-en-vscode-c0b9951132699e3aa0094718474436ea7b4ad5560f67e0ee66cad43b3528acf0", "text": "apps: @@NAME@@: <del> command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ </del> <ins> command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ --no-sandbox </ins> common-id: @@NAME@@.desktop url-handler: <del> command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ --open-url </del> <ins> command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ --open-url --no-sandbox </ins>", "commid": "vscode_pr_216661"}], "negative_passages": []}
{"query_id": "q-en-vscode-2bc803a9e1dcfb83a1f1bf8c937d63189b8ac2b5195642ca961ec81e46a38fcd", "query": "Seeing this logged about 100 times at startup. Let's avoid stuff like this in the log level", "positive_passages": [{"docid": "doc-en-vscode-77e13d2e4fa5fade2d733ca9ddb002da6f4b8a4e8713114526b4687515174fa5", "text": "} set statusBarCommands(statusBarCommands: vscode.Command[] | undefined) { <del> this.logService.info('ExtHostSourceControl#statusBarCommands', (statusBarCommands ?? []).map(c => c.command).join(', ')); </del> <ins> this.logService.trace('ExtHostSourceControl#statusBarCommands', (statusBarCommands ?? []).map(c => c.command).join(', ')); </ins> if (this._statusBarCommands && statusBarCommands && commandListEquals(this._statusBarCommands, statusBarCommands)) { <del> this.logService.info('ExtHostSourceControl#statusBarCommands are equal'); </del> <ins> this.logService.trace('ExtHostSourceControl#statusBarCommands are equal'); </ins> return; }", "commid": "vscode_pr_216784"}], "negative_passages": []}
{"query_id": "q-en-vscode-a276a82a2f6e0838e07c0e847aa5c14e0fe1cfa6d52a84f878b96cafadfae5e8", "query": "I think the editor used to preserve the vertical position of the line where the the cursor is in. It jumps now: ! Repro steps: Enable Code Lenses for TypeScript Navigate to a symbol in a file that has not been opened yet Notice that the editor reveals the symbol correctly, but without code lenses yet Notice that the editor jumps once code lenses appear Verification steps: Observe that the line the cursor is in does not jump anymore. If I don't misremember, there was a change made here recently?\nNo changes for code lens since long. Doesn't reproduce for me. Can yo consistently repro? Can you try without custom settings?\nThe current logic is to keep the first line in the viewport stable. A good improvement might be to keep the line where the cursor is stable (if it's in the viewport), but that is not what we have implemented. PR welcome.\nOh, somehow I didn't realizing the jumping then. Did you open this file before in the VS Code session? In the first frame of your screenrecording where shows, the code lens feature already reserved some (empty) space to prevent layout shifts (which I don't think the feature knows the first time the text model is opened): !\nBetween reloads the slots are persisted and optimistically shown for a couple of seconds so that the actual extension/provider can compute theirs (which is usually the same)\nI think there is something fishy going on with persisting the code lens cache ().\n<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .\n<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased\nClosing in favor of (which proposes one possible solution to this). To be honest though, I think is what caused my feeling of this happening much more often.", "positive_passages": [{"docid": "doc-en-vscode-96df99395cf2ee639ce243862ad62c6369731bf6f182be79d6bc2d6ef5b5bbe7", "text": "const visibleRanges = editor.getVisibleRanges(); if (visibleRanges.length > 0) { visiblePosition = visibleRanges[0].getStartPosition(); <ins> const cursorPos = editor.getPosition(); if (cursorPos) { const isVisible = visibleRanges.some(range => range.containsPosition(cursorPos)); if (isVisible) { // Keep cursor pos fixed if it is visible visiblePosition = cursorPos; } } </ins> const visiblePositionScrollTop = editor.getTopForPosition(visiblePosition.lineNumber, visiblePosition.column); visiblePositionScrollDelta = editor.getScrollTop() - visiblePositionScrollTop; }", "commid": "vscode_pr_221031"}], "negative_passages": []}
{"query_id": "q-en-vscode-3feab95bbed1b52331aa7739ac310dfbe7ee76cf7c9823ea86d95f681fe06723", "query": "Testing text buttons some code and ask \"What does this do?\" starts, and the \"ctrl+esc to stop\" button shows. . actually opens the Windows start menu and streaming continues. It seems like this is a default Windows shortcut.\nThis is the default keybinding (the one we use in all chat boxes) and it looks like we need something else on windows...\nThey have a whole keyboard button for that, why are they taking ctrl+esc too...\nGoing with alt+backspace. Would like ctrl+backspace, but you might start typing while the previous request is running, and still want to use ctrl+backspace to delete a word.\nWorks great!", "positive_passages": [{"docid": "doc-en-vscode-5e4dd4e6f1b02b37bac327ca8603792f8ce9892a85ca8fa04541c6279359912d", "text": "keybinding: { weight: KeybindingWeight.WorkbenchContrib, primary: KeyMod.CtrlCmd | KeyCode.Escape, <ins> win: { primary: KeyMod.Alt | KeyCode.Backspace }, </ins> } }); }", "commid": "vscode_pr_218647"}], "negative_passages": []}
{"query_id": "q-en-vscode-a9b16cfcb4b309d03fb94c388012bb4fc2401699b48372f295700b1be2d2eae1", "query": "Testing Hover in Chat View doesn't respect underline setting (expect to be underlined): !", "positive_passages": [{"docid": "doc-en-vscode-bbffda69a2b1c62421df43fd7237f8d3f0374d386e1482d417476287a2cf5dda", "text": "padding-right: 4px; } <ins> .monaco-hover .hover-row.status-bar .actions .action-container a { color: var(--vscode-textLink-foreground); text-decoration: var(--text-link-decoration); } </ins> .monaco-hover .markdown-hover .hover-contents .codicon { color: inherit; font-size: inherit;", "commid": "vscode_pr_218226"}], "negative_passages": []}
{"query_id": "q-en-vscode-a9b16cfcb4b309d03fb94c388012bb4fc2401699b48372f295700b1be2d2eae1", "query": "Testing Hover in Chat View doesn't respect underline setting (expect to be underlined): !", "positive_passages": [{"docid": "doc-en-vscode-c492f00e5ad1985c0decc12e97ac5d9cd61444b55382411808b9cec0c6b08cb6", "text": ".monaco-workbench .hover-language-status > .element .right .monaco-link { margin: auto 0; white-space: nowrap; <ins> text-decoration: var(--text-link-decoration); </ins> } .monaco-workbench .hover-language-status > .element .right .monaco-action-bar:not(:first-child) {", "commid": "vscode_pr_218226"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-57ce381c1b4f1db515c0ac564b67079894ac728bb3ceff328474b37ad90a14c5", "text": "this._viewsService.openView(Markers.MARKERS_VIEW_ID); } else if (task.command.presentation && (task.command.presentation.focus || task.command.presentation.reveal === RevealKind.Always)) { this._terminalService.setActiveInstance(terminal); <del> await this._terminalService.revealActiveTerminal(); </del> <ins> await this._terminalService.revealTerminal(terminal); </ins> if (task.command.presentation.focus) { <del> this._terminalService.focusActiveInstance(); </del> <ins> this._terminalService.focusInstance(terminal); </ins> } } this._activeTasks[task.getMapKey()].terminal = terminal;", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-7ee19c42f0dbb9269f1198d9db02bdf9be7d7e9aead1091b7b2c22ef11a1caaa", "text": "getReconnectedTerminals(reconnectionOwner: string): ITerminalInstance[] | undefined; getActiveOrCreateInstance(options?: { acceptsInput?: boolean }): Promise<ITerminalInstance>; <ins> revealTerminal(source: ITerminalInstance, preserveFocus?: boolean): Promise<void>; </ins> revealActiveTerminal(preserveFocus?: boolean): Promise<void>; moveToEditor(source: ITerminalInstance, group?: GroupIdentifier | SIDE_GROUP_TYPE | ACTIVE_GROUP_TYPE | AUX_WINDOW_GROUP_TYPE): void; moveIntoNewEditor(source: ITerminalInstance): void;", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-c521da915954447a84ad1dbbbb8767d52f86c5a29061a06fe1e7c578be1d1a43", "text": "setActiveInstance(instance: ITerminalInstance): void; /** <ins> * Reveal and focus the instance, regardless of its location. */ focusInstance(instance: ITerminalInstance): void; /** </ins> * Reveal and focus the active instance, regardless of its location. */ focusActiveInstance(): Promise<void>;", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-2a1b1822168796cce9747140084f8b5445be16f26fd966b385a8dce38b90bd24", "text": "this._onDidChangeActiveInstance.fire(this.activeInstance); } <ins> async focusInstance(instance: ITerminalInstance): Promise<void> { return instance.focusWhenReady(true); } </ins> async focusActiveInstance(): Promise<void> { return this.activeInstance?.focusWhenReady(true); }", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-9da05d7ad88187ac74609dde96cbfe61f21210458f4364ec3ec4001a948008b0", "text": "pane?.terminalTabbedView?.focusHover(); } <ins> async focusInstance(_: ITerminalInstance): Promise<void> { return this.showPanel(true); } </ins> async focusActiveInstance(): Promise<void> { return this.showPanel(true); }", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-5625206abb319ba7f4769a7324b5a6ef5dabc85011db6d4b74e60246c0eae61c", "text": "} } <ins> async focusInstance(instance: ITerminalInstance): Promise<void> { if (instance.target === TerminalLocation.Editor) { return this._terminalEditorService.focusInstance(instance); } return this._terminalGroupService.focusInstance(instance); } </ins> async focusActiveInstance(): Promise<void> { if (!this._activeInstance) { return; } <del> if (this._activeInstance.target === TerminalLocation.Editor) { return this._terminalEditorService.focusActiveInstance(); } return this._terminalGroupService.focusActiveInstance(); </del> <ins> return this.focusInstance(this._activeInstance); </ins> } async createContributedTerminalProfile(extensionIdentifier: string, id: string, options: ICreateContributedTerminalProfileOptions): Promise<void> {", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-953443979ad98703d1f6043b5f3cae25e0c7c4cb784add5a2d2a7a38052934a0", "text": "return instance; } <ins> async revealTerminal(source: ITerminalInstance, preserveFocus?: boolean): Promise<void> { if (source.target === TerminalLocation.Editor) { await this._terminalEditorService.revealActiveEditor(preserveFocus); } else { await this._terminalGroupService.showPanel(); } } </ins> async revealActiveTerminal(preserveFocus?: boolean): Promise<void> { const instance = this.activeInstance; if (!instance) { return; } <del> if (instance.target === TerminalLocation.Editor) { await this._terminalEditorService.revealActiveEditor(preserveFocus); } else { await this._terminalGroupService.showPanel(); } </del> <ins> await this.revealTerminal(instance, preserveFocus); </ins> } setEditable(instance: ITerminalInstance, data?: IEditableData | null): void {", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-1c6ea06faab134380cdf48949fbe97fed03bcde22a60d15a8122b669f2ff239e", "text": "getInputFromResource(resource: URI): TerminalEditorInput { throw new Error('Method not implemented.'); } setActiveInstance(instance: ITerminalInstance): void { throw new Error('Method not implemented.'); } focusActiveInstance(): Promise<void> { throw new Error('Method not implemented.'); } <ins> focusInstance(instance: ITerminalInstance): void { throw new Error('Method not implemented.'); } </ins> getInstanceFromResource(resource: URI | undefined): ITerminalInstance | undefined { throw new Error('Method not implemented.'); } focusFindWidget(): void { throw new Error('Method not implemented.'); } hideFindWidget(): void { throw new Error('Method not implemented.'); }", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-c5edf98a4ee83e5ec09b1c3096f0a254f83bfec67c801e0430bcfff3b9887259", "query": "Type: <bBug</bPreparation: create the following file: the terminals panel, create a new shell terminal it to the main editor area to make it a full-size terminal open an editor tab (any file will do, including Command-N) sure the panel is closed (press Command-J to close it if it is open) the above task (e.g. with Command-P, then type ) Expected: the panel opens and shows the running task Actual: the editor terminal is brought to the front, and the panel stays closed VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-11T05:03:58.450Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --\nIn this scenario, focus also fails.\nI can confirm that fixes the problem for me. Thanks!", "positive_passages": [{"docid": "doc-en-vscode-c6f3b623eb9ef8891fcb1905f169b538501dd289979a4969957a28d95b8d29bf", "text": "focusHover(): void { throw new Error('Method not implemented.'); } setActiveInstance(instance: ITerminalInstance): void { throw new Error('Method not implemented.'); } focusActiveInstance(): Promise<void> { throw new Error('Method not implemented.'); } <ins> focusInstance(instance: ITerminalInstance): void { throw new Error('Method not implemented.'); } </ins> getInstanceFromResource(resource: URI | undefined): ITerminalInstance | undefined { throw new Error('Method not implemented.'); } focusFindWidget(): void { throw new Error('Method not implemented.'); } hideFindWidget(): void { throw new Error('Method not implemented.'); }", "commid": "vscode_pr_221684"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f174507210d3776f23bfc41ba46a73d8043f5211e150016ed14be12aa1870d", "query": "Testing 1) select a cell 2) cmd+/ -cell commented 3) ESC 4) cmd+/ -nothing 5) arrow-up 6) Cmd+/ -nothing 7) Shift + arrow-up 8) Cmd+/ -two cells commented I don't really understand in which mode I'm in after step 3 and 5. I would expect Cmd+/ to work in those states.", "positive_passages": [{"docid": "doc-en-vscode-6281fdea632a51d8166ea2ab047afe38e4859c173ec52445c4d90fc83bc458a1", "text": "// no parsed args, try handle active editor const editor = getEditorFromArgsOrActivePane(accessor); if (editor) { <ins> const selectedCellRange: ICellRange[] = editor.getSelections().length === 0 ? [editor.getFocus()] : editor.getSelections(); </ins> telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', { id: this.desc.id, from: from }); return this.runWithContext(accessor, { ui: false, notebookEditor: editor, <del> selectedCells: cellRangeToViewCells(editor, editor.getSelections()) </del> <ins> selectedCells: cellRangeToViewCells(editor, selectedCellRange) </ins> }); } }", "commid": "vscode_pr_223794"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f174507210d3776f23bfc41ba46a73d8043f5211e150016ed14be12aa1870d", "query": "Testing 1) select a cell 2) cmd+/ -cell commented 3) ESC 4) cmd+/ -nothing 5) arrow-up 6) Cmd+/ -nothing 7) Shift + arrow-up 8) Cmd+/ -two cells commented I don't really understand in which mode I'm in after step 3 and 5. I would expect Cmd+/ to work in those states.", "positive_passages": [{"docid": "doc-en-vscode-52e8355c5e208c20009eee8ba2fe08c1f6f223b9ad814e95e87b5f22b3fd2db1", "text": "keybinding: { when: ContextKeyExpr.and( NOTEBOOK_EDITOR_FOCUSED, <del> NOTEBOOK_CELL_LIST_FOCUSED, ContextKeyExpr.not(InputFocusedContextKey), </del> NOTEBOOK_EDITOR_EDITABLE, <del> NOTEBOOK_CELL_EDITABLE </del> <ins> ContextKeyExpr.not(InputFocusedContextKey), </ins> ), primary: KeyMod.CtrlCmd | KeyCode.Slash, weight: KeybindingWeight.WorkbenchContrib", "commid": "vscode_pr_223794"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f174507210d3776f23bfc41ba46a73d8043f5211e150016ed14be12aa1870d", "query": "Testing 1) select a cell 2) cmd+/ -cell commented 3) ESC 4) cmd+/ -nothing 5) arrow-up 6) Cmd+/ -nothing 7) Shift + arrow-up 8) Cmd+/ -two cells commented I don't really understand in which mode I'm in after step 3 and 5. I would expect Cmd+/ to work in those states.", "positive_passages": [{"docid": "doc-en-vscode-91e4bc860b02df3b2c693a0742723a2150a9a4531ceeb14ef3d998d1fd7c78e2", "text": "} }); selectedCellEditors.forEach(editor => { if (!editor.hasModel()) { return;", "commid": "vscode_pr_223794"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f174507210d3776f23bfc41ba46a73d8043f5211e150016ed14be12aa1870d", "query": "Testing 1) select a cell 2) cmd+/ -cell commented 3) ESC 4) cmd+/ -nothing 5) arrow-up 6) Cmd+/ -nothing 7) Shift + arrow-up 8) Cmd+/ -two cells commented I don't really understand in which mode I'm in after step 3 and 5. I would expect Cmd+/ to work in those states.", "positive_passages": [{"docid": "doc-en-vscode-c1d681417a6b7d18f90dcdb343a18e9c95f21c1a6d556c70d66e7e5fd7e1a402", "text": "const modelOptions = model.getOptions(); const commentsOptions = editor.getOption(EditorOption.comments); <ins> const selection = editor.getSelection(); </ins> commands.push(new LineCommentCommand( languageConfigurationService, new Selection(1, 1, model.getLineCount(), model.getLineMaxColumn(model.getLineCount())),", "commid": "vscode_pr_223794"}], "negative_passages": []}
{"query_id": "q-en-vscode-21f174507210d3776f23bfc41ba46a73d8043f5211e150016ed14be12aa1870d", "query": "Testing 1) select a cell 2) cmd+/ -cell commented 3) ESC 4) cmd+/ -nothing 5) arrow-up 6) Cmd+/ -nothing 7) Shift + arrow-up 8) Cmd+/ -two cells commented I don't really understand in which mode I'm in after step 3 and 5. I would expect Cmd+/ to work in those states.", "positive_passages": [{"docid": "doc-en-vscode-ed281793472dca3e5061bae884b87dc1edb6ebf5f95e5dea317eb02de779d4be", "text": "editor.pushUndoStop(); editor.executeCommands(COMMENT_SELECTED_CELLS_ID, commands); editor.pushUndoStop(); <ins> editor.setSelection(selection); </ins> }); }", "commid": "vscode_pr_223794"}], "negative_passages": []}
{"query_id": "q-en-vscode-54a87bca7379c61bfc8cbde14450b9b744d3cfe71daba87073eceba63522d767", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.91.1 Commit: Date: 2024-07-09T22:06:49.809Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView with an TreeItem the TreeItem's iconPath to the extension. The TreeItem's icon will still be yellow same as in debugging. After inspecting developer tools, this is likely due to how the icon debug-stackframe's color rule is set to !important. The ThemeColor fails to overwrite it due to low specificity. This may not only happen with the icon \"debug-stackframe\" and is affecting customisations of treeitems. Why is some icons' color rules given the !important flag et al? There might not be any easy fix due to this flag's present. I hope the team could look into it, and if possible fix this selector specificity issue (if it won't break vscode, somehow).\nEdit: This not only occurs on special icons like debug-stackframe, but also on very ordinary ones like circle-filled. style attribute { color: rgb(204, 204, 204); } .monaco-workbench .codicon { } Adding !important to the color flag of .monaco-workbench .codicon will fix the issue though.. The problem is worse :C\nI think the best solution would be to get rid of that . it's coming from here. Can it be removed? The css you shared is correct. The rbg value is the one you set in your ThemeIcon. !\nYea, we should scope these rules better (and also move them to css now that we have variables there)\n<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased", "positive_passages": [{"docid": "doc-en-vscode-eb4b4cd3981d441848bcb6b48bcd555cf81a858b221c5170ad7116e03a82ff35", "text": "} registerThemingParticipant((theme, collector) => { <ins> const scope = '.monaco-editor .glyph-margin-widgets, .monaco-workbench .debug-breakpoints, .monaco-workbench .disassembly-view'; </ins> const debugIconBreakpointColor = theme.getColor(debugIconBreakpointForeground); if (debugIconBreakpointColor) { <del> collector.addRule(` ${icons.allBreakpoints.map(b => `.monaco-workbench ${ThemeIcon.asCSSSelector(b.regular)}`).join(',n\t\t')}, .monaco-workbench ${ThemeIcon.asCSSSelector(icons.debugBreakpointUnsupported)}, .monaco-workbench ${ThemeIcon.asCSSSelector(icons.debugBreakpointHint)}:not([class*='codicon-debug-breakpoint']):not([class*='codicon-debug-stackframe']), .monaco-workbench ${ThemeIcon.asCSSSelector(icons.breakpoint.regular)}${ThemeIcon.asCSSSelector(icons.debugStackframeFocused)}::after, .monaco-workbench ${ThemeIcon.asCSSSelector(icons.breakpoint.regular)}${ThemeIcon.asCSSSelector(icons.debugStackframe)}::after { color: ${debugIconBreakpointColor} !important; } `); </del> <ins> collector.addRule(`${scope} { ${icons.allBreakpoints.map(b => `${ThemeIcon.asCSSSelector(b.regular)}`).join(',n\t\t')}, ${ThemeIcon.asCSSSelector(icons.debugBreakpointUnsupported)}, ${ThemeIcon.asCSSSelector(icons.debugBreakpointHint)}:not([class*='codicon-debug-breakpoint']):not([class*='codicon-debug-stackframe']), ${ThemeIcon.asCSSSelector(icons.breakpoint.regular)}${ThemeIcon.asCSSSelector(icons.debugStackframeFocused)}::after, ${ThemeIcon.asCSSSelector(icons.breakpoint.regular)}${ThemeIcon.asCSSSelector(icons.debugStackframe)}::after { color: ${debugIconBreakpointColor} !important; } }`); </ins> <del> collector.addRule(` .monaco-workbench ${ThemeIcon.asCSSSelector(icons.breakpoint.pending)} { color: ${debugIconBreakpointColor} !important; font-size: 12px !important; } `); </del> <ins> collector.addRule(`${scope} { ${ThemeIcon.asCSSSelector(icons.breakpoint.pending)} { color: ${debugIconBreakpointColor} !important; font-size: 12px !important; } }`); </ins> } const debugIconBreakpointDisabledColor = theme.getColor(debugIconBreakpointDisabledForeground); if (debugIconBreakpointDisabledColor) { <del> collector.addRule(` ${icons.allBreakpoints.map(b => `.monaco-workbench ${ThemeIcon.asCSSSelector(b.disabled)}`).join(',n\t\t')} { color: ${debugIconBreakpointDisabledColor}; } `); </del> <ins> collector.addRule(`${scope} { ${icons.allBreakpoints.map(b => ThemeIcon.asCSSSelector(b.disabled)).join(',n\t\t')} { color: ${debugIconBreakpointDisabledColor}; } }`); </ins> } const debugIconBreakpointUnverifiedColor = theme.getColor(debugIconBreakpointUnverifiedForeground); if (debugIconBreakpointUnverifiedColor) { <del> collector.addRule(` ${icons.allBreakpoints.map(b => `.monaco-workbench ${ThemeIcon.asCSSSelector(b.unverified)}`).join(',n\t\t')} { color: ${debugIconBreakpointUnverifiedColor}; } `); </del> <ins> collector.addRule(`${scope} { ${icons.allBreakpoints.map(b => ThemeIcon.asCSSSelector(b.unverified)).join(',n\t\t')} { color: ${debugIconBreakpointUnverifiedColor}; } }`); </ins> } const debugIconBreakpointCurrentStackframeForegroundColor = theme.getColor(debugIconBreakpointCurrentStackframeForeground); if (debugIconBreakpointCurrentStackframeForegroundColor) { collector.addRule(` <del> .monaco-workbench ${ThemeIcon.asCSSSelector(icons.debugStackframe)}, </del> .monaco-editor .debug-top-stack-frame-column { color: ${debugIconBreakpointCurrentStackframeForegroundColor} !important; } <ins> ${scope} { ${ThemeIcon.asCSSSelector(icons.debugStackframe)} { color: ${debugIconBreakpointCurrentStackframeForegroundColor} !important; } } </ins> `); } const debugIconBreakpointStackframeFocusedColor = theme.getColor(debugIconBreakpointStackframeForeground); if (debugIconBreakpointStackframeFocusedColor) { <del> collector.addRule(` .monaco-workbench ${ThemeIcon.asCSSSelector(icons.debugStackframeFocused)} { color: ${debugIconBreakpointStackframeFocusedColor} !important; } `); </del> <ins> collector.addRule(`${scope} { ${ThemeIcon.asCSSSelector(icons.debugStackframeFocused)} { color: ${debugIconBreakpointStackframeFocusedColor} !important; } }`); </ins> } });", "commid": "vscode_pr_224417"}], "negative_passages": []}
{"query_id": "q-en-vscode-54a87bca7379c61bfc8cbde14450b9b744d3cfe71daba87073eceba63522d767", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.91.1 Commit: Date: 2024-07-09T22:06:49.809Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView with an TreeItem the TreeItem's iconPath to the extension. The TreeItem's icon will still be yellow same as in debugging. After inspecting developer tools, this is likely due to how the icon debug-stackframe's color rule is set to !important. The ThemeColor fails to overwrite it due to low specificity. This may not only happen with the icon \"debug-stackframe\" and is affecting customisations of treeitems. Why is some icons' color rules given the !important flag et al? There might not be any easy fix due to this flag's present. I hope the team could look into it, and if possible fix this selector specificity issue (if it won't break vscode, somehow).\nEdit: This not only occurs on special icons like debug-stackframe, but also on very ordinary ones like circle-filled. style attribute { color: rgb(204, 204, 204); } .monaco-workbench .codicon { } Adding !important to the color flag of .monaco-workbench .codicon will fix the issue though.. The problem is worse :C\nI think the best solution would be to get rid of that . it's coming from here. Can it be removed? The css you shared is correct. The rbg value is the one you set in your ThemeIcon. !\nYea, we should scope these rules better (and also move them to css now that we have variables there)\n<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased", "positive_passages": [{"docid": "doc-en-vscode-85675d72db396c770295750e02e8492987166a61a19820a9224c6705fbd4690f", "text": "} )) as WorkbenchTable<IDisassembledInstructionEntry>; <ins> this._disassembledInstructions.domNode.classList.add('disassembly-view'); </ins> if (this.focusedInstructionReference) { this.reloadDisassembly(this.focusedInstructionReference, 0); }", "commid": "vscode_pr_224417"}], "negative_passages": []}
{"query_id": "q-en-vscode-54a87bca7379c61bfc8cbde14450b9b744d3cfe71daba87073eceba63522d767", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.91.1 Commit: Date: 2024-07-09T22:06:49.809Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a TreeView with an TreeItem the TreeItem's iconPath to the extension. The TreeItem's icon will still be yellow same as in debugging. After inspecting developer tools, this is likely due to how the icon debug-stackframe's color rule is set to !important. The ThemeColor fails to overwrite it due to low specificity. This may not only happen with the icon \"debug-stackframe\" and is affecting customisations of treeitems. Why is some icons' color rules given the !important flag et al? There might not be any easy fix due to this flag's present. I hope the team could look into it, and if possible fix this selector specificity issue (if it won't break vscode, somehow).\nEdit: This not only occurs on special icons like debug-stackframe, but also on very ordinary ones like circle-filled. style attribute { color: rgb(204, 204, 204); } .monaco-workbench .codicon { } Adding !important to the color flag of .monaco-workbench .codicon will fix the issue though.. The problem is worse :C\nI think the best solution would be to get rid of that . it's coming from here. Can it be removed? The css you shared is correct. The rbg value is the one you set in your ThemeIcon. !\nYea, we should scope these rules better (and also move them to css now that we have variables there)\n<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased", "positive_passages": [{"docid": "doc-en-vscode-d2c403efb2c41c3888f53e8d779cd46bb2bfe6a8ef20f0a41744cebabc80544b", "text": "// align from the bottom so that it lines up with instruction when source code is present. container.style.alignSelf = 'flex-end'; <del> const icon = append(container, $('.disassembly-view')); icon.classList.add('codicon'); </del> <ins> const icon = append(container, $('.codicon')); </ins> icon.style.display = 'flex'; icon.style.alignItems = 'center'; icon.style.justifyContent = 'center';", "commid": "vscode_pr_224417"}], "negative_passages": []}
{"query_id": "q-en-vscode-dcbdd8e4c7391ac6ba53aea50af07a3b64d4f71112c04060bfbf1cb8f2244f7a", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.92.0 Commit: Date: 2024-07-31T23:26:45.634Z Electron: 30.1.2 ElectronBuildId: Chromium: 124.0.6367.243 20.14.0 V8: 12.4.254.20-electron.0 OS: Linux x64 6.9.3--generic Steps to Reproduce: theme to Light High Contrast a Javascript file final bracket is black, not red as in other themes\nI believe this may be the core cause: The value for hcLight here is just an empty string\nThanks for investigating, looks like this color got forgotten when creating the Light HC theme. I took the same color as used in the overview ruler", "positive_passages": [{"docid": "doc-en-vscode-96f3162e73e36169b992f7d56955a4b4e367cbf297456b31386056a334948c7b", "text": "export const editorBracketHighlightingForeground5 = registerColor('editorBracketHighlight.foreground5', '#00000000', nls.localize('editorBracketHighlightForeground5', 'Foreground color of brackets (5). Requires enabling bracket pair colorization.')); export const editorBracketHighlightingForeground6 = registerColor('editorBracketHighlight.foreground6', '#00000000', nls.localize('editorBracketHighlightForeground6', 'Foreground color of brackets (6). Requires enabling bracket pair colorization.')); <del> export const editorBracketHighlightingUnexpectedBracketForeground = registerColor('editorBracketHighlight.unexpectedBracket.foreground', { dark: new Color(new RGBA(255, 18, 18, 0.8)), light: new Color(new RGBA(255, 18, 18, 0.8)), hcDark: new Color(new RGBA(255, 50, 50, 1)), hcLight: '' }, nls.localize('editorBracketHighlightUnexpectedBracketForeground', 'Foreground color of unexpected brackets.')); </del> <ins> export const editorBracketHighlightingUnexpectedBracketForeground = registerColor('editorBracketHighlight.unexpectedBracket.foreground', { dark: new Color(new RGBA(255, 18, 18, 0.8)), light: new Color(new RGBA(255, 18, 18, 0.8)), hcDark: 'new Color(new RGBA(255, 50, 50, 1))', hcLight: '#B5200D' }, nls.localize('editorBracketHighlightUnexpectedBracketForeground', 'Foreground color of unexpected brackets.')); </ins> export const editorBracketPairGuideBackground1 = registerColor('editorBracketPairGuide.background1', '#00000000', nls.localize('editorBracketPairGuide.background1', 'Background color of inactive bracket pair guides (1). Requires enabling bracket pair guides.')); export const editorBracketPairGuideBackground2 = registerColor('editorBracketPairGuide.background2', '#00000000', nls.localize('editorBracketPairGuide.background2', 'Background color of inactive bracket pair guides (2). Requires enabling bracket pair guides.'));", "commid": "vscode_pr_225036"}], "negative_passages": []}
{"query_id": "q-en-vscode-bc64935df97369fe03c8aa593d8488e4dd290e079ba40ed9a98f4cb8ebca67d2", "query": "As reported by open notebook open nb from timeline close diff close notebook then I got Can repro from stable", "positive_passages": [{"docid": "doc-en-vscode-4d6a41b1e0902c0b99d9f047e8f9273d146af938e9742191bf9964516e97f96e", "text": "} override dispose() { <ins> // The editor isn't disposed yet, it can be re-used. // However the model can be disposed before the editor & that causes issues. if (this._editor) { this._editor.setModel(null); } </ins> if (this._editor && this._editorViewStateChanged) { this.cell.saveSpirceEditorViewState(this._editor.saveViewState()); }", "commid": "vscode_pr_226583"}], "negative_passages": []}
{"query_id": "q-en-vscode-314f9272723d20737bd1aa7c66611d7c7e5913239f8aebd695329b770f03140c", "query": "<img width=\"1072\" alt=\"image\" src=\"\"<img width=\"838\" alt=\"image\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-71a544e78afb24fa9333a608414a6c6e9cc5ed8fca255db7fb3df39a2d0906b5", "text": "return $('tr', undefined, ...row.map(rowData => { if (typeof rowData === 'string') { <del> return $('td', undefined, rowData); </del> <ins> return $('td', undefined, $('p', undefined, rowData)); </ins> } const data = Array.isArray(rowData) ? rowData : [rowData]; return $('td', undefined, ...data.map(item => {", "commid": "vscode_pr_228365"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d0b0a81275d02fbb5ebd894ac2e10ebc90c6806a11f54d939627e2a38c6776f", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information\nwill be exploring fixing this type of issue transparently.\nThis will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?\nthat fixed the issue. Thanks so much for the quick response to our problem!", "positive_passages": [{"docid": "doc-en-vscode-edb5fd81a86935ef95c49caaafa27a524280a996a57b16a6f7ff3880d759de77", "text": "alias: { './node/authServer': path.resolve(__dirname, 'src/browser/authServer'), './node/buffer': path.resolve(__dirname, 'src/browser/buffer'), <ins> './node/fetch': path.resolve(__dirname, 'src/browser/fetch'), </ins> './node/authProvider': path.resolve(__dirname, 'src/browser/authProvider'), } }", "commid": "vscode_pr_229202"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d0b0a81275d02fbb5ebd894ac2e10ebc90c6806a11f54d939627e2a38c6776f", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information\nwill be exploring fixing this type of issue transparently.\nThis will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?\nthat fixed the issue. Thanks so much for the quick response to our problem!", "positive_passages": [{"docid": "doc-en-vscode-27c68f0c37d512c3c753902f1ba8515d410ab71fff849b6b56a4e32ecfc9f9e0", "text": "import { BetterTokenStorage, IDidChangeInOtherWindowEvent } from './betterSecretStorage'; import { LoopbackAuthServer } from './node/authServer'; import { base64Decode } from './node/buffer'; <ins> import fetch from './node/fetch'; </ins> import { UriEventHandler } from './UriEventHandler'; import TelemetryReporter from '@vscode/extension-telemetry'; import { Environment } from '@azure/ms-rest-azure-env';", "commid": "vscode_pr_229202"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d0b0a81275d02fbb5ebd894ac2e10ebc90c6806a11f54d939627e2a38c6776f", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information\nwill be exploring fixing this type of issue transparently.\nThis will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?\nthat fixed the issue. Thanks so much for the quick response to our problem!", "positive_passages": [{"docid": "doc-en-vscode-cc2d5b53b7f698b1f57dd54116d44a60e7c4cc451141c5f3663205021fd9c6dd", "text": "let result; let errorMessage: string | undefined; try { <del> result = await fetch(endpoint, { </del> <ins> result = await fetch(endpoint.toString(), { </ins> method: 'POST', headers: { <del> 'Content-Type': 'application/x-www-form-urlencoded', 'Content-Length': postData.length.toString() </del> <ins> 'Content-Type': 'application/x-www-form-urlencoded' </ins> }, body: postData });", "commid": "vscode_pr_229202"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d0b0a81275d02fbb5ebd894ac2e10ebc90c6806a11f54d939627e2a38c6776f", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information\nwill be exploring fixing this type of issue transparently.\nThis will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?\nthat fixed the issue. Thanks so much for the quick response to our problem!", "positive_passages": [{"docid": "doc-en-vscode-aaefce4154fdd266ebb08cd95fe25bbe9ae0b47a1bd7790e953f8a0d9531a4f2", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ export default fetch; </ins>", "commid": "vscode_pr_229202"}], "negative_passages": []}
{"query_id": "q-en-vscode-1d0b0a81275d02fbb5ebd894ac2e10ebc90c6806a11f54d939627e2a38c6776f", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No No. The issue occurs in a built-in extension so extensions need to be enabled to see the issue. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider (Universal) Commit: Date: 2024-08-26T05:04:02.640Z Electron: 30.3.1 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce: VS Code behind a proxy server and make a call to the function from the package included with VS Code similar to the one below. After the changes listed in , we began seeing failures from the Microsoft Authentication extension with the following log entries at startup. We rely on that extension to allow another extension we developed internally to authenticate our users. After debugging into the extension source, I found that the issue was originating here. After reading through the previously mentioned pull request, I figured that the call was hanging because the new function was not handling proxy configurations the same way (a common issue in corporate settings). I pulled down VS Code, built from source and tested a change that resolves the issue. I'd like to open a pull request with the fix if you agree that there is a bug in this flow. System Information\nwill be exploring fixing this type of issue transparently.\nThis will be in Monday's Insiders build. Can you please give that a try when it drops so we know for a fact we've fixed the issue for you?\nthat fixed the issue. Thanks so much for the quick response to our problem!", "positive_passages": [{"docid": "doc-en-vscode-b2e8ae59e547ade7048dcd7efa993d34b734a3f50f5c7a6191bf27094680c5d0", "text": "<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ let _fetch: typeof fetch; try { _fetch = require('electron').net.fetch; } catch { _fetch = fetch; } export default _fetch; </ins>", "commid": "vscode_pr_229202"}], "negative_passages": []}
{"query_id": "q-en-vscode-c17fb1cf41ea8ce271f7bc47f537ec62797e2a57ff8a379f18f7b88e0d8dd855", "query": "Testing Repro steps: some changes to a cell, in my case I a cell with some content the changes some lines from the cell that was in step 1, and save. diff view launched from \"changes\" SCM view should diff between staged and working.\nNow the diff view for the changes in the 'Staged Changes' group is the same as the diff view for the unstaged changes\nI am seeing it as I would expect. This is diff launched from staged (where the cell was ) ! This is diff launched on unstaged: !\nWorks for me too, can you share the text file contents in the 3 cases Commited ipynb Staged ipynb & finally changed ipynb\nOriginal steps LGTM\nOriginal file: ! Modification 1: ! Modification 2: ! Observe that the diffs for the Staged and Working Changes regions below are identical !", "positive_passages": [{"docid": "doc-en-vscode-68035118474e6ce46b24cf3606012e6df004d0d99a2cb8428ae27247bc623393", "text": "this._versionId = this._textModel.getVersionId(); this._alternativeId = this._textModel.getAlternativeVersionId(); } <ins> this._textBufferHash = null; </ins> this._onDidChangeContent.fire('content'); }));", "commid": "vscode_pr_226905"}], "negative_passages": []}
{"query_id": "q-en-vscode-fde1ef81a780ce338df6c7d9618a6bfa5625827ef93853cc3c55d41bf66d5a7a", "query": "Testing I think we have another issue discussing a similar issue. This hover and the main item hover can conflict with each other: <img width=\"579\" alt=\"Screenshot 2024-08-27 at 10 37 49 AM\" src=\"\"Instead of having a special hover just for the badges I think the main hover accomplishes the goal just fine as the badge and its description shows up at the bottom: <img width=\"698\" alt=\"Screenshot 2024-08-27 at 10 39 05 AM\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-83a3b7bc081b209c38b1c2aabae9f11079787fa9a7b0bd24330e75f3b9e25992", "text": "import { $, append } from 'vs/base/browser/dom'; import { IHoverOptions, IManagedHover, IManagedHoverTooltipMarkdownString } from 'vs/base/browser/ui/hover/hover'; import { IHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegate'; <del> import { createInstantHoverDelegate, getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; </del> <ins> import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; </ins> import { IconLabel } from 'vs/base/browser/ui/iconLabel/iconLabel'; import { IIdentityProvider, IKeyboardNavigationLabelProvider, IListVirtualDelegate } from 'vs/base/browser/ui/list/list'; import { LabelFuzzyScore } from 'vs/base/browser/ui/tree/abstractTree';", "commid": "vscode_pr_226872"}], "negative_passages": []}
{"query_id": "q-en-vscode-fde1ef81a780ce338df6c7d9618a6bfa5625827ef93853cc3c55d41bf66d5a7a", "query": "Testing I think we have another issue discussing a similar issue. This hover and the main item hover can conflict with each other: <img width=\"579\" alt=\"Screenshot 2024-08-27 at 10 37 49 AM\" src=\"\"Instead of having a special hover just for the badges I think the main hover accomplishes the goal just fine as the badge and its description shows up at the bottom: <img width=\"698\" alt=\"Screenshot 2024-08-27 at 10 39 05 AM\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-989d2aee038e313a32aa4b398e81a4fbf2d874549afbc7eb8d98562e99774f98", "text": "templateData.labelContainer.textContent = ''; if (historyItem.labels) { <del> const instantHoverDelegate = createInstantHoverDelegate(); templateData.elementDisposables.add(instantHoverDelegate); </del> // Get lits of labels to render (current, remote, base) const labels = this.getLabels(node.element.repository);", "commid": "vscode_pr_226872"}], "negative_passages": []}
{"query_id": "q-en-vscode-fde1ef81a780ce338df6c7d9618a6bfa5625827ef93853cc3c55d41bf66d5a7a", "query": "Testing I think we have another issue discussing a similar issue. This hover and the main item hover can conflict with each other: <img width=\"579\" alt=\"Screenshot 2024-08-27 at 10 37 49 AM\" src=\"\"Instead of having a special hover just for the badges I think the main hover accomplishes the goal just fine as the badge and its description shows up at the bottom: <img width=\"698\" alt=\"Screenshot 2024-08-27 at 10 39 05 AM\" src=\"\"", "positive_passages": [{"docid": "doc-en-vscode-a8f0ccd73f291c8fadc0f7bb45ec01e50d515801848c09b1e1377ccb10c60f24", "text": "if (label.icon && ThemeIcon.isThemeIcon(label.icon) && labels.includes(label.title)) { const icon = append(templateData.labelContainer, $('div.label')); icon.classList.add(...ThemeIcon.asClassNameArray(label.icon)); <del> const hover = this.hoverService.setupManagedHover(instantHoverDelegate, icon, label.title); templateData.elementDisposables.add(hover); </del> } } }", "commid": "vscode_pr_226872"}], "negative_passages": []}
{"query_id": "q-en-vscode-416096d72ad920cb1af1f132058f092b9b0fac54b29765eec7c2d1b643d880b0", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.93.0-insider Commit: Date: 2024-08-29T05:04:03.909Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Linux x64 6.9.3--generic Steps to Reproduce: a few editor groups in seemingly any split configuration one for text input or otherwise run to type: no result, as no editor has focus any more. This is especially frustrating when some of your other keyboard shortcuts rely on the editorFocus context, as they become unusable after using this feature.\nIn case this takes a while to fix, anyone looking for a workaround can rebind their preferred shortcut to automatically refocus the editor and then \"move\" the cursor to ensure if another window has now covered your cursor, the editor scrolls to reveal it again (also respecting scrolloff setting).\n<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!\n/verified", "positive_passages": [{"docid": "doc-en-vscode-84a4369d519f3ce987f5d1ea2181946d96ad3cbf1ee88d99134962a0de4e888a", "text": "const editorGroupService = accessor.get(IEditorGroupsService); const newOrientation = (editorGroupService.orientation === GroupOrientation.VERTICAL) ? GroupOrientation.HORIZONTAL : GroupOrientation.VERTICAL; editorGroupService.setGroupOrientation(newOrientation); <ins> editorGroupService.activeGroup.focus(); </ins> } });", "commid": "vscode_pr_227193"}], "negative_passages": []}
{"query_id": "q-en-vscode-e7d66e2b3df52dbcf2134b90422dc10faf520f6a5d89007ce877a9132be18e3a", "query": "Enable the setting which enabled the native edit context adoption Copy some code which is more than 3 lines long Paste the code. The code that is pasted does not correspond to the code that is copied\nAfter some investigation, I have noticed the following curious points. In the following, please note that to fix the long-press-E chromium issue, we essentially always write the screen reader content which means we always change the document selection. When screen reader is toggled off: When we read the copied text from the the electron clipboard in order to paste, it is incorrect When we remove the logic that sets the document selection for the screen reader content, the pasted text is correct When screen reader is toggled on: Text that is read from electron clipboard is always correct In fact interestingly when we revert the changes we have made for the long-press E issue, then this copy-paste issue no longer occurs! Since the long-press E issue is not important, and copy pasting is much more important, I believe that we should revert that fix. From this I believe this could be somehow related to a chromium bug. cc\nI have made the following PR to revert the long press E fix : This fixed copy-pasting too.", "positive_passages": [{"docid": "doc-en-vscode-4bc187cfdac26f453ab02295be392d1bfa4adc40afe1ae2b6bfc622ec76b1aee", "text": "this._compositionRangeWithinEditor = newCompositionRangeWithinEditor; } this._emitTypeEvent(viewController, e); <del> // TODO @aiday-mar calling write screen reader content so that the document selection is immediately set // remove the following when electron will be upgraded this._screenReaderSupport.writeScreenReaderContent(); </del> })); this._register(editContextAddDisposableListener(this._editContext, 'compositionstart', (e) => { const position = this._context.viewModel.getPrimaryCursorState().modelState.position;", "commid": "vscode_pr_228494"}], "negative_passages": []}
{"query_id": "q-en-vscode-e7d66e2b3df52dbcf2134b90422dc10faf520f6a5d89007ce877a9132be18e3a", "query": "Enable the setting which enabled the native edit context adoption Copy some code which is more than 3 lines long Paste the code. The code that is pasted does not correspond to the code that is copied\nAfter some investigation, I have noticed the following curious points. In the following, please note that to fix the long-press-E chromium issue, we essentially always write the screen reader content which means we always change the document selection. When screen reader is toggled off: When we read the copied text from the the electron clipboard in order to paste, it is incorrect When we remove the logic that sets the document selection for the screen reader content, the pasted text is correct When screen reader is toggled on: Text that is read from electron clipboard is always correct In fact interestingly when we revert the changes we have made for the long-press E issue, then this copy-paste issue no longer occurs! Since the long-press E issue is not important, and copy pasting is much more important, I believe that we should revert that fix. From this I believe this could be somehow related to a chromium bug. cc\nI have made the following PR to revert the long press E fix : This fixed copy-pasting too.", "positive_passages": [{"docid": "doc-en-vscode-7ddd1ae3b709b7d958f4c6304e1cba4eb8d3db7c65656a5715074f060fdd5c73", "text": "} private _getScreenReaderContentState(): ScreenReaderContentState | undefined { <del> // Make the screen reader content always be visible because of the bug and also set the selection // TODO @aiday-mar Ultimately uncomment this code when Electron will be upgraded // if (this._accessibilitySupport === AccessibilitySupport.Disabled) { // \treturn; // } const accessibilityPageSize = this._accessibilitySupport === AccessibilitySupport.Disabled ? 1 : this._accessibilityPageSize; </del> <ins> if (this._accessibilitySupport === AccessibilitySupport.Disabled) { return; } </ins> const simpleModel: ISimpleModel = { getLineCount: (): number => { return this._context.viewModel.getLineCount();", "commid": "vscode_pr_228494"}], "negative_passages": []}
{"query_id": "q-en-vscode-e7d66e2b3df52dbcf2134b90422dc10faf520f6a5d89007ce877a9132be18e3a", "query": "Enable the setting which enabled the native edit context adoption Copy some code which is more than 3 lines long Paste the code. The code that is pasted does not correspond to the code that is copied\nAfter some investigation, I have noticed the following curious points. In the following, please note that to fix the long-press-E chromium issue, we essentially always write the screen reader content which means we always change the document selection. When screen reader is toggled off: When we read the copied text from the the electron clipboard in order to paste, it is incorrect When we remove the logic that sets the document selection for the screen reader content, the pasted text is correct When screen reader is toggled on: Text that is read from electron clipboard is always correct In fact interestingly when we revert the changes we have made for the long-press E issue, then this copy-paste issue no longer occurs! Since the long-press E issue is not important, and copy pasting is much more important, I believe that we should revert that fix. From this I believe this could be somehow related to a chromium bug. cc\nI have made the following PR to revert the long press E fix : This fixed copy-pasting too.", "positive_passages": [{"docid": "doc-en-vscode-733db3a76381fabf1a0df7c698d7ac494b72916d4db79afc9b07960b68645efb", "text": "return this._context.viewModel.modifyPosition(position, offset); } }; <del> return PagedScreenReaderStrategy.fromEditorSelection(simpleModel, this._primarySelection, accessibilityPageSize, this._accessibilitySupport === AccessibilitySupport.Unknown); </del> <ins> return PagedScreenReaderStrategy.fromEditorSelection(simpleModel, this._primarySelection, this._accessibilityPageSize, this._accessibilitySupport === AccessibilitySupport.Unknown); </ins> } private _setSelectionOfScreenReaderContent(selectionOffsetStart: number, selectionOffsetEnd: number): void {", "commid": "vscode_pr_228494"}], "negative_passages": []}
{"query_id": "q-en-vscode-5d64e507f879970c582fdbfd1d65e9db4d050dedd1f082ce7190fa99c90404a1", "query": "Enable the setting Open the editor Open the find widget Type several letters The editor is focused as soon as there is a match for the find result It is no longer possible to continue typing in the find widget without retriggering the focusing of the find widget", "positive_passages": [{"docid": "doc-en-vscode-54907b24397244ce093d2621e0fd084f9dbe02a2e7aabbe1e7189edd96b4a8a6", "text": "*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { getActiveWindow } from '../../../../../base/browser/dom.js'; </del> <ins> import { getActiveWindow, isHTMLElement } from '../../../../../base/browser/dom.js'; </ins> import { FastDomNode } from '../../../../../base/browser/fastDomNode.js'; import { AccessibilitySupport } from '../../../../../platform/accessibility/common/accessibility.js'; import { IKeybindingService } from '../../../../../platform/keybinding/common/keybinding.js';", "commid": "vscode_pr_227989"}], "negative_passages": []}
{"query_id": "q-en-vscode-5d64e507f879970c582fdbfd1d65e9db4d050dedd1f082ce7190fa99c90404a1", "query": "Enable the setting Open the editor Open the find widget Type several letters The editor is focused as soon as there is a match for the find result It is no longer possible to continue typing in the find widget without retriggering the focusing of the find widget", "positive_passages": [{"docid": "doc-en-vscode-729f39c99f778dfe5fb0ac69f8ce79fd6133bbdc01e73f8c1c928295175e9e28", "text": "if (!textContent) { return; } <ins> const focusedElement = getActiveWindow().document.activeElement; </ins> const range = new globalThis.Range(); range.setStart(textContent, selectionOffsetStart); range.setEnd(textContent, selectionOffsetEnd); activeDocumentSelection.removeAllRanges(); activeDocumentSelection.addRange(range); <ins> if (isHTMLElement(focusedElement)) { focusedElement.focus(); } </ins> } }", "commid": "vscode_pr_227989"}], "negative_passages": []}
{"query_id": "q-en-vscode-db82882439def63f05c7f27c6cc920d4497eff898b4526ab051decff485a02d8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.93.1 OS Version: Windows 11 Pro Originally from To Reproduce Steps to reproduce the behavior: an empty dart project (can be any language, this is just the one I use of course) the code below breakpoints on both and print calls the breakpoint on the trigger only after the one at (screenshot) the code and make sure the breakpoint stops the program that triggers before Expected behavior For the triggered breakpoint to wait again on restart. Also note that there are two ways to restart a debug session too - a full restart handled by VS Code (which is what happens for Dart above), and a restart that is delegated to the debug adapter (which we use for Flutter to do Hot Restart, so it's faster than a cold restart by VS Code). In both cases, this state should be reset. Screenshots ! <details<summaryRelevant debugging log part </summary</details// CC:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nInterestingly, I cannot reproduce this with JavaScript using an equivalent file: Unfortunately I don't think it uses DAP and I don't know if there's a way to get a log of what's happening there. It's not clear to me how it could be working there given the DAP traffic captured for Dart. Someone familiar with the implementation of Triggered Breakpoints or the JS debugger might be able to explain what's going on.\nI can on python:\nI am also running into this issue\nThis is probably because the JS debugger has each debugee as its own, child session, and when restarting JS you will retain the parent session (handled by the DA) but get a new child session that doesn't have the data set.\nI am debugging Go. I don't remember seeing it with other languages but I also only rarely run anything other than Go.\nyea, it's reproducable with Python too. Fixed in Monday's Insiders.", "positive_passages": [{"docid": "doc-en-vscode-6498a3a760d7d7cb4edeb46d4ff0ce70c0039f2116b193d4460b894be062a172", "text": "} }; <ins> for (const breakpoint of this.model.getBreakpoints({ triggeredOnly: true })) { breakpoint.setSessionDidTrigger(session.getId(), false); } </ins> // For debug sessions spawned by test runs, cancel the test run and stop // the session, then start the test run again; tests have no notion of restarts. if (session.correlatedTestRun) {", "commid": "vscode_pr_230551"}], "negative_passages": []}
{"query_id": "q-en-vscode-db82882439def63f05c7f27c6cc920d4497eff898b4526ab051decff485a02d8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.93.1 OS Version: Windows 11 Pro Originally from To Reproduce Steps to reproduce the behavior: an empty dart project (can be any language, this is just the one I use of course) the code below breakpoints on both and print calls the breakpoint on the trigger only after the one at (screenshot) the code and make sure the breakpoint stops the program that triggers before Expected behavior For the triggered breakpoint to wait again on restart. Also note that there are two ways to restart a debug session too - a full restart handled by VS Code (which is what happens for Dart above), and a restart that is delegated to the debug adapter (which we use for Flutter to do Hot Restart, so it's faster than a cold restart by VS Code). In both cases, this state should be reset. Screenshots ! <details<summaryRelevant debugging log part </summary</details// CC:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nInterestingly, I cannot reproduce this with JavaScript using an equivalent file: Unfortunately I don't think it uses DAP and I don't know if there's a way to get a log of what's happening there. It's not clear to me how it could be working there given the DAP traffic captured for Dart. Someone familiar with the implementation of Triggered Breakpoints or the JS debugger might be able to explain what's going on.\nI can on python:\nI am also running into this issue\nThis is probably because the JS debugger has each debugee as its own, child session, and when restarting JS you will retain the parent session (handled by the DA) but get a new child session that doesn't have the data set.\nI am debugging Go. I don't remember seeing it with other languages but I also only rarely run anything other than Go.\nyea, it's reproducable with Python too. Fixed in Monday's Insiders.", "positive_passages": [{"docid": "doc-en-vscode-cd6b6f05fb68eb165df01506af13d96e8547c29f0a3e3e853634be4b8432ab81", "text": "readonly pending: boolean; /** Marks that a session did trigger the breakpoint. */ <del> setSessionDidTrigger(sessionId: string): void; </del> <ins> setSessionDidTrigger(sessionId: string, didTrigger?: boolean): void; </ins> /** Gets whether the `triggeredBy` condition has been met in the given sesison ID. */ getSessionDidTrigger(sessionId: string): boolean;", "commid": "vscode_pr_230551"}], "negative_passages": []}
{"query_id": "q-en-vscode-db82882439def63f05c7f27c6cc920d4497eff898b4526ab051decff485a02d8", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.93.1 OS Version: Windows 11 Pro Originally from To Reproduce Steps to reproduce the behavior: an empty dart project (can be any language, this is just the one I use of course) the code below breakpoints on both and print calls the breakpoint on the trigger only after the one at (screenshot) the code and make sure the breakpoint stops the program that triggers before Expected behavior For the triggered breakpoint to wait again on restart. Also note that there are two ways to restart a debug session too - a full restart handled by VS Code (which is what happens for Dart above), and a restart that is delegated to the debug adapter (which we use for Flutter to do Hot Restart, so it's faster than a cold restart by VS Code). In both cases, this state should be reset. Screenshots ! <details<summaryRelevant debugging log part </summary</details// CC:\nThanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!\nInterestingly, I cannot reproduce this with JavaScript using an equivalent file: Unfortunately I don't think it uses DAP and I don't know if there's a way to get a log of what's happening there. It's not clear to me how it could be working there given the DAP traffic captured for Dart. Someone familiar with the implementation of Triggered Breakpoints or the JS debugger might be able to explain what's going on.\nI can on python:\nI am also running into this issue\nThis is probably because the JS debugger has each debugee as its own, child session, and when restarting JS you will retain the parent session (handled by the DA) but get a new child session that doesn't have the data set.\nI am debugging Go. I don't remember seeing it with other languages but I also only rarely run anything other than Go.\nyea, it's reproducable with Python too. Fixed in Monday's Insiders.", "positive_passages": [{"docid": "doc-en-vscode-4cac9ad05bd4ace573f4cd18dd8c3d101f6e72df1a411aa1d52daa501986da30", "text": "return `${resources.basenameOrAuthority(this.uri)} ${this.lineNumber}`; } <del> public setSessionDidTrigger(sessionId: string): void { this.sessionsDidTrigger ??= new Set(); this.sessionsDidTrigger.add(sessionId); </del> <ins> public setSessionDidTrigger(sessionId: string, didTrigger = true): void { if (didTrigger) { this.sessionsDidTrigger ??= new Set(); this.sessionsDidTrigger.add(sessionId); } else { this.sessionsDidTrigger?.delete(sessionId); } </ins> } public getSessionDidTrigger(sessionId: string): boolean {", "commid": "vscode_pr_230551"}], "negative_passages": []}
{"query_id": "q-en-vscode-3450cd62072d804257a5726f9802d0dddd042ba04c38c153b0586770c0e81078", "query": "today's insiders open GHINB and run a cell see errors (many) on the console\nbroke\nWe should also add a custom eslint rule for this. It has been broken for a few weeks and it regresses the output focus context keys.", "positive_passages": [{"docid": "doc-en-vscode-70778f4ebb42d109e69080436647867a5152fc66fc0867e57dd3924b13050cb0", "text": "}, 0); }; <ins> const isEditableElement = (element: Element) => { return element.tagName.toLowerCase() === 'input' || element.tagName.toLowerCase() === 'textarea' || 'editContext' in element; }; </ins> // check if an input element is focused within the output element const checkOutputInputFocus = (e: FocusEvent) => { lastFocusedOutput = getOutputContainer(e);", "commid": "vscode_pr_229869"}], "negative_passages": []}
{"query_id": "q-en-vscode-3450cd62072d804257a5726f9802d0dddd042ba04c38c153b0586770c0e81078", "query": "today's insiders open GHINB and run a cell see errors (many) on the console\nbroke\nWe should also add a custom eslint rule for this. It has been broken for a few weeks and it regresses the output focus context keys.", "positive_passages": [{"docid": "doc-en-vscode-287b00d686e1213a25d614138be9c02e5c551aa3f12f45a8040c02799a292853", "text": "JSON.parse(decodeURIComponent(\"${encodeURIComponent(JSON.stringify(ctx))}\")) )n//# sourceURL=notebookWebviewPreloads.jsn`; } <del> export function isEditableElement(element: Element): boolean { return element.tagName.toLowerCase() === 'input' || element.tagName.toLowerCase() === 'textarea' || 'editContext' in element; } </del>", "commid": "vscode_pr_229869"}], "negative_passages": []}
{"query_id": "q-en-vscode-e5b44f7654273b46bc3820b1d249187b7bf7c1c3e939a88ece4de9171e021628", "query": "<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.95.0-insider OS Version: Windows 11 Steps to Reproduce: : window to message and use <kbdShift</kbd+<kbdEnter</kbd<kbdShift</kbd+<kbdEnter</kbddoes not work in Source control message text area if option is enabled. It seems that it occurs not only in but also when I edit any file. <hrMaybe related to\nI see thank you for filing this issue. I will look into it.\nHi may I ask you what you were expecting to see? I turned the setting on and off and press when I have no commits to make and a notification pops up mentioning that I have no changes to commit. Thank you.\nHi, thank you for checking it out. I expect that a new line will be , the same as with just pressing <kbdEnter</kbd. By the way, the same issue occurs when I edit a file.\nHi thank you for clarifying the question, yes I am able to reproduce this behavior. This happens because we don't send a new line event when we receive the event. I will make a PR to fix this.", "positive_passages": [{"docid": "doc-en-vscode-e4c7ca08586b35f56af7d1d78dd383354617d4c803589dcb9638e5ab56c50fd9", "text": "viewController.emitKeyDown(standardKeyboardEvent); })); this._register(addDisposableListener(this.domNode.domNode, 'beforeinput', async (e) => { <del> if (e.inputType === 'insertParagraph') { </del> <ins> if (e.inputType === 'insertParagraph' || e.inputType === 'insertLineBreak') { </ins> this._onType(viewController, { text: 'n', replacePrevCharCnt: 0, replaceNextCharCnt: 0, positionDelta: 0 }); } }));", "commid": "vscode_pr_230469"}], "negative_passages": []}