| { | |
| "number": 100, | |
| "title": "Remove repo zipping / unzipping", | |
| "body": "As according to Matt Mitchell performance issues related to\r\nrepeated git checkouts (throttling) have been fixed and Azure\r\npipelines should automatically make sure that all jobs check out\r\nthe same GIT commit, I am removing the previous workaround to\r\nzip the Windows & Linux checkout as an initial step in each\r\npipeline and unzip it in subsequent jobs instead of repeating\r\nthe git checkout.\r\n\r\nThanks\r\n\r\nTomas", | |
| "createdAt": "2019-11-18T15:50:10Z", | |
| "closedAt": "2019-11-27T11:35:11Z", | |
| "mergedAt": null, | |
| "state": "CLOSED", | |
| "author": { | |
| "login": "trylek" | |
| }, | |
| "labels": { | |
| "nodes": [ | |
| { | |
| "name": "area-Infrastructure-coreclr" | |
| } | |
| ] | |
| }, | |
| "headRefName": "RemoveRepoZipUnzip", | |
| "additions": 3, | |
| "deletions": 201, | |
| "changedFiles": 24, | |
| "comments": { | |
| "totalCount": 17, | |
| "nodes": [ | |
| { | |
| "body": "Fixes: #96 ", | |
| "createdAt": "2019-11-18T15:57:21Z" | |
| }, | |
| { | |
| "body": "AzDO folks say the bug isn't fixed yet so you may get a torn state. The fix is currently in progress. it's probably not too risky to merge this, as most repos are getting this behavior already.", | |
| "createdAt": "2019-11-18T16:44:44Z" | |
| }, | |
| { | |
| "body": "I am conflicted on whether we should take this or not. I think there is little benefit to moving back at the moment.", | |
| "createdAt": "2019-11-18T16:56:09Z" | |
| }, | |
| { | |
| "body": "Mostly about cleanliness and potentially reducing overall PR times. It means you've removed a dependency edge from the build graph.", | |
| "createdAt": "2019-11-18T17:03:58Z" | |
| }, | |
| { | |
| "body": "> AzDO folks say the bug isn't fixed yet so you may get a torn state. The fix is currently in progress. it's probably not too risky to merge this, as most repos are getting this behavior already.\r\n\r\nThey've known about the issue with the checkout ref for a while - so I would keep the workaround with zipping/unzipping (or see another proposal below) until they have the fix ready. Otherwise, you will get strange failures in PRs when a test job fails because someone has commited a test to the repo in the meantime (e.g. that reproduces a jit assertion)\r\n\r\n> Mostly about cleanliness and potentially reducing overall PR times. It means you've removed a dependency edge from the build graph.\r\n\r\nHow about if I port my changes in https://github.com/dotnet/coreclr/pull/27867 to runtimes - so we can gen twice less dependency edges - and have only one checkout job that works for both Windows and non-Windows scenarios", | |
| "createdAt": "2019-11-18T19:11:09Z" | |
| }, | |
| { | |
| "body": "Do you have perf numbers how long uploading and downloading (from AzDO) of the compressed repository takes?", | |
| "createdAt": "2019-11-18T19:12:46Z" | |
| }, | |
| { | |
| "body": "> Do you have perf numbers how long uploading and downloading (from AzDO) of the compressed repository takes?\r\n\r\nI have only one measurement https://dev.azure.com/dnceng/public/_build/results?buildId=427792 with git bundles (which is obviously not enough):\r\n* cloning from GitHub took 1m22s (on macOS agent)\r\n* creation of the bundle took 6s\r\n* upload took 13s \r\n* download steps took from 6-11s (depending on the agent)\r\n* cloning repo from the bundle takes from 7s (on macOS agent) up to 1m40s (on NetCorePublic-Pool agent)\r\n\r\n", | |
| "createdAt": "2019-11-18T19:22:19Z" | |
| }, | |
| { | |
| "body": "> The fix is currently in progress\r\n\r\n@mmitche do you have the internal link to the tracking issue?", | |
| "createdAt": "2019-11-18T19:25:20Z" | |
| }, | |
| { | |
| "body": "There is one more approach we can take:\r\n\r\n* Checkout directly from GitHub during build job - this way we remove common dependency edge [Build] -> [Checkout]\r\n* Then create a git bundle based on the commit fetched in a build job and publish the bundle as artifact\r\n* Download the bundle during test job instead of cloning from GitHub\r\n\r\nThis way we can remove a common dependency **and** make sure that the tests are built based on the same commit that product was built on.", | |
| "createdAt": "2019-11-18T19:26:31Z" | |
| }, | |
| { | |
| "body": "> The fix is currently in progress\r\n> \r\n> @mmitche do you have the internal link to the tracking issue?\r\n\r\nWe reported this issue to the AzDO team with help from @chcosta. Chris do you happen to know the tracking issue?", | |
| "createdAt": "2019-11-18T19:29:55Z" | |
| }, | |
| { | |
| "body": "https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1529338", | |
| "createdAt": "2019-11-18T19:31:10Z" | |
| }, | |
| { | |
| "body": "We're tracking with https://dev.azure.com/dnceng/internal/_queries/edit/152 which links to [AzDo's work item](https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/1529338)", | |
| "createdAt": "2019-11-18T19:32:23Z" | |
| }, | |
| { | |
| "body": "As concerns perf, I usually saw GIT checkout take about 30~60 seconds on both Linux and Windows; downloading and unzipping of the zipped repo takes about 40 seconds on Linux / Mac and about 60 seconds on Windows. For now I would assume Egor's change to be the easiest to take as he already has it working and it maintains commit stability (in fact it even improves it by removing a potential difference between the Windows and Linux checkout).", | |
| "createdAt": "2019-11-18T20:28:12Z" | |
| }, | |
| { | |
| "body": "> As concerns perf, I usually saw GIT checkout take about 30~60 seconds on both Linux and Windows; downloading and unzipping of the zipped repo takes about 40 seconds on Linux / Mac and about 60 seconds on Windows. For now I would assume Egor's change to be the easiest to take as he already has it working and it maintains commit stability (in fact it even improves it by removing a potential difference between the Windows and Linux checkout).\r\n\r\nThe downside is that you have the setup + teardown and queuing of another leg we can be signfiicant (e.g. parallelism). Anyway, I think we should fix this once AzDO confirms they have the fix for the checkout sha in place.", | |
| "createdAt": "2019-11-18T21:08:34Z" | |
| }, | |
| { | |
| "body": "I agree with @mmitche here but I would just keep the PR open until this is fixed on the AzDO side. I'm following the tracking issue and will comment here as soon as the fix landed.", | |
| "createdAt": "2019-11-19T10:42:43Z" | |
| }, | |
| { | |
| "body": "@trylek let's close this until we have the fix on AzDO ready. This will probably take 4-6 weeks.", | |
| "createdAt": "2019-11-27T11:35:11Z" | |
| }, | |
| { | |
| "body": "The AzDO change is now implemented but probably will take a few weeks till being rolled out. I will keep you updated.", | |
| "createdAt": "2019-12-05T16:17:58Z" | |
| } | |
| ] | |
| }, | |
| "reviewThreads": { | |
| "totalCount": 1, | |
| "nodes": [ | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "eng/pipelines/coreclr/templates/xplat-job.yml", | |
| "diffHunk": "@@ -164,20 +155,8 @@ jobs:\n - ${{insert}}: ${{ variable }}\n \n steps:\n- - checkout: none\n+ - checkout: self", | |
| "body": "Do you actually need the checkout step here? Except the clean eq true, this is the default. We don't clean in the Libraries ones so I don't think that's necessary.", | |
| "createdAt": "2019-11-18T16:43:42Z" | |
| }, | |
| { | |
| "path": "eng/pipelines/coreclr/templates/xplat-job.yml", | |
| "diffHunk": "@@ -164,20 +155,8 @@ jobs:\n - ${{insert}}: ${{ variable }}\n \n steps:\n- - checkout: none\n+ - checkout: self", | |
| "body": "Just saw that you are also specifying the fetchDepth here. Then it makes sense to keep it here.", | |
| "createdAt": "2019-11-18T16:44:15Z" | |
| }, | |
| { | |
| "path": "eng/pipelines/coreclr/templates/xplat-job.yml", | |
| "diffHunk": "@@ -164,20 +155,8 @@ jobs:\n - ${{insert}}: ${{ variable }}\n \n steps:\n- - checkout: none\n+ - checkout: self", | |
| "body": "Still my question would be, do we need cleaning enabled?", | |
| "createdAt": "2019-11-18T16:45:38Z" | |
| } | |
| ] | |
| } | |
| } | |
| ] | |
| }, | |
| "commits": { | |
| "totalCount": 1, | |
| "nodes": [ | |
| { | |
| "commit": { | |
| "oid": "23ae599fe2f44f9be3d24e0223240d25c21ee3a4", | |
| "message": "Remove repo zipping / unzipping\n\nAs according to Matt Mitchell performance issues related to\nrepeated git checkouts (throttling) have been fixed and Azure\npipelines should automatically make sure that all jobs check out\nthe same GIT commit, I am removing the previous workaround to\nzip the Windows & Linux checkout as an initial step in each\npipeline and unzip it in subsequent jobs instead of repeating\nthe git checkout.\n\nThanks\n\nTomas", | |
| "committedDate": "2019-11-18T15:53:55Z" | |
| } | |
| } | |
| ] | |
| } | |
| } |