| { | |
| "number": 100001, | |
| "title": "Support setting NamedPipeClientStream.ReadMode with PipeAccessRights ctor overload", | |
| "body": "Fixes #83072 ([Cannot set ReadMode after creating a NamedPipeClientStream instance](https://github.com/dotnet/runtime/issues/83072)).\r\n\r\nPer the [API Review notes and video](https://github.com/dotnet/runtime/issues/83072#issuecomment-1942189738):\r\n\r\n1. Add the missing constructor to `NamedPipeClientStream` that accepts `PipeAccessRights`\r\n2. Promote `PipeAccessRights` from System.IO.Pipes.AccessRights to System.IO.Pipes, and add the necessary type-forward\r\n3. Mark the constructor as being only supported on Windows, but leave the enum available on all platforms\r\n4. Review for nullability annotations -- no arguments allow null\r\n\r\nThe .NET Framework implementation was referenced from [Pipe.cs](https://referencesource.microsoft.com/#System.Core/System/IO/Pipes/Pipe.cs,a71f90682fcb0da9), but the behavior was improved slightly.\r\n\r\n* Argument validation logic is reused rather than being duplicated into the new constructor\r\n* The `direction` argument is given a valid value when the `desiredAccessRights` value is invalid, ensuring that the correct `desiredAccessRights` argument exception is thrown\r\n * In netfx, any `desiredAccessRights` value missing both the `ReadData` (1) and `WriteData` (2) bits would throw an argument exception for `direction`, which is not an argument to the constructor\r\n* Argument validation for `desiredAccessRights` also throws for a `0` value, which netfx didn't do\r\n\r\nThe functionality was tested using the following server / client apps:\r\n\r\n**server.cs**\r\n```c#\r\nusing System.IO.Pipes;\r\n\r\nvar pipeOut = new NamedPipeServerStream(\"SomeNamedPipe\",\r\n PipeDirection.Out,\r\n 1,\r\n PipeTransmissionMode.Message);\r\n\r\nConsole.WriteLine(\"Waiting for a connection...\");\r\npipeOut.WaitForConnection();\r\n\r\nConsole.WriteLine(\"Connected. Sending messages...\");\r\n\r\nwhile (true) {\r\n pipeOut.Write(\"Hello \"u8);\r\n pipeOut.Write(\"from \"u8);\r\n pipeOut.Write(\"the \"u8);\r\n pipeOut.Write(\"server!\"u8);\r\n\r\n Console.WriteLine(\"Messages sent. Sleeping for 10 seconds.\");\r\n System.Threading.Thread.Sleep(10_000);\r\n}\r\n```\r\n\r\n**client.cs**\r\n```c#\r\nusing System.IO.Pipes;\r\n\r\nvar pipeIn = new NamedPipeClientStream(\".\",\r\n \"SomeNamedPipe\",\r\n PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes,\r\n PipeOptions.None,\r\n System.Security.Principal.TokenImpersonationLevel.None,\r\n System.IO.HandleInheritability.None);\r\n\r\npipeIn.Connect();\r\npipeIn.ReadMode = PipeTransmissionMode.Message;\r\n\r\nwhile (pipeIn.IsConnected)\r\n{\r\n var buffer = new byte[2];\r\n var bytesRead = pipeIn.Read(buffer, 0, buffer.Length);\r\n\r\n if (bytesRead > 0) {\r\n var message = System.Text.Encoding.UTF8.GetString(buffer, 0, bytesRead);\r\n Console.Write(message);\r\n\r\n System.Threading.Thread.Sleep(1000);\r\n\r\n if (pipeIn.IsMessageComplete) {\r\n Console.WriteLine();\r\n }\r\n }\r\n}\r\n```\r\n\r\nWith this PR, that application works as expected, with the client detecting completed messages after each word and rendering newlines.\r\n", | |
| "createdAt": "2024-03-20T09:10:25Z", | |
| "closedAt": "2024-03-27T15:02:32Z", | |
| "mergedAt": "2024-03-27T15:02:32Z", | |
| "state": "MERGED", | |
| "author": { | |
| "login": "jeffhandley" | |
| }, | |
| "labels": { | |
| "nodes": [ | |
| { | |
| "name": "area-System.IO" | |
| }, | |
| { | |
| "name": "new-api-needs-documentation" | |
| } | |
| ] | |
| }, | |
| "headRefName": "jeffhandley/namedpipe-readmode", | |
| "additions": 334, | |
| "deletions": 58, | |
| "changedFiles": 15, | |
| "comments": { | |
| "totalCount": 1, | |
| "nodes": [ | |
| { | |
| "body": "Note regarding the `new-api-needs-documentation` label:\r\n\r\n This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.", | |
| "createdAt": "2024-03-20T09:10:30Z" | |
| } | |
| ] | |
| }, | |
| "reviewThreads": { | |
| "totalCount": 7, | |
| "nodes": [ | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeClientStream.Windows.cs", | |
| "diffHunk": "@@ -16,6 +17,78 @@ namespace System.IO.Pipes\n /// </summary>\n public sealed partial class NamedPipeClientStream : PipeStream\n {\n+ /// <summary>\n+ /// Initializes a new instance of the <see cref=\"NamedPipeClientStream\"/> class with the specified pipe and server names,\n+ /// the desired <see cref=\"PipeAccessRights\"/>, and the specified impersonation level and inheritability.\n+ /// </summary>\n+ /// <param name=\"serverName\">The name of the remote computer to connect to, or \".\" to specify the local computer.</param>\n+ /// <param name=\"pipeName\">The name of the pipe.</param>\n+ /// <param name=\"desiredAccessRights\">One of the enumeration values that specifies the desired access rights of the pipe.</param>\n+ /// <param name=\"options\">One of the enumeration values that determines how to open or create the pipe.</param>\n+ /// <param name=\"impersonationLevel\">One of the enumeration values that determines the security impersonation level.</param>\n+ /// <param name=\"inheritability\">One of the enumeration values that determines whether the underlying handle will be inheritable by child processes.</param>\n+ /// <exception cref=\"ArgumentNullException\"><paramref name=\"pipeName\"/> or <paramref name=\"serverName\"/> is <c>null</c>.</exception>\n+ /// <exception cref=\"ArgumentException\"><paramref name=\"pipeName\"/> or <paramref name=\"serverName\"/> is a zero-length string.</exception>\n+ /// <exception cref=\"ArgumentOutOfRangeException\"><paramref name=\"pipeName\"/> is set to \"anonymous\".</exception>\n+ /// <exception cref=\"ArgumentOutOfRangeException\"><paramref name=\"desiredAccessRights\"/> is not a valid <see cref=\"PipeAccessRights\"/> value.</exception>\n+ /// <exception cref=\"ArgumentOutOfRangeException\"><paramref name=\"options\"/> is not a valid <see cref=\"PipeOptions\"/> value.</exception>\n+ /// <exception cref=\"ArgumentOutOfRangeException\"><paramref name=\"impersonationLevel\"/> is not a valid <see cref=\"TokenImpersonationLevel\"/> value.</exception>\n+ /// <exception cref=\"ArgumentOutOfRangeException\"><paramref name=\"inheritability\"/> is not a valid <see cref=\"HandleInheritability\"/> value.</exception>\n+ /// <remarks>\n+ /// The pipe direction for this constructor is determined by the <paramref name=\"desiredAccessRights\"/> parameter.\n+ /// If the <paramref name=\"desiredAccessRights\"/> parameter specifies <see cref=\"PipeAccessRights.ReadData\"/>,\n+ /// the pipe direction is <see cref=\"PipeDirection.In\"/>. If the <paramref name=\"desiredAccessRights\"/> parameter\n+ /// specifies <see cref=\"PipeAccessRights.WriteData\"/>, the pipe direction is <see cref=\"PipeDirection.Out\"/>.\n+ /// If the value of <paramref name=\"desiredAccessRights\"/> specifies both <see cref=\"PipeAccessRights.ReadData\"/>\n+ /// and <see cref=\"PipeAccessRights.WriteData\"/>, the pipe direction is <see cref=\"PipeDirection.InOut\"/>.\n+ /// </remarks>\n+ [System.Runtime.Versioning.SupportedOSPlatform(\"windows\")]\n+ public NamedPipeClientStream(string serverName, string pipeName, PipeAccessRights desiredAccessRights,", | |
| "body": "Are there any tests for this new ctor other than failure cases?", | |
| "createdAt": "2024-03-20T14:15:02Z" | |
| } | |
| ] | |
| } | |
| }, | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CreateClient.cs", | |
| "diffHunk": "@@ -17,13 +17,15 @@ public static void NullPipeName_Throws_ArgumentNullException()\n {\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(null));\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(\".\", null));\n+ AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(\".\", null, PipeAccessRights.FullControl, PipeOptions.None, TokenImpersonationLevel.None, HandleInheritability.None));", | |
| "body": "Do these tests run on Unix? I'd expect such use would result in a PlatformNotSupportedException being thrown, since the Unix impl is hardcoded to always do that and not do any arg validation.", | |
| "createdAt": "2024-03-20T14:18:55Z" | |
| }, | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CreateClient.cs", | |
| "diffHunk": "@@ -17,13 +17,15 @@ public static void NullPipeName_Throws_ArgumentNullException()\n {\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(null));\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(\".\", null));\n+ AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(\".\", null, PipeAccessRights.FullControl, PipeOptions.None, TokenImpersonationLevel.None, HandleInheritability.None));", | |
| "body": "Thanks for catching that. I broke these out into separate platform-specific tests.", | |
| "createdAt": "2024-03-22T01:10:32Z" | |
| } | |
| ] | |
| } | |
| }, | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CreateClient.cs", | |
| "diffHunk": "@@ -17,6 +17,12 @@ public static void NullPipeName_Throws_ArgumentNullException()\n {\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(null));\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(\".\", null));\n+ }\n+\n+ [Fact]\n+ [PlatformSpecific(TestPlatforms.Windows)]", | |
| "body": "Since AccessRights are specific to Windows, could you please move the PlatformSpecific tests to a separate file? It could be named NamedPipeTest.CreateClient.Windows.cs and can be placed in the same csproj ItemGroup as the other Windows-specific tests.", | |
| "createdAt": "2024-03-23T00:04:01Z" | |
| }, | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CreateClient.cs", | |
| "diffHunk": "@@ -17,6 +17,12 @@ public static void NullPipeName_Throws_ArgumentNullException()\n {\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(null));\n AssertExtensions.Throws<ArgumentNullException>(\"pipeName\", () => new NamedPipeClientStream(\".\", null));\n+ }\n+\n+ [Fact]\n+ [PlatformSpecific(TestPlatforms.Windows)]", | |
| "body": "I was torn on this and saw trade-offs in either direction (separate file for improved cleanliness, or same file for improved discoverability). But as you call out, there is already a heavy usage of platform-specific files, so I'll make the change.", | |
| "createdAt": "2024-03-26T04:26:42Z" | |
| } | |
| ] | |
| } | |
| }, | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });", | |
| "body": "Is there a reason why the `ValueTask` is being created here if it's not being awaited? I'm failing to see if such early/non-awaited call is relevant to the new constructor.", | |
| "createdAt": "2024-03-23T00:10:23Z" | |
| }, | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });", | |
| "body": "It is awaited before existing the test. I need to call the non-blocking `WriteAsync` so that the test can proceed and the client can start consuming the data; otherwise, `Write` blocks while waiting for a client to consume the data.\r\n\r\nI could probably get away with discarding the `ValueTask`, but it seemed cleaner to capture it and await it before letting the test finish.", | |
| "createdAt": "2024-03-26T05:01:25Z" | |
| } | |
| ] | |
| } | |
| }, | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\n+\n+ byte[] buffer1 = new byte[2], buffer2 = new byte[2], buffer3 = new byte[2];\n+ bool[] messageCompleted = new bool[3];\n+\n+ int bytesRead = client.Read(buffer1, 0, 2);\n+ messageCompleted[0] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer2, 0, 2);\n+ messageCompleted[1] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer3, 0, 2);\n+ messageCompleted[2] = client.IsMessageComplete;\n+\n+ Assert.Equal(5, bytesRead);\n+ Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 0 }, buffer1.Concat(buffer2).Concat(buffer3));\n+ Assert.Equal(new bool[] { false, false, true }, messageCompleted);\n+\n+ await serverWrite;", | |
| "body": "I would move line 35 to here, and return the `ValueTask` directly:\r\n\r\n```suggestion\r\n return server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\r\n```\r\n\r\nAnd since you have no more awaits in the method body, you can remove the `async` modified from the method. And I think you can also change the return type of the method to `ValueTask`.\r\n\r\n@stephentoub please yell at me if I'm giving a bad suggestion.", | |
| "createdAt": "2024-03-23T00:11:18Z" | |
| }, | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\n+\n+ byte[] buffer1 = new byte[2], buffer2 = new byte[2], buffer3 = new byte[2];\n+ bool[] messageCompleted = new bool[3];\n+\n+ int bytesRead = client.Read(buffer1, 0, 2);\n+ messageCompleted[0] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer2, 0, 2);\n+ messageCompleted[1] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer3, 0, 2);\n+ messageCompleted[2] = client.IsMessageComplete;\n+\n+ Assert.Equal(5, bytesRead);\n+ Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 0 }, buffer1.Concat(buffer2).Concat(buffer3));\n+ Assert.Equal(new bool[] { false, false, true }, messageCompleted);\n+\n+ await serverWrite;", | |
| "body": "I'm not sure I follow the recommendation. The test is getting both the server and client running and connected, and then it fires off an async write from the server so that the test can proceed with the client consuming the written bytes (and make asserts based on the received data). Without the `WriteAsync`, the `client.Read` calls will block until data can be received.\r\n\r\n_XUnit test methods don't support `ValueTask` returns. Today I learned._", | |
| "createdAt": "2024-03-26T05:10:16Z" | |
| } | |
| ] | |
| } | |
| }, | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\n+\n+ byte[] buffer1 = new byte[2], buffer2 = new byte[2], buffer3 = new byte[2];\n+ bool[] messageCompleted = new bool[3];\n+\n+ int bytesRead = client.Read(buffer1, 0, 2);\n+ messageCompleted[0] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer2, 0, 2);\n+ messageCompleted[1] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer3, 0, 2);\n+ messageCompleted[2] = client.IsMessageComplete;\n+\n+ Assert.Equal(5, bytesRead);\n+ Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 0 }, buffer1.Concat(buffer2).Concat(buffer3));\n+ Assert.Equal(new bool[] { false, false, true }, messageCompleted);\n+\n+ await serverWrite;\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.Asynchronous)]\n+ public void ServerIn_ClientConnect_Throws(PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, PipeDirection.In, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Assert.Throws<UnauthorizedAccessException>(() => client.Connect());\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ public async Task ServerByteMode_ClientReadModeMessage_Throws(PipeDirection serverDirection, PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task serverConnected = server.WaitForConnectionAsync();\n+ client.Connect();\n+ await serverConnected;", | |
| "body": "Similar question here. I think the `WaitForConnectionAsync` method invocation has to be awaited here, not in line 85.\r\n\r\nAdditionally, if the server async methods are being called, I would also call the client async methods. In line 84, I would call `await client.ConnectAsync();`\r\n", | |
| "createdAt": "2024-03-23T00:17:33Z" | |
| }, | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\n+\n+ byte[] buffer1 = new byte[2], buffer2 = new byte[2], buffer3 = new byte[2];\n+ bool[] messageCompleted = new bool[3];\n+\n+ int bytesRead = client.Read(buffer1, 0, 2);\n+ messageCompleted[0] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer2, 0, 2);\n+ messageCompleted[1] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer3, 0, 2);\n+ messageCompleted[2] = client.IsMessageComplete;\n+\n+ Assert.Equal(5, bytesRead);\n+ Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 0 }, buffer1.Concat(buffer2).Concat(buffer3));\n+ Assert.Equal(new bool[] { false, false, true }, messageCompleted);\n+\n+ await serverWrite;\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.Asynchronous)]\n+ public void ServerIn_ClientConnect_Throws(PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, PipeDirection.In, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Assert.Throws<UnauthorizedAccessException>(() => client.Connect());\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ public async Task ServerByteMode_ClientReadModeMessage_Throws(PipeDirection serverDirection, PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task serverConnected = server.WaitForConnectionAsync();\n+ client.Connect();\n+ await serverConnected;", | |
| "body": "We need to have _at least one_ end of the pipe connect asynchronously so that execution isn't blocked and the other side of the connection can be made. As soon as both sides connect, the awaited tasks are completed. The approach here lets me establish that connection and proceed.\r\n\r\nI did use `Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync())` elsewhere though, so I can standardize on that so it's clearer.", | |
| "createdAt": "2024-03-26T05:13:30Z" | |
| } | |
| ] | |
| } | |
| }, | |
| { | |
| "comments": { | |
| "nodes": [ | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\n+\n+ byte[] buffer1 = new byte[2], buffer2 = new byte[2], buffer3 = new byte[2];\n+ bool[] messageCompleted = new bool[3];\n+\n+ int bytesRead = client.Read(buffer1, 0, 2);\n+ messageCompleted[0] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer2, 0, 2);\n+ messageCompleted[1] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer3, 0, 2);\n+ messageCompleted[2] = client.IsMessageComplete;\n+\n+ Assert.Equal(5, bytesRead);\n+ Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 0 }, buffer1.Concat(buffer2).Concat(buffer3));\n+ Assert.Equal(new bool[] { false, false, true }, messageCompleted);\n+\n+ await serverWrite;\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.Asynchronous)]\n+ public void ServerIn_ClientConnect_Throws(PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, PipeDirection.In, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Assert.Throws<UnauthorizedAccessException>(() => client.Connect());\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ public async Task ServerByteMode_ClientReadModeMessage_Throws(PipeDirection serverDirection, PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task serverConnected = server.WaitForConnectionAsync();\n+ client.Connect();\n+ await serverConnected;\n+\n+ Assert.Throws<IOException>(() => client.ReadMode = PipeTransmissionMode.Message);\n+ }\n+\n+ [Fact]\n+ public async Task PipeAccessRights_Without_WriteAttributes_ClientReadModeMessage_Throws()\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+ PipeAccessRights rights = MinimumMessageAccessRights & ~PipeAccessRights.WriteAttributes;\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, PipeDirection.InOut, 1, PipeTransmissionMode.Message);\n+ using NamedPipeClientStream client = new NamedPipeClientStream(\".\", pipeName, rights, PipeOptions.None, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ Task serverConnected = server.WaitForConnectionAsync();\n+ client.Connect();\n+ await serverConnected;", | |
| "body": "Ditto.\r\n\r\nIt would be nice to see synchronous methods and asynchronous methods doing the same logic. Similar to System.Formats.Tar: we have files to test the async methods only, and files to test the sync methods only, but never intermixed. Here we don't need separate files, they can be added to the same file. The async methods need to end with the *Async suffix.", | |
| "createdAt": "2024-03-23T00:19:27Z" | |
| }, | |
| { | |
| "path": "src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.MessageMode.Windows.cs", | |
| "diffHunk": "@@ -0,0 +1,106 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+\n+using System.Collections.Generic;\n+using System.IO.Tests;\n+using System.Linq;\n+using System.Runtime.InteropServices;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Xunit;\n+\n+namespace System.IO.Pipes.Tests\n+{\n+ // Support for PipeAccessRights and setting ReadMode to Message is only supported on Windows\n+ public class NamedPipeTest_MessageMode_Windows\n+ {\n+ private const PipeAccessRights MinimumMessageAccessRights = PipeAccessRights.ReadData | PipeAccessRights.WriteAttributes;\n+\n+ private static NamedPipeClientStream CreateClientStream(string pipeName, PipeOptions options) =>\n+ new NamedPipeClientStream(\".\", pipeName, MinimumMessageAccessRights, options, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeOptions.Asynchronous)]\n+ public async Task Client_DetectsMessageCompleted(PipeDirection serverDirection, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, PipeTransmissionMode.Message, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync());\n+ client.ReadMode = PipeTransmissionMode.Message;\n+\n+ ValueTask serverWrite = server.WriteAsync(new byte[] { 1, 2, 3, 4, 5 });\n+\n+ byte[] buffer1 = new byte[2], buffer2 = new byte[2], buffer3 = new byte[2];\n+ bool[] messageCompleted = new bool[3];\n+\n+ int bytesRead = client.Read(buffer1, 0, 2);\n+ messageCompleted[0] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer2, 0, 2);\n+ messageCompleted[1] = client.IsMessageComplete;\n+\n+ bytesRead += client.Read(buffer3, 0, 2);\n+ messageCompleted[2] = client.IsMessageComplete;\n+\n+ Assert.Equal(5, bytesRead);\n+ Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 0 }, buffer1.Concat(buffer2).Concat(buffer3));\n+ Assert.Equal(new bool[] { false, false, true }, messageCompleted);\n+\n+ await serverWrite;\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.None)]\n+ [InlineData(PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeTransmissionMode.Message, PipeOptions.Asynchronous)]\n+ public void ServerIn_ClientConnect_Throws(PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, PipeDirection.In, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Assert.Throws<UnauthorizedAccessException>(() => client.Connect());\n+ }\n+\n+ [Theory]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.Out, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.None)]\n+ [InlineData(PipeDirection.InOut, PipeTransmissionMode.Byte, PipeOptions.Asynchronous)]\n+ public async Task ServerByteMode_ClientReadModeMessage_Throws(PipeDirection serverDirection, PipeTransmissionMode serverMode, PipeOptions options)\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, serverDirection, 1, serverMode, options);\n+ using NamedPipeClientStream client = CreateClientStream(pipeName, options);\n+\n+ Task serverConnected = server.WaitForConnectionAsync();\n+ client.Connect();\n+ await serverConnected;\n+\n+ Assert.Throws<IOException>(() => client.ReadMode = PipeTransmissionMode.Message);\n+ }\n+\n+ [Fact]\n+ public async Task PipeAccessRights_Without_WriteAttributes_ClientReadModeMessage_Throws()\n+ {\n+ string pipeName = PipeStreamConformanceTests.GetUniquePipeName();\n+ PipeAccessRights rights = MinimumMessageAccessRights & ~PipeAccessRights.WriteAttributes;\n+\n+ using NamedPipeServerStream server = new NamedPipeServerStream(pipeName, PipeDirection.InOut, 1, PipeTransmissionMode.Message);\n+ using NamedPipeClientStream client = new NamedPipeClientStream(\".\", pipeName, rights, PipeOptions.None, Security.Principal.TokenImpersonationLevel.None, HandleInheritability.None);\n+\n+ Task serverConnected = server.WaitForConnectionAsync();\n+ client.Connect();\n+ await serverConnected;", | |
| "body": "These tests are focused on the message mode itself, not the aspect of making connections, so I'll leave that out of scope to ensure all combinations of sync/async connections are covered. But I'll standardize onto `Task.WaitAll(server.WaitForConnectionAsync(), client.ConnectAsync())` instead of mixing sync/async to make it more readable.\r\n\r\nSince the access rights overload throws on non-Windows platforms, I'll keep these tests in a separate file too (otherwise, they'd need to all be `[PlatformSpecific(TestPlatforms.Windows)]`).", | |
| "createdAt": "2024-03-26T05:17:55Z" | |
| } | |
| ] | |
| } | |
| } | |
| ] | |
| }, | |
| "commits": { | |
| "totalCount": 7, | |
| "nodes": [ | |
| { | |
| "commit": { | |
| "oid": "6ca147bf996f585931b64177096050d837b9ef1e", | |
| "message": "Support setting NamedPipeClientStream.ReadMode with PipeAccessRights ctor overload", | |
| "committedDate": "2024-03-20T09:09:23Z" | |
| } | |
| }, | |
| { | |
| "commit": { | |
| "oid": "d5eacc149076afd03f3d53323be1602da2dc694e", | |
| "message": "Add API doc comments for new constructor (and fix placement of comment)", | |
| "committedDate": "2024-03-20T09:24:24Z" | |
| } | |
| }, | |
| { | |
| "commit": { | |
| "oid": "5bdf1c858a4ad483a6653e62886847b2f0feee34", | |
| "message": "Add more tests including functional tests. Fill an argument validation gap.", | |
| "committedDate": "2024-03-22T01:09:57Z" | |
| } | |
| }, | |
| { | |
| "commit": { | |
| "oid": "2cfb092d293dd126e2b02b68aa80c91c98351396", | |
| "message": "Merge branch 'main' into jeffhandley/namedpipe-readmode", | |
| "committedDate": "2024-03-22T06:19:36Z" | |
| } | |
| }, | |
| { | |
| "commit": { | |
| "oid": "6d7aad7900110947ee565a0bc7bb111ab29b8759", | |
| "message": "Remove old ApiCompat suppression from PipeAccessRights", | |
| "committedDate": "2024-03-22T06:30:59Z" | |
| } | |
| }, | |
| { | |
| "commit": { | |
| "oid": "8c0a19e05cc847fac12bac17d06d5038882c7dd0", | |
| "message": "Make new tests more readable per PR feedback", | |
| "committedDate": "2024-03-26T05:47:08Z" | |
| } | |
| }, | |
| { | |
| "commit": { | |
| "oid": "481df95464dc298e111fc9b3e3e0659f8ad82b99", | |
| "message": "Merge branch 'main' into jeffhandley/namedpipe-readmode", | |
| "committedDate": "2024-03-26T23:02:29Z" | |
| } | |
| } | |
| ] | |
| } | |
| } |