sha
stringlengths
1
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85.4k
4189eb0f5ef9b8d468131adcae6d8f006abc1ada
Robert Jackson
Robert Jackson
Set outlet state prior to rendering {{outlet}} in tests.
set outlet state prior to rendering {{outlet}} in tests
55
false
false
9
false
false
false
emberjs
ember.js
12,400
73881e41290eb86850193fb34e085d7e46c53641
Robert Jackson
Robert Jackson
Fix dynamic `makeViewHelper`.
fix dynamic `makeviewhelper`
28
false
false
3
true
true
true
emberjs
ember.js
12,401
57f05daa8fc4fd94e3507e4dab2bcbab3e32f699
Robert Jackson
Robert Jackson
Fix dynamic `makeViewHelper`.
fix dynamic `makeviewhelper`
28
false
false
3
true
true
true
emberjs
ember.js
12,402
c762400b954e044adbc568a0db9e312a6eb3ce9e
Robert Jackson
Robert Jackson
Merge pull request #10977 from fivetanley/bower-idemptotent-rerender publish idemptotent rerender to bower
merge pull request from fivetanley/bower-idemptotent-rerender
62
true
false
5
true
false
false
emberjs
ember.js
12,403
2d501df08085018bcab80148ce941ce4410a6c03
Robert Jackson
Robert Jackson
Remove unused imports in Ember.TextArea.
remove unused imports in ember.textarea
39
false
false
5
true
true
true
emberjs
ember.js
12,404
0e674a4eb9e08ad98909db8de78b89e505114405
Robert Jackson
Robert Jackson
Update HTMLBars to v0.13.11. * Remove 'value' attribute hacks. * Add `AttrMorph.prototype.getContent`.
update htmlbars to v0.13.11
27
false
false
4
true
true
true
emberjs
ember.js
12,405
a80574534bf0ec76d34ac3cdbc956df03c2fe183
Robert Jackson
Robert Jackson
Use readDOMAttr + attributeBinding for <textarea>. The new `readDOMAttr` API allows us to remove this manual `value` property binding in `Ember.TextArea`.
use readdomattr + attributebinding for <textarea>
49
false
false
6
true
true
true
emberjs
ember.js
12,406
918f69d943e63a9ec4ce3004a1f889f64f8b8f95
Yehuda Katz
Yehuda Katz
Adds a way to reliably read from DOM The readDOMAttr method on views makes it possible to read an attribute from DOM and update the internal lastValue at the same time. This effectively fixes the fact that some attribute sets are not idempotent, which causes problems for the write-only pure-function rendering model u...
adds a way to reliably read from dom
36
false
false
8
false
false
false
emberjs
ember.js
12,407
b12adfb3d8e64a2f73dca2370d3c37cf366d9c1a
Yehuda Katz
Yehuda Katz
Fixes input getting re-rendered incorrectly
fixes input getting re-rendered incorrectly
43
false
false
5
false
false
false
emberjs
ember.js
12,408
c0df0cd60db89af1c1ca815afc43c8505f6c0bf5
Robert Jackson
Robert Jackson
Fix failed teardown in `View.prototype.appendTo` tests.
fix failed teardown in `view.prototype.appendto` tests
54
false
false
6
false
true
false
emberjs
ember.js
12,409
18bf2f3a11f2c13d05f327413798c96e4e448960
Robert Jackson
Robert Jackson
Bump HTMLBars version to 0.13.10.
bump htmlbars version to 0.13.10
32
true
false
5
true
true
false
emberjs
ember.js
12,410
4e585da9dc2882e6babd11499acad6e450805eb9
Yehuda Katz
Yehuda Katz
Fix issue with inputs getting re-rendered
fix issue with inputs getting re-rendered
41
false
false
6
true
true
true
emberjs
ember.js
12,411
8e82692bc61a68f15553648d93cb383c1f9366e9
Matthew Beale
Matthew Beale
Style cleanup to fix tests
style cleanup to fix tests
26
false
false
5
false
false
false
emberjs
ember.js
12,412
a3d4ebadefadefa68ad9f93595a75ca45a208fa6
Robert Jackson
Robert Jackson
Merge pull request #11008 from krisselden/idempotent-rerender Merge master into idempotent rerender
merge pull request from krisselden/idempotent-rerender
55
true
false
5
true
false
false
emberjs
ember.js
12,413
c340bab3acb9e33008f7e76617b23b12aba2007a
Kris Selden
Kris Selden
Merge branch 'master' into idempotent-rerender
merge branch 'master' into idempotent-rerender
46
true
false
5
false
true
false
emberjs
ember.js
12,414
a4dffa9a3a16994fc670d04edff719e22bc1e5e7
Martin Muñoz
Martin Muñoz
Make streams aware of proxies If a stream value results in a proxy, the stream will begin to observe the proxy's content and notify itself if the content changes.
make streams aware of proxies
29
false
false
5
false
true
false
emberjs
ember.js
12,415
ac680f4ae0cbb78c4f9016542d08243a84a5119c
Tom Dale
Tom Dale
Extract lookupComponent
extract lookupcomponent
23
false
false
2
true
true
false
emberjs
ember.js
12,416
ed438565fb36095393c2797104d31fc9c649445d
Tom Dale
Tom Dale
Extract simplified ComponentNodeManager
extract simplified componentnodemanager
39
false
false
3
false
true
false
emberjs
ember.js
12,417
3493fdc8d50faf21879022fe03a3f99f782a93df
Tom Dale
Tom Dale
Rename componentNode -> manager
rename componentnode -> manager
31
false
false
4
false
true
false
emberjs
ember.js
12,418
3e662449ff4a3bfb935eb0d4c34908120364df12
Tom Dale
Tom Dale
Add failing controller scope/action test
add failing controller scope/action test
40
false
false
5
false
false
false
emberjs
ember.js
12,419
1ab4ccb49f3bf3fe5b4b93301b42c12f83e6a785
Matthew Beale
Matthew Beale
Merge pull request #10993 from EndangeredMassa/patch-1 add code fences around ascii charts in text_support.js
merge pull request from endangeredmassa/patch-1
48
true
false
5
true
false
false
emberjs
ember.js
12,420
9aaa8ebbd9207ec23dabbe2c84398c4a2149d82b
Robert Jackson
Robert Jackson
Use `indexOf` from EnumerableUtils. It properly defers to the object or polyfil as needed.
use `indexof` from enumerableutils
34
false
false
4
false
true
false
emberjs
ember.js
12,421
5700eee0e7feaecbec67833b190a5dcd6a9fc29a
Yehuda Katz
Yehuda Katz
Merge pull request #10958 from mixonic/idempotent-rerender-assert-rerender Throw when rerender called after rendering
merge pull request from mixonic/idempotent-rerender-assert-rerender
68
true
false
5
true
false
false
emberjs
ember.js
12,422
ea44afbb423e1b4c06d4e6fd4ed0986f18b92797
Robert Jackson
Robert Jackson
Prevent clobbering attrs with an attr named attrs. When invoking a component like: ```javascript {{foo-bar attrs="blah"}} ``` We cannot set `this.attrs` to be equal to `"blah"`. This is potentially breaking for folks that have used `attrs` as a single attribute value in the root of a component.
prevent clobbering attrs with an attr named attrs
49
false
false
8
false
false
false
emberjs
ember.js
12,423
2b0404b75afffab5f0a039062ed6df3e7dedfda5
Robert Jackson
Robert Jackson
Update remaining skipped `View.prototype.createElement`. * Avoid using `RenderBuffer` * assert the output HTML
update remaining skipped `view.prototype.createelement`
55
false
false
4
false
false
false
emberjs
ember.js
12,424
45079478d0733ea2aa06277ab574fbe767928569
Robert Jackson
Robert Jackson
Always set `elementId`. The container view template uses `elementId` as the key for `{{each}}`. We need to ensure that even tagless views have an `elementId`.
always set `elementid`
22
false
false
3
false
false
false
emberjs
ember.js
12,425
7f0d4ed6a9d1e7a319dea288c80c5516b365725f
Robert Jackson
Robert Jackson
Use modern template in ember-testing integration tests.
use modern template in ember-testing integration tests
54
false
false
7
true
true
false
emberjs
ember.js
12,426
cd81304a549f0c2a11d175b6b3d141b155917b35
Robert Jackson
Robert Jackson
Use attrs by default and fallback to root properties in TextSupport.
use attrs by default and fallback to root properties in textsupport
67
false
false
11
true
true
false
emberjs
ember.js
12,427
505ec7346f60cabf76f24784496444150038160d
Yehuda Katz
Yehuda Katz
Merge pull request #11004 from bantic/idempotent-rerender-fix-input-types Fallback to "-text-field" component name for unrecognized input type
merge pull request from bantic/idempotent-rerender-fix-input-types
67
true
false
5
true
false
false
emberjs
ember.js
12,428
5a1c5e1ec740658f1dffdb491509a6036502803c
Cory Forsyth
Cory Forsyth
Fallback to "-text-field" component name for unrecognized input type Previously, using an input type not in the map (such as "email") would cause an exception. This renames the `classification` var to more expressive `componentNameMap`, and turns the map into a whitelist of non-default component names only. Any value ...
fallback to "-text-field" component name for unrecognized input type
68
false
false
9
false
false
false
emberjs
ember.js
12,429
8d720b92c58d63ea9654f4a43cc5e8b57dbe241c
Trek Glowacki
Trek Glowacki
Merge pull request #11003 from trek/remove-unused-controller-property Remove `_pCacheMeta` property on controllers, which appears to just be leftover from an earlier time.
merge pull request from trek/remove-unused-controller-property
63
true
false
5
true
false
false
emberjs
ember.js
12,430
4a9a4e6db51f5b2314ae2a65f4cbdb939759a752
Trek Glowacki
Trek Glowacki
Remove `_pCacheMeta` property on controllers, which appears to just be leftover from an earlier time.
remove `_pcachemeta` property on controllers, which appears to just be
70
false
false
10
false
true
false
emberjs
ember.js
12,431
fd1550384817cc30fd25f236635ed329385679a0
Alex Matchneer
Alex Matchneer
Merge pull request #11001 from trek/move-qp-config-to-routes Remove vestigial `states.changingKeys`
merge pull request from trek/move-qp-config-to-routes
54
true
false
5
true
false
false
emberjs
ember.js
12,432
a991d78f38767522d16f47eb4573042f55be1a96
Trek Glowacki
Trek Glowacki
Clarifies intetend of `states.inactive` `states.inactive` is just a clever (and expensive) way of saying "null". This also saves you the time of wonder WTH `states.inactive` is defined.
clarifies intetend of `states.inactive`
39
false
false
4
false
false
false
emberjs
ember.js
12,433
37b21bf917ac00fe70ace5c6a37419f2110b583a
Trek Glowacki
Trek Glowacki
Remove vestigial `states.changingKeys`
remove vestigial `states.changingkeys`
38
false
false
3
true
true
true
emberjs
ember.js
12,434
5725b5cb1f39fdabb7f068bfbbe4c5fd58e3494c
Robert Jackson
Robert Jackson
Merge pull request #10991 from mitchlloyd/view-computed-controller Fix a test for view controller property
merge pull request from mitchlloyd/view-computed-controller
60
true
false
5
true
false
false
emberjs
ember.js
12,435
3ba81e3162bc49cac5abe2c59ef351abe38506e9
Robert Jackson
Robert Jackson
Merge pull request #10999 from mitchlloyd/fix-create-child-view-tests Consistently use `parentView` over `_parentView`
merge pull request from mitchlloyd/fix-create-child-view-tests
63
true
false
5
true
false
false
emberjs
ember.js
12,436
d5fe775738e30e52dc0872068426e0c3b786602d
Mitch Lloyd
Mitch Lloyd
Consistently use `parentView` over `_parentView`
consistently use `parentview` over `_parentview`
48
false
false
5
false
false
false
emberjs
ember.js
12,437
ce28b3ca811e520e86de8caa8a632fab58c6c4bf
Mitch Lloyd
Mitch Lloyd
Notify view controller when its parentView changes
notify view controller when its parentview changes
50
false
false
7
true
true
true
emberjs
ember.js
12,438
e9221691fe8c4a116555f700d1f684fabd7d94a3
Yehuda Katz
Yehuda Katz
Don't leak the stream into user code In the previous commit, mutable bindings had a value() method that was a live reflection of the underlying stream. Those semantics were inconsistent with immutable bindings, which only update during the rendering process and trigger lifecycle hooks. This commit snapshots the value...
don't leak the stream into user code
36
false
false
7
false
false
false
emberjs
ember.js
12,439
28f04c63dd03aabfc93961959c23b569c391caa0
Yehuda Katz
Yehuda Katz
Mostly complete impl of mutable bindings There are two failing tests related to timing and I want to investigate an alternate approach for mutable cells.
mostly complete impl of mutable bindings
40
false
false
6
false
false
false
emberjs
ember.js
12,440
cb5f07ce5b57c9bbfe99557a29d8ed16297e477d
Robert Jackson
Robert Jackson
Add integration test for makeViewHelper looked up from the container.
add integration test for makeviewhelper looked up from the container
68
false
false
10
true
true
false
emberjs
ember.js
12,441
9c9c45c3bebeb7fd3abc79a52bc7f17129e38c4e
Robert Jackson
Robert Jackson
Make proper test for makeViewHelper being looked up lazily from container.
make proper test for makeviewhelper being looked up lazily from container
73
false
false
11
true
true
false
emberjs
ember.js
12,442
85cda2e9c2b9d7d612cbe105bf4985f7cf49eff4
Tom Dale
Tom Dale
Allow {{with}} to bind controller
allow {{with}} to bind controller
33
false
false
5
false
true
false
emberjs
ember.js
12,443
dc97966be2134d794611b0c693193caad8207dc0
Tom Dale
Tom Dale
Preserve controller instance across rerenders
preserve controller instance across rerenders
45
false
false
5
true
true
true
emberjs
ember.js
12,444
b9eb523fc562f67921bb1c43a021044661a15683
Tom Dale
Tom Dale
Refactor controller binding
refactor controller binding
27
false
false
3
false
false
false
emberjs
ember.js
12,445
ccc13a67f3649cf27d8307242a656707ccb40c5c
Tom Dale
Tom Dale
Set controller inside {{#each arrayController}}
set controller inside {{#each arraycontroller}}
47
false
false
5
false
true
false
emberjs
ember.js
12,446
9681ce8a1e4881cfb25a8c647ac448a7093400d2
Sean Massa
Sean Massa
add code fences around ascii charts in text_support.js The [rendered docs](http://emberjs.com/api/classes/Ember.TextSupport.html) do not show these charts properly. I added code fences around them. If there is some better way to address this, feel free to let me know or just close this PR and updated it yourself. N...
add code fences around ascii charts in text_support.js
54
false
false
8
true
true
false
emberjs
ember.js
12,447
a2d9a41354d40c2737a64c94308bd488562fd713
Robert Jackson
Robert Jackson
Fix incorrect `typeOf` import. `typeOf` moved from `ember-metal/utils` to `ember-runtime/utils` as of https://github.com/emberjs/ember.js/pull/10988.
fix incorrect `typeof` import
29
false
false
4
true
true
true
emberjs
ember.js
12,448
53e6ebaeff50de9265cff4bfacf6611ac9576b19
Robert Jackson
Robert Jackson
Fix lint errors. * `get` was unused in ember-routing-htmlbars/keywords/action * Indentation was incorrect in ember-htmlbars/tests/integration/mutable_binding_test
fix lint errors
15
false
false
3
true
true
true
emberjs
ember.js
12,449
6af18a07a8f4f242dfde1331ceea37b1cfc8b2c8
Robert Jackson
Robert Jackson
Merge pull request #10990 from krisselden/idempotent-rerender Idempotent rerender
merge pull request from krisselden/idempotent-rerender
55
true
false
5
true
false
false
emberjs
ember.js
12,450
5e371c0af5adf29339e53e13f9c9b3a3c8047303
Kris Selden
Kris Selden
Merge branch 'master' into idempotent-rerender Conflicts: packages/ember-views/lib/attr_nodes/legacy_bind.js packages/ember-views/lib/mixins/class_names_support.js packages/ember-views/lib/streams/should_display.js packages/ember-views/lib/views/collection_view.js packages/ember-views/lib/views/core_view.js pack...
merge branch 'master' into idempotent-rerender
46
true
false
5
false
true
false
emberjs
ember.js
12,451
6991d73675b1c43d0e19c26a4bb3d4f36bc3b280
Kris Selden
Kris Selden
Merge pull request #10988 from emberjs/move-is-array-and-type-of Move Ember.typeOf and Ember.isArray back into ember-runtime.
merge pull request from emberjs/move-is-array-and-type-of
58
true
false
5
true
false
false
emberjs
ember.js
12,452
19b2a72c46bac02688893c99c830496555ef9c21
Kris Selden
Kris Selden
Move Ember.typeOf and Ember.isArray back into ember-runtime. These should have never been moved into ember-metal as they depend on ember-runtime. The uses of them in ember-metal was few and dubious.
move ember.typeof and ember.isarray back into ember-runtime
59
false
false
7
true
true
false
emberjs
ember.js
12,453
2b5a6dc508107abba91bceac8d7f5785d441222f
Martin Muñoz
Martin Muñoz
Bump emberjs-build to 0.1.1
bump emberjs-build to 0.1.1
27
true
false
4
true
true
false
emberjs
ember.js
12,454
8732970e6bee9deea2fb17e68f658c1bb5387efd
Martin Muñoz
Martin Muñoz
Fix controller usage in {{action}} and sendAction
fix controller usage in {{action}} and sendaction
49
false
false
7
true
true
true
emberjs
ember.js
12,455
d3ce9787236da793d0b68e7059fc91207470f734
Martin Muñoz
Martin Muñoz
Recover willCreateElement hook to support instrumentation
recover willcreateelement hook to support instrumentation
57
false
false
6
true
true
false
emberjs
ember.js
12,456
c8dfd40c941fe917f19c2d462490ad1ecea63d18
Martin Muñoz
Martin Muñoz
Fix preventDefault on link-to
fix preventdefault on link-to
29
false
false
4
true
true
true
emberjs
ember.js
12,457
f0ca0686c5a92cd1230b9bbb5e4a5ca7dfa762de
Tom Dale
Tom Dale
Fix incomplete query params support in LinkView
fix incomplete query params support in linkview
47
false
false
7
false
true
false
emberjs
ember.js
12,458
60dc11f3c57f75579c6d64fafbab66393ada98fc
Tom Dale
Tom Dale
Assert when calling view helpers with params
assert when calling view helpers with params
44
false
false
7
false
false
false
emberjs
ember.js
12,459
f68ceeb01a65f8c53e15ecfa3b2c3dad490493d0
Yehuda Katz
Yehuda Katz
Add support for intercepting get and set These hooks are internal-only, not exposed publicly, and are only intended to be used to emulate deprecated functionality for the moment.
add support for intercepting get and set
40
false
false
7
true
true
true
emberjs
ember.js
12,460
ab20172c1432b715347fb15b878f78958b9961be
Tom Dale
Tom Dale
Unskip some link-to tests
unskip some link-to tests
25
false
false
4
false
false
false
emberjs
ember.js
12,461
9d0b5a4c7490a4f321bbeae1c0dcd6f99e55bff4
Tom Dale
Tom Dale
Bump htmlbars version
bump htmlbars version
21
true
false
3
true
true
false
emberjs
ember.js
12,462
79c06f10da33ddc08e0f8737cfe3a9611d9a49b8
Tom Dale
Tom Dale
Support re-rendering inside lifecycle hooks
support re-rendering inside lifecycle hooks
43
false
false
5
false
true
false
emberjs
ember.js
12,463
6d43084109df897b8acb6adcac637748a37de282
Matthew Beale
Matthew Beale
Throw when rerender called after rendering Just before a block is rendered, views are put into a renderedViews list. When `rerender` is called, this list is checked to ensure the view being rerendered has not already been rerendered.
throw when rerender called after rendering
42
false
false
6
false
false
false
emberjs
ember.js
12,464
8737c41cfe98f8b331118b98d16ca52d5375c97c
Robert Jackson
Robert Jackson
Merge pull request #10896 from koriroys/kjr/refactor-each-with-index extract nested if from each-with-index code
merge pull request from koriroys/kjr/refactor-each-with-index
62
true
false
5
true
false
false
emberjs
ember.js
12,465
cc26fb7c4ad9610b3693006afd4cd68876dffb62
Kori Roys
Kori Roys
code cleanup related to each-with-index feature flagging for each-with-index no longer necessary extract nested if from each-with-index code
code cleanup related to each-with-index
39
false
false
5
false
false
false
emberjs
ember.js
12,466
967fd42854f90e27e264bfe333093c834da915b0
Yehuda Katz
Yehuda Katz
Initial incomplete impl of mut bindings
initial incomplete impl of mut bindings
39
false
false
6
false
false
false
emberjs
ember.js
12,467
f74f109b5bbe9c0a5c483b90e2056b9835398252
Stanley Stuart
Stanley Stuart
publish glimmer builds to bower
publish glimmer builds to bower
31
false
false
5
false
true
false
emberjs
ember.js
12,468
afa11990bc2dff11faff353d0b159fff45acbe8a
Tom Dale
Tom Dale
Merge branch 'master' into idempotent-rerender
merge branch 'master' into idempotent-rerender
46
true
false
5
false
true
false
emberjs
ember.js
12,469
a3f96a8ddfd06e53dccc35c3840180711fc46a2f
Tom Dale
Tom Dale
Merge branch 'idempotent-rerender' of http://github.com/emberjs/ember.js into idempotent-rerender
//github.com/emberjs/ember.js into idempotent-rerender
54
false
false
3
false
false
false
emberjs
ember.js
12,470
d31876afb241986978d7c4472fc12ddfc195f9c7
Tom Dale
Tom Dale
Resolve master merge conflicts
resolve master merge conflicts
30
false
false
4
true
true
true
emberjs
ember.js
12,471
4df389443987f164c31c30711e03b65bdc1c4ddd
Martin Muñoz
Martin Muñoz
Rename SimpleStream to ProxyStream
rename simplestream to proxystream
34
false
false
4
false
true
false
emberjs
ember.js
12,472
af36378a5dc6c5b9e0b38af1f8825b344197075f
Martin Muñoz
Martin Muñoz
Differentiate between mutable and immutable dependencies this.addDependency now assumes that the dependee is immutable. In particular this means that it no longer returns the Dependency instance. If you need access to the dependency you must now call this.addMutableDependency. This change allows this.addDependency to...
differentiate between mutable and immutable dependencies
56
false
false
6
false
false
false
emberjs
ember.js
12,473
82b6968b8b3520d968a5bfb0fc5d758b919f6feb
Martin Muñoz
Martin Muñoz
Refactor SubexprStream
refactor subexprstream
22
false
false
2
false
false
false
emberjs
ember.js
12,474
af5c3ead94fa4603acd0a58ac868e84dc1b533f7
Martin Muñoz
Martin Muñoz
Only proxy through dependencies when necessary, and make it painfully obvious
only proxy through dependencies when necessary, and make it painfully obvious
77
false
false
11
false
false
false
emberjs
ember.js
12,475
b162d69debcbb397a36d18394f3ed922307b936b
Robert Jackson
Robert Jackson
Merge pull request #10969 from machty/ir-qp Get remainder of query_params_test.js passing
merge pull request from machty/ir-qp
37
true
false
5
true
false
false
emberjs
ember.js
12,476
97c10391c8d3a98c5ffba3a940f2b3dcf73485e2
machty
machty
Get remainder of query_params_test.js passing And a link-to test
get remainder of query_params_test.js passing
45
false
false
5
true
true
true
emberjs
ember.js
12,477
9e91371e8f50ff40e3160c17a48fb9ea432e85fa
Robert Jackson
Robert Jackson
Merge pull request #10968 from cibernox/fix_breaking_assertion_on_cps [BUGFIX beta] Fix assertion to make sure doesn't affect old CP syntax
merge pull request from cibernox/fix_breaking_assertion_on_cps
63
true
false
5
true
false
false
emberjs
ember.js
12,478
332bf345ab4109b8a8194e0b2d6fcdd0b387d759
Miguel Camba
Miguel Camba
Fix assertion to make sure doesn't affect old CP syntax
fix assertion to make sure doesn't affect old cp syntax
55
false
false
10
true
true
false
emberjs
ember.js
12,479
20d9700e5763869e9a0714cafa32210009222014
Stefan Penner
Stefan Penner
Merge pull request #10950 from cibernox/es6-getters-setters-in-cps Use nicer ES6 syntax for get/set on CPs
merge pull request from cibernox/es6-getters-setters-in-cps
60
true
false
5
true
false
false
emberjs
ember.js
12,480
0f66c76d5c2453a06f001c1089510de8da8d22ae
Miguel Camba
Miguel Camba
Use nicer ES6 syntax for get/set on CPs
use nicer es6 syntax for get/set on cps
39
false
false
8
true
true
true
emberjs
ember.js
12,481
6f090c90bd861e1e065751c9845c1b7907892b22
Stefan Penner
Stefan Penner
Merge pull request #10963 from apaganobeleno/passing-jshint [cleaning] removing illegal trailing space
merge pull request from apaganobeleno/passing-jshint
53
true
false
5
true
false
false
emberjs
ember.js
12,482
6b6379cb3dad892536d02c4cea0fe4ac85d1273b
Antonio Pagano
Antonio Pagano
[cleaning] removing illegal trailing space
[cleaning] removing illegal trailing space
42
false
false
5
false
false
false
emberjs
ember.js
12,483
f9a192abc0d4803ea404c8744fa777f2dd3ea4f1
Robert Jackson
Robert Jackson
Merge pull request #10960 from mitchlloyd/tagless-assertion Add back assertion for tagless components with classNameBindings
merge pull request from mitchlloyd/tagless-assertion
53
true
false
5
true
false
false
emberjs
ember.js
12,484
ba5f1cfc3a856a1e46e14431d80986eeb9337dfb
Mitch Lloyd
Mitch Lloyd
Add back assertion for tagless components
add back assertion for tagless components
41
false
false
6
false
true
false
emberjs
ember.js
12,485
af75b400ea0af9af3c06080eb2c593b1d3079853
Matthew Beale
Matthew Beale
Fix arguments to handlebars compat helpers, and render return values
fix arguments to handlebars compat helpers, and render return values
68
false
false
10
true
true
false
emberjs
ember.js
12,486
32d8584ff3a84960c10c48f5bbbeae3df5732699
Matthew Beale
Matthew Beale
Port deprecated tests, add test for passing attrs prop to component
port deprecated tests, add test for passing attrs prop to component
67
false
false
11
false
false
false
emberjs
ember.js
12,487
10d0861673f1ba5ef93672c0b5ae5f1a85ca8512
Matthew Beale
Matthew Beale
Update template_test to use compiled templates
update template_test to use compiled templates
46
false
false
6
false
true
false
emberjs
ember.js
12,488
210a47c1118ddf293ddc2720c4335443ae9f5fc0
Robert Jackson
Robert Jackson
Update HTMLBars to 0.13.8.
update htmlbars to 0.13.8
25
false
false
4
true
true
true
emberjs
ember.js
12,489
8578ade9755a3ddf4e9436e89e09502f1bae9d83
Matthew Beale
Matthew Beale
Fix layout tests
fix layout tests
16
false
false
3
true
true
true
emberjs
ember.js
12,490
d739bd0e784eaee631556c86a2150b2d723bdca6
Matthew Beale
Matthew Beale
Merge pull request #10957 from mitchlloyd/view-attr-fixes View attribute fixes
merge pull request from mitchlloyd/view-attr-fixes
51
true
false
5
true
false
false
emberjs
ember.js
12,491
c4cf0ef406049a33131498959b87bf998be74687
Mitch Lloyd
Mitch Lloyd
Disallow spaces in classNameBindings property Interestingly, spaces are allowed when setting classNameBindings on a view inside of a template. {{view classNameBindings="prop:true:false anotherProp:more-true:more-false"}} However, they are not allowed when setting the property on a view class: Ember.View.create({ ...
disallow spaces in classnamebindings property
45
false
false
5
false
true
false
emberjs
ember.js
12,492
f224f28db3f7c9763c101a2482da7630dd8fd68b
Mitch Lloyd
Mitch Lloyd
Update number of observers in test It seems that this test was passing in spirit: the number of observers does not increase when rerendering.
update number of observers in test
34
false
false
6
false
true
false
emberjs
ember.js
12,493
e5d76eec9e857f3eabe47ccbeac7768ba61f6916
Mitch Lloyd
Mitch Lloyd
Add assertion on 'class' for attributeBindings
add assertion on 'class' for attributebindings
46
false
false
6
true
true
true
emberjs
ember.js
12,494
c278ff54d9721c1babc4b32cc0561fd6c7e55d00
Mitch Lloyd
Mitch Lloyd
Allow attr names with `:` in attributeBindings
` in attributebindings
22
false
false
3
false
false
false
emberjs
ember.js
12,495
97fa5ea1e36bbb9fece7dc13e9706ba82d8e6d50
Matthew Beale
Matthew Beale
Use unbound to assert dom rerender
use unbound to assert dom rerender
34
false
false
6
true
true
true
emberjs
ember.js
12,496
96895af571f211afd78300f9a76ec8834ccee10f
Matthew Beale
Matthew Beale
Revert incorrectly bumped htmlbars in a79c5868
revert incorrectly bumped htmlbars in a79c5868
46
false
false
6
false
false
false
emberjs
ember.js
12,497
4181cc962399cbce4d4b36a2f95bd6c696f168b1
Matthew Beale
Matthew Beale
Remove unnnecessary test
remove unnnecessary test
24
false
false
3
true
true
true
emberjs
ember.js
12,498
a79c586846362e066a8cece6dba8f1ec92061671
Matthew Beale
Matthew Beale
Tweak childNodes to fix test
tweak childnodes to fix test
28
false
false
5
false
true
false
emberjs
ember.js
12,499