id
int64
2.74B
3.05B
title
stringlengths
1
255
user
stringlengths
2
26
state
stringclasses
2 values
labels
listlengths
0
24
comments
int64
0
206
author_association
stringclasses
4 values
body
stringlengths
7
62.5k
is_title
bool
1 class
2,812,541,502
Add correct `__repr__` for parallel distributed modules
ArthurZucker
open
[ "oncall: distributed", "triaged", "oncall: pt2" ]
3
NONE
### 🚀 The feature, motivation and pitch Sorry if this is a duplicated, but instantiating a `transformers` and paralellizing will print the same model, which is unintuitive. ```python import torch import os from transformers import LlamaConfig, LlamaModel model_id = "meta-llama/Meta-Llama-3-8B-Instru...
true
2,812,534,440
Add `sharding strategy` for `torch.distributed.tensor.parallel.ParallelStyle` with `inference_mode`
ArthurZucker
closed
[ "oncall: distributed", "triaged", "module: dtensor" ]
3
NONE
### 🚀 The feature, motivation and pitch When using tensor parallel and `with torch.inference_mode()`, any `torch.distributed.tensor.parallel.ParallelStyle` layers, we have: `aten.mm.default: got mixed torch.Tensor and DTensor, need to convert all torch.Tensor to DTensor before calling distributed operators!`. With ...
true
2,812,288,005
internal assert failed -- trying to update all from pinokio comfy ui
lingtalfi
closed
[ "module: windows", "triaged" ]
3
NONE
### 🐛 Describe the bug I'm on windows 11, with nvidia 4090, and playing with comfyUI installed via pinokio. Everything works well, but when i clicked the "update all" button from the comfyUI's node manager button, i got this message that suggested me to report the bug to pyTorch, so here i am. Note that i can just r...
true
2,812,281,001
[dynamo][dicts] Fix dict.__new__ bug
anijain2305
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145559 * #145753 * #145744 * __->__ #145723 * #145558 * #145547 * #145519 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,812,237,128
[MPS] optimize cholesky
Isalia20
closed
[ "triaged", "open source", "Merged", "module: mps", "release notes: mps", "ciflow/mps" ]
4
COLLABORATOR
Followup to #145701 Optimizes the syrk and trsm kernels of cholesky decomposition on mps. For SYRK kernel it does matmuls with apple's simdgroup matrices instead of a tiled implementation and for trsm kernel we do vectorized loads. Also this PR puts command encoder inside of the stream queue dispatch (as discussed ...
true
2,812,227,068
[Customized Optimus][Inductor] Add split cat pattern in aten level
mengluy0125
closed
[ "fb-exported", "Merged", "ciflow/trunk", "module: inductor", "ciflow/inductor", "release notes: inductor", "inductor_pattern_match" ]
7
CONTRIBUTOR
Summary: Thanks Microve for discovering that recGPT has some repeated similar kernels that might be optimized through optimus. After investigation, I designed a pattern in the aten level to remove such excessive kernels. trace: https://fburl.com/perfdoctor/82fauil7 tlparse: https://fburl.com/98q6tadx Test Plan: # uni...
true
2,812,161,492
Fix support for nccl < 2.17
oraluben
open
[ "oncall: distributed", "open source", "ciflow/trunk", "release notes: distributed (c10d)", "topic: not user facing" ]
28
CONTRIBUTOR
Fix build failure with older (< 2.17) NCCL. Refactoring NCCL version related code: 1. Fix failure against old NCCL versions since #138527 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o ; 2. remove unused checks caused by unsupported NCCL version (since there's a static asser...
true
2,812,082,404
[BE] Use copy_method to import all tests
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145718 Less chances for typo when doing the imports cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @...
true
2,812,035,836
add input shape check for _local_scalar_dense
jiayisunx
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing" ]
4
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145717 Fix https://github.com/pytorch/pytorch/issues/145066.
true
2,812,022,132
support arm architectures in your Docker images on docker hub? (
cboettig
open
[ "triaged", "enhancement", "module: docker", "module: arm" ]
2
NONE
### 🚀 The feature, motivation and pitch `pytorch` images on Docker Hub are still only available for amd64 architectures. Nvidia/cuda images support both arm64 and amd64. I believe we are seeing more and more devices offering Nvidia GPUs witth ARM cpu architecture, and multi-arch builds are commonplace. It would be ...
true
2,811,957,447
Log cache state for AOTAutograd in title of file
jamesjwu
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145715 Differential Revision: [D68692755](https://our.internmc.facebook.com/intern/diff/D68692755/) cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @...
true
2,811,947,398
setitem node shouldn't be deadcode eliminated
leslie-fang-intel
closed
[ "open source", "Merged", "ciflow/trunk", "release notes: fx", "fx" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145714 **Summary** Fix issue https://github.com/pytorch/pytorch/issues/145697. The `operator.setitem` has been eliminated as dead code, causing a correctness issue. Mark it as impure in this PR to avoid this side effect. **TestP...
true
2,811,856,964
Doubt about the actual behavior of handle.wait() in torch.distributed
Edenzzzz
closed
[ "oncall: distributed", "triaged" ]
7
NONE
### 📚 The doc issue For `comm_handle.wait()` in the case of async comm, the doc (https://pytorch.org/docs/stable/distributed.html#synchronous-and-asynchronous-collective-operations) says `In the case of CUDA collectives, will block until the operation has been successfully enqueued onto a CUDA stream and the output ...
true
2,811,816,932
[inductor] Remove type ignores from scheduler.py
jansel
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145712 * #145692 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aak...
true
2,811,812,021
[Inductor-CPU] Templated codegened kernel name may not correctly reflect epilogue fusions
sanchitintel
open
[ "oncall: pt2", "oncall: cpu inductor" ]
4
COLLABORATOR
### 🐛 Describe the bug Ran LLaMA2 with BF16 AMP & max-autotune enabled for CPU. Some codegened kernel names are of the type `cpp_fused_add_mul_silu_xxx`, but `SiLU` & `mul` are not present in the generated code, and the only epilogue present in the sample codegened code below is `add`. UPDATE: The issue is related ...
true
2,811,805,366
LBFGS-B with cuda implementation (and CPU one too)
AnFunctionArray
open
[ "module: optimizer", "triaged" ]
4
NONE
### 🚀 The feature, motivation and pitch I've found LBFGS to be bottleneck in my application, so I searched and found [this](https://github.com/raymondyfei/lbfgsb-gpu) - then I implemented in my own LBFGS1.cpp and LBFGS1.h using the cuda files from [culbfgsb](https://github.com/raymondyfei/lbfgsb-gpu/tree/master/culbf...
true
2,811,794,179
[Inductor-CPU] Templated codegened kernel names are ambiguous in PyTorch profiler results
sanchitintel
open
[ "oncall: pt2", "oncall: cpu inductor" ]
1
COLLABORATOR
### 🐛 Describe the bug When max-autotune is used with Inductor-CPU & PyTorch Profiler is used to collect performance data, kernel names are ambiguous - when a templated FlexAttention kernel or a templated GEMM is used, the kernel name doesn't reflect whether the kernel pertains to GEMM or to attention. e.g. `cpp_fus...
true
2,811,756,969
PEP585: .github release triggers
aorenste
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145708
true
2,811,756,935
PEP585: .github
aorenste
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145708 * __->__ #145707
true
2,811,734,182
Modify torch/_functorch/_aot_autograd/dispatch_and_compile_graph.py
rec
closed
[ "ciflow/inductor" ]
1
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145706 * #145636
true
2,811,726,803
[MPSInductor] Add rand support
malfet
closed
[ "Merged", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145718 * __->__ #145705 Using Philox4 as PRNG Test plan (other that CI) Run ```python mport torch from torch._inductor.utils import run_and_get_code from contextlib import nullcontext def foo(x): return x * torch.randn_like(...
true
2,811,650,043
Bot spamming on PR trying to deploy to upload-benchmark-results environment
huydhn
closed
[ "triaged", "module: devx" ]
6
CONTRIBUTOR
### 🐛 Describe the bug Reported by @ezyang, for example https://github.com/pytorch/pytorch/pull/144695 <img width="903" alt="Image" src="https://github.com/user-attachments/assets/099bbf5d-340a-4ccc-9cfe-000569e55b03" /> ### Versions The issue manifests on both regular and ghstack PRs cc @ZainRizvi @kit1980 @clee...
true
2,811,644,603
CUDA IPC tensors keep occupying GPU memory that cannot be freed
fingertap
closed
[]
0
NONE
### 🐛 Describe the bug CUDA IPC is very important for sharing tensors between multiple ray actors in RL applications to accelerate the communication. Currently the CUDA IPC memory cannot get freed: ```python import ray import torch from torch.multiprocessing.reductions import reduce_tensor def create_handle(tensor...
true
2,811,602,739
PyTorch VS2022 official build Windows binary illegal instruction on AVX2(max ISA level) CPU
xuhancn
open
[ "high priority", "module: crash", "module: build", "module: windows", "module: cpu", "triaged" ]
17
COLLABORATOR
### 🐛 Describe the bug # Background This issue is re-submit of https://github.com/pytorch/pytorch/issues/145042, because of we taked about this issue and we think the original issue will make us confuse it is a `XPU` related issue. But acturally it is a `CPU` only issue. # Reproduce steps: 1. It is easy step to repr...
true
2,811,472,484
[MPS] cholesky implementation
Isalia20
closed
[ "open source", "Merged", "ciflow/trunk", "topic: improvements", "release notes: mps", "ciflow/mps", "ciflow/inductor" ]
4
COLLABORATOR
Requested in #77764 Closed #144193 due to a lot of conflicts when rebasing
true
2,811,367,294
[POC] [CPU][Inductor] Support INT8 SDPA based on CPP template
Valentine233
closed
[ "open source", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
2
COLLABORATOR
This PR implements the Int8 SDPA CPU kernel based on CPP template following the RFC #144941. ARs: - [ ] INT8 SDPA patterns: - Done: FP32 with/wo mask, batch size >/= 1; - Remain: BF16 with/wo mask, batch size >/= 1. - [ ] Add the `select_strategy` to generate the kernel with various parallel loop...
true
2,811,315,942
PEP585: .github 1b1
aorenste
closed
[ "topic: not user facing" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145699
true
2,811,302,087
PEP585: .github 1b2
aorenste
closed
[ "topic: not user facing" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145698
true
2,811,298,530
Constant folding pass leads to model inference errors
fernchen
closed
[ "triaged", "oncall: pt2", "module: inductor" ]
3
NONE
### 🐛 Describe the bug I accidentally discovered that PyTorch's built-in constant folding optimization pass(`torch._inductor.constant_folding.constant_fold` ) may cause inference errors in the model in certain situations, as shown below: ```Python import torch import torch._dynamo as torch_dynamo import torchvision....
true
2,811,297,236
[CI][CUDA][cuSPARSELt] cusparselt 0.6.3 and cu121 related cleanups
nWEIdia
closed
[ "oncall: distributed", "open source", "module: amp (automated mixed precision)", "topic: not user facing", "ciflow/mps", "module: inductor", "module: dynamo", "ciflow/inductor", "module: compiled autograd" ]
4
COLLABORATOR
Fix inconsistency between CD (nightly binary) and CI (what ci jobs install for cu126) Remove remaining cu121 ci/docker jobs cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @mcarilli @ptrblck @leslie-fang-intel @jgong5 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @XiaobingS...
true
2,811,288,468
[inductor] Remove mask_str from IndexingOptions
jansel
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145689 * #145688 * __->__ #145695 * #145671 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @deser...
true
2,811,281,430
feat: improve indexing error messages
MattGPT-ai
closed
[ "triaged", "open source", "Stale", "release notes: mps" ]
3
NONE
Improves the error messages when certain tensor operations fail, for example `RuntimeError: index_select(): Expected dtype int32 or int64 for index` will now say e.g. `RuntimeError: index_select(): Expected dtype int32 or int64 for index, got float32`
true
2,811,278,439
AMD MI300A Unified Memory Support
lancelotnd
open
[ "feature", "module: rocm", "triaged", "topic: new features" ]
4
CONTRIBUTOR
### 🚀 The feature, motivation and pitch I am working on improving performance for LLM workloads on AMD Instinct™ MI300A Accelerator. This APU is equipped with a fully unified-memory architecture not taken advantage by PyTorch at this time. Because both the GPU and CPU share the same physical memory, memcpy ops become...
true
2,811,276,060
[inductor] Change type of get_backend_features to OrderedSet
jansel
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145712 * __->__ #145692 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aak...
true
2,811,275,967
[inductor] Add some typing to common.py
jansel
closed
[ "module: rocm", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145712 * #145692 * __->__ #145691 * #145690 cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhu...
true
2,811,234,883
[inductor] Add some typing to simd.py
jansel
closed
[ "Merged", "topic: not user facing", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145712 * #145692 * #145691 * __->__ #145690 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @deser...
true
2,811,224,680
[inductor] Support non-power-of-2 cooperative RSPLIT
jansel
closed
[ "Merged", "ciflow/trunk", "module: inductor", "ciflow/inductor", "release notes: inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #143812 * #142295 * __->__ #145689 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @cha...
true
2,811,224,646
[inductor] Add some typing to triton.py
jansel
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
5
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145689 * __->__ #145688 * #145695 * #145671 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @deser...
true
2,811,211,133
[Inductor-CPU] `add` is not being fused with templated int8 WoQ GEMM while running LLaMA2
sanchitintel
open
[ "oncall: pt2", "oncall: cpu inductor" ]
3
COLLABORATOR
### 🐛 Describe the bug When max-autotune is enabled with Inductor-CPU, and when int8 WoQ GEMM is used with auto-tuning enabled, `add` isn't being fused with it. So, there's an opportunity cost. i.e. For LLaMA, for BF16 dtype, with BF16 templated GEMM, we are even able to fuse `add` & RMSNorm's decomposed ops as epil...
true
2,811,162,520
[inductor] Adjust test_log_fp64 to only run when float64 is supported.
dcci
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: mps", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
6
MEMBER
cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
true
2,811,124,908
[Easy] update pip sources for ROCm in nightly pull tool
XuehaiPan
open
[ "module: rocm", "open source", "topic: not user facing", "ciflow/rocm" ]
3
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #149143 * __->__ #145685 cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd
true
2,811,113,793
[inductor triton] Disable incorrect TF32 usage on CUDA capability < 8
benjaminglass1
closed
[ "open source", "Merged", "ciflow/trunk", "release notes: cuda", "module: inductor", "ciflow/inductor" ]
5
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145683 * #145655 * #145654 * #145095 * __->__ #145684 Triton 2.2 and greater have a bug where allowing TF32 generation for a GPU that does not support TF32 will cause code generation errors. Patch around this problem by: 1. Adding a fun...
true
2,811,110,100
cpp_wrapper: fix CPU cpp_wrapper and max-autotune tests
benjaminglass1
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
8
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #146424 * #146109 * __->__ #145683 * #145655 * #145654 * #145095 Both of these tests mostly failed due to incorrect assumptions about the generated code. cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe...
true
2,811,088,644
PEP585: .github 2
aorenste
closed
[ "topic: not user facing" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145682
true
2,811,055,638
Avoid data-dependent errors by runtime assert substitution.
ysiraichi
open
[ "open source", "release notes: fx", "fx", "module: dynamo", "ciflow/inductor" ]
9
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #142372 * __->__ #145681 This PR adds a simplification method using runtime asserts, whenever we are about to raise a data-dependent error. We use the recorded runtime asserts as a source of knowledge for substituting the free symbols in the...
true
2,811,039,337
Add icdf to Gamma dist
moghadas76
open
[ "triaged", "open source", "Stale" ]
6
NONE
Fixes #145679
true
2,811,029,133
Gamma cdf function
moghadas76
open
[ "module: distributions", "triaged" ]
0
NONE
### 🐛 Describe the bug ```python chi2 = torch.distributions.Gamma(df=self.df.squeeze(-1)).icdf(uniform) ``` File "/home/seyed/miniconda3/envs/env/lib/python3.11/site-packages/torch/distributions/distribution.py", line 212, in icdf raise NotImplementedError NotImplementedError ### Versions Collecting environm...
true
2,811,019,416
torch.tensor reports inconsistent errors when running on GPU and CPU
CZXIANGOvO
closed
[]
1
NONE
### 🐛 Describe the bug # description The error messages displayed for torch.tensor on GPU and CPU are inconsistent. The error messages on GPU are very abstract and difficult to understand. The error messages on CPU are very straightforward. # GPU ```python import torch data = torch.tensor(np.random.randn(1, 10), dtyp...
true
2,810,916,337
[1/N] Improve typing in torch/_C/__init__.pyi.in
cyyever
closed
[ "oncall: distributed", "triaged", "open source", "module: amp (automated mixed precision)", "Stale", "ciflow/trunk", "topic: not user facing" ]
14
COLLABORATOR
Fixes #ISSUE_NUMBER cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @mcarilli @ptrblck @leslie-fang-intel @jgong5
true
2,810,907,179
Build RowwiseScaledMM.cu for SM89
alexsamardzic
closed
[ "oncall: distributed", "open source", "Merged", "ciflow/trunk", "topic: not user facing", "topic: build", "module: inductor", "ciflow/inductor" ]
10
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145676 cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenya...
true
2,810,815,305
[c10d] Add NCCL memory allocator
kwen2501
closed
[ "oncall: distributed", "module: nccl", "Merged", "Reverted", "ciflow/trunk", "release notes: distributed (c10d)", "ci-no-td" ]
15
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145675 This PR implements a small UI improvement over #133603. It prepares a NCCL memory allocator in torch cpp and then pybind's it out, so that user can directly use it. UI: ``` pool = torch.cuda.MemPool(backend.mem_alloca...
true
2,810,812,915
Convert Tensor lr to 0-dim as needed for the optimizer to normally work
Tony-Y
closed
[ "triaged", "open source", "Merged", "ciflow/trunk", "release notes: optim" ]
62
CONTRIBUTOR
Fixes #145461
true
2,810,747,029
[Custom Ops] Fix f-strings in custom ops error message
yanboliang
closed
[ "module: custom-operators", "Merged", "ciflow/trunk", "topic: not user facing" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145673 * #145588
true
2,810,741,786
[3/N] Remove unnecessary once flag usage
cyyever
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing" ]
9
COLLABORATOR
Fixes #ISSUE_NUMBER
true
2,810,691,146
[inductor] Fix handling of fixed XBLOCK larger than xnumel=1
jansel
closed
[ "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145689 * #145688 * #145695 * __->__ #145671 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @deser...
true
2,810,677,890
compiling for rocm gfx1010, getting cuda errors
bragadzilla
open
[ "module: build", "module: rocm", "triaged" ]
8
NONE
### 🐛 Describe the bug I am compiling for rocm, but getting a cuda error. The same error has been discussed in https://github.com/pytorch/pytorch/issues/108344, but the user said it was solved by using `USE_ROCM` and did not elaborate further. ``` export VERBOSE=1 export PYTORCH_ROCM_ARCH="gfx1010" export USE_ROCM=1...
true
2,810,670,135
[CUDA][B200] Update the number of threads in `avg_pool2d` backward for SM 10.0
eqy
closed
[ "module: cuda", "open source", "Merged", "module: pooling", "ciflow/trunk", "topic: not user facing" ]
34
COLLABORATOR
Fixes register count issue when launching on SM 10.0, originally authored by @bilal2vec cc @ptrblck @msaroufim @mikaylagawarecki
true
2,810,648,759
Pull request
rohansudarshan1810
closed
[ "open source" ]
3
NONE
Fixes #ISSUE_NUMBER
true
2,810,647,083
Make sure to evaluate annotation strings in the context of where the prototype was created
aorenste
closed
[ "Merged", "ciflow/trunk", "topic: not user facing" ]
7
CONTRIBUTOR
This was incorrectly evaluating the annotation in the context of infer_schema - make sure to evaluate annotation strings in the context of where the prototype was created instead. Fixes #145481 Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145667
true
2,810,632,136
[autocast][pytorch] Support autocast for MTIA (policy)
nautsimon
closed
[ "fb-exported", "module: amp (automated mixed precision)", "Merged", "ciflow/trunk", "topic: not user facing", "module: mtia" ]
7
MEMBER
Summary: Add autocast support for MTIA (policy) Reviewed By: egienvalue Differential Revision: D68604796 cc @mcarilli @ptrblck @leslie-fang-intel @jgong5 @egienvalue
true
2,810,632,070
Pickling duplicates Storage
roosephu
open
[ "module: pickle", "triaged" ]
2
NONE
### 🐛 Describe the bug When pickling two tensors with the same underlying storage, I expected the storage to be only pickled once. However, it seems that the storage is saved twice. ```python import torch import pickle x = torch.zeros(1_000_000) print(len(pickle.dumps(x)), len(pickle.dumps([x, x[:]]))) ``` Output...
true
2,810,570,168
Remove FBGEMM sccache hack
huydhn
closed
[ "Merged", "topic: not user facing" ]
3
CONTRIBUTOR
Testing https://github.com/pytorch/pytorch/actions/runs/12959358756, sccache is working correctly now
true
2,810,533,892
The difference between CPP and python3 on matrix permute
George0726
closed
[]
0
NONE
### 🐛 Describe the bug I am trying to implement code on CPP, However, I found that the permute and transpose functions in cpp have different values from permute python3. Besides, the tensor after view is the same and I also try ``` python output = tensor1.view(1, -1, 24, 128).permute(0, 2, 1, 3) #python3 code ``` ...
true
2,810,500,337
[CUDA] Change slim-wheel libraries load order
pytorchbot
closed
[ "open source" ]
1
COLLABORATOR
There is no libnvjitlink in CUDA-11.x , so attempts to load it first will abort the execution and prevent the script from preloading nvrtc Fixes issues reported in https://github.com/pytorch/pytorch/pull/145614#issuecomment-2613107072 cc @atalman @malfet @ptrblck @eqy @tinglvv
true
2,810,473,542
PYTORCH_NO_CUDA_MEMORY_CACHING=0 affects native allocator as if: = 1
Teriks
closed
[ "module: docs", "module: cuda", "triaged" ]
3
NONE
### 🐛 Describe the bug It came as a surprise to me that setting `PYTORCH_NO_CUDA_MEMORY_CACHING=0` is treated the same as `PYTORCH_NO_CUDA_MEMORY_CACHING=1` in the native allocator code. The python code of torch handles this envvar by checking its value, the cpp code for the allocator essentially just checks if it i...
true
2,810,449,563
Reapply "refactor tensorify restart logic to use sources (#141517)" (#143623)
bobrenjc93
closed
[ "release notes: fx", "fx", "module: dynamo", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145660 * #145659 * #145650 This reverts commit 4f8b7c4272db521f7ffc4070ce1bdece513d1183. cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @...
true
2,810,449,469
add speculation log divergence test
bobrenjc93
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
9
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145659 Followup from a SEV. Confirmed that this breaks when stacked on top of https://github.com/pytorch/pytorch/pull/145660 (offending PR that caused the SEV) cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingS...
true
2,810,431,288
[dynamo] Fix read/write conflicts in a cuda test
StrongerXi
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145658 Prior to this patch, the `test_cuda_event_created_outside_of_graph` is flaky in CI, and that's because we have read and write to the same `foo` tensor buffer from 2 different streams. This patch eliminates that by adding a syn...
true
2,810,405,320
PEP585: .github 1a
aorenste
closed
[ "topic: not user facing" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145657
true
2,810,395,787
Stable C bindings for libtorch
ehartford
open
[ "module: cpp", "triaged" ]
4
NONE
### 🚀 The feature, motivation and pitch Thank you for all your hard work on PyTorch and LibTorch! The C++ API is excellent, but there’s a recurring need across many developer communities for an official or semi-official C API (i.e., a stable libtorch_c.so / “C shim”). ## Why a C API? Language Interop: Most languages...
true
2,810,384,503
cpp_wrapper: enable all CPU repro tests
benjaminglass1
closed
[ "open source", "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
1
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #146424 * #146109 * #145683 * __->__ #145655 * #145654 * #145095 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPep...
true
2,810,384,444
cpp_wrapper: fix set_.source_Tensor lowering
benjaminglass1
closed
[ "open source", "Merged", "topic: not user facing", "module: inductor", "ciflow/inductor" ]
1
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #146424 * #146109 * #145683 * #145655 * __->__ #145654 * #145095 Adds a C-shim fallback for `set_.source_Tensor`, which is effectively required by `ir.SetSourceTensorKernel`. As a necessary prerequisite to use that IR node, updates `CppWrap...
true
2,810,373,279
[draft_export] fix dense-in-memory check for inferring fakes
pianpwk
closed
[ "fb-exported", "Merged", "ciflow/trunk", "ciflow/inductor", "release notes: export" ]
4
CONTRIBUTOR
Test Plan: fixes check for dense tensors with size-1 dimensions Differential Revision: D68644028
true
2,810,360,776
[c10d] implement ReduceOp.unbox()
yifuwang
open
[ "oncall: distributed", "open source", "Stale", "release notes: distributed (c10d)" ]
2
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145652 * #144886 ```python >>> import torch >>> op = torch.classes.c10d.ReduceOp() >>> op <torch.ScriptObject object at 0x5b688b0> >>> torch.distributed.ReduceOp.unbox(op) <torch.distributed.distributed_c10d.ReduceOp object...
true
2,810,351,107
Add link to non_blocking/pinmem tutorial in `Tensor.to` docstrings
vmoens
closed
[ "module: docs", "Merged", "ciflow/trunk", "topic: not user facing" ]
6
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145651 cc @svekars @brycebortree @sekyondaMeta @AlannaBurke
true
2,810,340,548
Fix nonzero meta function striding
bobrenjc93
closed
[ "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
1
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): Fixes #130290 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,810,306,970
Add fake_impl for unique_consecutive
zou3519
closed
[ "Merged", "ciflow/trunk", "release notes: composability", "module: dynamo", "ciflow/inductor" ]
7
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145649 Summary: It's fairly similar to torch.unique and torch.unique_dim. Test Plan: New test cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kaden...
true
2,810,290,499
Test distributions compilation
vmoens
open
[ "Stale", "topic: not user facing" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145648 * #145647 * #145646 * #145645
true
2,810,290,331
Fix distributions dynamo tracing (`__init__`, sample and log_prob)
vmoens
open
[ "Stale", "module: dynamo", "ciflow/inductor" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145648 * __->__ #145647 * #145646 * #145645 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
true
2,810,290,151
refactor Distribution class for compile support
vmoens
open
[ "Stale" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145648 * #145647 * __->__ #145646 * #145645
true
2,810,289,953
Parametrize distributions tests
vmoens
open
[ "Stale", "topic: not user facing" ]
2
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #145648 * #145647 * #145646 * __->__ #145645
true
2,810,281,752
[inductor] Fix crash running wrapper_benchmark with no device
mgraczyk
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor" ]
11
CONTRIBUTOR
Fixes #145434 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
true
2,810,268,911
[mps/inductor] Add support for `erfinv`.
dcci
closed
[ "Merged", "topic: not user facing", "module: mps", "ciflow/mps", "module: inductor", "ciflow/inductor" ]
3
MEMBER
After several rounds of refactoring, this seems to be done now. cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire ...
true
2,810,255,093
torch/utils/cpp_extension.py doesn't support sm_90a
zhengqigao
closed
[ "module: cpp-extensions", "module: cuda", "triaged", "module: regression" ]
3
NONE
### 🐛 Describe the bug I am compiling a customized CUDA extension on H200 GPU using torch.utils.cpp_extension, and get the following error: ``` /lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1973, in <listcomp> supported_sm = [int(arch.split('_')[1]) ValueError: invalid literal for int() with...
true
2,810,245,001
[CI][CUDA][Blackwell] sm_\d\d no longer matches sm_100.
nWEIdia
closed
[ "open source", "Merged", "ciflow/trunk", "topic: not user facing" ]
13
COLLABORATOR
Therefore making it sm_\d+ Fixes this unit test failure: python test/test_cpp_extensions_jit.py -k TestCppExtensionJIT.test_jit_cuda_archflags cc @atalman @malfet @ptrblck @eqy @tinglvv
true
2,810,186,360
[dynamo] clear out traced frames at the start of `test_log_traced_frames`
StrongerXi
closed
[ "Merged", "ciflow/trunk", "topic: not user facing", "module: dynamo", "ciflow/inductor" ]
4
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145640 The test was being flaky in CI, and this patch fixes it. Fixes #137461. cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @am...
true
2,810,179,123
[AOTInductor] Refactor CPU and GPU to remove ifdef macros
muchulee8
closed
[ "fb-exported", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/inductor" ]
6
CONTRIBUTOR
Summary: Remove #ifdef USE_CUDA macros through some refactor Test Plan: Refactor code, existing tests. Differential Revision: D68636743
true
2,810,140,747
[CUDA] Change slim-wheel libraries load order
nWEIdia
closed
[ "open source", "Merged", "ciflow/trunk", "release notes: build" ]
16
COLLABORATOR
There is no libnvjitlink in CUDA-11.x , so attempts to load it first will abort the execution and prevent the script from preloading nvrtc Fixes issues reported in https://github.com/pytorch/pytorch/pull/145614#issuecomment-2613107072 cc @atalman @malfet @ptrblck @eqy @tinglvv
true
2,810,138,356
Remove duplicate code in _aot_autograd/dispatch_and_compile_graph.py
rec
closed
[ "topic: not user facing", "ciflow/inductor" ]
1
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145637 * #145636
true
2,810,137,955
Simplify functional composition in _aot_autograd/dispatch_and_compile_graph.py
rec
closed
[ "open source", "topic: not user facing", "ciflow/inductor" ]
14
COLLABORATOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145636
true
2,810,135,973
[ROCm] Improvements to non-vectorized elementwise kernels
jerrymannil
closed
[ "module: rocm", "open source", "topic: not user facing", "ciflow/periodic", "rocm", "ciflow/rocm", "ciflow/inductor-rocm" ]
11
CONTRIBUTOR
* Unroll loops manually to hide memory access latency * Strided access for coalesced memory acesses Cherry-pick of https://github.com/pytorch/pytorch/pull/145635 Co-authors: @akadutta @doru1004 @amd-hhashemi @carlobertolli cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @j...
true
2,810,129,477
Revert D68241649
ezyang
closed
[ "fb-exported" ]
6
CONTRIBUTOR
Summary: This diff reverts D68241649 Revert D68241649 as it impacts model inference performance. The impacted performance was observed in the Shaker patform, which runs embedded Linux. Test Plan: NA Reviewed By: ezyang Differential Revision: D68636019
true
2,810,120,056
Simplify inplace decomp logic by avoiding recursion
albanD
closed
[ "topic: not user facing", "ciflow/inductor" ]
2
COLLABORATOR
This significantly reduces the number of infinite recursion when writing decomps. Helps with https://github.com/pytorch/pytorch/issues/145094
true
2,810,113,565
Enable `sm_89` support for relevant ops in PyTorch
vgoklani
closed
[ "module: build", "module: cuda", "triaged", "module: m1" ]
14
NONE
Please add sm_89 to the list of target architectures for the stable, nightly, and Docker images. While I’ve seen references indicating that sm_89 might not need explicit builds due to binary compatibility with sm_86 and sm_80, that compatibility does not hold for FP8-related features on sm_89. For more details, see th...
true
2,810,093,266
Back out "Add generator parameter to rand*_like functions (#136780)"
ezyang
closed
[ "fb-exported" ]
5
CONTRIBUTOR
Summary: Revert D68241649 as it impacts model inference performance Test Plan: TBD Reviewed By: ezyang Differential Revision: D68635488
true
2,810,048,146
Introduce aoti_call_delegate HOP
SherlockNoMad
closed
[ "fb-exported", "Merged", "ciflow/trunk", "ciflow/inductor", "release notes: export" ]
22
CONTRIBUTOR
Summary: Previously, aoti compile node is represented as a kernel-less custom op in the exported program. The node was not eager runnable, which is a common practice for numerical validation during lowering. I introduce a new HOP to address this. The schema is following ``` aoti_call_delegate(lower_moduel: AOTInduc...
true
2,809,968,113
[ROCm] trunk.yml only runs pre-merge via ciflow/trunk label
amdfaa
closed
[ "module: rocm", "open source", "Merged", "ciflow/trunk", "topic: not user facing", "ciflow/rocm" ]
3
CONTRIBUTOR
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd
true
2,809,944,166
Add __all__ for torch.nn.init
mikaylagawarecki
closed
[ "Stale" ]
3
CONTRIBUTOR
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #145628
true
2,809,910,190
[autocast][pytorch] Support autocast for MTIA
nautsimon
closed
[ "fb-exported", "module: amp (automated mixed precision)", "Merged", "ciflow/trunk", "topic: not user facing", "module: mtia" ]
4
MEMBER
Summary: Add autocast support to MTIA Reviewed By: egienvalue Differential Revision: D68572548 cc @mcarilli @ptrblck @leslie-fang-intel @jgong5 @egienvalue
true
2,809,892,278
[Rocm][Inductor][CK] silence ck package not installed warning when CK backend is not used to autotune bmm
tenpercent
closed
[ "module: rocm", "open source", "Merged", "ciflow/trunk", "topic: not user facing", "module: inductor", "ciflow/inductor", "ciflow/rocm" ]
5
COLLABORATOR
As titled cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desert...
true