{
"_id": "7fd7a89707530ea4",
"_schema_version": "1.0",
"_cleaned_at": "2026-02-12T07:46:51.362973+00:00",
"repo": "psf/requests",
"repo_url": "https://github.com/psf/requests",
"license_name": "Apache License 2.0",
"license_spdx": "Apache-2.0",
"pr_number": 7191,
"title": "Update maintainers in the AUTHORS.rst",
"body": "Updated the maintainers list with our rotations in the last year. This will align with the published metadata in #7012 once it's merged.",
"author": "user_dbf2a999bd6d",
"created_at": "2026-01-30T22:52:33+00:00",
"merged_at": "2026-01-31T02:12:41+00:00",
"base_branch": "main",
"head_branch": "update-maintainers",
"additions": 7,
"deletions": 7,
"changed_files": 1,
"files": [
{
"filename": "AUTHORS.rst",
"status": "modified",
"additions": 7,
"deletions": 7,
"changes": 14,
"patch": "@@ -1,17 +1,17 @@\n Requests was lovingly created by [NAME_REDACTED]\n \n-Keepers of the Crystals\n-```````````````````````\n+Requests Maintainers\n+````````````````````\n \n+- [NAME_REDACTED] <[EMAIL_REDACTED]> [CONTRIBUTOR_REDACTED]\n - [NAME_REDACTED] [CONTRIBUTOR_REDACTED]\n-- [NAME_REDACTED] [CONTRIBUTOR_REDACTED]\n \n-Previous Keepers of Crystals\n-````````````````````````````\n+Previous Maintainers\n+````````````````````\n+\n - [NAME_REDACTED] <[EMAIL_REDACTED]> [CONTRIBUTOR_REDACTED], reluctant Keeper of the Master Crystal.\n - [NAME_REDACTED] <[EMAIL_REDACTED]> [CONTRIBUTOR_REDACTED]\n-- [NAME_REDACTED] <[EMAIL_REDACTED]> [CONTRIBUTOR_REDACTED]\n-\n+- [NAME_REDACTED] [CONTRIBUTOR_REDACTED]\n \n Patches and Suggestions\n ```````````````````````"
}
],
"reviews": [
{
"id": 3731002085,
"user": "user_0fa58b6f3572",
"state": "CHANGES_REQUESTED",
"body": null,
"submitted_at": "2026-01-30T23:47:34+00:00"
},
{
"id": 3731009362,
"user": "user_dbf2a999bd6d",
"state": "COMMENTED",
"body": null,
"submitted_at": "2026-01-30T23:49:04+00:00"
},
{
"id": 3731208005,
"user": "user_0fa58b6f3572",
"state": "APPROVED",
"body": null,
"submitted_at": "2026-01-31T00:52:44+00:00"
},
{
"id": 3731209056,
"user": "user_0fa58b6f3572",
"state": "COMMENTED",
"body": null,
"submitted_at": "2026-01-31T00:53:25+00:00"
},
{
"id": 3731210868,
"user": "user_dbf2a999bd6d",
"state": "COMMENTED",
"body": null,
"submitted_at": "2026-01-31T00:55:11+00:00"
}
],
"review_comments": [
{
"id": 2748444433,
"user": "user_0fa58b6f3572",
"body": "```suggestion\n- [NAME_EMAIL_REDACTED] [CONTRIBUTOR_REDACTED]\n```",
"path": "AUTHORS.rst",
"line": null,
"side": "RIGHT",
"created_at": "2026-01-30T23:47:28+00:00"
},
{
"id": 2748449786,
"user": "user_dbf2a999bd6d",
"body": "I completely missed that 😅 Apologies.",
"path": "AUTHORS.rst",
"line": null,
"side": "RIGHT",
"created_at": "2026-01-30T23:49:04+00:00"
},
{
"id": 2748609530,
"user": "user_0fa58b6f3572",
"body": "Maybe we should rename \"Keepers of the Crystals\" too at some point",
"path": "AUTHORS.rst",
"line": null,
"side": "RIGHT",
"created_at": "2026-01-31T00:53:25+00:00"
},
{
"id": 2748611665,
"user": "user_dbf2a999bd6d",
"body": "Yep, I'm onboard with that. We can just swap it to maintainers and former.",
"path": "AUTHORS.rst",
"line": null,
"side": "RIGHT",
"created_at": "2026-01-31T00:55:11+00:00"
}
],
"meta": {
"languages": [
"rst"
],
"touches_tests": false,
"review_state_summary": {
"CHANGES_REQUESTED": 1,
"COMMENTED": 3,
"APPROVED": 1
},
"meaningful_comment_count": 4,
"has_approval": true,
"has_changes_requested": true,
"total_review_comments": 4
}
}
{
"_id": "1060d9a975ea74ca",
"_schema_version": "1.0",
"_cleaned_at": "2026-02-12T07:46:51.378696+00:00",
"repo": "psf/requests",
"repo_url": "https://github.com/psf/requests",
"license_name": "Apache License 2.0",
"license_spdx": "Apache-2.0",
"pr_number": 7012,
"title": "Migrate build system to PEP 517",
"body": "This PR follows up on the original [announcement ](https://github.com/psf/requests/releases/tag/v2.32.0) of migrating Requests to a PEP 517 compliant backend in 2.33.0. This PR proposes moving to ~~hatchling which has wide adoption, but there's an argument for staying on setuptools~~ setuptools after reviewing our current needs. I'd be curious to hear from other maintainers on if there's a strong preference in either direction based on other projects.\n\n[USER_REDACTED] or [USER_REDACTED] may have input from migrating urllib3 as well. Presumably users with urllib3 2.x are already capable of building with this setup in their environment.",
"author": "user_dbf2a999bd6d",
"created_at": "2025-08-17T16:29:40+00:00",
"merged_at": "2026-01-31T02:25:56+00:00",
"base_branch": "main",
"head_branch": "hatchling",
"additions": 79,
"deletions": 111,
"changed_files": 3,
"files": [
{
"filename": "pyproject.toml",
"status": "modified",
"additions": 75,
"deletions": 1,
"changes": 76,
"patch": "@@ -1,3 +1,76 @@\n+[build-system]\n+requires = [\"setuptools>=61.0\"]\n+build-backend = \"setuptools.build_meta\"\n+\n+[project]\n+name = \"requests\"\n+description = \"Python HTTP for Humans.\"\n+readme = \"README.md\"\n+license = {text = \"Apache-2.0\"}\n+authors = [\n+ { name = \"[NAME_REDACTED]\", email = \"[EMAIL_REDACTED]\" },\n+]\n+maintainers = [\n+ {name = \"[NAME_REDACTED]\", email=\"[EMAIL_REDACTED]\"},\n+ {name = \"[NAME_REDACTED]\", email=\"[EMAIL_REDACTED]\"}\n+]\n+requires-python = \">=3.9\"\n+dependencies = [\n+ \"charset_normalizer>=2,<4\",\n+ \"idna>=2.5,<4\",\n+ \"urllib3>=1.21.1,<3\",\n+ \"certifi>=2017.4.17\"\n+]\n+dynamic = [\"version\"]\n+\n+classifiers = [\n+ \"[NAME_REDACTED] :: 5 - Production/Stable\",\n+ \"Environment :: [NAME_REDACTED]\",\n+ \"[NAME_REDACTED] :: Developers\",\n+ \"License :: OSI Approved :: [NAME_REDACTED]\",\n+ \"[NAME_REDACTED] :: English\",\n+ \"[NAME_REDACTED] :: OS Independent\",\n+ \"[NAME_REDACTED] :: Python\",\n+ \"[NAME_REDACTED] :: Python :: 3\",\n+ \"[NAME_REDACTED] :: Python :: 3.9\",\n+ \"[NAME_REDACTED] :: Python :: 3.10\",\n+ \"[NAME_REDACTED] :: Python :: 3.11\",\n+ \"[NAME_REDACTED] :: Python :: 3.12\",\n+ \"[NAME_REDACTED] :: Python :: 3.13\",\n+ \"[NAME_REDACTED] :: Python :: 3.14\",\n+ \"[NAME_REDACTED] :: Python :: 3 :: Only\",\n+ \"[NAME_REDACTED] :: Python :: Implementation :: CPython\",\n+ \"[NAME_REDACTED] :: Python :: Implementation :: PyPy\",\n+ \"Topic :: Internet :: WWW/HTTP\",\n+ \"Topic :: [NAME_REDACTED] :: Libraries\"\n+]\n+\n+[project.urls]\n+Documentation = \"https://requests.readthedocs.io\"\n+Source = \"https://github.com/psf/requests\"\n+\n+[project.optional-dependencies]\n+security = []\n+socks = [\"PySocks>=1.5.6, !=1.5.7\"]\n+use_chardet_on_py3 = [\"chardet>=3.0.2,<6\"]\n+test = [\n+ \"pytest-httpbin==2.1.0\",\n+ \"pytest-cov\",\n+ \"pytest-mock\",\n+ \"pytest-xdist\",\n+ \"PySocks>=1.5.6, !=1.5.7\",\n+ \"pytest>=3\"\n+]\n+\n+[tool.setuptools]\n+license-files = [\"LICENSE\", \"NOTICE\"]\n+\n+[tool.setuptools.dynamic]\n+version = {attr = \"requests.__version__.__version__\"}\n+\n+[tool.setuptools.packages.find]\n+where = [\"src\"]\n+\n [tool.ruff]\n target-version = \"py310\"\n src = [\"src/requests\", \"tests\"]\n@@ -12,7 +85,8 @@ select = [\n \"UP\", # pyupgrade\n \"T10\", # flake8-debugger (replaces debug-statements hook)\n ]\n-ignore = [\"E203\", \"E501\", \"UP038\", \"UP031\"]\n+# UP036: Remove once Python 3.10 is the minimum supported version\n+ignore = [\"E203\", \"E501\", \"UP038\", \"UP031\", \"UP036\"]\n per-file-ignores = {\"src/requests/__init__.py\" = [\"E402\", \"F401\"], \"src/requests/compat.py\" = [\"E402\", \"F401\"], \"tests/compat.py\" = [\"F401\"]}\n \n [tool.ruff.lint.isort]"
},
{
"filename": "setup.cfg",
"status": "removed",
"additions": 0,
"deletions": 10,
"changes": 10,
"patch": "@@ -1,10 +0,0 @@\n-[metadata]\n-license_file = LICENSE\n-provides-extra =\n- socks\n- use_chardet_on_py3\n-requires-dist =\n- certifi>=2017.4.17\n- charset_normalizer>=2,<4\n- idna>=2.5,<4\n- urllib3>=1.21.1,<3"
},
{
"filename": "setup.py",
"status": "modified",
"additions": 4,
"deletions": 100,
"changes": 104,
"patch": "@@ -1,105 +1,9 @@\n-#!/usr/bin/env python\n-import os\n import sys\n-from codecs import open\n \n-from setuptools import setup\n-\n-CURRENT_PYTHON = sys.version_info[:2]\n-REQUIRED_PYTHON = (3, 9)\n-\n-if CURRENT_PYTHON < REQUIRED_PYTHON:\n- sys.stderr.write(\n- \"\"\"\n-==========================\n-[NAME_REDACTED] version\n-==========================\n-This version of Requests requires at least Python {}.{}, but\n-you're trying to install it on Python {}.{}. To resolve this,\n-consider upgrading to a supported Python version.\n-\n-If you can't upgrade your Python version, you'll need to\n-pin to an older version of Requests (<2.32.0).\n-\"\"\".format(*(REQUIRED_PYTHON + CURRENT_PYTHON))\n- )\n+if sys.version_info < (3, 9):\n+ sys.stderr.write(\"Requests requires Python 3.9 or later.\\n\")\n sys.exit(1)\n \n+from setuptools import setup\n \n-# 'setup.py publish' shortcut.\n-if sys.argv[-1] == \"publish\":\n- os.system(\"python setup.py sdist bdist_wheel\")\n- os.system(\"twine upload dist/*\")\n- sys.exit()\n-\n-requires = [\n- \"charset_normalizer>=2,<4\",\n- \"idna>=2.5,<4\",\n- \"urllib3>=1.21.1,<3\",\n- \"certifi>=2017.4.17\",\n-]\n-test_requirements = [\n- \"pytest-httpbin==2.1.0\",\n- \"pytest-cov\",\n- \"pytest-mock\",\n- \"pytest-xdist\",\n- \"PySocks>=1.5.6, !=1.5.7\",\n- \"pytest>=3\",\n-]\n-\n-about = {}\n-here = os.path.abspath(os.path.dirname(__file__))\n-with open(os.path.join(here, \"src\", \"requests\", \"__version__.py\"), \"r\", \"utf-8\") as f:\n- exec(f.read(), about)\n-\n-with open(\"README.md\", \"r\", \"utf-8\") as f:\n- readme = f.read()\n-\n-setup(\n- name=about[\"__title__\"],\n- version=about[\"__version__\"],\n- description=about[\"__description__\"],\n- long_description=readme,\n- long_description_content_type=\"text/markdown\",\n- author=about[\"__author__\"],\n- author_email=about[\"__author_email__\"],\n- url=about[\"__url__\"],\n- packages=[\"requests\"],\n- package_data={\"\": [\"LICENSE\", \"NOTICE\"]},\n- package_dir={\"\": \"src\"},\n- include_package_data=True,\n- python_requires=\">=3.9\",\n- install_requires=requires,\n- license=about[\"__license__\"],\n- zip_safe=False,\n- classifiers=[\n- \"[NAME_REDACTED] :: 5 - Production/Stable\",\n- \"Environment :: [NAME_REDACTED]\",\n- \"[NAME_REDACTED] :: Developers\",\n- \"License :: OSI Approved :: [NAME_REDACTED]\",\n- \"[NAME_REDACTED] :: English\",\n- \"[NAME_REDACTED] :: OS Independent\",\n- \"[NAME_REDACTED] :: Python\",\n- \"[NAME_REDACTED] :: Python :: 3\",\n- \"[NAME_REDACTED] :: Python :: 3.9\",\n- \"[NAME_REDACTED] :: Python :: 3.10\",\n- \"[NAME_REDACTED] :: Python :: 3.11\",\n- \"[NAME_REDACTED] :: Python :: 3.12\",\n- \"[NAME_REDACTED] :: Python :: 3.13\",\n- \"[NAME_REDACTED] :: Python :: 3.14\",\n- \"[NAME_REDACTED] :: Python :: 3 :: Only\",\n- \"[NAME_REDACTED] :: Python :: Implementation :: CPython\",\n- \"[NAME_REDACTED] :: Python :: Implementation :: PyPy\",\n- \"Topic :: Internet :: WWW/HTTP\",\n- \"Topic :: [NAME_REDACTED] :: Libraries\",\n- ],\n- tests_require=test_requirements,\n- extras_require={\n- \"security\": [],\n- \"socks\": [\"PySocks>=1.5.6, !=1.5.7\"],\n- \"use_chardet_on_py3\": [\"chardet>=3.0.2,<6\"],\n- },\n- project_urls={\n- \"Documentation\": \"https://requests.readthedocs.io\",\n- \"Source\": \"https://github.com/psf/requests\",\n- },\n-)\n+setup()"
}
],
"reviews": [
{
"id": 3730413647,
"user": "user_0fa58b6f3572",
"state": "APPROVED",
"body": null,
"submitted_at": "2026-01-30T21:08:43+00:00"
},
{
"id": 3730866462,
"user": "user_dbf2a999bd6d",
"state": "COMMENTED",
"body": null,
"submitted_at": "2026-01-30T23:08:15+00:00"
},
{
"id": 3731211174,
"user": "user_0fa58b6f3572",
"state": "COMMENTED",
"body": null,
"submitted_at": "2026-01-31T00:55:33+00:00"
}
],
"review_comments": [
{
"id": 2748329758,
"user": "user_dbf2a999bd6d",
"body": "I'll note here that we left the text identifier instead of using [PEP 639](https://peps.python.org/pep-0639/) intentionally. While it is marked for deprecation in Feb 2027, the minimum supported version (setuptools 77) is still quite recent and I'm not comfortable bringing the floor up that high yet. We'll evaluate how this initial migration goes and address that later.",
"path": "pyproject.toml",
"line": 9,
"side": "RIGHT",
"created_at": "2026-01-30T23:08:16+00:00"
},
{
"id": 2748611996,
"user": "user_0fa58b6f3572",
"body": "It wouldn't be a day ending in y if something in [NAME_REDACTED] wasn't being deprecated with hard to find warning messages, that's for sure. ;)",
"path": "pyproject.toml",
"line": 9,
"side": "RIGHT",
"created_at": "2026-01-31T00:55:33+00:00"
}
],
"meta": {
"languages": [
"cfg",
"py",
"toml"
],
"touches_tests": false,
"review_state_summary": {
"APPROVED": 1,
"COMMENTED": 2
},
"meaningful_comment_count": 2,
"has_approval": true,
"has_changes_requested": false,
"total_review_comments": 2
}
}
{
"_id": "04a3ac8f90ef3153",
"_schema_version": "1.0",
"_cleaned_at": "2026-02-12T07:46:51.378696+00:00",
"repo": "psf/requests",
"repo_url": "https://github.com/psf/requests",
"license_name": "Apache License 2.0",
"license_spdx": "Apache-2.0",
"pr_number": 6963,
"title": "fix CVE 2024 47081: manual url parsing leads to netloc credentials leak",
"body": "https://seclists.org/fulldisclosure/2025/Jun/2\n\nHonestly I have no idea why this lib used `netloc` + manual parsing instead of `hostname` as I can see references to `hostname` as early as from [the python 2.6 docs](https://docs.python.org/2.6/library/urlparse.html).",
"author": "user_50fe2a4bfbbf",
"created_at": "2025-06-04T10:59:08+00:00",
"merged_at": "2025-06-05T14:55:33+00:00",
"base_branch": "main",
"head_branch": "aw/fix-CVE-2024-47081",
"additions": 20,
"deletions": 8,
"changed_files": 2,
"files": [
{
"filename": "src/requests/utils.py",
"status": "modified",
"additions": 1,
"deletions": 8,
"changes": 9,
"patch": "@@ -219,14 +219,7 @@ def get_netrc_auth(url, raise_errors=False):\n netrc_path = None\n \n for f in netrc_locations:\n- try:\n- loc = os.path.expanduser(f)\n- except KeyError:\n- # os.path.expanduser can fail when $HOME is undefined and\n- # getpwuid fails. See https://bugs.python.org/issue20164 &\n- # https://github.com/psf/requests/issues/1846\n- return\n-\n+ loc = os.path.expanduser(f)\n if os.path.exists(loc):\n netrc_path = loc\n break"
},
{
"filename": "tests/test_utils.py",
"status": "modified",
"additions": 19,
"deletions": 0,
"changes": 19,
"patch": "@@ -23,6 +23,7 @@\n get_encoding_from_headers,\n get_encodings_from_content,\n get_environ_proxies,\n+ get_netrc_auth,\n guess_filename,\n guess_json_utf,\n is_ipv4_address,\n@@ -152,6 +153,24 @@ def test_super_len_with_no_matches(self):\n assert super_len(object()) == 0\n \n \n+class TestGetNetrcAuth:\n+ def test_works(self, tmp_path, monkeypatch):\n+ netrc_path = tmp_path / \".netrc\"\n+ monkeypatch.setenv(\"NETRC\", str(netrc_path))\n+ with open(netrc_path, \"w\") as f:\n+ f.write(\"machine example.com login aaaa password bbbb\\n\")\n+ auth = get_netrc_auth(\"http://example.com/thing\")\n+ assert auth == (\"aaaa\", \"bbbb\")\n+\n+ def test_not_vulnerable_to_bad_url_parsing(self, tmp_path, monkeypatch):\n+ netrc_path = tmp_path / \".netrc\"\n+ monkeypatch.setenv(\"NETRC\", str(netrc_path))\n+ with open(netrc_path, \"w\") as f:\n+ f.write(\"machine example.com login aaaa password bbbb\\n\")\n+ auth = get_netrc_auth(\"http://example.com:[USER_REDACTED].com/'\")\n+ assert auth is None\n+\n+\n class TestToKeyValList:\n [USER_REDACTED].mark.parametrize(\n \"value, expected\","
}
],
"reviews": [
{
"id": 2899123279,
"user": "user_b94daa584f46",
"state": "COMMENTED",
"body": "About the test, I created another test for the same issue in a [different PR](https://github.com/psf/requests/pull/6962/). So at this point, the issue is fixed and it could be nice to have a test for this case, I'm okay to close my PR if this test is good enough, or keep it if maintainers are okay to have two tests for this case.",
"submitted_at": "2025-06-05T07:17:48+00:00"
},
{
"id": 2900241034,
"user": "user_0fa58b6f3572",
"state": "APPROVED",
"body": null,
"submitted_at": "2025-06-05T13:00:47+00:00"
}
],
"review_comments": [
{
"id": 2128118428,
"user": "user_b94daa584f46",
"body": "This is fixed now in main: https://github.com/psf/requests/commit/96ba401c1296ab1dda74a2365ef36d88f7d144ef",
"path": "src/requests/utils.py",
"line": null,
"side": "RIGHT",
"created_at": "2025-06-05T07:12:17+00:00"
}
],
"meta": {
"languages": [
"py"
],
"touches_tests": true,
"review_state_summary": {
"COMMENTED": 1,
"APPROVED": 1
},
"meaningful_comment_count": 1,
"has_approval": true,
"has_changes_requested": false,
"total_review_comments": 1
}
}
{
"_id": "0c69e1dbe0a5b84e",
"_schema_version": "1.0",
"_cleaned_at": "2026-02-12T07:46:51.378696+00:00",
"repo": "psf/requests",
"repo_url": "https://github.com/psf/requests",
"license_name": "Apache License 2.0",
"license_spdx": "Apache-2.0",
"pr_number": 6951,
"title": "docs: fix dead links to kenreitz.org",
"body": "I noticed a few dead links. Looking back through the [wayback machine](https://web.archive.org/web/20220203091232/https://kenreitz.org/essays/2012/06/14/the-future-of-python-http), I was able to find the new location of these articles.",
"author": "user_4759e575a3d3",
"created_at": "2025-05-21T16:11:00+00:00",
"merged_at": "2025-06-01T18:07:18+00:00",
"base_branch": "main",
"head_branch": "patch-1",
"additions": 13,
"deletions": 18,
"changed_files": 3,
"files": [
{
"filename": "docs/conf.py",
"status": "modified",
"additions": 1,
"deletions": 1,
"changes": 2,
"patch": "@@ -58,7 +58,7 @@\n \n # General information about the project.\n project = u\"Requests\"\n-copyright = u'MMXVIX. A [NAME_REDACTED] Project'\n+copyright = u'MMXVIX. A [NAME_REDACTED]'\n author = u\"[NAME_REDACTED]\"\n \n # The version info for the project you're documenting, acts as replacement for"
},
{
"filename": "docs/dev/contributing.rst",
"status": "modified",
"additions": 9,
"deletions": 11,
"changes": 20,
"patch": "@@ -22,19 +22,17 @@ The guide is split into sections based on the type of contribution you're\n thinking of making, with a section that covers general guidelines for all\n contributors.\n \n-[NAME_REDACTED]\n-----------\n+Code of Conduct\n+---------------\n \n- **Be cordial or be on your way**. *—[NAME_REDACTED]*\n+The Python community is made up of members from around the globe with a diverse\n+set of skills, personalities, and experiences. It is through these differences\n+that our community experiences great successes and continued growth. When you're\n+working with members of the community, follow the\n+`[NAME_REDACTED] Code of Conduct`_ to help steer your interactions\n+and keep Python a positive, successful, and growing community.\n \n-Requests has one very important rule governing all forms of contribution,\n-including reporting bugs or requesting features. This golden rule is\n-\"`be cordial or be on your way`_\".\n-\n-**All contributions are welcome**, as long as\n-everyone involved is treated with respect.\n-\n-.. _be cordial or be on your way: https://kenreitz.org/essays/2013/01/27/be-cordial-or-be-on-your-way\n+.. _Python [NAME_REDACTED] of Conduct: https://policies.python.org/python.org/code-of-conduct/\n \n .. _early-feedback:"
},
{
"filename": "docs/user/advanced.rst",
"status": "modified",
"additions": 3,
"deletions": 6,
"changes": 9,
"patch": "@@ -969,11 +969,9 @@ Requests will automatically parse these link headers and make them easily consum\n [NAME_REDACTED]\n ------------------\n \n-As of v1.0.0, Requests has moved to a modular internal design. Part of the\n-reason this was done was to implement [NAME_REDACTED], originally\n-`described here`_. [NAME_REDACTED] provide a mechanism to define interaction\n-methods for an HTTP service. In particular, they allow you to apply per-service\n-configuration.\n+As of v1.0.0, Requests has moved to a modular internal design using Transport\n+Adapters. These objects provide a mechanism to define interaction methods for an\n+HTTP service. In particular, they allow you to apply per-service configuration.\n \n Requests ships with a single [NAME_REDACTED], the :class:`HTTPAdapter\n \n-This software has been designed for you, with much joy, \n-by [NAME_REDACTED] & is secured by The [NAME_REDACTED]. \n+This software has been designed for you, with much joy,\n+by [NAME_REDACTED] & is protected by The [NAME_REDACTED].\n \n-
\n \n \n@@ -71,14 +68,14 @@ Requests is ready for the demands of building robust and reliable HTTP–speak a\n \n
\n+
\n+ \n Python 3.7.4 (default, Sep 7 2019, 18:27:02)\n@@ -12,15 +13,11 @@\n >>> r.json()[\"description\"]\n 'A simple, yet elegant HTTP library. Handcrafted, with ♥, for the Python community.'\n
\n- \n+\n
\n \n + [NAME_REDACTED] and URLs + Keep-Alive & [NAME_REDACTED]\n- + Sessions with [NAME_REDACTED] + Browser-style SSL Verification \n- + Basic & [NAME_REDACTED] + Familiar `dict`–like Cookies \n- + [NAME_REDACTED] of Content + [NAME_REDACTED] \n+ + Sessions with [NAME_REDACTED] + Browser-style SSL Verification\n+ + Basic & [NAME_REDACTED] + Familiar `dict`–like Cookies\n+ + [NAME_REDACTED] of Content + [NAME_REDACTED]\n + [NAME_REDACTED] + [NAME_REDACTED]
\n \n@@ -127,4 +124,3 @@ Requests officially supports Python 2.7 & 3.4–3.8.\n \n-"
},
{
"filename": "ext/LICENSE",
"status": "added",
"additions": 1,
"deletions": 0,
"changes": 1,
"patch": "@@ -0,0 +1 @@\n+Copyright 2019 [NAME_REDACTED] reserved."
},
{
"filename": "ext/deepmind-kr.jpg",
"status": "removed",
"additions": 0,
"deletions": 0,
"changes": 0,
"patch": null
},
{
"filename": "ext/flourish.jpg",
"status": "removed",
"additions": 0,
"deletions": 0,
"changes": 0,
"patch": null
},
{
"filename": "ext/flower-of-life.jpg",
"status": "modified",
"additions": 0,
"deletions": 0,
"changes": 0,
"patch": null
}
],
"reviews": [
{
"id": 291974410,
"user": "user_c71bba18f1eb",
"state": "APPROVED",
"body": null,
"submitted_at": "2019-09-23T18:35:47+00:00"
},
{
"id": 291976846,
"user": "user_36df932e8b7a",
"state": "COMMENTED",
"body": null,
"submitted_at": "2019-09-23T18:39:59+00:00"
}
],
"review_comments": [
{
"id": 327269074,
"user": "user_36df932e8b7a",
"body": "**Note**: this is for the images contained within the `ext` folder, which includes a [tattoo upon my arm](https://images.squarespace-cdn.com/content/v1/533ad9bde4b098d084a846b1/1469928300857-S9WKXBO0CCRX0RL4PJYX/ke17ZwdGBToddI8pDm48kKLHmMs23ZxPgeOu8Yrs55d7gQa3H78H3Y0txjaiv_0fDoOvxcdMmMKkDsyUqMSsMWxHk725yiiHCCLfrh8O1z4YTzHvnKhyp6Da-NYroOW3ZGjoBKy3azqku80C789l0iyqMbMesKd95J-X4EagrgXXATmnXitsEasKvdtVty7KcIpiUOmkkpuOP9PWkdpi9w/L1000129-Edit.jpg?format=1500w) — I had the tattoo before I made it the Requests logo :)",
"path": "ext/LICENSE",
"line": 1,
"side": "RIGHT",
"created_at": "2019-09-23T18:39:59+00:00"
}
],
"meta": {
"languages": [
"jpg",
"md",
"rst"
],
"touches_tests": false,
"review_state_summary": {
"APPROVED": 1,
"COMMENTED": 1
},
"meaningful_comment_count": 1,
"has_approval": true,
"has_changes_requested": false,
"total_review_comments": 1
}
}
{
"_id": "a3716fe2faa7fd3c",
"_schema_version": "1.0",
"_cleaned_at": "2026-02-12T07:46:51.487316+00:00",
"repo": "psf/requests",
"repo_url": "https://github.com/psf/requests",
"license_name": "Apache License 2.0",
"license_spdx": "Apache-2.0",
"pr_number": 4987,
"title": "[fix] fix failing doctests in requests/*",
"body": "## Why this PR\nRunning the command:\n`\n$ py.test --doctest-module requests\n`\ngives failing doctests. This PR aims to fix these failing doctests.\n\n[NAME_REDACTED]: https://github.com/[USER_REDACTED]nethreitz/requests/issues/4986\n\n## How to test\n`\n$ py.test --doctest-module requests\n`\nAll the 11 doctests should pass.",
"author": "user_f9f268d1dfdc",
"created_at": "2019-02-17T18:47:44+00:00",
"merged_at": "2019-08-20T04:25:51+00:00",
"base_branch": "master",
"head_branch": "master",
"additions": 18,
"deletions": 9,
"changed_files": 8,
"files": [
{
"filename": "AUTHORS.rst",
"status": "modified",
"additions": 2,
"deletions": 0,
"changes": 2,
"patch": "@@ -189,5 +189,7 @@ Patches and Suggestions\n - [NAME_REDACTED] ([CONTRIBUTOR_REDACTED])\n - [NAME_REDACTED] ([CONTRIBUTOR_REDACTED])\n - [NAME_REDACTED] ([CONTRIBUTOR_REDACTED])\n+- \"[NAME_REDACTED]\" <[EMAIL_REDACTED]> ([CONTRIBUTOR_REDACTED])\n+- [NAME_REDACTED] ([CONTRIBUTOR_REDACTED])\n - [NAME_REDACTED] ([CONTRIBUTOR_REDACTED])\n - [NAME_REDACTED] <[EMAIL_REDACTED]> ([CONTRIBUTOR_REDACTED])"
},
{
"filename": "pytest.ini",
"status": "modified",
"additions": 2,
"deletions": 1,
"changes": 3,
"patch": "@@ -1,2 +1,3 @@\n [pytest]\n-addopts = -p no:warnings\n\\ No newline at end of file\n+addopts = -p no:warnings --doctest-modules\n+doctest_optionflags= NORMALIZE_WHITESPACE ELLIPSIS\n\\ No newline at end of file"
},
{
"filename": "requests/__init__.py",
"status": "modified",
"additions": 5,
"deletions": 5,
"changes": 10,
"patch": "@@ -9,14 +9,14 @@\n Requests HTTP Library\n ~~~~~~~~~~~~~~~~~~~~~\n \n-Requests is an HTTP library, written in Python, for human beings. Basic GET\n-usage:\n+Requests is an HTTP library, written in Python, for human beings.\n+Basic GET usage:\n \n >>> import requests\n >>> r = requests.get('https://www.python.org')\n >>> r.status_code\n 200\n- >>> 'Python is a programming language' in r.content\n+ >>> b'Python is a programming language' in r.content\n True\n \n ... or POST:\n@@ -27,8 +27,8 @@\n {\n ...\n \"form\": {\n- \"key2\": \"value2\",\n- \"key1\": \"value1\"\n+ \"key1\": \"value1\",\n+ \"key2\": \"value2\"\n },\n ...\n }"
},
{
"filename": "requests/api.py",
"status": "modified",
"additions": 1,
"deletions": 0,
"changes": 1,
"patch": "@@ -50,6 +50,7 @@ def request(method, url, **kwargs):\n \n >>> import requests\n >>> req = requests.request('GET', 'https://httpbin.org/get')\n+ >>> req\n [NAME_REDACTED]
\n allowtransparency=\"true\" frameborder=\"0\" scrolling=\"0\" width=\"200\" height=\"20\">
More [NAME_REDACTED] projects:
\n+More [NAME_REDACTED] projects:
\nReceive updates on new releases and upcoming projects.
\n \n-\n+\n \nMore [NAME_REDACTED] projects:
\n+More [NAME_REDACTED] projects:
\n