Refactor

alt.py

@@ -216,10 +216,8 @@ class Alt(datasets.GeneratorBasedBuilder):
 
         data = {}
         if self.config.name.startswith("alt-parallel"):
-            files = self.config.languages
-
             data = {}
-            for lang in files:
+            for lang in self.config.languages:
                 file_path = os.path.join(basepath, "ALT-Parallel-Corpus-20191206", f"data_{lang}.txt")
                 with open(file_path, encoding="utf-8") as fin:
                     for line in fin:
@@ -227,16 +225,18 @@ class Alt(datasets.GeneratorBasedBuilder):
                         sp = line.split("\t")
 
                         _, urlid, sntid = sp[0].split(".")
-                        sntid = sntid.strip()  # Some lines have a trailing blank space: "SNT.102053.5598 " in data_fil.txt
+                        # Some lines have a trailing blank space: "SNT.102053.5598 " in data_fil.txt
+                        sntid = sntid.strip()
                         if urlid not in allow_urls:
                             continue
 
                         if sntid not in data:
-                            data[sntid] = {}
-                            data[sntid]["SNT.URLID"] = urlid
-                            data[sntid]["SNT.URLID.SNTID"] = sntid
-                            data[sntid]["url"] = allow_urls[urlid]["url"]
-                            data[sntid]["translation"] = {}
+                            data[sntid] = {
+                                "SNT.URLID": urlid,
+                                "SNT.URLID.SNTID": sntid,
+                                "url": allow_urls[urlid]["url"],
+                                "translation": {},
+                            }
 
                         # Note that Japanese and Myanmar texts have empty sentence fields in this release.
                         if len(sp) >= 2:
@@ -259,15 +259,10 @@ class Alt(datasets.GeneratorBasedBuilder):
                             "SNT.URLID": urlid,
                             "SNT.URLID.SNTID": sntid,
                             "url": allow_urls[urlid]["url"],
-                            "status": None,
+                            "status": "draft" if fname == "English-ALT-Draft.txt" else "reviewed",
                             "value": sp[1],
                         }
 
-                        if fname == "English-ALT-Draft.txt":
-                            d["status"] = "draft"
-                        else:
-                            d["status"] = "reviewed"
-
                         data[sntid] = d
 
         elif self.config.name == "alt-jp":
@@ -287,16 +282,12 @@ class Alt(datasets.GeneratorBasedBuilder):
                             "SNT.URLID.SNTID": sntid,
                             "url": allow_urls[urlid]["url"],
                             "value": sp[1],
-                             "status": None,
+                            "status": "draft" if fname == "Japanese-ALT-Draft.txt" else "reviewed",
                             "word_alignment": None,
                             "en_tokenized": None,
                             "jp_tokenized": None,
                         }
 
-                        if fname == "Japanese-ALT-Draft.txt":
-                            d["status"] = "draft"
-                        else:
-                            d["status"] = "reviewed"
                         data[sntid] = d
 
             keys = {
@@ -354,9 +345,7 @@ class Alt(datasets.GeneratorBasedBuilder):
                             continue
 
                         k = "km_pos_tag" if fname == "data_km.km-tag.nova" else "km_tokenized"
-                        if sntid in data:
-                            data[sntid][k] = sp[1]
-                        else:
+                        if sntid not in data:
                             data[sntid] = {
                                 "SNT.URLID": urlid,
                                 "SNT.URLID.SNTID": sntid,
@@ -364,7 +353,7 @@ class Alt(datasets.GeneratorBasedBuilder):
                                 "km_pos_tag": None,
                                 "km_tokenized": None,
                             }
-                            data[sntid][k] = sp[1]
+                        data[sntid][k] = sp[1]
 
         elif self.config.name == "alt-my-transliteration":
             file_path = os.path.join(basepath, "my-en-transliteration", "data.txt")