Add files using upload-large-folder tool

1technophile_OpenMQTTGateway_2269__agent_authored/issues/1technophile_OpenMQTTGateway_2264.json

@@ -0,0 +1 @@
+{"number": 2264, "title": "Changes between 1.8.1 and development breaks CC1101 (rcswitch / smartrc-cc1101-driver) default behaviour", "body": "Hi again :-D\n\ni recently updated my ESP with the latest development-build and found some change in behaviour. \n\n**Describe the bug**\nThere must be some changes between v1.8.1 and the current development-branch, that causes the TI-C1101 not to listen properly by default on boot. Maybe there is a problem between RC-Switch and smartrc-cc1101-driver\n\n**To Reproduce**\n-compile latest development source files\n-upload latest build to ESP\n-let ESP boot\n-watch MQTT or Serial-console and wait for captured RF-signals\n-Conclusion: CC1101 seems not to listen like it did with earlier version v1.8.0-development\n\nTo Fix it, open the WebUI and switch from RTL_433 to RF and back\n<img width=\"501\" height=\"438\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/b6dcaa31-4240-4b9d-9b77-bfb4bd5d84b0\" />\n-Sometimes the ESP crashes at these point and failed to activate SPI Interface properly.\n-after a reboot, i can try to switch between RTL_433 to RF without crash\n\n**Expected behavior**\nIf attached to esp, the CC1101 shoud be initialized and receiving on boot-time\n\n\n**Environment**\n* OpenMQTTGateway version used (V1.8.1 development - build from latest files)\n* smartrc-cc1101 with rc-switch\n\n* Hardware: ESP32-Wroom-32D Board\n* Receiver: TI-CC1101\n\nCustom Environment:\n-smartrc for receiving temperatures from LaCrosse/Nexus\n-rc-switch for controling old RF433 sockets\n\n```\n[mycustom]\nbuild_flags =\n  '-DOMG_VERSION=\"v1.8.1\"'\n\n[env:custom-esp32dev-rtl_433]\nplatform = espressif32@6.1.0\nboard = esp32dev\nboard_build.partitions = min_spiffs.csv\nlib_deps =\n  ${com-esp32.lib_deps}\n  ${libraries.rtl_433_ESP}\n  ${libraries.rc-switch}\n  ${libraries.smartrc-cc1101-driver-lib}\nbuild_flags =\n  ${com-esp32.build_flags}\n  ${mycustom.build_flags}  \n; *** OpenMQTTGateway Config ***\n  '-UZmqttDiscovery'          ; disables MQTT Discovery\n  '-DvalueAsATopic=true'       ; MQTT topic includes model and device\n;  '-DLOG_LEVEL=LOG_LEVEL_TRACE'\n  '-DGateway_Name=\"OpenMQTTGateway_rtl_433_ESP\"'\n  '-DjsonPublishing=true'\n; *** OpenMQTTGateway Modules ***\n  '-DZgatewayRTL_433=\"rtl_433\"'\n  '-DZgatewayRF=\"RF\"'\n  '-DZradioCC1101=\"CC1101\"'\n; *** rtl_433_ESP Options ***\n;  '-DRTL_DEBUG=4'             ; rtl_433 verbose mode\n;  '-DRTL_VERBOSE=58'          ; LaCrosse TX141-Bv2, TX141TH-Bv2, TX141-Bv3, TX141W, TX145wsdth sensor\n;  '-DRAW_SIGNAL_DEBUG=true'   ; display raw received messages\n;  '-DMEMORY_DEBUG=true'       ; display memory usage information\n;  '-DDEMOD_DEBUG=true'         ; display signal debug info\n;  '-DMY_DEVICES=true'         ; subset of devices\n  '-DPUBLISH_UNPARSED=true'    ; publish unparsed signal details\n;  '-DRSSI_THRESHOLD=12'       ; Apply a delta of 12 to average RSSI level\n;  '-DAVERAGE_RSSI=5000'       ; Display RSSI floor ( Average of 5000 samples )\n  '-DSIGNAL_RSSI=true'         ; Display during signal receive\n;  '-DNO_DEAF_WORKAROUND=true'\n; *** RF Module Options ***\n  '-DRF_CC1101=\"CC1101\"'       ; CC1101 Transceiver Module\n  '-DRF_CC1101_TXPOWER=12'  ; (-30  -20  -15  -10  -6    0    5    7    10   11   12) Default is max!  \n;  '-DRF_MODULE_CS=5'          ; pin to be used as chip select\n  '-DRF_MODULE_GDO0=4'        ; CC1101 pin GDO0\n  '-DRF_MODULE_GDO2=15'        ; CC1101 pin GDO2\n  '-DRF_RECEIVER_GPIO=15' #D2\n  '-DRF_EMITTER_GPIO=4' #D4  \n;  *** LED ***\n  #'-DLED_SEND_RECEIVE=2'\n  #'-DLED_SEND_RECEIVE_ON=1'\n  '-DLED_PIN=2'\n  '-DLED_PIN_ON=LOW'\n  ; *** RadioLib Options ***\n;  '-DRADIOLIB_DEBUG=true'\n;  '-DRADIOLIB_VERBOSE=true'\n;  '-DDISABLERSSITHRESHOLD=true'\ncustom_description = Gateway using RTL_433_ESP library, need CC1101\n```\n\n**Additional context**\n\nHere are some console outputs from ESP-Boot and switching between RTL433/RF to initialize CC1101 after boot.\n```\nN: OpenMQTTGateway URL: http://192.168.178.23/\nN: webUI setup done\nN: Config frequency changed to: false\nN: RF Receive mhz: 433.92\nN: Config active changed to: false\nN: RF receiver active: 3\nN: RF Config loaded\nN: gatewayRTL_433 setup done \nN: Offline disabled\nN: OpenMQTTGateway modules: [\"WebUI\",\"RF\",\"rtl_433\"]\nN: ************** Setup OpenMQTTGateway end **************\nN: Reconfiguring MQTT client...\nN: Update check, free heap: 171676N: Using memory cert\nN: Update check done, free heap: 124448N: Connected to broker\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/LWT msg: online \nN: SYS json: {\"uptime\":10,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":166944,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":111512,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-59,\"SSID\":\"XXXXXXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":\"'WebUI', 'RF', 'rtl_433'\",\"origin\":\"/SYStoMQTT\"}\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RLStoMQTT msg: {\"latest_version\":\"v1.8.1\",\"title\":\"OpenMQTTGateway\",\"release_url\":\"https://github.com/1technophile/OpenMQTTGateway/releases/tag/v1.8.1\",\"installed_version\":\"v1.8.1\",\"entity_picture\":\"https://github.com/1technophile/OpenMQTTGateway/raw/development/docs/img/Openmqttgateway_logo_mini_margins.png\",\"release_summary\":\"\"} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/SYStoMQTT msg: {\"uptime\":10,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":166944,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":111512,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-59,\"SSID\":\"XXXXXXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":[\"WebUI\",\"RF\",\"rtl_433\"]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":0,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":3980} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/WebUItoMQTT msg: {\"displayMetric\":true,\"webUISecure\":false,\"displayQueue\":0} \n```\n\nSwitching from RTL_433 to RF\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nN: C1101 spi Connection OK\nN: [RF] Enable RF Receiver: Mhz, RF_EMITTER_GPIO: 0, RF_RECEIVER_GPIO: 1610612736\nN: RF Config_save: {\"frequency\":433.92,\"active\":2,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":0,\"ookthreshold\":0,\"active\":2,\"white-list\":[],\"black-list\":[]} \n```\n\nSwitching from RF to RTL_433 \n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nN: C1101 spi Connection OK\nN: Enable RTL_433 Receiver: 433.92Mhz\nN: RF Config_save: {\"frequency\":433.92,\"active\":3,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\n```\n", "state": "CLOSED", "created_at": "2025-12-28T23:03:55Z", "closed_at": "2026-01-06T11:47:50Z", "author_login": "Dattel", "comment_rounds": [{"comments": [{"id": "IC_kwDOBBSfJs7cYxTu", "body": "Have you already looked at the code? Are you thinking of anything specific? There have been several changes recently in the RF department. I have the same hardware configuration as you, but I can't load the latest configuration (problem with firmware loading), so I can't check... I hope to be able to reproduce the problem as soon as possible and give you more information.", "createdAt": "2025-12-29T20:27:22Z", "updatedAt": "2025-12-29T20:27:22Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7cY9Rz", "body": "not sure... maybe the reason is, that i want to run both (rcswitch and smartrc-cc1101-driver) libs in parallel and maybe the initialization of one crashes the other... \n\ni will check later, if compiling only with smartrc will work as intended\n", "createdAt": "2025-12-29T20:57:40Z", "updatedAt": "2025-12-29T20:57:40Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cY-xy", "body": "by the way... \nthere is something weired with the RF_Pins in the Log during switch from RTL_433 to RF\n\nN: [RF] Enable RF Receiver: Mhz, **RF_EMITTER_GPIO: 0, RF_RECEIVER_GPIO: 1610612736**\n\nAs you can see in my provided configuration, both pins are defined correct", "createdAt": "2025-12-29T21:01:30Z", "updatedAt": "2025-12-29T21:01:30Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cZboS", "body": "Ok, same behaviour with a rtl_433-only Build. So no competition-problem between rcswitch an rtl_433.\nHere are some more protocols from bootup till the first RAW Signal is detected.\n\nNormal Boot-process. Please note that the CC1101 with SPI is missing here.\n```\n************* WELCOME TO OpenMQTTGateway **************\nN: SYS config not found\nN: OpenMQTTGateway Version: v1.8.1\nN: OTA server cert hash: 02118cbaf5cc02748398d93ecdb0ef2a444c37358a617bfb2206dfe351dc7cf2\nN: Config loaded from flash\nN: Attempting Wifi connection with saved AP: 0\nN: Attempting Wifi connection with saved AP: 1\nE (3073) wifi:sta is connecting, return error\n[  1344][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Attempting Wifi connection with saved AP: 2\nE (4082) wifi:sta is connecting, return error\n[  2352][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Attempting Wifi connection with saved AP: 3\nE (5091) wifi:sta is connecting, return error\n[  3361][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Attempting Wifi connection with saved AP: 4\nE (6099) wifi:sta is connecting, return error\n[  4369][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Connect your phone to WIFI AP: OpenMQTTGateway_rtl_433_ESP with PWD: \nE (8760) wifi:sta is connecting, return error\n[  7030][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: OpenMQTTGateway URL: http://192.168.178.23/\nN: webUI setup done\nN: Config frequency changed to: false\nN: RF Receive mhz: 433.92\nN: Config active unchanged, currently: false\nN: RF receiver active: 3\nN: RF Config loaded\nN: gatewayRTL_433 setup done \nN: Offline disabled\nN: OpenMQTTGateway modules: [\"WebUI\",\"rtl_433\"]\nN: ************** Setup OpenMQTTGateway end **************\nN: Reconfiguring MQTT client...\nN: Update check, free heap: 173540N: Using memory cert\nN: Update check done, free heap: 126304N: Connected to broker\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/LWT msg: online \nN: SYS json: {\"uptime\":9,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168788,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":114740,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-58,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":\"'WebUI', 'rtl_433'\",\"origin\":\"/SYStoMQTT\"}\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RLStoMQTT msg: {\"latest_version\":\"v1.8.1\",\"title\":\"OpenMQTTGateway\",\"release_url\":\"https://github.com/1technophile/OpenMQTTGateway/releases/tag/v1.8.1\",\"installed_version\":\"v1.8.1\",\"entity_picture\":\"https://github.com/1technophile/OpenMQTTGateway/raw/development/docs/img/Openmqttgateway_logo_mini_margins.png\",\"release_summary\":\"\"} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/SYStoMQTT msg: {\"uptime\":9,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168788,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":114740,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-58,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":[\"WebUI\",\"rtl_433\"]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":0,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":3980} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/WebUItoMQTT msg: {\"displayMetric\":true,\"webUISecure\":false,\"displayQueue\":0} \n```\n\nNow switching in the webui from **rtl_433** to **inactive**\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nE: ERROR: no receiver selected\nN: RF Config_save: {\"frequency\":433.92,\"active\":0,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":0,\"ookthreshold\":0,\"active\":0,\"white-list\":[],\"black-list\":[]} \nN: SYS json: {\"uptime\":129,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168976,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":5,\"msgblck\":0,\"msgrcv\":5,\"maxq\":4,\"cnt_index\":0,\"minmem\":114740,\"tempc\":51.11,\"freestck\":1692,\"powermode\":-1,\"eth\":false,\"rssi\":-57,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":\"'WebUI', 'rtl_433'\",\"origin\":\"/SYStoMQTT\"}\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/SYStoMQTT msg: {\"uptime\":129,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168976,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":5,\"msgblck\":0,\"msgrcv\":5,\"maxq\":4,\"cnt_index\":0,\"minmem\":114740,\"tempc\":51.11,\"freestck\":1692,\"powermode\":-1,\"eth\":false,\"rssi\":-57,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":[\"WebUI\",\"rtl_433\"]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":0,\"ookthreshold\":0,\"active\":0,\"white-list\":[],\"black-list\":[]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/WebUItoMQTT msg: {\"displayMetric\":true,\"webUISecure\":false,\"displayQueue\":0} \n```\n\nNow switching in the webui back from **inactive** to **rtl_433**.\nNotice the SPI initialization and that CC1101 instantly receives signals.\n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nN: C1101 spi Connection OK\nN: Enable RTL_433 Receiver: 433.92Mhz\nN: RF Config_save: {\"frequency\":433.92,\"active\":3,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":-80,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":10904} \nrtl_433_ESP(6): Unparsed Signal length: 806196, Signal RSSI: -77, pulses: 162\nrtl_433_ESP(6): RAW (806196): +0-1203(-78)+117-826(-78)+175-1326(-78)+106-569(-79)+127-175(-80)+150-17516(-76)+100-175(-76)+250-225(-76)+150-276(-76)+75-504(-76)+124-131(-78)+72-348(-79)+200-1711(-79)+65-926(-80)+75-51(-80)+126-424(-80)+100-75(-80)+109-191(-80)+200-426(-81)+26571-300(-81)+223-54141(-75)+102-1513(-76)+100-100(-76)+275-501(-77)+75-126(-77)+224-100(-78)+175-125(-78)+626-100(-78)+325-100(-78)+601-275(-79)+150-203(-79)+147-175(-80)+276-375(-80)+175-76186(-80)+51-375(-76)+100-125(-77)+151-875(-78)+75-901(-78)+125-1902(-79)+75-751(-79)+201-150(-80)+200-350(-80)+100-401(-81)+75-1077(-81)+125-34947(-75)+300-100(-78)+51-201(-78)+149-250(-78)+225-776(-79)+125-275(-79)+175-1851(-81)+125-876(-81)+100-39943(-81)+75-876(-77)+125-16961(-75)+100-576(-75)+76-176(-76)+100-901(-76)+100-425(-77)+149-201(-77)+200-150(-78)+175-500(-78)+100-876(-79)+150-175(-79)+100-276(-79)+100-225(-80)+350-526(-80)+125-851(-81)+125-350(-81)+125-19447(-74)+75-2910(-76)+75-901(-77)+150-526(-77)+226-18090(-75)+126-875(-77)+125-401(-78)+102-298(-78)+200-502(-79)+100-174(-79)+75-801(-80)+100-300(-80)+75-50505(-81)+100-250(-76)+300-376(-77)+100-900(-78)+75-926(-79)+75-45946(-74)+75-75(-76)+51-325(-76)+75-1376(-78)+75-16934(-78)+76-929(-76)+75-1902(-78)+100-900(-78)+101-875(-79)+125-880(-79)+121-275(-80)+75-526(-80)+150-13861(-81)+100-49933(-81)+75-2882(-78)+125-826(-78)+200-875(-79)+100-901(-79)+100-853(-79)+148-375(-80)+100-451(-80)+75-275(-81)+125-200(-81)+75-226(-81)+75-15946(-74)+51-2938(-75)+100-4879(-80)+100-300(-80)+101-350(-80)+125-23879(-75)+100-1896(-75)+100-901(-77)+100-901(-78)+100-876(-79)+152-348(-80)+75-901(-80)+100-876(-81)+175-375(-81)+153-17350(-81)+51-1927(-76)+75-325(-77)+75-16511(-75)+74-1906(-76)+125-826(-77)+175-900(-78)+100-251(-79)+200-1376(-80)+100-325(-80)+100-1452(-81)+125-26894(-74)+125-876(-79)+100-925(-80)+75-876(-80)+150-351(-80)+75-101(-80)+149-176(-80)+99-69939(-74)+75-926(-78)+75-900(-79)+100-901(-80)+100-75(-80)+175-726(-80)+150-726(-81)+125-550(-81)+201-36069(-76)+125-175(-78)+125-601(-78)+100-200(-79)+100-425(-79)+126-875(-79)+125-75(-80)+75-901(-80)+100-901(-81)+100-2527(-81)+75-175(-81)+0-0(0) \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RTL_433toMQTT/undecoded signal msg: {\"model\":\"undecoded signal\",\"protocol\":\"signal parsing failed\",\"duration\":806196,\"rssi\":-77,\"pulses\":162} \nrtl_433_ESP(6): Unparsed Signal length: 202996, Signal RSSI: -71, pulses: 47\nrtl_433_ESP(6): RAW (202996): +0-13056(-74)+0-1992(-75)+100-955(-76)+125-450(-76)+175-125(-76)+75-126(-77)+200-275(-77)+250-275(-78)+150-16444(-74)+125-327(-75)+51-932(-76)+75-876(-76)+125-100(-77)+75-1752(-77)+400-576(-79)+100-400(-79)+100-100(-79)+251-350(-80)+150-175(-80)+225-350(-80)+76-75(-80)+75-325(-81)+350-59664(-81)+75-1918(-77)+100-375(-77)+151-150(-77)+400-275(-78)+275-251(-78)+450-175(-78)+275-326(-79)+200-30383(-74)+100-1905(-74)+75-406(-76)+75-275(-76)+100-426(-77)+100-250(-78)+250-103(-78)+148-275(-78)+151-51091(-75)+122-2832(-77)+124-751(-78)+75-75(-79)+100-801(-79)+200-901(-80)+125-350(-80)+150-400(-81)+150-0(-81)\n```", "createdAt": "2025-12-29T22:17:12Z", "updatedAt": "2025-12-29T22:17:12Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cZi2U", "body": "Hi @Odyno \ndrilled the problem down to #2245.... \nLast Build with from Nov 22 2025 with #401be5f10c93d141d9dcfaec8783715e49c0cba1 works as intended.", "createdAt": "2025-12-29T22:37:04Z", "updatedAt": "2025-12-29T22:37:04Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cZpb4", "body": "Ok, but it\u2019s not clear to me at this point. It seems that the issue isn\u2019t related to switching between the two configurations, is that right? I got a bit lost in your experiments, could you please summarize what you\u2019ve found? I\u2019d really appreciate it.", "createdAt": "2025-12-29T22:54:19Z", "updatedAt": "2025-12-29T22:54:19Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7cZ2HM", "body": "i'll try to summarize\n\n#2245 introduced a problem during CC1101 initialization... Seems that the SPI-Interface is not started properly.\n\nTo fix that problem during runtime, i need to perform the following steps\n\n-go to the WebUI -> Configuration -> Configure RF\n-set \"Active Library\" to \"INACTIVE\"\n-Wait some seconds (if i change settings to fast, ESP will crash and reboot)\n-set \"Active Library\" back to \"RTL_433\"\n\n Now you see the _N: C1101 spi Connection OK_ in the Log and the CC1101 receives signals...\n\n", "createdAt": "2025-12-29T23:07:52Z", "updatedAt": "2025-12-29T23:07:52Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cqVBb", "body": "btw, there must be some more strange stuff happening in the **void initCC1101()**\n\ni tried an esp32-s3 board as well with cc1101 and got the same issue with the need of deactivating/reactivating RTL to make it work. But the serial-log looks a but off to what i expected...\n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\n[ 75058][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75059][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75065][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75098][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75099][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75099][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75148][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75149][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75149][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75230][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75231][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75231][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75376][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75377][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75377][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75650][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75651][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75651][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 76168][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76169][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76169][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 76686][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76687][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76687][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 77204][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77205][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77205][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 77722][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77723][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77724][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\nN: Enable RTL_433 Receiver: 433.92Mhz\nN: RF Config_save: {\"frequency\":433.92,\"active\":3,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OMG_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":-79,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":10720} \nrtl_433_ESP(6): Unparsed Signal length: 129998, Signal RSSI: -76, pulses: 27\nrtl_433_ESP(6): RAW (129998): +249-1175(-77)+1237-89(-78)+427-99(-78)+100-675(-79)+75-151(-79)+376-199(-79)+501-733(-80)+270-727(-81)+4500-724(-81)+75-125(-81)+2232-570(-81)+1301-701(-81)+21919-146(-81)+6705-74(-81)+18639-99(-81)+953-2975(-81)+527-125(-81)+4907-72(-81)+6912-169(-81)+252-149(-81)+51-524(-81)+4034-895(-78)+1126-248(-80)+151-575(-80)+627-1150(-81)+200-125(-81)+0-0(0) \nN: [ OMG->MQTT ] topic: home/OMG_rtl_433_ESP/RTL_433toMQTT/undecoded signal msg: {\"model\":\"undecoded signal\",\"protocol\":\"signal parsing failed\",\"duration\":129998,\"rssi\":-76,\"pulses\":27} \n```\n\ni got the 10x \"C1101 spi Connection Error\" but never a \"C1101 spi Connection OK\" Notice from the log, but CC1101 works fine... \n\nUpdate:\nwhen i explicit define the pinout, the invalid PIN messages disappears..\n\n```\n  '-DRF_CC1101=\"CC1101\"'       ; CC1101 Transceiver Module\n  '-DRF_MODULE_SCK=12'\n  '-DRF_MODULE_MISO=13'\n  '-DRF_MODULE_MOSI=11'\n  '-DRF_MODULE_CS=10'\n  '-DRF_MODULE_GDO0=14'        ; CC1101 pin GDO0\n  '-DRF_MODULE_GDO2=9'        ; CC1101 pin GDO2\n```\n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\n[109007][E][esp32-hal-cpu.c:110] addApbChangeCallback(): duplicate func=0x420f10c4 arg=0x3fc98a34\nN: C1101 spi Connection OK\nN: Enable RTL_433 Receiver: 433.92Mhz\n```\n\n", "createdAt": "2025-12-31T12:06:58Z", "updatedAt": "2025-12-31T12:20:21Z", "author": {"login": "Dattel"}}]}, {"comments": [{"id": "IC_kwDOBBSfJs7dCjjT", "body": "I have a very similar issue, but with an other device. It's a Lilygo 1.6.1 Lora with SX1276 running rtl_433-fsk. \nThe device boots fine, but does not decode any signals. Only after going to configuration and just hitting save, the RF module starts receiving code and everything works fine - until the next reboot.", "createdAt": "2026-01-04T21:17:51Z", "updatedAt": "2026-01-04T21:17:51Z", "author": {"login": "iz3man"}}, {"id": "IC_kwDOBBSfJs7dCs9H", "body": "thats exactly what i figured out... :-D\n\nYou need to \"reenable\" the RF-Module manually everytime the device boots..\n", "createdAt": "2026-01-04T22:13:12Z", "updatedAt": "2026-01-04T22:13:12Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7dG8Yl", "body": "I'm sorry, but I really can't test or fix this now. Until I can flash a board, I won't be able to check the problem myself. What I can do is give you a diff that shows how I think it can be fixed. I haven't tested it, I only reviewed the code. If you want to try it before I arrive, here it is:\n\n\n```\n--- a/main/rf/RFConfiguration.h\n+++ b/main/rf/RFConfiguration.h\n@@ -48,7 +48,12 @@ public:\n   /**\n    * Loads the RF configuration from persistent storage and applies it.\n    *\n+   * @param reinitReceiver If true (default), disables and re-enables the receiver.\n+   *                       If false, only loads the configuration without reinitialization.\n+   *\n    * @note This function has specific behavior for ESP32 platforms. On ESP32,\n    *       it uses the Preferences library to access stored configuration data.\n    *       For other platforms, it directly enables the active receiver.\n    */\n-  void loadFromStorage();\n+  void loadFromStorage(bool reinitReceiver = true);\n\n--- a/main/rf/RFConfiguration.cpp\n+++ b/main/rf/RFConfiguration.cpp\n@@ -130,10 +130,11 @@ void RFConfiguration::eraseStorage() {\n  * @brief Loads the RF configuration from persistent storage and applies it.\n  *\n  * This function retrieves the RF configuration stored in non-volatile\n  * storage (NVS) and applies it to the RF receiver. If the configuration\n  * is not found, a notice is logged, and the RF receiver is enabled with\n  * default settings.\n  *\n  * @note This function has specific behavior for ESP32 platforms. On ESP32,\n  *       it uses the Preferences library to access stored configuration data.\n  *       For other platforms, it directly enables the active receiver.\n+ *\n+ * @param reinitReceiver If true (default), disables and re-enables the receiver.\n+ *                       If false, only loads the configuration without reinitialization.\n  */\n-void RFConfiguration::loadFromStorage() {\n+void RFConfiguration::loadFromStorage(bool reinitReceiver) {\n #ifdef ESP32\n   StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n   preferences.begin(Gateway_Short_Name, true);\n@@ -157,6 +158,11 @@ void RFConfiguration::loadFromStorage() {\n     Log.notice(F(\"RF Config not found using default\" CR));\n   }\n #endif\n+  // Disable and re-enable the receiver to ensure proper initialization\n+  if (reinitReceiver) {\n+    iRFReceiver.disable();\n+    iRFReceiver.enable();\n+  }\n }\n \n /**\n@@ -199,6 +205,7 @@ void RFConfiguration::loadFromStorage() {\n void RFConfiguration::loadFromMessage(JsonObject& RFdata) {\n   if (RFdata.containsKey(\"init\") && RFdata[\"init\"].as<bool>()) {\n     // Restore the default (initial) configuration\n     reInit();\n+  } else if (RFdata.containsKey(\"load\") && RFdata[\"load\"].as<bool>()) {\n+    // Load the saved configuration from storage (without receiver reinitialization)\n+    loadFromStorage(false);\n   }\n \n   fromJson(RFdata);\n\n\n```", "createdAt": "2026-01-05T09:24:21Z", "updatedAt": "2026-01-05T09:42:20Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7dJ6Q4", "body": "@claude Could you sum-up the sequence of activation and deactivation of the RF modules before and after https://github.com/1technophile/OpenMQTTGateway/pull/2245\nHighlight any changes that could have caused this issue", "createdAt": "2026-01-05T13:11:46Z", "updatedAt": "2026-01-05T13:11:46Z", "author": {"login": "1technophile"}}, {"id": "IC_kwDOBBSfJs7dJ6du", "body": "**Claude finished @1technophile's task in 7m 14s** \u2014\u2014 [View job](https://github.com/1technophile/OpenMQTTGateway/actions/runs/20716452790)\n\n---\n### Analysis Complete: RF Module Initialization Changes\n\nI've analyzed the code and identified the root cause of the CC1101 initialization issue introduced in PR #2245.\n\n---\n\n### Root Cause\n\nThe issue is in `main/rf/RFConfiguration.cpp:141-167` in the `loadFromStorage()` function. \n\n**The Problem**: When a saved configuration exists in NVS storage, `loadFromStorage()` loads the config but **never calls `iRFReceiver.enable()`**, which means `initCC1101()` is never invoked during boot.\n\n### Sequence Comparison\n\n#### BEFORE PR #2245 (Working)\nThe old code likely called the receiver enable function directly during setup, ensuring CC1101 was always initialized on boot.\n\n#### AFTER PR #2245 (Broken)\n\n**Boot sequence when saved config EXISTS:**\n1. `setupCommonRF()` \u2192 `iRFConfig.loadFromStorage()`\n2. `loadFromStorage()` finds saved config in NVS\n3. Calls `fromJson(jo)` to load settings\n4. **STOPS** - never calls `iRFReceiver.enable()` \u274c\n5. Result: `enableActiveReceiver()` \u2192 `initCC1101()` chain never executes\n\n**Boot sequence when NO saved config:**\n1. `setupCommonRF()` \u2192 `iRFConfig.loadFromStorage()`\n2. `loadFromStorage()` doesn't find config\n3. Calls `iRFReceiver.enable()` \u2705\n4. Result: CC1101 initializes properly\n\n**WebUI toggle (workaround):**\n1. User changes config \u2192 `loadFromMessage()` is called\n2. `loadFromMessage()` calls `fromJson(jo)`\n3. Then calls `iRFReceiver.disable()` and `iRFReceiver.enable()` \u2705\n4. Result: CC1101 initializes\n\n### The Enable Chain That's Missing\n\n```cpp\niRFReceiver.enable()\n  \u2192 ZCommonRFWrapper::enable() (commonRF.cpp:54)\n    \u2192 enableActiveReceiver() (commonRF.cpp:152)\n      \u2192 initCC1101() (commonRF.cpp:64-88)  \u2190 NEVER CALLED ON BOOT\n        \u2192 ELECHOUSE_cc1101.getCC1101()\n        \u2192 ELECHOUSE_cc1101.Init()\n        \u2192 ELECHOUSE_cc1101.SetRx()\n```\n\n### Code Comparison\n\n**`loadFromStorage()` - lines 141-167** (BROKEN on boot):\n```cpp\nif (preferences.isKey(\"RFConfig\")) {\n  // ... load config ...\n  fromJson(jo);\n  Log.notice(F(\"RF Config loaded\" CR));\n  // \u274c MISSING: iRFReceiver.enable() is NEVER called!\n}\n```\n\n**`loadFromMessage()` - lines 191-212** (WORKS from WebUI):\n```cpp\nfromJson(RFdata);\n\niRFReceiver.disable();\niRFReceiver.enable();  // \u2705 THIS IS CALLED\n```\n\n### Recommended Fix\n\n**Simple solution** - Add one line in `RFConfiguration.cpp:loadFromStorage()`:\n\n```cpp\nvoid RFConfiguration::loadFromStorage() {\n#ifdef ESP32\n  StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n  preferences.begin(Gateway_Short_Name, true);\n  if (preferences.isKey(\"RFConfig\")) {\n    auto error = deserializeJson(jsonBuffer, preferences.getString(\"RFConfig\", \"{}\"));\n    preferences.end();\n    if (error) {\n      Log.error(F(\"RF Config deserialization failed: %s, buffer capacity: %u\" CR), error.c_str(), jsonBuffer.capacity());\n      return;\n    }\n    if (jsonBuffer.isNull()) {\n      Log.warning(F(\"RF Config is null\" CR));\n      return;\n    }\n    JsonObject jo = jsonBuffer.as<JsonObject>();\n    fromJson(jo);\n    Log.notice(F(\"RF Config loaded\" CR));\n    iRFReceiver.enable();  // \u2190 ADD THIS LINE (matches line 162 behavior)\n  } else {\n    preferences.end();\n    Log.notice(F(\"RF Config not found using default\" CR));\n    iRFReceiver.enable();  // \u2190 Already here for \"no config\" case\n  }\n#else\n  iRFReceiver.enable();\n#endif\n}\n```\n\nThis ensures both code paths (config exists vs. doesn't exist) behave identically: load config, then enable receiver.\n\n### Why WebUI Toggle Works\n\nThe WebUI workaround triggers `loadFromMessage()` which correctly calls:\n```cpp\niRFReceiver.disable();\niRFReceiver.enable();\n```\n\nThis properly initializes CC1101, explaining why the workaround succeeds.\n\n### Additional Notes\n\n- There's a `//TODO review` comment at `commonRF.cpp:63` before `initCC1101()`, suggesting this code area was flagged for review\n- The issue affects users who have saved their RF config to NVS (most users after first configuration)\n- First-time users or those without saved config don't see the issue\n- The bug also explains the \"Invalid pin selected\" errors on ESP32-S3 that resolved when explicit pins were defined\n\n### Summary\n\n**What changed**: PR #2245 introduced the `RFConfiguration` class with `loadFromStorage()` and `loadFromMessage()` methods. The `loadFromStorage()` method loads saved config but fails to call `iRFReceiver.enable()` when config exists.\n\n**Impact**: Users with saved RF configurations (most users after initial setup) experience CC1101 not initializing on boot. First-time users are unaffected because the \"no config\" path correctly calls `enable()`.\n\n**Fix**: Add `iRFReceiver.enable()` call after loading configuration in `loadFromStorage()` to match the behavior in both the \"no config\" branch and the `loadFromMessage()` method.\n\n---", "createdAt": "2026-01-05T13:12:03Z", "updatedAt": "2026-01-05T13:55:35Z", "author": {"login": "claude"}}, {"id": "IC_kwDOBBSfJs7dKH3g", "body": "@claude could you propose a PR to fix this", "createdAt": "2026-01-05T13:25:22Z", "updatedAt": "2026-01-05T13:25:22Z", "author": {"login": "1technophile"}}, {"id": "IC_kwDOBBSfJs7dKIFV", "body": "**Claude encountered an error** \u2014\u2014 [View job](https://github.com/1technophile/OpenMQTTGateway/actions/runs/20716816038)\n\n---\nI'll analyze this and get back to you.", "createdAt": "2026-01-05T13:25:38Z", "updatedAt": "2026-01-05T13:28:17Z", "author": {"login": "claude"}}, {"id": "IC_kwDOBBSfJs7dLKyz", "body": "@1technophile  Yes, it is the same solution I found, but it is missing one thing. It disables and enables the driver twice every time you save from the message. That\u2019s why I added that flag reinitReceiver to my diff. ", "createdAt": "2026-01-05T14:36:10Z", "updatedAt": "2026-01-05T14:36:10Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7dPw5s", "body": "@1technophile & @Odyno but works fine for me \ud83d\udc4d ", "createdAt": "2026-01-05T19:58:59Z", "updatedAt": "2026-01-05T19:58:59Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7dZNIY", "body": "@Odyno make sense, thanks for pointing this\n@claude create a PR with @Odyno solution and close the other one", "createdAt": "2026-01-06T11:34:17Z", "updatedAt": "2026-01-06T11:34:17Z", "author": {"login": "1technophile"}}, {"id": "IC_kwDOBBSfJs7dZNSD", "body": "**Claude finished @1technophile's task in 1m 43s** \u2014\u2014 [View job](https://github.com/1technophile/OpenMQTTGateway/actions/runs/20747071005) \u2022 [`claude/issue-2264-20260106-1134`](https://github.com/1technophile/OpenMQTTGateway/tree/claude/issue-2264-20260106-1134) \u2022 [Create PR \u2794](https://github.com/1technophile/OpenMQTTGateway/compare/development...claude/issue-2264-20260106-1134?quick_pull=1&title=Fix%20CC1101%20initialization%20on%20boot%20with%20saved%20RF%20config&body=%23%23%20Summary%0AFixes%20%232264%20-%20CC1101%20not%20initializing%20properly%20on%20boot%20when%20a%20saved%20RF%20configuration%20exists.%0A%0A%23%23%20Changes%0A-%20Added%20%60reinitReceiver%60%20parameter%20to%20%60loadFromStorage()%60%20(default%3A%20%60true%60)%0A-%20When%20true%2C%20disables%20and%20re-enables%20the%20receiver%20after%20loading%20config%0A-%20%60loadFromMessage()%60%20passes%20%60false%60%20to%20avoid%20double%20initialization%0A%0A%23%23%20Root%20Cause%0AWhen%20saved%20config%20existed%20in%20NVS%2C%20%60loadFromStorage()%60%20loaded%20config%20but%20never%20called%20%60iRFReceiver.enable()%60%2C%20so%20%60initCC1101()%60%20was%20never%20invoked.%0A%0ASolution%20by%20%40Odyno%0A%0A%F0%9F%A4%96%20Generated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode))\n\n---\n### CC1101 Initialization Fix Implemented\n\n#### Summary\nImplemented @Odyno's solution to fix the CC1101 initialization issue on boot when a saved RF configuration exists.\n\n#### Changes Made\n- Added `reinitReceiver` parameter to `loadFromStorage()` (default: `true`)\n- When `reinitReceiver` is true, the receiver is disabled then re-enabled after loading config\n- Updated `loadFromMessage()` to pass `false` to avoid double initialization\n- Moved the receiver enable logic outside the `#ifdef ESP32` block so it works on all platforms\n\n#### Root Cause\nWhen a saved configuration existed in NVS, `loadFromStorage()` was loading the config but never calling `iRFReceiver.enable()`, which meant `initCC1101()` was never invoked during boot. The WebUI toggle worked because `loadFromMessage()` explicitly calls `disable()/enable()`.\n\n#### Todo List\n- [x] Review @Odyno's proposed diff solution\n- [x] Read current `RFConfiguration.h` and `RFConfiguration.cpp` files\n- [x] Implement the `reinitReceiver` parameter changes\n- [x] Commit and push changes\n- [x] Create PR link\n- [x] Close the other PR (I cannot close PRs directly - please close it manually)\n\n\n\n---\n |", "createdAt": "2026-01-06T11:34:30Z", "updatedAt": "2026-01-06T11:48:08Z", "author": {"login": "claude"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 2269, "link_type": "closing_keyword", "will_close": true, "comment_count": 19, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

1technophile_OpenMQTTGateway_2269__agent_authored/pr.json

@@ -0,0 +1 @@
+{"repo": "1technophile/OpenMQTTGateway", "pr_number": 2269, "pr_title": "[RF] Fix CC1101 initialization on boot with saved RF config", "pr_state": "merged", "pr_author": "1technophile", "base_branch": "development", "head_branch": "claude/issue-2264-20260106-1134", "created_at": "2026-01-06T11:47:16Z", "merged_at": "2026-01-06T11:47:49Z", "base_ref_oid": "0c2884c3922d86c2e1f974b032e05d9a6fd848df", "head_ref_oid": "94869e6fb91b5d4e35630e0119602ac226af3d94", "base_commit": {"oid": "0c2884c3922d86c2e1f974b032e05d9a6fd848df", "message": "[CI] Configure Claude GitHub Actions to use Opus model (#2267)\n\n* [CI] Configure Claude GitHub Actions to use Opus model\n\n- Add --model opus flag to claude.yml workflow\n- Add --model opus flag to claude-code-review.yml workflow\n- Ensures advanced reasoning capabilities for complex firmware codebase\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.com/claude-code)\n\nCo-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>\n\n* Fix model ID to use full Claude Opus identifier\n\n---------\n\nCo-authored-by: Florian <1technophile@users.noreply.github.com>\nCo-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>", "authoredDate": "2026-01-05T13:58:05Z", "author": {"name": "Florian", "email": "florian@theengs.io", "user": {"login": "1technophile"}}}, "rounds": [], "threads": [], "agent_threads": [], "pr_review_class": "mixed", "compliance": {"total_threads": 0, "resolved": 0, "unresolved": 0, "compliance_rate": 0.0, "compliance_class": "unreviewed", "inline_threads": 0, "body_only_threads": 0, "compliance_band": "unreviewed", "n_agent_threads": 0}, "linked_issues": [{"number": 2264, "title": "Changes between 1.8.1 and development breaks CC1101 (rcswitch / smartrc-cc1101-driver) default behaviour", "body": "Hi again :-D\n\ni recently updated my ESP with the latest development-build and found some change in behaviour. \n\n**Describe the bug**\nThere must be some changes between v1.8.1 and the current development-branch, that causes the TI-C1101 not to listen properly by default on boot. Maybe there is a problem between RC-Switch and smartrc-cc1101-driver\n\n**To Reproduce**\n-compile latest development source files\n-upload latest build to ESP\n-let ESP boot\n-watch MQTT or Serial-console and wait for captured RF-signals\n-Conclusion: CC1101 seems not to listen like it did with earlier version v1.8.0-development\n\nTo Fix it, open the WebUI and switch from RTL_433 to RF and back\n<img width=\"501\" height=\"438\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/b6dcaa31-4240-4b9d-9b77-bfb4bd5d84b0\" />\n-Sometimes the ESP crashes at these point and failed to activate SPI Interface properly.\n-after a reboot, i can try to switch between RTL_433 to RF without crash\n\n**Expected behavior**\nIf attached to esp, the CC1101 shoud be initialized and receiving on boot-time\n\n\n**Environment**\n* OpenMQTTGateway version used (V1.8.1 development - build from latest files)\n* smartrc-cc1101 with rc-switch\n\n* Hardware: ESP32-Wroom-32D Board\n* Receiver: TI-CC1101\n\nCustom Environment:\n-smartrc for receiving temperatures from LaCrosse/Nexus\n-rc-switch for controling old RF433 sockets\n\n```\n[mycustom]\nbuild_flags =\n  '-DOMG_VERSION=\"v1.8.1\"'\n\n[env:custom-esp32dev-rtl_433]\nplatform = espressif32@6.1.0\nboard = esp32dev\nboard_build.partitions = min_spiffs.csv\nlib_deps =\n  ${com-esp32.lib_deps}\n  ${libraries.rtl_433_ESP}\n  ${libraries.rc-switch}\n  ${libraries.smartrc-cc1101-driver-lib}\nbuild_flags =\n  ${com-esp32.build_flags}\n  ${mycustom.build_flags}  \n; *** OpenMQTTGateway Config ***\n  '-UZmqttDiscovery'          ; disables MQTT Discovery\n  '-DvalueAsATopic=true'       ; MQTT topic includes model and device\n;  '-DLOG_LEVEL=LOG_LEVEL_TRACE'\n  '-DGateway_Name=\"OpenMQTTGateway_rtl_433_ESP\"'\n  '-DjsonPublishing=true'\n; *** OpenMQTTGateway Modules ***\n  '-DZgatewayRTL_433=\"rtl_433\"'\n  '-DZgatewayRF=\"RF\"'\n  '-DZradioCC1101=\"CC1101\"'\n; *** rtl_433_ESP Options ***\n;  '-DRTL_DEBUG=4'             ; rtl_433 verbose mode\n;  '-DRTL_VERBOSE=58'          ; LaCrosse TX141-Bv2, TX141TH-Bv2, TX141-Bv3, TX141W, TX145wsdth sensor\n;  '-DRAW_SIGNAL_DEBUG=true'   ; display raw received messages\n;  '-DMEMORY_DEBUG=true'       ; display memory usage information\n;  '-DDEMOD_DEBUG=true'         ; display signal debug info\n;  '-DMY_DEVICES=true'         ; subset of devices\n  '-DPUBLISH_UNPARSED=true'    ; publish unparsed signal details\n;  '-DRSSI_THRESHOLD=12'       ; Apply a delta of 12 to average RSSI level\n;  '-DAVERAGE_RSSI=5000'       ; Display RSSI floor ( Average of 5000 samples )\n  '-DSIGNAL_RSSI=true'         ; Display during signal receive\n;  '-DNO_DEAF_WORKAROUND=true'\n; *** RF Module Options ***\n  '-DRF_CC1101=\"CC1101\"'       ; CC1101 Transceiver Module\n  '-DRF_CC1101_TXPOWER=12'  ; (-30  -20  -15  -10  -6    0    5    7    10   11   12) Default is max!  \n;  '-DRF_MODULE_CS=5'          ; pin to be used as chip select\n  '-DRF_MODULE_GDO0=4'        ; CC1101 pin GDO0\n  '-DRF_MODULE_GDO2=15'        ; CC1101 pin GDO2\n  '-DRF_RECEIVER_GPIO=15' #D2\n  '-DRF_EMITTER_GPIO=4' #D4  \n;  *** LED ***\n  #'-DLED_SEND_RECEIVE=2'\n  #'-DLED_SEND_RECEIVE_ON=1'\n  '-DLED_PIN=2'\n  '-DLED_PIN_ON=LOW'\n  ; *** RadioLib Options ***\n;  '-DRADIOLIB_DEBUG=true'\n;  '-DRADIOLIB_VERBOSE=true'\n;  '-DDISABLERSSITHRESHOLD=true'\ncustom_description = Gateway using RTL_433_ESP library, need CC1101\n```\n\n**Additional context**\n\nHere are some console outputs from ESP-Boot and switching between RTL433/RF to initialize CC1101 after boot.\n```\nN: OpenMQTTGateway URL: http://192.168.178.23/\nN: webUI setup done\nN: Config frequency changed to: false\nN: RF Receive mhz: 433.92\nN: Config active changed to: false\nN: RF receiver active: 3\nN: RF Config loaded\nN: gatewayRTL_433 setup done \nN: Offline disabled\nN: OpenMQTTGateway modules: [\"WebUI\",\"RF\",\"rtl_433\"]\nN: ************** Setup OpenMQTTGateway end **************\nN: Reconfiguring MQTT client...\nN: Update check, free heap: 171676N: Using memory cert\nN: Update check done, free heap: 124448N: Connected to broker\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/LWT msg: online \nN: SYS json: {\"uptime\":10,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":166944,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":111512,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-59,\"SSID\":\"XXXXXXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":\"'WebUI', 'RF', 'rtl_433'\",\"origin\":\"/SYStoMQTT\"}\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RLStoMQTT msg: {\"latest_version\":\"v1.8.1\",\"title\":\"OpenMQTTGateway\",\"release_url\":\"https://github.com/1technophile/OpenMQTTGateway/releases/tag/v1.8.1\",\"installed_version\":\"v1.8.1\",\"entity_picture\":\"https://github.com/1technophile/OpenMQTTGateway/raw/development/docs/img/Openmqttgateway_logo_mini_margins.png\",\"release_summary\":\"\"} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/SYStoMQTT msg: {\"uptime\":10,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":166944,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":111512,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-59,\"SSID\":\"XXXXXXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":[\"WebUI\",\"RF\",\"rtl_433\"]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":0,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":3980} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/WebUItoMQTT msg: {\"displayMetric\":true,\"webUISecure\":false,\"displayQueue\":0} \n```\n\nSwitching from RTL_433 to RF\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nN: C1101 spi Connection OK\nN: [RF] Enable RF Receiver: Mhz, RF_EMITTER_GPIO: 0, RF_RECEIVER_GPIO: 1610612736\nN: RF Config_save: {\"frequency\":433.92,\"active\":2,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":0,\"ookthreshold\":0,\"active\":2,\"white-list\":[],\"black-list\":[]} \n```\n\nSwitching from RF to RTL_433 \n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nN: C1101 spi Connection OK\nN: Enable RTL_433 Receiver: 433.92Mhz\nN: RF Config_save: {\"frequency\":433.92,\"active\":3,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\n```\n", "state": "CLOSED", "created_at": "2025-12-28T23:03:55Z", "closed_at": "2026-01-06T11:47:50Z", "author_login": "Dattel", "comment_rounds": [{"comments": [{"id": "IC_kwDOBBSfJs7cYxTu", "body": "Have you already looked at the code? Are you thinking of anything specific? There have been several changes recently in the RF department. I have the same hardware configuration as you, but I can't load the latest configuration (problem with firmware loading), so I can't check... I hope to be able to reproduce the problem as soon as possible and give you more information.", "createdAt": "2025-12-29T20:27:22Z", "updatedAt": "2025-12-29T20:27:22Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7cY9Rz", "body": "not sure... maybe the reason is, that i want to run both (rcswitch and smartrc-cc1101-driver) libs in parallel and maybe the initialization of one crashes the other... \n\ni will check later, if compiling only with smartrc will work as intended\n", "createdAt": "2025-12-29T20:57:40Z", "updatedAt": "2025-12-29T20:57:40Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cY-xy", "body": "by the way... \nthere is something weired with the RF_Pins in the Log during switch from RTL_433 to RF\n\nN: [RF] Enable RF Receiver: Mhz, **RF_EMITTER_GPIO: 0, RF_RECEIVER_GPIO: 1610612736**\n\nAs you can see in my provided configuration, both pins are defined correct", "createdAt": "2025-12-29T21:01:30Z", "updatedAt": "2025-12-29T21:01:30Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cZboS", "body": "Ok, same behaviour with a rtl_433-only Build. So no competition-problem between rcswitch an rtl_433.\nHere are some more protocols from bootup till the first RAW Signal is detected.\n\nNormal Boot-process. Please note that the CC1101 with SPI is missing here.\n```\n************* WELCOME TO OpenMQTTGateway **************\nN: SYS config not found\nN: OpenMQTTGateway Version: v1.8.1\nN: OTA server cert hash: 02118cbaf5cc02748398d93ecdb0ef2a444c37358a617bfb2206dfe351dc7cf2\nN: Config loaded from flash\nN: Attempting Wifi connection with saved AP: 0\nN: Attempting Wifi connection with saved AP: 1\nE (3073) wifi:sta is connecting, return error\n[  1344][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Attempting Wifi connection with saved AP: 2\nE (4082) wifi:sta is connecting, return error\n[  2352][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Attempting Wifi connection with saved AP: 3\nE (5091) wifi:sta is connecting, return error\n[  3361][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Attempting Wifi connection with saved AP: 4\nE (6099) wifi:sta is connecting, return error\n[  4369][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: Connect your phone to WIFI AP: OpenMQTTGateway_rtl_433_ESP with PWD: \nE (8760) wifi:sta is connecting, return error\n[  7030][E][WiFiSTA.cpp:317] begin(): connect failed! 0x3007\nN: OpenMQTTGateway URL: http://192.168.178.23/\nN: webUI setup done\nN: Config frequency changed to: false\nN: RF Receive mhz: 433.92\nN: Config active unchanged, currently: false\nN: RF receiver active: 3\nN: RF Config loaded\nN: gatewayRTL_433 setup done \nN: Offline disabled\nN: OpenMQTTGateway modules: [\"WebUI\",\"rtl_433\"]\nN: ************** Setup OpenMQTTGateway end **************\nN: Reconfiguring MQTT client...\nN: Update check, free heap: 173540N: Using memory cert\nN: Update check done, free heap: 126304N: Connected to broker\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/LWT msg: online \nN: SYS json: {\"uptime\":9,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168788,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":114740,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-58,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":\"'WebUI', 'rtl_433'\",\"origin\":\"/SYStoMQTT\"}\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RLStoMQTT msg: {\"latest_version\":\"v1.8.1\",\"title\":\"OpenMQTTGateway\",\"release_url\":\"https://github.com/1technophile/OpenMQTTGateway/releases/tag/v1.8.1\",\"installed_version\":\"v1.8.1\",\"entity_picture\":\"https://github.com/1technophile/OpenMQTTGateway/raw/development/docs/img/Openmqttgateway_logo_mini_margins.png\",\"release_summary\":\"\"} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/SYStoMQTT msg: {\"uptime\":9,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168788,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":0,\"msgblck\":0,\"msgrcv\":1,\"maxq\":0,\"cnt_index\":0,\"minmem\":114740,\"tempc\":52.22,\"freestck\":3980,\"powermode\":-1,\"eth\":false,\"rssi\":-58,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":[\"WebUI\",\"rtl_433\"]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":0,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":3980} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/WebUItoMQTT msg: {\"displayMetric\":true,\"webUISecure\":false,\"displayQueue\":0} \n```\n\nNow switching in the webui from **rtl_433** to **inactive**\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nE: ERROR: no receiver selected\nN: RF Config_save: {\"frequency\":433.92,\"active\":0,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":0,\"ookthreshold\":0,\"active\":0,\"white-list\":[],\"black-list\":[]} \nN: SYS json: {\"uptime\":129,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168976,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":5,\"msgblck\":0,\"msgrcv\":5,\"maxq\":4,\"cnt_index\":0,\"minmem\":114740,\"tempc\":51.11,\"freestck\":1692,\"powermode\":-1,\"eth\":false,\"rssi\":-57,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":\"'WebUI', 'rtl_433'\",\"origin\":\"/SYStoMQTT\"}\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/SYStoMQTT msg: {\"uptime\":129,\"version\":\"v1.8.1\",\"mqtt\":true,\"serial\":false,\"env\":\"custom-esp32dev-rtl_433\",\"freemem\":168976,\"mqttp\":\"1883\",\"mqtts\":false,\"mqttv\":false,\"msgprc\":5,\"msgblck\":0,\"msgrcv\":5,\"maxq\":4,\"cnt_index\":0,\"minmem\":114740,\"tempc\":51.11,\"freestck\":1692,\"powermode\":-1,\"eth\":false,\"rssi\":-57,\"SSID\":\"XXXXXXXXXX\",\"BSSID\":\"XXXXXXXXXX\",\"ip\":\"192.168.178.23\",\"mac\":\"4C:11:AE:F7:65:BC\",\"modules\":[\"WebUI\",\"rtl_433\"]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":0,\"ookthreshold\":0,\"active\":0,\"white-list\":[],\"black-list\":[]} \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/WebUItoMQTT msg: {\"displayMetric\":true,\"webUISecure\":false,\"displayQueue\":0} \n```\n\nNow switching in the webui back from **inactive** to **rtl_433**.\nNotice the SPI initialization and that CC1101 instantly receives signals.\n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\nN: C1101 spi Connection OK\nN: Enable RTL_433 Receiver: 433.92Mhz\nN: RF Config_save: {\"frequency\":433.92,\"active\":3,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":-80,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":10904} \nrtl_433_ESP(6): Unparsed Signal length: 806196, Signal RSSI: -77, pulses: 162\nrtl_433_ESP(6): RAW (806196): +0-1203(-78)+117-826(-78)+175-1326(-78)+106-569(-79)+127-175(-80)+150-17516(-76)+100-175(-76)+250-225(-76)+150-276(-76)+75-504(-76)+124-131(-78)+72-348(-79)+200-1711(-79)+65-926(-80)+75-51(-80)+126-424(-80)+100-75(-80)+109-191(-80)+200-426(-81)+26571-300(-81)+223-54141(-75)+102-1513(-76)+100-100(-76)+275-501(-77)+75-126(-77)+224-100(-78)+175-125(-78)+626-100(-78)+325-100(-78)+601-275(-79)+150-203(-79)+147-175(-80)+276-375(-80)+175-76186(-80)+51-375(-76)+100-125(-77)+151-875(-78)+75-901(-78)+125-1902(-79)+75-751(-79)+201-150(-80)+200-350(-80)+100-401(-81)+75-1077(-81)+125-34947(-75)+300-100(-78)+51-201(-78)+149-250(-78)+225-776(-79)+125-275(-79)+175-1851(-81)+125-876(-81)+100-39943(-81)+75-876(-77)+125-16961(-75)+100-576(-75)+76-176(-76)+100-901(-76)+100-425(-77)+149-201(-77)+200-150(-78)+175-500(-78)+100-876(-79)+150-175(-79)+100-276(-79)+100-225(-80)+350-526(-80)+125-851(-81)+125-350(-81)+125-19447(-74)+75-2910(-76)+75-901(-77)+150-526(-77)+226-18090(-75)+126-875(-77)+125-401(-78)+102-298(-78)+200-502(-79)+100-174(-79)+75-801(-80)+100-300(-80)+75-50505(-81)+100-250(-76)+300-376(-77)+100-900(-78)+75-926(-79)+75-45946(-74)+75-75(-76)+51-325(-76)+75-1376(-78)+75-16934(-78)+76-929(-76)+75-1902(-78)+100-900(-78)+101-875(-79)+125-880(-79)+121-275(-80)+75-526(-80)+150-13861(-81)+100-49933(-81)+75-2882(-78)+125-826(-78)+200-875(-79)+100-901(-79)+100-853(-79)+148-375(-80)+100-451(-80)+75-275(-81)+125-200(-81)+75-226(-81)+75-15946(-74)+51-2938(-75)+100-4879(-80)+100-300(-80)+101-350(-80)+125-23879(-75)+100-1896(-75)+100-901(-77)+100-901(-78)+100-876(-79)+152-348(-80)+75-901(-80)+100-876(-81)+175-375(-81)+153-17350(-81)+51-1927(-76)+75-325(-77)+75-16511(-75)+74-1906(-76)+125-826(-77)+175-900(-78)+100-251(-79)+200-1376(-80)+100-325(-80)+100-1452(-81)+125-26894(-74)+125-876(-79)+100-925(-80)+75-876(-80)+150-351(-80)+75-101(-80)+149-176(-80)+99-69939(-74)+75-926(-78)+75-900(-79)+100-901(-80)+100-75(-80)+175-726(-80)+150-726(-81)+125-550(-81)+201-36069(-76)+125-175(-78)+125-601(-78)+100-200(-79)+100-425(-79)+126-875(-79)+125-75(-80)+75-901(-80)+100-901(-81)+100-2527(-81)+75-175(-81)+0-0(0) \nN: [ OMG->MQTT ] topic: home/OpenMQTTGateway_rtl_433_ESP/RTL_433toMQTT/undecoded signal msg: {\"model\":\"undecoded signal\",\"protocol\":\"signal parsing failed\",\"duration\":806196,\"rssi\":-77,\"pulses\":162} \nrtl_433_ESP(6): Unparsed Signal length: 202996, Signal RSSI: -71, pulses: 47\nrtl_433_ESP(6): RAW (202996): +0-13056(-74)+0-1992(-75)+100-955(-76)+125-450(-76)+175-125(-76)+75-126(-77)+200-275(-77)+250-275(-78)+150-16444(-74)+125-327(-75)+51-932(-76)+75-876(-76)+125-100(-77)+75-1752(-77)+400-576(-79)+100-400(-79)+100-100(-79)+251-350(-80)+150-175(-80)+225-350(-80)+76-75(-80)+75-325(-81)+350-59664(-81)+75-1918(-77)+100-375(-77)+151-150(-77)+400-275(-78)+275-251(-78)+450-175(-78)+275-326(-79)+200-30383(-74)+100-1905(-74)+75-406(-76)+75-275(-76)+100-426(-77)+100-250(-78)+250-103(-78)+148-275(-78)+151-51091(-75)+122-2832(-77)+124-751(-78)+75-75(-79)+100-801(-79)+200-901(-80)+125-350(-80)+150-400(-81)+150-0(-81)\n```", "createdAt": "2025-12-29T22:17:12Z", "updatedAt": "2025-12-29T22:17:12Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cZi2U", "body": "Hi @Odyno \ndrilled the problem down to #2245.... \nLast Build with from Nov 22 2025 with #401be5f10c93d141d9dcfaec8783715e49c0cba1 works as intended.", "createdAt": "2025-12-29T22:37:04Z", "updatedAt": "2025-12-29T22:37:04Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cZpb4", "body": "Ok, but it\u2019s not clear to me at this point. It seems that the issue isn\u2019t related to switching between the two configurations, is that right? I got a bit lost in your experiments, could you please summarize what you\u2019ve found? I\u2019d really appreciate it.", "createdAt": "2025-12-29T22:54:19Z", "updatedAt": "2025-12-29T22:54:19Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7cZ2HM", "body": "i'll try to summarize\n\n#2245 introduced a problem during CC1101 initialization... Seems that the SPI-Interface is not started properly.\n\nTo fix that problem during runtime, i need to perform the following steps\n\n-go to the WebUI -> Configuration -> Configure RF\n-set \"Active Library\" to \"INACTIVE\"\n-Wait some seconds (if i change settings to fast, ESP will crash and reboot)\n-set \"Active Library\" back to \"RTL_433\"\n\n Now you see the _N: C1101 spi Connection OK_ in the Log and the CC1101 receives signals...\n\n", "createdAt": "2025-12-29T23:07:52Z", "updatedAt": "2025-12-29T23:07:52Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7cqVBb", "body": "btw, there must be some more strange stuff happening in the **void initCC1101()**\n\ni tried an esp32-s3 board as well with cc1101 and got the same issue with the need of deactivating/reactivating RTL to make it work. But the serial-log looks a but off to what i expected...\n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\n[ 75058][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75059][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75065][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75098][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75099][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75099][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75148][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75149][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75149][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75230][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75231][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75231][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75376][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75377][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75377][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 75650][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75651][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 75651][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 76168][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76169][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76169][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 76686][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76687][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 76687][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 77204][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77205][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77205][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\n[ 77722][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77723][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\n[ 77724][E][esp32-hal-gpio.c:102] __pinMode(): Invalid pin selected\nE: C1101 spi Connection Error\nN: Enable RTL_433 Receiver: 433.92Mhz\nN: RF Config_save: {\"frequency\":433.92,\"active\":3,\"white-list\":[],\"black-list\":[]}, result: 63\nN: RF Config saved\nN: [ OMG->MQTT ] topic: home/OMG_rtl_433_ESP/RFtoMQTT msg: {\"frequency\":433.92,\"rssithreshold\":-82,\"ookthreshold\":0,\"active\":3,\"white-list\":[],\"black-list\":[],\"rssi\":-79,\"avgrssi\":0,\"count\":0,\"rtl433_stack\":10720} \nrtl_433_ESP(6): Unparsed Signal length: 129998, Signal RSSI: -76, pulses: 27\nrtl_433_ESP(6): RAW (129998): +249-1175(-77)+1237-89(-78)+427-99(-78)+100-675(-79)+75-151(-79)+376-199(-79)+501-733(-80)+270-727(-81)+4500-724(-81)+75-125(-81)+2232-570(-81)+1301-701(-81)+21919-146(-81)+6705-74(-81)+18639-99(-81)+953-2975(-81)+527-125(-81)+4907-72(-81)+6912-169(-81)+252-149(-81)+51-524(-81)+4034-895(-78)+1126-248(-80)+151-575(-80)+627-1150(-81)+200-125(-81)+0-0(0) \nN: [ OMG->MQTT ] topic: home/OMG_rtl_433_ESP/RTL_433toMQTT/undecoded signal msg: {\"model\":\"undecoded signal\",\"protocol\":\"signal parsing failed\",\"duration\":129998,\"rssi\":-76,\"pulses\":27} \n```\n\ni got the 10x \"C1101 spi Connection Error\" but never a \"C1101 spi Connection OK\" Notice from the log, but CC1101 works fine... \n\nUpdate:\nwhen i explicit define the pinout, the invalid PIN messages disappears..\n\n```\n  '-DRF_CC1101=\"CC1101\"'       ; CC1101 Transceiver Module\n  '-DRF_MODULE_SCK=12'\n  '-DRF_MODULE_MISO=13'\n  '-DRF_MODULE_MOSI=11'\n  '-DRF_MODULE_CS=10'\n  '-DRF_MODULE_GDO0=14'        ; CC1101 pin GDO0\n  '-DRF_MODULE_GDO2=9'        ; CC1101 pin GDO2\n```\n\n```\nN: [WebUI] Save data\nN: Config frequency unchanged, currently: false\nN: RF Receive mhz: 433.92\n[109007][E][esp32-hal-cpu.c:110] addApbChangeCallback(): duplicate func=0x420f10c4 arg=0x3fc98a34\nN: C1101 spi Connection OK\nN: Enable RTL_433 Receiver: 433.92Mhz\n```\n\n", "createdAt": "2025-12-31T12:06:58Z", "updatedAt": "2025-12-31T12:20:21Z", "author": {"login": "Dattel"}}]}, {"comments": [{"id": "IC_kwDOBBSfJs7dCjjT", "body": "I have a very similar issue, but with an other device. It's a Lilygo 1.6.1 Lora with SX1276 running rtl_433-fsk. \nThe device boots fine, but does not decode any signals. Only after going to configuration and just hitting save, the RF module starts receiving code and everything works fine - until the next reboot.", "createdAt": "2026-01-04T21:17:51Z", "updatedAt": "2026-01-04T21:17:51Z", "author": {"login": "iz3man"}}, {"id": "IC_kwDOBBSfJs7dCs9H", "body": "thats exactly what i figured out... :-D\n\nYou need to \"reenable\" the RF-Module manually everytime the device boots..\n", "createdAt": "2026-01-04T22:13:12Z", "updatedAt": "2026-01-04T22:13:12Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7dG8Yl", "body": "I'm sorry, but I really can't test or fix this now. Until I can flash a board, I won't be able to check the problem myself. What I can do is give you a diff that shows how I think it can be fixed. I haven't tested it, I only reviewed the code. If you want to try it before I arrive, here it is:\n\n\n```\n--- a/main/rf/RFConfiguration.h\n+++ b/main/rf/RFConfiguration.h\n@@ -48,7 +48,12 @@ public:\n   /**\n    * Loads the RF configuration from persistent storage and applies it.\n    *\n+   * @param reinitReceiver If true (default), disables and re-enables the receiver.\n+   *                       If false, only loads the configuration without reinitialization.\n+   *\n    * @note This function has specific behavior for ESP32 platforms. On ESP32,\n    *       it uses the Preferences library to access stored configuration data.\n    *       For other platforms, it directly enables the active receiver.\n    */\n-  void loadFromStorage();\n+  void loadFromStorage(bool reinitReceiver = true);\n\n--- a/main/rf/RFConfiguration.cpp\n+++ b/main/rf/RFConfiguration.cpp\n@@ -130,10 +130,11 @@ void RFConfiguration::eraseStorage() {\n  * @brief Loads the RF configuration from persistent storage and applies it.\n  *\n  * This function retrieves the RF configuration stored in non-volatile\n  * storage (NVS) and applies it to the RF receiver. If the configuration\n  * is not found, a notice is logged, and the RF receiver is enabled with\n  * default settings.\n  *\n  * @note This function has specific behavior for ESP32 platforms. On ESP32,\n  *       it uses the Preferences library to access stored configuration data.\n  *       For other platforms, it directly enables the active receiver.\n+ *\n+ * @param reinitReceiver If true (default), disables and re-enables the receiver.\n+ *                       If false, only loads the configuration without reinitialization.\n  */\n-void RFConfiguration::loadFromStorage() {\n+void RFConfiguration::loadFromStorage(bool reinitReceiver) {\n #ifdef ESP32\n   StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n   preferences.begin(Gateway_Short_Name, true);\n@@ -157,6 +158,11 @@ void RFConfiguration::loadFromStorage() {\n     Log.notice(F(\"RF Config not found using default\" CR));\n   }\n #endif\n+  // Disable and re-enable the receiver to ensure proper initialization\n+  if (reinitReceiver) {\n+    iRFReceiver.disable();\n+    iRFReceiver.enable();\n+  }\n }\n \n /**\n@@ -199,6 +205,7 @@ void RFConfiguration::loadFromStorage() {\n void RFConfiguration::loadFromMessage(JsonObject& RFdata) {\n   if (RFdata.containsKey(\"init\") && RFdata[\"init\"].as<bool>()) {\n     // Restore the default (initial) configuration\n     reInit();\n+  } else if (RFdata.containsKey(\"load\") && RFdata[\"load\"].as<bool>()) {\n+    // Load the saved configuration from storage (without receiver reinitialization)\n+    loadFromStorage(false);\n   }\n \n   fromJson(RFdata);\n\n\n```", "createdAt": "2026-01-05T09:24:21Z", "updatedAt": "2026-01-05T09:42:20Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7dJ6Q4", "body": "@claude Could you sum-up the sequence of activation and deactivation of the RF modules before and after https://github.com/1technophile/OpenMQTTGateway/pull/2245\nHighlight any changes that could have caused this issue", "createdAt": "2026-01-05T13:11:46Z", "updatedAt": "2026-01-05T13:11:46Z", "author": {"login": "1technophile"}}, {"id": "IC_kwDOBBSfJs7dJ6du", "body": "**Claude finished @1technophile's task in 7m 14s** \u2014\u2014 [View job](https://github.com/1technophile/OpenMQTTGateway/actions/runs/20716452790)\n\n---\n### Analysis Complete: RF Module Initialization Changes\n\nI've analyzed the code and identified the root cause of the CC1101 initialization issue introduced in PR #2245.\n\n---\n\n### Root Cause\n\nThe issue is in `main/rf/RFConfiguration.cpp:141-167` in the `loadFromStorage()` function. \n\n**The Problem**: When a saved configuration exists in NVS storage, `loadFromStorage()` loads the config but **never calls `iRFReceiver.enable()`**, which means `initCC1101()` is never invoked during boot.\n\n### Sequence Comparison\n\n#### BEFORE PR #2245 (Working)\nThe old code likely called the receiver enable function directly during setup, ensuring CC1101 was always initialized on boot.\n\n#### AFTER PR #2245 (Broken)\n\n**Boot sequence when saved config EXISTS:**\n1. `setupCommonRF()` \u2192 `iRFConfig.loadFromStorage()`\n2. `loadFromStorage()` finds saved config in NVS\n3. Calls `fromJson(jo)` to load settings\n4. **STOPS** - never calls `iRFReceiver.enable()` \u274c\n5. Result: `enableActiveReceiver()` \u2192 `initCC1101()` chain never executes\n\n**Boot sequence when NO saved config:**\n1. `setupCommonRF()` \u2192 `iRFConfig.loadFromStorage()`\n2. `loadFromStorage()` doesn't find config\n3. Calls `iRFReceiver.enable()` \u2705\n4. Result: CC1101 initializes properly\n\n**WebUI toggle (workaround):**\n1. User changes config \u2192 `loadFromMessage()` is called\n2. `loadFromMessage()` calls `fromJson(jo)`\n3. Then calls `iRFReceiver.disable()` and `iRFReceiver.enable()` \u2705\n4. Result: CC1101 initializes\n\n### The Enable Chain That's Missing\n\n```cpp\niRFReceiver.enable()\n  \u2192 ZCommonRFWrapper::enable() (commonRF.cpp:54)\n    \u2192 enableActiveReceiver() (commonRF.cpp:152)\n      \u2192 initCC1101() (commonRF.cpp:64-88)  \u2190 NEVER CALLED ON BOOT\n        \u2192 ELECHOUSE_cc1101.getCC1101()\n        \u2192 ELECHOUSE_cc1101.Init()\n        \u2192 ELECHOUSE_cc1101.SetRx()\n```\n\n### Code Comparison\n\n**`loadFromStorage()` - lines 141-167** (BROKEN on boot):\n```cpp\nif (preferences.isKey(\"RFConfig\")) {\n  // ... load config ...\n  fromJson(jo);\n  Log.notice(F(\"RF Config loaded\" CR));\n  // \u274c MISSING: iRFReceiver.enable() is NEVER called!\n}\n```\n\n**`loadFromMessage()` - lines 191-212** (WORKS from WebUI):\n```cpp\nfromJson(RFdata);\n\niRFReceiver.disable();\niRFReceiver.enable();  // \u2705 THIS IS CALLED\n```\n\n### Recommended Fix\n\n**Simple solution** - Add one line in `RFConfiguration.cpp:loadFromStorage()`:\n\n```cpp\nvoid RFConfiguration::loadFromStorage() {\n#ifdef ESP32\n  StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n  preferences.begin(Gateway_Short_Name, true);\n  if (preferences.isKey(\"RFConfig\")) {\n    auto error = deserializeJson(jsonBuffer, preferences.getString(\"RFConfig\", \"{}\"));\n    preferences.end();\n    if (error) {\n      Log.error(F(\"RF Config deserialization failed: %s, buffer capacity: %u\" CR), error.c_str(), jsonBuffer.capacity());\n      return;\n    }\n    if (jsonBuffer.isNull()) {\n      Log.warning(F(\"RF Config is null\" CR));\n      return;\n    }\n    JsonObject jo = jsonBuffer.as<JsonObject>();\n    fromJson(jo);\n    Log.notice(F(\"RF Config loaded\" CR));\n    iRFReceiver.enable();  // \u2190 ADD THIS LINE (matches line 162 behavior)\n  } else {\n    preferences.end();\n    Log.notice(F(\"RF Config not found using default\" CR));\n    iRFReceiver.enable();  // \u2190 Already here for \"no config\" case\n  }\n#else\n  iRFReceiver.enable();\n#endif\n}\n```\n\nThis ensures both code paths (config exists vs. doesn't exist) behave identically: load config, then enable receiver.\n\n### Why WebUI Toggle Works\n\nThe WebUI workaround triggers `loadFromMessage()` which correctly calls:\n```cpp\niRFReceiver.disable();\niRFReceiver.enable();\n```\n\nThis properly initializes CC1101, explaining why the workaround succeeds.\n\n### Additional Notes\n\n- There's a `//TODO review` comment at `commonRF.cpp:63` before `initCC1101()`, suggesting this code area was flagged for review\n- The issue affects users who have saved their RF config to NVS (most users after first configuration)\n- First-time users or those without saved config don't see the issue\n- The bug also explains the \"Invalid pin selected\" errors on ESP32-S3 that resolved when explicit pins were defined\n\n### Summary\n\n**What changed**: PR #2245 introduced the `RFConfiguration` class with `loadFromStorage()` and `loadFromMessage()` methods. The `loadFromStorage()` method loads saved config but fails to call `iRFReceiver.enable()` when config exists.\n\n**Impact**: Users with saved RF configurations (most users after initial setup) experience CC1101 not initializing on boot. First-time users are unaffected because the \"no config\" path correctly calls `enable()`.\n\n**Fix**: Add `iRFReceiver.enable()` call after loading configuration in `loadFromStorage()` to match the behavior in both the \"no config\" branch and the `loadFromMessage()` method.\n\n---", "createdAt": "2026-01-05T13:12:03Z", "updatedAt": "2026-01-05T13:55:35Z", "author": {"login": "claude"}}, {"id": "IC_kwDOBBSfJs7dKH3g", "body": "@claude could you propose a PR to fix this", "createdAt": "2026-01-05T13:25:22Z", "updatedAt": "2026-01-05T13:25:22Z", "author": {"login": "1technophile"}}, {"id": "IC_kwDOBBSfJs7dKIFV", "body": "**Claude encountered an error** \u2014\u2014 [View job](https://github.com/1technophile/OpenMQTTGateway/actions/runs/20716816038)\n\n---\nI'll analyze this and get back to you.", "createdAt": "2026-01-05T13:25:38Z", "updatedAt": "2026-01-05T13:28:17Z", "author": {"login": "claude"}}, {"id": "IC_kwDOBBSfJs7dLKyz", "body": "@1technophile  Yes, it is the same solution I found, but it is missing one thing. It disables and enables the driver twice every time you save from the message. That\u2019s why I added that flag reinitReceiver to my diff. ", "createdAt": "2026-01-05T14:36:10Z", "updatedAt": "2026-01-05T14:36:10Z", "author": {"login": "Odyno"}}, {"id": "IC_kwDOBBSfJs7dPw5s", "body": "@1technophile & @Odyno but works fine for me \ud83d\udc4d ", "createdAt": "2026-01-05T19:58:59Z", "updatedAt": "2026-01-05T19:58:59Z", "author": {"login": "Dattel"}}, {"id": "IC_kwDOBBSfJs7dZNIY", "body": "@Odyno make sense, thanks for pointing this\n@claude create a PR with @Odyno solution and close the other one", "createdAt": "2026-01-06T11:34:17Z", "updatedAt": "2026-01-06T11:34:17Z", "author": {"login": "1technophile"}}, {"id": "IC_kwDOBBSfJs7dZNSD", "body": "**Claude finished @1technophile's task in 1m 43s** \u2014\u2014 [View job](https://github.com/1technophile/OpenMQTTGateway/actions/runs/20747071005) \u2022 [`claude/issue-2264-20260106-1134`](https://github.com/1technophile/OpenMQTTGateway/tree/claude/issue-2264-20260106-1134) \u2022 [Create PR \u2794](https://github.com/1technophile/OpenMQTTGateway/compare/development...claude/issue-2264-20260106-1134?quick_pull=1&title=Fix%20CC1101%20initialization%20on%20boot%20with%20saved%20RF%20config&body=%23%23%20Summary%0AFixes%20%232264%20-%20CC1101%20not%20initializing%20properly%20on%20boot%20when%20a%20saved%20RF%20configuration%20exists.%0A%0A%23%23%20Changes%0A-%20Added%20%60reinitReceiver%60%20parameter%20to%20%60loadFromStorage()%60%20(default%3A%20%60true%60)%0A-%20When%20true%2C%20disables%20and%20re-enables%20the%20receiver%20after%20loading%20config%0A-%20%60loadFromMessage()%60%20passes%20%60false%60%20to%20avoid%20double%20initialization%0A%0A%23%23%20Root%20Cause%0AWhen%20saved%20config%20existed%20in%20NVS%2C%20%60loadFromStorage()%60%20loaded%20config%20but%20never%20called%20%60iRFReceiver.enable()%60%2C%20so%20%60initCC1101()%60%20was%20never%20invoked.%0A%0ASolution%20by%20%40Odyno%0A%0A%F0%9F%A4%96%20Generated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode))\n\n---\n### CC1101 Initialization Fix Implemented\n\n#### Summary\nImplemented @Odyno's solution to fix the CC1101 initialization issue on boot when a saved RF configuration exists.\n\n#### Changes Made\n- Added `reinitReceiver` parameter to `loadFromStorage()` (default: `true`)\n- When `reinitReceiver` is true, the receiver is disabled then re-enabled after loading config\n- Updated `loadFromMessage()` to pass `false` to avoid double initialization\n- Moved the receiver enable logic outside the `#ifdef ESP32` block so it works on all platforms\n\n#### Root Cause\nWhen a saved configuration existed in NVS, `loadFromStorage()` was loading the config but never calling `iRFReceiver.enable()`, which meant `initCC1101()` was never invoked during boot. The WebUI toggle worked because `loadFromMessage()` explicitly calls `disable()/enable()`.\n\n#### Todo List\n- [x] Review @Odyno's proposed diff solution\n- [x] Read current `RFConfiguration.h` and `RFConfiguration.cpp` files\n- [x] Implement the `reinitReceiver` parameter changes\n- [x] Commit and push changes\n- [x] Create PR link\n- [x] Close the other PR (I cannot close PRs directly - please close it manually)\n\n\n\n---\n |", "createdAt": "2026-01-06T11:34:30Z", "updatedAt": "2026-01-06T11:48:08Z", "author": {"login": "claude"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 2269, "link_type": "closing_keyword", "will_close": true, "comment_count": 19, "issue_age_at_pr_days": 8.530104166666666, "issue_was_open_at_pr": false, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}], "has_inline_feedback": false, "feedback_track": "body_only", "changed_files": 2, "additions": 15, "deletions": 7, "author_association": "OWNER", "is_cross_repository": false, "files": [{"path": "main/rf/RFConfiguration.cpp", "additions": 11, "deletions": 6, "changeType": "MODIFIED", "base_content": "#include \"RFConfiguration.h\"\n\n#include <config_RF.h>\n\n#ifdef ZgatewayRTL_433\n#  include <rtl_433_ESP.h>\nextern rtl_433_ESP rtl_433;\n#endif\n\n// Constructor\nRFConfiguration::RFConfiguration(RFReceiver& receiver) : iRFReceiver(receiver) {\n  reInit();\n}\n\n// Destructor\nRFConfiguration::~RFConfiguration() {\n}\n\n// Getters and Setters\nfloat RFConfiguration::getFrequency() const {\n  return frequency;\n}\n\nvoid RFConfiguration::setFrequency(float freq) {\n  frequency = freq;\n}\n\nint RFConfiguration::getRssiThreshold() const {\n  return rssiThreshold;\n}\n\nvoid RFConfiguration::setRssiThreshold(int threshold) {\n  rssiThreshold = threshold;\n}\n\nint RFConfiguration::getNewOokThreshold() const {\n  return newOokThreshold;\n}\n\nvoid RFConfiguration::setNewOokThreshold(int threshold) {\n  newOokThreshold = threshold;\n}\n\nint RFConfiguration::getActiveReceiver() const {\n  return activeReceiver;\n}\n\nvoid RFConfiguration::setActiveReceiver(int receiver) {\n  activeReceiver = receiver;\n}\n\n/**\n * @brief Initializes the RFConfiguration  with default values.\n * \n * This function sets up the RFConfiguration by assigning default values \n * to its members, including frequency, active receiver, RSSI threshold, \n * and new OOK threshold. It also clears and shrinks the whiteList and \n * blackList containers to ensure they are empty and optimized for memory usage.\n * \n * @note This function should be called during the initialization phase \n *       to ensure the RFConfiguration is properly configured.\n */\nvoid RFConfiguration::reInit() {\n  frequency = RF_FREQUENCY;\n  activeReceiver = ACTIVE_RECEIVER;\n  rssiThreshold = 0;\n  newOokThreshold = 0;\n}\n\n/**\n * @brief Erases the RF configuration from non-volatile storage (NVS).\n *\n * This function removes the RF configuration stored in NVS. It checks if\n * the configuration exists and, if so, removes it. If the configuration\n * is not found, a notice is logged.\n *\n * @note This function is only available on ESP32 platforms.\n */\nvoid RFConfiguration::eraseStorage() {\n#ifdef ESP32\n  // Erase config from NVS (non-volatile storage)\n  preferences.begin(Gateway_Short_Name, false);\n  if (preferences.isKey(\"RFConfig\")) {\n    int result = preferences.remove(\"RFConfig\");\n    Log.notice(F(\"RF config erase result: %d\" CR), result);\n  } else {\n    Log.notice(F(\"RF config not found\" CR));\n  }\n  preferences.end();\n#else\n  Log.warning(F(\"RF Config Erase not support with this board\" CR));\n#endif\n}\n\n/**\n   * @brief Saves the RF configuration to non-volatile storage (NVS).\n   *\n   * This function serializes the RF configuration data into a JSON object\n   * and saves it to NVS. The saved configuration includes frequency, active\n   * receiver, and other relevant parameters.\n   *\n   * @note This function is only available on ESP32 platforms.\n   * @note Ensure that the `JSON_MSG_BUFFER` is large enough to hold the\n   *       serialized configuration data to avoid deserialization errors.\n   */\nvoid RFConfiguration::saveOnStorage() {\n#ifdef ESP32\n  StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n  JsonObject jo = jsonBuffer.to<JsonObject>();\n  toJson(jo);\n#  ifdef ZgatewayRTL_433\n  // FROM ORIGINAL CONFIGURATION:\n  // > Don't save those for now, need to be tested\n  jo.remove(\"rssithreshold\");\n  jo.remove(\"ookthreshold\");\n#  endif\n  // Save config into NVS (non-volatile storage)\n  String conf = \"\";\n  serializeJson(jsonBuffer, conf);\n  preferences.begin(Gateway_Short_Name, false);\n  int result = preferences.putString(\"RFConfig\", conf);\n  preferences.end();\n  Log.notice(F(\"RF Config_save: %s, result: %d\" CR), conf.c_str(), result);\n#else\n  Log.warning(F(\"RF Config_save not support with this board\" CR));\n#endif\n}\n\n/**\n * @brief Loads the RF configuration from persistent storage and applies it.\n *\n * This function retrieves the RF configuration stored in non-volatile\n * storage (NVS) and applies it to the RF receiver. If the configuration\n * is not found, a notice is logged, and the RF receiver is enabled with\n * default settings.\n *\n * @note This function has specific behavior for ESP32 platforms. On ESP32,\n *       it uses the Preferences library to access stored configuration data.\n *       For other platforms, it directly enables the active receiver.\n */\nvoid RFConfiguration::loadFromStorage() {\n#ifdef ESP32\n  StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n  preferences.begin(Gateway_Short_Name, true);\n  if (preferences.isKey(\"RFConfig\")) {\n    auto error = deserializeJson(jsonBuffer, preferences.getString(\"RFConfig\", \"{}\"));\n    preferences.end();\n    if (error) {\n      Log.error(F(\"RF Config deserialization failed: %s, buffer capacity: %u\" CR), error.c_str(), jsonBuffer.capacity());\n      return;\n    }\n    if (jsonBuffer.isNull()) {\n      Log.warning(F(\"RF Config is null\" CR));\n      return;\n    }\n    JsonObject jo = jsonBuffer.as<JsonObject>();\n    fromJson(jo);\n    Log.notice(F(\"RF Config loaded\" CR));\n  } else {\n    preferences.end();\n    Log.notice(F(\"RF Config not found using default\" CR));\n    iRFReceiver.enable();\n  }\n#else\n  iRFReceiver.enable();\n#endif\n}\n\n/**\n * @brief Loads the RF configuration from a JSON object and applies it.\n *\n * This function takes a JSON object containing RF configuration data and\n * applies it to the RF receiver. It also handles the erasure and saving of\n * the configuration based on the provided JSON data.\n * \n * Configuration modifications priorities:\n * - First `init=true` and `load=true` commands are executed (if both are present, INIT prevails on LOAD)\n * - Then parameters included in json are taken in account\n * - Finally `erase=true` and `save=true` commands are executed (if both are present, ERASE prevails on SAVE)* \n *\n * @param RFdata A reference to a JsonObject containing the RF configuration data.\n *\n * The following keys are supported in the JSON object:\n * - \"init\": If true, restores the default RF configuration.\n * - \"load\": If true, loads the saved RF configuration from storage.\n * - \"erase\": If true, erases the RF configuration from storage.\n * - \"save\": If true, saves the current RF configuration to storage.\n *\n * Logs messages to indicate the success or failure of each operation.\n */\nvoid RFConfiguration::loadFromMessage(JsonObject& RFdata) {\n  if (RFdata.containsKey(\"init\") && RFdata[\"init\"].as<bool>()) {\n    // Restore the default (initial) configuration\n    reInit();\n  } else if (RFdata.containsKey(\"load\") && RFdata[\"load\"].as<bool>()) {\n    // Load the saved configuration, if not initialised\n    loadFromStorage();\n  }\n\n  fromJson(RFdata);\n\n  iRFReceiver.disable();\n  iRFReceiver.enable();\n\n  if (RFdata.containsKey(\"erase\") && RFdata[\"erase\"].as<bool>()) {\n    eraseStorage();\n    Log.notice(F(\"RF Config erased\" CR));\n  } else if (RFdata.containsKey(\"save\") && RFdata[\"save\"].as<bool>()) {\n    saveOnStorage();\n    Log.notice(F(\"RF Config saved\" CR));\n  }\n}\n\n/**\n * @brief Updates the RF configuration from a JSON object.\n *\n * This function parses the provided JSON object and updates the RF configuration\n * based on the keys and values present in the object. It supports updating\n * white-list, black-list, frequency, active receiver status, and other RF-related\n * parameters depending on the defined preprocessor directives.\n *\n * @param RFdata A reference to a JsonObject containing the RF configuration data.\n *\n * The following keys are supported in the JSON object:\n * - \"white-list\": Updates the RF white-list.\n * - \"black-list\": Updates the RF black-list.\n * - \"frequency\": Updates the RF frequency if the value is valid.\n * - \"active\": Updates the active receiver status.\n *\n * Additional keys supported when ZgatewayRTL_433 is defined:\n * - \"rssithreshold\": Updates the RSSI threshold for RTL_433.\n * - \"ookthreshold\": Updates the OOK threshold for RTL_433 (requires RF_SX1276 or RF_SX1278).\n * - \"status\": Retrieves the current status of the RF configuration.\n *\n * Logs messages to indicate the success or failure of each update operation.\n * If no valid keys are found in the JSON object, an error message is logged.\n */\nvoid RFConfiguration::fromJson(JsonObject& RFdata) {\n  bool success = false;\n\n  if (RFdata.containsKey(\"frequency\") && validFrequency(RFdata[\"frequency\"])) {\n    Config_update(RFdata, \"frequency\", frequency);\n    Log.notice(F(\"RF Receive mhz: %F\" CR), frequency);\n    success = true;\n  }\n  if (RFdata.containsKey(\"active\")) {\n    Config_update(RFdata, \"active\", activeReceiver);\n    Log.notice(F(\"RF receiver active: %d\" CR), activeReceiver);\n    success = true;\n  }\n#ifdef ZgatewayRTL_433\n  if (RFdata.containsKey(\"rssithreshold\")) {\n    Log.notice(F(\"RTL_433 RSSI Threshold : %d \" CR), rssiThreshold);\n    Config_update(RFdata, \"rssithreshold\", rssiThreshold);\n    rtl_433.setRSSIThreshold(rssiThreshold);\n    success = true;\n  }\n#  if defined(RF_SX1276) || defined(RF_SX1278)\n  if (RFdata.containsKey(\"ookthreshold\")) {\n    Config_update(RFdata, \"ookthreshold\", newOokThreshold);\n    Log.notice(F(\"RTL_433 ookThreshold %d\" CR), newOokThreshold);\n    rtl_433.setOOKThreshold(newOokThreshold);\n    success = true;\n  }\n#  endif\n  if (RFdata.containsKey(\"status\")) {\n    Log.notice(F(\"RF get status:\" CR));\n    rtl_433.getStatus();\n    success = true;\n  }\n  if (!success) {\n    Log.error(F(\"MQTTtoRF Fail json\" CR));\n  }\n#endif\n}\n\n/**\n * @brief Serializes the RFConfiguration object into a JSON object.\n * \n * This method populates the provided JSON object with the configuration\n * details of the RF module, including frequency, RSSI threshold, OOK threshold,\n * active receiver status, and ignore list settings. Additionally, it includes\n * the white-list and black-list vectors as nested JSON arrays.\n * \n * @param RFdata A reference to a JsonObject where the RF configuration data \n *               will be serialized.\n * \n * JSON Structure:\n * {\n *   \"frequency\": <float>,          // Frequency value\n *   \"rssithreshold\": <float>,      // RSSI threshold value\n *   \"ookthreshold\": <float>,       // OOK threshold value\n *   \"active\": <bool>,              // Active receiver status\n *   \"ignoreWhitelist\": <bool>,     // Ignore white-list flag\n *   \"ignoreBlacklist\": <bool>,     // Ignore black-list flag\n *   \"white-list\": [<int>, ...],    // Array of white-list values\n *   \"black-list\": [<int>, ...]     // Array of black-list values\n * }\n */\nvoid RFConfiguration::toJson(JsonObject& RFdata) {\n  RFdata[\"frequency\"] = frequency;\n  RFdata[\"rssithreshold\"] = rssiThreshold;\n  RFdata[\"ookthreshold\"] = newOokThreshold;\n  RFdata[\"active\"] = activeReceiver;\n\n  // Add white-list vector to the JSON object\n  JsonArray whiteListArray = RFdata.createNestedArray(\"white-list\");\n  // Add black-list vector to the JSON object\n  JsonArray blackListArray = RFdata.createNestedArray(\"black-list\");\n}\n\n/**\n * @brief Validates if the given frequency is within the acceptable ranges for the CC1101 module.\n *\n * The CC1101 module supports the following frequency ranges:\n * - 300 MHz to 348 MHz\n * - 387 MHz to 464 MHz\n * - 779 MHz to 928 MHz\n *\n * @param mhz The frequency in MHz to validate.\n * @return true if the frequency is within one of the valid ranges, false otherwise.\n */\nbool RFConfiguration::validFrequency(float mhz) {\n  //  CC1101 valid frequencies 300-348 MHZ, 387-464MHZ and 779-928MHZ.\n  if (mhz >= 300 && mhz <= 348)\n    return true;\n  if (mhz >= 387 && mhz <= 464)\n    return true;\n  if (mhz >= 779 && mhz <= 928)\n    return true;\n  return false;\n}\n", "head_content": "#include \"RFConfiguration.h\"\n\n#include <config_RF.h>\n\n#ifdef ZgatewayRTL_433\n#  include <rtl_433_ESP.h>\nextern rtl_433_ESP rtl_433;\n#endif\n\n// Constructor\nRFConfiguration::RFConfiguration(RFReceiver& receiver) : iRFReceiver(receiver) {\n  reInit();\n}\n\n// Destructor\nRFConfiguration::~RFConfiguration() {\n}\n\n// Getters and Setters\nfloat RFConfiguration::getFrequency() const {\n  return frequency;\n}\n\nvoid RFConfiguration::setFrequency(float freq) {\n  frequency = freq;\n}\n\nint RFConfiguration::getRssiThreshold() const {\n  return rssiThreshold;\n}\n\nvoid RFConfiguration::setRssiThreshold(int threshold) {\n  rssiThreshold = threshold;\n}\n\nint RFConfiguration::getNewOokThreshold() const {\n  return newOokThreshold;\n}\n\nvoid RFConfiguration::setNewOokThreshold(int threshold) {\n  newOokThreshold = threshold;\n}\n\nint RFConfiguration::getActiveReceiver() const {\n  return activeReceiver;\n}\n\nvoid RFConfiguration::setActiveReceiver(int receiver) {\n  activeReceiver = receiver;\n}\n\n/**\n * @brief Initializes the RFConfiguration  with default values.\n * \n * This function sets up the RFConfiguration by assigning default values \n * to its members, including frequency, active receiver, RSSI threshold, \n * and new OOK threshold. It also clears and shrinks the whiteList and \n * blackList containers to ensure they are empty and optimized for memory usage.\n * \n * @note This function should be called during the initialization phase \n *       to ensure the RFConfiguration is properly configured.\n */\nvoid RFConfiguration::reInit() {\n  frequency = RF_FREQUENCY;\n  activeReceiver = ACTIVE_RECEIVER;\n  rssiThreshold = 0;\n  newOokThreshold = 0;\n}\n\n/**\n * @brief Erases the RF configuration from non-volatile storage (NVS).\n *\n * This function removes the RF configuration stored in NVS. It checks if\n * the configuration exists and, if so, removes it. If the configuration\n * is not found, a notice is logged.\n *\n * @note This function is only available on ESP32 platforms.\n */\nvoid RFConfiguration::eraseStorage() {\n#ifdef ESP32\n  // Erase config from NVS (non-volatile storage)\n  preferences.begin(Gateway_Short_Name, false);\n  if (preferences.isKey(\"RFConfig\")) {\n    int result = preferences.remove(\"RFConfig\");\n    Log.notice(F(\"RF config erase result: %d\" CR), result);\n  } else {\n    Log.notice(F(\"RF config not found\" CR));\n  }\n  preferences.end();\n#else\n  Log.warning(F(\"RF Config Erase not support with this board\" CR));\n#endif\n}\n\n/**\n   * @brief Saves the RF configuration to non-volatile storage (NVS).\n   *\n   * This function serializes the RF configuration data into a JSON object\n   * and saves it to NVS. The saved configuration includes frequency, active\n   * receiver, and other relevant parameters.\n   *\n   * @note This function is only available on ESP32 platforms.\n   * @note Ensure that the `JSON_MSG_BUFFER` is large enough to hold the\n   *       serialized configuration data to avoid deserialization errors.\n   */\nvoid RFConfiguration::saveOnStorage() {\n#ifdef ESP32\n  StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n  JsonObject jo = jsonBuffer.to<JsonObject>();\n  toJson(jo);\n#  ifdef ZgatewayRTL_433\n  // FROM ORIGINAL CONFIGURATION:\n  // > Don't save those for now, need to be tested\n  jo.remove(\"rssithreshold\");\n  jo.remove(\"ookthreshold\");\n#  endif\n  // Save config into NVS (non-volatile storage)\n  String conf = \"\";\n  serializeJson(jsonBuffer, conf);\n  preferences.begin(Gateway_Short_Name, false);\n  int result = preferences.putString(\"RFConfig\", conf);\n  preferences.end();\n  Log.notice(F(\"RF Config_save: %s, result: %d\" CR), conf.c_str(), result);\n#else\n  Log.warning(F(\"RF Config_save not support with this board\" CR));\n#endif\n}\n\n/**\n * @brief Loads the RF configuration from persistent storage and applies it.\n *\n * This function retrieves the RF configuration stored in non-volatile\n * storage (NVS) and applies it to the RF receiver. If the configuration\n * is not found, a notice is logged, and the RF receiver is enabled with\n * default settings.\n *\n * @param reinitReceiver If true (default), disables and re-enables the receiver.\n *                       If false, only loads the configuration without reinitialization.\n *\n * @note This function has specific behavior for ESP32 platforms. On ESP32,\n *       it uses the Preferences library to access stored configuration data.\n *       For other platforms, it directly enables the active receiver.\n */\nvoid RFConfiguration::loadFromStorage(bool reinitReceiver) {\n#ifdef ESP32\n  StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n  preferences.begin(Gateway_Short_Name, true);\n  if (preferences.isKey(\"RFConfig\")) {\n    auto error = deserializeJson(jsonBuffer, preferences.getString(\"RFConfig\", \"{}\"));\n    preferences.end();\n    if (error) {\n      Log.error(F(\"RF Config deserialization failed: %s, buffer capacity: %u\" CR), error.c_str(), jsonBuffer.capacity());\n      return;\n    }\n    if (jsonBuffer.isNull()) {\n      Log.warning(F(\"RF Config is null\" CR));\n      return;\n    }\n    JsonObject jo = jsonBuffer.as<JsonObject>();\n    fromJson(jo);\n    Log.notice(F(\"RF Config loaded\" CR));\n  } else {\n    preferences.end();\n    Log.notice(F(\"RF Config not found using default\" CR));\n  }\n#endif\n  // Disable and re-enable the receiver to ensure proper initialization\n  if (reinitReceiver) {\n    iRFReceiver.disable();\n    iRFReceiver.enable();\n  }\n}\n\n/**\n * @brief Loads the RF configuration from a JSON object and applies it.\n *\n * This function takes a JSON object containing RF configuration data and\n * applies it to the RF receiver. It also handles the erasure and saving of\n * the configuration based on the provided JSON data.\n * \n * Configuration modifications priorities:\n * - First `init=true` and `load=true` commands are executed (if both are present, INIT prevails on LOAD)\n * - Then parameters included in json are taken in account\n * - Finally `erase=true` and `save=true` commands are executed (if both are present, ERASE prevails on SAVE)* \n *\n * @param RFdata A reference to a JsonObject containing the RF configuration data.\n *\n * The following keys are supported in the JSON object:\n * - \"init\": If true, restores the default RF configuration.\n * - \"load\": If true, loads the saved RF configuration from storage.\n * - \"erase\": If true, erases the RF configuration from storage.\n * - \"save\": If true, saves the current RF configuration to storage.\n *\n * Logs messages to indicate the success or failure of each operation.\n */\nvoid RFConfiguration::loadFromMessage(JsonObject& RFdata) {\n  if (RFdata.containsKey(\"init\") && RFdata[\"init\"].as<bool>()) {\n    // Restore the default (initial) configuration\n    reInit();\n  } else if (RFdata.containsKey(\"load\") && RFdata[\"load\"].as<bool>()) {\n    // Load the saved configuration from storage (without receiver reinitialization)\n    loadFromStorage(false);\n  }\n\n  fromJson(RFdata);\n\n  iRFReceiver.disable();\n  iRFReceiver.enable();\n\n  if (RFdata.containsKey(\"erase\") && RFdata[\"erase\"].as<bool>()) {\n    eraseStorage();\n    Log.notice(F(\"RF Config erased\" CR));\n  } else if (RFdata.containsKey(\"save\") && RFdata[\"save\"].as<bool>()) {\n    saveOnStorage();\n    Log.notice(F(\"RF Config saved\" CR));\n  }\n}\n\n/**\n * @brief Updates the RF configuration from a JSON object.\n *\n * This function parses the provided JSON object and updates the RF configuration\n * based on the keys and values present in the object. It supports updating\n * white-list, black-list, frequency, active receiver status, and other RF-related\n * parameters depending on the defined preprocessor directives.\n *\n * @param RFdata A reference to a JsonObject containing the RF configuration data.\n *\n * The following keys are supported in the JSON object:\n * - \"white-list\": Updates the RF white-list.\n * - \"black-list\": Updates the RF black-list.\n * - \"frequency\": Updates the RF frequency if the value is valid.\n * - \"active\": Updates the active receiver status.\n *\n * Additional keys supported when ZgatewayRTL_433 is defined:\n * - \"rssithreshold\": Updates the RSSI threshold for RTL_433.\n * - \"ookthreshold\": Updates the OOK threshold for RTL_433 (requires RF_SX1276 or RF_SX1278).\n * - \"status\": Retrieves the current status of the RF configuration.\n *\n * Logs messages to indicate the success or failure of each update operation.\n * If no valid keys are found in the JSON object, an error message is logged.\n */\nvoid RFConfiguration::fromJson(JsonObject& RFdata) {\n  bool success = false;\n\n  if (RFdata.containsKey(\"frequency\") && validFrequency(RFdata[\"frequency\"])) {\n    Config_update(RFdata, \"frequency\", frequency);\n    Log.notice(F(\"RF Receive mhz: %F\" CR), frequency);\n    success = true;\n  }\n  if (RFdata.containsKey(\"active\")) {\n    Config_update(RFdata, \"active\", activeReceiver);\n    Log.notice(F(\"RF receiver active: %d\" CR), activeReceiver);\n    success = true;\n  }\n#ifdef ZgatewayRTL_433\n  if (RFdata.containsKey(\"rssithreshold\")) {\n    Log.notice(F(\"RTL_433 RSSI Threshold : %d \" CR), rssiThreshold);\n    Config_update(RFdata, \"rssithreshold\", rssiThreshold);\n    rtl_433.setRSSIThreshold(rssiThreshold);\n    success = true;\n  }\n#  if defined(RF_SX1276) || defined(RF_SX1278)\n  if (RFdata.containsKey(\"ookthreshold\")) {\n    Config_update(RFdata, \"ookthreshold\", newOokThreshold);\n    Log.notice(F(\"RTL_433 ookThreshold %d\" CR), newOokThreshold);\n    rtl_433.setOOKThreshold(newOokThreshold);\n    success = true;\n  }\n#  endif\n  if (RFdata.containsKey(\"status\")) {\n    Log.notice(F(\"RF get status:\" CR));\n    rtl_433.getStatus();\n    success = true;\n  }\n  if (!success) {\n    Log.error(F(\"MQTTtoRF Fail json\" CR));\n  }\n#endif\n}\n\n/**\n * @brief Serializes the RFConfiguration object into a JSON object.\n * \n * This method populates the provided JSON object with the configuration\n * details of the RF module, including frequency, RSSI threshold, OOK threshold,\n * active receiver status, and ignore list settings. Additionally, it includes\n * the white-list and black-list vectors as nested JSON arrays.\n * \n * @param RFdata A reference to a JsonObject where the RF configuration data \n *               will be serialized.\n * \n * JSON Structure:\n * {\n *   \"frequency\": <float>,          // Frequency value\n *   \"rssithreshold\": <float>,      // RSSI threshold value\n *   \"ookthreshold\": <float>,       // OOK threshold value\n *   \"active\": <bool>,              // Active receiver status\n *   \"ignoreWhitelist\": <bool>,     // Ignore white-list flag\n *   \"ignoreBlacklist\": <bool>,     // Ignore black-list flag\n *   \"white-list\": [<int>, ...],    // Array of white-list values\n *   \"black-list\": [<int>, ...]     // Array of black-list values\n * }\n */\nvoid RFConfiguration::toJson(JsonObject& RFdata) {\n  RFdata[\"frequency\"] = frequency;\n  RFdata[\"rssithreshold\"] = rssiThreshold;\n  RFdata[\"ookthreshold\"] = newOokThreshold;\n  RFdata[\"active\"] = activeReceiver;\n\n  // Add white-list vector to the JSON object\n  JsonArray whiteListArray = RFdata.createNestedArray(\"white-list\");\n  // Add black-list vector to the JSON object\n  JsonArray blackListArray = RFdata.createNestedArray(\"black-list\");\n}\n\n/**\n * @brief Validates if the given frequency is within the acceptable ranges for the CC1101 module.\n *\n * The CC1101 module supports the following frequency ranges:\n * - 300 MHz to 348 MHz\n * - 387 MHz to 464 MHz\n * - 779 MHz to 928 MHz\n *\n * @param mhz The frequency in MHz to validate.\n * @return true if the frequency is within one of the valid ranges, false otherwise.\n */\nbool RFConfiguration::validFrequency(float mhz) {\n  //  CC1101 valid frequencies 300-348 MHZ, 387-464MHZ and 779-928MHZ.\n  if (mhz >= 300 && mhz <= 348)\n    return true;\n  if (mhz >= 387 && mhz <= 464)\n    return true;\n  if (mhz >= 779 && mhz <= 928)\n    return true;\n  return false;\n}\n", "patch": "--- a/main/rf/RFConfiguration.cpp\n+++ b/main/rf/RFConfiguration.cpp\n@@ -134,11 +134,14 @@\n  * is not found, a notice is logged, and the RF receiver is enabled with\n  * default settings.\n  *\n+ * @param reinitReceiver If true (default), disables and re-enables the receiver.\n+ *                       If false, only loads the configuration without reinitialization.\n+ *\n  * @note This function has specific behavior for ESP32 platforms. On ESP32,\n  *       it uses the Preferences library to access stored configuration data.\n  *       For other platforms, it directly enables the active receiver.\n  */\n-void RFConfiguration::loadFromStorage() {\n+void RFConfiguration::loadFromStorage(bool reinitReceiver) {\n #ifdef ESP32\n   StaticJsonDocument<JSON_MSG_BUFFER> jsonBuffer;\n   preferences.begin(Gateway_Short_Name, true);\n@@ -159,11 +162,13 @@\n   } else {\n     preferences.end();\n     Log.notice(F(\"RF Config not found using default\" CR));\n+  }\n+#endif\n+  // Disable and re-enable the receiver to ensure proper initialization\n+  if (reinitReceiver) {\n+    iRFReceiver.disable();\n     iRFReceiver.enable();\n   }\n-#else\n-  iRFReceiver.enable();\n-#endif\n }\n \n /**\n@@ -193,8 +198,8 @@\n     // Restore the default (initial) configuration\n     reInit();\n   } else if (RFdata.containsKey(\"load\") && RFdata[\"load\"].as<bool>()) {\n-    // Load the saved configuration, if not initialised\n-    loadFromStorage();\n+    // Load the saved configuration from storage (without receiver reinitialization)\n+    loadFromStorage(false);\n   }\n \n   fromJson(RFdata);\n"}, {"path": "main/rf/RFConfiguration.h", "additions": 4, "deletions": 1, "changeType": "MODIFIED", "base_content": "#ifndef RFCONFIG_H\n#define RFCONFIG_H\n#pragma once\n\n#include <TheengsCommon.h>\n#include <rf/RFReceiver.h>\n\nclass RFConfiguration {\npublic:\n  // Constructor\n  RFConfiguration(RFReceiver& receiver);\n  ~RFConfiguration();\n\n  // Getters and Setters\n  float getFrequency() const;\n  void setFrequency(float freq);\n\n  int getRssiThreshold() const;\n  void setRssiThreshold(int threshold);\n\n  int getNewOokThreshold() const;\n  void setNewOokThreshold(int threshold);\n\n  int getActiveReceiver() const;\n  void setActiveReceiver(int receiver);\n\n  /**\n   * Initializes the  structure with default values.\n   * \n   * @note This function should be called during the initialization phase \n   *       to ensure the  structure is properly configured.\n   */\n  void reInit();\n\n  /**\n   * Erases the RF configuration from non-volatile storage (NVS).\n   * \n   * @note This function is only available on ESP32 platforms.\n   */\n  void eraseStorage();\n\n  /**\n   * Saves the RF configuration to non-volatile storage (NVS).\n   *\n   * @note This function is only available on ESP32 platforms.\n   */\n  void saveOnStorage();\n\n  /**\n   * Loads the RF configuration from persistent storage and applies it.\n   *\n   * @note This function has specific behavior for ESP32 platforms. On ESP32,\n   *       it uses the Preferences library to access stored configuration data.\n   *       For other platforms, it directly enables the active receiver.\n   */\n  void loadFromStorage();\n\n  /**\n   * Loads the RF configuration from a JSON object and applies it.\n   *\n   * @param RFdata A reference to a JsonObject containing the RF configuration data.\n   *\n   * The following keys are supported in the JSON object:\n   * - \"erase\": If true, erases the RF configuration from storage.\n   * - \"save\": If true, saves the current RF configuration to storage.\n   *\n   * Logs messages to indicate the success or failure of each operation.\n   */\n  void loadFromMessage(JsonObject& RFdata);\n\n  /**\n   * Updates the RF configuration from a JSON object.\n   *\n   * @param RFdata A reference to a JsonObject containing the RF configuration data.\n   *\n   * The following keys are supported in the JSON object:\n   * - \"white-list\": Updates the RF white-list.\n   * - \"black-list\": Updates the RF black-list.\n   * - \"frequency\": Updates the RF frequency if the value is valid.\n   * - \"active\": Updates the active receiver status.\n   *\n   * Additional keys supported when ZgatewayRTL_433 is defined:\n   * - \"rssithreshold\": Updates the RSSI threshold for RTL_433.\n   * - \"ookthreshold\": Updates the OOK threshold for RTL_433 (requires RF_SX1276 or RF_SX1278).\n   * - \"status\": Retrieves the current status of the RF configuration.\n   */\n  void fromJson(JsonObject& RFdata);\n\n  /**\n   * Serializes the RF configuration to a JSON object.\n   *\n   * @param RFdata A reference to a JsonObject where the RF configuration will be serialized.\n   */\n  void toJson(JsonObject& RFdata);\n\n  /**\n   * @brief Validates if the given frequency is within the acceptable ranges for the CC1101 module.\n   *\n   * The CC1101 module supports the following frequency ranges:\n   * - 300 MHz to 348 MHz\n   * - 387 MHz to 464 MHz\n   * - 779 MHz to 928 MHz\n   *\n   * @param mhz The frequency in MHz to validate.\n   * @return true if the frequency is within one of the valid ranges, false otherwise.\n   */\n  bool validFrequency(float mhz);\n\nprivate:\n  // Reference to the RFReceiver object\n  RFReceiver& iRFReceiver;\n  float frequency;\n  int rssiThreshold;\n  int newOokThreshold;\n  int activeReceiver;\n};\n\n#endif // RFCONFIG_H", "head_content": "#ifndef RFCONFIG_H\n#define RFCONFIG_H\n#pragma once\n\n#include <TheengsCommon.h>\n#include <rf/RFReceiver.h>\n\nclass RFConfiguration {\npublic:\n  // Constructor\n  RFConfiguration(RFReceiver& receiver);\n  ~RFConfiguration();\n\n  // Getters and Setters\n  float getFrequency() const;\n  void setFrequency(float freq);\n\n  int getRssiThreshold() const;\n  void setRssiThreshold(int threshold);\n\n  int getNewOokThreshold() const;\n  void setNewOokThreshold(int threshold);\n\n  int getActiveReceiver() const;\n  void setActiveReceiver(int receiver);\n\n  /**\n   * Initializes the  structure with default values.\n   * \n   * @note This function should be called during the initialization phase \n   *       to ensure the  structure is properly configured.\n   */\n  void reInit();\n\n  /**\n   * Erases the RF configuration from non-volatile storage (NVS).\n   * \n   * @note This function is only available on ESP32 platforms.\n   */\n  void eraseStorage();\n\n  /**\n   * Saves the RF configuration to non-volatile storage (NVS).\n   *\n   * @note This function is only available on ESP32 platforms.\n   */\n  void saveOnStorage();\n\n  /**\n   * Loads the RF configuration from persistent storage and applies it.\n   *\n   * @param reinitReceiver If true (default), disables and re-enables the receiver.\n   *                       If false, only loads the configuration without reinitialization.\n   *\n   * @note This function has specific behavior for ESP32 platforms. On ESP32,\n   *       it uses the Preferences library to access stored configuration data.\n   *       For other platforms, it directly enables the active receiver.\n   */\n  void loadFromStorage(bool reinitReceiver = true);\n\n  /**\n   * Loads the RF configuration from a JSON object and applies it.\n   *\n   * @param RFdata A reference to a JsonObject containing the RF configuration data.\n   *\n   * The following keys are supported in the JSON object:\n   * - \"erase\": If true, erases the RF configuration from storage.\n   * - \"save\": If true, saves the current RF configuration to storage.\n   *\n   * Logs messages to indicate the success or failure of each operation.\n   */\n  void loadFromMessage(JsonObject& RFdata);\n\n  /**\n   * Updates the RF configuration from a JSON object.\n   *\n   * @param RFdata A reference to a JsonObject containing the RF configuration data.\n   *\n   * The following keys are supported in the JSON object:\n   * - \"white-list\": Updates the RF white-list.\n   * - \"black-list\": Updates the RF black-list.\n   * - \"frequency\": Updates the RF frequency if the value is valid.\n   * - \"active\": Updates the active receiver status.\n   *\n   * Additional keys supported when ZgatewayRTL_433 is defined:\n   * - \"rssithreshold\": Updates the RSSI threshold for RTL_433.\n   * - \"ookthreshold\": Updates the OOK threshold for RTL_433 (requires RF_SX1276 or RF_SX1278).\n   * - \"status\": Retrieves the current status of the RF configuration.\n   */\n  void fromJson(JsonObject& RFdata);\n\n  /**\n   * Serializes the RF configuration to a JSON object.\n   *\n   * @param RFdata A reference to a JsonObject where the RF configuration will be serialized.\n   */\n  void toJson(JsonObject& RFdata);\n\n  /**\n   * @brief Validates if the given frequency is within the acceptable ranges for the CC1101 module.\n   *\n   * The CC1101 module supports the following frequency ranges:\n   * - 300 MHz to 348 MHz\n   * - 387 MHz to 464 MHz\n   * - 779 MHz to 928 MHz\n   *\n   * @param mhz The frequency in MHz to validate.\n   * @return true if the frequency is within one of the valid ranges, false otherwise.\n   */\n  bool validFrequency(float mhz);\n\nprivate:\n  // Reference to the RFReceiver object\n  RFReceiver& iRFReceiver;\n  float frequency;\n  int rssiThreshold;\n  int newOokThreshold;\n  int activeReceiver;\n};\n\n#endif // RFCONFIG_H", "patch": "--- a/main/rf/RFConfiguration.h\n+++ b/main/rf/RFConfiguration.h\n@@ -49,11 +49,14 @@\n   /**\n    * Loads the RF configuration from persistent storage and applies it.\n    *\n+   * @param reinitReceiver If true (default), disables and re-enables the receiver.\n+   *                       If false, only loads the configuration without reinitialization.\n+   *\n    * @note This function has specific behavior for ESP32 platforms. On ESP32,\n    *       it uses the Preferences library to access stored configuration data.\n    *       For other platforms, it directly enables the active receiver.\n    */\n-  void loadFromStorage();\n+  void loadFromStorage(bool reinitReceiver = true);\n \n   /**\n    * Loads the RF configuration from a JSON object and applies it.\n"}], "agent_initiated": false, "agent_signals": null, "author_type": "agent", "reviewer_types": [], "interaction_type": "human_agent", "takeover_events": [], "first_human_takeover_ts": null, "merged_with_unresolved": false, "candidate_issues": [], "link_confidence": "explicit", "thread_chains": [], "author_self_reviewed": false, "fully_agent_authored": true, "requested_reviewers": [], "review_request_removed": [], "reviewer_was_requested": false, "merged_by": "1technophile", "merge_commit_oid": "e01b22695a814aaa06c8b6618ff69a4056655682", "merged_by_is_author": true, "maintainer_override": false, "referenced_file_contents": {}, "repo_is_fork": null, "repo_parent": null, "repo_collaborator_count": null, "hours_to_first_review": null, "median_response_latency_hours": null, "reviewer_count": 0, "merged_by_association": null, "n_commits": 1, "n_human_commits": 0, "n_agent_commits": 0, "n_bot_commits": 1, "agent_commit_ratio": 0.0, "repo_metadata": {"full_name": "1technophile/OpenMQTTGateway", "owner": "1technophile", "name": "OpenMQTTGateway", "stars": 3977, "language": "C++", "license": "gpl-3.0", "topics": ["mqtt", "gateway", "openhab2", "home-automation", "home-assistant", "wemos-d1", "rcswitch", "arduino", "bridge", "nodemcu"], "description": "MQTT gateway for ESP8266 or ESP32 with bidirectional 433mhz/315mhz/868mhz, Infrared communications, BLE, Bluetooth, beacons detection, mi flora, mi jia, LYWSD02, LYWSD03MMC, Mi Scale, TPMS, BBQ thermometer compatibility & LoRa.", "url": "https://github.com/1technophile/OpenMQTTGateway", "default_branch": "development", "open_issues": 49, "forks": 859, "discovered_via": "license:gpl-3.0 language:C++ stars:1001..5000 created:2008-01-01..2026-02-01 archived:false", "created_at": "2016-09-17T15:25:25Z", "pr_total_count": 1342, "issue_total_count": 956, "primary_language": "C++", "language_bytes": {"C++": 825270, "C": 149364, "Shell": 79147, "JavaScript": 25207, "Python": 2941, "Smarty": 257}}, "conversation_comments": [{"id": "rest_3714413081", "body": "## PR Review: [RF] Fix CC1101 initialization on boot with saved RF config\n\n### Summary\nThis PR fixes issue #2264 where the CC1101 RF module wasn't properly initialized on boot when a saved RF configuration existed in NVS. The root cause was that `loadFromStorage()` loaded the config but never called `iRFReceiver.enable()` to initialize the hardware.\n\n### Code Quality \u2705\n\n**Good aspects:**\n- Clean solution with minimal changes (15 additions, 7 deletions)\n- Well-documented parameter with clear docstring updates in both `.cpp` and `.h` files\n- Uses a sensible default (`reinitReceiver = true`) that ensures backwards compatibility\n- The fix correctly addresses the root cause identified in the issue\n\n**Design choice:**\nThe approach of adding a `reinitReceiver` parameter with a default of `true` is appropriate. This ensures:\n1. Boot-time initialization (`setupCommonRF()` at `main/commonRF.cpp:92`) gets proper hardware initialization\n2. MQTT message handling (`loadFromMessage()`) avoids double initialization since it already calls `disable()`/`enable()` after `fromJson()`\n\n### Correctness Analysis \u2705\n\nThe logic is sound:\n\n1. **Boot path** (`setupCommonRF` \u2192 `loadFromStorage()`): \n   - `reinitReceiver` defaults to `true`\n   - Receiver is disabled then enabled, triggering `initCC1101()`\n\n2. **MQTT message path** (`loadFromMessage` \u2192 `loadFromStorage(false)`):\n   - Passes `false` to avoid double initialization\n   - `loadFromMessage()` already calls `disable()`/`enable()` at lines 207-208\n\n3. **Non-ESP32 platforms**: The receiver initialization now happens unconditionally (outside the `#ifdef ESP32` block), which is actually an improvement - previously non-ESP32 platforms only called `enable()` but never `disable()` first, and now they consistently get the disable/enable cycle when `reinitReceiver` is true.\n\n### Potential Concerns \u26a0\ufe0f\n\n1. **Early return paths in ESP32 block**: When deserialization fails (line 153) or config is null (line 157), the function returns early *before* the `reinitReceiver` block. This means if there's a corrupted config in NVS, the receiver won't be initialized at boot. \n\n   **Suggestion**: Consider whether the receiver should still be initialized in these error cases:\n   ```cpp\n   if (error) {\n     Log.error(F(\"RF Config deserialization failed: %s, buffer capacity: %u\" CR), error.c_str(), jsonBuffer.capacity());\n     // Still initialize receiver with defaults on error?\n     if (reinitReceiver) {\n       iRFReceiver.disable();\n       iRFReceiver.enable();\n     }\n     return;\n   }\n   ```\n\n2. **Order of operations**: Calling `disable()` before `enable()` is good practice for ensuring clean state. The current implementation correctly does this.\n\n### Performance \u2705\nNo performance concerns - the disable/enable cycle only happens once at boot or on explicit config reload.\n\n### Security \u2705\nNo security implications in this change.\n\n### Test Coverage \ud83d\udcdd\nThe PR description mentions the fix was validated against the specific scenario in #2264 (boot with saved config). Manual testing appears to have confirmed the CC1101 now receives signals after boot without requiring WebUI toggle.\n\n**Recommendation**: If the project has unit tests for `RFConfiguration`, consider adding test cases for:\n- `loadFromStorage(true)` - verify receiver is re-initialized\n- `loadFromStorage(false)` - verify receiver is not touched\n- Error paths (deserialization failure, null config)\n\n### Overall Assessment \u2705\n\n**Approve** - This is a well-crafted fix that addresses the reported issue with minimal, targeted changes. The code is clean, well-documented, and follows the project's existing patterns.\n\nThe one minor suggestion above (handling error paths) is optional and can be addressed in a follow-up if desired.\n\n---\n\ud83e\udd16 *Review generated with Claude Code*", "createdAt": "2026-01-06T11:48:31Z", "author": {"login": "claude[bot]"}}]}

AFM-SPM_TopoStats_1094/issues/AFM-SPM_TopoStats_1076.json

@@ -0,0 +1 @@
+{"number": 1076, "title": "[Bug]: Minor issue: Running just the filter program with image_set=all produces plotting directory structure erroneously.", "body": "### Checklist\n\n- [x] Find the offending file in the output. If processing halts, re-run analysis with `topostats --core 1 process`.\n- [x] Describe the bug.\n- [x] Include the configuration file.\n- [x] Copy of the log-file from running with `topostats --log-level debug <command>`.\n- [x] The exact command that failed. This is what you typed at the command line, including any options.\n- [x] TopoStats version, this is reported by `topostats --version`\n- [x] Operating System and Python Version\n\n### Describe the bug\n\nJust to emphasize, this is a really niche and minor bug.\n\nWhen running the `filter` program on an image using a config file that has `image_set=all`, it produces the plotting output directory structure, despite this program not plotting anything.\n\nSee here the output folders for the different image sets:\n\n`image_set=core`:\n```\n\u276f tree output\noutput\n\u251c\u2500\u2500 config.yaml\n\u2514\u2500\u2500 processed\n    \u2514\u2500\u2500 minicircle_small_processed.topostats\n\n2 directories, 2 files\n```\n\n`image_set=all`:\n```\n\u276f tree output\noutput\n\u251c\u2500\u2500 config.yaml\n\u2514\u2500\u2500 processed\n    \u251c\u2500\u2500 minicircle_small_processed\n    \u2502\u00a0\u00a0 \u251c\u2500\u2500 dnatracing\n    \u2502\u00a0\u00a0 \u2502\u00a0\u00a0 \u251c\u2500\u2500 above\n    \u2502\u00a0\u00a0 \u2502\u00a0\u00a0 \u2502\u00a0\u00a0 \u251c\u2500\u2500 curvature\n    \u2502\u00a0\u00a0 \u2502\u00a0\u00a0 \u2502\u00a0\u00a0 \u2514\u2500\u2500 nodes\n    \u2502\u00a0\u00a0 \u2502\u00a0\u00a0 \u2514\u2500\u2500 below\n    \u2502\u00a0\u00a0 \u2502\u00a0\u00a0     \u251c\u2500\u2500 curvature\n    \u2502\u00a0\u00a0 \u2502\u00a0\u00a0     \u2514\u2500\u2500 nodes\n    \u2502\u00a0\u00a0 \u251c\u2500\u2500 filters\n    \u2502\u00a0\u00a0 \u2514\u2500\u2500 grains\n    \u2502\u00a0\u00a0     \u251c\u2500\u2500 above\n    \u2502\u00a0\u00a0     \u2514\u2500\u2500 below\n    \u2514\u2500\u2500 minicircle_small_processed.topostats\n\n14 directories, 2 files\n```\n\n### Copy of the log-file from running with `topostats --log-level debug <command>`\n\n`image_set=core`:\n```\n\u276f topostats -c config.yaml filter\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] The YAML configuration file is valid.\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] The YAML plotting configuration file is valid.\n[Tue, 21 Jan 2025 16:25:46] [ERROR   ] [topostats] Splining enabled but Filters disabled. Please check your configuration file.\n[Tue, 21 Jan 2025 16:25:46] [ERROR   ] [topostats] [processing.py] [1384] Splining enabled but Filters disabled. Please check your configuration file.\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Configuration file loaded from      : config.yaml\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Scanning for images in              : data\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Output directory                    : output\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Looking for images with extension   : .topostats\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Images with extension .topostats in data : 1\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Thresholding method (Filtering)     : std_dev\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Thresholding method (Grains)        : std_dev\n[Tue, 21 Jan 2025 16:25:46] [INFO    ] [topostats] Extracting image from data/minicircle_small_processed.topostats\n16:25:46 | INFO |topostats.py:topostats:load_topostats:38 | Loading image from : data/minicircle_small_processed.topostats\n16:25:47 | INFO |topostats.py:topostats:load_topostats:46 | [minicircle_small_processed] TopoStats file version : 0.2\nProcessing images from data, results are under output:   0%|                                                      | 0/1 [00:00<?, ?it/s][Tue, 21 Jan 2025 16:25:50] [INFO    ] [topostats] Processing : minicircle_small_processed\n[Tue, 21 Jan 2025 16:25:50] [ERROR   ] [topostats] You have not included running the initial filter stage. This is required for all subsequent stages of processing. Please check your configuration file.\n[Tue, 21 Jan 2025 16:25:50] [ERROR   ] [topostats] [processing.py] [127] You have not included running the initial filter stage. This is required for all subsequent stages of processing. Please check your configuration file.\n[Tue, 21 Jan 2025 16:25:50] [INFO    ] [topostats] [minicircle_small_processed] : Saving image to .topostats file\nProcessing images from data, results are under output: 100%|\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588| 1/1 [00:03<00:00,  3.20s/it][Tue, 21 Jan 2025 16:25:50] [INFO    ] [topostats] [minicircle_small_processed] Filtering completed.\nProcessing images from data, results are under output: 100%|\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588| 1/1 [00:03<00:00,  3.20s/it]\n\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n\n  _______      _____      __ __       _____     ______    _______      _____      _______    ______\n/\\_______)\\   ) ___ (    /_/\\__/\\    ) ___ (   / ____/\\ /\\_______)\\   /\\___/\\   /\\_______)\\ / ____/\\\n\\(___  __\\/  / /\\_/\\ \\   ) ) ) ) )  / /\\_/\\ \\  ) ) __\\/ \\(___  __\\/  / / _ \\ \\  \\(___  __\\/ ) ) __\\/\n  / / /     / /_/ (_\\ \\ /_/ /_/ /  / /_/ (_\\ \\  \\ \\ \\     / / /      \\ \\(_)/ /    / / /      \\ \\ \\\n ( ( (      \\ \\ )_/ / / \\ \\ \\_\\/   \\ \\ )_/ / /  _\\ \\ \\   ( ( (       / / _ \\ \\   ( ( (       _\\ \\ \\\n  \\ \\ \\      \\ \\/_\\/ /   )_) )      \\ \\/_\\/ /  )____) )   \\ \\ \\     ( (_( )_) )   \\ \\ \\     )____) )\n  /_/_/       )_____(    \\_\\/        )_____(   \\____\\/    /_/_/      \\/_/ \\_\\/    /_/_/     \\____\\/\n\n\n[Tue, 21 Jan 2025 16:25:50] [INFO    ] [topostats]\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ COMPLETE ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n  TopoStats Version           : 2.3.1.dev84+g83aaed27d.d20250120\n  Base Directory              : data\n  File Extension              : .topostats\n  Files Found                 : 1\n  Successfully Processed^1    : 1 (100.0%)\n  All statistics              : output/all_statistics.csv\n  Distribution Plots          : Disabled. Enable in config 'summary_stats/run' if needed.\n\n  Configuration               : output/config.yaml\n\n  Email                       : topostats@sheffield.ac.uk\n  Documentation               : https://afm-spm.github.io/topostats/\n  Source Code                 : https://github.com/AFM-SPM/TopoStats/\n  Bug Reports/Feature Request : https://github.com/AFM-SPM/TopoStats/issues/new/choose\n  Citation File Format        : https://github.com/AFM-SPM/TopoStats/blob/main/CITATION.cff\n\n  ^1 Successful processing of an image is detection of grains and calculation of at least\n     grain statistics. If these have been disabled the percentage will be 0.\n\n  If you encounter bugs/issues or have feature requests please report them at the above URL\n  or email us.\n\n  If you have found TopoStats useful please consider citing it. A Citation File Format is\n  linked above and available from the Source Code page.\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n```\n\n`image_set=all`:\n```\n\u276f topostats -c config.yaml filter\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] The YAML configuration file is valid.\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] The YAML plotting configuration file is valid.\n[Tue, 21 Jan 2025 16:14:34] [ERROR   ] [topostats] Splining enabled but Filters disabled. Please check your configuration file.\n[Tue, 21 Jan 2025 16:14:34] [ERROR   ] [topostats] [processing.py] [1384] Splining enabled but Filters disabled. Please check your configuration file.\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Configuration file loaded from      : config.yaml\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Scanning for images in              : data\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Output directory                    : output\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Looking for images with extension   : .topostats\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Images with extension .topostats in data : 1\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Thresholding method (Filtering)     : std_dev\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Thresholding method (Grains)        : std_dev\n[Tue, 21 Jan 2025 16:14:34] [INFO    ] [topostats] Extracting image from data/minicircle_small_processed.topostats\n16:14:34 | INFO |topostats.py:topostats:load_topostats:38 | Loading image from : data/minicircle_small_processed.topostats\n16:14:34 | INFO |topostats.py:topostats:load_topostats:46 | [minicircle_small_processed] TopoStats file version : 0.2\nProcessing images from data, results are under output:   0%|                                                      | 0/1 [00:00<?, ?it/s][Tue, 21 Jan 2025 16:14:37] [INFO    ] [topostats] Processing : minicircle_small_processed\n[Tue, 21 Jan 2025 16:14:37] [ERROR   ] [topostats] You have not included running the initial filter stage. This is required for all subsequent stages of processing. Please check your configuration file.\n[Tue, 21 Jan 2025 16:14:37] [ERROR   ] [topostats] [processing.py] [127] You have not included running the initial filter stage. This is required for all subsequent stages of processing. Please check your configuration file.\n[Tue, 21 Jan 2025 16:14:37] [INFO    ] [topostats] [minicircle_small_processed] : Saving image to .topostats file\nProcessing images from data, results are under output: 100%|\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588| 1/1 [00:03<00:00,  3.29s/it][Tue, 21 Jan 2025 16:14:37] [INFO    ] [topostats] [minicircle_small_processed] Filtering completed.\nProcessing images from data, results are under output: 100%|\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588\u2588| 1/1 [00:03<00:00,  3.29s/it]\n\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n\n  _______      _____      __ __       _____     ______    _______      _____      _______    ______\n/\\_______)\\   ) ___ (    /_/\\__/\\    ) ___ (   / ____/\\ /\\_______)\\   /\\___/\\   /\\_______)\\ / ____/\\\n\\(___  __\\/  / /\\_/\\ \\   ) ) ) ) )  / /\\_/\\ \\  ) ) __\\/ \\(___  __\\/  / / _ \\ \\  \\(___  __\\/ ) ) __\\/\n  / / /     / /_/ (_\\ \\ /_/ /_/ /  / /_/ (_\\ \\  \\ \\ \\     / / /      \\ \\(_)/ /    / / /      \\ \\ \\\n ( ( (      \\ \\ )_/ / / \\ \\ \\_\\/   \\ \\ )_/ / /  _\\ \\ \\   ( ( (       / / _ \\ \\   ( ( (       _\\ \\ \\\n  \\ \\ \\      \\ \\/_\\/ /   )_) )      \\ \\/_\\/ /  )____) )   \\ \\ \\     ( (_( )_) )   \\ \\ \\     )____) )\n  /_/_/       )_____(    \\_\\/        )_____(   \\____\\/    /_/_/      \\/_/ \\_\\/    /_/_/     \\____\\/\n\n\n[Tue, 21 Jan 2025 16:14:37] [INFO    ] [topostats]\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ COMPLETE ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n  TopoStats Version           : 2.3.1.dev84+g83aaed27d.d20250120\n  Base Directory              : data\n  File Extension              : .topostats\n  Files Found                 : 1\n  Successfully Processed^1    : 1 (100.0%)\n  All statistics              : output/all_statistics.csv\n  Distribution Plots          : Disabled. Enable in config 'summary_stats/run' if needed.\n\n  Configuration               : output/config.yaml\n\n  Email                       : topostats@sheffield.ac.uk\n  Documentation               : https://afm-spm.github.io/topostats/\n  Source Code                 : https://github.com/AFM-SPM/TopoStats/\n  Bug Reports/Feature Request : https://github.com/AFM-SPM/TopoStats/issues/new/choose\n  Citation File Format        : https://github.com/AFM-SPM/TopoStats/blob/main/CITATION.cff\n\n  ^1 Successful processing of an image is detection of grains and calculation of at least\n     grain statistics. If these have been disabled the percentage will be 0.\n\n  If you encounter bugs/issues or have feature requests please report them at the above URL\n  or email us.\n\n  If you have found TopoStats useful please consider citing it. A Citation File Format is\n  linked above and available from the Source Code page.\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n```\n\n### Include the configuration file\n\nUsing partial config files (\ud83c\udf89)\n\n`image_set=core`:\n```yaml\nbase_dir: ./data # Directory in which to search for data files\noutput_dir: ./output # Directory to output results to\nlog_level: info # Verbosity of output. Options: warning, error, info, debug\ncores: 1 # Number of CPU cores to utilise for processing multiple files simultaneously.\nfile_ext: .topostats # File extension of the data files.\nloading:\n  channel: Height # Channel to pull data from in the data files.\n  extract: all # Array to extract when loading .topostats files.\nfilter:\n  run: false # Options : true, false\nplotting:\n  run: true # Options : true, false\n  image_set: core # Options : all, core\n```\n\n`image_set=all`:\n```\nbase_dir: ./data # Directory in which to search for data files\noutput_dir: ./output # Directory to output results to\nlog_level: info # Verbosity of output. Options: warning, error, info, debug\ncores: 1 # Number of CPU cores to utilise for processing multiple files simultaneously.\nfile_ext: .topostats # File extension of the data files.\nloading:\n  channel: Height # Channel to pull data from in the data files.\n  extract: all # Array to extract when loading .topostats files.\nfilter:\n  run: false # Options : true, false\nplotting:\n  run: true # Options : true, false\n  image_set: all # Options : all, core\n```\n\n\n### To Reproduce\n\n`topostats -c config.yaml filter` using the above `image_set=all` config. It'll produce the plot directory output structure.\n\n### TopoStats Version\n\nGit main branch\n\n### Python Version\n\n3.11\n\n### Operating System\n\nGNU/Linux\n\n### Python Packages\n\nN/A IMO", "state": "CLOSED", "created_at": "2025-01-21T16:40:55Z", "closed_at": "2025-03-03T09:11:03Z", "author_login": "SylviaWhittle", "comment_rounds": [{"comments": [{"id": "IC_kwDOCgYf5M6bUB6a", "body": "I know why this is, and it's because we setup the directory structure up-front based on the loaded configuration which includes everything that is to be run, even if invocation is via the first of many new entry points in the #517 work.\n\nWill need some refactoring of how and when to do this, shouldn't be too big a job.", "createdAt": "2025-01-21T20:55:01Z", "updatedAt": "2025-01-21T20:55:01Z", "author": {"login": "ns-rse"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 1095, "link_type": "bare_mention", "will_close": false, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [], "body_backfilled": true}

AFM-SPM_TopoStats_1094/issues/AFM-SPM_TopoStats_743.json

@@ -0,0 +1 @@
+{"number": 743, "title": "Grainstats entry point", "body": "Further to #517 add an entry point for `topostats grainstats` which loads files saved as `.topostats` (handled by `io.LoadScans` class) and calculates statistics.\r\n\r\nQuestions...\r\n\r\n+ Should the statistics be saved as part of the HDF5 data? I ask because in batch processing end-to-end the grain statistics are often combined with the tracing statistics so if a user were to load a `.topostats` file to perform tracing they might expect to have grain statistics combined. Of course if they haven't undertaken grain statistic calculation and jump straight to tracing and tracing statistics this will never be possible.", "state": "CLOSED", "created_at": "2023-11-30T10:26:07Z", "closed_at": "2025-03-03T14:52:19Z", "author_login": "ns-rse", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1094, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["ui", "v2.4.0"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [{"number": 517, "title": "Remodel entry points and Command Line Interface to use \"Swiss Army knife\" approach", "state": "OPEN"}]}

Aam-Digital_ndb-core_3080__human_human_2/issues/Aam-Digital_ndb-core_2693.json

@@ -0,0 +1 @@
+{"number": 2693, "title": "On clicking \"Go to Details\" button, page is blank", "body": "**Describe the bug**\nAfter recording \"Attendance\" from the dashboard link, on clicking \"Go to Details\" button, page is blank. \n\n**To Reproduce**\n\n\n1. Go to ' Record Attendance\" from the dashboard.\n2. Mark class' attendance.\n3. Click on \"Review details\"\n4. Scroll down to 'Go to Details\"\n5. See error- Page shows up blank.\n\n\n**Screenshots**\n![Image](https://github.com/user-attachments/assets/9e0becea-7347-4445-96e3-4a35717f1835)\n![Image](https://github.com/user-attachments/assets/8b722ec8-38d1-414c-a631-ad661ba5cf15)\n![Image](https://github.com/user-attachments/assets/2311df55-20c9-4100-97d7-427665715f34)\n\n", "state": "CLOSED", "created_at": "2024-11-29T14:28:14Z", "closed_at": "2025-06-23T11:40:40Z", "author_login": "george-neha", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM6di6zo", "body": "The issue behind this is that such entities are \"EventNote\" and not \"Note\" entities. The routes do not work correctly then in this context ...", "createdAt": "2025-02-07T14:58:04Z", "updatedAt": "2025-02-07T14:58:04Z", "author": {"login": "sleidig"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM6sZIro", "body": "- related to #2918 ", "createdAt": "2025-05-19T21:10:15Z", "updatedAt": "2025-05-19T21:10:15Z", "author": {"login": "sleidig"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM6yk2g0", "body": "This is currently not an open bug anymore (there simply is not \"go to details\" button for EventNote records) but we should fix this more generally, considering the differences between Note & EventNote entities\n\n- #2405 \n- custom code adding view config for note/:id https://github.com/Aam-Digital/ndb-core/blob/c204919d995acaca015f076c1edd07b1bbe234e7/src/app/core/config/config.service.ts#L344", "createdAt": "2025-06-23T11:13:06Z", "updatedAt": "2025-06-23T11:13:06Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6ylYL8", "body": "Added auto-config for a view:eventnote route now. We may still want to consider finding a different entity-type model with these two closely overlapping types, Note and EventNote. But the issue itself is resolved now.", "createdAt": "2025-06-23T11:40:40Z", "updatedAt": "2025-06-23T11:40:40Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6zFAhW", "body": ":tada: This issue has been resolved in version 3.57.0-master.5 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.0-master.5)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-06-25T11:30:19Z", "updatedAt": "2025-06-25T11:30:19Z", "author": {"login": "aam-digital-ci"}}, {"id": "IC_kwDOA0GdQM6zZfQJ", "body": ":tada: This issue has been resolved in version 3.57.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-06-26T20:04:47Z", "updatedAt": "2025-06-26T20:04:47Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Status: Complex Issue", "released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [], "body_backfilled": true}

Aam-Digital_ndb-core_3080__human_human_2/issues/Aam-Digital_ndb-core_2944.json

@@ -0,0 +1 @@
+{"number": 2944, "title": "Editing the address details", "body": "**Edit Address details**\n\n**Scenario :** I should be able to edit the child's address details. As a user, I should be able to edit the full address or parts. The newly captured address details should override the previously captured ones.\nIn scenarios where the user clicks on on one of suggested/possible locations listed, then the functionality should be as scenario 1 in https://github.com/Aam-Digital/ndb-core/issues/2943.\n\nIn scenarios where:\nUser edits the address details, but does not click one of the suggested/possible locations. Then the following should be triggered on save: \u201cDo you want to update the location pinned on the map?\u201d\nIf the user clicks no, then the address details are captured without changing the location on the map.\nExample : \nOld Location:  Impact Hub, Rollbergstra\u00dfe 28A, 12053 Berlin\nUser edits:  Impact Hub, 2nd floor, cabin 3 Rollbergstra\u00dfe 28A, 12053 Berlin\nNew Location:  Impact Hub, 2nd floor, cabin 3 Rollbergstra\u00dfe 28A, 12053 Berlin\n\nExample : \nOld Location:  Impact Hub, Rollbergstra\u00dfe 28A, 12053 Berlin\nUser edits: Impact Hub Stuttgart\nNew Location: Impact Hub, Reuterstrasse 17A, 12053 Stuttgart\n\n", "state": "CLOSED", "created_at": "2025-04-08T15:26:26Z", "closed_at": "2025-07-02T11:19:14Z", "author_login": "george-neha", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM60eoab", "body": ":tada: This issue has been resolved in version 3.57.1-master.6 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.1-master.6)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-07-02T13:39:19Z", "updatedAt": "2025-07-02T13:39:19Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM61gPg6", "body": ":tada: This issue has been resolved in version 3.57.1 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.1)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-07-07T13:24:35Z", "updatedAt": "2025-07-07T13:24:35Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3080, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Aam-Digital_ndb-core_3080__human_human_2/issues/Aam-Digital_ndb-core_3074.json

@@ -0,0 +1 @@
+{"number": 3074, "title": "Capturing additional details in the address field", "body": "As a user, I should be able to capture the address details given by the child in the Aam Digital System so that I can visualise them, if available, on a map without losing any additional data.\n\nScenario 2: As a user, I should be able to capture additional details like the house number, flat number, building name etc. so that these details are available in the system.\nA second line should contain additional details captured that do not match the data pulled from the map API.\n\nExample 2:\nUser input: \u201cImpact Hub, 2nd floor, cabin 3 Berlin\u201d\nAddress Displayed: Impact Hub, Rollbergstra\u00dfe 28A, 12053 Berlin.\n2nd floor, cabin 3\nExample 3: User input: \u201cReuterstrasse 17A, Berlin\u201d\nAddress displayed: \u201cReuterstrasse, 12053 Berlin.\n17A\n\nWhen you enter an address with additional details (like the house number, flat number, building name, etc.) in the search bar, the possible/ suggested locations should be available in a drop-down menu.\nThe user should be able to click on the suggested location from the list.\nThe additional details captured do not match the API; they should be available in a second line to avoid losing this information.\nThe selected location should be displayed along with the pinned map in the UI.", "state": "CLOSED", "created_at": "2025-06-16T14:49:12Z", "closed_at": "2025-07-02T11:19:14Z", "author_login": "george-neha", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM6yyrUs", "body": "To support multi-line addresses in the future (see #3062), I would suggest a single textarea (multi-line input field) rather than separate fields for the additional details. What do you think, @sadaf895 , @george-neha ?", "createdAt": "2025-06-24T09:58:19Z", "updatedAt": "2025-06-24T09:58:19Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6zGTQ8", "body": "Bug: Clicked on an address from the dropdown list, but changed the pinned location in the map, so then the captured address is getting replaced with the address details of the pinned location. @sadaf895 ", "createdAt": "2025-06-25T13:27:12Z", "updatedAt": "2025-06-25T13:27:12Z", "author": {"login": "george-neha"}}, {"id": "IC_kwDOA0GdQM6zPoHj", "body": "> Bug: Clicked on an address from the dropdown list, but changed the pinned location in the map, so then the captured address is getting replaced with the address details of the pinned location. [@sadaf895](https://github.com/sadaf895)\n\nThis is (currently) expected behavior as a feature to help users get a readable address after selecting some location on the map. The other PR is currently working on adapting this behavior with a confirmation dialog (see https://github.com/Aam-Digital/ndb-core/pull/3080#pullrequestreview-2942381291)", "createdAt": "2025-06-26T06:09:09Z", "updatedAt": "2025-06-26T06:09:09Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6zPyps", "body": "In the current PR #3084 the field is now multi-line (thanks!) but no additional information is put into the text yet. I understand that often the search doesn't return any results if the user enters too specifically but there are some examples from the general overview here (https://github.com/Aam-Digital/ndb-core/issues/2878#issuecomment-2740931434) that could serve as test cases that can be improved:\n\nfor example:\n- user input (search): \"Reuterstr. 17a, Berlin\"\n- --> found address \"Reuterstra\u00dfe, 12053 Berlin\"\n- improved functionality here should keep the house number, which is missing from the search result, in the second line\n\n@sadaf895 , @george-neha ", "createdAt": "2025-06-26T06:21:50Z", "updatedAt": "2025-06-26T06:22:10Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6zVSzE", "body": "> In the current PR [#3084](https://github.com/Aam-Digital/ndb-core/pull/3084) the field is now multi-line (thanks!) but no additional information is put into the text yet. I understand that often the search doesn't return any results if the user enters too specifically but there are some examples from the general overview here ([#2878 (comment)](https://github.com/Aam-Digital/ndb-core/issues/2878#issuecomment-2740931434)) that could serve as test cases that can be improved:\n> \n> for example:\n> \n> * user input (search): \"Reuterstr. 17a, Berlin\"\n> * --> found address \"Reuterstra\u00dfe, 12053 Berlin\"\n> * improved functionality here should keep the house number, which is missing from the search result, in the second line\n> \n> [@sadaf895](https://github.com/sadaf895) , [@george-neha](https://github.com/george-neha)\n\nI am sharing my opinion on improving the UX flow:\n1.User types an address and sees suggestions.\n2.User selects a suggestion.\n3.If the user\u2019s input is different from the suggestion (i.e., not a substring or not fully included):\n -Show a dialog/modal or inline prompt: \u201cDo you want to keep your original input as additional info?\u201d\n Options:\n  -Use only the selected address\n  -Add my input as additional info (second line)\n4.Save the address based on the user\u2019s choice.\n\nWhat are your thoughts? @sleidig, @george-neha ", "createdAt": "2025-06-26T14:30:02Z", "updatedAt": "2025-06-26T14:30:02Z", "author": {"login": "sadaf895"}}, {"id": "IC_kwDOA0GdQM6zVc1T", "body": "This sounds good to me. Pretty clear flow.\n\nWe _are_ putting a lot of confirmation dialogs and things in front of users but I can't think of very obvious ways to simplify it ... How does Google Calendar and others manage to make selecting a location so seamless? \ud83e\udd14 ", "createdAt": "2025-06-26T14:42:25Z", "updatedAt": "2025-06-26T14:42:25Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6zmkD2", "body": "Can we move the additional details that do not match with the API in the second line? @sadaf895 \n\nEg. ser input (search): \"Reuterstr. 17a, Berlin\"\n\n--> found address \"Reuterstra\u00dfe, 12053 Berlin\"\n\n    UI:  Reuterstra\u00dfe, 12053 Berlin\n          17a", "createdAt": "2025-06-27T14:15:19Z", "updatedAt": "2025-06-27T14:15:19Z", "author": {"login": "george-neha"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM60eodA", "body": ":tada: This issue has been resolved in version 3.57.1-master.6 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.1-master.6)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-07-02T13:39:22Z", "updatedAt": "2025-07-02T13:39:22Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM61gPou", "body": ":tada: This issue has been resolved in version 3.57.1 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.1)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-07-07T13:24:38Z", "updatedAt": "2025-07-07T13:24:38Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3080, "link_type": "closing_keyword", "will_close": true, "comment_count": 9, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Aam-Digital_ndb-core_3080__human_human_2/issues/Aam-Digital_ndb-core_3076.json

@@ -0,0 +1 @@
+{"number": 3076, "title": "Capture address details and Change the pinned location on the map", "body": "Scenario 4: As a user, I should be able to manually move the pin on the map without losing on the address details that i have captured.\nWhen entering an address in the search bar, the possible/ suggested locations are available in a listed drop-down. I should be able to move the pinned location on the map. If the address captured does not match with the new pinned location, a dialog box should appear: \" Address details captured does not match with the location on the map. Do you want to continue or edit the address?\u201d\n\nDialog buttons: Continue/Edit Address\nContinue> The address details captured should be saved along with the new the pinned location on the map.", "state": "CLOSED", "created_at": "2025-06-16T14:51:20Z", "closed_at": "2025-07-02T11:19:14Z", "author_login": "george-neha", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM60eoYQ", "body": ":tada: This issue has been resolved in version 3.57.1-master.6 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.1-master.6)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-07-02T13:39:16Z", "updatedAt": "2025-07-02T13:39:16Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM61gPYN", "body": ":tada: This issue has been resolved in version 3.57.1 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.1)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-07-07T13:24:32Z", "updatedAt": "2025-07-07T13:24:32Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3080, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Aam-Digital_ndb-core_3080__human_human_2/issues/Aam-Digital_ndb-core_3093.json

@@ -0,0 +1 @@
+{"number": 3093, "title": "code-based entity types somehow not properly loaded", "body": "\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Init with \"basic setup\" use case\n2. Log in as demo-admin\n3. Open \"Admin\" > \"Administer Entity Types\"\n4. A type like \"Recurring Activity\" is not listed until you click \"Load internal types\" although it is a primary, user-facing type\n", "state": "CLOSED", "created_at": "2025-06-23T19:22:03Z", "closed_at": "2025-06-25T11:26:07Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM6zB1bG", "body": "@sleidig, I\u2019ve found the issue(its related to configjson).\n\nIn our current basic setup, the code-based entity type (like \"Recurring Activity\", \"Note\") is not present in the `config_entityJson` files. That\u2019s why it doesn\u2019t appear in the \"Administer Entity Types\" list until \"Load internal types\" is clicked.\n\nAlso, these types are user-facing, but in the `entityRegistry.getEntityTypes()` output, they do not have _isCustomizedType. For eg:\n```\nclass Note {\n  ENTITY_TYPE = \"Note\";\n  hasPII = true;\n  icon = \"file-alt\";\n  label = \"Note\";\n  _labelPlural = \"Notes\";\n  toStringAttributes = ['subject'];\n}\n```\nBecause of the missing `_isCustomizedType`, these types are filtered out initially, and only appear when we load internal types.\n\nTo fix this, we need to include these entity types in the base config. Let me know if I should go ahead and update the configuration accordingly. may be for (Note, school enrollment, recurring activity, Event Note ,and observation?)\neg baisc details -\n```\n \"entity:RecurringActivity\": {\n      \"label\": \"Recurring Activity\",\n      \"labelPlural\": \"Recurring Activities\",\n      \"attributes\": {}\n    },\n\n\"entity:Note\":{\n      \"label\": \"Note\",\n      \"labelPlural\": \"Notes\",\n}\n```\n\n", "createdAt": "2025-06-25T07:00:09Z", "updatedAt": "2025-06-25T07:09:02Z", "author": {"login": "Abhinegi2"}}, {"id": "IC_kwDOA0GdQM6zB5gB", "body": "Previously it was possible to have these entities only in the code base and (if no custom fields were required) not mention them in the customized config doc. This saves a lot of complexity in the config. I would like to recover that functionality.\n\nDidn't we introduce the more explicit `isInternalEntity` flag to do filtering? Do we really need/want to hide also other entities that are not customized?", "createdAt": "2025-06-25T07:06:29Z", "updatedAt": "2025-06-25T07:06:29Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM6zCA8r", "body": "Hmm, I think we can simplify this by using the existing `isInternalEntity` flag.\n\nCurrently, we first get all entity types using `getEntityTypes()`, and then apply additional filtering using `isInternalEntity`. But since we already have the `isInternalEntity` flag, we could use that at a higher level instead.\n\nSo, in getEntityTypes instead of checking `value._isCustomizedType && value.label`, we could simplify the logic to something like:\n`!value.isInternalEntity && value.label`.\nAnd then we do not need to check _isCustomizedType\n\n", "createdAt": "2025-06-25T07:15:35Z", "updatedAt": "2025-06-25T07:15:35Z", "author": {"login": "Abhinegi2"}}, {"id": "IC_kwDOA0GdQM6zFAfV", "body": ":tada: This issue has been resolved in version 3.57.0-master.5 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.0-master.5)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-06-25T11:30:16Z", "updatedAt": "2025-06-25T11:30:16Z", "author": {"login": "aam-digital-ci"}}, {"id": "IC_kwDOA0GdQM6zZfOS", "body": ":tada: This issue has been resolved in version 3.57.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.57.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-06-26T20:04:44Z", "updatedAt": "2025-06-26T20:04:44Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released", "Client: by X"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [], "body_backfilled": true}

Aam-Digital_ndb-core_3317__human_agent/issues/Aam-Digital_ndb-core_3185.json

@@ -0,0 +1 @@
+{"number": 3185, "title": "Public form magic links to take up/link with more than 1 parameter/entity type", "body": "As a user, for my public forms, I want to be able to send out magic links that on top of the public form (UU)ID include more than 1 parameter, i.e. allow me to link the submission to more than 1 entity type at once. E.g. I want to send out a form that automatically links the submitted public form both to the entity type \"participant\" and the entity type \"event\".\n\nE.g. `https://..... /publicformID?event=eventID&participant=participantID`\n\nThis would help me to automatically link my submission to multiple entity types, which saves me time and also gives me more analysis options later down the line.\n\nThis is different from the \"prefill form field  with value\" form setting, since it is more dynamic and doesn't force the user to create a separate public form for each potentially linked value of an entity type, e.g. to each \"event\". \n\n\nThis first issue ticket is **just about the technical ability** of the system to understand such magic links. It is not yet about the question how such links could be made available to a user via the UI. This is a separate topic.", "state": "CLOSED", "created_at": "2025-08-01T09:31:25Z", "closed_at": "2025-09-29T12:15:42Z", "author_login": "MalteHD", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM7E4cVZ", "body": "The general guide talking about public forms setup as context: https://chatwoot.help/hc/aam-digital/articles/1738849087-creating-a-public-form-for-external-users\n\nCurrently, users can set up the public form with one special ID in the URL through the interface:\n\n<img width=\"927\" height=\"837\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/6ef48b84-c140-4d82-84d9-89ab278f66c6\" />\n\n1. Create a Public Form for an entity type that links to other types (e.g. for Note)\n2. Go to \"Configure Pre-filled Values\" tab configuring the form\n3. Select a field for \"Collect replies of this form linked to individual records\" section (e.g. \"Children\") \n4. Then open one Child record (to which a public form response should be linked)\n5. Open the context menu for that entity and select \"Copy Custom Form\"\nThat link contains the entity ID and the public form will prefill this in the background (e.g. https://test.aam-digital.net/public-form/form/note?children=Child%3A12)\n\n--> new requirement: the URL can contain multiple such IDs and the public form prefills all of these IDs. (UI to copy such a complex URL with multiple parameters is out of scope for this issue. We will manually create the URLs for now)", "createdAt": "2025-09-17T13:56:49Z", "updatedAt": "2025-09-17T17:31:26Z", "author": {"login": "sleidig"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM7HeY8r", "body": ":tada: This issue has been resolved in version 3.62.0-master.4 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.62.0-master.4)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-09-29T12:19:08Z", "updatedAt": "2025-09-29T12:19:08Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM7Jn1zL", "body": ":tada: This issue has been resolved in version 3.62.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.62.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-10-08T18:08:27Z", "updatedAt": "2025-10-08T18:08:27Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3317, "link_type": "closing_keyword", "will_close": true, "comment_count": 3, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Type: Improvement", "released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Aam-Digital_ndb-core_3561__human_agent_2/issues/Aam-Digital_ndb-core_3548.json

@@ -0,0 +1 @@
+{"number": 3548, "title": "app gets extremely slow when there are many (300+) NotificationEvents", "body": "- try to reproduce the slowdown by adding (fake) notification events manually overwriting in [NotificationComponent](https://github.com/Aam-Digital/ndb-core/blob/503bd13bb0416832375cac6f02053df9bf3ebc43/src/app/features/notification/notification.component.ts#L47C10-L47C26)\n- if that causes the issue, implement a virtual scroll or \"load more\" in the list of notifications", "state": "CLOSED", "created_at": "2025-12-30T19:09:42Z", "closed_at": "2026-01-07T17:32:05Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM7dulfS", "body": ":tada: This issue has been resolved in version 3.68.0-master.10 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.68.0-master.10)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-01-07T17:35:37Z", "updatedAt": "2026-01-07T17:35:37Z", "author": {"login": "aam-digital-ci"}}, {"id": "IC_kwDOA0GdQM7eUZNu", "body": ":tada: This issue has been resolved in version 3.68.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.68.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-01-09T17:25:04Z", "updatedAt": "2026-01-09T17:25:04Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3561, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released", "Client: by X"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [], "body_backfilled": true}

Aam-Digital_ndb-core_3675__human_agent/issues/Aam-Digital_ndb-core_3663.json

@@ -0,0 +1 @@
+{"number": 3663, "title": "deleting from dialog context menu should close dialog", "body": "**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Go to 'Tasks'\n2. Open a Task's details (opens dialog overlay)\n3. use the three-dot context menu and delete the entity\n4. ... dialog remains open. --> should close the dialog because you are viewing data that has been deleted already\n", "state": "CLOSED", "created_at": "2026-02-12T12:56:35Z", "closed_at": "2026-02-16T18:05:26Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM7pC9jb", "body": ":tada: This issue has been resolved in version 3.70.1-master.2 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.70.1-master.2)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-02-16T18:08:50Z", "updatedAt": "2026-02-16T18:08:50Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM7qmRpr", "body": ":tada: This issue has been resolved in version 3.71.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.71.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-02-20T16:32:45Z", "updatedAt": "2026-02-20T16:32:45Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3675, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Aam-Digital_ndb-core_3675__human_agent/pr.json

@@ -0,0 +1 @@
+{"repo": "Aam-Digital/ndb-core", "pr_number": 3675, "pr_title": "fix: close task dialog after successful delete action", "pr_state": "merged", "pr_author": "sadaf895", "base_branch": "master", "head_branch": "fix/dialog-delete-close", "created_at": "2026-02-16T14:45:47Z", "merged_at": "2026-02-16T18:05:25Z", "base_ref_oid": "d513b879ceabcc6c96394859afb8a91e82cca379", "head_ref_oid": "98d7a614ebad4f71981df87132322bde29fe9600", "base_commit": {"oid": "d513b879ceabcc6c96394859afb8a91e82cca379", "message": "fix: skip non-sortable columns when inferring default sort (#3672)\n\nfixes #3647", "authoredDate": "2026-02-16T17:49:26Z", "author": {"name": "Abhishek Negi", "email": "108608673+Abhinegi2@users.noreply.github.com", "user": {"login": "Abhinegi2"}}}, "rounds": [{"round_index": 0, "review_state": "COMMENTED", "review_author": "qltysh", "submitted_at": "2026-02-16T14:47:53Z", "feedback_type": "inline", "review_author_association": "CONTRIBUTOR", "inline_comments": [{"id": "PRRC_kwDOA0GdQM6np7mV", "body": "Member 'dialogRef' is never reassigned; mark it as <code>readonly</code>\\. <i>[radarlint-js:typescript:S2933]</i><a href=\"https://qlty.sh/gh/Aam-Digital/projects/ndb-core/issues/radarlint-js/typescript:S2933/issues/5cbf2ebf70d3b5879628cb332124fdc9\"></a>", "path": "src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts", "originalLine": 38, "line": null, "originalStartLine": null, "startLine": null, "position": 1, "originalPosition": 12, "outdated": true, "subjectType": "LINE", "authorAssociation": "CONTRIBUTOR", "originalCommit": {"oid": "005ada49e5c3374fdb5b3789d67d3dfdb703a6fc"}, "diffHunk": "@@ -34,6 +35,7 @@ import { EntityAction } from \"./entity-action.interface\";\n export class EntityActionsMenuComponent implements OnChanges {\n   private entityActionsMenuService = inject(EntityActionsMenuService);\n   protected viewContext = inject(ViewComponentContext, { optional: true });\n+  private dialogRef = inject(MatDialogRef, { optional: true });", "replyTo": null, "createdAt": "2026-02-16T14:47:53Z", "author": {"login": "qltysh"}, "reactions": {"totalCount": 0, "nodes": []}, "in_reply_to_id": null, "suggested_changes": [], "extended_context": "    MatMenuModule,\n    Angulartics2Module,\n    DisableEntityOperationDirective,\n    MatTooltipModule,\n  ],\n})\nexport class EntityActionsMenuComponent implements OnChanges {\n  private entityActionsMenuService = inject(EntityActionsMenuService);\n  protected viewContext = inject(ViewComponentContext, { optional: true });\n\n  @Input() entity: Entity;\n\n  /**\n   * whether the \"delete\" action will trigger a navigation back to the parent list.\n   * This is useful when the entity is deleted from a fullscreen detail view but not for an overlay.\n   */\n  @Input() navigateOnDelete: boolean = false;\n\n  @Output() actionTriggered = new EventEmitter<string>();\n\n  /**", "referenced_paths": []}], "body_comments": [], "response_commits": [{"oid": "dc2bc54f04f7aadeb1957f1b8dcf6dc9e2ea4fc4", "message": "Change dialogRef to readonly in EntityActionsMenuComponent", "authoredDate": "2026-02-16T14:48:43Z", "author": {"user": {"login": "sadaf895"}, "name": "Abu Sadaf"}, "statusCheckRollup": {"state": "SUCCESS", "contexts": {"nodes": [{"__typename": "CheckRun", "name": "qa / code-quality", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:51Z", "completedAt": "2026-02-16T14:49:57Z"}, {"__typename": "CheckRun", "name": "qa / test-unit", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:51Z", "completedAt": "2026-02-16T14:50:55Z"}, {"__typename": "CheckRun", "name": "qa / test-e2e", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:51Z", "completedAt": "2026-02-16T14:51:35Z"}, {"__typename": "CheckRun", "name": "build / build-webapp", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:49:02Z", "completedAt": "2026-02-16T14:51:16Z"}, {"__typename": "CheckRun", "name": "build / build-image", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:51:20Z", "completedAt": "2026-02-16T14:52:18Z"}, {"__typename": "CheckRun", "name": "deploy", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:52:21Z", "completedAt": "2026-02-16T14:52:32Z"}, {"__typename": "CheckRun", "name": "SonarCloud", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:49:32Z", "completedAt": "2026-02-16T14:49:35Z"}, {"__typename": "StatusContext", "context": "CodeRabbit", "state": "SUCCESS", "createdAt": "2026-02-16T14:52:09Z"}, {"__typename": "CheckRun", "name": "SonarCloud Code Analysis", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:58Z", "completedAt": "2026-02-16T14:49:31Z"}, {"__typename": "StatusContext", "context": "argos", "state": "SUCCESS", "createdAt": "2026-02-16T14:53:49Z"}]}}, "author_type": "human", "agent_commit_signals": [], "ci_state": "SUCCESS", "ci_contexts": [{"__typename": "CheckRun", "name": "qa / code-quality", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:51Z", "completedAt": "2026-02-16T14:49:57Z"}, {"__typename": "CheckRun", "name": "qa / test-unit", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:51Z", "completedAt": "2026-02-16T14:50:55Z"}, {"__typename": "CheckRun", "name": "qa / test-e2e", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:51Z", "completedAt": "2026-02-16T14:51:35Z"}, {"__typename": "CheckRun", "name": "build / build-webapp", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:49:02Z", "completedAt": "2026-02-16T14:51:16Z"}, {"__typename": "CheckRun", "name": "build / build-image", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:51:20Z", "completedAt": "2026-02-16T14:52:18Z"}, {"__typename": "CheckRun", "name": "deploy", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:52:21Z", "completedAt": "2026-02-16T14:52:32Z"}, {"__typename": "CheckRun", "name": "SonarCloud", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:49:32Z", "completedAt": "2026-02-16T14:49:35Z"}, {"__typename": "StatusContext", "context": "CodeRabbit", "state": "SUCCESS", "createdAt": "2026-02-16T14:52:09Z"}, {"__typename": "CheckRun", "name": "SonarCloud Code Analysis", "conclusion": "SUCCESS", "startedAt": "2026-02-16T14:48:58Z", "completedAt": "2026-02-16T14:49:31Z"}, {"__typename": "StatusContext", "context": "argos", "state": "SUCCESS", "createdAt": "2026-02-16T14:53:49Z"}], "ci_failed_checks": [], "ci_test_check_failed": false}], "force_pushes": [], "builds_on_rounds": [], "references_repo_structure": false, "ci_state_at_review": "FAILURE", "ci_state_after_response": "SUCCESS", "ci_transition": "fail_to_pass", "response_commit_diffs": {"dc2bc54f04f7aadeb1957f1b8dcf6dc9e2ea4fc4": {"src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts": [[35, 41]]}}, "has_code_backing": false, "head_commit_at_review": "005ada49e5c3374fdb5b3789d67d3dfdb703a6fc", "file_contents_at_review": {"src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts": "import {\n  Component,\n  EventEmitter,\n  inject,\n  Input,\n  OnChanges,\n  Output,\n  SimpleChanges,\n} from \"@angular/core\";\nimport { Entity } from \"../../entity/model/entity\";\nimport { MatButtonModule } from \"@angular/material/button\";\nimport { FontAwesomeModule } from \"@fortawesome/angular-fontawesome\";\nimport { MatMenuModule } from \"@angular/material/menu\";\nimport { Angulartics2Module } from \"angulartics2\";\nimport { DisableEntityOperationDirective } from \"../../permissions/permission-directive/disable-entity-operation.directive\";\nimport { MatTooltipModule } from \"@angular/material/tooltip\";\nimport { ViewComponentContext } from \"../../ui/abstract-view/view-component-context\";\nimport { EntityActionsMenuService } from \"./entity-actions-menu.service\";\nimport { EntityAction } from \"./entity-action.interface\";\nimport { MatDialogRef } from \"@angular/material/dialog\";\n\n@Component({\n  selector: \"app-entity-actions-menu\",\n  templateUrl: \"./entity-actions-menu.component.html\",\n  styleUrls: [\"./entity-actions-menu.component.scss\"],\n  imports: [\n    MatButtonModule,\n    FontAwesomeModule,\n    MatMenuModule,\n    Angulartics2Module,\n    DisableEntityOperationDirective,\n    MatTooltipModule,\n  ],\n})\nexport class EntityActionsMenuComponent implements OnChanges {\n  private entityActionsMenuService = inject(EntityActionsMenuService);\n  protected viewContext = inject(ViewComponentContext, { optional: true });\n  private dialogRef = inject(MatDialogRef, { optional: true });\n\n  @Input() entity: Entity;\n\n  /**\n   * whether the \"delete\" action will trigger a navigation back to the parent list.\n   * This is useful when the entity is deleted from a fullscreen detail view but not for an overlay.\n   */\n  @Input() navigateOnDelete: boolean = false;\n\n  @Output() actionTriggered = new EventEmitter<string>();\n\n  /**\n   * The actions being displayed as menu items.\n   */\n  actions: EntityAction[];\n\n  /**\n   * Whether some buttons should be displayed directly, outside the three-dot menu in dialog views.\n   */\n  @Input() showExpanded?: boolean;\n\n  async ngOnChanges(changes: SimpleChanges): Promise<void> {\n    if (changes.entity) {\n      await this.filterAvailableActions();\n    }\n  }\n\n  private async filterAvailableActions() {\n    if (!this.entity) {\n      this.actions = [];\n      return;\n    }\n\n    const allActions = await this.entityActionsMenuService.getActionsForSingle(\n      this.entity,\n    );\n    this.actions = allActions;\n  }\n\n  async executeAction(action: EntityAction) {\n    const result = await action.execute(\n      this.entity,\n      this.navigateOnDelete && !this.viewContext?.isDialog,\n    );\n    if (result) {\n      this.actionTriggered.emit(action.action);\n\n      // Close dialog after successful delete action\n      if (\n        action.action === \"delete\" &&\n        this.viewContext?.isDialog &&\n        this.dialogRef\n      ) {\n        this.dialogRef.close();\n      }\n    }\n    setTimeout(() => this.filterAvailableActions());\n  }\n}\n"}}, {"round_index": 1, "review_state": "COMMENTED", "review_author": "coderabbitai", "submitted_at": "2026-02-16T14:52:08Z", "feedback_type": "body_only", "review_author_association": "CONTRIBUTOR", "inline_comments": [], "body_comments": [{"body": "\n\n<details>\n<summary>\ud83e\uddf9 Nitpick comments (1)</summary><blockquote>\n\n<details>\n<summary>src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts (1)</summary><blockquote>\n\n`34-35`: **Missing `OnPush` change detection and signal-based inputs (pre-existing).**\n\nThe component doesn't set `changeDetection: ChangeDetectionStrategy.OnPush` and uses `@Input()`/`@Output()` decorators instead of `input()`/`output()` functions. These are pre-existing and out of scope for this PR, but worth addressing in a follow-up. As per coding guidelines, `Set changeDetection: ChangeDetectionStrategy.OnPush for all components` and `Prefer input() and output() functions over decorators in Angular components`.\n\n</blockquote></details>\n\n</blockquote></details>\n\n<!-- This is an auto-generated comment by CodeRabbit for review status -->", "referenced_paths": [], "reactions": []}], "response_commits": [], "force_pushes": [], "builds_on_rounds": [], "references_repo_structure": false, "ci_state_at_review": "SUCCESS", "ci_state_after_response": null, "ci_transition": "no_response_commits", "response_commit_diffs": {}, "has_code_backing": false, "head_commit_at_review": "dc2bc54f04f7aadeb1957f1b8dcf6dc9e2ea4fc4", "file_contents_at_review": {}}, {"round_index": 2, "review_state": "APPROVED", "review_author": "sleidig", "submitted_at": "2026-02-16T18:01:49Z", "feedback_type": "body_only", "review_author_association": "MEMBER", "inline_comments": [], "body_comments": [{"body": "Nice. Thanks for the quick fix, @sadaf895  \ud83d\ude42 ", "referenced_paths": [], "reactions": []}], "response_commits": [{"oid": "98d7a614ebad4f71981df87132322bde29fe9600", "message": "Merge branch 'master' into fix/dialog-delete-close", "authoredDate": "2026-02-16T18:01:55Z", "author": {"user": {"login": "sleidig"}, "name": "Sebastian"}, "statusCheckRollup": {"state": "SUCCESS", "contexts": {"nodes": [{"__typename": "CheckRun", "name": "remove-deployment", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:05:32Z", "completedAt": "2026-02-16T18:05:57Z"}, {"__typename": "CheckRun", "name": "qa / code-quality", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:03Z", "completedAt": "2026-02-16T18:03:16Z"}, {"__typename": "CheckRun", "name": "qa / test-unit", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:03Z", "completedAt": "2026-02-16T18:04:15Z"}, {"__typename": "CheckRun", "name": "qa / test-e2e", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:02Z", "completedAt": "2026-02-16T18:04:41Z"}, {"__typename": "CheckRun", "name": "build / build-webapp", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:03Z", "completedAt": "2026-02-16T18:04:10Z"}, {"__typename": "CheckRun", "name": "build / build-image", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:04:14Z", "completedAt": "2026-02-16T18:05:10Z"}, {"__typename": "CheckRun", "name": "deploy", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:05:13Z", "completedAt": "2026-02-16T18:05:23Z"}, {"__typename": "CheckRun", "name": "SonarCloud", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:29Z", "completedAt": "2026-02-16T18:02:31Z"}, {"__typename": "StatusContext", "context": "CodeRabbit", "state": "SUCCESS", "createdAt": "2026-02-16T18:02:05Z"}, {"__typename": "CheckRun", "name": "SonarCloud Code Analysis", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:05Z", "completedAt": "2026-02-16T18:02:27Z"}]}}, "author_type": "human", "agent_commit_signals": [], "ci_state": "SUCCESS", "ci_contexts": [{"__typename": "CheckRun", "name": "remove-deployment", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:05:32Z", "completedAt": "2026-02-16T18:05:57Z"}, {"__typename": "CheckRun", "name": "qa / code-quality", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:03Z", "completedAt": "2026-02-16T18:03:16Z"}, {"__typename": "CheckRun", "name": "qa / test-unit", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:03Z", "completedAt": "2026-02-16T18:04:15Z"}, {"__typename": "CheckRun", "name": "qa / test-e2e", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:02Z", "completedAt": "2026-02-16T18:04:41Z"}, {"__typename": "CheckRun", "name": "build / build-webapp", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:03Z", "completedAt": "2026-02-16T18:04:10Z"}, {"__typename": "CheckRun", "name": "build / build-image", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:04:14Z", "completedAt": "2026-02-16T18:05:10Z"}, {"__typename": "CheckRun", "name": "deploy", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:05:13Z", "completedAt": "2026-02-16T18:05:23Z"}, {"__typename": "CheckRun", "name": "SonarCloud", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:29Z", "completedAt": "2026-02-16T18:02:31Z"}, {"__typename": "StatusContext", "context": "CodeRabbit", "state": "SUCCESS", "createdAt": "2026-02-16T18:02:05Z"}, {"__typename": "CheckRun", "name": "SonarCloud Code Analysis", "conclusion": "SUCCESS", "startedAt": "2026-02-16T18:02:05Z", "completedAt": "2026-02-16T18:02:27Z"}], "ci_failed_checks": [], "ci_test_check_failed": false}], "force_pushes": [], "builds_on_rounds": [], "references_repo_structure": false, "ci_state_at_review": "SUCCESS", "ci_state_after_response": "SUCCESS", "ci_transition": "pass_to_pass", "response_commit_diffs": {"98d7a614ebad4f71981df87132322bde29fe9600": {"e2e/fixtures.ts": [[6, 12]], "e2e/tests/attendance-tests.spec.ts": [[2, 8]], "src/app/app.module.ts": [[74, 80]], "src/app/child-dev-project/children/children-components.ts": [[1, 6]], "src/app/child-dev-project/children/children.service.spec.ts": [[9, 14], [20, 26]], "src/app/child-dev-project/notes/demo-data/demo-note-generator.service.ts": [[7, 13]], "src/app/child-dev-project/notes/model/note.spec.ts": [[5, 11]], "src/app/child-dev-project/notes/model/note.ts": [[25, 35]], "src/app/child-dev-project/notes/notes-components.ts": [[8, 13]], "src/app/child-dev-project/notes/notes-manager/notes-manager.component.spec.ts": [[16, 22]], "src/app/child-dev-project/notes/notes-manager/notes-manager.component.ts": [[9, 15]], "src/app/core/admin/admin-entity-details/admin-entity-field/admin-entity-field.component.spec.ts": [[21, 27]], "src/app/core/basic-datatypes/configurable-enum/configurable-enum-testing.ts": [[10, 15], [23, 28]], "src/app/core/common-components/edit-text-with-autocomplete/edit-text-with-autocomplete.component.spec.ts": [[2, 8]], "src/app/core/common-components/entities-table/entities-table.component.spec.ts": [[108, 126]], "src/app/core/common-components/entities-table/entities-table.component.ts": [[507, 520]], "src/app/core/config/config.service.spec.ts": [[431, 436]], "src/app/core/config/config.service.ts": [[1, 7], [110, 115], [429, 434]], "src/app/core/config/default-config/default-attendance-status-types.ts": [[1, 4]], "src/app/core/demo-data/demo-data.module.ts": [[24, 31]], "src/app/core/entity-list/entity-list/entity-list.component.spec.ts": [[9, 14], [28, 34], [56, 65], [71, 76]], "src/app/core/entity/entity-actions/entity-delete.service.spec.ts": [[16, 22]], "src/app/core/export/data-transformation-service/data-transformation.service.spec.ts": [[7, 13]], "src/app/core/export/query.service.spec.ts": [[6, 18]], "src/app/core/export/query.service.ts": [[1, 12]], "src/app/core/import/additional-actions/import-additional.service.spec.ts": [[5, 11]], "src/app/core/import/additional-actions/import-additional.service.ts": [[12, 18]], "src/app/core/import/import/import-sample-raw-data.ts": [[1, 4]], "src/app/core/permissions/ability/ability.service.spec.ts": [[13, 19]], "src/app/features/attendance/add-day-attendance/activity-card/activity-card.component.spec.ts": [[2, 8]], "src/app/features/attendance/add-day-attendance/activity-card/activity-card.component.ts": [[1, 10]], "src/app/features/attendance/add-day-attendance/activity-card/activity-card.stories.ts": [[1, 9]], "src/app/features/attendance/add-day-attendance/add-day-attendance.component.spec.ts": [[1, 11]], "src/app/features/attendance/add-day-attendance/add-day-attendance.component.ts": [[1, 15]], "src/app/features/attendance/add-day-attendance/attendance-manager/attendance-manager.component.spec.ts": [[2, 8]], "src/app/features/attendance/add-day-attendance/attendance-manager/attendance-manager.component.ts": [[1, 10]], "src/app/features/attendance/add-day-attendance/roll-call-setup/roll-call-setup.component.spec.ts": [[7, 20]], "src/app/features/attendance/add-day-attendance/roll-call-setup/roll-call-setup.component.ts": [[7, 31]], "src/app/features/attendance/add-day-attendance/roll-call-setup/roll-call-setup.stories.ts": [[1, 10]], "src/app/features/attendance/add-day-attendance/roll-call/roll-call-tab/roll-call-tab.component.scss": [[1, 9]], "src/app/features/attendance/add-day-attendance/roll-call/roll-call.component.spec.ts": [[7, 22]], "src/app/features/attendance/add-day-attendance/roll-call/roll-call.component.ts": [[13, 25], [30, 39]], "src/app/features/attendance/add-day-attendance/roll-call/roll-call.stories.ts": [[1, 8]], "src/app/features/attendance/add-default-recurring-activity-views.ts": [[1, 4]], "src/app/features/attendance/analysis/activity-attendance-section/activity-attendance-section.component.spec.ts": [[1, 14]], "src/app/features/attendance/analysis/activity-attendance-section/activity-attendance-section.component.ts": [[7, 20], [22, 33]], "src/app/features/attendance/analysis/activity-attendance-section/activity-attendance-section.stories.ts": [[4, 23]], "src/app/features/attendance/analysis/attendance-calendar/attendance-calendar.component.spec.ts": [[1, 20]], "src/app/features/attendance/analysis/attendance-calendar/attendance-calendar.component.ts": [[7, 35], [42, 48]], "src/app/features/attendance/analysis/attendance-calendar/attendance-calendar.stories.ts": [[1, 10]], "src/app/features/attendance/analysis/attendance-details/attendance-details.component.spec.ts": [[4, 16]], "src/app/features/attendance/analysis/attendance-details/attendance-details.component.ts": [[1, 24]], "src/app/features/attendance/analysis/attendance-details/attendance-details.stories.ts": [[4, 18]], "src/app/features/attendance/analysis/attendance-summary/attendance-summary.component.spec.ts": [[1, 7]], "src/app/features/attendance/analysis/attendance-summary/attendance-summary.component.ts": [[1, 12]], "src/app/features/attendance/analysis/grouped-child-attendance/grouped-child-attendance.component.spec.ts": [[1, 7]], "src/app/features/attendance/analysis/grouped-child-attendance/grouped-child-attendance.component.ts": [[5, 24]], "src/app/features/attendance/attendance-components.ts": [[1, 10], [15, 38], [46, 52]], "src/app/features/attendance/attendance-week-dashboard/attendance-day-block/attendance-day-block.component.ts": [[1, 5]], "src/app/features/attendance/attendance-week-dashboard/attendance-week-dashboard.component.scss": [[1, 4]], "src/app/features/attendance/attendance-week-dashboard/attendance-week-dashboard.component.spec.ts": [[1, 16]], "src/app/features/attendance/attendance-week-dashboard/attendance-week-dashboard.component.ts": [[1, 20]], "src/app/features/attendance/attendance-week-dashboard/attendance-week-dashboard.stories.ts": [[1, 14]], "src/app/features/attendance/attendance.module.ts": [[1, 14]], "src/app/features/attendance/attendance.service.spec.ts": [[1, 20]], "src/app/features/attendance/attendance.service.ts": [[1, 12], [49, 55]], "src/app/features/attendance/demo-data/demo-activity-events-generator.service.spec.ts": [[1, 14]], "src/app/features/attendance/demo-data/demo-activity-events-generator.service.ts": [[1, 9]], "src/app/features/attendance/demo-data/demo-activity-generator.service.spec.ts": [[1, 13]], "src/app/features/attendance/demo-data/demo-activity-generator.service.ts": [[1, 11]], "src/app/features/attendance/deprecated/attendance-block/attendance-block.component.spec.ts": [[1, 8]], "src/app/features/attendance/deprecated/attendance-block/attendance-block.component.ts": [[1, 14]], "src/app/features/attendance/deprecated/attendance-block/attendance-block.stories.ts": [[2, 13]], "src/app/features/attendance/edit-attendance/attendance-status-select/attendance-status-select.component.spec.ts": [[1, 7]], "src/app/features/attendance/edit-attendance/attendance-status-select/attendance-status-select.component.ts": [[3, 14]], "src/app/features/attendance/edit-attendance/attendance-status-select/attendance-status-select.stories.ts": [[1, 7]], "src/app/features/attendance/edit-attendance/edit-attendance.component.spec.ts": [[4, 17]], "src/app/features/attendance/edit-attendance/edit-attendance.component.ts": [[7, 22]], "src/app/features/attendance/model/activity-attendance.spec.ts": [[23, 29]], "src/app/features/attendance/model/activity-attendance.ts": [[1, 12]], "src/app/features/attendance/model/attendance-status.ts": [[1, 4]], "src/app/features/attendance/model/calculate-average-event-attendance.ts": [[1, 4]], "src/app/features/attendance/model/event-attendance.datatype.spec.ts": [[1, 16]], "src/app/features/attendance/model/event-attendance.datatype.ts": [[1, 8]], "src/app/features/attendance/model/event-attendance.ts": [[3, 9]], "src/app/features/attendance/model/event-note.spec.ts": [[16, 26]], "src/app/features/attendance/model/event-note.ts": [[1, 5]], "src/app/features/attendance/model/recurring-activity.spec.ts": [[16, 23]], "src/app/features/attendance/model/recurring-activity.ts": [[1, 12]], "src/app/features/de-duplication/bulk-merge-service.spec.ts": [[12, 18]], "src/app/features/de-duplication/bulk-merge-service.ts": [[7, 13]], "src/app/features/reporting/data-aggregation.service.spec.ts": [[5, 11]], "src/app/features/todos/model/todo.ts": [[1, 6], [77, 83]], "src/assets/base-configs/all-features/Config_CONFIG_ENTITY.json": [[523, 528], [551, 556]], "src/assets/base-configs/education/Config_CONFIG_ENTITY.json": [[434, 439]], "src/assets/base-configs/education/de/Config_CONFIG_ENTITY.json": [[428, 433]], "src/assets/base-configs/education/fr/Config_CONFIG_ENTITY.json": [[428, 433]]}}, "has_code_backing": false, "head_commit_at_review": "dc2bc54f04f7aadeb1957f1b8dcf6dc9e2ea4fc4", "file_contents_at_review": {}}], "threads": [], "agent_threads": [], "pr_review_class": "approved", "compliance": {"total_threads": 0, "resolved": 0, "unresolved": 0, "compliance_rate": 0.0, "compliance_class": "approved_no_threads", "inline_threads": 0, "body_only_threads": 0, "compliance_band": "none", "n_agent_threads": 0}, "linked_issues": [{"number": 3663, "title": "deleting from dialog context menu should close dialog", "body": "**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Go to 'Tasks'\n2. Open a Task's details (opens dialog overlay)\n3. use the three-dot context menu and delete the entity\n4. ... dialog remains open. --> should close the dialog because you are viewing data that has been deleted already\n", "state": "CLOSED", "created_at": "2026-02-12T12:56:35Z", "closed_at": "2026-02-16T18:05:26Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM7pC9jb", "body": ":tada: This issue has been resolved in version 3.70.1-master.2 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.70.1-master.2)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-02-16T18:08:50Z", "updatedAt": "2026-02-16T18:08:50Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM7qmRpr", "body": ":tada: This issue has been resolved in version 3.71.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.71.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-02-20T16:32:45Z", "updatedAt": "2026-02-20T16:32:45Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3675, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": 4.075833333333334, "issue_was_open_at_pr": false, "labels": ["released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}], "has_inline_feedback": true, "feedback_track": "inline", "changed_files": 1, "additions": 11, "deletions": 0, "author_association": "CONTRIBUTOR", "is_cross_repository": false, "files": [{"path": "src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts", "additions": 11, "deletions": 0, "changeType": "MODIFIED", "base_content": "import {\n  Component,\n  EventEmitter,\n  inject,\n  Input,\n  OnChanges,\n  Output,\n  SimpleChanges,\n} from \"@angular/core\";\nimport { Entity } from \"../../entity/model/entity\";\nimport { MatButtonModule } from \"@angular/material/button\";\nimport { FontAwesomeModule } from \"@fortawesome/angular-fontawesome\";\nimport { MatMenuModule } from \"@angular/material/menu\";\nimport { Angulartics2Module } from \"angulartics2\";\nimport { DisableEntityOperationDirective } from \"../../permissions/permission-directive/disable-entity-operation.directive\";\nimport { MatTooltipModule } from \"@angular/material/tooltip\";\nimport { ViewComponentContext } from \"../../ui/abstract-view/view-component-context\";\nimport { EntityActionsMenuService } from \"./entity-actions-menu.service\";\nimport { EntityAction } from \"./entity-action.interface\";\n\n@Component({\n  selector: \"app-entity-actions-menu\",\n  templateUrl: \"./entity-actions-menu.component.html\",\n  styleUrls: [\"./entity-actions-menu.component.scss\"],\n  imports: [\n    MatButtonModule,\n    FontAwesomeModule,\n    MatMenuModule,\n    Angulartics2Module,\n    DisableEntityOperationDirective,\n    MatTooltipModule,\n  ],\n})\nexport class EntityActionsMenuComponent implements OnChanges {\n  private entityActionsMenuService = inject(EntityActionsMenuService);\n  protected viewContext = inject(ViewComponentContext, { optional: true });\n\n  @Input() entity: Entity;\n\n  /**\n   * whether the \"delete\" action will trigger a navigation back to the parent list.\n   * This is useful when the entity is deleted from a fullscreen detail view but not for an overlay.\n   */\n  @Input() navigateOnDelete: boolean = false;\n\n  @Output() actionTriggered = new EventEmitter<string>();\n\n  /**\n   * The actions being displayed as menu items.\n   */\n  actions: EntityAction[];\n\n  /**\n   * Whether some buttons should be displayed directly, outside the three-dot menu in dialog views.\n   */\n  @Input() showExpanded?: boolean;\n\n  async ngOnChanges(changes: SimpleChanges): Promise<void> {\n    if (changes.entity) {\n      await this.filterAvailableActions();\n    }\n  }\n\n  private async filterAvailableActions() {\n    if (!this.entity) {\n      this.actions = [];\n      return;\n    }\n\n    const allActions = await this.entityActionsMenuService.getActionsForSingle(\n      this.entity,\n    );\n    this.actions = allActions;\n  }\n\n  async executeAction(action: EntityAction) {\n    const result = await action.execute(\n      this.entity,\n      this.navigateOnDelete && !this.viewContext?.isDialog,\n    );\n    if (result) {\n      this.actionTriggered.emit(action.action);\n    }\n    setTimeout(() => this.filterAvailableActions());\n  }\n}\n", "head_content": "import {\n  Component,\n  EventEmitter,\n  inject,\n  Input,\n  OnChanges,\n  Output,\n  SimpleChanges,\n} from \"@angular/core\";\nimport { Entity } from \"../../entity/model/entity\";\nimport { MatButtonModule } from \"@angular/material/button\";\nimport { FontAwesomeModule } from \"@fortawesome/angular-fontawesome\";\nimport { MatMenuModule } from \"@angular/material/menu\";\nimport { Angulartics2Module } from \"angulartics2\";\nimport { DisableEntityOperationDirective } from \"../../permissions/permission-directive/disable-entity-operation.directive\";\nimport { MatTooltipModule } from \"@angular/material/tooltip\";\nimport { ViewComponentContext } from \"../../ui/abstract-view/view-component-context\";\nimport { EntityActionsMenuService } from \"./entity-actions-menu.service\";\nimport { EntityAction } from \"./entity-action.interface\";\nimport { MatDialogRef } from \"@angular/material/dialog\";\n\n@Component({\n  selector: \"app-entity-actions-menu\",\n  templateUrl: \"./entity-actions-menu.component.html\",\n  styleUrls: [\"./entity-actions-menu.component.scss\"],\n  imports: [\n    MatButtonModule,\n    FontAwesomeModule,\n    MatMenuModule,\n    Angulartics2Module,\n    DisableEntityOperationDirective,\n    MatTooltipModule,\n  ],\n})\nexport class EntityActionsMenuComponent implements OnChanges {\n  private entityActionsMenuService = inject(EntityActionsMenuService);\n  protected viewContext = inject(ViewComponentContext, { optional: true });\n  private readonly dialogRef = inject(MatDialogRef, { optional: true });\n\n  @Input() entity: Entity;\n\n  /**\n   * whether the \"delete\" action will trigger a navigation back to the parent list.\n   * This is useful when the entity is deleted from a fullscreen detail view but not for an overlay.\n   */\n  @Input() navigateOnDelete: boolean = false;\n\n  @Output() actionTriggered = new EventEmitter<string>();\n\n  /**\n   * The actions being displayed as menu items.\n   */\n  actions: EntityAction[];\n\n  /**\n   * Whether some buttons should be displayed directly, outside the three-dot menu in dialog views.\n   */\n  @Input() showExpanded?: boolean;\n\n  async ngOnChanges(changes: SimpleChanges): Promise<void> {\n    if (changes.entity) {\n      await this.filterAvailableActions();\n    }\n  }\n\n  private async filterAvailableActions() {\n    if (!this.entity) {\n      this.actions = [];\n      return;\n    }\n\n    const allActions = await this.entityActionsMenuService.getActionsForSingle(\n      this.entity,\n    );\n    this.actions = allActions;\n  }\n\n  async executeAction(action: EntityAction) {\n    const result = await action.execute(\n      this.entity,\n      this.navigateOnDelete && !this.viewContext?.isDialog,\n    );\n    if (result) {\n      this.actionTriggered.emit(action.action);\n\n      // Close dialog after successful delete action\n      if (\n        action.action === \"delete\" &&\n        this.viewContext?.isDialog &&\n        this.dialogRef\n      ) {\n        this.dialogRef.close();\n      }\n    }\n    setTimeout(() => this.filterAvailableActions());\n  }\n}\n", "patch": "--- a/src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts\n+++ b/src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts\n@@ -17,6 +17,7 @@\n import { ViewComponentContext } from \"../../ui/abstract-view/view-component-context\";\n import { EntityActionsMenuService } from \"./entity-actions-menu.service\";\n import { EntityAction } from \"./entity-action.interface\";\n+import { MatDialogRef } from \"@angular/material/dialog\";\n \n @Component({\n   selector: \"app-entity-actions-menu\",\n@@ -34,6 +35,7 @@\n export class EntityActionsMenuComponent implements OnChanges {\n   private entityActionsMenuService = inject(EntityActionsMenuService);\n   protected viewContext = inject(ViewComponentContext, { optional: true });\n+  private readonly dialogRef = inject(MatDialogRef, { optional: true });\n \n   @Input() entity: Entity;\n \n@@ -80,6 +82,15 @@\n     );\n     if (result) {\n       this.actionTriggered.emit(action.action);\n+\n+      // Close dialog after successful delete action\n+      if (\n+        action.action === \"delete\" &&\n+        this.viewContext?.isDialog &&\n+        this.dialogRef\n+      ) {\n+        this.dialogRef.close();\n+      }\n     }\n     setTimeout(() => this.filterAvailableActions());\n   }\n"}], "agent_initiated": false, "agent_signals": null, "author_type": "human", "reviewer_types": ["agent", "human", "human"], "interaction_type": "human_agent", "takeover_events": [], "first_human_takeover_ts": null, "merged_with_unresolved": false, "candidate_issues": [], "link_confidence": "explicit", "thread_chains": [], "author_self_reviewed": false, "fully_agent_authored": false, "requested_reviewers": [], "review_request_removed": [], "reviewer_was_requested": false, "merged_by": "sleidig", "merge_commit_oid": "6f5b8b71b0de9d77c4ff61d5d9a8f90f2a24dd40", "merged_by_is_author": false, "maintainer_override": false, "referenced_file_contents": {}, "repo_is_fork": null, "repo_parent": null, "repo_collaborator_count": null, "hours_to_first_review": 0.035, "median_response_latency_hours": null, "reviewer_count": 3, "merged_by_association": null, "n_commits": 3, "n_human_commits": 3, "n_agent_commits": 0, "n_bot_commits": 0, "agent_commit_ratio": 0.0, "repo_metadata": {"full_name": "Aam-Digital/ndb-core", "owner": "Aam-Digital", "name": "ndb-core", "stars": 71, "language": "TypeScript", "license": "gpl-3.0", "topics": [], "description": "Easy-to-use case management web app for NGOs anywhere in the world (Progressive Web App)", "url": "https://github.com/Aam-Digital/ndb-core", "default_branch": "master", "open_issues": 187, "forks": 29, "discovered_via": "license:gpl-3.0 language:TypeScript stars:51..200 created:2008-01-01..2017-01-16 archived:false", "created_at": "2016-03-24T09:51:57Z", "pr_total_count": 2426, "issue_total_count": 1428, "primary_language": "TypeScript", "language_bytes": {}}, "conversation_comments": [{"id": "rest_3908875630", "body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- walkthrough_start -->\n\n<details>\n<summary>\ud83d\udcdd Walkthrough</summary>\n\n## Walkthrough\n\nAdds dialog closure integration to the entity actions menu component. When a delete action succeeds within a dialog context, the MatDialogRef is now closed automatically, preventing users from viewing deleted entity details in an open dialog.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Dialog Closure on Delete** <br> `src/app/core/entity-details/entity-actions-menu/entity-actions-menu.component.ts`|Imports MatDialogRef, injects it as optional private dependency, and closes the dialog when delete action completes successfully within a dialog context.|\n\n## Estimated code review effort\n\n\ud83c\udfaf 1 (Trivial) | \u23f1\ufe0f ~3 minutes\n\n## Suggested labels\n\n`released on `@master``, `released`\n\n## Suggested reviewers\n\n- sleidig\n\n## Poem\n\n> \ud83d\udc30 A hop through dialogs, deletes complete,\n> When entities vanish, closure's so sweet!\n> No lingering windows with ghosts of the past,\n> Dialog dismisses when deletions are cast.\n> Neat! \u2728\n\n</details>\n\n<!-- walkthrough_end -->\n\n\n<!-- pre_merge_checks_walkthrough_start -->\n\n<details>\n<summary>\ud83d\udea5 Pre-merge checks | \u2705 6</summary>\n\n<details>\n<summary>\u2705 Passed checks (6 passed)</summary>\n\n|         Check name         | Status   | Explanation                                                                                                                                                                                                        |\n| :------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n|         Title check        | \u2705 Passed | The title accurately summarizes the main change: closing a task dialog after successful deletion, which aligns perfectly with the PR's primary objective and code changes.                                         |\n|      Description check     | \u2705 Passed | The description includes the required linked issue reference (`#3663`) and follows the template structure, though several PR checklist items remain unchecked including CI checks, manual testing, and unit tests.   |\n|     Linked Issues check    | \u2705 Passed | The code changes directly address issue `#3663` by implementing dialog closure after successful delete actions, matching the requirement to close the dialog when an entity is deleted from within a dialog context. |\n| Out of Scope Changes check | \u2705 Passed | All changes are confined to entity-actions-menu component for dialog management integration during delete actions, directly aligned with the linked issue scope.                                                   |\n|     Docstring Coverage     | \u2705 Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.                                                                                                         |\n|  Merge Conflict Detection  | \u2705 Passed | \u2705 No merge conflicts detected when merging into `master`                                                                                                                                                           |\n\n</details>\n\n<sub>\u270f\ufe0f Tip: You can configure your own custom pre-merge checks in the settings.</sub>\n\n</details>\n\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>\u2728 Finishing touches</summary>\n\n- [ ] <!-- {\"checkboxId\": \"7962f53c-55bc-4827-bfbf-6a18da830691\"} --> \ud83d\udcdd Generate docstrings\n<details>\n<summary>\ud83e\uddea Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Post copyable unit tests in a comment\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `fix/dialog-delete-close`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=Aam-Digital/ndb-core&utm_content=3675)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>\u2764\ufe0f Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrIPR1AGxJcAZvAAeXAwe+IgkkLhoiADWkLTwaCFE6D40fA4MDNKIPtgecSReNOhi8PhYABS2kGYAzABsAOwArACUkJAGAIJ4sPgUXIhotGg+ABwAnM0dBgDK+NgUWZACVBgMsL4BAPTxifhEYEpFJGDBoeGASYQwzqS4K2sbXMxRaTOzkbjYiFz43GSQCoMCgkah0SAAJgADBD6mAYWAAIz1aCIgAsHDRzUxjQAWu1OgBVGwAGS4sFwuG4P222yI6lg2AEGiYzG2XTQzDAABF4PTIh5thhaAIzv0SNtuHlBQ0WkZudJgfBuOJyhwDFAAJLMbheNgYXDINCMWCYUgRU33c5hZC4WDhSIxAqReD5PZJFJvY0ZLKIHJ5AonEqqjAaGZQGwkHyUMi+7bW6QoP3YcJ1er1Wphzpa9YebBKI3WOwbUTRDxIK34KQUeAYZIAYU1JtLiAANJAXhhsIkItJxHX234vJAQRJ4CQAO7t6og4a17LtkGIfAeMd1kckMeThSsdht9DCjtV2vJO3hEEeMH0JAOB34SAAIgAYth1iGe5GtxOH1mNZAAHL4DQyAgi8tYnjAADy3KQVwwz0K+6i9oghoaOYliQcIojiFIyA+BQLCQOWGDROCN4pogBiasmqYNBmXDHCQ/bJPhhHugcCgGiQ/j3Pq2D2H0eT0AmcQJEkf6RrwijYFkXCQf8WDQFE0T7n8ALGkpMQAOTIEoLoeMgFTsckVaUJesitO23wOvaFogqctBAZxNA8R2ZD8QQgZMTZ4TsOosi/lAmFhBQUj0FJAh6lwXSpJQXkhpAY7Gmeon7EQOnOdxvHue2KXGRuYEYMgalYIgfQThBIyRBa1CQBOUTxXQgWQAqiDwCC9ACCQppjv0XBwOE+VlQsHjCSEYSenFKV+bg8ioIxNC0GhBgWJA9YsMwSFsH6aCkMgDhOC4f4PiJ+WjG8PrZLkbqFN5wZlBgD6QIAKAQoDqep7is3VoL1fCeSJeViRxE72lgxoLeEl10IgzUPvWpp1oNQNEJGPgRPes6ORgHhzVgACiBr+V0pTlIgACy7nrTq5TsE9r3YNwVWJgT4izcTIbk5TLDcDTBrox2aCkalSSo+gG7DOUOM8AR/wULNy36MY4BQGQ9D4GjaB4IQpDkFQi07vqnDS/wWGlLhKzyEwShUKo6haDoismFAcCoKgmA4AQxBkMo+usobXBUBO9iOC8LgWwo1sqGomjaLoYCGErpgGIgSzbGg3DcPG4rbDNshHEx2gGTnhOzWAaAk0VYB8cXrN5+XHNV+5LLc7zmiGuqD6dytlhdJqXu61eweHfI6smma0hGF0tC0LpyMCxgu0kIbKBcUQesPZAPj9JAuf3aTXDwNTcvIGT1C8mlouYNeGAiGIyBIQ1xp/O++S8JIYJucwXUULloOMONiZAZpTqn/cGt1ij1w3qgS6fprpS24qIPA4IKp2lrGLfKTAuI8TDC7e+BoCK0BkomY05Ag48xQmXCuzkCL5B8CEMh1BYD8GxvILefAIZ7yKivNqShhYHEQAAbkgBge8Gxx62nvJQAifAEa0GIiZPgQF7R8EgaTZa6FIBdA8GkagD0JEWkGqIS869Sb8DRtxHmctwTbylJFeADAd4l3HJRP8gEx6I30RY/oi1JRMnLA43ebUiALy+EuZaJJ5zIDEYjWgXAADUiJETbHhEYPGKFD6DytueTc44g5RjYUbCm8RHAGE7g+IwisDBO0cWrDWWt+4+3BH7dgAc0BBwOqHeQcgI7KFtjHB28cqnKwNuoAA+vAGeozRy5LoKMlCzh7iVOqbQBgEIBAMGaGiHwUItmNDQMMEgAhERTEaD4REAgxgrJ8PUFZEwSAQlBFshgaI44J2qX7MZEzEBTJyZOWZqtXlDIgNLEgoy2AUFIKMksDAVJzMiHLQFBgADeBgOgPiQLYAAQiEGFdAqaGysKERaD5fCJDCK2VFj5hpCWxfgGFtgSWbzJSQClaKkCQWrDWaeZBGU+GZayx88RaA2FfNyOlHwax1kQPDUsjLcAUBTAKh8QqRUYHcLgLwMqYVyoVSyylyqJmqtakqFUD0tXRB1Yq/VxFSK0GoreRAErGUPgADoYDdS63AnrvVet9cAG1szyIkD0B631PqfUWEsGmei8UIKsWYHw5ImCXLZS7AJEaY0LiJo9e6sNebPWrXVV4HNC040EQTRg8oKa3JpupaNf+WbjI5tWsamspryg5oAFSdugPeSSBCiHdrdR8Eg1J+YgikoQ5YKUuo9TKAMHNiIwwAHF7yeS0ppFSWk3UQjDPJdSNxtK6QLq6QyJVZ7ANMhQcyrQ3WZkgNZAxdkSAOScsmrKNb+JX0ak+3Obq0Rhg0EBxNBVtBcJKmGfQ6ahINomkAj0XUGCawmrIBY6AQSJVyZVagyVLSQFNDIF9WAIb0ESJjWQObw35twMAbYAbaDjJonoB8SrLwoXNZGBw2jECMoANqUo6CijownHzQuiP+TkJBnVFvCGJljAnhMPnmV8HjXB5VWpE2iixl4QkPWk7ZVmw5y4MEWGCKWHTnDwAAF6ANsoVdxpAgjjQgslZSIHzpxRgf6G6RQHrthBvYphiQ+RcNltGMQUsUFMJSrYDKb9Okm1vjhcI36skOekBoeTmnHzMEUFJrgD56oUAwCeLLmmHwgkwX4Igix8tMoMnq7LD5+h8lrIkc1Em2DOsM1JhTABfAVgmFNorE51urD5W3KgSnJwbinlPfEtY18r2nMC6PKPpwxiATUJVrMEfMtnskAEdsDtXBPRpMt4NzRhBOscIFRo21HaN+reHh6G2gM0vXUH8UIKrELV3+CwiBMLCNWHs1QxPlhQigGgzAQJLzAw+9Y9pcXXz2/EdcjZmwwv3J2bs+RgLMXbN+xC9wCcwzKyJh8uWlDOqKyVusFPFOVfKNV2rvL+XDcfC1+kC8PAdck86gs229P9dm0J8ro2BcFYiSRcE9qKJY4tbNtF83VMRF1crx8K3dPrYKwNHp6XZ6VY1fIeCS5740RqHRWo4dD66iXn5dcGDxq1cmukGSvpvM/tUUVdsLxcAbAgilEEx3TvL3+gAp9+UQbqSwLvea4DwTxrqgyNB4M57vuwYztF1Pxt09K5rirogWd8jZ6Shrhfudtb58j8TUvHz0fl9ILofpsiG3KSJgbCnxeU8l11grkE8BmMgLMJg/w1oIz2or7PVLPgLbUxrznD5tdrcegVrR+RolT+cLJkv5B6CeVzpQhufEdw83IHzNhIHOyL2XrWGga9V9xEWJVRPnD9zxGN1LYLwTkEMifedkGvYGPiQJloXrnrTs4PTkQDPkXlVqXiCOzhXkvlXrzvzv3lzngJBD4KPmpPDOIi3jaIgO3qLt3kvn3uNmKgwD9hBOtKDqQLAarotoXiviGM6m4rkG+HopvAsIeGgilFvknq6IApIhIIkN2MUI5NQfKhBEwPQaASPtEMqNwJVHSjQeuHIcoOaGJmAUvkuCuHgHpgVgAOo1iSFqEyFSo8F/S2ScEVzICbR+hB72gJqeRDDiA5DyACFXqLzPrDSjS6FNYQEFb54M6V41g87ta15jaC4WGSpEA8akEiY96KYUHOoUwQrhDrQYB0L2L3AKg0AVyMFz5q7qZLaU6sFGGPiACg5ABPeOCtoSzv4oaM6NhMgn/A0RBPfveAAAYvAoSUA9GwH6F5hsFcBdivbgF5aQHFYF4oERHV7oHjYNEkDZG5FiAd7CZ9aUoAC6rGrwtgk27aa+j4tQjQ5xtQlyiImyEwYwjQtQaAtxaAUIYwaAjQtAYwJATQDAiIXxiI5xAg+yDAAgEItApyoJIJSGEwaAdAtQtQPgtAUItQaIEw9QEwiIZWD4bGuAtgMmzq0JaJUIPgjQiIGyKyEIQJtAzQDxMIUIjxJJYwAgaIjJ9QaAlyZyYwtQEwaIJAaIIozQUI9Q0ItQzQjQoJ5yEwUIAg08jQmJUh6hRAdBWhJAmoXExWiQHwYIjKSK2x2xQKUAvAoKKxUKte3yAKjswymsBAoy3AyGoKym9p8KiygyyKWJBxdptAXQuAn4MytA+K6g60r4uAJKUIep1SVp+ANpdpcKYIoy5p8cQAA -->\n\n<!-- internal state end -->", "createdAt": "2026-02-16T14:45:59Z", "author": {"login": "coderabbitai[bot]"}}, {"id": "rest_3908875859", "body": "Deployed to https://pr-3675.aam-digital.net/", "createdAt": "2026-02-16T14:46:02Z", "author": {"login": "github-actions[bot]"}}, {"id": "rest_3908891658", "body": "**The latest updates on your projects.** Learn more about [Argos notifications \u2197\ufe0e](https://argos-ci.com/docs/notifications)\n\n| Build | Status | Details | Updated (UTC) |\n| :---- | :----- | :------ | :------------ |\n| **default** ([Inspect](https://app.argos-ci.com/sleidig/ndb-core/builds/2317)) | \u2705 No changes detected | - | Feb 16, 2026, 6:04 PM |", "createdAt": "2026-02-16T14:49:32Z", "author": {"login": "argos-ci[bot]"}}, {"id": "rest_3908912470", "body": "@sleidig This bug is also fixed.", "createdAt": "2026-02-16T14:53:14Z", "author": {"login": "sadaf895"}}, {"id": "rest_3909867510", "body": ":tada: This PR is included in version 3.70.1-master.2 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.70.1-master.2)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-02-16T18:08:47Z", "author": {"login": "aam-digital-ci"}}, {"id": "rest_3935899746", "body": ":tada: This PR is included in version 3.71.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.71.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-02-20T16:32:12Z", "author": {"login": "aam-digital-ci"}}]}

Aam-Digital_ndb-core_3845/issues/Aam-Digital_ndb-core_3650.json

@@ -0,0 +1 @@
+{"number": 3650, "title": "Add user account from \"User Account List\" view", "body": "_As a admin I want to create new accounts from the \"Manage User Accounts\" list in order to have an intuitive place to register accounts without having to go to other user profile entities._\n\n**Objective**\n- Add a \"Add New Account\" button above the user management list.\n- When clicked, show a dialog similar/same as the dialog to view details of existing accounts\n- Use the same logic as when creating new account from the \"User Account\" tab shown in the Entity Details of an entity type to create a new account. Allow the admin to select any entity as the linked profile from that place.\n- Make sure to reuse the existing code to create accounts and not create duplicated logic", "state": "CLOSED", "created_at": "2026-02-09T15:15:49Z", "closed_at": "2026-04-22T10:33:49Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM78fOMF", "body": "Suggestions @sleidig @Abhinegi2 \n1.  To link a new profile, I currently have to create it from the \"Users\" section in the main menu. I should also be able to create a new profile under the \"Add New User\" option. At the moment, I'm limited to linking a child entity instead of a user entity.\n\n<img width=\"826\" height=\"369\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/5c28e02e-4eb3-4636-adc2-a858859a5ac7\" />\n\n2. After clicking on \"Create Account and Send Invitation\" the dialogue box should close immediately or let the user know if the process is successful Right now im very confused and have to click on the cancel to close the dialogue box.\n\n3. After clicking on \"Create Account and Send Invitation\" an error message is displayed event though the account is created. \n\n<img width=\"1612\" height=\"698\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/48a13f7b-6d01-4e9c-bb4d-dc20a88887e2\" />", "createdAt": "2026-04-13T11:32:05Z", "updatedAt": "2026-04-13T11:32:05Z", "author": {"login": "george-neha"}}, {"id": "IC_kwDOA0GdQM78hO0r", "body": "> 1. To link a new profile, I currently have to create it from the \"Users\" section in the main menu. I should also be able to create a new profile under the \"Add New User\" option. At the moment, I'm limited to linking a child entity instead of a user entity.\n\nI agree, admins should be able to create a new entity for the new account on this screen also. The permitted entity type(s) can be inferred by scanning the config which have `enableUserAccounts` flag.\n\nIf there is more than one entity type supporting user accounts, our standard edit-entity may not be able to offer a \"Create new XXX\" option yet? But maybe we can extend it to simply offer one \"create new ...\" option for each type?", "createdAt": "2026-04-13T13:02:46Z", "updatedAt": "2026-04-13T13:02:46Z", "author": {"login": "sleidig"}}, {"id": "IC_kwDOA0GdQM7857HY", "body": "Looks good :)", "createdAt": "2026-04-14T10:05:06Z", "updatedAt": "2026-04-14T10:05:06Z", "author": {"login": "george-neha"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM8AAAABAAgToA", "body": ":tada: This issue has been resolved in version 3.77.0-master.6 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.77.0-master.6)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-04-22T10:38:12Z", "updatedAt": "2026-04-22T10:38:12Z", "author": {"login": "aam-digital-ci"}}, {"id": "IC_kwDOA0GdQM8AAAABACbtfw", "body": ":tada: This issue has been resolved in version 3.77.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.77.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-04-22T15:23:04Z", "updatedAt": "2026-04-22T15:23:04Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3845, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released", "Client: by X"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Aam-Digital_ndb-core_3928/issues/Aam-Digital_ndb-core_3927.json

@@ -0,0 +1 @@
+{"number": 3927, "title": "Users from online-only mode are also shown for \"offline login\"", "body": "", "state": "CLOSED", "created_at": "2026-05-06T07:43:06Z", "closed_at": "2026-05-06T11:44:41Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM8AAAABBYbziw", "body": ":tada: This issue has been resolved in version 3.79.1-master.3 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.79.1-master.3)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-05-06T12:01:08Z", "updatedAt": "2026-05-06T12:01:08Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM8AAAABBtNXzw", "body": ":tada: This issue has been resolved in version 3.80.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.80.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2026-05-08T20:06:26Z", "updatedAt": "2026-05-08T20:06:26Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3928, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [], "body_backfilled": true}

Alfanous-team_alfanous_688__unreviewed/issues/Alfanous-team_alfanous_687.json

@@ -0,0 +1 @@
+{"number": 687, "title": "Improve then fuzzy search", "body": "Current implementation is processing in search time , the idea was to keep the exact search for statistical purposes however this is very slow, it is killing the CPU.\n\nNew implementation should be:\n- we keep aya_ field as it is, same process.  we use aya field for fuzzy search\n- `aya` field should be normalized, remove stop words, added synonyms , stemmed in indexing time, no operation in query time\n", "state": "CLOSED", "created_at": "2026-03-05T10:46:29Z", "closed_at": "2026-03-05T12:58:08Z", "author_login": "assem-ch", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 688, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Alfanous-team_alfanous_817__unreviewed/issues/Alfanous-team_alfanous_816.json

@@ -0,0 +1 @@
+{"number": 816, "title": "Show all matching keywords in output keywords", "body": "- for example if you search \u0642\u0627\u0644 in fuzzy mode, should return all variations \n- another example, if you search fire, fire should be in keywords", "state": "CLOSED", "created_at": "2026-03-18T22:48:45Z", "closed_at": "2026-03-18T23:40:47Z", "author_login": "assem-ch", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 817, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

AndBible_and-bible_3521/issues/AndBible_and-bible_3520.json

@@ -0,0 +1 @@
+{"number": 3520, "title": "Crash", "body": "https://support.andbible.org/scp/tickets.php?id=2981\n\n--- PLEASE WRITE YOUR FEEDBACK OR BUG REPORT ABOVE THIS LINE ---\n\nInstructions:\nTell us briefly what did you do / what happened when issue took place.\n\nFor example:\n  1. Opened app\n  2. Clicked window menu\n  -> Crash\n \nPlease use this function to report as soon as you have noticed issue taking place. You can also use this function after opening app, after crash has taken place.\n\nAttachments:\n  - logcat.txt.gz: Log file produced by this app. It does not contain information about any other apps.\n  - screenshot.webp: Screenshot of app when crash took place, or when bug report was created.\n  - last_crash_logcat.txt.gz: Logcat from the last app crash\n  - last_crash_screenshot.webp: Screenshot from the last app crash\n\nHaving these files attached helps app developers a lot in fixing the reported bug. Sometimes manually taken screenshots also are beneficial in resolving issues.\n\nDevice info:\nApp id: net.bible.android.activity\nVersion: 5.0.888#3949112a9 googleplay standard release (31/07/25 17:21:09)\nAndroid version: 15\nAndroid SDK version: 35\nManufacturer: motorola\nHardware: qcom\nProduct: fogo_g\nDevice: fogo\nBrand: motorola\nModel: moto g 5G - 2024\nStorage Mb free: 63668\nWebView version: 138.0.7204.179\nSQLITE version: 3.49.0\nUsed heap memory in Mb: 13\nMax heap memory in Mb: 256\n\n=== LAST APP CRASH INFORMATION ===\nLast crash occurred at: 2025-08-08 23:30:24\nCrash stacktrace:\nnet.bible.android.view.activity.installzip.FileNotFound\nat net.bible.android.view.activity.installzip.InstallZip.installZip$lambda$6(InstallZip.kt:547)\nat net.bible.android.view.activity.installzip.InstallZip.$r8$lambda$G65HLAtpnmW2dLVtSOBkK2zpiLY(InstallZip.kt:0)\nat net.bible.android.view.activity.installzip.InstallZip$$ExternalSyntheticLambda0.invoke(R8$$SyntheticClass:0)\nat net.bible.android.view.activity.installzip.ZipHandler$checkZipFile$2.invokeSuspend(InstallZip.kt:110)\nat kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)\nat kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)\nat kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)\nat kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)\nat kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)\nat kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)\nat kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)\nat kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)\nSuppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@e7f3c88, Dispatchers.Main.immediate]\n\n=== END LAST CRASH INFORMATION ===", "state": "CLOSED", "created_at": "2025-09-18T12:48:45Z", "closed_at": "2025-09-18T13:24:30Z", "author_login": "tuomas2", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 3521, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

AndBible_and-bible_3521/pr.json

@@ -0,0 +1 @@
+{"repo": "AndBible/and-bible", "pr_number": 3521, "pr_title": "Fix FileNotFound crash in InstallZip when opening input streams", "pr_state": "merged", "pr_author": "copilot-swe-agent", "base_branch": "current-stable", "head_branch": "copilot/fix-3520", "created_at": "2025-09-18T12:48:56Z", "merged_at": "2025-09-18T13:24:29Z", "base_ref_oid": "d80826b1d4045cb779f35658e689cf326c324d69", "head_ref_oid": "b4a1a0cedc7c7a6020b502a78d8adadbcb4d8f37", "base_commit": {"oid": "d80826b1d4045cb779f35658e689cf326c324d69", "message": "Increment version to 5.0.896", "authoredDate": "2025-09-18T12:36:16Z", "author": {"name": "Tuomas Airaksinen", "email": "tuomas.airaksinen@gmail.com", "user": {"login": "tuomas2"}}}, "rounds": [{"round_index": 0, "review_state": "APPROVED", "review_author": "tuomas2", "submitted_at": "2025-09-18T13:24:23Z", "feedback_type": "body_only", "review_author_association": "CONTRIBUTOR", "inline_comments": [], "body_comments": [{"body": "Looks OK", "referenced_paths": [], "reactions": []}], "response_commits": [], "force_pushes": [], "builds_on_rounds": [], "references_repo_structure": false, "ci_state_at_review": "SUCCESS", "ci_state_after_response": null, "ci_transition": "no_response_commits", "response_commit_diffs": {}, "has_code_backing": false, "head_commit_at_review": "b4a1a0cedc7c7a6020b502a78d8adadbcb4d8f37", "file_contents_at_review": {}}], "threads": [], "agent_threads": [], "pr_review_class": "approved", "compliance": {"total_threads": 0, "resolved": 0, "unresolved": 0, "compliance_rate": 0.0, "compliance_class": "approved_no_threads", "inline_threads": 0, "body_only_threads": 0, "compliance_band": "none", "n_agent_threads": 0}, "linked_issues": [{"number": 3520, "title": "Crash", "body": "https://support.andbible.org/scp/tickets.php?id=2981\n\n--- PLEASE WRITE YOUR FEEDBACK OR BUG REPORT ABOVE THIS LINE ---\n\nInstructions:\nTell us briefly what did you do / what happened when issue took place.\n\nFor example:\n  1. Opened app\n  2. Clicked window menu\n  -> Crash\n \nPlease use this function to report as soon as you have noticed issue taking place. You can also use this function after opening app, after crash has taken place.\n\nAttachments:\n  - logcat.txt.gz: Log file produced by this app. It does not contain information about any other apps.\n  - screenshot.webp: Screenshot of app when crash took place, or when bug report was created.\n  - last_crash_logcat.txt.gz: Logcat from the last app crash\n  - last_crash_screenshot.webp: Screenshot from the last app crash\n\nHaving these files attached helps app developers a lot in fixing the reported bug. Sometimes manually taken screenshots also are beneficial in resolving issues.\n\nDevice info:\nApp id: net.bible.android.activity\nVersion: 5.0.888#3949112a9 googleplay standard release (31/07/25 17:21:09)\nAndroid version: 15\nAndroid SDK version: 35\nManufacturer: motorola\nHardware: qcom\nProduct: fogo_g\nDevice: fogo\nBrand: motorola\nModel: moto g 5G - 2024\nStorage Mb free: 63668\nWebView version: 138.0.7204.179\nSQLITE version: 3.49.0\nUsed heap memory in Mb: 13\nMax heap memory in Mb: 256\n\n=== LAST APP CRASH INFORMATION ===\nLast crash occurred at: 2025-08-08 23:30:24\nCrash stacktrace:\nnet.bible.android.view.activity.installzip.FileNotFound\nat net.bible.android.view.activity.installzip.InstallZip.installZip$lambda$6(InstallZip.kt:547)\nat net.bible.android.view.activity.installzip.InstallZip.$r8$lambda$G65HLAtpnmW2dLVtSOBkK2zpiLY(InstallZip.kt:0)\nat net.bible.android.view.activity.installzip.InstallZip$$ExternalSyntheticLambda0.invoke(R8$$SyntheticClass:0)\nat net.bible.android.view.activity.installzip.ZipHandler$checkZipFile$2.invokeSuspend(InstallZip.kt:110)\nat kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)\nat kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)\nat kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)\nat kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)\nat kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)\nat kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)\nat kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)\nat kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)\nSuppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@e7f3c88, Dispatchers.Main.immediate]\n\n=== END LAST CRASH INFORMATION ===", "state": "CLOSED", "created_at": "2025-09-18T12:48:45Z", "closed_at": "2025-09-18T13:24:30Z", "author_login": "tuomas2", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 3521, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": 0.0001273148148148148, "issue_was_open_at_pr": false, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}], "has_inline_feedback": false, "feedback_track": "body_only", "changed_files": 1, "additions": 6, "deletions": 0, "author_association": "CONTRIBUTOR", "is_cross_repository": false, "files": [{"path": "app/src/main/java/net/bible/android/view/activity/installzip/InstallZip.kt", "additions": 6, "deletions": 0, "changeType": "MODIFIED", "base_content": "/*\n * Copyright (c) 2020-2022 Martin Denham, Tuomas Airaksinen and the AndBible contributors.\n *\n * This file is part of AndBible: Bible Study (http://github.com/AndBible/and-bible).\n *\n * AndBible is free software: you can redistribute it and/or modify it under the\n * terms of the GNU General Public License as published by the Free Software Foundation,\n * either version 3 of the License, or (at your option) any later version.\n *\n * AndBible is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;\n * without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n * See the GNU General Public License for more details.\n *\n * You should have received a copy of the GNU General Public License along with AndBible.\n * If not, see http://www.gnu.org/licenses/.\n */\n\npackage net.bible.android.view.activity.installzip\n\nimport android.app.Activity\nimport android.app.AlertDialog\nimport android.content.Intent\nimport android.net.Uri\nimport android.os.Bundle\nimport android.provider.OpenableColumns\nimport android.util.Log\nimport android.view.View\nimport androidx.lifecycle.lifecycleScope\nimport kotlinx.coroutines.Dispatchers\nimport kotlinx.coroutines.launch\nimport kotlinx.coroutines.withContext\nimport net.bible.android.SharedConstants\nimport net.bible.android.activity.R\nimport net.bible.android.activity.databinding.ActivityInstallZipBinding\nimport net.bible.android.control.backup.BackupControl\nimport net.bible.android.control.event.ABEventBus\nimport net.bible.android.control.event.ToastEvent\nimport net.bible.android.database.BookmarkDatabase\nimport net.bible.android.view.activity.base.ActivityBase\nimport net.bible.android.view.activity.base.Dialogs\nimport net.bible.android.view.activity.page.MainBibleActivity\nimport net.bible.service.cloudsync.SyncableDatabaseDefinition\nimport net.bible.service.common.ANDBIBLE_BACKUP_MANIFEST_FILENAME\nimport net.bible.service.common.AndBibleAddons\nimport net.bible.service.common.AndBibleBackupManifest\nimport net.bible.service.common.BackupType\nimport net.bible.service.common.CommonUtils\nimport net.bible.service.common.CommonUtils.determineFileType\nimport net.bible.service.common.CommonUtils.unzipInputStream\nimport net.bible.service.db.DatabaseContainer\nimport net.bible.service.db.bookmarksDbStats\nimport net.bible.service.db.importDatabaseFile\nimport net.bible.service.sword.epub.EPUB_OPTIMIZER_VERSION\nimport net.bible.service.sword.epub.EpubBackend\nimport net.bible.service.sword.epub.addManuallyInstalledEpubBooks\nimport net.bible.service.sword.epub.epubInitials\nimport net.bible.service.sword.mybible.addManuallyInstalledMyBibleBooks\nimport net.bible.service.sword.mybible.addMyBibleBook\nimport net.bible.service.sword.mysword.addManuallyInstalledMySwordBooks\nimport net.bible.service.sword.mysword.addMySwordBook\nimport net.bible.service.sword.ttf.addManuallyInstalledTtfBooks\nimport org.crosswire.common.util.NetUtil\nimport org.crosswire.jsword.book.BookException\nimport org.crosswire.jsword.book.Books\nimport org.crosswire.jsword.book.sword.SwordBookDriver\nimport org.crosswire.jsword.book.sword.SwordBookMetaData\nimport org.crosswire.jsword.book.sword.SwordBookPath\nimport org.crosswire.jsword.book.sword.SwordConstants\nimport org.crosswire.jsword.book.sword.SwordGenBook\nimport java.io.File\nimport java.io.FileOutputStream\nimport java.io.IOException\nimport java.io.InputStream\nimport java.util.UUID\nimport java.util.zip.ZipEntry\nimport java.util.zip.ZipInputStream\nimport kotlin.coroutines.resume\nimport kotlin.coroutines.suspendCoroutine\nimport kotlin.math.roundToInt\n\n/**\n * Install SWORD module from a zip file\n *\n * @author Tuomas Airaksinen [tuomas.airaksinen at gmail dot com]\n */\n\nclass InstallZipEvent(val message: String)\n\nclass ModulesExists(val files: List<String>) : Exception()\nclass CantOverwrite(val files: List<String>) : Exception()\n\nclass InvalidModule : Exception()\n\nclass EpubFile : Exception()\n\nconst val TAG = \"InstallZip\"\n\nclass ZipHandler(\n        private val newInputStream: () -> InputStream?,\n        private val updateProgress: (progress: Int) -> Unit,\n        private val finish: (finishResult: Int) -> Unit,\n        private val activity: Activity\n) {\n    private var totalEntries = 0\n\n    private suspend fun checkZipFile() = withContext(Dispatchers.IO) {\n        var modsDirFound = false\n        var modulesFound = false\n        var entry: ZipEntry?\n\n        val targetDirectory = SwordBookPath.getSwordDownloadDir()\n        val zin = ZipInputStream(newInputStream())\n        try {\n            entry = zin.nextEntry\n        } catch (e: IllegalArgumentException) {\n            throw InvalidModule()\n        }\n        val existingFiles = mutableListOf<String>()\n        val otherFiles = mutableListOf<String>()\n\n        while (entry != null) {\n            totalEntries++\n            val name = entry.name.replace('\\\\', '/')\n\n            val targetFile = File(targetDirectory, name)\n            if (!entry.isDirectory && targetFile.exists()) {\n                existingFiles.add(targetFile.relativeTo(targetDirectory).canonicalPath)\n            }\n            if (name.startsWith(SwordConstants.DIR_CONF + \"/\") && name.endsWith(SwordConstants.EXTENSION_CONF))\n                modsDirFound = true\n            else if (name.startsWith(SwordConstants.DIR_CONF + \"/\")) {\n                // Ignore directory\n            } else if (name.startsWith(SwordConstants.DIR_DATA + \"/\")) {\n                modulesFound = true\n            } else if (name.startsWith(\"epub/\") || name.startsWith(\"mysword/\") || name.startsWith(\"mybible/\")) {\n                modulesFound = true\n                modsDirFound = true\n            } else if (name == ANDBIBLE_BACKUP_MANIFEST_FILENAME) {\n            } else {\n                otherFiles.add(name)\n            }\n            entry = zin.nextEntry\n        }\n\n        if(otherFiles.isNotEmpty()) {\n            if(otherFiles.find { it == \"META-INF/container.xml\" } != null) {\n                throw EpubFile()\n            } else {\n                zin.close()\n                throw InvalidModule()\n            }\n        }\n\n        if (!(modsDirFound && modulesFound)) {\n            zin.close()\n            throw InvalidModule()\n        }\n        zin.close()\n        if(existingFiles.isNotEmpty())\n            throw ModulesExists(existingFiles)\n    }\n\n\n    private suspend fun installZipFile() = withContext(Dispatchers.IO) {\n        val confFiles = ArrayList<File>()\n        val targetDirectory = SwordBookPath.getSwordDownloadDir()\n        val errors: MutableList<String> = mutableListOf()\n        ZipInputStream(newInputStream()).use { zIn ->\n            var ze: ZipEntry?\n            var count: Int\n            var entryNum = 0\n            val buffer = ByteArray(8192)\n            ze = zIn.nextEntry\n            while (ze != null) {\n                val name = ze.name.replace('\\\\', '/')\n                if (name == ANDBIBLE_BACKUP_MANIFEST_FILENAME) {\n                    ze = zIn.nextEntry\n                    continue\n                }\n\n                val file = File(targetDirectory, name)\n                if (name.startsWith(SwordConstants.DIR_CONF) && name.endsWith(SwordConstants.EXTENSION_CONF))\n                    confFiles.add(file)\n\n                val dir = if (ze.isDirectory) file else file.parentFile\n\n                if (!dir.isDirectory && !(dir.mkdirs() || dir.isDirectory))\n                    throw IOException()\n\n                if (ze.isDirectory) {\n                    ze = zIn.nextEntry\n                    continue\n                }\n                try {\n                    FileOutputStream(file).use { fOut ->\n                        count = zIn.read(buffer)\n                        while (count != -1) {\n                            fOut.write(buffer, 0, count)\n                            count = zIn.read(buffer)\n                        }\n                    }\n                } catch (e: IOException) {\n                    errors.add(file.name)\n                    Log.e(TAG, \"Error in writing ${file.name}\", e);\n                }\n                onProgressUpdate(++entryNum)\n                ze = zIn.nextEntry\n            }\n            if(errors.isNotEmpty()) {\n                throw CantOverwrite(errors)\n            }\n        }\n        // Load configuration files & register books\n        val bookDriver = SwordBookDriver.instance()\n        for (confFile in confFiles) {\n            val me = SwordBookMetaData(confFile, NetUtil.getURI(targetDirectory))\n            me.driver = bookDriver\n            SwordBookDriver.registerNewBook(me)\n        }\n        addManuallyInstalledMyBibleBooks()\n        addManuallyInstalledMySwordBooks()\n        addManuallyInstalledEpubBooks()\n        addManuallyInstalledTtfBooks()\n    }\n\n    suspend fun execute() = withContext(Dispatchers.Main) {\n        var finishResult = Activity.RESULT_CANCELED\n        var doInstall = false\n\n        var result = try {\n            checkZipFile()\n            doInstall = true\n            InstallResult.OK\n        } catch (e: IOException) {\n            Log.e(TAG, \"Error occurred\", e)\n            InstallResult.ERROR\n        } catch (e: IllegalArgumentException) {\n            InstallResult.INVALID_MODULE\n        } catch (e: InvalidModule) {\n            InstallResult.INVALID_MODULE\n        } catch (e: ModulesExists) {\n            doInstall = suspendCoroutine {\n                AlertDialog.Builder(activity)\n                    .setTitle(R.string.overwrite_files_title)\n                    .setMessage(activity.getString(R.string.overwrite_files, \"\\n\" + e.files.joinToString(\"\\n\")))\n                    .setPositiveButton(R.string.yes) {_, _ -> it.resume(true)}\n                    .setNeutralButton(R.string.cancel) {_, _ -> it.resume(false)}\n                    .setOnCancelListener {_ -> it.resume(false)}\n                    .show()\n            }\n            if(doInstall) InstallResult.OK else InstallResult.CANCEL\n        }\n\n        if(doInstall) {\n            result = try {\n                installZipFile()\n                finishResult = Activity.RESULT_OK\n                InstallResult.OK\n            } catch (e: BookException) {\n                Log.e(TAG, \"Error occurred\", e)\n                InstallResult.ERROR\n            } catch (e: IOException) {\n                Log.e(TAG, \"Error occurred\", e)\n                InstallResult.ERROR\n            } catch (e: CantOverwrite) {\n                suspendCoroutine {\n                    AlertDialog.Builder(activity)\n                        .setTitle(R.string.error_occurred)\n                        .setMessage(\n                            activity.getString(\n                                R.string.could_not_overwrite_files,\n                                \"\\n\" + e.files.joinToString(\"\\n\")\n                            )\n                        )\n                        .setPositiveButton(R.string.okay) {_, _ -> it.resume(InstallResult.IGNORE)}\n                        .setOnCancelListener {_ -> it.resume(InstallResult.IGNORE)}\n                        .show()\n                }\n            }\n        }\n\n        val bus = ABEventBus\n        when (result) {\n            InstallResult.ERROR -> bus.post(ToastEvent(R.string.error_occurred))\n            InstallResult.CANCEL -> bus.post(ToastEvent(R.string.install_zip_canceled))\n            InstallResult.INVALID_MODULE -> bus.post(ToastEvent(R.string.invalid_module))\n            InstallResult.OK -> bus.post(ToastEvent(R.string.install_zip_successfull))\n            InstallResult.IGNORE -> {}\n        }\n        finish(finishResult)\n\n    }\n\n    private suspend fun onProgressUpdate(value: Int)  = withContext(Dispatchers.Main) {\n        val progressNow = (value.toFloat() / totalEntries.toFloat() * 100).roundToInt()\n        updateProgress(progressNow/totalEntries)\n    }\n\n    enum class InstallResult {ERROR, INVALID_MODULE, CANCEL, OK, IGNORE}\n}\n\nopen class InstallZipError: Error()\n\nclass CantRead: InstallZipError()\nclass FileNotFound: InstallZipError()\nclass InvalidFile(val filename: String): InstallZipError()\nclass CantWrite: InstallZipError()\n\nclass InstallZip : ActivityBase() {\n    private lateinit var binding: ActivityInstallZipBinding\n    override fun onCreate(savedInstanceState: Bundle?) {\n        super.onCreate(savedInstanceState)\n        Log.i(TAG, \"Install from Zip starting\")\n        binding = ActivityInstallZipBinding.inflate(layoutInflater)\n        setContentView(binding.root)\n        ABEventBus.register(this)\n        super.buildActivityComponent().inject(this)\n        lifecycleScope.launch {\n            when (intent?.action) {\n                Intent.ACTION_VIEW -> {\n                    val uri = intent.data!!\n                    val mimeType = getMimeType(uri)\n                    val displayName = getDisplayName(uri)\n                    val manifest = AndBibleBackupManifest.fromUri(uri)\n                    if(\n                        // installStudyPads will ask after reading the file (will show stats from db)\n                        manifest?.backupType == BackupType.STUDYPAD_EXPORT\n                        || askIfWantInstall(displayName)\n                    ) {\n                        when (mimeType) {\n                            \"application/epub+zip\" -> installEpub(uri, displayName)\n                            \"font/ttf\", \"application/x-font-ttf\" -> installTtf(uri, displayName)\n                            else -> installZip(uri, displayName)\n                        }\n                    } else {\n                        finish()\n                    }\n                }\n                Intent.ACTION_SEND -> {\n                    val uri = intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM)!!\n                    val displayName = getDisplayName(uri) ?: UUID.randomUUID().toString()\n                    installZip(uri, displayName)\n                }\n                Intent.ACTION_SEND_MULTIPLE -> {\n                    for (uri in intent.getParcelableArrayListExtra<Uri>(Intent.EXTRA_STREAM)!!) {\n                        val displayName = getDisplayName(uri) ?: UUID.randomUUID().toString()\n                        installZip(uri, displayName)\n                    }\n                }\n                else -> {\n                    getFileFromUserAndInstall()\n                }\n            }\n        }\n    }\n\n    private suspend fun askIfWantInstall(displayName: String?): Boolean {\n        val q = getString(R.string.install_do_you_want, displayName?: \"?\")\n        return Dialogs.simpleQuestion(this@InstallZip, q)\n    }\n\n    override fun onDestroy() {\n        ABEventBus.unregister(this)\n        super.onDestroy()\n    }\n\n    private suspend fun getFileFromUserAndInstall() {\n        val proceed = suspendCoroutine {\n            val zip = getString(R.string.format_zip, getString(R.string.app_name_andbible))\n            val myBible = getString(R.string.format_mybible)\n            val mySword = getString(R.string.format_mysword)\n            val epub = getString(R.string.format_epub)\n            val studyPads = getString(R.string.format_studypads)\n            val ttf = getString(R.string.format_ttf)\n            val formats = getString(R.string.choose_file, getString(R.string.app_name_andbible)) + \" \\n\\n\" + getString(R.string.supported_formats, \"$zip, $myBible, $mySword, $epub, $ttf, $studyPads\")\n\n            AlertDialog.Builder(this@InstallZip)\n                .setTitle(R.string.install_zip)\n                .setMessage(formats)\n                .setPositiveButton(R.string.proceed) { dialog, which ->\n                    it.resume(true)\n                }\n                .setNeutralButton(R.string.cancel){ _, _ ->\n                    it.resume(false)\n                }\n                .setOnCancelListener {_ -> it.resume(false)}\n                .show()\n        }\n\n        if(!proceed) {\n            finish()\n            return\n        }\n\n        val intent = Intent(Intent.ACTION_OPEN_DOCUMENT)\n        intent.type = \"*/*\"\n        intent.putExtra(Intent.EXTRA_MIME_TYPES, arrayOf(\n            \"application/zip\",\n            \"application/x-zip-compressed\",\n            \"application/epub+zip\",\n            \"application/x-font-ttf\",\n            \"font/ttf\",\n            \"font/otf\",\n            \"application/x-font-ttf\",\n            \"application/x-font-otf\"\n        ))\n        val result = awaitIntent(intent)\n        if (result.resultCode == Activity.RESULT_OK) {\n            val uri = result.data!!.data!!\n            val displayName = getDisplayName(uri) ?: UUID.randomUUID().toString()\n            val mimeType = getMimeType(uri)\n\n            try {\n                installFromFile(uri, displayName, mimeType)\n            } catch (e: InstallZipError) {\n                Log.e(TAG, \"Error occurred in installing module\", e)\n                val msg = when(e) {\n                    is CantRead -> getString(R.string.sqlite_cant_read)\n                    is FileNotFound -> getString(R.string.sqlite_cant_read)\n                    is InvalidFile -> getString(R.string.sqlite_invalid_file, e.filename)\n                    is CantWrite -> getString(R.string.sqlite_cant_write)\n                    else -> throw RuntimeException(e)\n                }\n                suspendCoroutine {\n                    AlertDialog.Builder(this@InstallZip)\n                        .setTitle(R.string.error_occurred)\n                        .setMessage(getString(R.string.install_failed_reason, msg))\n                        .setPositiveButton(R.string.okay) { dialog, which ->\n                            it.resume(true)\n                        }\n                        .setOnCancelListener {_ -> it.resume(false)}\n                        .show()\n                }\n            }\n        }\n        finish()\n    }\n\n    enum class FileType {\n        MYBIBLE, MYSWORD, TTF;\n        val displayName get () = name.lowercase()\n    }\n\n    private fun getDisplayName(uri: Uri): String? =\n        contentResolver.query(uri, null, null, null, null)?.use {\n            if (it.isLast) return null;\n            it.moveToFirst()\n            val displayNameIdx = it.getColumnIndex(OpenableColumns.DISPLAY_NAME)\n            if(displayNameIdx < 0) null else it.getString(displayNameIdx)\n        }\n\n    private fun getMimeType(uri: Uri): String? =\n        contentResolver.query(uri, null, null, null, null)?.use {\n            if (it.isLast) return null;\n            it.moveToFirst()\n            val mimeTypeIdx = it.getColumnIndex(\"mime_type\")\n            if(mimeTypeIdx < 0) null else it.getString(mimeTypeIdx)\n        }\n\n    private suspend fun installFromFile(uri: Uri, displayName: String, mimeType: String?): Boolean {\n        if(mimeType == \"application/epub+zip\") {\n            return installEpub(uri, displayName)\n        }\n\n        // Check for TTF files first\n        if(displayName.lowercase().endsWith(\".ttf\") || mimeType?.contains(\"font\") == true) {\n            return installTtf(uri, displayName)\n        }\n\n        val fileTypeFromContent = determineFileType(uri)\n\n        if (fileTypeFromContent == BackupControl.AbDbFileType.ZIP) {\n            return installZip(uri, displayName)\n        }\n\n        if(fileTypeFromContent != BackupControl.AbDbFileType.SQLITE3) {\n            throw InvalidFile(displayName)\n        }\n\n        val filetype = when {\n            displayName.lowercase().endsWith(\".sqlite3\") -> FileType.MYBIBLE\n            displayName.lowercase().endsWith(\".mybible\") -> FileType.MYSWORD\n            else -> throw InvalidFile(displayName)\n        }\n\n        binding.loadingIndicator.visibility = View.VISIBLE\n        try {\n            val inputStream = contentResolver.openInputStream(uri) ?: throw FileNotFound()\n            inputStream.use { fIn ->\n                val outDir = File(SharedConstants.modulesDir, filetype.displayName)\n                outDir.mkdirs()\n                val outFile = File(outDir, displayName)\n                if (outFile.exists()) {\n                    val doInstall = suspendCoroutine {\n                        AlertDialog.Builder(this)\n                            .setTitle(R.string.overwrite_files_title)\n                            .setMessage(getString(R.string.overwrite_files, \"$filetype/$displayName\"))\n                            .setPositiveButton(R.string.yes) { _, _ -> it.resume(true) }\n                            .setNeutralButton(R.string.cancel) { _, _ -> it.resume(false) }\n                            .setOnCancelListener { _ -> it.resume(false) }\n                            .show()\n                    }\n                    if (!doInstall) {\n                        ABEventBus.post(ToastEvent(R.string.install_zip_canceled))\n                        return false\n                    }\n                }\n\n                if ((outFile.exists() && !outFile.canWrite()) || (!outFile.exists() && !outDir.canWrite())) {\n                    throw CantWrite()\n                }\n\n                withContext(Dispatchers.IO) {\n                    val header = ByteArray(16)\n                    fIn.read(header)\n                    if (String(header) == \"SQLite format 3\\u0000\") {\n                        val out = FileOutputStream(outFile)\n                        withContext(Dispatchers.IO) {\n                            out.write(header)\n                            fIn.copyTo(out)\n                            out.close()\n                        }\n                        val book = when (filetype) {\n                            FileType.MYBIBLE -> addMyBibleBook(outFile)\n                            FileType.MYSWORD -> addMySwordBook(outFile)\n                            else -> throw InvalidFile(displayName)\n                        }\n                        if (book == null) {\n                            outFile.delete()\n                            throw InvalidFile(displayName)\n                        }\n                    } else {\n                        throw InvalidFile(displayName)\n                    }\n                }\n            }\n        } catch (e: IOException) {\n            binding.loadingIndicator.visibility = View.GONE\n            Log.e(TAG, \"IOException when reading file\", e)\n            throw FileNotFound()\n        }\n        binding.loadingIndicator.visibility = View.GONE\n        ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n        ABEventBus.post(MainBibleActivity.UpdateMainBibleActivityDocuments())\n        setResult(RESULT_OK)\n        finish()\n        return true\n    }\n\n    private suspend fun installTtf(uri: Uri, displayName_: String?): Boolean = withContext(Dispatchers.IO) {\n        val displayName = displayName_ ?: UUID.randomUUID().toString()\n        withContext(Dispatchers.Main) {\n            binding.loadingIndicator.visibility = View.VISIBLE\n        }\n        \n        try {\n            val inputStream = contentResolver.openInputStream(uri) ?: throw FileNotFound()\n            inputStream.use { fIn ->\n                val outDir = File(SharedConstants.modulesDir, \"ttf\")\n                outDir.mkdirs()\n                val outFile = File(outDir, displayName)\n                \n                if (outFile.exists()) {\n                    val doInstall = withContext(Dispatchers.Main) {\n                        suspendCoroutine {\n                            AlertDialog.Builder(this@InstallZip)\n                                .setTitle(R.string.overwrite_files_title)\n                                .setMessage(getString(R.string.overwrite_files, \"ttf/$displayName\"))\n                                .setPositiveButton(R.string.yes) { _, _ -> it.resume(true) }\n                                .setNeutralButton(R.string.cancel) { _, _ -> it.resume(false) }\n                                .setOnCancelListener { _ -> it.resume(false) }\n                                .show()\n                        }\n                    }\n                    if (!doInstall) {\n                        withContext(Dispatchers.Main) {\n                            ABEventBus.post(ToastEvent(R.string.install_zip_canceled))\n                            binding.loadingIndicator.visibility = View.GONE\n                        }\n                        return@withContext false\n                    }\n                }\n\n                if ((outFile.exists() && !outFile.canWrite()) || (!outFile.exists() && !outDir.canWrite())) {\n                    throw CantWrite()\n                }\n\n                withContext(Dispatchers.IO) {\n                    val out = FileOutputStream(outFile)\n                    fIn.copyTo(out)\n                    out.close()\n                }\n            }\n        } catch (e: IOException) {\n            Log.e(TAG, \"IOException when reading TTF file\", e)\n            withContext(Dispatchers.Main) {\n                binding.loadingIndicator.visibility = View.GONE\n            }\n            throw FileNotFound()\n        }\n\n        addManuallyInstalledTtfBooks()\n\n        withContext(Dispatchers.Main) {\n            binding.loadingIndicator.visibility = View.GONE\n            ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n            AndBibleAddons.clearCaches()\n            setResult(RESULT_OK)\n            finish()\n        }\n        true\n    }\n\n\n    private suspend fun installZip(uri: Uri, displayName: String?): Boolean {\n        var result = false\n        binding.installZipLabel.text = getString(R.string.checking_zip_file)\n        binding.loadingIndicator.visibility = View.VISIBLE\n        val manifest = AndBibleBackupManifest.fromUri(uri)\n        if (manifest?.backupType == BackupType.STUDYPAD_EXPORT) {\n            result = installStudyPads(uri)\n            finish()\n        } else {\n            val zh = ZipHandler(\n                {\n                    try {\n                        contentResolver.openInputStream(uri) ?: throw FileNotFound()\n                    } catch (e: Exception) {\n                        Log.e(TAG, \"Error opening input stream for zip file\", e)\n                        throw FileNotFound()\n                    }\n                },\n                { percent -> updateProgress(percent) },\n                { finishResult ->\n                    result = finishResult == RESULT_OK\n                    setResult(finishResult);\n                    ABEventBus.post(MainBibleActivity.UpdateMainBibleActivityDocuments())\n                    finish()\n                },\n                this\n            )\n\n            try {\n                zh.execute()\n            } catch (e: EpubFile) {\n                installEpub(uri, displayName)\n                finish()\n            }\n        }\n        binding.loadingIndicator.visibility = View.GONE\n        if (result) {\n            ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n        }\n        return result\n    }\n\n    private suspend fun installStudyPads(uri: Uri): Boolean {\n        val inputStream = try {\n            contentResolver.openInputStream(uri) ?: throw FileNotFound()\n        } catch (e: Exception) {\n            Log.e(TAG, \"Error opening input stream for study pads\", e)\n            throw FileNotFound()\n        }\n        val category = SyncableDatabaseDefinition.BOOKMARKS\n        val unzipFolder = File(BackupControl.internalDbBackupDir, \"unzip\")\n        unzipInputStream(inputStream, unzipFolder)\n        val file = File(unzipFolder, \"db/${BookmarkDatabase.dbFileName}\")\n        val stats = bookmarksDbStats(category, file)\n        val result = Dialogs.simpleQuestion(this@InstallZip, getString(R.string.install_do_you_want, stats))\n        if (!result) {\n            unzipFolder.deleteRecursively()\n            return false\n        }\n        importDatabaseFile(category, file)\n        unzipFolder.deleteRecursively()\n        return true\n    }\n\n    fun onEventMainThread(e: InstallZipEvent) {\n        binding.statusText.text = e.message\n    }\n\n    private val bookmarksDao get() = DatabaseContainer.instance.bookmarkDb.bookmarkDao()\n\n    private suspend fun installEpub(uri: Uri, displayName_: String?): Boolean = withContext(Dispatchers.IO) {\n        val displayName = displayName_ ?: UUID.randomUUID().toString()\n        withContext(Dispatchers.Main) {\n            binding.loadingIndicator.visibility = View.VISIBLE\n        }\n        val dir = File(SharedConstants.modulesDir, \"epub/$displayName\")\n        if (dir.exists()) {\n            val initials = epubInitials(displayName)\n            val book = Books.installed().getBook(initials)\n            val optimizerVersion = ((book as? SwordGenBook)?.backend as? EpubBackend)?.state?.optimizerVersion ?: 1\n            if(DatabaseContainer.ready && bookmarksDao.genericBookmarkCountFor(initials) > 0 && optimizerVersion < EPUB_OPTIMIZER_VERSION) {\n                if(CommonUtils.documentUpgradeConfirmation(this@InstallZip)) {\n                    dir.deleteRecursively()\n                } else {\n                    finish()\n                    return@withContext false\n                }\n            } else {\n                dir.deleteRecursively()\n            }\n        }\n        dir.mkdirs()\n        try {\n            val inputStream = contentResolver.openInputStream(uri) ?: throw FileNotFound()\n            unzipInputStream(inputStream, dir)\n        } catch (e: Exception) {\n            Log.e(TAG, \"Error opening input stream for epub\", e)\n            throw FileNotFound()\n        }\n        val installOk = addManuallyInstalledEpubBooks()\n        withContext(Dispatchers.Main) {\n            if(installOk) {\n                ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n            } else {\n                Dialogs.showMsg2(this@InstallZip,\n                    application.getString(R.string.sqlite_invalid_file, displayName)\n                )\n            }\n            binding.loadingIndicator.visibility = View.GONE\n            finish()\n        }\n        true\n    }\n\n    override fun onBackPressed() {}\n\n    private fun updateProgress(percentValue: Int) {\n        if (percentValue == 1)\n            binding.installZipLabel.text = getString(R.string.extracting_zip_file)\n\n        binding.progressBar.progress = percentValue\n    }\n}\n", "head_content": "/*\n * Copyright (c) 2020-2022 Martin Denham, Tuomas Airaksinen and the AndBible contributors.\n *\n * This file is part of AndBible: Bible Study (http://github.com/AndBible/and-bible).\n *\n * AndBible is free software: you can redistribute it and/or modify it under the\n * terms of the GNU General Public License as published by the Free Software Foundation,\n * either version 3 of the License, or (at your option) any later version.\n *\n * AndBible is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;\n * without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n * See the GNU General Public License for more details.\n *\n * You should have received a copy of the GNU General Public License along with AndBible.\n * If not, see http://www.gnu.org/licenses/.\n */\n\npackage net.bible.android.view.activity.installzip\n\nimport android.app.Activity\nimport android.app.AlertDialog\nimport android.content.Intent\nimport android.net.Uri\nimport android.os.Bundle\nimport android.provider.OpenableColumns\nimport android.util.Log\nimport android.view.View\nimport androidx.lifecycle.lifecycleScope\nimport kotlinx.coroutines.Dispatchers\nimport kotlinx.coroutines.launch\nimport kotlinx.coroutines.withContext\nimport net.bible.android.SharedConstants\nimport net.bible.android.activity.R\nimport net.bible.android.activity.databinding.ActivityInstallZipBinding\nimport net.bible.android.control.backup.BackupControl\nimport net.bible.android.control.event.ABEventBus\nimport net.bible.android.control.event.ToastEvent\nimport net.bible.android.database.BookmarkDatabase\nimport net.bible.android.view.activity.base.ActivityBase\nimport net.bible.android.view.activity.base.Dialogs\nimport net.bible.android.view.activity.page.MainBibleActivity\nimport net.bible.service.cloudsync.SyncableDatabaseDefinition\nimport net.bible.service.common.ANDBIBLE_BACKUP_MANIFEST_FILENAME\nimport net.bible.service.common.AndBibleAddons\nimport net.bible.service.common.AndBibleBackupManifest\nimport net.bible.service.common.BackupType\nimport net.bible.service.common.CommonUtils\nimport net.bible.service.common.CommonUtils.determineFileType\nimport net.bible.service.common.CommonUtils.unzipInputStream\nimport net.bible.service.db.DatabaseContainer\nimport net.bible.service.db.bookmarksDbStats\nimport net.bible.service.db.importDatabaseFile\nimport net.bible.service.sword.epub.EPUB_OPTIMIZER_VERSION\nimport net.bible.service.sword.epub.EpubBackend\nimport net.bible.service.sword.epub.addManuallyInstalledEpubBooks\nimport net.bible.service.sword.epub.epubInitials\nimport net.bible.service.sword.mybible.addManuallyInstalledMyBibleBooks\nimport net.bible.service.sword.mybible.addMyBibleBook\nimport net.bible.service.sword.mysword.addManuallyInstalledMySwordBooks\nimport net.bible.service.sword.mysword.addMySwordBook\nimport net.bible.service.sword.ttf.addManuallyInstalledTtfBooks\nimport org.crosswire.common.util.NetUtil\nimport org.crosswire.jsword.book.BookException\nimport org.crosswire.jsword.book.Books\nimport org.crosswire.jsword.book.sword.SwordBookDriver\nimport org.crosswire.jsword.book.sword.SwordBookMetaData\nimport org.crosswire.jsword.book.sword.SwordBookPath\nimport org.crosswire.jsword.book.sword.SwordConstants\nimport org.crosswire.jsword.book.sword.SwordGenBook\nimport java.io.File\nimport java.io.FileOutputStream\nimport java.io.IOException\nimport java.io.InputStream\nimport java.util.UUID\nimport java.util.zip.ZipEntry\nimport java.util.zip.ZipInputStream\nimport kotlin.coroutines.resume\nimport kotlin.coroutines.suspendCoroutine\nimport kotlin.math.roundToInt\n\n/**\n * Install SWORD module from a zip file\n *\n * @author Tuomas Airaksinen [tuomas.airaksinen at gmail dot com]\n */\n\nclass InstallZipEvent(val message: String)\n\nclass ModulesExists(val files: List<String>) : Exception()\nclass CantOverwrite(val files: List<String>) : Exception()\n\nclass InvalidModule : Exception()\n\nclass EpubFile : Exception()\n\nconst val TAG = \"InstallZip\"\n\nclass ZipHandler(\n        private val newInputStream: () -> InputStream?,\n        private val updateProgress: (progress: Int) -> Unit,\n        private val finish: (finishResult: Int) -> Unit,\n        private val activity: Activity\n) {\n    private var totalEntries = 0\n\n    private suspend fun checkZipFile() = withContext(Dispatchers.IO) {\n        var modsDirFound = false\n        var modulesFound = false\n        var entry: ZipEntry?\n\n        val targetDirectory = SwordBookPath.getSwordDownloadDir()\n        val zin = ZipInputStream(newInputStream())\n        try {\n            entry = zin.nextEntry\n        } catch (e: IllegalArgumentException) {\n            throw InvalidModule()\n        }\n        val existingFiles = mutableListOf<String>()\n        val otherFiles = mutableListOf<String>()\n\n        while (entry != null) {\n            totalEntries++\n            val name = entry.name.replace('\\\\', '/')\n\n            val targetFile = File(targetDirectory, name)\n            if (!entry.isDirectory && targetFile.exists()) {\n                existingFiles.add(targetFile.relativeTo(targetDirectory).canonicalPath)\n            }\n            if (name.startsWith(SwordConstants.DIR_CONF + \"/\") && name.endsWith(SwordConstants.EXTENSION_CONF))\n                modsDirFound = true\n            else if (name.startsWith(SwordConstants.DIR_CONF + \"/\")) {\n                // Ignore directory\n            } else if (name.startsWith(SwordConstants.DIR_DATA + \"/\")) {\n                modulesFound = true\n            } else if (name.startsWith(\"epub/\") || name.startsWith(\"mysword/\") || name.startsWith(\"mybible/\")) {\n                modulesFound = true\n                modsDirFound = true\n            } else if (name == ANDBIBLE_BACKUP_MANIFEST_FILENAME) {\n            } else {\n                otherFiles.add(name)\n            }\n            entry = zin.nextEntry\n        }\n\n        if(otherFiles.isNotEmpty()) {\n            if(otherFiles.find { it == \"META-INF/container.xml\" } != null) {\n                throw EpubFile()\n            } else {\n                zin.close()\n                throw InvalidModule()\n            }\n        }\n\n        if (!(modsDirFound && modulesFound)) {\n            zin.close()\n            throw InvalidModule()\n        }\n        zin.close()\n        if(existingFiles.isNotEmpty())\n            throw ModulesExists(existingFiles)\n    }\n\n\n    private suspend fun installZipFile() = withContext(Dispatchers.IO) {\n        val confFiles = ArrayList<File>()\n        val targetDirectory = SwordBookPath.getSwordDownloadDir()\n        val errors: MutableList<String> = mutableListOf()\n        ZipInputStream(newInputStream()).use { zIn ->\n            var ze: ZipEntry?\n            var count: Int\n            var entryNum = 0\n            val buffer = ByteArray(8192)\n            ze = zIn.nextEntry\n            while (ze != null) {\n                val name = ze.name.replace('\\\\', '/')\n                if (name == ANDBIBLE_BACKUP_MANIFEST_FILENAME) {\n                    ze = zIn.nextEntry\n                    continue\n                }\n\n                val file = File(targetDirectory, name)\n                if (name.startsWith(SwordConstants.DIR_CONF) && name.endsWith(SwordConstants.EXTENSION_CONF))\n                    confFiles.add(file)\n\n                val dir = if (ze.isDirectory) file else file.parentFile\n\n                if (!dir.isDirectory && !(dir.mkdirs() || dir.isDirectory))\n                    throw IOException()\n\n                if (ze.isDirectory) {\n                    ze = zIn.nextEntry\n                    continue\n                }\n                try {\n                    FileOutputStream(file).use { fOut ->\n                        count = zIn.read(buffer)\n                        while (count != -1) {\n                            fOut.write(buffer, 0, count)\n                            count = zIn.read(buffer)\n                        }\n                    }\n                } catch (e: IOException) {\n                    errors.add(file.name)\n                    Log.e(TAG, \"Error in writing ${file.name}\", e);\n                }\n                onProgressUpdate(++entryNum)\n                ze = zIn.nextEntry\n            }\n            if(errors.isNotEmpty()) {\n                throw CantOverwrite(errors)\n            }\n        }\n        // Load configuration files & register books\n        val bookDriver = SwordBookDriver.instance()\n        for (confFile in confFiles) {\n            val me = SwordBookMetaData(confFile, NetUtil.getURI(targetDirectory))\n            me.driver = bookDriver\n            SwordBookDriver.registerNewBook(me)\n        }\n        addManuallyInstalledMyBibleBooks()\n        addManuallyInstalledMySwordBooks()\n        addManuallyInstalledEpubBooks()\n        addManuallyInstalledTtfBooks()\n    }\n\n    suspend fun execute() = withContext(Dispatchers.Main) {\n        var finishResult = Activity.RESULT_CANCELED\n        var doInstall = false\n\n        var result = try {\n            checkZipFile()\n            doInstall = true\n            InstallResult.OK\n        } catch (e: IOException) {\n            Log.e(TAG, \"Error occurred\", e)\n            InstallResult.ERROR\n        } catch (e: IllegalArgumentException) {\n            InstallResult.INVALID_MODULE\n        } catch (e: InvalidModule) {\n            InstallResult.INVALID_MODULE\n        } catch (e: FileNotFound) {\n            Log.e(TAG, \"File not found or could not be opened\", e)\n            InstallResult.ERROR\n        } catch (e: ModulesExists) {\n            doInstall = suspendCoroutine {\n                AlertDialog.Builder(activity)\n                    .setTitle(R.string.overwrite_files_title)\n                    .setMessage(activity.getString(R.string.overwrite_files, \"\\n\" + e.files.joinToString(\"\\n\")))\n                    .setPositiveButton(R.string.yes) {_, _ -> it.resume(true)}\n                    .setNeutralButton(R.string.cancel) {_, _ -> it.resume(false)}\n                    .setOnCancelListener {_ -> it.resume(false)}\n                    .show()\n            }\n            if(doInstall) InstallResult.OK else InstallResult.CANCEL\n        }\n\n        if(doInstall) {\n            result = try {\n                installZipFile()\n                finishResult = Activity.RESULT_OK\n                InstallResult.OK\n            } catch (e: BookException) {\n                Log.e(TAG, \"Error occurred\", e)\n                InstallResult.ERROR\n            } catch (e: IOException) {\n                Log.e(TAG, \"Error occurred\", e)\n                InstallResult.ERROR\n            } catch (e: FileNotFound) {\n                Log.e(TAG, \"File not found or could not be opened during installation\", e)\n                InstallResult.ERROR\n            } catch (e: CantOverwrite) {\n                suspendCoroutine {\n                    AlertDialog.Builder(activity)\n                        .setTitle(R.string.error_occurred)\n                        .setMessage(\n                            activity.getString(\n                                R.string.could_not_overwrite_files,\n                                \"\\n\" + e.files.joinToString(\"\\n\")\n                            )\n                        )\n                        .setPositiveButton(R.string.okay) {_, _ -> it.resume(InstallResult.IGNORE)}\n                        .setOnCancelListener {_ -> it.resume(InstallResult.IGNORE)}\n                        .show()\n                }\n            }\n        }\n\n        val bus = ABEventBus\n        when (result) {\n            InstallResult.ERROR -> bus.post(ToastEvent(R.string.error_occurred))\n            InstallResult.CANCEL -> bus.post(ToastEvent(R.string.install_zip_canceled))\n            InstallResult.INVALID_MODULE -> bus.post(ToastEvent(R.string.invalid_module))\n            InstallResult.OK -> bus.post(ToastEvent(R.string.install_zip_successfull))\n            InstallResult.IGNORE -> {}\n        }\n        finish(finishResult)\n\n    }\n\n    private suspend fun onProgressUpdate(value: Int)  = withContext(Dispatchers.Main) {\n        val progressNow = (value.toFloat() / totalEntries.toFloat() * 100).roundToInt()\n        updateProgress(progressNow/totalEntries)\n    }\n\n    enum class InstallResult {ERROR, INVALID_MODULE, CANCEL, OK, IGNORE}\n}\n\nopen class InstallZipError: Error()\n\nclass CantRead: InstallZipError()\nclass FileNotFound: InstallZipError()\nclass InvalidFile(val filename: String): InstallZipError()\nclass CantWrite: InstallZipError()\n\nclass InstallZip : ActivityBase() {\n    private lateinit var binding: ActivityInstallZipBinding\n    override fun onCreate(savedInstanceState: Bundle?) {\n        super.onCreate(savedInstanceState)\n        Log.i(TAG, \"Install from Zip starting\")\n        binding = ActivityInstallZipBinding.inflate(layoutInflater)\n        setContentView(binding.root)\n        ABEventBus.register(this)\n        super.buildActivityComponent().inject(this)\n        lifecycleScope.launch {\n            when (intent?.action) {\n                Intent.ACTION_VIEW -> {\n                    val uri = intent.data!!\n                    val mimeType = getMimeType(uri)\n                    val displayName = getDisplayName(uri)\n                    val manifest = AndBibleBackupManifest.fromUri(uri)\n                    if(\n                        // installStudyPads will ask after reading the file (will show stats from db)\n                        manifest?.backupType == BackupType.STUDYPAD_EXPORT\n                        || askIfWantInstall(displayName)\n                    ) {\n                        when (mimeType) {\n                            \"application/epub+zip\" -> installEpub(uri, displayName)\n                            \"font/ttf\", \"application/x-font-ttf\" -> installTtf(uri, displayName)\n                            else -> installZip(uri, displayName)\n                        }\n                    } else {\n                        finish()\n                    }\n                }\n                Intent.ACTION_SEND -> {\n                    val uri = intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM)!!\n                    val displayName = getDisplayName(uri) ?: UUID.randomUUID().toString()\n                    installZip(uri, displayName)\n                }\n                Intent.ACTION_SEND_MULTIPLE -> {\n                    for (uri in intent.getParcelableArrayListExtra<Uri>(Intent.EXTRA_STREAM)!!) {\n                        val displayName = getDisplayName(uri) ?: UUID.randomUUID().toString()\n                        installZip(uri, displayName)\n                    }\n                }\n                else -> {\n                    getFileFromUserAndInstall()\n                }\n            }\n        }\n    }\n\n    private suspend fun askIfWantInstall(displayName: String?): Boolean {\n        val q = getString(R.string.install_do_you_want, displayName?: \"?\")\n        return Dialogs.simpleQuestion(this@InstallZip, q)\n    }\n\n    override fun onDestroy() {\n        ABEventBus.unregister(this)\n        super.onDestroy()\n    }\n\n    private suspend fun getFileFromUserAndInstall() {\n        val proceed = suspendCoroutine {\n            val zip = getString(R.string.format_zip, getString(R.string.app_name_andbible))\n            val myBible = getString(R.string.format_mybible)\n            val mySword = getString(R.string.format_mysword)\n            val epub = getString(R.string.format_epub)\n            val studyPads = getString(R.string.format_studypads)\n            val ttf = getString(R.string.format_ttf)\n            val formats = getString(R.string.choose_file, getString(R.string.app_name_andbible)) + \" \\n\\n\" + getString(R.string.supported_formats, \"$zip, $myBible, $mySword, $epub, $ttf, $studyPads\")\n\n            AlertDialog.Builder(this@InstallZip)\n                .setTitle(R.string.install_zip)\n                .setMessage(formats)\n                .setPositiveButton(R.string.proceed) { dialog, which ->\n                    it.resume(true)\n                }\n                .setNeutralButton(R.string.cancel){ _, _ ->\n                    it.resume(false)\n                }\n                .setOnCancelListener {_ -> it.resume(false)}\n                .show()\n        }\n\n        if(!proceed) {\n            finish()\n            return\n        }\n\n        val intent = Intent(Intent.ACTION_OPEN_DOCUMENT)\n        intent.type = \"*/*\"\n        intent.putExtra(Intent.EXTRA_MIME_TYPES, arrayOf(\n            \"application/zip\",\n            \"application/x-zip-compressed\",\n            \"application/epub+zip\",\n            \"application/x-font-ttf\",\n            \"font/ttf\",\n            \"font/otf\",\n            \"application/x-font-ttf\",\n            \"application/x-font-otf\"\n        ))\n        val result = awaitIntent(intent)\n        if (result.resultCode == Activity.RESULT_OK) {\n            val uri = result.data!!.data!!\n            val displayName = getDisplayName(uri) ?: UUID.randomUUID().toString()\n            val mimeType = getMimeType(uri)\n\n            try {\n                installFromFile(uri, displayName, mimeType)\n            } catch (e: InstallZipError) {\n                Log.e(TAG, \"Error occurred in installing module\", e)\n                val msg = when(e) {\n                    is CantRead -> getString(R.string.sqlite_cant_read)\n                    is FileNotFound -> getString(R.string.sqlite_cant_read)\n                    is InvalidFile -> getString(R.string.sqlite_invalid_file, e.filename)\n                    is CantWrite -> getString(R.string.sqlite_cant_write)\n                    else -> throw RuntimeException(e)\n                }\n                suspendCoroutine {\n                    AlertDialog.Builder(this@InstallZip)\n                        .setTitle(R.string.error_occurred)\n                        .setMessage(getString(R.string.install_failed_reason, msg))\n                        .setPositiveButton(R.string.okay) { dialog, which ->\n                            it.resume(true)\n                        }\n                        .setOnCancelListener {_ -> it.resume(false)}\n                        .show()\n                }\n            }\n        }\n        finish()\n    }\n\n    enum class FileType {\n        MYBIBLE, MYSWORD, TTF;\n        val displayName get () = name.lowercase()\n    }\n\n    private fun getDisplayName(uri: Uri): String? =\n        contentResolver.query(uri, null, null, null, null)?.use {\n            if (it.isLast) return null;\n            it.moveToFirst()\n            val displayNameIdx = it.getColumnIndex(OpenableColumns.DISPLAY_NAME)\n            if(displayNameIdx < 0) null else it.getString(displayNameIdx)\n        }\n\n    private fun getMimeType(uri: Uri): String? =\n        contentResolver.query(uri, null, null, null, null)?.use {\n            if (it.isLast) return null;\n            it.moveToFirst()\n            val mimeTypeIdx = it.getColumnIndex(\"mime_type\")\n            if(mimeTypeIdx < 0) null else it.getString(mimeTypeIdx)\n        }\n\n    private suspend fun installFromFile(uri: Uri, displayName: String, mimeType: String?): Boolean {\n        if(mimeType == \"application/epub+zip\") {\n            return installEpub(uri, displayName)\n        }\n\n        // Check for TTF files first\n        if(displayName.lowercase().endsWith(\".ttf\") || mimeType?.contains(\"font\") == true) {\n            return installTtf(uri, displayName)\n        }\n\n        val fileTypeFromContent = determineFileType(uri)\n\n        if (fileTypeFromContent == BackupControl.AbDbFileType.ZIP) {\n            return installZip(uri, displayName)\n        }\n\n        if(fileTypeFromContent != BackupControl.AbDbFileType.SQLITE3) {\n            throw InvalidFile(displayName)\n        }\n\n        val filetype = when {\n            displayName.lowercase().endsWith(\".sqlite3\") -> FileType.MYBIBLE\n            displayName.lowercase().endsWith(\".mybible\") -> FileType.MYSWORD\n            else -> throw InvalidFile(displayName)\n        }\n\n        binding.loadingIndicator.visibility = View.VISIBLE\n        try {\n            val inputStream = contentResolver.openInputStream(uri) ?: throw FileNotFound()\n            inputStream.use { fIn ->\n                val outDir = File(SharedConstants.modulesDir, filetype.displayName)\n                outDir.mkdirs()\n                val outFile = File(outDir, displayName)\n                if (outFile.exists()) {\n                    val doInstall = suspendCoroutine {\n                        AlertDialog.Builder(this)\n                            .setTitle(R.string.overwrite_files_title)\n                            .setMessage(getString(R.string.overwrite_files, \"$filetype/$displayName\"))\n                            .setPositiveButton(R.string.yes) { _, _ -> it.resume(true) }\n                            .setNeutralButton(R.string.cancel) { _, _ -> it.resume(false) }\n                            .setOnCancelListener { _ -> it.resume(false) }\n                            .show()\n                    }\n                    if (!doInstall) {\n                        ABEventBus.post(ToastEvent(R.string.install_zip_canceled))\n                        return false\n                    }\n                }\n\n                if ((outFile.exists() && !outFile.canWrite()) || (!outFile.exists() && !outDir.canWrite())) {\n                    throw CantWrite()\n                }\n\n                withContext(Dispatchers.IO) {\n                    val header = ByteArray(16)\n                    fIn.read(header)\n                    if (String(header) == \"SQLite format 3\\u0000\") {\n                        val out = FileOutputStream(outFile)\n                        withContext(Dispatchers.IO) {\n                            out.write(header)\n                            fIn.copyTo(out)\n                            out.close()\n                        }\n                        val book = when (filetype) {\n                            FileType.MYBIBLE -> addMyBibleBook(outFile)\n                            FileType.MYSWORD -> addMySwordBook(outFile)\n                            else -> throw InvalidFile(displayName)\n                        }\n                        if (book == null) {\n                            outFile.delete()\n                            throw InvalidFile(displayName)\n                        }\n                    } else {\n                        throw InvalidFile(displayName)\n                    }\n                }\n            }\n        } catch (e: IOException) {\n            binding.loadingIndicator.visibility = View.GONE\n            Log.e(TAG, \"IOException when reading file\", e)\n            throw FileNotFound()\n        }\n        binding.loadingIndicator.visibility = View.GONE\n        ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n        ABEventBus.post(MainBibleActivity.UpdateMainBibleActivityDocuments())\n        setResult(RESULT_OK)\n        finish()\n        return true\n    }\n\n    private suspend fun installTtf(uri: Uri, displayName_: String?): Boolean = withContext(Dispatchers.IO) {\n        val displayName = displayName_ ?: UUID.randomUUID().toString()\n        withContext(Dispatchers.Main) {\n            binding.loadingIndicator.visibility = View.VISIBLE\n        }\n        \n        try {\n            val inputStream = contentResolver.openInputStream(uri) ?: throw FileNotFound()\n            inputStream.use { fIn ->\n                val outDir = File(SharedConstants.modulesDir, \"ttf\")\n                outDir.mkdirs()\n                val outFile = File(outDir, displayName)\n                \n                if (outFile.exists()) {\n                    val doInstall = withContext(Dispatchers.Main) {\n                        suspendCoroutine {\n                            AlertDialog.Builder(this@InstallZip)\n                                .setTitle(R.string.overwrite_files_title)\n                                .setMessage(getString(R.string.overwrite_files, \"ttf/$displayName\"))\n                                .setPositiveButton(R.string.yes) { _, _ -> it.resume(true) }\n                                .setNeutralButton(R.string.cancel) { _, _ -> it.resume(false) }\n                                .setOnCancelListener { _ -> it.resume(false) }\n                                .show()\n                        }\n                    }\n                    if (!doInstall) {\n                        withContext(Dispatchers.Main) {\n                            ABEventBus.post(ToastEvent(R.string.install_zip_canceled))\n                            binding.loadingIndicator.visibility = View.GONE\n                        }\n                        return@withContext false\n                    }\n                }\n\n                if ((outFile.exists() && !outFile.canWrite()) || (!outFile.exists() && !outDir.canWrite())) {\n                    throw CantWrite()\n                }\n\n                withContext(Dispatchers.IO) {\n                    val out = FileOutputStream(outFile)\n                    fIn.copyTo(out)\n                    out.close()\n                }\n            }\n        } catch (e: IOException) {\n            Log.e(TAG, \"IOException when reading TTF file\", e)\n            withContext(Dispatchers.Main) {\n                binding.loadingIndicator.visibility = View.GONE\n            }\n            throw FileNotFound()\n        }\n\n        addManuallyInstalledTtfBooks()\n\n        withContext(Dispatchers.Main) {\n            binding.loadingIndicator.visibility = View.GONE\n            ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n            AndBibleAddons.clearCaches()\n            setResult(RESULT_OK)\n            finish()\n        }\n        true\n    }\n\n\n    private suspend fun installZip(uri: Uri, displayName: String?): Boolean {\n        var result = false\n        binding.installZipLabel.text = getString(R.string.checking_zip_file)\n        binding.loadingIndicator.visibility = View.VISIBLE\n        val manifest = AndBibleBackupManifest.fromUri(uri)\n        if (manifest?.backupType == BackupType.STUDYPAD_EXPORT) {\n            result = installStudyPads(uri)\n            finish()\n        } else {\n            val zh = ZipHandler(\n                {\n                    try {\n                        contentResolver.openInputStream(uri) ?: throw FileNotFound()\n                    } catch (e: Exception) {\n                        Log.e(TAG, \"Error opening input stream for zip file\", e)\n                        throw FileNotFound()\n                    }\n                },\n                { percent -> updateProgress(percent) },\n                { finishResult ->\n                    result = finishResult == RESULT_OK\n                    setResult(finishResult);\n                    ABEventBus.post(MainBibleActivity.UpdateMainBibleActivityDocuments())\n                    finish()\n                },\n                this\n            )\n\n            try {\n                zh.execute()\n            } catch (e: EpubFile) {\n                installEpub(uri, displayName)\n                finish()\n            }\n        }\n        binding.loadingIndicator.visibility = View.GONE\n        if (result) {\n            ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n        }\n        return result\n    }\n\n    private suspend fun installStudyPads(uri: Uri): Boolean {\n        val inputStream = try {\n            contentResolver.openInputStream(uri) ?: throw FileNotFound()\n        } catch (e: Exception) {\n            Log.e(TAG, \"Error opening input stream for study pads\", e)\n            throw FileNotFound()\n        }\n        val category = SyncableDatabaseDefinition.BOOKMARKS\n        val unzipFolder = File(BackupControl.internalDbBackupDir, \"unzip\")\n        unzipInputStream(inputStream, unzipFolder)\n        val file = File(unzipFolder, \"db/${BookmarkDatabase.dbFileName}\")\n        val stats = bookmarksDbStats(category, file)\n        val result = Dialogs.simpleQuestion(this@InstallZip, getString(R.string.install_do_you_want, stats))\n        if (!result) {\n            unzipFolder.deleteRecursively()\n            return false\n        }\n        importDatabaseFile(category, file)\n        unzipFolder.deleteRecursively()\n        return true\n    }\n\n    fun onEventMainThread(e: InstallZipEvent) {\n        binding.statusText.text = e.message\n    }\n\n    private val bookmarksDao get() = DatabaseContainer.instance.bookmarkDb.bookmarkDao()\n\n    private suspend fun installEpub(uri: Uri, displayName_: String?): Boolean = withContext(Dispatchers.IO) {\n        val displayName = displayName_ ?: UUID.randomUUID().toString()\n        withContext(Dispatchers.Main) {\n            binding.loadingIndicator.visibility = View.VISIBLE\n        }\n        val dir = File(SharedConstants.modulesDir, \"epub/$displayName\")\n        if (dir.exists()) {\n            val initials = epubInitials(displayName)\n            val book = Books.installed().getBook(initials)\n            val optimizerVersion = ((book as? SwordGenBook)?.backend as? EpubBackend)?.state?.optimizerVersion ?: 1\n            if(DatabaseContainer.ready && bookmarksDao.genericBookmarkCountFor(initials) > 0 && optimizerVersion < EPUB_OPTIMIZER_VERSION) {\n                if(CommonUtils.documentUpgradeConfirmation(this@InstallZip)) {\n                    dir.deleteRecursively()\n                } else {\n                    finish()\n                    return@withContext false\n                }\n            } else {\n                dir.deleteRecursively()\n            }\n        }\n        dir.mkdirs()\n        try {\n            val inputStream = contentResolver.openInputStream(uri) ?: throw FileNotFound()\n            unzipInputStream(inputStream, dir)\n        } catch (e: Exception) {\n            Log.e(TAG, \"Error opening input stream for epub\", e)\n            throw FileNotFound()\n        }\n        val installOk = addManuallyInstalledEpubBooks()\n        withContext(Dispatchers.Main) {\n            if(installOk) {\n                ABEventBus.post(ToastEvent(R.string.install_zip_successfull))\n            } else {\n                Dialogs.showMsg2(this@InstallZip,\n                    application.getString(R.string.sqlite_invalid_file, displayName)\n                )\n            }\n            binding.loadingIndicator.visibility = View.GONE\n            finish()\n        }\n        true\n    }\n\n    override fun onBackPressed() {}\n\n    private fun updateProgress(percentValue: Int) {\n        if (percentValue == 1)\n            binding.installZipLabel.text = getString(R.string.extracting_zip_file)\n\n        binding.progressBar.progress = percentValue\n    }\n}\n", "patch": "--- a/app/src/main/java/net/bible/android/view/activity/installzip/InstallZip.kt\n+++ b/app/src/main/java/net/bible/android/view/activity/installzip/InstallZip.kt\n@@ -238,6 +238,9 @@\n             InstallResult.INVALID_MODULE\n         } catch (e: InvalidModule) {\n             InstallResult.INVALID_MODULE\n+        } catch (e: FileNotFound) {\n+            Log.e(TAG, \"File not found or could not be opened\", e)\n+            InstallResult.ERROR\n         } catch (e: ModulesExists) {\n             doInstall = suspendCoroutine {\n                 AlertDialog.Builder(activity)\n@@ -261,6 +264,9 @@\n                 InstallResult.ERROR\n             } catch (e: IOException) {\n                 Log.e(TAG, \"Error occurred\", e)\n+                InstallResult.ERROR\n+            } catch (e: FileNotFound) {\n+                Log.e(TAG, \"File not found or could not be opened during installation\", e)\n                 InstallResult.ERROR\n             } catch (e: CantOverwrite) {\n                 suspendCoroutine {\n"}], "agent_initiated": true, "agent_signals": {"layer": 1, "value": "copilot-swe-agent"}, "author_type": "agent", "reviewer_types": ["human"], "interaction_type": "human_agent", "takeover_events": [{"type": "commit", "actor_login": "tuomas2", "actor_type": "human", "timestamp": "2025-09-18T13:21:54Z", "round_index": null, "commit_oid": "b4a1a0cedc7c7a6020b502a78d8adadbcb4d8f37"}, {"type": "review_reply", "actor_login": "tuomas2", "actor_type": "human", "timestamp": "2025-09-18T13:24:23Z", "round_index": 0, "commit_oid": null}], "first_human_takeover_ts": "2025-09-18T13:21:54Z", "merged_with_unresolved": false, "candidate_issues": [], "link_confidence": "explicit", "thread_chains": [], "author_self_reviewed": false, "fully_agent_authored": false, "requested_reviewers": [{"login_or_team": "tuomas2", "kind": "user", "created_at": "2025-09-18T12:57:41Z"}], "review_request_removed": [], "reviewer_was_requested": true, "merged_by": "tuomas2", "merge_commit_oid": "6c2938375f8c35586c586585ee64c5e4aba1a64c", "merged_by_is_author": false, "maintainer_override": false, "referenced_file_contents": {}, "repo_is_fork": null, "repo_parent": null, "repo_collaborator_count": null, "hours_to_first_review": 0.5908333333333333, "median_response_latency_hours": null, "reviewer_count": 1, "merged_by_association": null, "n_commits": 3, "n_human_commits": 1, "n_agent_commits": 2, "n_bot_commits": 0, "agent_commit_ratio": 0.6666666666666666, "repo_metadata": {"full_name": "AndBible/and-bible", "owner": "AndBible", "name": "and-bible", "stars": 741, "language": "Kotlin", "license": "gpl-3.0", "topics": ["bible", "java", "android", "kotlin", "biblestudy", "commentary", "vuejs", "vue", "vue3"], "description": "AndBible: Bible Study", "url": "https://github.com/AndBible/and-bible", "default_branch": "current-stable", "open_issues": 1008, "forks": 223, "discovered_via": "license:gpl-3.0 topic:vue stars:201..1000 created:2008-01-01..2026-02-01 archived:false", "created_at": "2011-09-26T21:24:29Z", "pr_total_count": 580, "issue_total_count": 3156, "primary_language": "Kotlin", "language_bytes": {"Kotlin": 4373057, "JavaScript": 469146, "Vue": 398736, "TypeScript": 236695, "Python": 81903, "SCSS": 17671, "Shell": 13685, "HTML": 9779, "Makefile": 2625, "Dockerfile": 2235}}, "conversation_comments": []}

Appsilon_shiny.react_62/issues/Appsilon_shiny.react_43.json

@@ -0,0 +1 @@
+{"number": 43, "title": "Support accessor in `setInput()`", "body": "### Background\r\n\r\nReact components typically use handlers to notify parent about value changes, e.g. ([Checkbox](https://blueprintjs.com/docs/#core/components/checkbox) from Blueprint.js):\r\n```jsx\r\n<Checkbox\r\n  defaultChecked={false}\r\n  onChange={(event) => handle(event.target.checked)}\r\n/>\r\n```\r\n\r\nWith shiny.react it is possible to use such a component in the following way:\r\n```r\r\nCheckbox(\r\n  defaultChecked = FALSE,\r\n  onChange = JS('(event) => Shiny.setInputValue(\"checked\", event.target.checked)')\r\n)\r\n```\r\n\r\nHowever, it is inconvenient and error-prone to define the `onChange` handler using JS code embedded in a string, so we have\r\n```r\r\nshiny.react::setInput(inputId, argIdx = 1)\r\n```\r\nwhich can be seen as equivalent to\r\n```js\r\n(...args) => Shiny.setInputValue(inputId, args[argIdx - 1]) // JS uses 0-based indexing\r\n```\r\n\r\n### Problem\r\n\r\nThe `setInput()` function currently only supports sending one of the arguments to Shiny server. It is insufficient when we need to do something with the argument first, like getting the `.target.checked` property in the `Checkbox` example above. It would be great if we could do something like this:\r\n```r\r\nCheckbox(\r\n  defaultChecked = FALSE,\r\n  onChange = setInput(\"checked\", \"[0].target.value\")\r\n)\r\n```\r\n\r\n### Approach\r\n\r\nConsider replacing the `argIdx` argument of `setInput` with `accessor` which would behave as in the example above. Suggest other possible API ideas for `setInput` (e.g. have both `argIdx` and `accessor` arguments) and consult with reviewer before implementation.\r\n\r\n### Relevant files\r\n\r\n1. `R/react.R:174`: definition of `setInput()`\r\n2. `js/src/react/mapReactData.js:88`: JS-side handler", "state": "CLOSED", "created_at": "2022-06-29T08:37:01Z", "closed_at": "2023-01-27T11:00:49Z", "author_login": "kamilzyla", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 62, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

ArduPilot_ardupilot_30098/issues/ArduPilot_ardupilot_29932.json

@@ -0,0 +1 @@
+{"number": 29932, "title": "Plane: add support for Quadplane VTOL Takeoff in ROS2", "body": "## Feature request\nThis is a feature request to add VTOL takeoff support for quadplanes in ROS2. \n\n- So far there is an experimental takeoff feature for Copter but this can't be used for quadplanes. \n- It is not possible to call ROS2 commands to have the Plane takeoff in VTOL mode from any of the other Q_ flight modes (at least from when I was testing Ardupilot SITL, Gazebo, and Mavproxy commands). \n- From https://mavlink.io/en/messages/ardupilotmega.html#PLANE_MODE%22, there is a PLANE_MODE_TAKEOFF, but there is no PLANE_MODE_QTAKEOFF.\n\n**How I'd like the solution to turn out:**\nI'd like to be able to call something like the following CLI command:\n> ros2 service call /ap/QTakeoff ardupilot_msgs/srv/QTakeoff \"{altitude: 400}\"\n\nAnd the following in C++:\n```\nauto client_mode_switch = create_client<ardupilot_msgs::srv::QTakeoff>(\"ap/QTakeoff\");\nauto request = std::make_shared<ardupilot_msgs::srv::QTakeoff::Takeoff_Request>();\nrequest->alt = 400;\n```\n\n**Considered alternatives:**\nI've considered Mavros for its quadplane support but I've read multiple times that it's prone to bugs and that it's not ideal to combine it with ROS2. I've seen quadplane features implemented in MavSDK but I'm not sure how well this would end up working when also combining MavSDK with ROS2. \n\n**Platform**\n[  ] All\n[  ] AntennaTracker\n[  ] Copter\n[ x ] Plane\n[  ] Rover\n[  ] Submarine\n\n**Additional context**\nThere are tutorials such as https://discuss.ardupilot.org/t/offboard-terrain-navigation-for-plane-with-ros-2-ap-dds/114418 that show quadplanes taking off as VTOL but this is done in MavProxy while the rest of the navigation is done in ROS2.\n\nOther References:\nhttps://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_DDS/Idl/ardupilot_msgs/srv/Takeoff.idl\nhttps://docs.ros.org/en/foxy/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Service-And-Client.html#write-the-service-node", "state": "CLOSED", "created_at": "2025-04-30T07:00:39Z", "closed_at": "2025-05-28T04:01:23Z", "author_login": "joshua-git0", "comment_rounds": [{"comments": [{"id": "IC_kwDOAHKhpM6pV17J", "body": "This is probably one for @Ryanf55 and/or @srmainwaring to respond on", "createdAt": "2025-04-30T07:33:16Z", "updatedAt": "2025-04-30T07:33:16Z", "author": {"login": "rmackay9"}}, {"id": "IC_kwDOAHKhpM6pWDmt", "body": "@rmackay9 Thank you for mentioning Ryan and Rhys. So far I've tried to add in how I think the feature would be implemented - https://github.com/ArduPilot/ardupilot/compare/master...joshua-git0:ardupilot:master\n\nI noticed there are the do_vtol_takeoff and set_armed functions in https://github.com/ardupilot/ardupilot/blob/master/ArduPlane/quadplane.cpp and I've been trying to understand how these would integrate with ROS2", "createdAt": "2025-04-30T07:55:56Z", "updatedAt": "2025-04-30T07:55:56Z", "author": {"login": "joshua-git0"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 30098, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Plane", "ROS"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Automattic_woocommerce-services_2727/issues/Automattic_woocommerce-services_2726.json

@@ -0,0 +1 @@
+{"number": 2726, "title": "Stop plugin execution when woocommerce-shipping or woocommerce-tax is active", "body": "In order to prepare for the separation of shipping and tax we need to add a check to ensure that WCS&T does not work when either `woocommerce-shipping` or `woocommerce-tax` are active.\n\nWe also need to display a message indicating that you cannot have WCS&T active alongside Woo Shipping or Woo Tax.", "state": "CLOSED", "created_at": "2024-04-04T09:20:11Z", "closed_at": "2024-04-24T13:55:00Z", "author_login": "kloon", "comment_rounds": [{"comments": [{"id": "IC_kwDOAwlji855ZbBr", "body": "The solution I ended up implementing is that WCS&T will display the notice and not activate itself if possible. If not, Woo Shipping will deactivate itself instead (to cover cases where a merchant is using an older version of WCS&T).\n\nSee the screenshots here: https://github.com/woocommerce/woocommerce-shipping/pull/345", "createdAt": "2024-04-04T09:44:56Z", "updatedAt": "2024-04-04T09:44:56Z", "author": {"login": "waclawjacek"}}]}, {"comments": [{"id": "IC_kwDOAwlji856R6OI", "body": "Added the same logic to Woo Tax: https://github.com/woocommerce/woocommerce-tax/pull/59", "createdAt": "2024-04-12T10:42:53Z", "updatedAt": "2024-04-12T10:42:53Z", "author": {"login": "waclawjacek"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 2727, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Automattic_wp-calypso_92015/issues/Automattic_wp-calypso_76102.json

@@ -0,0 +1 @@
+{"number": 76102, "title": "Invalid button label when non plan purchasing user visits plan page", "body": "How to reproduce\r\n1 - Create a site with a paid plan\r\n2 - Add a non Super User account to a WordPress site as an administrator (This is to trigger the `This plan was purchased by a different WordPress.com account` state)\r\n3 - On the non super user account visit the plans page\r\n\r\nAs shown below the `Downgrade` greyed out text is incorrect to be shown in the Business/eCommerce plan when a Premium plan  is purchased. It should be changed to `Upgrade` but still remain greyed out because we are not in the site owner's context.\r\n\r\n<img width=\"1672\" alt=\"image\" src=\"https://user-images.githubusercontent.com/3422709/236474619-2fb51302-7edb-4cee-9aca-c0c1acbc1256.png\">\r\n\r\n", "state": "CLOSED", "created_at": "2023-04-21T21:08:24Z", "closed_at": "2024-05-03T18:35:42Z", "author_login": "ddc22", "comment_rounds": [{"comments": [{"id": "IC_kwDOArzw_85agFo8", "body": "Hi @southp I assigned this to you so that you can prioritise this as you see fit :)", "createdAt": "2023-04-21T21:43:57Z", "updatedAt": "2023-04-21T21:43:57Z", "author": {"login": "ddc22"}}]}, {"comments": [{"id": "IC_kwDOArzw_85bPyF6", "body": "@jdc91 Looks like the screenshot is missing :P Could you help me add it when you have a moment?", "createdAt": "2023-05-02T04:35:31Z", "updatedAt": "2023-05-02T04:35:31Z", "author": {"login": "southp"}}]}, {"comments": [{"id": "IC_kwDOArzw_85bkfy4", "body": "For some reason the previous screenshot was not showing \ud83d\ude2e . I added it again.", "createdAt": "2023-05-05T13:51:41Z", "updatedAt": "2023-05-05T13:51:41Z", "author": {"login": "ddc22"}}]}, {"comments": [{"id": "IC_kwDOArzw_85cYXlS", "body": "Thanks. I've moved it to Next Up since it is conveying wrong information.", "createdAt": "2023-05-16T15:26:27Z", "updatedAt": "2023-05-16T15:26:27Z", "author": {"login": "southp"}}]}, {"comments": [{"id": "IC_kwDOArzw_858yR9L", "body": "Hi! Closing this in favor of https://github.com/Automattic/wp-calypso/issues/87479. If, for some reason, we want both issues open at the same, we can always reopen \ud83d\ude42", "createdAt": "2024-05-03T18:35:42Z", "updatedAt": "2024-05-03T18:35:42Z", "author": {"login": "jeyip"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Bug", "[Pri] High", "Triaged", "2023 Pricing Page \u26a1", "[Status] Priority Review Triggered", "Bottle Pickup"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Automattic_wp-calypso_92015/issues/Automattic_wp-calypso_87479.json

@@ -0,0 +1 @@
+{"number": 87479, "title": "Plans page: Incorrect option to downgrade from lower plan instead of upgrade to higher plans", "body": "### Quick summary\r\n\r\nI noticed that an Admin user who is not a plan subscription owner only sees an option to _Downgrade_ from a lower to higher plan in the plans page. This option is also greyed out (presumably because this Admin user is not the subscription owner).\r\n\r\nTake a look here:\r\n\r\n![CleanShot 2024-02-15 at 09 14 55](https://github.com/Automattic/wp-calypso/assets/2912202/ec71dc43-a4bf-4a26-ad3e-9b42fe7e6d41)\r\n\r\nI was able to reproduce this issue on a site I have Admin access to, but where I am not the plan owner.\r\n\r\n### Steps to reproduce\r\n\r\n1. Access a site as an Admin, non-subscription owner user;\r\n2. Go to _Upgrades_ > _Plans_;\r\n3. Notice that instead of being presented with buttons to **Upgrade** to a higher plan, the buttons are to **Downgrade** despite the current plan being the WordPress Starter plan.\r\n\r\n### What you expected to happen\r\n\r\nThe call to action buttons should be to **Upgrade** to a higher plan, not **Downgrade**.\r\n\r\n### What actually happened\r\n\r\nThe buttons incorrectly indicate an option to downgrade from a lower to higher plan.\r\n\r\n### Impact\r\n\r\nPotentially many users\r\n\r\n### Available workarounds?\r\n\r\nNo but the platform is still usable\r\n\r\n### Platform (Simple and/or Atomic)\r\n\r\nSimple\r\n\r\n### Logs or notes\r\n\r\nI came across this issue when conducting a review of 7742729-zen", "state": "CLOSED", "created_at": "2024-02-15T07:22:45Z", "closed_at": "2024-08-02T07:33:50Z", "author_login": "pauljacobson", "comment_rounds": [{"comments": [{"id": "IC_kwDOArzw_85z9f8C", "body": "**Support References**\n\n*This comment is automatically generated. Please do not edit it.*\n\n\n- [ ] 7742729-zen\n", "createdAt": "2024-02-15T07:27:06Z", "updatedAt": "2024-02-15T07:27:06Z", "author": {"login": "github-actions"}}, {"id": "IC_kwDOArzw_850KPd2", "body": "\ud83d\udccc REPRODUCTION RESULTS\r\n\u2013 Tested on Atomic \u2013 Replicated \r\n\r\n\ud83d\udccc FINDINGS/SCREENSHOTS/VIDEO\r\nI was able to reproduce the issue on my test site:\r\n![Markup on 2024-02-16 at 17:36:56](https://github.com/Automattic/wp-calypso/assets/9025643/d5abedf4-b036-428f-a5dd-c8234e6c7ddb)\r\n\r\n\ud83d\udccc ACTIONS\r\n\u2013 Triaged", "createdAt": "2024-02-16T16:38:10Z", "updatedAt": "2024-02-16T16:38:10Z", "author": {"login": "maciejpilarski"}}]}, {"comments": [{"id": "IC_kwDOArzw_858H7Zr", "body": "The label is incorrect, however I don't think it's a particularly impactful problem. We can resolve it by changing the label to \"Change\" instead of \"Downgrade\".\r\n\r\nThe issue is that we use `isPlanAvailableForPurchase` for this label and it combines two meanings - the plan is unavailable because it's an unsupported downgrade, and the plan is unavailable because the user is not the site owner.\r\n\r\nSending this to Decepticons with a recommendation to update the button to \"Change\" or a similar word.", "createdAt": "2024-04-29T11:15:31Z", "updatedAt": "2024-04-29T11:15:31Z", "author": {"login": "dzver"}}]}, {"comments": [{"id": "IC_kwDOArzw_858kVeG", "body": "Thanks for the heads up. The same issue was reported by @ddc22 in the past here: https://github.com/Automattic/wp-calypso/issues/76102. I'll bump its priority and triage accordingly.", "createdAt": "2024-05-02T08:32:59Z", "updatedAt": "2024-05-02T08:32:59Z", "author": {"login": "southp"}}]}, {"comments": [{"id": "IC_kwDOArzw_86EZ0SF", "body": "As part of pb5gDS-3YO-p2, we're aiming to fix/close high-priority issues in [The One Board](https://github.com/orgs/Automattic/projects/391/views/12)\r\nHey, @aneeshd16, I see you are working on [this PR](https://github.com/Automattic/wp-calypso/pull/92015) that fixes it. Can you update this issue when the PR is merged?\r\n\r\nThanks", "createdAt": "2024-07-10T20:16:34Z", "updatedAt": "2024-07-10T20:16:34Z", "author": {"login": "lupus2k"}}, {"id": "IC_kwDOArzw_86Efha_", "body": "Hi @lupus2k, yes, sure will do!", "createdAt": "2024-07-11T12:50:20Z", "updatedAt": "2024-07-11T12:50:20Z", "author": {"login": "aneeshd16"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 92015, "link_type": "closing_keyword", "will_close": true, "comment_count": 6, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Bug", "[Feature] Plans & Upgrades", "[Feature Group] WPCOM Store & Purchases", "Customer report [LEGACY]", "Triaged", "[Platform] Simple", "[Status] Priority Review Triggered", "[Product] WordPress.com"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Automattic_wp-calypso_95695/issues/Automattic_wp-calypso_95384.json

@@ -0,0 +1 @@
+{"number": 95384, "title": "Post-purchase Migration Experience: Handle selecting a DIY site in the Sites dashboard that has started migration", "body": "Dependent on #95379.\n\n## Description\nWhen a user clicks on a site in the Sites dashboard that has the `migration-started-diy` sticker, display a detailed view communicating what the user can expect.\n\nFigma - nOWSHCjXMpB5sXHthTVdvK-fi-3949_19812\n\n![Image](https://github.com/user-attachments/assets/fc7087a3-dd9d-4d3b-b3e4-48201a839263)", "state": "CLOSED", "created_at": "2024-10-15T14:47:39Z", "closed_at": "2024-10-30T12:32:05Z", "author_login": "donnapep", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 95695, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Automattic_wp-calypso_98390/issues/Automattic_wp-calypso_96291.json

@@ -0,0 +1 @@
+{"number": 96291, "title": "Forgot your password: Should we bring users to the old screen?", "body": "### Quick summary\n\n![Image](https://github.com/user-attachments/assets/63855fcc-163d-4f5a-9134-931bacc6f50e)\n\nLink at the bottom brings the user to an older page\n\nhttps://wordpress.com/wp-login.php?action=lostpassword\n\nWhile \"Forgot password?\" to https://wordpress.com/log-in/lostpassword, that even if not beautiful is in Calypso.\n\n### Steps to reproduce\n\n- Go to login page\n\n### What you expected to happen\n\nDecide where to send the user if they forgot the password\n\n### What actually happened\n\nTwo different links\n\n### Impact\n\nAll\n\n### Available workarounds?\n\nThere is no user impact\n\n### If the above answer is \"Yes...\", outline the workaround.\n\n_No response_\n\n### Platform (Simple and/or Atomic)\n\n_No response_\n\n### Logs or notes\n\n_No response_", "state": "CLOSED", "created_at": "2024-11-12T15:46:26Z", "closed_at": "2025-01-20T02:30:33Z", "author_login": "escapemanuele", "comment_rounds": [{"comments": [{"id": "IC_kwDOArzw_86TaFML", "body": "I don't think so. We should keep the experience consistent. Honestly, it seems like a mistake to me. Let me check if it's intentional. ", "createdAt": "2024-11-13T10:17:05Z", "updatedAt": "2024-11-13T10:17:05Z", "author": {"login": "gavande1"}}, {"id": "IC_kwDOArzw_86TaGDQ", "body": "Yeah 100% a mistake as it should be consistent. I'm not sure of the status of the Calypso lost your password page, as I've not worked on that. Maybe @chihsuan knows more", "createdAt": "2024-11-13T10:18:30Z", "updatedAt": "2024-11-13T10:18:30Z", "author": {"login": "escapemanuele"}}, {"id": "IC_kwDOArzw_86TaKZ1", "body": "It appears that the Calypso screen is not fully functional. After submitting my email, it redirected me to log in without providing any message. I did receive the email, but the link directed me to the old UI (wp-login.php). I have a feeling that keeping the old UI may have been a conscious decision. ", "createdAt": "2024-11-13T10:26:12Z", "updatedAt": "2024-11-13T10:26:12Z", "author": {"login": "gavande1"}}, {"id": "IC_kwDOArzw_86TcM9S", "body": "> I have a feeling that keeping the old UI may have been a conscious decision.\n\nYeah, that may be it. We should probably keep the old UI for now, but strive to get to the new version, as the jump from one screen to the other is a bit strange.", "createdAt": "2024-11-13T13:36:18Z", "updatedAt": "2024-11-13T13:36:18Z", "author": {"login": "escapemanuele"}}, {"id": "IC_kwDOArzw_86Ti9Z0", "body": "Perfect. I will prepare a fix for that. Instead of redirecting users to the Calypso screen to reset their passwords, it will redirect them to the Old UI for consistency. ", "createdAt": "2024-11-14T04:55:26Z", "updatedAt": "2024-11-14T04:55:26Z", "author": {"login": "gavande1"}}, {"id": "IC_kwDOArzw_86Tlfy2", "body": "\ud83d\udc4b @chihsuan, I am restoring the changes introduced in the https://github.com/Automattic/wp-calypso/pull/68699 PR, which introduces a react-based lost password screen. Before making changes to it, I wanted to confirm with you that the changes are restored and if you have any concerns with that. \n\nI was thinking of making changes to [renderLostPasswordLink()](https://github.com/Automattic/wp-calypso/blob/cff770810c9064424ef818c12033b166da7f8ba0/client/blocks/login/login-form.jsx#L623-L623).  Let me know what you think about it. \n\n@escapemanuele, Originally, we used the old lost password screen. Then, the react-based screen was introduced behind the `login/react-lost-password-screen` feature, and the flag was enabled for all environments. \n", "createdAt": "2024-11-14T11:18:05Z", "updatedAt": "2024-11-14T11:18:05Z", "author": {"login": "gavande1"}}, {"id": "IC_kwDOArzw_86Tl0iY", "body": "> I am restoring the changes introduced in the https://github.com/Automattic/wp-calypso/pull/68699 PR, which introduces a react-based lost password screen. Before making changes to it, I wanted to confirm with you that the changes are restored and if you have any concerns with that.\n\n@gavande1 When I introduced the react-based lost password screen, I made sure that it was enabled for WooCommerce.com only. I am not sure why it was enabled for all environments. As long as the feature is enabled for Woo, I don't have any concerns. Thanks for checking in with me! \ud83d\ude4f ", "createdAt": "2024-11-14T11:57:59Z", "updatedAt": "2024-11-14T11:57:59Z", "author": {"login": "chihsuan"}}, {"id": "IC_kwDOArzw_86TnW3V", "body": "I'd love to have the react screen, but @chihsuan told me that it's tested on Woo. So, I believe it'll be necessary to do some testing and maybe tweak things a little. Hopefully, not much.\n\nThe react screen also needs some styling work, but it's almost there.", "createdAt": "2024-11-14T14:52:46Z", "updatedAt": "2024-11-14T14:52:46Z", "author": {"login": "escapemanuele"}}, {"id": "IC_kwDOArzw_86Tu_C6", "body": "Idea: How about we take this up as a mini project and revamp the forgot password screen and standardize the calypso screen? ", "createdAt": "2024-11-15T11:02:20Z", "updatedAt": "2024-11-15T11:02:20Z", "author": {"login": "gavande1"}}, {"id": "IC_kwDOArzw_86Tu_ig", "body": "I will mark this issue's status as `Need Shaping`. ", "createdAt": "2024-11-15T11:03:29Z", "updatedAt": "2024-11-15T11:03:29Z", "author": {"login": "gavande1"}}]}, {"comments": [{"id": "IC_kwDOArzw_86UB4A3", "body": "I feel like there is some need for that, as it is now a really neglected part. Thanks", "createdAt": "2024-11-18T16:23:13Z", "updatedAt": "2024-11-18T16:23:13Z", "author": {"login": "escapemanuele"}}]}, {"comments": [{"id": "IC_kwDOArzw_86aUVud", "body": "> @gavande1 When I introduced the react-based lost password screen, **I made sure that it was enabled for WooCommerce.com only**. I am not sure why it was enabled for all environments. As long as the feature is enabled for Woo, I don't have any concerns. Thanks for checking in with me! \ud83d\ude4f\n\n@chihsuan I believe that is only partly true. It appears like the [original PR](https://github.com/Automattic/wp-calypso/pull/68885) introduced a defect that was sorted in #96506. Additionally, looking at that PR, there isn't any `isWoo` checks for [rendering the react view](https://github.com/Automattic/wp-calypso/pull/68885/files#diff-a2085484a90c3affa18d524a40f82a2dcd6f62819f3c9246abdb4dca23feb5e2R277) itself and [the route is added for all cases](https://github.com/Automattic/wp-calypso/pull/68885/files#diff-8b66011588360680c38b6923b3207d38dec4282037d8adbd40ea3dd2c68262a5R102).\n\nSince there are no longer any links to the React view accessible from dotCOM, and the [dotCom knowledge base uses the PHP lost-password](https://wordpress.com/support/passwords/), I would suggest we redirect wp.com users to `wp-login.php?action=lostpassword` or alternatively remove the route.\n\nI can look into that.", "createdAt": "2025-01-14T05:16:58Z", "updatedAt": "2025-01-14T05:17:31Z", "author": {"login": "StevenDufresne"}}, {"id": "IC_kwDOArzw_86aUxbF", "body": "> I  believe that is only partly true. It appears like the https://github.com/Automattic/wp-calypso/pull/68885 introduced a defect that was sorted in https://github.com/Automattic/wp-calypso/pull/96506. Additionally, looking at that PR, there isn't any isWoo checks for [rendering the react view](https://github.com/Automattic/wp-calypso/pull/68885/files#diff-a2085484a90c3affa18d524a40f82a2dcd6f62819f3c9246abdb4dca23feb5e2R277) itself and [the route is added for all cases](https://github.com/Automattic/wp-calypso/pull/68885/files#diff-8b66011588360680c38b6923b3207d38dec4282037d8adbd40ea3dd2c68262a5R102).\n\n@StevenDufresne The defect logic was introduced by another PR. The original PR [only rendered the lost password link for Woo](https://github.com/Automattic/wp-calypso/pull/68885/files#diff-c4b202c48b075713a04477b1013b69e705758b4a0db59b3e648a48ed95077eddR727). It's intentional that there is no isWoo check for the route since the lost password link (action=lostpassword param) was only available for WooCommerce.com at that time. \n\n> Since there are no longer any links to the React view accessible from dotCOM, and the dotCom knowledge base uses the PHP lost-password, I would suggest we redirect wp.com users to wp-login.php?action=lostpassword or alternatively remove the route.\n\nThat sounds good.", "createdAt": "2025-01-14T06:31:38Z", "updatedAt": "2025-01-14T06:31:38Z", "author": {"login": "chihsuan"}}, {"id": "IC_kwDOArzw_86aU4c1", "body": "Ah [you're right](https://github.com/Automattic/wp-calypso/commit/0425c28813a1d8873e6c104c75cb245c55766142#diff-c4b202c48b075713a04477b1013b69e705758b4a0db59b3e648a48ed95077eddR937), thanks for the follow-up!", "createdAt": "2025-01-14T06:56:42Z", "updatedAt": "2025-01-14T06:56:42Z", "author": {"login": "StevenDufresne"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 98390, "link_type": "closing_keyword", "will_close": true, "comment_count": 14, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Bug", "[Pri] Normal", "[Feature] Signup & Account Creation", "[Feature Group] Signup & Site Onboarding", "Triaged", "[Product] WordPress.com"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Autonomy-Logic_openplc-editor_617/issues/Autonomy-Logic_openplc-editor_585.json

@@ -0,0 +1 @@
+{"number": 585, "title": "array not green on debugger", "body": "<!-- Please use the following issue template or your issue will be closed -->\n\n## Expected Behavior\n\n<!--- What should have happened? -->\nArray inputs and outputs to turn green during debugging when activated \n## Current Behavior\nInputs and outputs are red and stay red when activated \n\n\n- Version :v4.1.1\n- Operating System and version :windows 10\n", "state": "CLOSED", "created_at": "2026-02-05T04:23:45Z", "closed_at": "2026-02-19T01:43:15Z", "author_login": "streatstyle", "comment_rounds": [{"comments": [{"id": "IC_kwDOKzKQVM7s_AIF", "body": "when say using a push button to control one of the array bits sensor[0], the actual contact or coil of sensor[0] does not turn Green when activated but does send the active high or low to the bit. I can however see the list of the array in the debugger and if I activate/force it there it does turn the contact or coil high/Green also if I try to force the contact or coil from the rung it doesn't work either only in the debugger/watchdog can I control them ", "createdAt": "2026-02-28T01:05:46Z", "updatedAt": "2026-02-28T01:05:46Z", "author": {"login": "streatstyle"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 617, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

BBMRI-ERIC_negotiator_727/issues/BBMRI-ERIC_negotiator_709.json

@@ -0,0 +1 @@
+{"number": 709, "title": "[FEATURE] Delete Draft Negotiations", "body": "**Brief description.**\nThe user should be able to delete their own Negotiations as long as they are in a draft state.", "state": "CLOSED", "created_at": "2025-04-07T09:10:25Z", "closed_at": "2025-04-29T13:28:17Z", "author_login": "RadovanTomik", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 727, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

BentoBoxWorld_BentoBox_2863__unreviewed_2/issues/BentoBoxWorld_BentoBox_2862.json

@@ -0,0 +1 @@
+{"number": 2862, "title": "Geo-limit-settings improvement", "body": "### Is your feature request related to a problem?\n\nI would like to add not only regular mobs, but also their projectiles, because they accumulate over time, such as snowballs or eggs.\n\n### Describe the solution you'd like.\n\nAdd to this geo-limit-settings as:\n\n```- fireball\n- small_fireball\n- dragon_fireball\n- firework_rocket\n- llama_spit\n- arrow\n- spectral_arrow\n- shulker_bullet\n- experience_bottle\n- egg\n- ender_pearl\n- eye_of_ender\n- snowball\n- potion\n- trident\n- wind_charge\n- breeze_wind_charge\n- wither_skull\n```\n\n### Describe alternatives you've considered.\n\nThere are none\n\n### Agreements\n\n- [x] I have searched for and ensured there isn't already an open issue regarding this.\n- [x] I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.\n\n### Other\n\nhttps://github.com/user-attachments/assets/8d179b05-3cf0-4c52-a475-05573c37f005", "state": "CLOSED", "created_at": "2025-08-06T16:54:43Z", "closed_at": "2026-03-14T21:26:05Z", "author_login": "Vinrey123", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 2863, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

BentoBoxWorld_BentoBox_2863__unreviewed_2/pr.json

@@ -0,0 +1 @@
+{"repo": "BentoBoxWorld/BentoBox", "pr_number": 2863, "pr_title": "Add projectile entity support to geo-limit-settings", "pr_state": "merged", "pr_author": "copilot-swe-agent", "base_branch": "develop", "head_branch": "copilot/add-geo-limit-projectiles", "created_at": "2026-03-14T21:06:21Z", "merged_at": "2026-03-14T21:26:03Z", "base_ref_oid": "caa782aab7117e5dcfa394786d7e973652c1f6ab", "head_ref_oid": "7031a1bbbb3b3c533793dc4428d2d66c8bf5fd20", "base_commit": {"oid": "caa782aab7117e5dcfa394786d7e973652c1f6ab", "message": "Merge pull request #2858 from BentoBoxWorld/copilot/add-is-lock-command\n\nAdd /island lock command to toggle island lock state and expel visitors", "authoredDate": "2026-03-14T20:51:37Z", "author": {"name": "tastybento", "email": "tastybento@users.noreply.github.com", "user": {"login": "tastybento"}}}, "rounds": [], "threads": [], "agent_threads": [], "pr_review_class": "mixed", "compliance": {"total_threads": 0, "resolved": 0, "unresolved": 0, "compliance_rate": 0.0, "compliance_class": "unreviewed", "inline_threads": 0, "body_only_threads": 0, "compliance_band": "unreviewed", "n_agent_threads": 0}, "linked_issues": [{"number": 2862, "title": "Geo-limit-settings improvement", "body": "### Is your feature request related to a problem?\n\nI would like to add not only regular mobs, but also their projectiles, because they accumulate over time, such as snowballs or eggs.\n\n### Describe the solution you'd like.\n\nAdd to this geo-limit-settings as:\n\n```- fireball\n- small_fireball\n- dragon_fireball\n- firework_rocket\n- llama_spit\n- arrow\n- spectral_arrow\n- shulker_bullet\n- experience_bottle\n- egg\n- ender_pearl\n- eye_of_ender\n- snowball\n- potion\n- trident\n- wind_charge\n- breeze_wind_charge\n- wither_skull\n```\n\n### Describe alternatives you've considered.\n\nThere are none\n\n### Agreements\n\n- [x] I have searched for and ensured there isn't already an open issue regarding this.\n- [x] I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.\n\n### Other\n\nhttps://github.com/user-attachments/assets/8d179b05-3cf0-4c52-a475-05573c37f005", "state": "CLOSED", "created_at": "2025-08-06T16:54:43Z", "closed_at": "2026-03-14T21:26:05Z", "author_login": "Vinrey123", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 2863, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": 220.17474537037037, "issue_was_open_at_pr": false, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}], "has_inline_feedback": false, "feedback_track": "body_only", "changed_files": 3, "additions": 163, "deletions": 2, "author_association": "CONTRIBUTOR", "is_cross_repository": false, "files": [{"path": "src/main/java/world/bentobox/bentobox/listeners/flags/clicklisteners/GeoMobLimitTab.java", "additions": 35, "deletions": 2, "changeType": "MODIFIED", "base_content": "package world.bentobox.bentobox.listeners.flags.clicklisteners;\n\nimport java.util.Arrays;\nimport java.util.Comparator;\nimport java.util.List;\n\nimport org.bukkit.Material;\nimport org.bukkit.World;\nimport org.bukkit.entity.EntityType;\nimport org.bukkit.event.inventory.ClickType;\nimport org.eclipse.jdt.annotation.NonNull;\nimport org.eclipse.jdt.annotation.Nullable;\n\nimport world.bentobox.bentobox.BentoBox;\nimport world.bentobox.bentobox.api.addons.GameModeAddon;\nimport world.bentobox.bentobox.api.panels.Panel;\nimport world.bentobox.bentobox.api.panels.PanelItem;\nimport world.bentobox.bentobox.api.panels.PanelItem.ClickHandler;\nimport world.bentobox.bentobox.api.panels.Tab;\nimport world.bentobox.bentobox.api.panels.TabbedPanel;\nimport world.bentobox.bentobox.api.panels.builders.PanelItemBuilder;\nimport world.bentobox.bentobox.api.user.User;\nimport world.bentobox.bentobox.hooks.LangUtilsHook;\nimport world.bentobox.bentobox.util.Util;\n\n/**\n * Provides a tab GUI for viewing geo-limited mobs\n * @author tastybento\n *\n */\npublic class GeoMobLimitTab implements Tab, ClickHandler {\n\n    /**\n     * A list of all living entity types, minus some\n     */\n    private static final List<EntityType> LIVING_ENTITY_TYPES = Arrays.stream(EntityType.values())\n            .filter(EntityType::isAlive)\n            .filter(t -> !(t.equals(EntityType.PLAYER) || t.equals(EntityType.GIANT) || t.equals(EntityType.ARMOR_STAND)))\n            .sorted(Comparator.comparing(EntityType::name))\n            .toList();\n\n    public enum EntityLimitTabType {\n        GEO_LIMIT,\n        MOB_LIMIT\n    }\n\n    private final BentoBox plugin = BentoBox.getInstance();\n    private final User user;\n    private final EntityLimitTabType type;\n    private final World world;\n    private TabbedPanel parent;\n\n    /**\n     * @param user - user viewing the tab\n     * @param type - type of tab to show - Geo limit or Mob limit\n     * @param world - world where this tab is being used\n     */\n    public GeoMobLimitTab(@NonNull User user, @NonNull EntityLimitTabType type, World world) {\n        super();\n        this.user = user;\n        this.type = type;\n        this.world = world;\n    }\n\n    @Override\n    public boolean onClick(Panel panel, User user, ClickType clickType, int slot) {\n        // Case panel to Tabbed Panel to get the active page\n        TabbedPanel tp = (TabbedPanel)panel;\n        // Convert the slot and active page to an index\n        int index = tp.getActivePage() * 36 + slot - 9;\n        EntityType c = LIVING_ENTITY_TYPES.get(index);\n        if (type == EntityLimitTabType.MOB_LIMIT) {\n            if (plugin.getIWM().getMobLimitSettings(world).contains(c.name())) {\n                plugin.getIWM().getMobLimitSettings(world).remove(c.name());\n            } else {\n                plugin.getIWM().getMobLimitSettings(world).add(c.name());\n            }\n        } else {\n            if (plugin.getIWM().getGeoLimitSettings(world).contains(c.name())) {\n                plugin.getIWM().getGeoLimitSettings(world).remove(c.name());\n            } else {\n                plugin.getIWM().getGeoLimitSettings(world).add(c.name());\n            }\n        }\n        // Apply change to panel\n        panel.getInventory().setItem(slot, getPanelItem(c, user).getItem());\n        // Save settings\n        plugin.getIWM().getAddon(Util.getWorld(world)).ifPresent(GameModeAddon::saveWorldSettings);\n        return true;\n    }\n\n    @Override\n    public PanelItem getIcon() {\n        if (type == EntityLimitTabType.MOB_LIMIT) {\n            return new PanelItemBuilder().icon(Material.IRON_BOOTS).name(getName()).build();\n        } else {\n            return new PanelItemBuilder().icon(Material.CHAINMAIL_CHESTPLATE).name(getName()).build();\n\n        }\n    }\n\n    @Override\n    public String getName() {\n        return type == EntityLimitTabType.MOB_LIMIT ? user.getTranslation(\"protection.flags.LIMIT_MOBS.name\")\n                : user.getTranslation(\"protection.flags.GEO_LIMIT_MOBS.name\");\n    }\n\n    @Override\n    public List<@Nullable PanelItem> getPanelItems() {\n        // Make panel items\n        return LIVING_ENTITY_TYPES.stream().map(c -> getPanelItem(c, user)).toList();\n    }\n\n    @Override\n    public String getPermission() {\n        return \"\";\n    }\n\n    private PanelItem getPanelItem(EntityType c, User user) {\n        PanelItemBuilder pib = new PanelItemBuilder();\n        pib.name(LangUtilsHook.getEntityName(c, user));\n        pib.clickHandler(this);\n        if (type == EntityLimitTabType.MOB_LIMIT) {\n            if (!BentoBox.getInstance().getIWM().getMobLimitSettings(world).contains(c.name())) {\n                pib.icon(Material.GREEN_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.flags.LIMIT_MOBS.can\"));\n            } else {\n                pib.icon(Material.RED_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.flags.LIMIT_MOBS.cannot\"));\n            }\n        } else {\n            if (BentoBox.getInstance().getIWM().getGeoLimitSettings(world).contains(c.name())) {\n                pib.icon(Material.GREEN_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.panel.flag-item.setting-active\"));\n            } else {\n                pib.icon(Material.RED_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.panel.flag-item.setting-disabled\"));\n            }\n        }\n        return pib.build();\n    }\n\n    @Override\n    public TabbedPanel getParentPanel() {\n        return parent;\n    }\n\n    @Override\n    public void setParentPanel(TabbedPanel parent) {\n        this.parent = parent;\n    }\n\n}\n", "head_content": "package world.bentobox.bentobox.listeners.flags.clicklisteners;\n\nimport java.util.Arrays;\nimport java.util.Comparator;\nimport java.util.List;\nimport java.util.stream.Stream;\n\nimport org.bukkit.Material;\nimport org.bukkit.World;\nimport org.bukkit.entity.EntityType;\nimport org.bukkit.entity.Projectile;\nimport org.bukkit.event.inventory.ClickType;\nimport org.eclipse.jdt.annotation.NonNull;\nimport org.eclipse.jdt.annotation.Nullable;\n\nimport world.bentobox.bentobox.BentoBox;\nimport world.bentobox.bentobox.api.addons.GameModeAddon;\nimport world.bentobox.bentobox.api.panels.Panel;\nimport world.bentobox.bentobox.api.panels.PanelItem;\nimport world.bentobox.bentobox.api.panels.PanelItem.ClickHandler;\nimport world.bentobox.bentobox.api.panels.Tab;\nimport world.bentobox.bentobox.api.panels.TabbedPanel;\nimport world.bentobox.bentobox.api.panels.builders.PanelItemBuilder;\nimport world.bentobox.bentobox.api.user.User;\nimport world.bentobox.bentobox.hooks.LangUtilsHook;\nimport world.bentobox.bentobox.util.Util;\n\n/**\n * Provides a tab GUI for viewing geo-limited mobs\n * @author tastybento\n *\n */\npublic class GeoMobLimitTab implements Tab, ClickHandler {\n\n    /**\n     * A list of all living entity types, minus some\n     */\n    private static final List<EntityType> LIVING_ENTITY_TYPES = Arrays.stream(EntityType.values())\n            .filter(EntityType::isAlive)\n            .filter(t -> !(t.equals(EntityType.PLAYER) || t.equals(EntityType.GIANT) || t.equals(EntityType.ARMOR_STAND)))\n            .sorted(Comparator.comparing(EntityType::name))\n            .toList();\n\n    /**\n     * A list of projectile entity types (for geo-limiting projectiles)\n     */\n    private static final List<EntityType> PROJECTILE_ENTITY_TYPES = Arrays.stream(EntityType.values())\n            .filter(t -> !t.isAlive())\n            .filter(t -> {\n                Class<?> cls = t.getEntityClass();\n                return cls != null && Projectile.class.isAssignableFrom(cls);\n            })\n            .sorted(Comparator.comparing(EntityType::name))\n            .toList();\n\n    /**\n     * A combined list of living and projectile entity types for the GEO_LIMIT tab\n     */\n    private static final List<EntityType> GEO_LIMIT_ENTITY_TYPES = Stream.concat(\n            LIVING_ENTITY_TYPES.stream(),\n            PROJECTILE_ENTITY_TYPES.stream())\n            .sorted(Comparator.comparing(EntityType::name))\n            .toList();\n\n    public enum EntityLimitTabType {\n        GEO_LIMIT,\n        MOB_LIMIT\n    }\n\n    private final BentoBox plugin = BentoBox.getInstance();\n    private final User user;\n    private final EntityLimitTabType type;\n    private final World world;\n    private TabbedPanel parent;\n\n    /**\n     * @param user - user viewing the tab\n     * @param type - type of tab to show - Geo limit or Mob limit\n     * @param world - world where this tab is being used\n     */\n    public GeoMobLimitTab(@NonNull User user, @NonNull EntityLimitTabType type, World world) {\n        super();\n        this.user = user;\n        this.type = type;\n        this.world = world;\n    }\n\n    @Override\n    public boolean onClick(Panel panel, User user, ClickType clickType, int slot) {\n        // Case panel to Tabbed Panel to get the active page\n        TabbedPanel tp = (TabbedPanel)panel;\n        // Convert the slot and active page to an index\n        int index = tp.getActivePage() * 36 + slot - 9;\n        EntityType c = getEntityTypes().get(index);\n        if (type == EntityLimitTabType.MOB_LIMIT) {\n            if (plugin.getIWM().getMobLimitSettings(world).contains(c.name())) {\n                plugin.getIWM().getMobLimitSettings(world).remove(c.name());\n            } else {\n                plugin.getIWM().getMobLimitSettings(world).add(c.name());\n            }\n        } else {\n            if (plugin.getIWM().getGeoLimitSettings(world).contains(c.name())) {\n                plugin.getIWM().getGeoLimitSettings(world).remove(c.name());\n            } else {\n                plugin.getIWM().getGeoLimitSettings(world).add(c.name());\n            }\n        }\n        // Apply change to panel\n        panel.getInventory().setItem(slot, getPanelItem(c, user).getItem());\n        // Save settings\n        plugin.getIWM().getAddon(Util.getWorld(world)).ifPresent(GameModeAddon::saveWorldSettings);\n        return true;\n    }\n\n    @Override\n    public PanelItem getIcon() {\n        if (type == EntityLimitTabType.MOB_LIMIT) {\n            return new PanelItemBuilder().icon(Material.IRON_BOOTS).name(getName()).build();\n        } else {\n            return new PanelItemBuilder().icon(Material.CHAINMAIL_CHESTPLATE).name(getName()).build();\n\n        }\n    }\n\n    @Override\n    public String getName() {\n        return type == EntityLimitTabType.MOB_LIMIT ? user.getTranslation(\"protection.flags.LIMIT_MOBS.name\")\n                : user.getTranslation(\"protection.flags.GEO_LIMIT_MOBS.name\");\n    }\n\n    @Override\n    public List<@Nullable PanelItem> getPanelItems() {\n        // Make panel items\n        return getEntityTypes().stream().map(c -> getPanelItem(c, user)).toList();\n    }\n\n    @Override\n    public String getPermission() {\n        return \"\";\n    }\n\n    private PanelItem getPanelItem(EntityType c, User user) {\n        PanelItemBuilder pib = new PanelItemBuilder();\n        pib.name(LangUtilsHook.getEntityName(c, user));\n        pib.clickHandler(this);\n        if (type == EntityLimitTabType.MOB_LIMIT) {\n            if (!BentoBox.getInstance().getIWM().getMobLimitSettings(world).contains(c.name())) {\n                pib.icon(Material.GREEN_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.flags.LIMIT_MOBS.can\"));\n            } else {\n                pib.icon(Material.RED_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.flags.LIMIT_MOBS.cannot\"));\n            }\n        } else {\n            if (BentoBox.getInstance().getIWM().getGeoLimitSettings(world).contains(c.name())) {\n                pib.icon(Material.GREEN_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.panel.flag-item.setting-active\"));\n            } else {\n                pib.icon(Material.RED_SHULKER_BOX);\n                pib.description(user.getTranslation(\"protection.panel.flag-item.setting-disabled\"));\n            }\n        }\n        return pib.build();\n    }\n\n    /**\n     * Returns the list of entity types shown in this tab.\n     * The GEO_LIMIT tab includes both living entities and projectiles;\n     * the MOB_LIMIT tab includes only living entities.\n     * @return list of entity types for this tab\n     */\n    private List<EntityType> getEntityTypes() {\n        return type == EntityLimitTabType.GEO_LIMIT ? GEO_LIMIT_ENTITY_TYPES : LIVING_ENTITY_TYPES;\n    }\n\n    @Override\n    public TabbedPanel getParentPanel() {\n        return parent;\n    }\n\n    @Override\n    public void setParentPanel(TabbedPanel parent) {\n        this.parent = parent;\n    }\n\n}\n", "patch": "--- a/src/main/java/world/bentobox/bentobox/listeners/flags/clicklisteners/GeoMobLimitTab.java\n+++ b/src/main/java/world/bentobox/bentobox/listeners/flags/clicklisteners/GeoMobLimitTab.java\n@@ -3,10 +3,12 @@\n import java.util.Arrays;\n import java.util.Comparator;\n import java.util.List;\n+import java.util.stream.Stream;\n \n import org.bukkit.Material;\n import org.bukkit.World;\n import org.bukkit.entity.EntityType;\n+import org.bukkit.entity.Projectile;\n import org.bukkit.event.inventory.ClickType;\n import org.eclipse.jdt.annotation.NonNull;\n import org.eclipse.jdt.annotation.Nullable;\n@@ -39,6 +41,27 @@\n             .sorted(Comparator.comparing(EntityType::name))\n             .toList();\n \n+    /**\n+     * A list of projectile entity types (for geo-limiting projectiles)\n+     */\n+    private static final List<EntityType> PROJECTILE_ENTITY_TYPES = Arrays.stream(EntityType.values())\n+            .filter(t -> !t.isAlive())\n+            .filter(t -> {\n+                Class<?> cls = t.getEntityClass();\n+                return cls != null && Projectile.class.isAssignableFrom(cls);\n+            })\n+            .sorted(Comparator.comparing(EntityType::name))\n+            .toList();\n+\n+    /**\n+     * A combined list of living and projectile entity types for the GEO_LIMIT tab\n+     */\n+    private static final List<EntityType> GEO_LIMIT_ENTITY_TYPES = Stream.concat(\n+            LIVING_ENTITY_TYPES.stream(),\n+            PROJECTILE_ENTITY_TYPES.stream())\n+            .sorted(Comparator.comparing(EntityType::name))\n+            .toList();\n+\n     public enum EntityLimitTabType {\n         GEO_LIMIT,\n         MOB_LIMIT\n@@ -68,7 +91,7 @@\n         TabbedPanel tp = (TabbedPanel)panel;\n         // Convert the slot and active page to an index\n         int index = tp.getActivePage() * 36 + slot - 9;\n-        EntityType c = LIVING_ENTITY_TYPES.get(index);\n+        EntityType c = getEntityTypes().get(index);\n         if (type == EntityLimitTabType.MOB_LIMIT) {\n             if (plugin.getIWM().getMobLimitSettings(world).contains(c.name())) {\n                 plugin.getIWM().getMobLimitSettings(world).remove(c.name());\n@@ -108,7 +131,7 @@\n     @Override\n     public List<@Nullable PanelItem> getPanelItems() {\n         // Make panel items\n-        return LIVING_ENTITY_TYPES.stream().map(c -> getPanelItem(c, user)).toList();\n+        return getEntityTypes().stream().map(c -> getPanelItem(c, user)).toList();\n     }\n \n     @Override\n@@ -140,6 +163,16 @@\n         return pib.build();\n     }\n \n+    /**\n+     * Returns the list of entity types shown in this tab.\n+     * The GEO_LIMIT tab includes both living entities and projectiles;\n+     * the MOB_LIMIT tab includes only living entities.\n+     * @return list of entity types for this tab\n+     */\n+    private List<EntityType> getEntityTypes() {\n+        return type == EntityLimitTabType.GEO_LIMIT ? GEO_LIMIT_ENTITY_TYPES : LIVING_ENTITY_TYPES;\n+    }\n+\n     @Override\n     public TabbedPanel getParentPanel() {\n         return parent;\n"}, {"path": "src/main/java/world/bentobox/bentobox/listeners/flags/worldsettings/GeoLimitMobsListener.java", "additions": 13, "deletions": 0, "changeType": "MODIFIED", "base_content": "package world.bentobox.bentobox.listeners.flags.worldsettings;\n\nimport java.util.Map;\nimport java.util.WeakHashMap;\n\nimport org.bukkit.Bukkit;\nimport org.bukkit.entity.Entity;\nimport org.bukkit.entity.Projectile;\nimport org.bukkit.event.EventHandler;\nimport org.bukkit.event.EventPriority;\nimport org.bukkit.event.entity.CreatureSpawnEvent;\nimport org.bukkit.event.entity.EntityDeathEvent;\nimport org.bukkit.event.entity.ExplosionPrimeEvent;\nimport org.bukkit.projectiles.ProjectileSource;\n\nimport world.bentobox.bentobox.api.events.BentoBoxReadyEvent;\nimport world.bentobox.bentobox.api.flags.FlagListener;\nimport world.bentobox.bentobox.database.objects.Island;\n\n/**\n * Provide geo limiting to mobs - removed them if they go outside island bounds\n * @author tastybento\n *\n */\npublic class GeoLimitMobsListener extends FlagListener {\n\n    private final Map<Entity, Island> mobSpawnTracker = new WeakHashMap<>();\n\n    /**\n     * Start the tracker when the plugin is loaded\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onPluginReady(BentoBoxReadyEvent event) {\n        // Kick off the task to remove entities that go outside island boundaries\n        Bukkit.getScheduler().runTaskTimer(getPlugin(), () -> {\n            mobSpawnTracker.entrySet().stream()\n            .filter(e -> !e.getValue().onIsland(e.getKey().getLocation()))\n            .map(Map.Entry::getKey)\n            .forEach(Entity::remove);\n            mobSpawnTracker.keySet().removeIf(e -> e == null || e.isDead());\n        }, 20L, 20L);\n    }\n\n    /**\n     * Track where the mob was created. This will determine its allowable movement zone.\n     * @param e - event\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onMobSpawn(CreatureSpawnEvent e) {\n        if (getIWM().inWorld(e.getLocation())\n                && getIWM().getGeoLimitSettings(e.getLocation().getWorld()).contains(e.getEntityType().name())) {\n            getIslands().getIslandAt(e.getLocation()).ifPresent(i -> mobSpawnTracker.put(e.getEntity(), i));\n        }\n    }\n\n    /**\n     * Clean up the map when entity dies (does not handle entity removal)\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onMobDeath(final EntityDeathEvent e) {\n        mobSpawnTracker.remove(e.getEntity());\n    }\n\n    /**\n     * Deal with projectiles fired by entities\n     * @param e - event\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onProjectileExplode(final ExplosionPrimeEvent e) {\n        if (e.getEntity() instanceof Projectile projectile && getIWM().inWorld(e.getEntity().getLocation())) {\n            ProjectileSource source = projectile.getShooter();\n            if (source instanceof Entity shooter\n                    && mobSpawnTracker.containsKey(shooter)\n                    && !mobSpawnTracker.get(shooter).onIsland(e.getEntity().getLocation())) {\n                e.getEntity().remove();\n                e.setCancelled(true);\n            }\n        }\n    }\n}\n\n", "head_content": "package world.bentobox.bentobox.listeners.flags.worldsettings;\n\nimport java.util.Map;\nimport java.util.WeakHashMap;\n\nimport org.bukkit.Bukkit;\nimport org.bukkit.entity.Entity;\nimport org.bukkit.entity.Projectile;\nimport org.bukkit.event.EventHandler;\nimport org.bukkit.event.EventPriority;\nimport org.bukkit.event.entity.CreatureSpawnEvent;\nimport org.bukkit.event.entity.EntityDeathEvent;\nimport org.bukkit.event.entity.ExplosionPrimeEvent;\nimport org.bukkit.event.entity.ProjectileLaunchEvent;\nimport org.bukkit.projectiles.ProjectileSource;\n\nimport world.bentobox.bentobox.api.events.BentoBoxReadyEvent;\nimport world.bentobox.bentobox.api.flags.FlagListener;\nimport world.bentobox.bentobox.database.objects.Island;\n\n/**\n * Provide geo limiting to mobs - removed them if they go outside island bounds\n * @author tastybento\n *\n */\npublic class GeoLimitMobsListener extends FlagListener {\n\n    private final Map<Entity, Island> mobSpawnTracker = new WeakHashMap<>();\n\n    /**\n     * Start the tracker when the plugin is loaded\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onPluginReady(BentoBoxReadyEvent event) {\n        // Kick off the task to remove entities that go outside island boundaries\n        Bukkit.getScheduler().runTaskTimer(getPlugin(), () -> {\n            mobSpawnTracker.entrySet().stream()\n            .filter(e -> !e.getValue().onIsland(e.getKey().getLocation()))\n            .map(Map.Entry::getKey)\n            .forEach(Entity::remove);\n            mobSpawnTracker.keySet().removeIf(e -> e == null || e.isDead());\n        }, 20L, 20L);\n    }\n\n    /**\n     * Track where the mob was created. This will determine its allowable movement zone.\n     * @param e - event\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onMobSpawn(CreatureSpawnEvent e) {\n        if (getIWM().inWorld(e.getLocation())\n                && getIWM().getGeoLimitSettings(e.getLocation().getWorld()).contains(e.getEntityType().name())) {\n            getIslands().getIslandAt(e.getLocation()).ifPresent(i -> mobSpawnTracker.put(e.getEntity(), i));\n        }\n    }\n\n    /**\n     * Clean up the map when entity dies (does not handle entity removal)\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onMobDeath(final EntityDeathEvent e) {\n        mobSpawnTracker.remove(e.getEntity());\n    }\n\n    /**\n     * Track projectiles launched from within an island so they can be geo-limited.\n     * @param e - event\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onProjectileLaunch(final ProjectileLaunchEvent e) {\n        if (getIWM().inWorld(e.getEntity().getLocation())\n                && getIWM().getGeoLimitSettings(e.getEntity().getLocation().getWorld()).contains(e.getEntityType().name())) {\n            getIslands().getIslandAt(e.getEntity().getLocation()).ifPresent(i -> mobSpawnTracker.put(e.getEntity(), i));\n        }\n    }\n\n    /**\n     * Deal with projectiles fired by entities\n     * @param e - event\n     */\n    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n    public void onProjectileExplode(final ExplosionPrimeEvent e) {\n        if (e.getEntity() instanceof Projectile projectile && getIWM().inWorld(e.getEntity().getLocation())) {\n            ProjectileSource source = projectile.getShooter();\n            if (source instanceof Entity shooter\n                    && mobSpawnTracker.containsKey(shooter)\n                    && !mobSpawnTracker.get(shooter).onIsland(e.getEntity().getLocation())) {\n                e.getEntity().remove();\n                e.setCancelled(true);\n            }\n        }\n    }\n}\n\n", "patch": "--- a/src/main/java/world/bentobox/bentobox/listeners/flags/worldsettings/GeoLimitMobsListener.java\n+++ b/src/main/java/world/bentobox/bentobox/listeners/flags/worldsettings/GeoLimitMobsListener.java\n@@ -11,6 +11,7 @@\n import org.bukkit.event.entity.CreatureSpawnEvent;\n import org.bukkit.event.entity.EntityDeathEvent;\n import org.bukkit.event.entity.ExplosionPrimeEvent;\n+import org.bukkit.event.entity.ProjectileLaunchEvent;\n import org.bukkit.projectiles.ProjectileSource;\n \n import world.bentobox.bentobox.api.events.BentoBoxReadyEvent;\n@@ -62,6 +63,18 @@\n     }\n \n     /**\n+     * Track projectiles launched from within an island so they can be geo-limited.\n+     * @param e - event\n+     */\n+    @EventHandler(priority = EventPriority.LOW, ignoreCancelled = true)\n+    public void onProjectileLaunch(final ProjectileLaunchEvent e) {\n+        if (getIWM().inWorld(e.getEntity().getLocation())\n+                && getIWM().getGeoLimitSettings(e.getEntity().getLocation().getWorld()).contains(e.getEntityType().name())) {\n+            getIslands().getIslandAt(e.getEntity().getLocation()).ifPresent(i -> mobSpawnTracker.put(e.getEntity(), i));\n+        }\n+    }\n+\n+    /**\n      * Deal with projectiles fired by entities\n      * @param e - event\n      */\n"}, {"path": "src/test/java/world/bentobox/bentobox/listeners/flags/worldsettings/GeoLimitMobsListenerTest.java", "additions": 115, "deletions": 0, "changeType": "ADDED", "base_content": null, "is_new_file": true, "head_content": "package world.bentobox.bentobox.listeners.flags.worldsettings;\n\nimport static org.mockito.ArgumentMatchers.any;\nimport static org.mockito.Mockito.never;\nimport static org.mockito.Mockito.verify;\nimport static org.mockito.Mockito.when;\n\nimport java.util.ArrayList;\nimport java.util.List;\nimport java.util.Optional;\n\nimport org.bukkit.World;\nimport org.bukkit.entity.EntityType;\nimport org.bukkit.entity.Snowball;\nimport org.bukkit.event.entity.ProjectileLaunchEvent;\nimport org.junit.jupiter.api.AfterEach;\nimport org.junit.jupiter.api.BeforeEach;\nimport org.junit.jupiter.api.Test;\nimport org.mockito.Mock;\n\nimport world.bentobox.bentobox.CommonTestSetup;\n\n/**\n * Tests for {@link GeoLimitMobsListener}\n */\nclass GeoLimitMobsListenerTest extends CommonTestSetup {\n\n    private List<String> geoLimitList = new ArrayList<>();\n    private GeoLimitMobsListener listener;\n\n    @Mock\n    private Snowball snowball;\n\n    @Override\n    @BeforeEach\n    public void setUp() throws Exception {\n        super.setUp();\n        geoLimitList.add(\"SNOWBALL\");\n        when(iwm.getGeoLimitSettings(world)).thenReturn(geoLimitList);\n        when(iwm.inWorld(world)).thenReturn(true);\n        when(iwm.inWorld(location)).thenReturn(true);\n        when(location.getWorld()).thenReturn(world);\n        when(snowball.getType()).thenReturn(EntityType.SNOWBALL);\n        when(snowball.getLocation()).thenReturn(location);\n        when(im.getIslandAt(any())).thenReturn(Optional.of(island));\n\n        listener = new GeoLimitMobsListener();\n    }\n\n    @Override\n    @AfterEach\n    public void tearDown() throws Exception {\n        super.tearDown();\n    }\n\n    /**\n     * Test that a projectile in the geo-limit list is tracked when launched.\n     */\n    @Test\n    void testOnProjectileLaunchTracked() {\n        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n        listener.onProjectileLaunch(e);\n        // Verify that getIslandAt was called to track the projectile\n        verify(im).getIslandAt(location);\n    }\n\n    /**\n     * Test that a projectile NOT in the geo-limit list is NOT tracked.\n     */\n    @Test\n    void testOnProjectileLaunchNotInList() {\n        when(snowball.getType()).thenReturn(EntityType.ARROW);\n        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n        listener.onProjectileLaunch(e);\n        // Verify that getIslandAt was NOT called (not tracked)\n        verify(im, never()).getIslandAt(any());\n    }\n\n    /**\n     * Test that a projectile launched outside a BentoBox world is NOT tracked.\n     */\n    @Test\n    void testOnProjectileLaunchNotInWorld() {\n        when(iwm.inWorld(location)).thenReturn(false);\n        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n        listener.onProjectileLaunch(e);\n        // Verify that getIslandAt was NOT called (not tracked)\n        verify(im, never()).getIslandAt(any());\n    }\n\n    /**\n     * Test that a projectile launched outside any island is NOT tracked.\n     */\n    @Test\n    void testOnProjectileLaunchNoIsland() {\n        when(im.getIslandAt(any())).thenReturn(Optional.empty());\n        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n        listener.onProjectileLaunch(e);\n        // getIslandAt is called, but no island found so nothing is added to tracker\n        verify(im).getIslandAt(location);\n    }\n\n    /**\n     * Test that a projectile launched in a different world is NOT tracked.\n     */\n    @Test\n    void testOnProjectileLaunchDifferentWorld() {\n        when(location.getWorld()).thenReturn(org.mockito.Mockito.mock(World.class));\n        when(iwm.inWorld(location)).thenReturn(false);\n        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n        listener.onProjectileLaunch(e);\n        verify(im, never()).getIslandAt(any());\n    }\n\n}\n", "patch": "--- a/src/test/java/world/bentobox/bentobox/listeners/flags/worldsettings/GeoLimitMobsListenerTest.java\n+++ b/src/test/java/world/bentobox/bentobox/listeners/flags/worldsettings/GeoLimitMobsListenerTest.java\n@@ -0,0 +1,115 @@\n+package world.bentobox.bentobox.listeners.flags.worldsettings;\n+\n+import static org.mockito.ArgumentMatchers.any;\n+import static org.mockito.Mockito.never;\n+import static org.mockito.Mockito.verify;\n+import static org.mockito.Mockito.when;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+import java.util.Optional;\n+\n+import org.bukkit.World;\n+import org.bukkit.entity.EntityType;\n+import org.bukkit.entity.Snowball;\n+import org.bukkit.event.entity.ProjectileLaunchEvent;\n+import org.junit.jupiter.api.AfterEach;\n+import org.junit.jupiter.api.BeforeEach;\n+import org.junit.jupiter.api.Test;\n+import org.mockito.Mock;\n+\n+import world.bentobox.bentobox.CommonTestSetup;\n+\n+/**\n+ * Tests for {@link GeoLimitMobsListener}\n+ */\n+class GeoLimitMobsListenerTest extends CommonTestSetup {\n+\n+    private List<String> geoLimitList = new ArrayList<>();\n+    private GeoLimitMobsListener listener;\n+\n+    @Mock\n+    private Snowball snowball;\n+\n+    @Override\n+    @BeforeEach\n+    public void setUp() throws Exception {\n+        super.setUp();\n+        geoLimitList.add(\"SNOWBALL\");\n+        when(iwm.getGeoLimitSettings(world)).thenReturn(geoLimitList);\n+        when(iwm.inWorld(world)).thenReturn(true);\n+        when(iwm.inWorld(location)).thenReturn(true);\n+        when(location.getWorld()).thenReturn(world);\n+        when(snowball.getType()).thenReturn(EntityType.SNOWBALL);\n+        when(snowball.getLocation()).thenReturn(location);\n+        when(im.getIslandAt(any())).thenReturn(Optional.of(island));\n+\n+        listener = new GeoLimitMobsListener();\n+    }\n+\n+    @Override\n+    @AfterEach\n+    public void tearDown() throws Exception {\n+        super.tearDown();\n+    }\n+\n+    /**\n+     * Test that a projectile in the geo-limit list is tracked when launched.\n+     */\n+    @Test\n+    void testOnProjectileLaunchTracked() {\n+        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n+        listener.onProjectileLaunch(e);\n+        // Verify that getIslandAt was called to track the projectile\n+        verify(im).getIslandAt(location);\n+    }\n+\n+    /**\n+     * Test that a projectile NOT in the geo-limit list is NOT tracked.\n+     */\n+    @Test\n+    void testOnProjectileLaunchNotInList() {\n+        when(snowball.getType()).thenReturn(EntityType.ARROW);\n+        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n+        listener.onProjectileLaunch(e);\n+        // Verify that getIslandAt was NOT called (not tracked)\n+        verify(im, never()).getIslandAt(any());\n+    }\n+\n+    /**\n+     * Test that a projectile launched outside a BentoBox world is NOT tracked.\n+     */\n+    @Test\n+    void testOnProjectileLaunchNotInWorld() {\n+        when(iwm.inWorld(location)).thenReturn(false);\n+        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n+        listener.onProjectileLaunch(e);\n+        // Verify that getIslandAt was NOT called (not tracked)\n+        verify(im, never()).getIslandAt(any());\n+    }\n+\n+    /**\n+     * Test that a projectile launched outside any island is NOT tracked.\n+     */\n+    @Test\n+    void testOnProjectileLaunchNoIsland() {\n+        when(im.getIslandAt(any())).thenReturn(Optional.empty());\n+        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n+        listener.onProjectileLaunch(e);\n+        // getIslandAt is called, but no island found so nothing is added to tracker\n+        verify(im).getIslandAt(location);\n+    }\n+\n+    /**\n+     * Test that a projectile launched in a different world is NOT tracked.\n+     */\n+    @Test\n+    void testOnProjectileLaunchDifferentWorld() {\n+        when(location.getWorld()).thenReturn(org.mockito.Mockito.mock(World.class));\n+        when(iwm.inWorld(location)).thenReturn(false);\n+        ProjectileLaunchEvent e = new ProjectileLaunchEvent(snowball);\n+        listener.onProjectileLaunch(e);\n+        verify(im, never()).getIslandAt(any());\n+    }\n+\n+}\n"}], "agent_initiated": true, "agent_signals": {"layer": 1, "value": "copilot-swe-agent"}, "author_type": "agent", "reviewer_types": [], "interaction_type": "human_agent", "takeover_events": [], "first_human_takeover_ts": null, "merged_with_unresolved": false, "candidate_issues": [], "link_confidence": "explicit", "thread_chains": [], "author_self_reviewed": false, "fully_agent_authored": false, "requested_reviewers": [{"login_or_team": "tastybento", "kind": "user", "created_at": "2026-03-14T21:19:38Z"}], "review_request_removed": [], "reviewer_was_requested": false, "merged_by": "tastybento", "merge_commit_oid": "bdaeadc4f4761e7d3a2e05d49397b652fa559786", "merged_by_is_author": false, "maintainer_override": false, "referenced_file_contents": {}, "repo_is_fork": null, "repo_parent": null, "repo_collaborator_count": null, "hours_to_first_review": null, "median_response_latency_hours": null, "reviewer_count": 0, "merged_by_association": null, "n_commits": 2, "n_human_commits": 0, "n_agent_commits": 2, "n_bot_commits": 0, "agent_commit_ratio": 1.0, "repo_metadata": {"full_name": "BentoBoxWorld/BentoBox", "owner": "BentoBoxWorld", "name": "BentoBox", "stars": 392, "language": "Java", "license": "epl-2.0", "topics": [], "description": "Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.", "url": "https://github.com/BentoBoxWorld/BentoBox", "default_branch": "develop", "open_issues": 138, "forks": 147, "discovered_via": "license:epl-2.0 language:Java stars:201..1000 created:2008-01-01..2026-02-01 archived:false", "created_at": "2017-05-20T21:05:15Z", "pr_total_count": 922, "issue_total_count": 1873, "primary_language": "Java", "language_bytes": {}}, "conversation_comments": [{"id": "rest_4061430457", "body": "## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=BentoBoxWorld_BentoBox&pullRequest=2863) **Quality Gate passed**  \nIssues  \n![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&pullRequest=2863&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  \n![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&pullRequest=2863&issueStatuses=ACCEPTED)\n\nMeasures  \n![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=BentoBoxWorld_BentoBox&pullRequest=2863&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  \n![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=BentoBoxWorld_BentoBox&pullRequest=2863&metric=new_coverage&view=list)  \n![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=BentoBoxWorld_BentoBox&pullRequest=2863&metric=new_duplicated_lines_density&view=list)  \n  \n[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=BentoBoxWorld_BentoBox&pullRequest=2863)\n\n", "createdAt": "2026-03-14T21:24:41Z", "author": {"login": "sonarqubecloud[bot]"}}]}

Blobscan_blobscan_537/issues/Blobscan_blobscan_516.json

@@ -0,0 +1 @@
+{"number": 516, "title": "Starknet blob decoding contains wrong data", "body": "https://blobscan.com/blob/0x0150c4fc905316b21d5c6666866c78303d2c803375f05fce4e5b86698c695a72\r\n\r\n![image](https://github.com/user-attachments/assets/eae724aa-cfdb-4beb-96ad-699b65059eac)\r\n\r\nWe made a first implementation using [majin-blob](https://github.com/AbdelStark/majin-blob) that is already running in production. However some data look fishy:\r\n\r\n* Contract address doesn't look like it\r\n* Nonce doesn't look correct\r\n* Some more data can probably be decoded\r\n* Storage updates button is almost invisible\r\n* Storage updates are also be wrong (keys should be incremental numbers instead of random hex numbers)\r\n* 'Original Data' switcher should better say 'Raw data'", "state": "CLOSED", "created_at": "2024-08-24T09:31:00Z", "closed_at": "2024-09-20T00:07:00Z", "author_login": "PabloCastellano", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 537, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

CARTAvis_carta-frontend_2084/issues/CARTAvis_carta-frontend_1272.json

@@ -0,0 +1 @@
+{"number": 1272, "title": "Initial support for saving/restoring/sharing of workspaces (frontend)", "body": "As an extension to layouts, states are a full CARTA session, including the images loaded, render settings, animator status etc.\r\nIt should be possible to save such states and reload them. \r\n\r\nAssociated backend issue https://github.com/CARTAvis/carta-backend/issues/1185\r\n\r\n\r\nInitial work for v4 beta1: (edit by @veggiesaurus)\r\n\r\n- treat workspaces like layouts, in the sense that we have a list of them in CARTA, and stored in .carta/config or .carta/workspaces  (and in the database for controller users) This allows us to build up the functionality easily via the API stuff on the backend, and it will ensure that it works well for the controller and standalone.\r\n- exporting/importing will be done manually at first (e.g. copy-pasting to the carta folder)\r\n- temporary things (e.g. PV, moment images that haven't' been saved) don't get persisted\r\n\r\nWorking schema [here](https://cartavis.org/schemas/workspace_schema_1.json)\r\n\r\nThings to save:\r\n- CARTA version\r\n- ~~Layout, including docked widgets, floating widgets, and dialogs. This defines a set of active widgets and dialogs to be restored.~~ deferred\r\n- ~~The states of control UI elements in each active widget or dialog~~ deferred\r\n- Preferences ?\r\n- A list of loaded images\r\n- A list of regions\r\n- ~~A list of loaded catalogs~~ deferred\r\n- ~~A list of catalogs retrieved from remote services (either we keep the recipes of query or we keep a copy of remote catalogs as part~~ deferred\r\n\r\n\r\n", "state": "CLOSED", "created_at": "2020-11-18T22:22:16Z", "closed_at": "2023-05-03T14:32:18Z", "author_login": "jott3077", "comment_rounds": [{"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDcyOTk5ODQzOA==", "body": "@kswang1029 we've discussed this before, do we have an existing issue for it?", "createdAt": "2020-11-18T22:30:40Z", "updatedAt": "2020-11-18T22:30:40Z", "author": {"login": "veggiesaurus"}}, {"id": "MDEyOklzc3VlQ29tbWVudDczMDA0MTAwNA==", "body": "Sounds like (sort of) part of this https://github.com/CARTAvis/carta-frontend/issues/479\r\n\r\n", "createdAt": "2020-11-19T00:22:03Z", "updatedAt": "2020-11-19T00:25:47Z", "author": {"login": "kswang1029"}}, {"id": "MDEyOklzc3VlQ29tbWVudDczMDA0Mjc5NA==", "body": "This feature sounds more like an extension of session resume.", "createdAt": "2020-11-19T00:26:54Z", "updatedAt": "2020-11-19T00:26:54Z", "author": {"login": "kswang1029"}}, {"id": "MDEyOklzc3VlQ29tbWVudDczMDE2NzkzOA==", "body": "I think this is primarily a frontend issue.", "createdAt": "2020-11-19T06:49:39Z", "updatedAt": "2020-11-19T06:49:39Z", "author": {"login": "veggiesaurus"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDc0MDMwMjE5Mw==", "body": "not only reload them but capture the state and share it.", "createdAt": "2020-12-08T01:34:38Z", "updatedAt": "2020-12-08T01:34:38Z", "author": {"login": "arusstaylor"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 2084, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["enhancement", "requiring backend"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}