Upload folder using huggingface_hub (part 434)

.gitattributes

@@ -688,3 +688,5 @@ tuomount_Open-Realms-of-Stars_645/pr.json filter=lfs diff=lfs merge=lfs -text
 tutao_tutanota_10178/pr.json filter=lfs diff=lfs merge=lfs -text
 tutao_tutanota_4931/pr.json filter=lfs diff=lfs merge=lfs -text
 tutao_tutanota_4995/pr.json filter=lfs diff=lfs merge=lfs -text
+tutao_tutanota_5791/pr.json filter=lfs diff=lfs merge=lfs -text
+tutao_tutanota_6345/pr.json filter=lfs diff=lfs merge=lfs -text

tutao_tutanota_5278/issues/tutao_tutanota_3006.json

@@ -0,0 +1 @@
+{"number": 3006, "title": "Use system preference for light/dark theme", "body": "## User story\r\nAs a user i want the default theme of the Tutanota app to follow the system preference so that I don't have to think about changing the tutanota theme when the system theme changes\r\n\r\n## AC\r\n* (mobile) When the app starts, the splash screen should be shown in the selected theme\r\n* there is an option to use the system theme in the appearance settings\r\n  * if the current theme is light, we use the red light theme\r\n  * if it's in dark/night mode, we use the dark theme\r\n  * if no theme is persisted we use the system default theme\r\n* themes are only persisted if the decision was explicitly made\r\n* persisted themes are kept (no change to the setting if there is something stored)\r\n* if the system preference setting is used, we check the theme when the app receives focus\r\n* on desktop, after the theme change is detected, there is no flash of the previous theme even on windows that were in the background\r\n* the theming of whitelabel domains stays as it is\r\n\r\n## Test notes\r\nEach test on web, desktop, iOS, Android\r\n\r\n - [x] Regression testing for normal dark/light themes\r\n - [x] Regression testing for whitelabel editor\r\n        See #5827 \r\n - [x] Regression testing for whitelabel theme\r\n - [x] Test that when \"system\" preference is set, dark/light is picked up correctly on startup\r\n - [x] Test that when \"system\" preference is set dark/light is changed together with the system\r\n        **Unless there is an active whitelabel custom color theme. In that case, the text stays at \"System\"**\r\n - [x] Check that \"system\" is the new default for fresh installations\r\n       **On first startup the preference text field is empty but the App defaults to light theme. The text \"ligth\" appears on second startup. App was installed while phone's theme is set to dark. Tested with and without active whitelabel colors**\r\n\r\n## Tester's notes\r\nLogin on Android is randomly stuck at \"offline\" for about 5s. Regardless of whether theme is set to \"System\".\r\n\r\n## Notes\r\nUsually the mobile operating systems provide an option to set a system light or dark mode. We want to pick up that setting and update the Tutanota theme according to that configuration. \r\n\r\nOperating systems also provide a setting that light/dark  theme selection changes depending on time. We don't know yet what is the best option to synchronize the theme in that case. The idea is to check the setting each time the app receives focus (put to foreground)\r\n\r\n## Original comment\r\nI do not use the forum so I will try to write here. I hope they will understand me. \r\n\r\nIn Tutanota there is a light and dark theme, it would be great if you could configure the function in the settings so that the themes change automatically depending on the time on the computer or the user's time zone. \r\n\r\nThanks.", "state": "CLOSED", "created_at": "2021-05-02T12:11:43Z", "closed_at": "2023-08-30T14:20:49Z", "author_login": "", "comment_rounds": [{"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDgzMTA2MTAwNQ==", "body": "For web client see [prefers-color-scheme](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme).", "createdAt": "2021-05-03T06:53:20Z", "updatedAt": "2021-05-03T06:53:20Z", "author": {"login": "jowlo"}}, {"id": "MDEyOklzc3VlQ29tbWVudDgzMTIzOTczOA==", "body": "I think we should not switch between light and dark mode based on the system time but only based on system preference.\r\n\r\nAt least for android i know that it is quite easy to switch the system wide dark/light preference based on time (or sunset) and we would then change in the app as well.", "createdAt": "2021-05-03T12:53:53Z", "updatedAt": "2021-05-03T12:53:53Z", "author": {"login": "jowlo"}}, {"id": "MDEyOklzc3VlQ29tbWVudDgzMTI4MDcyOA==", "body": "You can configure in your system when its daytime and when it's not. We should not implement our logic, I agree completely.", "createdAt": "2021-05-03T14:03:43Z", "updatedAt": "2021-05-03T14:03:43Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs49lZng", "body": "I'd hope this would be a simple addition to ad!\r\n\r\nMajority of apps and websites now support automatic switching of day and night mode based on system prefs. \r\nSurely this would be like a few lines of code as already the backbone of the day and night theme is there!\r\n\r\nWould be a good update and easy one :)\r\n\r\nAt the very least, Whitelabel users should be able to add in custom css code even\r\n\r\n.day   { background: #eee; color: black; }\r\n.night { background: #333; color: white; }\r\n\r\n@media (prefers-color-scheme: dark) {\r\n  .day.dark-scheme   { background:  #333; color: white; }\r\n  .night.dark-scheme { background: black; color:  #ddd; }\r\n}\r\n\r\n@media (prefers-color-scheme: light) {\r\n  .day.light-scheme   { background: white; color:  #555; }\r\n  .night.light-scheme { background:  #eee; color: black; }\r\n}\r\n\r\n.day, .night {\r\n  display: inline-block;\r\n  padding: 1em;\r\n  width: 7em;\r\n  height: 2em;\r\n  vertical-align: middle;\r\n}", "createdAt": "2022-02-09T00:52:47Z", "updatedAt": "2022-02-09T00:56:46Z", "author": {"login": "rightsaidfred99"}}, {"id": "IC_kwDOAVT0qs49mbDN", "body": "@rightsaidfred99 I also want to have it but it's more complicated than a few lines. We need a new preference value for selected theme and we need to have detection in the native part of each app.", "createdAt": "2022-02-09T08:27:52Z", "updatedAt": "2022-02-09T08:27:52Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5ASxsg", "body": "> @rightsaidfred99 I also want to have it but it's more complicated than a few lines. We need a new preference value for selected theme and we need to have detection in the native part of each app.\r\n\r\nI don't understand, isn't Tutanota a web interface so basically CSS can be used for theming? \r\n\r\nWhy would it not be possible to use this so that the client has system ui as light and Tutanota defaults to red/light UI and when client has system ui to dark, Tutanota uses  default dark UI? \r\n\r\n[prefers-color-scheme](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme).\r\n\r\nThis would work, Mac, Windows, android etc...surely?", "createdAt": "2022-03-25T05:17:09Z", "updatedAt": "2022-03-25T05:18:43Z", "author": {"login": "rightsaidfred99"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5AziPi", "body": "We do generate css programmatically so it's not as easy as just applying a bit of CSS.\r\n\r\nIn addition we have:\r\n - 2 light themes\r\n - whitelabel themes (which are handled in web and apps)\r\n - whitelabel theme editor (which applies the theme only whilte editing)\r\n - mobile/desktop apps (which also make use of colors although this could be changed slightly but they also need to use *some* system API to query dark theme status)\r\n - we need to introduce another preference, codify it into UI and change our already not so simple theming model\r\n\r\nThis is a desirable feature but it's not three lines, it never is.", "createdAt": "2022-04-04T08:14:48Z", "updatedAt": "2022-04-04T08:14:48Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5H5l7G", "body": "In some other applications (also Electron) the selection of system theme in the theme menu defaults to the regular light/dark theme (which imo is a good enough v1) or allows you to choose two separate ones for light/dark. ", "createdAt": "2022-08-05T10:09:57Z", "updatedAt": "2022-08-05T10:09:57Z", "author": {"login": "bufothefrog"}}, {"id": "IC_kwDOAVT0qs5H85yN", "body": "Can you also apply dark css for the content of the email (similar to darkreader browser extension)? \r\nHtml emails are often sent by companies and those burn eyes because there is no dark mode.", "createdAt": "2022-08-06T05:03:15Z", "updatedAt": "2022-08-06T05:03:15Z", "author": {"login": "Magical898"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5h7kZU", "body": "Any update on this one? Most Android/iOS apps automatically adapt to the system theme, and it'd be great to not have to switch the theme manually each day.\r\n\r\nThanks to the devs for all that you do! \u2764\ufe0f", "createdAt": "2023-07-20T02:16:30Z", "updatedAt": "2023-07-20T02:16:30Z", "author": {"login": "WannabeSmith"}}, {"id": "IC_kwDOAVT0qs5h9UYw", "body": "It is scheduled so hopefully it's not too far", "createdAt": "2023-07-20T08:03:11Z", "updatedAt": "2023-07-20T08:03:11Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5lZLzs", "body": "Login on Android is randomly stuck at \"offline\" for about 5s. Regardless of whether theme is set to \"System\".", "createdAt": "2023-08-31T14:01:53Z", "updatedAt": "2023-08-31T14:02:18Z", "author": {"login": "kibibytium"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5mcOtN", "body": "On Linux, where does tutanota read the preferred theme? I switch to dark mode with \r\n```\r\ngsettings set org.gnome.desktop.interface color-scheme 'prefer-dark'\r\ngsettings set org.gnome.desktop.interface gtk-theme Adwaita-dark\r\n```\r\nbut tutanota doesn't seem to respect the theme. Is there something else I should set? I skimmed the code but must've missed how it actually gets the theme. I know the preferred theme is visible to electron apps because signal desktop switches with the theme", "createdAt": "2023-09-14T02:52:26Z", "updatedAt": "2023-09-14T03:21:17Z", "author": {"login": "jm355"}}, {"id": "IC_kwDOAVT0qs5mc9bm", "body": "@jeremiah-miller If you haven't already, you also need to set the \"System\" option in Settings -> Appearance -> Switch Color Theme, then it should work.", "createdAt": "2023-09-14T06:55:58Z", "updatedAt": "2023-09-14T06:56:09Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5mfF8_", "body": "Yep, it's set to \"System\"", "createdAt": "2023-09-14T13:12:14Z", "updatedAt": "2023-09-14T13:12:14Z", "author": {"login": "jm355"}}, {"id": "IC_kwDOAVT0qs5mgFFf", "body": "that sounds like a bug then. the relevant code for the preference is in the `ThemeController.ts` file for the web renderer and the `DesktopThemeFacade.ts` for the node side of the equation. If you can make an issue with your setup and repro steps, we'll take a look at it.", "createdAt": "2023-09-14T15:33:36Z", "updatedAt": "2023-09-14T15:34:02Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5mgd-5", "body": "Created #5886", "createdAt": "2023-09-14T16:38:19Z", "updatedAt": "2023-09-14T16:38:19Z", "author": {"login": "jm355"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5278, "link_type": "closing_keyword", "will_close": true, "comment_count": 17, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["improvement", "state:tested", "state:done", "ui"], "milestone": "3.118.4", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5287/issues/tutao_tutanota_5166.json

@@ -0,0 +1 @@
+{"number": 5166, "title": "Stored credentials are not updated after changing password", "body": "When you change the password on one client, stored credentials on all other clients are not updated after the first login. The user is prompted for a password each time. \r\n\r\nThis affects all platforms.\r\n\r\n\r\n## Test Notes:\r\n* [x] Premium Account\r\n  * [x] login on two devices, both with stored credentials\r\n    * [x] change credentials on one of the two devices\r\n    * [x] you should get logged out of the second device\r\n    * [x] click on the stored credentials on the device where you just got logged out\r\n    * [x] you are prompted to type in the new password and can use the mailbox afterwards\r\n    * [x] log out\r\n    * [x] when you log in again you are not asked for credentials again and everything works fine\r\n  * [x] have stored credentials on two devices but only be logged in on one device\r\n    * [x] change password on the device where you're logged in\r\n    * [x] shows same behavior like above\r\n  * [x] use an account that has a second factor registered and store credentials on two devices\r\n    * [x] you can change the password without being prompted to use the second factor\r\n    * [x] on the other you are prompted to use the second factor FIXME\r\n  * [x] login on two devices, both with stored credentials\r\n    * [x] change credentials on one of the two devices\r\n    * [x] you should get logged out of the second device\r\n    * [x] deactivate internet connection\r\n    * [x] click on the stored credentials on the device where you just got logged out\r\n    * [x] offline login works fine\r\n    * [x] activate internet again\r\n    * [x] try to reconnect and you are prompted for the password again FIXME\r\n* [x] Free Account\r\n  * [x] login on two devices, both with stored credentials\r\n    * [x] change credentials on one of the two devices\r\n    * [x] you should get logged out of the second device\r\n    * [x] click on the stored credentials on the device where you just got logged out\r\n    * [x] the credentials are deleted completely\r\n    * [x] the mailbox works after you have logged in again\r\n  * [x] have stored credentials on two devices but only be logged in on one device\r\n    * [x] change password on the device where you're logged in\r\n    * [x] shows same behavior like above\r\n  * [x] use an account that has a second factor registered and store credentials on two devices\r\n    * [x] you can change the password without being prompted to use the second factor\r\n    * [x] click on the stored credentials on the device where you just got logged out\r\n    * [x] the credentials are deleted completely\r\n    * [x] the mailbox works after you have logged in again and were prompted for the second factor\r\n * [x] External Login\r\n   * [x] when the tutanota sender changes the shared password and sends a new mail, the old external login link does not work anymore (no login attempt possible)\r\n   * [x] if the password is changed (and new mail is sent) while logged in, the external user can keep using the mailbox until they log out, then the outdated link message is shown\r\n\r\n## Regressions\r\n* [x] the phishing/spam banner still works\r\n* [x] the phishing/spam banner does not show tutanota.com links for non-admin whitelabel users\r\n* [x] creating more calendars works for premium only\r\n* [x] sending calendar invite still works\r\n* [x] calendar event popup still shows the bell icon for alarms\r\n* [x] creating users works\r\n* [x] creating aliases works\r\n* [x] creating contacts works\r\n* [x] in single-column mode, the bottom nav only shows the calendar/contact/search buttons for internal users\r\n* [x] the progress bar in the header works as expected when syncing\r\n* [x] header shortcuts (contact/calendar etc) work, but only while logged in\r\n* [x] contact form requests and login work\r\n* [x] recovering a login works with recovery dialog and for resetting the 2nd factor\r\n* [x] editing the custom external notification mail for whitelabel still works\r\n* [x] inbox rules are still applied and can be edited\r\n* [x] password strength indicator still works (try using the user's name, mail address, ....)\r\n* [x] out of office notifications work as expected\r\n* [x] trying to use a business feature (like adding a template group) shows the business upgrade dialog on plain premium\r\n* [x] we can open the mailbox from a mailto link or a notification in desktop\r\n* [x] calendar opens from an alarm notification\r\n* [x] search for longer than the 30 days (?) still requires premium\r\n* [x] the search overlay only shows the \"change time period\" text to premium\r\n* [x] adding groups works\r\n* [x] displaying the recover code works\r\n* [x] appearance settings are applied from the users account info\r\n* [x] signature can be edited and is applied\r\n* [x] global settings view loads fine\r\n* [x] sending/accepting calendar share works\r\n* [x] purchasing / redeeming gift cards works\r\n* [x] premium/free/business signup works\r\n* [x] deleting an account works, with takeover\r\n* [x] templates can be edited and applied", "state": "CLOSED", "created_at": "2023-02-23T12:46:31Z", "closed_at": "2023-03-24T14:55:06Z", "author_login": "kibibytium", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5XwOtU", "body": "after the password is changed from another client and we try to resume the session:\n\n* we create a new session, then log out after a while, then try to use these credentials again\n* with the new credentials, we call resumeSession, then initSession\n* here we request the user (to get a verifier among other things)\n* this is served from the outdated cache, old verifier?\n* the checkOutdatedPassword checks the verifier against the passphrase and fails throwing NotAuthenticatedError\n* this causes us to go into the offline login auth flow again\n\npossibility after we delete user from cache (need to think about inconsistencies):\n* user not there -> fall back to sync login?\n\nquestion: why is no entity event update applied after we log in with the new password?", "createdAt": "2023-03-16T16:04:20Z", "updatedAt": "2023-03-16T16:04:54Z", "author": {"login": "nokhub"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5YuMzH", "body": "During testing: When you change the password on an ipad, the entire app closes and when opened again the credentials are not saved and it brings you to the login screen.\r\n\r\nAlso, app on ipad will crash and delete credentials when you log in on another device while the app is open.", "createdAt": "2023-03-29T12:24:25Z", "updatedAt": "2023-03-29T14:05:02Z", "author": {"login": "wrdhub"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "state:tested", "state:done"], "milestone": "3.112.5", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5291/issues/tutao_tutanota_4951.json

@@ -0,0 +1 @@
+{"number": 4951, "title": "", "body": "", "state": "", "created_at": "", "closed_at": null, "author_login": "", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5Se2nT", "body": "Check if we still receive these errors after  3.108.xx has been released", "createdAt": "2023-01-16T10:23:13Z", "updatedAt": "2023-01-16T10:23:13Z", "author": {"login": "bedhub"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5TQqi5", "body": "we have a repro in the reports mailbox (the offending mail is in the BadRequestError folder):  \r\n\r\n```\r\nClient: linux\r\nType: PREMIUM\r\nTutanota version: 3.106.5\r\nTimestamp (UTC): Thu, 19 Jan 2023 12:06:52 GMT\r\nUser agent:\r\nMozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) tutanota-desktop/3.106.5 Chrome/108.0.5359.62 Electron/22.0.0 Safari/537.36\r\nBadRequestError\r\nError message: 400: NM8vAaS----9 | PUT /rest/tutanota/mail/NKxWKxk--7-9/NM8n0fs----9\r\nStacktrace:\r\nBadRequestError: 400: NM8vAaS----9 | PUT /rest/tutanota/mail/NKxWKxk--7-9/NM8n0fs----9\r\nat cP (asset://app/common-min-ad5cd377.js:1:7485)\r\nat l.onload (asset://app/worker.js:12:100956)\r\n```", "createdAt": "2023-01-19T12:08:29Z", "updatedAt": "2023-01-19T12:08:29Z", "author": {"login": "ganthern"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5UreKH", "body": "This seems to have cleared up completely with 3.108.x and the mail that did this in the reports mailbox is also fine now, can be set read/unread and everything.", "createdAt": "2023-02-07T12:18:12Z", "updatedAt": "2023-02-07T12:18:12Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5U4B1I", "body": "It still comes up with 3.108.12", "createdAt": "2023-02-09T10:38:46Z", "updatedAt": "2023-02-09T10:38:46Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5U9yt1", "body": "Might be related to #4664 ", "createdAt": "2023-02-10T09:23:36Z", "updatedAt": "2023-02-10T09:23:36Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5VpuwD", "body": "Investigating one case of the ghost email it seems like the same email is in two folders, there were few update and move events but the latest move (to trash) was not (fully) processed. We don't see how it could happen so far.", "createdAt": "2023-02-20T13:09:20Z", "updatedAt": "2023-02-20T13:09:20Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5XAjTO", "body": "A case in the browser:\r\n\r\n> Not sure what happened. I was just clicking through and deleting emails.\r\n\r\nClient: Browser\r\nType: PREMIUM\r\nTutanota version: 3.110.0\r\nTimestamp (UTC): Mon, 06 Mar 2023 18:43:26 GMT\r\nUser agent:\r\nMozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36\r\nBadRequestError\r\nError message: 400: NPsE4Ex----9 | PUT /rest/tutanota/mail/NBERYmx--k-2/NPqbVGM----9\r\nStacktrace:\r\nBadRequestError: 400: NPsE4Ex----9 | PUT /rest/tutanota/mail/NBERYmx--k-2/NPqbVGM----9\r\nat cW (https://mail.tutanota.com/common-min-3277242d.js:1:7560)\r\nat l.onload (https://mail.tutanota.com/worker.js:12:23203)\r\n\r\nUser Responded:\r\n> I do typically have 2 tabs with Tutanota, one for emails, the other for the calendar.  This is the first time I've gotten this error.\r\n\r\nWorker Log:\r\n```\r\n2023-03-06T16:17:43.685Z I \"ws connect reconnect:\",false,\"state:\",\"terminated\"\r\n2023-03-06T16:17:43.686Z I \"initIndexer after log in\"\r\n2023-03-06T16:17:43.857Z I \"ws open state:\",\"automatic\"\r\n2023-03-06T16:17:43.858Z I \"New leader status set:\",false\r\n2023-03-06T16:17:44.404Z I \"{\\\"indexingTime\\\":0,\\\"storageTime\\\":0,\\\"preparingTime\\\":0,\\\"mailcount\\\":0,\\\"storedBytes\\\":0,\\\"encryptionTime\\\":0,\\\"writeRequests\\\":0,\\\"largestColumn\\\":0,\\\"words\\\":0,\\\"indexedBytes\\\":0,\\\"downloadingTime\\\":0}\",\"total time: \",0\r\n2023-03-06T16:17:45.598Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPp1nop----9\"\r\n2023-03-06T16:17:46.971Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPqbVPm----9\"\r\n2023-03-06T17:51:34.354Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs2Bzv----9\"\r\n2023-03-06T17:51:34.367Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs2CBV----9\"\r\n2023-03-06T17:58:55.375Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs3sxM----9\"\r\n2023-03-06T18:08:56.451Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs6AhH----9\"\r\n2023-03-06T18:09:00.676Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs6BjJ----9\"\r\n2023-03-06T18:09:10.450Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs6E70----9\"\r\n2023-03-06T18:09:12.393Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs6EaL----9\"\r\n2023-03-06T18:10:27.885Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs6Wzk----9\"\r\n2023-03-06T18:16:56.843Z I \"ws close event:\",{\"isTrusted\":true},\"state:\",\"automatic\"\r\n2023-03-06T18:16:56.844Z I \"New leader status set:\",false\r\n2023-03-06T18:16:56.844Z I \"ws tryReconnect closeIfOpen:\",false,\"enableAutomaticState:\",false,\"delay:\",6000\r\n2023-03-06T18:17:02.852Z I \"ws reconnect socket.readyState: (CONNECTING=0, OPEN=1, CLOSING=2, CLOSED=3): 3\",\"state:\",\"automatic\",\"closeIfOpen:\",false,\"enableAutomaticState:\",false\r\n2023-03-06T18:17:02.956Z I \"ws connect reconnect:\",true,\"state:\",\"automatic\"\r\n2023-03-06T18:17:03.498Z I \"ws open state:\",\"automatic\"\r\n2023-03-06T18:17:03.500Z I \"New leader status set:\",true\r\n2023-03-06T18:20:55.310Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs8uvP----9\"\r\n2023-03-06T18:20:55.337Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPs8v7S----9\"\r\n2023-03-06T18:35:43.887Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsCJ8y--7-9\"\r\n2023-03-06T18:35:46.425Z I \"[RestClient]\",\"failed request\",\"GET\",\"https://mail.tutanota.com/rest/sys/publickeyservice?_body=<redacted>\",404,\"\",[\"accessToken\",\"v\",\"cv\",\"Content-Type\",\"Accept\"],\"[63 characters]\"\r\n2023-03-06T18:37:23.430Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsCg3H----9\"\r\n2023-03-06T18:37:26.142Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsCh46----9\"\r\n2023-03-06T18:37:42.849Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsClBQ----9\"\r\n2023-03-06T18:37:45.593Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsClrN----9\"\r\n2023-03-06T18:37:47.499Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsCmK4----9\"\r\n2023-03-06T18:37:48.060Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsCmQQ----9\"\r\n2023-03-06T18:38:53.415Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsD1Pf----9\"\r\n2023-03-06T18:43:04.698Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsDzKi----9\"\r\n2023-03-06T18:43:04.722Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsDzbj----9\"\r\n2023-03-06T18:43:08.513Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsE-gj----9\"\r\n2023-03-06T18:43:14.473Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsE18t----9\"\r\n2023-03-06T18:43:21.355Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsE2pg----9\"\r\n2023-03-06T18:43:26.220Z W \"Abort transaction on updating group data: concurrent access\",\"NBERYmv--N-2\",\"NPsE40f----9\"\r\n2023-03-06T18:43:26.916Z I \"[RestClient]\",\"failed request\",\"PUT\",\"https://mail.tutanota.com/rest/tutanota/mail/NBERYmx--k-2/NPqbVGM----9\",400,\"\",[\"accessToken\",\"v\",\"cv\",\"Content-Type\",\"Accept\"],\"[2111 characters]\"\r\n```", "createdAt": "2023-03-08T08:48:07Z", "updatedAt": "2023-03-08T08:48:07Z", "author": {"login": "ganthern"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5XgXyE", "body": "It might be related to `SessionKeyNotFoundError` for Mail that is happening since the offline release.\n\nAfter checking with @armhub we've discovered that the mail has the `_finalEncrypted` fields which means it was already successfully decrypted **but** it has no `_ownerEncSessionKey` set. It is unclear yet how it happens but it seems like we are saving an entity to the cache which doesn't have `_ownerEncSessionKey`. This should not happen.", "createdAt": "2023-03-14T13:27:51Z", "updatedAt": "2023-03-14T13:27:51Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5XhvRL", "body": "After looking closely and for a long time at `CryptoFacade` I think these are the cases and how we handle them:\n\n1. If the key is in the cache we **don't** write it to the instance\n2. If it is resolved via `.bucketKey` aggregate it will *invoke server update* with a **delay**\n3. If it's there, it's there\n4. It is' Symmetric permission, we **don't** write it to the instance\n5. If it's External bucket, we **don't** write it **nor** update it on the instance\n6. If it's Public bucket, we **only** write and update it if we are the **leader** client\n\nIn most of these cases (except for 3.) we might end with a *decrypted* instance *without* `_ownerEncSessionKey`, even if temporarily (until the update with the session key comes in). As the key should be the same for all clients I don't see a problem with always setting it on the instance.", "createdAt": "2023-03-14T16:47:57Z", "updatedAt": "2023-03-14T16:47:57Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5Xl6qg", "body": "It could work with the old permission system, we tried this approach first while implementing the new permission system (BucketKey), but this was problematic at the end. \r\nWith the new permission system we must resolve the session key always with the bucket key as long as all the ownerEncSession keys (including attachments) have been updated on the server\r\nand made their roundtrip to the client. Writing these temporary ownerEncSession keys on the instance (Mail) might lead to a situation that we cannot resolve the session key for an attachment in the\r\nnew permission system.\r\n\r\nSo i think we should find another solution.\r\n\r\nI assume that we receive this error now because the client is doing a put request with ownerEncSessionKey=null while the state  on the server is already not null.\r\n\r\nTo solve this we could either \r\n\r\na) Implement partial update (so put request do not always include the full instance) or\r\nb) Ignore updates of the ownerEncSessionKey from the client in a regular put request. \r\n\r\nI am in favor of option b for now. As for both permission systems (old and new) We have special requests to update the ownerEncSession key. We should just rely on them and ingore setting\r\nthis field for regular put requests.\r\n", "createdAt": "2023-03-15T08:24:31Z", "updatedAt": "2023-03-15T08:24:31Z", "author": {"login": "bedhub"}}, {"id": "IC_kwDOAVT0qs5XmNjw", "body": "I'm for option A \ud83d\ude0a\r\n\r\nServer side is already halfway implemented i think (see tutadb#1331)", "createdAt": "2023-03-15T09:17:01Z", "updatedAt": "2023-03-15T09:18:11Z", "author": {"login": "mpfau"}}, {"id": "IC_kwDOAVT0qs5XmPDe", "body": "> Writing these temporary ownerEncSession keys on the instance (Mail) might lead to a situation that we cannot resolve the session key for an attachment in the\r\nnew permission system.\r\n\r\nI am not sure why this is is the case yet. I would be in favor of keeping the key on the instance once we resolve it because there still might be a situation where we will try to resolve the key again and if we can avoid it, we should.", "createdAt": "2023-03-15T09:21:05Z", "updatedAt": "2023-03-15T09:21:05Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5X1tUX", "body": "> > Writing these temporary ownerEncSession keys on the instance (Mail) might lead to a situation that we cannot resolve the session key for an attachment in the\r\n> > new permission system.\r\n> \r\n> I am not sure why this is is the case yet. I would be in favor of keeping the key on the instance once we resolve it because there still might be a situation where we will try to resolve the key again and if we can avoid it, we should.\r\n\r\nIt is the case because the `bucketKey` on the mail is used to get the session keys for attached files and the `MailDetailsBlob` instances. When decrypting the \"leading\" mail instance using the `bucketKey`, we store the session keys in the session key cache and then use it later when we need to decrypt on the associated instances.\r\n\r\nI am in favor of option B. Just not making requests fail, based on whether they have an `ownerEncSessionKey` set, seems to be a rather simple yet reasonable fix. We could even write it to the mail if it is set in the request. We would just need to make sure, that we resolve the session key of mail instances using the `bucketKey` even if there is an `ownerEncSessionKey` set. This should already be the case. The `bucketKey` will be removed from the mail once all session keys it can resolve were written to the associated instances.", "createdAt": "2023-03-17T11:32:19Z", "updatedAt": "2023-03-17T12:04:26Z", "author": {"login": "vaf-hub"}}, {"id": "IC_kwDOAVT0qs5X2Qb-", "body": "> When decrypting the \"leading\" mail instance using the `bucketKey`, we store the session keys in the session key cache and then use it later when we need to decrypt on the associated instances.\r\n\r\nSo the problematic situation is where we download the email only, write it to offline with `ownerEncSessionKey` but not download e.g. attachments and then when we later (e.g. after restart) want to download attachments we wouldn't have it in the cache, do I understand correctly?", "createdAt": "2023-03-17T13:24:44Z", "updatedAt": "2023-03-17T13:24:44Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5X93B3", "body": "> \r\n\r\nI think the problem will only occur if we do not call `resolveSessionKey` in the case that the mail is stored in the offline cache with an `ownerEncSessionKey`. I am not sure if we do that. If we always call `resolveSessionKey` even for such cases we should not have a problem. Right now it is anyway only possible to get a reference to an associated instance (`MailDetailsBlob` or `File`) if we have the mail. This is the main reason why we thought it is fine to make decryption of those instances dependent on the mail. Also, in the leader client we try to write all `ownerEncSessionKey`s when we decrypt a mail using the `bucketKey`, i.e. even for attached files that are not downloaded yet. We do that without downloading the `File` instances:\r\n\r\nhttps://github.com/tutao/tutanota/blob/f6b0edc4c4cad4fb111067f56ac5343579ec6310/src/api/worker/crypto/CryptoFacade.ts#L321-L322\r\n\r\nI guess the fact that the PUT request fails for these mails because of a missing `ownerEncSessionKey` already tells us that the request to update the `ownerEncSessionKey`s failed or was never sent because we are not the leader client.", "createdAt": "2023-03-20T08:48:03Z", "updatedAt": "2023-03-20T08:48:03Z", "author": {"login": "vaf-hub"}}, {"id": "IC_kwDOAVT0qs5X-Bsf", "body": "I think this is how it happens:\r\n - we resolve session key but not write it to the object (maybe we are not the leader)\r\n - we return from `resolveSessionKey()`\r\n - we put the instance into the cache\r\n - we try to update the instance before getting an entity update with `ownerEncSessionKey` written to the instance\r\n\r\nhttps://github.com/tutao/tutanota/blob/f6b0edc4c4cad4fb111067f56ac5343579ec6310/src/api/worker/crypto/CryptoFacade.ts#L562-L579", "createdAt": "2023-03-20T09:19:29Z", "updatedAt": "2023-03-20T09:19:29Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5X-Nus", "body": "Just saw multiple messages in the logs where leader client is explicitly `false` right before the failing update", "createdAt": "2023-03-20T09:57:05Z", "updatedAt": "2023-03-20T09:57:05Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5YEiru", "body": "I just had this case in support and I know how this error happens and possible other inconsistencies.\n\nThere were multiple entity updates for a mail, `CREATE, `UPDATE` and then move.\n\nWe've tried to process `UPDATE` and tried to download the updated mail, got 404 and skipped the update. Then we reached move operation and we just moved mail from one list to another, without re-downloading. From now on we will have outdated mail instance until another client updates it.\n\nWe probably should at least expel the instance from the cache when we get 404 for it and should generally consider what happens with these timing issues.", "createdAt": "2023-03-21T10:21:17Z", "updatedAt": "2023-03-21T10:21:17Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5YKMYv", "body": "> I just had this case in support and I know how this error happens and possible other inconsistencies.\r\n> \r\n> There were multiple entity updates for a mail, `CREATE, `UPDATE` and then move.\r\n> \r\n> We've tried to process `UPDATE` and tried to download the updated mail, got 404 and skipped the update. Then we reached move operation and we just moved mail from one list to another, without re-downloading. From now on we will have outdated mail instance until another client updates it.\r\n> \r\n> We probably should at least expel the instance from the cache when we get 404 for it and should generally consider what happens with these timing issues.\r\n\r\nJust to be clear, this cannot be related to the new session key resolution with `bucketKeys`, as we did not enable it yet, but when we do it might well be the case that the number of these errors increases as we would then automatically have updates for the ownerEncSessionKey and move operations if there are inbox rules.\r\n\r\nI think we should do both:\r\n\r\n1. On the server-side handle PUT requests even if the ownerEncSessionKey is not set (just keep the one that is set in the database). This should decrease the number of errors. I am not sure if we need to make more exceptions.\r\n2. On the client-side delete the instance from the cache if an entity event update leads to a failed request. This makes it at least possible to recover from the broken state of that instance", "createdAt": "2023-03-22T08:03:07Z", "updatedAt": "2023-03-22T08:05:02Z", "author": {"login": "vaf-hub"}}, {"id": "IC_kwDOAVT0qs5YM07G", "body": "Related: Why do we even need entity updates for the updated enc session key?\r\n\r\nEither we already downloaded the instance without the key and then we are in the process of resolving it or we already downloaded it with a key. All clients should independently arrive on the same `ownerEncSessionKey` or am I wrong?", "createdAt": "2023-03-22T15:14:40Z", "updatedAt": "2023-03-22T15:14:50Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5YTAd9", "body": "> Related: Why do we even need entity updates for the updated enc session key?\r\n\r\nThere is definitely room for optimizations here. I think we want to distribute the `ownerEncSessionKey`  on all instances (`Mail`, `Files`, `MailDetailsBlob`) and the removal of the bucket key, so that we can just use the `ownerEncSessionKeys` for symmetric decryption in the future and avoid the asymmetric crypto. Just writing the ownerEncSessionKey on the local object does not have an effect anyway, because of the way that `CryptoFacade` resolves the session keys (prioritizing `bucketKey`).\r\n\r\n> Either we already downloaded the instance without the key and then we are in the process of resolving it or we already downloaded it with a key. All clients should independently arrive on the same `ownerEncSessionKey` or am I wrong?\r\n\r\nThe `ownerEncSessionKey` should of course always be the same. The point is we can only really use it on the mail once the `bucketKey` was removed. Otherwise we could always end up non-decryptable associated instances.\r\n\r\nAt this point, I feel like we should have a meeting about this. Or just assign this issue to the infrastructure team?!", "createdAt": "2023-03-23T15:14:04Z", "updatedAt": "2023-03-23T15:14:04Z", "author": {"login": "vaf-hub"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5ZuuBI", "body": "I'm still getting some reports about this", "createdAt": "2023-04-12T14:53:25Z", "updatedAt": "2023-04-12T14:53:25Z", "author": {"login": "ganthern"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5cO5En", "body": "Two things I've noticed in reports:\n - `Abort transaction on updating group data: concurrent access` is quite often printed before this error happens, even in android app (!)\n - quite often WS connection is unstable before this happens", "createdAt": "2023-05-15T08:22:26Z", "updatedAt": "2023-05-15T08:22:26Z", "author": {"login": "charlag"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5fY7oC", "body": "I think this error occurs because we allow updating the ownerEncSessionKey with a regular PUT request and we don't have the most recent version of the entity on the client. I assume that we are sending an entity with ownerEncSessionKey set to null together with the PUT request although the ownerEncSessionKey has already been set on the entity.\r\n\r\nI am thinking of an UPDATE operation on a newly received mail which is done before we processed the UPDATE event of setting the ownerEncSessionKey . Such fast UPDATE might be triggered by inbox rule processing although i was not able to reproduce this case.\r\n\r\nI was able to reproduce the error by setting ownerEncSessionKey to null for an update request using browser dev tools. \r\n\r\nI made a fix on the server to ignore changes of the ownerEncSessionKey with regular PUT request, so let's observe if this error still occurs.\r\n\r\n**see**\r\ntutadb: 3.114.5\r\nmerge_requests/408", "createdAt": "2023-06-21T07:59:09Z", "updatedAt": "2023-06-21T08:00:43Z", "author": {"login": "bedhub"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "bare_mention", "will_close": false, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "no-repro"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5291/issues/tutao_tutanota_5290.json

@@ -0,0 +1 @@
+{"number": 5290, "title": "Instances can get stuck in outdated state when the client is not leader", "body": "From my [comment](https://github.com/tutao/tutanota/issues/4951#issuecomment-1477585646):\r\n\r\n> There were multiple entity updates for a mail, CREATE, UPDATE` and then move.\r\n>\r\n>We've tried to process UPDATE and tried to download the updated mail, got 404 and skipped the update. Then we reached >move operation and we just moved mail from one list to another, without re-downloading. From now on we will have outdated >mail instance until another client updates it.\r\n>\r\n>We probably should at least expel the instance from the cache when we get 404 for it and should generally consider what >happens with these timing issues.\r\n\r\nI have not managed to reproduce this more than once as it requires precise timing: there should be enough time between update and move batches so that we start downloading the instance but move must also succeed before we download it.\r\n\r\n## Test notes (you can try)\r\n * cache email on the slow client, per-cache another (destination) mail list\r\n * update and then move email on another client\r\n * if you are lucky you will see 404 for the email at the old location\r\n * with this fix it should re-download email at the new location and not just move it in memory", "state": "CLOSED", "created_at": "2023-03-22T15:36:00Z", "closed_at": "2023-03-24T15:01:31Z", "author_login": "charlag", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5291, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "state:tested", "state:done"], "milestone": "3.112.5", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5347/issues/tutao_tutanota_4576.json

@@ -0,0 +1 @@
+{"number": 4576, "title": "Update esbuild", "body": "As of 0.15.7 there should be nothing that should break a build for us\r\n\r\nsee https://github.com/evanw/esbuild/releases", "state": "CLOSED", "created_at": "2022-09-14T09:10:25Z", "closed_at": "2023-04-11T11:05:38Z", "author_login": "charlag", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5347, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "maintenance"], "milestone": "3.112.9", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5347/issues/tutao_tutanota_5301.json

@@ -0,0 +1 @@
+{"number": 5301, "title": "Multi-select indicator & select all", "body": "## User story\r\nAs a user, i want to have a visual indication that i can select/deselect all and individual items from the loaded list, so that i can run actions for the selected items.\r\n\r\n## AC\r\n* A checkbox is shown in the toolbar which allows selecting all loaded emails, contacts or search results\r\n* A checkbox is shown for each individual list item\r\n* The number of selected items are shown in the viewer section.\r\n* If the list is not loaded completely we show another button in the viewer to load and select all.\r\n  * While we try to load all items we show the progress in some way\r\n  * If the selection if switched while loading, the loading is stopped\r\n\r\n## Tasks\r\n - [ ] Adapt the design of the first column action (\"new email\"/\"new contact\" to fit the toolbar in some way) \r\n - [x] Implement new design for the list and mail row\r\n - [x] Implement \"select all\" button that selects all loaded items\r\n - [x] Implement true \"load all\", progress and cancellation\r\n - [x] Do not run into rate limits right away\r\n - [x] Fix contact list\r\n - [x] Fix template list\r\n - [x] Fix user list\r\n - [x] Fix group list\r\n - [x] Fix contact form list\r\n - [x] Fix knowledge base list\r\n - [x] Fix quick search\r\n\r\n![Image](https://user-images.githubusercontent.com/3099142/227905823-14237357-e3f3-4d3b-bb81-015ab523dd0c.png)\r\n\r\nnote: the filter function is not part of this issue\r\n\r\n## Test notes\r\n - [ ] Test select all\r\n   - [ ] it shows correct version of multiselection in the viewer with an ability to load all or deselect\r\n - [ ] Test load all\r\n   - [ ] It progressively loads and selects\r\n   - [ ] Cancellation should stop it\r\n   - [ ] Continuing should pick up from where it left last time\r\n   - [ ] Changing to another folder stops the loading\r\n   - [ ] Changing to another view stops the loading\r\n   - [ ] Test that scrolling does not affect loading progress\r\n - [ ] Test actions applied to a lot of emails at once\r\n   - [ ] Marking a lot of emails read/unread does not start too many requests at once \r\n - [ ] Test that above things also work in search\r\n   - [ ] Changing search criteria stops the loading\r\n   - [ ] Viewer works correctly in search too\r\n - [ ] Check that list rows look correct:\r\n   - [ ] Mail\r\n   - [ ] Contact\r\n   - [ ] Template\r\n   - [ ] User\r\n   - [ ] Group\r\n   - [ ] Contact form\r\n   - [ ] Knowledge base\r\n - [ ] Check that there are no checkboxes in mail/contact rows when in single-column layout", "state": "CLOSED", "created_at": "2023-03-24T15:41:37Z", "closed_at": "2023-04-11T11:05:37Z", "author_login": "bedhub", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5347, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "ui"], "milestone": "3.112.9", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5347/issues/tutao_tutanota_5306.json

@@ -0,0 +1 @@
+{"number": 5306, "title": "Toolbar in mail viewer", "body": "## Tasks\n- [x] Update the UI to have a toolbar above the mail view (not the mail list side).\n- [x] Add action buttons like in the below screenshot (not the mail list side).\n- [x] Ensure that correct action buttons appear for the selected mail/user authority.\n- [x] Actions on mails in the viewer will be in the \"more\" (three dots) button.\n- [x] When multiple mail are selected, the mail viewer displays how many mail are selected and the actions are in the toolbar.\n- [x] The toolbar will be included in mail search view.\n- [x] The toolbar will show on the two and three column layout.\n- [ ] Always display subject above the selected card, and should be visible when the email is first opened (but does not stick when scrolled).\n\n![Image](https://user-images.githubusercontent.com/119855382/227898994-18c1e0cb-4558-419a-850c-a79f029337fd.png)\n\n## Test Notes\n- [ ] General\n    - [ ] Toolbar is displayed for mail view in three-column and two-column mode\n    - [ ] Toolbar is not displayed single column mode\n- [ ] Mail view\n    - [ ] toolbar has expected actions for a mail\n    - [ ] the action buttons all work\n    - [ ] action buttons are navigable with keyboard\n    - [ ] keyboard shortcuts still work\n    - [ ] all available actions for a mail are available on its card under the three dots button\n    - [ ] When opening a mail, it is scrolled to the correct spot (to the subject or displaying some of the previous entry)\n- [ ] Multiple mails selected \n    - [ ] toolbar shows actions related to multiple selected mails\n    - [ ] The action buttons work\n    - [ ] the \"cancel\" button works and deselects selected mails\n- [ ] Search View\n    - [ ] The toolbar also works for mails in the search view (including multi-select)\n    - [ ] search for contacts works as expected\n    - [ ] multi-select for contacts works as expected\n\n\n\n\n", "state": "CLOSED", "created_at": "2023-03-27T09:32:50Z", "closed_at": "2023-04-11T11:05:38Z", "author_login": "wrdhub", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5347, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "ui"], "milestone": "3.112.9", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5347/issues/tutao_tutanota_5307.json

@@ -0,0 +1 @@
+{"number": 5307, "title": "Toolbar in contact viewer", "body": "## Tasks\r\n - [x] Design contact viewer to be closer aligned to mail viewer: toolbar above the viewer and contact as a card\r\n - [x] Adapt contact viewer to new design\r\n - [x] Make sure it is consistent with search results viewer\r\n\r\n## Test notes\r\n - [ ] Contact viewer shows all information correctly\r\n - [ ] Switching between contacts works without issues\r\n - [ ] Editing contacts leads to them being updated in the viewer\r\n - [ ] Mobile toolbar for contact viewer works", "state": "CLOSED", "created_at": "2023-03-27T10:01:52Z", "closed_at": "2023-04-11T11:05:35Z", "author_login": "charlag", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5347, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "ui"], "milestone": "3.112.9", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5347/issues/tutao_tutanota_5352.json

@@ -0,0 +1 @@
+{"number": 5352, "title": "", "body": "", "state": "", "created_at": "", "closed_at": null, "author_login": "", "comment_rounds": [], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "desktop", "maintenance"], "milestone": "3.112.9", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5380/issues/tutao_tutanota_5137.json

@@ -0,0 +1 @@
+{"number": 5137, "title": "Updating calendar event does not properly handle network errors", "body": " `CalendarFacade#updateCalendarEvent()` calls `_saveMultipleAlarms()` but doesn't unwrap `SetupMultipleError` to convert it to `ConnectionError`.\r\n\r\n```\r\nUpdating a calendar appointment (to add a reminder)\r\n\r\n\r\nClient: win32\r\nTutanota version: 3.108.12\r\nUser agent:\r\nMozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) tutanota-desktop/3.108.12 Chrome/108.0.5359.179 Electron/22.0.3 Safari/537.36\r\nSetupMultipleError\r\nError message: Setup multiple entities failed\r\nNumber of errors: 1\r\nFirst error: ConnectionError: 0: | POST /rest/sys/useralarminfo/LjHEozM--R-1\r\nStacktrace:\r\nSetupMultipleError: Setup multiple entities failed\r\nNumber of errors: 1\r\nFirst error: ConnectionError: 0: | POST /rest/sys/useralarminfo/LjHEozM--R-1\r\nat Ka.setupMultiple (asset://app/worker.js:1:28888)\r\nat async kl._saveMultipleAlarms (asset://app/worker.js:12:132367)\r\nat async kl.updateCalendarEvent (asset://app/worker.js:12:128872)\r\n```\r\n\r\nTo fix it we should do a similar thing to what `_saveCalendarEvents` does and convert it to `ConnectionError` if appropriate.\r\n\r\n## Test Notes\r\n* [x] saving calendar events with multiple alarms still works\r\n* [x] updating calendar events with multiple alarms still works\r\n* [x] if the connection drops while saving/updating, an offline notification is shown, but no uncaught error is thrown.", "state": "CLOSED", "created_at": "2023-02-14T15:55:19Z", "closed_at": "2023-04-19T11:26:16Z", "author_login": "charlag", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5380, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "state:tested", "state:done", "topic: calendar"], "milestone": "3.112.9", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5404/issues/tutao_tutanota_4213.json

@@ -0,0 +1 @@
+{"number": 4213, "title": "Vendor desktop libraries", "body": "We do vendoring for web part for security reasons (libs directory). We should do the same for desktop-only libraries.\r\n\r\n* [x] update-libs scripts needs to be updated to pull desktop deps\r\n* [x] update debug and dist build to use the vendored files\r\n* [x] create list of dependencies to pull\r\n* [x] restrict dist build to only use `@tutao` dependencies from node_modules (node-resolve plugin)\r\n* [ ] review the dependencies\r\n\r\n## Test Notes\r\n* [x] auto-update works for mac, linux, windows\r\n* [x] saving credentials works for mac, linux, windows\r\n* [x] offline mode works for mac, linux, windows\r\n* [x] dev build of the desktop client works", "state": "CLOSED", "created_at": "2022-05-27T08:00:04Z", "closed_at": "2023-08-30T14:38:02Z", "author_login": "charlag", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5le5ks", "body": "see #5836 ", "createdAt": "2023-09-01T11:27:14Z", "updatedAt": "2023-09-01T11:27:14Z", "author": {"login": "kibibytium"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5404, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "desktop", "build", "state:done"], "milestone": "3.118.4", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5473/issues/tutao_tutanota_5437.json

@@ -0,0 +1 @@
+{"number": 5437, "title": "Improved calendar event viewer and editor", "body": "the calendar event editor and view model are monolithic and hard to test / extend.\r\n\r\nas user I don't want to be confused by being offered to edit an event when I can't actually edit it. I still need to be able to set my attendance and alarms without having the full event editor available.\r\n\r\n## AC\r\n\r\n* it's not possible to edit anything about the attendees in an event that was created in a calendar that was shared with you\r\n  * if it has guests, the editor cannot be opened for it (because you're not the organizer and cant send updates)\r\n  * if it has no guests, the editor can be opened, but the guest list is replaced with a message stating \"you cannot invite people to an event that was not created in one of your personal calendars\"\r\n* in your own calendars, the calendar details popup shows a selector for your own attendance if you're invited to it (similar to the invite banner or as a dropdown like in the editor. keep it short)\r\n* it's not possible to set the same alarm multiple times in the editor\r\n\r\n\r\n## Tasks\r\n\r\n* [x] finish splitting the CalendarEventViewModel into components that \r\n  * uphold invariants while the editing operation is in progress\r\n  * contains the logic necessary to do higher-level operations like rescheduling, excluding\r\n  * sending updates/cancellations/invites\r\n* [x] re-write the calendar event editor to always be writable (don't open it for read-only events)\r\n  * in cases where the event is partially writable, add a message that states that this is the case and why\r\n* [x] adapt calendar popup to enable\r\n  * [x] setting and viewed your own attendance (if you're invited)\r\n* [x] update the calendar documentation in the doc project with the most important high-level concepts and the invariants (or where to find them - tests)\r\n* [x] add the new translations to phrase\r\n\r\n## Test Notes\r\npersonal calendar = calendar that's shown under \"your calendars\"\r\n(rw/ro)-shared calendar = calendar that's not shown under \"your calendars\" (read-write/read-only)\r\n\r\n**event popup**\r\n* [x] the event popup shows only the close button for ro-shared events or on invites in external mailboxes\r\n* [x] it shows edit, delete and close for events in personal calendar and rw-shared calendars\r\n* [x] it shows edit, delete, close, send update for events with attendees in personal calendar, but not in rw-shared calendars.\r\n* [x] it shows the yes/no/maybe buttons with the selected one highlighted if you're an attendee, but only in personal calendars.\r\n* [x] these butttons also work as expected - status is set, the event is updated, response mail is sent\r\n* [x] the buttons are not shown in events where you're not invited.\r\n\r\n**event banner (mailview)**\r\n* [x] for tutanota users, the event banner still can be used to set the attendance and adds the event to the first personal calendar.\r\n* [x] for external users, the event banner can be used to send a response, but does not add the event to any calendars.\r\n* [x] the banner can be used to open the popup\r\n\r\n**event editor - personal calendar**\r\n* [x] editor for a calendar event with no attendees is fully editable and does not show the note about partially editing.\r\n* [x] it's impossible to change the organizer address unless the event is completely new or had no attendees\r\n* [x] in cases where the organizer address can change, the selector shows the active aliases of the user\r\n* [x] the selected organizer address is used for sending the invites.\r\n* [x] saving a new event sets it up correctly on the server, sets the alarms and sends invites/updates/cancellations as required.\r\n\r\n**event editor - rw-shared calendar**\r\n* [x] the editor for a rw-shared event without attendees is fully editable except for the attendees and shows the note about partial editing.\r\n* [x] the editor for an event with attendees only allows adding alarms.\r\n\r\n**event editor - ro-shared calendar**\r\n* [x] it's not possible to open the editor for events in a ro-shared calendar.\r\n\r\n**event editing - general**\r\n* [x] editing the calendar an event is in works as it should:\r\n  * [x] for new and existing events, all writable (shared and personal) calendars are selectable while there are no guests added\r\n  * [x] if there are guests in a new event, the calendar dropdown only shows personal calendars\r\n  * [x] if there are guests in an existing event in a shared calendar, the calendar cannot be changed\r\n  * [x] if there are guests in an existing event in a personal calendar, the calendar can only be changed to other personal calendars\r\n* [x] editing an event without changing the start time works\r\n* [x] editing an event with changing the start time works\r\n* [x] events show at the right time in the calendar, even when switching time zones:\r\n  * all-day events\r\n  * normal events\r\n\r\n**event editor - alarms**\r\n* [x] existing alarms from the event are shown correctly\r\n* [x] in shared calendars, only the alarms set by the current user are shown and editable.\r\n* [x] it's possible to add new alarms, but only if an alarm of that time does not exist yet\r\n* [x] it's possible to remove alarms\r\n* [x] the selected alarms are set up correctly after saving and fire at the right time (test switching timezones)\r\n\r\n**invites**\r\n* [x] only paying customers can send invites\r\n* [x] all users can respond to invites\r\n* [x] responding to invites from external mail services works and is applied\r\n* [x] responding to invites from secured external tutanota mail boxes works\r\n\r\n**exclusions**\r\n* [x] can be deleted from the editor (if editing the event is possible for the current user)\r\n* [x] can be added from the popup by selecting the correct option from the delete-dropdown\r\n* [x] can not be added for non-repeating events or repeating events that have only one occurrence left that's not excluded\r\n* [x] will be displayed correctly in different time zones\r\n* [x] will not be deleted when merely changing the event from all-day to not all-day or back\r\n* [x] will be deleted if anything else about the event scheduling changes\r\n* [x] will not be deleted if any other fields change\r\n\r\n**regressions**\r\n* [x] import of events still works\r\n  * in tutanota, exported from tutanota and form other mailboxes\r\n  * in other mailboxes, exported from tutanota", "state": "CLOSED", "created_at": "2023-05-08T09:22:07Z", "closed_at": "2023-07-12T06:40:34Z", "author_login": "ganthern", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5hGvfG", "body": "Some findings:\r\n\r\n- Decline an invite from the mail view. See that the event does not show up in your calendar. I would expect it to do so, because it might be important to know when the event is happening even if I do not attend. More importantly, it not possible to change this initial choice, because there is no event in the calendar and from the event popup in the mail view the status buttons are not available anymore. We probably should just always create the event in the first personal calendar.\r\n- Not sure what \"for external users, the event banner can be used to send a response, but does not add the event to any calendars\" means. -> seems like we always send SMTP messages out to the external attendees and ignore any secure external contacts (I am not sure that this behavior is new?).\r\n- \"it's not possible to open the editor for an event that has attendees\" -> it is possible, but the event is not editable except for the alarms. i think this is fine.\r\n- save an event without attendees in the private calendar. open the event editor and add an attendee. before saving select rw shared calendar and observe the uncaught error. the rw calendar should not be selectable anymore as soon as an attendee is added.\r\n- it is not possible to send confidential external invites (see above).\r\n- \"only paying customers can send or respond invites\" -> it is possible to accept event invites from the mail view as a free account. it is not possible to accept or send calendar invites. it is not possible to send event invites as a free user. seems fine to me, but it is not what the test notes say.\r\n- create a repeating event with an end date for the repetition. try deleting the last occurrence and see that it does not ask whether to delete only this occurrence or the entire event but rather ask for confirmation to delete the event. this happens even if this is not the last occurrence left. this bug does not happen with number of occurences as event repeat rule.\r\n\r\nAnd some more notes, that are probably less related to the changes made here:\r\n\r\n- It is still confusing that you end up with two events (in different calendars) in case you accept an invitation to an event in a calendar that has been shared with you.\r\n- Not sure if this a new problem: Go to the month view in a calendar with events in that month. Change the timezone of your system. Click somewhere in the calendar and close event edit dialog. See how all events disappear from the calendar. After logging back in or switching the time zone back to the original one (and doing the calendar click) the events show up again.\r\n- It is not possible to set alarms for ro calendars.", "createdAt": "2023-07-10T15:06:10Z", "updatedAt": "2023-07-10T15:15:10Z", "author": {"login": "vaf-hub"}}, {"id": "IC_kwDOAVT0qs5hHItW", "body": "We've discussed it with @ganthern \r\n\r\n1. It is true but also not new. Will create another issue\r\n2. I could not reproduce it locally but there are some weird cases where I can't delete an event with secure external recipient\r\n3. it's fine\r\n4. it is a bug\r\n5. Could not reproduce\r\n6. It is possible to accept event invites but not calendar invites, yes\r\n7. Probably a bug, need investigation\r\n\r\nand for the rest:\r\n1. not sure what to do there otherwise\r\n2. probably not worth investigating\r\n3. it was not possible for some time but we should eventually fix it", "createdAt": "2023-07-10T16:06:57Z", "updatedAt": "2023-07-10T16:06:57Z", "author": {"login": "charlag"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5473, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "topic: calendar"], "milestone": "3.115.2", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5476/issues/tutao_tutanota_2885.json

@@ -0,0 +1 @@
+{"number": 2885, "title": "Test DesktopConfig.js", "body": "DesktopConfig.js is not tested and as is not testable either. The class should be split into the config itself and the persistence mechanisms it uses and after that tested with unit tests.", "state": "CLOSED", "created_at": "2021-03-29T13:37:20Z", "closed_at": "2023-06-15T12:00:04Z", "author_login": "rosso-ptg", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5c9AR0", "body": "## Test Notes\r\n- [x] Settings like color theme and spell check language are persisted", "createdAt": "2023-05-23T14:16:51Z", "updatedAt": "2023-07-10T13:06:52Z", "author": {"login": "wrdhub"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5476, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "desktop", "maintenance", "state:done"], "milestone": "3.115.2", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5518/issues/tutao_tutanota_5431.json

@@ -0,0 +1 @@
+{"number": 5431, "title": "Filter for unread emails", "body": "As a user i want to have the option to filter my email list so that only the unread or read emails of that list/folder are shown.\r\n\r\n## AC\r\n* there is a button inside the mail list toolbar that allows to set a filter on the mail list to only show read email, only show unread emails or to deactivate the filter\r\n* if you click select all while a filter is active, clicking \"select all\" will only select mails that match the current filter\r\n* if more mails are loaded while the filter is active, the filter also applies to the newly loaded mails\r\n* same with updates coming from outside: if new mail arrives in the list, it's only displayed if it matches current filter\r\n* filter should be available in the search view\u00a0 (it should possible to use it in the mobile view)\r\n* as soon as a set of emails is loaded the filter is applied and the matching results are shown even if there are not enough emails to finish loading.\r\n* if there are not enough results, loading continues\r\n* while emails are loading a progress item appears as last list item.\r\n* there is a cancel button on the progress item in the list to stop the loading.\r\n* when loading is cancelled the \"show more\" item appears.\r\n\r\n## Tasks\r\n * [x] List refactoring\r\n   * [x] Introduce ListModel\r\n   * [x] Virtual row handling\r\n   * [x] Updates for list items\r\n   * [x] Selection handling\r\n   * [x] Automatic load on scroll\r\n   * [x] Loading indicator & manual load more\r\n   * [x] \"load, scroll to and select\" based on the url\r\n   * [x] Mobile multiselect\r\n   * [x] Sorting in contact view\r\n   * [x] Swipe items\r\n   * [x] Load all\r\n   * [x] Move shortcut\r\n   * [x] Empty list state\r\n   * [x] Update URL\r\n   * [x] Keep track of selection per folder\r\n   * [x] Focus viewercolumn when we select a mail\r\n   * [x] dragging mails\r\n   * [x] socket for admin client\r\n   * [x] self-healing unread mail counters\r\n   * [x] mutliselect not allowed in some lists\r\n * [x] Filter\r\n   * [x] Model for the filtered list\r\n   * [x] UI for filtering in the toolbar mail view\r\n   * [x] UI for filtering search view\r\n   * [x] cancelling of loading\r\n\r\n## Test ntoes\r\n - [x] Switching between mails\r\n - [x] Multiselect mails (different methods, including keyboard and checkbox and mobile multiselect)\r\n - [x] URL is updated correctly\r\n - [x] Loading the app with mail URL will try to load and display that email\r\n - [x] Loading more works\r\n - [x] Cancelling of loading works\r\n - [x] Network errors are handled correctly\r\n - [x] Inbox rules are applied\r\n - [x] Selected folder/mail is remembered when switching between views\r\n - [x] Filtering mails works\r\n - [x] Mails don't disappear if they stop matching the filter\r\n - [x] Loading can be cancelled and resumed\r\n - [x] Load all still works\r\n - [x] Load all still works in search\r\n - [x] Load all works with filters\r\n - [x] Contact list works\r\n - [x] Search view works\r\n - [x] Filters work in search\r\n - [x] Filters work in mobile mail view\r\n - [x] Filters work in mobile search view\r\n - [x] Secure external mails\r\n - [x] Mailto & MAPI\r\n - [ ] ~~Contact forms~~", "state": "CLOSED", "created_at": "2023-05-05T09:40:36Z", "closed_at": "2023-06-15T14:03:49Z", "author_login": "bedhub", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5b4bh0", "body": "It's ridiculous that this doesn't work and that it has been like this for [three years](https://archive.is/ui4Qa).", "createdAt": "2023-05-10T07:51:58Z", "updatedAt": "2023-05-10T11:32:51Z", "author": {"login": "dergigi"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5hGEam", "body": "> URL is updated correctly\r\n\r\nWhat does \"correctly\" mean?", "createdAt": "2023-07-10T13:36:55Z", "updatedAt": "2023-07-10T13:37:07Z", "author": {"login": "vitoreiji"}}, {"id": "IC_kwDOAVT0qs5hGLOn", "body": "> Network errors are handled correctly\r\n\r\nAgain, what does \"correctly\" mean? Also, which network errors, other than being offline, and how to I trigger them?", "createdAt": "2023-07-10T13:49:18Z", "updatedAt": "2023-07-10T13:49:18Z", "author": {"login": "vitoreiji"}}, {"id": "IC_kwDOAVT0qs5hGMYp", "body": "> > URL is updated correctly\r\n> \r\n> What does \"correctly\" mean?\r\n\r\n- [x] URL is updated every time you switch between folders or mails and only once per switch\r\n- [x] it remembers the mail per folder\r\n- [x] it remember the folder that was open before leaving mail view\r\n- [x] in multiselect the element id part is removed from the URL", "createdAt": "2023-07-10T13:52:13Z", "updatedAt": "2023-07-10T14:37:27Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5hGNBZ", "body": "> > Network errors are handled correctly\r\n> \r\n> Again, what does \"correctly\" mean? Also, which network errors, other than being offline, and how to I trigger them?\r\n\r\nYou can trigger network errors by breaking the connection, either by actually disconnecting or by using devtools (only works in browser). So yeah it means offline.\r\n\r\nIt should stop loading and show \"load more\" button and it should be able to continue when you press on it.", "createdAt": "2023-07-10T13:53:42Z", "updatedAt": "2023-07-10T13:53:42Z", "author": {"login": "charlag"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["new feature", "state:tested", "state:done"], "milestone": "3.115.2", "sub_issues": [], "sub_issue_count": 0, "parent_issues": [{"number": 2347, "title": "More search filter options", "state": "OPEN"}]}

tutao_tutanota_5573/issues/tutao_tutanota_5406.json

@@ -0,0 +1 @@
+{"number": 5406, "title": "Search in Settings for Templates and Knowledgebase", "body": "## User story\nAs a user I want to be able to search in templates and knowledgebase entries to find things more easily.\n\n## AC\n* Search input field is available on top of the list when Templates and Knowledgebase are visible in the settings\n* This search function is the same as the filters in the mail editor (the template shortcut/the knowledgebase button)\n* Non-matching items are filtered out of the list, only leaving matching items that the user can navigate through.\n* If no items matches there should be a \"no matches\" text similar to the empty list message.\n\n## Tasks\n - [x] Replace template list with the new list\n - [x] Add a filter bar to the template list\n - [x] Replace knowledge base list with the new list\n - [x] Add a filter bar to the knowledge base list\n\n## Test notes\n - [x] Filtering templates works\n - [x] Navigating through templates works\n - [x] creating templates work\n - [x] Can delete and edit a template\n - [x] Can delete and rename a template group\n - [x] When sharing, the other user interacts with the templates with the correct permissions (Read only can only read, edit permissions can edit, etc)\n - [x] Filtering knowledge base works\n - [x] Navigating through knowledge base works\n - [x] creating knowledgebases works\n - [x] Can edit and delete a knowledgebase entry\n Regression\n - [x] Search for emails and contacts works as expected", "state": "CLOSED", "created_at": "2023-04-24T08:59:38Z", "closed_at": "2023-06-28T16:04:32Z", "author_login": "bedhub", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5573, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["improvement", "state:tested", "state:done"], "milestone": "3.115.2", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5573/issues/tutao_tutanota_5541.json

@@ -0,0 +1 @@
+{"number": 5541, "title": "Replace lists in settings", "body": "With filter for unread emails we now have a filter implementation for the list and also new list components and we should use them in the rest of the codebase.\r\n\r\nAdditionally we don't need to use search & search index infrastructure for simple search implementations in settings.\r\n\r\n\r\n## Tasks\r\n - [x] Replace user list with the new list\r\n - [x] Add a filter bar to the user list \r\n - [x] Replace group list with the new list\r\n - [x] Add a filter bar to the group list\r\n - [x] Update search bar/search index to not include groups\r\n - [x] Remove whitelabel children\r\n - [x] Replace contact form list with the new list\r\n\r\n\r\n## Test notes\r\n - [x] For each list check that search, filtering and selection works\r\n      - [x] Users\r\n      - [x] Groups\r\n      - [x] Contact Forms (does not have filtering)\r\n - [x] Selection should focus the right column (test in mobile)\r\n - [x] Entity updates should be applied (Example: changes made to a user or group from another client should display)\r\n - [x] Adding user/group/contact form works correctly", "state": "CLOSED", "created_at": "2023-06-19T09:53:39Z", "closed_at": "2023-06-28T16:04:33Z", "author_login": "charlag", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5573, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "state:done"], "milestone": "3.115.2", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5591/issues/tutao_tutanota_5579.json

@@ -0,0 +1 @@
+{"number": 5579, "title": "changes in the email list cause ui issues", "body": "**v3.114.4**\r\n\r\nbest to describe with have examples:\r\n\r\n1. have multiple emails\r\n2. archive one\r\n3. use \"u\" to mark next one as unread\r\n4. email is marked actually marked as unread but the email in the list doesn't change.\r\n5. click on the email\r\n6. use \"u\"\r\n7. works as expected\r\n\r\nanother example:\r\n1. have multiple emails\r\n2. archive one\r\n3. use up/down arrows\r\n4. first press is ineffective\r\n5. press again\r\n6. works as expected\r\n", "state": "CLOSED", "created_at": "2023-06-29T12:06:47Z", "closed_at": "2023-07-04T15:51:54Z", "author_login": "kibibytium", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5gNyf9", "body": "@kibhub which version was that?", "createdAt": "2023-06-30T07:09:39Z", "updatedAt": "2023-06-30T07:09:39Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5gOZ-_", "body": "> @kibhub which version was that?\r\n\r\nsorry, v3.114.4. description updated as well. ", "createdAt": "2023-06-30T09:27:27Z", "updatedAt": "2023-06-30T09:27:27Z", "author": {"login": "kibibytium"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5585, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["dev bug", "state:tested", "state:done"], "milestone": "3.115.2", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5642/issues/tutao_tutanota_4860.json

@@ -0,0 +1 @@
+{"number": 4860, "title": "Advanced repeat rule: Reschedule occurrence of a repeating event", "body": "As a user i want to be able to reschedule specific occurrences of a repeating calendar event so I can keep the original repeat rule while being able to react to scheduling conflicts.\r\n\r\n### Acceptance criteria\r\n* When an occurrence of a repeating event is rescheduled via dragging or edited in the editor, the user gets asked when saving or dropping the dragged event:\r\n  * edit only the occurrence that was clicked \u2192 do that\r\n  *   edit everything \u2192 add offset that was edited to the original event. don't do a separate rescheduled occurrence (basically what we're doing now)\r\n* Rescheduled occurences are visible in the event edit dialog\r\n* Received calendar invites with rescheduled occurrences are recognized\r\n* Sending an invite with rescheduled occurrences correctly sends rescheduled occurrences so that it is recognized by other calendar software\r\n* When an event with rescheduled occurrences is deleted completely, it deletes all occurrences - orginal, repeats and reschedules\r\n  * this does not include the case where we delete a single occurrence - just add the exclusion then.\r\n  * if a single rescheduled occurrence is deleted , we add an exception/exclusion for the orginal start time of the occurrence\r\n* ~~Reminders on all platforms are fired in accordance with the rescheduled event~~ -> in next step #5358 \r\n* When editing the occurence of a repeating event we display the datetime of that occurence in the edit dialog\r\n* When changing the calendar of the events all of the linked events are moved to that calendar\r\n  * Tentative: Guests are shared between all occurrences, also rescheduled ones\r\n        Override this if implementation strongly suggests otherwise because we want to change it eventually anyway\r\n\r\n\r\n\r\n### Notes\r\nhttps://github.com/tutao/tutanota/issues/4872\r\n\r\n### Release notes\r\n * schema upgrade must be run before any clients supporting writing the new index format are released.\r\n\r\n### Tasks\r\n* [x] model changes\r\n    * [x] tutadb\r\n    * [x] tutanota-next\r\n    * [x] client\r\n    * [x] backwards migration\r\n    * [x] offline database must be consistent with the server after the update or be emptied\r\n* [x] export/import\r\n    * [x] Exports properly\r\n    * [x] Imports another Tutanota Calendar\r\n    * [x] imports calendars with rescheduled events from other calendar apps\r\n* [x] documentation\r\n* [x] translations\r\n* [x] invites \r\n    * [x] sends notifications for adding altered instances\r\n    * [x] sends notifications for updating altered instances\r\n    * [x] sends notifications for removing altered instances\r\n    * [x] sends notifications for changing the whole series\r\n    * [x] canceling events works correctly for rescheduled events (for single and the whole series)\r\n    * [x] Process incoming updates correctly and update rescheduled occurrences\r\n* [x] calendar event editor\r\n    * [x] change it so it always displays the selected instance when opened\r\n    * [x] add the display section for rescheduled instances\r\n    * [x] ask user about scope of the changes before opening the editor\r\n        * [x] Editing a rescheduled event should still ask \r\n       * [x] if all events -> just edit as normal\r\n      * [x] if only this occurrence -> add a new rescheduled occurrence after the edit operation\r\n    * [x] guests should continue to apply to all instances\r\n* [x] Rescheduled events are cleaned up properly\r\n* [x] drag'n'drop for event should ask what to do on drop\r\n* [x] test old clients in the presence of events with the same UID\r\n* [ ] ~~Invalidate stored alarms on all platforms~~\r\n\r\n## Test notes\r\n\r\n**drag&drop**\r\n * [x] When dragging and dropping one (non-rescheduled) occurrence of a repeating event there is a dropdown which suggest to change only one or all of them\r\n   * [x] it is not shown for single events that do not repeat\r\n   * [x] it is not shown for already rescheduled events (those just get rescheduled after drop)\r\n\r\n**deleting**\r\n* [x] When clicking delete on any event of a series that has more than one visible (non-excluded) instance, the popup asks if only that instance should be deleted. the operation is applied according to the user's choice.\r\n* [x] if the series has only one visible instance, it asks for confirmation and deletes the whole series if approved\r\n\r\n**editing**\r\n * [x] when clicking edit on the popup, there is a dropdown to select single edit or multiple edit if the event is part of a series (even if it is the last remaining instance)\r\n * [x] #5692\r\n   * it's not possible to change the calendar\r\n   * it's not possible to change the attendees\r\n* [x] changing the repeat rule on the whole series deletes all exclusions & altered instances\r\n* [x] changing the start time on the whole series deletes all exclusions & altered instances\r\n* [x] changing the end time on the whole series adjusts the length of all altered instances as well\r\n* [x] other edits to the whole series are applied to all altered instances as well\r\n\r\n**invitations, outgoing** \r\nfor all of these, the appropriate notifications are sent:\r\n  * [x] cancellation for removed attendees and cancelled instances (deletion of a single non-altered instance should be an update notification for the whole series)\r\n  * [x] updates are sent to kept attendees after editing an event instance\r\n  * [x] invitations are sent to any attendees when creating new altered instances.\r\n\r\n**invitations, incoming**\r\nit's possible to accept/reject invites from outlook, proton and google.\r\n* [ ] single, non-repeating event\r\n* [ ] repeating event\r\n* [ ] repeating event with exclusions\r\n* [ ] repeating event where an altered instance exists and we get invited afterwards to all instances\r\n* [ ] invitation to a single altered instance without being invited to the original event series.\r\n* [ ] cancellations for accepted invites are correctly processed and the events are removed from the calendar.\r\n* [ ] response mail is correctly sent to the organizer\r\n\r\n**import/export**\r\n* [x] the tutanota import/export roundtrip works for events with altered instances\r\n* [x] we can import events with altered instances from other calendar apps #5708\r\n* [x] we can export calendars with altered instances from tutanota and import them into other calendar apps\r\n\r\n\r\n## Regression Test\r\n* [x] navigation between columns in mobile and desktop view works\r\n* [x] after editing an event's repeat rule, alarms are fired (or not fired) according to the new rule, like after adding an end condition or increasing the interval\r\n", "state": "CLOSED", "created_at": "2022-12-16T08:05:25Z", "closed_at": "2023-07-28T09:19:17Z", "author_login": "bedhub", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5Wcckb", "body": "I would also like to have a \"This and following events\" option when modifying an event. Justification: A client's schedule may change and require moving recurring appointments to another day/time; however, keeping the past events scheduled is just as important.", "createdAt": "2023-03-01T15:02:37Z", "updatedAt": "2023-03-01T15:02:37Z", "author": {"login": "jctratt"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5jh0OT", "body": "* Google. NOTE: Tutanota ignores any updates if the sender is not the organizer\r\n  * [X] single, non-repeating event\r\n  * [X] repeating event\r\n  * [X] repeating event with exclusions: exclusion not considered\r\n  * [X] repeating event where an altered instance exists and we get invited afterwards to all instances: main one does not exclude rescheduled until we accept altered one\r\n  * [X] invitation to a single altered instance without being invited to the original event series\r\n  * [ ] cancellations for accepted invites are correctly processed and the events are removed from the calendar.\r\n  * [X] response mail is correctly sent to the organizer\r\n* Outlook. NOTE: responses not processed by Outlook\r\n  * [X] single, non-repeating event\r\n  * [X] repeating event\r\n  * [X] repeating event with exclusions\r\n  * [X] repeating event where an altered instance exists and we get invited afterwards to all instances\r\n  * [X] invitation to a single altered instance without being invited to the original event series.\r\n  * [x] cancellations for accepted invites are correctly processed and the events are removed from the calendar.\r\n  * [X] response mail is correctly sent to the organizer\r\n  * [ ] cancelling one occurrence of an event after accepting the whole series. Not processed by Tutanota\r\n* Proton\r\n  * [X] single, non-repeating event\r\n  * [X] repeating event. NOTE: changing from YES to MAYBE is not reflected on Proton\r\n  * [X] repeating event with exclusions. NOTE: Proton removes all alterations from event\r\n  * [X] repeating event where an altered instance exists and we get invited afterwards to all instances. NOTE: same as above\r\n  * [X] invitation to a single altered instance without being invited to the original event series. NOTE: same as above\r\n  * [X] cancellations for accepted invites are correctly processed and the events are removed from the calendar.\r\n  * [X] response mail is correctly sent to the organizer", "createdAt": "2023-08-08T15:10:57Z", "updatedAt": "2023-08-09T09:12:25Z", "author": {"login": "vitoreiji"}}, {"id": "IC_kwDOAVT0qs5jiD16", "body": "### outlooks \"cancelling one occurrence of an event after accepting the whole series. Not processed by Tutanota\"\r\n\r\nthis is the result of outlook not sending a new version of the event series with an added exclusion, but a CANCEL request\r\nfor a RECURRENCE-ID we never received (that never existed). we could handle this case easily by just adding the exclusion\r\nand special-casing this.\r\n\r\n### outlooks \"cancellations for accepted invites are correctly processed and the events are removed from the calendar.\"\r\n\r\n* cancelling non-repeating events\r\n* cancelling whole series \r\n* cancelling an altered event\r\nall work fine, more context needed\r\n\r\n### googles \"cancellations for accepted invites are correctly processed and the events are removed from the calendar.\"\r\n\r\nadding an exclusion on google has the same problem as outlook: we get a CANCEL request for the RECURRENCE-ID. we can fix it in the same way. \r\n\r\nin combination with the fact that google does not like to send the EXDATE property, this also means that we will lose any exclusions added in this way when the google organizer sends an update to the whole event series, however.\r\n\r\nother cancel operations seem to work fine, though\r\n", "createdAt": "2023-08-08T15:49:45Z", "updatedAt": "2023-08-08T15:50:15Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5jiHJP", "body": "I upgraded the CANCEL problem to a bug, I'm pretty sure it already doesn't work with the prod version.\r\n\r\nhttps://github.com/tutao/tutanota/issues/5752", "createdAt": "2023-08-08T15:58:17Z", "updatedAt": "2023-08-08T15:58:17Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5jmRVk", "body": "Retested, cancelling from outlook, it is fine. Should we just accept the other two and finish this once and for all?", "createdAt": "2023-08-09T09:23:42Z", "updatedAt": "2023-08-09T09:23:42Z", "author": {"login": "vitoreiji"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5642, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["new feature", "state:tested", "topic: calendar", "model changes"], "milestone": "3.116.8", "sub_issues": [{"number": 5692, "title": "It's possible to change the calendar if editing a single instance of an event", "state": "CLOSED"}], "sub_issue_count": 1, "parent_issues": []}

tutao_tutanota_5703/issues/tutao_tutanota_5665.json

@@ -0,0 +1 @@
+{"number": 5665, "title": "Calendar not default using custom email ", "body": "- [X] This is not a feature request (existing functionality does not work, **not** missing functionality).\r\n I will request features on [forum](https://www.reddit.com/r/tutanota/) or via support.\r\n- [X] I've searched and did not find a similar issue.\r\n\r\n**Describe the bug**\r\nWhen using a custom domain, and custom domain email addr is default, then when sending an calendar invitation, the tutanota email is default used, instead of the custom domain email. In previous versions, the custom domain email addr was default used,\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. make sure to use a custom domain for email\r\n2. Create a new calandar event\r\n3. Invite a guest\r\n4. See the error, the tutanota email addr is used.\r\n\r\n**Expected behavior**\r\nThe calendar should default use the sender email as selected as default sender email, OR have an separate config setting for which email to addr to use when sending calendar events\r\n\r\n**Screenshots**\r\nIf applicable, add screenshots to help explain your problem.\r\n\r\n**Desktop (please complete the following information):**\r\n - OS: Ubuntu Linux\r\n - Desktop Environment, Ubuntu Linux\r\n - Version v3.115.2\r\n\r\n**Additional context**\r\nIt was working correctly previously, but has changed in a recent update\r\n", "state": "CLOSED", "created_at": "2023-07-25T15:06:52Z", "closed_at": "2023-08-02T14:33:50Z", "author_login": "elsgaard", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5i7R3z", "body": "okay, the preselected mail address is wrong.\r\n\r\nAs a workaround for now, you can still select your desired organizer address by clicking on the address you want to change.\r\n\r\nthank you for the report!", "createdAt": "2023-08-01T07:13:46Z", "updatedAt": "2023-08-01T07:13:46Z", "author": {"login": "ganthern"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5703, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "state:tested", "state:done", "topic: calendar"], "milestone": "3.116.8", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5715/issues/tutao_tutanota_5708.json

@@ -0,0 +1 @@
+{"number": 5708, "title": "Importing events with rescheduled occurrences keeps original occurrence", "body": "Same result from Google Calendar, Outlook and Proton.\r\n\r\n1. On Google Calendar, create a weekly repeating event and reschedule one occurrence for the next day.\r\n2. Export that calendar and import it to Tutanota.\r\n3. See the repeating event, including the occurrence that was supposed to be rescheduled. One occurrence is also shown on the next day, i.e., the occurrence is duplicated.\r\n\r\n**Expected behavior**\r\nOccurrence is rescheduled and not duplicated.\r\n\r\n**Screenshots**\r\nOriginal in Google Calendar:\r\n![image](https://github.com/tutao/tutanota/assets/197261/273ec344-3bca-4cdf-a150-2bfccefd55da)\r\n\r\nImported to Tutanota:\r\n![image](https://github.com/tutao/tutanota/assets/197261/d33ab33a-48b3-4a40-b18c-50ca61db90a4)\r\n\r\n**Files**\r\nHere is the ICS file, for convenience:\r\n```\r\nBEGIN:VCALENDAR\r\nPRODID:-//Google Inc//Google Calendar 70.9054//EN\r\nVERSION:2.0\r\nCALSCALE:GREGORIAN\r\nMETHOD:PUBLISH\r\nX-WR-CALNAME:Another export test\r\nX-WR-TIMEZONE:Europe/Berlin\r\nBEGIN:VEVENT\r\nDTSTART;VALUE=DATE:20230802\r\nDTEND;VALUE=DATE:20230803\r\nRRULE:FREQ=WEEKLY;BYDAY=WE\r\nDTSTAMP:20230801T093501Z\r\nUID:4k0c5e7dv6if6k81ercq7bt372@google.com\r\nCREATED:20230801T093020Z\r\nLAST-MODIFIED:20230801T093455Z\r\nSEQUENCE:0\r\nSTATUS:CONFIRMED\r\nSUMMARY:Ghoulgle event\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nBEGIN:VEVENT\r\nDTSTART;VALUE=DATE:20230810\r\nDTEND;VALUE=DATE:20230811\r\nDTSTAMP:20230801T093501Z\r\nUID:4k0c5e7dv6if6k81ercq7bt372@google.com\r\nRECURRENCE-ID;VALUE=DATE:20230809\r\nCREATED:20230801T093020Z\r\nLAST-MODIFIED:20230801T093455Z\r\nSEQUENCE:1\r\nSTATUS:CONFIRMED\r\nSUMMARY:Ghoulgle event\r\nTRANSP:TRANSPARENT\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n```", "state": "CLOSED", "created_at": "2023-08-01T09:50:27Z", "closed_at": "2023-08-03T08:45:54Z", "author_login": "vitoreiji", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5715, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["dev bug", "state:tested", "state:done", "topic: calendar"], "milestone": "3.116.8", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5719/issues/tutao_tutanota_5707.json

@@ -0,0 +1 @@
+{"number": 5707, "title": "Calendar Events are not added to other calendars when inviting ", "body": "\r\n- Create an event with rescheduled events. and invite a non-tutanota user\r\n- For the non-tutanota user the event is not able to be added to their calendar (for example, Protonmail will say \"Unsupported Invite\" and Gmail will just not add it.", "state": "CLOSED", "created_at": "2023-08-01T09:29:02Z", "closed_at": "2023-08-03T08:48:51Z", "author_login": "wrdhub", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5i-Ok0", "body": "looks like proton does not support event series that have both altered instances and attendees at all. \r\n\r\nadding attendees on proton calendars resets all altered instances, and trying to edit a single instance on an event with attendees will always update all events of the series.", "createdAt": "2023-08-01T14:47:15Z", "updatedAt": "2023-08-01T14:47:15Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5i-hxR", "body": "I'm not sure what's up with the google calendar. The progenitor shows up fine, but the rescheduled instance is not accepted into the calendar at all. it just shows the yes/no/maybe selector that does not seem to do anything.\r\n\r\neven downloading and importing the invite does nothing, it just says \"1 event imported\" and then it doesn't show.\r\n\r\nour invites look like the ones google is sending at first glance, but there might be a subtle difference.\r\n\r\nwhen trying the same from outlook to google, it seems to work. need to investigate what they're doing differently. outlook also handles our invitations fine it seems.", "createdAt": "2023-08-01T15:27:19Z", "updatedAt": "2023-08-01T16:00:51Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5jEqiy", "body": "so there are two issues, one easily handled, the other not so much (that's why I'm upgrading this to a bug):\r\n\r\n#### we did not format the recurrenceId quite correctly when exporting \r\n\r\nwe should export it as UTC but did it in the local time zone\r\n\r\n#### google calendar will refuse to handle rescheduled instances for which the original start time/recurrenceId is added as an exclusion to the progenitor. \r\n\r\nwe're internally always adding rescheduled instances as an exclusion to make alarm\r\n  handling easy and need to remove those exclusions before exporting or sending calendar notifications.\r\n\r\nsome solution ideas:\r\n1. make any operation that results in an exported event a whole-series affair and always pass around all\r\n   events belonging to that series so we can filter out exclusions that were added for altered instances. this can be done retroactively after we already started producing recurrenceIds, but requires to change our model from passing around single events to passing around whole uid index entries. it's also error-prone, considering we're interleaving sending notifications and updating events during some edit operations.\r\n2. add a separate list of \"exclusions\" next to the normal exclusions on repeat rules that allows us to only serialize the\r\n   actually deleted instances. this needs to be kept in sync when deleting / creating altered instances,\r\n   but we're handling that for the current process already. involves a slight model change and requires updating the instance enumeration/alarm scheduling on all platforms.\r\n3. mark the exclusions by adding a boolean field to the dateWrapper and filter on that -> another model change, similar to 2. slightly easier because we can still keep a single sorted list of exclusions. \r\n\r\n\r\nmethod 1 is a bit messy but easy to retrofit, methods 2 & 3 are harder to implement, but cleaner and hard to migrate after the fact.", "createdAt": "2023-08-02T12:58:16Z", "updatedAt": "2023-08-02T13:14:51Z", "author": {"login": "ganthern"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5719, "link_type": "closing_keyword", "will_close": true, "comment_count": 3, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["dev bug", "state:tested", "state:done", "topic: calendar"], "milestone": "3.116.8", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5766/issues/tutao_tutanota_4221.json

@@ -0,0 +1 @@
+{"number": 4221, "title": "remove usages of deprecated KeyboardEvent properties in KeyManager", "body": "i.e. `which`, `keyCode`\r\n\r\n## Test Notes\r\nTest all of these on multiple keyboard types and keyboard layouts\r\n- [ ] Keyboard controls for mail view work as expected -> Pressing enter and key up/down does not work any more on the recipient suggestions, see https://github.com/tutao/tutanota/issues/5829\r\n- [x] Keyboard controls for interacting with a single mail work as expected\r\n- [x] Keyboard controls for writing a mail work as expected\r\n- [x] Keyboard controls for contact view work as expected\r\n- [x] Keyboard controls for calendar view work as expected\r\n\r\nNote: ctrl + e exporting contacts even when not in the contacts view was a pre-existing bug that is fixed in a different PR (the upcoming contact lists)", "state": "CLOSED", "created_at": "2022-05-27T13:27:01Z", "closed_at": "2023-08-30T14:21:18Z", "author_login": "ganthern", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5EBFIQ", "body": "I'm not sure if alternatives work everywhere already", "createdAt": "2022-05-30T13:04:03Z", "updatedAt": "2022-05-30T13:04:03Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5EBFjH", "body": "I'm pretty sure that this will be a medium refactoring even if everything is supported since key codes seem to be on the way out in general.", "createdAt": "2022-05-30T13:05:35Z", "updatedAt": "2022-05-30T13:05:35Z", "author": {"login": "ganthern"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5766, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "maintenance"], "milestone": "3.118.4", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5779/issues/tutao_tutanota_5584.json

@@ -0,0 +1 @@
+{"number": 5584, "title": "Unlimited custom domain mail addresses for the new plans", "body": "As a user who owns a custom domain, I want to be able to define as many email addresses as I want with that domain, so that I can take full advantage of my domain name.\n\n## AC\n* Custom domain mail addresses are not counted as used email alias for plans with unlimited custom domain alias support.\n* Behavior for Tutanota domain aliases does not change\n* Unlimited custom domain alias feature is available for all new paid plans\n* Numbers of used / available aliases are shown in the settings including a hint that custom domain aliases do not count towards the email address limit.\n\n## Additional info\n* Showing this feature in the plan feature list (website and client) will be handled in a separate issue.\n* Server branch is unlimited-custom-addresses-5584\n\n## Tasks\n- [x] Adapt settings to show the number of used Tutanota email addresses and info about what affects limit\n- [x] Add new translations to Phrase\n- [x] Adapt server side to allow this\n- [x] Make sure downgrading checks for all kinds of aliases\n\n## Test Notes\n* [x] it's not possible to downgrade to free if there are any extra addresses enabled\n* [x] the number of used / enabled addresses does not change for new plans when adding or deleting custom domain addresses\n* [x] the number does change as expected when adding / disabling / enabling tutanota addresses for new and legacy plans\n* [x] it's possible to add more custom domain addresses if the limit is reached for tutanota addresses on new plans\n* [x] it's still possible to reassign any addresses to a different user when the limit is reached on the sending user\n* [x] it's still possible to reassign any addresses to a different user when the limit is reached for the customer on legacy plans\n* [x] it's only possible to reassign an address to a different user when the user's \"used\" limit is not reached (new plans)\n* [x] for legacy plan customers, the custom domain addresses still count towards the limit\n* [x] it is not possible to switch to a plan with less aliases if the \"used\" aliases count is higher (new plans and legacy)", "state": "CLOSED", "created_at": "2023-06-30T11:12:26Z", "closed_at": "2023-09-07T14:16:44Z", "author_login": "bedhub", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5gbBTN", "body": "Should also consider implementing #4566.", "createdAt": "2023-07-03T09:16:05Z", "updatedAt": "2023-07-03T09:16:05Z", "author": {"login": "vitoreiji"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5jmPcz", "body": "When this is being implemented. I feel like it would also be a huge opportunity to integrate it with services like bitwarden. To have the alias be auto-created if at all technically possible.\r\nhttps://bitwarden.com/blog/use-bitwarden-to-generate-email-aliases-with-fastmail/\r\n\r\nProbably at a later stage, with a different issue to avoid this from holding up this feature.", "createdAt": "2023-08-09T09:18:29Z", "updatedAt": "2023-08-09T09:19:58Z", "author": {"login": "D0T1X"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5mFBs4", "body": "It is stated as Done but as of right now, still not able to create more than 15 aliases with my custom domain.\r\n\r\nAm I missing out something?", "createdAt": "2023-09-09T20:21:48Z", "updatedAt": "2023-09-09T20:21:48Z", "author": {"login": "githupper"}}, {"id": "IC_kwDOAVT0qs5mHfAK", "body": "@githupper \"Done\" means we are done developing it, not necessarily that it is already released. We finished this recently, so it will be on the next release.", "createdAt": "2023-09-11T06:20:31Z", "updatedAt": "2023-09-11T06:20:31Z", "author": {"login": "vitoreiji"}}, {"id": "IC_kwDOAVT0qs5mP1dX", "body": "Finally! \r\nYou were really lagging behind and I was just about to jump ship to skiff. Glad I searched and found this.\r\n\r\nI hope this will apply not only to the highest tier plans, but all plans which have custom domain option.", "createdAt": "2023-09-12T10:16:42Z", "updatedAt": "2023-09-12T10:16:42Z", "author": {"login": "C8opmBM"}}, {"id": "IC_kwDOAVT0qs5mQEGY", "body": "The update has just been released, the hint is present (_custom domain addresses do not count towards the limit_), however they DO count towards the limit.\r\nI tried deleting and re-adding one, same behaviour.\r\n\r\nI have the old premium plan with 5 aliases and 1 custom domain.\r\nCan you please clarify? Thanks!", "createdAt": "2023-09-12T10:46:12Z", "updatedAt": "2023-09-12T10:46:12Z", "author": {"login": "C8opmBM"}}, {"id": "IC_kwDOAVT0qs5mQIIO", "body": "> I have the old premium plan with 5 aliases and 1 custom domain.\r\n\r\nThis feature only applies to the new paid plans (Revolutionary, Legend, Essential, Advanced, Unlimited)", "createdAt": "2023-09-12T10:57:32Z", "updatedAt": "2023-09-12T10:57:55Z", "author": {"login": "ganthern"}}, {"id": "IC_kwDOAVT0qs5mQL5Q", "body": "Not good tutanota. I've been waiting for this for a long time to drop anondaddy or refrain from going to skiff which offer this for free. You will, slowly, be left behind.\r\n\r\nHave a good day.", "createdAt": "2023-09-12T11:08:34Z", "updatedAt": "2023-09-12T11:08:34Z", "author": {"login": "C8opmBM"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5migj5", "body": "> > I have the old premium plan with 5 aliases and 1 custom domain.\r\n> \r\n> This feature only applies to the new paid plans (Revolutionary, Legend, Essential, Advanced, Unlimited)\r\n\r\nSo I guess we will slowly see users using the old paid plan being left behind on new features to try force their hand to migrate to one of the newer more expensive plans?", "createdAt": "2023-09-15T00:28:38Z", "updatedAt": "2023-09-15T00:28:38Z", "author": {"login": "quamok"}}, {"id": "IC_kwDOAVT0qs5mkNvW", "body": "I'd like to hear compelling arguments against existing customers getting what they pay for (a supported and regularly maintained product) and us financing the development of new features in a way that enables us to expand development capacity.\r\n\r\nBut not here, because that would be against the rules. Please contact premium support with any concerns, they will be forwarded to the appropriate people.", "createdAt": "2023-09-15T06:53:51Z", "updatedAt": "2023-09-15T06:56:08Z", "author": {"login": "ganthern"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5779, "link_type": "closing_keyword", "will_close": true, "comment_count": 10, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["new feature", "state:tested", "state:done"], "milestone": "3.118.6", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5779/issues/tutao_tutanota_5858.json

@@ -0,0 +1 @@
+{"number": 5858, "title": "Email address table closes automatically when adding alias", "body": "How to reproduce:\r\n1. Open Settings -> User management\r\n2. Expand email address table\r\n3. Add email alias\r\n-> The table is closed\r\nExpected: the table stays expanded", "state": "CLOSED", "created_at": "2023-09-07T10:04:48Z", "closed_at": "2023-09-07T14:16:44Z", "author_login": "armhub", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5779, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "state:tested", "state:done"], "milestone": "3.118.6", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5791/issues/tutao_tutanota_5407.json

@@ -0,0 +1 @@
+{"number": 5407, "title": "", "body": "", "state": "", "created_at": "", "closed_at": null, "author_login": "", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5lKb9f", "body": "\"Loading entry by URL will load and select the entry\" does not work. Redirected to contact list view but not entries are loaded.\r\n\r\ntesting with one stored account (auto-login) and with multiple accounts (no auto-login).", "createdAt": "2023-08-29T11:08:32Z", "updatedAt": "2023-08-29T11:09:27Z", "author": {"login": "kibibytium"}}, {"id": "IC_kwDOAVT0qs5lKg8p", "body": "Some notes:\r\n\r\n- Adding invalid email address does not throw an error. Editor vanishes and invalid address is not added.\r\n- Adding a duplicate address does not throw an error/warning. ", "createdAt": "2023-08-29T11:23:51Z", "updatedAt": "2023-08-29T11:23:51Z", "author": {"login": "kibibytium"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5l2pUl", "body": "Is this feature intended to be unavailable with the old subscription model?", "createdAt": "2023-09-06T17:39:47Z", "updatedAt": "2023-09-06T17:39:47Z", "author": {"login": "GenericGuy"}}, {"id": "IC_kwDOAVT0qs5l5i0h", "body": "> Is this feature intended to be unavailable with the old subscription model?\r\n\r\nYes. The new paid plans are more expensive, and so we feel that it is fair that some features are only available with those plans. This is in part to incentivize switching, but also because that extra support really does help us to be able to work on these new features.\r\n\r\nWe appreciate everyone's support so that we can continue to work on Tutanota!", "createdAt": "2023-09-07T06:59:25Z", "updatedAt": "2023-09-07T06:59:25Z", "author": {"login": "wrdhub"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "state:done", "contact lists"], "milestone": "3.118.1", "sub_issues": [], "sub_issue_count": 0, "parent_issues": [{"number": 393, "title": "Recipient lists", "state": "CLOSED"}]}

tutao_tutanota_5791/issues/tutao_tutanota_5432.json

@@ -0,0 +1 @@
+{"number": 5432, "title": "", "body": "", "state": "", "created_at": "", "closed_at": null, "author_login": "", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5802, "link_type": "closing_text", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "state:done", "contact lists"], "milestone": "3.118.1", "sub_issues": [], "sub_issue_count": 0, "parent_issues": [{"number": 393, "title": "Recipient lists", "state": "CLOSED"}]}

tutao_tutanota_5791/issues/tutao_tutanota_5433.json

@@ -0,0 +1 @@
+{"number": 5433, "title": "Allow sharing of contact lists", "body": "## User story\nAs a user i want to be able to share my contact lists with other Tutanota users so they can send emails to the same group of addresses.\n\n## AC\n* Sharing individual contact lists is possible, similar to sharing a calendar\n* Contact list invitations are shown below the Contact lists in another \"invitation\" section\n* Shared contact lists are shown in its own section \"other contact lists\"\n\n## Test Notes\n- [x] The creator of a contact list can share the contact list with other users.\n- [x] Shared users with \"read only\" permission cannot share the contact list with other users\n- [x] Shared users with \"read and write\" permission cannot share the contact list with other users\n- [x] Shared users with \"write and manage sharing\" permission can share the contact list with other users\n- [x] Sharing a contact list with another user has that contact list show up in the other user's Contact page under \"Contact List Invitations\"\n- [x] Accepting an invitation works, and an email is sent to the Invitor\n- [x] Declining an invitation works, and an email is sent to the Invitor\n- [x] A user accepting an invitation to a contact list can rename the list while accepting the invitation\n- [x] Contact lists that have been shared with a user show up on the shared user under \"Shared Contact Lists\"\n- [x] A user can edit the name of a contact list that has been shared with them, this change will only apply to their list and not change the name for other users. The name is persistent and stays after reload\n- [x] The creator of the contact list can remove added users through the sharing dialog\n- [x] Shared users with \"read only\" permission cannot remove users through the sharing dialog\n- [x] Shared users with \"read and write\" permission cannot remove users through the sharing dialog\n- [x] Shared users with \"write and manage sharing\" permission can remove users through the sharing dialog\n- [x] Removing a shared user immediately removes the contact list from their \"Shared Contact Lists\" list\n- [x] The creator of the contact list deleting the contact list immediately removes it for other users\n- [x] Changes made by the creator to the list of addresses in the contact list are immediately reflected in shared user's copy of that list\n- [x] Shared users with \"read only\" permission cannot add or remove addresses to the contact list\n- [x] Changes made by a user with \"read and write\" permission to the list of addresses in the contact list are immediately reflected in shared user's copy of that list\n- [x] Changes made by a user with \"write and manage sharing\" permission to the list of addresses in the contact list are immediately reflected in shared user's copy of that list\n- [x] Shared contact lists show up in suggestions (such as when writing an email or adding guests to an event)\n- [x] A user can remove a shared contact list by selecting \"leave group\"\n- [x] A user can remove a shared contact list by selecting \"sharing\" and clicking the x by their name (no matter the permission level they have)\n- [x] An account that has a shared contact list will be prompted to remove the list when trying to downgrade to free account\n- [x] An account that is free cannot accept a contact list invitation and will be prompted to upgrade account\nRegression testing:\n- [x] Look at text around inviting users to calendars or template lists, and invited users accepting/declining those invitations. Make sure the text is appropriate and makes sense.\n\n", "state": "CLOSED", "created_at": "2023-05-05T09:53:14Z", "closed_at": "2023-08-24T15:07:52Z", "author_login": "bedhub", "comment_rounds": [{"comments": [{"id": "IC_kwDOAVT0qs5lKVKn", "body": "During  \"_A user can remove a shared contact list by selecting \"sharing\" and clicking the x by their name (no matter the permission level they have)_\": The view does not close and the user can click on the x by their name again which results in error \r\nNotAuthorizedError\r\nError message: 403: Nd-sjBB----0 | DELETE /rest/sys/membershipservice.", "createdAt": "2023-08-29T10:50:40Z", "updatedAt": "2023-08-29T10:50:40Z", "author": {"login": "jalhubb"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5802, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["state:tested", "state:done", "contact lists"], "milestone": "3.118.1", "sub_issues": [], "sub_issue_count": 0, "parent_issues": [{"number": 393, "title": "Recipient lists", "state": "CLOSED"}]}

tutao_tutanota_5791/pr.json

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:626f6cc989b682b201d07b097f4036a97b8333351e92c6c8716b09821923e395
+size 19629459

tutao_tutanota_5840/issues/tutao_tutanota_903.json

@@ -0,0 +1 @@
+{"number": 903, "title": "Shared mailboxes", "body": "As a admin of tutanota account, i want to configure mailboxes that can be accessed by multiple users, so that they can send and receive messages from that mailbox without the need to login into another account.\n\n## AC\n* Tutanota admin user can order shared mailboxes in \"Settings \u2192 Shared mailboxes\"  and assign users as members\n* The shared mailbox section is available for accounts with multi user support (new business plans, new private plans with multi-user support, legacy plans)\n* Ordering of shared mailboxes is only possible for new plans.\n* Members of such a mailbox see another mailbox with the same folder structure in their folder list.\n* A member can send and receive  SMTP messages\n* A member can send and receive end-to-end encrypted messages to other Tutanota users\n* Sending end-to-end encrypted messages to external user is not supported and shows an appropriate info message.\n* Local admin groups are kept in the new \"Shared mailboxes\" section\n\n## Tasks\n* [x] Rename the \"Groups\" section to \"Shared mailboxes\"\n* [x] Only show the shared mailboxes section for plans with multi user support\n* [x] Restrict creating shared mailboxes for admins of new paid plans. For others show an upgrade dialog.\n* [x] Verify that all members of the shared mailbox see it below their private mailbox\n* [x] Verify that members can send and receive SMTP messages\n* [x] Verify that members can send and receive end-to-end encrypted messages to other Tutanota users\n* [x] Show a dialog informing that it is not possible to send confidential emails to externals when a user tries to send one\n* [x] Verify that local admin groups are still visible and accessible in the new \"Shared mailboxes\" section\n* [x] Add an info link in the create dialog that points to an FAQ entry explaining details of the shared mailboxes\n\nBug collection for refinement:\n* When clicking on a notification for a new email in a shared mailbox the user inbox is opened instead (tested on desktop).\n\n## Test notes shared mailboxes\n- [x] Order shared mailboxes in Settings -> Shared mailboxes in a new paid plan\n- [x] Ordering a shared mailbox is not possible for legacy paid plans\n- [x] Check that the shared mailboxes section is available for new paid plans, new private plans with multi-user support and legacy paid plans\n- [x] Check that the shared mailboxes section is not available for the free plan and private plans without multi-user support\n- [x] Assign the admin user itself to the shared mailbox and remove it again\n- [x] Assign a non-admin user to the shared mailbox and remove it again\n- [x] Shared mailboxes are visible below the personal mailbox in the mail view\n- [x] When a folder of a shared mailbox is selected the sender in the email editor is the shared mailbox address\n- [x] When a folder of a personal mailbox is selected the sender in the email editor is the personal mailbox address\n- [x] Sending and receiving SMTP emails from a shared mailbox is possible\n- [x] Sending and receiving internal emails from a shared mailbox is possible\n- [x] When trying to send a confidential email to externals (click send button) a dialog is shown informing that this is not possible yet.\n- [x] Existing local admin groups are visible in the shared mailbox section as well.\n- [x] The info link at the bottom of the add shared mailbox dialog points to an FAQ entry informing about shared mailboxes\n- [x] Deactivating and activating shared mailboxes is possible. The price changes in this case.\n- [x] Change the sender name of the shared mailbox and check that it is used when sending an email.\n- [x] Regression test adding/removing users, including the own user, from a calendar group\n- [x] Regression test adding/removing users, including the own user, from contact list groups\n- [x] Regression test adding/removing users, including the own user, from template groups", "state": "CLOSED", "created_at": "2018-12-06T21:36:01Z", "closed_at": "2023-09-07T14:58:33Z", "author_login": "armhub", "comment_rounds": [{"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDU2NTMxMzUwMw==", "body": "This is a very important feature for business use. I hope it will be coming soon.", "createdAt": "2019-12-13T06:06:38Z", "updatedAt": "2019-12-13T06:06:38Z", "author": {"login": "JimmyCushnie"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDU5MzE2ODA4MQ==", "body": "A little confused by the linked closed issues. By shared email accounts, does this mean mailboxes to which multiple users (with their own login credentials) have access?", "createdAt": "2020-03-02T00:04:26Z", "updatedAt": "2020-03-02T00:04:26Z", "author": null}, {"id": "MDEyOklzc3VlQ29tbWVudDU5MzgyMjExOA==", "body": "Yes, this is about shared mailboxes that can be used by multiple users at the same time without having to login as a different user. I have renamed the issue to make it better understandable. ", "createdAt": "2020-03-03T08:12:37Z", "updatedAt": "2020-03-03T08:12:37Z", "author": {"login": "armhub"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDYxOTkzMTAzMw==", "body": "This feature would also be great for families and couples, who want a shared email address, like us@[familiy_name].TLD. Currently, you need either need a separate account with the shared address or, if you make it an alias to one of the family member's account, other family members have to log into the other person's account. Instead, it would be nice to simply have one or more folders that could be accessed from each person's own account. ", "createdAt": "2020-04-27T11:46:07Z", "updatedAt": "2020-04-27T11:46:07Z", "author": {"login": "QEDeD"}}, {"id": "MDEyOklzc3VlQ29tbWVudDYxOTk1Nzg4MQ==", "body": "Shared mailboxes are a surprisingly rare feature of mail services, considering how useful they are!", "createdAt": "2020-04-27T12:34:35Z", "updatedAt": "2020-04-27T12:34:35Z", "author": null}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDY1Mzg2MTU3MA==", "body": "Am I mistaked here or this could be trivially solved by implementing #516? (One mailbox + aliases = shared mailbox)", "createdAt": "2020-07-05T09:07:27Z", "updatedAt": "2020-07-05T09:07:27Z", "author": {"login": "AFulgens"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDY3NDg3NTQ2OQ==", "body": "Any news regarding a release date? After all, it's been added to the project roadmap over 19 months ago. And it's (from my PoV) essential for families requiring a common inbox.", "createdAt": "2020-08-17T13:16:51Z", "updatedAt": "2020-08-17T13:16:51Z", "author": {"login": "laius"}}, {"id": "MDEyOklzc3VlQ29tbWVudDY3NDg3NjI0Mg==", "body": "> Am I mistaked here or this could be trivially solved by implementing #516? (One mailbox + aliases = shared mailbox)\r\n\r\nNo. We don't want one mailbox with two addresses. Instead we want two mailboxes of which one is shared.", "createdAt": "2020-08-17T13:18:19Z", "updatedAt": "2020-08-17T13:18:43Z", "author": {"login": "laius"}}, {"id": "MDEyOklzc3VlQ29tbWVudDY3NDg3Njc0MA==", "body": "> Any news regarding a release date? After all, it's been added to the project roadmap over 19 months ago. And it's (from my PoV) essential for families requiring a common inbox.\r\n\r\n\"Soon\"\u2122", "createdAt": "2020-08-17T13:19:18Z", "updatedAt": "2020-08-17T13:19:18Z", "author": {"login": "jflattery"}}, {"id": "MDEyOklzc3VlQ29tbWVudDY3NTI2OTczMA==", "body": "Looking forward to it \ud83d\ude42 ", "createdAt": "2020-08-18T05:56:32Z", "updatedAt": "2020-08-18T05:56:32Z", "author": {"login": "QEDeD"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDY4MDc4NDUxNg==", "body": "> > Any news regarding a release date? After all, it's been added to the project roadmap over 19 months ago. And it's (from my PoV) essential for families requiring a common inbox.\r\n> \r\n> \"Soon\"\u2122\r\n\r\nCould you specify this a little? Like, are we talking closer to 4 weeks or 4 months?", "createdAt": "2020-08-26T10:01:12Z", "updatedAt": "2020-08-26T10:01:12Z", "author": {"login": "laius"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDY4MjUxMjU5Ng==", "body": "> > > Any news regarding a release date? After all, it's been added to the project roadmap over 19 months ago. And it's (from my PoV) essential for families requiring a common inbox.\n> \n> > \n> \n> > \"Soon\"\u2122\n> \n> \n> \n> Could you specify this a little? Like, are we talking closer to 4 weeks or 4 months?\n\nI would say 4 years, give or take 3 years should be about accurate. But I know nothing.", "createdAt": "2020-08-28T12:48:09Z", "updatedAt": "2020-08-28T12:48:09Z", "author": {"login": "jflattery"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDczNTk4NDMzMw==", "body": "Bump -- @armhub is there any ETA for this? It is a pain forwarding emails to the other person who needs to see them.", "createdAt": "2020-11-30T19:11:46Z", "updatedAt": "2020-11-30T19:11:46Z", "author": {"login": "JimmyCushnie"}}]}, {"comments": [{"id": "MDEyOklzc3VlQ29tbWVudDgzNTcyMzA1NA==", "body": "Come on. Please do this.\nThe only privacy friendly clients are K-9 and FairEmail.\n\nThe only alternatives would be Tutunota or ProtonMail (if they do it) or CanaryMail (they think about making it open source)", "createdAt": "2021-05-09T07:18:20Z", "updatedAt": "2021-05-09T07:18:20Z", "author": {"login": "sami155"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs45mTgh", "body": "i vote for this. It will be a **game changer!** _C'mon Tutanota team_  ", "createdAt": "2021-11-11T14:23:05Z", "updatedAt": "2021-11-11T14:23:05Z", "author": {"login": "BriT999"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs46wyfv", "body": "Please, as a family, this is absolutely necessary.", "createdAt": "2021-12-03T21:53:11Z", "updatedAt": "2021-12-03T21:53:11Z", "author": {"login": "Creylia"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs48ftgu", "body": "Will this support multiple accounts as suggested in #521 ? \r\n\r\nI ask as I am considering Tutanota for both a separate Private and Business account (with custom domains), which I'd want to access using the same mobile device. An Android Work Profile might be a workaround in the short term...", "createdAt": "2022-01-17T23:13:17Z", "updatedAt": "2022-01-17T23:13:17Z", "author": {"login": "evilrobot-01"}}, {"id": "IC_kwDOAVT0qs48gkW_", "body": "@EVLRBT-01 your use case is already supported; you can log into multiple accounts with your device and switch between them at will. All of them will be able to get notifications.", "createdAt": "2022-01-18T08:20:48Z", "updatedAt": "2022-01-18T08:20:48Z", "author": {"login": "vitoreiji"}}, {"id": "IC_kwDOAVT0qs48g-fl", "body": "Not on mobile? You need to log out and back in as the other user as far as I am aware?\n\nThe FAQ on the Tutanota site also says \"In the mobile app, you can currently only login with one user.\".\n________________________________\nFrom: Vitor Sakaguti ***@***.***>\nSent: Tuesday, January 18, 2022 8:21:01 AM\nTo: tutao/tutanota ***@***.***>\nCc: EVLRBT-01 ***@***.***>; Mention ***@***.***>\nSubject: Re: [tutao/tutanota] Shared mailboxes (#903)\n\n\n@EVLRBT-01<https://github.com/EVLRBT-01> your use case is already supported; you can log into multiple accounts with your device and switch between them at will. All of them will be able to get notifications.\n\n\u2014\nReply to this email directly, view it on GitHub<https://github.com/tutao/tutanota/issues/903#issuecomment-1015170495>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AORABCWRNRBNKLFC7BA5PADUWUPG3ANCNFSM4GI5OCWQ>.\nTriage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.\nYou are receiving this because you were mentioned.Message ID: ***@***.***>\n", "createdAt": "2022-01-18T10:31:52Z", "updatedAt": "2022-01-18T10:31:52Z", "author": {"login": "evilrobot-01"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs494qRt", "body": "I honestly can not believe this was started in 2018 and we're in to 2022 and this has still not been implemented. How do you offer business accounts without this basic option? I would love to move away from Office 365 and come here but there's not even the basics. ", "createdAt": "2022-02-13T17:01:41Z", "updatedAt": "2022-03-01T08:12:22Z", "author": {"login": "deangmx"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs4-2lDE", "body": "Stil waiting.\r\n\r\nDamn why it takes so long?", "createdAt": "2022-02-28T17:31:15Z", "updatedAt": "2022-03-01T08:12:16Z", "author": {"login": "Creylia"}}]}, {"comments": [{"id": "IC_kwDOAVT0qs5UJ3l0", "body": "Just going to add my voice to the rest to say that a shared mailbox that is accessible from two different accounts without additional log in steps will be a huge win - I will pay money and shift domains to whichever secure email provider comes up with this first but none seem to see it as any kind of priority.", "createdAt": "2023-02-01T11:03:37Z", "updatedAt": "2023-02-01T11:03:37Z", "author": {"login": "cyb3n3tic"}}, {"id": "IC_kwDOAVT0qs5UKPvd", "body": "It is actually possible to book it via Settings -> Groups -> Add group  but some functionality is unfinished (e.g. signature)", "createdAt": "2023-02-01T12:21:34Z", "updatedAt": "2023-02-01T12:21:34Z", "author": {"login": "charlag"}}, {"id": "IC_kwDOAVT0qs5UKROX", "body": "OK, that's interesting - I will see how that works. Thanks", "createdAt": "2023-02-01T12:26:42Z", "updatedAt": "2023-02-01T12:26:42Z", "author": {"login": "cyb3n3tic"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 5840, "link_type": "closing_keyword", "will_close": true, "comment_count": 24, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["new feature", "state:tested", "state:done"], "milestone": "3.118.6", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

tutao_tutanota_5854/issues/tutao_tutanota_5710.json

@@ -0,0 +1 @@
+{"number": 5710, "title": "Remind users to switch to new plans", "body": "As a user on the new paid plans, I want to be reminded that the new plans offer great features and I can do the switch.\r\n\r\n## AC\r\n-    The upgrade reminder dialog shows the new texts\r\n-    For Free customer the dialog is shown 14 days after account creation and then every 3 months.\r\n-    For private customers that are on a legacy paid plan the dialog is shown once after login and never repeated.\r\n\r\n## Notes\r\nNew texts:\r\n- `upgradeReminderTitle_msg`:  Get the best of Tutanota! \r\n- `premiumOffer_msg`:  \"Your support will enable us to offer privacy to everyone.  Upgrade now and enjoy the many benefits you get with Revolutionary and Legend!\"\r\n\r\n## Test notes\r\nIf you struggle to find a legacy account use local one and change the plan via admin client.\r\nYou can adjust the intervals via dev tools before logging in to make it easier to test:\r\n`tutao.locator.Const.INITIAL_UPGRADE_REMINDER_INTERVAL_MS` and `tutao.locator.Const.REPEATED_UPGRADE_REMINDER_INTERVAL_MS`.\r\n\r\n - [x] Free account, upgrade not shown before `INITIAL_UPGRADE_REMINDER_INTERVAL_MS` has passed since the account creation\r\n - [x] Free account, upgrade shown after `INITIAL_UPGRADE_REMINDER_INTERVAL_MS` has passed since the account creation\r\n - [x] Free account, upgrade not shown until `REPEATED_UPGRADE_REMINDER_INTERVAL_MS` passed since the last upgrade reminder\r\n - [x] Free account, upgrade shown again after `REPEATED_UPGRADE_REMINDER_INTERVAL_MS` since the last upgrade reminder\r\n - [x] Legacy paid private account, upgrade is shown after `INITIAL_UPGRADE_REMINDER_INTERVAL_MS` has passed since the account creation\r\n - [x] Legacy paid business account, upgrade reminder never shown\r\n - [x] New paid account, upgrade not shown no matter how much time has passed since the account creation or last reminder (before the upgrade)\r\n", "state": "CLOSED", "created_at": "2023-08-01T12:33:34Z", "closed_at": "2023-09-22T08:37:16Z", "author_login": "vitoreiji", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 5854, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["improvement", "state:tested", "state:done"], "milestone": "3.118.12", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}