Sync from source tree: docs/tests drift since 2026-07-29

tests/test_dataset.py

@@ -293,8 +293,56 @@ def test_readme_marks_the_two_figures_it_cannot_reproduce():
     Every other number on the card re-derives from the published files. These
     two do not, and a reader has no way to tell them apart unless we say so.
     """
+    import re
+
     readme = (HERE / "README.md").read_text(encoding="utf-8")
+    markers = ("not part of this release", "cannot re-derive")
+    at = [m.start() for k in markers for m in re.finditer(re.escape(k), readme)]
+    assert at, "the card carries no non-reproducibility disclosure at all"
+
+    # Two failure modes to close, both found by adversarial review of an
+    # earlier version of this guard:
+    #   * a figure quoted somewhere far from any disclosure (e.g. a summary
+    #     table appended to the end of the card) -- so check EVERY occurrence,
+    #     not just the first;
+    #   * one disclosure sentence covering both figures, so that deleting it
+    #     silently un-discloses two numbers -- so require distinct markers.
+    WINDOW = 500  # every real mention today sits within 358 characters
+    nearest = {}
     for figure in ("0.081%", "0.9053"):
-        assert figure in readme, f"{figure} vanished; drop this guard with it"
-    assert "not part of this release" in readme
-    assert "cannot re-derive it from what is published here" in readme
+        hits = list(re.finditer(re.escape(figure), readme))
+        assert hits, f"{figure} vanished; drop this guard with it"
+        for m in hits:
+            d = min(abs(m.start() - x) for x in at)
+            assert d <= WINDOW, (
+                f"{figure} is quoted at character {m.start()} with no "
+                f"disclosure within {WINDOW} characters (nearest is {d} away)"
+            )
+        nearest[figure] = min(at, key=lambda x: min(abs(m.start() - x) for m in hits))
+
+    assert len(set(nearest.values())) == 2, (
+        "both figures lean on the same disclosure sentence; each needs its own, "
+        "or removing one silently un-discloses the other"
+    )
+
+
+def test_citation_points_at_a_home_that_exists():
+    """CITATION.cff pointed at a GitHub repo that was never created.
+
+    The dataset is published on the Hub, not on GitHub, so `repository-code`
+    named a URL that 404s -- on the one file whose entire job is telling people
+    where this came from. Checked offline by shape: a citation may only name a
+    host this project actually publishes to.
+    """
+    import re
+
+    cff = (HERE / "CITATION.cff").read_text(encoding="utf-8")
+    m = re.search(r'repository-code:\s*"?([^"\n]+)', cff)
+    assert m, "CITATION.cff names no repository-code"
+    url = m.group(1).strip()
+    assert url.startswith(
+        ("https://huggingface.co/datasets/nickh007/", "https://github.com/nickharris808/")
+    ), f"citation points somewhere this project does not publish: {url}"
+    assert "github.com/nickharris808/screening-ceiling" not in url, (
+        "that GitHub repo does not exist; this dataset lives on the Hub"
+    )