owner stringclasses 14
values | repo stringclasses 14
values | id int64 116k 4.61B | issue_number int32 1 181k | author stringlengths 1 39 | body stringlengths 1 262k | created_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:16:18 | updated_at timestamp[us]date 2000-06-06 02:40:44 2026-06-02 20:22:56 | reactions unknown | author_association stringclasses 5
values |
|---|---|---|---|---|---|---|---|---|---|
vuejs | core | 1,450,923,017 | 6,206 | carvemerson | Hi @dxvladislavvolkov, I just had the same issue as you.
I fixed it in the following way:
| 2023-03-01T22:13:10 | 2023-03-01T22:13:10 | {} | NONE |
vuejs | core | 1,452,876,360 | 5,339 | edison1105 | duplicate of https://github.com/vuejs/core/issues/7392 and will be fixed via https://github.com/vuejs/core/pull/7432 | 2023-03-03T02:44:43 | 2023-03-03T02:45:21 | {} | MEMBER |
vuejs | core | 1,455,098,273 | 7,819 | baiwusanyu-c | I closed the pr because I thought it over and thought it was expected
1. InheritAttrs: false is not set, so some attributes will be inherited by subcomponents to dom by default
2. From the source code pointed out by @RicardoErii, it can be seen that the corresponding props need to be explicitly set in the component, ... | 2023-03-05T13:52:20 | 2023-03-05T13:52:20 | {} | MEMBER |
vuejs | core | 1,455,208,729 | 7,832 | rdhelms | Also, @LinusBorg I decided to look into the `defineComponent` typing in `apiDefineComponent.ts`, and this is the overload that I'm ending up in by passing the generic type without a runtime value. The fact that I'm in the "no props" case along with the comment "uses user defined props interface" seems to indicate that ... | 2023-03-05T21:16:16 | 2023-03-05T21:16:16 | {} | NONE |
vuejs | core | 1,455,799,289 | 7,817 | I-love-learn | @baiwusanyu-c I SEE，I don't think anyone will ever use it like I do ，lol | 2023-03-06T09:42:07 | 2023-03-06T09:42:07 | {} | NONE |
vuejs | core | 1,456,150,980 | 7,836 | sxzz | @sto3psl It only fails when running on a single thread. Try `GITHUB_ACTIONS=1 pnpm run test-unit` locally. | 2023-03-06T13:37:05 | 2023-03-06T13:37:32 | {} | MEMBER |
vuejs | core | 1,456,164,172 | 7,835 | edison1105 | > Looks like Vue can indeed handle the teleport target change, but Vue only handles it while the teleport is enabled.
Correct, it seems that we also need to handle target changes when teleport is disabled.
| 2023-03-06T13:46:49 | 2023-03-06T13:46:49 | {} | MEMBER |
vuejs | core | 1,456,760,773 | 7,836 | sto3psl | @sxzz I implemented the backwards compat and reused the type everywhere. Added a comment too that will show up in Intellisense if one wonders why that union type is a bit weird 😄.
<img width="648" alt="Display union type with backwards compatibility" src="https://user-images.githubusercontent.com/5798652/223203416-... | 2023-03-06T18:51:09 | 2023-03-06T18:51:09 | {} | CONTRIBUTOR |
vuejs | core | 1,451,395,908 | 7,812 | houd1ni | Hi! What do you mean by not need to be handled ? That code line is not the same as in the original issue. In the issue, it's perfectly valid and makes sense. I haven't dove deep into the code, yet hope, it fixes my original issue with ;(window as any).prop 🛩️ | 2023-03-02T07:09:32 | 2023-03-02T07:09:32 | {} | NONE |
vuejs | core | 1,451,760,883 | 7,813 | baiwusanyu-c | When the `is` value is a string, it must be the registered name of the component. But in the syntactic sugar of setup, it seems that the component will not be registered automatically, so the alternative is to use `:is` | 2023-03-02T12:04:32 | 2023-03-02T12:04:32 | {} | MEMBER |
vuejs | core | 1,453,034,213 | 7,817 | edison1105 | you should add `inheritAttrs: false` to the child component. Because you did not define `modelValue` as props in the child component.
| 2023-03-03T06:14:12 | 2023-03-03T06:16:16 | {} | MEMBER |
vuejs | core | 1,454,897,009 | 6,962 | justinwinslow | Any progress on this? | 2023-03-04T21:45:26 | 2023-03-04T21:45:26 | {
"+1": 1
} | NONE |
vuejs | core | 1,455,070,306 | 5,584 | M1CK431 | > > I had a similar issue recently, the workaround I went with was creating a computed with a get and set. Passing the get to model and having the set emit the update.
> > ```js
> > const value = computed({
> > get() {
> > return props.modelValue;
> > },
> > set(value) {
> > emit("update:modelValue... | 2023-03-05T11:58:50 | 2023-03-05T11:58:50 | {
"rocket": 1
} | NONE |
vuejs | core | 1,455,387,453 | 3,044 | sxzz | `isShallow` is exported now, but didn't introduced in the docs. Should we make it public? | 2023-03-06T03:31:51 | 2023-03-06T03:31:51 | {} | MEMBER |
vuejs | core | 1,457,026,317 | 7,836 | sto3psl | I checked why the ecosystem-ci fails for a lot of suits and it's the same reason a lot of core tests failed here first.
> **Warning**
> `MathMLElement is not defined`
It looks like JSDOM doesn't provide `MathMLElement` as global. I worked around it by stubbing it with Vitest. Is there anything I can do about thi... | 2023-03-06T21:26:32 | 2023-03-06T21:26:32 | {} | CONTRIBUTOR |
vuejs | core | 1,451,351,963 | 4,733 | horans | > ```ts
> import {
> Comment,
> Text,
> Slot,
> VNode,
> } from 'vue';
> ```
You may need to add `type` when using Vite.
```ts
import { Comment, Text, type Slot, type VNode } from 'vue'
``` | 2023-03-02T06:10:15 | 2023-03-02T06:10:15 | {} | NONE |
vuejs | core | 1,451,934,058 | 7,814 | LinusBorg | This behavior is expected. `UserBindingObject.vue` emits a new, cloned user object. Which will replace the orginal user object.
But in the case of the filtered computed, it will replace the user object *in the filtered array* that was returned by the computed property. The original array will still contain the origi... | 2023-03-02T14:14:07 | 2023-03-02T14:17:27 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,453,038,474 | 7,818 | baiwusanyu-c | reactive will automatically infer its type based on the incoming object | 2023-03-03T06:20:15 | 2023-03-03T06:20:15 | {} | MEMBER |
vuejs | core | 1,457,426,452 | 7,839 | taoke4869 | Is this the problem? second line：`/node_modules/.vite/deps/vue.js?v=580ba9ff`
```js
import { createHotContext as __vite__createHotContext } from "/@vite/client";import.meta.hot = __vite__createHotContext("/src/components/SearchForm/index.vue");/* unplugin-vue-components disabled */const _sfc_main = { name: "SearchFor... | 2023-03-07T02:53:28 | 2023-03-07T02:53:28 | {} | NONE |
vuejs | core | 1,457,475,499 | 7,836 | sxzz | MathMLElement API is [introduced in Chrome > 109](https://caniuse.com/mdn-api_mathmlelement), so we should do some checks to ensure it's compatible with all ES6 browsers. `typeof MathMLElement === 'function' && el instanceof MathMLElement` | 2023-03-07T03:47:24 | 2023-03-07T03:47:24 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,457,667,367 | 7,840 | puppet-666 | @asuishi
But not always a function. However, what is confusing here is that since `Boolean(useSlots(). defult` is true (annotated nodes are created), why dom is not mounted. I think there is a performance inconsistency here
[Contrast Example](https://sfc.vuejs.org/#eNp9UslOwzAQ/RXLlxapsSVAQqpCVZYrJ66+hGRKA/EiL0Eoyr8... | 2023-03-07T07:12:32 | 2023-03-07T07:14:00 | {} | NONE |
vuejs | core | 1,451,544,378 | 5,339 | ghost | This also causes select inputs to show empty or the first option selected after the initial browser's render.
Which is not good. | 2023-03-02T09:16:52 | 2023-03-02T09:16:52 | {} | NONE |
vuejs | core | 1,455,128,659 | 7,830 | zhangenming |
@chatGPT translate
translate | 2023-03-05T15:49:58 | 2023-03-05T15:49:58 | {} | CONTRIBUTOR |
vuejs | core | 1,455,654,767 | 7,803 | sxzz | /ecosystem-ci run | 2023-03-06T08:02:49 | 2023-03-06T08:02:49 | {} | MEMBER |
vuejs | core | 1,455,798,974 | 6,548 | adroslice | What's the status on this? I'd really like to use this in a project. | 2023-03-06T09:41:53 | 2023-03-06T09:41:53 | {
"eyes": 1
} | NONE |
vuejs | core | 1,451,764,936 | 7,813 | LinusBorg | Correct. You need to pass the component itself as the value with `v-bind:is`, because in `script setup`, there is no local component registration - we just directly use the variable in the template. | 2023-03-02T12:07:29 | 2023-03-02T12:07:29 | {} | MEMBER |
vuejs | core | 1,451,768,333 | 7,813 | LinusBorg | Also, the reproduction uses Vue 2.6 compiler and a very old Vue CLI version, for some reason? | 2023-03-02T12:10:05 | 2023-03-02T12:10:52 | {} | MEMBER |
vuejs | core | 1,453,842,208 | 4,566 | hokkaido | @LinusBorg
Thanks. Like this? If so, I think this behaviour and workaround should be documented, will try to open a PR with the docs project.
<script lang="ts">
import { ExternalVue3Component } from "@acme-corp/ui-toolkit";
(ExternalVue3Component as any).compatConfig = { MODE: 3 };
//...
... | 2023-03-03T17:10:09 | 2023-03-03T17:17:13 | {} | NONE |
vuejs | core | 1,456,116,376 | 7,836 | sto3psl | > It's a breaking change to Vue, right? Can we avoid it?
>
> Maybe we can change API `isSVG?: boolean` to `namespace?: boolean | 'svg' | 'mathml'`. If `namespace` is `true` then fallback to `svg`.
I don't think so, since this is only internal code. As far as I can tell, no public APIs have changed. Please correct... | 2023-03-06T13:15:43 | 2023-03-06T13:15:43 | {} | CONTRIBUTOR |
vuejs | core | 1,456,135,324 | 7,836 | sxzz | > I don't think so, since this is only internal code. As far as I can tell, no public APIs have changed. Please correct me if I'm wrong.
<img width="668" alt="image" src="https://user-images.githubusercontent.com/6481596/223122726-02503edd-e1f1-46ec-89d1-c5044bbf045a.png">
It's a public API definitely. | 2023-03-06T13:26:46 | 2023-03-06T13:26:46 | {} | MEMBER |
vuejs | core | 1,456,138,874 | 7,836 | sto3psl | > > I don't think so, since this is only internal code. As far as I can tell, no public APIs have changed. Please correct me if I'm wrong.
>
> <img alt="image" width="668" src="https://user-images.githubusercontent.com/6481596/223122726-02503edd-e1f1-46ec-89d1-c5044bbf045a.png">
>
> It's a public API definitely.
... | 2023-03-06T13:29:08 | 2023-03-06T13:29:08 | {} | CONTRIBUTOR |
vuejs | core | 1,450,616,789 | 5,912 | skirtles-code | I think this may cause problems in cases that rely on the laziness of `computed` evaluation to avoid errors. e.g.:
* [Current `main` - no error](https://sfc.vuejs.org/#eNp9UclugzAQ/ZWRLwEpMW2PiETqf/jCMiRE3uSFHhD/3iEYmhzSk/1m5r03y8S+reVjRFayyrdusAE8hmgvQg/KGhdgAof9EVqjbAzYwQy9MwoORDoILXRrtA9Qw3mpyyahAcYSPoWe8790Q+lNI... | 2023-03-01T18:02:34 | 2023-03-01T18:02:34 | {
"eyes": 1
} | CONTRIBUTOR |
vuejs | core | 1,453,007,039 | 7,817 | baiwusanyu-c | [playground](https://sfc.vuejs.org/#eNqVkMFOwzAMhl/FyqUgseTAreqQEBfegEsuo3NHpyaOYncDVX13nG1UDInDbk78+/fvbzLPKdnDiKY2Dbe5TwKMMqYnH/uQKAtMkLGDGbpMASqVVkvrFYeB3igP28dL27oXCidDVbUUWSDwDtbF466q7n1s3HmNLmgEQxo2gloDTJMq57mU0Px2PqwCbXFYe6MCb8CVUbfMmgdzjrMKm2T3TFFvmYqNvzTYmxpOP+VPs5W3Nx8iiWvnuGtL4D1byjunlc1jlD6gRQ6r90xHxqzG3hQL... | 2023-03-03T05:44:39 | 2023-03-03T05:44:39 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,453,154,660 | 7,818 | LinusBorg | This seems to be a TS bug (or at least: a typically weird TS edge case). Here's a demo of what's happening in the [TS Playground](https://www.typescriptlang.org/play?#code/GYVwdgxgLglg9mABAJwKYENowG6oDwAqiqAHlKmACYDOicARgFarQB8AFA4wFyIECUvIgG8AsAChEUlKighkSLhIC+EiTDDlkwTKkQBBRGMmJ0valGQaA5iokQEF0wEZehgLxGJUs4gDk6H4ANN6... | 2023-03-03T08:27:46 | 2023-03-03T08:34:53 | {} | MEMBER |
vuejs | core | 1,453,178,909 | 7,818 | LinusBorg | Since were not dealing with a Union Type, I don't see how. I'm not one of the TS experts here, though
| 2023-03-03T08:49:54 | 2023-03-03T08:49:54 | {} | MEMBER |
vuejs | core | 1,453,614,311 | 7,820 | sto3psl | > Oh, we need to use the MathML namespace like we use SVG namespace for SVG elements. That will be a bigger change than initially expected.
@LinusBorg This is exactly right. I just checked the code and made it work with MathML.
<img width="948" alt="Working MathML rendered by Vue 3" src="https://user-images.gith... | 2023-03-03T14:28:59 | 2023-03-03T14:37:04 | {} | CONTRIBUTOR |
vuejs | core | 1,455,171,151 | 7,832 | rdhelms | @LinusBorg I had script setup's defineProps in mind when I tried defineComponent's generic type. I was hoping that defineComponent's generic Props type might be processed the same way as defineProp's generic type.
If that's not possible for some reason, would this be better suited as a feature request to make props ru... | 2023-03-05T18:46:45 | 2023-03-05T18:46:45 | {} | NONE |
vuejs | core | 1,456,264,494 | 7,276 | zhangzhonghe | > Any luck with getting the PR reviewed and released? Thanks.
@yxchai You could leave a comment in #7286 and @yyx990803 to review it. Maybe it will get yyx's attention. | 2023-03-06T14:41:15 | 2023-03-06T14:41:36 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,787,535,997 | 3,962 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB (**+6 B**) | 29.6 kB (**-67 B**) |
| vue.global.prod.js | 132 kB ... | 2023-10-31T16:11:03 | 2023-10-31T16:11:03 | {} | NONE |
vuejs | core | 1,789,240,957 | 9,523 | folmert | @LinusBorg after adding it to vite.config.js, re-building and re-running dev server I get an error:
> Uncaught TypeError: Cannot read properties of undefined (reading 'pushScopeId') | 2023-11-01T16:12:51 | 2023-11-01T16:12:51 | {} | NONE |
vuejs | core | 1,789,289,431 | 9,523 | LinusBorg | Then that might be a problem do ask help for in the "Discussions" section or on our discord.
Excluding the vue package from lib builds is correct and necessary. What the particular problem in your scenario is should be first analyzed in the community. | 2023-11-01T16:41:02 | 2023-11-01T16:41:02 | {} | MEMBER |
vuejs | core | 1,672,978,072 | 8,952 | TheAlexLichter | Added [another simple example](https://play.vuejs.org/#eNqNU8FOwzAM/RWTy0BiqwScSpkEiAMcALEdcxmdt2Vrkyhxt6HSf8dpt8G0MpCqNrafn19stxS31vaWBYpYJD51yhJ4pMJCNtLTGynIS9GXWuXWOIKByfHe8FmjJpg4k0OnF+15A1nnWuokaug4mQ3C3GYjQrYAkpNuF4Yz5cHPTJGNQRuClXEL6HYbwH6dmD8spdOW0pGC4zRDx4irC7aiNoqGobUmqpDdSrMvlp+J0vgfkRtoENcq57BUEu1aJM6566nRE... | 2023-08-10T10:38:00 | 2023-11-02T17:34:51 | {
"heart": 9
} | NONE |
vuejs | core | 1,791,262,821 | 9,528 | LinusBorg | I understand your sentiment, and am aware of the multitude of legacy apps out there. And I feel the pain of having to maintain these apps, often with with companies not willing (or arguably not able) to provide funds and/or time to migrate away even 8 years after the support of the library in question has stopped.
A... | 2023-11-02T17:54:10 | 2023-11-02T17:54:10 | {
"+1": 23,
"heart": 63
} | MEMBER |
vuejs | core | 1,793,406,097 | 7,073 | ycmjason | closing now. | 2023-11-04T10:28:31 | 2023-11-04T10:28:31 | {} | CONTRIBUTOR |
vuejs | core | 1,785,387,566 | 9,497 | Anoesj | How much does redundant re-rendering affect performance compared to doing a (sometimes really heavy) `isEquals`-like check? Maybe it's wise to do some benchmarks to see if this API change truly improves performance in various scenarios. E.g.:
- Small vs. huge objects/arrays/`Map`/`Set`/etcetera.
- Small vs. big templ... | 2023-10-30T14:51:29 | 2023-10-30T14:51:29 | {
"+1": 1
} | NONE |
vuejs | core | 1,789,550,577 | 9,528 | LinusBorg | My recommendation would be to re-override the override of prototype in that project with something that doesn't break modern JS.
We should not revert our change as we can't guarantee to respect such edge cases in the future, caused by outdated libraries that mess up globals (prototype is not the only one doing that,... | 2023-11-01T19:41:33 | 2023-11-01T19:42:07 | {
"+1": 9
} | MEMBER |
vuejs | core | 1,790,182,569 | 6,728 | jh-leong | As a workaround, use a sync flush watcher:
```ts
watch(
() => isActive.value,
v => {
// ...
},
{ flush: 'sync' }
)
``` | 2023-11-02T07:06:19 | 2023-11-02T07:06:57 | {} | MEMBER |
vuejs | core | 1,790,218,629 | 9,532 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-sfc-playground* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | e45c0205e31cc65c08d3098ba6964ba1460ecea4 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/vue... | 2023-11-02T07:39:34 | 2023-11-02T07:39:34 | {} | NONE |
vuejs | core | 1,793,002,790 | 7,073 | pikax | @ycmjason Apologies for just looking at this now, I've tried to fix the conflicts but I believe I wasn't have to sort out the tests, if you don't mind rebasing or if you don't have time we can just close this and start over. | 2023-11-03T19:42:08 | 2023-11-03T19:42:08 | {} | MEMBER |
vuejs | core | 1,797,926,674 | 9,546 | so1ve | @KUN1007 https://play.vuejs.org/#eNqNUslu20AM/RViLmmBWDrkUEBwirRFDu2hCRof5yJLtDKuNDPlUI4LQ/8earTEcRbkxv09PvKgvnmf7FpUmVqGgoxnCMithzq31aVWHLSCCi2SKcRdafVVW9N4RwwHuCXnV/89Qgcbcg2cyaQzbQtnA4OXZIBLKHFjLPal4dNBW4A8gzsmY6tzbXt/nUGMA7DMyuBmvcWCIQ/z/OVKUAG6saH4SIPU9hWE/1pDWGbA1GIMdtp2n/tJkWGST8Z6Mgptl+mghuCqczUsvGhyn2yDsyJWxNd... | 2023-11-07T07:04:55 | 2023-11-07T07:04:55 | {} | MEMBER |
vuejs | core | 1,797,928,576 | 9,541 | so1ve | Before the fix gets merged, you can use https://github.com/unplugin/unplugin-vue-complex-types as a temporal solution. | 2023-11-07T07:06:41 | 2023-11-07T07:06:41 | {} | MEMBER |
vuejs | core | 1,798,257,456 | 9,523 | folmert | For anyone having a similar issue, adding `optimizeDeps.include` to vite.config.js fixed it for me:
```
optimizeDeps: {
include: ['path/to/your/module'],
},
```
The exact same path needs to be used in the import, otherwise `optimizeDeps.include` won't pick it up. | 2023-11-07T10:45:56 | 2023-11-07T10:45:56 | {} | NONE |
vuejs | core | 1,786,200,468 | 9,511 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | --------------------- | -------------------- | -------------------- |
| runtime-dom.global.prod.js | 89 kB (**+2.52 kB**) | 33.6 kB (**+701 B**) | 30.3 kB (**... | 2023-10-30T23:26:41 | 2023-10-30T23:26:41 | {} | NONE |
vuejs | core | 1,786,503,383 | 9,515 | Alfred-Skyblue | You should use `getCurrentInstance` in the setup to save the current instance to a variable. If asynchronously retrieved, it works similarly to `watchEffect` in not collecting asynchronous dependencies. | 2023-10-31T06:02:11 | 2023-10-31T06:02:11 | {} | MEMBER |
vuejs | core | 1,787,946,627 | 9,478 | b12k | @sodatea I really need this fix =) We can not directly import types/interfaces, and using (redundant file) *.ts import/export workaround. | 2023-10-31T19:58:07 | 2023-10-31T19:58:07 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,788,563,882 | 7,315 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------ | ------------------- |
| runtime-dom.global.prod.js | 86.5 kB (**+16 B**) | 32.9 kB (**+3 B**) | 29.7 kB (**-31 B**) |
| v... | 2023-11-01T08:04:57 | 2023-11-01T08:04:57 | {} | NONE |
vuejs | core | 1,790,666,002 | 9,535 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-02T12:49:12 | 2023-11-02T12:49:12 | {} | NONE |
vuejs | core | 1,793,000,050 | 4,629 | pikax | @KaelWD is this still an issue? If it is can you create an issue please, I might be missing the full scope of this 🤔 | 2023-11-03T19:39:47 | 2023-11-03T19:39:47 | {} | MEMBER |
vuejs | core | 1,785,636,240 | 8,468 | unrevised6419 | Hey there! Another use case.
My example is different, but the error message seems the same (not related to discriminated unions).
There are compiler errors, but Volar seems to work fine.
```
Error: [@vue/compiler-sfc] Unresolvable type reference or unsupported built-in utility type
src/LocalScope.vue
4 | ... | 2023-10-30T16:44:55 | 2023-11-05T11:46:46 | {
"+1": 2
} | CONTRIBUTOR |
vuejs | core | 1,797,991,595 | 8,372 | grindpride | No longer reproduced on `vue-tsc@1.8.22` | 2023-11-07T08:00:27 | 2023-11-07T08:00:27 | {} | NONE |
vuejs | core | 1,793,977,894 | 9,551 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.4 kB | 32.9 kB | 29.6 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-06T02:19:01 | 2023-11-07T11:07:08 | {} | NONE |
vuejs | core | 1,784,622,979 | 5,955 | haoqunjiang | /ecosystem-ci run | 2023-10-30T07:30:02 | 2023-10-30T07:30:02 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,790,395,006 | 9,451 | yyx990803 | /cc @johnsoncodehk
I assume this will need special handling in Volar for Vue 3.4+
- Previously `:id` will result in a parsing error, which now removed in this PR
- Now `:id` implicitly expands to `:id="id"` and should result in type checking errors if necessary. | 2023-11-02T09:46:10 | 2023-11-02T09:46:10 | {} | MEMBER |
vuejs | core | 1,790,454,351 | 5,300 | posva | BTW a workaround is to read again the computed once it has been fetched:
```ts
const App = defineComponent(() => {
const msg = computed(() => store.state.items?.join(' '))
// If msg value is falsy then we are either in ssr context or on the client
// and the initial state was not modified/hydrated.
//... | 2023-11-02T10:21:27 | 2023-11-02T10:21:27 | {} | MEMBER |
vuejs | core | 1,792,516,398 | 9,528 | Sublime1 | Thanks for the thoughtful reply, Thorsten. I do appreciate your engagement on this. It's a tricky one because there are multiple factors involved, aren't there?
On one hand you could argue that no library needs to have a duty of care towards other libraries, and that you should be able to do whatever you want in is... | 2023-11-03T14:15:56 | 2023-11-03T14:15:56 | {
"+1": 3,
"heart": 26
} | NONE |
vuejs | core | 1,792,593,636 | 9,528 | LinusBorg | Thanks for your thoughtful response, as well!
I agree about the kind of arbitrary line of duty of care, in general.
There is something special about the problem with Protoype though: It pollutes the global namespace, overriding existing Javascript functionality in the process. That was, in my recollection, one o... | 2023-11-03T14:56:40 | 2023-11-03T14:58:46 | {
"+1": 4,
"heart": 43
} | MEMBER |
vuejs | core | 1,793,355,924 | 9,495 | edison1105 | @sodatea
due to the dynamic directive argument cannot contain spaces, this means it cannot be a possible TypeScript expression. I think it just need to strip out the string. | 2023-11-04T06:09:00 | 2023-11-04T06:09:00 | {} | MEMBER |
vuejs | core | 1,793,562,763 | 9,521 | LiamVisionary | Was also experiencing the same issue today. I worked around it by changing lru-cache/min to lru-cache in compiler-sfc.d.ts. This fixed building on my side, but the issue still existed when Render (my web-hosting platform of choice) installed all packages and tried to build the project. Fixed it by creating a post-insta... | 2023-11-04T21:47:16 | 2023-11-04T21:47:16 | {} | NONE |
vuejs | core | 1,793,676,032 | 9,550 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-05T09:48:50 | 2023-11-05T09:48:50 | {} | NONE |
vuejs | core | 1,794,871,643 | 9,341 | yashha | For those who have the same problem.
While #9351 is not merged, we could already use it with vue 3.3.7 and https://github.com/ds300/patch-package | 2023-11-06T13:51:41 | 2023-11-06T13:51:55 | {} | NONE |
vuejs | core | 1,785,129,832 | 9,507 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-30T12:52:45 | 2023-10-30T12:52:45 | {} | NONE |
vuejs | core | 1,789,383,749 | 9,529 | haoqunjiang | /ecosystem-ci run | 2023-11-01T17:41:54 | 2023-11-01T17:41:54 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,789,399,570 | 9,529 | vue-bot |
📝 Ran ecosystem CI: [Open](https://github.com//vuejs/ecosystem-ci/actions/runs/6723133754)
| suite | result | [latest scheduled](https://github.com/vuejs/ecosystem-ci/actions/runs/6715876018) |
|-------|--------|----------------|
| language-tools | :x: [failure](https://github.com/vuejs/ecosystem-ci/actions/runs/672... | 2023-11-01T17:53:06 | 2023-11-01T17:53:06 | {} | CONTRIBUTOR |
vuejs | core | 1,790,218,918 | 9,532 | netlify[bot] | ### <span aria-hidden="true">❌</span> Deploy Preview for *vue-next-template-explorer* failed.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | e45c0205e31cc65c08d3098ba6964ba1460ecea4 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/s... | 2023-11-02T07:39:53 | 2023-11-02T07:39:53 | {} | NONE |
vuejs | core | 1,792,029,956 | 9,540 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-03T08:19:23 | 2023-11-03T08:19:23 | {} | NONE |
vuejs | core | 1,792,543,017 | 9,521 | ne0guille | would be ok to revert it back to ?
```import { LRUCache } from 'lru-cache'
export function createCache<T extends {}>(
max = 500
): Map<string, T> & { max?: number } {
if (__GLOBAL__ || __ESM_BROWSER__) {
return new Map<string, T>()
}
return new LRUCache({ max }) as any as Map<string, T>
}``` | 2023-11-03T14:32:16 | 2023-11-03T14:32:16 | {} | NONE |
vuejs | core | 1,792,990,229 | 3,096 | pikax | Closing see https://github.com/vuejs/core/issues/3095#issuecomment-1792989843 | 2023-11-03T19:31:54 | 2023-11-03T19:31:54 | {} | MEMBER |
vuejs | core | 1,798,201,238 | 9,557 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.4 kB | 32.9 kB | 29.6 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-07T10:11:16 | 2023-11-07T10:11:16 | {} | NONE |
vuejs | core | 1,788,658,142 | 9,526 | edison1105 | This is the expected behavior, consistent with vue2 | 2023-11-01T09:27:59 | 2023-11-01T09:27:59 | {} | MEMBER |
vuejs | core | 1,788,708,070 | 9,526 | LinusBorg | I mean, that's what the slot default content is for. | 2023-11-01T10:09:23 | 2023-11-01T10:09:23 | {} | MEMBER |
vuejs | core | 1,790,432,852 | 5,300 | posva | I'm reopening this as it is still not fixed (the same reproduction still fails). It looks like it got fixed because of the line that reads `msg.value` after fetching:
- https://github.com/vuejs/core/commit/2f91872e7b64fb5e497529a9ed21c76c602bad2c#diff-c39f837454871308e7768f723b69481a057d8dfa7b021103f976de8b4f4e827bR... | 2023-11-02T10:10:08 | 2023-11-02T10:17:11 | {} | MEMBER |
vuejs | core | 1,790,668,070 | 9,536 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-02T12:50:36 | 2023-11-02T12:50:36 | {} | NONE |
vuejs | core | 1,790,780,547 | 7,290 | KaelWD | Yep, this PR seems to fix https://github.com/vuetifyjs/vuetify/pull/15215
I am getting hydration mismatch warnings without SSR now but that might just be a vite-ssr thing. | 2023-11-02T13:52:36 | 2023-11-02T13:52:36 | {} | CONTRIBUTOR |
vuejs | core | 1,791,767,876 | 9,538 | Alfred-Skyblue | Regarding the matter related to the [repl](https://github.com/vuejs/repl), let's address it in [#3450](https://github.com/vuejs/repl/pull/168). | 2023-11-03T01:12:33 | 2023-11-03T01:12:33 | {} | MEMBER |
vuejs | core | 1,792,677,676 | 9,542 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-11-03T15:44:40 | 2023-11-03T15:44:40 | {} | NONE |
vuejs | core | 1,793,254,334 | 9,543 | edison1105 | see #9431 | 2023-11-04T00:01:18 | 2023-11-04T00:01:18 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,794,310,489 | 9,546 | KUN1007 | You should add the `type` property to define the `props` object.
```typescript
<script setup lang="ts" generic="T">
import { PropType } from 'vue'
const props = defineProps({
a: {
type: Object as PropType<T>,
},
b: {
type: Object as PropType<T>,
},
c: {
type: Object as PropType<T>,... | 2023-11-06T08:33:37 | 2023-11-06T08:33:37 | {
"-1": 3
} | NONE |
vuejs | core | 1,794,914,360 | 9,555 | haoqunjiang | > ` 8:1 error 'defineProps' is not defined`
This is from ESLint and an old version of `eslint-plugin-vue`.
Now that you are using `@vue/cli-plugin-eslint`, which only supports `eslint-plugin-vue` v8, you need to add the following configuration in your package.json:
```diff
"eslintConfig": {
"root": true,
... | 2023-11-06T14:13:29 | 2023-11-06T14:13:43 | {} | MEMBER |
vuejs | core | 1,786,469,144 | 9,516 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------- | ------- | ------- |
| runtime-dom.global.prod.js | 86.5 kB | 32.9 kB | 29.7 kB |
| vue.global.prod.js | 132 kB | 49.6 kB | 44.5 kB |
### Usages
| Name | Size |... | 2023-10-31T05:23:59 | 2023-10-31T05:23:59 | {} | NONE |
vuejs | core | 1,788,853,730 | 9,521 | haoqunjiang | The rewriting of `lru-cache` to `lru-cache/min` looks like a TypeScript bug to me.
On the other hand, we accidentally exposed the `lru-cache` type to the end user in https://github.com/vuejs/core/commit/f5a253f69f9a2d6a141839675d0e32f145471afd#diff-7ba159198fd8831307a1c39831d6679874e024dd7e9d8ca66ce1760e3e19703dR5 T... | 2023-11-01T12:14:36 | 2023-11-01T12:14:36 | {} | MEMBER |
vuejs | core | 1,790,210,109 | 9,531 | jacky-yanglei | 在3.3.4版本下就不会出现这个问题
| 2023-11-02T07:31:03 | 2023-11-02T07:31:03 | {} | NONE |
vuejs | core | 1,790,795,889 | 9,537 | github-actions[bot] | ## Size Report
### Bundles
| File | Size | Gzip | Brotli |
| -------------------------- | ------------------- | ------------------- | -------------------- |
| runtime-dom.global.prod.js | 86.5 kB (**+89 B**) | 32.9 kB (**+37 B**) | 29.7 kB (**+2 B**) ... | 2023-11-02T14:01:38 | 2023-11-02T14:11:14 | {} | NONE |
vuejs | core | 1,792,681,933 | 3,039 | pikax | Closing this in favour of #9542
Created a new PR since this PR implementation was not playing nicely with the types when I resolved conflicts | 2023-11-03T15:47:17 | 2023-11-03T15:47:17 | {} | MEMBER |
vuejs | core | 1,793,374,807 | 8,468 | so1ve | @justin-schroeder Can you try this plz
https://github.com/unplugin/unplugin-vue-complex-types/commit/df8d0a521df0d79d9cacd6e516b24595b0bd6f75 | 2023-11-04T07:53:18 | 2023-11-04T08:31:10 | {} | MEMBER |
vuejs | core | 1,793,885,737 | 9,521 | dimahmz | I had the same issue in my project and I fixed by regressing vuejs to the 3.3.4 version. | 2023-11-05T23:46:56 | 2023-11-05T23:46:56 | {
"+1": 1
} | NONE |
vuejs | core | 1,794,342,343 | 9,541 | jacekkarczmarczyk | Code below seems to work
```ts
type Emits = BaseEmits & {
(e: 'unChange', id: number): void
}
```
| 2023-11-06T08:53:48 | 2023-11-06T08:53:48 | {
"+1": 1
} | CONTRIBUTOR |
vuejs | core | 1,786,452,154 | 9,515 | so1ve | This is intended. You should cache the instance before awaits. | 2023-10-31T05:04:22 | 2023-10-31T05:04:22 | {
"+1": 1
} | MEMBER |
vuejs | core | 1,787,124,568 | 9,511 | jods4 | @johnsoncodehk Thanks, I based the PR on `minor`. Only my commit shows up now, it's reviewable ;) | 2023-10-31T12:28:58 | 2023-10-31T12:28:58 | {} | CONTRIBUTOR |
vuejs | core | 1,790,551,126 | 9,528 | Sublime1 | Thanks sodatea for the helpful workaround - that seems to have solved my immediate problem.
Your decision not to respect such edge cases is understandable, but I must admit to a little touch of disappointment, even if I completely understand your point of view. There are many legacy apps out there, especially in old... | 2023-11-02T11:28:32 | 2023-11-02T11:28:32 | {
"+1": 3
} | NONE |
vuejs | core | 1,792,394,445 | 2,669 | cernymatej | @yyx990803 Sorry for the ping but would it be okay to use the internal API for this use case?
`getCurrentInstance()?.vnode.scopeId` | 2023-11-03T12:56:56 | 2023-11-03T12:56:56 | {} | CONTRIBUTOR |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.