prompt listlengths 2 2 | source stringclasses 3
values | severity stringclasses 5
values | category stringclasses 186
values | has_code bool 2
classes | has_poc bool 2
classes | reference_response stringlengths 23 5k | firm stringclasses 26
values | quality_score float64 0 5 | protocol stringclasses 398
values |
|---|---|---|---|---|---|---|---|---|---|
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | access-control | true | false | ## Low: Proposal deadline extension is allowed even in `Pending` state
### Description
`HubProposalExtender::extendProposal` function allows the extension of proposal deadlines even when the proposal is in a `Pending` state. This allows the `VoteExtenderAdmin` to extend the deadline of a proposal before the voting per... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | storage | true | false | ## Gas: `struct Order`: can be more tighly packed
### Description
Each slot saved can avoid an extra Gsset (20000 gas) for the first setting of the struct. Subsequent reads as well as writes have smaller gas savings.
Before:
https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/con... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: Missing `supportsInterface` Selector from `DiamondLoupeFacet`
### Description
The `SimplexDiamond` contract is intended to support multiple interfaces, including `IERC165`, `IDiamondCut`, `IDiamondLoupe`, and `IERC173`. While `SimplexDiamond` correctly adds these interfaces to `ds.supportedInterfaces`, it *... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | false | false | ## Medium: Input is insufficiently validated in multiple methods
### Description
**Severity**
**Impact:**
High, as it can result of loss of accrued yield for validators or DoS of the protocol
**Likelihood:**
Low, as it requires configuration error by `Governance` or `TLSDFactory` or them being malicious or compromis... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | true | true | ## Medium: lockQuote() increaseNonce parameters do not work properly
### Description
in `lockQuote()` will execute `partyBNonces[quote.partyB][quote.partyA] += 1` if increaseNonce == true
But this operation is executed before setting `quote.partyB`, resulting in actually setting `partyBNonces[address(0)][quote.partyA]... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | oracle | true | false | ## High: The bptpricestablepool() function of bptoracle.sol contract calculates the value of stable bpt incorrectly
### Description
This implementation of valuing Stable BPT is incorrect and can lead to incorrect valuation of the Stable BPT because rates are not considered. The `BptPriceStablePool()` function of the `... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Inefficient Initializer Usage
### Description
The issue was identified within the [constructor](https://github.com/dforce-network/OFT/blob/2ff5d7a8f9a509006557bf5de72fabf40d1138a5/src/sUSX.sol#L58) of the `sUSX` contract.
The constructor uses the `initialize` function, which is not the optimal approach for pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | rounding | true | false | ## High: Apr can be rounded down for small _annualizedInterest in case of low decimals debtToken
### Description
The first thing to notice is that the `ft`, `xt`, and `debtToken` decimals match. This is clear from the `_deployTokens` function in `TermMaxMarket`. Second, for the following report, let's assume that `deb... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: OpenLevV1.closeTrade with V3 DEX doesn’t correctly accounts fee on transfer tokens for repayments
### Description
## Handle
hyh
## Vulnerability details
## Impact
The amount that OpenLevV1 will receive can be less than V3 DEX indicated as a swap result, while it is used as given for position debt repay... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | true | false | ## Low: Small borrows can create economically unviable liquidatable positions leading to bad debt accumulation
### Description
The borrow function in the Lender contract lacks a minimum borrow amount check, allowing agents to create positions as small as 1 wei. When these small positions become liquidatable, the gas c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | rounding | false | false | ## Medium: Division before Multiplication May Result In No Interest Being Accrued
### Description
_Submitted by AuditsAreUS, also found by minhquanym_
[NFTVault.sol#L590-L595](https://github.com/code-423n4/2022-04-jpegd/blob/e72861a9ccb707ced9015166fbded5c97c6991b6/contracts/vaults/NFTVault.sol#L590-L595)
There is a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Incorrect proxy address tracking misconfigures USDXL pool tokens
### Description
The `DeployUsdxlUtils._getUsdxlATokenProxy()` and `DeployUsdxlUtils._getUsdxlVariableDebtTokenProxy()` functions incorrectly return implementation contract addresses instead of proxy addresses.
```solidity
//File: src/deployment... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [4] Comment does not match the behavior of the code
### Description
Both of the functions below have `require(isOrchestrator(msg.sender))`, and orchestrators are the first signer, so not just anyone can call these | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Limit possibilities of recoverERC20()
### Description
The function `recoverERC20()` in the contract `MultiMerkleDistributor.sol` allows the retrieval of all ERC20 tokens from the contract. However, the comment suggests that it is only intended to retrieve tokens sent by mistake. This implementation allows n... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: USE DECLARED FUNCTION INSTEAD OF MSG.SENDER
### Description
The `BasePaymaster` contract uses a modifier to control functions are called by EntryPoint address. The other `onlyOwner` modifier uses `_msgSender()` function to return `msg.sender` address. However, the `_requireFromEntryPoint` modifier uses `msg.se... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Add Style CSP
### Description
## Content Security Policy (CSP) Update
Currently, the CSP is specified as:
However, it might make sense to further strengthen this CSP to avoid any potential risk from style injection exfiltration by adding a `style-src`.
## Remediation
For example, consider updating the CSP... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | true | false | ## Medium: depositFor function should be restricted to approved NFT types
### Description
The `depositFor` function was found to accept NFTs of all types (normal, locked, managed) without restriction.
```solidity
function depositFor(uint256 _tokenId, uint256 _value) external nonReentrant {
LockedBalance memory oldL... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Lack of initial liquidity in Pool leads to inflation / first-deposit attacks
### Description
In the context of `UniswapV2` liquidity pools (LPs), a **lack of initial liquidity can make the pool vulnerable to inflation attacks, also known as first-deposit attacks**. Although [UniswapV2 partially mitigates this ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `createMeme` Can be Called From The `MemeFactory` Directly Bypassing All Checks
### Description
**Severity** - Low
**Status** - Resolved
**Description**
A new meme is supposed to be deployed via the `createMeme()` function in the `WaveFrontFactory.sol` which checks the name , symbol and minAmountIn before d... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Avoid public initial-setter function
### Description
The `LockManagerBase` contract has a public `setPluginAddress()` function through which the plugin address is set once during its initialization. This function has no authentication and is at danger of being frontrun by a malicious actor when it is not calle... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | oracle | false | false | ## Low: Hardcoded testnet addresses in constructor.
### Description
**Description**
StWSX.sol, storage and constructor()
Currently, the contract utilizes testnet addresses for 3rd party contracts, dao and Oracle, which are hardcoded directly in the constructor. This approach may not be flexible and convenient when mi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | liquidation | true | false | ## High: Trader can't reduce open position size when under initial margin requirement but over maintenance margin requirement
### Description
**Description:** [`OrderBranch::createMarketOrder`](https://github.com/zaros-labs/zaros-core-audit/blob/de09d030c780942b70f1bebcb2d245214144acd2/src/perpetuals/branches/OrderBra... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: The db backup endpoint may be triggered via SSRF or when visiting an attacker website, which may cause a DoS
### Description
A Prysm node (beacon-chain or validator) run with the `--enable-db-backup-webhook` flag exposes a `GET /db/backup` monitoring API endpoint that saves a backup of the node database ont... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Missing zero-address validation and boundaries check in `DIARewardsDistribution` constructor
### Description
The constructor in `DIARewardsDistribution` does not validate that `rewardsTokenAddress` or `newRewardsWallet` parameters are non-zero addresses. Setting either parameter to address(0) during deployment... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Possible ddos attack
### Description
Malicious maker can block bots for filling order if he calls unbounded operation (infinite loop) in `notifyFillOrder`:
https://github.com/1inch/limit-order-protocol/tree/a14bde6a260458de5083cee117d734221e1cbc05/contracts/LimitOrderProtocol.sol#L338
### Recommendation
We... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | cross-chain | true | false | ## High: Owner Can Update Arbitrary Status for New Native Token Without Confirmation ✓ Fixed
### Description
The function `setCustomContract` allows the owner to update arbitrary status for new native tokens without confirmation, bypassing the bridge protocol.
* It can set `DEPLOYED_STATUS` for a new native token, e... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Solmate's ERC20 does not check for token contract's existence, which opens up possibility for a honeypot attack
### Description
When bidding, the contract pulls the quote token from the bidder to itself.
However, since the contract uses Solmate's [SafeTransferLib](https://github.com/transmissions11/solmat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: The protection check for `maxBetShare` can be gamed
### Description
**Impact:**
Medium, because a protocol invariant can be broken and the code gives a false sense of security
**Likelihood:**
Medium, as it can easily be gamed but there is no incentive for an attacker
**Description**
The `lockLiquidity` m... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | overflow | true | false | ## Gas: Using unchecked blocks to save gas
### Description
Solidity version 0.8+ comes with implicit overflow and underflow checks on unsigned integers. When an overflow or an underflow isn’t possible (as an example, when a comparison is made before the arithmetic operation), some gas can be saved by using an unchecke... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Minor mathematical mistake in comment
### Description
In `nTokenSupply.sol`, there is a comment explaining why 18 decimal places for the accumulation precision is a good choice. There is a minor mistake in the calculation. It does not invalidate the reasoning, but as it is confusing for a reader, we recommend ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | signature | false | false | ## Medium: Nonce reset increases the risk of a successful replay attack
### Description
Replay attacks pose a significant security threat to blockchain technologies. To maintain the integrity of signatures in a blockchain network, it is essential to use a nonce, a value that tracks the number of transactions made by a... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: `CrvDepositorWrapper.sol` relies on oracle that isn't frequently updated
### Description
_Submitted by 0x52_
[CrvDepositorWrapper.sol#L56-L65](https://github.com/code-423n4/2022-05-aura/blob/4989a2077546a5394e3650bf3c224669a0f7e690/contracts/CrvDepositorWrapper.sol#L56-L65)
Unpredictable slippage, sandwic... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: [06] Pragma float
### Description
All contracts in scope are floating the pragma version.
Locking the pragma helps to ensure that contracts do not accidentally get deployed using an outdated compiler version.
Note that pragma statements can be allowed to float when a contract is intended for consumption by o... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | front-running | false | false | ## Low: Frontrunning can cause DOS on transferAllocationAndSetSetter
### Description
The contract allows any user with allocation to become the admin of any random address. If `newRecipient` is supposed to be a contract, an attacker can frontrun the `transferAllocationAndSetSetter` call and set themselves as the newRe... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | true | false | ## Low: Lack of zero-value checks in constructor function
### Description
The Agreement constructor function fails to validate incoming arguments, so callers of this function could mistakenly set important state variables to a zero value, misconfiguring the system. The Agreement constructor is shown in Figure 12.1.
`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Update initialize... Function Names to initiate...
### Description
Within the [`StakeManager` contract](https://github.com/0xFFoundation/fchain-contracts/blob/11ffd45bc95747b8d2432a2e8bb120d4a1dc19a2/src/StakeManager.sol), there are 5 functions that follow the naming convention of `initialize...`, such as:
* ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Protocol insolvency risk
### Description
Currently, only `tokenAmounts[i] = incentiveAmount + frontendFeeAmount` is pulled from the IP order creator when an IP order is created. This means that if the **protocolFeeRecipient** claims their fees before the order is filled, `fillIPOrder` will fail because the Or... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | token | true | false | ## High: no-revert-on-transfer ERC20 tokens can be drained
### Description
_Submitted by Ruhum, also found by oyc_109 and smiling_heretic_
### Impact
Some ERC20 tokens don't throw but just return false when a transfer fails. This can be abused to trick the `createVault()` function to initialize the vault without pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: USDB and WETH addresses are misconfigured in blast.sol
### Description
The addresses of USDB and WETH are constants in the Blast.sol contract file; however, these variables are declared wrongly. As per the documentation, the addresses of USDB and WETH are `0x4300000000000000000000000000000000000003` and `0x4... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | liquidation | false | false | ## Gas: Do not add the data which is alreday included in the tx to save users gas cost.
### Description
In the `Borrowed` event we added the `startTimestamp` and gave it the value `block.timestamp`. This increases the gas of users and because this data is already present in the transaction then we can save users gas c... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: `gracePeriod` not increased after membership extension
### Description
In the function `purchaseMembership` of FSDNetwork.sol, when the membership is extended, `membership[msg.sender].creation` is increased. However, `membership[msg.sender].gracePeriod` is not increased.
This might lead to a `gracePeriod` t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Identical constants defined independently
### Description
The constant `PLACEHOLDER_UINT` is defined in [`ShareMath`](https://github.com/ribbon-finance/ribbon-v2/blob/3fa3bec15ad1e2b18ad87f979b87a68368497f13/contracts/libraries/ShareMath.sol#L11) and again in [`RibbonVault`](https://github.com/ribbon-finance/r... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [6] `private` functions not called by the contract should be removed to save deployment gas
### Description
*There is 1 instance of this issue:* | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | true | false | ## Medium: Inappropriate handling of referralFee makes collecting Mirror fails without error when referrerProfileId is burned
### Description
## Lines of code
https://github.com/code-423n4/2022-02-aave-lens/blob/c1d2de2b0609b7d2734ada2ce45c91a73cc54dd9/contracts/core/modules/collect/FeeCollectModule.sol#L163-L172
#... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | true | ## Medium: Disputer’s escalation pledge may become locked
### Description
When settling a bond escalation, the BondEscalation contract does not call the AccountingExtension contract’s `onSettleBondEscalation` function unless at least one user has pledged against the dispute. If no users pledge against the dispute, any... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | oracle | false | false | ## Medium: Oracle does not treat upward and downward price movement the same in validity checks, causing safety issues in oracle usage
### Description
NFTFloorOracle retrieves ERC721 prices for ParaSpace. maxPriceDeviation is a configurable parameter, which limits the change percentage from current price to a new feed... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | true | ## Low: Reward restaking creates unnecessary unbonding in edge cases
### Description
The `PolygonStrategy::restakeRewards()` function is publicly callable by anyone, allowing rewards to be restaked immediately before the `PolygonStrategy::unbond()` function is called.
In specific scenarios, this can cause the protoco... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | storage | true | false | ## Low: [10] NatSpec `@return` comment is incorrect in `_getPremiaDeltas()` function
### Description
https://github.com/code-423n4/2023-11-panoptic/blob/aa86461c9d6e60ef75ed5a1fe36a748b952c8666/contracts/SemiFungiblePositionManager.sol#L1253C1-L1254C147
The explanation is: "*... for `token0` (right) and `token1` (ri... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | cross-chain | false | false | ## Medium: Fee Cap May Be Too Low
### Description
A [fee cap](https://github.com/across-protocol/contracts/blob/d9826e30b51bbb3067df07c9532f4a5f6fe56f1c/deploy/011_deploy_polygon_spokepool.ts#L24) of `1e18` is set upon the deployment of the `Polygon_SpokePool` contract. Since the fee is calculated for execution on the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | false | false | ## Gas: Unnecessary Order Type Check In verifyRoute
### Description
The `verifyRoute` function short circuits if the order type is a redemption, as redemptions do not utilize routes. However, `verifyRoute` is only called in `mint`, which confirms the order type is a mint, so this short circuit check is never triggered... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Consider disallowing transfers to `address(this)`
### Description
Consider preventing a contract's tokens from being transferred to the contract itself.
*There are 3 instances of this issue.*
--- | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | false | false | ## Low: Rebalances are subject to sandwich attacks
### Description
Rebalancing transactions are very meaningful events within the strategy lifecycle. Potentially large amounts of `WETH` and `USDC` might be involved, and given the necessary use of Uniswap V3 pools in any scenario (apart from OTC auctions) there are two... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: `convertToAssets` and `convertToShares` does not consider bond and debond fee
### Description
`convertToAssets` and `convertToShares` are used to calculate the shares/assets required for bonding/debonding. However, they do not account for the bond and debond fees, which could cause integrators relying on these... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Lack of anonymity allows collusion-based attacks
### Description
Currently, the NuCypher system does not anonymize its users. Therefore, re-encryption nodes can acquire information about both the senders and recipients of the data they are re-encrypting. This allows for attacks where Ursulas collude with Bob ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | storage | true | false | ## High: Important Balancer fields can be overwritten by EndTime
### Description
## Severity: Critical Risk
**Context:**
ManagedPool.sol#L75-L77, ManagedPool.sol#L84-L86, LegacyBasePool.sol, WordCodec.sol
**Description:**
Balancer’s ManagedPool uses 32-bit values for `startTime` and `endTime`, but it does not ve... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Analysis - Some thoughts, consideration and advice for next steps
### Description
Logically you can chunk the code into 3 components
- Feeds
- Swap and Stake Operations
- Core
-----
It may be best to write fuzz and invariant tests on these separately and then you can consider adding a new
**Generic Gas Ad... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: SafeMath usage can be omitted.
### Description
**Description**
Contracts set utilizes Solidity 0.8.x, which has built in support of overflow and underflow warnings, thus SafeMath library can be omitted for gas savings and code simplification.
**Recommendation**
Remove SafeMath library.
**Re-audit comment**... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | initialization | true | false | ## Medium: Attacker can block refunds to the fulfiller's account
### Description
The current `fulfillQuery` pays refund gas to the query source. If the refund fails, the entire flow will revert. This means malicious users can always reject the completion of queries:
```solidity
QueryLogic.sol::L243
if (refundAmount... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: Parsing large JSON integers could result in interoperability issues
### Description
The parsing of strings as JSON integers differs from mainstream implementations such as NodeJS and jq. The JSON standard warns about certain "interoperability problems" in numeric types outside the range [-(2**53)+1, (2**53)-1]... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | other | false | false | ## High: Unimplemented allocate_constant Causes Panic in fq2.rs
### Description
The function [`allocate_constant`](https://github.com/matter-labs/zksync-crypto/blob/ccf5fa30ee2c94b594126d7b4b75770cafbbab21/crates/boojum/src/gadgets/traits/allocatable.rs#L14) in the `CSAllocatable` trait is unimplemented.
This results... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | dos | false | false | ## Low: Transactions can be excluded due to block gas limit while calling collectAllTokens()
### Description
**Severity**: Informational
**Status**: Resolved
**Description**
In the contract DynamicRange, the loop in line 396 iterates over all the tokens owned by the user and collects the rewards. This for loop has ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | cross-chain | false | false | ## Low: Lack of Input Validation
### Description
There are some instances of input parameters within the [`SpokePool`](https://github.com/UMAprotocol/across-contracts-v2-private/blob/8595081d0edf6aa265fc5e0d04437e9aa07efbcd/contracts/SpokePool.sol) contract that are not sufficiently validated:
* `fillDeadline` can b... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | front-running | true | false | Source: https://github.com/sherlock-audit/2023-12-flatmoney-judging/issues/190
The protocol has acknowledged this issue.
## Found by
santipu\_, xiaoming90
## Summary
Malicious users can perform an inflation attack against the vault to steal the assets of the victim.
## Vulnerability Detail
A malicious user can p... | Sherlock | 5 | FlatMoney |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Liquidation shouldn't be used to close positions that were fully-collateralized prior to collateral requirement changes
### Description
There are various factors associated with minimum collateral requirements, and if a position falls below them, the position is liquidated.
### Impact
Liquidation gives all... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Vote weight can be manipulated
### Description
## Handle
cmichel
## Vulnerability details
The vote weight is determined by the `DAOVault` and `BondVault` weight (`voteWeight = _DAOVAULT.getMemberWeight(msg.sender) + _BONDVAULT.getMemberWeight(msg.sender)`).
The weight in these vaults is the deposited LP to... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | initialization | false | false | ## Low: Farm Duration Can Be Extended Indefinitely Past `MAX_EXTENSION`
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `f0d4606cb9dc93f3ed8c9c4fb50c370211e52df4`. The client provided the following explanation:
> The code now checks if the new farm end time exceeds the maximum extension limi... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: rmation disclosure through console logging
### Description
The application logs information including transaction details, error messages, and potentially user data to the browser console through various console.log, console.warn, and console.error statements throughout the codebase.
**Recommendation**
Impl... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | false | false | ## Low: Missing docstrings
### Description
The [function `getRoleAuthorizationSigner`](https://github.com/celo-org/celo-monorepo/blob/f64b4c5b5228ecbf41e3e7cfdbb8c0e9a983eea2/packages/protocol/contracts/common/Accounts.sol#L937) is missing natspec comments. This hinders reviewers’ understanding of the code’s intention... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | token | false | false | ## Low: Incorrect Use of ERC-20 Approvals
### Description
**Update**
Marked as "Fixed" by the client. Addressed in: `b166e5b`. The client provided the following explanation: _Removed `safeIncreaseAllowance()` in the suggested functions._
**File(s) affected:**`BatchTrade.sol`
**Description:** When transferring ERC20 ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: `JPEGLock.unlock()`: use `storage` instead of copying struct in memory L69
### Description
See `@audit` tag:
Here, a copy in memory is costing 3 SLOADs and 3 MSTORES. The, 2 variables are only read once through MLOAD (`position.owner` and `position.unlockAt`) and one is read twice (`position.lockAmount`).
I ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Unused code present in the codebase
### Description
There are a few instances of unused code (dead code) in the code base, that is suggested to be removed .
### Recommendation
Some of the unused code were removed in [DecenterApps/[email protected]`61b0c09`](https://github.com/DecenterApps/defisaver-v3-contrac... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | liquidation | false | false | ## Gas: `Ownable` and `ERC20Burneable` implementations arent necesary in `DecentralizedStableCoin`
### Description
An optimization issue has been identified in the `DecentralizedStableCoin` smart contract. It involves replacing the OpenZeppelin's `Ownable` contract with a simple `owner` state variable and removing `ER... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: INACCURATE VALIDITY CHECKS
### Description
The `updateCacheAndGetTradeResult` function in the **OptionMarketPricer** contract contains the following inaccurate validity checks:
* `newSkew` includes **min / max** values in its validity check. As a consequence, the function will revert incorrectly when dealing ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | cyfrin_structured | low | other | true | false | ## Low: Comment incorrectly refers to `€` when it should be `$`
### Description
The following comment is [present](https://github.com/the-standard/smart-vault/blob/c6837d4a296fe8a6e4bb5e0280a66d6eb8a40361/contracts/SmartVaultV4.sol#L91) when summing the stablecoin collateral in `SmartVaultV4::yieldVaultCollateral`:
`... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | access-control | true | true | ## Severity: Medium Risk
## Context
- **LoansNFT.sol**: Lines 264-265, Lines 425-426
## Description
In `LoansNFT.closeLoan()`, `_isSenderOrKeeperFor()` is called to check if the borrower has approved the keeper to close the loan on their behalf:
```solidity
address borrower = ownerOf(loanId);
require(_isSenderOrKeepe... | Spearbit | 5 | Collar Protocol |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | liquidation | false | false | ## Low: Individually Changeable `RiskEngine` per `pToken` Leading to Inconsistency
### Description
This issue has been identified in the architecture allowing `riskEngine` to be changed individually for each `pToken`. There is no robust mechanism to ensure a coordinated migration for all `pToken`s simultaneously.
Pot... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: [G‑07] State variables should be cached in stack variables rather than re-reading them from storage
### Description
The instances below point to the second+ access of a state variable within a function. Caching of a state variable replace each Gwarmaccess (**100 gas**) with a much cheaper stack read. Other le... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: [23] PUSH0 Opcode is not supported on all to-deploy chains
### Description
### Proof of Concept
Per the readMe protocol is to also deploy on multiple optimistic chains see:
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/README.md#L254
Now contracts are being comp... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | false | false | ## Medium: OWNER ACCOUNTID CAN BE SET TO AN INVALID VALUE
### Description
The `set_owner()` method implemented in the AppchainAnchor Struct, which can be found in “appchain-anchor/src/lib.rs”, does not validate that the AccountId value passed to it actually contains a valid AccountId following the NEAR’s account ID ru... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | solodit_api | medium | other | true | false | ## Severity: Medium Risk
## Context
`UniswapV2Library.sol#L121-L132`
## Description
The `getAmountIn` function uses fees to determine the necessary `amountIn` to receive a given `amountOut` (refer to `UniswapV2Library.sol#L121-L132`):
```solidity
function getAmountIn(uint256 amountOut, uint256 reserveIn, uint256 res... | Spearbit | 5 | Velodrome Finance |
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | storage | true | false | ## Medium: [M-06]
### Description
Whenever a knot is deregistered, the last value of `accumulatedETHPerFreeFloatingShare` is stored in the mapping `lastAccumulatedETHPerFreeFloatingShare`. The accumulated value must be updated always before deregistering the knot, otherwise stakers of the knot could receive less ETH t... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | high | initialization | true | false | ## High: Unprotected Storage Allows Compromise During Deployment
### Description
The `onlyLatestRocketNetworkContract()` modifier allows direct modification of the RocketStorage contents during deployment. Any account can perform arbitrary storage modifications during the course of deployment, causing significant impa... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: There is no recovery option for ERC721
### Description
The `transferToVault()` function doesn't support ERC721 tokens:
https://github.com/lidofinance/lido-dao/blob/801d3e854efb33ff33a59fe51187e187047a6be2/contracts/0.4.24/Lido.sol#L356
### Recommendation
It is necessary to add another function to recover ... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: RocketMinipoolDelegate - Redundant refund() call on forced finalization ✓ Fixed
### Description
The `RocketMinipoolDelegate.refund` function will force finalization if a user previously distributed the pool. However, `_finalise` already calls `_refund()` if there is a node refund balance to transfer, making... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | logic | true | false | ## Medium: Incorrect calculation in `glpToUsd` function in `GlpPricing.sol`
### Description
**Description**
GlpPricing.sol - glpToUsd same issue as above - recommending replacing the div by mul.
**Recommendation**
Replace division with multiplication in the `glpToUsd` function.
**Re-audit comment**
Resolved | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | true | false | ## Low: There's no guarantee that the `locked` amounts of `MIM` and `USDB` tokens will exceed specific thresholds when creating a `MagicLP` through `bootstrap`
### Description
When creating a `MagicLP` using the `locked` `MIM` and `USDB` tokens, there's no verification performed to ensure that the amounts exceed a cer... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | liquidation | true | false | ## Medium: Divergence in the pricing method for collateral within the `calculateMinimumAmountOut()` may result in vaults transitioning into an uncollateralized state after executing swaps.
### Description
In the `SmartVaultV3.calculateMinimumAmountOut()` function, the variable `collateralValueMinusSwapValue` is comput... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | other | true | false | ## Medium: The return value(bool) of aurapool.withdrawandunwrap() isn't checked
### Description
The function `auraPool.withdrawAndUnwrap()` returns a boolean, but the return value is never checked.
```solidity
function withdrawAndUnwrap(uint256 _amount, bool _claim) external returns (bool);
```
The returned boolean... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | false | false | ## Low: Incorrect interface check for market maker contract
### Description
This issue has been identified within the [_changeMarketMakerAddress](https://github.com/longgammalabs/hanji-contracts/blob/70b15ec4d9e7578248141604503843716a67d875/src/HanjiLOB.sol#L1088) function of the `HanjiLOB` contract.
The function cha... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: [05] Add `Uni.handler.sol`, the wrapper around `Uni`, allowing to call its functions from fuzz/invariant tests
### Description
Similar to the already present [test/helpers/UniStaker.handler.sol](https://github.com/code-423n4/2024-02-uniswap-foundation/blob/5a2761c8277541a24bc551fbd624413b384bea94/test/helpers/... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | rounding | false | false | ## Low: Magic constants in token amounts
### Description
A few constants in the contract which denote BAT amounts ([`batFund`](https://github.com/brave-intl/basic-attention-token-crowdsale/blob/17a5f8440a256a6dc5d8dd894b9615182c2901b2/contracts/BAToken.sol#L21), [`tokenCreationCap`](https://github.com/brave-intl/basic... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | dos | false | false | ## Medium: Lack of validations on critical Token Sale parameters can allow malicious DAO Pool creators to DOS claims by token sale participants
### Description
**Description:** When creating a tier, a DAO Pool creator can define custom token sale parameters. These parameters are verified in the `TokenSaleProposalCreat... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Unnecessary use of SafeMath.
### Description
**Description**
Using safeMath in Solidity version 0.8.11 is not necessary and only increases gas spendings
since Solidity of this version has a built-in check for under/overflow.
**Recommendation**:
Replace functions from SafeMath with arithmetic operators. | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | access-control | true | false | ## Low: Missing Upper Bound Validation
### Description
The `setswapSlippage` function does not validate that the provided `slippage` value is less than or equal to `BASIS_POINTS`. If `slippage` is set to a value greater than `BASIS_POINTS`, it will result in underflows during calculations in the `swapEthToUsdc` and `s... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | token | false | false | ## Medium: The quorumVotes can be bypassed
### Description
This vulnerability allows for the minting and auctioning of an art piece that has not met the required quorum. It enables malicious voters to influence outcomes with fewer votes than what is stipulated by the protocol. This undermines a key invariant of the pr... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | medium | reentrancy | false | false | ## Medium: MuteBond is susceptible to DOS
### Description
Observe that if timeToTokens is called with `_lock_time = 1 week`, `_amount
function timeToTokens(uint256 _amount, uint256 _lock_time) internal pure returns (uint256){
uint256 week_time = 1 weeks;
uint256 max_lock = 52 weeks;
require(_lock_time >= w... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | overflow | false | false | ## Low: Precision Limitation in Format Coin
### Description
## Potential Inaccuracies in formatCoin
There are potential inaccuracies in the rendering and conversion of numeric values in `formatCoin`. This function relies on a `LegacyDec` type, which has a limitation of 18 digits of precision. If the difference in the... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | gas | other | true | false | ## Gas: Multiple accesses of a mapping/array should use a local variable cache
### Description
Caching a mapping's value in a local `storage` or `calldata` variable when the value is accessed multiple times saves **\~42 gas per access** due to not having to perform the same offset calculation every time.
Affected cod... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | reentrancy | true | false | ## Low: Functions can be called repeatedly, causing misleading events
### Description
Several event-emitting Folio functions can be called repeatedly, without intervening calls to related event-emitting functions. Off-chain code expecting to process multiple kinds of events could behave incorrectly when seeing just on... | 0 | ||
[
{
"role": "system",
"content": "You are an expert smart contract security auditor. Analyze the provided Solidity code for vulnerabilities.\n\nFor each finding, output a structured block:\nFINDING | contract: <name> | function: <name> | bug_class: <CWE/category> | confidence: <0-100>\n\nThen provide:\n- desc... | skyward_49k | low | other | true | false | ## Low: Adding a `return` statement when the function defines a named return variable, is redundant
### Description
While not consuming more gas with the Optimizer enabled: using both named returns and a return statement isn't necessary. Removing one of those can improve code clarity.
Affected code:
* contracts/con... | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.