repo stringclasses 1
value | pull_number int64 14 6.65k | instance_id stringlengths 19 21 | issue_numbers listlengths 1 2 | base_commit stringlengths 40 40 | patch stringlengths 505 226k | test_patch stringlengths 265 112k | problem_statement stringlengths 99 16.2k | hints_text stringlengths 0 33.2k | created_at stringlengths 20 20 | version stringlengths 3 4 | environment_setup_commit stringlengths 40 40 |
|---|---|---|---|---|---|---|---|---|---|---|---|
apache/arrow-rs | 6,649 | apache__arrow-rs-6649 | [
"6648"
] | 7bcc1ad988498def843180c6a4c95f9732f31a4b | diff --git a/parquet/src/record/reader.rs b/parquet/src/record/reader.rs
index 1f9128a8b4f..fd6ca7cdd57 100644
--- a/parquet/src/record/reader.rs
+++ b/parquet/src/record/reader.rs
@@ -138,7 +138,17 @@ impl TreeBuilder {
.column_descr_ptr();
let col_reader = row_group_reader.get_column_rea... | diff --git a/parquet-testing b/parquet-testing
index 50af3d8ce20..550368ca77b 160000
--- a/parquet-testing
+++ b/parquet-testing
@@ -1,1 +1,1 @@
-Subproject commit 50af3d8ce206990d81014b1862e5ce7380dc3e08
+Subproject commit 550368ca77b97231efead39251a96bd6f8f08c6e
| Primitive REPEATED fields not contained in LIST annotated groups aren't read as lists by record reader
**Describe the bug**
Primitive REPEATED fields not contained in LIST annotated groups should be read as lists according to the format but aren't.
**To Reproduce**
<!--
Steps to reproduce the behavior:
-->
**... | 2024-10-29T23:41:15Z | 53.2 | 7bcc1ad988498def843180c6a4c95f9732f31a4b | |
apache/arrow-rs | 6,453 | apache__arrow-rs-6453 | [
"6282"
] | f41c258246cd4bd9d89228cded9ed54dbd00faff | diff --git a/arrow-flight/examples/flight_sql_server.rs b/arrow-flight/examples/flight_sql_server.rs
index 81afecf85625..dd3a3943dd95 100644
--- a/arrow-flight/examples/flight_sql_server.rs
+++ b/arrow-flight/examples/flight_sql_server.rs
@@ -19,6 +19,7 @@ use arrow_flight::sql::server::PeekableFlightDataStream;
use a... | diff --git a/arrow-integration-test/src/lib.rs b/arrow-integration-test/src/lib.rs
index d1486fd5a153..ea5b545f2e81 100644
--- a/arrow-integration-test/src/lib.rs
+++ b/arrow-integration-test/src/lib.rs
@@ -21,6 +21,7 @@
//!
//! This is not a canonical format, but provides a human-readable way of verifying language i... | What is the highest compression level in gzip?
**Which part is this question about**
What is the highest compression level in gzip?
**Describe your question**
I see from other sources, including `flate2`, the highest compression level for gzip is 9 instead of 10. If we pass 10, it should be accepted by parquet b... | It seems flate2 documentation is wrong.
```rust
/// Returns an integer representing the compression level, typically on a
/// scale of 0-9
pub fn level(&self) -> u32 {
self.0
}
```
But internally, inside `DeflateBackend::make` they have `debug_assert!(level.level() <= 10);`. Using compression level up t... | 2024-09-25T04:27:02Z | 53.0 | f41c258246cd4bd9d89228cded9ed54dbd00faff |
apache/arrow-rs | 6,368 | apache__arrow-rs-6368 | [
"6366"
] | 0491294828a6480959ba3983355b415abbaf1174 | diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
index 1937fafe3a62..41edc1bb194e 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -48,7 +48,6 @@ on:
- arrow/**
jobs:
-
integration:
name: Archery test With other arrows
run... | diff --git a/arrow/tests/pyarrow.rs b/arrow/tests/pyarrow.rs
index a1c365c31798..d9ebd0daa1cd 100644
--- a/arrow/tests/pyarrow.rs
+++ b/arrow/tests/pyarrow.rs
@@ -18,6 +18,8 @@
use arrow::array::{ArrayRef, Int32Array, StringArray};
use arrow::pyarrow::{FromPyArrow, ToPyArrow};
use arrow::record_batch::RecordBatch;
+... | Exporting Binary/Utf8View from arrow-rs to pyarrow fails
**Describe the bug**
Exporting binaryview arrow to pyarrow fails with
`Expected at least 3 buffers for imported type binary_view, ArrowArray struct has 2`
**To Reproduce**
Construct binaryview array and export it over c data interface to pyarrow
**Ex... | 2024-09-06T21:16:12Z | 53.0 | f41c258246cd4bd9d89228cded9ed54dbd00faff | |
apache/arrow-rs | 6,332 | apache__arrow-rs-6332 | [
"6331"
] | d4be752ef54ee30198d0aa1abd3838188482e992 | diff --git a/arrow-flight/src/bin/flight_sql_client.rs b/arrow-flight/src/bin/flight_sql_client.rs
index 296efc1c308e..c334b95a9a96 100644
--- a/arrow-flight/src/bin/flight_sql_client.rs
+++ b/arrow-flight/src/bin/flight_sql_client.rs
@@ -20,7 +20,10 @@ use std::{sync::Arc, time::Duration};
use anyhow::{bail, Context,... | diff --git a/arrow-flight/tests/flight_sql_client_cli.rs b/arrow-flight/tests/flight_sql_client_cli.rs
index 168015d07e2d..6e1f6142c8b6 100644
--- a/arrow-flight/tests/flight_sql_client_cli.rs
+++ b/arrow-flight/tests/flight_sql_client_cli.rs
@@ -23,10 +23,12 @@ use crate::common::fixture::TestFixture;
use arrow_array... | Add Catalog DB Schema subcommands to `flight_sql_client`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
When using the `flight_sql_client` it can be helpful to interrogate the Flight SQL server for information about available catalogs, db schemas and tables.... | 2024-08-29T19:02:56Z | 53.0 | f41c258246cd4bd9d89228cded9ed54dbd00faff | |
apache/arrow-rs | 6,328 | apache__arrow-rs-6328 | [
"6179"
] | 678517018ddfd21b202a94df13b06dfa1ab8a378 | diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index a1644ee49b8d..1b65c5057de1 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -100,6 +100,13 @@ jobs:
run: rustup component add rustfmt
- name: Format arrow
run: cargo fmt --all -- --check
+ ... | diff --git a/parquet/src/util/test_common/file_util.rs b/parquet/src/util/test_common/file_util.rs
index c2dcd677360d..6c031358e795 100644
--- a/parquet/src/util/test_common/file_util.rs
+++ b/parquet/src/util/test_common/file_util.rs
@@ -19,8 +19,7 @@ use std::{fs, path::PathBuf, str::FromStr};
/// Returns path to ... | Is cargo fmt no longer working properly in parquet crate
**Which part is this question about**
Code formatter.
**Describe your question**
I've noticed recently that running `cargo fmt` while I'm editing files doesn't always seem to catch problems. Running rustfmt directly will work. For instance, running `cargo fm... | Fascinatingly, I am seeing the same thing
For example I deliberately introduced a formatting issue:
```
andrewlamb@Andrews-MacBook-Pro-2:~/Software/arrow-rs$ git diff
diff --git a/parquet/src/compression.rs b/parquet/src/compression.rs
index 10560210e4e..119af7e156f 100644
--- a/parquet/src/compression.rs
++... | 2024-08-29T16:36:10Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 |
apache/arrow-rs | 6,320 | apache__arrow-rs-6320 | [
"6318"
] | a937869f892dc12c4730189e216bf3bd48c2561d | diff --git a/arrow/src/pyarrow.rs b/arrow/src/pyarrow.rs
index 43cdb4fe0919..336398cbf22f 100644
--- a/arrow/src/pyarrow.rs
+++ b/arrow/src/pyarrow.rs
@@ -59,7 +59,7 @@ use std::convert::{From, TryFrom};
use std::ptr::{addr_of, addr_of_mut};
use std::sync::Arc;
-use arrow_array::{RecordBatchIterator, RecordBatchRea... | diff --git a/arrow-pyarrow-integration-testing/tests/test_sql.py b/arrow-pyarrow-integration-testing/tests/test_sql.py
index 5320d0a5343e..3b46d5729a1f 100644
--- a/arrow-pyarrow-integration-testing/tests/test_sql.py
+++ b/arrow-pyarrow-integration-testing/tests/test_sql.py
@@ -476,6 +476,29 @@ def test_tensor_array():... | Allow converting empty `pyarrow.RecordBatch` to `arrow::RecordBatch`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
`datafusion-python` currently errors when calling `select count(*) from t` when `t` is a `pyarrow.Dataset`.
The resulting `pyarrow.RecordBatc... | 2024-08-28T17:30:36Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 | |
apache/arrow-rs | 6,295 | apache__arrow-rs-6295 | [
"3577"
] | 8c956a9f9ab26c14072740cce64c2b99cb039b13 | diff --git a/parquet/src/encodings/rle.rs b/parquet/src/encodings/rle.rs
index 581f14b3c99a..97a122941f17 100644
--- a/parquet/src/encodings/rle.rs
+++ b/parquet/src/encodings/rle.rs
@@ -20,7 +20,6 @@ use std::{cmp, mem::size_of};
use bytes::Bytes;
use crate::errors::{ParquetError, Result};
-use crate::util::bit_ut... | diff --git a/parquet/tests/arrow_reader/bad_data.rs b/parquet/tests/arrow_reader/bad_data.rs
index 6e325f119710..cbd5d4d3b29e 100644
--- a/parquet/tests/arrow_reader/bad_data.rs
+++ b/parquet/tests/arrow_reader/bad_data.rs
@@ -134,3 +134,28 @@ fn read_file(name: &str) -> Result<usize, ParquetError> {
}
Ok(num... | Don't Panic on Invalid Parquet Statistics
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* ... | 2024-08-23T19:10:39Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 | |
apache/arrow-rs | 6,290 | apache__arrow-rs-6290 | [
"6289"
] | ebcc4a585136cd1d9696c38c41f71c9ced181f57 | diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
index b97b2a571646..1d38e67a0f02 100644
--- a/parquet/Cargo.toml
+++ b/parquet/Cargo.toml
@@ -68,6 +68,7 @@ twox-hash = { version = "1.6", default-features = false }
paste = { version = "1.0" }
half = { version = "2.1", default-features = false, features = ["num-tr... | diff --git a/parquet/tests/arrow_reader/checksum.rs b/parquet/tests/arrow_reader/checksum.rs
new file mode 100644
index 000000000000..c60908d8b95d
--- /dev/null
+++ b/parquet/tests/arrow_reader/checksum.rs
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag... | Optionally verify 32-bit CRC checksum when decoding parquet pages
Currently the PageHeader::crc is never used
| 2024-08-22T23:28:20Z | 53.0 | f41c258246cd4bd9d89228cded9ed54dbd00faff | |
apache/arrow-rs | 6,269 | apache__arrow-rs-6269 | [
"6268"
] | acdd27a66ac7b5e07816dc648db00532110fb89a | diff --git a/parquet_derive/src/lib.rs b/parquet_derive/src/lib.rs
index 16b6a6699e2d..9c93e2cca978 100644
--- a/parquet_derive/src/lib.rs
+++ b/parquet_derive/src/lib.rs
@@ -146,10 +146,10 @@ pub fn parquet_record_writer(input: proc_macro::TokenStream) -> proc_macro::Toke
/// Derive flat, simple RecordReader implemen... | diff --git a/parquet_derive_test/src/lib.rs b/parquet_derive_test/src/lib.rs
index e7c7896cb7f3..2cd69d03d731 100644
--- a/parquet_derive_test/src/lib.rs
+++ b/parquet_derive_test/src/lib.rs
@@ -73,9 +73,9 @@ struct APartiallyCompleteRecord {
struct APartiallyOptionalRecord {
pub bool: bool,
pub string: Stri... | parquet_derive: support reading selected columns from parquet file
# Feature Description
I'm effectively using `parquet_derive` in my project, and I found that there are two inconvenient constraints:
1. The `ParquetRecordReader` enforces the struct to organize fields exactly in the **same order** in the parquet f... | 2024-08-18T14:39:49Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 | |
apache/arrow-rs | 6,204 | apache__arrow-rs-6204 | [
"6203"
] | db239e5b3aa05985b0149187c8b93b88e2285b48 | diff --git a/parquet/benches/arrow_reader.rs b/parquet/benches/arrow_reader.rs
index 814e75c249bf..18e16f0a4297 100644
--- a/parquet/benches/arrow_reader.rs
+++ b/parquet/benches/arrow_reader.rs
@@ -20,6 +20,7 @@ use arrow::datatypes::DataType;
use arrow_schema::Field;
use criterion::measurement::WallTime;
use crite... | diff --git a/parquet/src/util/test_common/page_util.rs b/parquet/src/util/test_common/page_util.rs
index 3db43aef0eec..a1709efa92b3 100644
--- a/parquet/src/util/test_common/page_util.rs
+++ b/parquet/src/util/test_common/page_util.rs
@@ -51,13 +51,14 @@ pub struct DataPageBuilderImpl {
rep_levels_byte_len: u32,
... | Add benchmarks for `BYTE_STREAM_SPLIT` encoded Parquet `FIXED_LEN_BYTE_ARRAY` data
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
#6159 added support for using `BYTE_STREAM_SPLIT` with `FIXED_LEN_BYTE_ARRAY` primitive types. While some effort was put into opti... | 2024-08-06T22:53:02Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 | |
apache/arrow-rs | 6,190 | apache__arrow-rs-6190 | [
"6185"
] | e6bd74b2c381e67a2b08e15fc23672f8317436c4 | diff --git a/parquet/src/arrow/arrow_reader/statistics.rs b/parquet/src/arrow/arrow_reader/statistics.rs
index c42f92838c8c..369ea4a47e57 100644
--- a/parquet/src/arrow/arrow_reader/statistics.rs
+++ b/parquet/src/arrow/arrow_reader/statistics.rs
@@ -17,6 +17,8 @@
//! [`StatisticsConverter`] to convert statistics in... | diff --git a/parquet-testing b/parquet-testing
index 1ba34478f535..9b48ff4f94dc 160000
--- a/parquet-testing
+++ b/parquet-testing
@@ -1,1 +1,1 @@
-Subproject commit 1ba34478f535c89382263c42c675a9af4f57f2dd
+Subproject commit 9b48ff4f94dc5e89592d46a119884dbb88100884
diff --git a/parquet/tests/arrow_reader/statistics.rs... | Remove test duplication in parquet statistics tets
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
When adding additional support to the statistics converter as @Kev1n8 did in https://github.com/apache/arrow-rs/pull/6181 the presence of two sets of tests is q... | take | 2024-08-03T18:36:40Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 |
apache/arrow-rs | 6,181 | apache__arrow-rs-6181 | [
"6164"
] | ede5a64628e0a0df3d900cc0df17649f6bed9af0 | diff --git a/parquet/src/arrow/arrow_reader/statistics.rs b/parquet/src/arrow/arrow_reader/statistics.rs
index 6a1434bce906..c42f92838c8c 100644
--- a/parquet/src/arrow/arrow_reader/statistics.rs
+++ b/parquet/src/arrow/arrow_reader/statistics.rs
@@ -26,7 +26,8 @@ use crate::file::page_index::index::{Index, PageIndex};... | diff --git a/parquet/tests/arrow_reader/mod.rs b/parquet/tests/arrow_reader/mod.rs
index 4f63a505488c..7e979dcf3ec0 100644
--- a/parquet/tests/arrow_reader/mod.rs
+++ b/parquet/tests/arrow_reader/mod.rs
@@ -17,13 +17,13 @@
use arrow_array::types::{Int32Type, Int8Type};
use arrow_array::{
- Array, ArrayRef, Binar... | Add support for `StringView` and `BinaryView` statistics in `StatisticsConverter`
Part of https://github.com/apache/arrow-rs/issues/6163
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
@efredine recently added support for extracting statistics from parque... | I think this would be a good first issue as it has a detailed description and existing patterns to follow
take
Can i work on this issue? | 2024-08-02T09:39:07Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 |
apache/arrow-rs | 6,159 | apache__arrow-rs-6159 | [
"6048"
] | bf1a9ec7faa1e271681317572098c4d83297c3a9 | diff --git a/parquet/benches/encoding.rs b/parquet/benches/encoding.rs
index bdbca3567a2b..80befe8dadff 100644
--- a/parquet/benches/encoding.rs
+++ b/parquet/benches/encoding.rs
@@ -30,30 +30,30 @@ fn bench_typed<T: DataType>(c: &mut Criterion, values: &[T::T], encoding: Encodi
std::any::type_name::<T::T>(),
... | diff --git a/parquet/src/arrow/array_reader/test_util.rs b/parquet/src/arrow/array_reader/test_util.rs
index 05032920139b..a7ff8d6e41ba 100644
--- a/parquet/src/arrow/array_reader/test_util.rs
+++ b/parquet/src/arrow/array_reader/test_util.rs
@@ -46,7 +46,8 @@ pub fn utf8_column() -> ColumnDescPtr {
/// Encode `data... | Extend support for BYTE_STREAM_SPLIT to FIXED_LEN_BYTE_ARRAY, INT32, and INT64 primitive types
Please correct me if I'm wrong! It seems arrow-rs has added BYTE_STREAM_SPLIT support for [float types](https://github.com/apache/arrow-rs/pull/5293), but not for other numerical data types like INT32.
Since then, the Par... | @anjakefala are you working on this? If not I have some free cycles to devote to this.
@etseidl I am not! I would love it if you picked it up. =) | 2024-07-30T17:56:20Z | 52.2 | 678517018ddfd21b202a94df13b06dfa1ab8a378 |
apache/arrow-rs | 6,075 | apache__arrow-rs-6075 | [
"6018"
] | effccc13a9ef6e650049a160734d5ededb2a5383 | diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
index 9d3c431b3048..b8f40e1b4b99 100644
--- a/arrow/Cargo.toml
+++ b/arrow/Cargo.toml
@@ -54,7 +54,7 @@ arrow-select = { workspace = true }
arrow-string = { workspace = true }
rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional... | diff --git a/arrow-pyarrow-integration-testing/Cargo.toml b/arrow-pyarrow-integration-testing/Cargo.toml
index 6f07d42d88c1..0834f2d13384 100644
--- a/arrow-pyarrow-integration-testing/Cargo.toml
+++ b/arrow-pyarrow-integration-testing/Cargo.toml
@@ -34,4 +34,4 @@ crate-type = ["cdylib"]
[dependencies]
arrow = { pa... | Update pyo3 requirement from 0.21.1 to 0.22.1
Updates the requirements on [pyo3](https://github.com/pyo3/pyo3) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pyo3/pyo3/releases">pyo3's releases</a>.</em></p>
<blockquote>
<h2>PyO3 0.22.1</h2>
<p>T... | 2024-07-17T12:48:19Z | 52.1 | effccc13a9ef6e650049a160734d5ededb2a5383 | |
apache/arrow-rs | 6,046 | apache__arrow-rs-6046 | [
"4328"
] | 6d4e2f2ceaf423031b0bc72f54c547dd77a0ddbb | diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
index 2fb808e1ec8d..2cc12a81dea5 100644
--- a/parquet/Cargo.toml
+++ b/parquet/Cargo.toml
@@ -134,6 +134,11 @@ path = "./examples/read_with_rowgroup.rs"
name = "arrow_writer_layout"
required-features = ["arrow"]
+[[test]]
+name = "arrow_reader"
+required-features... | diff --git a/parquet/tests/arrow_reader/mod.rs b/parquet/tests/arrow_reader/mod.rs
new file mode 100644
index 000000000000..4f63a505488c
--- /dev/null
+++ b/parquet/tests/arrow_reader/mod.rs
@@ -0,0 +1,1003 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se... | Add function that converts from parquet statistics `ParquetStatistics` to arrow arrays `ArrayRef`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section ... | This would also help us in IOx (see https://github.com/influxdata/influxdb_iox/issues/7470, per @crepererum )
It would also be aweome to get a similar treatment for Data pages (the so called "page index" values)
Maybe we could add something to the `parquet` with the `arrow` featre: https://docs.rs/parquet/41.0.0/par... | 2024-07-11T22:06:19Z | 52.1 | effccc13a9ef6e650049a160734d5ededb2a5383 |
apache/arrow-rs | 6,041 | apache__arrow-rs-6041 | [
"6038"
] | 66390ff8ec15bb6ed585f353f67a19574da4375a | diff --git a/arrow-flight/Cargo.toml b/arrow-flight/Cargo.toml
index 60ba3ae827de..eaa1dd7e394d 100644
--- a/arrow-flight/Cargo.toml
+++ b/arrow-flight/Cargo.toml
@@ -44,11 +44,11 @@ bytes = { version = "1", default-features = false }
futures = { version = "0.3", default-features = false, features = ["alloc"] }
once_... | diff --git a/arrow-flight/tests/common/trailers_layer.rs b/arrow-flight/tests/common/trailers_layer.rs
index b2ab74f7d925..0ccb7df86c74 100644
--- a/arrow-flight/tests/common/trailers_layer.rs
+++ b/arrow-flight/tests/common/trailers_layer.rs
@@ -21,7 +21,7 @@ use std::task::{Context, Poll};
use futures::ready;
use... | Update prost requirement from 0.12.3 to 0.13.1
Updates the requirements on [prost](https://github.com/tokio-rs/prost) to permit the latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md">prost's changelog</a>.</em></p>
<blockquote>... | This should be treated as a breaking change. | 2024-07-11T06:23:13Z | 52.1 | effccc13a9ef6e650049a160734d5ededb2a5383 |
apache/arrow-rs | 6,039 | apache__arrow-rs-6039 | [
"6033"
] | e70c16d67d866ab7e4a75ef584c6fdc7b91e687c | diff --git a/arrow-array/src/array/dictionary_array.rs b/arrow-array/src/array/dictionary_array.rs
index 045917a1bfb8..d6c5dd4c3e13 100644
--- a/arrow-array/src/array/dictionary_array.rs
+++ b/arrow-array/src/array/dictionary_array.rs
@@ -1025,13 +1025,13 @@ mod tests {
let value_data = ArrayData::builder(Data... | diff --git a/arrow-integration-test/src/lib.rs b/arrow-integration-test/src/lib.rs
index 66fa9f3320e0..d1486fd5a153 100644
--- a/arrow-integration-test/src/lib.rs
+++ b/arrow-integration-test/src/lib.rs
@@ -696,7 +696,7 @@ pub fn array_from_json(
let list_data = ArrayData::builder(field.data_type().clone()... | Remove `From` impls that copy data into `arrow_buffer::Buffer`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
@XiangpengHao found this on https://github.com/apache/arrow-rs/pull/6031 and I am breaking it into its own ticket
```rust
let block_id = output... | 1000% this, the current hacks of using `Buffer::from_vec`, etc... are counter-intuitive and surprising.
I had hoped that we would get specialization and be able to fix it this way, but sadly it looks like that is stuck in limbo. As such a breaking change to remove the blanket impl makes sense to me.
Take
> Take
�... | 2024-07-10T15:15:30Z | 52.1 | effccc13a9ef6e650049a160734d5ededb2a5383 |
apache/arrow-rs | 5,971 | apache__arrow-rs-5971 | [
"5487"
] | 0a4d8a14b58e45ef92e31541f0b51a5b25de5f10 | diff --git a/arrow-flight/src/encode.rs b/arrow-flight/src/encode.rs
index f59c29e68173..e7722fd7f0a8 100644
--- a/arrow-flight/src/encode.rs
+++ b/arrow-flight/src/encode.rs
@@ -304,7 +304,11 @@ impl FlightDataEncoder {
// The first message is the schema message, and all
// batches have the same sche... | diff --git a/arrow-integration-testing/src/flight_client_scenarios/integration_test.rs b/arrow-integration-testing/src/flight_client_scenarios/integration_test.rs
index c6b5a72ca6e2..ec88ce36a4d2 100644
--- a/arrow-integration-testing/src/flight_client_scenarios/integration_test.rs
+++ b/arrow-integration-testing/src/f... | Improve documentation around handling of dictionary arrays in arrow flight
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers ... | Related slack thread: https://the-asf.slack.com/archives/C01QUFS30TD/p1709986070881859?thread_ts=1709815827.985999&cid=C01QUFS30TD
`label_issue.py` automatically added labels {'arrow'} from #5488
`label_issue.py` automatically added labels {'arrow-flight'} from #5488 | 2024-06-27T19:16:52Z | 52.0 | 0a4d8a14b58e45ef92e31541f0b51a5b25de5f10 |
apache/arrow-rs | 5,862 | apache__arrow-rs-5862 | [
"4897"
] | a20116ec36f8c0c959aa9e6c547dc7e5625ebb1b | diff --git a/arrow-data/src/transform/mod.rs b/arrow-data/src/transform/mod.rs
index b0d9475afcd6..1e43bf488cbe 100644
--- a/arrow-data/src/transform/mod.rs
+++ b/arrow-data/src/transform/mod.rs
@@ -385,7 +385,10 @@ impl<'a> MutableArrayData<'a> {
array_capacity = *capacity;
new_buffer... | diff --git a/arrow/tests/array_transform.rs b/arrow/tests/array_transform.rs
index 42e4da7c4b4e..08f23c200d52 100644
--- a/arrow/tests/array_transform.rs
+++ b/arrow/tests/array_transform.rs
@@ -17,9 +17,9 @@
use arrow::array::{
Array, ArrayRef, BooleanArray, Decimal128Array, DictionaryArray, FixedSizeBinaryArr... | concat should preallocate for FixedSizeList
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Right now, concat only pre-allocates for string, binary, dictionary and primitive arrays (IIUC):
https://github.com/apache/arrow-rs/blob/208da03979b2903c3182c20ef38... | 2024-06-10T15:57:58Z | 52.0 | 0a4d8a14b58e45ef92e31541f0b51a5b25de5f10 | |
apache/arrow-rs | 5,773 | apache__arrow-rs-5773 | [
"5254"
] | 30767a687b48d0dbd2e030eef327826c39095123 | diff --git a/parquet_derive/src/parquet_field.rs b/parquet_derive/src/parquet_field.rs
index 3ab85a8972f5..9fff76c42d1d 100644
--- a/parquet_derive/src/parquet_field.rs
+++ b/parquet_derive/src/parquet_field.rs
@@ -136,7 +136,7 @@ impl Field {
Type::Option(_) => unimplemented!("Unsupported nesting enco... | diff --git a/parquet_derive_test/Cargo.toml b/parquet_derive_test/Cargo.toml
index a5d2e76d4503..a3a4b58fea95 100644
--- a/parquet_derive_test/Cargo.toml
+++ b/parquet_derive_test/Cargo.toml
@@ -32,3 +32,4 @@ rust-version = { workspace = true }
parquet = { workspace = true }
parquet_derive = { path = "../parquet_deri... | parquet_derive: UUID should not be a ByteArray
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
`ParquetRecordWriter` is marking UUID as a `ByteArray` which causes a panic.
```
General("Cannot annotate Uuid from BYTE_ARRAY for field 'session_id'")
```
**To Reproduce**
<!-... | 2024-05-16T08:39:17Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 | |
apache/arrow-rs | 5,769 | apache__arrow-rs-5769 | [
"5654"
] | 30767a687b48d0dbd2e030eef327826c39095123 | diff --git a/arrow-arith/src/numeric.rs b/arrow-arith/src/numeric.rs
index b2c87bba5143..17b794762b9f 100644
--- a/arrow-arith/src/numeric.rs
+++ b/arrow-arith/src/numeric.rs
@@ -25,7 +25,7 @@ use arrow_array::cast::AsArray;
use arrow_array::timezone::Tz;
use arrow_array::types::*;
use arrow_array::*;
-use arrow_buf... | diff --git a/arrow-integration-test/src/lib.rs b/arrow-integration-test/src/lib.rs
index 30f0ccfbe12d..66fa9f3320e0 100644
--- a/arrow-integration-test/src/lib.rs
+++ b/arrow-integration-test/src/lib.rs
@@ -21,7 +21,7 @@
//!
//! This is not a canonical format, but provides a human-readable way of verifying language i... | Rust Interval definition incorrect
It seems the Rust `INTERVAL` definition is incorrect. Please see https://github.com/duckdb/duckdb-wasm/issues/1696#issuecomment-2047021075 for more details on the bug and where it occurs in the code.
Particularly this definition: https://github.com/apache/arrow-rs/blob/36a6e515f998... | @pitrou do you know if the integration tests cover the interval types?
@avantgardnerio as the author of https://github.com/apache/arrow-rs/pull/2235 which appears to have switched these round, perhaps you could weigh in here
> @avantgardnerio as the author of #2235 which appears to have switched these round, perhaps... | 2024-05-15T18:17:11Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 |
apache/arrow-rs | 5,717 | apache__arrow-rs-5717 | [
"5716"
] | a126d5097b71273428fba68d1c430f3d4beee684 | diff --git a/parquet_derive/src/parquet_field.rs b/parquet_derive/src/parquet_field.rs
index 9fff76c42d1d..f99ea3e0356c 100644
--- a/parquet_derive/src/parquet_field.rs
+++ b/parquet_derive/src/parquet_field.rs
@@ -239,7 +239,8 @@ impl Field {
/// because this parsing logic is not sophisticated enough for definiti... | diff --git a/parquet_derive_test/src/lib.rs b/parquet_derive_test/src/lib.rs
index 3743c6b55c7c..e168ad5b980a 100644
--- a/parquet_derive_test/src/lib.rs
+++ b/parquet_derive_test/src/lib.rs
@@ -66,6 +66,25 @@ struct APartiallyCompleteRecord {
pub byte_vec: Vec<u8>,
}
+// This struct has OPTIONAL columns
+// If... | [parquet_derive] support OPTIONAL (def_level = 1) columns by default
## Problem Description
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
I'm ... | What happens if you specify the field as `Option` to match the schema?
> What happens if you specify the field as `Option` to match the schema?
I have tried, it does not work, because:
1. the OPTIONAL, REQUIRED, REPEATED tags are generated automatically in the macro.
2. even I workaround 1 by enforce the field to ... | 2024-05-04T11:18:22Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 |
apache/arrow-rs | 5,698 | apache__arrow-rs-5698 | [
"3462"
] | a61f1dc8ea132add731e4426e11d341a1de5ca92 | diff --git a/arrow-flight/src/client.rs b/arrow-flight/src/client.rs
index b2abfb0c17b2..a7e15fe24cc5 100644
--- a/arrow-flight/src/client.rs
+++ b/arrow-flight/src/client.rs
@@ -417,9 +417,7 @@ impl FlightClient {
///
/// // encode the batch as a stream of `FlightData`
/// let flight_data_stream = Fligh... | diff --git a/arrow-flight/tests/client.rs b/arrow-flight/tests/client.rs
index 47565334cb63..478938d939a9 100644
--- a/arrow-flight/tests/client.rs
+++ b/arrow-flight/tests/client.rs
@@ -493,7 +493,7 @@ async fn test_do_exchange() {
.set_do_exchange_response(output_flight_data.clone().into_iter().map(Ok).c... | Flight Client should accept fallible streams (`do_put` and `do_exchange`)
Perhaps this should accept a `Stream<Item=Result<FlightData>>`, otherwise I'm not sure how one could use this to stream a fallible computation without panicking?
_Originally posted by @tustvold in https://github.com/apache/arrow-rs/pul... | Update is that we implemented this for `do_put` here: https://github.com/apache/arrow-rs/pull/3464
What is needed to close this ticket is to apply the same pattern to `do_exchange`
Since the pattern and testing framework are all in place, I think this would be a good first project.
So this is repeating the pat... | 2024-04-27T16:19:58Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 |
apache/arrow-rs | 5,679 | apache__arrow-rs-5679 | [
"5678"
] | 7568178e37812424d9189c625f3958b165ec13cf | diff --git a/arrow-csv/src/reader/mod.rs b/arrow-csv/src/reader/mod.rs
index 4d7d60e10cf6..09087ca31958 100644
--- a/arrow-csv/src/reader/mod.rs
+++ b/arrow-csv/src/reader/mod.rs
@@ -231,6 +231,7 @@ pub struct Format {
quote: Option<u8>,
terminator: Option<u8>,
null_regex: NullRegex,
+ truncated_rows:... | diff --git a/arrow-csv/test/data/truncated_rows.csv b/arrow-csv/test/data/truncated_rows.csv
new file mode 100644
index 000000000000..0b2af5740095
--- /dev/null
+++ b/arrow-csv/test/data/truncated_rows.csv
@@ -0,0 +1,8 @@
+Name,Age,Occupation,DOB
+A1,34,Engineer,1985-07-16
+B2,29,Doctor
+,
+C3,45,Artist,1964-11-30
+
+D... | Optionally support flexible column lengths
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Add the ability to parse csv files that have flexible number of columns. Specifically a large subset of CSVs have columns missing from the ends of rows, and expect them t... | 2024-04-22T15:43:20Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 | |
apache/arrow-rs | 5,652 | apache__arrow-rs-5652 | [
"5435"
] | f2765283b67e64a6923352ed23398ca9ca194ef2 | diff --git a/object_store/src/aws/client.rs b/object_store/src/aws/client.rs
index e81ef6aa220c..4a4dc178d5b0 100644
--- a/object_store/src/aws/client.rs
+++ b/object_store/src/aws/client.rs
@@ -19,8 +19,8 @@ use crate::aws::builder::S3EncryptionHeaders;
use crate::aws::checksum::Checksum;
use crate::aws::credential:... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index 59c593400450..c5550ac21728 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -46,7 +46,11 @@ impl ObjectStore for MyStore {
self.0.put_opts(location, payload, opts).await... | Add ObjectStore::put_multipart_opts
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for th... | Going to proceed with https://github.com/apache/arrow-rs/issues/5458 instead | 2024-04-16T13:30:21Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 |
apache/arrow-rs | 5,630 | apache__arrow-rs-5630 | [
"5606"
] | 36a6e515f99866eae5332dfc887c6cb5f8135064 | diff --git a/parquet/src/arrow/arrow_reader/mod.rs b/parquet/src/arrow/arrow_reader/mod.rs
index 3b4c09314374..c942461f37e7 100644
--- a/parquet/src/arrow/arrow_reader/mod.rs
+++ b/parquet/src/arrow/arrow_reader/mod.rs
@@ -1436,6 +1436,46 @@ mod tests {
assert_eq!(row_count, 300);
}
+ #[test]
+ fn... | diff --git a/parquet-testing b/parquet-testing
index 4cb3cff24c96..1ba34478f535 160000
--- a/parquet-testing
+++ b/parquet-testing
@@ -1,1 +1,1 @@
-Subproject commit 4cb3cff24c965fb329cdae763eabce47395a68a0
+Subproject commit 1ba34478f535c89382263c42c675a9af4f57f2dd
| Cannot read Parquet files that do not specify Map keys as required
**Describe the bug**
The [Parquet Format](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#maps) specifies that:
> The `key` field encodes the map's key type. This field must have repetition `required` and must always be present.... | It was hard to say whether this should be regarded as a bug or feature request. It's a bug from the perspective that we'd expect broad compatibility.
The conclusion of https://github.com/apache/arrow/issues/37389 appears to be that we are correct to refuse to read such malformed files, am I missing something here?
It w... | 2024-04-11T16:43:08Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 |
apache/arrow-rs | 5,623 | apache__arrow-rs-5623 | [
"5613"
] | 68d1eef689f2b71304003ae7f1f813f3ebb20b5a | diff --git a/arrow-array/src/array/union_array.rs b/arrow-array/src/array/union_array.rs
index 22d4cf90a092..ea4853cd1528 100644
--- a/arrow-array/src/array/union_array.rs
+++ b/arrow-array/src/array/union_array.rs
@@ -17,13 +17,12 @@
use crate::{make_array, Array, ArrayRef};
use arrow_buffer::buffer::NullBuffer;
-... | diff --git a/arrow-integration-test/src/lib.rs b/arrow-integration-test/src/lib.rs
index d6e0dda51a81..30f0ccfbe12d 100644
--- a/arrow-integration-test/src/lib.rs
+++ b/arrow-integration-test/src/lib.rs
@@ -21,6 +21,7 @@
//!
//! This is not a canonical format, but provides a human-readable way of verifying language i... | Cleanup UnionArray Constructors
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this f... | 2024-04-10T14:45:05Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 | |
apache/arrow-rs | 5,538 | apache__arrow-rs-5538 | [
"5514"
] | 2c4b321d3b8dcbb05c0590528abdf1859bc70cef | diff --git a/object_store/src/aws/checksum.rs b/object_store/src/aws/checksum.rs
index a50bd2d18b9c..d15bbf08df69 100644
--- a/object_store/src/aws/checksum.rs
+++ b/object_store/src/aws/checksum.rs
@@ -16,7 +16,6 @@
// under the License.
use crate::config::Parse;
-use ring::digest::{self, digest as ring_digest};
... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index 309a86d8fe9d..59c593400450 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -37,8 +37,13 @@ impl std::fmt::Display for MyStore {
#[async_trait]
impl ObjectStore for MyStore {... | [ObjectStore] Non-Contiguous Write Payloads
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why... | 2024-03-21T01:24:21Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 | |
apache/arrow-rs | 5,531 | apache__arrow-rs-5531 | [
"1207"
] | f41c2a4e5a33e482e12351051d77d0e059f28e33 | diff --git a/arrow-buffer/src/buffer/immutable.rs b/arrow-buffer/src/buffer/immutable.rs
index 552e3f1615c7..f26cde05b7ab 100644
--- a/arrow-buffer/src/buffer/immutable.rs
+++ b/arrow-buffer/src/buffer/immutable.rs
@@ -171,23 +171,33 @@ impl Buffer {
/// Returns a new [Buffer] that is a slice of this buffer star... | diff --git a/arrow-integration-testing/tests/ipc_reader.rs b/arrow-integration-testing/tests/ipc_reader.rs
index 88cdad64f92f..a683075990c7 100644
--- a/arrow-integration-testing/tests/ipc_reader.rs
+++ b/arrow-integration-testing/tests/ipc_reader.rs
@@ -19,10 +19,12 @@
//! in `testing/arrow-ipc-stream/integration/...... | Async IPC Reader/Writer
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The current IPCReader and IPCWriter require a sync Reader/Writer complicating their use in async systems such as DataFusion. Once such use case can be found in https://github.com/apache/a... | @tustvold I was going to create a similar issue but found this. Is something related to flatbuffer serialization blocking IPC streamwriter and filewriter from being async.
Looking at the code it feels like operations can be made async by switching out std::io with tokio::io. If it is actually that trivial to make t... | 2024-03-19T06:19:19Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 |
apache/arrow-rs | 5,500 | apache__arrow-rs-5500 | [
"5526"
] | f41c2a4e5a33e482e12351051d77d0e059f28e33 | diff --git a/object_store/src/aws/mod.rs b/object_store/src/aws/mod.rs
index b11f4513b6df..b33771de9a86 100644
--- a/object_store/src/aws/mod.rs
+++ b/object_store/src/aws/mod.rs
@@ -17,17 +17,14 @@
//! An object store implementation for S3
//!
-//! ## Multi-part uploads
+//! ## Multipart uploads
//!
-//! Multi-pa... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index f73d78578f08..309a86d8fe9d 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -25,7 +25,6 @@ use object_store::path::Path;
use object_store::*;
use std::fmt::Formatter;
use temp... | Inconsistent Multipart Nomenclature
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for th... | 2024-03-13T08:46:10Z | 51.0 | 30767a687b48d0dbd2e030eef327826c39095123 | |
apache/arrow-rs | 5,493 | apache__arrow-rs-5493 | [
"5492"
] | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | diff --git a/arrow-data/src/data.rs b/arrow-data/src/data.rs
index 2ddc2d845b01..914e90d96c22 100644
--- a/arrow-data/src/data.rs
+++ b/arrow-data/src/data.rs
@@ -119,12 +119,20 @@ pub(crate) fn new_buffers(data_type: &DataType, capacity: usize) -> [MutableBuff
buffer.push(0i32);
[buffer, empt... | diff --git a/arrow-integration-test/src/datatype.rs b/arrow-integration-test/src/datatype.rs
index a04db1cf3538..e45e94c24e07 100644
--- a/arrow-integration-test/src/datatype.rs
+++ b/arrow-integration-test/src/datatype.rs
@@ -281,6 +281,9 @@ pub fn data_type_to_json(data_type: &DataType) -> serde_json::Value {
... | Add DataType::ListView and DataType::LargeListView
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context a... | 2024-03-10T13:45:35Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | |
apache/arrow-rs | 5,481 | apache__arrow-rs-5481 | [
"5469"
] | ad3b4c92508a17ea679c9695a89f85c2cdcc4fcf | diff --git a/arrow-array/src/array/byte_array.rs b/arrow-array/src/array/byte_array.rs
index db825bbea97d..a57abc5b1e71 100644
--- a/arrow-array/src/array/byte_array.rs
+++ b/arrow-array/src/array/byte_array.rs
@@ -94,7 +94,7 @@ pub struct GenericByteArray<T: ByteArrayType> {
impl<T: ByteArrayType> Clone for GenericBy... | diff --git a/arrow/tests/array_equal.rs b/arrow/tests/array_equal.rs
index 9bd276428880..15011c547284 100644
--- a/arrow/tests/array_equal.rs
+++ b/arrow/tests/array_equal.rs
@@ -22,8 +22,8 @@ use arrow::array::{
StringArray, StringDictionaryBuilder, StructArray, UnionBuilder,
};
use arrow::datatypes::{Int16Type... | Add `StringViewArray` implementation and layout and basic construction + tests
This is part of the larger project to implement `StringViewArray` -- see https://github.com/apache/arrow-rs/issues/5374
After https://github.com/apache/arrow-rs/issues/5468 we will next need to implement `StringViewArray`
For inspirat... | Please assign me, thx :)
I plan to merge https://github.com/apache/arrow-rs/pull/5470 later today -- I don't expect substantial changes, so if you would like to start on this issue, you could probably make a branch from https://github.com/apache/arrow-rs/pull/5470 and rebase once we merge that
Noce that https://github.... | 2024-03-07T10:10:53Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d |
apache/arrow-rs | 5,477 | apache__arrow-rs-5477 | [
"5476"
] | c6ba0f764a9142b74c9070db269de04d2701d112 | diff --git a/arrow-arith/src/aggregate.rs b/arrow-arith/src/aggregate.rs
index 20ff0711d735..190685ff9df7 100644
--- a/arrow-arith/src/aggregate.rs
+++ b/arrow-arith/src/aggregate.rs
@@ -22,7 +22,6 @@ use arrow_array::iterator::ArrayIter;
use arrow_array::*;
use arrow_buffer::{ArrowNativeType, NullBuffer};
use arrow... | diff --git a/arrow-integration-test/src/lib.rs b/arrow-integration-test/src/lib.rs
index a312148dc91a..d6e0dda51a81 100644
--- a/arrow-integration-test/src/lib.rs
+++ b/arrow-integration-test/src/lib.rs
@@ -34,9 +34,7 @@ use arrow::buffer::{Buffer, MutableBuffer};
use arrow::compute;
use arrow::datatypes::*;
use arr... | Unused import in nightly rust
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
With this pr been merged to nightly rust: https://github.com/rust-lang/rust/pull/117772
The tracking for unused import has been improved, resulting numerous compiler warnings when building arrow-rs wit... | 2024-03-06T16:29:32Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | |
apache/arrow-rs | 5,474 | apache__arrow-rs-5474 | [
"5463"
] | 7eb866dd328ef9daaa8ce93c25163011ce6ff4d7 | diff --git a/arrow-array/src/record_batch.rs b/arrow-array/src/record_batch.rs
index d89020a65681..314445bba617 100644
--- a/arrow-array/src/record_batch.rs
+++ b/arrow-array/src/record_batch.rs
@@ -236,6 +236,11 @@ impl RecordBatch {
self.schema.clone()
}
+ /// Returns a reference to the [`Schema`] ... | diff --git a/arrow-flight/tests/encode_decode.rs b/arrow-flight/tests/encode_decode.rs
index 789233b918d0..224b12500a08 100644
--- a/arrow-flight/tests/encode_decode.rs
+++ b/arrow-flight/tests/encode_decode.rs
@@ -465,7 +465,7 @@ async fn roundtrip(input: Vec<RecordBatch>) {
/// When <https://github.com/apache/arrow-... | [DISCUSSION] Better borrow propagation (e.g. `RecordBatch::schema()` to return `&SchemaRef` vs `SchemaRef`)
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
For reasons I am not sure of (likely historical), certain APIs of `Schema`/`RecordBatch` return owned i... | 2024-03-05T23:57:29Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | |
apache/arrow-rs | 5,439 | apache__arrow-rs-5439 | [
"5438"
] | ef5c45cf4186a8124da5a1603ebdbc09ef9928fc | diff --git a/arrow-flight/src/error.rs b/arrow-flight/src/error.rs
index e054883e965d..ba979ca9f7a6 100644
--- a/arrow-flight/src/error.rs
+++ b/arrow-flight/src/error.rs
@@ -49,17 +49,24 @@ impl FlightError {
impl std::fmt::Display for FlightError {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::R... | diff --git a/arrow-flight/tests/client.rs b/arrow-flight/tests/client.rs
index 9e19bce92338..47565334cb63 100644
--- a/arrow-flight/tests/client.rs
+++ b/arrow-flight/tests/client.rs
@@ -935,7 +935,7 @@ async fn test_cancel_flight_info_error_no_response() {
assert_eq!(
err.to_string(),
- ... | Refine `Display` implementation for `FlightError`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
There's a `TODO` for a better `std::fmt::Display` implementation on `FlightError`. Currently it forwards to `std::fmt::Debug`, which does not appear to be a good... | 2024-02-27T07:27:28Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | |
apache/arrow-rs | 5,413 | apache__arrow-rs-5413 | [
"5367"
] | 5bb226cc791adfd6903497cbb8fcd8285fe6f298 | diff --git a/arrow-flight/Cargo.toml b/arrow-flight/Cargo.toml
index 81940b7600ee..1e7255baa748 100644
--- a/arrow-flight/Cargo.toml
+++ b/arrow-flight/Cargo.toml
@@ -44,7 +44,9 @@ bytes = { version = "1", default-features = false }
futures = { version = "0.3", default-features = false, features = ["alloc"] }
once_ce... | diff --git a/arrow-flight/tests/client.rs b/arrow-flight/tests/client.rs
index 3ad9ee7a45ca..9e19bce92338 100644
--- a/arrow-flight/tests/client.rs
+++ b/arrow-flight/tests/client.rs
@@ -24,13 +24,15 @@ mod common {
use arrow_array::{RecordBatch, UInt64Array};
use arrow_flight::{
decode::FlightRecordBatchStream,... | Update Flight proto
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in a... | I can take a stab at this next week or so, unless someone else is interested in picking this up :eyes: | 2024-02-20T11:54:36Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d |
apache/arrow-rs | 5,355 | apache__arrow-rs-5355 | [
"5354"
] | 31cf5ce23febf076104f064358a24fe8af09ee4b | diff --git a/arrow/src/pyarrow.rs b/arrow/src/pyarrow.rs
index 9a13cfa493e9..39702ce01aea 100644
--- a/arrow/src/pyarrow.rs
+++ b/arrow/src/pyarrow.rs
@@ -355,7 +355,16 @@ impl FromPyArrow for RecordBatch {
));
}
let array = StructArray::from(array_data);
- return O... | diff --git a/arrow-pyarrow-integration-testing/tests/test_sql.py b/arrow-pyarrow-integration-testing/tests/test_sql.py
index 16d4e0f12f88..5320d0a5343e 100644
--- a/arrow-pyarrow-integration-testing/tests/test_sql.py
+++ b/arrow-pyarrow-integration-testing/tests/test_sql.py
@@ -199,9 +199,10 @@ def test_field_metadata_... | RecordBatch conversion from pyarrow loses Schema's metadata
**Describe the bug**
When importing a pyarrow RecordBatch, we instantiate a `StructArray`, then convert it to a `RecordBatch`.
This loses the metadata from the original schema. This is not seen in the current tests, because pyarrow's
tests for equality on... | 2024-01-31T10:19:29Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | |
apache/arrow-rs | 5,319 | apache__arrow-rs-5319 | [
"5266"
] | b03613eb002302a85f5761f2b16753d4777552e5 | diff --git a/arrow-arith/src/temporal.rs b/arrow-arith/src/temporal.rs
index a9c3de5401c1..a386559e30ba 100644
--- a/arrow-arith/src/temporal.rs
+++ b/arrow-arith/src/temporal.rs
@@ -19,105 +19,302 @@
use std::sync::Arc;
-use chrono::{DateTime, Datelike, NaiveDateTime, NaiveTime, Offset, Timelike};
-
-use arrow_ar... | diff --git a/arrow/tests/arithmetic.rs b/arrow/tests/arithmetic.rs
index 81a19d4b5e20..59a162ef6dc0 100644
--- a/arrow/tests/arithmetic.rs
+++ b/arrow/tests/arithmetic.rs
@@ -16,7 +16,7 @@
// under the License.
use arrow_arith::numeric::{add, sub};
-use arrow_arith::temporal::hour;
+use arrow_arith::temporal::{date... | Temporal Extract/Date Part Kernel
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this... | This looks quite good, and would've made #5262 a bit easier to implement for sure (and for intervals in the future) :+1:
I wouldn't mind trying to take a shot at implementing this if it's not already on your todo list | 2024-01-21T03:01:21Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d |
apache/arrow-rs | 5,318 | apache__arrow-rs-5318 | [
"5314"
] | a0148ba4cea1756bd22c534dff14e362cb5ee242 | diff --git a/arrow-json/src/writer.rs b/arrow-json/src/writer.rs
index cabda5e2dca8..dd77328cb7b5 100644
--- a/arrow-json/src/writer.rs
+++ b/arrow-json/src/writer.rs
@@ -20,28 +20,6 @@
//! This JSON writer converts Arrow [`RecordBatch`]es into arrays of
//! JSON objects or JSON formatted byte streams.
//!
-//! ## W... | diff --git a/arrow-json/test/data/basic.json b/arrow-json/test/data/basic.json
index a6a8766bf97c..fdcae9e6557e 100644
--- a/arrow-json/test/data/basic.json
+++ b/arrow-json/test/data/basic.json
@@ -1,5 +1,5 @@
-{"a":1, "b":2.0, "c":false, "d":"4", "e":"1970-1-2", "f": "1.02", "g": "2012-04-23T18:25:43.511", "h": 1.1}
... | Raw JSON Writer
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addit... | 2024-01-20T13:03:28Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d | |
apache/arrow-rs | 5,293 | apache__arrow-rs-5293 | [
"4102"
] | db811083669df66992008c9409b743a2e365adb0 | diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
index 4cd03c051e62..fb3b67274ada 100644
--- a/parquet/Cargo.toml
+++ b/parquet/Cargo.toml
@@ -175,6 +175,11 @@ name = "compression"
required-features = ["experimental", "default"]
harness = false
+[[bench]]
+name = "encoding"
+required-features = ["experimental",... | diff --git a/parquet-testing b/parquet-testing
index 89b685a64c31..4cb3cff24c96 160000
--- a/parquet-testing
+++ b/parquet-testing
@@ -1,1 +1,1 @@
-Subproject commit 89b685a64c3117b3023d8684af1f41400841db71
+Subproject commit 4cb3cff24c965fb329cdae763eabce47395a68a0
| Parquet: Support `Encoding::BYTE_STREAM_SPLIT`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
I would like to evaluate whether using the `BYTE_STREAM_SPLIT` encoding helps a Float64 column compress better. But it seems like it is not supported yet: https://git... | I'll give it a go myself, if possible. | 2024-01-10T02:39:07Z | 50.0 | 82fc0df73ab97e239ce5c748a05c57ce582f3d5d |
apache/arrow-rs | 5,222 | apache__arrow-rs-5222 | [
"4611"
] | a9470d3eb083303350fc109f94865666fd0f062f | diff --git a/object_store/src/azure/client.rs b/object_store/src/azure/client.rs
index 3c71e69da00c..a30dfe8935be 100644
--- a/object_store/src/azure/client.rs
+++ b/object_store/src/azure/client.rs
@@ -25,7 +25,7 @@ use crate::client::retry::RetryExt;
use crate::client::GetOptionsExt;
use crate::multipart::PartId;
... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index 85231a5a5b9b..f73d78578f08 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -93,4 +93,29 @@ async fn test_get_range() {
let data = store.get_range(&path, range.clone()).... | object_store: range request with suffix
We need to read the last `n` bytes of a file whose size we do not know. This is supported by HTTP range requests, and access to local files (via `Seek`), can `object_store` support it?
`object_store::GetOptions::range` could take, instead of a `core::ops::Range`, something lik... | I seem to remember GCS being the only cloud store that supports this, but I could be mistaken. Have you done any research into this?
The S3 docs say they support the Range header, and specifically states that they don't support `multipart/byteranges` responses, but doesn't specifically say they don't support suffixes h... | 2023-12-18T15:18:36Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f |
apache/arrow-rs | 5,184 | apache__arrow-rs-5184 | [
"5185"
] | b06ab13fa2681624c7d5094004309607b253773b | diff --git a/.github/workflows/arrow.yml b/.github/workflows/arrow.yml
index da56c23b5cd9..d3b2526740fa 100644
--- a/.github/workflows/arrow.yml
+++ b/.github/workflows/arrow.yml
@@ -67,8 +67,8 @@ jobs:
run: cargo test -p arrow-data --all-features
- name: Test arrow-schema with all features
run... | diff --git a/arrow/tests/array_transform.rs b/arrow/tests/array_transform.rs
index 74e2a212736a..6f5b245b8e3b 100644
--- a/arrow/tests/array_transform.rs
+++ b/arrow/tests/array_transform.rs
@@ -28,6 +28,7 @@ use arrow_data::ArrayData;
use arrow_schema::{DataType, Field, Fields};
use std::sync::Arc;
+#[allow(unused... | Remove nightly-only simd feature and related code in ArrowNumericType
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers under... | 2023-12-07T16:39:44Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f | |
apache/arrow-rs | 5,092 | apache__arrow-rs-5092 | [
"5091"
] | 481652a4f8d972b633063158903dbdb0adcf094d | diff --git a/arrow-data/src/transform/mod.rs b/arrow-data/src/transform/mod.rs
index af25e9c7e3dc..268cf10f2326 100644
--- a/arrow-data/src/transform/mod.rs
+++ b/arrow-data/src/transform/mod.rs
@@ -354,6 +354,14 @@ impl<'a> MutableArrayData<'a> {
) -> Self {
let data_type = arrays[0].data_type();
+ ... | diff --git a/arrow/tests/array_transform.rs b/arrow/tests/array_transform.rs
index ccf66e1c30ad..74e2a212736a 100644
--- a/arrow/tests/array_transform.rs
+++ b/arrow/tests/array_transform.rs
@@ -975,6 +975,14 @@ fn test_extend_nulls_panic() {
mutable.extend_nulls(2);
}
+#[test]
+#[should_panic(expected = "Array... | Unsound MutableArrayData Constructor
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
I want to use `MutableArrayData` to construct an array, but if the input array sequence is different, the output will be different.
This is because `MutableArrayData::new_with_capacities` will... | I think it is probably a bug that MutableArrayData lets you extend with a mixture of types, this is not what it is intended to do and is highly unlikely to behave correctly... I was sure it checked this
Edit: it would appear this does is not only incorrect but is unsound, will prioritize fixing this
Thanks for your ... | 2023-11-17T15:11:14Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f |
apache/arrow-rs | 5,080 | apache__arrow-rs-5080 | [
"4867"
] | 4d141a34cb2ab53c07cfd2255351348a830b0224 | diff --git a/arrow-data/src/ffi.rs b/arrow-data/src/ffi.rs
index 2b4d52601286..589f7dac6d19 100644
--- a/arrow-data/src/ffi.rs
+++ b/arrow-data/src/ffi.rs
@@ -168,6 +168,12 @@ impl FFI_ArrowArray {
.collect::<Box<_>>();
let n_children = children.len() as i64;
+ // As in the IPC format, em... | diff --git a/arrow-integration-testing/Cargo.toml b/arrow-integration-testing/Cargo.toml
index 86c2cb27d297..c29860f09d64 100644
--- a/arrow-integration-testing/Cargo.toml
+++ b/arrow-integration-testing/Cargo.toml
@@ -27,11 +27,14 @@ edition = { workspace = true }
publish = false
rust-version = { workspace = true }
... | Enable C Data Integration Tests
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this f... | I'm not a Rust developer, but feel free to ping me for any guidance or early PR comments.
The logs also appear to contain
```
Rust does not support IPC
Rust does not support Flight
```
Which would appear to suggest there may be additional test coverage that isn't enabled properly
Which logs exactly?
For exam... | 2023-11-15T22:59:32Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f |
apache/arrow-rs | 5,076 | apache__arrow-rs-5076 | [
"5037"
] | 7ba36b012322e08b06184c806f8ba339181cebc1 | diff --git a/parquet/src/column/writer/mod.rs b/parquet/src/column/writer/mod.rs
index a917c4864988..11c39685911c 100644
--- a/parquet/src/column/writer/mod.rs
+++ b/parquet/src/column/writer/mod.rs
@@ -636,8 +636,16 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
Type::BYTE_ARR... | diff --git a/parquet/tests/arrow_writer_layout.rs b/parquet/tests/arrow_writer_layout.rs
index fab87f32f5c4..cd124031cfdc 100644
--- a/parquet/tests/arrow_writer_layout.rs
+++ b/parquet/tests/arrow_writer_layout.rs
@@ -185,7 +185,7 @@ fn test_primitive() {
pages: (0..8)
.ma... | Binary columns do not receive truncated statistics
**Describe the bug**
#4389 introduced truncation on column indices for binary columns, where the min/max values for a binary column may be arbitrarily large. As noted, this matches the behaviour in parquet-mr for shortening columns.
However, the value in the statis... | Support for this was only added to the parquet standard 3 weeks ago - https://github.com/apache/parquet-format/pull/216
TBC this will be a breaking API change, as it will break workloads expecting the statistics to not be truncated
Got it. It looks like the change to enable statistics truncation was done to parquet-mr... | 2023-11-14T13:24:14Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f |
apache/arrow-rs | 5,065 | apache__arrow-rs-5065 | [
"3774"
] | 4d141a34cb2ab53c07cfd2255351348a830b0224 | diff --git a/arrow-array/src/numeric.rs b/arrow-array/src/numeric.rs
index ad7b3eca1dbc..b5e474ba696a 100644
--- a/arrow-array/src/numeric.rs
+++ b/arrow-array/src/numeric.rs
@@ -618,7 +618,6 @@ mod tests {
let mask = 0b01010101_01010101_10101010_10101010;
let actual = UInt16Type::mask_from_u64(mask);... | diff --git a/arrow-json/test/data/nested_with_nulls.json b/arrow-json/test/data/nested_with_nulls.json
new file mode 100644
index 000000000000..932565d56063
--- /dev/null
+++ b/arrow-json/test/data/nested_with_nulls.json
@@ -0,0 +1,4 @@
+{"a": null, "b": null, "c": null, "d": {"d1": null, "d2": [null, 1, 2, nu... | arrow_json::LineDelimitedWriter: Write nulls
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
I am trying to convert Parquet data written using Avro Parquet Writer of Java. This parquet includes the Avro Schema inside the key `parquet.avro.schema` of the metad... | 2023-11-12T00:11:46Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f | |
apache/arrow-rs | 5,055 | apache__arrow-rs-5055 | [
"1474"
] | 1d1693777e13e0bc9e0b5326f1256d629278d4bd | diff --git a/parquet/src/arrow/array_reader/byte_array.rs b/parquet/src/arrow/array_reader/byte_array.rs
index 4612f816146a..01666c0af4e6 100644
--- a/parquet/src/arrow/array_reader/byte_array.rs
+++ b/parquet/src/arrow/array_reader/byte_array.rs
@@ -29,12 +29,12 @@ use crate::data_type::Int32Type;
use crate::encoding... | diff --git a/parquet/src/arrow/array_reader/test_util.rs b/parquet/src/arrow/array_reader/test_util.rs
index 7e66efead2e5..05032920139b 100644
--- a/parquet/src/arrow/array_reader/test_util.rs
+++ b/parquet/src/arrow/array_reader/test_util.rs
@@ -17,6 +17,7 @@
use arrow_array::{Array, ArrayRef};
use arrow_schema::D... | Replace Custom Buffer Implementation with Bytes in Parquet
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The parquet crate currently rolls its own `ByteBufferPtr`, `BufferPtr`, `Buffer`, etc... and this feels like functionality that could be provided by an ... | Thanks. Yes these are pretty out-dated and I think it will be good to replace them. Have you thought about just use `MutableBuffer` from Arrow side too?
> Have you thought about just use MutableBuffer from Arrow side too?
I hadn't, but I'm not sure it is a good fit
* I would like to use the ecosystem standard ab... | 2023-11-07T20:52:19Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f |
apache/arrow-rs | 5,003 | apache__arrow-rs-5003 | [
"4986"
] | f53f284b3e6933433c656f4d66e851b566c58c32 | diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
index e5f5e1652b82..bdcbcb81cfce 100644
--- a/parquet/Cargo.toml
+++ b/parquet/Cargo.toml
@@ -66,6 +66,7 @@ tokio = { version = "1.0", optional = true, default-features = false, features =
hashbrown = { version = "0.14", default-features = false }
twox-hash = { ver... | diff --git a/parquet-testing b/parquet-testing
index aafd3fc9df43..506afff9b695 160000
--- a/parquet-testing
+++ b/parquet-testing
@@ -1,1 +1,1 @@
-Subproject commit aafd3fc9df431c2625a514fb46626e5614f1d199
+Subproject commit 506afff9b6957ffe10d08470d467867d43e1bb91
| Add Float16/Half-float logical type to Parquet
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
There is a proposal for an addition of Logical Float-16 (with Fixed Length Byte Array physical typed) to the Parquet Format: https://github.com/apache/parquet-format/... | I'd like to take a stab at this if no one has yet | 2023-10-29T10:53:10Z | 49.0 | a9470d3eb083303350fc109f94865666fd0f062f |
apache/arrow-rs | 4,984 | apache__arrow-rs-4984 | [
"4879"
] | e78d1409c265ae5c216fc62e51a0f20aa55f6415 | diff --git a/object_store/src/aws/builder.rs b/object_store/src/aws/builder.rs
index 75a5299a0859..79ea75b5aba2 100644
--- a/object_store/src/aws/builder.rs
+++ b/object_store/src/aws/builder.rs
@@ -20,7 +20,8 @@ use crate::aws::credential::{
InstanceCredentialProvider, TaskCredentialProvider, WebIdentityProvider,... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index 3fa1cc7104b3..85231a5a5b9b 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -22,9 +22,7 @@ use bytes::Bytes;
use futures::stream::BoxStream;
use object_store::local::LocalFileS... | Conditional Put Support
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, ... | So it turns out that despite [docs](https://cloud.google.com/storage/docs/request-preconditions) that would suggest it is supported, GCS doesn't support preconditions on write other than based on the version number. This is why we test :sweat_smile: | 2023-10-24T13:41:59Z | 48.0 | e78d1409c265ae5c216fc62e51a0f20aa55f6415 |
apache/arrow-rs | 4,944 | apache__arrow-rs-4944 | [
"4934"
] | fa7a61a4b074ca4ec9bf429cc84b6c325057d96e | diff --git a/object_store/src/aws/client.rs b/object_store/src/aws/client.rs
index 8a45a9f3ac47..eb81e92fb932 100644
--- a/object_store/src/aws/client.rs
+++ b/object_store/src/aws/client.rs
@@ -21,6 +21,7 @@ use crate::aws::{
AwsCredentialProvider, S3CopyIfNotExists, STORE, STRICT_PATH_ENCODE_SET,
};
use crate:... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index 25c469260675..5703d7f24844 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -23,7 +23,7 @@ use futures::stream::BoxStream;
use object_store::local::LocalFileSystem;
use object_... | Return ETag and Version on Put
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this fe... | 2023-10-17T12:20:03Z | 47.0 | fa7a61a4b074ca4ec9bf429cc84b6c325057d96e | |
apache/arrow-rs | 4,941 | apache__arrow-rs-4941 | [
"4924"
] | 31bc84c91e7d6c509443f6e73bda0df32a0a5cba | diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
index 8abb4f73a384..37f03a05b3fa 100644
--- a/arrow/Cargo.toml
+++ b/arrow/Cargo.toml
@@ -60,7 +60,7 @@ arrow-select = { workspace = true }
arrow-string = { workspace = true }
rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional... | diff --git a/arrow-pyarrow-integration-testing/Cargo.toml b/arrow-pyarrow-integration-testing/Cargo.toml
index 50987b03ca9e..8c60c086c29a 100644
--- a/arrow-pyarrow-integration-testing/Cargo.toml
+++ b/arrow-pyarrow-integration-testing/Cargo.toml
@@ -34,4 +34,4 @@ crate-type = ["cdylib"]
[dependencies]
arrow = { pa... | Update pyo3 requirement from 0.19 to 0.20
Updates the requirements on [pyo3](https://github.com/pyo3/pyo3) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pyo3/pyo3/releases">pyo3's releases</a>.</em></p>
<blockquote>
<h2>PyO3 0.20.0</h2>
<p>This ... | 2023-10-16T12:20:01Z | 47.0 | fa7a61a4b074ca4ec9bf429cc84b6c325057d96e | |
apache/arrow-rs | 4,930 | apache__arrow-rs-4930 | [
"4946"
] | ab87abdd69ab787fdf247cf36f04abc1fbfa6266 | diff --git a/object_store/src/aws/mod.rs b/object_store/src/aws/mod.rs
index 0028be99fa2e..3c9431091018 100644
--- a/object_store/src/aws/mod.rs
+++ b/object_store/src/aws/mod.rs
@@ -335,19 +335,16 @@ impl ObjectStore for AmazonS3 {
.boxed()
}
- async fn list(
- &self,
- prefix: Opt... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
index f926e3b07f2a..25c469260675 100644
--- a/object_store/tests/get_range_file.rs
+++ b/object_store/tests/get_range_file.rs
@@ -75,10 +75,7 @@ impl ObjectStore for MyStore {
todo!()
}
- async fn list(
- ... | Simplify ObjectStore::List
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this featur... | 2023-10-13T13:42:45Z | 47.0 | fa7a61a4b074ca4ec9bf429cc84b6c325057d96e | |
apache/arrow-rs | 4,910 | apache__arrow-rs-4910 | [
"4903"
] | 2af51631e492e0ea0ac71da67b3dba6a846dafd5 | diff --git a/arrow-csv/src/reader/mod.rs b/arrow-csv/src/reader/mod.rs
index 17db7a34e06f..2ba49cadc73f 100644
--- a/arrow-csv/src/reader/mod.rs
+++ b/arrow-csv/src/reader/mod.rs
@@ -193,6 +193,7 @@ impl InferredDataType {
/// Returns the inferred data type
fn get(&self) -> DataType {
match self.pack... | diff --git a/arrow-csv/test/data/init_null_test.csv b/arrow-csv/test/data/init_null_test.csv
new file mode 100644
index 000000000000..f7d8a299645d
--- /dev/null
+++ b/arrow-csv/test/data/init_null_test.csv
@@ -0,0 +1,6 @@
+c_int,c_float,c_string,c_bool,c_null
+,,,,
+2,2.2,"a",TRUE,
+3,,"b",true,
+4,4.4,,False,
+5,6.6,"... | CSV schema inference assumes `Utf8` for empty columns
**Describe the bug**
When rows processed by schema inference do not contain any data (are empty) for given column, that column is inferred as nullable `DataType::Utf8`. This data type is in fact a "catch-all" that permits any values later on, but it is in fact a li... | 2023-10-09T17:24:04Z | 47.0 | fa7a61a4b074ca4ec9bf429cc84b6c325057d96e | |
apache/arrow-rs | 4,909 | apache__arrow-rs-4909 | [
"4735"
] | ed58e767d7607e954085842a57a680b6807794e0 | diff --git a/arrow-csv/src/writer.rs b/arrow-csv/src/writer.rs
index 840e8e8a93cc..1ca956e2c73f 100644
--- a/arrow-csv/src/writer.rs
+++ b/arrow-csv/src/writer.rs
@@ -70,11 +70,6 @@ use csv::ByteRecord;
use std::io::Write;
use crate::map_csv_error;
-
-const DEFAULT_DATE_FORMAT: &str = "%F";
-const DEFAULT_TIME_FORM... | diff --git a/arrow/tests/csv.rs b/arrow/tests/csv.rs
index 3ee319101757..a79b6b44c2d3 100644
--- a/arrow/tests/csv.rs
+++ b/arrow/tests/csv.rs
@@ -53,48 +53,6 @@ fn test_export_csv_timestamps() {
}
drop(writer);
- let left = "c1,c2
-2019-04-18T20:54:47.378000000+10:00,2019-04-18T10:54:47.378000000
-2021-... | Add read access to settings in `csv::WriterBuilder`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
While implementing CSV writing in DataFusion (see https://github.com/apache/arrow-datafusion/pull/7390/files), we would like to be able to check the value of `... | Looks it is easy. | 2023-10-09T16:11:31Z | 47.0 | fa7a61a4b074ca4ec9bf429cc84b6c325057d96e |
apache/arrow-rs | 4,808 | apache__arrow-rs-4808 | [
"4807"
] | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | diff --git a/arrow-array/src/array/map_array.rs b/arrow-array/src/array/map_array.rs
index fca49cd7836f..77a7b9d4d547 100644
--- a/arrow-array/src/array/map_array.rs
+++ b/arrow-array/src/array/map_array.rs
@@ -330,7 +330,7 @@ impl MapArray {
Arc::new(Field::new(
"entries",
... | diff --git a/arrow-integration-testing/src/bin/arrow-json-integration-test.rs b/arrow-integration-testing/src/bin/arrow-json-integration-test.rs
index 2c36e8d9b8ae..db5df8b58a6f 100644
--- a/arrow-integration-testing/src/bin/arrow-json-integration-test.rs
+++ b/arrow-integration-testing/src/bin/arrow-json-integration-t... | MapArray::new_from_strings creates nullable entries field
**Describe the bug**
This line creates a nullable entries field:
https://github.com/apache/arrow-rs/blob/878217b9e330b4f1ed13e798a214ea11fbeb2bbb/arrow-array/src/array/map_array.rs#L330-L334
The Arrow spec dictates this should not be nullable:
https:... | 2023-09-10T00:06:58Z | 46.0 | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | |
apache/arrow-rs | 4,806 | apache__arrow-rs-4806 | [
"4805"
] | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | diff --git a/arrow/src/pyarrow.rs b/arrow/src/pyarrow.rs
index 6063ae763228..ab0ea8ef8d74 100644
--- a/arrow/src/pyarrow.rs
+++ b/arrow/src/pyarrow.rs
@@ -59,14 +59,14 @@ use std::convert::{From, TryFrom};
use std::ptr::{addr_of, addr_of_mut};
use std::sync::Arc;
-use arrow_array::RecordBatchReader;
+use arrow_arra... | diff --git a/arrow-pyarrow-integration-testing/tests/test_sql.py b/arrow-pyarrow-integration-testing/tests/test_sql.py
index 3be5b9ec52fe..1748fd3ffb6b 100644
--- a/arrow-pyarrow-integration-testing/tests/test_sql.py
+++ b/arrow-pyarrow-integration-testing/tests/test_sql.py
@@ -393,6 +393,23 @@ def test_sparse_union_py... | pyarrow module can't roundtrip tensor arrays
**Describe the bug**
When exporting a tensor array (a kind of extension array) as a record batch, PyArrow segfaults. This does not happen if the batch is exported as a stream.
**To Reproduce**
The following test will fail in `arrow-pyarrow-integration-testing/tests/... | 2023-09-09T19:32:20Z | 46.0 | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | |
apache/arrow-rs | 4,797 | apache__arrow-rs-4797 | [
"4658",
"3598"
] | 15dde87d4ecefadedb22a1df1aeebc0a09cfab0e | diff --git a/arrow-flight/examples/flight_sql_server.rs b/arrow-flight/examples/flight_sql_server.rs
index 1e99957390d8..d1aeae6f0a6c 100644
--- a/arrow-flight/examples/flight_sql_server.rs
+++ b/arrow-flight/examples/flight_sql_server.rs
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
//... | diff --git a/arrow-flight/tests/flight_sql_client_cli.rs b/arrow-flight/tests/flight_sql_client_cli.rs
index 912bcc75a9df..221e776218c3 100644
--- a/arrow-flight/tests/flight_sql_client_cli.rs
+++ b/arrow-flight/tests/flight_sql_client_cli.rs
@@ -19,11 +19,13 @@ use std::{net::SocketAddr, pin::Pin, sync::Arc, time::Dur... | DoPut FlightSQL handler inadvertently consumes schema at start of Request<Streaming<FlightData>>
**Describe the bug**
When executing `DoPutPreparedStatementQuery` requests to bind parameters to a prepared statement, using the `DoPut` Flight RPC, one may receive an error like this:
```
rpc error: code = Internal desc... | 2023-09-07T21:04:59Z | 46.0 | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | |
apache/arrow-rs | 4,795 | apache__arrow-rs-4795 | [
"4794",
"4794"
] | 77455d48cd6609045a4728ba908123de9d0b62fd | diff --git a/arrow-csv/src/reader/mod.rs b/arrow-csv/src/reader/mod.rs
index 328c2cd41f3b..695e3d47965d 100644
--- a/arrow-csv/src/reader/mod.rs
+++ b/arrow-csv/src/reader/mod.rs
@@ -133,8 +133,8 @@ use arrow_schema::*;
use chrono::{TimeZone, Utc};
use csv::StringRecord;
use lazy_static::lazy_static;
-use regex::Reg... | diff --git a/arrow-csv/test/data/custom_null_test.csv b/arrow-csv/test/data/custom_null_test.csv
new file mode 100644
index 000000000000..39f9fc4b3eff
--- /dev/null
+++ b/arrow-csv/test/data/custom_null_test.csv
@@ -0,0 +1,6 @@
+c_int,c_float,c_string,c_bool
+1,1.1,"1.11",True
+nil,2.2,"2.22",TRUE
+3,nil,"3.33",true
+4... | Add option to specify custom null values for CSV reader
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the cont... | 2023-09-07T17:45:56Z | 46.0 | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | |
apache/arrow-rs | 4,773 | apache__arrow-rs-4773 | [
"4772"
] | 03d0505fc864c09e6dcd208d3cdddeecefb90345 | diff --git a/parquet/src/record/mod.rs b/parquet/src/record/mod.rs
index 771d8058c9c1..f40e91418da1 100644
--- a/parquet/src/record/mod.rs
+++ b/parquet/src/record/mod.rs
@@ -19,6 +19,7 @@
mod api;
pub mod reader;
+mod record_reader;
mod record_writer;
mod triplet;
@@ -26,5 +27,6 @@ pub use self::{
api::{
... | diff --git a/parquet_derive_test/src/lib.rs b/parquet_derive_test/src/lib.rs
index d377fb0a62af..a8b631ecc024 100644
--- a/parquet_derive_test/src/lib.rs
+++ b/parquet_derive_test/src/lib.rs
@@ -17,7 +17,7 @@
#![allow(clippy::approx_constant)]
-use parquet_derive::ParquetRecordWriter;
+use parquet_derive::{Parquet... | There exists a `ParquetRecordWriter` proc macro in `parquet_derive`, but `ParquetRecordReader` is missing
## Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Reading parquet files into slices of structs can take quite a lot of code. There exists a `parquet_derive::P... | 2023-09-04T16:10:38Z | 48.0 | e78d1409c265ae5c216fc62e51a0f20aa55f6415 | |
apache/arrow-rs | 4,752 | apache__arrow-rs-4752 | [
"4750"
] | 32e973d7fd90a6f94799177a6d3735c6e3201689 | diff --git a/arrow/src/ffi_stream.rs b/arrow/src/ffi_stream.rs
index 7005cadc623c..865a8d0e0a29 100644
--- a/arrow/src/ffi_stream.rs
+++ b/arrow/src/ffi_stream.rs
@@ -281,7 +281,7 @@ fn get_stream_schema(stream_ptr: *mut FFI_ArrowArrayStream) -> Result<SchemaRef>
let ret_code = unsafe { (*stream_ptr).get_schema.un... | diff --git a/arrow-pyarrow-integration-testing/tests/test_sql.py b/arrow-pyarrow-integration-testing/tests/test_sql.py
index 92782b9ed473..e2e8d66c0f29 100644
--- a/arrow-pyarrow-integration-testing/tests/test_sql.py
+++ b/arrow-pyarrow-integration-testing/tests/test_sql.py
@@ -421,6 +421,14 @@ def iter_batches():
... | stream ffi panics if schema metadata values aren't valid utf8
**Describe the bug**
The values in schema and field metadata should be valid UTF-8 according to the flatbuffers files but, due to a long-standing oversight, the C++ / Python implementations use binary and not string values. So it would be nicer to them if... | 2023-08-30T03:38:46Z | 46.0 | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | |
apache/arrow-rs | 4,751 | apache__arrow-rs-4751 | [
"4730"
] | eeba0a3792a2774dee1d10a25340b2741cf95c9e | diff --git a/arrow/src/lib.rs b/arrow/src/lib.rs
index fb904c1908e6..f4d0585fa6b5 100644
--- a/arrow/src/lib.rs
+++ b/arrow/src/lib.rs
@@ -375,7 +375,8 @@ pub mod pyarrow;
pub mod record_batch {
pub use arrow_array::{
- RecordBatch, RecordBatchOptions, RecordBatchReader, RecordBatchWriter,
+ Recor... | diff --git a/arrow-pyarrow-integration-testing/src/lib.rs b/arrow-pyarrow-integration-testing/src/lib.rs
index adcec769f247..a53447b53c31 100644
--- a/arrow-pyarrow-integration-testing/src/lib.rs
+++ b/arrow-pyarrow-integration-testing/src/lib.rs
@@ -21,6 +21,7 @@
use std::sync::Arc;
use arrow::array::new_empty_arr... | Support IntoPyArrow for impl RecordBatchReader
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
It's a little awkward to export RBR, since you have to export them manually like:
```
let batch_reader = ...
let stream = FFI_ArrowArrayStream::new(Box::new(... | 2023-08-30T03:21:34Z | 46.0 | 878217b9e330b4f1ed13e798a214ea11fbeb2bbb | |
apache/arrow-rs | 4,681 | apache__arrow-rs-4681 | [
"4255"
] | c6184389241a0c85823aa494e8b5d93343771666 | diff --git a/arrow-array/src/array/list_array.rs b/arrow-array/src/array/list_array.rs
index 05628084c844..e50f2eb0941d 100644
--- a/arrow-array/src/array/list_array.rs
+++ b/arrow-array/src/array/list_array.rs
@@ -1037,13 +1037,17 @@ mod tests {
#[should_panic(
expected = "Memory pointer is not aligned w... | diff --git a/arrow/tests/array_validation.rs b/arrow/tests/array_validation.rs
index 0d3652a0473a..fa80db1860cd 100644
--- a/arrow/tests/array_validation.rs
+++ b/arrow/tests/array_validation.rs
@@ -56,7 +56,9 @@ fn test_bad_number_of_buffers() {
}
#[test]
-#[should_panic(expected = "integer overflow computing min ... | Handle Misaligned IPC Buffers
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this fea... | 2023-08-11T11:00:40Z | 45.0 | c6184389241a0c85823aa494e8b5d93343771666 | |
apache/arrow-rs | 4,670 | apache__arrow-rs-4670 | [
"4637"
] | 5023ea8438e3143bf711a89a3a2ffb8838a18e9e | diff --git a/arrow-data/src/equal/fixed_binary.rs b/arrow-data/src/equal/fixed_binary.rs
index 9e0e77ff7eca..40dacdddd3a0 100644
--- a/arrow-data/src/equal/fixed_binary.rs
+++ b/arrow-data/src/equal/fixed_binary.rs
@@ -80,7 +80,7 @@ pub(super) fn fixed_binary_equal(
lhs_start + lhs_nulls.offset(),
... | diff --git a/arrow/tests/array_equal.rs b/arrow/tests/array_equal.rs
index 83a280db67b8..4abe31a36cf5 100644
--- a/arrow/tests/array_equal.rs
+++ b/arrow/tests/array_equal.rs
@@ -1295,3 +1295,25 @@ fn test_struct_equal_slice() {
test_equal(&a, &b, true);
}
+
+#[test]
+fn test_list_excess_children_equal() {
+ ... | `List(FixedSizeBinary)` array equality check may return wrong result
**Describe the bug**
`<ListArray as PartialEq>::eq` returns `false` for two arrays of datatype `List(FixedSizeBinary(5))` containing identical values but physically differ.
**To Reproduce**
```rust
#[test]
fn test_list_excess_children_equal() {... | These two array isn't equal in fact.
```
values: [
[49, 49, 49, 49, 49],
[50, 50, 50, 50, 50],
null,
]
value_offsets: [0, 1, 3]
values [
[50, 50, 50, 50, 50],
null,
]
value_offsets [0, 0, 2]
``` | 2023-08-09T15:59:12Z | 45.0 | c6184389241a0c85823aa494e8b5d93343771666 |
apache/arrow-rs | 4,665 | apache__arrow-rs-4665 | [
"4656"
] | 696cbdbb72e821613f44a09e2b547d2f85c06089 | diff --git a/arrow-flight/examples/flight_sql_server.rs b/arrow-flight/examples/flight_sql_server.rs
index f717d9b621b2..08a36bc49ea8 100644
--- a/arrow-flight/examples/flight_sql_server.rs
+++ b/arrow-flight/examples/flight_sql_server.rs
@@ -196,9 +196,9 @@ impl FlightSqlService for FlightSqlServiceImpl {
sel... | diff --git a/arrow-flight/tests/flight_sql_client_cli.rs b/arrow-flight/tests/flight_sql_client_cli.rs
index c4ae9280c898..912bcc75a9df 100644
--- a/arrow-flight/tests/flight_sql_client_cli.rs
+++ b/arrow-flight/tests/flight_sql_client_cli.rs
@@ -144,9 +144,9 @@ impl FlightSqlService for FlightSqlServiceImpl {
... | API improvement: `batches_to_flight_data` forces clone
The API is pretty inconsistent, sometimes requiring a `Schema` and sometimes a `SchemaRef`.
For example I hold a `SchemaRef`, but `batches_to_flight_data` requires a `Schema`, forcing me to create a clone of the ref counted object.
Instead, the function shoul... | Make sense to me | 2023-08-08T06:08:51Z | 45.0 | c6184389241a0c85823aa494e8b5d93343771666 |
apache/arrow-rs | 4,660 | apache__arrow-rs-4660 | [
"4659"
] | f16ceedf981c7230167ff858eabb9a8cdc87ffda | diff --git a/arrow/src/ffi_stream.rs b/arrow/src/ffi_stream.rs
index 7d6689a89058..a9d2e8ab6bf2 100644
--- a/arrow/src/ffi_stream.rs
+++ b/arrow/src/ffi_stream.rs
@@ -54,6 +54,7 @@
//! }
//! ```
+use std::ffi::CStr;
use std::ptr::addr_of;
use std::{
convert::TryFrom,
@@ -120,7 +121,7 @@ unsafe extern "C" fn ... | diff --git a/arrow-pyarrow-integration-testing/src/lib.rs b/arrow-pyarrow-integration-testing/src/lib.rs
index 89395bd2ed08..adcec769f247 100644
--- a/arrow-pyarrow-integration-testing/src/lib.rs
+++ b/arrow-pyarrow-integration-testing/src/lib.rs
@@ -21,6 +21,7 @@
use std::sync::Arc;
use arrow::array::new_empty_arr... | Double free in C Stream Interface
**Describe the bug**
Got a double free when consuming a stream and trying to return the error. Right now the C Stream Interface import tries to take ownership of the error string, but once the release callback is called that string gets freed.
https://github.com/apache/arrow-rs/b... | 2023-08-07T20:07:26Z | 45.0 | c6184389241a0c85823aa494e8b5d93343771666 | |
apache/arrow-rs | 4,598 | apache__arrow-rs-4598 | [
"4578"
] | 95683439fa4108c036e48b334f8bed898b87a9b9 | diff --git a/arrow-data/src/transform/union.rs b/arrow-data/src/transform/union.rs
index 8d1ea34c314d..d7083588d782 100644
--- a/arrow-data/src/transform/union.rs
+++ b/arrow-data/src/transform/union.rs
@@ -39,6 +39,9 @@ pub(super) fn build_extend_sparse(array: &ArrayData) -> Extend {
pub(super) fn build_extend_dense(... | diff --git a/arrow/tests/array_transform.rs b/arrow/tests/array_transform.rs
index ebbadc00aecd..15141eb208e4 100644
--- a/arrow/tests/array_transform.rs
+++ b/arrow/tests/array_transform.rs
@@ -19,7 +19,7 @@ use arrow::array::{
Array, ArrayRef, BooleanArray, Decimal128Array, DictionaryArray,
FixedSizeBinaryA... | `arrow::compute::concat` panics for dense union arrays with non-trivial type IDs
**Describe the bug**
`arrow::compute::concat` panics when called with dense union arrays with type IDs that don't start at zero.
```
thread 'proptest::tests::qc_row' panicked at 'index out of bounds: the len is 1 but the index is 35',... | MutableArrayData likely needs to be updated to properly understand UnionArray with non-trivial type ids | 2023-07-31T04:27:18Z | 45.0 | c6184389241a0c85823aa494e8b5d93343771666 |
apache/arrow-rs | 4,594 | apache__arrow-rs-4594 | [
"4481"
] | 16744e5ac08d9ead6c51ff6e08d8b91e87460c52 | diff --git a/arrow-arith/src/arithmetic.rs b/arrow-arith/src/arithmetic.rs
index f8c855af0183..8635ce0ddd80 100644
--- a/arrow-arith/src/arithmetic.rs
+++ b/arrow-arith/src/arithmetic.rs
@@ -31,552 +31,6 @@ use arrow_schema::*;
use std::cmp::min;
use std::sync::Arc;
-/// Helper function to perform math lambda funct... | diff --git a/arrow-pyarrow-integration-testing/src/lib.rs b/arrow-pyarrow-integration-testing/src/lib.rs
index 730409b3777e..89395bd2ed08 100644
--- a/arrow-pyarrow-integration-testing/src/lib.rs
+++ b/arrow-pyarrow-integration-testing/src/lib.rs
@@ -49,7 +49,7 @@ fn double(array: &PyAny, py: Python) -> PyResult<PyObje... | Remove Deprecated Arithmetic Kernels
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for t... | 2023-07-30T20:17:13Z | 45.0 | c6184389241a0c85823aa494e8b5d93343771666 | |
apache/arrow-rs | 4,351 | apache__arrow-rs-4351 | [
"4350"
] | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | diff --git a/object_store/Cargo.toml b/object_store/Cargo.toml
index 28bf29f7f1e0..4002a1865fa6 100644
--- a/object_store/Cargo.toml
+++ b/object_store/Cargo.toml
@@ -75,3 +75,7 @@ tempfile = "3.1.0"
futures-test = "0.3"
rand = "0.8"
hyper = { version = "0.14.24", features = ["server"] }
+
+[[test]]
+name = "get_ran... | diff --git a/object_store/tests/get_range_file.rs b/object_store/tests/get_range_file.rs
new file mode 100644
index 000000000000..f926e3b07f2a
--- /dev/null
+++ b/object_store/tests/get_range_file.rs
@@ -0,0 +1,116 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme... | Default ObjectStore::get_range Doesn't Apply Range to GetResult::File
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
The default implementation of `ObjectStore::get_range` added in #4212 incorrectly handles if `GetResult::File` is returned, instead returning the entire byte rang... | 2023-06-02T16:36:39Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,343 | apache__arrow-rs-4343 | [
"4324"
] | 795259502d8d19f1e929d8ebf1b2819b6ab145c4 | diff --git a/arrow-data/src/transform/mod.rs b/arrow-data/src/transform/mod.rs
index c74875072233..f4b2b46d1723 100644
--- a/arrow-data/src/transform/mod.rs
+++ b/arrow-data/src/transform/mod.rs
@@ -53,7 +53,7 @@ struct _MutableArrayData<'a> {
pub null_count: usize,
pub len: usize,
- pub null_buffer: Mut... | diff --git a/arrow/tests/array_transform.rs b/arrow/tests/array_transform.rs
index 40938c80f4c3..ebbadc00aecd 100644
--- a/arrow/tests/array_transform.rs
+++ b/arrow/tests/array_transform.rs
@@ -922,6 +922,29 @@ fn test_fixed_size_binary_append() {
assert_eq!(result, expected);
}
+#[test]
+fn test_extend_nulls(... | concat_batches panics with total_len <= bit_len assertion for records with lists
**Describe the bug**
`concat`, used by `concat_batches`, does not appear to allocate sufficient `capacities` when constructing the `MutableArrayData`. Concatenating records that contain lists of structs results in the following panic:
``... | Possibly related to https://github.com/apache/arrow-rs/issues/1230. The error would suggest that the validity buffer is not the correct length. I'll take a look in a bit, MutableArrayData is overdue some TLC in this regard (#1225)
Are you able to share a reproducer for this?
Sure, see https://github.com/ElementalCognit... | 2023-06-02T07:51:43Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 |
apache/arrow-rs | 4,342 | apache__arrow-rs-4342 | [
"4289"
] | a121e0969ee83d3396c59603717333864acc52fa | diff --git a/arrow-ord/src/comparison.rs b/arrow-ord/src/comparison.rs
index c771182f7917..b9274f0eaefb 100644
--- a/arrow-ord/src/comparison.rs
+++ b/arrow-ord/src/comparison.rs
@@ -2700,7 +2700,7 @@ where
}
/// Checks if a [`GenericListArray`] contains a value in the [`PrimitiveArray`]
-pub fn contains<T, OffsetS... | diff --git a/arrow/tests/array_validation.rs b/arrow/tests/array_validation.rs
index 67960ada6c98..0d3652a0473a 100644
--- a/arrow/tests/array_validation.rs
+++ b/arrow/tests/array_validation.rs
@@ -948,8 +948,7 @@ fn test_try_new_sliced_struct() {
let struct_array = builder.finish();
let struct_array_slice... | ambiguous glob re-exports of contains_utf8
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
```
warning: ambiguous glob re-exports
--> arrow/src/compute/kernels/mod.rs:31:13
|
31 | pub use arrow_ord::comparison::*;
| ^^^^^^^^^^^^^^^^^^^^^^^^ the name `co... | 2023-06-02T06:18:55Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,327 | apache__arrow-rs-4327 | [
"3680"
] | 30196d89bfab698c50bcde6c304f0599011a1100 | diff --git a/parquet/src/column/writer/mod.rs b/parquet/src/column/writer/mod.rs
index 310519f4a39c..fc5e29b03256 100644
--- a/parquet/src/column/writer/mod.rs
+++ b/parquet/src/column/writer/mod.rs
@@ -308,6 +308,17 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
max: Option<&E::T>,
d... | diff --git a/parquet/tests/arrow_writer_layout.rs b/parquet/tests/arrow_writer_layout.rs
index 142112b7b686..3142c8c52063 100644
--- a/parquet/tests/arrow_writer_layout.rs
+++ b/parquet/tests/arrow_writer_layout.rs
@@ -19,6 +19,7 @@
use arrow::array::{Int32Array, StringArray};
use arrow::record_batch::RecordBatch;
... | Should Parquet pages begin on the start of a row?
**Which part is this question about**
Parquet writer
<!--
Is it code base, library api, documentation or some other part?
-->
**Describe your question**
In #1777 it was brought up [here](https://github.com/apache/arrow-rs/issues/1777#issuecomment-1147686956) tha... | I'm not sure it is a bug per se, but I definitely think the APIs shouldn't do it unilaterally as they currently do.
I would support making `GenericColumnWriter::write_batch_internal` call `write_mini_batch` treating the `WriterProperties::write_batch_size` as being a number of rows, as opposed to levels. Tbh this is... | 2023-05-31T19:17:10Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 |
apache/arrow-rs | 4,326 | apache__arrow-rs-4326 | [
"4321"
] | 0baf99a2244d39ff910ec09a0bc3a30b1138a577 | diff --git a/parquet/src/arrow/arrow_reader/mod.rs b/parquet/src/arrow/arrow_reader/mod.rs
index 9cb09c9a5d7d..deca0c719551 100644
--- a/parquet/src/arrow/arrow_reader/mod.rs
+++ b/parquet/src/arrow/arrow_reader/mod.rs
@@ -2522,4 +2522,36 @@ mod tests {
assert_eq!(&written.slice(0, 8), &read[0]);
}
+
+ ... | diff --git a/parquet/src/util/test_common/page_util.rs b/parquet/src/util/test_common/page_util.rs
index ab5287462c8c..c51c5158cd42 100644
--- a/parquet/src/util/test_common/page_util.rs
+++ b/parquet/src/util/test_common/page_util.rs
@@ -170,15 +170,22 @@ impl<P: Iterator<Item = Page> + Send> PageReader for InMemoryPa... | Incorrect PageMetadata Row Count returned for V1 DataPage
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
`PageReader::peek_next_page` for `SerializedPageReader` and `InMemoryPageReader` returns num_values for DataPageV1. This is not the row count, and is instead the number of le... | 2023-05-31T17:53:53Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,316 | apache__arrow-rs-4316 | [
"4312"
] | 04ca2f2b0ad964ce8962b8b362da0df932c88091 | diff --git a/arrow/src/pyarrow.rs b/arrow/src/pyarrow.rs
index ba8d606f2e1f..98e27ab30e09 100644
--- a/arrow/src/pyarrow.rs
+++ b/arrow/src/pyarrow.rs
@@ -24,7 +24,7 @@ use std::convert::{From, TryFrom};
use std::ptr::{addr_of, addr_of_mut};
use std::sync::Arc;
-use pyo3::exceptions::PyValueError;
+use pyo3::except... | diff --git a/arrow-pyarrow-integration-testing/tests/test_sql.py b/arrow-pyarrow-integration-testing/tests/test_sql.py
index f631f67cbfea..a7c6b34a4474 100644
--- a/arrow-pyarrow-integration-testing/tests/test_sql.py
+++ b/arrow-pyarrow-integration-testing/tests/test_sql.py
@@ -408,3 +408,25 @@ def test_record_batch_re... | PyArrow conversions could return TypeError if provided incorrect Python type
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Right now, we bubble up an error like
```
AttributeError: 'XXX' object has no attribute '_export_to_c'
```
When we instead pro... | 2023-05-31T03:33:23Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,287 | apache__arrow-rs-4287 | [
"4286"
] | 3fd744b6913d12a9079db0bae1199cc80caff5d9 | diff --git a/parquet/src/arrow/arrow_writer/mod.rs b/parquet/src/arrow/arrow_writer/mod.rs
index 08cfc7ea3ebf..616968bf6407 100644
--- a/parquet/src/arrow/arrow_writer/mod.rs
+++ b/parquet/src/arrow/arrow_writer/mod.rs
@@ -117,7 +117,7 @@ impl<W: Write> Debug for ArrowWriter<W> {
}
}
-impl<W: Write> ArrowWriter... | diff --git a/parquet_derive_test/src/lib.rs b/parquet_derive_test/src/lib.rs
index d2cf9efb1db6..f4f8be1e0d8c 100644
--- a/parquet_derive_test/src/lib.rs
+++ b/parquet_derive_test/src/lib.rs
@@ -56,8 +56,7 @@ mod tests {
use std::{env, fs, io::Write, sync::Arc};
use parquet::{
- file::{properties::Wr... | Make ColumnWriter Send
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, i... | 2023-05-26T09:48:13Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,250 | apache__arrow-rs-4250 | [
"4249"
] | 25bfccca58ff219d9f59ba9f4d75550493238a4f | diff --git a/arrow-flight/examples/flight_sql_server.rs b/arrow-flight/examples/flight_sql_server.rs
index 23d71090ae47..01632285cf66 100644
--- a/arrow-flight/examples/flight_sql_server.rs
+++ b/arrow-flight/examples/flight_sql_server.rs
@@ -18,7 +18,11 @@
use arrow_array::builder::StringBuilder;
use arrow_array::{A... | diff --git a/arrow-flight/tests/client.rs b/arrow-flight/tests/client.rs
index ed928a52c99a..8ea542879a27 100644
--- a/arrow-flight/tests/client.rs
+++ b/arrow-flight/tests/client.rs
@@ -104,6 +104,7 @@ fn test_flight_info(request: &FlightDescriptor) -> FlightInfo {
flight_descriptor: Some(request.clone()),
... | Update flight-sql implementation to latest specs
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The proto definitions for the flight sql spec have seen some updates not yet reflected in the `arrow-flight` crate.
**Describe the solution you'd like**
Upd... | 2023-05-21T13:00:01Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,232 | apache__arrow-rs-4232 | [
"4222"
] | 25bfccca58ff219d9f59ba9f4d75550493238a4f | diff --git a/arrow/src/ffi_stream.rs b/arrow/src/ffi_stream.rs
index 0e358c36a0dc..cfda4c88b4b9 100644
--- a/arrow/src/ffi_stream.rs
+++ b/arrow/src/ffi_stream.rs
@@ -37,25 +37,19 @@
//! let reader = Box::new(FileReader::try_new(file).unwrap());
//!
//! // export it
-//! let stream = Box::new(FFI_ArrowArrayStream::e... | diff --git a/arrow-pyarrow-integration-testing/src/lib.rs b/arrow-pyarrow-integration-testing/src/lib.rs
index af400868ffa9..730409b3777e 100644
--- a/arrow-pyarrow-integration-testing/src/lib.rs
+++ b/arrow-pyarrow-integration-testing/src/lib.rs
@@ -24,12 +24,12 @@ use arrow::array::new_empty_array;
use pyo3::prelude... | Make ArrowArrayStreamReader Send
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
ArrowArrayStreamReader is not Send, which makes is very difficult to work with in async contexts.
While [FFI_ArrowArrayStream](https://docs.rs/arrow/39.0.0/arrow/ffi_stream/st... | 2023-05-17T03:12:15Z | 40.0 | 008cf9c27424d581a67ba97f338a22b6eace9cc1 | |
apache/arrow-rs | 4,201 | apache__arrow-rs-4201 | [
"1936"
] | 378a9fcc9ee31fff4a9a13f5de5a326dc449541e | diff --git a/arrow-cast/src/cast.rs b/arrow-cast/src/cast.rs
index 37fede0a6fe0..2b286bfa9119 100644
--- a/arrow-cast/src/cast.rs
+++ b/arrow-cast/src/cast.rs
@@ -35,7 +35,7 @@
//! assert_eq!(7.0, c.value(2));
//! ```
-use chrono::{NaiveTime, TimeZone, Timelike, Utc};
+use chrono::{NaiveTime, Offset, TimeZone, Time... | diff --git a/arrow/tests/array_cast.rs b/arrow/tests/array_cast.rs
index bf7e7a326efc..43dc6dd0eb0a 100644
--- a/arrow/tests/array_cast.rs
+++ b/arrow/tests/array_cast.rs
@@ -18,6 +18,7 @@
use arrow_array::builder::{
PrimitiveDictionaryBuilder, StringDictionaryBuilder, UnionBuilder,
};
+use arrow_array::cast::As... | Cast Kernel Ignores Timezone
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The beginnings of timezone support were added in #824, however, this is currently ignored by the cast kernel
**Describe the solution you'd like**
Timezones should be correctly ... | I'd like to work on this. And I think `fmt` of timestamp array cannot ignore timezone too.
Could you assign it to me? @tustvold
I would recommend writing up the expected behaviour first, as timezone handling is notoriously messy, and once we have consensus we can move forward with implementing that.
FYI @avantgardne... | 2023-05-11T11:37:13Z | 39.0 | 378a9fcc9ee31fff4a9a13f5de5a326dc449541e |
apache/arrow-rs | 4,101 | apache__arrow-rs-4101 | [
"3855"
] | 6099864180b9a42472bd0a0a17d16a1b612902f4 | diff --git a/arrow-flight/src/encode.rs b/arrow-flight/src/encode.rs
index f97311d6f9e3..9650031d8b5f 100644
--- a/arrow-flight/src/encode.rs
+++ b/arrow-flight/src/encode.rs
@@ -17,7 +17,7 @@
use std::{collections::VecDeque, fmt::Debug, pin::Pin, sync::Arc, task::Poll};
-use crate::{error::Result, FlightData, Sch... | diff --git a/arrow-flight/tests/encode_decode.rs b/arrow-flight/tests/encode_decode.rs
index 90fa2b7a6832..4f1a8e667ffc 100644
--- a/arrow-flight/tests/encode_decode.rs
+++ b/arrow-flight/tests/encode_decode.rs
@@ -22,6 +22,8 @@ use std::{collections::HashMap, sync::Arc};
use arrow_array::types::Int32Type;
use arrow_... | Enable setting FlightDescriptor on FlightDataEncoderBuilder
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
When using FlightDataEncoder to send arrow batches to a flight do_put endpoint, FlightDescriptor cannot easily be set on first message. https://arrow.apa... | Thanks for the suggestion @alexwilcoxson-rel -- I agree this sounds like a nice addition to the API.
Given the request is well specified and the code is fairly easy to test, I think this would be a good first issue for someone to work on if they wanted, so marking it thusly | 2023-04-19T22:31:46Z | 38.0 | 6099864180b9a42472bd0a0a17d16a1b612902f4 |
apache/arrow-rs | 4,061 | apache__arrow-rs-4061 | [
"3880"
] | a35c6c5f4309787a9a2f523920af2efd9b1682b9 | diff --git a/arrow-arith/src/aggregate.rs b/arrow-arith/src/aggregate.rs
index a9944db13ee1..9ed6dee516a4 100644
--- a/arrow-arith/src/aggregate.rs
+++ b/arrow-arith/src/aggregate.rs
@@ -1241,13 +1241,12 @@ mod tests {
.into_iter()
.collect();
let sliced_input = sliced_input.slice(4, ... | diff --git a/arrow-pyarrow-integration-testing/src/lib.rs b/arrow-pyarrow-integration-testing/src/lib.rs
index cf94b0dd40af..af400868ffa9 100644
--- a/arrow-pyarrow-integration-testing/src/lib.rs
+++ b/arrow-pyarrow-integration-testing/src/lib.rs
@@ -52,7 +52,7 @@ fn double(array: &PyAny, py: Python) -> PyResult<PyObje... | First-Class Array Abstractions
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this fe... | 2023-04-12T11:08:57Z | 37.0 | a35c6c5f4309787a9a2f523920af2efd9b1682b9 | |
apache/arrow-rs | 4,055 | apache__arrow-rs-4055 | [
"4054"
] | ee4003328d6615e011303ba57c24264a3f454e12 | diff --git a/arrow-flight/examples/flight_sql_server.rs b/arrow-flight/examples/flight_sql_server.rs
index 08744b65f7ac..675692aba6f9 100644
--- a/arrow-flight/examples/flight_sql_server.rs
+++ b/arrow-flight/examples/flight_sql_server.rs
@@ -44,9 +44,9 @@ use arrow_flight::{
ActionCreatePreparedStatementReque... | diff --git a/arrow-flight/tests/flight_sql_client_cli.rs b/arrow-flight/tests/flight_sql_client_cli.rs
index 2c54bd263fdb..248b3732ff97 100644
--- a/arrow-flight/tests/flight_sql_client_cli.rs
+++ b/arrow-flight/tests/flight_sql_client_cli.rs
@@ -26,9 +26,9 @@ use arrow_flight::{
CommandGetCatalogs, CommandGet... | Flight SQL Server missing command type.googleapis.com/arrow.flight.protocol.sql.CommandGetXdbcTypeInfo
**Describe the bug**
In the flight SQL servers' get_flight_info method, there currently is no method for the
The command itself is defined here: https://github.com/apache/arrow-rs/blob/6b17775f37b939221d855514db4ff... | 2023-04-11T16:40:59Z | 37.0 | a35c6c5f4309787a9a2f523920af2efd9b1682b9 | |
apache/arrow-rs | 4,045 | apache__arrow-rs-4045 | [
"4044"
] | fec282fd43add7df97ca8f58eb5eaa42eb9c928d | diff --git a/arrow-data/src/equal/union.rs b/arrow-data/src/equal/union.rs
index 4f04bc287aa8..5869afc30dbe 100644
--- a/arrow-data/src/equal/union.rs
+++ b/arrow-data/src/equal/union.rs
@@ -70,7 +70,13 @@ fn equal_sparse(
.iter()
.zip(rhs.child_data())
.all(|(lhs_values, rhs_values)| {
- ... | diff --git a/arrow/tests/array_equal.rs b/arrow/tests/array_equal.rs
index 93296c3b0e43..83a280db67b8 100644
--- a/arrow/tests/array_equal.rs
+++ b/arrow/tests/array_equal.rs
@@ -1155,6 +1155,22 @@ fn test_union_equal_sparse() {
test_equal(&union1, &union4, false);
}
+#[test]
+fn test_union_equal_sparse_slice()... | Sparse UnionArray Equality Incorrect Offset Handling
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
**To Reproduce**
<!--
Steps to reproduce the behavior:
-->
```
#[test]
fn test_union_equal_sparse_slice() {
let mut builder = UnionBuilder::new_sparse();
builder... | 2023-04-10T14:51:17Z | 37.0 | a35c6c5f4309787a9a2f523920af2efd9b1682b9 | |
apache/arrow-rs | 3,994 | apache__arrow-rs-3994 | [
"3991"
] | 4e7bb45050622d5b43505aa64dacf410cb329941 | diff --git a/arrow-cast/src/cast.rs b/arrow-cast/src/cast.rs
index e4f4370fdde5..5d7bea0e9d0f 100644
--- a/arrow-cast/src/cast.rs
+++ b/arrow-cast/src/cast.rs
@@ -145,6 +145,9 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
// decimal to signed numeric
(Decimal128(_, _), N... | diff --git a/arrow/tests/array_cast.rs b/arrow/tests/array_cast.rs
index 2807bbd79b83..96a4f2b41f3c 100644
--- a/arrow/tests/array_cast.rs
+++ b/arrow/tests/array_cast.rs
@@ -185,9 +185,7 @@ fn get_arrays_of_all_types() -> Vec<ArrayRef> {
Arc::new(DurationMillisecondArray::from(vec![1000, 2000])),
Arc... | Support Decimals cast to Utf8/LargeUtf
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for... | I will create a PR today | 2023-03-31T22:07:04Z | 36.0 | 4e7bb45050622d5b43505aa64dacf410cb329941 |
apache/arrow-rs | 3,983 | apache__arrow-rs-3983 | [
"3955"
] | e5a1676950ab5c04b0a74953ec5418da67cedb45 | diff --git a/arrow-array/src/array/binary_array.rs b/arrow-array/src/array/binary_array.rs
index 530f3835ce10..ccce3cda9989 100644
--- a/arrow-array/src/array/binary_array.rs
+++ b/arrow-array/src/array/binary_array.rs
@@ -303,6 +303,7 @@ mod tests {
use super::*;
use crate::{ListArray, StringArray};
use... | diff --git a/arrow-integration-test/src/datatype.rs b/arrow-integration-test/src/datatype.rs
index 5a5dd67fc7a1..47bacc7cc74b 100644
--- a/arrow-integration-test/src/datatype.rs
+++ b/arrow-integration-test/src/datatype.rs
@@ -22,7 +22,7 @@ use std::sync::Arc;
/// Parse a data type from a JSON representation.
pub fn ... | Reduce Cloning of Field
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, ... | This would be a potentially breaking change as https://github.com/apache/arrow-rs/pull/2239 made Schema's fields public...
I believe @tustvold is working on this, so assigning to him | 2023-03-30T14:17:08Z | 36.0 | 4e7bb45050622d5b43505aa64dacf410cb329941 |
apache/arrow-rs | 3,961 | apache__arrow-rs-3961 | [
"3826"
] | 9bd2bae586ed5b0edfd699f89a0855d79f61b611 | diff --git a/arrow-cast/src/cast.rs b/arrow-cast/src/cast.rs
index ba909649da3a..7ff7bcdd09f3 100644
--- a/arrow-cast/src/cast.rs
+++ b/arrow-cast/src/cast.rs
@@ -157,8 +157,9 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
(_, Boolean) => DataType::is_numeric(from_type) || from_ty... | diff --git a/arrow/tests/array_cast.rs b/arrow/tests/array_cast.rs
index 33695e2edeb6..4c1f5019597c 100644
--- a/arrow/tests/array_cast.rs
+++ b/arrow/tests/array_cast.rs
@@ -388,7 +388,7 @@ fn get_all_types() -> Vec<DataType> {
Interval(IntervalUnit::DayTime),
Interval(IntervalUnit::MonthDayNano),
... | Support Casting Between Binary / LargeBinary and FixedSizeBinary
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand... | @tustvold what do you think about casting between UTF8 and FixedSizeBinary? If that is worth it I will file a separate ticket
> what do you think about casting between UTF8 and FixedSizeBinary
Given the cast from UTF8 -> Binary is purely a metadata operation, I see no reason we couldn't support this using the same ... | 2023-03-27T17:05:51Z | 36.0 | 4e7bb45050622d5b43505aa64dacf410cb329941 |
apache/arrow-rs | 3,944 | apache__arrow-rs-3944 | [
"478"
] | 888c1cab7c76f0b28cecdd704c14e42256736def | diff --git a/arrow-schema/src/ffi.rs b/arrow-schema/src/ffi.rs
index 8e58e3158c8b..058febbdd35c 100644
--- a/arrow-schema/src/ffi.rs
+++ b/arrow-schema/src/ffi.rs
@@ -36,7 +36,10 @@
use crate::{ArrowError, DataType, Field, Schema, TimeUnit, UnionMode};
use bitflags::bitflags;
-use std::ffi::{c_char, c_void, CStr, C... | diff --git a/arrow-pyarrow-integration-testing/tests/test_sql.py b/arrow-pyarrow-integration-testing/tests/test_sql.py
index 98564408d937..f631f67cbfea 100644
--- a/arrow-pyarrow-integration-testing/tests/test_sql.py
+++ b/arrow-pyarrow-integration-testing/tests/test_sql.py
@@ -138,6 +138,12 @@ def test_field_roundtrip... | Exchange key-value metadata in the python FFI bridge
The `key_value_metadata` is currently ignored, we should add support for exchanging it for both the schema-like and array objects.
| 2023-03-25T23:27:26Z | 36.0 | 4e7bb45050622d5b43505aa64dacf410cb329941 | |
apache/arrow-rs | 3,930 | apache__arrow-rs-3930 | [
"3929"
] | 5eeccab922c377a18e54cf39ad49a2e4d54ffaf2 | diff --git a/arrow-arith/src/aggregate.rs b/arrow-arith/src/aggregate.rs
index 9e9d9333fdcb..a9944db13ee1 100644
--- a/arrow-arith/src/aggregate.rs
+++ b/arrow-arith/src/aggregate.rs
@@ -1219,13 +1219,12 @@ mod tests {
.into_iter()
.collect();
let sliced_input = sliced_input.slice(4, ... | diff --git a/arrow/tests/array_validation.rs b/arrow/tests/array_validation.rs
index 7e45ee7afcda..6c4249e38c58 100644
--- a/arrow/tests/array_validation.rs
+++ b/arrow/tests/array_validation.rs
@@ -941,9 +941,7 @@ fn test_try_new_sliced_struct() {
let struct_array = builder.finish();
let struct_array_slice... | Strongly Typed Array Slicing
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feat... | 2023-03-24T11:14:08Z | 35.0 | 5eeccab922c377a18e54cf39ad49a2e4d54ffaf2 | |
apache/arrow-rs | 3,913 | apache__arrow-rs-3913 | [
"3889"
] | 526c57a0f65ee7aaa838f252f48c8179f7d9ce03 | diff --git a/CHANGELOG-old.md b/CHANGELOG-old.md
index 2d7903e96a7d..8ddd7c6b6619 100644
--- a/CHANGELOG-old.md
+++ b/CHANGELOG-old.md
@@ -19,6 +19,74 @@
# Historical Changelog
+## [35.0.0](https://github.com/apache/arrow-rs/tree/35.0.0) (2023-03-10)
+
+[Full Changelog](https://github.com/apache/arrow-rs/compare/3... | diff --git a/arrow-integration-test/Cargo.toml b/arrow-integration-test/Cargo.toml
index ca14401b6899..61ffae23fbe7 100644
--- a/arrow-integration-test/Cargo.toml
+++ b/arrow-integration-test/Cargo.toml
@@ -17,7 +17,7 @@
[package]
name = "arrow-integration-test"
-version = "35.0.0"
+version = "36.0.0"
description ... | Release 36.0.0 of arrow/arrow-flight/parquet/parquet-derive (next release after 35.0.0)
Follow on from https://github.com/apache/arrow-rs/issues/3830
- Planned Release Candidate: 2023-03-25
- Planned Release and Publish to crates.io: 2023-03-27
Items (from [dev/release/README.md](https://github.com/apache/arrow... | This release will include fixes for:
- [x] https://github.com/apache/arrow-rs/issues/3859
- [x] https://github.com/apache/arrow-rs/issues/3861
- [x] https://github.com/apache/arrow-rs/issues/3859
Also https://github.com/apache/arrow-rs/pull/3902 | 2023-03-23T14:15:03Z | 35.0 | 5eeccab922c377a18e54cf39ad49a2e4d54ffaf2 |
apache/arrow-rs | 3,878 | apache__arrow-rs-3878 | [
"3864"
] | 0df21883cb7a5f414894a833ae301fcd8d8e464c | diff --git a/parquet/src/data_type.rs b/parquet/src/data_type.rs
index 40d54c78ed1d..48ee7f89fc5d 100644
--- a/parquet/src/data_type.rs
+++ b/parquet/src/data_type.rs
@@ -199,6 +199,16 @@ impl From<Vec<u8>> for ByteArray {
}
}
+impl<'a> From<&'a [u8]> for ByteArray {
+ fn from(b: &'a [u8]) -> ByteArray {
+ ... | diff --git a/parquet_derive_test/src/lib.rs b/parquet_derive_test/src/lib.rs
index 746644793ff2..2aa174974aba 100644
--- a/parquet_derive_test/src/lib.rs
+++ b/parquet_derive_test/src/lib.rs
@@ -42,6 +42,11 @@ struct ACompleteRecord<'a> {
pub borrowed_maybe_a_string: &'a Option<String>,
pub borrowed_maybe_a_s... | parquet_derive doesn't support Vec<u8>
**Describe the bug**
When I attempt to `#[derive(ParquetRecordWriter)]` on a struct that contains fields of type `Vec<u8>`, the proc-macro panics.
**To Reproduce**
```
#[derive(ParquetRecordWriter)]
pub struct Row {
foo: Vec<u8>,
}
```
results in
```
message: no... | 2023-03-17T00:10:25Z | 35.0 | 5eeccab922c377a18e54cf39ad49a2e4d54ffaf2 | |
apache/arrow-rs | 3,836 | apache__arrow-rs-3836 | [
"3830"
] | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d | diff --git a/arrow-arith/Cargo.toml b/arrow-arith/Cargo.toml
index 6b3d82c9c906..4360332d9c7a 100644
--- a/arrow-arith/Cargo.toml
+++ b/arrow-arith/Cargo.toml
@@ -17,7 +17,7 @@
[package]
name = "arrow-arith"
-version = "34.0.0"
+version = "35.0.0"
description = "Arrow arithmetic kernels"
homepage = "https://githu... | diff --git a/arrow-integration-test/Cargo.toml b/arrow-integration-test/Cargo.toml
index 2d92e6292ded..ca14401b6899 100644
--- a/arrow-integration-test/Cargo.toml
+++ b/arrow-integration-test/Cargo.toml
@@ -17,7 +17,7 @@
[package]
name = "arrow-integration-test"
-version = "34.0.0"
+version = "35.0.0"
description ... | Release 35.0.0 of arrow/arrow-flight/parquet/parquet-derive (next release after 34.0.0)
Follow on from https://github.com/apache/arrow-rs/issues/3755
- Planned Release Candidate: 2023-03-10
- Planned Release and Publish to crates.io: 2023-03-13
Items (from [dev/release/README.md](https://github.com/apache/arrow... | 2023-03-09T22:34:44Z | 34.0 | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d | |
apache/arrow-rs | 3,816 | apache__arrow-rs-3816 | [
"3814"
] | 1883bb691a33c39ce13e355e7f0a82414fc74010 | diff --git a/arrow-flight/Cargo.toml b/arrow-flight/Cargo.toml
index f1cd7d4fb23b..db9f0a023bf4 100644
--- a/arrow-flight/Cargo.toml
+++ b/arrow-flight/Cargo.toml
@@ -60,6 +60,7 @@ cli = ["arrow/prettyprint", "clap", "tracing-log", "tracing-subscriber", "tonic/
[dev-dependencies]
arrow = { version = "34.0.0", path ... | diff --git a/arrow-flight/tests/flight_sql_client_cli.rs b/arrow-flight/tests/flight_sql_client_cli.rs
new file mode 100644
index 000000000000..2c54bd263fdb
--- /dev/null
+++ b/arrow-flight/tests/flight_sql_client_cli.rs
@@ -0,0 +1,545 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri... | FlightSQL CLI client: simple test
Let's ave a simple integration test for the FlightSQL CLI client that connects to a server that returns 2 endpoints (both pointing to itself) and prints out the record batches. The setup can be used to test more upcoming features.
| self-assign | 2023-03-07T15:11:34Z | 34.0 | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d |
apache/arrow-rs | 3,811 | apache__arrow-rs-3811 | [
"3779"
] | 3df7c00a358cff34da8bacd819e791892755d3a9 | diff --git a/arrow-flight/src/encode.rs b/arrow-flight/src/encode.rs
index 2e93acb0931c..557663922121 100644
--- a/arrow-flight/src/encode.rs
+++ b/arrow-flight/src/encode.rs
@@ -323,7 +323,7 @@ fn prepare_schema_for_flight(schema: &Schema) -> Schema {
})
.collect();
- Schema::new(fields)
+ Sc... | diff --git a/arrow-flight/tests/encode_decode.rs b/arrow-flight/tests/encode_decode.rs
index 25e74cb3b6bc..8c73a516b2b0 100644
--- a/arrow-flight/tests/encode_decode.rs
+++ b/arrow-flight/tests/encode_decode.rs
@@ -17,7 +17,7 @@
//! Tests for round trip encoding / decoding
-use std::sync::Arc;
+use std::{collectio... | Schema-level metadata is not encoded in Flight responses
**Describe the bug**
When preparing schema for encoding into a Flight response, the schema-level metadata from the source schema is dropped:
https://github.com/apache/arrow-rs/blob/e7eb304dac442a943c434f8ea248de909f82aa88/arrow-flight/src/encode.rs#L326
... | @alamb I can confirm that with this patch:
```patch
Index: arrow-flight/src/encode.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/arrow-flight/src/encode.rs b/arrow-flight/src/encode.rs... | 2023-03-07T05:35:13Z | 34.0 | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d |
apache/arrow-rs | 3,805 | apache__arrow-rs-3805 | [
"2900"
] | 7eb588d7a9cee6516d53be6228130eda24810d37 | diff --git a/arrow-cast/src/parse.rs b/arrow-cast/src/parse.rs
index a48dd2bac7d2..f498bf142bd7 100644
--- a/arrow-cast/src/parse.rs
+++ b/arrow-cast/src/parse.rs
@@ -16,7 +16,8 @@
// under the License.
use arrow_array::types::*;
-use arrow_array::ArrowPrimitiveType;
+use arrow_array::{ArrowNativeTypeOp, ArrowPrimi... | diff --git a/arrow-json/test/data/basic.json b/arrow-json/test/data/basic.json
index 556c39c46be9..8de246e1ac28 100644
--- a/arrow-json/test/data/basic.json
+++ b/arrow-json/test/data/basic.json
@@ -1,12 +1,12 @@
-{"a":1, "b":2.0, "c":false, "d":"4", "e":"1970-1-2"}
-{"a":-10, "b":-3.5, "c":true, "d":"4", "e": "1969-12... | Support reading DecimalArray from JSON data
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The JSON reader doesn't support producing DecimalArray types. I have a `TODO: this is incomplete` that I left on the reader 2 years ago, which was from when DecimalArr... | #2580 is possibly related / could share some logic | 2023-03-05T21:48:49Z | 34.0 | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d |
apache/arrow-rs | 3,786 | apache__arrow-rs-3786 | [
"3785"
] | 7852e763fea66b33a2766b6d6421cafcf6a58c29 | diff --git a/parquet/src/bin/parquet-read.rs b/parquet/src/bin/parquet-read.rs
index c1e08387a550..a8a835ab870d 100644
--- a/parquet/src/bin/parquet-read.rs
+++ b/parquet/src/bin/parquet-read.rs
@@ -45,7 +45,7 @@ use std::{fs::File, path::Path};
#[derive(Debug, Parser)]
#[clap(author, version, about("Binary file to r... | diff --git a/parquet/pytest/test_parquet_integration.py b/parquet/pytest/test_parquet_integration.py
index 268caa8fab06..e0846d4e779f 100755
--- a/parquet/pytest/test_parquet_integration.py
+++ b/parquet/pytest/test_parquet_integration.py
@@ -68,15 +68,13 @@ def get_show_filter_cli_output(output_dir, data, col_name="id... | Make Parquet CLI args consistent
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The current input argument format is inconsistent across CLI tools. E.g., parquet-layout does not need passing "-f" or "--file" for the input file name. This should be consisten... | 2023-03-02T07:44:29Z | 34.0 | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d | |
apache/arrow-rs | 3,778 | apache__arrow-rs-3778 | [
"3775"
] | e7eb304dac442a943c434f8ea248de909f82aa88 | diff --git a/arrow-arith/src/aggregate.rs b/arrow-arith/src/aggregate.rs
index b578dbd4a94c..7777bb0ede43 100644
--- a/arrow-arith/src/aggregate.rs
+++ b/arrow-arith/src/aggregate.rs
@@ -117,8 +117,8 @@ where
.map(|i| unsafe { array.value_unchecked(i) })
.reduce(|acc, item| if cmp(&acc, &item)... | diff --git a/arrow/tests/array_validation.rs b/arrow/tests/array_validation.rs
index 3cdec46b59a0..7e45ee7afcda 100644
--- a/arrow/tests/array_validation.rs
+++ b/arrow/tests/array_validation.rs
@@ -943,17 +943,7 @@ fn test_try_new_sliced_struct() {
let struct_array_slice = struct_array.slice(1, 3);
let struc... | Use NullBuffer in ArrayData
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feat... | 2023-02-28T19:13:58Z | 34.0 | 495682aa72ffe92bbd0d6d8d93e0c00b5483ff7d | |
apache/arrow-rs | 3,757 | apache__arrow-rs-3757 | [
"3755"
] | 9699e1df7c7e0b83c8ec8be6678ee17d77a17f47 | diff --git a/CHANGELOG-old.md b/CHANGELOG-old.md
index 9ac8cb530456..9b9df494efb2 100644
--- a/CHANGELOG-old.md
+++ b/CHANGELOG-old.md
@@ -19,6 +19,79 @@
# Historical Changelog
+## [33.0.0](https://github.com/apache/arrow-rs/tree/33.0.0) (2023-02-10)
+
+[Full Changelog](https://github.com/apache/arrow-rs/compare/3... | diff --git a/arrow-integration-test/Cargo.toml b/arrow-integration-test/Cargo.toml
index f9ca4297e6e7..2d92e6292ded 100644
--- a/arrow-integration-test/Cargo.toml
+++ b/arrow-integration-test/Cargo.toml
@@ -17,7 +17,7 @@
[package]
name = "arrow-integration-test"
-version = "33.0.0"
+version = "34.0.0"
description ... | Release 34.0.0 of arrow/arrow-flight/parquet/parquet-derive (next release after 33.0.0)
Follow on from https://github.com/apache/arrow-rs/issues/3682
- Planned Release Candidate: 2023-02-24
- Planned Release and Publish to crates.io: 2023-02-27
Items (from [dev/release/README.md](https://github.com/apache/arrow-... | 2023-02-23T14:49:12Z | 33.0 | 9699e1df7c7e0b83c8ec8be6678ee17d77a17f47 | |
apache/arrow-rs | 3,686 | apache__arrow-rs-3686 | [
"3682"
] | bb4fc59009e7c5861a6b1967a53e9daa2554d5c6 | diff --git a/CHANGELOG-old.md b/CHANGELOG-old.md
index 65a95579e9f8..9ac8cb530456 100644
--- a/CHANGELOG-old.md
+++ b/CHANGELOG-old.md
@@ -19,6 +19,81 @@
# Historical Changelog
+## [32.0.0](https://github.com/apache/arrow-rs/tree/32.0.0) (2023-01-27)
+
+[Full Changelog](https://github.com/apache/arrow-rs/compare/3... | diff --git a/arrow-integration-test/Cargo.toml b/arrow-integration-test/Cargo.toml
index 35b088b1636f..f9ca4297e6e7 100644
--- a/arrow-integration-test/Cargo.toml
+++ b/arrow-integration-test/Cargo.toml
@@ -17,7 +17,7 @@
[package]
name = "arrow-integration-test"
-version = "32.0.0"
+version = "33.0.0"
description ... | Release 33.0.0 of arrow/arrow-flight/parquet/parquet-derive (next release after 32.0.0)
Follow on from https://github.com/apache/arrow-rs/issues/3584
- Planned Release Candidate: 2023-02-10
- Planned Release and Publish to crates.io: 2023-02-13
Items (from [dev/release/README.md](https://github.com/apache/arrow... | Hmm that's not a bug.
@alamb On it. :)
Thanks @iajoiner -- FYI @tustvold
@alamb You’re welcome! Will finish in an hour. | 2023-02-09T23:31:50Z | 32.0 | bb4fc59009e7c5861a6b1967a53e9daa2554d5c6 |
apache/arrow-rs | 3,673 | apache__arrow-rs-3673 | [
"3664"
] | b79f27b512d46715e9881e34fe4bb525b88fef9d | diff --git a/arrow-cast/src/cast.rs b/arrow-cast/src/cast.rs
index 69e42a5485e6..010c77c22455 100644
--- a/arrow-cast/src/cast.rs
+++ b/arrow-cast/src/cast.rs
@@ -168,7 +168,7 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
| Time32(TimeUnit::Millisecond)
| Time64(... | diff --git a/arrow/tests/array_cast.rs b/arrow/tests/array_cast.rs
index ae73b1b4200b..55719a6c7187 100644
--- a/arrow/tests/array_cast.rs
+++ b/arrow/tests/array_cast.rs
@@ -97,7 +97,7 @@ fn test_can_cast_types() {
/// Create instances of arrays with varying types for cast tests
fn get_arrays_of_all_types() -> Vec... | Support UTF8 cast to Timestamp with timezone
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Support cast UTF8 to Timestamp with time zone
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps ... | @viirya @waitingkuo @alamb please assign this issue to me
```
let valid = StringArray::from(vec![
"2023-01-01 04:05:06.789-8",
"2023-01-01 04:05:06.789-7",
]);
let array = Arc::new(valid) as ArrayRef;
let b = cast(&array, &DataType::Timestamp(TimeUnit::Nan... | 2023-02-07T19:06:14Z | 32.0 | bb4fc59009e7c5861a6b1967a53e9daa2554d5c6 |
apache/arrow-rs | 3,602 | apache__arrow-rs-3602 | [
"3599"
] | f0be9da82cbd76da3042b426daf6c424c9560d93 | diff --git a/arrow-arith/src/aggregate.rs b/arrow-arith/src/aggregate.rs
index a1cf8d84954c..b578dbd4a94c 100644
--- a/arrow-arith/src/aggregate.rs
+++ b/arrow-arith/src/aggregate.rs
@@ -1072,7 +1072,8 @@ mod tests {
#[test]
fn test_string_min_max_all_nulls() {
- let a = StringArray::from(vec![None, ... | diff --git a/arrow/tests/array_transform.rs b/arrow/tests/array_transform.rs
index 3c08a592dd2c..34ef6cbae428 100644
--- a/arrow/tests/array_transform.rs
+++ b/arrow/tests/array_transform.rs
@@ -433,7 +433,8 @@ fn test_struct_nulls() {
let data = mutable.freeze();
let array = StructArray::from(data);
- l... | There should be a `From<Vec<Option<String>>>` impl for `GenericStringArray<OffsetSize>`
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
I have a `Vec<Option<String>>`, and I want it to be a `StringArray`. Right now the only relevant impls to do this are:
*... | Makes sense to me, would be happy to review a PR that implemented this.
FWIW from_iter should work I think | 2023-01-25T14:09:57Z | 31.0 | f0be9da82cbd76da3042b426daf6c424c9560d93 |
apache/arrow-rs | 3,557 | apache__arrow-rs-3557 | [
"3552"
] | 3ae1c728b266c1ba801409eb7f4b901285783e94 | diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
index 8719cba0effe..ee926ee52868 100644
--- a/arrow/Cargo.toml
+++ b/arrow/Cargo.toml
@@ -61,7 +61,7 @@ arrow-string = { version = "31.0.0", path = "../arrow-string" }
rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional = true }... | diff --git a/arrow-pyarrow-integration-testing/Cargo.toml b/arrow-pyarrow-integration-testing/Cargo.toml
index e1fa90836f61..7a2dc563a1ac 100644
--- a/arrow-pyarrow-integration-testing/Cargo.toml
+++ b/arrow-pyarrow-integration-testing/Cargo.toml
@@ -33,7 +33,7 @@ crate-type = ["cdylib"]
[dependencies]
arrow = { pa... | Update pyo3 requirement from 0.17 to 0.18
Updates the requirements on [pyo3](https://github.com/pyo3/pyo3) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pyo3/pyo3/releases">pyo3's releases</a>.</em></p>
<blockquote>
<h2>PyO3 0.18.0</h2>
<p>This ... | 2023-01-18T18:37:59Z | 31.0 | f0be9da82cbd76da3042b426daf6c424c9560d93 | |
apache/arrow-rs | 3,542 | apache__arrow-rs-3542 | [
"1179"
] | d938cd9bf621c9bf3c3bd9e33c4c0a5eb4060534 | diff --git a/arrow-cast/src/cast.rs b/arrow-cast/src/cast.rs
index c54761840167..c60e660378aa 100644
--- a/arrow-cast/src/cast.rs
+++ b/arrow-cast/src/cast.rs
@@ -151,13 +151,16 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
(_, Decimal256(_, _)) => false,
(Struct(_), _) ... | diff --git a/arrow/tests/array_cast.rs b/arrow/tests/array_cast.rs
index ff6fbad099cb..ae73b1b4200b 100644
--- a/arrow/tests/array_cast.rs
+++ b/arrow/tests/array_cast.rs
@@ -421,7 +421,9 @@ fn get_all_types() -> Vec<DataType> {
vec![
Dictionary(Box::new(key_type.clone()), Box::new(Int32))... | Support casting to/from DictionaryArray <--> LargeUTF8, Binary and LargeBinary in Cast Kernels
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Currently if you try to cast a LargeStringArray, BinaryArray or LargeBinaryArray into a dictionary an error is retur... | Specifically, we would like to add support to the cast and cast_with_options kernels:
https://docs.rs/arrow/20.0.0/arrow/compute/kernels/cast/index.html
https://docs.rs/arrow/20.0.0/arrow/compute/kernels/cast/fn.cast_with_options.html | 2023-01-17T08:40:14Z | 31.0 | f0be9da82cbd76da3042b426daf6c424c9560d93 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.