repo string | pull_number int64 | instance_id string | issue_numbers list | base_commit string | patch string | test_patch string | problem_statement string | hints_text string | created_at string | version string | updated_at string | environment_setup_commit string | FAIL_TO_PASS list | PASS_TO_PASS list | FAIL_TO_FAIL list | PASS_TO_FAIL list | source_dir string |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
bevyengine/bevy | 15,166 | bevyengine__bevy-15166 | [
"15105",
"15105"
] | 8bfe635c3e119fa9324ba738ac11d30e7b988ac1 | diff --git a/crates/bevy_ecs/src/system/commands/mod.rs b/crates/bevy_ecs/src/system/commands/mod.rs
--- a/crates/bevy_ecs/src/system/commands/mod.rs
+++ b/crates/bevy_ecs/src/system/commands/mod.rs
@@ -1017,13 +1017,36 @@ impl EntityCommands<'_> {
///
/// # Panics
///
+ /// The command will panic whe... | diff --git a/crates/bevy_ecs/src/system/commands/mod.rs b/crates/bevy_ecs/src/system/commands/mod.rs
--- a/crates/bevy_ecs/src/system/commands/mod.rs
+++ b/crates/bevy_ecs/src/system/commands/mod.rs
@@ -1684,6 +1753,45 @@ mod tests {
assert_eq!(results3, vec![(42u32, 0u64), (0u32, 42u64)]);
}
+ #[tes... | Add missing insert APIs for predicates
## What problem does this solve or what need does it fill?
For consistency, we are missing the following methods:
- `insert_if_new_and` (`insert_if_new` + `insert_if`)
- `try_insert_if_new_and` (`try_insert` +`insert_if_new` + `insert_if`)
## Additional context
https... | 2024-09-11T20:27:48Z | 1.79 | 2024-09-16T23:16:19Z | 612897becd415b7b982f58bd76deb719b42c9790 | [
"change_detection::tests::as_deref_mut",
"change_detection::tests::mut_from_non_send_mut",
"bundle::tests::component_hook_order_spawn_despawn_with_macro_hooks",
"bundle::tests::component_hook_order_spawn_despawn",
"bundle::tests::component_hook_order_replace",
"bundle::tests::component_hook_order_insert_r... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 14,631 | bevyengine__bevy-14631 | [
"14629"
] | fc2f564c6f205163b8ba0f3a0bd40fe20739fa7a | diff --git a/crates/bevy_ecs/src/observer/runner.rs b/crates/bevy_ecs/src/observer/runner.rs
--- a/crates/bevy_ecs/src/observer/runner.rs
+++ b/crates/bevy_ecs/src/observer/runner.rs
@@ -375,8 +375,7 @@ fn observer_system_runner<E: Event, B: Bundle>(
};
// TODO: Move this check into the observer cache to av... | diff --git a/crates/bevy_ecs/src/query/state.rs b/crates/bevy_ecs/src/query/state.rs
--- a/crates/bevy_ecs/src/query/state.rs
+++ b/crates/bevy_ecs/src/query/state.rs
@@ -1779,7 +1790,7 @@ mod tests {
world.spawn((A(1), B(0)));
let query_state = world.query::<(&A, &B)>();
- let mut new_query_... | `Query::transmute`/`Query::transmute_filtered` accept any `&Components` parameter and this is unsound
## Bevy version
Both 0.14.1 and c1c003d
## What you did
```rs
#[derive(Component)]
struct A(u32);
#[derive(Component)]
struct B(u32);
let mut world = World::new();
world.spawn((A(1), B(2)));
let... | 2024-08-05T13:52:48Z | 1.79 | 2024-08-06T06:15:03Z | 612897becd415b7b982f58bd76deb719b42c9790 | [
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::mut_new",
"change_detection::tests::as_deref_mut",
"bundle::tests::component_hook_order_spawn_despawn_with_macro_hooks",
"change_detection::tests::... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 14,539 | bevyengine__bevy-14539 | [
"12139"
] | ba09f354745b1c4420e6e316d80ac97c9eb37f56 | diff --git a/crates/bevy_ecs/src/entity/mod.rs b/crates/bevy_ecs/src/entity/mod.rs
--- a/crates/bevy_ecs/src/entity/mod.rs
+++ b/crates/bevy_ecs/src/entity/mod.rs
@@ -142,7 +142,7 @@ type IdCursor = isize;
/// [`Query::get`]: crate::system::Query::get
/// [`World`]: crate::world::World
/// [SemVer]: https://semver.o... | diff --git a/crates/bevy_ecs/src/entity/mod.rs b/crates/bevy_ecs/src/entity/mod.rs
--- a/crates/bevy_ecs/src/entity/mod.rs
+++ b/crates/bevy_ecs/src/entity/mod.rs
@@ -1152,6 +1188,15 @@ mod tests {
}
}
+ #[test]
+ fn entity_debug() {
+ let entity = Entity::from_raw(42);
+ let string ... | Inconsistency between `Debug` and serialized representation of `Entity`
## Bevy version
0.13
## What went wrong
There is an inconsistency between the `Debug` representation of an `Entity`:
```rust
impl fmt::Debug for Entity {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f... | Ah: I know what we should do. The serialized representation should stay the same, optimized for information density. This is just an opaque identifier. However, we should make the debug representation more verbose, and report `index`, `generation` and `raw_bits` separately.
In the future, we will be packing more inf... | 2024-07-30T17:39:55Z | 1.79 | 2024-08-04T06:18:41Z | 612897becd415b7b982f58bd76deb719b42c9790 | [
"entity::tests::entity_debug"
] | [
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::mut_untyped_from_mut",
"change_detection::tests::mut_new",
"change_detection::tests::as_deref_mut",
"change_detection::tests::mut_untyped_to_reflec... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 14,380 | bevyengine__bevy-14380 | [
"14378"
] | a8530ebbc83f6f53751bfbcfc128db0764a5d2b3 | diff --git a/crates/bevy_reflect/src/array.rs b/crates/bevy_reflect/src/array.rs
--- a/crates/bevy_reflect/src/array.rs
+++ b/crates/bevy_reflect/src/array.rs
@@ -74,6 +74,11 @@ pub trait Array: PartialReflect {
values: self.iter().map(PartialReflect::clone_value).collect(),
}
}
+
+ /// Wi... | diff --git a/crates/bevy_reflect/src/lib.rs b/crates/bevy_reflect/src/lib.rs
--- a/crates/bevy_reflect/src/lib.rs
+++ b/crates/bevy_reflect/src/lib.rs
@@ -1864,6 +1864,41 @@ mod tests {
assert!(info.is::<MyValue>());
}
+ #[test]
+ fn get_represented_kind_info() {
+ #[derive(Reflect)]
+ ... | bevy_reflect: Consider API for getting kind info
## What problem does this solve or what need does it fill?
Let's say I have this:
```rust
if let bevy_reflect::ReflectMut::Struct(s) = reflected.reflect_mut() {
let Some(bevy_reflect::TypeInfo::Struct(info)) = s.get_represented_type_info() else {
return;
... | Seems reasonable. Want to put together a PR?
Yeah this would be a good improvement. Although, rather than `get_kind_info` maybe we should call it `get_represented_kind_info` since it's the info of the represented type that we want (and for parity with the method on `Reflect`).
> Seems reasonable. Want to put together a... | 2024-07-18T17:37:45Z | 1.81 | 2024-10-15T02:25:58Z | 60b2c7ce7755a49381c5265021ff175d3624218c | [
"array::tests::next_index_increment",
"attributes::tests::should_allow_unit_struct_attribute_values",
"attributes::tests::should_accept_last_attribute",
"attributes::tests::should_derive_custom_attributes_on_struct_container",
"attributes::tests::should_debug_custom_attributes",
"attributes::tests::should... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 8,040 | bevyengine__bevy-8040 | [
"8034"
] | ee0e6f485575952fb51d38f807f60907272e1d44 | diff --git a/crates/bevy_render/src/color/mod.rs b/crates/bevy_render/src/color/mod.rs
--- a/crates/bevy_render/src/color/mod.rs
+++ b/crates/bevy_render/src/color/mod.rs
@@ -525,7 +525,7 @@ impl Color {
let [red, green, blue] =
LchRepresentation::lch_to_nonlinear_srgb(*lightness, ... | diff --git a/crates/bevy_render/src/color/mod.rs b/crates/bevy_render/src/color/mod.rs
--- a/crates/bevy_render/src/color/mod.rs
+++ b/crates/bevy_render/src/color/mod.rs
@@ -1858,4 +1858,22 @@ mod tests {
assert_eq!(starting_color * transformation, mutated_color,);
}
+
+ // regression test for https... | Crash when setting background color via Color::Lcha
## Bevy version
0.10.0
## \[Optional\] Relevant system information
rustc 1.68.0
SystemInfo { os: "Linux 22.0.4 Manjaro Linux", kernel: "5.15.94-1-MANJARO", cpu: "AMD Ryzen 7 2700X Eight-Core Processor", core_count: "8", memory: "15.6 GiB" }
AdapterInfo { na... | There is a wrong return value in Color::as_rgba_linear. I make a PR | 2023-03-11T10:56:59Z | 1.67 | 2023-03-11T12:32:56Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"color::tests::convert_to_rgba_linear"
] | [
"mesh::mesh::conversions::tests::vec3a",
"color::tests::mul_and_mulassign_f32",
"primitives::tests::intersects_sphere_big_frustum_outside",
"mesh::mesh::conversions::tests::correct_message",
"color::tests::mul_and_mulassign_f32by3",
"color::colorspace::test::lch_to_srgb",
"color::colorspace::test::srgb_... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 8,014 | bevyengine__bevy-8014 | [
"7989"
] | 7d9cb1c4ab210595c5228af0ed4ec7d095241db5 | diff --git a/crates/bevy_reflect/bevy_reflect_derive/src/from_reflect.rs b/crates/bevy_reflect/bevy_reflect_derive/src/from_reflect.rs
--- a/crates/bevy_reflect/bevy_reflect_derive/src/from_reflect.rs
+++ b/crates/bevy_reflect/bevy_reflect_derive/src/from_reflect.rs
@@ -3,7 +3,7 @@ use crate::derive_data::ReflectEnum;
... | diff --git /dev/null b/crates/bevy_reflect_compile_fail_tests/tests/reflect_derive/bounds.pass.rs
new file mode 100644
--- /dev/null
+++ b/crates/bevy_reflect_compile_fail_tests/tests/reflect_derive/bounds.pass.rs
@@ -0,0 +1,282 @@
+use bevy_reflect::prelude::*;
+
+fn main() {}
+
+#[derive(Default)]
+struct NonReflect;... | Issue with specific reflect breaking after upgrading from 0.9-0.10
## Bevy 0.10
0.10
## What you did
Upgraded from bevy 0.9 -> 0.10
## What went wrong
The following code has stopped compiling:
```rust
use bevy::{reflect::Reflect, utils::HashSet};
#[derive(Default, Clone, Reflect, serde::Serialize, s... | After expanding the macro I think I've found the issue:
The emitted version of the macro (one example)
```rust
#[allow(unused_mut)]
impl <T>bevy::reflect::GetTypeRegistration for NetSet<T>where T:'static+Send+Sync+Eq+Copy+core::hash::Hash HashSet<T> :bevy::reflect::Reflect,{
fn get_type_registration() -> bevy:... | 2023-03-10T06:47:15Z | 1.67 | 2023-03-27T22:06:30Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"tests/reflect_derive/bounds.pass.rs [should pass]",
"test"
] | [
"tests/reflect_derive/generics.fail.rs [should fail to compile]",
"tests/reflect_derive/generics_structs.pass.rs [should pass]",
"tests/reflect_derive/lifetimes.pass.rs [should pass]"
] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 8,012 | bevyengine__bevy-8012 | [
"8010"
] | 2d5ef75c9fc93cbb301c4b0d19f73b8864694be9 | diff --git a/crates/bevy_ecs/macros/src/fetch.rs b/crates/bevy_ecs/macros/src/fetch.rs
--- a/crates/bevy_ecs/macros/src/fetch.rs
+++ b/crates/bevy_ecs/macros/src/fetch.rs
@@ -1,9 +1,10 @@
+use bevy_macro_utils::ensure_no_collision;
use proc_macro::TokenStream;
use proc_macro2::{Ident, Span};
use quote::{quote, ToTok... | diff --git a/crates/bevy_ecs/src/query/fetch.rs b/crates/bevy_ecs/src/query/fetch.rs
--- a/crates/bevy_ecs/src/query/fetch.rs
+++ b/crates/bevy_ecs/src/query/fetch.rs
@@ -1388,3 +1388,37 @@ unsafe impl<Q: WorldQuery> WorldQuery for NopWorldQuery<Q> {
/// SAFETY: `NopFetch` never accesses any data
unsafe impl<Q: Wor... | WorldQuery derive State and Fetch types are still accidentally nameable
## Bevy version
Latest commit as of writing ([`7d9cb1c`](https://github.com/bevyengine/bevy/commit/7d9cb1c4ab210595c5228af0ed4ec7d095241db5))
## What you did
```rust
#[derive(WorldQuery)]
pub struct Client<S: ClientState> {
pub stat... | Interesting, I'll look into this. Not sure if there's a clean way of solving this, but it should at least be possible to *check* for this footgun and emit a descriptive error message. | 2023-03-10T04:12:11Z | 1.67 | 2023-03-22T16:42:32Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::mut_new",
"entity::tests::entity_bits_roundtrip",
"entity::tests::entity_const",
"change_detection::tests::set_if_neq",
"entity::tests::reserve_e... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 7,931 | bevyengine__bevy-7931 | [
"6497"
] | d3df04cb4c8d94cb06780a777cc6712fa4a316dd | diff --git a/crates/bevy_ecs/src/change_detection.rs b/crates/bevy_ecs/src/change_detection.rs
--- a/crates/bevy_ecs/src/change_detection.rs
+++ b/crates/bevy_ecs/src/change_detection.rs
@@ -537,6 +537,41 @@ pub struct Mut<'a, T: ?Sized> {
pub(crate) ticks: TicksMut<'a>,
}
+impl<'a, T: ?Sized> Mut<'a, T> {
+ ... | diff --git a/crates/bevy_ecs/src/change_detection.rs b/crates/bevy_ecs/src/change_detection.rs
--- a/crates/bevy_ecs/src/change_detection.rs
+++ b/crates/bevy_ecs/src/change_detection.rs
@@ -827,6 +862,26 @@ mod tests {
assert_eq!(4, into_mut.ticks.change_tick);
}
+ #[test]
+ fn mut_new() {
+ ... | Expose a public constructor for `Mut`
## What problem does this solve or what need does it fill?
While ordinarily `Mut` should not be constructed directly by users (and instead should be retrieved via querying), it can be very useful when writing bevy-external tests.
## What solution would you like?
Create a `... | 2023-03-06T16:52:34Z | 1.67 | 2023-04-05T14:22:14Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_non_send_mut",
"entity::tests::entity_bits_roundtrip",
"entity::tests::entity_const",
"change_detection::tests::set_if_neq",
"entity::tests::get_reserved_and_invalid",
"entity::tests::re... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 7,454 | bevyengine__bevy-7454 | [
"7429"
] | 84de9e7f28bfaaba8e0eef4ecf185ce795add9e2 | diff --git a/crates/bevy_reflect/src/impls/std.rs b/crates/bevy_reflect/src/impls/std.rs
--- a/crates/bevy_reflect/src/impls/std.rs
+++ b/crates/bevy_reflect/src/impls/std.rs
@@ -1219,6 +1219,178 @@ impl FromReflect for Cow<'static, str> {
}
}
+impl<T: PathOnly> PathOnly for [T] where [T]: ToOwned {}
+
+impl<T:... | diff --git a/crates/bevy_reflect/src/lib.rs b/crates/bevy_reflect/src/lib.rs
--- a/crates/bevy_reflect/src/lib.rs
+++ b/crates/bevy_reflect/src/lib.rs
@@ -550,8 +550,12 @@ mod tests {
ser::{to_string_pretty, PrettyConfig},
Deserializer,
};
- use std::fmt::{Debug, Formatter};
- use std::{any... | bevy_reflect: Support Cow<'static, [T]>
## What problem does this solve or what need does it fill?
At present, only `Cow<'static, str>` implements `Reflect`. However, `Cow` has another use: `Cow<'static, [T]>` for owned or borrowed lists.
## What solution would you like?
Implement `Reflect` and all other assoc... | 2023-02-01T01:50:05Z | 1.70 | 2023-06-19T15:25:35Z | 6f27e0e35faffbf2b77807bb222d3d3a9a529210 | [
"enums::tests::applying_non_enum_should_panic - should panic",
"enums::tests::enum_should_allow_struct_fields",
"enums::tests::enum_should_allow_nesting_enums",
"enums::tests::dynamic_enum_should_set_variant_fields",
"enums::tests::dynamic_enum_should_change_variant",
"enums::tests::enum_should_allow_gene... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 1,070 | bevyengine__bevy-1070 | [
"1036"
] | 51650f114fbf31fc89db7bd69542dc21edf2dcb7 | diff --git a/crates/bevy_ui/src/focus.rs b/crates/bevy_ui/src/focus.rs
--- a/crates/bevy_ui/src/focus.rs
+++ b/crates/bevy_ui/src/focus.rs
@@ -1,11 +1,9 @@
use crate::Node;
-use bevy_app::{EventReader, Events};
use bevy_core::FloatOrd;
use bevy_ecs::prelude::*;
use bevy_input::{mouse::MouseButton, touch::Touches, I... | diff --git a/crates/bevy_ui/src/focus.rs b/crates/bevy_ui/src/focus.rs
--- a/crates/bevy_ui/src/focus.rs
+++ b/crates/bevy_ui/src/focus.rs
@@ -52,12 +48,14 @@ pub fn ui_focus_system(
Option<&FocusPolicy>,
)>,
) {
- if let Some(cursor_moved) = state.cursor_moved_event_reader.latest(&cursor_moved_events... | ButtonBundle starts up with Hovered Interaction.
**Bevy version**
bevy = { git = "https://github.com/bevyengine/bevy", version = "0.3.0" }
**Operating system & version**
Windows 10
**What you did**
```
use bevy::prelude::*;
struct Output {
msg: String,
msg_prev: String,
}
impl Default f... | the issue is that before you move your mouse, it uses the default value for a position which is `(0, 0)` so over your button in the corner... it's the default value of [this field](https://github.com/bevyengine/bevy/blob/c54179b1829e90d6da8323b67bbab8fe3d4af4b4/crates/bevy_ui/src/focus.rs#L38). This should be fixed, ma... | 2020-12-15T09:47:12Z | 0.3 | 2021-04-27T23:51:09Z | 51650f114fbf31fc89db7bd69542dc21edf2dcb7 | [
"update::tests::test_ui_z_system"
] | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 763 | bevyengine__bevy-763 | [
"762"
] | 9cc6368b28a2df2dff652ae1a087f74fd0362a6a | diff --git a/crates/bevy_ecs/hecs/src/query.rs b/crates/bevy_ecs/hecs/src/query.rs
--- a/crates/bevy_ecs/hecs/src/query.rs
+++ b/crates/bevy_ecs/hecs/src/query.rs
@@ -263,6 +263,9 @@ macro_rules! impl_or_query {
true $( && $T.should_skip(n) )+
}
}
+
+ unsafe impl<$( $T: Rea... | diff --git a/crates/bevy_ecs/src/system/into_system.rs b/crates/bevy_ecs/src/system/into_system.rs
--- a/crates/bevy_ecs/src/system/into_system.rs
+++ b/crates/bevy_ecs/src/system/into_system.rs
@@ -489,6 +489,43 @@ mod tests {
assert!(*resources.get::<bool>().unwrap(), "system ran");
}
+ #[test]
+ ... | Query using the Or operator do not provide .iter() method, only iter_mut().
**Bevy version**
Following version, containing changes on query:
9cc6368b28a2df2dff652ae1a087f74fd0362a6a
**Operating system & version**
Ubuntu 20.04
**What you did**
The following query, that contains an Or, does not have the .iter... | 2020-11-01T15:30:51Z | 0.2 | 2020-11-02T00:51:52Z | 9cc6368b28a2df2dff652ae1a087f74fd0362a6a | [
"resource::resources::tests::thread_local_resource",
"resource::resource_query::tests::changed_resource",
"resource::resources::tests::resource",
"resource::resource_query::tests::or_changed_resource",
"resource::resources::tests::thread_local_resource_ref_aliasing",
"resource::resources::tests::resource_... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 543 | bevyengine__bevy-543 | [
"541"
] | 9a4167ef7f5115f7fc045a881f5c865f568d34c0 | diff --git a/crates/bevy_ecs/hecs/src/query_one.rs b/crates/bevy_ecs/hecs/src/query_one.rs
--- a/crates/bevy_ecs/hecs/src/query_one.rs
+++ b/crates/bevy_ecs/hecs/src/query_one.rs
@@ -37,7 +37,11 @@ impl<'a, Q: Query> QueryOne<'a, Q> {
pub fn get(&mut self) -> Option<<Q::Fetch as Fetch<'_>>::Item> {
unsafe... | diff --git a/crates/bevy_ecs/hecs/tests/tests.rs b/crates/bevy_ecs/hecs/tests/tests.rs
--- a/crates/bevy_ecs/hecs/tests/tests.rs
+++ b/crates/bevy_ecs/hecs/tests/tests.rs
@@ -365,3 +365,35 @@ fn remove_tracking() {
"world clears result in 'removed component' states"
);
}
+
+#[test]
+fn added_tracking() {... | Added<X> not properly filtered in QueryOne.get() and Query.get() methods
With the following standalone testcase, after the second iteration when Added counting becomes 0, I think we should also see both boolean be false.
The second boolean, being based QueryOne.get() has been reported by @cart to behave incorrectly in... | 2020-09-21T12:42:19Z | 0.2 | 2020-10-05T17:38:13Z | 9cc6368b28a2df2dff652ae1a087f74fd0362a6a | [
"added_tracking"
] | [
"bad_bundle_derive",
"alias",
"clear",
"despawn",
"derived_bundle",
"query_missing_component",
"dynamic_components",
"build_entity",
"query_batched",
"query_all",
"query_optional_component",
"remove_missing",
"random_access",
"query_single_component",
"query_one",
"query_sparse_compone... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 488 | bevyengine__bevy-488 | [
"476"
] | 74ad1c375268cedfbb3b218cfc5e86b8d54e1885 | diff --git a/crates/bevy_render/src/camera/camera.rs b/crates/bevy_render/src/camera/camera.rs
--- a/crates/bevy_render/src/camera/camera.rs
+++ b/crates/bevy_render/src/camera/camera.rs
@@ -1,6 +1,6 @@
use super::CameraProjection;
use bevy_app::prelude::{EventReader, Events};
-use bevy_ecs::{Component, Local, Query,... | diff --git a/crates/bevy_render/src/camera/camera.rs b/crates/bevy_render/src/camera/camera.rs
--- a/crates/bevy_render/src/camera/camera.rs
+++ b/crates/bevy_render/src/camera/camera.rs
@@ -38,7 +38,8 @@ pub fn camera_system<T: CameraProjection + Component>(
window_resized_events: Res<Events<WindowResized>>,
... | Camera2dComponents spawned after frame 3 no more display anything.
I reproduced the issue by modifying the sprite.rs example to not spawn on startup, but after X frames.
If X >=3 the bevy logo no more appear.
Is there something that needs to be done to have the 2d camera work when spawned later in the life of the a... | Doing the same test for the example/3d_scene.rs with the Camera3dComponents gave the same strange behaviour.
Spawning at frame 1 or 2 is displaying correctly, spawning starting from frame 3 nothing appears.
Hmm looks like resizing the window "fixes" this problem. Printing out the `OrthographicProjection` component ill... | 2020-09-14T08:19:21Z | 0.2 | 2020-10-05T17:41:35Z | 9cc6368b28a2df2dff652ae1a087f74fd0362a6a | [
"color::test_hex_color",
"mesh::mesh::tests::test_get_vertex_bytes",
"batch::batcher::tests::test_batcher_2",
"render_graph::graph::tests::test_edge_already_exists",
"render_graph::graph::tests::test_get_node_typed",
"render_graph::graph::tests::test_slot_already_occupied",
"render_graph::graph::tests::... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 404 | bevyengine__bevy-404 | [
"333"
] | 0f43fb066f42e459e2f68bc5009af47c00fdc510 | diff --git a/crates/bevy_ecs/hecs/src/archetype.rs b/crates/bevy_ecs/hecs/src/archetype.rs
--- a/crates/bevy_ecs/hecs/src/archetype.rs
+++ b/crates/bevy_ecs/hecs/src/archetype.rs
@@ -404,11 +404,15 @@ impl Archetype {
size: usize,
index: usize,
added: bool,
+ mutated: bool,
) {
... | diff --git a/crates/bevy_ecs/hecs/src/query.rs b/crates/bevy_ecs/hecs/src/query.rs
--- a/crates/bevy_ecs/hecs/src/query.rs
+++ b/crates/bevy_ecs/hecs/src/query.rs
@@ -1089,7 +1089,7 @@ mod tests {
}
}
- fn get_changed_a(world: &mut World) -> Vec<Entity> {
+ fn get_mutated_a(world: ... | Mutating a component with insert(_one) doesn't trigger Mutated query filter
## Expected Behavior
I tried to make a small example and it should print "Tag added" once because the system with Added filter should be called once.
Or maybe I'm wrong and there is another way to add a component to an entity.
## Actual ... | I did a bit of digging and the problem is the two systems `add_tag_on_click` and `print_added` run on the same stage. So when the component is added, the Added system has probably already been run and on each iteration the trackers are cleared. The solution is to add `print_added` to POST_UPDATE stage and it works fine... | 2020-08-31T15:03:18Z | 0.2 | 2020-11-05T01:51:55Z | 9cc6368b28a2df2dff652ae1a087f74fd0362a6a | [
"query::tests::mutated_trackers"
] | [
"entities::tests::entity_bits_roundtrip",
"query::tests::access_order",
"query::tests::changed_query",
"query::tests::multiple_mutated_query",
"query::tests::or_mutated_query",
"query::tests::added_queries",
"added_tracking",
"derived_bundle",
"clear",
"alias",
"build_entity",
"bad_bundle_deri... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 386 | bevyengine__bevy-386 | [
"352"
] | db8ec7d55ffc966f8ee62722156aaaa3f3bb8a56 | diff --git a/crates/bevy_transform/src/hierarchy/hierarchy.rs b/crates/bevy_transform/src/hierarchy/hierarchy.rs
--- a/crates/bevy_transform/src/hierarchy/hierarchy.rs
+++ b/crates/bevy_transform/src/hierarchy/hierarchy.rs
@@ -1,4 +1,4 @@
-use crate::components::Children;
+use crate::components::{Children, Parent};
us... | diff --git a/crates/bevy_transform/src/hierarchy/hierarchy.rs b/crates/bevy_transform/src/hierarchy/hierarchy.rs
--- a/crates/bevy_transform/src/hierarchy/hierarchy.rs
+++ b/crates/bevy_transform/src/hierarchy/hierarchy.rs
@@ -78,32 +90,41 @@ impl DespawnRecursiveExt for Commands {
#[cfg(test)]
mod tests {
use s... | Despawned Node Entities are not removed from their parent Node's Children
An entity that is despawned doesn't appear to be removed from the `Children` component of their parent Node.
I'm not sure this is a bug, but I could see it eventually effective performance for a long running game that both spawns and despawns ... | @karroffel or @cart This behavior is also leading to a crash if you later call `.despawn_recursive` on the entity that has the no longer existing child:
```
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NoSuchEntity', /Users/noah/.cargo/git/checkouts/bevy-f7ffde730c324c74/89a1d36/crates/be... | 2020-08-29T04:56:04Z | 0.1 | 2020-09-02T02:57:34Z | 2667c24656b74fb6d3ee17206494f990678e52b3 | [
"hierarchy::hierarchy::tests::despawn_recursive"
] | [
"hierarchy::child_builder::tests::build_children",
"hierarchy::child_builder::tests::push_and_insert_children",
"transform_propagate_system::test::did_propagate_command_buffer",
"local_transform_systems::test::correct_local_transformation",
"transform_systems::test::correct_world_transformation",
"hierarc... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 13,886 | bevyengine__bevy-13886 | [
"13885"
] | 836b6c4409fbb2a9b16a972c26de631e859a6581 | diff --git a/crates/bevy_ecs/src/archetype.rs b/crates/bevy_ecs/src/archetype.rs
--- a/crates/bevy_ecs/src/archetype.rs
+++ b/crates/bevy_ecs/src/archetype.rs
@@ -370,6 +370,7 @@ impl Archetype {
// SAFETY: We are creating an archetype that includes this component so it must exist
let info = u... | diff --git a/crates/bevy_ecs/src/observer/mod.rs b/crates/bevy_ecs/src/observer/mod.rs
--- a/crates/bevy_ecs/src/observer/mod.rs
+++ b/crates/bevy_ecs/src/observer/mod.rs
@@ -400,6 +400,10 @@ mod tests {
#[derive(Component)]
struct C;
+ #[derive(Component)]
+ #[component(storage = "SparseSet")]
+ s... | Observers don't trigger for Sparse components
Bevy version: 0.14.0-rc.3
`Trigger<OnAdd, C>`, `Trigger<OnUpdate, C>`, `Trigger<OnRemove, C>` don't seem to trigger if the component is Sparse, not Dense.
| FYI @cart @james-j-obrien | 2024-06-17T00:14:44Z | 1.78 | 2024-06-17T15:30:12Z | 3a04d38832fc5ed31526c83b0a19a52faf2063bd | [
"observer::tests::observer_order_insert_remove_sparse"
] | [
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::map_mut",
"change_detection::tests::mut_new",
"change_detection::tests::mut_untyped_from_mut",
"change_detection::tests::mut_untyped_to_reflect",
"entity::map_entities::tests::dyn_ent... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 13,848 | bevyengine__bevy-13848 | [
"13844"
] | 2cffd14923c9e217dc98881af6c8926fe4dc65ea | diff --git a/crates/bevy_state/src/app.rs b/crates/bevy_state/src/app.rs
--- a/crates/bevy_state/src/app.rs
+++ b/crates/bevy_state/src/app.rs
@@ -4,6 +4,7 @@ use bevy_ecs::{
schedule::{IntoSystemConfigs, ScheduleLabel},
world::FromWorld,
};
+use bevy_utils::tracing::warn;
use crate::state::{
setup_s... | diff --git a/crates/bevy_state/src/app.rs b/crates/bevy_state/src/app.rs
--- a/crates/bevy_state/src/app.rs
+++ b/crates/bevy_state/src/app.rs
@@ -192,3 +212,62 @@ impl Plugin for StatesPlugin {
schedule.insert_after(PreUpdate, StateTransition);
}
}
+
+#[cfg(test)]
+mod tests {
+ use crate::{
+ ... | OnEnter triggers twice and OnExit is not triggered
## Bevy version
0.13.2
## \[Optional\] Relevant system information
Ubuntu 22.04.4 LTS 64-bit
## Minimal project with the issue
```rust
use bevy::prelude::*;
fn main() {
App::new()
.add_plugins(DefaultPlugins)
.insert_state(AppS... | 2024-06-14T16:17:31Z | 1.78 | 2024-09-07T19:14:04Z | 3a04d38832fc5ed31526c83b0a19a52faf2063bd | [
"app::tests::insert_state_can_overwrite_insert_state",
"app::tests::insert_state_can_overwrite_init_state"
] | [
"condition::tests::distributive_run_if_compiles",
"state::tests::same_state_transition_should_emit_event_and_not_run_schedules",
"state::tests::computed_state_with_a_single_source_is_correctly_derived",
"state::tests::sub_state_exists_only_when_allowed_but_can_be_modified_freely",
"state::tests::same_state_... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 13,817 | bevyengine__bevy-13817 | [
"13815"
] | 2825ac8a8e69b4c816e3ca67df2f841904ac7b69 | diff --git a/crates/bevy_app/src/app.rs b/crates/bevy_app/src/app.rs
--- a/crates/bevy_app/src/app.rs
+++ b/crates/bevy_app/src/app.rs
@@ -439,12 +439,7 @@ impl App {
plugin: Box<dyn Plugin>,
) -> Result<&mut Self, AppError> {
debug!("added plugin: {}", plugin.name());
- if plugin.is_uniqu... | diff --git a/crates/bevy_app/src/app.rs b/crates/bevy_app/src/app.rs
--- a/crates/bevy_app/src/app.rs
+++ b/crates/bevy_app/src/app.rs
@@ -1275,6 +1273,21 @@ mod tests {
.init_resource::<TestResource>();
}
+ #[test]
+ /// Plugin should not be considered inserted while it's being built
+ ///... | is_plugin_added is always true for Self
## Bevy version
0.14.0-rc.2
## What you did
The following program panics in Bevy 0.14.0-rc.2, but runs successfully in 0.13.2
```rust
use bevy::prelude::*;
fn main() {
let app = App::new().add_plugins(Foo);
}
pub struct Foo;
impl Plugin for Foo {
... | 2024-06-11T22:18:39Z | 1.78 | 2024-06-14T19:51:44Z | 3a04d38832fc5ed31526c83b0a19a52faf2063bd | [
"app::tests::plugin_should_not_be_added_during_build_time"
] | [
"app::tests::app_exit_size",
"app::tests::test_derive_app_label",
"plugin_group::tests::add_after",
"app::tests::initializing_resources_from_world",
"app::tests::can_add_two_plugins",
"app::tests::can_add_twice_the_same_plugin_with_different_type_param",
"app::tests::can_add_twice_the_same_plugin_not_un... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 13,706 | bevyengine__bevy-13706 | [
"13646"
] | b17292f9d11cf3d3fb4a2fb3e3324fb80afd8c88 | diff --git a/crates/bevy_reflect/src/map.rs b/crates/bevy_reflect/src/map.rs
--- a/crates/bevy_reflect/src/map.rs
+++ b/crates/bevy_reflect/src/map.rs
@@ -197,12 +197,26 @@ impl MapInfo {
#[macro_export]
macro_rules! hash_error {
( $key:expr ) => {{
- let type_name = match (*$key).get_represented_type_inf... | diff --git a/crates/bevy_reflect/src/lib.rs b/crates/bevy_reflect/src/lib.rs
--- a/crates/bevy_reflect/src/lib.rs
+++ b/crates/bevy_reflect/src/lib.rs
@@ -596,6 +596,7 @@ mod tests {
any::TypeId,
borrow::Cow,
fmt::{Debug, Formatter},
+ hash::Hash,
marker::PhantomData,
};
... | Panic "the given key does not support hashing" should indicate the type.
The reflection panic "the given key does not support hashing" raised by insert_boxed needs to indicate the type that it is trying to use as a key. Otherwise, it is difficult to track down the source of the panic.
| Hi, Im new to rust and bevy, in this particular issue I managed to figure that we need the debug msg to be more descriptive. However I cant seem what exactly keeps track of the type. Any advice? | 2024-06-06T07:36:57Z | 1.78 | 2024-06-10T12:20:23Z | 3a04d38832fc5ed31526c83b0a19a52faf2063bd | [
"tests::reflect_map_no_hash - should panic",
"tests::reflect_map_no_hash_dynamic - should panic",
"tests::reflect_map_no_hash_dynamic_representing - should panic"
] | [
"array::tests::next_index_increment",
"attributes::tests::should_allow_unit_struct_attribute_values",
"attributes::tests::should_accept_last_attribute",
"attributes::tests::should_debug_custom_attributes",
"attributes::tests::should_derive_custom_attributes_on_enum_container",
"attributes::tests::should_d... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 13,691 | bevyengine__bevy-13691 | [
"13646"
] | 519abbca1141bf904695b1c0cf4184addc6883c5 | diff --git a/crates/bevy_reflect/src/map.rs b/crates/bevy_reflect/src/map.rs
--- a/crates/bevy_reflect/src/map.rs
+++ b/crates/bevy_reflect/src/map.rs
@@ -194,7 +194,16 @@ impl MapInfo {
}
}
-const HASH_ERROR: &str = "the given key does not support hashing";
+#[macro_export]
+macro_rules! hash_error {
+ ( $k... | diff --git a/crates/bevy_reflect/src/lib.rs b/crates/bevy_reflect/src/lib.rs
--- a/crates/bevy_reflect/src/lib.rs
+++ b/crates/bevy_reflect/src/lib.rs
@@ -756,7 +756,7 @@ mod tests {
}
#[test]
- #[should_panic(expected = "the given key does not support hashing")]
+ #[should_panic(expected = "the given... | Panic "the given key does not support hashing" should indicate the type.
The reflection panic "the given key does not support hashing" raised by insert_boxed needs to indicate the type that it is trying to use as a key. Otherwise, it is difficult to track down the source of the panic.
| Hi, Im new to rust and bevy, in this particular issue I managed to figure that we need the debug msg to be more descriptive. However I cant seem what exactly keeps track of the type. Any advice? | 2024-06-05T19:05:50Z | 1.78 | 2024-06-06T15:08:29Z | 3a04d38832fc5ed31526c83b0a19a52faf2063bd | [
"tests::reflect_map_no_hash - should panic"
] | [
"array::tests::next_index_increment",
"attributes::tests::should_allow_unit_struct_attribute_values",
"attributes::tests::should_debug_custom_attributes",
"attributes::tests::should_accept_last_attribute",
"attributes::tests::should_derive_custom_attributes_on_enum_variant_fields",
"attributes::tests::sho... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 13,650 | bevyengine__bevy-13650 | [
"10958"
] | cca4fc76de29762d313d6bc567ae709445b24c27 | diff --git a/crates/bevy_ecs/src/reflect/map_entities.rs b/crates/bevy_ecs/src/reflect/map_entities.rs
--- a/crates/bevy_ecs/src/reflect/map_entities.rs
+++ b/crates/bevy_ecs/src/reflect/map_entities.rs
@@ -73,3 +73,34 @@ impl<C: Component + MapEntities> FromType<C> for ReflectMapEntities {
}
}
}
+
+/// ... | diff --git a/crates/bevy_scene/src/dynamic_scene.rs b/crates/bevy_scene/src/dynamic_scene.rs
--- a/crates/bevy_scene/src/dynamic_scene.rs
+++ b/crates/bevy_scene/src/dynamic_scene.rs
@@ -198,12 +205,68 @@ where
#[cfg(test)]
mod tests {
- use bevy_ecs::entity::EntityHashMap;
+ use bevy_ecs::entity::{Entity, En... | `ReflectMapEntities` on Resources
## Bevy version
`0.12.1`
## What you did
```rust
#[derive(Resource, Reflect, Clone, Default)]
#[reflect(Resource, MapEntities)]
pub struct MyResource {
entity: Entity
}
impl MapEntities for MyResource {
fn map_entities(&mut self, entity_mapper: &mut EntityMapp... | I believe a workaround would be to derive `Component` in addition to `Resource`, this should still work with `bevy_scene`'s implementation of `MapEntities`.
I was just looking at this wrt. `DynamicScene`, which is missing the implementation to call `map_entities` for `Resource`s implementing the trait. Given the scene ... | 2024-06-03T15:18:37Z | 1.77 | 2024-06-03T20:51:57Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"dynamic_scene_builder::tests::extract_entity_order",
"dynamic_scene_builder::tests::extract_one_resource",
"dynamic_scene_builder::tests::extract_one_entity",
"dynamic_scene_builder::tests::extract_one_entity_two_components",
"dynamic_scene_builder::tests::extract_one_entity_twice",
"dynamic_scene_builde... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 13,451 | bevyengine__bevy-13451 | [
"13407"
] | 5a1c62faae54bae1291c6f80898f29153faa0979 | diff --git a/crates/bevy_math/src/direction.rs b/crates/bevy_math/src/direction.rs
--- a/crates/bevy_math/src/direction.rs
+++ b/crates/bevy_math/src/direction.rs
@@ -143,6 +143,35 @@ impl Dir2 {
pub const fn as_vec2(&self) -> Vec2 {
self.0
}
+
+ /// Performs a spherical linear interpolation betwe... | diff --git a/crates/bevy_math/src/direction.rs b/crates/bevy_math/src/direction.rs
--- a/crates/bevy_math/src/direction.rs
+++ b/crates/bevy_math/src/direction.rs
@@ -582,6 +680,7 @@ impl approx::UlpsEq for Dir3A {
#[cfg(test)]
mod tests {
use super::*;
+ use approx::assert_relative_eq;
#[test]
fn... | slerp functions for directions (Vec2 and Vec3)
## What problem does this solve or what need does it fill?
Linear interpolation is unsuited for transitioning of directions.
## What solution would you like?
I would like a spherical interpolation function (slerp) for Vec2 and Vec3 directions.
## Additional con... | [Vec2 and Vec3 is part of glam crate](https://github.com/bevyengine/bevy/blob/11f0a2dcdeb86651fdb6cdaf2c83ffd01df93149/crates/bevy_math/src/common_traits.rs#L1), this problem should be solved there, futhermore there is already [long living issue](https://github.com/bitshifter/glam-rs/issues/377)
@bugsweeper You're righ... | 2024-05-21T10:39:48Z | 1.77 | 2024-05-21T21:28:31Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"bounding::bounded2d::aabb2d_tests::center",
"bounding::bounded2d::aabb2d_tests::area",
"bounding::bounded2d::aabb2d_tests::contains",
"bounding::bounded2d::aabb2d_tests::closest_point",
"bounding::bounded2d::aabb2d_tests::grow",
"bounding::bounded2d::aabb2d_tests::half_size",
"bounding::bounded2d::aabb... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 12,997 | bevyengine__bevy-12997 | [
"12966"
] | ade70b3925b27f76b669ac5fd9e2c31f824d7667 | diff --git a/Cargo.toml b/Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -67,7 +67,7 @@ default = [
"bevy_sprite",
"bevy_text",
"bevy_ui",
- "multi-threaded",
+ "multi_threaded",
"png",
"hdr",
"vorbis",
diff --git a/Cargo.toml b/Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -252,7 +252,7 @@ symph... | diff --git a/crates/bevy_asset/src/lib.rs b/crates/bevy_asset/src/lib.rs
--- a/crates/bevy_asset/src/lib.rs
+++ b/crates/bevy_asset/src/lib.rs
@@ -659,8 +659,8 @@ mod tests {
#[test]
fn load_dependencies() {
// The particular usage of GatedReader in this test will cause deadlocking if running single-... | multi-threaded feature name is kebab case but all others are snake case
## Bevy version
0.14
## What went wrong
See https://github.com/bevyengine/bevy/blob/62f2a73cac70237c83054345a26b19c9e0a0ee2f/Cargo.toml#L70
| There are actually quite a few features that use kebab case, such as all the `symphonia-*` ones. Should those also be changed, or just `multi-threaded`?
Oh so there is. We should change all of the ones that aren't deliberately matching a dependencies' feature IMO. | 2024-04-16T16:04:30Z | 1.77 | 2024-11-17T23:16:31Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"assets::test::asset_index_round_trip",
"handle::tests::hashing",
"handle::tests::equality",
"handle::tests::conversion",
"handle::tests::ordering",
"id::tests::equality",
"id::tests::hashing",
"id::tests::ordering",
"id::tests::conversion",
"io::embedded::tests::embedded_asset_path_from_external_... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 15,546 | bevyengine__bevy-15546 | [
"15541"
] | 429987ebf811da7fa30adc57dca5d83ed9c7e871 | diff --git a/crates/bevy_animation/src/graph.rs b/crates/bevy_animation/src/graph.rs
--- a/crates/bevy_animation/src/graph.rs
+++ b/crates/bevy_animation/src/graph.rs
@@ -508,11 +508,11 @@ impl AssetLoader for AnimationGraphAssetLoader {
type Error = AnimationGraphLoadError;
- async fn load<'a>(
- &'... | diff --git a/crates/bevy_asset/src/lib.rs b/crates/bevy_asset/src/lib.rs
--- a/crates/bevy_asset/src/lib.rs
+++ b/crates/bevy_asset/src/lib.rs
@@ -676,11 +676,11 @@ mod tests {
type Error = CoolTextLoaderError;
- async fn load<'a>(
- &'a self,
- reader: &'a mut dyn Reader,
- ... | AssetServer lifetimes can probably be simplified
> I might be missing something, but I think these can be simplified. There's also other functions in the same file that has unused `'a` lifetimes.
_Originally posted by @kristoff3r in https://github.com/bevyengine/bevy/pull/15533#pullrequestreview-2337163550_
... | 2024-09-30T20:18:46Z | 1.81 | 2024-09-30T22:13:39Z | 60b2c7ce7755a49381c5265021ff175d3624218c | [
"assets::test::asset_index_round_trip",
"handle::tests::equality",
"handle::tests::conversion",
"handle::tests::ordering",
"id::tests::conversion",
"handle::tests::hashing",
"id::tests::equality",
"id::tests::hashing",
"id::tests::ordering",
"io::embedded::tests::embedded_asset_path_from_external_... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 15,405 | bevyengine__bevy-15405 | [
"14300"
] | efda7f3f9c96164f6e5be04d2be9c267919c6a0a | diff --git a/crates/bevy_ecs/src/entity/map_entities.rs b/crates/bevy_ecs/src/entity/map_entities.rs
--- a/crates/bevy_ecs/src/entity/map_entities.rs
+++ b/crates/bevy_ecs/src/entity/map_entities.rs
@@ -183,6 +183,9 @@ impl<'m> SceneEntityMapper<'m> {
/// Creates a new [`SceneEntityMapper`], spawning a temporary... | diff --git a/crates/bevy_ecs/src/entity/map_entities.rs b/crates/bevy_ecs/src/entity/map_entities.rs
--- a/crates/bevy_ecs/src/entity/map_entities.rs
+++ b/crates/bevy_ecs/src/entity/map_entities.rs
@@ -292,6 +295,23 @@ mod tests {
);
}
+ #[test]
+ fn entity_mapper_no_panic() {
+ let mut wo... | Panic calling `DynamicScene::write_to_world` with `MapEntities` and `ComponentHooks`
## Bevy version
`0.14.0`
## What you did
- call `DynamicScene::write_to_world` with two components:
1. One that uses `MapEntities`
2. One that calls `world.commands().spawn_empty()` in `ComponentHooks::on_add`
## W... | looks related to https://github.com/bevyengine/bevy/issues/14465 | 2024-09-24T00:11:46Z | 1.81 | 2024-09-24T17:54:36Z | 60b2c7ce7755a49381c5265021ff175d3624218c | [
"entity::map_entities::tests::entity_mapper_no_panic"
] | [
"change_detection::tests::as_deref_mut",
"bundle::tests::component_hook_order_spawn_despawn",
"bundle::tests::component_hook_order_insert_remove",
"bundle::tests::component_hook_order_spawn_despawn_with_macro_hooks",
"bundle::tests::component_hook_order_replace",
"bundle::tests::insert_if_new",
"bundle:... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 15,398 | bevyengine__bevy-15398 | [
"14467"
] | 1a41c736b39a01f4dbef75c4282edf3ced5f01e9 | diff --git a/crates/bevy_ecs/src/world/entity_ref.rs b/crates/bevy_ecs/src/world/entity_ref.rs
--- a/crates/bevy_ecs/src/world/entity_ref.rs
+++ b/crates/bevy_ecs/src/world/entity_ref.rs
@@ -1297,7 +1297,6 @@ impl<'w> EntityWorldMut<'w> {
/// See [`World::despawn`] for more details.
pub fn despawn(self) {
... | diff --git a/crates/bevy_ecs/src/observer/mod.rs b/crates/bevy_ecs/src/observer/mod.rs
--- a/crates/bevy_ecs/src/observer/mod.rs
+++ b/crates/bevy_ecs/src/observer/mod.rs
@@ -1160,4 +1160,26 @@ mod tests {
world.flush();
assert_eq!(vec!["event", "event"], world.resource::<Order>().0);
}
+
+ //... | Panic when a despawning `Entity`'s observer spawns an `Entity`
## Bevy version
`0.14.0`
## What you did
```rust
use bevy::prelude::*;
fn main() {
App::new()
.add_plugins(MinimalPlugins)
.add_systems(Startup, startup)
.add_systems(Update, update)
.run();
}
#[deri... | 2024-09-23T20:28:24Z | 1.81 | 2024-09-24T01:25:13Z | 60b2c7ce7755a49381c5265021ff175d3624218c | [
"observer::tests::observer_on_remove_during_despawn_spawn_empty"
] | [
"change_detection::tests::mut_untyped_from_mut",
"change_detection::tests::mut_untyped_to_reflect",
"change_detection::tests::change_tick_wraparound",
"change_detection::tests::map_mut",
"change_detection::tests::change_tick_scan",
"bundle::tests::component_hook_order_replace",
"bundle::tests::component... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 12,867 | bevyengine__bevy-12867 | [
"12837"
] | fae2200b1ad1df3ec97b6d3545022e8e5581e245 | diff --git a/crates/bevy_math/src/primitives/dim3.rs b/crates/bevy_math/src/primitives/dim3.rs
--- a/crates/bevy_math/src/primitives/dim3.rs
+++ b/crates/bevy_math/src/primitives/dim3.rs
@@ -834,14 +834,14 @@ impl Primitive3d for Tetrahedron {}
impl Default for Tetrahedron {
/// Returns the default [`Tetrahedro... | diff --git a/crates/bevy_math/src/primitives/dim3.rs b/crates/bevy_math/src/primitives/dim3.rs
--- a/crates/bevy_math/src/primitives/dim3.rs
+++ b/crates/bevy_math/src/primitives/dim3.rs
@@ -1085,20 +1085,17 @@ mod tests {
);
assert_relative_eq!(tetrahedron.centroid(), Vec3::new(-0.225, -0.375, 1.55))... | Default tetrahedron origin should be at (0, 0, 0)
I think the default tet should be centered on the origin. It's going to rotate strangely when people mesh it and apply transforms. I believe all other default primitives have their center of mass more or less at the origin.
_Originally posted by @NthTen... | 2024-04-03T22:04:48Z | 1.77 | 2024-04-03T23:15:04Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"primitives::dim3::tests::tetrahedron_math"
] | [
"bounding::bounded2d::aabb2d_tests::area",
"bounding::bounded2d::aabb2d_tests::closest_point",
"bounding::bounded2d::aabb2d_tests::center",
"bounding::bounded2d::aabb2d_tests::contains",
"bounding::bounded2d::aabb2d_tests::grow",
"bounding::bounded2d::aabb2d_tests::half_size",
"bounding::bounded2d::aabb... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 12,842 | bevyengine__bevy-12842 | [
"9261"
] | 8092e2c86d32a0f83c7c7d97233130d6d7f68dc4 | diff --git a/crates/bevy_ecs/src/system/commands/mod.rs b/crates/bevy_ecs/src/system/commands/mod.rs
--- a/crates/bevy_ecs/src/system/commands/mod.rs
+++ b/crates/bevy_ecs/src/system/commands/mod.rs
@@ -4,6 +4,7 @@ use super::{Deferred, IntoSystem, RegisterSystem, Resource};
use crate::{
self as bevy_ecs,
bu... | diff --git a/crates/bevy_ecs/src/system/commands/mod.rs b/crates/bevy_ecs/src/system/commands/mod.rs
--- a/crates/bevy_ecs/src/system/commands/mod.rs
+++ b/crates/bevy_ecs/src/system/commands/mod.rs
@@ -1153,9 +1171,12 @@ mod tests {
system::{Commands, Resource},
world::{CommandQueue, World},
};
... | Missing `remove_by_id`
The untyped API seems to be missing the comparable `EntityMut::remove_by_id` or `EntityCommands::remove_by_id` methods. There are, however, `World::remove_resource_by_id` and `World::remove_non_send_by_id` for some reason.
| i would like to solve this isssue in a decent way as my first contribution but i'm actually really new at bevy. So could someone verify my approach maybe.
I already defined a method called `EntitiyMut::remove_by_id(&mut self, component_id)` which takes a `component_id` and uses the instance of the world attribute to... | 2024-04-02T01:46:02Z | 1.77 | 2024-04-03T10:04:59Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::mut_untyped_to_reflect",
"change_detection::tests::mut_new",
"change_detection::tests::mut_untyped_from_mut",
"change_detection::tests::as_deref_mu... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 12,816 | bevyengine__bevy-12816 | [
"12184"
] | a27ce270d00cdc54d4ecd2aae1d9edb6978ed0f7 | diff --git a/crates/bevy_ui/src/layout/mod.rs b/crates/bevy_ui/src/layout/mod.rs
--- a/crates/bevy_ui/src/layout/mod.rs
+++ b/crates/bevy_ui/src/layout/mod.rs
@@ -32,6 +32,12 @@ pub struct LayoutContext {
}
impl LayoutContext {
+ pub const DEFAULT: Self = Self {
+ scale_factor: 1.0,
+ physical_size... | diff --git a/crates/bevy_ui/src/layout/mod.rs b/crates/bevy_ui/src/layout/mod.rs
--- a/crates/bevy_ui/src/layout/mod.rs
+++ b/crates/bevy_ui/src/layout/mod.rs
@@ -1000,4 +1014,65 @@ mod tests {
}
}
}
+
+ #[test]
+ fn no_camera_ui() {
+ let mut world = World::new();
+ world... | Panic with UI hierarchy when no camera is present
## Bevy version
main, 0.13
bisected to #10559
## Relevant system information
```
AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
SystemInfo { os: "MacOS 14.2.1 ", kernel: "... | I want to work on this issue, if it's OK | 2024-03-31T21:44:08Z | 1.77 | 2024-04-22T16:56:20Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"layout::tests::no_camera_ui"
] | [
"geometry::tests::default_val_equals_const_default_val",
"geometry::tests::test_uirect_axes",
"geometry::tests::uirect_default_equals_const_default",
"geometry::tests::uirect_px",
"geometry::tests::uirect_percent",
"geometry::tests::val_auto_is_non_resolveable",
"geometry::tests::val_evaluate",
"geome... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 12,738 | bevyengine__bevy-12738 | [
"12736"
] | 221d925e9098ee3f0c83237e8b96e49b62cebcea | diff --git a/crates/bevy_sprite/src/lib.rs b/crates/bevy_sprite/src/lib.rs
--- a/crates/bevy_sprite/src/lib.rs
+++ b/crates/bevy_sprite/src/lib.rs
@@ -194,14 +194,18 @@ pub fn calculate_bounds_2d(
}
}
for (entity, sprite, texture_handle, atlas) in &sprites_to_recalculate_aabb {
- if let Some(s... | diff --git a/crates/bevy_sprite/src/lib.rs b/crates/bevy_sprite/src/lib.rs
--- a/crates/bevy_sprite/src/lib.rs
+++ b/crates/bevy_sprite/src/lib.rs
@@ -226,7 +230,7 @@ impl ExtractComponent for SpriteSource {
#[cfg(test)]
mod test {
- use bevy_math::Vec2;
+ use bevy_math::{Rect, Vec2, Vec3A};
use bevy_uti... | Sprite with rect and custom anchor doesn't render when it should
## Bevy version
0.13.0 and b7ab1466c7ac2c6f20a37e47db9b8d889a940611
## Relevant system information
```ignore
`AdapterInfo { name: "Intel(R) Xe Graphics (TGL GT2)", vendor: 32902, device: 39497, device_type: Integrate
dGpu, driver: "Intel open-s... | 2024-03-26T19:40:47Z | 1.77 | 2024-04-16T16:50:34Z | 257fec996fedfe8e3757b11720eb2ab8a21fbbb5 | [
"test::calculate_bounds_2d_correct_aabb_for_sprite_with_custom_rect"
] | [
"test::calculate_bounds_2d_create_aabb_for_image_sprite_entity",
"test::calculate_bounds_2d_update_aabb_when_sprite_custom_size_changes_to_some",
"crates/bevy_sprite/src/mesh2d/material.rs - mesh2d::material::Material2d (line 54)",
"crates/bevy_sprite/src/texture_atlas_builder.rs - texture_atlas_builder::Text... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 12,469 | bevyengine__bevy-12469 | [
"12139",
"12139"
] | 4b64d1d1d721a6974a6a06e57749227806f6835c | diff --git a/crates/bevy_ecs/src/entity/mod.rs b/crates/bevy_ecs/src/entity/mod.rs
--- a/crates/bevy_ecs/src/entity/mod.rs
+++ b/crates/bevy_ecs/src/entity/mod.rs
@@ -139,7 +139,7 @@ type IdCursor = isize;
/// [`Query::get`]: crate::system::Query::get
/// [`World`]: crate::world::World
/// [SemVer]: https://semver.o... | diff --git a/crates/bevy_ecs/src/entity/mod.rs b/crates/bevy_ecs/src/entity/mod.rs
--- a/crates/bevy_ecs/src/entity/mod.rs
+++ b/crates/bevy_ecs/src/entity/mod.rs
@@ -1147,4 +1153,14 @@ mod tests {
assert_ne!(hash, first_hash);
}
}
+
+ #[test]
+ fn entity_display() {
+ let entity... | Inconsistency between `Debug` and serialized representation of `Entity`
## Bevy version
0.13
## What went wrong
There is an inconsistency between the `Debug` representation of an `Entity`:
```rust
impl fmt::Debug for Entity {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f... | Ah: I know what we should do. The serialized representation should stay the same, optimized for information density. This is just an opaque identifier. However, we should make the debug representation more verbose, and report `index`, `generation` and `raw_bits` separately.
In the future, we will be packing more inf... | 2024-03-14T04:35:47Z | 1.76 | 2024-03-14T23:54:21Z | c9ec95d7827297528d0779e3fd232dfc2e3cbed7 | [
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::map_mut",
"change_detection::tests::as_deref_mut",
"bundle::tests::component_hook_order_spawn_despawn",
"change_detection::tests::mut_from_res_mut",
"bundle::tests::component_hook_order_insert_remove",
"change_detection::tests::... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 12,399 | bevyengine__bevy-12399 | [
"12200"
] | ba0f033e8f9dfed3d3a37aea97fbe6481dd2f905 | diff --git a/crates/bevy_color/src/color_ops.rs b/crates/bevy_color/src/color_ops.rs
--- a/crates/bevy_color/src/color_ops.rs
+++ b/crates/bevy_color/src/color_ops.rs
@@ -62,6 +62,24 @@ pub trait Alpha: Sized {
}
}
+/// Trait for manipulating the hue of a color.
+pub trait Hue: Sized {
+ /// Return a new ver... | diff --git a/crates/bevy_color/src/color_ops.rs b/crates/bevy_color/src/color_ops.rs
--- a/crates/bevy_color/src/color_ops.rs
+++ b/crates/bevy_color/src/color_ops.rs
@@ -78,3 +96,21 @@ pub trait ClampColor: Sized {
/// Are all the fields of this color in bounds?
fn is_within_bounds(&self) -> bool;
}
+
+#[cf... | Add hue rotation traits
Nit for future PR: We should add hue rotation traits to make this cleaner.
_Originally posted by @bushrat011899 in https://github.com/bevyengine/bevy/pull/12163#discussion_r1506997793_
Much like the `Alpha` trait, we should provide easy ways to "rota... | If nobody is working on it, I'll give it a try.
That would be lovely :) Feel free to open a draft PR and ping me if you run into difficulties. | 2024-03-10T05:51:01Z | 1.76 | 2024-05-03T20:25:31Z | c9ec95d7827297528d0779e3fd232dfc2e3cbed7 | [
"hsla::tests::test_from_index",
"color_range::tests::test_color_range",
"hsla::tests::test_mix_wrap",
"hsla::tests::test_clamp",
"hsla::tests::test_to_from_srgba",
"hsla::tests::test_to_from_linear",
"hsla::tests::test_to_from_srgba_2",
"hsva::tests::test_clamp",
"hsva::tests::test_to_from_srgba",
... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 16,910 | bevyengine__bevy-16910 | [
"16676"
] | 65835f535493a14d4fabe3c1569de61be2e884b1 | diff --git a/crates/bevy_math/src/curve/easing.rs b/crates/bevy_math/src/curve/easing.rs
--- a/crates/bevy_math/src/curve/easing.rs
+++ b/crates/bevy_math/src/curve/easing.rs
@@ -176,9 +176,15 @@ pub enum EaseFunction {
/// Behaves as `EaseFunction::CircularIn` for t < 0.5 and as `EaseFunction::CircularOut` for t ... | diff --git a/crates/bevy_math/src/curve/easing.rs b/crates/bevy_math/src/curve/easing.rs
--- a/crates/bevy_math/src/curve/easing.rs
+++ b/crates/bevy_math/src/curve/easing.rs
@@ -459,3 +475,83 @@ impl EaseFunction {
}
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ const MONOTONIC_IN_OUT_INOUT: ... | `EaseFunction::ExponentialIn` jumps at the beginning
## Bevy version
2024-12-05 https://github.com/bevyengine/bevy/commit/bc572cd27
## What you did
Called `ExponentialIn.eval(0)`, expecting it to be essentially 0, but it returned about 1‰ instead.
See tests in https://github.com/bevyengine/bevy/pull/16675/files#dif... | 2024-12-20T07:30:51Z | 1.83 | 2024-12-24T03:01:12Z | 64efd08e13c55598587f3071070f750f8945e28e | [
"curve::easing::tests::ease_functions_zero_to_one"
] | [
"bounding::bounded2d::aabb2d_tests::area",
"bounding::bounded2d::aabb2d_tests::center",
"bounding::bounded2d::aabb2d_tests::closest_point",
"bounding::bounded2d::aabb2d_tests::contains",
"bounding::bounded2d::aabb2d_tests::grow",
"bounding::bounded2d::aabb2d_tests::half_size",
"bounding::bounded2d::aabb... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 16,747 | bevyengine__bevy-16747 | [
"16736"
] | bb090e61766a7e4c09d14e28abc16829d7b60368 | diff --git a/crates/bevy_animation/src/animation_curves.rs b/crates/bevy_animation/src/animation_curves.rs
--- a/crates/bevy_animation/src/animation_curves.rs
+++ b/crates/bevy_animation/src/animation_curves.rs
@@ -243,18 +243,26 @@ where
impl<C: Typed, P, F: Fn(&mut C) -> &mut P + 'static> AnimatedField<C, P, F> {
... | diff --git a/crates/bevy_animation/src/animation_curves.rs b/crates/bevy_animation/src/animation_curves.rs
--- a/crates/bevy_animation/src/animation_curves.rs
+++ b/crates/bevy_animation/src/animation_curves.rs
@@ -984,3 +992,21 @@ macro_rules! animated_field {
})
};
}
+
+#[cfg(test)]
+mod tests {
+ u... | Add support to the `animated_field!` macro for tuple structs
## What problem does this solve or what need does it fill?
Components like `TextColor` and `BackgroundColor` cannot currently be easily animated without creating a custom `AnimatableProperty`.
## What solution would you like?
Add support to the `animated_f... | Can you use `_0` and so on? That's the field name of tuple structs.
`_0` and friends don't seem to work with the macro, Rust complains about incorrect field names because the macro does field access via the provided field name.
You can try to construct an `AnimatedField` directly (the below compiles):
```rust
#[derive(... | 2024-12-10T13:25:48Z | 1.82 | 2024-12-12T04:00:23Z | 6178ce93e8537f823685e8c1b617e22ba93696e7 | [
"animation_curves::tests::test_animated_field_tuple_struct_simple_uses"
] | [
"tests::test_events_triggers",
"tests::test_events_triggers_looping",
"tests::test_multiple_events_triggers",
"crates/bevy_animation/src/animation_curves.rs - animation_curves (line 10)",
"crates/bevy_animation/src/animation_curves.rs - animation_curves::AnimatableProperty (line 117)",
"crates/bevy_animat... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 16,499 | bevyengine__bevy-16499 | [
"16498"
] | 0070514f5468909ffa50845bca2a665766edfe9d | diff --git a/crates/bevy_ecs/src/bundle.rs b/crates/bevy_ecs/src/bundle.rs
--- a/crates/bevy_ecs/src/bundle.rs
+++ b/crates/bevy_ecs/src/bundle.rs
@@ -902,7 +902,6 @@ impl<'w> BundleInserter<'w> {
let mut deferred_world = self.world.into_deferred();
if insert_mode == InsertMode::Replace {
- ... | diff --git a/crates/bevy_ecs/src/world/entity_ref.rs b/crates/bevy_ecs/src/world/entity_ref.rs
--- a/crates/bevy_ecs/src/world/entity_ref.rs
+++ b/crates/bevy_ecs/src/world/entity_ref.rs
@@ -4910,14 +4910,14 @@ mod tests {
"OrdB hook on_insert",
"OrdB observer on_insert",
"OrdB co... | Hook and observer ordering for `on_remove`/`on_replace` should be inverted
## Bevy version
0.15.0-rc.3 (exists before as well)
## What you did
When adding a component, the order of hooks and observers are:
- on_add hook
- on_add observers
- on_insert hook
- on_insert observers
When removing a component, the order o... | [Flecs also runs `on_remove` hooks after `OnRemove` observers](https://www.flecs.dev/flecs/md_docs_2ObserversManual.html#hooks-and-events) | 2024-11-25T00:48:00Z | 1.82 | 2024-12-06T00:45:03Z | 6178ce93e8537f823685e8c1b617e22ba93696e7 | [
"world::entity_ref::tests::command_ordering_is_correct"
] | [
"bundle::tests::component_hook_order_spawn_despawn",
"bundle::tests::component_hook_order_replace",
"bundle::tests::component_hook_order_insert_remove",
"bundle::tests::component_hook_order_spawn_despawn_with_macro_hooks",
"bundle::tests::insert_if_new",
"change_detection::tests::as_deref_mut",
"change_... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 16,475 | bevyengine__bevy-16475 | [
"16474"
] | 6741e01dfa8876a6113adb79bdd475982e4d3e80 | diff --git a/crates/bevy_image/src/image.rs b/crates/bevy_image/src/image.rs
--- a/crates/bevy_image/src/image.rs
+++ b/crates/bevy_image/src/image.rs
@@ -944,19 +944,19 @@ impl Image {
let pixel_size = self.texture_descriptor.format.pixel_size();
let pixel_offset = match self.texture_descriptor.dimen... | diff --git a/crates/bevy_image/src/image.rs b/crates/bevy_image/src/image.rs
--- a/crates/bevy_image/src/image.rs
+++ b/crates/bevy_image/src/image.rs
@@ -1573,4 +1573,28 @@ mod test {
assert_eq!(UVec2::ONE, image.size());
assert_eq!(Vec2::ONE, image.size_f32());
}
+
+ #[test]
+ fn on_edge_... | Calling `Image::get_color_at` panics
On #16388, we are using `Image::get_color_at` to determine a pixel's alpha value. There is no unwrap occuring, so we expect there to be no panics, however another user noted the following:
Testing the changes got this error after a crash:
```
2024-11-22T07:39:32.137594Z INFO b... | 2024-11-22T08:25:30Z | 1.82 | 2024-11-22T18:34:57Z | 6178ce93e8537f823685e8c1b617e22ba93696e7 | [
"image::test::on_edge_pixel_is_invalid"
] | [
"dds::test::dds_skybox",
"image_texture_conversion::test::two_way_conversion",
"ktx2::tests::test_ktx_levels",
"image::test::image_default_size",
"image::test::image_size"
] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 16,441 | bevyengine__bevy-16441 | [
"16406"
] | 4a6b686832a9ea19bc6738f4019bb58d9d052ee3 | diff --git a/crates/bevy_ecs/src/component.rs b/crates/bevy_ecs/src/component.rs
--- a/crates/bevy_ecs/src/component.rs
+++ b/crates/bevy_ecs/src/component.rs
@@ -1029,8 +1029,8 @@ impl Components {
/// registration will be used.
pub(crate) unsafe fn register_required_components<R: Component>(
&mut s... | diff --git a/crates/bevy_ecs/src/lib.rs b/crates/bevy_ecs/src/lib.rs
--- a/crates/bevy_ecs/src/lib.rs
+++ b/crates/bevy_ecs/src/lib.rs
@@ -2399,6 +2399,40 @@ mod tests {
assert_eq!(world.entity(id).get::<Counter>().unwrap().0, 1);
}
+ #[test]
+ fn runtime_required_components_deep_require_does_not_... | Runtime required components do not work correctly for components added through `#[require(...)]`
## Bevy version
Bevy 0.15.0-rc.3
## What you did
I have a component, let's say `A`, that requires another component `B` using `#[require(B)]`. `B` then requires another component `C`, but the requirement is registered in... | ```rs
let mut world = World::new();
world.register_required_components::<B, C>();
let result = world.try_register_required_components::<A, B>();
assert!(result.is_ok());
let id = world.spawn(B).id();
assert!(world.entity(id).get::<C>().is_some());
```
The first assertion ... | 2024-11-20T00:43:21Z | 1.82 | 2024-11-22T01:17:37Z | 6178ce93e8537f823685e8c1b617e22ba93696e7 | [
"tests::runtime_required_components_deep_require_does_not_override_shallow_require_deep_subtree_after_shallow"
] | [
"bundle::tests::component_hook_order_insert_remove",
"bundle::tests::insert_if_new",
"change_detection::tests::as_deref_mut",
"bundle::tests::component_hook_order_spawn_despawn_with_macro_hooks",
"bundle::tests::component_hook_order_replace",
"bundle::tests::component_hook_order_spawn_despawn",
"change_... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 16,264 | bevyengine__bevy-16264 | [
"16223"
] | a967c75e92aa08704f11459e4597f6a24bc476c3 | diff --git a/crates/bevy_text/src/text2d.rs b/crates/bevy_text/src/text2d.rs
--- a/crates/bevy_text/src/text2d.rs
+++ b/crates/bevy_text/src/text2d.rs
@@ -11,7 +11,6 @@ use bevy_ecs::component::Component;
use bevy_ecs::{
change_detection::{DetectChanges, Ref},
entity::Entity,
- event::EventReader,
pr... | diff --git a/crates/bevy_text/src/text2d.rs b/crates/bevy_text/src/text2d.rs
--- a/crates/bevy_text/src/text2d.rs
+++ b/crates/bevy_text/src/text2d.rs
@@ -359,7 +358,7 @@ mod tests {
use bevy_app::{App, Update};
use bevy_asset::{load_internal_binary_asset, Handle};
- use bevy_ecs::{event::Events, schedul... | Text doesn't respond correctly to scale changes
## Bevy version
Bevy 0.15.0-rc.2
## What you did
I spawned a `Text2d` during `Setup`
## What went wrong
The text gets a different size and position at a scale factor of 2 compared to a scale factor of 1.
## Additional information
Text that is updated after the scal... | 2024-11-06T16:31:21Z | 1.82 | 2024-11-13T21:42:11Z | 6178ce93e8537f823685e8c1b617e22ba93696e7 | [
"text2d::tests::calculate_bounds_text2d_update_aabb",
"text2d::tests::calculate_bounds_text2d_create_aabb"
] | [
"crates/bevy_text/src/text.rs - text::TextSpan (line 162)"
] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 11,167 | bevyengine__bevy-11167 | [
"10797"
] | 425570aa752b32ef26f6573b385d49d6254bd868 | diff --git a/crates/bevy_ecs/src/storage/blob_vec.rs b/crates/bevy_ecs/src/storage/blob_vec.rs
--- a/crates/bevy_ecs/src/storage/blob_vec.rs
+++ b/crates/bevy_ecs/src/storage/blob_vec.rs
@@ -124,6 +124,23 @@ impl BlobVec {
}
}
+ /// Reserves the minimum capacity for at least `additional` more element... | diff --git a/crates/bevy_ecs/src/storage/blob_vec.rs b/crates/bevy_ecs/src/storage/blob_vec.rs
--- a/crates/bevy_ecs/src/storage/blob_vec.rs
+++ b/crates/bevy_ecs/src/storage/blob_vec.rs
@@ -530,7 +547,7 @@ mod tests {
}
assert_eq!(blob_vec.len(), 1_000);
- assert_eq!(blob_vec.capacity(), 1_0... | BlobVec::push is linear
```rust
#[test]
fn test_quadratic() {
unsafe {
let mut vec = BlobVec::new(Layout::new::<u64>(), None, 0);
for i in 0..100_000_000 {
if i % 1_000_000 == 0 {
println!("{i}");
}
Owni... | 2024-01-01T09:47:01Z | 0.12 | 2024-01-22T15:25:33Z | e6e25dead4d4b274e439f0050a2595b42b009dd2 | [
"storage::blob_vec::tests::blob_vec",
"storage::blob_vec::tests::resize_test"
] | [
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::mut_from_res_mut",
"change_detection::tests::mut_new",
"change_detection::tests::as_deref_mut",
"change_detection::tests::change_tick_wraparound",
"change_detection::tests::mut_untyped_to_refl... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 10,627 | bevyengine__bevy-10627 | [
"10590"
] | 48d10e6d48d0a19ffa32aa195093bfcf8d3a5df0 | diff --git a/crates/bevy_ecs/src/reflect/entity_commands.rs b/crates/bevy_ecs/src/reflect/entity_commands.rs
--- a/crates/bevy_ecs/src/reflect/entity_commands.rs
+++ b/crates/bevy_ecs/src/reflect/entity_commands.rs
@@ -189,15 +189,18 @@ fn insert_reflect(
type_registry: &TypeRegistry,
component: Box<dyn Refle... | diff --git a/crates/bevy_ecs/src/reflect/entity_commands.rs b/crates/bevy_ecs/src/reflect/entity_commands.rs
--- a/crates/bevy_ecs/src/reflect/entity_commands.rs
+++ b/crates/bevy_ecs/src/reflect/entity_commands.rs
@@ -346,17 +349,22 @@ mod tests {
let mut commands = system_state.get_mut(&mut world);
... | `insert_reflect` panics when inserting component
## Bevy version
0.12.0
## What you did
Registered a type, create it from somewhere and then send it by event.
```rust
bullet_ec.insert_reflect(event.bullet_type.clone_value());
```
## What went wrong
```
thread 'main' panicked at T:\packages\cargo\regi... | ~~I also suspect `type_registration.data::<ReflectComponent>()` won't work, for it returns value from internal map by TypeId, which is never exists in `TypeRegistry` of any type.~~
I found this is because I missed `#[reflect(Component)]` | 2023-11-18T09:11:55Z | 0.12 | 2024-01-30T14:10:13Z | e6e25dead4d4b274e439f0050a2595b42b009dd2 | [
"reflect::entity_commands::tests::insert_reflected"
] | [
"change_detection::tests::map_mut",
"change_detection::tests::mut_from_non_send_mut",
"change_detection::tests::mut_new",
"change_detection::tests::mut_untyped_to_reflect",
"change_detection::tests::mut_from_res_mut",
"entity::map_entities::tests::entity_mapper",
"entity::map_entities::tests::world_scop... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 10,103 | bevyengine__bevy-10103 | [
"10086"
] | 88599d7fa06dff6bba434f3a91b57bf8f483f158 | diff --git a/crates/bevy_reflect/src/serde/ser.rs b/crates/bevy_reflect/src/serde/ser.rs
--- a/crates/bevy_reflect/src/serde/ser.rs
+++ b/crates/bevy_reflect/src/serde/ser.rs
@@ -68,7 +68,22 @@ impl<'a> Serialize for ReflectSerializer<'a> {
{
let mut state = serializer.serialize_map(Some(1))?;
st... | diff --git a/crates/bevy_reflect/src/serde/mod.rs b/crates/bevy_reflect/src/serde/mod.rs
--- a/crates/bevy_reflect/src/serde/mod.rs
+++ b/crates/bevy_reflect/src/serde/mod.rs
@@ -8,7 +8,7 @@ pub use type_data::*;
#[cfg(test)]
mod tests {
- use crate::{self as bevy_reflect, DynamicTupleStruct};
+ use crate::{s... | Potential reflect issue: DynamicStruct not registered
## Bevy version
version: current main branch
## What you did
While migrating my crate to the current bevy main, I am facing the current error: "No registration found for bevy_reflect::DynamicStruct" when deserializing a reflected component.
This worked in ... | @MrGVSV I don't follow exactly what's going on / broke here, but this looks like a regression.
Yeah this seems to be an issue with the recent changes to how `TypePath` is used in the reflection serializer. I'll make a PR! | 2023-10-12T23:39:42Z | 1.70 | 2023-10-17T00:03:37Z | 6f27e0e35faffbf2b77807bb222d3d3a9a529210 | [
"serde::tests::should_not_serialize_unproxied_dynamic - should panic",
"serde::tests::should_roundtrip_proxied_dynamic"
] | [
"enums::tests::enum_should_return_correct_variant_type",
"enums::tests::enum_should_allow_generics",
"enums::tests::enum_should_return_correct_variant_path",
"enums::tests::enum_should_allow_struct_fields",
"impls::smol_str::tests::should_partial_eq_smolstr",
"enums::tests::enum_should_allow_nesting_enums... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 9,551 | bevyengine__bevy-9551 | [
"9550"
] | 8edcd8285d27cc16a7052cdb55f9bae85e0b1a2f | diff --git a/crates/bevy_derive/src/derefs.rs b/crates/bevy_derive/src/derefs.rs
--- a/crates/bevy_derive/src/derefs.rs
+++ b/crates/bevy_derive/src/derefs.rs
@@ -68,10 +68,12 @@ fn get_deref_field(ast: &DeriveInput, is_mut: bool) -> syn::Result<(Member, &Typ
let mut selected_field: Option<(Member, &Type)>... | diff --git a/crates/bevy_macros_compile_fail_tests/tests/deref_derive/multiple_fields.pass.rs b/crates/bevy_macros_compile_fail_tests/tests/deref_derive/multiple_fields.pass.rs
--- a/crates/bevy_macros_compile_fail_tests/tests/deref_derive/multiple_fields.pass.rs
+++ b/crates/bevy_macros_compile_fail_tests/tests/deref_... | `#[deref]` fails when properties have other attributes or doc comments: "unexpected token in attribute"
## Bevy version
0.11.2
## What you did
I have a struct with several properties and would like to use the `#[deref]` attribute for one of them.
However, this doesn't work if any of the struct's fields have d... | Replicated! I'll post a fix shortly | 2023-08-23T20:11:45Z | 1.70 | 2023-08-29T06:28:56Z | 6f27e0e35faffbf2b77807bb222d3d3a9a529210 | [
"tests/deref_derive/multiple_fields.pass.rs [should pass]"
] | [
"tests/deref_derive/invalid_attribute.fail.rs [should fail to compile]",
"tests/deref_derive/invalid_item.fail.rs [should fail to compile]",
"tests/deref_derive/missing_attribute.fail.rs [should fail to compile]",
"tests/deref_derive/multiple_attributes.fail.rs [should fail to compile]",
"tests/deref_derive... | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 9,530 | bevyengine__bevy-9530 | [
"751"
] | 5bcc100d108b1b49d7c505682236520ad54797ec | diff --git a/crates/bevy_app/src/plugin_group.rs b/crates/bevy_app/src/plugin_group.rs
--- a/crates/bevy_app/src/plugin_group.rs
+++ b/crates/bevy_app/src/plugin_group.rs
@@ -66,13 +66,25 @@ impl PluginGroupBuilder {
// Insert the new plugin as enabled, and removes its previous ordering if it was
// already p... | diff --git a/crates/bevy_app/src/plugin_group.rs b/crates/bevy_app/src/plugin_group.rs
--- a/crates/bevy_app/src/plugin_group.rs
+++ b/crates/bevy_app/src/plugin_group.rs
@@ -335,4 +367,48 @@ mod tests {
]
);
}
+
+ #[test]
+ fn add_basic_subgroup() {
+ let group_a = PluginGroupBu... | Enable subgroups for PluginGroups
The primary place I see this being used is for DefaultPlugins.
Would allow bevies' default plugins to to take advantage of PluginGroups with only a PluginGroup instead of a Plugin + PluginGroup.
Example API:
```rust
// Implements Plugin
pub struct FooPlugin;
// Implements Plugi... | 2023-08-22T02:51:39Z | 1.76 | 2024-05-27T09:08:24Z | c9ec95d7827297528d0779e3fd232dfc2e3cbed7 | [
"plugin_group::tests::add_after",
"plugin_group::tests::add_before",
"plugin_group::tests::basic_ordering",
"plugin_group::tests::readd",
"plugin_group::tests::readd_after",
"app::tests::test_derive_app_label",
"plugin_group::tests::readd_before",
"app::tests::cant_call_app_run_from_plugin_build - sho... | [] | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 8,691 | bevyengine__bevy-8691 | [
"8596"
] | 735f9b60241000f49089ae587ba7d88bf2a5d932 | diff --git a/crates/bevy_reflect/src/impls/std.rs b/crates/bevy_reflect/src/impls/std.rs
--- a/crates/bevy_reflect/src/impls/std.rs
+++ b/crates/bevy_reflect/src/impls/std.rs
@@ -374,6 +374,12 @@ macro_rules! impl_reflect_for_hashmap {
.map(|(key, value)| (key as &dyn Reflect, value as &dyn Reflect... | diff --git a/crates/bevy_reflect/src/map.rs b/crates/bevy_reflect/src/map.rs
--- a/crates/bevy_reflect/src/map.rs
+++ b/crates/bevy_reflect/src/map.rs
@@ -491,6 +500,8 @@ pub fn map_apply<M: Map>(a: &mut M, b: &dyn Reflect) {
#[cfg(test)]
mod tests {
use super::DynamicMap;
+ use super::Map;
+ use crate::re... | Add `get_at_mut` to `Map` trait
## What problem does this solve or what need does it fill?
Currently the solution to getting a mutable reference to the key/value at an index of a map is to get the key and value immutably, clone the key, then use that to index the map. This is unnecessarily inefficient and could easi... | I assume this is for ordered maps? In which case, I think it makes sense to add these kinds of methods, but with a disclaimer that not all maps guarantee a particular order.
Technically this is for any map actually; which makes me realize we need `.iter_mut()` as well to do what I'm doing properly, as I'm just relying ... | 2023-05-27T05:00:49Z | 1.67 | 2023-07-10T00:11:01Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"enums::tests::enum_should_allow_struct_fields",
"enums::tests::enum_should_allow_nesting_enums",
"impls::std::tests::can_serialize_duration",
"enums::tests::should_get_enum_type_info",
"impls::std::tests::instant_should_from_reflect",
"impls::std::tests::nonzero_usize_impl_reflect_from_reflect",
"enums... | [] | [] | [] | auto_2025-06-08 |
bevyengine/bevy | 8,476 | bevyengine__bevy-8476 | [
"8474"
] | abf12f3b3be0a537484aa3ce0adc625f627c413a | diff --git a/crates/bevy_hierarchy/src/hierarchy.rs b/crates/bevy_hierarchy/src/hierarchy.rs
--- a/crates/bevy_hierarchy/src/hierarchy.rs
+++ b/crates/bevy_hierarchy/src/hierarchy.rs
@@ -46,9 +46,9 @@ fn despawn_with_children_recursive_inner(world: &mut World, entity: Entity) {
}
}
-fn despawn_children(world: &... | diff --git a/crates/bevy_hierarchy/src/hierarchy.rs b/crates/bevy_hierarchy/src/hierarchy.rs
--- a/crates/bevy_hierarchy/src/hierarchy.rs
+++ b/crates/bevy_hierarchy/src/hierarchy.rs
@@ -226,4 +224,26 @@ mod tests {
]
);
}
+
+ #[test]
+ fn despawn_descendants() {
+ let mut world ... | `despawn_descendants` does not clear `Children` component on parent entity
## Bevy version
0.10
## What you did
Call `.despawn_descendants` either via `Commands` or directly on the `World` via `.entity_mut()`.
## What went wrong
The parent's `Children` component is not cleared.
## Additional informati... | 2023-04-23T19:29:09Z | 1.67 | 2025-01-28T04:46:47Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"hierarchy::tests::despawn_descendants"
] | [
"child_builder::tests::build_children",
"child_builder::tests::children_removed_when_empty_commands",
"child_builder::tests::add_child",
"child_builder::tests::children_removed_when_empty_world",
"child_builder::tests::push_and_insert_and_remove_children_world",
"child_builder::tests::regression_push_chil... | [] | [] | auto_2025-06-08 | |
bevyengine/bevy | 8,467 | bevyengine__bevy-8467 | [
"8463"
] | 15a96adc01d9b9df4237290efd7f0020b50482ae | diff --git a/crates/bevy_time/src/timer.rs b/crates/bevy_time/src/timer.rs
--- a/crates/bevy_time/src/timer.rs
+++ b/crates/bevy_time/src/timer.rs
@@ -224,10 +224,17 @@ impl Timer {
if self.finished() {
if self.mode == TimerMode::Repeating {
- self.times_finished_this_tick =
- ... | diff --git a/crates/bevy_time/src/timer.rs b/crates/bevy_time/src/timer.rs
--- a/crates/bevy_time/src/timer.rs
+++ b/crates/bevy_time/src/timer.rs
@@ -517,6 +528,26 @@ mod tests {
assert_eq!(t.times_finished_this_tick(), 0);
}
+ #[test]
+ fn times_finished_this_tick_repeating_zero_duration() {
+ ... | Setting the timer duration to zero panicks
## Bevy version
bevy 0.10.1
## What you did
I set a repeating timers duration to 0. I did so accidentally using the egui_inspector, but is also reproducible if setting it via code.
## What went wrong
Bevy panicked, because it can't divide by 0.
thread 'Compute... | Also I'm not entirely sure what the expected behaviour would be in a case like that (except it not panicking :) ).
I'm not 100% sure what the correct behavior is here either, but it shouldn't be too hard to investigate. | 2023-04-22T22:00:36Z | 1.67 | 2023-04-24T15:17:08Z | 735f9b60241000f49089ae587ba7d88bf2a5d932 | [
"timer::tests::times_finished_this_tick_repeating_zero_duration"
] | [
"time::tests::wrapping_test",
"time::tests::pause_test",
"time::tests::update_test",
"common_conditions::tests::distributive_run_if_compiles",
"timer::tests::times_finished_this_tick",
"timer::tests::paused_repeating",
"fixed_timestep::test::fixed_time_starts_at_zero",
"timer::tests::times_finished_th... | [] | [] | auto_2025-06-08 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.