Datasets:
r1v3r
/
biomejs_biome

Dataset card Data Studio Files
xet
 Community
1
repo
string
pull_number
int64
instance_id
string
issue_numbers
list
base_commit
string
patch
string
test_patch
string
problem_statement
string
hints_text
string
created_at
string
version
string
updated_at
string
environment_setup_commit
string
FAIL_TO_PASS
list
PASS_TO_PASS
list
FAIL_TO_FAIL
list
PASS_TO_FAIL
list
source_dir
string
biomejs/biome
2,324
biomejs__biome-2324
[ "2303" ]
75af8016b50476ae32193ec87c475e182925e9e0
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -273,6 +273,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Implement [#2043](https://github.com/biomejs/biome/issues/2043): The React rule [`useExhaustiveDependencies`](https://biomejs.dev/linte...
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2620,6 +2620,9 @@ pub struct Nursery { #[doc = "Disallow using export or module.exports in files...
📎 Implement `lint/noFlatMapIdentity` - `clippy/flat_map_identity` ### Description Implement [flat_map_identity](https://rust-lang.github.io/rust-clippy/master/#/flat_map_identity). **Want to contribute?** Lets you know you are interested! We will assign you to the issue to prevent several people to work on the sam...
i'm interested
2024-04-06T05:05:24Z
0.5
2024-04-14T14:31:41Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::diagnostic_size", "diagnostics::test::deserialization_quick_check", "diagnostics::test::deserialization_error", "diagnostics::test::config_already_exists" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,317
biomejs__biome-2317
[ "2245" ]
2b1919494d8eb62221db1742552fea20698d585d
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Analyzer +#### Bug fixes + +- Now Biome can detect the script language in Svelte and Vue script blocks more reliably ([#2245](https:...
diff --git a/crates/biome_cli/tests/cases/handle_svelte_files.rs b/crates/biome_cli/tests/cases/handle_svelte_files.rs --- a/crates/biome_cli/tests/cases/handle_svelte_files.rs +++ b/crates/biome_cli/tests/cases/handle_svelte_files.rs @@ -6,26 +6,38 @@ use biome_service::DynRef; use bpaf::Args; use std::path::Path; ...
🐛 In Svelte context=module Scripts error "import { type x ident }' are a TypeScript only feature." ### Environment information ```block CLI: Version: 1.6.3 Color support: true Platform: CPU Architecture: aarch64 OS: macos Envi...
MouseEvent also fails with code below, interestingly only that part, interface itself does not produce any errors. "Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax." ```svelte <script context="module" lang="ts"> export interface ButtonProps { onclick...
2024-04-05T08:58:51Z
0.5
2024-04-05T11:40:48Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "commands::check_options" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,300
biomejs__biome-2300
[ "2296" ]
60671ec3a4c59421583d5d1ec8cfe30d45b27cd7
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -167,6 +167,12 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ``` </details> +- Added new `--staged` flag to the `check`, `format` and `lint` subcommands. + + This new option allows users to a...
diff --git a/crates/biome_cli/src/commands/mod.rs b/crates/biome_cli/src/commands/mod.rs --- a/crates/biome_cli/src/commands/mod.rs +++ b/crates/biome_cli/src/commands/mod.rs @@ -510,6 +525,34 @@ pub(crate) fn get_stdin( Ok(stdin) } +fn get_files_to_process( + since: Option<String>, + changed: bool, + ...
📎 Feature: --staged option to simplify the creation of git hook scripts ### Description ## Problem Statement As of today, `biome` does not provide a direct mechanism to select (for linting, formatting or checking) only the files that are staged for a commit. We have a "similar" flag, `--changed`, but its main...
2024-04-04T10:25:43Z
0.5
2024-04-12T14:21:49Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::negated_pattern", "execute::migrate::ignorefile::tests::empty", "execute::migrate::eslint_to_biome::tests::flat_config_single_config_object", "execute::m...
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,292
biomejs__biome-2292
[ "2288" ]
cc04271f337cdd5a8af583aed09a44cb72b17a82
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### CLI +#### Bug fixes + +- Biome now tags the diagnostics emitted by `organizeImports` and `formatter` with correct severity levels, s...
diff --git a/crates/biome_cli/tests/cases/diagnostics.rs b/crates/biome_cli/tests/cases/diagnostics.rs --- a/crates/biome_cli/tests/cases/diagnostics.rs +++ b/crates/biome_cli/tests/cases/diagnostics.rs @@ -137,3 +137,60 @@ fn max_diagnostics_verbose() { result, )); } + +#[test] +fn diagnostic_level() { ...
🐛 `organizeImports` causes check to fail but does not print errors with `--diagnostic-level=error` ### Environment information ```block > biome-sandbox@1.0.0 rage > biome rage CLI: Version: 1.6.4 Color support: true Platform: CPU Architecture: x86_64 ...
2024-04-04T03:40:59Z
0.5
2024-04-07T04:36:07Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::protected_files::not_process_file_from_stdin_verbose_lint", "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration", "cases::overrides_formatter::does_handle_included_file_and_disable_formatter", "cases::config_extends::extends_should_raise_an_error_for_unresolved_configura...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_timing", "metrics::tests::test_layer", "commands::check_options" ]
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,250
biomejs__biome-2250
[ "2243" ]
cad1cfd1e8fc7440960213ce49130670dc90491d
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Analyzer +#### Bug fixes + +- An operator with no spaces around in a binary expression no longer breaks the js analyzer ([#2243](htt...
diff --git a/crates/biome_js_analyze/src/utils.rs b/crates/biome_js_analyze/src/utils.rs --- a/crates/biome_js_analyze/src/utils.rs +++ b/crates/biome_js_analyze/src/utils.rs @@ -186,4 +186,27 @@ mod test { assert_eq!(position, None); } + + #[test] + fn find_variable_position_when_the_operator_has...
📝 biom crashed ### Environment information ```bash ❯ pnpm biome check . --apply Biome encountered an unexpected error This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fix...
This error is thrown from this function. Would you please help us narrow down the source code file which triggers this error? https://github.com/biomejs/biome/blob/edacd6e6e2df813be67beec18fa84e0b7c0c5be9/crates/biome_js_analyze/src/utils.rs#L79-L112 ### New information: This is caused by a minified file If I f...
2024-03-31T14:34:47Z
0.5
2024-03-31T16:09:30Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "utils::test::find_variable_position_when_the_operator_has_no_spaces_around" ]
[ "assists::correctness::organize_imports::test_order", "globals::javascript::node::test_order", "globals::javascript::language::test_order", "globals::module::node::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[]
[]
auto_2025-06-09
biomejs/biome
2,220
biomejs__biome-2220
[ "2217" ]
b6d4c6e8108c69882d76863a1340080fd2c1fbdc
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -73,6 +73,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Add rule [noEvolvingAny](https://biomejs.dev/linter/rules/no-evolving-any) to disallow variables from evolving into `any` type through r...
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -124,8 +124,8 @@ define_categories! { "lint/nursery/noNodejsModules":...
💅 Rename `noSemicolonInJsx` rule? ### Environment information ```bash irrelevant ``` ### Rule name noSemicolonInJsx ### Playground link https://biomejs.dev/playground/?code=LwAvACAAaABhAGQAIAB0AG8AIABmAGkAbABsACAAdABoAGUAIAAiAFAAbABhAHkAZwByAG8AdQBuAGQAIABsAGkAbgBrACIAIABmAGkAZQBsAGQAIAB3AGkAdABoACAAcwBvAG0AZQB0...
@fujiyamaorange would you like to help? Unfortunately we didn't catch the name of the name early. Thankfully it's still in nursery 🙂 @nstepien Thank you for the comment. As you mentioned, >I do realize that it'll end up under the suspicious group though, so maybe that's why it was named noSemicolonInJsx? this...
2024-03-27T00:48:19Z
0.5
2024-03-28T03:06:24Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "assists::correctness::organize_imports::test_order", "globals::javascript::language::test_order", "globals::javascript::node::test_order", "globals::module::node::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[ "target/debug/build/biome_diagnostics_categories-50cc392058e367b8/out/categories.rs - category (line 6)" ]
[]
[]
auto_2025-06-09
biomejs/biome
2,204
biomejs__biome-2204
[ "2191" ]
62fbec86467946e8d71dcd0098e3d90443208f78
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,28 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). +## Unreleased + +### Analyze...
diff --git a/crates/biome_cli/tests/commands/lint.rs b/crates/biome_cli/tests/commands/lint.rs --- a/crates/biome_cli/tests/commands/lint.rs +++ b/crates/biome_cli/tests/commands/lint.rs @@ -1918,6 +1918,52 @@ fn top_level_all_down_level_empty() { )); } +#[test] +fn group_level_disable_recommended_enable_specif...
💅 recommended: false disables all nested rules ### Environment information ```bash CLI: Version: 1.6.2 Color support: true Platform: CPU Architecture: x86_64 OS: linux Environment: BIOME_LOG_DIR: unset NO_...
~~Sorry, I think this is a regression introduced in #2072, I'll fix it ASAP.~~ It's not a regression, it's a long-existing bug.
2024-03-25T17:24:38Z
0.5
2024-03-26T02:48:16Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::group_level_disable_recommended_enable_specific", "commands::lint::lint_help", "commands::lsp_proxy::lsp_proxy_help", "commands::rage::rage_help...
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "execute::migrate::prettier::test::ok", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "commands::check_options", "cases::protected_files::not_process_file_from_stdin_format", "cases::c...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,169
biomejs__biome-2169
[ "2164" ]
95974a106067083c32066eee28ff95cbc3db9a31
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,30 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). +## Unreleased + +### Analyze...
diff --git /dev/null b/crates/biome_cli/tests/cases/config_path.rs new file mode 100644 --- /dev/null +++ b/crates/biome_cli/tests/cases/config_path.rs @@ -0,0 +1,55 @@ +use crate::run_cli; +use crate::snap_test::{assert_cli_snapshot, SnapshotPayload}; +use biome_console::BufferConsole; +use biome_fs::MemoryFileSystem;...
--config-path fails with JSONC ### Environment information ```block I am using pre-commit hook, where I've overridden the entry, to benefit from `--config-path` argument, as my config file is in a subdirectory. CLI: Version: 1.6.2 Color support: true Platform: CPU Arc...
Could you please tell us how you use the argument via CLI? I point it to the containing directory of the config file, in this example that would be `biome check --config-path=./src` I'll work on this.
2024-03-23T06:22:32Z
0.5
2024-03-23T14:42:31Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::config_path::set_config_path", "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_help", "commands::lsp_proxy::lsp_proxy_help", "commands::migrate::migrate_help", "commands::rage::...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "cases::biome_json_support::ci_biome_json", "cases::biome_json_support::check_biome_json", "cases:...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,116
biomejs__biome-2116
[ "2114" ]
984626de115e4b8f64dec97d3f66ba353ebf1b65
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). -## Ureleased +## Unreleased ...
diff --git /dev/null b/crates/biome_cli/tests/cases/cts_files.rs new file mode 100644 --- /dev/null +++ b/crates/biome_cli/tests/cases/cts_files.rs @@ -0,0 +1,35 @@ +use crate::run_cli; +use crate::snap_test::{assert_cli_snapshot, SnapshotPayload}; +use biome_console::BufferConsole; +use biome_fs::MemoryFileSystem; +us...
🐛 Typescripts "Module" syntax is invalid for typescript-enabled common js ### Environment information ```block CLI: Version: 1.6.1 Color support: true Platform: CPU Architecture: aarch64 OS: linux Environment: BIOME_LOG_DIR...
2024-03-17T08:06:29Z
0.5
2024-03-18T12:40:11Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::cts_files::should_allow_using_export_statements" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "execute::migrate::prettier::test::ok", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "cases::protected_files::not_process_file_from_stdin_lint", "cases::protected_files::not_process_fil...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,103
biomejs__biome-2103
[ "1752" ]
2b1919494d8eb62221db1742552fea20698d585d
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -714,7 +790,7 @@ Additionally, the following rules are now recommended: ```diff - <div class="px-2 foo p-4 bar" /> - + <div class="foo·bar·p-4·px-2" /> + + <div class="foo bar p-4 px-2" /> ``` Contributed by @DaniGuardiola...
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,8 +21,84 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b #### New features +- Add a command to migrate from ESLint + + `@biomejs/biome migrate eslint` allows you to migrate an ESLint configura...
📎 Add command `biome migrate eslint` ## Description We want to create a new command, `biome migrate eslint`, which will attempt to determine the rules configured in eslint and update the `biome.json` with rules that have a source in Biome. Plus, it will attempt to read `.eslintignore` file and map the glob pat...
> Computing the rules that applied by eslint by reading the configuration file isn't an easy task, mainly because the majority of the projects out there use JavaScript to write their configuration file. We could invoke eslint with the [`--print-config` CLI flag](https://eslint.org/docs/latest/use/command-line-interf...
2024-03-15T13:11:19Z
0.5
2024-04-10T10:09:23Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::diagnostics::logs_the_appropriate_messages_according_to_set_diagnostics_level", "cases::config_extends::allows_reverting_fields_in_extended_config_to_default", "cases::config_extends::respects_unaffected_values_from_extended_config", "cases::overrides_formatter::does_include_file_with_different_format...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::tests::ok", "metrics::tests::test_timing", "execute::migrate::prettier::tests::some_properties", "metrics::tests::test_layer", "commands::check_options" ]
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,072
biomejs__biome-2072
[ "2028" ]
409eb1083ede5b887e35f4dfa80f860490823b8c
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,28 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). +## Ureleased + +### Analyzer...
diff --git a/crates/biome_cli/tests/commands/lint.rs b/crates/biome_cli/tests/commands/lint.rs --- a/crates/biome_cli/tests/commands/lint.rs +++ b/crates/biome_cli/tests/commands/lint.rs @@ -1866,6 +1866,58 @@ fn top_level_not_all_down_level_all() { )); } +#[test] +fn top_level_all_down_level_empty() { + let...
💅 Regression: Disabling one nursery rule disables all nursery rules ### Environment information ```bash CLI: Version: 1.6.0 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: ...
I don't think this is a bug because as the schema says the `lint.rules.all` won't enable nursery rules: ![image](https://github.com/biomejs/biome/assets/10386119/56de79aa-3364-4694-9cb8-4f95bfce493d) If you want to enable all the rules in the nursery group, you should use `lint.rules.nursery.all`. And you can dis...
2024-03-13T03:42:02Z
0.5
2024-03-13T12:17:28Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::lint::top_level_all_down_level_empty", "commands::version::ok" ]
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "commands::check::apply_suggested_error", "cases::protected_files::not_process_file_from_stdin_verbo...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,044
biomejs__biome-2044
[ "1941" ]
57fa9366d1a8635fda6faef7970c0d53c6538399
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -56,6 +56,11 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Parser +#### Bug fixes + +- JavaScript lexer is now able to lex regular expression literals with escaped non-ascii chars ([#1941](ht...
diff --git a/crates/biome_js_parser/src/syntax/expr.rs b/crates/biome_js_parser/src/syntax/expr.rs --- a/crates/biome_js_parser/src/syntax/expr.rs +++ b/crates/biome_js_parser/src/syntax/expr.rs @@ -156,6 +156,7 @@ pub(crate) fn parse_expression_or_recover_to_next_statement( // new-line"; // /^[يفمئامئ‍ئاسۆند]/i; //r...
🐛 Including smart-quote `‘` with escape `\` confuses the JS lexer ### Environment information ```block CLI: Version: 1.5.3 Color support: true Platform: CPU Architecture: x86_64 OS: macos Environment: BIOME_LOG_DIR: ...
An observation: the crash of the playground seems to be the result of an out of range position acquired from the diagnostics. So it should be automatically fixed if the root cause is fixed. And apart from smart quotes, Chinese characters will also trigger the similar problem. Just type (or copy paste) `一'` into the p...
2024-03-11T11:40:02Z
0.5
2024-03-11T15:33:56Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "tests::parser::ok::literals_js" ]
[ "lexer::tests::bang", "lexer::tests::are_we_jsx", "lexer::tests::bigint_literals", "lexer::tests::at_token", "lexer::tests::binary_literals", "lexer::tests::all_whitespace", "lexer::tests::consecutive_punctuators", "lexer::tests::complex_string_1", "lexer::tests::division", "lexer::tests::block_co...
[]
[]
auto_2025-06-09
biomejs/biome
2,030
biomejs__biome-2030
[ "2008" ]
870989d3675ff58707b3a801a407f03a2e790f04
diff --git a/crates/biome_fs/src/fs.rs b/crates/biome_fs/src/fs.rs --- a/crates/biome_fs/src/fs.rs +++ b/crates/biome_fs/src/fs.rs @@ -81,81 +81,83 @@ pub trait FileSystem: Send + Sync + RefUnwindSafe { should_error_if_file_not_found: bool, ) -> AutoSearchResultAlias { let mut from_parent = false...
diff --git a/crates/biome_cli/tests/commands/rage.rs b/crates/biome_cli/tests/commands/rage.rs --- a/crates/biome_cli/tests/commands/rage.rs +++ b/crates/biome_cli/tests/commands/rage.rs @@ -83,6 +83,37 @@ fn with_configuration() { )); } +#[test] +fn with_jsonc_configuration() { + let mut fs = MemoryFileSyst...
🐛 biome.jsonc is not being used. ### Environment information ```block CLI: Version: 1.6.0 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: unset NO_COLOR: ...
Yeah I can see from the biome rage output that the configuration is unset I have the same problem, the `biome.jsonc` is simply ignored. macOS 14.1 (arm). The problem is in `auto_search` loops. I want to give this a try :)
2024-03-10T10:31:42Z
0.5
2024-03-11T20:36:34Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::version::ok" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "execute::migrate::prettier::test::ok", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "cases::protected_files::not_process_file_from_stdin_verbose_lint", "commands::check::apply_suggeste...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
1,935
biomejs__biome-1935
[ "1848" ]
ad0a0b57a1a16b62536619ccf8093a131311f00f
diff --git a/crates/biome_js_analyze/src/lint/a11y/use_valid_aria_role.rs b/crates/biome_js_analyze/src/lint/a11y/use_valid_aria_role.rs --- a/crates/biome_js_analyze/src/lint/a11y/use_valid_aria_role.rs +++ b/crates/biome_js_analyze/src/lint/a11y/use_valid_aria_role.rs @@ -42,7 +42,7 @@ declare_rule! { /// </> ...
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -119,6 +119,7 @@ define_categories! { "lint/nursery/noExcessiveNested...
☂️ Lint rules for testing frameworks ### Description We want to implement some lint rules to help people with their tests. I baked this list from the `eslint-plugin-jest` and evaluated only those rules that **aren't** pedantic and can be enabled for multiple test runners: `mocha`, `jest`, `node:test`, etc. Feel f...
I am picking `noDuplicateTestHooks`. Can I work on `noExportsInTest`? I am working on `noNestedTestSuites`. I will work on `noMisplacedAssertion` I am working on `noDoneCallback`.
2024-02-28T09:22:02Z
0.5
2024-04-15T13:13:42Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "assists::correctness::organize_imports::test_order", "globals::javascript::node::test_order", "globals::javascript::language::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::module::node::test_order", "globals::typescript::language::test_order", ...
[ "directive_ext::tests::js_directive_inner_string_text", "expr_ext::test::doesnt_static_member_expression_deep", "expr_ext::test::matches_simple_call", "expr_ext::test::matches_static_member_expression", "expr_ext::test::matches_static_member_expression_deep", "numbers::tests::base_10_float", "numbers::t...
[]
[]
auto_2025-06-09
biomejs/biome
1,912
biomejs__biome-1912
[ "1750" ]
2a841396834f030946f469143b1b6c632a744f85
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -378,6 +378,12 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ``` Contributed by @fujiyamaorange +- Add rule [noBarrelFile](https://biomejs.dev/linter/rules/no-barrel-file), to report the usage...
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -102,6 +102,7 @@ define_categories! { "lint/correctness/useValidForDi...
📎 Create lint rules for barrel files ### Description We would want to implement the rules that belong to: https://github.com/thepassle/eslint-plugin-barrel-files - [x] `noBarrelFile` -> [barrel-files/avoid-barrel-files](https://github.com/thepassle/eslint-plugin-barrel-files/blob/main/docs/rules/avoid-barrel-fil...
Can I work on "noReExportAll"?? Sure go ahead! I made a pr for `noNamespaceImport`. I'll try `noBarrelFile`:)
2024-02-25T16:24:35Z
0.4
2024-02-28T14:27:09Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "globals::browser::test_order", "globals...
[ "target/debug/build/biome_diagnostics_categories-d35c1acfd32ea72c/out/categories.rs - category (line 6)" ]
[]
[]
auto_2025-06-09
biomejs/biome
1,881
biomejs__biome-1881
[ "927" ]
c3a05f78293fe8153b713922a54069da0214d1fb
diff --git a/crates/biome_js_analyze/src/options.rs b/crates/biome_js_analyze/src/options.rs --- a/crates/biome_js_analyze/src/options.rs +++ b/crates/biome_js_analyze/src/options.rs @@ -142,6 +142,7 @@ pub type NoSelfAssign = <analyzers::correctness::no_self_assign::NoSelfAssign as biome_analyze::Rule>::Options; ...
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -117,6 +117,7 @@ define_categories! { "lint/nursery/noNodejsModules":...
📎 `lint/noSuspiciousSemicolonInJSX`: disallow suspicious `;` in JSX ### Description I don't know if such a lint rule exists in other tools, but this is an issue I've ran into a few times before. Basically, I'd like to have a rule to catch semicolons that may have been introduced in the JSX after a copy/paste or...
Have you some name·s to suggest? `noSuspiciousSemicolonInJSX` maybe? @Conaclos May I try this issue? All yours @fujiyamaorange
2024-02-21T13:20:33Z
0.4
2024-02-26T11:22:20Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "configuration::diagnostics::test::diagnostic_size", "diagnostics::test::diagnostic_size", "configuration::diagnostics::test::deserialization_quick_check", "file_handlers::test_order", "matcher::pattern::test::test_matches_path", "matcher::pattern::test::test_path_join", "configuration::test::resolver_t...
[ "target/debug/build/biome_diagnostics_categories-d35c1acfd32ea72c/out/categories.rs - category (line 6)" ]
[]
[]
auto_2025-06-09
biomejs/biome
1,843
biomejs__biome-1843
[ "1754" ]
48f9998622ba4e0d66cbd4299c6a87d32253570f
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Now the file name printed in the diagnostics is clickable. If you run the CLI from your editor, you can <kbd>Ctrl</kbd>/<kbd title="Cmd"...
diff --git a/crates/biome_cli/tests/commands/rage.rs b/crates/biome_cli/tests/commands/rage.rs --- a/crates/biome_cli/tests/commands/rage.rs +++ b/crates/biome_cli/tests/commands/rage.rs @@ -181,6 +181,132 @@ Not most recent log file )); } +#[test] +fn with_formatter_configuration() { + let mut fs = MemoryFi...
📎 Add `--formatter` to the command `biome rage` ### Description We want to add a new option called `--formatter` to the command `biome rage`. The command is meant to print helpful information for us maintainers. With the `--foramtter` option, we want to print a list of the options currently applied by the current ...
2024-02-17T07:38:13Z
0.4
2024-02-20T17:22:16Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "commands::version::ok", "commands::rage::rage_help", "commands::rage::with_formatter_configuration", "commands::rage::with_linter_configuration" ]
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "cases::protected_files::not_process_file_from_stdin_verbose_format", "cases::config_extends::extend...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
1,806
biomejs__biome-1806
[ "1786" ]
dca6a7a8a7db39789cfb0fa8164d8b7a47e9becd
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -199,6 +199,27 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom Contributed by @Conaclos +- [useNamingConvention](https://biomejs.dev/linter/rules/use-naming-convention) now supports [unicase](htt...
diff --git a/crates/biome_js_analyze/src/utils/case.rs b/crates/biome_js_analyze/src/utils/case.rs --- a/crates/biome_js_analyze/src/utils/case.rs +++ b/crates/biome_js_analyze/src/utils/case.rs @@ -297,6 +299,159 @@ impl std::fmt::Display for Case { mod tests { use super::*; + #[test] + fn test_case_iden...
💅 `useNamingConvention` can suggest useless fix ### Environment information Used [`biome-linux-x64` binary from the release](https://github.com/biomejs/biome/releases/tag/cli%2Fv1.5.3) (sha256sum: `adf8a6029f43ac6eb07c86519f7ff08875915acec082d0be9393888044806243`) ``` CLI: Version: 1....
I suppose we should ignore identifiers that aren't UTF-8 > I suppose we should ignore identifiers that aren't UTF-8 AFAIK, Korean characters can be represented as UTF-8. Not 100% sure, but most likely concepts such as camel casing and such only apply to _latin_ scripts. Note that Koreans mostly do not prefer to w...
2024-02-13T12:13:06Z
0.4
2024-02-13T16:07:03Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "assists::correctness::organize_imports::test_order", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_co...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,800
biomejs__biome-1800
[ "1652" ]
dca6a7a8a7db39789cfb0fa8164d8b7a47e9becd
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -201,6 +201,27 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### Bug fixes +- [noInvalidUseBeforeDeclaration](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration) no longer report...
diff --git a/crates/biome_js_analyze/src/react/hooks.rs b/crates/biome_js_analyze/src/react/hooks.rs --- a/crates/biome_js_analyze/src/react/hooks.rs +++ b/crates/biome_js_analyze/src/react/hooks.rs @@ -239,45 +239,26 @@ pub fn is_binding_react_stable( model: &SemanticModel, stable_config: &FxHashSet<StableRe...
💅 `noUnusedVariables` - false-positive for param destructuring if it's used as a default value for another destructured param ### Environment information ```bash CLI: Version: 1.5.2 Color support: true Platform: CPU Architecture: x86_64 OS: ...
Related to https://github.com/biomejs/biome/issues/1648
2024-02-12T21:24:49Z
0.4
2024-02-13T14:04:45Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "assists::correctness::organize_imports::t...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,747
biomejs__biome-1747
[ "1697" ]
ee9b3ac6c7338f7718bf685159daf90e4396b583
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -129,6 +129,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#1704](https://github.com/biomejs/biome/issues/1704). Convert `/` to escaped slash `\/` to avoid parsing error in the result of au...
diff --git a/crates/biome_js_analyze/tests/spec_tests.rs b/crates/biome_js_analyze/tests/spec_tests.rs --- a/crates/biome_js_analyze/tests/spec_tests.rs +++ b/crates/biome_js_analyze/tests/spec_tests.rs @@ -2,7 +2,7 @@ use biome_analyze::{AnalysisFilter, AnalyzerAction, ControlFlow, Never, RuleFilt use biome_diagnosti...
"Suppress rule" quickfix removes indentation Biome version `1.5.3` VSCode version `1.85.2` Extension version `2.1.2` Steps: 1. Enable `lint/suspicious/noAssignInExpressions` and `lint/suspicious/noConsoleLog`. 2. Code ```typescript // file.ts export function foo() { let x: number; ...
For anyone who wants to help with this issue, the code to fix the issue should be here: https://github.com/biomejs/biome/blob/f7d4683f1027c8f5d046c130069141141e8aab6f/crates/biome_js_analyze/src/suppression_action.rs#L117-L154
2024-02-04T12:09:35Z
0.4
2024-02-04T19:29:58Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "no_assign_in_expressions_ts", "no_double_equals_jsx", "specs::correctness::no_unused_variables::valid_class_ts", "no_array_index_key_jsx" ]
[ "specs::complexity::no_excessive_cognitive_complexity::boolean_operators2_options_json", "specs::complexity::no_excessive_cognitive_complexity::boolean_operators_options_json", "specs::a11y::no_autofocus::valid_jsx", "specs::a11y::no_aria_unsupported_elements::valid_jsx", "specs::a11y::no_redundant_roles::v...
[]
[]
auto_2025-06-09
biomejs/biome
1,712
biomejs__biome-1712
[ "1706" ]
d04c2c45db4950ebf341017a4b88fe9d2ce04a11
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Biome now allows to format the `package.json` file. This is now the default behaviour and users can remove their workarounds. If you r...
diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs --- a/crates/biome_cli/tests/commands/format.rs +++ b/crates/biome_cli/tests/commands/format.rs @@ -114,6 +114,25 @@ const APPLY_BRACKET_SAME_LINE_AFTER: &str = r#"<Foo </Foo>; "#; +const APPLY_ATTRIBUTE_POSITION_BEFO...
📎 Implement format option `singleAttributePerLine` ### Description From the discussion https://github.com/biomejs/biome/discussions/698 It would be great if someone wanted to implement this option. Here's the prettier reference: https://prettier.io/docs/en/options#single-attribute-per-line I'm happy to rep...
Hi @ematipico ! I've start working on this issue and have 1 question about running specific jsx tests with newly added configuration option `singleAttributePerLine`. For now add this in crates/biome_js_formatter/tests/prettier_tests.rs for options variable, but it apply for all tests and i have a lot of snapshot chang...
2024-01-30T20:17:46Z
0.4
2024-02-03T11:41:50Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "commands::check::check_help", "commands::ci::ci_help", "commands::format::applies_custom_attribute_position", "commands::format::format_help", "commands::migrate::prettier_migrate_write", "commands::version::ok", "commands::migrate::prettier_migrate_write_with_ignore_file", "commands::migrate::pretti...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "commands::check::fs_error_infinite_symlink_expansion_to_files", "cases::biome_json_support::check_b...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
1,614
biomejs__biome-1614
[ "1607" ]
a03bf8580bc688747a1f17bc6b31951768494cec
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,12 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom Contributed by @Conaclos +- Don't format **ignored** files that are well-known JSONC files when `files.ignoreUnknown` is enabled ([#16...
diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs --- a/crates/biome_cli/tests/commands/format.rs +++ b/crates/biome_cli/tests/commands/format.rs @@ -2730,3 +2730,47 @@ fn format_with_configured_line_ending() { "const b = {\r\n\tname: \"mike\",\r\n\tsurname: \"r...
🐛 IgnoreUnknown resulting in additional file being formatted ### Environment information ```block Biome 1.5.2 ``` ### What happened? When using `ignoreUnknown`, special files like `.eslintrc` seem to be formatted, even if they're not in the include list Reproduction here: https://github.com/anthonyhayesres/biome-...
2024-01-20T13:33:20Z
0.4
2024-01-20T13:48:31Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "commands::format::don_t_format_ignored_known_jsonc_files", "commands::version::ok", "file_handlers::test_order" ]
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "commands::check::fs_error_infinite_symlink_expansion_to_files", "cases::config_extends::extends_sho...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
1,606
biomejs__biome-1606
[ "1349" ]
2dfb1420e208f0a11516c016f0055ecc67353a44
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,18 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom ### Configuration +#### Bug fixes + +- Override correctly the recommended preset ([#1349](https://github.com/biomejs/biome/issues/1349))...
diff --git a/crates/biome_cli/tests/cases/overrides_linter.rs b/crates/biome_cli/tests/cases/overrides_linter.rs --- a/crates/biome_cli/tests/cases/overrides_linter.rs +++ b/crates/biome_cli/tests/cases/overrides_linter.rs @@ -385,3 +385,284 @@ fn does_not_change_linting_settings() { result, )); } + +#[t...
💅 Biome encountered an unexpected error when setting noExplicitAny=off in an override in CLI ### Environment information ```bash CLI: Version: 1.4.1 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environm...
This should be fixed in the next release. Still getting this error in 1.5.1. Other disables work, `noExplicitAny` errors. ``` ✖ processing panicked: internal error: entered unreachable code: the rule is turned off, it should not step in here ⚠ This diagnostic was derived from an internal Biome error. Poten...
2024-01-19T14:33:57Z
0.4
2024-01-20T13:25:00Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "cases::overrides_linter::does_preserve_group_recommended_when_override_global_recommened", "cases::overrides_linter::does_preserve_individually_diabled_rules_in_overrides", "cases::overrides_linter::does_override_recommended", "cases::overrides_linter::does_override_groupe_recommended", "commands::version:...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::prettier::test::ok", "metrics::tests::test_timing", "execute::migrate::prettier::test::some_properties", "metrics::tests::test_layer", "commands::check::fs_error_infinite_symlink_expansion_to_files", "cases::config_extends::extends_sho...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
1,542
biomejs__biome-1542
[ "1541" ]
e7fe085fe89859dcfdb944a0e0bc67345fdf3b28
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#1512](https://github.com/biomejs/biome/issues/1512) by skipping verbose diagnostics from the count. Contributed by @ematipico - Don'...
diff --git a/crates/biome_cli/tests/cases/protected_files.rs b/crates/biome_cli/tests/cases/protected_files.rs --- a/crates/biome_cli/tests/cases/protected_files.rs +++ b/crates/biome_cli/tests/cases/protected_files.rs @@ -1,6 +1,6 @@ use crate::run_cli; -use crate::snap_test::{assert_cli_snapshot, SnapshotPayload}; -...
🐛 Webstorm plugin clears package.json since 1.5.0 ### Environment information ```block CLI: Version: 1.4.1 Color support: true Platform: CPU Architecture: x86_64 OS:...
2024-01-12T10:53:03Z
0.4
2024-01-12T11:34:23Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "cases::protected_files::should_return_the_content_of_protected_files_via_stdin", "cases::protected_files::not_process_file_from_stdin_verbose_lint", "cases::protected_files::not_process_file_from_stdin_format", "cases::protected_files::not_process_file_from_stdin_verbose_format", "cases::protected_files::n...
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "cases::biome_json_support::biome_json_is_not_ignored", "cases::included_files::does_lint_included_files", "cases::diagnostics::max_diagnostics_verbose", "cases::config_extends::extends_config_...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
1,527
biomejs__biome-1527
[ "1524" ]
57f454976a02d34581291e6f06a10caa34953745
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,8 +39,35 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Add an unsafe code fix for [noConsoleLog](https://biomejs.dev/linter/rules/no-console-log/). Contributed by @vasucp1207 +- [useArrowFu...
diff --git a/crates/biome_js_analyze/src/analyzers/complexity/use_arrow_function.rs b/crates/biome_js_analyze/src/analyzers/complexity/use_arrow_function.rs --- a/crates/biome_js_analyze/src/analyzers/complexity/use_arrow_function.rs +++ b/crates/biome_js_analyze/src/analyzers/complexity/use_arrow_function.rs @@ -165,2...
🐛 useArrowFunction exception in operator expression ? ### Environment information ```block CLI: Version: 1.5.1 Color support: true Platform: CPU Architecture: x86_64 OS: macos Environment: BIOME_LOG_DIR: u...
2024-01-11T12:29:29Z
0.4
2024-01-11T17:23:34Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "analyzers::suspicious::no_control_charact...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,519
biomejs__biome-1519
[ "1200" ]
f423ed0a96cf1bef51707c11271c9170bc95f393
diff --git a/crates/biome_analyze/src/lib.rs b/crates/biome_analyze/src/lib.rs --- a/crates/biome_analyze/src/lib.rs +++ b/crates/biome_analyze/src/lib.rs @@ -36,7 +36,7 @@ pub use crate::registry::{ }; pub use crate::rule::{ CategoryLanguage, FixKind, GroupCategory, GroupLanguage, Rule, RuleAction, RuleDiagnost...
diff --git a/crates/biome_analyze/src/rule.rs b/crates/biome_analyze/src/rule.rs --- a/crates/biome_analyze/src/rule.rs +++ b/crates/biome_analyze/src/rule.rs @@ -78,30 +86,38 @@ pub enum Source { EslintMysticatea(&'static str), } -impl Source { +impl RuleSource { pub fn as_rule_name(&self) -> &'static str...
📎 Add `source` and `source_kind` to a rule metadata ### Description We want to two new metadata fields to our rules: - `source`: the URL of the rule we inspired from. Many rules aren't "new", but they were inspired or ported from other existing linters: `eslint`, `typescript-eslint`, `clippy`, eslint plugins, etc...
Thanks for bring this. It is something I had in mind since a long time (we discussed it on Discord). Some suggestions: - I think we can omit the URL for the known sources, because this can be inferred. - I think we could add more sources ("important" eslint plugins) - We could even get rid of the `Other` source. ...
2024-01-10T23:14:00Z
0.4
2024-01-11T22:11:40Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "syntax::tests::syntax_visitor", "matcher::tests::suppressions", "crates/biome_analyze/src/categories.rs - categories::ActionCategory::matches (line 60)", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::t...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,441
biomejs__biome-1441
[ "610" ]
ec6f13b3c9dfc3b211f4df2d49418db366ef7953
diff --git a/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs b/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs --- a/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs +++ b/crates/biome_js_analyze/src/semantic_anal...
diff --git a/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs b/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs --- a/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs +++ b/crates/biome_js_analyze/src/semantic_anal...
🐛 `useHookAtTopLevel`: unconditional hook usage flagged as conditionally called ### Environment information ```block https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&code=aQBtAHAAbwByAHQAIAB7ACAAYwByAGUAYQB0AGUAQwBvAG4AdABlAHgAdAAsACAAdQBzAGUAQwBhAGwAbABiAGEAYwBr...
https://stackblitz.com/edit/node-74lxwb?file=src%2Findex.js,package.json Links replicated with ESLint: execute `npm run lint` This also happens when using function components in objects: ```jsx const obj = { Component() { useState(0); return ...; } } ``` I have included fixes for the edge case...
2024-01-05T14:26:19Z
0.3
2024-01-06T23:25:20Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "assists::correctness::organize_imports::test_order", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,393
biomejs__biome-1393
[ "610" ]
ff41788bc80146752c8aa73b72ec15b8e6d06ee7
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -495,9 +495,7 @@ The following rules are now deprecated: #### New features -- Add [noUnusedPrivateClassMembers](https://biomejs.dev/linter/rules/no-unused-private-class-members) rule. - The rule disallow unused private class members...
diff --git a/crates/biome_js_analyze/src/react/hooks.rs b/crates/biome_js_analyze/src/react/hooks.rs --- a/crates/biome_js_analyze/src/react/hooks.rs +++ b/crates/biome_js_analyze/src/react/hooks.rs @@ -256,10 +266,46 @@ pub fn is_binding_react_stable( #[cfg(test)] mod test { use super::*; + use crate::react:...
🐛 `useHookAtTopLevel`: unconditional hook usage flagged as conditionally called ### Environment information ```block https://biomejs.dev/playground/?indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&code=aQBtAHAAbwByAHQAIAB7ACAAYwByAGUAYQB0AGUAQwBvAG4AdABlAHgAdAAsACAAdQBzAGUAQwBhAGwAbABiAGEAYwBr...
https://stackblitz.com/edit/node-74lxwb?file=src%2Findex.js,package.json Links replicated with ESLint: execute `npm run lint` This also happens when using function components in objects: ```jsx const obj = { Component() { useState(0); return ...; } } ```
2023-12-31T17:05:12Z
0.3
2024-01-04T19:19:40Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "globals::browser::test_order", "react::hooks::test::ok_react_stable_captures_with_default_import", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "utils::batch::tests::ok_remove_last_member", "utils::batch::tests::ok_remove_formal_parameter_from_class_constructor_seco...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,375
biomejs__biome-1375
[ "1370" ]
73c524454812c038c027b8e5442629d09ce6dfdd
diff --git a/crates/biome_css_factory/src/generated/node_factory.rs b/crates/biome_css_factory/src/generated/node_factory.rs --- a/crates/biome_css_factory/src/generated/node_factory.rs +++ b/crates/biome_css_factory/src/generated/node_factory.rs @@ -944,20 +944,11 @@ impl CssParenthesizedExpressionBuilder { )...
diff --git a/crates/biome_css_formatter/tests/quick_test.rs b/crates/biome_css_formatter/tests/quick_test.rs --- a/crates/biome_css_formatter/tests/quick_test.rs +++ b/crates/biome_css_formatter/tests/quick_test.rs @@ -13,8 +13,11 @@ mod language { // use this test check if your snippet prints as you wish, without usi...
📎 Handle and recover from unknown dimensions ### Description Tracing this error in the benchmarks: https://github.com/biomejs/biome/actions/runs/7355456817/job/20024092373#step:7:306 The code that caused it was: ```css @media screen and (min-width: 0\0 ) { /* ... */ } ``` Specifically, the `0\0` here...
2023-12-30T04:59:03Z
0.3
2024-01-07T22:06:07Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "lexer::tests::cdo_and_cdc", "lexer::tests::attribute", "lexer::tests::identifier", "lexer::tests::dimension", "tests::parser_smoke_test", "lexer::tests::empty", "lexer::tests::keywords", "lexer::tests::number", "lexer::tests::wrong_line_comments", "lexer::tests::char", "lexer::tests::block_comm...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,327
biomejs__biome-1327
[ "1012" ]
cd9623d6184f5a91192bd301184d2c84c0135895
diff --git a/crates/biome_html_syntax/src/generated/nodes.rs b/crates/biome_html_syntax/src/generated/nodes.rs --- a/crates/biome_html_syntax/src/generated/nodes.rs +++ b/crates/biome_html_syntax/src/generated/nodes.rs @@ -12,7 +12,8 @@ use crate::{ use biome_rowan::{support, AstNode, RawSyntaxKind, SyntaxKindSet, Syn...
diff --git a/crates/biome_js_analyze/src/lib.rs b/crates/biome_js_analyze/src/lib.rs --- a/crates/biome_js_analyze/src/lib.rs +++ b/crates/biome_js_analyze/src/lib.rs @@ -243,7 +243,17 @@ mod tests { String::from_utf8(buffer).unwrap() } - const SOURCE: &str = r#"require("fs") + con...
💅 useExhaustiveDependencies nested access check relies on the source format ### Environment information ```block CLI: Version: 1.4.1 Color support: true Platform: CPU Architecture: x86_64 OS: linux Environment: BIOME_LOG_DI...
It's because of using raw source strings to determine the object access overlap: [source](https://github.com/biomejs/biome/blob/02747d76ebfc8775e700a7fa5517edcb24fcabeb/crates/biome_js_analyze/src/semantic_analyzers/correctness/use_exhaustive_dependencies.rs#L585-L592) I'd like to contribute on this one.
2023-12-24T18:40:09Z
0.4
2024-01-17T01:01:47Z
b8cf046560376b8b19042b95a518e45bdcbbac22
[ "specs::correctness::use_exhaustive_dependencies::valid_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "assists::correctness::organize_imports::t...
[]
[]
auto_2025-06-09
biomejs/biome
1,249
biomejs__biome-1249
[ "1247" ]
6832256865e51b4358d5b49b1c98a58dd15a66aa
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,6 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### New features - The command `biome migrate` now updates the `$schema` if there's an outdated version. -- The CLI now supports nested `...
diff --git a/crates/biome_cli/tests/cases/mod.rs b/crates/biome_cli/tests/cases/mod.rs --- a/crates/biome_cli/tests/cases/mod.rs +++ b/crates/biome_cli/tests/cases/mod.rs @@ -8,3 +8,4 @@ mod included_files; mod overrides_formatter; mod overrides_linter; mod overrides_organize_imports; +mod unknown_files; diff --git ...
🐛 Biome doesn't throw errors for files that can't handle ### Environment information ```block main ``` ### What happened? Try to handle a file that Biome doesn't know how to handle. I should print a diagnostic saying that it doesn't know how to handle a file. This is a regression that was introduced way back, a...
2023-12-18T17:16:46Z
0.3
2023-12-18T21:56:38Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "cases::unknown_files::should_print_a_diagnostic_unknown_file", "commands::check::fs_files_ignore_symlink", "commands::check::unsupported_file", "commands::lint::fs_files_ignore_symlink", "commands::version::ok", "commands::lint::unsupported_file" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "cases::biome_json_support::ci_biome_json", "cases::config_extends::applies_extended_values_in_current_config", "cases::included_files::does_handle_only_included_files", "cases::biome_json_supp...
[]
[]
auto_2025-06-09
biomejs/biome
1,240
biomejs__biome-1240
[ "1220" ]
2e5d39a71950b0f077bf72dbef081902d7afd064
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,6 +49,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom ### Formatter - Fix [#1169](https://github.com/biomejs/biome/issues/1169). Account for escaped strings when computing layout for assignmen...
diff --git a/crates/biome_cli/tests/commands/lint.rs b/crates/biome_cli/tests/commands/lint.rs --- a/crates/biome_cli/tests/commands/lint.rs +++ b/crates/biome_cli/tests/commands/lint.rs @@ -992,6 +992,7 @@ fn fs_error_unknown() { // ├── symlink_testcase1_1 -> hidden_nested // └── symlink_testcase2 -> hidden_...
📝 Comment near a computed key in a union type gets duplicated ### Environment information ```bash CLI: Version: 1.4.1 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: ...
2023-12-17T19:17:48Z
0.3
2023-12-19T01:23:07Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "commands::version::ok" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "cases::included_files::does_not_handle_included_files_if_overridden_by_ignore", "cases::included_files::does_not_handle_included_files_if_overridden_by_ignore_formatter", "cases::diagnostics::lo...
[]
[]
auto_2025-06-09
biomejs/biome
3,764
biomejs__biome-3764
[ "3763" ]
ab4399897950e3edce59c81a01577b5f990195db
diff --git a/crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs b/crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs --- a/crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs +++ b/crates/biome_js_analyze/src/lint/correctness/use_exhaustive_depen...
diff --git a/crates/biome_js_analyze/src/lib.rs b/crates/biome_js_analyze/src/lib.rs --- a/crates/biome_js_analyze/src/lib.rs +++ b/crates/biome_js_analyze/src/lib.rs @@ -177,7 +177,6 @@ mod tests { use std::slice; use crate::lint::correctness::use_exhaustive_dependencies::{Hook, HooksOptions}; - use cra...
🐛 json shcema for options of `useExhaustiveDependencies` incorrectly requires `stableResult` ### Environment information ```block CLI: Version: 1.8.3 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environmen...
2024-09-02T16:04:35Z
0.5
2024-09-02T17:01:58Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "assists::source::organize_imports::test_order", "globals::javascript::language::test_order", "globals::javascript::node::test_order", "globals::module::node::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", "lin...
[]
[]
[]
auto_2025-06-09
biomejs/biome
3,674
biomejs__biome-3674
[ "1674" ]
ffb66d962bfc1056e40dd1fd5c3196fb6d804a78
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -282,6 +282,18 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b Contributed by @Jayllyz +- [noNodejsModules](https://biomejs.dev/linter/rules/no-nodejs-modules/) now ignores type-only imports ([#1...
diff --git a/crates/biome_js_analyze/tests/specs/correctness/noNodejsModules/valid.ts b/crates/biome_js_analyze/tests/specs/correctness/noNodejsModules/valid.ts --- a/crates/biome_js_analyze/tests/specs/correctness/noNodejsModules/valid.ts +++ b/crates/biome_js_analyze/tests/specs/correctness/noNodejsModules/valid.ts @...
💅 Improve `nursery/noNodejsModules` detection (ignore type only imports and apply it only on `use-client` directives) ### Environment information ```bash CLI: Version: 1.5.3 Color support: true Platform: CPU Architecture: aarch64 OS: ...
Makes sense to me. I'll update the implementation.
2024-08-18T12:55:19Z
0.5
2024-08-18T13:29:20Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "expr_ext::test::matches_simple_call", "expr_ext::test::matches_failing_each", "expr_ext::test::matches_concurrent_each", "numbers::tests::base_16_float", "numbers::tests::base_8_legacy_float", "numbers::tests::split_binary", "expr_ext::test::matches_only_each", "numbers::tests::base_8_float", "expr...
[]
[]
[]
auto_2025-06-09
biomejs/biome
3,671
biomejs__biome-3671
[ "3544", "3544" ]
ffb66d962bfc1056e40dd1fd5c3196fb6d804a78
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -86,13 +86,19 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b #### Bug fixes - `biome lint --write` now takes `--only` and `--skip` into account ([#3470](https://github.com/biomejs/biome/issues/3470...
diff --git a/crates/biome_cli/tests/cases/config_extends.rs b/crates/biome_cli/tests/cases/config_extends.rs --- a/crates/biome_cli/tests/cases/config_extends.rs +++ b/crates/biome_cli/tests/cases/config_extends.rs @@ -358,3 +358,49 @@ fn allows_reverting_fields_in_extended_config_to_default() { result, )...
🐛 Overwriting the "overrides" section after migrate ### Environment information ```block CLI: Version: 1.8.3 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: BIOME_LOG_DIR: u...
2024-08-17T19:13:36Z
0.5
2024-08-18T13:18:57Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::config_extends::extends_config_merge_overrides", "commands::lsp_proxy::lsp_proxy_help", "commands::migrate_eslint::migrate_merge_with_overrides" ]
[ "commands::tests::incompatible_arguments", "execute::migrate::eslint_to_biome::tests::flat_config_single_config_object", "commands::tests::no_fix", "execute::migrate::ignorefile::tests::empty", "commands::tests::safe_fixes", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migr...
[ "commands::explain::explain_help" ]
[ "cases::diagnostics::max_diagnostics_are_lifted", "commands::check::file_too_large", "commands::ci::file_too_large" ]
auto_2025-06-09
biomejs/biome
3,496
biomejs__biome-3496
[ "3470" ]
6f8eade22aaf0f46e49d92f17b7e9ffb121dc450
diff --git a/crates/biome_cli/src/execute/process_file/lint.rs b/crates/biome_cli/src/execute/process_file/lint.rs --- a/crates/biome_cli/src/execute/process_file/lint.rs +++ b/crates/biome_cli/src/execute/process_file/lint.rs @@ -22,10 +22,16 @@ pub(crate) fn lint_with_guard<'ctx>( move || { let ...
diff --git a/crates/biome_cli/tests/commands/lint.rs b/crates/biome_cli/tests/commands/lint.rs --- a/crates/biome_cli/tests/commands/lint.rs +++ b/crates/biome_cli/tests/commands/lint.rs @@ -3806,6 +3806,46 @@ fn lint_only_group_with_disabled_rule() { )); } +#[test] +fn lint_only_write() { + let mut fs = Mem...
🐛 `--write` applies fixes to all rules ignoring `--only` ### Environment information ```block CLI: Version: 1.8.3 Color support: true Platform: CPU Architecture: x86_64 OS: linux Environment: BIOME_LOG_DIR: u...
This doesn't fix the issue, however note that you can also skip an entire group `--skip=correctness`. This could make easier your life in the meantime.
2024-07-22T14:49:08Z
0.5
2024-07-23T15:55:08Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_help", "commands::lint::lint_only_missing_group", "commands::lint::lint_only_nursery_group", "commands::lint::lint_only_write", "commands...
[ "commands::tests::incompatible_arguments", "commands::tests::no_fix", "diagnostics::test::termination_diagnostic_size", "commands::tests::safe_and_unsafe_fixes", "commands::tests::safe_fixes", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::empty", ...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
3,451
biomejs__biome-3451
[ "3419" ]
46ab996cc0f49bdba00f5e7c61f4122ab6ff717c
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Formatter +#### Bug fixes + +- Keep the parentheses around `infer` declarations in type unions and type intersections ([#3419](https...
diff --git a/crates/biome_js_formatter/src/ts/types/infer_type.rs b/crates/biome_js_formatter/src/ts/types/infer_type.rs --- a/crates/biome_js_formatter/src/ts/types/infer_type.rs +++ b/crates/biome_js_formatter/src/ts/types/infer_type.rs @@ -64,6 +70,10 @@ mod tests { "type A = T extends [(infer string)?]...
Removal of necessary parentheses when formatting union of types which include an `infer` ... `extends` Reproduction is simple, see playground link. ### Environment information ```bash CLI: Version: 1.8.3 Color support: true Platform: CPU Architecture: a...
2024-07-16T16:26:41Z
0.5
2024-07-16T17:52:59Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "ts::types::infer_type::tests::needs_parentheses", "formatter::ts_module::specs::ts::type_::injfer_in_union_ts", "formatter::ts_module::specs::ts::type_::injfer_in_intersection_ts" ]
[ "js::assignments::identifier_assignment::tests::needs_parentheses", "js::expressions::number_literal_expression::tests::needs_parentheses", "syntax_rewriter::tests::adjacent_nodes", "js::expressions::call_expression::tests::needs_parentheses", "js::expressions::computed_member_expression::tests::needs_paren...
[]
[]
auto_2025-06-09
biomejs/biome
3,304
biomejs__biome-3304
[ "3278" ]
c28d5978c1440b3ae184d1cc354233711abf8a8e
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,10 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). +## Unreleased + +- Implement...
diff --git a/crates/biome_css_analyze/tests/spec_tests.rs b/crates/biome_css_analyze/tests/spec_tests.rs --- a/crates/biome_css_analyze/tests/spec_tests.rs +++ b/crates/biome_css_analyze/tests/spec_tests.rs @@ -197,7 +197,7 @@ fn check_code_action( assert_errors_are_absent(re_parse.tree().syntax(), re_parse.diagno...
📎 Implement suppression action for the CSS analyzer ### Description At the moment, there's no way to suppress a CSS lint rule via editor because we don't expose an action that creates the suppression comment. We should create one here: https://github.com/biomejs/biome/blob/bb5faa052cc9b0596aec30a9627ea94a93af...
2024-06-27T15:43:55Z
0.5
2024-06-28T01:59:11Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "no_duplicate_font_names_css", "no_empty_block_css" ]
[ "specs::nursery::no_duplicate_at_import_rules::valid_css", "specs::nursery::no_duplicate_selectors_keyframe_block::valid_css", "specs::nursery::no_duplicate_at_import_rules::invalid_urls_css", "specs::nursery::no_important_in_keyframe::invalid_css", "specs::nursery::no_duplicate_at_import_rules::invalid_mul...
[]
[]
auto_2025-06-09
biomejs/biome
2,794
biomejs__biome-2794
[ "2148" ]
9c920a1898960ac866c78ee727fc8b408f98c968
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -85,6 +85,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Add [nursery/useThrowNewError](https://biomejs.dev/linter/rules/use-throw-new-error/). Contributed by @minht11 +- Add [nursery/useTopL...
diff --git /dev/null b/crates/biome_js_analyze/src/lint/nursery/use_top_level_regex.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/lint/nursery/use_top_level_regex.rs @@ -0,0 +1,90 @@ +use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic}; +use biome_console::markup...
📎 Implement rule `useTopLevelRegex` ### Description I *don't* know if there's a similar rule out there, we can add a reference later. I came up with this rule while looking at many JS PRs out there, and I was surprised that there are many developers that don't adopt the following practice. Given the following code...
I like the suggestion :+1: Of course there is an obvious downside to it: Placing all regular expressions in the top-level scope will cause startup performance of the bundle to suffer. Usually this is negligible, and if the regexes are used inside a hot loop, it's absolutely the trade-off you want to make. But forcin...
2024-05-09T17:27:07Z
0.5
2024-05-15T14:35:46Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::use_top_level_regex::valid_js", "specs::nursery::use_top_level_regex::invalid_js" ]
[ "assists::correctness::organize_imports::test_order", "globals::javascript::node::test_order", "globals::javascript::language::test_order", "globals::javascript::web::test_order", "globals::module::node::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[]
[]
auto_2025-06-09
biomejs/biome
2,788
biomejs__biome-2788
[ "2765" ]
49cace81ce65ab7ab3bccb7b4b404778630f153d
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,7 +23,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - biome check . + biome check # You can run the command without the path ``` - + ### Configuration ### Editors diff --git a/...
diff --git a/crates/biome_service/src/file_handlers/mod.rs b/crates/biome_service/src/file_handlers/mod.rs --- a/crates/biome_service/src/file_handlers/mod.rs +++ b/crates/biome_service/src/file_handlers/mod.rs @@ -580,11 +579,13 @@ fn test_svelte_script_lang() { fn test_vue_script_lang() { const VUE_JS_SCRIPT_OP...
🐛 vue sfc `lang="tsx"` support ### Environment information ```block CLI: Version: 1.7.3 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: unset NO_COLOR: ...
I didn't know JSX was supported inside templating. Does anyone want to add support for that? https://github.com/biomejs/biome/blob/67888a864fab60d467094d4870811a99ded2e82f/crates/biome_service/src/file_handlers/mod.rs#L547-L553 I had no idea this was a thing either, but [apparently it is](https://github.com/vitejs/...
2024-05-09T11:35:05Z
0.5
2024-05-10T11:43:26Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "file_handlers::test_vue_script_lang" ]
[ "diagnostics::test::diagnostic_size", "matcher::pattern::test::test_pattern_absolute", "matcher::pattern::test::test_pattern_from_str", "matcher::pattern::test::test_pattern_glob", "matcher::pattern::test::test_pattern_matches_case_insensitive_range", "matcher::pattern::test::test_pattern_escape", "matc...
[]
[]
auto_2025-06-09
biomejs/biome
2,726
biomejs__biome-2726
[ "2266" ]
5f2b80e9db52a13d8b256c917d3991ec130db0b1
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,15 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### CLI +#### Enhancements + +- Biome now executes commands (lint, format, check and ci) on the working directory by default. [#2266](ht...
diff --git a/crates/biome_cli/tests/commands/check.rs b/crates/biome_cli/tests/commands/check.rs --- a/crates/biome_cli/tests/commands/check.rs +++ b/crates/biome_cli/tests/commands/check.rs @@ -2897,3 +2897,28 @@ fn print_json_pretty() { result, )); } + +#[test] +fn lint_error_without_file_paths() { + ...
📎 Execute Biome command on the working directory by default ### Description See #2240 for more context. For now, The main Biome commands require passing at least one file (possibly a directory). For instance, to format all files in the working directory, a user has to run `biome format ./`. Running a Biome com...
2024-05-05T20:50:05Z
0.5
2024-06-05T09:10:01Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_help", "commands::migrate::migrate_help", "commands::lsp_proxy::lsp_proxy_help", "commands::rage::rage_help" ]
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::eslint_to_biome::tests::flat_config_single_config_object", "execute::migrate::ignorefile::tests::empty", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::negated_pattern", "execute::m...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,692
biomejs__biome-2692
[ "2571" ]
43525a35c4e2777b4d5874851ad849fa31552538
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,18 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b Contributed by @Conaclos +- [noUnusedLabels](https://biomejs.dev/linter/rules/no-unused-labels/) and [noConfusingLabels](https://biome...
diff --git a/crates/biome_js_analyze/tests/spec_tests.rs b/crates/biome_js_analyze/tests/spec_tests.rs --- a/crates/biome_js_analyze/tests/spec_tests.rs +++ b/crates/biome_js_analyze/tests/spec_tests.rs @@ -11,8 +11,8 @@ use biome_test_utils::{ }; use std::{ffi::OsStr, fs::read_to_string, path::Path, slice}; -tests...
💅 Svelte Reactive Blocks marked as Unexpected/Unused ### Environment information ```bash CLI: Version: 1.7.1 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: un...
We have two options here: - Document the caveat on the website, and tell people to disable the rules themselves; - We start disabling rules based on file extension. For example, we would need to disable other rules for other files, such as `noUnusedVariables` for Astro files. And `noUnusedImports` for all vue/astro/s...
2024-05-03T10:12:40Z
0.5
2024-05-04T20:54:36Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::correctness::no_unused_labels::valid_svelte", "specs::suspicious::no_confusing_labels::valid_svelte" ]
[ "specs::a11y::no_aria_unsupported_elements::valid_jsx", "specs::a11y::no_aria_hidden_on_focusable::valid_jsx", "specs::a11y::no_header_scope::valid_jsx", "specs::a11y::no_autofocus::valid_jsx", "specs::a11y::no_redundant_roles::valid_jsx", "simple_js", "specs::a11y::use_button_type::with_binding_valid_j...
[]
[]
auto_2025-06-09
biomejs/biome
2,658
biomejs__biome-2658
[ "2627" ]
5fda633add27d3605fff43cee76d66a5ef15c98c
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2751,6 +2754,7 @@ impl Nursery { "noConstantMathMinMaxClamp", "noCssEmptyBlock", ...
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2662,6 +2662,9 @@ pub struct Nursery { #[doc = "Disallow using a callback in asynchronous tests ...
📎 Implement no-duplicate-at-import-rules ## Description Implement [no-duplicate-at-import-rules](https://stylelint.io/user-guide/rules/no-duplicate-at-import-rules) > [!IMPORTANT] > - Please skip implementing options for now since we will evaluate users actually want them later. > - Please ignore handling ext...
I'd like to help out with this one 🙂
2024-04-30T12:07:05Z
0.5
2024-05-02T05:41:07Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::diagnostic_size", "diagnostics::test::deserialization_quick_check", "diagnostics::test::deserialization_error", "diagnostics::test::config_already_exists" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,655
biomejs__biome-2655
[ "2624" ]
150dd0e622494792c857a1e9235fd1e2b63bfb12
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2705,6 +2705,10 @@ pub struct Nursery { #[doc = "Disallow unknown CSS value functions."] #[...
diff --git a/crates/biome_css_analyze/src/keywords.rs b/crates/biome_css_analyze/src/keywords.rs --- a/crates/biome_css_analyze/src/keywords.rs +++ b/crates/biome_css_analyze/src/keywords.rs @@ -759,6 +759,104 @@ pub const FUNCTION_KEYWORDS: [&str; 671] = [ "xywh", ]; +// These are the ones that can have single...
📎 Implement selector-pseudo-element-no-unknown ## Description Implement [selector-pseudo-element-no-unknown](https://stylelint.io/user-guide/rules/selector-pseudo-element-no-unknown) > [!IMPORTANT] > - Please skip implementing options for now since we will evaluate users actually want them later. > - Please ...
Can I work on this issue?
2024-04-30T09:26:20Z
0.5
2024-05-02T06:11:02Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::no_unknown_selector_pseudo_element::valid_css", "specs::nursery::no_unknown_selector_pseudo_element::invalid_css" ]
[ "keywords::tests::test_function_keywords_sorted", "keywords::tests::test_function_keywords_unique", "specs::nursery::no_css_empty_block::disallow_comment_options_json", "specs::nursery::no_color_invalid_hex::invalid_css", "specs::nursery::no_important_in_keyframe::valid_css", "specs::nursery::no_color_inv...
[]
[]
auto_2025-06-09
biomejs/biome
2,621
biomejs__biome-2621
[ "2357", "2357" ]
1d525033b22f9fee682252197a6233a4222f28a6
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -68,6 +68,9 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b #### Bug fixes +- [noDuplicateJsonKeys](https://biomejs.dev/linter/rules/no-duplicate-json-keys/) no longer crashes when a JSON file cont...
diff --git a/crates/biome_json_formatter/tests/specs/prettier/json/json/json5.json.snap b/crates/biome_json_formatter/tests/specs/prettier/json/json/json5.json.snap --- a/crates/biome_json_formatter/tests/specs/prettier/json/json/json5.json.snap +++ b/crates/biome_json_formatter/tests/specs/prettier/json/json/json5.jso...
🐛 JSON Parser: Unterminated string literal can make `inner_string_text` panic ### Environment information ```block Unrelated, the issue is reproducible when nursery/noDuplicateJsonKeys is enabled. ``` ### What happened? Our JSON parser allows `JSON_STRING_LITERAL` to include an unterminated string literal...
Wow, that's surprising! Some ideas: - We could add a `JsonBogusMemberName` and `AnyJsonMemberName = JsonMemberName | JsonBogusMemberName`. - or, we could handle `{ "a }` like a value with a missing key and colon. This could avoid introducing a new node. Any opinion? > Some ideas: > > * We could add a `JsonBo...
2024-04-27T15:56:51Z
0.5
2024-04-28T15:49:05Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "lexer::tests::unterminated_string", "err::number_0_e1_json", "err::array_spaces_vertical_tab_formfeed_json", "err::number_minus_infinity_json", "err::number_2_e_3_json", "err::number___inf_json", "err::number__1_0__json", "err::number_9_e__json", "err::number_0_1_2_json", "err::number_2_e3_json",...
[ "lexer::tests::array", "lexer::tests::basic_string", "lexer::tests::empty", "lexer::tests::exponent", "lexer::tests::float", "lexer::tests::float_invalid", "lexer::tests::block_comment", "lexer::tests::identifiers", "lexer::tests::int", "lexer::tests::keywords", "lexer::tests::invalid_unicode_es...
[]
[ "err::string_unescaped_ctrl_char_json", "err::string_backslash_00_json" ]
auto_2025-06-09
biomejs/biome
2,607
biomejs__biome-2607
[ "1573" ]
43525a35c4e2777b4d5874851ad849fa31552538
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Editors +#### New features + +- Add support for LSP Workspaces + ### Formatter ### JavaScript APIs diff --git a/CHANGELOG.md b/C...
diff --git a/crates/biome_lsp/tests/server.rs b/crates/biome_lsp/tests/server.rs --- a/crates/biome_lsp/tests/server.rs +++ b/crates/biome_lsp/tests/server.rs @@ -28,7 +28,6 @@ use tower::{Service, ServiceExt}; use tower_lsp::jsonrpc; use tower_lsp::jsonrpc::Response; use tower_lsp::lsp_types as lsp; -use tower_lsp:...
📎 LSP: support for Workspaces ### Description At the moment, our LSP doesn't support workspaces. To achieve that, the LSP needs to add a few features that it doesn't support at the moment: - register itself for other events: - [`workspace/workspaceFolders`](https://microsoft.github.io/language-server-protocol/s...
Adding my two cents here. The projects within a workspace (vscode workspace) can be owned by different teams and they have different configuration. Also the file/folder structure can be very different (thus the `files.include` and `files.ignore`). So switching setting on the fly before handing a file may not be ...
2024-04-26T10:05:32Z
0.5
2024-05-06T15:58:00Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "does_not_format_ignored_files" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,600
biomejs__biome-2600
[ "2580" ]
b24b44c34b2912ed02653b43c96f807579e6a3aa
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -79,6 +79,12 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b Contributed by @Conaclos +- Fix [useTemplate](https://biomejs.dev/linter/rules/use-template/) that wrongly escaped strings in some edg...
diff --git /dev/null b/crates/biome_js_analyze/tests/specs/style/useTemplate/invalidIssue2580.js new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/tests/specs/style/useTemplate/invalidIssue2580.js @@ -0,0 +1,2 @@ +// Issue https://github.com/biomejs/biome/issues/2580 +'```ts\n' + x + '\n```'; \ No newlin...
💅 useTemplate problem ### Environment information ```bash CLI: Version: 1.7.1 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: unset NO_COLOR: ...
Thank you, @Jack-Works for reporting the error; the readability is subjective, that's why this rule is part of the `style` group. However, the fix is indeed incorrect.
2024-04-25T14:38:05Z
0.5
2024-04-25T15:10:17Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "utils::tests::ok_escape_dollar_signs_and_backticks" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,573
biomejs__biome-2573
[ "2572" ]
e96781a48b218b2480da5344124ab0c9b9c4c086
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2712,6 +2712,9 @@ pub struct Nursery { #[doc = "Enforce the use of new for all builtins, except ...
diff --git a/crates/biome_css_analyze/src/lib.rs b/crates/biome_css_analyze/src/lib.rs --- a/crates/biome_css_analyze/src/lib.rs +++ b/crates/biome_css_analyze/src/lib.rs @@ -122,13 +122,12 @@ mod tests { String::from_utf8(buffer).unwrap() } - const SOURCE: &str = r#".something {} -"#; + ...
📎 Implement font-family-no-missing-generic-family-keyword Implement [font-family-no-missing-generic-family-keyword](https://stylelint.io/user-guide/rules/font-family-no-missing-generic-family-keyword)
2024-04-23T15:26:47Z
0.5
2024-04-26T14:23:49Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::use_generic_font_names::valid_css", "specs::nursery::use_generic_font_names::invalid_css" ]
[ "specs::nursery::no_css_empty_block::disallow_comment_options_json", "specs::nursery::no_duplicate_selectors_keyframe_block::valid_css", "specs::nursery::no_important_in_keyframe::valid_css", "specs::nursery::no_color_invalid_hex::invalid_css", "specs::nursery::no_important_in_keyframe::invalid_css", "spe...
[]
[]
auto_2025-06-09
biomejs/biome
2,570
biomejs__biome-2570
[ "2530" ]
608f842c15d1ec2ae7e8f4a8c5d76b7cca8569e4
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2699,6 +2699,9 @@ pub struct Nursery { #[doc = "Disallow the use of dependencies that aren't spe...
diff --git a/crates/biome_css_analyze/src/keywords.rs b/crates/biome_css_analyze/src/keywords.rs --- a/crates/biome_css_analyze/src/keywords.rs +++ b/crates/biome_css_analyze/src/keywords.rs @@ -82,3 +82,700 @@ pub const FONT_SIZE_KEYWORDS: [&str; 9] = [ ]; pub const LINE_HEIGHT_KEYWORDS: [&str; 1] = ["normal"]; + ...
📎 Implement function-no-unknown
2024-04-23T10:05:46Z
0.5
2024-04-29T06:46:51Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::no_unknown_function::invalid_css", "specs::nursery::no_unknown_function::valid_css" ]
[ "keywords::tests::test_function_keywords_sorted", "keywords::tests::test_function_keywords_unique", "specs::nursery::no_css_empty_block::disallow_comment_options_json", "specs::nursery::no_color_invalid_hex::invalid_css", "specs::nursery::no_color_invalid_hex::valid_css", "specs::nursery::no_important_in_...
[]
[]
auto_2025-06-09
biomejs/biome
2,563
biomejs__biome-2563
[ "817" ]
b150000f92a821ef0d36ff06ae568b55f0b6ab73
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,8 +9,49 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). -## 1.7.1 (2024-04-22) +## Un...
diff --git a/crates/biome_cli/tests/commands/check.rs b/crates/biome_cli/tests/commands/check.rs --- a/crates/biome_cli/tests/commands/check.rs +++ b/crates/biome_cli/tests/commands/check.rs @@ -2204,7 +2204,7 @@ fn check_stdin_apply_unsafe_successfully() { let mut console = BufferConsole::default(); consol...
🐛 Ignore side-effect imports when organising imports ### Environment information ```block CLI: Version: 1.3.3 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: unse...
I've been looking at the source code, and here are my initial thoughts. 1. The file extension `.css` is not relevant. 2. Side effects imports (imports without `from`) should not be organized 3. Side effects imports are identifiable in the AST as `JSImportBareClause` If this is correct, my approach would be to ...
2024-04-22T17:24:39Z
0.5
2024-04-22T21:40:19Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration", "cases::biome_json_support::formatter_biome_json", "cases::biome_json_support::ci_biome_json", "cases::diagnostics::logs_the_appropriate_messages_according_to_set_diagnostics_level", "cases::config_extends::allows_reverting...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::ignorefile::tests::negated_pattern", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::empty", "execute::migrate::eslint_to_biome::tests::flat_config_single_config_object", "execute::m...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,513
biomejs__biome-2513
[ "2512" ]
2c4d6e722e5bbd051b16f186735f142ed97930a0
diff --git a/crates/biome_configuration/Cargo.toml b/crates/biome_configuration/Cargo.toml --- a/crates/biome_configuration/Cargo.toml +++ b/crates/biome_configuration/Cargo.toml @@ -42,6 +42,7 @@ serde_json = { workspace = true, features = ["raw_value"] } schema = [ "dep:schemars", "biome_js_analy...
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -257,11 +257,15 @@ dependencies = [ "biome_console", "biome_css_parser", "biome_css_syntax", + "biome_deserialize", + "biome_deserialize_macros", "biome_diagnostics", "biome_rowan", "biome_test_utils", "insta", "lazy_static", + "s...
📎 Implement `block-no-empty` ### Description Implement [block-no-empty](https://stylelint.io/user-guide/rules/block-no-empty) **Want to contribute?** Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if yo...
2024-04-18T15:18:22Z
0.5
2024-04-19T07:58:07Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::diagnostic_size", "diagnostics::test::deserialization_quick_check", "diagnostics::test::deserialization_error", "diagnostics::test::config_already_exists" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,510
biomejs__biome-2510
[ "2338" ]
416433146f2b8543a6dee674b425c51d41e4fd81
diff --git a/crates/biome_js_factory/src/generated/node_factory.rs b/crates/biome_js_factory/src/generated/node_factory.rs --- a/crates/biome_js_factory/src/generated/node_factory.rs +++ b/crates/biome_js_factory/src/generated/node_factory.rs @@ -5619,32 +5619,6 @@ pub fn ts_module_declaration( ], )) } -...
diff --git a/crates/biome_js_parser/src/syntax/typescript.rs b/crates/biome_js_parser/src/syntax/typescript.rs --- a/crates/biome_js_parser/src/syntax/typescript.rs +++ b/crates/biome_js_parser/src/syntax/typescript.rs @@ -110,7 +111,7 @@ fn expect_ts_type_list(p: &mut JsParser, clause_name: &str) -> CompletedMarker { ...
📎 Investigate AST nodes `TsNameWithTypeArguments` vs `TsReferenceType` ### Description While reviewing #2092, I noticed that `TsNameWithTypeArguments` and `TsReferenceType` have the same shape and are always used together in a match condition in the semantic model. It seems that these two nodes have the same purpos...
2024-04-18T14:25:53Z
0.5
2024-04-18T18:14:00Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "lexer::tests::bigint_literals", "lexer::tests::are_we_jsx", "lexer::tests::bang", "lexer::tests::at_token", "lexer::tests::all_whitespace", "lexer::tests::binary_literals", "lexer::tests::complex_string_1", "lexer::tests::consecutive_punctuators", "lexer::tests::division", "lexer::tests::block_co...
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,457
biomejs__biome-2457
[ "2456" ]
23076b9e4898e2cbd20d8caa78a310ea17d57a3b
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,14 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Biome now can handle `.svelte` and `.vue` files with `CRLF` as the end-of-line sequence. Contributed by @Sec-ant +- Biome now can hand...
diff --git a/crates/biome_cli/tests/cases/handle_vue_files.rs b/crates/biome_cli/tests/cases/handle_vue_files.rs --- a/crates/biome_cli/tests/cases/handle_vue_files.rs +++ b/crates/biome_cli/tests/cases/handle_vue_files.rs @@ -73,6 +73,10 @@ import Button from "./components/Button.vue"; const VUE_CARRIAGE_RETURN_LINE_...
🐛 parse error when using generic component in vue files ### Environment information ```block CLI: Version: 1.6.4 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: BIOME_LOG_DIR: ...
That's a weird error This is the issue of the regexes we use 😓. I'll look into it.
2024-04-15T10:17:07Z
0.5
2024-04-15T12:18:27Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration_and_show_verbose", "cases::protected_files::should_return_the_content_of_protected_files_via_stdin", "cases::config_extends::respects_unaffected_values_from_extended_config", "cases::biome_json_support::check_biome_json", "ca...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::ignorefile::tests::empty", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::negated_pattern", "execute::migrate::eslint_to_biome::tests::flat_config_single_config_object", "execute::m...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,453
biomejs__biome-2453
[ "2443" ]
05e4796016268319ecbdc3caca318af00cbadff6
diff --git a/crates/biome_js_analyze/src/lint/nursery/no_misplaced_assertion.rs b/crates/biome_js_analyze/src/lint/nursery/no_misplaced_assertion.rs --- a/crates/biome_js_analyze/src/lint/nursery/no_misplaced_assertion.rs +++ b/crates/biome_js_analyze/src/lint/nursery/no_misplaced_assertion.rs @@ -113,6 +119,7 @@ impl ...
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Biome now can handle `.svelte` and `.vue` files with `CRLF` as the end-of-line sequence. Contributed by @Sec-ant +- `noMisplacedAsserti...
💅 [noMisplacedAssertion] The rule does not support `it.each` in `vitest` ### Environment information ```bash ❯ ppm biome rage --linter CLI: Version: 1.6.4 Color support: true Platform: CPU Architecture: aarch64 OS: macos E...
2024-04-15T07:04:11Z
0.5
2024-04-15T17:06:18Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::no_misplaced_assertion::valid_method_calls_js" ]
[ "globals::javascript::node::test_order", "assists::correctness::organize_imports::test_order", "globals::javascript::language::test_order", "globals::module::node::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[]
[]
auto_2025-06-09
biomejs/biome
2,404
biomejs__biome-2404
[ "2304" ]
60671ec3a4c59421583d5d1ec8cfe30d45b27cd7
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -267,6 +267,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Implement [#2043](https://github.com/biomejs/biome/issues/2043): The React rule [`useExhaustiveDependencies`](https://biomejs.dev/linte...
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2593,6 +2593,9 @@ pub struct Nursery { #[doc = "Disallow the use of console."] #[serde(skip...
📎 Implement `lint/noConstantMinMax` - `clippy/min_max` ### Description Implement [clippy/min_max](https://rust-lang.github.io/rust-clippy/master/#/min_max) **Want to contribute?** Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we ...
I'd like to give it a try
2024-04-10T20:38:47Z
0.5
2024-04-14T13:34:44Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::diagnostic_size", "diagnostics::test::deserialization_quick_check", "diagnostics::test::deserialization_error", "diagnostics::test::config_already_exists" ]
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,134
biomejs__biome-1134
[ "847" ]
6d86024e02c4049ae24302964fe0ca4f8229a470
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,9 +17,29 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### New features - The command `biome migrate` now updates the `$schema` if there's an outdated version. +- The CLI now supports nested ...
diff --git a/.gitignore b/.gitignore --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,7 @@ Profile-*.json # Release artifacts **/target # Ignore test files that contributors could create locally -/test.* +**/test.* # Ignore third-party files **/node_modules **/dist diff --git a/crates/biome_cli/src/diagnostics.rs b/c...
📎 use ignore crate for walking the file system ### Description At the moment we use some in-house code for walking the file system and for matching globs to ignore the files. While this works, we have some issues: - we can't respect nested gitignore files during the traversal - our glob matcher is a copy of the...
Related: - #805 - #709
2023-12-09T20:11:24Z
0.3
2023-12-20T17:15:00Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "commands::check::ok", "cases::biome_json_support::linter_biome_json", "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration", "cases::included_files::does_lint_inc...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,070
biomejs__biome-1070
[ "728" ]
c8aab475b131cced31d1711ab1e09adcec92c7ff
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -70,6 +70,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom } ``` +- Fix [#728](https://github.com/biomejs/biome/issues/728). [useSingleVarDeclarator](https://biomejs.dev/linter/rules/use-single...
diff --git a/crates/biome_js_analyze/src/analyzers/style/use_single_var_declarator.rs b/crates/biome_js_analyze/src/analyzers/style/use_single_var_declarator.rs --- a/crates/biome_js_analyze/src/analyzers/style/use_single_var_declarator.rs +++ b/crates/biome_js_analyze/src/analyzers/style/use_single_var_declarator.rs @...
💅 useSingleVarDeclarator suggests non-working code ### Environment information ```bash CLI: Version: 1.3.3 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: unset ...
2023-12-05T22:42:46Z
0.3
2023-12-06T11:18:26Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_control_characters", "analyzers::correctness::no_nonocta...
[]
[]
[]
auto_2025-06-09
biomejs/biome
1,023
biomejs__biome-1023
[ "914" ]
8e326f51ea19e54181c0b0dd17a9ba8c6eadf80b
diff --git a/crates/biome_js_formatter/src/ts/expressions/as_expression.rs b/crates/biome_js_formatter/src/ts/expressions/as_expression.rs --- a/crates/biome_js_formatter/src/ts/expressions/as_expression.rs +++ b/crates/biome_js_formatter/src/ts/expressions/as_expression.rs @@ -91,6 +91,20 @@ impl NeedsParentheses for ...
diff --git a/crates/biome_js_formatter/src/ts/expressions/as_expression.rs b/crates/biome_js_formatter/src/ts/expressions/as_expression.rs --- a/crates/biome_js_formatter/src/ts/expressions/as_expression.rs +++ b/crates/biome_js_formatter/src/ts/expressions/as_expression.rs @@ -152,5 +166,14 @@ mod tests { ass...
📝 formatting compat issues ### Environment information ```block Playground ``` ### What happened? Hey, it's me again with more formatting discrepancies I found in our codebases. - [x] https://biomejs.dev/playground/?lineWidth=100&indentStyle=space&quoteStyle=single&trailingComma=none&lintRules=all&enabledLintin...
The first bug here happens because the formatter uses a `BestFitting` set when laying out arguments to a call expression, and it somehow manages to pick the middle variant rather than falling back to the fully-broken-out layout. I've been trying to address that to solve a number of other prettier diffs (like `prettier/...
2023-12-02T23:39:24Z
0.3
2023-12-03T12:23:39Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "ts::expressions::as_expression::tests::needs_parentheses" ]
[ "js::assignments::identifier_assignment::tests::needs_parentheses", "js::expressions::class_expression::tests::needs_parentheses", "js::expressions::number_literal_expression::tests::needs_parentheses", "js::expressions::computed_member_expression::tests::needs_parentheses", "syntax_rewriter::tests::comment...
[]
[]
auto_2025-06-09
biomejs/biome
996
biomejs__biome-996
[ "578" ]
c890be77cd77fea7a970c638fca7405b8d56df41
diff --git a/crates/biome_js_analyze/src/react/hooks.rs b/crates/biome_js_analyze/src/react/hooks.rs --- a/crates/biome_js_analyze/src/react/hooks.rs +++ b/crates/biome_js_analyze/src/react/hooks.rs @@ -209,6 +209,7 @@ impl StableReactHookConfiguration { /// ``` pub fn is_binding_react_stable( binding: &AnyJsIde...
diff --git a/crates/biome_js_analyze/src/react/hooks.rs b/crates/biome_js_analyze/src/react/hooks.rs --- a/crates/biome_js_analyze/src/react/hooks.rs +++ b/crates/biome_js_analyze/src/react/hooks.rs @@ -260,12 +257,46 @@ pub fn is_binding_react_stable( mod test { use super::*; use biome_js_parser::JsParserOp...
🐛 When using `React` hook prefix, exhaustive deps breaks ### Environment information ```block ↳ pnpm biome rage CLI: Version: 1.3.1 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: BIOME_...
Can you provide an example with the Eslint rule, please? This rule should follow what the original rule does. Sure @ematipico, here you are: https://stackblitz.com/edit/node-hcjbcn?file=src%2Findex.js,.eslintrc.js This has ESLint setup and allows you to run `npm run lint` in the terminal to verify the ESLint func...
2023-12-01T15:47:29Z
0.3
2024-01-07T21:54:39Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_control_characters", "assists::correctness::organize_imp...
[]
[]
[]
auto_2025-06-09
biomejs/biome
942
biomejs__biome-942
[ "933" ]
04e6319e5744b7f7b7e131db55e92b9b1e192124
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom ### Editors +- Fix [#933](https://github.com/biomejs/biome/issues/933). Some files are properly ignored in the LSP too. E.g. `package.jso...
diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs --- a/crates/biome_cli/tests/commands/format.rs +++ b/crates/biome_cli/tests/commands/format.rs @@ -1825,7 +1825,7 @@ fn ignore_comments_error_when_allow_comments() { let code = r#" /*test*/ [1, 2, 3] "#; - let...
🐛 tsconfig.json should be ignored, but it now reports problems ### Environment information ```block CLI: Version: 1.4.0 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: ...
Do you see these errors even when you run the CLI? > Do you see these errors even when you run the CLI? No, CLI didn't show these errors. Only in VS Code. > biome(parse) <img width="782" alt="image" src="https://github.com/biomejs/biome/assets/35226412/0ab9cd8b-c0cc-46e0-ac2f-e71d60cf7cf7"> I tried 1.3....
2023-11-28T15:03:12Z
0.3
2024-01-18T09:50:19Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "commands::version::ok" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "commands::check::ok", "cases::overrides_formatter::does_handle_included_file_and_disable_formatter", "commands::check::check_stdin_apply_unsafe_only_organize_imports", "cases::biome_json_suppo...
[]
[]
auto_2025-06-09
biomejs/biome
872
biomejs__biome-872
[ "832" ]
3a2af456d1dd9998f24aac8f55ac843044c05d24
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### Bug fixes +- Fix [#832](https://github.com/biomejs/biome/issues/832), the formatter no longer keeps an unnecessary trailing comma in...
diff --git a/crates/biome_js_formatter/tests/prettier_tests.rs b/crates/biome_js_formatter/tests/prettier_tests.rs --- a/crates/biome_js_formatter/tests/prettier_tests.rs +++ b/crates/biome_js_formatter/tests/prettier_tests.rs @@ -3,7 +3,7 @@ use std::{env, path::Path}; use biome_formatter::IndentStyle; use biome_for...
🐛 unnecessary trailing comma in type parameter list ### Environment information ```block Plaground ``` ### What happened? Biome keeps the trailing comma of type parameter lists. The following example: ```ts class A<T,> { } ``` is formatted to: ```ts class A<T,> {} ``` [Playground link](h...
2023-11-24T22:25:20Z
0.2
2023-11-24T23:06:21Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "specs::prettier::js::array_spread::multiple_js", "specs::prettier::js::arrays::last_js", "specs::prettier::js::arrays::holes_in_args_js", "specs::prettier::js::arrows::block_like_js", "specs::prettier::js::arrays::empty_js", "specs::prettier::js::arrows::semi::semi_js", "specs::prettier::js::arrows::lo...
[]
[]
[]
auto_2025-06-09
biomejs/biome
867
biomejs__biome-867
[ "861" ]
a3e14daacce1425c6275995dbd34dfb906121d47
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -109,6 +109,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#576](https://github.com/biomejs/biome/issues/576) by removing some erroneous logic in [noSelfAssign](https://biomejs.dev/linter/r...
diff --git a/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_unused_variables.rs b/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_unused_variables.rs --- a/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_unused_variables.rs +++ b/crates/biome_js_analyze/src/semantic_analyzers/...
💅 False positive `lint/correctness/noUnusedVariables` on bracketless arrow functions ### Environment information ```bash $ bun biome rage CLI: Version: 1.3.3-nightly.38797b7 Color support: true Platform: CPU Architecture: x86_64 OS: ...
2023-11-24T12:55:38Z
0.2
2023-11-24T22:15:58Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "specs::correctness::no_unused_variables::valid_issue861_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_control_characters", "assists::correctness::organize_imp...
[]
[]
auto_2025-06-09
biomejs/biome
859
biomejs__biome-859
[ "856" ]
a69a094ae991d4f0d839be9a0c0bb9d8ce8a5e1e
diff --git a/crates/biome_service/src/matcher/mod.rs b/crates/biome_service/src/matcher/mod.rs --- a/crates/biome_service/src/matcher/mod.rs +++ b/crates/biome_service/src/matcher/mod.rs @@ -73,7 +73,15 @@ impl Matcher { // Here we cover cases where the user specifies single files inside the patter...
diff --git a/crates/biome_service/src/matcher/mod.rs b/crates/biome_service/src/matcher/mod.rs --- a/crates/biome_service/src/matcher/mod.rs +++ b/crates/biome_service/src/matcher/mod.rs @@ -132,6 +140,25 @@ mod test { assert!(result); } + #[test] + fn matches_path_for_single_file_or_directory_nam...
🐛 File ignored when `.gitignore` partially matching characters are included ### Environment information ```block CLI: Version: 1.3.3 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_D...
2023-11-23T18:56:49Z
0.2
2023-11-23T20:00:51Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "matcher::test::matches_path_for_single_file_or_directory_name" ]
[ "configuration::diagnostics::test::diagnostic_size", "diagnostics::test::diagnostic_size", "configuration::diagnostics::test::deserialization_quick_check", "matcher::pattern::test::test_matches_path", "matcher::pattern::test::test_pattern_absolute", "matcher::pattern::test::test_path_join", "matcher::pa...
[]
[]
auto_2025-06-09
biomejs/biome
843
biomejs__biome-843
[ "353" ]
ca576c8a5388cdfb6c0257804e723f7a129876ac
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -115,6 +115,7 @@ define_categories! { "lint/nursery/useBiomeSuppressi...
diff --git /dev/null b/crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/analyzers/nursery/use_regex_literals.rs @@ -0,0 +1,244 @@ +use biome_analyze::{ + context::RuleContext, declare_rule, ActionCategory, FixKind, Rule, RuleDiag...
📎 Implement `lint/useRegexLiterals` - `eslint/prefer-regex-literals` ### Description [prefer-regex-literals](https://eslint.org/docs/latest/rules/prefer-regex-literals/) Want to contribute? Lets we know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't...
I'm insterested in this issue. Can I work on this? @Yuiki Off course! 🚀
2023-11-23T11:12:41Z
0.2
2023-11-25T14:07:07Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "specs::nursery::use_regex_literals::valid_jsonc", "specs::nursery::use_regex_literals::invalid_jsonc" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "assists::correctness::organize_imports::test_order", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_co...
[]
[]
auto_2025-06-09
biomejs/biome
710
biomejs__biome-710
[ "49" ]
c3150e615e4942e51b8331321f491f98303e9f83
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### New features +- Add [useForOf](https://biomejs.dev/linter/rules/use-for-of) rule. + The rule recommends a for-of loop when the loo...
diff --git /dev/null b/crates/biome_js_analyze/src/semantic_analyzers/nursery/use_for_of.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/semantic_analyzers/nursery/use_for_of.rs @@ -0,0 +1,412 @@ +use biome_analyze::{context::RuleContext, declare_rule, Rule, RuleDiagnostic}; +use biome_console::...
📎 Implement `lint/useForOf` - `typescript-eslint/prefer-for-of` ### Description [prefer-for-of](https://typescript-eslint.io/rules/prefer-for-of) **Want to contribute?** Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unas...
2023-11-13T02:50:06Z
0.3
2023-12-02T03:14:52Z
8dc2b1e4734c7992bf26c26ea37acd9df6e89f1d
[ "specs::nursery::use_for_of::invalid_js", "specs::nursery::use_for_of::valid_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "assists::correctness::organize_imports::test_order", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_co...
[]
[]
auto_2025-06-09
biomejs/biome
693
biomejs__biome-693
[ "455" ]
8475169ddc89aab85859b08949e75d44979c8b99
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#676](https://github.com/biomejs/biome/issues/676), by using the correct node for the `"noreferrer"` when applying the code action. ...
diff --git a/crates/biome_console/src/write/termcolor.rs b/crates/biome_console/src/write/termcolor.rs --- a/crates/biome_console/src/write/termcolor.rs +++ b/crates/biome_console/src/write/termcolor.rs @@ -235,4 +272,30 @@ mod tests { assert_eq!(from_utf8(&buffer).unwrap(), OUTPUT); } + + #[test] + ...
🐛 `biome format` breaks emojis when used via stdin ### Environment information ```block CLI: Version: 1.2.2 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: uns...
This was also flagged in the Rome repository, and it seems it wasn't fixed. Here's a possible reason of the bug: https://github.com/rome/tools/issues/3915#issuecomment-1339388916 I think that problem is the logic of converting strings to buffers. Sometimes a Unicode "character" is made up of multiple [Unicode sc...
2023-11-09T17:45:51Z
0.2
2023-11-10T16:47:33Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "write::termcolor::tests::test_printing_complex_emojis" ]
[ "fmt::tests::display_bytes", "write::termcolor::tests::test_hyperlink", "write::termcolor::tests::test_sanitize", "test_macro", "test_macro_attributes", "tests/markup/closing_element_mismatch.rs", "tests/markup/closing_element_standalone.rs", "tests/markup/element_non_ident_name.rs", "tests/markup/i...
[]
[]
auto_2025-06-09
biomejs/biome
619
biomejs__biome-619
[ "613" ]
3b22c30b7d375aee10ee0024ac434a3dbef4b679
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom ### Parser +- Support RegExp v flag. Contributed by @nissy-dev + ### VSCode ## 1.3.1 (2023-10-20) diff --git a/crates/biome_js_parser...
diff --git a/crates/biome_js_parser/src/syntax/expr.rs b/crates/biome_js_parser/src/syntax/expr.rs --- a/crates/biome_js_parser/src/syntax/expr.rs +++ b/crates/biome_js_parser/src/syntax/expr.rs @@ -155,6 +155,7 @@ pub(crate) fn parse_expression_or_recover_to_next_statement( // "test\ // new-line"; // /^[يفمئامئ‍ئاس...
📎 js_parser: support RegExp `v` flag ### Description Make the JavaScript parser to recognize the RegExp `v` flag (Unicode sets). The [tc39/proposal-regexp-v-flag](https://github.com/tc39/proposal-regexp-v-flag) has reached the stage 4 of the TC39 process and is [widely supported](https://developer.mozilla.org/en-US/d...
2023-10-28T07:13:48Z
0.2
2023-10-30T03:14:10Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "tests::parser::ok::literals_js" ]
[ "lexer::tests::binary_literals", "lexer::tests::at_token", "lexer::tests::are_we_jsx", "lexer::tests::bigint_literals", "lexer::tests::bang", "lexer::tests::all_whitespace", "lexer::tests::consecutive_punctuators", "lexer::tests::complex_string_1", "lexer::tests::block_comment", "lexer::tests::div...
[]
[]
auto_2025-06-09
biomejs/biome
585
biomejs__biome-585
[ "44" ]
8287c1a37bc7024ce4f9c88f32d7dd96678c51aa
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -96,6 +96,13 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#591](https://github.com/biomejs/biome/issues/591) which made [noRedeclare](https://biomejs.dev/linter/rules/no-redeclare) report typ...
diff --git /dev/null b/crates/biome_js_analyze/src/analyzers/nursery/no_unused_private_class_members.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/analyzers/nursery/no_unused_private_class_members.rs @@ -0,0 +1,365 @@ +use biome_analyze::{ + context::RuleContext, declare_rule, ActionCategor...
📎 Implement `lint/noUnusedPrivateClassMembers` - `eslint/no-unused-private-class-members` ### Description [no-unused-private-class-members](https://eslint.org/docs/latest/rules/no-unused-private-class-members/) **Want to contribute?** Lets you know you are interested! We will assign you to the issue to prevent s...
@Conaclos I'll work on this one. This rule should also cover private members in typescript ? or only es2022 class private members ? I'd say both, because we can :) Not sure, because private TypeScript field are not ensured to leak. I mean: ```ts class A { private n: number; } declare const a: A; const...
2023-10-23T02:41:54Z
0.2
2023-12-06T21:53:41Z
cf9a586d69b09437bf4b7f075df0aa627daa891d
[ "specs::nursery::no_unused_private_class_members::valid_js", "specs::nursery::no_unused_private_class_members::invalid_ts", "specs::nursery::no_unused_private_class_members::invalid_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "analyzers::suspicious::no_control_charact...
[]
[]
auto_2025-06-09
biomejs/biome
521
biomejs__biome-521
[ "39" ]
57a3d9d721ab685c741f66b160a4adfe767ffa60
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -92,6 +92,7 @@ define_categories! { "lint/nursery/noApproximativeNume...
diff --git /dev/null b/crates/biome_js_analyze/src/analyzers/nursery/no_empty_block_statements.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/analyzers/nursery/no_empty_block_statements.rs @@ -0,0 +1,107 @@ +use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic}; +us...
📎 Implement `lint/noEmptyBlockStatements` - `eslint/no-empty` `eslint/no-empty-static-block` ### Description This lint rule should integrate both [no-empty](https://eslint.org/docs/latest/rules/no-empty/) and [no-empty-static-block](https://eslint.org/docs/latest/rules/no-empty-static-block/) rules. **Want to co...
What's the difference between this rule and https://github.com/biomejs/biome/issues/42? It's worth an explanation in the description > What's the difference between this rule and #42? It's worth an explanation in the description In contrast to #42, the rule prohibits any empty block statements. Examples of incorrec...
2023-10-13T15:52:11Z
0.1
2023-10-16T15:24:52Z
57a3d9d721ab685c741f66b160a4adfe767ffa60
[ "specs::nursery::no_empty_block_statements::valid_cjs", "specs::nursery::no_empty_block_statements::valid_ts", "specs::nursery::no_empty_block_statements::valid_js", "specs::nursery::no_empty_block_statements::invalid_js", "specs::nursery::no_empty_block_statements::invalid_ts" ]
[ "globals::node::test_order", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "assists::correctness::organize_imports::test_order", "aria_services::tests::test_extract_attributes", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_seque...
[]
[]
auto_2025-06-09
biomejs/biome
499
biomejs__biome-499
[ "42" ]
ee2e2ab72dd146f72c3493047ca7ec7da13e3505
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs --- a/crates/biome_diagnostics_categories/src/categories.rs +++ b/crates/biome_diagnostics_categories/src/categories.rs @@ -102,6 +102,7 @@ define_categories! { "lint/nursery/noMisrefactoredSh...
diff --git /dev/null b/crates/biome_js_analyze/src/analyzers/nursery/no_useless_lone_block_statements.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/analyzers/nursery/no_useless_lone_block_statements.rs @@ -0,0 +1,166 @@ +use crate::semantic_services::Semantic; +use crate::JsRuleAction; +use bi...
📎 Implement `lint/noUselessLoneBlockStatements` - `eslint/no-lone-block` ### Description [no-lone-blocks](https://eslint.org/docs/latest/rules/no-lone-blocks/). **Want to contribute?** Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't wor...
I think, in our case, the word "lone" can be dropped. I suggest `noUselessBlock` > I think, in our case, the word "lone" can be dropped. I suggest `noUselessBlock` Not sure, because the rule concerns only "lone" block statements, i.e. block statements that are not attached to a `if`, `else`, `while`, `function`, ......
2023-10-08T11:13:32Z
0.1
2023-10-16T13:51:29Z
57a3d9d721ab685c741f66b160a4adfe767ffa60
[ "specs::nursery::no_useless_lone_block_statements::valid_module_js", "specs::nursery::no_useless_lone_block_statements::valid_cjs", "specs::nursery::no_useless_lone_block_statements::invalid_module_js", "specs::nursery::no_useless_lone_block_statements::invalid_cjs" ]
[ "utils::test::find_variable_position_matches_on_right", "aria_services::tests::test_extract_attributes", "globals::browser::test_order", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "utils::batch::tests::ok_remove_formal_parameter_first", "assists::correctnes...
[]
[]
auto_2025-06-09
biomejs/biome
493
biomejs__biome-493
[ "491" ]
4751532f8c2590274c7f16389d4198914f35f2cb
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -704,6 +704,7 @@ dependencies = [ "dashmap", "indexmap", "insta", + "lazy_static", "rustc-hash", "schemars", "serde", diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -826,7 +827,7 @@ checksum = "22cbaba260bbc...
diff --git a/crates/biome_cli/tests/cases/mod.rs b/crates/biome_cli/tests/cases/mod.rs --- a/crates/biome_cli/tests/cases/mod.rs +++ b/crates/biome_cli/tests/cases/mod.rs @@ -4,3 +4,6 @@ mod biome_json_support; mod config_extends; mod included_files; +mod overrides_formatter; +mod overrides_linter; +mod overrides_or...
☂️ Configuration `overrides` support From RFC https://github.com/biomejs/biome/discussions/180 ## Goals - apply a subset of configuration (formatting, lint rules, etc.) only to specific files; - apply different subsets of configurations to different files; - turn off tools for certain files ## Non-goals -...
2023-10-06T10:38:15Z
0.1
2024-01-07T22:11:40Z
57a3d9d721ab685c741f66b160a4adfe767ffa60
[ "commands::check::ignore_vcs_ignored_file_via_cli", "commands::version::ok", "test_json", "top_level_keys_json", "incorrect_type_json", "incorrect_value_javascript_json", "incorrect_key_json", "top_level_extraneous_field_json" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "commands::check::files_max_size_parse_error", "commands::check::check_help", "commands::format::indent_size_parse_errors_negative", "commands::ci::ci_help", "commands::ci::files_max_size_par...
[ "cases::included_files::does_not_handle_included_files_if_overridden_by_organize_imports", "commands::check::doesnt_error_if_no_files_were_processed", "cases::overrides_formatter::does_include_file_with_different_languages_and_files", "commands::check::maximum_diagnostics", "commands::check::downgrade_sever...
[ "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration" ]
auto_2025-06-09
biomejs/biome
469
biomejs__biome-469
[ "456" ]
3dc932726905c33f7fc5e77275bd5736e3f12c35
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -125,6 +125,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom The rule enforce use of `as const` assertion to infer literal types. Contributed by @unvalley +- Add [noMisrefactoredShorthandAssig...
diff --git a/crates/biome_js_analyze/src/utils.rs b/crates/biome_js_analyze/src/utils.rs --- a/crates/biome_js_analyze/src/utils.rs +++ b/crates/biome_js_analyze/src/utils.rs @@ -95,3 +95,121 @@ pub(crate) fn is_node_equal(a_node: &JsSyntaxNode, b_node: &JsSyntaxNode) -> boo } true } + +#[derive(Debug, Parti...
📎 Implement `lint/noMisrefactoredShorthandAssign` - `clippy/misrefactored_assign_op` ### Description Clippy [misrefactored_assign_op](https://rust-lang.github.io/rust-clippy/master/#/misrefactored_assign_op). Want to contribute? Lets us know you are interested! We will assign you to the issue to prevent several pe...
@victor-teles You may be interested in this rule because you have recently implemented [useShorthandAssign](https://biomejs.dev/linter/rules/use-shorthand-assign). @Conaclos Sure! I'll assign it to me
2023-10-01T15:49:15Z
0.1
2023-10-10T20:34:46Z
57a3d9d721ab685c741f66b160a4adfe767ffa60
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "assists::correctness::organize_imports::test_order", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_co...
[]
[]
[]
auto_2025-06-09
biomejs/biome
468
biomejs__biome-468
[ "313" ]
003899166dcff1fe322cf2316aa01c577f56536b
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -109,6 +109,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#294](https://github.com/biomejs/biome/issues/294). [noConfusingVoidType](https://biomejs.dev/linter/rules/no-confusing-void-type/...
diff --git a/crates/biome_js_analyze/src/utils/batch.rs b/crates/biome_js_analyze/src/utils/batch.rs --- a/crates/biome_js_analyze/src/utils/batch.rs +++ b/crates/biome_js_analyze/src/utils/batch.rs @@ -288,6 +293,27 @@ impl JsBatchMutation for BatchMutation<JsLanguage> { false } } + + fn ...
🐛 `noRedundantUseStrict`: Applying fixes also removes the comment above "use strict" directive ### Environment information ```block CLI: Version: 1.2.2 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environ...
2023-10-01T12:44:52Z
0.0
2023-10-01T13:30:26Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "analyzers::suspicious::no_control_charact...
[]
[]
[]
auto_2025-06-09
biomejs/biome
457
biomejs__biome-457
[ "296" ]
240aa9a2a213680bb28a897dcccdd918e023c854
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Add option `--indent-width`, and deprecated the option `--indent-size`. Contributed by @ematipico - Add option `--javascript-formatter-ind...
diff --git a/crates/biome_cli/tests/commands/rage.rs b/crates/biome_cli/tests/commands/rage.rs --- a/crates/biome_cli/tests/commands/rage.rs +++ b/crates/biome_cli/tests/commands/rage.rs @@ -1,5 +1,5 @@ use crate::run_cli; -use crate::snap_test::{CliSnapshot, SnapshotPayload}; +use crate::snap_test::{assert_cli_snapsh...
📎 change how `rome rage` collects data ### Description At the moment, when you run `biome rage`, the command reads a bunch of stuff from your machine and the configuration file. Then, if a Daemon is running that is hooked to the LSP of the user, it prints all the logs captured in the last hour. This can be over...
2023-09-30T13:58:05Z
0.0
2023-10-02T00:53:54Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "commands::rage::rage_help", "commands::rage::with_server_logs" ]
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "commands::ci::ci_errors_for_all_disabled_checks", "commands::check::check_help", "cases::config_extends::extends_should_raise_an_error_for_unresolved_configuration_and_show_verbose", "commands...
[]
[]
auto_2025-06-09
biomejs/biome
452
biomejs__biome-452
[ "450" ]
69cbd76a8ffa789cbc68ffd867f7974ad6e6903a
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -104,6 +104,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#397](https://github.com/biomejs/biome/issues/397). [useNumericLiterals](https://biomejs.dev/linter/rules/use-numeric-literals) no...
diff --git a/crates/biome_js_analyze/src/analyzers/suspicious/no_control_characters_in_regex.rs b/crates/biome_js_analyze/src/analyzers/suspicious/no_control_characters_in_regex.rs --- a/crates/biome_js_analyze/src/analyzers/suspicious/no_control_characters_in_regex.rs +++ b/crates/biome_js_analyze/src/analyzers/suspic...
🐛 Unexpected error in `expr_ext.rs` ### Environment information ```block Just received the following error from Biome in my console: This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following informa...
2023-09-29T14:40:56Z
0.0
2023-09-30T18:25:55Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "globals::node::test_order", "globals::browser::test_order", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_pars...
[]
[]
[]
auto_2025-06-09
biomejs/biome
440
biomejs__biome-440
[ "51" ]
ae1021c30b312f100cb8d281da6a9069340ce054
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -61,6 +61,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### New features +- Add [noEmptyCharacterClassInRegex](https://biomejs.dev/linter/rules/no-empty-character-class-in-regex) rule. The rul...
diff --git /dev/null b/crates/biome_js_analyze/src/analyzers/nursery/no_empty_character_class_in_regex.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/analyzers/nursery/no_empty_character_class_in_regex.rs @@ -0,0 +1,129 @@ +use std::ops::Range; + +use biome_analyze::{context::RuleContext, decla...
📎 Implement `lint/noEmptyCharacterClassInRegex` - `eslint/no-empty-character-class` ### Description [eslint/no-empty-character-class](https://eslint.org/docs/latest/rules/no-empty-character-class) and [eslint-regex-plugin/no-empty-character-class](https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-empty-char...
2023-09-27T22:24:17Z
0.0
2023-09-28T10:39:15Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "specs::nursery::no_empty_character_class_in_regex::valid_js", "specs::nursery::no_empty_character_class_in_regex::invalid_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "analyzers::suspicious::no_control_charact...
[]
[]
auto_2025-06-09
biomejs/biome
411
biomejs__biome-411
[ "276" ]
51da9e942769fbfea1a4d869b074cba99e7b9285
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -69,6 +69,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom The rule reports `else` clauses that can be omitted because their `if` branches break. Contributed by @Conaclos +- Add [useShorthandA...
diff --git /dev/null b/crates/biome_js_analyze/src/analyzers/nursery/use_shorthand_assign.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/analyzers/nursery/use_shorthand_assign.rs @@ -0,0 +1,210 @@ +use biome_analyze::{ + context::RuleContext, declare_rule, ActionCategory, Ast, Rule, RuleDiag...
📎 Implement `lint/useShorthandAssign` - `eslint/operator-assignment` ### Description Implement [operator-assignment](https://eslint.org/docs/latest/rules/operator-assignment/). **Want to contribute?** Lets we know you are interested! We will assign you to the issue to prevent several people to work on the same i...
@Conaclos 👋 I want to contribute, can you assign it to me?
2023-09-25T02:13:58Z
0.0
2023-09-28T19:46:23Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "specs::nursery::use_shorthand_assign::valid_js", "specs::nursery::use_shorthand_assign::invalid_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_control_characters", "globals::node::test_order", "glo...
[]
[]
auto_2025-06-09
biomejs/biome
385
biomejs__biome-385
[ "322" ]
fdc3bc88c52624fdd5af6f9337c7d27099107437
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom #### Bug fixes - Fix [#243](https://github.com/biomejs/biome/issues/243) a false positive case where the incorrect scope was defined for t...
diff --git a/crates/biome_js_analyze/src/lib.rs b/crates/biome_js_analyze/src/lib.rs --- a/crates/biome_js_analyze/src/lib.rs +++ b/crates/biome_js_analyze/src/lib.rs @@ -239,8 +239,16 @@ mod tests { String::from_utf8(buffer).unwrap() } - const SOURCE: &str = r#"value['optimizelyService']...
🐛 correctness/noSelfAssign false positive ### Environment information ```block biome v 1.2.2 ``` ### What happened? See code. ``` document .querySelector(`[data-field-id="customModel-container"]`) .querySelector('input').value = document .querySelector(`[data-field-id="${modelField.i...
2023-09-22T12:25:56Z
0.0
2023-09-22T13:15:10Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "specs::correctness::no_self_assign::valid_js", "specs::style::use_naming_convention::invalid_class_static_getter_js" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::suspicious::no_control_characters_in_regex::tests::test_collect_control_characters", "analyzers::correctness::no_nonocta...
[ "specs::correctness::no_self_assign::invalid_js" ]
[]
auto_2025-06-09
biomejs/biome
384
biomejs__biome-384
[ "383" ]
1aa21df1e6c537b022c130e8d44351d4c244d331
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -56,6 +56,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - Fix [#294](https://github.com/biomejs/biome/issues/294). [noConfusingVoidType](https://biomejs.dev/linter/rules/no-confusing-void-type/) ...
diff --git a/crates/biome_js_analyze/src/analyzers/complexity/no_multiple_spaces_in_regular_expression_literals.rs b/crates/biome_js_analyze/src/analyzers/complexity/no_multiple_spaces_in_regular_expression_literals.rs --- a/crates/biome_js_analyze/src/analyzers/complexity/no_multiple_spaces_in_regular_expression_liter...
🐛 `lint/noMultipleSpacesInRegularExpressionLiterals` code fix doesn't correctly handle consecutive spaces followed by a quantifier ### Environment information ```block Playground ``` ### What happened? The rule provides a wrong an incorrect suggestion when a quantifier follows multiple spaces. For instance, the...
2023-09-22T11:56:17Z
0.0
2023-09-22T21:59:24Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "specs::complexity::no_multiple_spaces_in_regular_expression_literals::invalid_jsonc" ]
[ "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::correctness::no_nonoctal_decimal_escape::tests::test_parse_escape_sequences", "analyzers::suspicious::no_control_charact...
[]
[]
auto_2025-06-09
biomejs/biome
326
biomejs__biome-326
[ "129" ]
34ba257158f71388e993cb3972a5bfe3d04299be
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,19 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom ### Parser - Enhance diagnostic for infer type handling in the parser. The 'infer' keyword can only be utilized within the 'extends' clau...
diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs --- a/crates/biome_cli/tests/commands/format.rs +++ b/crates/biome_cli/tests/commands/format.rs @@ -1856,13 +1856,13 @@ fn ignore_comments_error_when_allow_comments() { } "#; - let rome_config = "biome.json"; + ...
📎 Implement `json.parser.allowTrailingCommas` ### Description As reported in #83, some config files support trailing comma. `json.parser.allowTrailingCommas: true` enables trailing commas in `json` and `jsonc` files, making the following example valid: ```jsonc { "prop1": [ 1, 2, ], "prop2":...
I'm working
2023-09-18T10:19:50Z
0.0
2023-09-22T13:46:46Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "commands::format::format_json_when_allow_trailing_commas", "err::array_comma_after_close_json", "err::array_1_true_without_comma_json", "err::array_double_comma_json", "err::array_comma_and_number_json", "err::array_incomplete_json", "err::array_extra_close_json", "err::array_unclosed_trailing_comma_...
[ "diagnostics::test::termination_diagnostic_size", "metrics::tests::test_timing", "metrics::tests::test_layer", "cases::biome_json_support::ci_biome_json", "cases::biome_json_support::linter_biome_json", "commands::check::apply_suggested_error", "cases::config_extends::extends_should_raise_an_error_for_u...
[]
[]
auto_2025-06-09
biomejs/biome
256
biomejs__biome-256
[ "105" ]
b14349ff0fd655ba7c4a00525a6a650d79f58f36
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,31 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom - [useCollapsedElseIf](https://biomejs.dev/linter/rules/use-collapsed-else-if/) now only provides safe code fixes. Contributed by [@Conacl...
diff --git a/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_unused_variables.rs b/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_unused_variables.rs --- a/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_unused_variables.rs +++ b/crates/biome_js_analyze/src/semantic_analyzers/...
🐛 `noUnusedVariables` not looking at inner functions against a declared variable for a match ### Environment information ```block CLI: Version: 1.0.0 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environ...
2023-09-12T16:10:43Z
0.0
2023-09-13T15:01:56Z
003899166dcff1fe322cf2316aa01c577f56536b
[ "analyzers::nursery::no_nonoctal_decimal_escape::tests::test_is_octal_escape_sequence", "analyzers::nursery::no_nonoctal_decimal_escape::tests::test_get_unicode_escape", "analyzers::nursery::no_control_characters_in_regex::tests::test_collect_control_characters", "globals::node::test_order", "globals::brows...
[]
[]
[]
auto_2025-06-09
biomejs/biome
3,207
biomejs__biome-3207
[ "3179" ]
b70f405b5f7c6f7afeb4bdb9272fcf2ab0b764cd
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### CLI +#### Bug fixes + +- Fix [#3179](https://github.com/biomejs/biome/issues/3179) where comma separators are not correctly removed ...
diff --git a/crates/biome_migrate/src/analyzers/nursery_rules.rs b/crates/biome_migrate/src/analyzers/nursery_rules.rs --- a/crates/biome_migrate/src/analyzers/nursery_rules.rs +++ b/crates/biome_migrate/src/analyzers/nursery_rules.rs @@ -69,7 +72,7 @@ fn find_group_by_name(root: &JsonRoot, group_name: &str) -> Option<...
🐛 `npx @biomejs/biome migrate` command crashes ### Environment information ```block CLI: Version: 1.8.1 Color support: true Platform: CPU Architecture: x86_64 OS: linux Environment: BIOME_LOG_DIR: unset NO...
Is it possible that you have a leading comma in `biome.json` and that you enabled it in the configuration file? e.g. ```json { "json": { "parser": { "allowTrailingCommas": true } } } ``` I have it in the `javascript.formatter` property section, and it is `"trailingCommas": "es5"` Could you share your `biome.jso...
2024-06-13T18:29:28Z
0.5
2024-06-14T10:01:21Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::migrations::nursery_rules::middle_to_existing_group_json", "specs::migrations::nursery_rules::last_to_existing_group_json", "specs::migrations::nursery_rules::first_to_existing_group_json", "specs::migrations::nursery_rules::existing_group_with_existing_rule_json" ]
[ "specs::migrations::nursery_rules::renamed_rule_json", "specs::migrations::nursery_rules::no_new_group_json", "specs::migrations::schema::invalid_json", "specs::migrations::schema::valid_json", "specs::migrations::indent_size::invalid_json", "specs::migrations::nursery_rules::renamed_rule_and_new_rule_jso...
[ "specs::migrations::nursery_rules::single_to_existing_group_json" ]
[]
auto_2025-06-09
biomejs/biome
3,183
biomejs__biome-3183
[ "3176" ]
c9261d2a008462ba4a48d56e5a7a17c7c5186919
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,46 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Configuration +#### Bug fixes + +- Don't conceal previous overrides ([#3176](https://github.com/biomejs/biome/issues/3176)). + + Pr...
diff --git a/crates/biome_cli/tests/cases/overrides_formatter.rs b/crates/biome_cli/tests/cases/overrides_formatter.rs --- a/crates/biome_cli/tests/cases/overrides_formatter.rs +++ b/crates/biome_cli/tests/cases/overrides_formatter.rs @@ -587,3 +587,87 @@ fn does_not_change_formatting_language_settings_2() { r...
🐛 Override behavior with multiple matches ### Discussed in https://github.com/biomejs/biome/discussions/3166 <div type='discussions-op-text'> <sup>Originally posted by **redbmk** June 10, 2024</sup> I'm not sure if this is a bug so starting it out as a discussion. I expected to be able to add multiple blocks...
It seems that we propagate the base settings to every override item. Thus, the following config: ```json { "$schema": "https://biomejs.dev/schemas/1.7.1/schema.json", "linter": { "rules": { "suspicious": { "noConsoleLog": "warn" } } }, "overrides": [ { "include": ["index.js...
2024-06-11T22:14:06Z
0.5
2024-06-12T16:27:47Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::overrides_linter::does_merge_all_overrides", "cases::overrides_linter::takes_last_linter_enabled_into_account", "cases::overrides_formatter::takes_last_formatter_enabled_into_account", "cases::overrides_formatter::does_not_conceal_previous_overrides", "commands::check::check_help", "cases::overrid...
[ "commands::tests::incompatible_arguments", "commands::tests::no_fix", "diagnostics::test::termination_diagnostic_size", "commands::tests::safe_and_unsafe_fixes", "commands::tests::safe_fixes", "execute::migrate::ignorefile::tests::negated_pattern", "execute::migrate::ignorefile::tests::empty", "execut...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
3,143
biomejs__biome-3143
[ "3037" ]
e79759994f10bd3d5bbb60cc5ea1971ae092311b
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,11 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Linter + +#### New features + +- Add [nursery/useValidAutocomplete](https://biomejs.dev/linter/rules/use-valid-autocomplete/). Contr...
diff --git /dev/null b/crates/biome_js_analyze/src/lint/nursery/use_valid_autocomplete.rs new file mode 100644 --- /dev/null +++ b/crates/biome_js_analyze/src/lint/nursery/use_valid_autocomplete.rs @@ -0,0 +1,248 @@ +use biome_analyze::{context::RuleContext, declare_rule, Rule, RuleDiagnostic, RuleSource}; +use biome_c...
📎 Implement `jsx-a11y/autocomplete-valid` - `useValidAutocomplete` ### Description - [eslint-plugin-jsx-a11y/docs/rules/autocomplete-valid.md at main · jsx-eslint/eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/autocomplete-valid.md)
2024-06-10T01:35:06Z
0.5
2024-06-12T05:54:20Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::use_valid_autocomplete::invalid_options_json", "specs::nursery::use_valid_autocomplete::valid_options_json", "specs::nursery::use_valid_autocomplete::valid_jsx", "specs::nursery::use_valid_autocomplete::invalid_jsx" ]
[ "globals::javascript::language::test_order", "assists::correctness::organize_imports::test_order", "globals::javascript::node::test_order", "globals::module::node::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[]
[]
auto_2025-06-09
biomejs/biome
3,074
biomejs__biome-3074
[ "3069" ]
2d9f96cb28d570c759b75941bb9471592c48cea4
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,14 @@ New entries must be placed in a section entitled `Unreleased`. Read our [guidelines for writing a good changelog entry](https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#changelog). +## Unreleased + +### CLI + +...
diff --git a/crates/biome_cli/tests/commands/check.rs b/crates/biome_cli/tests/commands/check.rs --- a/crates/biome_cli/tests/commands/check.rs +++ b/crates/biome_cli/tests/commands/check.rs @@ -3293,3 +3293,52 @@ function f() {\n\targuments;\n} result, )); } + +#[test] +fn should_error_if_unstaged_files...
🐛 --staged regression in v1.8.0 ### Environment information ```block CLI: Version: 1.8.0 Color support: true Platform: CPU Architecture: aarch64 OS: macos Environment: BIOME_LOG_DIR: unset NO_COLOR: ...
Thank you for reporting it! @unvalley are you able to take a look?
2024-06-05T17:07:15Z
0.5
2024-06-06T02:14:06Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_help", "commands::lint::lint_only_missing_group", "commands::lint::lint_only_nursery_group", "commands::migrate::migrate_help", "commands...
[ "commands::tests::no_fix", "diagnostics::test::termination_diagnostic_size", "commands::tests::incompatible_arguments", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::eslint_to_biome::tests::flat_config_single_config_object", "execute::migrate::ignorefile::tests::empty...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
3,036
biomejs__biome-3036
[ "1056" ]
e3e93cc52b9b5c3cb7e8dda1eb30030400788d9b
diff --git a/crates/biome_formatter/src/format_element/document.rs b/crates/biome_formatter/src/format_element/document.rs --- a/crates/biome_formatter/src/format_element/document.rs +++ b/crates/biome_formatter/src/format_element/document.rs @@ -250,7 +250,35 @@ impl Format<IrFormatContext> for &[FormatElement] { ...
diff --git a/crates/biome_formatter/src/format_element/document.rs b/crates/biome_formatter/src/format_element/document.rs --- a/crates/biome_formatter/src/format_element/document.rs +++ b/crates/biome_formatter/src/format_element/document.rs @@ -710,6 +738,10 @@ impl FormatElements for [FormatElement] { #[cfg(test)...
🐛 Quotes within quotes of Formatter IR isn't escaped ### Environment information ```block This is running Biomejs playground with no special options enabled. ``` ### What happened? 1. Had a string in Biome.js playground: https://biomejs.dev/playground/?code=YQB3AGEAaQB0ACAAIgBhACIAIAA%3D ```ts await "a"...
@ematipico I would like to address this issue! @ematipico ~~Thanks for your hard work! I have a question about this issue! I'm looking at a lot of implementations right now, and the one that needs to be fixed is https://github.com/biomejs/biome/blob/main/crates/biome_js_formatter/src/js/expressions/await_ In the...
2024-06-01T13:35:19Z
0.5
2024-09-10T12:34:47Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "format_element::document::tests::escapes_quotes" ]
[ "arguments::tests::test_nesting", "comments::map::tests::dangling_leading", "comments::map::tests::dangling_trailing", "comments::builder::tests::comment_only_program", "comments::builder::tests::dangling_arrow", "comments::map::tests::empty", "comments::map::tests::keys_out_of_order", "comments::buil...
[]
[]
auto_2025-06-09
biomejs/biome
3,034
biomejs__biome-3034
[ "2625" ]
4ce214462aa33da8213015fa98a6375665bdbe6e
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2869,6 +2869,9 @@ pub struct Nursery { #[doc = "Disallow unknown properties."] #[serde(skip...
diff --git a/crates/biome_css_analyze/src/lib.rs b/crates/biome_css_analyze/src/lib.rs --- a/crates/biome_css_analyze/src/lib.rs +++ b/crates/biome_css_analyze/src/lib.rs @@ -158,12 +158,30 @@ mod tests { String::from_utf8(buffer).unwrap() } - const SOURCE: &str = r#"@font-face { font-fam...
📎 Implement selector-pseudo-class-no-unknown ## Description Implement [selector-pseudo-class-no-unknown](https://stylelint.io/user-guide/rules/selector-pseudo-class-no-unknown) > [!IMPORTANT] > - Please skip implementing options for now since we will evaluate users actually want them later. > - Please ignore ...
Hi can I work on this issue?
2024-06-01T07:26:32Z
0.5
2024-09-10T13:10:29Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::no_unknown_pseudo_class_selector::valid_css", "specs::nursery::no_unknown_pseudo_class_selector::invalid_css" ]
[ "keywords::tests::test_known_properties_order", "keywords::tests::test_function_keywords_sorted", "keywords::tests::test_kown_explorer_properties_order", "keywords::tests::test_kown_edge_properties_order", "keywords::tests::test_kown_firefox_properties_order", "keywords::tests::test_kown_safari_properties...
[]
[]
auto_2025-06-09
biomejs/biome
3,007
biomejs__biome-3007
[ "2990" ]
5e96827c40ccb31c831a09f3ad68700753e12905
diff --git a/crates/biome_service/src/file_handlers/json.rs b/crates/biome_service/src/file_handlers/json.rs --- a/crates/biome_service/src/file_handlers/json.rs +++ b/crates/biome_service/src/file_handlers/json.rs @@ -1,3 +1,5 @@ +use std::ffi::OsStr; + use super::{CodeActionsParams, DocumentFileSource, ExtensionHand...
diff --git a/crates/biome_cli/tests/cases/biome_json_support.rs b/crates/biome_cli/tests/cases/biome_json_support.rs --- a/crates/biome_cli/tests/cases/biome_json_support.rs +++ b/crates/biome_cli/tests/cases/biome_json_support.rs @@ -253,3 +253,41 @@ fn biome_json_is_not_ignored() { result, )); } + +#[t...
🐛 Buggy side-effect caused by previous fix that made `biome.json(c)` un-ignore-able ### Environment information ```block Platform: CPU Architecture: x86_64 OS: linux Environment: BIOME_LOG_DIR: unset NO_COLOR: unset TERM: ...
For those come across here looking for a workaround, here's what you need to do: ```javascript "json": { "formatter": { "trailingCommas": "none" } }, ``` And keep the discussion going so our wonderful maintainers can see this issue. ❤️ I'd like to give this a shot. > I'd like to give this a...
2024-05-27T19:59:51Z
0.5
2024-05-28T13:08:20Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::biome_json_support::always_disable_trailing_commas_biome_json", "commands::check::check_help", "commands::format::format_help", "commands::ci::ci_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_only_missing_group", "commands::lint::lint_only_nursery_group", "co...
[ "commands::tests::incompatible_arguments", "commands::tests::no_fix", "diagnostics::test::termination_diagnostic_size", "commands::tests::safe_fixes", "commands::tests::safe_and_unsafe_fixes", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::empty", ...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,989
biomejs__biome-2989
[ "2986" ]
5e96827c40ccb31c831a09f3ad68700753e12905
diff --git a/crates/biome_service/src/matcher/pattern.rs b/crates/biome_service/src/matcher/pattern.rs --- a/crates/biome_service/src/matcher/pattern.rs +++ b/crates/biome_service/src/matcher/pattern.rs @@ -3,7 +3,7 @@ use crate::matcher::pattern::MatchResult::{ EntirePatternDoesntMatch, Match, SubPatternDoesntMat...
diff --git a/crates/biome_service/src/matcher/pattern.rs b/crates/biome_service/src/matcher/pattern.rs --- a/crates/biome_service/src/matcher/pattern.rs +++ b/crates/biome_service/src/matcher/pattern.rs @@ -924,4 +1008,46 @@ mod test { .matches_path(Path::new("\\\\?\\C:\\a\\b\\c.js"))); } ...
📎 Support `{a,b}` glob pattern syntax for includes/excludes # Summary We want to support `{a,b}` pattern matching syntax for includes and excludes. It will allow us to more comprehensively support all the patterns that the Editorconfig spec defines (although not completely). Specifically, this syntax is to indic...
2024-05-26T13:33:10Z
0.5
2024-05-28T12:47:16Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::diagnostic_size", "matcher::pattern::test::test_matches_path", "matcher::pattern::test::test_path_join", "matcher::pattern::test::test_pattern_absolute", "matcher::pattern::test::test_pattern_escape", "matcher::pattern::test::test_pattern_from_str", "matcher::pattern::test::test_patt...
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,958
biomejs__biome-2958
[ "2807" ]
04745f42096b9797c87f6913a178961f7053bb39
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2857,6 +2857,9 @@ pub struct Nursery { #[doc = "Disallow specified modules when loaded by import...
diff --git a/crates/biome_css_analyze/src/keywords.rs b/crates/biome_css_analyze/src/keywords.rs --- a/crates/biome_css_analyze/src/keywords.rs +++ b/crates/biome_css_analyze/src/keywords.rs @@ -5124,6 +5124,315 @@ pub const MEDIA_FEATURE_NAMES: [&str; 60] = [ "width", ]; +pub const SHORTHAND_PROPERTIES: [&str;...
📎 Implement declaration-block-no-shorthand-property-overrides ## Description Implement [declaration-block-no-shorthand-property-overrides](https://stylelint.io/user-guide/rules/declaration-block-no-shorthand-property-overrides) > [!IMPORTANT] > - Please skip implementing options for now since we will evaluate ...
Hello! I'm interested in tackling this issue. We should come up with a better name. The current name is very long. What do you suggest @togami2864 ? How about `noShorthandPropertyOverrides`? I think it's fine not to include declaration-block since there's only one override rule.
2024-05-23T15:43:24Z
0.5
2024-06-10T19:56:07Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::no_shorthand_property_overrides::valid_css", "specs::nursery::no_shorthand_property_overrides::invalid_css" ]
[ "keywords::tests::test_kown_explorer_properties_order", "keywords::tests::test_function_keywords_sorted", "keywords::tests::test_kown_edge_properties_order", "keywords::tests::test_known_properties_order", "keywords::tests::test_kown_firefox_properties_order", "keywords::tests::test_kown_safari_properties...
[]
[]
auto_2025-06-09
biomejs/biome
2,957
biomejs__biome-2957
[ "2924" ]
a51ef9d771c526c5df42da0167a65813b7e80854
diff --git a/crates/biome_service/src/settings.rs b/crates/biome_service/src/settings.rs --- a/crates/biome_service/src/settings.rs +++ b/crates/biome_service/src/settings.rs @@ -1307,7 +1307,13 @@ pub(crate) fn to_override_format_settings( .unwrap_or(format_settings.format_with_errors); OverrideFormatS...
diff --git a/crates/biome_cli/tests/cases/overrides_formatter.rs b/crates/biome_cli/tests/cases/overrides_formatter.rs --- a/crates/biome_cli/tests/cases/overrides_formatter.rs +++ b/crates/biome_cli/tests/cases/overrides_formatter.rs @@ -234,6 +234,74 @@ fn does_include_file_with_different_overrides() { )); } ...
📝 disabling formatter doesn't work ### Environment information ```bash ❯ yarn biome rage --formatter yarn run v1.22.22 $ /Users/yagiz/coding/sentry/node_modules/.bin/biome rage --formatter CLI: Version: 1.7.3 Color support: true Platform: CPU Architecture: ...
Disabling javascript formatter still proposes the following change: ``` ./static/app/utils/queryClient.tsx format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ Formatter would have printed the following content: 290 290 │ } 291 291 │ 292 │ - type·ApiMutationVariables< ...
2024-05-23T15:01:06Z
0.5
2024-05-24T12:49:01Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "cases::overrides_formatter::complex_enable_disable_overrides", "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_rule_missing_group", "commands::lint::lint_help", "commands::lsp_proxy::lsp...
[ "commands::tests::incompatible_arguments", "commands::tests::no_fix", "diagnostics::test::termination_diagnostic_size", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "commands::tests::safe_and_unsafe_fixes", "commands::tests::safe_fixes", "execute::migrate::ignorefile::tests::negated_...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,940
biomejs__biome-2940
[ "2809" ]
b75d30e8c48f64dfc44b93585e1e280f8abda8cc
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs --- a/crates/biome_configuration/src/linter/rules.rs +++ b/crates/biome_configuration/src/linter/rules.rs @@ -2905,6 +2905,9 @@ pub struct Nursery { #[serde(skip_serializing_if = "Option::is_none")] pu...
diff --git a/Cargo.lock b/Cargo.lock --- a/Cargo.lock +++ b/Cargo.lock @@ -260,6 +260,7 @@ dependencies = [ "biome_test_utils", "insta", "lazy_static", + "rustc-hash", "schemars", "serde", "tests_macros", diff --git /dev/null b/crates/biome_css_analyze/src/lint/nursery/use_consistent_grid_areas.rs new file ...
📎 Implement named-grid-areas-no-invalid ## Description Implement [named-grid-areas-no-invalid](https://stylelint.io/user-guide/rules/named-grid-areas-no-invalid) > [!IMPORTANT] > - Please skip implementing options for now since we will evaluate users actually want them later. > - Please ignore handling extend...
I'd like to work on this issue:) @togami2864 what's the suggested name for this rule? Maybe: `useConsistentGridAreas`
2024-05-21T15:40:25Z
0.5
2024-06-10T11:35:00Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::nursery::use_consistent_grid_areas::valid_css", "specs::nursery::use_consistent_grid_areas::invalid_css" ]
[ "keywords::tests::test_function_keywords_sorted", "keywords::tests::test_known_properties_order", "keywords::tests::test_kown_edge_properties_order", "keywords::tests::test_kown_explorer_properties_order", "keywords::tests::test_kown_firefox_properties_order", "keywords::tests::test_kown_safari_properties...
[]
[]
auto_2025-06-09
biomejs/biome
2,898
biomejs__biome-2898
[ "2267" ]
2d61a95641ae4248c68b542a5bf56e83239f2235
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -71,6 +71,24 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b - Add new CLI options to control the CSS formatting. Check the [CLI reference page](https://biomejs.dev/reference/cli/) for more details. ...
diff --git a/crates/biome_cli/src/commands/mod.rs b/crates/biome_cli/src/commands/mod.rs --- a/crates/biome_cli/src/commands/mod.rs +++ b/crates/biome_cli/src/commands/mod.rs @@ -590,8 +626,183 @@ fn get_files_to_process( } } -/// Tests that all CLI options adhere to the invariants expected by `bpaf`. -#[test] ...
📎 `--write` everywhere ### Description See #2240 for more context. - [x] Add `--write` and `--unsafe` option to lint/check CLI commands - `--write` indicates if (safe) code fixes should be applied - `--unsafe` indicates that safe and unsafe code fixes should be applied if `--write` is passed - [x]...
Since this isn't clear unless someone reads the original discussion, `--apply` and `--apply-unsafe` have to be deprecated. On second thought, I think we should use `--fix` instead of `--write` because it is a more common option name among linters. This will generate more deprecations, but I think it is time or never? ...
2024-05-17T09:47:37Z
0.5
2024-05-19T19:39:25Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::negated_pattern", "execute::migrate::ignorefile::tests::empty", "execute::migrate::ignorefile::tests::relative_patterns", "execute::migrate::eslint_to_bi...
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,892
biomejs__biome-2892
[ "2882" ]
32e422d0d63ec17c7eded814cdde0d26b158c110
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -67,6 +67,47 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Configuration +#### New features + +- Add an rule option `fix` to override the code fix kind of a rule ([#2882](https://github.com/b...
diff --git a/crates/biome_js_analyze/src/lib.rs b/crates/biome_js_analyze/src/lib.rs --- a/crates/biome_js_analyze/src/lib.rs +++ b/crates/biome_js_analyze/src/lib.rs @@ -268,7 +268,7 @@ mod tests { options.configuration.rules.push_rule( RuleKey::new("nursery", "useHookAtTopLevel"), - ...
📎 Make code fix kind configurable ### Description Users have asked several times for a way to [disable a rule fix](https://github.com/biomejs/biome/discussions/2104) or to upgrade a rule fix from `unsafe` to `safe`. Some users would also like a way to downgrade a fix from `safe` to `unsafe`. Disabling a code fix...
2024-05-16T15:55:08Z
0.5
2024-05-16T17:47:21Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "globals::javascript::node::test_order", "globals::module::node::test_order", "globals::javascript::language::test_order", "assists::correctness::organize_imports::test_order", "globals::javascript::web::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,889
biomejs__biome-2889
[ "2799", "2797" ]
a678c68693d587641bbb1d9590aa10c947b6c6cb
diff --git a/crates/biome_analyze/src/rule.rs b/crates/biome_analyze/src/rule.rs --- a/crates/biome_analyze/src/rule.rs +++ b/crates/biome_analyze/src/rule.rs @@ -327,7 +327,7 @@ impl RuleMetadata { self } - pub fn to_applicability(&self) -> Applicability { + pub fn applicability(&self) -> Applica...
diff --git a/crates/biome_js_analyze/src/lint/suspicious/no_focused_tests.rs b/crates/biome_js_analyze/src/lint/suspicious/no_focused_tests.rs --- a/crates/biome_js_analyze/src/lint/suspicious/no_focused_tests.rs +++ b/crates/biome_js_analyze/src/lint/suspicious/no_focused_tests.rs @@ -4,7 +4,6 @@ use biome_analyze::{ ...
Compute fix kind from metatadata The `RuleAction` now accepts an `applicability` field, determining whether the action is safe/unsafe. However, we also provide the same information to our `RuleMeta`, which is `fix_kind`. Once https://github.com/biomejs/biome/issues/2798 is completed, we can retrieve the `fix_ki...
I can pick this up.
2024-05-16T14:43:41Z
0.5
2024-05-18T12:13:13Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "assists::correctness::organize_imports::test_order", "globals::javascript::web::test_order", "globals::javascript::node::test_order", "globals::javascript::language::test_order", "globals::module::node::test_order", "globals::typescript::node::test_order", "globals::typescript::language::test_order", ...
[]
[]
[]
auto_2025-06-09
biomejs/biome
2,868
biomejs__biome-2868
[ "2825" ]
d906941642cae0b3b3d0ac8f6de4365ce3aba8ac
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -143,6 +143,21 @@ z.object({}) - `lang="tsx"` is now supported in Vue Single File Components. [#2765](https://github.com/biomejs/biome/issues/2765) Contributed by @dyc3 +#### Bug fixes + +- The `const` modifier for type parameters is...
diff --git a/crates/biome_js_parser/src/syntax/typescript/types.rs b/crates/biome_js_parser/src/syntax/typescript/types.rs --- a/crates/biome_js_parser/src/syntax/typescript/types.rs +++ b/crates/biome_js_parser/src/syntax/typescript/types.rs @@ -1294,6 +1294,7 @@ fn parse_ts_call_signature_type_member(p: &mut JsParser...
🐛 parser chokes when `const` modifier describes a constructor function ### Environment information - [Biome playground](https://biomejs.dev/playground/?lineWidth=120&code=LwAvACAAVAB5AHAAZQBTAGMAcgBpAHAAdAAgAHAAbABhAHkAZwByAG8AdQBuAGQAOgAgAGgAdAB0AHAAcwA6AC8ALwB0AHMAcABsAGEAeQAuAGQAZQB2AC8ATgBWAFgAbABCAFcACgAvAC8AI...
2024-05-15T10:32:33Z
0.5
2024-05-15T11:11:43Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "tests::parser::ok::ts_construct_signature_member_ts" ]
[ "lexer::tests::bigint_literals", "lexer::tests::are_we_jsx", "lexer::tests::bang", "lexer::tests::binary_literals", "lexer::tests::all_whitespace", "lexer::tests::at_token", "lexer::tests::division", "lexer::tests::consecutive_punctuators", "lexer::tests::complex_string_1", "lexer::tests::block_co...
[]
[]
auto_2025-06-09
biomejs/biome
2,823
biomejs__biome-2823
[ "2771" ]
671e1386c3bf894bafef3235e6a2d46c30c88601
diff --git a/CHANGELOG.md b/CHANGELOG.md --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b ### Analyzer +#### Enhancements + +- Assume Vue compiler macros are globals when processing `.vue` files. ([#2771](https://github.com/bi...
diff --git a/crates/biome_cli/tests/cases/handle_vue_files.rs b/crates/biome_cli/tests/cases/handle_vue_files.rs --- a/crates/biome_cli/tests/cases/handle_vue_files.rs +++ b/crates/biome_cli/tests/cases/handle_vue_files.rs @@ -119,6 +119,28 @@ a.c = undefined; </script> <template></template>"#; +const VUE_TS_FILE_S...
🐛 vue formatter does not recognize vue magic ### Environment information ```block CLI: Version: 1.7.3 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: BIOME_LOG_DIR: unset NO...
Your solution is the correct approach. We suggest this caveat for other files too. Would like to send a PR to the website to document it? I dislike the workaround and don't love the idea of enshrining it. It's superficial (e.g. it shouldn't but does allow `x = defineEmits`) and can't provide many of even more semantic ...
2024-05-12T16:45:37Z
0.5
2024-05-16T14:35:56Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "commands::check::check_help", "commands::ci::ci_help", "commands::format::format_help", "commands::format::with_invalid_semicolons_option", "commands::lint::lint_rule_missing_group", "commands::lint::lint_help", "commands::lsp_proxy::lsp_proxy_help", "commands::rage::rage_help", "commands::migrate:...
[ "diagnostics::test::termination_diagnostic_size", "execute::migrate::ignorefile::tests::comments_and_empty_lines", "execute::migrate::ignorefile::tests::negated_pattern", "execute::migrate::ignorefile::tests::empty", "execute::migrate::ignorefile::tests::relative_patterns", "execute::migrate::ignorefile::...
[ "commands::explain::explain_help" ]
[]
auto_2025-06-09
biomejs/biome
2,811
biomejs__biome-2811
[ "2801" ]
50c270e9f024bca2e4fa5af6f54606d1bac28e86
diff --git a/crates/biome_analyze/CONTRIBUTING.md b/crates/biome_analyze/CONTRIBUTING.md --- a/crates/biome_analyze/CONTRIBUTING.md +++ b/crates/biome_analyze/CONTRIBUTING.md @@ -183,6 +183,9 @@ The documentation needs to adhere to the following rules: - When adding _invalid_ snippets in the `### Invalid` section, you...
diff --git a/crates/biome_js_analyze/src/lint/complexity/no_excessive_nested_test_suites.rs b/crates/biome_js_analyze/src/lint/complexity/no_excessive_nested_test_suites.rs --- a/crates/biome_js_analyze/src/lint/complexity/no_excessive_nested_test_suites.rs +++ b/crates/biome_js_analyze/src/lint/complexity/no_excessive...
Add a `language` field to `RuleMetadata` @togami2864 did try to add this, however it was added as an enum, which is too specific. We should add language as a plain static string. Once this is done, you could update all the rules to add something like this to the macro that creates the rules: ```diff declare_r...
I could take this one.
2024-05-10T14:10:38Z
0.5
2024-05-11T13:03:16Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "assists::correctness::organize_imports::test_order", "globals::javascript::node::test_order", "globals::javascript::language::test_order", "globals::module::node::test_order", "globals::typescript::node::test_order", "globals::javascript::web::test_order", "globals::typescript::language::test_order", ...
[]
[]
[]
auto_2025-06-09
biomejs/biome
4,791
biomejs__biome-4791
[ "3969" ]
3c32a66294c817d733c9f65c1916328a42c5efa9
diff --git a/Cargo.toml b/Cargo.toml --- a/Cargo.toml +++ b/Cargo.toml @@ -13,6 +13,7 @@ unused_lifetimes = "warn" unused_macro_rules = "warn" [workspace.lints.clippy] +allow_attributes = "deny" cargo_common_metadata = "allow" empty_docs = "allow" # ...
diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs --- a/crates/biome_cli/tests/commands/format.rs +++ b/crates/biome_cli/tests/commands/format.rs @@ -180,14 +180,10 @@ const APPLY_ATTRIBUTE_POSITION_AFTER: &str = r#"<Foo </Foo>; "#; -// Without this, Test (windows-la...
📎 Replace Clippy `allow` with `expect` ### Description Rust 1.81 stabilizes Clippy's [`expect` attribute](https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#expectlint). This attribute ensures that a lint diagnostic is emitted where the attribute appears. We should replace `allow` attribute with `expect`. ...
I just noticed you don't use 1.81.0 yet, so this task needs to wait until to move to 1.81 > so this task needs to wait until to move to 1.81 Done in #3972
2024-12-24T19:28:20Z
0.5
2024-12-29T16:48:49Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "err::multidigit_number_then_00_json", "err::structure_null_byte_outside_string_json" ]
[ "commands::tests::incompatible_arguments", "commands::tests::no_fix", "diagnostics::test::termination_diagnostic_size", "execute::migrate::eslint::tests::eslint_package_resolve_name", "commands::tests::safe_fixes", "commands::tests::safe_and_unsafe_fixes", "execute::migrate::ignorefile::tests::negated_p...
[ "commands::explain::explain_help" ]
[ "cases::diagnostics::max_diagnostics_are_lifted", "commands::lsp_proxy::lsp_proxy_help" ]
auto_2025-06-09
biomejs/biome
4,766
biomejs__biome-4766
[ "4767" ]
95680416c9c7aec57635e2e5762db3163d693414
diff --git /dev/null b/.changeset/remove_deprecaterd_rules.md new file mode 100644 --- /dev/null +++ b/.changeset/remove_deprecaterd_rules.md @@ -0,0 +1,15 @@ +--- +cli: major +--- + +# Remove deprecated rules + +The following _deprecated_ rules have been deleted: + +- `noInvalidNewBuiltin` +- `noNewSymbol` +- `useShor...
diff --git a/crates/biome_configuration/src/analyzer/linter/rules.rs b/crates/biome_configuration/src/analyzer/linter/rules.rs --- a/crates/biome_configuration/src/analyzer/linter/rules.rs +++ b/crates/biome_configuration/src/analyzer/linter/rules.rs @@ -5689,289 +5685,284 @@ impl Suspicious { index_se...
BREAKING: Remove deprecated rules - `noInvalidNewBuiltin` - `noNewSymbol` - `useShorthandArrayType` - `useSingleCaseStatement` - `noConsoleLog`
2024-12-20T16:27:51Z
0.5
2024-12-22T20:55:32Z
2425ce767fc6a93bbd091a5a9ec18beb5476e204
[ "specs::migrations::deleted_rules::invalid_json", "specs::migrations::deleted_rules::invalid_with_level_json" ]
[ "analyzer::assist::actions::test_order", "analyzer::linter::rules::test_order", "analyzer::test::correctly_parses_string_to_rule_selector", "analyzer::test::lsp_filter_to_rule_selector", "css::default_css", "diagnostics::test::diagnostic_size", "editorconfig::tests::should_correct_double_star", "edito...
[]
[]
auto_2025-06-09