base_commit stringlengths 40 40 | problem_statement stringlengths 26 4.45k | hints_text stringlengths 0 8.52k | created_at stringlengths 20 20 | instance_id stringlengths 16 18 | repo stringclasses 1
value | version stringclasses 13
values | patch stringlengths 223 160k | pull_number int64 57 2.9k | issue_numbers listlengths 1 1 | test_patch stringlengths 365 43.9k | environment_setup_commit stringclasses 13
values |
|---|---|---|---|---|---|---|---|---|---|---|---|
c02196882a336d46c3dd5fcfafeed45ef0a4490e | Implement wasi-keyvalue
An exploratory PR for exploring, apropos of #2447.
| 2024-10-24T23:21:04Z | fermyon__spin-2895 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 25d792db42..0e9cf73e06 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -7093,6 +7093,7 @@ dependencies = [
"spin-resource-table",
"spin-world",
"tempfile",
+ "thiserror",
"tokio",
"toml 0.8.19",
"tracing",
@@ -7355,6 +7356,7 @@ name = "spin-key-value-azure"
version = ... | 2,895 | [
"2486"
] | diff --git a/crates/factor-key-value/tests/factor_test.rs b/crates/factor-key-value/tests/factor_test.rs
index 83a67700d7..afd62a03f9 100644
--- a/crates/factor-key-value/tests/factor_test.rs
+++ b/crates/factor-key-value/tests/factor_test.rs
@@ -1,6 +1,6 @@
use anyhow::bail;
use spin_core::async_trait;
-use spin_fac... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
2a9bf7c57eda9aa42152f016373d3105170b164b | Support wasi-config
WASI is moving wasi-config to phase 3 soon. We should consider moving from the [spin variables](https://github.com/fermyon/spin/blob/main/wit/variables.wit) interface to [WASI config](https://github.com/WebAssembly/wasi-runtime-config).
The main diff is the need to add support for `get-all`
Sp... | 2024-09-27T03:14:37Z | fermyon__spin-2869 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index dcb490ed1f..7e275d9e29 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -7065,6 +7065,7 @@ version = "2.8.0-pre0"
dependencies = [
"anyhow",
"async-trait",
+ "futures",
"spin-locked-app",
"thiserror",
"tokio",
diff --git a/crates/expressions/Cargo.toml b/crates/expressio... | 2,869 | [
"2868"
] | diff --git a/tests/runtime-tests/tests/variables/spin.toml b/tests/runtime-tests/tests/variables/spin.toml
new file mode 100644
index 0000000000..b63cd61ddd
--- /dev/null
+++ b/tests/runtime-tests/tests/variables/spin.toml
@@ -0,0 +1,17 @@
+spin_manifest_version = "1"
+authors = [""]
+description = ""
+name = "variable... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
6df7262df11bce1046fb838ed2e7b1126c2966c0 | Enable spinning up only a subset of an application's components
## Summary
Say I have an app with 4 components but only want to run 2, I should be able to do the equivalent of `spin up --component "foo" --component "bar"`
## Background
Spin unifies serverless application development. Developers can define disti... | I am working on a SIP for this | 2024-09-12T17:06:00Z | fermyon__spin-2826 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 62cf5ab301..9a64364e80 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -7006,6 +7006,7 @@ dependencies = [
"futures",
"glob",
"hex",
+ "http 1.1.0",
"http-body-util",
"hyper 1.4.1",
"hyper-util",
@@ -7032,6 +7033,7 @@ dependencies = [
"spin-common",
"spin-doctor",
... | 2,826 | [
"2820"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 6cbf43cfc6..4b14a1e8a9 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -348,12 +348,7 @@ mod integration_tests {
},
)?;
- let expected = r#"Error: Couldn't find trigger executor for local app "spin.toml"
-
-Cau... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
09de9c38f6c9ca280020cd9afd5eb655651b8766 | Swift and Grain Templates Tests Not Working
After the Factors work the Swift and Grain templates have stopped working:
## Swift
When the `http_swift_template_smoke_test` test is run, the following error appears:
```
Error: preparing wasm "/tmp/t68d4-a/main.wasm"
Caused by:
This Wasm module appears t... | The Grain issue appears to be a missing newline between the header and the body, which reproduces under `wasmtime run`.
A newer versions of Grain (0.6.6) fixes the newline issue but has an exciting new problem: it emits duplicate imports which are permitted in core wasm modules but forbidden in component model modules.... | 2024-08-29T21:22:47Z | fermyon__spin-2789 | fermyon/spin | 3.2 | diff --git a/crates/templates/src/manager.rs b/crates/templates/src/manager.rs
index 4ddc7271cd..2ef5abfebb 100644
--- a/crates/templates/src/manager.rs
+++ b/crates/templates/src/manager.rs
@@ -566,7 +566,7 @@ mod tests {
}
}
- const TPLS_IN_THIS: usize = 12;
+ const TPLS_IN_THIS: usize = 11;
... | 2,789 | [
"2774"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index c09e241d3f..6cbf43cfc6 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -628,7 +628,6 @@ Caused by:
#[test]
#[cfg(target_arch = "x86_64")]
#[cfg(feature = "extern-dependencies-tests")]
- #[ignore = "https://github.com/fermyo... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
c02b44135364b6aab5f427a2697cfa347042c0af | Format toml in CI
I'd like us to add a toml formatter to CI. It'd be nice to not have to deal with formatting or alphabetical sorting in our `Cargo.toml`'s.
| This is as standard as it gets right now afaict: https://github.com/tamasfe/taplo
cc @rylev | 2024-08-26T21:17:10Z | fermyon__spin-2767 | fermyon/spin | 3.2 | diff --git a/.cargo/config.toml b/.cargo/config.toml
index c390ab08e0..00b96c3e8b 100644
--- a/.cargo/config.toml
+++ b/.cargo/config.toml
@@ -1,11 +1,11 @@
[net]
- git-fetch-with-cli = true
+git-fetch-with-cli = true
[target.aarch64-unknown-linux-gnu]
- rustflags = ["-C", "target-feature=+fp16"]
+rustflags =... | 2,767 | [
"2766"
] | diff --git a/crates/ui-testing/Cargo.toml b/crates/ui-testing/Cargo.toml
index ad0d9021be..ad2a7316ae 100644
--- a/crates/ui-testing/Cargo.toml
+++ b/crates/ui-testing/Cargo.toml
@@ -9,4 +9,4 @@ anyhow = "1.0"
dirs = "4.0"
libtest-mimic = "0.6.1"
snapbox = "0.4.12"
-tokio = { version = "1", features = ["macros", "rt... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
2d709df2d87ec1efd11a7052df6135e4ea29a7be | Abstract pg client type in factor-outbound-pg
This is followup work to #2632
| 2024-07-15T21:05:43Z | fermyon__spin-2651 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 891e4802c9..f2cae7b546 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -7615,7 +7615,6 @@ dependencies = [
"spin-core",
"spin-factor-outbound-networking",
"spin-factor-variables",
- "spin-factor-wasi",
"spin-factors",
"spin-factors-test",
"spin-world",
diff --git a/cra... | 2,651 | [
"2649"
] | diff --git a/crates/factor-outbound-pg/tests/factor_test.rs b/crates/factor-outbound-pg/tests/factor_test.rs
index 4f2f788521..07f47cc0c0 100644
--- a/crates/factor-outbound-pg/tests/factor_test.rs
+++ b/crates/factor-outbound-pg/tests/factor_test.rs
@@ -1,39 +1,48 @@
-use anyhow::bail;
+use anyhow::{bail, Result};
us... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
aedc2b8ccc65f41615fa7beb3e427843dd782114 | Support overriding the "Spin data dir" via env var
The Spin "data dir" (e.g. `~/.local/share`) is used as the root for plugin and template state. We have a request (part of #2555) to make this customizable to aid integration with other development tooling.
The data dir is constructed here: https://github.com/fermyon... | 2024-06-17T03:01:45Z | fermyon__spin-2568 | fermyon/spin | 3.2 | diff --git a/crates/common/src/data_dir.rs b/crates/common/src/data_dir.rs
index 1d6fc8a496..e5f1a05349 100644
--- a/crates/common/src/data_dir.rs
+++ b/crates/common/src/data_dir.rs
@@ -4,7 +4,10 @@ use anyhow::{anyhow, Result};
use std::path::{Path, PathBuf};
/// Return the default data directory for Spin
-pub fn... | 2,568 | [
"2563"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index f0841cab35..210a8440ae 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -903,7 +903,7 @@ route = "/..."
"--yes",
])
// Ensure that spin installs the plugins into the temporary directory
- ... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
4f63686c1ce2432306279b11deb28bb183e2eb50 | "Unknown lint: `clippy::blocks_in_conditions`" warning when clippying Spin source
The `clippy::blocks_in_conditions` lint causes an "unknown lint" warning on Rust 1.75. Looking at the linked issue it was maybe introduced in 1.76? The MSRV of Spin is 1.74. Are we happy to rev that to 1.76, or are we okay to ignore th... | > since the only reason we mention the lint is a bug that will hopefully get fixed soon
@itowlson can you link to the bug? Or not yet tracked? At first take, I'd be inclined to keep Spin at 1.74 and fix the bug.
@vdice https://github.com/rust-lang/rust-clippy/issues/12281 (ref: https://github.com/fermyon/spin/blob/a... | 2024-05-06T22:38:55Z | fermyon__spin-2491 | fermyon/spin | 3.2 | diff --git a/.cargo/config b/.cargo/config.toml
similarity index 100%
rename from .cargo/config
rename to .cargo/config.toml
diff --git a/crates/http/src/wagi/mod.rs b/crates/http/src/wagi/mod.rs
index bbb021dc93..6f93971767 100644
--- a/crates/http/src/wagi/mod.rs
+++ b/crates/http/src/wagi/mod.rs
@@ -184,13 +184,13 @... | 2,491 | [
"2424"
] | diff --git a/tests/testcases/mod.rs b/tests/testcases/mod.rs
index 4ebd2338bb..12eae3c469 100644
--- a/tests/testcases/mod.rs
+++ b/tests/testcases/mod.rs
@@ -345,11 +345,11 @@ pub fn bootstrap_smoke_test(
let mut custom_path = value.to_owned();
if value.starts_with('.') {
let... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
72cc02514e3506ddda357d03d2d060d8ad08f2b1 | Allow for more granular route matching in Spin
Currently, the route matching in spin can be of two forms
```toml
# match a single route
route = "/{path}"
# match any route with the prefix
route = "/{path-prefix}/..."
```
It would be helpful in certain cases if the route matching allowed more granularity. Fo... | I'm not necessarily opposed to this but just want to note that V2 manifests help with a workaround in some (not all!) situations:
```toml
[[trigger.http]]
route = "/..."
component = "bartholomew"
[[trigger.http]]
route = "/spin/..."
component = "proxy"
[[trigger.http]]
route = "/spin/v1/..."
component =... | 2024-04-22T03:53:13Z | fermyon__spin-2464 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 3242c114aa..d8b01f0cf2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2901,7 +2901,7 @@ dependencies = [
"httpdate",
"itoa",
"pin-project-lite",
- "socket2 0.4.10",
+ "socket2 0.5.6",
"tokio",
"tower-service",
"tracing",
@@ -5434,6 +5434,16 @@ version = "1.0.3"
sour... | 2,464 | [
"1923"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 9e30952a35..1a4fe2acbe 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -1273,6 +1273,41 @@ route = "/..."
Ok(())
}
+ #[test]
+ fn test_http_routing() -> anyhow::Result<()> {
+ run_test(
+ "http-routing... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
d6b9713c311208a250185f326987f3dcf651517c | In `component.files`, mapping a single file to `/` gives an unhelpful error
The `component.files` section allows a directory or file to be mounted in the guest at a specific location, e.g. `{ source = "cat.jpg", destination = "/dog.jpg" }`.
If the destination is an illegal name for a file, such as `/`, an error occu... | 2024-04-17T02:05:18Z | fermyon__spin-2460 | fermyon/spin | 3.2 | diff --git a/crates/loader/src/local.rs b/crates/loader/src/local.rs
index f9d019c737..c6e122ab94 100644
--- a/crates/loader/src/local.rs
+++ b/crates/loader/src/local.rs
@@ -269,7 +269,8 @@ impl LocalLoader {
} => {
let src = Path::new(source);
let dest = dest_root.join(d... | 2,460 | [
"2361"
] | diff --git a/crates/loader/tests/file-errors/bad.toml b/crates/loader/tests/file-errors/bad.toml
new file mode 100644
index 0000000000..3da28e46fc
--- /dev/null
+++ b/crates/loader/tests/file-errors/bad.toml
@@ -0,0 +1,12 @@
+spin_manifest_version = 2
+
+[application]
+name = "file-errors"
+
+[[trigger.http]]
+route = ... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
769d71efb1768f3f972ac47b5f05d41365b9a458 | Create directory for `static-fileserver` template
When a user runs the `static-fileserver` template, it asks for the directory from which to serve files.
If that directory doesn't exist, it would be a nice touch to create it.
| Implication is that `spin up` fails if the directory does not exist.
```
> spin up
Error: Failed to prepare configuration
Caused by:
0: Failed to collect file mounts for assets
1: Cannot place /Users/mikkel/code/temp/new_fileserver/assets: source must be a directory
```
We should improve that error m... | 2024-03-21T20:08:16Z | fermyon__spin-2387 | fermyon/spin | 3.2 | diff --git a/crates/templates/src/reader.rs b/crates/templates/src/reader.rs
index 9006c8a065..5e64739442 100644
--- a/crates/templates/src/reader.rs
+++ b/crates/templates/src/reader.rs
@@ -23,6 +23,7 @@ pub(crate) struct RawTemplateManifestV1 {
pub add_component: Option<RawTemplateVariant>,
pub parameters: ... | 2,387 | [
"1022"
] | diff --git a/crates/templates/src/test_built_ins/mod.rs b/crates/templates/src/test_built_ins/mod.rs
index ef32188fdb..aa018a984b 100644
--- a/crates/templates/src/test_built_ins/mod.rs
+++ b/crates/templates/src/test_built_ins/mod.rs
@@ -15,7 +15,53 @@ impl ProgressReporter for DiscardingReporter {
}
#[tokio::test... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
0df6fe6f3866b3eea7f4b3470e1b874a3d0a72d6 | Cyclic dependency (sometimes) may break Rust Analyzer
This is the error I am seeing when opening the Spin workspace:
```
[ERROR project_model::workspace] cyclic deps:
spin_trigger_http(Idx::<CrateData>(562)) ->
spin_testing(Idx::<CrateData>(560)), alternative path: spin_testing(Idx::<CrateData>(560)) ->
spin_... | 2024-03-18T23:37:23Z | fermyon__spin-2375 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 2b857cbac1..13bd06bd6b 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -6377,7 +6377,6 @@ dependencies = [
"spin-core",
"spin-http",
"spin-trigger",
- "spin-trigger-http",
"tokio",
"tracing-subscriber",
]
| 2,375 | [
"2253"
] | diff --git a/crates/testing/Cargo.toml b/crates/testing/Cargo.toml
index e6ba33bac7..45204df15d 100644
--- a/crates/testing/Cargo.toml
+++ b/crates/testing/Cargo.toml
@@ -13,7 +13,6 @@ serde_json = "1"
spin-app = { path = "../app" }
spin-core = { path = "../core" }
spin-http = { path = "../http" }
-spin-trigger-http... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
6178b24de08252072352e5c6ac9d77827f2a155a | `spin up --build --help` incorrectly builds the application
When passing both `--build` and `--help` to spin up, the application builds _while also showing help output_ - you can see this in the details block below. One would expect the application to not build, but instead only show the help output 😅 (although admitt... | 2024-03-05T17:09:39Z | fermyon__spin-2324 | fermyon/spin | 3.2 | diff --git a/src/commands/up.rs b/src/commands/up.rs
index ee6fbe30c1..d66d7930ba 100644
--- a/src/commands/up.rs
+++ b/src/commands/up.rs
@@ -151,10 +151,6 @@ impl UpCommand {
}
}
- if self.build {
- app_source.build().await?;
- }
-
// Get working dir holder an... | 2,324 | [
"2323"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index eb4e3db16c..330c3161d3 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -662,6 +662,47 @@ route = "/..."
Ok(())
}
+ #[test]
+ fn spin_up_help_build_does_not_build() -> anyhow::Result<()> {
+ let env = testing_fram... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
b3cfbba3ea576a4094122e04bc287458e5dbe920 | Configurable allowed outbound hosts based on application variables
I have the following setup: the host I need my application to send outbound connections to is an application variable that is set at runtime through an application variable.
Is there a way to use a (or more) variable(s) to configure an allowed outbou... | I tried tackling this for #653 a while ago but realized that this would require some major design changes to the variables subsystem. One question is whether these settings should update if the interpolated values from a dynamic variables provider update. On top of that the current implementation just makes it hard to ... | 2024-02-27T05:35:10Z | fermyon__spin-2299 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 6448dcb92f..2b8e78ec5d 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4257,6 +4257,7 @@ dependencies = [
"reqwest",
"spin-app",
"spin-core",
+ "spin-expressions",
"spin-locked-app",
"spin-outbound-networking",
"spin-world",
@@ -4273,6 +4274,7 @@ dependencies = [
"r... | 2,299 | [
"2153"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 330c3161d3..ea6177ff31 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -245,6 +245,7 @@ mod integration_tests {
[],
testing_framework::ServicesConfig::none(),
SpinAppType::None,
+ |_| Ok(()),... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
bf3be1b271bf0efa7c3bffde071d512ef646fe81 | Mounting the same component on multiple triggers does not work
When trying to use the same component for multiple triggers, only the final trigger works when running a `spin up`
An example of a manifest is
```toml
spin_manifest_version = 2
[application]
name = "test"
version = "0.1.0"
authors = ["karthik28... | 2023-12-06T00:49:11Z | fermyon__spin-2145 | fermyon/spin | 3.2 | diff --git a/crates/trigger/src/lib.rs b/crates/trigger/src/lib.rs
index 961ad8947f..5b8c10559c 100644
--- a/crates/trigger/src/lib.rs
+++ b/crates/trigger/src/lib.rs
@@ -7,7 +7,6 @@ use std::{collections::HashMap, marker::PhantomData};
use anyhow::{Context, Result};
pub use async_trait::async_trait;
-use indexmap:... | 2,145 | [
"2143"
] | diff --git a/tests/http/simple-spin-rust/double-trouble.toml b/tests/http/simple-spin-rust/double-trouble.toml
new file mode 100644
index 0000000000..b42f8181c5
--- /dev/null
+++ b/tests/http/simple-spin-rust/double-trouble.toml
@@ -0,0 +1,22 @@
+spin_manifest_version = 2
+
+[application]
+name = "spin-hello-world"
+ve... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
8337a35c57d0540caf7a48d70e839a1e41608011 | Allow plugin settings in the manifest
A user is working on a `spin clean` plugin. The files to delete on a clean may be language and application specific (e.g. in Rust the `target` directory, in JS the `dist` directory, etc.). Noted troublemaker @mikkelhegn suggested the info could be stored in `spin.toml` as e.g. `c... | I'm definitely weary of option 2. I think this is the most risky choice fraught with the evilest of demons.
I'm not strongly opposed to the idea of a `component.tool.clean` where `tool` is effectively like `package.metadata` in `Cargo.toml`. Generically we reserve `tool` (or whatever) and allow per compoment customiza... | 2023-11-16T21:46:17Z | fermyon__spin-2104 | fermyon/spin | 3.2 | diff --git a/crates/manifest/src/compat.rs b/crates/manifest/src/compat.rs
index fd453fa5ee..4cb12d698d 100644
--- a/crates/manifest/src/compat.rs
+++ b/crates/manifest/src/compat.rs
@@ -21,6 +21,7 @@ pub fn v1_to_v2_app(manifest: v1::AppManifestV1) -> Result<v2::AppManifest, Erro
description: manifest.descrip... | 2,104 | [
"1768"
] | diff --git a/crates/manifest/tests/ui/maximal.json b/crates/manifest/tests/ui/maximal.json
index 4780f693b1..1968f2d32f 100644
--- a/crates/manifest/tests/ui/maximal.json
+++ b/crates/manifest/tests/ui/maximal.json
@@ -12,6 +12,11 @@
"fake": {
"global_option": true
}
+ },
+ "tool": {
+ ... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
273c684627837e48c141050ad10ec23f94244b45 | Relax the .cache requirement for `spin_loader::from_file`
Hi there,
I was upgrading the spin shim from spin 1.x to 2.0.0 and found that the `spin_loader::from_file` function requires the work directory to either have `$HOME/.cache` or `XDG_CACHE_HOME` for Linux environment due to the usage of `dirs::cache_dir()`. I ... | Replied inline: https://github.com/deislabs/containerd-wasm-shims/pull/177#discussion_r1388210225 | 2023-11-14T20:25:31Z | fermyon__spin-2095 | fermyon/spin | 3.2 | diff --git a/crates/loader/src/lib.rs b/crates/loader/src/lib.rs
index 86e625d79f..9b5d5f72b1 100644
--- a/crates/loader/src/lib.rs
+++ b/crates/loader/src/lib.rs
@@ -30,10 +30,11 @@ pub(crate) const MAX_FILE_LOADING_CONCURRENCY: usize = 16;
pub async fn from_file(
manifest_path: impl AsRef<Path>,
files_moun... | 2,095 | [
"2072"
] | diff --git a/crates/loader/tests/ui.rs b/crates/loader/tests/ui.rs
index 8dc80d2858..2debf28203 100644
--- a/crates/loader/tests/ui.rs
+++ b/crates/loader/tests/ui.rs
@@ -49,6 +49,7 @@ fn run_test(input: &Path, normalizer: &mut Normalizer) -> Result<String, Failed>
let locked = spin_loader::from_file(
... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
40bbead627ef6c8f61706516e5f11f1122a33f21 | Manifest(v2): improved error when component id not kebab-case
For v2 manifests (`spin_manifest_version = 2`), the [component ID must be kebab-case](https://github.com/fermyon/spin/blob/main/crates/manifest/src/schema/v2.rs) if employing separators. When not in this form, the `spin up` error should mention this. As o... | 2023-11-13T14:14:18Z | fermyon__spin-2092 | fermyon/spin | 3.2 | diff --git a/crates/manifest/src/schema/v2.rs b/crates/manifest/src/schema/v2.rs
index 18c5233ee5..c51c9da24f 100644
--- a/crates/manifest/src/schema/v2.rs
+++ b/crates/manifest/src/schema/v2.rs
@@ -70,7 +70,7 @@ pub struct OneOrManyComponentSpecs(#[serde(with = "one_or_many")] pub Vec<Compon
/// Component reference... | 2,092 | [
"1950"
] | diff --git a/crates/manifest/tests/ui/invalid/bad_kebab_component_ref.err b/crates/manifest/tests/ui/invalid/bad_kebab_component_ref.err
new file mode 100644
index 0000000000..59fdcfcc82
--- /dev/null
+++ b/crates/manifest/tests/ui/invalid/bad_kebab_component_ref.err
@@ -0,0 +1,6 @@
+TOML parse error at line 7, column ... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
fb03aadaefbde4e4d3a26169782f5efa44847940 | Outgoing post requests send(Request::post(...)) do not work
spin 2.0.0 (e4bb235 2023-11-03)
cloud 0.5.1 [installed]
js2wasm 0.6.1 [installed]
py2wasm 0.3.2 [installed]
I am trying to send an outgoing post request with some payload but the http::send() does not finish.
```rust
#[http_component]
async fn hand... | I wrote a dummy server that outputs incoming requests:
INFO dummy_server: req: Request { method: POST, uri: http://localhost:3001/, version: HTTP/1.1, headers: {"host": "localhost:3001", "transfer-encoding": "chunked"}, body: Body(Streaming) }
at src/main.rs:9
INFO dummy_server: Body(Streaming)
at src/ma... | 2023-11-10T16:34:48Z | fermyon__spin-2086 | fermyon/spin | 2.0 | diff --git a/Cargo.lock b/Cargo.lock
index 1191cd0198..c50558a2ba 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5637,6 +5637,7 @@ dependencies = [
"futures",
"glob",
"hex",
+ "http-body-util",
"hyper 1.0.0-rc.3",
"indicatif 0.17.6",
"is-terminal",
diff --git a/Cargo.toml b/Cargo.toml
index 2acf7c4205..66b792... | 2,086 | [
"2080"
] | diff --git a/tests/http/headers-env-routes-test/Cargo.lock b/tests/http/headers-env-routes-test/Cargo.lock
index d57a7d2a78..490730043f 100644
--- a/tests/http/headers-env-routes-test/Cargo.lock
+++ b/tests/http/headers-env-routes-test/Cargo.lock
@@ -377,7 +377,7 @@ dependencies = [
[[package]]
name = "spin-sdk"
-v... | fb03aadaefbde4e4d3a26169782f5efa44847940 |
3fbff440a53fb45a8d8df25d763f9141c65af614 | Outgoing post requests send(Request::post(...)) do not work
spin 2.0.0 (e4bb235 2023-11-03)
cloud 0.5.1 [installed]
js2wasm 0.6.1 [installed]
py2wasm 0.3.2 [installed]
I am trying to send an outgoing post request with some payload but the http::send() does not finish.
```rust
#[http_component]
async fn hand... | I wrote a dummy server that outputs incoming requests:
INFO dummy_server: req: Request { method: POST, uri: http://localhost:3001/, version: HTTP/1.1, headers: {"host": "localhost:3001", "transfer-encoding": "chunked"}, body: Body(Streaming) }
at src/main.rs:9
INFO dummy_server: Body(Streaming)
at src/ma... | 2023-11-10T16:13:07Z | fermyon__spin-2083 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 4c03d62ec7..5d16ce9406 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5647,6 +5647,7 @@ dependencies = [
"futures",
"glob",
"hex",
+ "http-body-util",
"hyper 1.0.0-rc.3",
"indicatif 0.17.6",
"is-terminal",
diff --git a/Cargo.toml b/Cargo.toml
index e304790437..1c94ce... | 2,083 | [
"2080"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 36ab055056..d7c07bb729 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -2,6 +2,7 @@
mod integration_tests {
use anyhow::{anyhow, Context, Error, Result};
use futures::{channel::oneshot, future, stream, FutureExt};
+ use http_bo... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
a7c0f6a7f23f74742654d0f69ae888ebf18f6407 | `spin add` doesn't check for manifest version mis-match
When using the `spin add` command with a template using the manifest v1 format, with an application, which already has the manifest in v2, the command completes, and you end up with a non-working manifest.
It would be great to have something checking if there's... | Yes, we should also check for same trigger type.
The slight challenge here is that fragment TOML in `spin add` doesn't carry a version number. We can either apply some heuristics or add some metadata to the trigger (which is what we did for the trigger type check I think). | 2023-11-01T21:01:39Z | fermyon__spin-2025 | fermyon/spin | 3.2 | diff --git a/crates/templates/src/app_info.rs b/crates/templates/src/app_info.rs
index 4326c3a7e3..fef0e8fb8a 100644
--- a/crates/templates/src/app_info.rs
+++ b/crates/templates/src/app_info.rs
@@ -11,6 +11,7 @@ use spin_manifest::schema::v1;
use crate::store::TemplateLayout;
pub(crate) struct AppInfo {
+ manif... | 2,025 | [
"2016"
] | diff --git a/crates/templates/tests/v1manifest.toml b/crates/templates/tests/v1manifest.toml
new file mode 100644
index 0000000000..c98aab9aff
--- /dev/null
+++ b/crates/templates/tests/v1manifest.toml
@@ -0,0 +1,8 @@
+spin_manifest_version = "1"
+name = "v1"
+version = "0.1.0"
+trigger = { type = "http", base = "/" }
... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
3167e6ee78e739367762fb41ccc2098f9620c40e | unable to use docker compose file to run e2e tests on newer macs
While trying to run the docker compose file for the e2e tests, I ran into the following error:
```
$ docker build -t spin-e2e-tests -f e2e-tests-aarch64.Dockerfile
$ docker compose -f e2e-tests-docker-compose.yml run e2e-tests
[+] Running 0/1
⠧ my... | I used the `mysql/mysql-server` image locally to run the docker compose file and got past the previous issue but wasn't able to get past compiling the spin-cli:
```
error: linking with `cc` failed: exit status: 1 [... lots of other output here]
= note: collect2: fatal error: ld terminated with signal 9 [Killed]
... | 2023-02-17T05:52:15Z | fermyon__spin-1174 | fermyon/spin | 0.9 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 0b89821db3..6ce192740b 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -170,4 +170,4 @@ jobs:
- name: Run e2e tests
run: |
chmod +x `pwd`/target/release/spin
- docker compose -f... | 1,174 | [
"1105"
] | diff --git a/e2e-tests-aarch64.Dockerfile b/e2e-tests-aarch64.Dockerfile
index 282bd5610c..042f5fe536 100644
--- a/e2e-tests-aarch64.Dockerfile
+++ b/e2e-tests-aarch64.Dockerfile
@@ -1,5 +1,8 @@
FROM ubuntu:22.04
+ARG BUILD_SPIN=false
+ARG SPIN_VERSION=canary
+
WORKDIR /root
RUN apt-get update && apt-get install -... | 3da388c68704a21fd6292987b4e9ddb1079d2984 |
e2f4fac924bcd2e222faad7eb49bb7dcfcec62ad | Rename `spin_version` to `spin_manifest_version` in Spin application manifest
## Issue
Spin application manifests (`spin.toml`) must specify what application manifest version it is using. This is set by setting the [`spin_version` in a `spin.toml`](https://github.com/fermyon/spin/blob/7cad829d6c87d6956a049bb6fa7e8d371... | I'm weary of the custom deserializer approach for *1*. My concern is that for tools not written in rust that might consume a `spin.toml` can now no longer just deserialize the manifest however they have to implement this custom deserializing. Thinking about some theoretical plugin implemented in `go` that consumes a `s... | 2023-02-16T21:18:21Z | fermyon__spin-1169 | fermyon/spin | 0.9 | diff --git a/crates/bindle/src/expander.rs b/crates/bindle/src/expander.rs
index ef6d89999e..5001384bdc 100644
--- a/crates/bindle/src/expander.rs
+++ b/crates/bindle/src/expander.rs
@@ -20,7 +20,7 @@ pub async fn expand_manifest(
let app_file = absolutize(app_file)?;
let manifest = spin_loader::local::raw_ma... | 1,169 | [
"1069"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 06a2e0704c..e9b17cfb62 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -47,12 +47,34 @@ async fn test_from_local_source() -> Result<()> {
Ok(())
}
+#[test]
+fn test_manifest_v1_signatur... | 3da388c68704a21fd6292987b4e9ddb1079d2984 |
25d35a8bbafb447cacc4357a79f8c50ac81007c8 | Make log output to stdout default
When running Spin locally in a development loop, I always use `--follow-all` to have my logs written out to the console.
From conversations I've heard others not discovering this option, e.g.:
> Debugging in spin was an initial pain point until finding the log directory. Did not ... | Is that "make writing to standard output default and _not_ write to a log directory", or do we want both?
My preference would be default to both, meaning only changing the current default behavior to also write to stdout. If completeness is important, having switches being `--logging file-only` `--logging stdout-only` ... | 2023-02-07T00:08:14Z | fermyon__spin-1115 | fermyon/spin | 0.8 | diff --git a/crates/trigger/src/cli.rs b/crates/trigger/src/cli.rs
index 082b6f407f..f115cbc56b 100644
--- a/crates/trigger/src/cli.rs
+++ b/crates/trigger/src/cli.rs
@@ -65,11 +65,18 @@ where
pub follow_components: Vec<String>,
/// Print all component output to stdout/stderr
+ /// Deprecated
+ #[clap... | 1,115 | [
"928"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 793f47153d..1fc926676f 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -1076,7 +1076,7 @@ route = "/..."
let output = run(up_help_args, None, None)?;
let stdout = String::from_utf8_lossy(&output.stdout);
- assert!(... | 25d35a8bbafb447cacc4357a79f8c50ac81007c8 |
1abf1c0b396e574e7ce0ebdd76939e6efcaaafc0 | spin plugin -> spin plugins
Super minor nit. Currently the top level command is `plugin` and is aliased to `plugins`. Should the top level command be `plugins` instead to match the plurality of `spin templates`? Still aliased to plugin for convenience. Thoughts welcome.
| @itowlson and I were discussing this on the aliasing PR: https://github.com/fermyon/spin/pull/994#issuecomment-1358408185. +1 for changing `Plugin` to `Plugins`. I am happy to take this on | 2023-01-23T22:58:54Z | fermyon__spin-1043 | fermyon/spin | 0.7 | diff --git a/crates/plugins/src/manifest.rs b/crates/plugins/src/manifest.rs
index 03c73bf13b..8e01580cd8 100644
--- a/crates/plugins/src/manifest.rs
+++ b/crates/plugins/src/manifest.rs
@@ -141,7 +141,7 @@ fn inner_check_supported_version(
eprintln!("Plugin is not compatible with this version of Spin (sup... | 1,043 | [
"1042"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index e1e5cd30ff..944bebe317 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -1201,7 +1201,7 @@ route = "/..."
// Install plugin
let install_args = vec![
SPIN_BINARY,
- "plugin",
+ "plugins",
... | 1abf1c0b396e574e7ce0ebdd76939e6efcaaafc0 |
7c00e8a59cb0436ecc017f16371db3929185b2af | Variable default value ignored and error thrown when Vault Config Provider is used
In my Spin app I've configured three variables (**it's important to have at least one variable configured which is not stored in Vault as secret**)
```toml
[variables]
a = { default = "foo" }
b = { required = true }
c = { required... | Just to be clear, if you're _not_ using Vault (so `b` and `c` are provided via environment variables), it works correctly, right? This is only when the Vault config provider is in the mix?
Just checked it. Yes, when I do not link Vault, it works as expected.
Thanks, I can reproduce this and will take a look.
Wheneve... | 2022-12-16T00:00:19Z | fermyon__spin-984 | fermyon/spin | 0.7 | diff --git a/crates/config/src/provider/vault.rs b/crates/config/src/provider/vault.rs
index 58fd653dad..afc8c08b2d 100644
--- a/crates/config/src/provider/vault.rs
+++ b/crates/config/src/provider/vault.rs
@@ -1,8 +1,9 @@
-use anyhow::Result;
+use anyhow::{Context, Result};
use async_trait::async_trait;
use serde::{... | 984 | [
"983"
] | diff --git a/tests/http/vault-config-test/spin.toml b/tests/http/vault-config-test/spin.toml
index c61db840f7..422a6f3b3e 100644
--- a/tests/http/vault-config-test/spin.toml
+++ b/tests/http/vault-config-test/spin.toml
@@ -7,13 +7,15 @@ version = "0.1.0"
[variables]
password = { required = true }
+greeting = { defa... | 1abf1c0b396e574e7ce0ebdd76939e6efcaaafc0 |
268ae0a0015ac5b971ddd11a4c336fc24b76e754 | request to add `spin plugin list` command
it will be nice to list the `plugins` available to install (or already installed?)
| listing available plugins (in the plugins repo) vs installed ones in fairly different on the implementation side. Do we want to support both? We could do the following:
`spin plugin list`: lists installed plugins
`spin plugin search`: displays all plugins available in plugins registry
Or maybe `spin plugin install` (... | 2022-12-14T01:02:48Z | fermyon__spin-972 | fermyon/spin | 0.6 | diff --git a/crates/plugins/src/lookup.rs b/crates/plugins/src/lookup.rs
index 194e0ae28d..08e4847aa4 100644
--- a/crates/plugins/src/lookup.rs
+++ b/crates/plugins/src/lookup.rs
@@ -100,9 +100,13 @@ fn spin_plugins_repo_manifest_path(
plugin_version: &Option<Version>,
plugins_dir: &Path,
) -> PathBuf {
+ ... | 972 | [
"937"
] | diff --git a/crates/plugins/tests/README.md b/crates/plugins/tests/README.md
new file mode 100644
index 0000000000..8462f4b10a
--- /dev/null
+++ b/crates/plugins/tests/README.md
@@ -0,0 +1,8 @@
+## Fake plugin manifests
+
+These plugin manifests are fake - they exist to help exercise compatibility
+failure paths. They... | 268ae0a0015ac5b971ddd11a4c336fc24b76e754 |
8dfc4d6fbb31d624eb034f78640cb207bec1f682 | Add `spin up` option to mount static asset directory directly
Currently, `spin up` always copies static assets into a temporary directory and mounts that into the host. This creates friction when iteratively developing static assets (e.g. SPAs) since `spin up` must be restarted each time any asset changes in order for... | It would be good to ponder the behaviour on patterns/individual files. Many users will read a `--direct-mount` flag as implying that _all_ files, including loose ones, are also directly mounted, but as far as I know that would require mounting the entire containing directory, which is what the copy sought to avoid.
... | 2022-12-12T22:01:37Z | fermyon__spin-967 | fermyon/spin | 0.6 | diff --git a/crates/loader/src/local/assets.rs b/crates/loader/src/local/assets.rs
index a38f0f0de6..174c95bec3 100644
--- a/crates/loader/src/local/assets.rs
+++ b/crates/loader/src/local/assets.rs
@@ -18,6 +18,26 @@ use super::config::{RawDirectoryPlacement, RawFileMount};
/// Prepare all local assets given a compon... | 967 | [
"964"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index ceaff588af..3aae011dc4 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -11,7 +11,7 @@ async fn test_from_local_source() -> Result<()> {
let temp_dir = tempfile::tempdir()?;
let dir ... | 268ae0a0015ac5b971ddd11a4c336fc24b76e754 |
c368fce72261339b6de908e22b81cf21217a8181 | `spin up --help` doesn't display all options unless application is fully ready to load
If I do a `spin up --help` in a directory with a `spin.toml`, I normally get a full set of options including those that (internally) happen to be implemented through the trigger such as `--log-dir` and `--follow`.
However, if I `s... | 2022-12-05T00:14:22Z | fermyon__spin-934 | fermyon/spin | 0.6 | diff --git a/src/commands/up.rs b/src/commands/up.rs
index 958a59ccd2..0a83078c82 100644
--- a/src/commands/up.rs
+++ b/src/commands/up.rs
@@ -148,32 +148,20 @@ impl UpCommand {
ApplicationTrigger::Redis(_) => "redis",
};
- // Build and write app lock file
- let locked_app = spin_t... | 934 | [
"932"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index e0c5373e65..d191e60fcc 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -1078,6 +1078,43 @@ mod integration_tests {
Ok(())
}
+ #[test]
+ fn spin_up_gives_help_on_new_app() -> Result<()> {
+ let temp_dir = tempdir(... | 268ae0a0015ac5b971ddd11a4c336fc24b76e754 | |
cfc203e63a4a0e36a4ee94d66362c04f07d52841 | `spin build` trigger validation messages are not explained
I fouled up the Redis template so that `trigger` had a `base` field instead of `address`.
When I ran `spin build`, it said `Error: missing field `address``.
As my brain was in the "I am compiling" mindset, I assumed there was something wrong in the code, ... | I think this could be a "good first issue" if we flesh it out a bit more, e.g. explaining where in the code to add context. | 2022-11-22T00:57:31Z | fermyon__spin-913 | fermyon/spin | 0.6 | diff --git a/Cargo.lock b/Cargo.lock
index 849055c632..f3a5ac0b31 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4006,8 +4006,11 @@ version = "0.6.0"
dependencies = [
"anyhow",
"futures",
+ "serde",
"spin-loader",
"subprocess",
+ "tokio",
+ "toml",
"tracing",
]
diff --git a/crates/build/Cargo.toml b/crates/... | 913 | [
"473"
] | diff --git a/crates/build/tests/bad_trigger.toml b/crates/build/tests/bad_trigger.toml
new file mode 100644
index 0000000000..8af11b6e71
--- /dev/null
+++ b/crates/build/tests/bad_trigger.toml
@@ -0,0 +1,13 @@
+spin_version = "1"
+name = "bad_trigger"
+# The trigger is missing the `base` field
+trigger = { type = "http... | 268ae0a0015ac5b971ddd11a4c336fc24b76e754 |
79d16153927850496cb84c1f50a8bfd3ae3e7821 | Grab `.wasm` binaries from the web
I want to be able to share modules with others but not require them to download/compile them themselves
## Spin.toml
My intuition says this URL would be written in the `spin.toml` like so:
```
[[component]]
id = "key-value"
source = "https://github.com/ecumene/components/.... | We could combine the two ways: having spin download these wasm files at runtime and cache them to a `spin.lock` file, which includes the checksums. In this way when the next time spin is running, if the checksum of the `spin.toml` is not changed, then can use the cached wasm files. And of course if the lock file is del... | 2022-11-09T04:41:25Z | fermyon__spin-890 | fermyon/spin | 0.6 | diff --git a/crates/loader/src/local/config.rs b/crates/loader/src/local/config.rs
index 3773d7697c..5cde747cbd 100644
--- a/crates/loader/src/local/config.rs
+++ b/crates/loader/src/local/config.rs
@@ -137,6 +137,8 @@ pub enum RawModuleSource {
FileReference(PathBuf),
/// Reference to a remote bindle
Bi... | 890 | [
"393"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index f355fc7958..ceaff588af 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -91,11 +91,63 @@ fn test_manifest() -> Result<()> {
let b = match cfg.components[1].source.clone() {
RawModu... | 268ae0a0015ac5b971ddd11a4c336fc24b76e754 |
f94e397a7c5f83a753e3333ec3d9eed2a440261a | Spurious warning "skipping duplicate package `spinhelloworld`" when using Rust SDK
When you build Rust application that references the Rust SDK, you get a spurious warning:
```
warning: skipping duplicate package `spinhelloworld` found at `/home/ivan/.cargo/git/checkouts/spin-91500438ac5656d2/b316f47/examples/http-... | Warning doesn't happen in Rust 1.62.1 but does in 1.63.0.
Also affects programs that import Spin crates, it seems.
https://github.com/rust-lang/cargo/issues/10752 | 2022-10-26T18:12:56Z | fermyon__spin-862 | fermyon/spin | 0.6 | diff --git a/examples/http-rust/Cargo.toml b/examples/http-rust/Cargo.toml
index 6a639603ea..5fe0d9383f 100644
--- a/examples/http-rust/Cargo.toml
+++ b/examples/http-rust/Cargo.toml
@@ -1,5 +1,5 @@
[package]
-name = "spinhelloworld"
+name = "http-rust"
version = "0.1.0"
edition = "2021"
@@ -18,4 +18,4 @@ spin-sdk... | 862 | [
"793"
] | diff --git a/tests/http/simple-spin-rust/Cargo.lock b/tests/http/simple-spin-rust/Cargo.lock
index 84414d3142..e842ec65e4 100644
--- a/tests/http/simple-spin-rust/Cargo.lock
+++ b/tests/http/simple-spin-rust/Cargo.lock
@@ -126,6 +126,17 @@ dependencies = [
"proc-macro2",
]
+[[package]]
+name = "simple-spin-rust"
+... | 268ae0a0015ac5b971ddd11a4c336fc24b76e754 |
eb50b54c51cb6290a592bdbfc4aa4882fdfe7191 | Add redis command DEL to redis sdk rust
Add redis command DEL to redis sdk rust, this is a common used command in nearly all cases.
| 2022-10-18T15:22:30Z | fermyon__spin-828 | fermyon/spin | 0.5 | diff --git a/Cargo.toml b/Cargo.toml
index ec8a8e960d..dcc1d9b6bc 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -75,6 +75,7 @@ vergen = { version = "7", default-features = false, features = [ "build", "git"
[features]
default = []
e2e-tests = []
+outbound-redis-tests = []
[workspace]
members = [
diff --git a/Makef... | 828 | [
"801"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 55b2d2bb0d..a7690d02b4 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -602,6 +602,30 @@ mod integration_tests {
}
}
+ #[cfg(feature = "outbound-redis-tests")]
+ mod outbound_pg_tests {
+ use super::*;
+
+ ... | eb50b54c51cb6290a592bdbfc4aa4882fdfe7191 | |
646ff10807ea049a4630ad56c84ea3faddaf3b22 | Better error messaging for trigger execution failures
I was running a Spin application without an available Redis instance on the configured endpoint for the trigger:
`trigger = { type = "redis", address = "redis://localhost:6379" }`
The error message produced on a macOS was:
```
2022-08-21T09:37:21.146153Z E... | 2022-10-02T17:59:40Z | fermyon__spin-800 | fermyon/spin | 0.5 | diff --git a/crates/http/benches/baseline.rs b/crates/http/benches/baseline.rs
index 00f6250743..f7ae27b639 100644
--- a/crates/http/benches/baseline.rs
+++ b/crates/http/benches/baseline.rs
@@ -7,7 +7,7 @@ use futures::future::join_all;
use http::uri::Scheme;
use http::Request;
use spin_http::HttpTrigger;
-use spin... | 800 | [
"704"
] | diff --git a/crates/redis/src/tests.rs b/crates/redis/src/tests.rs
index 951ae655d3..29620f7cf4 100644
--- a/crates/redis/src/tests.rs
+++ b/crates/redis/src/tests.rs
@@ -1,7 +1,7 @@
use super::*;
use anyhow::Result;
use redis::{Msg, Value};
-use spin_testing::{tokio, TestConfig};
+use spin_testing::{tokio, RedisTes... | eb50b54c51cb6290a592bdbfc4aa4882fdfe7191 | |
0e3b3d43659f1c881f07b0aca54678ed66a7aa79 | Don't allow variables containing the '.' character
This is firmly in the "machiavellian user could shoot self in foot" category - I only encountered it because I was exploring the config code and wanted to understand the tree traversal stuff. Priority is "wash your dog first."
If you create a variable with a "." ch... | 2022-09-08T17:42:55Z | fermyon__spin-750 | fermyon/spin | 0.5 | diff --git a/Cargo.lock b/Cargo.lock
index 7f1463987c..acb3aea92e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3351,7 +3351,10 @@ name = "spin-config"
version = "0.2.0"
dependencies = [
"anyhow",
+ "async-trait",
"serde",
+ "spin-engine",
+ "spin-manifest",
"thiserror",
"tokio",
"toml",
@@ -3367,7 +3370,6 @... | 750 | [
"718"
] | diff --git a/crates/testing/src/lib.rs b/crates/testing/src/lib.rs
index 51744b34b4..eaf5c4504b 100644
--- a/crates/testing/src/lib.rs
+++ b/crates/testing/src/lib.rs
@@ -79,6 +79,7 @@ impl TestConfig {
id: "test-component".to_string(),
description: None,
wasm: Default::default(),... | eb50b54c51cb6290a592bdbfc4aa4882fdfe7191 | |
e8b6667af92152971faf96e53669531c45b55c1d | `allowed_http_hosts` requires protocol but ignores it
If I write `allowed_http_hosts = ["https://localhost:3001"]` I can still make a request to `http://localhost:3001/` and it works.
If we are to require a protocol, shouldn't that be enforced? I assumed this was why we required a protocol rather than just a hostna... | Also, any port the operator specifies is ignored, e.g. if I write `allowed_http_hosts = ["https://localhost:4444"]` then make a request to `http://localhost:3001/`, it is allowed.
This is certainly in line with the name "hosts" but maybe we should validate that no port is given, or an operator might be led into a wr... | 2022-08-31T05:19:04Z | fermyon__spin-727 | fermyon/spin | 0.4 | diff --git a/Cargo.lock b/Cargo.lock
index 0e0abf2562..a64c3e68bb 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3538,6 +3538,7 @@ dependencies = [
"serde",
"spin-config",
"thiserror",
+ "url",
]
[[package]]
diff --git a/crates/loader/src/bindle/mod.rs b/crates/loader/src/bindle/mod.rs
index c89f45541b..74e8a5f... | 727 | [
"720"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index a52c012063..3ffe3a2abe 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -185,15 +185,16 @@ async fn test_invalid_url_in_allowed_http_hosts_is_rejected() -> Result<()> {
let dir = temp_dir.p... | e8b6667af92152971faf96e53669531c45b55c1d |
d4678db4948a8ef8a87f0005ae7e12321085415d | Test: Feature gate the e2e tests
(Where e2e tests refer to all of the currently-named integration tests that rely on dependencies such as the `bindle-server`, `nomad` and `Hippo.Web` binaries.)
Can we feature gate the newly added tests? Something like,
```rust
#[cfg(feature = "e2e-tests")]
mod e2e {
... | Hey @vdice and @fibonacci1729. I am happy to take this one on. | 2022-08-10T22:25:15Z | fermyon__spin-681 | fermyon/spin | 0.4 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3d6ce3d90f..a0a6692d84 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -124,7 +124,7 @@ jobs:
- name: Cargo Test
run: |
make test-unit
- make test-integration
+ make te... | 681 | [
"626"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index a0031e9f18..89f8047189 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -1,7 +1,7 @@
#[cfg(test)]
mod integration_tests {
use anyhow::{Context, Result};
- use hyper::{header::HeaderName, Body, Client, Response};
+ use hyper::{Bod... | e8b6667af92152971faf96e53669531c45b55c1d |
8e8867af3994e2f0d66153f79299a41b3798ccf0 | Add a way to exclude patterns from `files` patterns
Per https://github.com/fermyon/spin-fileserver/issues/11, it is easy to accidentally include unwanted files in a `files` glob pattern. We should think of a mechanism to exclude some files from a glob, perhaps something like a `exclude_files` pattern. It might be nice ... | Poking around, it looks like this would mostly concern `spin-loader` but what other crates would be affected by making an addition to spin component configuration options?
Also, how should `exclude_files` be resolved with `files`? My gut says erring towards anything captured by `exclude_files` is excluded, even when... | 2022-07-15T16:34:18Z | fermyon__spin-645 | fermyon/spin | 0.4 | diff --git a/crates/loader/src/local/assets.rs b/crates/loader/src/local/assets.rs
index 538a1293ed..8ece1d50a1 100644
--- a/crates/loader/src/local/assets.rs
+++ b/crates/loader/src/local/assets.rs
@@ -6,7 +6,10 @@ use crate::assets::{
use anyhow::{anyhow, bail, ensure, Context, Result};
use futures::{future, stream... | 645 | [
"554"
] | diff --git a/tests/http/assets-test/spin.toml b/tests/http/assets-test/spin.toml
index 1e8c2bb9b8..4d4437f7ec 100644
--- a/tests/http/assets-test/spin.toml
+++ b/tests/http/assets-test/spin.toml
@@ -9,6 +9,7 @@ id = "fs"
# should we just use git submodules to avoid having binary test files here?
source = "spin_static... | e8b6667af92152971faf96e53669531c45b55c1d |
e06c6b13510d7fd7a57322e0e9e5f1766eab6981 | GoSDK - TinyGo V0.24.0 / Go 1.18.3 - compile error
Using the latest golang and tiny go versions (go - 1.18.3 and tinygo v0.24.0 ) and running the make file in the Go SDK folder results in:
```
# github.com/fermyon/spin/sdk/go/http
http/internals.go:67:15: cannot use newSpinHeader(k, v[0]) (value of type spinHeade... | I can confirm that I see the same issue when trying to build a Spin component with TinyGo 0.24 and Go 1.18 on `main`.
I wrote a patch for this last week. I'll open a PR tomorrow.
Yay, thanks, @adamreese! | 2022-07-11T21:45:42Z | fermyon__spin-625 | fermyon/spin | 0.3 | diff --git a/sdk/go/http/internals.go b/sdk/go/http/internals.go
index ce2930da14..39bb840101 100644
--- a/sdk/go/http/internals.go
+++ b/sdk/go/http/internals.go
@@ -17,10 +17,15 @@ import (
func handle_http_request(req *C.spin_http_request_t, res *C.spin_http_response_t) {
defer C.spin_http_request_free(req)
- s... | 625 | [
"624"
] | diff --git a/sdk/go/http/internals_test.go b/sdk/go/http/internals_test.go
deleted file mode 100644
index fe498fcc52..0000000000
--- a/sdk/go/http/internals_test.go
+++ /dev/null
@@ -1,21 +0,0 @@
-package http
-
-import "testing"
-
-func TestString(t *testing.T) {
- tt := "hello"
- if tt != newSpinString(tt).String() {... | e06c6b13510d7fd7a57322e0e9e5f1766eab6981 |
e06c6b13510d7fd7a57322e0e9e5f1766eab6981 | e2e test for spin deploy
| Hi, I would like to help with this issue and also have a draft PR https://github.com/FrankYang0529/spin/pull/1 in my repo to run integration tests on GitHub Workflow. I have two questions for the PR:
1. What is a proper way to install Hippo as a dependent on GitHub Actions? Looks like [engineerd/configurator](https://... | 2022-06-28T15:05:07Z | fermyon__spin-607 | fermyon/spin | 0.3 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9b9e0ef272..3d6ce3d90f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -28,6 +28,10 @@ jobs:
bindleUrl: "https://bindle.blob.core.windows.net/releases/bindle-v0.8.0-linux-amd64.tar.gz",
... | 607 | [
"583"
] | diff --git a/tests/README.md b/tests/README.md
new file mode 100644
index 0000000000..3d38947384
--- /dev/null
+++ b/tests/README.md
@@ -0,0 +1,9 @@
+# Integration test
+
+## Dependencies
+
+Please add following dependencies to your PATH before running `make test-integration`.
+
+* [bindle-server](https://github.com/de... | e06c6b13510d7fd7a57322e0e9e5f1766eab6981 |
fab46dea2f9fa38ca5527cf7b3821c47472c6ffd | Add tests for the Redis trigger
| 2022-06-08T00:18:12Z | fermyon__spin-543 | fermyon/spin | 0.2 | diff --git a/Makefile b/Makefile
index 87299e667f..b7dcfa062e 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ build:
.PHONY: test
test:
- RUST_LOG=$(LOG_LEVEL) cargo test --all --no-fail-fast -- --nocapture
+ RUST_LOG=$(LOG_LEVEL) cargo test --all --no-fail-fast -- --nocapture --include-ignored
cargo clippy ... | 543 | [
"179"
] | diff --git a/crates/redis/src/tests.rs b/crates/redis/src/tests.rs
index d5360cdf41..02c834af73 100644
--- a/crates/redis/src/tests.rs
+++ b/crates/redis/src/tests.rs
@@ -1,5 +1,6 @@
use super::*;
use anyhow::Result;
+use redis::{Msg, Value};
use spin_manifest::{RedisConfig, RedisExecutor};
use spin_testing::TestCo... | fab46dea2f9fa38ca5527cf7b3821c47472c6ffd | |
95f9da2a41aded597a437ad041a5a13ab19604ee | Implement Bindle module source in application manifest
The local configuration allows defining a remote reference to a bindle as the module source:
https://github.com/fermyon/spin/blob/a09fb1f2b6f9a52dee7dbcbe54e6f9ff41a72ea0/crates/loader/src/local/config.rs#L123-L131
However, that is currently not implemented:
... | 2022-05-09T04:13:50Z | fermyon__spin-456 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 7b1cee750e..7da4d209a6 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3449,6 +3449,7 @@ dependencies = [
"reqwest",
"semver",
"serde",
+ "sha2 0.10.2",
"spin-build",
"spin-config",
"spin-engine",
diff --git a/Cargo.toml b/Cargo.toml
index bfc302c744..b3494bee35 10064... | 456 | [
"454"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 1cef2e756c..7c4d03b9f3 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -11,7 +11,7 @@ async fn test_from_local_source() -> Result<()> {
let temp_dir = tempfile::tempdir()?;
let dir ... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
f267af00cd0fc0f809e403163763c059c86fbbef | Bindle server arg should be `--bindle-server`
Instead of just `--server`.
What else would be impacted by this change?
| I don't see anything immediate, other than updating the documentation and making sure the argument is consistent across commands. | 2022-05-06T19:16:17Z | fermyon__spin-452 | fermyon/spin | 0.1 | diff --git a/src/commands/up.rs b/src/commands/up.rs
index 2eb078f024..c96a5ff284 100644
--- a/src/commands/up.rs
+++ b/src/commands/up.rs
@@ -41,7 +41,7 @@ pub struct UpCommand {
/// URL of bindle server.
#[clap(
name = BINDLE_SERVER_URL_OPT,
- long = "server",
+ long = "bi... | 452 | [
"451"
] | diff --git a/tests/integration.rs b/tests/integration.rs
index 265b5c4770..fe5925f7c5 100644
--- a/tests/integration.rs
+++ b/tests/integration.rs
@@ -305,7 +305,13 @@ mod integration_tests {
) -> Result<SpinTestController> {
let url = format!("127.0.0.1:{}", get_random_port()?);
let ... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
a09fb1f2b6f9a52dee7dbcbe54e6f9ff41a72ea0 | Add option to follow the component logs when running `spin up`
When running `spin up`, you see the _Spin_ logs, and the logs of components are saved in the configured logs directory.
I would like to propose optionally following the component logs in the standard output / error of the Spin process.
| I can take a crack at this, but would like to raise what the UI might look like. A few thoughts (using `follow` as a sighting shot but that is up for grabs too).
**Option 1**
* `spin up --follow` - follows all components
It's terse, but not very selective if you have a lot of components.
**Option 2**
* ... | 2022-05-03T04:36:34Z | fermyon__spin-431 | fermyon/spin | 0.1 | diff --git a/crates/engine/src/io.rs b/crates/engine/src/io.rs
index 6884a56957..cfa1d091d3 100644
--- a/crates/engine/src/io.rs
+++ b/crates/engine/src/io.rs
@@ -1,22 +1,215 @@
-use std::sync::{Arc, RwLock};
-use wasi_common::pipe::{ReadPipe, WritePipe};
-
-/// Input/Output stream redirects
-#[derive(Clone)]
-pub stru... | 431 | [
"380"
] | diff --git a/crates/redis/src/tests.rs b/crates/redis/src/tests.rs
index be0949d31d..d5360cdf41 100644
--- a/crates/redis/src/tests.rs
+++ b/crates/redis/src/tests.rs
@@ -29,7 +29,8 @@ async fn test_pubsub() -> Result<()> {
});
let app = cfg.build_application();
- let trigger: RedisTrigger = build_tr... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
f04205bb1ff6cb21a0ed310203a4cca289d22496 | Make Application clonable
We should make `Application` clonable, such that it could be used to constrct customized `ExecutionContext`.
```rust
--> crates/manifest/src/lib.rs:23:5
|
14 | #[derive(Clone, Debug)]
| ----- in this derive macro expansion
...
23 | pub config_resolver: Option<Res... | cc @lann
I'd really like to remove `Application` from trigger initialization, but unfortunately the HTTP trigger config is currently deeply woven into the component config.
In the meantime it should be fine to wrap `config_resolver` in an `Arc`. It does currently get mutated in the `spin up` init code (which I need ... | 2022-04-21T17:44:14Z | fermyon__spin-382 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index b37c0ed6a1..52ea51f938 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3339,6 +3339,7 @@ dependencies = [
"anyhow",
"http 0.2.6",
"hyper",
+ "spin-engine",
"spin-http-engine",
"spin-manifest",
]
diff --git a/crates/engine/src/lib.rs b/crates/engine/src/lib.rs
index d80... | 382 | [
"376"
] | diff --git a/crates/redis/src/tests.rs b/crates/redis/src/tests.rs
index 41967ac399..ca45ee7909 100644
--- a/crates/redis/src/tests.rs
+++ b/crates/redis/src/tests.rs
@@ -20,15 +20,16 @@ pub(crate) fn init() {
async fn test_pubsub() -> Result<()> {
init();
- let cfg = TestConfig::default()
- .test_pro... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
a4079e321f69227632b82963cc2a5279a1cfa3ad | refactor: Host components
Currently, host-implemented interfaces have to be hard-coded in `engine` in a couple of places:
- the implementation state is included in `RuntimeContext`: https://github.com/fermyon/spin/blob/2be403465390f1a767181f16190aa4f14512c9f3/crates/engine/src/lib.rs#L49-L50
- a `link_*` method, whic... | How should configuration work for these? A solution that might fit with our current manifest:
```toml
[config]
cat_images_root = { default = "cats/" }
[host-components]
file-object-store = { root = "{{ cat_images_root }}" }
outbound-http = { allowed_hosts = [ "..." ] }
```
Longer-term, I wonder if these could... | 2022-04-21T15:25:48Z | fermyon__spin-381 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 52ea51f938..fcae0caba2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2145,6 +2145,8 @@ version = "0.1.0"
dependencies = [
"anyhow",
"redis",
+ "spin-engine",
+ "spin-manifest",
"wit-bindgen-wasmtime",
]
@@ -3096,6 +3098,7 @@ dependencies = [
"futures",
"hyper",
... | 381 | [
"311"
] | diff --git a/crates/testing/src/lib.rs b/crates/testing/src/lib.rs
index 65fa3d978c..ffd66ed28a 100644
--- a/crates/testing/src/lib.rs
+++ b/crates/testing/src/lib.rs
@@ -96,7 +96,10 @@ impl TestConfig {
}
}
- pub async fn prepare_builder<T: Default>(&self, app: Application<CoreComponent>) -> Builder... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
6d650ef75cddb93d6c46f876226b269d28ab769d | Rename `config` crate
After discussion about a better name for application config, we're going to rename the current `config` crate to `manifest` and use `config` for #307 unless we can come up with better names for those two things.
| Do we want to refer to `spin.toml` as a "Spin application manifest" in the docs?
Edit: we call it "manifest file" in one place, but mostly "application configuration". | 2022-04-06T14:01:05Z | fermyon__spin-326 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index e829c18ab3..8bc9cfe9d9 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3090,10 +3090,10 @@ dependencies = [
"path-absolutize",
"semver",
"serde",
- "spin-config",
"spin-engine",
"spin-http-engine",
"spin-loader",
+ "spin-manifest",
"spin-publish",
"spin-redis-engi... | 326 | [
"318"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 2769a9ab22..a900e64caf 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -2,7 +2,7 @@ use crate::local::config::{RawDirectoryPlacement, RawFileMount, RawModuleSource}
use super::*;
use anyhow... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
6d650ef75cddb93d6c46f876226b269d28ab769d | Rename `config` crate
After discussion about a better name for application config, we're going to rename the current `config` crate to `manifest` and use `config` for #307 unless we can come up with better names for those two things.
| Do we want to refer to `spin.toml` as a "Spin application manifest" in the docs?
Edit: we call it "manifest file" in one place, but mostly "application configuration". | 2022-04-05T20:24:31Z | fermyon__spin-319 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index e829c18ab3..8bc9cfe9d9 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3090,10 +3090,10 @@ dependencies = [
"path-absolutize",
"semver",
"serde",
- "spin-config",
"spin-engine",
"spin-http-engine",
"spin-loader",
+ "spin-manifest",
"spin-publish",
"spin-redis-engi... | 319 | [
"318"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 2769a9ab22..a900e64caf 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -2,7 +2,7 @@ use crate::local::config::{RawDirectoryPlacement, RawFileMount, RawModuleSource}
use super::*;
use anyhow... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
d235bc1c23ac15a6c737d295a146476c86e0432a | Missing request headers when using the Go SDK
Consider the following Go program:
```go
func main() {
spin.HandleRequest(func(w http.ResponseWriter, r *http.Request) {
for k, v := range r.Header {
fmt.Fprintf(w, "Header field %q, Value %q\n", k, v)
}
})
}
```
This should print all request headers ... | The commonality between the two headers set is the `HTTP_` prefix (`HTTP_ACCEPT` and `HTTP_USER_AGENT` being translated into `Accept` and `User-Agent`.
The CGI implementation from the Go standard library (https://cs.opensource.google/go/go/+/refs/tags/go1.18:src/net/http/cgi/child.go;l=83;drc=refs%2Ftags%2Fgo1.18) e... | 2022-03-29T13:12:46Z | fermyon__spin-274 | fermyon/spin | 0.1 | diff --git a/crates/http/src/lib.rs b/crates/http/src/lib.rs
index da0423258e..a48fbf2907 100644
--- a/crates/http/src/lib.rs
+++ b/crates/http/src/lib.rs
@@ -333,20 +333,24 @@ fn on_ctrl_c() -> Result<impl std::future::Future<Output = Result<(), tokio::tas
Ok(rx_future)
}
-// The default headers set across bot... | 274 | [
"270"
] | diff --git a/tests/http/assets-test/spin.toml b/tests/http/assets-test/spin.toml
index 28bb37ca70..1e8c2bb9b8 100644
--- a/tests/http/assets-test/spin.toml
+++ b/tests/http/assets-test/spin.toml
@@ -6,8 +6,9 @@ version = "1.0.0"
[[component]]
id = "fs"
+# should we just use git submodules to avoid having binary tes... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
ea0aafa346ee9f7cfcf6b680e9564105d6c2163a | Component configuration used by the internal execution context should not contain trigger configuration
As the issue title suggests, the component configuration used by the internal execution context should not contain trigger configuration — which is a _trigger_-specific piece of configuration:
https://github.com/f... | I ran into this with the object store implementation. Going to take a look.
Do we want to do something about #86 with this? | 2022-03-25T19:06:29Z | fermyon__spin-261 | fermyon/spin | 0.1 | diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
index 210fe978ef..94fa2ad848 100644
--- a/crates/config/src/lib.rs
+++ b/crates/config/src/lib.rs
@@ -16,6 +16,8 @@ pub struct Application<T> {
pub info: ApplicationInformation,
/// Configuration for the application components.
pub componen... | 261 | [
"229"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index aa320a8d30..2769a9ab22 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -11,28 +11,35 @@ async fn test_from_local_source() -> Result<()> {
let temp_dir = tempfile::tempdir()?;
let di... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
f830e5462ab3d89717e660e425d6ae8f32ee4341 | Use `.cargo/config.toml` `target = "wasm32-wasi"` in test crates
Some quick testing suggests that a [`rust-toolchain.toml`](https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file) file like this:
```toml
[toolchain]
targets = [ "wasm32-wasi" ]
```
will make `cargo` default to `--target wasm32-was... | In the examples / templates (specifically for `rust`) there is a `.cargo/config.toml` that contains
```toml
[build]
target = "wasm32-wasi"
```
To enable `cargo build --release`
Oh cool. Why aren't we doing that everywhere?
Ha, thats exactly where I was testing the rust-toolchain.toml file, so it might not have... | 2022-03-25T12:48:24Z | fermyon__spin-255 | fermyon/spin | 0.1 | diff --git a/crates/http/benches/spin-http-benchmark/.cargo/config.toml b/crates/http/benches/spin-http-benchmark/.cargo/config.toml
new file mode 100644
index 0000000000..6b77899cb3
--- /dev/null
+++ b/crates/http/benches/spin-http-benchmark/.cargo/config.toml
@@ -0,0 +1,2 @@
+[build]
+target = "wasm32-wasi"
diff --gi... | 255 | [
"234"
] | diff --git a/crates/http/tests/rust-http-test/.cargo/config.toml b/crates/http/tests/rust-http-test/.cargo/config.toml
new file mode 100644
index 0000000000..6b77899cb3
--- /dev/null
+++ b/crates/http/tests/rust-http-test/.cargo/config.toml
@@ -0,0 +1,2 @@
+[build]
+target = "wasm32-wasi"
diff --git a/crates/http/tests... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
67b222b136ab936ae5a9ec00e99432191fe0c896 | Add a `spin-testing` crate with common testing utilities
We have a lot of code duplication in some of our tests around e.g. setting up `ApplicationInformation`. I'd like a e.g. `crates/testing` :bike::derelict_house: crate that would be used in `[dev-dependencies]` with helpers like `build_test_application_information`... | 2022-03-24T20:58:17Z | fermyon__spin-245 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 7b9f30931a..ad800b4df5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3143,6 +3143,7 @@ dependencies = [
"serde",
"spin-config",
"spin-engine",
+ "spin-testing",
"tls-listener",
"tokio",
"tokio-rustls 0.23.3",
@@ -3235,6 +3236,7 @@ dependencies = [
"serde",
"spin... | 245 | [
"233"
] | diff --git a/crates/redis/src/tests.rs b/crates/redis/src/tests.rs
index 1cd5fd37ad..008699283f 100644
--- a/crates/redis/src/tests.rs
+++ b/crates/redis/src/tests.rs
@@ -1,15 +1,11 @@
use super::*;
use anyhow::Result;
-use spin_config::{
- ApplicationInformation, Configuration, CoreComponent, ModuleSource, RedisC... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
3a4b61a2c29cf351a42525f4296f207bcbfa086f | Error in static assets logic on Windows
When building `spin` on Windows, I'm running into an error regarding the path of static assets files:
```
PS C:\Users\jdboh\OneDrive\Documents\Fermyon\spin\docs> spin up --file spin.toml
Error: Failed to prepare configuration
Caused by:
0: Failed to collect file moun... | cc @itowlson
Can you share the `spin.toml` file please?
I think James was testing with the docs website in `docs/spin.toml`.
> I think James was testing with the docs website in `docs/spin.toml`.
This is correct
Mystic Ivan predicts all
```
// TODO: check if this works if the host is Windows
``` | 2022-03-22T21:47:04Z | fermyon__spin-211 | fermyon/spin | 0.1 | diff --git a/crates/loader/src/local/assets.rs b/crates/loader/src/local/assets.rs
index 0294e888af..2b222de8ef 100644
--- a/crates/loader/src/local/assets.rs
+++ b/crates/loader/src/local/assets.rs
@@ -112,10 +112,9 @@ fn collect_placement(
source.display()
);
}
- // TODO: check if this w... | 211 | [
"204"
] | diff --git a/tests/http/simple-spin-rust/assets/test.txt b/tests/http/simple-spin-rust/assets/test.txt
new file mode 100644
index 0000000000..56ff8c93da
--- /dev/null
+++ b/tests/http/simple-spin-rust/assets/test.txt
@@ -0,0 +1,1 @@
+text for test
\ No newline at end of file
diff --git a/tests/http/simple-spin-rust/spi... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
6ec44284e6e933b536a7461740844d428f3d69cf | Camel case vs. snake case for TOML configuration
The current `spin.toml` file format expects multi-word identifiers to be camel case, which, as far as I can tell, is not that common for TOML files.
Should we update all identifiers in TOML configuration files to be snake case instead?
| While I really don't have much of an opinion, what tilted me in favor of snake_case in Bindle was the TOML spec, which uses snake_case. https://toml.io/en/v1.0.0#array
I figure that as long as we're consistent, though, it probably doesn't matter much.
+1 for snake
If we're going to change it we should do so soon be... | 2022-03-10T12:08:41Z | fermyon__spin-157 | fermyon/spin | 0.1 | diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
index 1d58db56de..486e2b95ad 100644
--- a/crates/config/src/lib.rs
+++ b/crates/config/src/lib.rs
@@ -18,11 +18,18 @@ pub struct Configuration<T> {
pub components: Vec<T>,
}
+/// Spin API version.
+#[derive(Copy, Clone, Debug, Eq, PartialEq)]
+pub... | 157 | [
"132"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 2d3c1d3bc8..200d897b25 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -15,7 +15,7 @@ async fn test_from_local_source() -> Result<()> {
assert_eq!(cfg.info.name, "spin-local-source-test"... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
56203d9d83f833ee9472c552be6b9610554a20a0 | Implement Redis trigger
There is a very early skeleton for a Redis trigger (https://github.com/fermyon/spin/tree/main/crates/redis) that we should update to be usable using the new application configuration.
| 2022-03-10T00:01:58Z | fermyon__spin-155 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 9133e8c851..68cf59f7c7 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -23,7 +23,7 @@ version = "0.7.6"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "fcb51a0695d8f838b1ee009b3fbf66bda078cd64590202a864a8f3e8c4315c47"
dependencies = [
- "getrandom 0... | 155 | [
"59"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 200d897b25..aa320a8d30 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -2,7 +2,7 @@ use crate::local::config::{RawDirectoryPlacement, RawFileMount, RawModuleSource}
use super::*;
use anyhow... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
e80696c95ac711fe6635fe0f59e7798d5a479670 | Leaking temporary asset directories
In my testing, it appears temporary directories used for copying static assets are not deleted after stopping Spin.
Repro: run an application with file mounts multiple times, then check the temporary directories.
| 2022-03-09T02:53:38Z | fermyon__spin-149 | fermyon/spin | 0.1 | diff --git a/crates/loader/src/bindle/mod.rs b/crates/loader/src/bindle/mod.rs
index 7fbc50dd27..3252456c95 100644
--- a/crates/loader/src/bindle/mod.rs
+++ b/crates/loader/src/bindle/mod.rs
@@ -23,7 +23,7 @@ use spin_config::{
ApplicationInformation, ApplicationOrigin, Configuration, CoreComponent, ModuleSource,
... | 149 | [
"146"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 710600f482..2d3c1d3bc8 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -9,7 +9,8 @@ use std::path::PathBuf;
async fn test_from_local_source() -> Result<()> {
const MANIFEST: &str = "tests... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
d393dd47617b57affeb92b842e5ce670c1f762a4 | Volume mounting
Mapping volume mounts would allow for flexible directories within a spin project. I have a module that expects files mounted as standard linux directories. In wagi you can map a volume in modules.toml as `volumes = { "/usr" = "ruby-wasm32-wasi/usr" }` which is much cleaner than having a `usr` director... | This is biting me, too. Treating volumes as maps is much better, because it is often not possible to make the outside directory structure exactly match the internal directory structure. In multi-module/component repos, I need to map the same external path to different internal paths (otherwise I have to copy the same d... | 2022-03-01T23:09:22Z | fermyon__spin-118 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 066f728539..ebc91e0e08 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2987,6 +2987,7 @@ dependencies = [
"tracing",
"tracing-futures",
"tracing-subscriber 0.3.8",
+ "walkdir",
]
[[package]]
diff --git a/crates/loader/Cargo.toml b/crates/loader/Cargo.toml
index 6488640f... | 118 | [
"106"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 00830456c7..649b0ac274 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -1,4 +1,4 @@
-use crate::local::config::RawModuleSource;
+use crate::local::config::{RawDirectoryPlacement, RawFileMount, ... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
6651c2ca8d4592a41e1816e70f3af1cb47aee7d5 | Add TLS support for the HTTP trigger
The new HTTP trigger should have support for TLS — https://github.com/fermyon/spin/blob/751cda3ee182675b00f05bfd3f18c05086978bf2/crates/http/src/lib.rs#L33
| 2022-02-28T18:54:55Z | fermyon__spin-114 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 0e3d6952c3..066f728539 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1298,7 +1298,9 @@ checksum = "d87c48c02e0dc5e3b849a2041db3029fd066650f8f717c07bf8ed78ccb895cac"
dependencies = [
"http 0.2.6",
"hyper",
+ "log",
"rustls 0.20.3",
+ "rustls-native-certs",
"tokio",
"t... | 114 | [
"33"
] | diff --git a/crates/http/tests/local.crt.pem b/crates/http/tests/local.crt.pem
new file mode 100644
index 0000000000..efd51f6707
--- /dev/null
+++ b/crates/http/tests/local.crt.pem
@@ -0,0 +1,17 @@
+-----BEGIN CERTIFICATE-----
+MIICujCCAaICCQClexHj2O4K/TANBgkqhkiG9w0BAQsFADAfMQswCQYDVQQGEwJV
+UzEQMA4GA1UECgwHRmVybXlvbj... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
2782bb320dbb4a671691acab2d4c20f8191c1806 | Verify apiVersion
I didn't know what `apiVersion` was meant to be, so in my test app I used `1.0.0`. Looking at the template, that uses `0.1.0`, so my guess was wrong - but still seems to work.
If the `apiVersion` isn't recognised, we must reject the manifest. Otherwise mistakes like mine will proliferate and we'l... | 2022-02-22T23:29:38Z | fermyon__spin-97 | fermyon/spin | 0.1 | diff --git a/crates/loader/src/local/config.rs b/crates/loader/src/local/config.rs
index 9f3d863308..90941e8373 100644
--- a/crates/loader/src/local/config.rs
+++ b/crates/loader/src/local/config.rs
@@ -8,6 +8,15 @@ use serde::{Deserialize, Serialize};
use spin_config::{ApplicationTrigger, TriggerConfig};
use std::{c... | 97 | [
"91"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index b16f321a28..00830456c7 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -40,7 +40,8 @@ async fn test_from_local_source() -> Result<()> {
fn test_manifest() -> Result<()> {
const MANIFEST: ... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
fa95701bc2384259fc9677d5c96e2cddd9eb0556 | Custom entrypoints for Wagi components
#54 adds support for Wagi components.
However, the only supported entrypoint is `_start` — https://github.com/fermyon/spin/pull/54#discussion_r804378999
There should be a way in the component configuration to specify the custom Wagi entrypoint.
| Do you see that change in configuration as something like:
```
[component.trigger]
...
entrypoint = "_start"
```
Yes, but keep in mind this is a config that only makes sense for Wagi components.
Perfect. That was my next question.
What is a "WAGI component" in this context? Is the idea to allow the mounting o... | 2022-02-18T16:40:08Z | fermyon__spin-88 | fermyon/spin | 0.1 | diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
index b396f02e20..77aa5e926a 100644
--- a/crates/config/src/lib.rs
+++ b/crates/config/src/lib.rs
@@ -137,12 +137,12 @@ impl Default for HttpConfig {
/// The type of interface the component implements.
#[derive(Clone, Debug, PartialEq, Deserialize, Se... | 88 | [
"69"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
new file mode 100644
index 0000000000..ab7254adf1
--- /dev/null
+++ b/crates/loader/src/local/tests.rs
@@ -0,0 +1,103 @@
+use crate::local::config::RawModuleSource;
+
+use super::*;
+use anyhow::Result;
+use spin_config::{ApplicationTrigge... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
1b33dc526ca077fe8dcab7b011be6a359d523656 | Normalize the paths between the configuration file and module source
`spin up --app spin.toml` must currently be run from the same directory as `spin.toml`, because a relative path for the component `source` is not handled properly:
https://github.com/fermyon/spin/blob/751cda3ee182675b00f05bfd3f18c05086978bf2/src/co... | Should we make it so that the path must be relative to the directory that the Spin.toml file lives? What happens if the user wants to specify absolutely path?
Right now I'm thinking.. if component source is a path, check if it is relative or not. Relative paths are relative to the directory where the Spin.toml file... | 2022-02-16T22:27:27Z | fermyon__spin-87 | fermyon/spin | 0.1 | diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
index 31c510b188..ce57601214 100644
--- a/crates/config/src/lib.rs
+++ b/crates/config/src/lib.rs
@@ -21,8 +21,12 @@ pub use bindle_utils::BindleReader;
/// Reads the application configuration from the specified file.
pub fn read_from_file(app_file: imp... | 87 | [
"35"
] | diff --git a/crates/engine/src/tests.rs b/crates/engine/src/tests.rs
new file mode 100644
index 0000000000..feecdc0630
--- /dev/null
+++ b/crates/engine/src/tests.rs
@@ -0,0 +1,55 @@
+use super::*;
+use anyhow::Result;
+use spin_config::Configuration;
+use std::io::Write;
+
+const CFG_TEST: &str = r#"
+name = "s... | 95f9da2a41aded597a437ad041a5a13ab19604ee |
ae95bc05814267c5559fbed3d5263b3dcb54fd55 | Handle route patterns for the HTTP trigger
A component will only be executed if the request's URI path matches the route defined in the trigger configuration exactly:
https://github.com/fermyon/spin/blob/751cda3ee182675b00f05bfd3f18c05086978bf2/crates/http/src/lib.rs#L80-L87
This needs to handle route patterns l... | 2022-02-09T04:38:05Z | fermyon__spin-57 | fermyon/spin | 0.1 | diff --git a/Cargo.lock b/Cargo.lock
index 61de1bd702..39a294ce01 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -807,9 +807,9 @@ dependencies = [
[[package]]
name = "hashbrown"
-version = "0.9.1"
+version = "0.11.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d7afe4a420e3fe79967a008... | 57 | [
"36"
] | diff --git a/crates/http/tests/rust-http-test/src/lib.rs b/crates/http/tests/rust-http-test/src/lib.rs
index 02de4a9d30..5b46a74a37 100644
--- a/crates/http/tests/rust-http-test/src/lib.rs
+++ b/crates/http/tests/rust-http-test/src/lib.rs
@@ -6,6 +6,15 @@ struct SpinHttp {}
impl spin_http::SpinHttp for SpinHttp {
... | 95f9da2a41aded597a437ad041a5a13ab19604ee | |
561b3e132b99537d823b33984e371bb8326ad3e6 | Using the llm 2.0 crate with Rust SDK fails with `import `fermyon:spin/llm@2.0.0` has the wrong type`
Using the Rust SDK from version `spin 2.0.0-pre0 (561b3e1 2023-10-30)` with a following reference to the SDK `spin-sdk = { git = "https://github.com/fermyon/spin", branch = "main" }`, fails with the following error, wh... | 2023-10-31T12:01:57Z | fermyon__spin-1997 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 44ef3f4b38..605a9cad82 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1830,7 +1830,6 @@ dependencies = [
"anyhow",
"async-trait",
"derive_builder 0.12.0",
- "hyper 0.14.25",
"hyper-tls",
"nix 0.26.2",
"regex",
diff --git a/crates/llm-local/src/lib.rs b/crates/llm-loc... | 1,997 | [
"1995"
] | diff --git a/crates/e2e-testing/Cargo.toml b/crates/e2e-testing/Cargo.toml
index 7fbd464ec6..de23d7f786 100644
--- a/crates/e2e-testing/Cargo.toml
+++ b/crates/e2e-testing/Cargo.toml
@@ -10,12 +10,11 @@ doctest = false
[dependencies]
anyhow = "1.0"
async-trait = "0.1"
-tokio = { version = "1.23", features = [ "full"... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
12becdcc33b6e59bb3aea3dd511f24616a239852 | Consider deprecation of old style `outbound-http` and `inbound-http` in the Spin guest world
With `wasi-http` affording the ability to do inbound and outbound http, there is little reason to have an the old style `outbound-http` and `inbound-http` interfaces. We should consider getting rid of them - potentially in Spin... | What would "deprecation" look like here?
With Spin 2.0 we could conceivably just remove them from the Spin 2.0 world. This would mean the SDK would no longer expose them. Legacy apps would still run fine, but anything new would go through using `wasi-http` instead.
If we get rid of the imports that would imply that sup... | 2023-10-17T14:45:13Z | fermyon__spin-1901 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 4d1863cb16..66598d7526 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1225,7 +1225,7 @@ dependencies = [
[[package]]
name = "cranelift-bforest"
version = "0.101.0"
-source = "git+https://github.com/bytecodealliance/wasmtime?rev=c796ce7376a57a40605f03e74bd78cefcc9acf3a#c796ce7... | 1,901 | [
"1871"
] | diff --git a/crates/core/tests/integration_test.rs b/crates/core/tests/integration_test.rs
index abc32f8d35..a5a0994880 100644
--- a/crates/core/tests/integration_test.rs
+++ b/crates/core/tests/integration_test.rs
@@ -178,6 +178,9 @@ fn test_config() -> Config {
fn test_engine() -> Engine<()> {
let mut builder =... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
503917f58269d500d0efe201a8ecb7df6427ddc3 | Improve Rust SDK HTTP handler macro with an `IntoResponse` trait
Right now the http handler in the Rust SDK assumes that the annotated function will return `Result<T, E> where T: TryInto<spin_http::Response>` and where `E` has the same API as `std::error::Error` (which one should note `anyhow::Error` does not implement... | This is a great idea. I definitely think this API change is worth it because it significantly improves the ergonomics of the Rust SDK, however, i'm not quite sure either how to support this in a backwards compatible way. It might be worth exploring the third bullet of a second macro; if we do that i'd like us to explor... | 2023-10-12T14:08:48Z | fermyon__spin-1887 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 90eabbae4f..defa627a52 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -390,9 +390,9 @@ checksum = "b9441c6b2fe128a7c2bf680a44c34d0df31ce09e5b7e401fcca3faa483dbc921"
[[package]]
name = "async-trait"
-version = "0.1.73"
+version = "0.1.74"
source = "registry+https://github.com... | 1,887 | [
"1372"
] | diff --git a/tests/http/headers-env-routes-test/Cargo.lock b/tests/http/headers-env-routes-test/Cargo.lock
index 40d01ab1bc..709cb10ba8 100644
--- a/tests/http/headers-env-routes-test/Cargo.lock
+++ b/tests/http/headers-env-routes-test/Cargo.lock
@@ -8,6 +8,17 @@ version = "1.0.75"
source = "registry+https://github.co... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
2a0205608ff47e9fd42c5056abc79715c9138032 | `spin new`: provide application name without providing template
When creating a Spin application, I usually know the name I want to give the application, but I often cannot remember the template name I'd like to use (is it `http-rust`, `rust-http`, or something else?). I really wish I could `spin new $SOME_NAME` and th... | Yeah we should maybe have done this the other way round...
The only things I can think of are:
1. Allow the name as a named parameter as well as a positional one (clap permitting). So your command would become `spin new --name myapp`.
2. Have a magic syntax for "prompt me for the template ID" e.g. `spin new * m... | 2023-10-10T21:38:13Z | fermyon__spin-1872 | fermyon/spin | 3.2 | diff --git a/crates/templates/src/interaction.rs b/crates/templates/src/interaction.rs
index 5a02c31278..a8d36abaec 100644
--- a/crates/templates/src/interaction.rs
+++ b/crates/templates/src/interaction.rs
@@ -42,7 +42,7 @@ impl InteractionStrategy for Interactive {
fn allow_generate_into(&self, target_dir: &Path... | 1,872 | [
"1525"
] | diff --git a/crates/e2e-testing/src/spin.rs b/crates/e2e-testing/src/spin.rs
index 4772f65673..e735b16b97 100644
--- a/crates/e2e-testing/src/spin.rs
+++ b/crates/e2e-testing/src/spin.rs
@@ -30,7 +30,14 @@ pub fn new_app<'a>(
mut args: Vec<&'a str>,
) -> Result<Output> {
let basedir = utils::testcases_base_d... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
78e0f7f09f2eb8d89786a739e399456ba7a252fb | templates: redirect support for 'spin new'
The [redirect template](https://github.com/fermyon/spin/tree/main/templates/redirect) doesn't currently support use with `spin new`:
```
$ spin new redirect redirect
Template redirect doesn't support the 'new application' operation
```
There've been cases of [pure red... | I think my thinking was that if you didn't have any components yet then there was nothing to redirect _to_. You're right that there could be redirects to external URLs though; and although it's unlikely that anyone is going to start a Spin app from scratch _just_ to do redirects, there's probably no reason to actually... | 2023-10-09T03:40:00Z | fermyon__spin-1865 | fermyon/spin | 3.2 | diff --git a/crates/templates/src/manager.rs b/crates/templates/src/manager.rs
index 677ca7e7cd..82c0479753 100644
--- a/crates/templates/src/manager.rs
+++ b/crates/templates/src/manager.rs
@@ -1033,10 +1033,15 @@ mod tests {
let temp_dir = tempdir().unwrap();
let store = TemplateStore::new(temp_dir.... | 1,865 | [
"1860"
] | diff --git a/crates/templates/tests/templates/add-only-redirect/metadata/snippets/component.txt b/crates/templates/tests/templates/add-only-redirect/metadata/snippets/component.txt
new file mode 100644
index 0000000000..5ae6628514
--- /dev/null
+++ b/crates/templates/tests/templates/add-only-redirect/metadata/snippets/... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
268883366d57712de1a9cc33135238b46013fe86 | templates: Remove wit-bindgen-backport dependency
This is the last vestage of "old" wit-bindgen in spin; app usage of the old ABI is now handled by the spin-componentize adaptation.
After some discussion, I think one of the following should be done:
- Remove the custom filters feature; the only known usage of it ... | I think we've settled on the breaking change of removing the functionality for 2.0. | 2023-09-28T01:54:29Z | fermyon__spin-1822 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 162179a8fb..cb017d81f7 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -6166,9 +6166,6 @@ dependencies = [
"toml 0.5.11",
"url",
"walkdir",
- "wasmtime",
- "wasmtime-wasi",
- "wit-bindgen-wasmtime",
]
[[package]]
@@ -8161,34 +8158,6 @@ dependencies = [
"wit-parser 0.8.... | 1,822 | [
"1581"
] | diff --git a/crates/templates/tests/filters/clappy/Cargo.toml b/crates/templates/tests/filters/clappy/Cargo.toml
deleted file mode 100644
index a30d5ce910..0000000000
--- a/crates/templates/tests/filters/clappy/Cargo.toml
+++ /dev/null
@@ -1,12 +0,0 @@
-[package]
-name = "clappy"
-version = "0.1.0"
-edition = "2021"
-
... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
35dcc921cee8a48d727e9036490da3e63d8dfcab | Timer trigger sample fails to resolve import
As part of ongoing component and Wasmtime infrastructure improvements, the `examples/spin-timer` trigger sample was updated in #1615 to refer to the Spin `config` API in a new way. Unfortunately, although both the trigger and example guest build okay, the example guest fail... | 2023-08-30T19:03:51Z | fermyon__spin-1719 | fermyon/spin | 1.4 | diff --git a/.github/actions/spin-ci-dependencies/action.yml b/.github/actions/spin-ci-dependencies/action.yml
index 8552ec3ed8..0be6c8ecf2 100644
--- a/.github/actions/spin-ci-dependencies/action.yml
+++ b/.github/actions/spin-ci-dependencies/action.yml
@@ -93,12 +93,11 @@ runs:
using: "composite"
steps:
- ... | 1,719 | [
"1662"
] | diff --git a/crates/e2e-testing/src/testcase.rs b/crates/e2e-testing/src/testcase.rs
index 8d940f0c61..383cde239f 100644
--- a/crates/e2e-testing/src/testcase.rs
+++ b/crates/e2e-testing/src/testcase.rs
@@ -153,7 +153,9 @@ impl TestCase {
}
// run spin build
- let build_output = controller.bu... | 35dcc921cee8a48d727e9036490da3e63d8dfcab | |
7f84a95bc842d8a23410c2b381594d7218f76f8f | outbound-http: Support "relative" URIs to current app
This has been requested a couple of times and should be _relatively_ straightforward:
- Add a field to `OutboundHttp` e.g. `origin: Uri` which gets updated from each inbound request
- If an outbound request starts with a `/` (has no scheme or authority), join wi... | If the application has a `base`, should "relative" URLs be relativised to that base, or to the host? (The reference to "current app" makes me assume this is relative to the app base but I want to check!)
First, I'd like to get rid of `base` :sweat_smile:.
I'm not sure which would be less confusing. Magically prepen... | 2023-08-26T04:15:06Z | fermyon__spin-1710 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 4ac146655d..a6584ae786 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5311,6 +5311,7 @@ dependencies = [
"hyper",
"indexmap",
"num_cpus",
+ "outbound-http",
"percent-encoding",
"rustls-pemfile 0.3.0",
"serde",
diff --git a/crates/outbound-http/src/allowed_http_hosts.... | 1,710 | [
"1533"
] | diff --git a/tests/spinup_tests.rs b/tests/spinup_tests.rs
index 0cfa3121ea..5de715d3d0 100644
--- a/tests/spinup_tests.rs
+++ b/tests/spinup_tests.rs
@@ -7,6 +7,11 @@ mod spinup_tests {
use {e2e_testing::controller::Controller, e2e_testing::spin_controller::SpinUp};
const CONTROLLER: &dyn Controller = &SpinU... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
ced6f0e9a04631de351e0d137873be301d7e08bb | `spin add static-fileserver` creates folder based on component name (still have to create `assets` dir manually)
Version:
`spin 1.4.0 (7aab1fe 2023-07-11)`
Issue:
When adding a `static-fileserver` component to an application, Spin creates a new directory based on the component name which the user provides. For ex... | I was going to claim that this would require some changes because the template system _always_ created the new directory... but the `redirect` template doesn't. Time to do some figuring! | 2023-07-19T03:25:57Z | fermyon__spin-1670 | fermyon/spin | 3.2 | diff --git a/crates/templates/src/lib.rs b/crates/templates/src/lib.rs
index 1aa344acd0..e4b18216d9 100644
--- a/crates/templates/src/lib.rs
+++ b/crates/templates/src/lib.rs
@@ -24,3 +24,6 @@ pub use manager::*;
pub use run::{Run, RunOptions};
pub use source::TemplateSource;
pub use template::{Template, TemplateVar... | 1,670 | [
"1669"
] | diff --git a/crates/templates/src/test_built_ins/mod.rs b/crates/templates/src/test_built_ins/mod.rs
new file mode 100644
index 0000000000..8df9710678
--- /dev/null
+++ b/crates/templates/src/test_built_ins/mod.rs
@@ -0,0 +1,73 @@
+#![cfg(test)]
+
+// Module for unit-testing the built-in templates when a full e2e test ... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
ced6f0e9a04631de351e0d137873be301d7e08bb | `spin plugin install` fails if latest plugin version doesn't support current Spin version
on trying to install the plugins with spin 1.3, we get following error:
```
$) spin --version
spin 1.3.0 (9fb8256 2023-06-12)
$) spin plugin install js2wasm --yes
Error: Plugin is not compatible with this version of Spi... | one more thing I noticed is that you can't install the latest version by using a `--version` flag:
```
$) spin plugin install js2wasm -v 0.5.0
Error: plugin 'js2wasm' not found at expected location /Users/rajatjindal/Library/Application Support/spin/plugins/.spin-plugins/manifests/js2wasm/js2wasm@0.5.0.json: No su... | 2023-07-18T03:42:05Z | fermyon__spin-1668 | fermyon/spin | 3.2 | diff --git a/crates/plugins/Cargo.toml b/crates/plugins/Cargo.toml
index 5ce5c631d6..0816ef3d64 100644
--- a/crates/plugins/Cargo.toml
+++ b/crates/plugins/Cargo.toml
@@ -7,14 +7,14 @@ edition = { workspace = true }
[dependencies]
anyhow = "1.0"
bytes = "1.1"
-chrono = "0.4"
+chrono = { version = "0.4", features = [... | 1,668 | [
"1661"
] | diff --git a/crates/plugins/tests/.spin-plugins/_spin_test_dot_git b/crates/plugins/tests/.spin-plugins/_spin_test_dot_git
new file mode 100644
index 0000000000..a60a97e033
--- /dev/null
+++ b/crates/plugins/tests/.spin-plugins/_spin_test_dot_git
@@ -0,0 +1,1 @@
+Fake file for preventing the plugin system from pulling ... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
75b3474dfa96d5ba93f931f2625e2829f57422ac | Unhide planned Spin 1.4 features
* CLI: Unhide `spin up --sqlite` flag
* Rust SDK: Move `sqlite` out of `experimental` feature
* CLI: Unhide `spin doctor` command
| 2023-06-26T22:13:01Z | fermyon__spin-1617 | fermyon/spin | 3.2 | diff --git a/crates/trigger/src/cli.rs b/crates/trigger/src/cli.rs
index 5e23eb04c9..31bb76c0c7 100644
--- a/crates/trigger/src/cli.rs
+++ b/crates/trigger/src/cli.rs
@@ -107,8 +107,9 @@ where
#[clap(long = "key-value", parse(try_from_str = parse_kv))]
key_values: Vec<(String, String)>,
- /// Run a sqlit... | 1,617 | [
"1616"
] | diff --git a/tests/testcases/sqlite-undefined-db/Cargo.toml b/tests/testcases/sqlite-undefined-db/Cargo.toml
index b1373a5f16..fd3944394a 100644
--- a/tests/testcases/sqlite-undefined-db/Cargo.toml
+++ b/tests/testcases/sqlite-undefined-db/Cargo.toml
@@ -16,7 +16,7 @@ http = "0.2"
itertools = "0.10"
serde = { version... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
9aa23cf51d3e625392182f18ec48ffec10543884 | Run local integration tests with clean or predictable starting state
Per #1448, I got a failure in `make-kv` which neither @rajatjindal nor @lann could reproduce. It turned out this was because I had previously tried to adapt the test to include the new `spin up --key-value` option; apparently that worked, because it... | 2023-05-08T06:58:24Z | fermyon__spin-1461 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index 4642285a74..97077bdf31 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1438,6 +1438,7 @@ dependencies = [
"nix 0.26.2",
"regex",
"reqwest",
+ "tempfile",
"tokio",
"url",
]
| 1,461 | [
"1458"
] | diff --git a/crates/e2e-testing/Cargo.toml b/crates/e2e-testing/Cargo.toml
index 03294f4bd9..7fbd464ec6 100644
--- a/crates/e2e-testing/Cargo.toml
+++ b/crates/e2e-testing/Cargo.toml
@@ -17,4 +17,5 @@ reqwest = { version = "0.11", features = ["blocking"] }
nix = "0.26.1"
url = "2.2.2"
derive_builder = "0.12.0"
-hype... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
033c3d1d6de26bfa3441aa38e5b44d077457321d | Add support for `spin up --key-value KEY,VALUE`
It would be nice to have parity between `spin up` and `spin cloud deploy` for the pre-seed key value feature. Today only `spin cloud deploy --key-value KEY,VALUE` works. This issue will track the work to add support for `spin up --key-value KEY,VALUE`. That way, Spin & F... | nit so we don't accidentally end up with different syntaxes: the `deploy` syntax is `KEY=VALUE`, i.e. equals sign not a comma.
The existing `cloud deploy` syntax allows setting K/V pairs only in the app's default store (because cloud only has the default store).
1. For the local case, is it necessary to set pairs in... | 2023-05-02T00:57:31Z | fermyon__spin-1442 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index de376a04cc..dcc8f03c1e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4976,6 +4976,7 @@ dependencies = [
"spin-app",
"spin-bindle",
"spin-build",
+ "spin-common",
"spin-config",
"spin-key-value",
"spin-key-value-sqlite",
@@ -5005,6 +5006,7 @@ dependencies = [
name =... | 1,442 | [
"1404"
] | diff --git a/crates/testing/src/lib.rs b/crates/testing/src/lib.rs
index 3f2aef347b..3c9df07c7d 100644
--- a/crates/testing/src/lib.rs
+++ b/crates/testing/src/lib.rs
@@ -17,7 +17,7 @@ use spin_app::{
AppComponent, Loader,
};
use spin_core::{Component, StoreBuilder};
-use spin_trigger::{RuntimeConfig, TriggerExe... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
40d50862f1d917bf1907081e1f925e84e29d2215 | Misleading `spin plugin install` error
When the URL to the tarball in a plugin manifest is wrong, the error returned is the following
```
$ spin plugin install -u https://github.com/karthik2804/spin-js-sdk/releases/download/canary/js2wasm.json
Are you sure you want to install plugin 'js2wasm' with license Apache-... | 2023-04-30T22:42:12Z | fermyon__spin-1441 | fermyon/spin | 3.2 | diff --git a/crates/plugins/src/manager.rs b/crates/plugins/src/manager.rs
index 10f82660e1..f886e64441 100644
--- a/crates/plugins/src/manager.rs
+++ b/crates/plugins/src/manager.rs
@@ -219,6 +219,13 @@ pub fn get_package(plugin_manifest: &PluginManifest) -> Result<&PluginPackage> {
async fn download_plugin(name: &st... | 1,441 | [
"1436"
] | diff --git a/crates/plugins/tests/nonexistent-url/nonexistent-url.json b/crates/plugins/tests/nonexistent-url/nonexistent-url.json
new file mode 100644
index 0000000000..9733792ec3
--- /dev/null
+++ b/crates/plugins/tests/nonexistent-url/nonexistent-url.json
@@ -0,0 +1,14 @@
+{
+ "name": "nonexistent-url",
+ "ver... | c02196882a336d46c3dd5fcfafeed45ef0a4490e | |
40d50862f1d917bf1907081e1f925e84e29d2215 | "No built-in trigger named 'http'" if `trigger.base` is missing
If `base` is missing:
```console
$ spin up
Error: No built-in trigger named 'http', and no plugin named 'trigger-http' was found
```
| @itowlson Is this a regression from the original external trigger impl?
@lann Could be - I will have a look. | 2023-04-30T21:40:56Z | fermyon__spin-1440 | fermyon/spin | 3.2 | diff --git a/crates/manifest/src/lib.rs b/crates/manifest/src/lib.rs
index 9d7a580c42..a099051e71 100644
--- a/crates/manifest/src/lib.rs
+++ b/crates/manifest/src/lib.rs
@@ -20,6 +20,9 @@ pub enum Error {
/// No 'type' key in trigger declaration.
#[error("the application did not specify a trigger type")]
... | 1,440 | [
"1434"
] | diff --git a/crates/loader/src/local/tests.rs b/crates/loader/src/local/tests.rs
index 2f3446d267..c79f16e829 100644
--- a/crates/loader/src/local/tests.rs
+++ b/crates/loader/src/local/tests.rs
@@ -201,6 +201,21 @@ fn test_unknown_version_is_rejected() {
);
}
+#[tokio::test]
+async fn gives_correct_error_when_... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
40d50862f1d917bf1907081e1f925e84e29d2215 | Embedding spin v1.1.0 does not built
## TL;DR
spin `v1.1.0` depends on wasmtime `v7.0.0`, but also depends on `spin-componentize` which depends on wasmtime `v8.0.1`. This makes using spin v1.1.0 as a library unable to built correctly.
## How to repro
Create an empty rust project and add `spin-app = { git = "... | I guess to resolve this issue in the future is to pin `spin-componentize` to a specific rev in spin's `Cargo.toml` | 2023-04-29T16:50:15Z | fermyon__spin-1439 | fermyon/spin | 3.2 | diff --git a/Cargo.lock b/Cargo.lock
index a47fe64565..2b0b26fed4 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -845,18 +845,18 @@ dependencies = [
[[package]]
name = "cranelift-bforest"
-version = "0.94.1"
+version = "0.95.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0853f4732d95... | 1,439 | [
"1437"
] | diff --git a/crates/core/tests/core-wasi-test/Cargo.toml b/crates/core/tests/core-wasi-test/Cargo.toml
index d388b0233a..9de6561859 100644
--- a/crates/core/tests/core-wasi-test/Cargo.toml
+++ b/crates/core/tests/core-wasi-test/Cargo.toml
@@ -7,6 +7,6 @@ edition = "2021"
debug = true
[dependencies]
-wit-bindgen = "... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
0b683a9bf9750723aa7a65a390d76fc1f7a6ae05 | Dev Loop Test Failure
When running `make test` spin is not present in dev container/system path which results in the following error:
---
running 1 test
**"/bin/bash: line 1: spin: command not found\n"**
""
thread 'spinup_tests::key_value_works' panicked at 'command `cd "/workspaces/spin/crates/e2e-testing/../..... | Hi @suneetnangia
thank you for reporting this issue. Could you please confirm if you have Spin in `target/{release,debug}` directory? I think we should add those dir to PATH before running the tests.
Hi @rajatjindal
Confirmed, spin binary does get created in `./target/release` dir, I had to manually copy it to /us... | 2023-04-25T05:39:06Z | fermyon__spin-1422 | fermyon/spin | 3.2 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2bd46125d8..67cc4d3299 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -174,8 +174,8 @@ jobs:
export E2E_FETCH_SPIN=false
make build-test-spin-up
- - name: Run e2e tests image
+ -... | 1,422 | [
"1385"
] | diff --git a/crates/e2e-testing/src/spin.rs b/crates/e2e-testing/src/spin.rs
index dc848c54f1..4772f65673 100644
--- a/crates/e2e-testing/src/spin.rs
+++ b/crates/e2e-testing/src/spin.rs
@@ -117,5 +117,11 @@ pub fn registry_login(registry_url: &str, username: &str, password: &str) -> Res
pub fn version() -> Result<Str... | c02196882a336d46c3dd5fcfafeed45ef0a4490e |
7f0d5460125dbff96b4bba1a32ca8750d17b0bd0 | `spin watch` configuration handles multi-component applications poorly
Imagine a Spin application that has two components. Here is its `spin.toml`:
```toml
[[component]]
id = "web"
source = "modules/spin_static_fs.wasm"
environment = { FALLBACK_PATH = "index.html" }
# [[component.files]]
# source = "web/dist"
... | I like the idea that `build.watch` sees the world in the same way as `build.command`, which is your option 1.
Could you elaborate on scenarios where a source to be watched-built is _not_ under the `workdir`? That would help establish how important it is to address this case and whether there are satisfactory workar... | 2023-04-18T17:30:40Z | fermyon__spin-1409 | fermyon/spin | 3.1 | diff --git a/src/commands/watch.rs b/src/commands/watch.rs
index 41df859904..0a8a7418f0 100644
--- a/src/commands/watch.rs
+++ b/src/commands/watch.rs
@@ -188,11 +188,26 @@ impl WatchCommand {
.iter()
.filter_map(|c| {
if let Some(build) = c.build.as_ref() {
- ... | 1,409 | [
"1402"
] | diff --git a/tests/watch/http-rust/spin.toml b/tests/watch/http-rust/spin.toml
index 10854dc585..c6ab91fafa 100644
--- a/tests/watch/http-rust/spin.toml
+++ b/tests/watch/http-rust/spin.toml
@@ -14,3 +14,14 @@ route = "/hello"
[component.build]
command = "cargo build --target wasm32-wasi --release"
watch = ["src/**/... | 7f0d5460125dbff96b4bba1a32ca8750d17b0bd0 |
88c7dbe987af72be7faf950df9af3a40fca02a72 | Add `spin up --app-state-dir`
We're starting to move some per-app local state (logs, default KV store) into a `.spin` dir adjacent to the `spin.toml` file, which we'll start calling the "app state" directory. This should be configurable, with different defaults between "local" (`spin.toml`) and "remote" (Bindle, OCI) a... | For the local case, it seems like there would be no way to unset `--app-state-dir` - is that correct? (I don't see a lot of value to doing so, but just want to be sure that we're making that decision intentionally.)
> way to unset `--app-state-dir`
We can probably safely interpret `--app-state-dir ''` as "unset" wh... | 2023-03-08T22:50:45Z | fermyon__spin-1245 | fermyon/spin | 3.1 | diff --git a/Cargo.lock b/Cargo.lock
index 7183b512b7..68eead556d 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4724,7 +4724,6 @@ dependencies = [
"ctrlc",
"dirs 4.0.0",
"futures",
- "once_cell",
"outbound-http",
"outbound-mysql",
"outbound-pg",
diff --git a/crates/config/src/provider/vault.rs b/crates/confi... | 1,245 | [
"1175"
] | diff --git a/crates/testing/src/lib.rs b/crates/testing/src/lib.rs
index 7bf3f9c097..f2abf4234e 100644
--- a/crates/testing/src/lib.rs
+++ b/crates/testing/src/lib.rs
@@ -18,7 +18,7 @@ use spin_app::{
};
use spin_core::{Module, StoreBuilder};
use spin_http::{HttpExecutorType, HttpTriggerConfig, WagiTriggerConfig};
-... | 7f0d5460125dbff96b4bba1a32ca8750d17b0bd0 |
8f33ca92dd863fa935f60c0a4ef393de4c464cad | Catch invalid key/value store at build time
Currently, Spin's SQLite key value feature only supports a single `"default"` store per application. The implementation [hard codes only supporting this store](https://github.com/fermyon/spin/blob/665d3a023d2a192b12f32dedec9d89b8fd9f9e7e/crates/trigger/src/lib.rs#L393). Acces... | Just to clarify: this would happen at `spin up` time (which would include `spin build --up`). We don't know what stores are available at build time (or won't, once multiple stores are available).
I hadn't realised this. This has docs impact too.
I'd argue this shouldn't prevent build:
* I want to be able to chec... | 2023-03-07T02:57:30Z | fermyon__spin-1235 | fermyon/spin | 3.1 | diff --git a/crates/loader/src/lib.rs b/crates/loader/src/lib.rs
index 0eb307f33c..7ce84abf43 100644
--- a/crates/loader/src/lib.rs
+++ b/crates/loader/src/lib.rs
@@ -16,6 +16,7 @@ pub mod cache;
mod common;
pub mod digest;
pub mod local;
+mod validation;
/// Load a Spin application configuration from a spin.toml... | 1,235 | [
"1232"
] | diff --git a/tests/testcases/key-value/spin.toml b/tests/testcases/key-value/spin.toml
index 764ebdaad0..7891c0bca1 100644
--- a/tests/testcases/key-value/spin.toml
+++ b/tests/testcases/key-value/spin.toml
@@ -7,7 +7,7 @@ version = "1.0.0"
[[component]]
id = "hello"
-key_value_stores = ["default", "foo"]
+key_valu... | 7f0d5460125dbff96b4bba1a32ca8750d17b0bd0 |
3da388c68704a21fd6292987b4e9ddb1079d2984 | Warnings on clean build of new Rust app
We had this before, I think, and got rid of it, but I can't remember how, sorry.
| Previous occurrence was #793 which was fixed in #862. Looks like the fix is to rename the example and test crates?
Is this worth having an integration/SDK test to detect? | 2023-02-22T21:35:06Z | fermyon__spin-1192 | fermyon/spin | 0.9 | diff --git a/examples/rust-key-value/Cargo.toml b/examples/rust-key-value/Cargo.toml
index 55b8526fd4..186ac88ea8 100644
--- a/examples/rust-key-value/Cargo.toml
+++ b/examples/rust-key-value/Cargo.toml
@@ -1,5 +1,5 @@
[package]
-name = "spin-key-value"
+name = "rust-key-value"
version = "0.1.0"
edition = "202... | 1,192 | [
"1186"
] | diff --git a/tests/testcases/headers-dynamic-env-test/Cargo.toml b/tests/testcases/headers-dynamic-env-test/Cargo.toml
index b38cc622cb..7da7cec6e7 100644
--- a/tests/testcases/headers-dynamic-env-test/Cargo.toml
+++ b/tests/testcases/headers-dynamic-env-test/Cargo.toml
@@ -1,5 +1,5 @@
[package]
-name = "env"
+name... | 3da388c68704a21fd6292987b4e9ddb1079d2984 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.