url
stringlengths
52
53
repository_url
stringclasses
1 value
labels_url
stringlengths
66
67
comments_url
stringlengths
61
62
events_url
stringlengths
59
60
html_url
stringlengths
40
43
id
int64
719M
2.8B
node_id
stringlengths
18
32
number
int64
1.28k
11.9k
title
stringlengths
1
350
user
dict
labels
listlengths
0
10
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
3
milestone
null
comments
listlengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
sub_issues_summary
dict
active_lock_reason
stringclasses
1 value
draft
bool
2 classes
pull_request
dict
body
stringlengths
0
73.4k
closed_by
dict
reactions
dict
timeline_url
stringlengths
61
62
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/NVIDIA/NeMo/issues/2220
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2220/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2220/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2220/events
https://github.com/NVIDIA/NeMo/pull/2220
892,602,276
MDExOlB1bGxSZXF1ZXN0NjQ1MjY3NTYw
2,220
Replace model names in VAD tutorials
{ "login": "fayejf", "id": 36722593, "node_id": "MDQ6VXNlcjM2NzIyNTkz", "avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fayejf", "html_url": "https://github.com/fayejf", "followers_url": "https://api.github.com/users/fayejf/followers", "following_url": "https://api.github.com/users/fayejf/following{/other_user}", "gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}", "starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fayejf/subscriptions", "organizations_url": "https://api.github.com/users/fayejf/orgs", "repos_url": "https://api.github.com/users/fayejf/repos", "events_url": "https://api.github.com/users/fayejf/events{/privacy}", "received_events_url": "https://api.github.com/users/fayejf/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-16T05:46:41
2021-05-17T13:28:16
2021-05-17T13:28:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2220", "html_url": "https://github.com/NVIDIA/NeMo/pull/2220", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2220.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2220.patch", "merged_at": "2021-05-17T13:28:14" }
Fix some model names (MatchboxNet -> MarbleNet) in VAD tutorials. (Thought I've fixed all of them before but it's still there hmm)
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2220/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2220/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2219
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2219/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2219/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2219/events
https://github.com/NVIDIA/NeMo/pull/2219
892,556,995
MDExOlB1bGxSZXF1ZXN0NjQ1MjMzMDA4
2,219
Log audio file on loading errors
{ "login": "piraka9011", "id": 16828657, "node_id": "MDQ6VXNlcjE2ODI4NjU3", "avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4", "gravatar_id": "", "url": "https://api.github.com/users/piraka9011", "html_url": "https://github.com/piraka9011", "followers_url": "https://api.github.com/users/piraka9011/followers", "following_url": "https://api.github.com/users/piraka9011/following{/other_user}", "gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}", "starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions", "organizations_url": "https://api.github.com/users/piraka9011/orgs", "repos_url": "https://api.github.com/users/piraka9011/repos", "events_url": "https://api.github.com/users/piraka9011/events{/privacy}", "received_events_url": "https://api.github.com/users/piraka9011/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Seems theres some formatting errors, could you run `python setup.py style --scope nemo --fix`", "This PR will be merged into another PR (https://github.com/NVIDIA/NeMo/pull/2240) due to inactivity. One difference is that it will not raise the error, but instead simply log that the file was not loaded properly.",...
2021-05-15T23:13:34
2021-05-20T01:46:17
2021-05-19T23:41:38
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2219", "html_url": "https://github.com/NVIDIA/NeMo/pull/2219", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2219.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2219.patch", "merged_at": null }
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me> It would be helpful to know offending audio files that fail to load if they are corrupt and/or not supported.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2219/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2219/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2218
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2218/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2218/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2218/events
https://github.com/NVIDIA/NeMo/issues/2218
892,544,245
MDU6SXNzdWU4OTI1NDQyNDU=
2,218
TarredAudioToTextDataset assumes audio is always wav
{ "login": "piraka9011", "id": 16828657, "node_id": "MDQ6VXNlcjE2ODI4NjU3", "avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4", "gravatar_id": "", "url": "https://api.github.com/users/piraka9011", "html_url": "https://github.com/piraka9011", "followers_url": "https://api.github.com/users/piraka9011/followers", "following_url": "https://api.github.com/users/piraka9011/following{/other_user}", "gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}", "starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions", "organizations_url": "https://api.github.com/users/piraka9011/orgs", "repos_url": "https://api.github.com/users/piraka9011/repos", "events_url": "https://api.github.com/users/piraka9011/events{/privacy}", "received_events_url": "https://api.github.com/users/piraka9011/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "We generally don't prefer to have other file formats for efficiency reasons (wav takes storage but at least it prevents on the fly resampling to 16khz monochannel audio). \r\n\r\nTarred datasets are meant for distributed training on clusters, where network I/O can have a significant impact on training speed. Likew...
2021-05-15T21:33:30
2021-05-28T08:37:25
2021-05-28T08:37:25
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** `TarredAudioToTextDataset` assumes audio is `wav`. However I was able to train a model with `mp3` files and would like `TarredAudioToTextDataset` to support other file types. **Steps/Code to reproduce bug** Use any dataset with non-wav files. **Expected behavior** Model should be trainable with non-wav tarred datasets **Environment overview (please complete the following information)** - Environment location: Bare-metal - Method of NeMo install: pip install nemo['all']==1.0.0rc1 **Environment details** Otherwise, please provide: - OS version: Ubuntu 20.04 - PyTorch version: 1.7.1 - Python version: 3.8 **Additional context** My suggestion is to simply add another field to the `*_ds` config called `file_format` or `file_extension` which can be one of a list of supported files by `soundfile`. Can submit a PR if this is fine, but some guidance/feedback on the approach first would be good.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2218/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2218/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2217
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2217/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2217/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2217/events
https://github.com/NVIDIA/NeMo/issues/2217
892,543,318
MDU6SXNzdWU4OTI1NDMzMTg=
2,217
Is there a way to modify Offline_ASR tutorial so that it builds KenLM binary file?
{ "login": "jsilbergDS", "id": 71464491, "node_id": "MDQ6VXNlcjcxNDY0NDkx", "avatar_url": "https://avatars.githubusercontent.com/u/71464491?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jsilbergDS", "html_url": "https://github.com/jsilbergDS", "followers_url": "https://api.github.com/users/jsilbergDS/followers", "following_url": "https://api.github.com/users/jsilbergDS/following{/other_user}", "gists_url": "https://api.github.com/users/jsilbergDS/gists{/gist_id}", "starred_url": "https://api.github.com/users/jsilbergDS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jsilbergDS/subscriptions", "organizations_url": "https://api.github.com/users/jsilbergDS/orgs", "repos_url": "https://api.github.com/users/jsilbergDS/repos", "events_url": "https://api.github.com/users/jsilbergDS/events{/privacy}", "received_events_url": "https://api.github.com/users/jsilbergDS/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "These docs are quite outdated, could you point me to where they were referenced so we can update them ?\r\n\r\nThese are the latest docs - https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/\r\n\r\nThis section (https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/asr/asr_language_model...
2021-05-15T21:28:17
2021-06-09T12:33:26
2021-05-15T23:06:14
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hello, thank you again for the amazing project. I am trying to modify the code in https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/asr/Offline_ASR.ipynb#scrollTo=I9eIxAyKHREB. Am I correct, based on (https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/zh/latest/asr/tutorial.html#using-kenlm) that this does not actually build the KenLM binary? When I try to use the train_kenlm.py script, it says I don't have /content/NeMo/decoders/kenlm/build/bin/lmplz, but reading through the KenLM README and the various setup.sh and setup.py scripts in NeMo and OpenSeq2Seq, I cannot seem to get it to build this /bin folder. I am sure this is my user error :-) Thanks!
{ "login": "jsilbergDS", "id": 71464491, "node_id": "MDQ6VXNlcjcxNDY0NDkx", "avatar_url": "https://avatars.githubusercontent.com/u/71464491?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jsilbergDS", "html_url": "https://github.com/jsilbergDS", "followers_url": "https://api.github.com/users/jsilbergDS/followers", "following_url": "https://api.github.com/users/jsilbergDS/following{/other_user}", "gists_url": "https://api.github.com/users/jsilbergDS/gists{/gist_id}", "starred_url": "https://api.github.com/users/jsilbergDS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jsilbergDS/subscriptions", "organizations_url": "https://api.github.com/users/jsilbergDS/orgs", "repos_url": "https://api.github.com/users/jsilbergDS/repos", "events_url": "https://api.github.com/users/jsilbergDS/events{/privacy}", "received_events_url": "https://api.github.com/users/jsilbergDS/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2217/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2217/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2216
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2216/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2216/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2216/events
https://github.com/NVIDIA/NeMo/pull/2216
892,541,473
MDExOlB1bGxSZXF1ZXN0NjQ1MjIxMjQz
2,216
Support symlinked files
{ "login": "piraka9011", "id": 16828657, "node_id": "MDQ6VXNlcjE2ODI4NjU3", "avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4", "gravatar_id": "", "url": "https://api.github.com/users/piraka9011", "html_url": "https://github.com/piraka9011", "followers_url": "https://api.github.com/users/piraka9011/followers", "following_url": "https://api.github.com/users/piraka9011/following{/other_user}", "gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}", "starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions", "organizations_url": "https://api.github.com/users/piraka9011/orgs", "repos_url": "https://api.github.com/users/piraka9011/repos", "events_url": "https://api.github.com/users/piraka9011/events{/privacy}", "received_events_url": "https://api.github.com/users/piraka9011/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Just a note - The manifest file can (and generally it should) have absolute paths to the dataset files when on a local machine, which the tarfile would then use. ", "> Just a note - The manifest file can (and generally it should) have absolute paths to the dataset files when on a local machine, which the tarfile...
2021-05-15T21:17:24
2021-05-17T22:55:28
2021-05-17T22:55:28
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2216", "html_url": "https://github.com/NVIDIA/NeMo/pull/2216", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2216.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2216.patch", "merged_at": "2021-05-17T22:55:28" }
To preserve disk space on my machine, I generally use symlinks to create different splits of my data. The tarred audio dataset script doesn't follow symlinks, so simply pass `dereference=True` to the `tarfile.open()` method. See more info in the python docs: https://docs.python.org/3/library/tarfile.html#tarfile.TarFile
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2216/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2216/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2215
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2215/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2215/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2215/events
https://github.com/NVIDIA/NeMo/issues/2215
892,424,167
MDU6SXNzdWU4OTI0MjQxNjc=
2,215
problem with fine-tuning th e pre-trained `SpeakerNet` model for speaker recognition
{ "login": "JINHXu", "id": 36717127, "node_id": "MDQ6VXNlcjM2NzE3MTI3", "avatar_url": "https://avatars.githubusercontent.com/u/36717127?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JINHXu", "html_url": "https://github.com/JINHXu", "followers_url": "https://api.github.com/users/JINHXu/followers", "following_url": "https://api.github.com/users/JINHXu/following{/other_user}", "gists_url": "https://api.github.com/users/JINHXu/gists{/gist_id}", "starred_url": "https://api.github.com/users/JINHXu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JINHXu/subscriptions", "organizations_url": "https://api.github.com/users/JINHXu/orgs", "repos_url": "https://api.github.com/users/JINHXu/repos", "events_url": "https://api.github.com/users/JINHXu/events{/privacy}", "received_events_url": "https://api.github.com/users/JINHXu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https:...
null
[ "Hi, again! I just tried with the `hi-mia` dataset and received the same error ", "Hi, I just ran `speaker_reco_finetune.py` and everything looks good to me. \r\nCan you make sure you have set the following params in conf/SpeakerNet_verification_3x2x512.yaml:\r\ntrain_set\r\ndev_set\r\ndecoder.emb_sizes: 256\r\nd...
2021-05-15T11:59:48
2021-05-23T11:42:04
2021-05-23T11:42:04
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi! As an experiment, I was fine-tuning the pre-trained `SpeakerNet` model with the `an4` dataset plus my own voice recordings. I used the example script `speaker_reco_finetune.py` and changed the configuration file according to the documentation and the colab notebook tutorial. But it appears something is always wrong with setting up the optimizer: ``` Traceback (most recent call last): File "/Users/xujinghua/speaker-recognition-nemo/scripts/experimental/fine_tune_an4.py", line 119, in <module> main() File "/Users/xujinghua/speaker-recognition-nemo/scripts/experimental/fine_tune_an4.py", line 108, in main speaker_model.setup_optimization(speaker_model._cfg.optim) File "/Users/xujinghua/miniconda3/lib/python3.7/site-packages/nemo/core/classes/modelPT.py", line 603, in setup_optimization optimizer=self._optimizer, scheduler_config=scheduler_config, train_dataloader=self._train_dl File "/Users/xujinghua/miniconda3/lib/python3.7/site-packages/nemo/core/optim/lr_scheduler.py", line 539, in prepare_lr_scheduler max_epochs, accumulate_grad_batches, num_workers, num_samples, batch_size, drop_last, File "/Users/xujinghua/miniconda3/lib/python3.7/site-packages/nemo/core/optim/lr_scheduler.py", line 587, in compute_max_steps sampler_num_samples = math.ceil(num_samples / num_workers) ZeroDivisionError: division by zero ``` I tried a few ways to debug but nothing helped I have no clue what is going on wrong. Has anyone got an idea or run into such problems before? Help would be super appreciated! Cheers, JX
{ "login": "JINHXu", "id": 36717127, "node_id": "MDQ6VXNlcjM2NzE3MTI3", "avatar_url": "https://avatars.githubusercontent.com/u/36717127?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JINHXu", "html_url": "https://github.com/JINHXu", "followers_url": "https://api.github.com/users/JINHXu/followers", "following_url": "https://api.github.com/users/JINHXu/following{/other_user}", "gists_url": "https://api.github.com/users/JINHXu/gists{/gist_id}", "starred_url": "https://api.github.com/users/JINHXu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JINHXu/subscriptions", "organizations_url": "https://api.github.com/users/JINHXu/orgs", "repos_url": "https://api.github.com/users/JINHXu/repos", "events_url": "https://api.github.com/users/JINHXu/events{/privacy}", "received_events_url": "https://api.github.com/users/JINHXu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2215/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2215/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2214
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2214/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2214/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2214/events
https://github.com/NVIDIA/NeMo/issues/2214
892,330,614
MDU6SXNzdWU4OTIzMzA2MTQ=
2,214
Can not run Relation-Extraction-BioMegatron.ipynb because of error ModuleNotFoundError: No module named 'apex.normalization'
{ "login": "MHDBST", "id": 6802945, "node_id": "MDQ6VXNlcjY4MDI5NDU=", "avatar_url": "https://avatars.githubusercontent.com/u/6802945?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MHDBST", "html_url": "https://github.com/MHDBST", "followers_url": "https://api.github.com/users/MHDBST/followers", "following_url": "https://api.github.com/users/MHDBST/following{/other_user}", "gists_url": "https://api.github.com/users/MHDBST/gists{/gist_id}", "starred_url": "https://api.github.com/users/MHDBST/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MHDBST/subscriptions", "organizations_url": "https://api.github.com/users/MHDBST/orgs", "repos_url": "https://api.github.com/users/MHDBST/repos", "events_url": "https://api.github.com/users/MHDBST/events{/privacy}", "received_events_url": "https://api.github.com/users/MHDBST/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/u...
null
[ "I couldn't reproduce any training issues with [this notebook](https://colab.research.google.com/github/NVIDIA/NeMo/blob/r1.0.0rc1/tutorials/nlp/Relation_Extraction-BioMegatron.ipynb) running on Colab. A few warnings do appear during installation but they can be disregarded. \r\nCould you please specify the exact c...
2021-05-15T01:45:26
2021-10-26T23:44:59
2021-10-26T23:44:59
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** A clear and concise description of what the bug is. I am trying to use a pretrained model on the relation extraction task and chem-rot dataset. As suggested by the authors, I'm using the notebook provided: Relation-Extraction-BioMegatron.ipynb **Steps/Code to reproduce bug** When I run the codes in the notebook, I get different errors. The first one is inconsistency between torch, torchtext and coda version. I was able to solve this problem by using this command: ``` !pip install torch==1.7.1+cu110 torchvision==0.8.2+cu110 torchaudio==0.7.2 torchtext==0.8 -f https://download.pytorch.org/whl/torch_stable.html ``` Then I had problems with installing apex and I was able to solve by using this code: ``` %%writefile setup.sh # git clone https://github.com/qywu/apex # cd apex # pip install -v --no-cache-dir --global-option="--cpp_ext" --global-option="--cuda_ext" ./ !sh setup.sh ``` Now I have another issue, I can use this command: ``` import apex ``` but this command returns error: ``` from apex.normalization.fused_layer_norm import FusedLayerNorm ModuleNotFoundError: No module named 'apex.normalization' ``` What do you suggest? **Expected behavior** I expect to be able to run the code without any errors. **Environment overview (please complete the following information)** - Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)] - Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install. - If method of install is [Docker], provide `docker pull` & `docker run` commands used I used everything mentioned in this notebook: `Relation-Extraction-BioMegatron.ipynb` **Environment details** If NVIDIA docker image is used you don't need to specify these. Otherwise, please provide: - OS version - PyTorch version - Python version **Additional context** Add any other context about the problem here. Example: GPU model I used GPU version of the Google Colab
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2214/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2213
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2213/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2213/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2213/events
https://github.com/NVIDIA/NeMo/pull/2213
892,303,149
MDExOlB1bGxSZXF1ZXN0NjQ1MDM4MjQ0
2,213
Remove memory leak from ASR notebook + update model notebook
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-14T23:32:33
2021-05-15T01:59:53
2021-05-15T01:59:51
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2213", "html_url": "https://github.com/NVIDIA/NeMo/pull/2213", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2213.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2213.patch", "merged_at": "2021-05-15T01:59:51" }
# Bugfix - Fix a memory leak in the WER calculation loop in the notebook - (NOTE: The notebook content has not changed, the diff is just large cause colab version updated) # Update - Update the model notebook to use the new artifact system + log the loss properly Closes https://github.com/NVIDIA/NeMo/issues/2208
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2213/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2213/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2212
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2212/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2212/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2212/events
https://github.com/NVIDIA/NeMo/issues/2212
892,297,081
MDU6SXNzdWU4OTIyOTcwODE=
2,212
Problem installing NeMo from pip
{ "login": "szalpal", "id": 7101064, "node_id": "MDQ6VXNlcjcxMDEwNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/7101064?v=4", "gravatar_id": "", "url": "https://api.github.com/users/szalpal", "html_url": "https://github.com/szalpal", "followers_url": "https://api.github.com/users/szalpal/followers", "following_url": "https://api.github.com/users/szalpal/following{/other_user}", "gists_url": "https://api.github.com/users/szalpal/gists{/gist_id}", "starred_url": "https://api.github.com/users/szalpal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/szalpal/subscriptions", "organizations_url": "https://api.github.com/users/szalpal/orgs", "repos_url": "https://api.github.com/users/szalpal/repos", "events_url": "https://api.github.com/users/szalpal/events{/privacy}", "received_events_url": "https://api.github.com/users/szalpal/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "which pip version do you have? Could be a problem with your environment. Are you able to pip install other packages? Like this: ```pip install pytorch-lightning==1.1.4``` ? I literally copy-pasted this: ```pip install nemo_toolkit[all]==1.0.0rc1``` and it worked." ]
2021-05-14T23:11:58
2021-05-17T17:59:49
2021-05-17T17:59:49
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi, I have a problem installing NeMo from pip. I'm using the instructions [here](https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/starthere/intro.html#pip) Following them, I'm getting: ``` (venv) ✘ mszolucha@szal-workstation  ~  sudo apt-get update && sudo apt-get install -y libsndfile1 ffmpeg [...] Reading package lists... Done Reading package lists... Done Building dependency tree Reading state information... Done libsndfile1 is already the newest version (1.0.28-7). ffmpeg is already the newest version (7:4.2.4-1ubuntu0.1). [...] 0 upgraded, 0 newly installed, 0 to remove and 298 not upgraded. (venv) mszolucha@szal-workstation  ~  pip install Cython Requirement already satisfied: Cython in ./virtualenv/venv/lib/python3.8/site-packages (0.29.23) (venv) mszolucha@szal-workstation  ~  pip install nemo_toolkit['all']==1.0.0rc1 zsh: no matches found: nemo_toolkit[all]==1.0.0rc1 (venv) ✘ mszolucha@szal-workstation  ~  pip install nemo_toolkit[all]==1.0.0rc1 zsh: no matches found: nemo_toolkit[all]==1.0.0rc1 ``` What should I do to install NeMo? My environment: ``` (venv) ✘ mszolucha@szal-workstation  ~  python --version Python 3.8.5 (venv) mszolucha@szal-workstation  ~  nvidia-smi +-----------------------------------------------------------------------------+ | NVIDIA-SMI 460.32.03 Driver Version: 460.32.03 CUDA Version: 11.2 | |-------------------------------+----------------------+----------------------+ | GPU Name Persistence-M| Bus-Id Disp.A | Volatile Uncorr. ECC | | Fan Temp Perf Pwr:Usage/Cap| Memory-Usage | GPU-Util Compute M. | | | | MIG M. | |===============================+======================+======================| | 0 TITAN RTX Off | 00000000:01:00.0 Off | N/A | | 23% 44C P0 33W / 280W | 0MiB / 24220MiB | 0% Default | | | | N/A | +-------------------------------+----------------------+----------------------+ ``` Ubuntu 20
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2212/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2212/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2211
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2211/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2211/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2211/events
https://github.com/NVIDIA/NeMo/pull/2211
892,233,163
MDExOlB1bGxSZXF1ZXN0NjQ0OTc3Njc2
2,211
Update models and notebook for 1.0
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging 85b00da1038709cc1b145f28c8e8dd043efb2932 into d1b37ed30a70bff00df4778b55b020d8bab2e6fb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-df3f0c730d38a856855a25d9a48542d309857460)\n\n**new alerts:**\n\n* 1 for Variable defined multiple times", ...
2021-05-14T20:48:05
2021-05-18T18:56:24
2021-05-18T18:56:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2211", "html_url": "https://github.com/NVIDIA/NeMo/pull/2211", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2211.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2211.patch", "merged_at": "2021-05-18T18:56:22" }
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2211/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2211/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2210
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2210/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2210/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2210/events
https://github.com/NVIDIA/NeMo/pull/2210
891,991,299
MDExOlB1bGxSZXF1ZXN0NjQ0NzcwNjE5
2,210
Small updates in TalkNet and FastPitch
{ "login": "Oktai15", "id": 17337773, "node_id": "MDQ6VXNlcjE3MzM3Nzcz", "avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Oktai15", "html_url": "https://github.com/Oktai15", "followers_url": "https://api.github.com/users/Oktai15/followers", "following_url": "https://api.github.com/users/Oktai15/following{/other_user}", "gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}", "starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions", "organizations_url": "https://api.github.com/users/Oktai15/orgs", "repos_url": "https://api.github.com/users/Oktai15/repos", "events_url": "https://api.github.com/users/Oktai15/events{/privacy}", "received_events_url": "https://api.github.com/users/Oktai15/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-14T14:56:20
2023-02-22T18:45:05
2021-05-14T16:50:53
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2210", "html_url": "https://github.com/NVIDIA/NeMo/pull/2210", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2210.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2210.patch", "merged_at": null }
* update `_loader` method in TalkNet and FastPitch for easy creating model from config for non-training/validating purposes (e.g. just check inference speed). * update FastPitch config
{ "login": "Oktai15", "id": 17337773, "node_id": "MDQ6VXNlcjE3MzM3Nzcz", "avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Oktai15", "html_url": "https://github.com/Oktai15", "followers_url": "https://api.github.com/users/Oktai15/followers", "following_url": "https://api.github.com/users/Oktai15/following{/other_user}", "gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}", "starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions", "organizations_url": "https://api.github.com/users/Oktai15/orgs", "repos_url": "https://api.github.com/users/Oktai15/repos", "events_url": "https://api.github.com/users/Oktai15/events{/privacy}", "received_events_url": "https://api.github.com/users/Oktai15/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2210/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2210/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2209
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2209/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2209/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2209/events
https://github.com/NVIDIA/NeMo/pull/2209
891,550,956
MDExOlB1bGxSZXF1ZXN0NjQ0NDA0OTc4
2,209
fix the versioning name.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "> \r\n> \r\n> Doesn't this just dump the files into the project dir? @blisc any thoughts if this is correct ?\r\n\r\nActually I made this from \"\" to None last time to hope it fixes the w&b but it made the issue that now we have a folder name \"None\" and then there is another folder under that named \"checkpoint...
2021-05-14T02:58:08
2021-08-06T08:01:13
2021-05-17T13:30:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2209", "html_url": "https://github.com/NVIDIA/NeMo/pull/2209", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2209.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2209.patch", "merged_at": "2021-05-17T13:30:09" }
Fix the versioning name to avoid creating the extra folder name "None" when training is supposed to continue.
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2209/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2209/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2208
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2208/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2208/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2208/events
https://github.com/NVIDIA/NeMo/issues/2208
891,533,211
MDU6SXNzdWU4OTE1MzMyMTE=
2,208
Memory leak in 01_ASR_with_NeMo.ipynb
{ "login": "jsilbergDS", "id": 71464491, "node_id": "MDQ6VXNlcjcxNDY0NDkx", "avatar_url": "https://avatars.githubusercontent.com/u/71464491?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jsilbergDS", "html_url": "https://github.com/jsilbergDS", "followers_url": "https://api.github.com/users/jsilbergDS/followers", "following_url": "https://api.github.com/users/jsilbergDS/following{/other_user}", "gists_url": "https://api.github.com/users/jsilbergDS/gists{/gist_id}", "starred_url": "https://api.github.com/users/jsilbergDS/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jsilbergDS/subscriptions", "organizations_url": "https://api.github.com/users/jsilbergDS/orgs", "repos_url": "https://api.github.com/users/jsilbergDS/repos", "events_url": "https://api.github.com/users/jsilbergDS/events{/privacy}", "received_events_url": "https://api.github.com/users/jsilbergDS/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "Thanks for finding this, I'll send a PR tomorrow patching this. If you only need inference, you can freeze the model with model.freeze() and this will prevent any leak. \r\n\r\nIt's the notebook environment which has the potential for leaking cuda tensors, and scripts don't have this leakage.\r\n\r\nThe notebooks ...
2021-05-14T02:07:58
2021-05-15T08:41:11
2021-05-15T08:41:11
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Running 01_ASR_with_NeMo.ipynb WER cells appears to be leaking data in CUDA. With batch_size 32, using print(torch.cuda.memory_allocated()) prints 91,033,600 prior to running, then 129,805,824 after. There's a hard delete in https://github.com/NVIDIA/NeMo/blob/8e239ecc7d7bc1206c72daa207b0f122e85551f1/examples/asr/speech_to_text_infer.py that's missing in the notebook. Additionally, a few more questions: 1) Is there some other way to run WER? 2) Why does batch size change the WER? Isn't it averaged across batches? 3) Is there any way to run this without Cuda, e.g., so that it can be used on Colab TPU's Thanks! I have really appreciated getting to use this!
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2208/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2208/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2207
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2207/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2207/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2207/events
https://github.com/NVIDIA/NeMo/pull/2207
891,523,702
MDExOlB1bGxSZXF1ZXN0NjQ0MzgyMzc0
2,207
ASR patches for v1.0.0
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "@okuchaiev fyi regarding the dockerfile ignore and correctly updating the self.trainer inside set_trainer." ]
2021-05-14T01:51:43
2021-05-14T07:03:56
2021-05-14T06:55:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2207", "html_url": "https://github.com/NVIDIA/NeMo/pull/2207", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2207.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2207.patch", "merged_at": "2021-05-14T06:55:42" }
# Bugfixes - Correct WER calculation for RNNT by resetting the metric after each computation. - Prevent numba from performing a sync across PT cuda stream simply to initialize a cost vector. - Correctly update the trainer value using `set_trainer` - Adds .nemo and .ckpt files to dockerignore # Additions - Adds RNNT global flags to enable detached gradient normalization of encoder, decoder and joint models - Adds `weights_init_scale` and `hidden_hidden_bias_scale` values (default to original values) to attempt reduction in variance between runs - Add `tds_uniform` and `tds_normal` initialization modes for Jasper based models.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2207/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2207/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2206
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2206/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2206/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2206/events
https://github.com/NVIDIA/NeMo/pull/2206
891,335,491
MDExOlB1bGxSZXF1ZXN0NjQ0MjE5MjEy
2,206
Set seed before generating random tensors in NMT test
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-13T20:10:09
2022-01-11T16:37:01
2021-05-13T22:23:49
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2206", "html_url": "https://github.com/NVIDIA/NeMo/pull/2206", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2206.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2206.patch", "merged_at": "2021-05-13T22:23:49" }
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2206/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2206/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2205
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2205/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2205/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2205/events
https://github.com/NVIDIA/NeMo/pull/2205
891,253,911
MDExOlB1bGxSZXF1ZXN0NjQ0MTQ5NTgw
2,205
Cherrypick SpecCutout PR
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-13T18:10:23
2021-05-13T20:51:32
2021-05-13T20:51:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2205", "html_url": "https://github.com/NVIDIA/NeMo/pull/2205", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2205.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2205.patch", "merged_at": "2021-05-13T20:51:28" }
# Changelog - cherry pick the bugfix from main for SpecCutout into v1.0.0 Refer to https://github.com/NVIDIA/NeMo/pull/2201
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2205/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2205/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2204
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2204/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2204/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2204/events
https://github.com/NVIDIA/NeMo/issues/2204
890,609,291
MDU6SXNzdWU4OTA2MDkyOTE=
2,204
Support cloud-based storage for checkpoints
{ "login": "piraka9011", "id": 16828657, "node_id": "MDQ6VXNlcjE2ODI4NjU3", "avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4", "gravatar_id": "", "url": "https://api.github.com/users/piraka9011", "html_url": "https://github.com/piraka9011", "followers_url": "https://api.github.com/users/piraka9011/followers", "following_url": "https://api.github.com/users/piraka9011/following{/other_user}", "gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}", "starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions", "organizations_url": "https://api.github.com/users/piraka9011/orgs", "repos_url": "https://api.github.com/users/piraka9011/repos", "events_url": "https://api.github.com/users/piraka9011/events{/privacy}", "received_events_url": "https://api.github.com/users/piraka9011/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" } ]
closed
false
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://a...
null
[ "Closing. re-open if issue is still relevant." ]
2021-05-13T01:12:36
2022-04-05T23:35:56
2022-04-05T23:35:56
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Is your feature request related to a problem? Please describe.** I would like to store my checkpoints/models using AWS/GCP so that when I run training on ephemeral instances, I don't lose my progress. **Describe the solution you'd like** Register a new callback on epoch end to upload the ckpt/Nemo file to AWS/GCP if the option is passed in the config file via the trainer (using the checkpoint callback field) **Describe alternatives you've considered** None, open to discussion though. **Additional context** I have a working implementation for a local repo, but would like to gauge interest for upstream support in NeMo before submitting a PR.
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2204/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2204/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2203
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2203/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2203/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2203/events
https://github.com/NVIDIA/NeMo/pull/2203
890,297,063
MDExOlB1bGxSZXF1ZXN0NjQzMzM4NzQy
2,203
readme and minor improvements
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-12T16:58:25
2021-05-12T18:50:48
2021-05-12T18:50:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2203", "html_url": "https://github.com/NVIDIA/NeMo/pull/2203", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2203.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2203.patch", "merged_at": "2021-05-12T18:50:40" }
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2203/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2203/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2202
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2202/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2202/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2202/events
https://github.com/NVIDIA/NeMo/pull/2202
890,267,284
MDExOlB1bGxSZXF1ZXN0NjQzMzE0NDUz
2,202
metrics fix
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-12T16:21:43
2021-05-12T17:49:31
2021-05-12T17:49:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2202", "html_url": "https://github.com/NVIDIA/NeMo/pull/2202", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2202.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2202.patch", "merged_at": "2021-05-12T17:49:28" }
Signed-off-by: ekmb <ebakhturina@nvidia.com>
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2202/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2202/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2201
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2201/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2201/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2201/events
https://github.com/NVIDIA/NeMo/pull/2201
890,224,909
MDExOlB1bGxSZXF1ZXN0NjQzMjc4Mzk1
2,201
Fix bug in SpecCutout
{ "login": "rbracco", "id": 47190785, "node_id": "MDQ6VXNlcjQ3MTkwNzg1", "avatar_url": "https://avatars.githubusercontent.com/u/47190785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rbracco", "html_url": "https://github.com/rbracco", "followers_url": "https://api.github.com/users/rbracco/followers", "following_url": "https://api.github.com/users/rbracco/following{/other_user}", "gists_url": "https://api.github.com/users/rbracco/gists{/gist_id}", "starred_url": "https://api.github.com/users/rbracco/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rbracco/subscriptions", "organizations_url": "https://api.github.com/users/rbracco/orgs", "repos_url": "https://api.github.com/users/rbracco/repos", "events_url": "https://api.github.com/users/rbracco/events{/privacy}", "received_events_url": "https://api.github.com/users/rbracco/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Thanks Robert for catching the bug! It looks like it has been around for a long time.\r\nWhy do you believe that \"it causes the placement of the masks to be limited to the lowest frequency bins\"?\r\nThe starting point for the frequency masking looks correct to me and can be any frequency. The only problem is tha...
2021-05-12T15:39:02
2021-05-13T17:54:12
2021-05-13T17:54:12
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2201", "html_url": "https://github.com/NVIDIA/NeMo/pull/2201", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2201.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2201.patch", "merged_at": "2021-05-13T17:54:12" }
[Colab notebook demonstrating bug and fix](https://colab.research.google.com/drive/1Tksb-RXAeLSkBW72KDgm1DYUaPAnHXBx?usp=sharing) There is a bug in the NeMo implementation of SpecCutout that causes the dimensions of masks to be transposed so that `rect_freq` is the size of the mask in the time dimension and `rect_time` is the size of the mask in the frequency dimension. This also causes the placement of the masks to be limited to the lowest frequency bins. ![image](https://user-images.githubusercontent.com/47190785/118002089-49df7b00-b315-11eb-9828-10436e84a674.png) Output after fix: ![image](https://user-images.githubusercontent.com/47190785/118003342-7e076b80-b316-11eb-9ddc-17af39e6b9da.png)
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2201/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2201/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2200
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2200/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2200/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2200/events
https://github.com/NVIDIA/NeMo/issues/2200
889,757,040
MDU6SXNzdWU4ODk3NTcwNDA=
2,200
Fine-tuning QuartNet15*5 with Persian long duration audio
{ "login": "MelikaBahmanabadi", "id": 56230126, "node_id": "MDQ6VXNlcjU2MjMwMTI2", "avatar_url": "https://avatars.githubusercontent.com/u/56230126?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MelikaBahmanabadi", "html_url": "https://github.com/MelikaBahmanabadi", "followers_url": "https://api.github.com/users/MelikaBahmanabadi/followers", "following_url": "https://api.github.com/users/MelikaBahmanabadi/following{/other_user}", "gists_url": "https://api.github.com/users/MelikaBahmanabadi/gists{/gist_id}", "starred_url": "https://api.github.com/users/MelikaBahmanabadi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MelikaBahmanabadi/subscriptions", "organizations_url": "https://api.github.com/users/MelikaBahmanabadi/orgs", "repos_url": "https://api.github.com/users/MelikaBahmanabadi/repos", "events_url": "https://api.github.com/users/MelikaBahmanabadi/events{/privacy}", "received_events_url": "https://api.github.com/users/MelikaBahmanabadi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "You generally should not train with such long sequences, since it would use far too much memory + enormous amounts of training data + compute to train a model on long segments. Generally durations of 15-20 second segments are used for training. \r\n\r\nIt would be best to segment the audio in the second dataset. I...
2021-05-12T07:13:23
2021-07-13T15:26:34
2021-07-13T15:26:34
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi, I used QuartNet15*5 and fine-tuned it with the Persian Common Voice dataset. the WER was 30%. Everything worked well and I saved it as a checkpoint. After a while, I restored the checkpoint. I fine-tuned it with another Persian data set that has a longer duration than 16.7 seconds (i.e., 2 minutes, 3minutes, and so on ). When I test the model with the long duration audio, the vocabulary disarranged and the model could not transcript any audio correctly. What's your idea for fine-tuning QuartNet15*5 with a long duration? Thanks
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2200/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2199
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2199/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2199/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2199/events
https://github.com/NVIDIA/NeMo/pull/2199
889,657,332
MDExOlB1bGxSZXF1ZXN0NjQyNzk0MDEy
2,199
Fix ipywidgets error in asr notebook
{ "login": "DerekChia", "id": 1457728, "node_id": "MDQ6VXNlcjE0NTc3Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1457728?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DerekChia", "html_url": "https://github.com/DerekChia", "followers_url": "https://api.github.com/users/DerekChia/followers", "following_url": "https://api.github.com/users/DerekChia/following{/other_user}", "gists_url": "https://api.github.com/users/DerekChia/gists{/gist_id}", "starred_url": "https://api.github.com/users/DerekChia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DerekChia/subscriptions", "organizations_url": "https://api.github.com/users/DerekChia/orgs", "repos_url": "https://api.github.com/users/DerekChia/repos", "events_url": "https://api.github.com/users/DerekChia/events{/privacy}", "received_events_url": "https://api.github.com/users/DerekChia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Thanks for the PR, could you sign your commit according to the instructions on the dco bot ?(https://github.com/NVIDIA/NeMo/pull/2199/checks?check_run_id=2563046850)\r\n", "@titu1994 done with the signoff", "Thanks for the fix !" ]
2021-05-12T05:38:08
2021-05-12T18:43:26
2021-05-12T15:55:37
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2199", "html_url": "https://github.com/NVIDIA/NeMo/pull/2199", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2199.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2199.patch", "merged_at": "2021-05-12T15:55:37" }
Added `ipywidgets` to avoid `ImportError: IProgress not found. Please update jupyter and ipywidgets. See https://ipywidgets.readthedocs.io/en/stable/user_install.html` error.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2199/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2199/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2198
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2198/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2198/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2198/events
https://github.com/NVIDIA/NeMo/pull/2198
888,862,325
MDExOlB1bGxSZXF1ZXN0NjQyMDMxOTMw
2,198
Add a CI test for doing inference with an NMT model trained with Pre-LN
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-11T22:09:46
2021-05-12T05:38:45
2021-05-12T05:38:41
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2198", "html_url": "https://github.com/NVIDIA/NeMo/pull/2198", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2198.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2198.patch", "merged_at": "2021-05-12T05:38:41" }
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2198/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2198/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2197
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2197/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2197/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2197/events
https://github.com/NVIDIA/NeMo/pull/2197
888,689,712
MDExOlB1bGxSZXF1ZXN0NjQxODY0MDc5
2,197
Transformer final norm preln
{ "login": "fayejf", "id": 36722593, "node_id": "MDQ6VXNlcjM2NzIyNTkz", "avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fayejf", "html_url": "https://github.com/fayejf", "followers_url": "https://api.github.com/users/fayejf/followers", "following_url": "https://api.github.com/users/fayejf/following{/other_user}", "gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}", "starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fayejf/subscriptions", "organizations_url": "https://api.github.com/users/fayejf/orgs", "repos_url": "https://api.github.com/users/fayejf/repos", "events_url": "https://api.github.com/users/fayejf/events{/privacy}", "received_events_url": "https://api.github.com/users/fayejf/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "wouldn't this break all the checkpoints trained with pre_ln=True?", "This pull request **introduces 1 alert** when merging 06d1bb03d4144ea1d95b1656083db015711489c2 into d1b37ed30a70bff00df4778b55b020d8bab2e6fb - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-72c6d188f1fb006ed4703c0de0401a0abd5...
2021-05-11T21:16:59
2021-05-18T17:07:28
2021-05-18T17:07:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2197", "html_url": "https://github.com/NVIDIA/NeMo/pull/2197", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2197.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2197.patch", "merged_at": "2021-05-18T17:07:23" }
Fix/Add final layer norm for pre_ln transformer encoder and decoder
{ "login": "fayejf", "id": 36722593, "node_id": "MDQ6VXNlcjM2NzIyNTkz", "avatar_url": "https://avatars.githubusercontent.com/u/36722593?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fayejf", "html_url": "https://github.com/fayejf", "followers_url": "https://api.github.com/users/fayejf/followers", "following_url": "https://api.github.com/users/fayejf/following{/other_user}", "gists_url": "https://api.github.com/users/fayejf/gists{/gist_id}", "starred_url": "https://api.github.com/users/fayejf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fayejf/subscriptions", "organizations_url": "https://api.github.com/users/fayejf/orgs", "repos_url": "https://api.github.com/users/fayejf/repos", "events_url": "https://api.github.com/users/fayejf/events{/privacy}", "received_events_url": "https://api.github.com/users/fayejf/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2197/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2197/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2196
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2196/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2196/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2196/events
https://github.com/NVIDIA/NeMo/pull/2196
888,652,851
MDExOlB1bGxSZXF1ZXN0NjQxODI4MzQ0
2,196
Store mappings file in .nemo for FS2 model
{ "login": "redoctopus", "id": 4268876, "node_id": "MDQ6VXNlcjQyNjg4NzY=", "avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4", "gravatar_id": "", "url": "https://api.github.com/users/redoctopus", "html_url": "https://github.com/redoctopus", "followers_url": "https://api.github.com/users/redoctopus/followers", "following_url": "https://api.github.com/users/redoctopus/following{/other_user}", "gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}", "starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions", "organizations_url": "https://api.github.com/users/redoctopus/orgs", "repos_url": "https://api.github.com/users/redoctopus/repos", "events_url": "https://api.github.com/users/redoctopus/events{/privacy}", "received_events_url": "https://api.github.com/users/redoctopus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-11T21:05:28
2021-05-11T22:32:22
2021-05-11T22:32:19
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2196", "html_url": "https://github.com/NVIDIA/NeMo/pull/2196", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2196.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2196.patch", "merged_at": "2021-05-11T22:32:19" }
Update the model code to save the mappings file as an artifact in the checkpoint file. Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
{ "login": "redoctopus", "id": 4268876, "node_id": "MDQ6VXNlcjQyNjg4NzY=", "avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4", "gravatar_id": "", "url": "https://api.github.com/users/redoctopus", "html_url": "https://github.com/redoctopus", "followers_url": "https://api.github.com/users/redoctopus/followers", "following_url": "https://api.github.com/users/redoctopus/following{/other_user}", "gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}", "starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions", "organizations_url": "https://api.github.com/users/redoctopus/orgs", "repos_url": "https://api.github.com/users/redoctopus/repos", "events_url": "https://api.github.com/users/redoctopus/events{/privacy}", "received_events_url": "https://api.github.com/users/redoctopus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2196/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2196/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2195
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2195/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2195/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2195/events
https://github.com/NVIDIA/NeMo/pull/2195
888,127,964
MDExOlB1bGxSZXF1ZXN0NjQxMzIyNDc0
2,195
Fix text processing docs
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "+ please run tests in an env that does not have pynini installed to ensure pytest tests/ --cpu is runnable " ]
2021-05-11T18:25:09
2021-05-12T21:23:01
2021-05-12T21:22:58
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2195", "html_url": "https://github.com/NVIDIA/NeMo/pull/2195", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2195.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2195.patch", "merged_at": "2021-05-12T21:22:58" }
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2195/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2195/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2194
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2194/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2194/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2194/events
https://github.com/NVIDIA/NeMo/pull/2194
888,050,526
MDExOlB1bGxSZXF1ZXN0NjQxMjQ4MzM2
2,194
NMT fixes
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-11T17:58:55
2021-05-11T21:17:36
2021-05-11T21:17:28
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2194", "html_url": "https://github.com/NVIDIA/NeMo/pull/2194", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2194.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2194.patch", "merged_at": "2021-05-11T21:17:28" }
* Allow models such as facebook/bart-large in NMT encoder * Fixes in nmt webapp
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2194/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2194/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2193
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2193/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2193/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2193/events
https://github.com/NVIDIA/NeMo/pull/2193
885,433,944
MDExOlB1bGxSZXF1ZXN0NjM4NzU4MDAy
2,193
Add support to change the SE context window of ConvASREncoder
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-11T00:13:07
2021-05-12T00:39:25
2021-05-12T00:39:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2193", "html_url": "https://github.com/NVIDIA/NeMo/pull/2193", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2193.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2193.patch", "merged_at": "2021-05-12T00:39:22" }
# Changelog - Adds the support to change the SqueezeExcite context window post instantiation inside a given ConvASREncoder module. - Adds tests to ensure the model updates the configs and changes the modules SE behaviour # Usage ```python model = ASRModel.from_pretrained("stt_en_citrinet_256") model.change_conv_asr_se_context_window(context_window=128, update_config=True) # equivalent to 128 * 0.01s of context ```
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2193/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2193/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2192
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2192/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2192/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2192/events
https://github.com/NVIDIA/NeMo/issues/2192
885,365,228
MDU6SXNzdWU4ODUzNjUyMjg=
2,192
Unable to export PyTorch .pt file from biomegatron .nemo model
{ "login": "flawaetz", "id": 1516944, "node_id": "MDQ6VXNlcjE1MTY5NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1516944?v=4", "gravatar_id": "", "url": "https://api.github.com/users/flawaetz", "html_url": "https://github.com/flawaetz", "followers_url": "https://api.github.com/users/flawaetz/followers", "following_url": "https://api.github.com/users/flawaetz/following{/other_user}", "gists_url": "https://api.github.com/users/flawaetz/gists{/gist_id}", "starred_url": "https://api.github.com/users/flawaetz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/flawaetz/subscriptions", "organizations_url": "https://api.github.com/users/flawaetz/orgs", "repos_url": "https://api.github.com/users/flawaetz/repos", "events_url": "https://api.github.com/users/flawaetz/events{/privacy}", "received_events_url": "https://api.github.com/users/flawaetz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api...
null
[ "What are you trying to accomplish? a) just to extract .pt from .nemo or b) export the model to Torchscript ? \r\nIf a): then simply use 'tar xvf model.nemo'\r\nIf b): Megatron model currently is not exportable to Torchscript. You can export it to ONNX though by supplying name with .onnx extension to export()\r\n",...
2021-05-10T23:34:11
2021-05-18T01:15:04
2021-05-18T01:15:04
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** When trying to do a `model.export()` of `qa_squadv2.0_megatron_uncased` nemo model I get `RuntimeError: Could not export Python function call '_ReduceFromModelParallelRegion'` **Steps/Code to reproduce bug** ``` wget --content-disposition https://api.ngc.nvidia.com/v2/models/nvidia/nemo/qa_squadv2_0_megatron_uncased/versions/1.0.0rc1/zip -O qa_squadv2_0_megatron_uncased_1.0.0rc1.zip import nemo import nemo.collections.nlp as nemo_nlp model = nemo_nlp.models.question_answering.qa_model.QAModel.from_pretrained(model_name="qa_squadv2.0_megatron_uncased") model.export('/QA.pt') ``` **Expected behavior** The nemo model should be exported as a PyTorch .pt model. **Environment overview (please complete the following information)** - Environment location: AWS Running in docker container `nvcr.io/nvidia/pytorch:21.04-py3` with nemo installed via `python -m pip install git+https://github.com/NVIDIA/NeMo.git@main#egg=nemo_toolkit[all]` The last section of output is: ``` [NeMo W 2021-05-10 23:12:08 megatron_bert:185] Megatron-lm checkpoint version not found. Setting checkpoint_version to 0. [NeMo I 2021-05-10 23:12:08 megatron_bert:193] Checkpoint loaded from from /root/.cache/torch/megatron/megatron-bert-345m-uncased [NeMo I 2021-05-10 23:12:11 modelPT:434] Model QAModel was successfully restored from /root/.cache/torch/NeMo/NeMo_1.0.0/qa_squadv2.0_megatron_uncased/747e4a01f09deb5e4269b1b36cfa4d8e/qa_squadv2.0_megatron_uncased.nemo. >>> model.export('/foo.pt') [NeMo W 2021-05-10 23:12:48 export_utils:198] Swapped 49 modules > initializing torch distributed ... > initializing tensor model parallel with size 1 > initializing pipeline model parallel with size 1 > setting random seeds to 1234 ... > initializing model parallel cuda seeds on global rank 0, model parallel rank 0, and data parallel rank 0 with model parallel seed: 3952 and data parallel seed: 1234 [NeMo W 2021-05-10 23:12:49 nemo_logging:349] /opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py:720: UserWarning: `optimize` is deprecated and has no effect. Use `with torch.jit.optimized_execution() instead warnings.warn( [NeMo W 2021-05-10 23:12:53 nemo_logging:349] /opt/conda/lib/python3.8/site-packages/megatron/mpu/utils.py:22: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs! assert numerator % denominator == 0, '{} is not divisible by {}'.format( [NeMo W 2021-05-10 23:12:53 nemo_logging:349] /opt/conda/lib/python3.8/site-packages/torch/_tensor.py:565: UserWarning: floor_divide is deprecated, and will be removed in a future version of pytorch. It currently rounds toward 0 (like the 'trunc' function NOT 'floor'). This results in incorrect rounding for negative values. To keep the current behavior, use torch.div(a, b, rounding_mode='trunc'), or for actual floor division, use torch.div(a, b, rounding_mode='floor'). (Triggered internally at ../aten/src/ATen/native/BinaryOps.cpp:335.) return torch.floor_divide(self, other) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/opt/conda/lib/python3.8/site-packages/nemo/core/classes/exportable.py", line 194, in export jitted_model.save(output) File "/opt/conda/lib/python3.8/site-packages/torch/jit/_script.py", line 495, in save return self._c.save(str(f), **kwargs) RuntimeError: Could not export Python function call '_ReduceFromModelParallelRegion'. Remove calls to Python functions before export. Did you forget to add @script or @script_method annotation? If this is a nn.ModuleList, add it to __constants__: /opt/conda/lib/python3.8/site-packages/megatron/mpu/mappings.py(149): reduce_from_tensor_model_parallel_region /opt/conda/lib/python3.8/site-packages/megatron/mpu/layers.py(191): forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1003): _slow_forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1015): _call_impl /opt/conda/lib/python3.8/site-packages/megatron/model/language_model.py(183): forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1003): _slow_forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1015): _call_impl /opt/conda/lib/python3.8/site-packages/megatron/model/language_model.py(321): forward /opt/conda/lib/python3.8/site-packages/megatron/model/language_model.py(414): forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1003): _slow_forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1015): _call_impl /opt/conda/lib/python3.8/site-packages/nemo/collections/nlp/modules/common/megatron/megatron_bert.py(163): forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1003): _slow_forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1015): _call_impl /opt/conda/lib/python3.8/site-packages/nemo/collections/nlp/models/question_answering/qa_model.py(81): forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1003): _slow_forward /opt/conda/lib/python3.8/site-packages/torch/nn/modules/module.py(1015): _call_impl /opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(950): trace_module /opt/conda/lib/python3.8/site-packages/torch/jit/_trace.py(733): trace /opt/conda/lib/python3.8/site-packages/nemo/core/classes/exportable.py(184): export <stdin>(1): <module> ```
{ "login": "flawaetz", "id": 1516944, "node_id": "MDQ6VXNlcjE1MTY5NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1516944?v=4", "gravatar_id": "", "url": "https://api.github.com/users/flawaetz", "html_url": "https://github.com/flawaetz", "followers_url": "https://api.github.com/users/flawaetz/followers", "following_url": "https://api.github.com/users/flawaetz/following{/other_user}", "gists_url": "https://api.github.com/users/flawaetz/gists{/gist_id}", "starred_url": "https://api.github.com/users/flawaetz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/flawaetz/subscriptions", "organizations_url": "https://api.github.com/users/flawaetz/orgs", "repos_url": "https://api.github.com/users/flawaetz/repos", "events_url": "https://api.github.com/users/flawaetz/events{/privacy}", "received_events_url": "https://api.github.com/users/flawaetz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2192/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2192/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2190
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2190/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2190/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2190/events
https://github.com/NVIDIA/NeMo/pull/2190
885,173,083
MDExOlB1bGxSZXF1ZXN0NjM4NTA4MTk1
2,190
Fix nodesplitter of webdataset.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "LGTM." ]
2021-05-10T21:42:16
2021-08-06T08:01:24
2021-05-11T00:28:10
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2190", "html_url": "https://github.com/NVIDIA/NeMo/pull/2190", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2190.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2190.patch", "merged_at": "2021-05-11T00:28:10" }
Set the nodessplitter param of webdataset to None as the default is True in their latest code.
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2190/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2190/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2189
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2189/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2189/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2189/events
https://github.com/NVIDIA/NeMo/pull/2189
884,262,229
MDExOlB1bGxSZXF1ZXN0NjM3NjU5NDEw
2,189
Add TTS aligner and improved version of g2p for vocabs.Phonemes, small improvement in TalkNet
{ "login": "Oktai15", "id": 17337773, "node_id": "MDQ6VXNlcjE3MzM3Nzcz", "avatar_url": "https://avatars.githubusercontent.com/u/17337773?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Oktai15", "html_url": "https://github.com/Oktai15", "followers_url": "https://api.github.com/users/Oktai15/followers", "following_url": "https://api.github.com/users/Oktai15/following{/other_user}", "gists_url": "https://api.github.com/users/Oktai15/gists{/gist_id}", "starred_url": "https://api.github.com/users/Oktai15/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Oktai15/subscriptions", "organizations_url": "https://api.github.com/users/Oktai15/orgs", "repos_url": "https://api.github.com/users/Oktai15/repos", "events_url": "https://api.github.com/users/Oktai15/events{/privacy}", "received_events_url": "https://api.github.com/users/Oktai15/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging a5b2e9be03ccadfd608d829ab10809af788c0a2f into b44a1077df4579ecdba9a5386fbfe2c0bcd20667 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-2d1e71128b7ca228053fb661556cd8f6fede1c7f)\n\n**new alerts:**\n\n* 1 for Unused import" ]
2021-05-10T13:46:46
2021-05-11T06:17:14
2021-05-10T22:15:10
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2189", "html_url": "https://github.com/NVIDIA/NeMo/pull/2189", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2189.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2189.patch", "merged_at": "2021-05-10T22:15:10" }
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2189/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2189/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2188
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2188/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2188/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2188/events
https://github.com/NVIDIA/NeMo/issues/2188
881,134,106
MDU6SXNzdWU4ODExMzQxMDY=
2,188
Training does not work with Google Colab TPUs - ZeroDivisionError
{ "login": "piraka9011", "id": 16828657, "node_id": "MDQ6VXNlcjE2ODI4NjU3", "avatar_url": "https://avatars.githubusercontent.com/u/16828657?v=4", "gravatar_id": "", "url": "https://api.github.com/users/piraka9011", "html_url": "https://github.com/piraka9011", "followers_url": "https://api.github.com/users/piraka9011/followers", "following_url": "https://api.github.com/users/piraka9011/following{/other_user}", "gists_url": "https://api.github.com/users/piraka9011/gists{/gist_id}", "starred_url": "https://api.github.com/users/piraka9011/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/piraka9011/subscriptions", "organizations_url": "https://api.github.com/users/piraka9011/orgs", "repos_url": "https://api.github.com/users/piraka9011/repos", "events_url": "https://api.github.com/users/piraka9011/events{/privacy}", "received_events_url": "https://api.github.com/users/piraka9011/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "I'm not too familiar with the internals of PTL, but I'm guessing the solution is to determine whether there are GPUs _or_ TPUs and not _just_ GPUs.", "We don't support TPU training, and it's not tested. If you get it working, please let us know. ", "looks like you can try disabling learning rate scheduler. but...
2021-05-08T18:13:51
2021-05-10T22:18:39
2021-05-10T22:18:39
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** Training any model does not work with TPUs due to an error with the way `modelPT.py` calculates `optim_config['sched']['t_num_workers']` [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/core/classes/modelPT.py#L649). When you have 0 GPUs, but are still using TPUs, `t_num_workers` is 0. This causes a division by zero error [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/core/optim/lr_scheduler.py#L646). ``` Exception in device=TPU:0: division by zero Traceback (most recent call last): File "/usr/local/lib/python3.7/dist-packages/torch_xla/distributed/xla_multiprocessing.py", line 330, in _mp_start_fn _start_fn(index, pf_cfg, fn, args) File "/usr/local/lib/python3.7/dist-packages/torch_xla/distributed/xla_multiprocessing.py", line 324, in _start_fn fn(gindex, *args) File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/accelerators/tpu_accelerator.py", line 135, in tpu_train_in_process self.__setup_tpu_training(model, trainer) File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/accelerators/tpu_accelerator.py", line 222, in __setup_tpu_training self.setup_optimizers(model) File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/accelerators/accelerator.py", line 150, in setup_optimizers optimizers, lr_schedulers, optimizer_frequencies = self.trainer.init_optimizers(model) File "/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/optimizers.py", line 31, in init_optimizers optim_conf = model.configure_optimizers() File "/usr/local/lib/python3.7/dist-packages/nemo/core/classes/modelPT.py", line 699, in configure_optimizers self.setup_optimization() File "/usr/local/lib/python3.7/dist-packages/nemo/core/classes/modelPT.py", line 691, in setup_optimization optimizer=self._optimizer, scheduler_config=scheduler_config, train_dataloader=self._train_dl File "/usr/local/lib/python3.7/dist-packages/nemo/core/optim/lr_scheduler.py", line 596, in prepare_lr_scheduler drop_last=drop_last, File "/usr/local/lib/python3.7/dist-packages/nemo/core/optim/lr_scheduler.py", line 646, in compute_max_steps sampler_num_samples = math.ceil(num_samples / num_workers) ZeroDivisionError: division by zero ``` **Steps/Code to reproduce bug** Follow any colab with TPU support and set `trainer.tpu_cores=8` in the config. ``` from hydra.experimental import compose, initialize import pytorch_lightning as pl from omegaconf import OmegaConf from nemo.collections.asr.models import EncDecCTCModel from nemo.core.config import hydra_runner from nemo.utils import logging from nemo.utils.exp_manager import exp_manager with initialize(config_path="configs"): cfg = compose(config_name="config") print(f'Hydra config: {OmegaConf.to_yaml(cfg)}') trainer = pl.Trainer(**cfg.trainer) exp_manager(trainer, cfg.get("exp_manager", None)) asr_model = EncDecCTCModel(cfg=cfg.model, trainer=trainer) trainer.fit(asr_model) ``` **Expected behavior** Training works. **Environment overview (please complete the following information)** - Environment location: Colab - Method of NeMo install: `pip install nemo_toolkit['all']==1.0.0rc1` **Environment details** Otherwise, please provide: - OS version: Debian ? Not sure what colab runs - PyTorch version: 1.7 - Python version: 3.7 **Additional context** Installed PyTorch XLA using: ``` pip install cloud-tpu-client==0.10 https://storage.googleapis.com/tpu-pytorch/wheels/torch_xla-1.7-cp37-cp37m-linux_x86_64.whl pip install pytorch-lightning ```
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2188/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2187
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2187/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2187/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2187/events
https://github.com/NVIDIA/NeMo/pull/2187
880,520,713
MDExOlB1bGxSZXF1ZXN0NjM0MTczNzcz
2,187
SDE updates
{ "login": "vsl9", "id": 4344862, "node_id": "MDQ6VXNlcjQzNDQ4NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/4344862?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vsl9", "html_url": "https://github.com/vsl9", "followers_url": "https://api.github.com/users/vsl9/followers", "following_url": "https://api.github.com/users/vsl9/following{/other_user}", "gists_url": "https://api.github.com/users/vsl9/gists{/gist_id}", "starred_url": "https://api.github.com/users/vsl9/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vsl9/subscriptions", "organizations_url": "https://api.github.com/users/vsl9/orgs", "repos_url": "https://api.github.com/users/vsl9/repos", "events_url": "https://api.github.com/users/vsl9/events{/privacy}", "received_events_url": "https://api.github.com/users/vsl9/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-08T08:46:27
2022-01-11T16:37:03
2021-05-10T20:28:58
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2187", "html_url": "https://github.com/NVIDIA/NeMo/pull/2187", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2187.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2187.patch", "merged_at": "2021-05-10T20:28:58" }
- added support for external vocabularies - UI improvements - refactored code
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2187/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2187/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2186
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2186/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2186/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2186/events
https://github.com/NVIDIA/NeMo/issues/2186
880,510,071
MDU6SXNzdWU4ODA1MTAwNzE=
2,186
Proper data (size & form) for fine-tunining speaker verification model
{ "login": "JINHXu", "id": 36717127, "node_id": "MDQ6VXNlcjM2NzE3MTI3", "avatar_url": "https://avatars.githubusercontent.com/u/36717127?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JINHXu", "html_url": "https://github.com/JINHXu", "followers_url": "https://api.github.com/users/JINHXu/followers", "following_url": "https://api.github.com/users/JINHXu/following{/other_user}", "gists_url": "https://api.github.com/users/JINHXu/gists{/gist_id}", "starred_url": "https://api.github.com/users/JINHXu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JINHXu/subscriptions", "organizations_url": "https://api.github.com/users/JINHXu/orgs", "repos_url": "https://api.github.com/users/JINHXu/repos", "events_url": "https://api.github.com/users/JINHXu/events{/privacy}", "received_events_url": "https://api.github.com/users/JINHXu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https:...
null
[ "It's better to have higher number_of_samples/speaker with shorter durations (of about 4 sec) than vice versa. ", "Hi, @nithinraok Thank you!" ]
2021-05-08T08:36:40
2021-05-28T08:39:41
2021-05-28T08:39:41
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hey there, I was trying to fine-tune the pre-trained speaker recognition model [`Speakernet`](https://ngc.nvidia.com/catalog/models/nvidia:nemo:speakerrecognition_speakernet) in order for it to recognize our registered speakers. I noticed in the tutorials the dataset `an4` was only used for illustration purposes, I wonder in real cases, how much data would be considered reasonable for fine-tuning? For example, in our system, we have about 15 registered users, whose voice would need to be recognized through about 4 seconds of speech for inference. Would it be enough to fine-tune with 20 recordings of about 5 seconds of each user's speech? Or might it be a better idea to try to gather the long speech of the users (10 recordings of 30 seconds speech for instance)? Thank you for your help in advance! Cheers, Xu
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2186/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2186/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2185
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2185/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2185/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2185/events
https://github.com/NVIDIA/NeMo/issues/2185
880,203,990
MDU6SXNzdWU4ODAyMDM5OTA=
2,185
requirements.txt should limit pytorch-lightning to 1.2.10 (max), avoiding 1.3.* for now
{ "login": "jprobichaud", "id": 9254379, "node_id": "MDQ6VXNlcjkyNTQzNzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9254379?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jprobichaud", "html_url": "https://github.com/jprobichaud", "followers_url": "https://api.github.com/users/jprobichaud/followers", "following_url": "https://api.github.com/users/jprobichaud/following{/other_user}", "gists_url": "https://api.github.com/users/jprobichaud/gists{/gist_id}", "starred_url": "https://api.github.com/users/jprobichaud/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jprobichaud/subscriptions", "organizations_url": "https://api.github.com/users/jprobichaud/orgs", "repos_url": "https://api.github.com/users/jprobichaud/repos", "events_url": "https://api.github.com/users/jprobichaud/events{/privacy}", "received_events_url": "https://api.github.com/users/jprobichaud/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "This should be fixed via https://github.com/NVIDIA/NeMo/pull/2178" ]
2021-05-08T03:44:37
2021-05-10T17:38:26
2021-05-10T17:38:26
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Some interface changes in 1.3.0 (at least around pl.ModelCheckpoint), breaks some expectation in the current code base. `requirements/requirements.txt` has `pytorch-lightning>=1.2.8` which could lead the installation of pytorch-lightning 1.3.0. Or aybe you are already planning on supporting 1.3.0?
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2185/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2185/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2184
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2184/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2184/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2184/events
https://github.com/NVIDIA/NeMo/pull/2184
879,933,079
MDExOlB1bGxSZXF1ZXN0NjMzNjE5MzQw
2,184
Change label smoothing prob to reduce chance of test failure
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-07T23:34:39
2021-05-08T05:57:31
2021-05-08T04:08:41
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2184", "html_url": "https://github.com/NVIDIA/NeMo/pull/2184", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2184.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2184.patch", "merged_at": "2021-05-08T04:08:41" }
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2184/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2183
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2183/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2183/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2183/events
https://github.com/NVIDIA/NeMo/pull/2183
879,907,719
MDExOlB1bGxSZXF1ZXN0NjMzNTk1MzI0
2,183
Increase label smoothing to reduce chance of test failing
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-07T23:12:56
2022-09-22T17:08:23
2021-05-07T23:31:36
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2183", "html_url": "https://github.com/NVIDIA/NeMo/pull/2183", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2183.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2183.patch", "merged_at": null }
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2183/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2183/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2182
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2182/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2182/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2182/events
https://github.com/NVIDIA/NeMo/issues/2182
879,668,502
MDU6SXNzdWU4Nzk2Njg1MDI=
2,182
Incorporation of Language Model with CitriNet
{ "login": "snaaz21", "id": 28730512, "node_id": "MDQ6VXNlcjI4NzMwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/28730512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/snaaz21", "html_url": "https://github.com/snaaz21", "followers_url": "https://api.github.com/users/snaaz21/followers", "following_url": "https://api.github.com/users/snaaz21/following{/other_user}", "gists_url": "https://api.github.com/users/snaaz21/gists{/gist_id}", "starred_url": "https://api.github.com/users/snaaz21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/snaaz21/subscriptions", "organizations_url": "https://api.github.com/users/snaaz21/orgs", "repos_url": "https://api.github.com/users/snaaz21/repos", "events_url": "https://api.github.com/users/snaaz21/events{/privacy}", "received_events_url": "https://api.github.com/users/snaaz21/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
true
null
[]
null
[ "Librispeech KenLM should be built on concatenated datasets of entire Librispeech lm text corpus (after normalization to lower case) + the 3 train transcripts. Overall it should be close to 41 M lines of text rather than the 300k lines of text here. \r\n\r\nSecondly, this sentence is confusing - \"However I got hig...
2021-05-07T20:12:08
2021-05-10T22:16:19
2021-05-10T22:16:18
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi, I trained a Language Model with [train_kenlm.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/train_kenlm.py) (**6-gram** with **286967 l**ines of text collected from LibriSpeech's train_clean_100, train_clean_360, train_other_500 and some other standard English text lines). Results of counting: ` === 1/5 Counting and sorting n-grams === Reading /home/lang_model/model.tmp.txt ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 Unigram tokens 16718614 types 937 === 2/5 Calculating and sorting adjusted counts === Chain sizes: 1:11244 2:822115520 3:1541466624 4:2466346752 5:3596755712 6:4932693504 Substituting fallback discounts for order 0: D1=0.5 D2=1 D3+=1.5 Statistics: 1 937 D1=0.5 D2=1 D3+=1.5 2 287721 D1=0.506285 D2=1.04345 D3+=1.59677 3 3215127 D1=0.697273 D2=1.12271 D3+=1.48872 4 8173916 D1=0.82992 D2=1.20302 D3+=1.43574 5 11728534 D1=0.908197 D2=1.24826 D3+=1.3993 6 13666388 D1=0.918745 D2=1.31875 D3+=1.46753 Memory estimate for binary LM: type MB probing 770 assuming -p 1.5 probing 904 assuming -r models -p 1.5 trie 337 without quantization trie 168 assuming -q 8 -b 8 quantization trie 291 assuming -a 22 array pointer compression trie 122 assuming -a 22 -q 8 -b 8 array pointer compression and quantization === 3/5 Calculating and sorting initial probabilities === Chain sizes: 1:11244 2:4603536 3:64302540 4:196173984 5:328398952 6:437324416 ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 #################################################################################################### === 4/5 Calculating and writing order-interpolated probabilities === Chain sizes: 1:11244 2:4603536 3:64302540 4:196173984 5:328398952 6:437324416 ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 #################################################################################################### === 5/5 Writing ARPA model === ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 Name:lmplz VmPeak:13261380 kB VmRSS:11264 kB RSSMax:2523692 kB user:25.2489 sys:5.2742 CPU:30.5231 real:19.9458 [NeMo I 2021-05-07 01:48:58 train_kenlm:135] Running binary_build command /home/lang_model/kenlm/build/bin/lmplz -o 6 --text /home/lang_model/model.tmp.txt --arpa /home/lang_model/model.tmp.arpa --discount_fallback Reading /home/lang_model/model.tmp.arpa ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 Identifying n-grams omitted by SRI ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 Writing trie ----5---10---15---20---25---30---35---40---45---50---55---60---65---70---75---80---85---90---95--100 vin SUCCESS ` Language model is trained without any error and in evaluation using [eval_beamsearch_ngram.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram.py), I got better WER i.e. **2.61% on Dev_clean and 6.27% on Dev_other by alpha=1.0 and beta=1.0.** However I got higher WER using LM i.e. approx 16.4% as compared to 3.4% WER using only CitriNet without LM on my audios. When I saw the predicted output I found that some consecutive words are missing, hence WER is high. One of the examples is given below: ` **Ground truth:** " hello welcome how can i help you today eh what kind of **products you** guys make sorry i **couldn't this can please help me with more** i recently here purchase reflects three dot o from one of the stores and this product is not behaving" **Predicted output:** "hello welcome how can i help you today what kind of guys make sorry i recently purchase reflects three doo from one of the stores and this product is not behaving" ` In the above example you can see bold text is missing in the predicted output, this is the output on choosing beam_alpha=1.0 and beam_beta=1.0. And there is lot of variations in output for missing words by just changing alpha and beta values. Why the words are missing in the prediction and how to decide the right alpha and beta values? @EmreOzkose did you face the same?
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2182/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2181
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2181/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2181/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2181/events
https://github.com/NVIDIA/NeMo/pull/2181
879,648,515
MDExOlB1bGxSZXF1ZXN0NjMzMzUyNTg5
2,181
Add FS2 checkpoint links to docs and inference notebook
{ "login": "redoctopus", "id": 4268876, "node_id": "MDQ6VXNlcjQyNjg4NzY=", "avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4", "gravatar_id": "", "url": "https://api.github.com/users/redoctopus", "html_url": "https://github.com/redoctopus", "followers_url": "https://api.github.com/users/redoctopus/followers", "following_url": "https://api.github.com/users/redoctopus/following{/other_user}", "gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}", "starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions", "organizations_url": "https://api.github.com/users/redoctopus/orgs", "repos_url": "https://api.github.com/users/redoctopus/repos", "events_url": "https://api.github.com/users/redoctopus/events{/privacy}", "received_events_url": "https://api.github.com/users/redoctopus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-07T19:59:34
2021-05-10T14:21:03
2021-05-10T14:21:01
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2181", "html_url": "https://github.com/NVIDIA/NeMo/pull/2181", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2181.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2181.patch", "merged_at": "2021-05-10T14:21:01" }
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2181/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2181/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2180
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2180/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2180/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2180/events
https://github.com/NVIDIA/NeMo/pull/2180
879,562,174
MDExOlB1bGxSZXF1ZXN0NjMzMjcxODY2
2,180
Acc tn
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging bc2cdec3c9e9767af3ef755a8160db979f572d59 into d9aab777c4954d13ae95d8b71ef08de65c947f5c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-30686a7b465ee52e9ed5f4017a818b2b8d5eb153)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull reque...
2021-05-07T19:04:37
2021-05-07T21:50:39
2021-05-07T21:50:36
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2180", "html_url": "https://github.com/NVIDIA/NeMo/pull/2180", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2180.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2180.patch", "merged_at": "2021-05-07T21:50:36" }
improved cardinal in textnormalization in terms of perf
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2180/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2180/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2179
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2179/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2179/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2179/events
https://github.com/NVIDIA/NeMo/pull/2179
879,405,240
MDExOlB1bGxSZXF1ZXN0NjMzMTI1NDYz
2,179
fix typo
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-07T17:29:49
2021-05-07T17:45:55
2021-05-07T17:45:52
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2179", "html_url": "https://github.com/NVIDIA/NeMo/pull/2179", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2179.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2179.patch", "merged_at": "2021-05-07T17:45:52" }
Signed-off-by: Yang Zhang <yangzhang@nvidia.com>
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2179/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2179/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2178
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2178/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2178/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2178/events
https://github.com/NVIDIA/NeMo/pull/2178
879,303,348
MDExOlB1bGxSZXF1ZXN0NjMzMDMxOTcw
2,178
Update ptl to 1.3 on main branch
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging 1c2ead52bc3b9c67f46f46636b31a0fc01a39935 into b44a1077df4579ecdba9a5386fbfe2c0bcd20667 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-49f72b46b780b693b22b9ea54e2714adcf6aa8e4)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull reque...
2021-05-07T16:22:37
2021-05-10T17:37:47
2021-05-10T17:37:26
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2178", "html_url": "https://github.com/NVIDIA/NeMo/pull/2178", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2178.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2178.patch", "merged_at": "2021-05-10T17:37:26" }
# Changelog - Update PTL to 1.3 - Fix related broken tests in NeMo
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2178/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2178/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2177
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2177/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2177/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2177/events
https://github.com/NVIDIA/NeMo/pull/2177
879,018,956
MDExOlB1bGxSZXF1ZXN0NjMyNzc1MDkw
2,177
[docs] variable name error in text to sound example in docs
{ "login": "tarun-bisht", "id": 47741102, "node_id": "MDQ6VXNlcjQ3NzQxMTAy", "avatar_url": "https://avatars.githubusercontent.com/u/47741102?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tarun-bisht", "html_url": "https://github.com/tarun-bisht", "followers_url": "https://api.github.com/users/tarun-bisht/followers", "following_url": "https://api.github.com/users/tarun-bisht/following{/other_user}", "gists_url": "https://api.github.com/users/tarun-bisht/gists{/gist_id}", "starred_url": "https://api.github.com/users/tarun-bisht/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tarun-bisht/subscriptions", "organizations_url": "https://api.github.com/users/tarun-bisht/orgs", "repos_url": "https://api.github.com/users/tarun-bisht/repos", "events_url": "https://api.github.com/users/tarun-bisht/events{/privacy}", "received_events_url": "https://api.github.com/users/tarun-bisht/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Thanks for noticing this bug. I'll fix this in #2166 ", "Oh, it looks like someone already fixed it. We will fix this in the upcoming 1.0 release." ]
2021-05-07T13:36:28
2021-05-07T14:35:54
2021-05-07T14:35:08
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2177", "html_url": "https://github.com/NVIDIA/NeMo/pull/2177", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2177.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2177.patch", "merged_at": null }
variable name `spec_gen` was used for parsing text and creating spectogram, which should be `spec_generator`
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2177/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2177/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2176
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2176/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2176/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2176/events
https://github.com/NVIDIA/NeMo/issues/2176
878,945,741
MDU6SXNzdWU4Nzg5NDU3NDE=
2,176
BeamSearchDecoderWithLM Memory Requirement
{ "login": "ulucsahin", "id": 22548197, "node_id": "MDQ6VXNlcjIyNTQ4MTk3", "avatar_url": "https://avatars.githubusercontent.com/u/22548197?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ulucsahin", "html_url": "https://github.com/ulucsahin", "followers_url": "https://api.github.com/users/ulucsahin/followers", "following_url": "https://api.github.com/users/ulucsahin/following{/other_user}", "gists_url": "https://api.github.com/users/ulucsahin/gists{/gist_id}", "starred_url": "https://api.github.com/users/ulucsahin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ulucsahin/subscriptions", "organizations_url": "https://api.github.com/users/ulucsahin/orgs", "repos_url": "https://api.github.com/users/ulucsahin/repos", "events_url": "https://api.github.com/users/ulucsahin/events{/privacy}", "received_events_url": "https://api.github.com/users/ulucsahin/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "If it's the KenLM binary causing the memory issue, then a smaller N-gram can be used. However we don't have much control over the c++ swig decoders so from our side there isn't a sufficient solution to reduce memory. Maybe @vsl9 has some ideas?", "If the memory issue is from the beam search decoder, then you may...
2021-05-07T12:50:17
2021-05-28T08:37:02
2021-05-28T08:37:02
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hello, I am using an n-gram KenLM (my language model is only 67 MBs) with BeamSearchDecoderWithLM. Scorer class inside BeamSearchDecoderWithLM which is imported from swig_decoders is using 2.3 gb of ram. I was wondering if there is anything I can do to reduce this memory requirement? I am trying to run this on a device with low memory and I am running out of memory during the initialization of BeamSearchDecoderWithLM. Is there any alternatives to Scorer that I can swap? I'm okay with it performing worse as long as memory requirements are reduced. Thanks.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2176/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2175
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2175/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2175/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2175/events
https://github.com/NVIDIA/NeMo/pull/2175
878,428,911
MDExOlB1bGxSZXF1ZXN0NjMyMjYwNzgx
2,175
Enabled passing kwargs to export()
{ "login": "borisfom", "id": 14189615, "node_id": "MDQ6VXNlcjE0MTg5NjE1", "avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4", "gravatar_id": "", "url": "https://api.github.com/users/borisfom", "html_url": "https://github.com/borisfom", "followers_url": "https://api.github.com/users/borisfom/followers", "following_url": "https://api.github.com/users/borisfom/following{/other_user}", "gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}", "starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/borisfom/subscriptions", "organizations_url": "https://api.github.com/users/borisfom/orgs", "repos_url": "https://api.github.com/users/borisfom/repos", "events_url": "https://api.github.com/users/borisfom/events{/privacy}", "received_events_url": "https://api.github.com/users/borisfom/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "> exortable changes look good to me. @blisc what about tts changes?\r\n\r\ntts changes are to conform to new extended syntax accepted by onnx.export (optional Dict as the last input tuple element, representing kwargs) instead of former non-standard extended syntax I briefly introduced in previous revision (accepti...
2021-05-07T04:16:52
2021-05-17T13:30:17
2021-05-17T13:30:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2175", "html_url": "https://github.com/NVIDIA/NeMo/pull/2175", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2175.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2175.patch", "merged_at": "2021-05-17T13:30:17" }
Also, removed previous (non–functional) extension for dicts in export - this schema matches what onnx.export expects. Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2175/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2175/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2174
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2174/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2174/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2174/events
https://github.com/NVIDIA/NeMo/pull/2174
878,328,068
MDExOlB1bGxSZXF1ZXN0NjMyMTcwNjgy
2,174
Fix to always_save_nemo
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-07T02:09:03
2021-05-07T17:45:15
2021-05-07T17:45:12
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2174", "html_url": "https://github.com/NVIDIA/NeMo/pull/2174", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2174.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2174.patch", "merged_at": "2021-05-07T17:45:12" }
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2174/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2174/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2173
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2173/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2173/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2173/events
https://github.com/NVIDIA/NeMo/pull/2173
878,253,170
MDExOlB1bGxSZXF1ZXN0NjMyMTA0MDQ4
2,173
Make itn tests optional
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-07T00:46:25
2021-05-07T18:30:16
2021-05-07T18:12:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2173", "html_url": "https://github.com/NVIDIA/NeMo/pull/2173", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2173.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2173.patch", "merged_at": "2021-05-07T18:12:09" }
# Bugfix - Make all ITN tests optional (will run only if installed)
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2173/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2173/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2171
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2171/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2171/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2171/events
https://github.com/NVIDIA/NeMo/pull/2171
878,211,101
MDExOlB1bGxSZXF1ZXN0NjMyMDY2MjY3
2,171
add more alternatives of 0 for telephone
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T23:53:01
2021-05-07T20:16:15
2021-05-07T20:16:10
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2171", "html_url": "https://github.com/NVIDIA/NeMo/pull/2171", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2171.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2171.patch", "merged_at": "2021-05-07T20:16:10" }
addressing https://github.com/NVIDIA/NeMo/issues/2161
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2171/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2171/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2170
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2170/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2170/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2170/events
https://github.com/NVIDIA/NeMo/pull/2170
878,144,456
MDExOlB1bGxSZXF1ZXN0NjMyMDA0ODU3
2,170
Restrict ptl version for 1.0 release
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T22:46:02
2021-05-07T00:10:03
2021-05-06T23:49:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2170", "html_url": "https://github.com/NVIDIA/NeMo/pull/2170", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2170.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2170.patch", "merged_at": "2021-05-06T23:49:06" }
# Changelog - Upper bounds PTL version to 1.2.10 for main branch Signed-off-by: smajumdar <titu1994@gmail.com>
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2170/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2170/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2169
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2169/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2169/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2169/events
https://github.com/NVIDIA/NeMo/pull/2169
878,129,291
MDExOlB1bGxSZXF1ZXN0NjMxOTkxMDg0
2,169
token classification models artifacts update
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "@okuchaiev @ericharper we need to enable the full CI before merging this", "> @okuchaiev @ericharper we need to enable the full CI before merging this\r\n\r\nLooks like the Jenkinsfile reverted to main. I replaced with v1.0.0 again." ]
2021-05-06T22:31:37
2021-05-07T16:03:39
2021-05-07T16:03:34
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2169", "html_url": "https://github.com/NVIDIA/NeMo/pull/2169", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2169.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2169.patch", "merged_at": "2021-05-07T16:03:34" }
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2169/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2169/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2168
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2168/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2168/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2168/events
https://github.com/NVIDIA/NeMo/pull/2168
878,088,379
MDExOlB1bGxSZXF1ZXN0NjMxOTUzOTI3
2,168
[DOCS] NLP Model parallel, NMT multi-val, CORE register artifacts
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "@titu1994 Could you review the register_artifact docs?\r\n\r\n@MaximumEntropy Could you review NLP/NMT docs?\r\n\r\n" ]
2021-05-06T21:54:22
2021-05-08T03:12:07
2021-05-08T03:12:04
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2168", "html_url": "https://github.com/NVIDIA/NeMo/pull/2168", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2168.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2168.patch", "merged_at": "2021-05-08T03:12:04" }
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2168/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2168/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2167
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2167/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2167/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2167/events
https://github.com/NVIDIA/NeMo/pull/2167
878,032,929
MDExOlB1bGxSZXF1ZXN0NjMxOTA0Mzc2
2,167
Revert README
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T21:02:54
2021-05-06T21:06:00
2021-05-06T21:05:58
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2167", "html_url": "https://github.com/NVIDIA/NeMo/pull/2167", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2167.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2167.patch", "merged_at": "2021-05-06T21:05:57" }
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2167/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2167/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2166
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2166/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2166/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2166/events
https://github.com/NVIDIA/NeMo/pull/2166
877,999,452
MDExOlB1bGxSZXF1ZXN0NjMxODc0ODYy
2,166
First Revision of TTS Docs and Notebooks Update for 1.0
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T20:34:19
2021-05-07T19:01:06
2021-05-07T19:01:03
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2166", "html_url": "https://github.com/NVIDIA/NeMo/pull/2166", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2166.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2166.patch", "merged_at": "2021-05-07T19:01:03" }
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2166/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2166/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2165
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2165/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2165/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2165/events
https://github.com/NVIDIA/NeMo/pull/2165
877,990,851
MDExOlB1bGxSZXF1ZXN0NjMxODY3MTM0
2,165
First Revision of TTS Docs and Notebooks Update for 1.0
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T20:27:22
2021-05-06T20:34:24
2021-05-06T20:34:21
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2165", "html_url": "https://github.com/NVIDIA/NeMo/pull/2165", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2165.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2165.patch", "merged_at": null }
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2165/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2165/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2164
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2164/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2164/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2164/events
https://github.com/NVIDIA/NeMo/pull/2164
877,901,577
MDExOlB1bGxSZXF1ZXN0NjMxNzg3MDMy
2,164
fixed the num_samples of text classification model.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T19:15:48
2021-08-06T08:01:30
2021-05-06T23:16:44
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2164", "html_url": "https://github.com/NVIDIA/NeMo/pull/2164", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2164.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2164.patch", "merged_at": "2021-05-06T23:16:44" }
{ "login": "tkornuta-nvidia", "id": 56979727, "node_id": "MDQ6VXNlcjU2OTc5NzI3", "avatar_url": "https://avatars.githubusercontent.com/u/56979727?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tkornuta-nvidia", "html_url": "https://github.com/tkornuta-nvidia", "followers_url": "https://api.github.com/users/tkornuta-nvidia/followers", "following_url": "https://api.github.com/users/tkornuta-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/tkornuta-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/tkornuta-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tkornuta-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/tkornuta-nvidia/orgs", "repos_url": "https://api.github.com/users/tkornuta-nvidia/repos", "events_url": "https://api.github.com/users/tkornuta-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/tkornuta-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2164/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2164/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2163
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2163/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2163/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2163/events
https://github.com/NVIDIA/NeMo/pull/2163
877,883,965
MDExOlB1bGxSZXF1ZXN0NjMxNzcxMTU2
2,163
Megatron nb size reduced
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T19:01:58
2021-05-06T19:38:05
2021-05-06T19:38:02
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2163", "html_url": "https://github.com/NVIDIA/NeMo/pull/2163", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2163.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2163.patch", "merged_at": "2021-05-06T19:38:02" }
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2163/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2163/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2162
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2162/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2162/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2162/events
https://github.com/NVIDIA/NeMo/pull/2162
877,558,036
MDExOlB1bGxSZXF1ZXN0NjMxNDg5NjUw
2,162
Notebook Version
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T14:27:06
2021-05-06T14:52:45
2021-05-06T14:52:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2162", "html_url": "https://github.com/NVIDIA/NeMo/pull/2162", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2162.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2162.patch", "merged_at": "2021-05-06T14:52:42" }
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2162/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2162/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2161
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2161/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2161/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2161/events
https://github.com/NVIDIA/NeMo/issues/2161
877,237,747
MDU6SXNzdWU4NzcyMzc3NDc=
2,161
ITN fails to normalize telephone numbers with zero in them
{ "login": "taufique74", "id": 7470463, "node_id": "MDQ6VXNlcjc0NzA0NjM=", "avatar_url": "https://avatars.githubusercontent.com/u/7470463?v=4", "gravatar_id": "", "url": "https://api.github.com/users/taufique74", "html_url": "https://github.com/taufique74", "followers_url": "https://api.github.com/users/taufique74/followers", "following_url": "https://api.github.com/users/taufique74/following{/other_user}", "gists_url": "https://api.github.com/users/taufique74/gists{/gist_id}", "starred_url": "https://api.github.com/users/taufique74/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/taufique74/subscriptions", "organizations_url": "https://api.github.com/users/taufique74/orgs", "repos_url": "https://api.github.com/users/taufique74/repos", "events_url": "https://api.github.com/users/taufique74/events{/privacy}", "received_events_url": "https://api.github.com/users/taufique74/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4910680898, "node_id": "LA_kwDOC_bI7s8AAAABJLMLQg", ...
closed
false
null
[]
null
[ "thanks for feedback, will add." ]
2021-05-06T08:31:24
2022-12-19T21:50:18
2021-05-17T16:24:47
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
ITN fails to normalize telephone numbers like this `five four two one two nine seven zero six five` It works fine after replacing `zero` with `o` I think this is because `zero` is in `zero.tsv` not `digit.tsv`, and you are not including `zero.tsv` in the digit FST. https://github.com/NVIDIA/NeMo/blob/74f1264e049c10b012a1ea483fcd468f4d89ecf8/nemo_text_processing/inverse_text_normalization/taggers/telephone.py#L38 Also, it's quite common for ASR to output `oh` instead of `o`, like this `five oh seven` (507). So do you think we can add two more rules like this? ```python digit = ( pynini.invert(pynini.string_file(get_abs_path("data/numbers/digit.tsv"))).optimize() | pynini.cross("0", "o") | pynini.cross("0", "zero") | pynini.cross("0", "oh") ) ``` @yzhang123
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2161/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2161/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2160
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2160/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2160/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2160/events
https://github.com/NVIDIA/NeMo/pull/2160
877,017,473
MDExOlB1bGxSZXF1ZXN0NjMxMDUxNDk2
2,160
Multilingual training for NMT
{ "login": "aklife97", "id": 16078071, "node_id": "MDQ6VXNlcjE2MDc4MDcx", "avatar_url": "https://avatars.githubusercontent.com/u/16078071?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aklife97", "html_url": "https://github.com/aklife97", "followers_url": "https://api.github.com/users/aklife97/followers", "following_url": "https://api.github.com/users/aklife97/following{/other_user}", "gists_url": "https://api.github.com/users/aklife97/gists{/gist_id}", "starred_url": "https://api.github.com/users/aklife97/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aklife97/subscriptions", "organizations_url": "https://api.github.com/users/aklife97/orgs", "repos_url": "https://api.github.com/users/aklife97/repos", "events_url": "https://api.github.com/users/aklife97/events{/privacy}", "received_events_url": "https://api.github.com/users/aklife97/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 3 alerts** when merging d75335ceb01cff0fcd27dbfdc171669389f6cc15 into 74f1264e049c10b012a1ea483fcd468f4d89ecf8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6b9dd3e2f2dbe721fa62dd144bab1d74313eb4c8)\n\n**new alerts:**\n\n* 1 for Unused local variable\n* 1 for Un...
2021-05-06T02:38:41
2022-01-11T16:37:00
2021-05-14T22:03:39
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2160", "html_url": "https://github.com/NVIDIA/NeMo/pull/2160", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2160.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2160.patch", "merged_at": "2021-05-14T22:03:39" }
This PR adds support for multilingual training for NMT. ### Usage ### To train a model in multilingual mode, simply set the following: * `model.multilingual=True` * `model.encoder_tokenizer.library=sentencepiece` and `model.decoder_tokenizer.library=sentencepiece`. Currently we only support sentencepiece for multilingual NMT. * `model.src_language=['lang1','lang2']` or `model.tgt_language=['lang1','lang2']` This PR only supports `many-to-one` or `one-to-many` model, as a result, only either of the above can be a list. * `model.train_ds.metadata_file = [a,b]` if using tarred dataset or `model.train_ds.src_file_name = [a.src,b.src]` and `model.train_ds.tgt_file_name = [a.ref,b.ref]` * MultiValidation from #2113 can be used to provide val sets from different languages NOTE: All the lists in the configuration, including src/tgt_languages, train_set, val_set need to be in the same order. That is, if `model.tgt_language=['de','fr']`, the train data should also be provided as `['de_train_data','fr_train_data']`. ### Additional Info ### Under the hood, the model automatically adds language identifier tokens which are created as `control_symbols` in sentencepiece. So for instance, if `model.tgt_language=['de','fr']`, `<de>` is prepended to all German source sentences and `<fr>` is prepended to all French source sentences. ### Edit ### The PR also does the following changes to the current `TarredTranslationDataset`: * Adjust `__len__` of the dataset based on the world size when shard strategy is set to `scatter`. * Change naming convention of fragment pkl files (during tar file creation in `preproc_mt_data`) to make them globally unique in the dataset. * Remove `load_from_cached_dataset`. * Small fix for a variable name and file ptr when only tar metadata is passed.
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2160/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2160/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2159
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2159/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2159/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2159/events
https://github.com/NVIDIA/NeMo/pull/2159
876,991,792
MDExOlB1bGxSZXF1ZXN0NjMxMDMyNDQ4
2,159
Make Hifigan jittable
{ "login": "ryanleary", "id": 2212584, "node_id": "MDQ6VXNlcjIyMTI1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2212584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ryanleary", "html_url": "https://github.com/ryanleary", "followers_url": "https://api.github.com/users/ryanleary/followers", "following_url": "https://api.github.com/users/ryanleary/following{/other_user}", "gists_url": "https://api.github.com/users/ryanleary/gists{/gist_id}", "starred_url": "https://api.github.com/users/ryanleary/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ryanleary/subscriptions", "organizations_url": "https://api.github.com/users/ryanleary/orgs", "repos_url": "https://api.github.com/users/ryanleary/repos", "events_url": "https://api.github.com/users/ryanleary/events{/privacy}", "received_events_url": "https://api.github.com/users/ryanleary/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-06T01:34:39
2021-05-06T14:43:55
2021-05-06T14:43:55
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2159", "html_url": "https://github.com/NVIDIA/NeMo/pull/2159", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2159.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2159.patch", "merged_at": "2021-05-06T14:43:55" }
This PR makes changes to the HifiGan module that should make it jittable/torchscriptable. nemo export should work as well. Verified compatible with checkpoint on NGC. ```python from nemo.collections.tts.models import HifiGanModel model = HifiGanModel.from_pretrained(model_name="tts_hifigan") model.export("test.onnx") ``` Signed-off-by: Ryan Leary <rleary@nvidia.com>
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2159/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2158
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2158/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2158/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2158/events
https://github.com/NVIDIA/NeMo/pull/2158
876,913,001
MDExOlB1bGxSZXF1ZXN0NjMwOTcwMzM1
2,158
update spectral clustering method
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 3 alerts** when merging b7b73650384ffbf4109fdaac69a3aa31e4ecbfe9 into 81df4358cd3afb3750bbc87981d57f54244f354c - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-6034fac3632b1bb543e7793c3c154b7958b232b4)\n\n**new alerts:**\n\n* 2 for Except block handles &#39;BaseExc...
2021-05-05T22:36:44
2021-05-31T08:54:17
2021-05-06T19:49:29
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2158", "html_url": "https://github.com/NVIDIA/NeMo/pull/2158", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2158.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2158.patch", "merged_at": "2021-05-06T19:49:29" }
This PR : * Adds new NMSE spectral clustering method * Updates Docs to include dataset creation for any dataset, with special mentions for AMI and CH109. * Adds ability to diarize for unknown number of speakers/session with very good accuracies * Replace SpectralCluster from requirements with pyamg (math computing repo) Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2158/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2158/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2157
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2157/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2157/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2157/events
https://github.com/NVIDIA/NeMo/pull/2157
876,831,795
MDExOlB1bGxSZXF1ZXN0NjMwODk5Mjgz
2,157
Correct branch version for v1.0.0
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-05T21:02:22
2021-05-05T21:58:17
2021-05-05T21:58:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2157", "html_url": "https://github.com/NVIDIA/NeMo/pull/2157", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2157.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2157.patch", "merged_at": "2021-05-05T21:58:14" }
# Changelog - All references of r1.0.0rc1 -> v1.0.0 Signed-off-by: smajumdar <titu1994@gmail.com>
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2157/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2157/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2156
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2156/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2156/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2156/events
https://github.com/NVIDIA/NeMo/pull/2156
876,763,020
MDExOlB1bGxSZXF1ZXN0NjMwODQzMDY3
2,156
Fix text classification doc
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-05T19:22:04
2021-08-06T08:00:17
2021-05-06T00:12:12
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2156", "html_url": "https://github.com/NVIDIA/NeMo/pull/2156", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2156.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2156.patch", "merged_at": "2021-05-06T00:12:12" }
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2156/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2156/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2155
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2155/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2155/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2155/events
https://github.com/NVIDIA/NeMo/pull/2155
876,609,350
MDExOlB1bGxSZXF1ZXN0NjMwNzIxMTky
2,155
Minor patch for translate_ddp
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging ed015efee22a8d532065f533db44694352a8023a into 7a62084946e93c4ce4fc885c1af8634e8e160937 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-17e3c52503f2d4b8a1bb0c8816a7aa08885956f1)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull reque...
2021-05-05T16:03:01
2021-05-05T18:31:35
2021-05-05T18:31:35
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2155", "html_url": "https://github.com/NVIDIA/NeMo/pull/2155", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2155.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2155.patch", "merged_at": "2021-05-05T18:31:35" }
Variable name change
{ "login": "AlexGrinch", "id": 8689095, "node_id": "MDQ6VXNlcjg2ODkwOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AlexGrinch", "html_url": "https://github.com/AlexGrinch", "followers_url": "https://api.github.com/users/AlexGrinch/followers", "following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}", "gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}", "starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions", "organizations_url": "https://api.github.com/users/AlexGrinch/orgs", "repos_url": "https://api.github.com/users/AlexGrinch/repos", "events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}", "received_events_url": "https://api.github.com/users/AlexGrinch/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2155/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2155/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2154
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2154/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2154/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2154/events
https://github.com/NVIDIA/NeMo/issues/2154
876,173,767
MDU6SXNzdWU4NzYxNzM3Njc=
2,154
Failed to build Tacotron2 in Jarvis
{ "login": "thananchaiktw", "id": 16872939, "node_id": "MDQ6VXNlcjE2ODcyOTM5", "avatar_url": "https://avatars.githubusercontent.com/u/16872939?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thananchaiktw", "html_url": "https://github.com/thananchaiktw", "followers_url": "https://api.github.com/users/thananchaiktw/followers", "following_url": "https://api.github.com/users/thananchaiktw/following{/other_user}", "gists_url": "https://api.github.com/users/thananchaiktw/gists{/gist_id}", "starred_url": "https://api.github.com/users/thananchaiktw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thananchaiktw/subscriptions", "organizations_url": "https://api.github.com/users/thananchaiktw/orgs", "repos_url": "https://api.github.com/users/thananchaiktw/repos", "events_url": "https://api.github.com/users/thananchaiktw/events{/privacy}", "received_events_url": "https://api.github.com/users/thananchaiktw/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Hello,\r\nIt looks like your nemo file does not have the model weights checkpoint that should be saved. Can you untar the nemo file and make sure it has a model_weights.ckpt and model_config.yaml? If it doesn't, please let me know what the contents are.", "> Hello,\r\n> It looks like your nemo file does not have...
2021-05-05T07:58:49
2021-05-12T07:06:54
2021-05-12T07:06:54
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I trained Tacotron2 in Thai language using NeMo and it failed to build jmir format. I use command for build jmir like in https://docs.nvidia.com/deeplearning/jarvis/user-guide/docs/service-tts.html#pipeline-configuration . ![image](https://user-images.githubusercontent.com/16872939/117111657-231fc280-adb2-11eb-97ea-0657c420ec11.png) ![image](https://user-images.githubusercontent.com/16872939/117111684-2ca92a80-adb2-11eb-90bb-ced61e68346f.png) I tried to use Tacotron2 that provides in https://ngc.nvidia.com/catalog/models/nvidia:tlt-jarvis:speechsynthesis_english_tacotron2/files and its works. What is different between these two nemo files?
{ "login": "thananchaiktw", "id": 16872939, "node_id": "MDQ6VXNlcjE2ODcyOTM5", "avatar_url": "https://avatars.githubusercontent.com/u/16872939?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thananchaiktw", "html_url": "https://github.com/thananchaiktw", "followers_url": "https://api.github.com/users/thananchaiktw/followers", "following_url": "https://api.github.com/users/thananchaiktw/following{/other_user}", "gists_url": "https://api.github.com/users/thananchaiktw/gists{/gist_id}", "starred_url": "https://api.github.com/users/thananchaiktw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thananchaiktw/subscriptions", "organizations_url": "https://api.github.com/users/thananchaiktw/orgs", "repos_url": "https://api.github.com/users/thananchaiktw/repos", "events_url": "https://api.github.com/users/thananchaiktw/events{/privacy}", "received_events_url": "https://api.github.com/users/thananchaiktw/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2154/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2154/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2153
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2153/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2153/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2153/events
https://github.com/NVIDIA/NeMo/pull/2153
876,008,113
MDExOlB1bGxSZXF1ZXN0NjMwMjM0MDM3
2,153
fix for electronic
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "@ekmb note that v1.0.0 has been cut. If this is a bugfix, send it to v1.0.0\r\n" ]
2021-05-05T03:29:50
2021-05-05T16:41:19
2021-05-05T16:41:16
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2153", "html_url": "https://github.com/NVIDIA/NeMo/pull/2153", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2153.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2153.patch", "merged_at": "2021-05-05T16:41:16" }
Signed-off-by: ekmb <ebakhturina@nvidia.com>
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2153/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2152
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2152/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2152/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2152/events
https://github.com/NVIDIA/NeMo/pull/2152
875,961,409
MDExOlB1bGxSZXF1ZXN0NjMwMTk4NTc1
2,152
fixed the num_samples of text classification model.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-05T01:11:35
2021-05-06T02:00:58
2021-05-05T03:33:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2152", "html_url": "https://github.com/NVIDIA/NeMo/pull/2152", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2152.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2152.patch", "merged_at": "2021-05-05T03:33:22" }
Parameter num_samples was considered as number of bytes instead of number of lines in the text classification dataset.
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2152/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2152/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2151
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2151/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2151/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2151/events
https://github.com/NVIDIA/NeMo/pull/2151
875,928,637
MDExOlB1bGxSZXF1ZXN0NjMwMTcyODY3
2,151
update to 21.04-py3
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-04T23:47:48
2022-09-22T17:08:10
2021-06-01T23:45:38
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2151", "html_url": "https://github.com/NVIDIA/NeMo/pull/2151", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2151.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2151.patch", "merged_at": null }
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2151/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2150
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2150/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2150/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2150/events
https://github.com/NVIDIA/NeMo/pull/2150
875,002,079
MDExOlB1bGxSZXF1ZXN0NjI5NDM5Njcz
2,150
[NMT] Multi-validation Patch
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-04T00:15:21
2021-05-04T22:50:53
2021-05-04T22:45:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2150", "html_url": "https://github.com/NVIDIA/NeMo/pull/2150", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2150.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2150.patch", "merged_at": "2021-05-04T22:45:50" }
We instantiate a TorchMetric for each dataloader. This needs to happen after the dataloaders are created. Moved the logic for instantiating TorchMetrics to after the dataloaders are created. This is necessary when restoring from .nemo.
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2150/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2149
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2149/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2149/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2149/events
https://github.com/NVIDIA/NeMo/pull/2149
874,919,672
MDExOlB1bGxSZXF1ZXN0NjI5Mzc0MzIx
2,149
Text processing refactor
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 6 alerts** when merging 1677f4448ac8536a58f2d6a533e7234cabdfa369 into 855ce265b80c0dc40f4f06ece76d2c9d6ca1be8d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-796aa3ea4cf0df26414f426444817cfc0c976ee7)\n\n**new alerts:**\n\n* 5 for Unused import\n* 1 for Missing ca...
2021-05-03T21:20:20
2021-05-04T16:44:54
2021-05-04T16:44:47
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2149", "html_url": "https://github.com/NVIDIA/NeMo/pull/2149", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2149.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2149.patch", "merged_at": "2021-05-04T16:44:47" }
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2149/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2149/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2148
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2148/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2148/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2148/events
https://github.com/NVIDIA/NeMo/pull/2148
874,819,541
MDExOlB1bGxSZXF1ZXN0NjI5Mjk0MjYz
2,148
fix the docs.
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-05-03T18:51:49
2021-05-06T02:00:48
2021-05-03T22:01:11
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2148", "html_url": "https://github.com/NVIDIA/NeMo/pull/2148", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2148.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2148.patch", "merged_at": "2021-05-03T22:01:11" }
Signed-off-by: Vahid <vnoroozi@nvidia.com>
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2148/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2147
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2147/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2147/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2147/events
https://github.com/NVIDIA/NeMo/issues/2147
874,393,124
MDU6SXNzdWU4NzQzOTMxMjQ=
2,147
TypeError when I run eval_beamsearch_ngram.py
{ "login": "EmreOzkose", "id": 17765576, "node_id": "MDQ6VXNlcjE3NzY1NTc2", "avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4", "gravatar_id": "", "url": "https://api.github.com/users/EmreOzkose", "html_url": "https://github.com/EmreOzkose", "followers_url": "https://api.github.com/users/EmreOzkose/followers", "following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}", "gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}", "starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions", "organizations_url": "https://api.github.com/users/EmreOzkose/orgs", "repos_url": "https://api.github.com/users/EmreOzkose/repos", "events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}", "received_events_url": "https://api.github.com/users/EmreOzkose/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "@VahidooX fyi", "The transcribe method used to return Tensors, but now it returns numpy arrays. So softmax does not need the conversion. I think you are using an older version of NeMo with the old transcribe method.", "@EmreOzkose \r\nHi!\r\n\r\nDid you try to run eval_beamsearch_ngram.py from inside of Docke...
2021-05-03T09:18:08
2021-06-25T10:32:09
2021-05-03T09:18:14
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi! I encountered a problem during inference of Citrinet-1024 with a language model. When I run [eval_beamsearch_ngram.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram.py), output is : ``` Traceback (most recent call last): File "eval_beamsearch_ngram.py", line 347, in <module> main() File "eval_beamsearch_ngram.py", line 256, in main all_probs = [kenlm_utils.softmax(logits) for logits in all_logits] File "eval_beamsearch_ngram.py", line 256, in <listcomp> all_probs = [kenlm_utils.softmax(logits) for logits in all_logits] File "/home/username/workspace/nemo_asr/scripts/kenlm_utils.py", line 39, in softmax print(x - np.max(x)) File "<__array_function__ internals>", line 6, in amax File "/home/username/anaconda3/envs/nemo/lib/python3.7/site-packages/numpy/core/fromnumeric.py", line 2706, in amax keepdims=keepdims, initial=initial, where=where) File "/home/username/anaconda3/envs/nemo/lib/python3.7/site-packages/numpy/core/fromnumeric.py", line 85, in _wrapreduction return reduction(axis=axis, out=out, **passkwargs) TypeError: max() received an invalid combination of arguments - got (out=NoneType, axis=NoneType, ), but expected one of: * () * (name dim, bool keepdim) didn't match because some of the keywords were incorrect: out, axis * (Tensor other) * (int dim, bool keepdim) didn't match because some of the keywords were incorrect: out, axis ``` So I modified kenlm_utils/softmax function as ``` def softmax(x, to_cpu=False): if to_cpu: x = x.cpu().numpy() e = np.exp(x - np.max(x)) return e / e.sum(axis=-1).reshape([x.shape[0], 1]) ``` and call with to_cpu=True in [eval_beamsearch_ngram.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram.py). The problem is solved. I just want to inform people who faced the same problem.
{ "login": "EmreOzkose", "id": 17765576, "node_id": "MDQ6VXNlcjE3NzY1NTc2", "avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4", "gravatar_id": "", "url": "https://api.github.com/users/EmreOzkose", "html_url": "https://github.com/EmreOzkose", "followers_url": "https://api.github.com/users/EmreOzkose/followers", "following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}", "gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}", "starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions", "organizations_url": "https://api.github.com/users/EmreOzkose/orgs", "repos_url": "https://api.github.com/users/EmreOzkose/repos", "events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}", "received_events_url": "https://api.github.com/users/EmreOzkose/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2147/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2146
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2146/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2146/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2146/events
https://github.com/NVIDIA/NeMo/pull/2146
873,785,066
MDExOlB1bGxSZXF1ZXN0NjI4NTA1NDI4
2,146
Fix Nemo eval nondeterminism
{ "login": "PiotrDabkowski", "id": 4052440, "node_id": "MDQ6VXNlcjQwNTI0NDA=", "avatar_url": "https://avatars.githubusercontent.com/u/4052440?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PiotrDabkowski", "html_url": "https://github.com/PiotrDabkowski", "followers_url": "https://api.github.com/users/PiotrDabkowski/followers", "following_url": "https://api.github.com/users/PiotrDabkowski/following{/other_user}", "gists_url": "https://api.github.com/users/PiotrDabkowski/gists{/gist_id}", "starred_url": "https://api.github.com/users/PiotrDabkowski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PiotrDabkowski/subscriptions", "organizations_url": "https://api.github.com/users/PiotrDabkowski/orgs", "repos_url": "https://api.github.com/users/PiotrDabkowski/repos", "events_url": "https://api.github.com/users/PiotrDabkowski/events{/privacy}", "received_events_url": "https://api.github.com/users/PiotrDabkowski/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Thanks for the PR ! It was an oversight since for papers we use batch size 1 with transcribe() method, and it disables dithering inside." ]
2021-05-01T22:42:49
2021-05-02T20:02:09
2021-05-02T20:00:14
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2146", "html_url": "https://github.com/NVIDIA/NeMo/pull/2146", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2146.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2146.patch", "merged_at": "2021-05-02T20:00:14" }
In the eval mode the model should be deterministic (return the same value for the same input). I find it strange that this was not fixed before - this makes exports and evaluation non-deterministic.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2146/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2146/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2145
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2145/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2145/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2145/events
https://github.com/NVIDIA/NeMo/issues/2145
873,435,201
MDU6SXNzdWU4NzM0MzUyMDE=
2,145
Outputs of same batch produce different results with deterministic settings on
{ "login": "rbracco", "id": 47190785, "node_id": "MDQ6VXNlcjQ3MTkwNzg1", "avatar_url": "https://avatars.githubusercontent.com/u/47190785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rbracco", "html_url": "https://github.com/rbracco", "followers_url": "https://api.github.com/users/rbracco/followers", "following_url": "https://api.github.com/users/rbracco/following{/other_user}", "gists_url": "https://api.github.com/users/rbracco/gists{/gist_id}", "starred_url": "https://api.github.com/users/rbracco/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rbracco/subscriptions", "organizations_url": "https://api.github.com/users/rbracco/orgs", "repos_url": "https://api.github.com/users/rbracco/repos", "events_url": "https://api.github.com/users/rbracco/events{/privacy}", "received_events_url": "https://api.github.com/users/rbracco/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Could you try quartzner with batch size 1?", "Issue solved, SpecAugment and SpecCutout weren't getting the seed, setting the seed manually on their rng with `self._rng.seed(8)` in the `__init__()` of each solved the issue. Thank you. " ]
2021-04-30T22:24:59
2021-05-01T14:01:45
2021-05-01T14:01:45
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I'm working on implementing something new but I'm having trouble getting the model to output the same thing each time. The output from the featurizer is consistent, but the output from Quartznet 15x5 (encoder + decoder) is slightly different each time. I am aware of #1030 and have taken the following steps. - Set pytorch lightning seed with `pl.utilities.seed.seed_everything(8)` - Set num_workers = 0 in the dataloader (This is the default NeMo value anyway, right?) - Setting shuffle=False in the train dataloader - Pass the flag `deterministic=True` to the lightning trainer. - Turn off dithering (this shouldn't really matter since I'm setting a seed) - Setting the environment variable `CUBLAS_WORKSPACE_CONFIG=:16:8` Any idea what could be causing this? If I load the model weights in to a quartznet like model in pytorch lightning and set the seed, the output is the same every time. Thank you!
{ "login": "rbracco", "id": 47190785, "node_id": "MDQ6VXNlcjQ3MTkwNzg1", "avatar_url": "https://avatars.githubusercontent.com/u/47190785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rbracco", "html_url": "https://github.com/rbracco", "followers_url": "https://api.github.com/users/rbracco/followers", "following_url": "https://api.github.com/users/rbracco/following{/other_user}", "gists_url": "https://api.github.com/users/rbracco/gists{/gist_id}", "starred_url": "https://api.github.com/users/rbracco/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rbracco/subscriptions", "organizations_url": "https://api.github.com/users/rbracco/orgs", "repos_url": "https://api.github.com/users/rbracco/repos", "events_url": "https://api.github.com/users/rbracco/events{/privacy}", "received_events_url": "https://api.github.com/users/rbracco/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2145/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2144
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2144/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2144/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2144/events
https://github.com/NVIDIA/NeMo/pull/2144
873,402,453
MDExOlB1bGxSZXF1ZXN0NjI4MjI2MTg1
2,144
Removing graphsurgeon optional dependency, improving import error rep…
{ "login": "borisfom", "id": 14189615, "node_id": "MDQ6VXNlcjE0MTg5NjE1", "avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4", "gravatar_id": "", "url": "https://api.github.com/users/borisfom", "html_url": "https://github.com/borisfom", "followers_url": "https://api.github.com/users/borisfom/followers", "following_url": "https://api.github.com/users/borisfom/following{/other_user}", "gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}", "starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/borisfom/subscriptions", "organizations_url": "https://api.github.com/users/borisfom/orgs", "repos_url": "https://api.github.com/users/borisfom/repos", "events_url": "https://api.github.com/users/borisfom/events{/privacy}", "received_events_url": "https://api.github.com/users/borisfom/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging 3afd577d38d6304614bfc59b57beae7f58e2679f into b6bdccd4effef234b7cb44917d57f1368b9b23d9 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-cc87bcbdf4417483b27b2f378f45917a0f3961e2)\n\n**new alerts:**\n\n* 1 for Unused import" ]
2021-04-30T21:54:24
2021-05-01T03:11:38
2021-05-01T00:31:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2144", "html_url": "https://github.com/NVIDIA/NeMo/pull/2144", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2144.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2144.patch", "merged_at": "2021-05-01T00:31:23" }
…orting I did not remove graph surgeon install from Dockerfile - as it's nice to have anyway and maybe some users already use it. But I did remove the extra GS step on export.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2144/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2144/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2143
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2143/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2143/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2143/events
https://github.com/NVIDIA/NeMo/pull/2143
873,314,093
MDExOlB1bGxSZXF1ZXN0NjI4MTQ0ODA0
2,143
FastSpeech 2 Test & Docs
{ "login": "redoctopus", "id": 4268876, "node_id": "MDQ6VXNlcjQyNjg4NzY=", "avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4", "gravatar_id": "", "url": "https://api.github.com/users/redoctopus", "html_url": "https://github.com/redoctopus", "followers_url": "https://api.github.com/users/redoctopus/followers", "following_url": "https://api.github.com/users/redoctopus/following{/other_user}", "gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}", "starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions", "organizations_url": "https://api.github.com/users/redoctopus/orgs", "repos_url": "https://api.github.com/users/redoctopus/repos", "events_url": "https://api.github.com/users/redoctopus/events{/privacy}", "received_events_url": "https://api.github.com/users/redoctopus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-30T21:00:33
2021-05-05T18:06:47
2021-05-05T18:06:44
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2143", "html_url": "https://github.com/NVIDIA/NeMo/pull/2143", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2143.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2143.patch", "merged_at": "2021-05-05T18:06:44" }
Adding: - Data loading test for the `FastSpeech2Dataset` - FS2 data format documentation - Some TTS class APIs
{ "login": "redoctopus", "id": 4268876, "node_id": "MDQ6VXNlcjQyNjg4NzY=", "avatar_url": "https://avatars.githubusercontent.com/u/4268876?v=4", "gravatar_id": "", "url": "https://api.github.com/users/redoctopus", "html_url": "https://github.com/redoctopus", "followers_url": "https://api.github.com/users/redoctopus/followers", "following_url": "https://api.github.com/users/redoctopus/following{/other_user}", "gists_url": "https://api.github.com/users/redoctopus/gists{/gist_id}", "starred_url": "https://api.github.com/users/redoctopus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/redoctopus/subscriptions", "organizations_url": "https://api.github.com/users/redoctopus/orgs", "repos_url": "https://api.github.com/users/redoctopus/repos", "events_url": "https://api.github.com/users/redoctopus/events{/privacy}", "received_events_url": "https://api.github.com/users/redoctopus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2143/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2143/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2142
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2142/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2142/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2142/events
https://github.com/NVIDIA/NeMo/issues/2142
872,139,000
MDU6SXNzdWU4NzIxMzkwMDA=
2,142
beam search decoder and N-gram language model re-scoring with Citrinet
{ "login": "EmreOzkose", "id": 17765576, "node_id": "MDQ6VXNlcjE3NzY1NTc2", "avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4", "gravatar_id": "", "url": "https://api.github.com/users/EmreOzkose", "html_url": "https://github.com/EmreOzkose", "followers_url": "https://api.github.com/users/EmreOzkose/followers", "following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}", "gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}", "starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions", "organizations_url": "https://api.github.com/users/EmreOzkose/orgs", "repos_url": "https://api.github.com/users/EmreOzkose/repos", "events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}", "received_events_url": "https://api.github.com/users/EmreOzkose/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "@EmreOzkose change. you have changed “Citrinet” in place of “quartznet”. you should change the class name which should be “nemo.asr.models.EncDecCTCModelBPE” at place of “nemo.asr.models.EncDecCTCModel”. ", "I changed the class name, but it didn't work.", "The kenlm model being used is meant for Character enc...
2021-04-30T08:04:17
2024-01-28T09:24:12
2021-05-05T08:40:29
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi, I am using Citrinet models to transcribe an audio (taken from Mini-Librispeech) and it transcribes good. However when I use beam search decoding [in this tutorial](https://github.com/NVIDIA/NeMo/blob/acbd88257f20e776c09f5015b8a793e1bcfa584d/tutorials/asr/Offline_ASR.ipynb), I am getting nonrelevant results. What can be the problem? Is there anyone to face with that problem? Target sentence: THE MANAGER TOOK MY ADVICE BUT MARIA'S STILL MISSING ``` asr_model = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name='stt_en_citrinet_1024', strict=False) transcript = asr_model.transcribe(paths2audio_files=[wav_path])[0] print(f'Transcript: "{transcript}"') ``` > the manager took my advice but maria still missing ``` asr_model = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name='stt_en_citrinet_1024', strict=False) lm_path = 'lowercase_3-gram.pruned.1e-7.arpa' beam_search_lm = nemo_asr.modules.BeamSearchDecoderWithLM( vocab=list(asr_model.decoder.vocabulary), beam_width=16, alpha=2, beta=1.5, lm_path=lm_path, num_cpus=max(os.cpu_count(), 1), input_tensor=False) result_lm = beam_search_lm.forward(log_probs = np.expand_dims(probs, axis=0), log_probs_length=None) print(result_lm) ``` > [[(-163.07594299316406, 'a'), (-164.35794067382812, 'an'), (-171.96630859375, 'aa'), (-173.6032257080078, 'aan'), (-2158.844482421875, 'aavn'), (-2158.845458984375, 'aai'), (-2158.8759765625, 'aaan'), (-2159.080078125, 'aabn'), (-2159.123779296875, 'aani'), (-2159.14208984375, 'avn'), (-2159.169677734375, 'aav'), (-2159.1845703125, 'aaa'), (-2159.33349609375, 'aab'), (-2159.3623046875, 'abn'), (-2159.367431640625, 'aain'), (-2159.513427734375, 'aavni')]] In adition to that, when I use QuartzNet15x5Base, I got good results. ``` asr_model = nemo_asr.models.EncDecCTCModel.from_pretrained(model_name='QuartzNet15x5Base-En', strict=False) lm_path = 'lowercase_3-gram.pruned.1e-7.arpa' beam_search_lm = nemo_asr.modules.BeamSearchDecoderWithLM( vocab=list(asr_model.decoder.vocabulary), beam_width=16, alpha=2, beta=1.5, lm_path=lm_path, num_cpus=max(os.cpu_count(), 1), input_tensor=False) result_lm = beam_search_lm.forward(log_probs = np.expand_dims(probs, axis=0), log_probs_length=None) print(result_lm) ``` > [[(-37.2982063293457, 'the manager took my advice but maria still missing'), (-43.66973114013672, 'the manager took my advice but marias still missing'), (-44.21354675292969, 'the manager took my advice but maria still missing '), (-45.12510299682617, "the manager took my advice but maria's still missing"), (-46.51353454589844, 'the manager took my advice but mara still missing'), (-48.59613800048828, 'the manager took my advice but maria still missin'), (-50.58517837524414, 'the manager took my advice but marias still missing '), (-52.988243103027344, 'the manager took my advice but maria till missing'), (-54.96765899658203, 'the manager took my advice but marias still missin'), (-55.6533317565918, 'the manager took my advice but maria still messing'), (-56.42308044433594, "the manager took my advice but maria's still missin"), (-57.81150817871094, 'the manager took my advice but mara still missin'), (-62.115047454833984, 'the manager took my advice but maria till missin'), (-2045.078857421875, 'the manager took my advice but maria still missina'), (-2047.1024169921875, 'the manager took my advice but maria still misin'), (-2048.393798828125, 'the manager took my advice but maria still missen')]]
{ "login": "EmreOzkose", "id": 17765576, "node_id": "MDQ6VXNlcjE3NzY1NTc2", "avatar_url": "https://avatars.githubusercontent.com/u/17765576?v=4", "gravatar_id": "", "url": "https://api.github.com/users/EmreOzkose", "html_url": "https://github.com/EmreOzkose", "followers_url": "https://api.github.com/users/EmreOzkose/followers", "following_url": "https://api.github.com/users/EmreOzkose/following{/other_user}", "gists_url": "https://api.github.com/users/EmreOzkose/gists{/gist_id}", "starred_url": "https://api.github.com/users/EmreOzkose/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/EmreOzkose/subscriptions", "organizations_url": "https://api.github.com/users/EmreOzkose/orgs", "repos_url": "https://api.github.com/users/EmreOzkose/repos", "events_url": "https://api.github.com/users/EmreOzkose/events{/privacy}", "received_events_url": "https://api.github.com/users/EmreOzkose/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2142/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2142/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2141
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2141/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2141/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2141/events
https://github.com/NVIDIA/NeMo/pull/2141
871,723,947
MDExOlB1bGxSZXF1ZXN0NjI2NzIyMjA0
2,141
Itn add classes
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging fe433b5014740ebc502c7562933de52402e2a7a5 into c5426c871d7ae7a006f496e33d2977d1791ebe51 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-f9718579a2247addeb8826e193a17d91647924cb)\n\n**new alerts:**\n\n* 1 for Unused import" ]
2021-04-30T00:41:51
2021-04-30T01:58:57
2021-04-30T01:58:55
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2141", "html_url": "https://github.com/NVIDIA/NeMo/pull/2141", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2141.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2141.patch", "merged_at": "2021-04-30T01:58:55" }
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2141/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2141/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2140
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2140/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2140/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2140/events
https://github.com/NVIDIA/NeMo/pull/2140
871,255,313
MDExOlB1bGxSZXF1ZXN0NjI2MzAzNDYx
2,140
Update bert
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 2 alerts** when merging 786c4a83e0d6a48bf4732bb400e31c3b0b0dff21 into 6ce670b7ab3ab5c84ce388fa1968748cd859b8f8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-82f3d3ec49f1c660c34799fa45e15ff9271c68ef)\n\n**new alerts:**\n\n* 2 for Unused local variable" ]
2021-04-29T17:11:39
2021-04-29T23:35:03
2021-04-29T20:13:31
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2140", "html_url": "https://github.com/NVIDIA/NeMo/pull/2140", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2140.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2140.patch", "merged_at": "2021-04-29T20:13:31" }
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2140/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2140/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2139
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2139/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2139/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2139/events
https://github.com/NVIDIA/NeMo/issues/2139
870,952,278
MDU6SXNzdWU4NzA5NTIyNzg=
2,139
BERT pretraining hangs at first epoch: MisconfigurationException
{ "login": "malloc-naski", "id": 67795154, "node_id": "MDQ6VXNlcjY3Nzk1MTU0", "avatar_url": "https://avatars.githubusercontent.com/u/67795154?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malloc-naski", "html_url": "https://github.com/malloc-naski", "followers_url": "https://api.github.com/users/malloc-naski/followers", "following_url": "https://api.github.com/users/malloc-naski/following{/other_user}", "gists_url": "https://api.github.com/users/malloc-naski/gists{/gist_id}", "starred_url": "https://api.github.com/users/malloc-naski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malloc-naski/subscriptions", "organizations_url": "https://api.github.com/users/malloc-naski/orgs", "repos_url": "https://api.github.com/users/malloc-naski/repos", "events_url": "https://api.github.com/users/malloc-naski/events{/privacy}", "received_events_url": "https://api.github.com/users/malloc-naski/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "This error happens usually in cases you train for limited steps and no validation has happend at all. Therefore there would be no validation loss logged. You may train for more steps, or drop the validation section, or increase the frequency of validation.", "@VahidooX Thank you for your response! I had to set `...
2021-04-29T12:16:36
2021-05-06T13:43:24
2021-05-06T13:43:24
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hello, I've been trying to pretrain a BERT model with the [`[examples/nlp/language_modeling/bert_pretraining.py]`](https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/bert_pretraining.py) script and the training hangs at the first epoch. Previously I used to train with the script that was there before [using PyTorch Lightning's DDPPlugin](https://github.com/NVIDIA/NeMo/commit/7d4ad85dc38d41eae4369f2d1b6ec8f3de5cf1b7#diff-388430d4055e0020d401768aa02e821c948d18afe24e37c10e9d443c88de0477) (i.e with older dependencies, using **nemo_toolkit[all]==1.0.0b1**) which worked just fine. This is the raised exception now: `MisconfigurationException: ModelCheckpoint(monitor='val_loss') not found in the returned metrics: ['train_loss']. HINT: Did you call self.log('val_loss', value) in the LightningModule?` **_P.S:_** I need to use this version of NeMo (1.0.0rc1) because I'm going to integrate another PyTorch Lightning plugin once this works, the 1.0.0rc1 is only compatible with an older Lightning version that doesn't support plugins. - Environment location: personal laptop - Method of NeMo install: apt-get update && apt-get install -y libsndfile1 ffmpeg pip install Cython python -m pip install git+https://github.com/NVIDIA/NeMo.git@main **Environment details** - Ubuntu 20.4 - PyTorch version==1.8.1+cu111 - Python version==Python 3.8.5 - PyTorch Lightning version==1.2.10 - NeMo toolkit version==1.0.0rc4 Stack trace: ``` [NeMo W 2021-04-29 13:10:38 nemo_logging:349] /home/mallonus/tunbert-pip/lib/python3.8/site-packages/omegaconf/basecontainer.py:225: UserWarning: cfg.pretty() is deprecated and will be removed in a future version. Use OmegaConf.to_yaml(cfg) warnings.warn( [NeMo I 2021-04-29 13:10:38 bert_pretraining:29] Config: name: PretrainingBERTFromText trainer: gpus: 1 num_nodes: 1 max_epochs: 10 max_steps: null accumulate_grad_batches: 1 precision: 16 amp_level: O1 accelerator: ddp gradient_clip_val: 0.0 log_every_n_steps: 1 val_check_interval: 1.0 checkpoint_callback: false logger: false model: nemo_path: null only_mlm_loss: false num_tok_classification_layers: 1 num_seq_classification_layers: 2 max_seq_length: 128 mask_prob: 0.15 short_seq_prob: 0.1 language_model: pretrained_model_name: bert-base-uncased lm_checkpoint: null config: attention_probs_dropout_prob: 0.1 hidden_act: gelu hidden_dropout_prob: 0.1 hidden_size: 768 initializer_range: 0.02 intermediate_size: 3072 max_position_embeddings: 512 num_attention_heads: 12 num_hidden_layers: 12 type_vocab_size: 2 vocab_size: 30522 config_file: null tokenizer: tokenizer_name: ${model.language_model.pretrained_model_name} vocab_file: null tokenizer_model: null special_tokens: unk_token: '[UNK]' sep_token: '[SEP]' pad_token: '[PAD]' bos_token: '[CLS]' mask_token: '[MASK]' eos_token: '[SEP]' cls_token: '[CLS]' train_ds: data_file: dev-data/pretraining_data/train.txt max_seq_length: ${model.max_seq_length} mask_prob: ${model.mask_prob} short_seq_prob: ${model.short_seq_prob} batch_size: 2 shuffle: true num_samples: -1 num_workers: 2 drop_last: false pin_memory: false validation_ds: data_file: dev-data/pretraining_data/valid.txt max_seq_length: ${model.max_seq_length} mask_prob: ${model.mask_prob} short_seq_prob: ${model.short_seq_prob} batch_size: 2 shuffle: false num_samples: -1 num_workers: 2 drop_last: false pin_memory: false optim: name: adamw lr: 3.0e-05 weight_decay: 0.0 sched: name: CosineAnnealing warmup_steps: null warmup_ratio: 0.1 min_lr: 0.0 last_epoch: -1 exp_manager: exp_dir: null name: PretrainingBERTFromText create_tensorboard_logger: true create_checkpoint_callback: true GPU available: True, used: True TPU available: False, using: 0 TPU cores Using native 16bit precision. [NeMo I 2021-04-29 13:10:38 exp_manager:216] Experiments will be logged at /home/mallonus/tunbert-master/nemo_experiments/PretrainingBERTFromText/2021-04-29_13-10-38 [NeMo I 2021-04-29 13:10:38 exp_manager:563] TensorboardLogger has been set up [NeMo I 2021-04-29 13:10:47 modelPT:695] Optimizer config = AdamW ( Parameter Group 0 amsgrad: False betas: (0.9, 0.999) eps: 1e-08 lr: 3e-05 weight_decay: 0.0 ) [NeMo I 2021-04-29 13:10:47 lr_scheduler:617] Scheduler "<nemo.core.optim.lr_scheduler.CosineAnnealing object at 0x7f44269322e0>" will be used during training (effective maximum steps = 80) - Parameters : (warmup_steps: null warmup_ratio: 0.1 min_lr: 0.0 last_epoch: -1 max_steps: 80 ) LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0] [NeMo I 2021-04-29 13:10:47 modelPT:695] Optimizer config = AdamW ( Parameter Group 0 amsgrad: False betas: (0.9, 0.999) eps: 1e-08 lr: 3e-05 weight_decay: 0.0 ) [NeMo I 2021-04-29 13:10:47 lr_scheduler:617] Scheduler "<nemo.core.optim.lr_scheduler.CosineAnnealing object at 0x7f4426757b20>" will be used during training (effective maximum steps = 80) - Parameters : (warmup_steps: null warmup_ratio: 0.1 min_lr: 0.0 last_epoch: -1 max_steps: 80 ) initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/1 INFO:root:Added key: store_based_barrier_key:1 to store for rank: 0 | Name | Type | Params ------------------------------------------------------------------------- 0 | bert_model | BertEncoder | 109 M 1 | mlm_classifier | BertPretrainingTokenClassifier | 24.1 M 2 | mlm_loss | SmoothedCrossEntropyLoss | 0 3 | nsp_classifier | SequenceClassifier | 592 K 4 | nsp_loss | CrossEntropyLoss | 0 5 | agg_loss | AggregatorLoss | 0 6 | validation_perplexity | Perplexity | 0 ------------------------------------------------------------------------- 110 M Trainable params 0 Non-trainable params 110 M Total params 442.788 Total estimated model params size (MB) [NeMo W 2021-04-29 13:10:49 nemo_logging:349] /home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/utilities/distributed.py:68: UserWarning: The dataloader, val dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 4 which is the number of cpus on this machine) in the `DataLoader` init to improve performance. warnings.warn(*args, **kwargs) Validation sanity check: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 5.42it/s][NeMo I 2021-04-29 13:10:49 bert_lm_model:184] evaluation perplexity 26155.0595703125 [NeMo W 2021-04-29 13:10:49 nemo_logging:349] /home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/utilities/distributed.py:68: UserWarning: The validation_epoch_end should not return anything as of 9.1. To log, use self.log(...) or self.write(...) directly in the LightningModule warnings.warn(*args, **kwargs) [NeMo W 2021-04-29 13:10:49 nemo_logging:349] /home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/utilities/distributed.py:68: UserWarning: The dataloader, train dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 4 which is the number of cpus on this machine) in the `DataLoader` init to improve performance. warnings.warn(*args, **kwargs) Epoch 0: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:03<00:00, 2.73it/s, loss=10.7, v_num=0-38][NeMo I 2021-04-29 13:10:53 bert_lm_model:184] evaluation perplexity 26092.4775390625██████████████ | 1/2 [00:00<00:00, 6.30it/s] [NeMo W 2021-04-29 13:10:53 nemo_logging:349] /home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/utilities/distributed.py:68: UserWarning: The {log:dict keyword} was deprecated in 0.9.1 and will be removed in 1.0.0 Please use self.log(...) inside the lightningModule instead. # log on a step or aggregate epoch metric to the logger and/or progress bar (inside LightningModule) self.log('train_loss', loss, on_step=True, on_epoch=True, prog_bar=True) warnings.warn(*args, **kwargs) Epoch 0: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:03<00:00, 2.63it/s, loss=10.7, v_num=0-38Saving latest checkpoint... Traceback (most recent call last): File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 637, in run_train self.train_loop.run_training_epoch() File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 577, in run_training_epoch self.trainer.run_evaluation(on_epoch=True) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 752, in run_evaluation self.evaluation_loop.on_evaluation_end() File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 100, in on_evaluation_end self.trainer.call_hook('on_validation_end', *args, **kwargs) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1095, in call_hook trainer_hook(*args, **kwargs) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/callback_hook.py", line 185, in on_validation_end callback.on_validation_end(self, self.lightning_module) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 212, in on_validation_end self.save_checkpoint(trainer, pl_module) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 247, in save_checkpoint self._validate_monitor_key(trainer) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 495, in _validate_monitor_key raise MisconfigurationException(m) pytorch_lightning.utilities.exceptions.MisconfigurationException: ModelCheckpoint(monitor='val_loss') not found in the returned metrics: ['train_loss']. HINT: Did you call self.log('val_loss', value) in the LightningModule? During handling of the above exception, another exception occurred: Traceback (most recent call last): File "models/bert-nvidia/bert_pretraining.py", line 33, in main trainer.fit(bert_model) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 499, in fit self.dispatch() File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 546, in dispatch self.accelerator.start_training(self) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 73, in start_training self.training_type_plugin.start_training(trainer) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 114, in start_training self._results = trainer.run_train() File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 670, in run_train self.train_loop.on_train_end() File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 134, in on_train_end self.check_checkpoint_callback(should_update=True, is_last=True) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 164, in check_checkpoint_callback cb.on_validation_end(self.trainer, model) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 212, in on_validation_end self.save_checkpoint(trainer, pl_module) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 247, in save_checkpoint self._validate_monitor_key(trainer) File "/home/mallonus/tunbert-pip/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 495, in _validate_monitor_key raise MisconfigurationException(m) pytorch_lightning.utilities.exceptions.MisconfigurationException: ModelCheckpoint(monitor='val_loss') not found in the returned metrics: ['train_loss']. HINT: Did you call self.log('val_loss', value) in the LightningModule? Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace. Epoch 0: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:03<00:00, 2.54it/s, loss=10.7, v_num=0-38] ```
{ "login": "malloc-naski", "id": 67795154, "node_id": "MDQ6VXNlcjY3Nzk1MTU0", "avatar_url": "https://avatars.githubusercontent.com/u/67795154?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malloc-naski", "html_url": "https://github.com/malloc-naski", "followers_url": "https://api.github.com/users/malloc-naski/followers", "following_url": "https://api.github.com/users/malloc-naski/following{/other_user}", "gists_url": "https://api.github.com/users/malloc-naski/gists{/gist_id}", "starred_url": "https://api.github.com/users/malloc-naski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malloc-naski/subscriptions", "organizations_url": "https://api.github.com/users/malloc-naski/orgs", "repos_url": "https://api.github.com/users/malloc-naski/repos", "events_url": "https://api.github.com/users/malloc-naski/events{/privacy}", "received_events_url": "https://api.github.com/users/malloc-naski/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2139/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2139/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2138
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2138/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2138/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2138/events
https://github.com/NVIDIA/NeMo/pull/2138
870,663,726
MDExOlB1bGxSZXF1ZXN0NjI1ODIyODUw
2,138
Update how artifacts work
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 1 alert** when merging cd8a56e9ff9ad495a6c805e6b703e668423dae02 into 6ce670b7ab3ab5c84ce388fa1968748cd859b8f8 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-b1aeb4e49c3b999fff107cf21c3f4ba261ec6d4b)\n\n**new alerts:**\n\n* 1 for Unused import", "This pull reque...
2021-04-29T06:37:56
2021-05-04T20:55:41
2021-05-04T20:55:36
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2138", "html_url": "https://github.com/NVIDIA/NeMo/pull/2138", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2138.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2138.patch", "merged_at": "2021-05-04T20:55:36" }
This PR changes the following: * how register_artifacts work * how save_to works The usage of both register_artifacts and save_to method remains identical. Key differences in behaiviour: * register_artifacts always guarantees to return existing path to artifact at the time of call. * save_to will replace and hash artifact names in config file before creating .nemo file. This is necessary to prevent name collisions * when restoring artifacts from .nemo file it will create a temporary folder with artifacts for the lifetime of a model * temporary folders associated with the model get deleted by destructor TODOs: * Some unittests fail * Model parallel save_to (?)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2138/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2138/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2137
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2137/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2137/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2137/events
https://github.com/NVIDIA/NeMo/pull/2137
870,496,648
MDExOlB1bGxSZXF1ZXN0NjI1Njg4ODE1
2,137
Update text norm docs
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-29T00:07:21
2021-04-29T23:35:07
2021-04-29T21:59:26
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2137", "html_url": "https://github.com/NVIDIA/NeMo/pull/2137", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2137.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2137.patch", "merged_at": "2021-04-29T21:59:26" }
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2137/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2137/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2136
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2136/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2136/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2136/events
https://github.com/NVIDIA/NeMo/pull/2136
870,426,707
MDExOlB1bGxSZXF1ZXN0NjI1NjI5Njky
2,136
ASR + NLP Doc Fixes
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-28T22:02:20
2021-04-30T04:50:41
2021-04-30T04:50:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2136", "html_url": "https://github.com/NVIDIA/NeMo/pull/2136", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2136.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2136.patch", "merged_at": "2021-04-30T04:50:15" }
Signed-off-by: smajumdar <titu1994@gmail.com>
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2136/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2135
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2135/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2135/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2135/events
https://github.com/NVIDIA/NeMo/pull/2135
870,404,426
MDExOlB1bGxSZXF1ZXN0NjI1NjEwMDYx
2,135
tutorial fix for wfst_norm+segm
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-28T21:37:21
2021-04-28T21:59:10
2021-04-28T21:58:59
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2135", "html_url": "https://github.com/NVIDIA/NeMo/pull/2135", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2135.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2135.patch", "merged_at": "2021-04-28T21:58:59" }
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2135/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2135/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2134
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2134/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2134/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2134/events
https://github.com/NVIDIA/NeMo/pull/2134
870,308,151
MDExOlB1bGxSZXF1ZXN0NjI1NTI2NTAw
2,134
segmentation fix for wfst normalization
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-28T19:55:34
2021-04-28T21:11:17
2021-04-28T21:11:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2134", "html_url": "https://github.com/NVIDIA/NeMo/pull/2134", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2134.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2134.patch", "merged_at": "2021-04-28T21:11:17" }
Signed-off-by: ekmb <ebakhturina@nvidia.com>
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2134/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2134/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2133
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2133/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2133/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2133/events
https://github.com/NVIDIA/NeMo/pull/2133
870,003,152
MDExOlB1bGxSZXF1ZXN0NjI1MjcyNDQx
2,133
Update TTS notebook with TalkNet inference
{ "login": "stasbel", "id": 12044462, "node_id": "MDQ6VXNlcjEyMDQ0NDYy", "avatar_url": "https://avatars.githubusercontent.com/u/12044462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stasbel", "html_url": "https://github.com/stasbel", "followers_url": "https://api.github.com/users/stasbel/followers", "following_url": "https://api.github.com/users/stasbel/following{/other_user}", "gists_url": "https://api.github.com/users/stasbel/gists{/gist_id}", "starred_url": "https://api.github.com/users/stasbel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stasbel/subscriptions", "organizations_url": "https://api.github.com/users/stasbel/orgs", "repos_url": "https://api.github.com/users/stasbel/repos", "events_url": "https://api.github.com/users/stasbel/events{/privacy}", "received_events_url": "https://api.github.com/users/stasbel/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Can you send this to v1.0.0 instead?", "@blisc ready for review", "link is fixed\r\nbranch choice is yet to be commented by @blisc ", "> link is fixed\r\n> branch choice is yet to be commented by @blisc\r\n\r\nPlease use `v1.0.0` for all files and branches", "Okay, now it's ready to be merged." ]
2021-04-28T14:20:09
2021-05-17T17:21:25
2021-05-17T17:21:22
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2133", "html_url": "https://github.com/NVIDIA/NeMo/pull/2133", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2133.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2133.patch", "merged_at": "2021-05-17T17:21:22" }
Signed-off-by: Stanislav Beliaev <stasbelyaev96@gmail.com>
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2133/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2133/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2132
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2132/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2132/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2132/events
https://github.com/NVIDIA/NeMo/issues/2132
869,569,797
MDU6SXNzdWU4Njk1Njk3OTc=
2,132
What is the preformance of Talknet compared to other state-of-art methods, like tacotron2 fastspeech2.
{ "login": "Liujingxiu23", "id": 49260794, "node_id": "MDQ6VXNlcjQ5MjYwNzk0", "avatar_url": "https://avatars.githubusercontent.com/u/49260794?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Liujingxiu23", "html_url": "https://github.com/Liujingxiu23", "followers_url": "https://api.github.com/users/Liujingxiu23/followers", "following_url": "https://api.github.com/users/Liujingxiu23/following{/other_user}", "gists_url": "https://api.github.com/users/Liujingxiu23/gists{/gist_id}", "starred_url": "https://api.github.com/users/Liujingxiu23/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Liujingxiu23/subscriptions", "organizations_url": "https://api.github.com/users/Liujingxiu23/orgs", "repos_url": "https://api.github.com/users/Liujingxiu23/repos", "events_url": "https://api.github.com/users/Liujingxiu23/events{/privacy}", "received_events_url": "https://api.github.com/users/Liujingxiu23/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "stasbel", "id": 12044462, "node_id": "MDQ6VXNlcjEyMDQ0NDYy", "avatar_url": "https://avatars.githubusercontent.com/u/12044462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stasbel", "html_url": "https://github.com/stasbel", "followers_url": "https://api.github.com/users/stasbel/followers", "following_url": "https://api.github.com/users/stasbel/following{/other_user}", "gists_url": "https://api.github.com/users/stasbel/gists{/gist_id}", "starred_url": "https://api.github.com/users/stasbel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stasbel/subscriptions", "organizations_url": "https://api.github.com/users/stasbel/orgs", "repos_url": "https://api.github.com/users/stasbel/repos", "events_url": "https://api.github.com/users/stasbel/events{/privacy}", "received_events_url": "https://api.github.com/users/stasbel/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "stasbel", "id": 12044462, "node_id": "MDQ6VXNlcjEyMDQ0NDYy", "avatar_url": "https://avatars.githubusercontent.com/u/12044462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stasbel", "html_url": "https://github.com/stasbel", "followers_url": "https://api.git...
null
[]
2021-04-28T07:00:34
2021-08-17T01:02:28
2021-08-17T01:02:28
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
What is the preformance of Talknet compared to other state-of-art methods, like tacotron2 fastspeech2.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2132/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2132/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2126
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2126/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2126/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2126/events
https://github.com/NVIDIA/NeMo/pull/2126
869,369,219
MDExOlB1bGxSZXF1ZXN0NjI0NzQ2NTgz
2,126
Preserve the tokenizer config for ASR
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-28T00:11:10
2021-04-28T03:54:45
2021-04-28T03:54:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2126", "html_url": "https://github.com/NVIDIA/NeMo/pull/2126", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2126.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2126.patch", "merged_at": "2021-04-28T03:54:42" }
# Bugfix - ASR BPE models did not correctly preserve the new tokenizer config after changing vocabulary Signed-off-by: smajumdar <titu1994@gmail.com>
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2126/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2126/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2125
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2125/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2125/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2125/events
https://github.com/NVIDIA/NeMo/pull/2125
869,108,459
MDExOlB1bGxSZXF1ZXN0NjI0NTI0NDk3
2,125
fix for model restoration
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-27T17:59:33
2021-04-27T18:32:39
2021-04-27T18:32:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2125", "html_url": "https://github.com/NVIDIA/NeMo/pull/2125", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2125.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2125.patch", "merged_at": "2021-04-27T18:32:36" }
Signed-off-by: ekmb <ebakhturina@nvidia.com>
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2125/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2125/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2124
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2124/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2124/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2124/events
https://github.com/NVIDIA/NeMo/pull/2124
868,494,077
MDExOlB1bGxSZXF1ZXN0NjI0MDExMTk4
2,124
Few fixes to enable backtranslation again
{ "login": "MaximumEntropy", "id": 9114321, "node_id": "MDQ6VXNlcjkxMTQzMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/9114321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaximumEntropy", "html_url": "https://github.com/MaximumEntropy", "followers_url": "https://api.github.com/users/MaximumEntropy/followers", "following_url": "https://api.github.com/users/MaximumEntropy/following{/other_user}", "gists_url": "https://api.github.com/users/MaximumEntropy/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaximumEntropy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaximumEntropy/subscriptions", "organizations_url": "https://api.github.com/users/MaximumEntropy/orgs", "repos_url": "https://api.github.com/users/MaximumEntropy/repos", "events_url": "https://api.github.com/users/MaximumEntropy/events{/privacy}", "received_events_url": "https://api.github.com/users/MaximumEntropy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **fixes 3 alerts** when merging a0d7a2c00d22791313e5404ac1654023f4eb0ec0 into e59dd39f6f847155a82d40ebe2264a0b7f2b7a13 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-fca57bc50d3f751d5d455b5490d473ee1719d621)\n\n**fixed alerts:**\n\n* 3 for Unused import", "This pull request...
2021-04-27T06:11:28
2021-04-27T18:01:22
2021-04-27T18:01:19
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2124", "html_url": "https://github.com/NVIDIA/NeMo/pull/2124", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2124.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2124.patch", "merged_at": "2021-04-27T18:01:19" }
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2124/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2124/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2123
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2123/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2123/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2123/events
https://github.com/NVIDIA/NeMo/pull/2123
868,222,020
MDExOlB1bGxSZXF1ZXN0NjIzNzgwNzc1
2,123
Text norm
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 21 alerts** when merging 98bdf7a16e27cf4157f0ec0fcf78e6b0d6373c02 into e59dd39f6f847155a82d40ebe2264a0b7f2b7a13 - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-c158b8211dc388233d44ba88f0a83f5f8e4bd8e6)\n\n**new alerts:**\n\n* 18 for Unused import\n* 3 for Unused l...
2021-04-26T21:36:08
2021-05-11T11:29:02
2021-04-28T23:27:28
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2123", "html_url": "https://github.com/NVIDIA/NeMo/pull/2123", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2123.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2123.patch", "merged_at": "2021-04-28T23:27:28" }
* text normalization in WFST * merge electronic (Evelina) * updated docs for ITN and TN * updated Tutorials * unified deployment route * unit tests for both
{ "login": "yzhang123", "id": 4204271, "node_id": "MDQ6VXNlcjQyMDQyNzE=", "avatar_url": "https://avatars.githubusercontent.com/u/4204271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yzhang123", "html_url": "https://github.com/yzhang123", "followers_url": "https://api.github.com/users/yzhang123/followers", "following_url": "https://api.github.com/users/yzhang123/following{/other_user}", "gists_url": "https://api.github.com/users/yzhang123/gists{/gist_id}", "starred_url": "https://api.github.com/users/yzhang123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yzhang123/subscriptions", "organizations_url": "https://api.github.com/users/yzhang123/orgs", "repos_url": "https://api.github.com/users/yzhang123/repos", "events_url": "https://api.github.com/users/yzhang123/events{/privacy}", "received_events_url": "https://api.github.com/users/yzhang123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2123/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2123/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2122
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2122/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2122/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2122/events
https://github.com/NVIDIA/NeMo/pull/2122
867,988,883
MDExOlB1bGxSZXF1ZXN0NjIzNTcxNDc1
2,122
output expects AudioSignal() type
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-26T18:16:30
2021-04-26T19:28:31
2021-04-26T19:14:48
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2122", "html_url": "https://github.com/NVIDIA/NeMo/pull/2122", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2122.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2122.patch", "merged_at": "2021-04-26T19:14:48" }
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2122/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2122/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2121
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2121/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2121/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2121/events
https://github.com/NVIDIA/NeMo/issues/2121
867,925,964
MDU6SXNzdWU4Njc5MjU5NjQ=
2,121
using new_vocabulary() with BPE model keeps the old tokenizer path in final model
{ "login": "jprobichaud", "id": 9254379, "node_id": "MDQ6VXNlcjkyNTQzNzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9254379?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jprobichaud", "html_url": "https://github.com/jprobichaud", "followers_url": "https://api.github.com/users/jprobichaud/followers", "following_url": "https://api.github.com/users/jprobichaud/following{/other_user}", "gists_url": "https://api.github.com/users/jprobichaud/gists{/gist_id}", "starred_url": "https://api.github.com/users/jprobichaud/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jprobichaud/subscriptions", "organizations_url": "https://api.github.com/users/jprobichaud/orgs", "repos_url": "https://api.github.com/users/jprobichaud/repos", "events_url": "https://api.github.com/users/jprobichaud/events{/privacy}", "received_events_url": "https://api.github.com/users/jprobichaud/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.gi...
null
[ "> The model is trained and I get a fina .nemo file at the end. Now, if I look at the config inside the final \"adapted\" model, I see\r\n\r\nQuite a silent bug there, sending a patch in https://github.com/NVIDIA/NeMo/pull/2126\r\n\r\nWe normally follow this procedure for finetuning our models as well, but didnt fa...
2021-04-26T17:01:13
2021-05-28T08:36:21
2021-05-28T08:36:21
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** It seems that while the vocabulary is updated and the model is trained, trying to restore the model from checkpoint still uses the old tokenizer path. **Steps/Code to reproduce bug** I did something very similar to what's in the 08_ASR_with_Subword_Tokenization.ipynb notebook: ``` model_cfg = ASRModel.restore_from(restore_path="stt_en_citrinet_1024.nemo", return_config=True) classpath = model_cfg.target imported_class = model_utils.import_class_by_path(classpath) trainer = pl.Trainer( logger=False, # Provided by exp_manager checkpoint_callback=False, accelerator="ddp", gpus=4, max_epochs=1) citrinet = imported_class.restore_from(restore_path=model_path) citrinet.set_trainer(trainer) model_cfg["validation_ds"]["manifest_filepath"]= "/path/to/my/val.manifest" model_cfg["test_ds"]["manifest_filepath"]= "/path/to/my/test.manifest" model_cfg["train_ds"]["manifest_filepath"]= "/path/to/my/train.manifest" new_opt = copy.deepcopy(model_cfg["optim"]) new_opt["lr"] = 0.0003 citrinet.change_vocabulary( new_tokenizer_dir="/my/bpe_exp01/tokenizer_spe_unigram_v3000/", new_tokenizer_type="bpe" ) model_cfg["decoder"] = citrinet._cfg.decoder citrinet.setup_training_data(train_data_config=model_cfg["train_ds"]) citrinet.setup_validation_data(val_data_config=model_cfg["validation_ds"]) citrinet.setup_test_data(test_data_config=model_cfg["test_ds"]) trainer.fit(citrinet) citrinet.save_to(save_path="./citrinet_1024-adapted03.nemo") ``` The model is trained and I get a fina .nemo file at the end. Now, if I look at the config inside the final "adapted" model, I see: ``` 'tokenizer': {'dir': '../../manifests/asrset_1.4/tokenizers/no_appen/tokenizer_spe_unigram_v1024/', 'type': 'bpe'} ``` **Expected behavior** I would have expect the tokenizer path to be the right one. Also, for a model that I let the training happen for a longer number of epochs, I can't covert a checkpoint into a final nemo package because `load_from_checkpoint()` throws: ``` FileNotFoundError: Could not find ../../manifests/asrset_1.4/tokenizers/no_appen/tokenizer_spe_unigram_v1024/tokenizer.model ``` How can I fix that? **Environment overview (please complete the following information)** - Environment location: AWS - Method of NeMo install: from source **Environment details** - OS version : ubuntu 16.04 - PyTorch version 1.7.1 - Python version : 3.8 - CUDA 10.2
{ "login": "VahidooX", "id": 23551647, "node_id": "MDQ6VXNlcjIzNTUxNjQ3", "avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VahidooX", "html_url": "https://github.com/VahidooX", "followers_url": "https://api.github.com/users/VahidooX/followers", "following_url": "https://api.github.com/users/VahidooX/following{/other_user}", "gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}", "starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions", "organizations_url": "https://api.github.com/users/VahidooX/orgs", "repos_url": "https://api.github.com/users/VahidooX/repos", "events_url": "https://api.github.com/users/VahidooX/events{/privacy}", "received_events_url": "https://api.github.com/users/VahidooX/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2121/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2121/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2120
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2120/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2120/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2120/events
https://github.com/NVIDIA/NeMo/pull/2120
867,767,576
MDExOlB1bGxSZXF1ZXN0NjIzMzg1NDQ0
2,120
Language model refactoring
{ "login": "AlexGrinch", "id": 8689095, "node_id": "MDQ6VXNlcjg2ODkwOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AlexGrinch", "html_url": "https://github.com/AlexGrinch", "followers_url": "https://api.github.com/users/AlexGrinch/followers", "following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}", "gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}", "starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions", "organizations_url": "https://api.github.com/users/AlexGrinch/orgs", "repos_url": "https://api.github.com/users/AlexGrinch/repos", "events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}", "received_events_url": "https://api.github.com/users/AlexGrinch/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 2 alerts** when merging ed136b9b2a340c1c3e5ffa8c0e609e5d3de52d01 into b4040fb37350ae86b64a5f53be911371d7a3879d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-55223cc7bf93f881bcbeaac5e0bdbb46892d0188)\n\n**new alerts:**\n\n* 2 for Unused import", "This pull requ...
2021-04-26T14:28:56
2021-05-04T21:42:19
2021-05-04T21:42:19
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2120", "html_url": "https://github.com/NVIDIA/NeMo/pull/2120", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2120.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2120.patch", "merged_at": "2021-05-04T21:42:19" }
1. Language model training code refactored to be compatible with the latest changes in NMT. 2. Perplexity metric refactored to take into account samples of different length in a batch.
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2120/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2120/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2119
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2119/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2119/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2119/events
https://github.com/NVIDIA/NeMo/issues/2119
867,618,529
MDU6SXNzdWU4Njc2MTg1Mjk=
2,119
ASR checkpoint saving error in 1.0.0rc1
{ "login": "karpnv", "id": 1645775, "node_id": "MDQ6VXNlcjE2NDU3NzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karpnv", "html_url": "https://github.com/karpnv", "followers_url": "https://api.github.com/users/karpnv/followers", "following_url": "https://api.github.com/users/karpnv/following{/other_user}", "gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karpnv/subscriptions", "organizations_url": "https://api.github.com/users/karpnv/orgs", "repos_url": "https://api.github.com/users/karpnv/repos", "events_url": "https://api.github.com/users/karpnv/events{/privacy}", "received_events_url": "https://api.github.com/users/karpnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.gi...
null
[ "Please post your environment - torch version, pytorch lightning version, colab of local, etc. \r\n\r\nThere's no official b4 docker container, so I assume a local docker container was built. \r\n\r\nAnother thing is main branch codebase does not work with RC1 container, please build a container for main specifical...
2021-04-26T11:50:46
2021-06-19T04:37:32
2021-06-19T04:37:32
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** Error during saving first checkpoint in 1.0.0rc1 and main branches ``` Epoch 0: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 563/563 [02:55<00:00, 3.20it/s, loss=767, v_num=6-59Epoch 0, global step 6: val_wer reached 1.00113 (best 1.00113), saving model to "nemo_experiments/QuartzNet15x5/2021-04-26_11-06-59/checkpoints/QuartzNet15x5---val_wer=1.00-epoch=0.ckpt" as top 3 Saving latest checkpoint... Epoch 0, global step 5: val_wer reached 1.00113 (best 1.00113), saving model to "nemo_experiments/QuartzNet15x5/2021-04-26_11-06-59/checkpoints/QuartzNet15x5---val_wer=1.00-epoch=0.ckpt" as top 3 Traceback (most recent call last): File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 560, in train self.train_loop.run_training_epoch() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/training_loop.py", line 562, in run_training_epoch self.trainer.run_evaluation() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 667, in run_evaluation self.evaluation_loop.on_evaluation_end() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 110, in on_evaluation_end self.trainer.call_hook('on_validation_end', *args, **kwargs) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 924, in call_hook trainer_hook(*args, **kwargs) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/callback_hook.py", line 177, in on_validation_end callback.on_validation_end(self, self.get_model()) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 203, in on_validation_end self.save_checkpoint(trainer, pl_module) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 250, in save_checkpoint self._save_top_k_checkpoints(trainer, pl_module, monitor_candidates) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 592, in _save_top_k_checkpoints self._update_best_and_save(current, epoch, step, trainer, pl_module, metrics) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 644, in _update_best_and_save self._save_model(filepath, trainer, pl_module) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 361, in _save_model self.save_function(filepath, self.save_weights_only) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/properties.py", line 257, in save_checkpoint self.checkpoint_connector.save_checkpoint(filepath, weights_only) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 392, in save_checkpoint checkpoint = self.dump_checkpoint(weights_only) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 277, in dump_checkpoint callback_states = self.trainer.on_save_checkpoint() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/callback_hook.py", line 199, in on_save_checkpoint state = callback.on_save_checkpoint(self, self.get_model()) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py", line 39, in wrapped_fn return fn(*args, **kwargs) TypeError: on_save_checkpoint() missing 1 required positional argument: 'checkpoint' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "NeMo/examples/asr/speech_to_text.py", line 54, in main trainer.fit(asr_model) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 509, in fit results = self.accelerator_backend.train() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/accelerators/ddp_accelerator.py", line 152, in train results = self.ddp_train(process_idx=self.task_idx, model=model) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/accelerators/ddp_accelerator.py", line 301, in ddp_train results = self.train_or_test() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/accelerators/accelerator.py", line 74, in train_or_test results = self.trainer.train() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 591, in train self.train_loop.on_train_end() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/training_loop.py", line 162, in on_train_end self.check_checkpoint_callback(should_save=True, is_last=True) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/training_loop.py", line 196, in check_checkpoint_callback callback.on_validation_end(self.trainer, model) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 203, in on_validation_end self.save_checkpoint(trainer, pl_module) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 250, in save_checkpoint self._save_top_k_checkpoints(trainer, pl_module, monitor_candidates) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 592, in _save_top_k_checkpoints self._update_best_and_save(current, epoch, step, trainer, pl_module, metrics) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 644, in _update_best_and_save self._save_model(filepath, trainer, pl_module) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 361, in _save_model self.save_function(filepath, self.save_weights_only) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/properties.py", line 257, in save_checkpoint self.checkpoint_connector.save_checkpoint(filepath, weights_only) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 392, in save_checkpoint checkpoint = self.dump_checkpoint(weights_only) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 277, in dump_checkpoint callback_states = self.trainer.on_save_checkpoint() File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/trainer/callback_hook.py", line 199, in on_save_checkpoint state = callback.on_save_checkpoint(self, self.get_model()) File "/opt/conda/lib/python3.6/site-packages/pytorch_lightning/utilities/distributed.py", line 39, in wrapped_fn return fn(*args, **kwargs) TypeError: on_save_checkpoint() missing 1 required positional argument: 'checkpoint' Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace. Epoch 0: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 563/563 [02:56<00:00, 3.19it/s, loss=767, v_num=6-59] ``` **Steps/Code to reproduce bug** Code error in branches 1.0.0rc1 and main with docker container 1.0.0rc1: python NeMo/examples/asr/speech_to_text.py But it works in the branch r1.0.0b4 with docker container r1.0.0b4 **Expected behavior** Expected to save checkpoint. **Environment overview (please complete the following information)** docker run --runtime=nvidia -itd --ipc=host -p 8888:8888 -p 6006:6006 --restart unless-stopped --name nemo_100rc1 nvcr.io/nvidia/nemo:1.0.0rc1 **Additional context** GPU model: v100
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2119/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2119/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2118
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2118/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2118/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2118/events
https://github.com/NVIDIA/NeMo/issues/2118
867,447,755
MDU6SXNzdWU4Njc0NDc3NTU=
2,118
Exporting nemo nlp models to onnx
{ "login": "avikpal00", "id": 72965135, "node_id": "MDQ6VXNlcjcyOTY1MTM1", "avatar_url": "https://avatars.githubusercontent.com/u/72965135?v=4", "gravatar_id": "", "url": "https://api.github.com/users/avikpal00", "html_url": "https://github.com/avikpal00", "followers_url": "https://api.github.com/users/avikpal00/followers", "following_url": "https://api.github.com/users/avikpal00/following{/other_user}", "gists_url": "https://api.github.com/users/avikpal00/gists{/gist_id}", "starred_url": "https://api.github.com/users/avikpal00/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/avikpal00/subscriptions", "organizations_url": "https://api.github.com/users/avikpal00/orgs", "repos_url": "https://api.github.com/users/avikpal00/repos", "events_url": "https://api.github.com/users/avikpal00/events{/privacy}", "received_events_url": "https://api.github.com/users/avikpal00/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "borisfom", "id": 14189615, "node_id": "MDQ6VXNlcjE0MTg5NjE1", "avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4", "gravatar_id": "", "url": "https://api.github.com/users/borisfom", "html_url": "https://github.com/borisfom", "followers_url": "https://api.github.com/users/borisfom/followers", "following_url": "https://api.github.com/users/borisfom/following{/other_user}", "gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}", "starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/borisfom/subscriptions", "organizations_url": "https://api.github.com/users/borisfom/orgs", "repos_url": "https://api.github.com/users/borisfom/repos", "events_url": "https://api.github.com/users/borisfom/events{/privacy}", "received_events_url": "https://api.github.com/users/borisfom/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "borisfom", "id": 14189615, "node_id": "MDQ6VXNlcjE0MTg5NjE1", "avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4", "gravatar_id": "", "url": "https://api.github.com/users/borisfom", "html_url": "https://github.com/borisfom", "followers_url": "https://api....
null
[ "UPDATE:\r\nI tried all the steps of inference in the [qa_model inference](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/models/question_answering/qa_model.py#L183) script, here instead of forward pass I did the pass through the onnx inference session and everything worked properly with exact result...
2021-04-26T08:54:06
2021-05-11T13:59:49
2021-04-28T12:49:22
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** I am trying to export the nemo_nlp QAModel to onnx format in order to deploy it on triton. I am able to do so using this block of code: `restored_model = nemo_nlp.models.QAModel.restore_from('finetuning_bert_base_uncased_squad.nemo') restored_model.export("test_bert_onnx/model.onnx")` And if it is a larger model (ex. albert-xlarge-v2), I get the protobuf 2GB limit error and to get around this I add _use_external_data_format=True_ to the torch.onnx.export in exportable.py. This works fine and I get the onnx file and I am able to load it using _onnx.load_ and check it using _onnx.checker.check_model_. Only after this while running single inference I do not get good results at all. My inference block: ```python import numpy as np from onnxruntime import InferenceSession, SessionOptions, get_all_providers from transformers import BertTokenizer tokenizer = BertTokenizer.from_pretrained('bert-base-uncased') def sigmoid(x): return 1 / (1 + np.exp(-x)) def create_model_for_provider(model_path: str, provider: str) -> InferenceSession: assert provider in get_all_providers(), f"provider {provider} not found, {get_all_providers()}" options = SessionOptions() options.intra_op_num_threads = 1 return InferenceSession(model_path, options, providers=[provider]) output_path = "test_bert_onnx/model.onnx" cpu_model = create_model_for_provider(output_path, "CPUExecutionProvider") question = "Which NFL team won Super Bowl 50?" text = "Super Bowl 50 was an American football game to determine the champion of the National Football League (NFL) for the 2015 season. The American Football Conference (AFC) champion Denver Broncos defeated the National Football Conference (NFC) champion Carolina Panthers 24–10 to earn their third Super Bowl title. The game was played on February 7, 2016, at Levi's Stadium in the San Francisco Bay Area at Santa Clara, California. As this was the 50th Super Bowl, the league emphasized the \"golden anniversary\" with various gold-themed initiatives, as well as temporarily suspending the tradition of naming each Super Bowl game with Roman numerals (under which the game would have been known as \"Super Bowl L\"), so that the logo could prominently feature the Arabic numerals 50." inputs = tokenizer.encode_plus(question,text, add_special_tokens=True,return_tensors="np") logits = cpu_model.run(output_names=None,input_feed={"attention_mask":inputs['attention_mask'],"input_ids":inputs["input_ids"],"token_type_ids":inputs["token_type_ids"]}) answer_start_scores = logits[0][0][:,0] answer_end_scores = logits[0][0][:,1] ans_tokens = inputs["input_ids"][0][np.argmax(answer_start_scores) : np.argmax(answer_end_scores) + 1 ] answer_tokens = tokenizer.convert_ids_to_tokens(ans_tokens , skip_special_tokens=True) answer_tokens_to_string = tokenizer.convert_tokens_to_string(answer_tokens) print ("\nQuestion : ",question) print ("\nAnswer : ",answer_tokens_to_string) ``` This works fine but the output answer (and logits) are not what I expect from trained model (The pre-trained bert-base-uncased model that I am using gives an evaluation score of 81.28 exact match and 88.58 f1 score on squad dev1.1 dataset). The output that I get for an example question-context pair taken from squad dataset is this. ![image](https://user-images.githubusercontent.com/72965135/116053402-4652bf80-a698-11eb-9162-03758cb9617d.png) Can someone point out if I'm missing some processing script of input or output or if the method to export to onnx format is different. I am able to deploy this in triton but the inference result is same as above. Lastly, will Triton support NeMo models directly in future as this would prevent a lot of hassle? **Expected behavior** Onnx inference working same as _model.inference_ in nemo_nlp **Environment overview** - Environment location: GCP - Installed Docker container: docker pull nvcr.io/nvidia/nemo:1.0.0rc1
{ "login": "avikpal00", "id": 72965135, "node_id": "MDQ6VXNlcjcyOTY1MTM1", "avatar_url": "https://avatars.githubusercontent.com/u/72965135?v=4", "gravatar_id": "", "url": "https://api.github.com/users/avikpal00", "html_url": "https://github.com/avikpal00", "followers_url": "https://api.github.com/users/avikpal00/followers", "following_url": "https://api.github.com/users/avikpal00/following{/other_user}", "gists_url": "https://api.github.com/users/avikpal00/gists{/gist_id}", "starred_url": "https://api.github.com/users/avikpal00/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/avikpal00/subscriptions", "organizations_url": "https://api.github.com/users/avikpal00/orgs", "repos_url": "https://api.github.com/users/avikpal00/repos", "events_url": "https://api.github.com/users/avikpal00/events{/privacy}", "received_events_url": "https://api.github.com/users/avikpal00/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2118/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/2117
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2117/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2117/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2117/events
https://github.com/NVIDIA/NeMo/pull/2117
867,302,895
MDExOlB1bGxSZXF1ZXN0NjIyOTk0MzYz
2,117
Modified convert_to_tarred_audio_dataset.py to accept another argument also as input
{ "login": "aahameda", "id": 80743770, "node_id": "MDQ6VXNlcjgwNzQzNzcw", "avatar_url": "https://avatars.githubusercontent.com/u/80743770?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aahameda", "html_url": "https://github.com/aahameda", "followers_url": "https://api.github.com/users/aahameda/followers", "following_url": "https://api.github.com/users/aahameda/following{/other_user}", "gists_url": "https://api.github.com/users/aahameda/gists{/gist_id}", "starred_url": "https://api.github.com/users/aahameda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aahameda/subscriptions", "organizations_url": "https://api.github.com/users/aahameda/orgs", "repos_url": "https://api.github.com/users/aahameda/repos", "events_url": "https://api.github.com/users/aahameda/events{/privacy}", "received_events_url": "https://api.github.com/users/aahameda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "This pull request **introduces 2 alerts** when merging 1ce64a75065b53909e042395c27bf1a35f68309d into b4040fb37350ae86b64a5f53be911371d7a3879d - [view on LGTM.com](https://lgtm.com/projects/g/NVIDIA/NeMo/rev/pr-8c2c9c4c374e615c273837a54858c8611874091b)\n\n**new alerts:**\n\n* 1 for Unused local variable\n* 1 for Un...
2021-04-26T06:13:54
2021-04-26T07:07:00
2021-04-26T07:05:54
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2117", "html_url": "https://github.com/NVIDIA/NeMo/pull/2117", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2117.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2117.patch", "merged_at": null }
The newly added argument(dataset_dir) is concatenated with the path obtained from the manifest file. This solves the problem of FileNotFoundError as an absolute path is given for the datasets.
{ "login": "aahameda", "id": 80743770, "node_id": "MDQ6VXNlcjgwNzQzNzcw", "avatar_url": "https://avatars.githubusercontent.com/u/80743770?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aahameda", "html_url": "https://github.com/aahameda", "followers_url": "https://api.github.com/users/aahameda/followers", "following_url": "https://api.github.com/users/aahameda/following{/other_user}", "gists_url": "https://api.github.com/users/aahameda/gists{/gist_id}", "starred_url": "https://api.github.com/users/aahameda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aahameda/subscriptions", "organizations_url": "https://api.github.com/users/aahameda/orgs", "repos_url": "https://api.github.com/users/aahameda/repos", "events_url": "https://api.github.com/users/aahameda/events{/privacy}", "received_events_url": "https://api.github.com/users/aahameda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2117/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2117/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2114
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2114/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2114/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2114/events
https://github.com/NVIDIA/NeMo/pull/2114
866,906,376
MDExOlB1bGxSZXF1ZXN0NjIyNjkwNTEy
2,114
[docs] Reviewed/edited NeMo doc files
{ "login": "LynseyFabel", "id": 46456803, "node_id": "MDQ6VXNlcjQ2NDU2ODAz", "avatar_url": "https://avatars.githubusercontent.com/u/46456803?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LynseyFabel", "html_url": "https://github.com/LynseyFabel", "followers_url": "https://api.github.com/users/LynseyFabel/followers", "following_url": "https://api.github.com/users/LynseyFabel/following{/other_user}", "gists_url": "https://api.github.com/users/LynseyFabel/gists{/gist_id}", "starred_url": "https://api.github.com/users/LynseyFabel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LynseyFabel/subscriptions", "organizations_url": "https://api.github.com/users/LynseyFabel/orgs", "repos_url": "https://api.github.com/users/LynseyFabel/repos", "events_url": "https://api.github.com/users/LynseyFabel/events{/privacy}", "received_events_url": "https://api.github.com/users/LynseyFabel/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Hi Lynsey, could you resolve the merge conflicts with current main? I took a look and they seem to be from others' recent documentation updates.", "looks like all these changes are already there." ]
2021-04-25T04:07:31
2022-09-22T17:08:09
2021-07-19T23:04:54
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2114", "html_url": "https://github.com/NVIDIA/NeMo/pull/2114", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2114.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2114.patch", "merged_at": null }
I've reviewed and edited the NeMo doc files. All documentation have been reviewed. Majority of them were edited/updated.
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2114/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2113
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2113/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2113/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2113/events
https://github.com/NVIDIA/NeMo/pull/2113
866,836,900
MDExOlB1bGxSZXF1ZXN0NjIyNjQ4NTg5
2,113
[NMT] Add support for multiple validation and test dataloaders
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2021-04-24T21:01:26
2021-04-27T16:25:32
2021-04-27T16:25:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/2113", "html_url": "https://github.com/NVIDIA/NeMo/pull/2113", "diff_url": "https://github.com/NVIDIA/NeMo/pull/2113.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/2113.patch", "merged_at": "2021-04-27T16:25:28" }
Specify multiple validation (or test) dataloaders by inputting a list of src (tgt) files. # Usage Replace `src_file_name` and `tgt_file_name` with a list of file paths. ``` model.validation_ds.src_file_name=/data/wmt14-en-de.src \ model.validation_ds.tgt_file_name=/data/wmt14-en-de.ref \ ``` Becomes: ``` model.validation_ds.src_file_name=[/data/wmt13-en-de.src,/data/wmt14-en-de.src] \ model.validation_ds.tgt_file_name=[/data/wmt13-en-de.ref,/data/wmt14-en-de.ref] \ ``` When using `val_loss` or `val_sacreBLEU` for the `exp_manager.checkpoint_callback_params.monitor` then the 0th indexed dataloader will be used as the monitor. This ensures backwards compatibility. Additionally, any validation dataloader can now be used as a monitor by appending the index as below: ``` exp_manager.checkpoint_callback_params.monitor=val_sacreBLEU_dl_index_1 ``` Multiple test datasets works exactly the same way as validation datasets, simply replace `validation_ds` by `test_ds` in the above examples.
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2113/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/2112
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/2112/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/2112/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/2112/events
https://github.com/NVIDIA/NeMo/issues/2112
866,761,597
MDU6SXNzdWU4NjY3NjE1OTc=
2,112
I get an incompatible library version error
{ "login": "fnsrc", "id": 66776447, "node_id": "MDQ6VXNlcjY2Nzc2NDQ3", "avatar_url": "https://avatars.githubusercontent.com/u/66776447?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fnsrc", "html_url": "https://github.com/fnsrc", "followers_url": "https://api.github.com/users/fnsrc/followers", "following_url": "https://api.github.com/users/fnsrc/following{/other_user}", "gists_url": "https://api.github.com/users/fnsrc/gists{/gist_id}", "starred_url": "https://api.github.com/users/fnsrc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fnsrc/subscriptions", "organizations_url": "https://api.github.com/users/fnsrc/orgs", "repos_url": "https://api.github.com/users/fnsrc/repos", "events_url": "https://api.github.com/users/fnsrc/events{/privacy}", "received_events_url": "https://api.github.com/users/fnsrc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "(1) Please try running it Google's Colab (which would have a clean environment and should work)\r\n(2) If you try running it locally, I'd recommend creating a new conda environment with Python 3.8 (and without Pytorch, Torchtext, etc.). This way when you do \"pip install ...\" correct versions of torch and torchte...
2021-04-24T14:39:12
2021-06-19T04:37:12
2021-06-19T04:37:12
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I run the code in https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/06_Voice_Activiy_Detection.ipynb, however I got again an error while runing below cell: 1 # NeMo's "core" package ----> 2 import nemo 3 # NeMo's ASR collection - this collections contains complete ASR models and 4 # building blocks (modules) for ASR 5 import nemo.collections.asr as nemo_asr 11 frames /usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py in () 23 TORCHTEXT_AVAILABLE = importlib.util.find_spec("torchtext") is not None 24 if TORCHTEXT_AVAILABLE: ---> 25 from torchtext.data import Batch 26 else: 27 Batch = type(None) ImportError: cannot import name 'Batch' from 'torchtext.data' (/usr/local/lib/python3.7/dist-packages/torchtext/data/init.py) and I got another error when I run below cell: AttributeError Traceback (most recent call last) in () ----> 1 exp_dir = exp_manager(trainer, config.get("exp_manager", None)) 1 frames /content/MyVADNeMo/nemo/utils/exp_manager.py in get_log_dir(trainer, exp_dir, name, version, explicit_log_dir, use_datetime_version) 428 if trainer.logger.save_dir: 429 if exp_dir: --> 430 raise LoggerMisconfigurationError( 431 "The pytorch lightning trainer that was passed to exp_manager contained a logger, the logger's " 432 f"save_dir was not None, and exp_dir ({exp_dir}) was not None. If trainer.logger.save_dir " AttributeError: 'Trainer' object has no attribute 'is_slurm_managing_tasks'. Thanks in advance!
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/2112/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/2112/timeline
null
completed
false