text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
flashbangs are actually strong as fuck against blobs, the only downside is the possibility of killing everyone else ;^)
|
[
1
] |
you should be able to get rid of this boolean
|
[
0
] |
dead code that probably needs a living counterpart
|
[
0
] |
Author Name: **Rodrigo Izurieta** (Rodrigo Izurieta) --- Corey Burger wrote: > This is a fairly major issue - as you can easily wipe out work with this. It is also a Regression from prior releases Well, this is exactly what happened to me. I find this "feature" of duplicating layers absurd. Why in the world would I duplicate a layer if all changes to the duplicated layer will be saved on the original. I'd simply work on the original! This is definitely a bug.
|
[
1
] |
kill the trailing blank line too
|
[
0
] |
useless var
|
[
0
] |
we should not need to do this nonsense now we have migrate data obj livemigratedata detect implementation in the compute manager but it needs a closer look
|
[
0
] |
remove white spaces here and elsehwere
|
[
0
] |
@HLeithner actually you don\u2019t have to rely on conventions, read the zip file, read the Joomla.xml or anything else that provides info about the installable and act on real data not on clumsy conventions
|
[
1
] |
why not pass join kernel args in one grubby call
|
[
0
] |
this block of code should be removed
|
[
0
] |
not necessary self columns is a tuple
|
[
0
] |
useless docstring
|
[
0
] |
you should do this atomically saving a backup of existing astute yaml dump new yaml to self path new remove it on error copy self path self path old move self path new self path
|
[
0
] |
done
|
[
0
] |
nit i would just call reloadcredentials passing no argument
|
[
0
] |
Who else would write comments like this? It would have been half-informative if it had mentioned the GCC version that was needed, but it seems sh*tting on Ubuntu was more important.
|
[
1
] |
i do not see a significance to these and i agree with salvatore in that they should be removed
|
[
0
] |
I assume you are getting `src = client` from a runtime error but runtime errors can fuck up their reported src/usr/loc
|
[
1
] |
you used plain type again here fwiw above you fixed one by not having a local variable and the other by renaming the local variable either works but it is a tiny bit nicer to be consistent
|
[
0
] |
probably forgot to re-check shit when I pulled
|
[
1
] |
Yeah, that is one of the most stupid and embarrassing things I've done in a while. lol. That's gonna leave a scar... OK, moving on... so there's still this other validation issue. Did I do something else ridiculously stupid here too? :)
|
[
1
] |
this is very wrong you should not call your mocks you can do what you meant here like this patch file mock open return value and then you do not need to store this in a separate variable do you
|
[
0
] |
endpointurl should be inside replaceable tags
|
[
0
] |
fixing others past typos. wtf is a comdom
|
[
1
] |
this if is not doing anything useful bytes based on the check above
|
[
0
] |
Every time someone uses this they end in nullspace due the nikita being sheer shitcode, i'd avoid it.
|
[
1
] |
nikhil do we need data migration
|
[
0
] |
it s copy pasted from drm gem mmap with one minor modification that i will note in gerrit the reason i copied it is because at this point in time drm offered no api for retrieving gem objects by their dumb offsets in my upstream branch this function just uses drm vma offset exact lookup to retrieve the gem object from dumb offset
|
[
0
] |
would it make things easier to have these point to q qhead when the pq is empty see include linux list h i am not sure though
|
[
0
] |
this and below assignments also should be removed
|
[
0
] |
You should revert this bit because it's vendored code, even if it may look like an oversight, we don't want to fuck with it in any way.
|
[
1
] |
notification count
|
[
0
] |
six itervalues then you do not need dummy variable
|
[
0
] |
we re killing all enum tests so do not add this one n c
|
[
0
] |
oh stupid me all i did was make it dereference invalid pieces of memory if the addresses are too big i did manually test this and i found the expected partition size unfortunately neither storm nor any of our other upcoming brillo devices have nand big enough to trigger this proto s nand is gb that s gigabits and all the production devices will be much smaller
|
[
0
] |
`NOT_HULL_BREACHABLE`, but preferably find a way to word this in the positive because `if(!(flags & NOT_))` is weird to read
|
[
1
] |
listing the related docstrings here seems silly as they are listed below why not just remove this section
|
[
0
] |
wait no , fuck there should be ! in there. my bad
|
[
1
] |
yeah i covered the mako gpu thing however right now dev graphics fb num is a graphics device i am more concerned that the raw file object is passed back via these two permissions android permission read frame buffer android permission access surface flinger now these perms are for internal apps so i am ok with killing them for untrusted app domain
|
[
0
] |
s configdrive cloud init
|
[
0
] |
nit let us get rid of the white spaces
|
[
0
] |
currently vm destroy goes ahead before vif unplug so these code block may not take effective at all as vif has been destroyed along with vm destroy
|
[
0
] |
this logic should be moved to setup to be executed just once
|
[
0
] |
unessary whitespce chagne pleease remove
|
[
0
] |
done it was actually an annoying behavior of the template system returning some invalid value when looking up undefined global variables which is never helpful the behavior is now the same when testing for existence if global foo returns false if undefined but it does not require the extra test as in if foo global foo foo else end anymore just global foo
|
[
0
] |
do not hardcode mnt host source yourself use gclient root from common sh
|
[
0
] |
is not this get by template uuid provider resource template uuid
|
[
0
] |
No recipe? Seriously? _Checks File_ Well crap.
|
[
1
] |
accessing a static field on a different class looks a little ugly maybe add a static utility wrapping it in variantconfiguration
|
[
0
] |
If you change these, you become the gayest gay such that even the gay world will disown you.
|
[
1
] |
then here do if allowed timestamp get timestamp last line then die could not get timestamp from last line fi which means at the top you should add die echo kernel log collector exit
|
[
0
] |
Honestly this entire portion of lifecode needs a rewrite, why the hell is sight change being called every life tick? Makes no sense.
|
[
1
] |
executions extend
|
[
0
] |
FAGGOTNESS
|
[
1
] |
i kinda agree with jakub that this check is worthless but i am ok ish to proceed landing it
|
[
0
] |
would you be kind enough to add the possibility to not use keystone for this like specifying an id on the command line
|
[
0
] |
It would be nice if anti-virus nonsense didn't interfere with builds in cases such as these, but I guess that will never happen on Windows.
|
[
1
] |
all args on the next line for a double indent or align the moblab host with service account
|
[
0
] |
ditto docstring comment from above
|
[
0
] |
should be removed when you have to another patchset
|
[
0
] |
what i spent valuable TCs on this crap why should I get penalized for using it
|
[
1
] |
this is totally bogus.. :)
|
[
1
] |
move this down to the iptablesfirewalltestcase the ipset mocks it
|
[
0
] |
Did you mess up indentation or is GitHub being weird?
|
[
1
] |
shit i totally forgot about that, my bad
|
[
1
] |
Hell, even `getSearchReplicaIndexName`
|
[
1
] |
Damn, same as above. Thanks!
|
[
1
] |
dumb nit should this be logged before the exception i guess i am fine as it is because it shows the error right after the traceback and you do not need to scroll up much to see what the problem is in a ideal world
|
[
0
] |
this will kill all modes
|
[
0
] |
i tried a bit different approach maybe you would like it more it saves even more long living memory while not creating so much garbage during visitor traversal and it is simple
|
[
0
] |
all file lines should be executed before start of apache server
|
[
0
] |
also need sigkill to all domains for kill pid sigkill
|
[
0
] |
so dumb question is the only difference between a none network and a flat network that a flat network supports cleaning in a separate network using neutron
|
[
0
] |
the following mocks are not used and should be removed from the test mock open mock copy mock rmtree mock file mock dump mock json load mock random name
|
[
0
] |
whitespaces have to be removed here
|
[
0
] |
"broken" nigga just dont open the damn pizza
|
[
1
] |
girl profile can chat and video free if the male and ladyboy profile is paid. as girls will never pay on my site. how to do that
|
[
1
] |
this is a little ugly but this is what we will use to do consistency checks on the parameter pack with std enable if etc
|
[
0
] |
should this be setting func category
|
[
0
] |
i think with a bit of refactor we can get rid of this class entirely
|
[
0
] |
Caching issue. Please disregard. Very bizarre. Thank you! I apologize for wasting your time!
|
[
1
] |
this is supposed to be a three state flag i use it for both detecting if we can stop checking for the host to schedule to and for storing default results i stop checking in two cases first when a wrong id is supplied or the host is found we can safely assume that there will not be any other hosts assosiated with specified volume if there are such hosts sth is probably very wrong and my small optimization will not do any more harm we set it to false and return it on the other hand a user may forget to supply or decide not to supply volume id and in this case all hosts should pass in this case i set filtering result to true and use it as return value if on the yet another hand it is set to none that means that we have a valid volume id and are in process of filtering i did it with two variables at first with self keep searching and self default search result but this approach appeared to be excessively verbose so i desided to use a three state flag instead
|
[
0
] |
well yes typically one of the silly mistakes i am burdened with done
|
[
0
] |
Then make one damnit.
|
[
1
] |
cleanups should not really have asserts because we do not want to give them more reasons to fail
|
[
0
] |
stupid question but why are you using the dict compat and not getattr
|
[
0
] |
thanks for sounding the stupid mistake alarm grin fixed but also supporting lower upper now
|
[
0
] |
i am not entirely sure how to run a test wit a trybot w out messing up the live system
|
[
0
] |
it seems you are still using self nested templ with server rather it should be files the yaml self nested templ
|
[
0
] |
i think the only header you may need from here is omnibox pedal and components strings
|
[
0
] |
guest id guest id tenant id tenant id
|
[
0
] |
initializenvram does still call into mock tpm utility before this line so you still have interleaved test setup test execution against the mock or am i missing something
|
[
0
] |
stupid question is aodh enabled by default in the overcloud
|
[
0
] |
Damn... I thought I removed them already...
|
[
1
] |
Thank you so fucking much
|
[
1
] |
why do not you die right away why keep writing
|
[
0
] |
you do not need to setup an addcleanup to stop the mocks the infrastructure will do this automatically
|
[
0
] |
i cannot seem to find statichostsconfig anywhere did you mean allhostsconfig here or am i being daft again
|
[
0
] |
i guess this is supposed to list the original commits that are being squashed here but it does not seem to be a valid git command
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.