text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
nit you do not need any of get calls here as there will both of these hashes in any case
|
[
0
] |
ah i missed this comment this may be why we see issues in statemanagergl it will sync the active program before syncing the transform feedback so no it wont go back and reset the program to the correct one for the upcoming draw call you should reset it here changing gl state while syncing dirty bits is one place we need to be careful
|
[
0
] |
Ouch... and also yuck!
|
[
1
] |
per josh commnet can you please add a comment that this should be killed once netvirt vpnservice support it
|
[
0
] |
no need for if test since null is a valid dummy clock
|
[
0
] |
deploy the dashboard behind x by using a x
|
[
0
] |
ok so i will remove the delete volume and delete snapshot parts
|
[
0
] |
Damn, you are good!
|
[
1
] |
if the read operation fails how to guarantee that the value in val is correct and that you are not writing garbage back
|
[
0
] |
i do not see any profit from that fate sharing with approach implemented in rootwrap daemon you could easily kill daemon without affecting main process and it will get restarted and reload it is configs and code why do you want to get rid of this feature
|
[
0
] |
i am dumb i mean so yeah i am wrong
|
[
0
] |
Holy crap, somehow this got saved as a draft or something and not posted when I meant to
|
[
1
] |
should probably be a fixme
|
[
0
] |
3 more lines with piss poor indents
|
[
1
] |
i think we should use stateful dhcpv subnets here
|
[
0
] |
i still really do not like kill being used here if u use l u do not need to do this and u can just call stop on that
|
[
0
] |
can you put all this stuff somewhere outside pytest like factory py locale py gooftool has a separate copy of this and it would be nice to consolidate later if you do that the remaining tasks are small enough that you could just put them into vpd py of course we should really find a way to reuse chromeos s l n libraries but i will not make you do that here
|
[
0
] |
i am gonna get rid of the venv jobs anyway next commit coming
|
[
0
] |
Ridiculous solution: Add `-> Any`. Add `can_get_drag_data`, like we have `can_drop_data`. This would mean `get_drag_data` no longer needs to be able to return `void`. And could return `Any`.
|
[
1
] |
mark this as a private function by prefixing with
|
[
0
] |
what the fuck would this even do lol the absolute value of 0 is 0. what were they thinking?
|
[
1
] |
why this shitty check instead of checking if slurring is above a defined threshold?
|
[
1
] |
sendmsg should return a ssize t changing it is type is an abi violation please do not do that is there a specific reason for this change
|
[
0
] |
fat finger would be nice
|
[
0
] |
haha i am idiot i am shadowing this on l
|
[
0
] |
Then I would recommend we make it work by massaging it for now, then somebody will need to rewrite it to make it not suck. Maybe Silent would like to look at it since he added all the index stuff.
|
[
1
] |
you should use ipwrapper netns delete
|
[
0
] |
this actually needs to die in a fire me adds a todo to do that
|
[
0
] |
kwargs dict cluster id cluster id kwargs
|
[
0
] |
the param in params is useless in this conditional if you add the params get param check you might as well simplify this down to if params get param
|
[
0
] |
typo sin c e
|
[
0
] |
nit you do not need to set a return value
|
[
0
] |
can you add an endline after the colon pretty please it ll make for easier copying and pasting
|
[
0
] |
for consistency this should be like add tuntap self as root link add name type dummy
|
[
0
] |
remove let the shell script and mimo updater check the pid
|
[
0
] |
you are throwing an exception here so this should be an error message
|
[
0
] |
There has got to be a better way to do it than this, seems kinda shitcodey
|
[
1
] |
are you intentionally including a newline at the beginning of the string i am surprised this works
|
[
0
] |
Changed unique to suspicious because this ain't some exclusive premium shit.
|
[
1
] |
how is it really a message queue it s just a dummy
|
[
0
] |
same comment about using mock here
|
[
0
] |
F**ck didn't push the right version. Fixed.
|
[
1
] |
should be end execute disksetup
|
[
0
] |
Don't give a syndie headset since it will screw up all traitors considering the ENTIRE syndicate comms is on a single channel
|
[
1
] |
fan is suspended
|
[
0
] |
are all of the id s in this file actually resource ids if so then let us call them all resource id for clarity
|
[
0
] |
you may want to explain in a comment for why this is needed i e certain boards do not access the boot device prior to initializing dram etc
|
[
0
] |
this should be flavor id self flavor id
|
[
0
] |
so you should fuck with lists every time you need send message to one adress? Better to fuck with list concatenator when you need it.
|
[
1
] |
in a follow up patch i would like to see this controller using self driver run and self trans
|
[
0
] |
if we do not delete servo we hang indefinitely on any error
|
[
0
] |
please specify mock nova available return value in l instead of here eg mock patch s networks network nova network available ctx return value false
|
[
0
] |
this is all obsolete and i will remove it on master
|
[
0
] |
Yuck. Hopefully this all goes away one day.
|
[
1
] |
discovery should be an extension api get os federated providers
|
[
0
] |
similary die if vertica package file is not set
|
[
0
] |
this isn't the candy itself you nerdfuck
|
[
1
] |
disregard being silly duh stdlib
|
[
0
] |
you could just inline this in the calling function no bool ret false if checkifrebootisneeded proxy ret ret g main loop run loop ret true
|
[
0
] |
missing a space after the if a few others are too but not all so might as well make the new ones non ugly
|
[
0
] |
consts network notation cidr
|
[
0
] |
Why the hell do we track a GLOB of filing cabinets
|
[
1
] |
@Jahnkeanater: Yes. You can also change them in the UI by double clicking onto them (albeit the UI for it is super clumsy).
|
[
1
] |
kwargs
|
[
0
] |
the ismodifieid commit stuff needs to move into a destructor of the impl class
|
[
0
] |
i forgot to kill this todo
|
[
0
] |
cephx should be configurable
|
[
0
] |
drop this method definition conf and local conf are now useless
|
[
0
] |
yes there is a race condition hiding somewhere and it is still waiting to be eliminated
|
[
0
] |
task action exs db api get action executions task execution id task ex id
|
[
0
] |
just noticed this mind using git openstack org instead of github d
|
[
0
] |
queue peek units reading is checked on line do you mean if the other side send garbage value of write count to us
|
[
0
] |
put please at this block err msg
|
[
0
] |
shouldn t this be self assembly id assembly uuid
|
[
0
] |
useless
|
[
0
] |
Wrong direction. Gina was very clear about shorter is better. #3109 I'd be very glad about to have more than 20 minutes before you merge rubbish. I suggest **at least** 24h between publishing a PR and merging it, is a adequate time for a review and comment.
|
[
1
] |
this is the only outstanding issue with this cl this hack is for demonstration only it accesses some private variables could be made public and does not work for retrystage and repeatstage they do not inherit from builderstage retrystage getstagenames repeatstage getstagenames is a dirty hack imho i propose letting this cl in with simply a todo here to also handle the case when an exception escapes a stage i ll work on that and test that separately sg
|
[
0
] |
i think thats because those are uibuttons and this is a uibarbuttonitem
|
[
0
] |
i will remove them
|
[
0
] |
init py should be empty
|
[
0
] |
This is a bad change. There is just no fucking point to it. None. Plus, reloading bullets one by one? Good god tedium is just godawful. There's a reason barely anybody wires solars because it's boring and repetitive.
|
[
1
] |
omg, is it autoformatting? Looks like a Lisp hell
|
[
1
] |
i might be dumb but i do not get where the comes from
|
[
0
] |
I completely disagree with this. We are building Vuetify SSR with Vite and it's a bit ridiculous that we're expected to include this as a dependency. Could we put more than 2 seconds into a discussion before closing it?
|
[
1
] |
yes i mean test create instance is called only with vnuma enabled false i did not find other usages like test create instance vnuma enabled true
|
[
0
] |
YOU KNOW HOW QDEL WORKS DAMMIT KEV
|
[
1
] |
if someone provides an empty list that's their own damn fault
|
[
1
] |
The spacing here is twenty five kinds of fucked up. There shouldn't be spaces before or after any brackets. `if(istype(user))`.
|
[
1
] |
map chromeos machinelearning mojom graphexecutorproxy
|
[
0
] |
To whoever is watching this, this is totally a joke, shame on @Siomt. Haters can say whatever they want, but they just don't represent any group or community or country! **Please close this issue, this is ridiculous.** Peace & Love.
|
[
1
] |
bad client should be initialized like fake client
|
[
0
] |
Ah, crap. Yeah, that's a typo. This only appears when trying to shove a crayon up the noses of admins, but I'll get on fixing that.
|
[
1
] |
move it just above self slot to tid to make it clear how about set the default self slot some abnormal self slot to tid self point self pressure self syn time none
|
[
0
] |
iife is malformed should be
|
[
0
] |
afaic this does not make sense
|
[
0
] |
Ugh, just noticed the 'wills' as well.
|
[
1
] |
this function is useless and can be removed
|
[
0
] |
the thing wont' do damage so at most it'll get you lynched/scare the shit out of a blob :P
|
[
1
] |
It felt weird keeping docs on private fields, but I can resurrect that.
|
[
1
] |
Glad you combined all these. It was a pain in the ass to have to update each file. We had good intentions, it's just become impractical
|
[
1
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.