added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| created
timestamp[us]date 2001-10-09 16:19:16
2025-01-01 03:51:31
| id
stringlengths 4
10
| metadata
dict | source
stringclasses 2
values | text
stringlengths 0
1.61M
|
|---|---|---|---|---|---|
2025-04-01T04:54:56.206550
| 2023-09-15T14:19:14
|
1898525418
|
{
"authors": [
"mikanIchinose",
"takahirom"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13802",
"repo": "DroidKaigi/conference-app-2023",
"url": "https://github.com/DroidKaigi/conference-app-2023/issues/1220"
}
|
gharchive/issue
|
Use explicit API for core/model module
Idea Description
You can see the 2022 pr
Reference images and links
https://github.com/DroidKaigi/conference-app-2022/pull/554/files
๐ค๐ป
Thanks! Assigned ๐
|
2025-04-01T04:54:56.221898
| 2018-10-11T23:41:50
|
369346589
|
{
"authors": [
"Dropelikeit",
"coveralls"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13803",
"repo": "Dropelikeit/PriceCalculator",
"url": "https://github.com/Dropelikeit/PriceCalculator/pull/12"
}
|
gharchive/pull-request
|
Change namespace of converts to sub namespace "currencies"
Fix phpcs issues
Remove todo rule from phpcs.xml
Coverage remained the same at 100.0% when pulling 0549c922e87b2d8514db103025fed5fa186cf816 on some_changes into 61fbf0a83546621457cbfce1748be3058c44206a on master.
|
2025-04-01T04:54:56.246280
| 2021-05-31T06:39:47
|
907126949
|
{
"authors": [
"DuhonTheGuy",
"itsOwen"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13804",
"repo": "DuhonTheGuy/RPG-Generator",
"url": "https://github.com/DuhonTheGuy/RPG-Generator/issues/2"
}
|
gharchive/issue
|
Reward System?
I love RPG games even if they are text-based, Good to know it's in development. I was wondering you could add reward system like if player founds a key in the dungeon then he shall be rewarded with a clue or something so he can pass the next stage easily.
Maybe that could be a nice addition once I get around to adding dungeons.
|
2025-04-01T04:54:56.262595
| 2020-10-11T19:00:03
|
718904075
|
{
"authors": [
"yo1995"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13805",
"repo": "DukeMobileDevCenter/Jigsaw",
"url": "https://github.com/DukeMobileDevCenter/Jigsaw/issues/99"
}
|
gharchive/issue
|
[Feature] Do not allow players to re-enter played games in 2020
So that they cannot retry to get a higher score.
Done.
|
2025-04-01T04:54:56.265083
| 2022-08-03T13:27:14
|
1327218290
|
{
"authors": [
"ShenyiCui",
"astraxq"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13806",
"repo": "Dulwich-Bookings/Dulwich-Bookings-Frontend",
"url": "https://github.com/Dulwich-Bookings/Dulwich-Bookings-Frontend/pull/45"
}
|
gharchive/pull-request
|
Add Subscription Modal
Changes
create Modal Wrapper Component
create Subscription Modal Body
fix the home view dependent on the user's role
fix the add room form such that student role is dependent on the teacher role.
Screenshots
Great code, just 2 comments.
Links should open in new tab
why so many changes to package-lock?
|
2025-04-01T04:54:56.275546
| 2024-06-17T09:18:02
|
2356837297
|
{
"authors": [
"Dun-sin",
"malavshah9"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13807",
"repo": "Dun-sin/react-open-source-projects",
"url": "https://github.com/Dun-sin/react-open-source-projects/pull/24"
}
|
gharchive/pull-request
|
doc: remove bigdrop
Removes bigdrop from the list
Resolves https://github.com/Dun-sin/react-open-source-projects/issues/23
Thanks for this @malavshah9
|
2025-04-01T04:54:56.288525
| 2024-01-02T22:03:09
|
2063007268
|
{
"authors": [
"CM000n",
"GitOldGrumpy"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13808",
"repo": "DurgNomis-drol/mytoyota",
"url": "https://github.com/DurgNomis-drol/mytoyota/pull/269"
}
|
gharchive/pull-request
|
Fix: Use pydantic 1.10 due to homeassistant incompatibility with pydantic>2.0
There is currently an error when trying to use the latest mytoyota version under a Homeassistant env.
This is apparently due to the pydantic>=2.0. incompatibility of some of the packages included in Homeassitant.
We should therefore also use pydantic=1.10 as the maximum version for the time being.
home-assistant:~# pip install mytoyota==1.0.0
Looking in indexes: https://pypi.org/simple, https://wheels.home-assistant.io/musllinux-index/
Collecting mytoyota==1.0.0
Downloading mytoyota-1.0.0-py3-none-any.whl.metadata (5.7 kB)
Requirement already satisfied: arrow<2.0,>=1.1 in /usr/local/lib/python3.11/site-packages (from mytoyota==1.0.0) (1.3.0)
Collecting hishel<0.0.20,>=0.0.19 (from mytoyota==1.0.0)
Downloading hishel-0.0.19-py3-none-any.whl.metadata (8.1 kB)
Requirement already satisfied: httpx>=0.18.1 in /usr/local/lib/python3.11/site-packages (from mytoyota==1.0.0) (0.25.0)
Collecting langcodes<4.0,>=3.1 (from mytoyota==1.0.0)
Downloading langcodes-3.3.0-py3-none-any.whl (181 kB)
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ 181.6/181.6 kB 4.5 MB/s eta 0:00:00
Collecting pydantic<3.0.0,>=2.5.1 (from mytoyota==1.0.0)
Downloading pydantic-2.5.3-py3-none-any.whl.metadata (65 kB)
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ 65.6/65.6 kB 23.5 MB/s eta 0:00:00
Requirement already satisfied: pyjwt<3.0.0,>=2.8.0 in /usr/local/lib/python3.11/site-packages (from mytoyota==1.0.0) (2.8.0)
Requirement already satisfied: python-dateutil>=2.7.0 in /usr/local/lib/python3.11/site-packages (from arrow<2.0,>=1.1->mytoyota==1.0.0) (2.8.2)
Requirement already satisfied: types-python-dateutil>=2.8.10 in /usr/local/lib/python3.11/site-packages (from arrow<2.0,>=1.1->mytoyota==1.0.0) (<IP_ADDRESS>)
Requirement already satisfied: certifi in /usr/local/lib/python3.11/site-packages (from httpx>=0.18.1->mytoyota==1.0.0) (2023.11.17)
Requirement already satisfied: httpcore<0.19.0,>=0.18.0 in /usr/local/lib/python3.11/site-packages (from httpx>=0.18.1->mytoyota==1.0.0) (0.18.0)
Requirement already satisfied: idna in /usr/local/lib/python3.11/site-packages (from httpx>=0.18.1->mytoyota==1.0.0) (3.6)
Requirement already satisfied: sniffio in /usr/local/lib/python3.11/site-packages (from httpx>=0.18.1->mytoyota==1.0.0) (1.3.0)
Collecting annotated-types>=0.4.0 (from pydantic<3.0.0,>=2.5.1->mytoyota==1.0.0)
Downloading annotated_types-0.6.0-py3-none-any.whl.metadata (12 kB)
Collecting pydantic-core==2.14.6 (from pydantic<3.0.0,>=2.5.1->mytoyota==1.0.0)
Downloading pydantic_core-2.14.6-cp311-cp311-musllinux_1_1_x86_64.whl.metadata (6.5 kB)
Requirement already satisfied: typing-extensions>=4.6.1 in /usr/local/lib/python3.11/site-packages (from pydantic<3.0.0,>=2.5.1->mytoyota==1.0.0) (4.9.0)
Requirement already satisfied: anyio<5.0,>=3.0 in /usr/local/lib/python3.11/site-packages (from httpcore<0.19.0,>=0.18.0->httpx>=0.18.1->mytoyota==1.0.0) (4.0.0)
Requirement already satisfied: h11<0.15,>=0.13 in /usr/local/lib/python3.11/site-packages (from httpcore<0.19.0,>=0.18.0->httpx>=0.18.1->mytoyota==1.0.0) (0.14.0)
Requirement already satisfied: six>=1.5 in /usr/local/lib/python3.11/site-packages (from python-dateutil>=2.7.0->arrow<2.0,>=1.1->mytoyota==1.0.0) (1.16.0)
Downloading mytoyota-1.0.0-py3-none-any.whl (40 kB)
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ 40.3/40.3 kB 128.0 MB/s eta 0:00:00
Downloading hishel-0.0.19-py3-none-any.whl (30 kB)
Downloading pydantic-2.5.3-py3-none-any.whl (381 kB)
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ 381.9/381.9 kB 10.5 MB/s eta 0:00:00
Downloading pydantic_core-2.14.6-cp311-cp311-musllinux_1_1_x86_64.whl (2.1 MB)
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ 2.1/2.1 MB 11.4 MB/s eta 0:00:00
Downloading annotated_types-0.6.0-py3-none-any.whl (12 kB)
Installing collected packages: pydantic-core, langcodes, annotated-types, pydantic, hishel, mytoyota
Attempting uninstall: pydantic
Found existing installation: pydantic 1.10.12
Uninstalling pydantic-1.10.12:
Successfully uninstalled pydantic-1.10.12
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pykoplenti 1.2.2 requires pydantic~=1.10, but you have pydantic 2.5.3 which is incompatible.
aiopurpleair 2022.12.1 requires pydantic<2.0.0,>=1.10.2, but you have pydantic 2.5.3 which is incompatible.
aionotion 2023.5.5 requires pydantic<2.0.0,>=1.10.7, but you have pydantic 2.5.3 which is incompatible.
pyaussiebb 0.0.15 requires pydantic<2.0.0,>=1.9.0, but you have pydantic 2.5.3 which is incompatible.
aioopenexchangerates 0.4.0 requires pydantic<2.0,>=1.9, but you have pydantic 2.5.3 which is incompatible.
demetriek 0.4.0 requires pydantic<2.0.0,>=1.9.0, but you have pydantic 2.5.3 which is incompatible.
systembridgemodels 3.10.5 requires pydantic<2.0.0, but you have pydantic 2.5.3 which is incompatible.
We should switch back to pydantic >= 2.0 as soon as the issue on home assistant side is resolved: https://github.com/home-assistant/core/issues/99218
Hi @GitOldGrumpy. Since @DurgNomis-drol seems to be quite busy and inactive here lately; Could you approve this MR without maintainer rights?
I don't know if it works, but it would be worth a try ๐
Hi @GitOldGrumpy. Since @DurgNomis-drol seems to be quite busy and inactive here lately; Could you approve this MR without maintainer rights? I don't know if it works, but it would be worth a try ๐
Afraid I dont have such options, maybe if you can add me to the list of reviewers I will have such an option?
Hi @GitOldGrumpy. Since @DurgNomis-drol seems to be quite busy and inactive here lately; Could you approve this MR without maintainer rights? I don't know if it works, but it would be worth a try ๐
Afraid I dont have such options, maybe if you can add me to the list of reviewers I will have such an option?
Unfortunately not. Looks like I can only request a review from maintainers. :-/
|
2025-04-01T04:54:56.290641
| 2020-11-24T14:23:37
|
749749439
|
{
"authors": [
"alisonrclarke"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13809",
"repo": "DurhamARC/classroom-abm",
"url": "https://github.com/DurhamARC/classroom-abm/pull/19"
}
|
gharchive/pull-request
|
Added collaboration between students
Students' state is now affected by green (active) neighbours as well as red.
Also refactored changes in state to avoid multiple state changes per tick. As discussed with Peter, we now look at the current colour first, then make up to 1 change of colour per tick.
Changes have increased end maths scores by a large amount but we'll adjust that as part of the parameterisation.
|
2025-04-01T04:54:56.313372
| 2022-10-27T12:19:17
|
1425543516
|
{
"authors": [
"BluebirdStory",
"Dylan-H-Wang"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13810",
"repo": "Dylan-H-Wang/SLF-RPM",
"url": "https://github.com/Dylan-H-Wang/SLF-RPM/issues/3"
}
|
gharchive/issue
|
Question about Sparsity-Based Temporal Augmentation
Hi๐ , great job, yet I still got a question about the Sparsity-Based Temporal Augmentation.
In the paper you mentioned "each augmented clip was con- strained to have length of 30-frame. Therefore, the longest clip (i.e., stride of 5) contained 5-second information, while the shortest clip (i.e., stride of 1) had 1-second information" in section 4 Experiment Setup.
However, as far as I know, given two fix-length video clips(30-frame here), if they have different fps, then they ought to represent different heart rate(the larger the fps is, the lower the heart rate. the smaller the fps is, the larger the heart rate). The Sparsity-Based Temporal Augmentation used in the paper will generate two 30-frame clips with different HRs from the exact one source video.
Not only the HRs is different, so do other physiological signals I suppose.
Since the two fix-length video clips have different physiological signals, how can they be trained with contrastive loss? I mean, intuitively, the contrastive loss used in paper ought to help model learn the physiological signal invariance from two views of the same video and learn the difference of physiological signals from different video.
It's a bit confusing, I would be very appreciate if you could answer the questions, many thanks.
Hi,
Thank you for being interested in our work!
The sparsity-based temporal augmentation is designed based on the NyquistโShannon sampling theorem. Suppose the HR value we have is 120 bpm which means the sampling rate has to be at least 120/60*2=4, i.e., 4 fps. Theoretically, videos with over 4 fps should be able to recover the same HR if you can perfectly extract underlying signals from them. However, this is not realistic for the real-world application since there are too many noises we need to account. Therefore, our aim is to train a model which learns to ignore these noises and find the underlying invariant signals.
Think about the data augmentation settings in MoCo v2, they used random crop with ratio of [0.2, 1]. How do you expect two crops from corners look similar?
Cheers
Hi,
Thank you for your reply!
I am afraid I still can't follow up, the algorithm do work, but I am thinking it's because of something unknown instead of what's explained in the paper.
Here is an example.
Actually we need to notice that model does not see the fps or stride of the input video clip, it only see the input 30 frames. Imagine that we use stride 1 and stride 5 to generate two video clips respectively from exact same video, the video clip generated by stride 5 will squeeze 5-second BVP(or ECG) wave signal into 30 frames, while the stride-one video only squeeze 1-second BVP wave, thus the 5-second BVP will seem much denser than the 1-second BVP.
Specifically, say I have a 40-bmp video and a 200-bmp video, the video clip generated from the 40-bmp video using stride 5 will have exactly the same HR with the video clip generated from the 200-bmp video using stride 1, given that the model does not see fps or stride. I wonder how can the model recover the same HR?
Actually this is a data augmentation method used in rPPG field, by using stride to change the GT HR of a video, you can see it in ใRobust Remote Heart Rate Estimation from Face Utilizing Spatial-temporal Attentionใ.
Thank you for your patience, I would be very appreciate if you can replay, many thanks.
I see what you are confused about. I agree with your opinions about the change of HR due to the fps changes. The paper you refer is using HR ground truth to constrain the model and assumes the input video has the same time-length.
However, it is not our case and the underlying theory of our work remains the same. The objective of sparsity-based temporal augmentation is to find invariant recovered HR of the original videos instead of the processed clips. It is true that the HR of processed clip will change only if we say the signals behind them have the same time-length. But we do not have such labels to force this condition. Instead, we use contrastive loss to force the model recover the original video HR and model should learn the knowledge of stride/fps. Additionally, this knowledge is then reinforced by the later pseudo-label classification task.
Cheers
I get it now, thank you for your patience. I realized now that it's the rPPG version of MoCo, but not that intuitive, really wonder how the model can learn the knowledge of stride/fps.
Again, great work, many thanks ! ๐
|
2025-04-01T04:54:56.318769
| 2018-03-31T10:05:23
|
310229286
|
{
"authors": [
"anvu69",
"csotiriou",
"newah",
"pontusab",
"rayhk6",
"uusa35"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13811",
"repo": "DylanVann/react-native-fast-image",
"url": "https://github.com/DylanVann/react-native-fast-image/issues/175"
}
|
gharchive/issue
|
View config not found
"react": "^16.3.0",
"react-native": "0.54.4",
I get this error when running:
<FastImage source={{ uri }} resizeMode={FastImage.resizeMode.contain} />
+1
+1
+1
i installed it using pod and it's working fine now.
Probably it's a linker error. I unlinked and linked the FastImage library in Xcode again, and it worked.
So instead of running react-native link you can set up it manually for now to get it to work.
getting this error, but only sometimes (ios). Seems to work fine. But in the release I keep seeing it from time to time. Sometimes during initial load of the app, but also happens when app is already loaded, using FastImage successfully and suddenly this happens (we get crash reports)
"react-native": "0.59.3",
"react-native-fast-image": "^5.2.0",
|
2025-04-01T04:54:56.383852
| 2023-03-06T11:44:34
|
1611230003
|
{
"authors": [
"UnseenWizzard",
"edfenergy-stevebowerman"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13812",
"repo": "Dynatrace/dynatrace-configuration-as-code",
"url": "https://github.com/Dynatrace/dynatrace-configuration-as-code/issues/861"
}
|
gharchive/issue
|
Service Now alerting profile
Describe the bug
We may upgrade to Monaco v2 when its GA/supported. But until then, we we'll use v1.
We experience the following when trying to create Service Now alerting profiles:
Snippet of config
config:
- customer common services apis_pn_snow_high: service-now.json
customer common services apis_pn_snow_high:
- name: customer common services apis_pn_snow_high_{{ .Env.MONACO_ENV }}
- alertingProfile: config/alerting-profile/customer common services apis_ap_high.id
- instanceName: REDACTED
- username: REDACTED
- password: REDACTED
The service-now.json looks like this:
{
"type": "SERVICE_NOW",
"name": "{{ .name }}",
"alertingProfile": "{{ .alertingProfile }}",
"active": true,
"message": "{ProblemID} {ProblemTitle}",
"instanceName": "{{ .instanceName }}",
"username": "{{ .username }}",
"password": "{{ .password }}",
"sendIncidents": true,
"sendEvents": false
}
Resulting error:
You are currently using the old CLI structure which will be used by
default until monaco version 2.0.0
Check out the beta of the new CLI by adding the environment variable
"NEW_CLI".
We can't wait for your feedback.
2023-03-06 06:30:27 INFO Dynatrace Monitoring as Code v1.7.0
2023-03-06 06:30:27 INFO Executing projects in this order:
2023-03-06 06:30:27 INFO 1: config (131 configs)
2023-03-06 06:30:27 INFO Processing environment cky14011...
2023-03-06 06:30:27 INFO Processing project config...
2023-03-06 06:30:33 INFO Deployment summary:
2023-03-06 06:30:33 ERROR Deployment to cky14011 failed with error!
2023-03-06 06:30:33 ERROR Failed to create DT object customer common services apis_pn_snow_critical_secondary (HTTP 400)!
Response was: {"error":{"code":400,"message":"Validation failed for 2 Validators.","constraintViolations":[{"path":"builtin:problem.notifications/0/serviceNowNotification/url","message":"Given property 'url' with value: '' violates the following constraint: Size must be between 1 and 1000.","parameterLocation":"PAYLOAD_BODY","location":null},{"path":"builtin:problem.notifications/0/serviceNowNotification/url","message":"Given property 'url' with value: '' violates the following constraint: Not a valid http(s) URL.","parameterLocation":"PAYLOAD_BODY","location":null}]}}, responsible config: config/notification/service-now.json
2023-03-06 06:30:33 ERROR Errors during deployment! Check log!
How to reproduce
See above
Expected behavior
Service now alerting profile to be created
Log output
error dump above
Environment (please complete the following information):
OS: macOs Ventura, but same error on our AWS CodeBuild image
Tool version 1.7.0 (also tried with 1.8)
Additional context
Add any other context about the problem here.
Hi @edfenergy-stevebowerman, please read the API error message in the log you shared
"builtin:problem.notifications/0/serviceNowNotification/url","message":"Given property 'url' with value: '' violates the following constraint: Size must be between 1 and 1000."
Your JSON template is missing an URL.
If this problem persists after adding one/none is part of the Config API payload, this is an issue in the internal conversion from the deprecated API to the "builtin:problem.notifications" Settings schema.
In that case, please contact Dynatrace Support, letting them know you're facing issues with the Notifications API/Settings 2.0.
In either case, closing this as not a Monaco specific issue.
See also: https://www.dynatrace.com/support/help/dynatrace-api/configuration-api/notifications-api/models#servicenow-notification.
The description of the URL field being mutually exclusive to instanceName suggests that this may really be a problem in how this is validated as a Setting internally.
Hi, thanks for the response, but I have read the error message before posting.
url and instanceName are mutually exclusive. So as you can see in my posting, we've supplied the instanceName, but NOT the url in the service-now.json
However, monaco seems to disagree as I'm clearly NOT passing in the url attribute, just the instanceName.
However, monaco seems to disagree as I'm clearly NOT passing in the url attribute, just the instanceName.
As I tried to mention, this Error is coming from Dynatrace, not Monaco.
Monaco is not aware of the exact contents of the payload it simply fills the template and calls the Dynatrace API.
The log shows an HTTP 400 reply and the accompanying message.
As mentioned, I think this might be an issue with validating the "builtin:problem.notifications" Settings schema.
Please contact Dynatrace Support, letting them know you're facing issues with the Notifications API/Settings 2.0 not with monaco.
|
2025-04-01T04:54:56.738210
| 2023-01-25T07:55:03
|
1556205099
|
{
"authors": [
"sajo-ebi",
"sprintell"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13813",
"repo": "EBISPOT/gwas-ui",
"url": "https://github.com/EBISPOT/gwas-ui/issues/285"
}
|
gharchive/issue
|
GeneticVariant Traits - Rest endpoint to get all traits associated to a given Genetic Variant
As developer
I want an api endpoint
So that when I send a GET request, hateoas, paginated list of all traits associated to a given Genetic Variant in the database is returned in JSON Format
Management Rules:
Rule 1: Endpoint - /v2/variants/{variantId}/traits
Rule 2: HTTP Request Method - GET
Rule 3: HATEOAS, with filer, sorting, pagination, and sizing
Rule 4: Endpoint should accept filter, and sort parameters as in /traits?label=...&page=0&size=20&sort=...
Rule 6: Sort feature should be available for: traits
Rule 6: Returned Study Json entity must include: Trait Label(s), ReportedTrait(s), AssociationCount
Acceptance Tests:
Given no parameter
When the front end sends a GET request to the endpoint
Hateoas compliant list of studies is returned in the specified JSON Format
Given sorting, pagination, and/or some search and filter parameters
When the front end sends a GET request to thesame endpoint
Hateoas compliant filtered list of studies satisfying the conditions in the url parameter must be returned
@ala-ebi The API details are below
Uri -: http://gwas-snoopy.ebi.ac.uk:9780/gwas/api/v2/variants//traits
Search Params -:
@JsonProperty("reportedTrait")
private String reportedTrait;
@JsonProperty("efoTrait")
private String efoTrait;
Sort Params -:
associationCount
|
2025-04-01T04:54:56.743889
| 2023-05-16T15:41:50
|
1712280700
|
{
"authors": [
"ala-ebi",
"ljwh2",
"sajo-ebi",
"sprintell"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13814",
"repo": "EBISPOT/gwas-ui",
"url": "https://github.com/EBISPOT/gwas-ui/issues/350"
}
|
gharchive/issue
|
Some search boxes do not work
On this page: https://www.ebi.ac.uk/gwas/labs/downloads/summary-statistics, in the first table, typing in the Trait(s) box does not work.
Also, search box does not work for first author in studies table on any page
@sajo-ebi please add firstAuthor search param to the search params for Study
@ala-ebi the 'firstAuthor' param has been added to Studies endpoint
Done, waiting to be deployed
@ljwh2 Deployed in Dev http://gwas-snoopy.ebi.ac.uk:9780/gwas
Confirmed First author search now works
When searching by trait on the sumstats page: https://www.ebi.ac.uk/gwas/labs/downloads/summary-statistics I encountered an error on loading the page. Cleared the error and the table loaded without any data in the reported trait column. Searching in the Trait(s) box produced the error again, but the search did work after clearing the error.
Confirmed reported traits are still not displayed in sumstats table (but I don't see the error message now)
We expect this will not happen in prod
First author search box still does not work
See also goci#1107
needs releasing
Now released
|
2025-04-01T04:54:56.751512
| 2024-05-31T09:26:40
|
2327363714
|
{
"authors": [
"deepananbu",
"haideriqbal",
"henrietteharmse",
"yangyangmiao2019"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13815",
"repo": "EBISPOT/ols4",
"url": "https://github.com/EBISPOT/ols4/issues/671"
}
|
gharchive/issue
|
Ontologies load failure - OLS4
We are facing multiple issues while loading ontologies through OLS4. Below are the issues
OntologyId
Issue
Exception
abcd
Invalid URI
org.apache.jena.riot.RiotException: Bad character in IRI (space): http://rs.tdwg.org/abcd/terms/Specimen[space]...
battinfo
URL doesn't exist
org.apache.jena.riot.RiotNotFoundException: Not found: https://w3id.org/emmo/domain/battery/0.8.0-beta/battery
bdsubj
Content Type
org.apache.jena.riot.RiotException: Failed to determine the content type: (URI=https://purl.org/fidbaudigital/subjects : stream=text/plain)
peco
Content
org.apache.jena.riot.RiotException: [line: 1, col: 1 ] Content is not allowed in prolog.
hoom
Multiple Children
org.apache.jena.riot.RiotException: [line: 21, col: 74] {E201} Multiple children of property element
These ontologies are loaded successfully in OLS3. Is there a way/approach we can follow to load these ontologies in OLS4?
Hi @deepananbu, looking at the table you have provided I can see the majority of the issues you are facing are because of the format of the ontologies.
OLS4 only accepts ontologies which are in RDF/OWL format so this the ontology itself and all the imports need to be RDF format. If for example the ontology itself is not in RDF format or one of its import is not in RDF format then OLS would complain.
Just a note, PECO is already in OLS4 you can access it here: https://www.ebi.ac.uk/ols4/ontologies/peco
@haideriqbal - Do we have any workaround or temp solution to load these ontologies in OLS4? And what would be ideal solution to fix these kind of issues?
@deepananbu possible fix would be to convert your ontologies to RDF format. You can do this using protoge (https://protege.stanford.edu/) or robot (https://robot.obolibrary.org/)
http://www.ebi.ac.uk/efo/EFO_0009603 ่ฏท้ฎ ่ฟไธชๆฐๆฎๅฆไฝไธ่ฝฝ๏ผๆฅ๏ผ่ฏทๆฑๅธฎๅฉใ
@deepananbu I am closing this ticket for now as to the best of our knowledge this needs to be fixed on your side. Please feel free to open this again if this proves otherwise.
|
2025-04-01T04:54:56.781281
| 2023-10-23T09:32:50
|
1956747972
|
{
"authors": [
"Jesper276",
"TSKsmiley"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13816",
"repo": "ECDAR-AAU-SW-P5/Ecdar-GUI-Web",
"url": "https://github.com/ECDAR-AAU-SW-P5/Ecdar-GUI-Web/issues/71"
}
|
gharchive/issue
|
Right-click menu for systems and components
Through a right-click menu the user should be able to rename or delete.
this goes under #69
|
2025-04-01T04:54:56.826226
| 2024-11-25T08:32:13
|
2689748244
|
{
"authors": [
"willcattoneeca"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13817",
"repo": "EECA-NZ/home-efficiency-calculator",
"url": "https://github.com/EECA-NZ/home-efficiency-calculator/pull/15"
}
|
gharchive/pull-request
|
Tune model assumptions
This PR brings in some further improvements to the model configuration prior to the public launch scheduled for this Weds.
Updates the hot water model to account for outdoor cylinder location (for HWHP systems) and indoor location (for other cylinder types) and refines the efficiencies for natural gas hot water systems. Corrects wood thrown density and calorific value figures to match those in the reference.
Pre-filters plans to those from the big-four gentailers, reducing the risk of plans belonging to bundles e.g. with internet being mistakenly selected by the optimization routines. Modifies the gas-using household profile to not have gas space heating as this is uncommon in NZ. Updates the electricity and natural gas plans selected as a result.
Updates the lookup tables based on these new model assumptions.
Tests passing.
Happy to merge with gg-eeca's review.
|
2025-04-01T04:55:02.287206
| 2022-11-30T06:40:53
|
1469125023
|
{
"authors": [
"TEAM4-0",
"codecov-commenter"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13818",
"repo": "EMMC-ASBL/oteapi-services",
"url": "https://github.com/EMMC-ASBL/oteapi-services/pull/206"
}
|
gharchive/pull-request
|
[Auto-generated] Update dependencies
Update dependencies
Automatically created PR from ci/dependabot-updates.
For more information see the "Dependabot updates" workflow.
To-do
[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.
Codecov Report
Base: 68.43% // Head: 68.43% // No change to project coverage :thumbsup:
Coverage data is based on head (1f07385) compared to base (50bddac).
Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 68.43% 68.43%
=======================================
Files 17 17
Lines 491 491
=======================================
Hits 336 336
Misses 155 155
Flag
Coverage ฮ
pytest
68.43% <รธ> (รธ)
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
|
2025-04-01T04:55:02.310001
| 2018-07-19T20:52:46
|
342885173
|
{
"authors": [
"bluabaleno",
"jgiszczak",
"lazaridiscom"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13821",
"repo": "EOSIO/eos",
"url": "https://github.com/EOSIO/eos/issues/4758"
}
|
gharchive/issue
|
Plugin and Nodeos test failed.
30 - plugin_test (Failed)
31 - nodeos_sanity_test (Failed)
32 - nodeos_run_test (Failed)
34 - nodeos_run_test-mongodb (Failed)
35 - distributed-transactions-test (Failed)
36 - restart-scenarios-test-resync (Failed)
37 - restart-scenarios-test-hard_replay (Failed)
38 - restart-scenarios-test-none (Failed)
39 - validate_dirty_db_test (Failed)
40 - nodeos_sanity_lr_test (Failed)
41 - nodeos_voting_lr_test (Failed)
running Ubuntu as Windows Linux Subsystem with EOS.IO 1.10.0 build.
Windows Linux Subsystem is not supported. If you wish to discover why those tests are failing and submit pull requests that correct the problem on Windows, we will evaluate them for possible merging.
possibly related: #3842
Windows Linux Subsystem is not supported.
As things stand, the problem with the test-failures is not related to WSL
|
2025-04-01T04:55:02.317156
| 2020-05-21T19:39:06
|
622735264
|
{
"authors": [
"heifner",
"huangminghuang",
"spoonincode"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13822",
"repo": "EOSIO/eos",
"url": "https://github.com/EOSIO/eos/pull/9125"
}
|
gharchive/pull-request
|
Add unity build support for some targets
Change Description
This PR add support to enable cmake unity build for certain targets. Enabling unity build can significantly improve the build time for the project. However, it's not possible enable it globally with CMAKE_UNITY_BUILD because some of the libraries/submodules requires modification to make it work. This PR uses ENABLE_UNITY_BUILD flag to enable unity build for the targets don't have problem with it.
Consensus Changes
[ ] Consensus Changes
API Changes
[ ] API Changes
Documentation Additions
[ ] Documentation Additions
@spoonincode do you see any issues with providing this option?
I played with it some and I guess not. It does feel a little hokey needing to sprinkle these all through various cmakefiles. Unless someone is actively using the feature it risks becoming wrong/broken like a handful of other cmake stuff we have sprinkled about still.
IMO, the option should be enabled by default for CI build. This is build times I got from comparing the CI build with the ENABLE_UNITY_BUILD ON and OFF.
ENABLE_UNITY_BUILD=OFF
ENABLE_UNITY_BUILD=ON
Amazon Linux
26.35
18.15
CentOS
28.03
17.34
macOS.
23.14
18.34
Ubuntu 16.04
27.58
17.10
Ubuntu 18.04
24.38
15.19
Docker
21.59
16.45
Personally, I don't use build script in the EOS repo. I prefer to supply the cmake options I need and use ninja. Without unity build, using "ninja" for clean build without limiting jobs would freeze my Mac with 32 GB ram, I need to explicit limit the jobs to 4 to avoid it. With unity build, I don't need to specify the number of jobs and it also compiles a lot faster. I can even go as far as 18 jobs on my 8-core machine without any issues.
Should we be keeping CI & build script in parity?
|
2025-04-01T04:55:02.319374
| 2018-05-25T19:44:24
|
326642388
|
{
"authors": [
"Dylan-Phoon",
"jcalfee"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13823",
"repo": "EOSIO/eosjs",
"url": "https://github.com/EOSIO/eosjs/issues/115"
}
|
gharchive/issue
|
Post dawn4.1 updates
Updates to stay in sync with eosio/eos master..
Related: https://github.com/EOSIO/eosjs/issues/106
Ah, nice! pubkey account lookup back in :))
Released eosjs@13 passing with dawn-v4.2.0
|
2025-04-01T04:55:02.323072
| 2024-07-24T22:05:04
|
2428549253
|
{
"authors": [
"matt-frey",
"sjboeing"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13824",
"repo": "EPIC-model/epic",
"url": "https://github.com/EPIC-model/epic/pull/569"
}
|
gharchive/pull-request
|
Bugfixes to labelling
Resets the labels on restarts, and fixes a wrong ifdef.
Do we still need this branch?
|
2025-04-01T04:55:02.463355
| 2016-09-29T21:33:24
|
180168914
|
{
"authors": [
"cfrazier",
"hermesmarcom",
"hmaesta",
"janiosarmento",
"rahul286",
"rsmith4321",
"tuxcomputing"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13825",
"repo": "EasyEngine/easyengine",
"url": "https://github.com/EasyEngine/easyengine/issues/773"
}
|
gharchive/issue
|
Let's Encrypt cron time
When I set my first cert from Let's Encrypt, ee created the auto-renew cron.
But, different from what is showed in the docs, the cron was set to 0 0 * * *, which does not serve its purpose โ and I had to manually renew every site.
I think this is a bug (other people appears to have a similar issue), but besides that, it would not be better if the cron was executed every 10 days or something like that?
The documentation shows 0 12 * * *, which means everyday 12:00. That's not necessary, since Let's Encrypt allows renews 20 days before the expiration.
In my server, I use 0 23 */10 * *, so it can renew everything every 10 days at 23:00 (11pm), when load is low.
Right now I am running ee v3.7.4, but it was an older version when I set Let's Encrypt.
โ
0 23 */10 * * ee site update --le=renew --all 2> /dev/null
Thanks, I seem to have this same issue.
@hmaesta, are you getting automatic renewals processing correctly with the changes cron time?
@cfrazier I want to say Yes!, but one single website is not renewing and I don't know why โ but I don't think it is crontime's fault.
I recommend you set the cron job to renew SSL every 70 - 80 days like this:
0 23 */70 * * ee site update --le=renew --all 2> /dev/null
Because I myself got this error when renew SSL manually:
More than 30 days left for certificate Expiry. Not renewing now.
What if you have two or more sites, with non coincident expiry dates?
Think twice.
@janiosarmento If you have two or more sites with non coincident expiry dates, IMHO, there is no other way but setting the cron job for each website:
instead of
0 23 */70 * * ee site update --le=renew --all 2> /dev/null
using:
0 23 */60 * * ee site update site1.com --le=renew 2> /dev/null #if site1 has SSL from 1/1/2017 and today is no later than 30 days from 1/1/2017.
0 23 */60 * * ee site update site2.com --le=renew 2> /dev/null #if site2 has SSL from 15/3/2017 and today is no later than 30 days from 15/3/2017.
and so on.
You may have more efficient way to configure above crons. Read more at: https://www.pantz.org/software/cron/croninfo.html
Or you can make it run every day on midnight for both sites and then you're certain that your certificate is renewed :)
@tuxcomputing Have you tried? Have you got the error message:
More than 30 days left for certificate Expiry. Not renewing now.
@hermesmarcom it does not matter if you get the error or not. just run it through cron every night, set the output to 2> /dev/null and it will renew itself when you have less than 30 days. :)
We have handled this in a better way in v4.
You may check this PR https://github.com/EasyEngine/easyengine/pull/1005
Please use http://community.rtcamp.com/c/easyengine for future support questions.
|
2025-04-01T04:55:02.492783
| 2022-10-24T18:40:33
|
1421259853
|
{
"authors": [
"Akash190104",
"shrn01"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13826",
"repo": "EbookFoundation/free-programming-books",
"url": "https://github.com/EbookFoundation/free-programming-books/issues/8919"
}
|
gharchive/issue
|
CODE_OF_CONDUCT-bn
I would like to create the code of conduct in Bengali. Please assign this issue to me.
@Akash190104 please feel free to add it. Add fixes #8919 to the PR to close this issue automatically
|
2025-04-01T04:55:02.496069
| 2020-08-19T01:44:59
|
681485805
|
{
"authors": [
"Kim-SuBin",
"eshellman"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13827",
"repo": "EbookFoundation/free-programming-books",
"url": "https://github.com/EbookFoundation/free-programming-books/pull/3677"
}
|
gharchive/pull-request
|
[Update] free-programming-books-ko.md
What does this PR do?
Add Resource(s)
For resources
Add Raspberry pi free docs link.
Why is this valuable (or not)
I thought it was worth it because it would help Koreans use raspberry pi.
How do we know it's really free?
Free online books from WikiDocs.
For book lists, is it a book?
To be exact, it is a translation of the official Raspberry Pi document.
Checklist:
[x] Not a duplicate
[ ] Included author(s) if appropriate
[x] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)
Thanks, and welcome to free-programming-books!
|
2025-04-01T04:55:02.529152
| 2023-10-29T07:49:01
|
1966883400
|
{
"authors": [
"SaraJaoude",
"mrical"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13828",
"repo": "EddieHubCommunity/BioDrop",
"url": "https://github.com/EddieHubCommunity/BioDrop/issues/9660"
}
|
gharchive/issue
|
[BUG] Edit button to manage link is not positioned properly
Has this bug been raised before?
[X] I have checked "open" AND "closed" issues and this is not a duplicate
Where did you find this bug?
production on biodrop.io
Version of BioDrop (for example "v1.2.3")
v2.83.8
Description
The Edit button on the /account/manage/links page is not positioned correctly, which results in visual inconsistency and usability problem. This affects the user experience when attempting to manage links in their account.
Screenshots
Do you want to work on this issue?
Yes
If you want to work on this issue...
To fix this issue I will be changing the position of edit link/button using Tailwind CSS styles
Thank you for raising - this has been raised before. This will be improved as part of the redesign process which is coming up, so I will close this for now.
|
2025-04-01T04:55:02.533233
| 2023-04-06T06:00:11
|
1656715886
|
{
"authors": [
"ChinmayMhatre",
"StarKnightt"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13829",
"repo": "EddieHubCommunity/LinkFree",
"url": "https://github.com/EddieHubCommunity/LinkFree/pull/5874"
}
|
gharchive/pull-request
|
data:StarKnightt
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.
Screenshots
Note to reviewers
Please check the rest of the icons from the set of available icons at : https://linkfree.io/icons
looks good
Thank YOU
|
2025-04-01T04:55:02.535996
| 2021-02-09T20:22:45
|
804891137
|
{
"authors": [
"BrendaMichellle",
"schmelto"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13830",
"repo": "EddieHubCommunity/awesome-github-profiles",
"url": "https://github.com/EddieHubCommunity/awesome-github-profiles/issues/353"
}
|
gharchive/issue
|
Brenda Michelle
Due we close new issues on PR merge and voting is still possible on closed issues I will close this one. Nice Profile btw ๐
|
2025-04-01T04:55:02.537459
| 2021-10-20T09:02:48
|
1031157043
|
{
"authors": [
"schmelto",
"shrejal99"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13831",
"repo": "EddieHubCommunity/awesome-github-profiles",
"url": "https://github.com/EddieHubCommunity/awesome-github-profiles/pull/785"
}
|
gharchive/pull-request
|
add shrejal99
resolve #784
Maybe you could consider using more like an image like this:
Thanks for your contribution ๐
|
2025-04-01T04:55:02.538959
| 2023-11-21T06:56:52
|
2003585730
|
{
"authors": [
"ORUNSOLU",
"schmelto"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13832",
"repo": "EddieHubCommunity/open-source-practice",
"url": "https://github.com/EddieHubCommunity/open-source-practice/pull/3295"
}
|
gharchive/pull-request
|
Add Oludayo Orunsolu
Related issue
What changes does this PR do?
added Oludayo Orunsolu to the contributors list to complete the AllInOneAfrica challenge
Screenshots (If any)
Questions
closing due to inactivity feel free to reopen
|
2025-04-01T04:55:02.540645
| 2020-11-07T17:24:19
|
738282620
|
{
"authors": [
"BOLT04",
"EugeneGohh",
"eddiejaoude"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13833",
"repo": "EddieJaoudeCommunity/awesome-github-profiles",
"url": "https://github.com/EddieJaoudeCommunity/awesome-github-profiles/issues/162"
}
|
gharchive/issue
|
Reshaping my GitHub profile
Anyone interested to work together? I wanna reshape my GitHub profile. (ps I am a beginner willing to learn from Open Source.)
Hi @EugeneGohh ๐, are you interested in working in any of the repositories of this organization? If you don't have a project that you like, try to pitch your idea for a new project on Discord, and see if more people like it ๐
@EugeneGohh in addition to what @BOLT04 mentioned. Have you looked at the examples in this repo? Your GitHub profile looks great, but if you want more ideas or inspiration, have a look at the README in this project - it has lots of examples
|
2025-04-01T04:55:02.548882
| 2020-11-02T09:19:19
|
734335873
|
{
"authors": [
"akshitagupta15june",
"eddiejaoude",
"yash982000"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13834",
"repo": "EddieJaoudeCommunity/support",
"url": "https://github.com/EddieJaoudeCommunity/support/issues/401"
}
|
gharchive/issue
|
Please invite me to the GitHub Community Organisation
Invitation will be sent for the GitHub Organisation soon. We look forward to having you part of our community :nerd:
Don't forget after accepting to make it public so it appears on your github profile for everyone else to see, you can do this by finding your name in the github organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practicing:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps
@eddiejaoude when will i receive an invitation?
@akshitagupta15june Hey, you will soon receive the invitation. The above message is from the bot which is automated but the invitation is yet to be automated, on which I have been assigned and currently working on.
@akshitagupta15june Meanwhile you can join the discord server here:- https://discord.gg/pQt7d2mK
Ok @yash982000 will join dicord
I would love to be the part of this organisation @eddiejaoude
I would love to be the part of this organisation @eddiejaoude
You will get an invite soon. Meanwhile, have an eye on issues/features you can work on.
@akshitagupta15june please stop spamming the community, we have received your many notifications that you want to join the community - we appreciate your enthusiasm but this does not speed up the progress and only causes extra work for the community. Please remember open source maintainers are people, these people have day jobs and families. Do not worry you will receive the invitation to the organisation soon.
As @yash982000 mentioned, you can already start getting involved and contributing to the community and our projects - therefore your organisation invitation is not blocking you ๐ค
Invitation sent for the GitHub Organisation. Welcome to the community ๐
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps
|
2025-04-01T04:55:02.550895
| 2016-06-27T11:13:29
|
162427868
|
{
"authors": [
"codecrab-studios"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13835",
"repo": "EddyVerbruggen/SocialSharing-PhoneGap-Plugin",
"url": "https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/626"
}
|
gharchive/issue
|
App Freezes when sharing..Plugin v5.1.1
Hi
I did installed the the plugin, when i hit a button to share, it freezes the app and takes too much time and sometimes, it crashes the app.
Can you please help!
Note: iOS and Android both!
Regards
Amandeep
On Emulator it works without any issues... it is happening only in Real Device!
Nevermind, i got it resolved, it was just due to a wrong url being passed on the the Image, which took too long to respond!
|
2025-04-01T04:55:02.555223
| 2017-07-28T11:08:45
|
246317552
|
{
"authors": [
"theely",
"vivekpd15"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13836",
"repo": "EddyVerbruggen/cordova-plugin-safariviewcontroller",
"url": "https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/71"
}
|
gharchive/issue
|
Chrome custom tabs - Prevent to display App Chooser Dialog
If multiple application that can handle the CustomTabIntent are installed on the device when trying to open the Chrome custom tabs the user is presented with the App Chooser Dialog.
Can we do anything to prevent this? Why would we want the user to select something different?
Possible solution approach:
https://stackoverflow.com/questions/38429630/custom-chrome-tabs-asks-for-multiple-browser-to-choose
When I tried installing the new version. I am getting this error while building, any idea what could have gone wrong?
platforms/android/src/com/customtabplugin/ChromeCustomTabPlugin.java:133: error: method getPackageNameToUse in class CustomTabsHelper cannot be applied to given types;
String packageName = CustomTabsHelper.getPackageNameToUse(cordova.getActivity(), url);
^
required: Context
found: Activity,String
reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':compileArmv7DebugJavaWithJavac'.
Compilation failed; see the compiler error output for details.
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
|
2025-04-01T04:55:02.569110
| 2022-05-02T14:07:55
|
1222934934
|
{
"authors": [
"Gako358"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13837",
"repo": "EdenEast/nightfox.nvim",
"url": "https://github.com/EdenEast/nightfox.nvim/issues/149"
}
|
gharchive/issue
|
Treesitter error when loading colorscheme
Description
A description of the issue.....
vim.cmd(colorscheme nightfox) is giving an treesitter error
ERROR: vim(highlights):/usr/share/nvim/runtime/lua/vim/treesitter/query.lua:172: query: invalid node type at position 765
Behavior
The colorscheme is working, but giving minor tresitter parsing errors
Any additional info like neovim version (nvim -v), terminal, platform, etc to help with resolution
Neovim 0.7
This was a treesitter errore, was fixed with updating treesitter, feel stupid...
|
2025-04-01T04:55:02.613416
| 2016-07-21T13:54:24
|
166825074
|
{
"authors": [
"EdouardTack",
"Palloquin"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13840",
"repo": "EdouardTack/candlestick",
"url": "https://github.com/EdouardTack/candlestick/pull/10"
}
|
gharchive/pull-request
|
add allowManualNc option
replaced $ with jQuery to allow noConflict() versions where the default jQuery alias $ is used by another application
I've added a 'allowManualNc' setting to create a way where the user can not manually select the default/no value option.
Hello,
First of all, thank you for contribution. You have 2 differents points on this pull request, can you create 2 branches with this 2 contributions ? In this way, i can merge separatly this issues.
For the first point, i don't think the replacement of $ by jQuery is the best way for the noConflict(). I see it on diffrent jQuery plugin, they used
(function($) {
Plugin code
}(jQuery));
Maybe is the "use strict" the problem.
You use jQuery and what other javascript library ? You have tried this different possibilities ?
Second point, when you separate it, i will try this.
Palloquin,
My commit 2d58110 fix the noConflict() problem.
Clear, I'll recreate a sepperate pull
|
2025-04-01T04:55:02.619741
| 2023-06-05T19:02:10
|
1742397089
|
{
"authors": [
"Edzelf",
"buddyroar"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13841",
"repo": "Edzelf/ESP32Radio-V2",
"url": "https://github.com/Edzelf/ESP32Radio-V2/issues/106"
}
|
gharchive/issue
|
Need Help!!!
Arduino: 1.8.19 (Windows Store <IP_ADDRESS>) (Windows 10), Board: "DOIT ESP32 DEVKIT V1, 80MHz, 115200, None, Disabled"
C:\Users\Buddy\Documents\Arduino\libraries\utils\utils.cpp:29:6: error: ambiguating new declaration of 'void dbgprint(const char*, ...)'
void dbgprint ( const char* format, ... )
^~~~~~~~
In file included from C:\Users\Buddy\Documents\Arduino\libraries\utils\utils.cpp:5:
C:\Users\Buddy\Documents\Arduino\libraries\utils\utils.h:11:13: note: old declaration 'char* dbgprint(const char*, ...)'
char* dbgprint ( const char* format, ... ) ; // Print a formatted debug line
^~~~~~~~
Multiple libraries were found for "WiFi.h"
Used: C:\Users\Buddy\Documents\ArduinoData\packages\esp32\hardware\esp32\2.0.6\libraries\WiFi
Not used: C:\Program Files\WindowsApps\ArduinoLLC.ArduinoIDE_<IP_ADDRESS>_x86__mdqgnx93n4wtt\libraries\WiFi
exit status 1
Error compiling for board DOIT ESP32 DEVKIT V1.
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
Looks like you have mixed versions. Please load the complete zip-file, upload sketch and data dairectory.
Could you explain what you mean by mixed versions?
Sorry, my fault. Just a moment.
Correct version is now available.
Thank you, I will try to upload the new version once Iโm home tonight.
|
2025-04-01T04:55:02.622609
| 2022-06-03T22:49:47
|
1260472907
|
{
"authors": [
"Eeems"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13842",
"repo": "Eeems-Org/oxide",
"url": "https://github.com/Eeems-Org/oxide/issues/261"
}
|
gharchive/issue
|
Touching screen with pen wakes device from sleep
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Suspend device
Tap on screen with pen
Device wakes from sleep
Expected behavior
Nothing happens
Version Information:
Device: reMarkable 1
OS: 2.12
Version v2.4
I can't replicate this anymore.
|
2025-04-01T04:55:02.637584
| 2024-08-16T18:08:48
|
2470730910
|
{
"authors": [
"IMax153",
"cdierkens"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13843",
"repo": "Effect-TS/effect",
"url": "https://github.com/Effect-TS/effect/pull/3466"
}
|
gharchive/pull-request
|
fix: respect the default for a text prompt
Type
[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Optimization
[ ] Documentation Update
Description
This PR respects the default value passed in when creating a
Example
const prompt = Prompt.text({
message: "This is a prompt with a default value",
default: "default-value", // <-- This value does not populate before this PR
});
[!WARNING]
I attempted to model the Wizard tests, but could not get the Enter key to effect the program exit.
Related
Closes #3465
@cdierkens - looks like there are some linting issues. If you run pnpm lint-fix it should take care of those issues.
@cdierkens - looks like there are some linting issues. If you run pnpm lint-fix it should take care of those issues.
@IMax153 Done and done.
|
2025-04-01T04:55:02.648806
| 2024-12-02T15:45:08
|
2712409743
|
{
"authors": [
"EgorBot"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13844",
"repo": "EgorBot/runtime-utils",
"url": "https://github.com/EgorBot/runtime-utils/issues/194"
}
|
gharchive/issue
|
EgorBot for AndyAyersMS in #110258
Processing https://github.com/dotnet/runtime/pull/110258#issuecomment-2511891015 command:
Command
-intel -arm -profiler --envvars DOTNET_TC_CallCounting:0 DOTNET_TieredPGO_InstrumentOnlyHotCode:0 DOTNET_TieredPGO_ScalableCountThreshold=1E
using BenchmarkDotNet.Attributes;
public class Bench
{
int a = 0;
int b = 0;
int c = 0;
int d = 0;
int e = 0;
[Benchmark]
public int Test()
{
int zeros = 0;
Parallel.For(0, 1024, i =>
{
int zeros = 0;
int nonzeros = 0;
if (a == 0)
zeros++;
else nonzeros++;
if (b == 0)
zeros++;
else nonzeros++;
if (c == 0)
zeros++;
else nonzeros++;
if (d == 0)
zeros++;
else nonzeros++;
if (e == 0)
zeros++;
else nonzeros++;
});
return zeros;
}
}
(EgorBot will reply in this issue)
Benchmark results on linux_azure_cobalt100
BDN_Artifacts.zip
Profiling for Bench_Test:
SVG flamegraph: Main vs PR ๐ฅ
Speedscope flamegraph: Main vs PR
Hot asm code: Main vs PR
HW counters: Main vs PR
cc @AndyAyersMS (agent_logs.txt). EgorBot manual: link.
Benchmark results on linux_azure_cascadelake
BDN_Artifacts.zip
Profiling for Bench_Test:
SVG flamegraph: Main vs PR ๐ฅ
Speedscope flamegraph: Main vs PR
Hot asm code: Main vs PR
HW counters: Main vs PR
cc @AndyAyersMS (agent_logs.txt). EgorBot manual: link.
|
2025-04-01T04:55:02.651313
| 2023-09-20T06:34:11
|
1904260424
|
{
"authors": [
"expipiplus1"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13845",
"repo": "EightB1ts/uni-sync",
"url": "https://github.com/EightB1ts/uni-sync/issues/3"
}
|
gharchive/issue
|
Why does this need to be a service
Hi, I suppose this is a documentation issue.
It's not clear to me from the readme why this has to be run as a service as all the commands (toggle rgb, pwm mode; set speed) seem to be one shot commands.
I would expect it to be a cli tool uni-sync --enable-motherboard-pwm-following sort of thing.
What am I missing :)
oh, it's just a one shot hah
|
2025-04-01T04:55:02.755755
| 2019-02-12T16:58:17
|
409401722
|
{
"authors": [
"ibdf",
"zackfly"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13846",
"repo": "ElemeFE/element",
"url": "https://github.com/ElemeFE/element/issues/14344"
}
|
gharchive/issue
|
can't update el-input value when using :value
I'm using Element with Vuex, so the input values come from the store (computed) and are set using :value and not v-model because I have a function to update the value on the store on blur.
I believe this is a common pattern when using vuex.
The problem is, if I use :value in el-input I can't type anything. I can't change the current text. It only seems to work with v-model.
@ibdf
|
2025-04-01T04:55:02.761538
| 2021-06-07T12:48:53
|
913511883
|
{
"authors": [
"cs1707",
"smg99"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13847",
"repo": "ElemeFE/element",
"url": "https://github.com/ElemeFE/element/issues/21051"
}
|
gharchive/issue
|
[Bug Report] Select Component does not blur on press of escape key
Element UI version
2.15.2
OS/Browsers version
Chrome Version 91.0.4472.77
Vue version
2.6.14
Reproduction Link
codepen.io?https://element.eleme.io/#/en-US/component/select
Steps to reproduce
Goto https://element.eleme.io/#/en-US/component/select#basic-usage
Select basic dropdown - it will open dropdown
Press escape once - it will close dropdown
Press escape again - nothing happens
What is Expected?
Goto https://element.eleme.io/#/en-US/component/select#basic-usage
Select basic dropdown - it will open dropdown
Press escape once - it will close dropdown
Press escape again - it should blur select (similar to what is does for other components like input, datepicker, datetime picker)
What is actually happening?
Goto https://element.eleme.io/#/en-US/component/select#basic-usage
Select basic dropdown - it will open dropdown
Press escape once - it will close dropdown
Press escape again - nothing happens
Default browser behavior
|
2025-04-01T04:55:02.764332
| 2017-05-11T07:13:53
|
227898341
|
{
"authors": [
"Leopoldthecoder",
"Simonalia"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13848",
"repo": "ElemeFE/element",
"url": "https://github.com/ElemeFE/element/issues/4805"
}
|
gharchive/issue
|
[Bug Report] selected item cann't show when using el-select
Element UI version
1.3.2
OS/Browsers version
Windows 10, Chrome 58.0
Vue version
2.3.3
Reproduction Link
https://jsfiddle.net/api/post/library/pure/
Steps to reproduce
Import el-select and el-option alone,
Click an option
What is Expected?
selected item show up in the select component
What is actually happening?
selected item cann't show.
It should work if the versions (Vue and Element) you submitted are correct.
|
2025-04-01T04:55:02.783032
| 2016-07-27T15:46:43
|
167887885
|
{
"authors": [
"nicholas-leonard",
"sagarwaghmare69"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13849",
"repo": "Element-Research/dataload",
"url": "https://github.com/Element-Research/dataload/pull/11"
}
|
gharchive/pull-request
|
Twitter
Skipping neutral tweets. Unit tested.
Updated README.
@sagarwaghmare69 The PR was merged to master (yours is a PR for the twitter branch). All you commits got merged.
|
2025-04-01T04:55:03.008149
| 2021-03-15T03:08:51
|
831366265
|
{
"authors": [
"Jake-Shadle",
"MaulingMonkey"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13850",
"repo": "EmbarkStudios/cargo-about",
"url": "https://github.com/EmbarkStudios/cargo-about/issues/147"
}
|
gharchive/issue
|
Missing .vscode/settings.json
Describe the bug
Embark Guidelines state:
As we want to run rustfmt on save, all of our repos should have a .vscode/settings.json with:
{
"editor.formatOnSave": true,
}
But this file is missing from cargo-about.
We don't expect everyone to use VSCode, this is just a local setup suggestion to improve your own workflow, all of our repos require the rustfmt check passes in CI regardless.
|
2025-04-01T04:55:03.010972
| 2022-11-07T08:41:01
|
1437975123
|
{
"authors": [
"emilk",
"repi"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13851",
"repo": "EmbarkStudios/puffin",
"url": "https://github.com/EmbarkStudios/puffin/pull/107"
}
|
gharchive/pull-request
|
Publish puffin 0.14.0
Checklist
[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below
Description of Changes
This publishes a new version of puffin. Mostly because I want https://github.com/EmbarkStudios/puffin/pull/98.
@emilk you'll also need to release compatible versions of puffin-imgui and puffin-egui right? as they can't be used with this new puffin release
|
2025-04-01T04:55:03.017203
| 2019-12-05T00:51:27
|
533051632
|
{
"authors": [
"AGlass0fMilk",
"MichalPrincNXP"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13852",
"repo": "EmbeddedRPC/erpc",
"url": "https://github.com/EmbeddedRPC/erpc/pull/81"
}
|
gharchive/pull-request
|
Add mbed os support
Add support to use erpc with Mbed-OS.
Hello @AGlass0fMilk , please rebase to the head of the develop branch (1.7.3 version) and follow instructions about code formatting as described here: https://github.com/EmbeddedRPC/erpc/wiki/Contributing (avoid using tabs).
Also, could you point to an example project with mbedOS that we could use for build testing? Thanks.
Hi @MichalPrincNXP,
I rebased with the current head of the develop branch and I reformatted my changes to remove tabs.
You can find example projects using MbedOS here: https://github.com/EmbeddedPlanet/mbed-rpc
Hi @AGlass0fMilk,
your pull request looks good. We prefer the PR integration into the develop branch first, the main branch should be used for main releases. I have added this note into the https://github.com/EmbeddedRPC/erpc/wiki/Contributing As per this, could you please rebase your PR to the develop branch?
As for the mbedOS app. build testing, this would require certain effort to setup the build environment on our side. Because it is out of our focus now we can accept your PR, supposing you have tested the mbedOS port in your project. Once there are any issues reported to the mbedOS port we will route them to you. Are you OK?
Another way how to ensure mbedOS build testing is the Travis. Would you be able to prepare erpc project .travis.yml update to add an mbedOS erpc app build? This could be done as a separate PR. Thanks.
Hello @AGlass0fMilk , did you have a chance to read my last comment? Thank you.
Hi @MichalPrincNXP. Yes I will rebase soon. This is again relevant to customer projects so I'll be able to devote some more time to it.
I can look into setting up the travis as well.
@MichalPrincNXP I rebased this PR to develop, can you review?
Thank you @AGlass0fMilk for rebasing, your pull request looks good and could be merged.
Once there is any question about mbedOS support it will be routed to you as stated in my previous comment. It would be also good if you could invest time to the Travis update, preparing another pull request.
@AGlass0fMilk , I have missed that the correct name of the added cpp files should be erpc_threading_mbed.cpp (instead of erpc_port_mbed.cpp) to be aligned with other port layer files naming. Just note, that I will do the renaming.
Any progress on the Travis?
Thanks.
|
2025-04-01T04:55:03.035470
| 2024-07-20T08:48:57
|
2420738512
|
{
"authors": [
"Emoun",
"Veetaha"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13853",
"repo": "Emoun/duplicate",
"url": "https://github.com/Emoun/duplicate/issues/63"
}
|
gharchive/issue
|
allow cfg attributes on substitution groups
Short Description:
Allows the use of cfg attributes on substitution groups, such that they can be enabled and disabled at build time.
Motivation:
See this code.
Here, they use two cfg_attrs to remove one substitution group based on whether a specific feature is enabled.
This is a bit ugly, as the two invocations of duplicate are identical except for the second substitution group not being present on the second invocation.
Therefore, the first substitution group is actually copied between the two invocations.
It would be better to be able to, within the invocation itself, be able to disable a substitution group using a method akin to cfg_attr.
Design
This could be one way of designing it (this is using verbose syntax to match that of the above example):
duplicate_item(
[
module_type [non_blocking]
maybe_async_attr [maybe_async::must_be_async]
File [tokio::fs::File]
HttpBody [reqwest::Body]
HttpClient [reqwest::Client]
]
#[cfg_attr(feature = "non_blocking")]
[
module_type [blocking]
maybe_async_attr [maybe_async::must_be_sync]
File [std::fs::File]
HttpBody [reqwest::blocking::Body]
HttpClient [reqwest::blocking::Client]
]
))]
This will disable the second substitution group when the non_blocking feature is disabled, exactly like the current semantics of the above example.
This would work the same way for the short syntax and global substitutions (where each attribute would work on just one substitution group or substitution).
Misc:
Open questions:
[ ] Could this be implemented by calling cfg_attr directly from duplicate, such that it can return an empty string when the cfg is false?
[ ] Can this be extended to any attribute macro and not just cfg or cfg_attr?
I just noticed how much context that discussion assumes. I recommend you to just take a look at this code comment here instead.
The idea is that when the proc macro detects any usage of cfg/cfg_attr attributes it generates a transitively-recursive call to the macro_rules (I posted a link to it). Then macro_rules generate use items that dispatch to true/false variants of macro_rules and then they collect the results of all cfg predicates evaluations into a list and call back to the original proc macro with #[macro_name(___cfgs(results) ...)] prrepended in the argument list
@Veetaha thank you for your explanations and links. It good to know that there probably is a workable implementation, though I would need to sit down and focus to really get my head around how it works.
|
2025-04-01T04:55:03.050177
| 2020-03-09T18:35:14
|
578111032
|
{
"authors": [
"enmasse-ci",
"k-wall"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13854",
"repo": "EnMasseProject/enmasse",
"url": "https://github.com/EnMasseProject/enmasse/pull/4078"
}
|
gharchive/pull-request
|
Increase the AMQP idle timeout
Type of change
Bugfix
Description
#4040 added an idle timeout to the Agent's container when connecting to the Brokers and Routers. Testing showed the the the idle timeout was too short, and this resulted in spurious connection aborts (which triggered #4077)
Increased the idle timeout.
Corrects the use of Rhea API to pass the idle_time_out as an option.
Checklist
[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md
@enmasse-ci run tests profile=isolated
:x: Test Summary :x:
TEST_PROFILE: isolated
TEST_CASE:
TOTAL: 122
PASS: 117
FAIL: 2
SKIP: 3
BUILD_NUMBER: 99
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:
testSelfSigned in io.enmasse.systemtest.isolated.certs.CertProviderTest
testAddressSpaceRules in io.enmasse.systemtest.isolated.monitoring.MonitoringTest
|
2025-04-01T04:55:03.068702
| 2017-05-03T08:54:37
|
225920243
|
{
"authors": [
"WLCIssuesBot"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13855",
"repo": "Enerccio/wlc",
"url": "https://github.com/Enerccio/wlc/issues/34"
}
|
gharchive/issue
|
Create tty switch event handler
Issue by Luminarys
Saturday Aug 22, 2015 at 22:48 GMT
Originally opened as https://github.com/Cloudef/wlc/issues/59
Right now, outputs which are sleeping will be woken up again when the tty is switched. A handler for the tty switch event would prevent this.
Comment by Cloudef
Wednesday Apr 06, 2016 at 14:58 GMT
If the above changes are enough for your needs, feel free close this issue.
Comment by Cloudef
Wednesday Apr 06, 2016 at 14:57 GMT
Output context change events were added that basically trigger this behaviour. It's not really TTY switch event per se, but indicates whenever the context for output was tear down'd and recreated. During creation the output would wake up.
https://github.com/Cloudef/wlc/commit/f21ec4055ff4c937e0c6968de75bbcbce5a47487
|
2025-04-01T04:55:03.071320
| 2022-09-21T10:14:41
|
1380681489
|
{
"authors": [
"PerTHenriksen",
"prtandrup"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13856",
"repo": "Energinet-DataHub/geh-charges",
"url": "https://github.com/Energinet-DataHub/geh-charges/issues/1670"
}
|
gharchive/issue
|
Receive RSM-034 file when peeking and requesting a JSON format
Synopsis:
As a datahub user,
I want to receive an RSM-034 in json format when Peeking
Acceptance criteria:
[ ] (1) When peeking in JSON, Datahub will deliver an RSM-034 in JSON format
Blocked due system test stopping deployment (authorization issue with client secret)
|
2025-04-01T04:55:03.077259
| 2021-11-10T06:52:55
|
1049462498
|
{
"authors": [
"MadsBloendAndersen",
"mogensjuul"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13857",
"repo": "Energinet-DataHub/green-energy-hub",
"url": "https://github.com/Energinet-DataHub/green-energy-hub/issues/214"
}
|
gharchive/issue
|
Migration Control
Problem Description
After CGI extracts data from an MP, these are stored in a Json file and transferred to DataHub V3 and stored in a Blob store in Azure.
There is a need to make two automatic checks:
Benefit Hypothesis
We are then able to control that the content of the migration files is correct and the values is ready for for the import process
Acceptance criteria and must have scope
AC 1: Create 1 File containing all filenames for controlling all transferred files in 24 hours
Check that the number of files sent by CGI is also stored in the Blob store. T his is done by creating an autojob that makes a list that shows which files have been stored in the Blob store for the past day. The file should show the name and file size of each file. The file must be saved in an agreed location.
The job should run 10 minutes after midnight each day.
AC2: Selection of 150 random files transferred the day before.
There must be 150 random files of those transferred the day before. These files are transferred and stored in an agreed location. The job should run automatically and should run 10 minutes after midnight each day.
Objectives and key results
Increased confidence and and part off the requirement for audit.
Leading Indicators
Non Functional Requirements
none
Stakeholders
Rasmus Juul Holm Christiansen, PBR, ++
Timeline PI 6
###Ressources: Titans,
@tml fjernet fra Titans og flyttet til Art. @ENDK-RHC hรฅndterer selvstรฆndigt
@mogensjuul skal denne feature lukkes?
|
2025-04-01T04:55:03.097270
| 2020-10-23T12:52:59
|
728194005
|
{
"authors": [
"AntonOellerer",
"EnricoMi"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13858",
"repo": "EnricoMi/publish-unit-test-result-action",
"url": "https://github.com/EnricoMi/publish-unit-test-result-action/issues/34"
}
|
gharchive/issue
|
Status message on Github Action Summary Page
Hey,
On the summary page of failed github workflows, in the "Annotations" Section, the failed tests are displayed as warnings for me.
Furthermore, they always recommend to check line 0 in the failed file. (See image below)
Do you know what the reason for this is?
Best regards
Anton
They have warning level because the action uses warning for failed tests and error for test errors.
The annotation has a non-zero line when the respective unit test file (here TEST-com.test.impl.Test.xml) provides a line number and 0 otherwise.
Ok, thank you
Do you know how to enable line number reporting?
Like is this a flag in JUnit5, do you have to implement it yourself, or something similar?
|
2025-04-01T04:55:03.100399
| 2023-11-16T15:41:49
|
1997159215
|
{
"authors": [
"JAlvarezJarreta"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13859",
"repo": "Ensembl/ensembl-genomio",
"url": "https://github.com/Ensembl/ensembl-genomio/pull/220"
}
|
gharchive/pull-request
|
Enable trace file by default with useful field information
With the inclusion of a logging system, this information is not stored in .nextflow.log but in each process' .command.log file (for the "default" StreamHandler, i.e. stderr). Thus I have introduced a nice default format for the trace to have an easy way to access a given process' working directory (will need to tun your pipeline with nextflow run ... -with-trace for it to be produced).
I have also left a comment with guidelines in how to use filters, in case we want to only generate traces for failed tasks and/or specific modules for some pipelines.
I have also added a Markdown template for the log report (following @ens-LCampbell's suggestion) and updated the README file to give some guidance on how to use all these new features.
Looks good to me. However, what is the rational for having two NXF README docs on in pipelines/nextflow and one in docs/nextflow ? Do they need to be separate files or could we combined all into the docs/nextflow.md ?
It was already there :see_no_evil: But yes, it makes sense to reduce documentation where possible to avoid duplication of efforts. Will create a JIRA ticket for that since it is out of the scope of this PR.
|
2025-04-01T04:55:03.109969
| 2023-11-24T15:48:05
|
2009921229
|
{
"authors": [
"devanoneth",
"fleupold"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13860",
"repo": "EnsoFinance/temper",
"url": "https://github.com/EnsoFinance/temper/pull/24"
}
|
gharchive/pull-request
|
Make content_length_limit configurable
Currently content_length_limit is hardcoded to 16KB, leading to errors of kind
Handling rejection: Rejection(PayloadTooLarge)
unhandled rejection: Rejection(PayloadTooLarge)
INFO ts::api > <IP_ADDRESS>:52125 "POST /api/v1/simulate HTTP/1.1" 500 "-" "curl/7.79.1" 686.917ยตs
when trying to simulate batched intent beauties like https://etherscan.io/tx/0x8d1feb91a6ca9398607b7f02177b61425b1a64d511fcccb9ef7a60becdde0a7b
This PR adds an optional config value that allows to configure this value and allow processing larger request bodies.
Test Plan
Above mentioned transaction simulates successfully when MAX_REQUEST_SIZE=32
Thanks for your contribution @fleupold! :)
|
2025-04-01T04:55:03.162492
| 2023-09-14T22:55:05
|
1897455405
|
{
"authors": [
"Mikirae",
"danorris709"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13861",
"repo": "EnvyWare/EnvyHunt",
"url": "https://github.com/EnvyWare/EnvyHunt/issues/22"
}
|
gharchive/issue
|
RandomGender Spec Can Give Impossible Genders
Pokemon whose only genders are Male and Female are able to have a Genderless Requirement in Hunts
This is just a visual bug. Technically what it means is that it will accept either Male or Female for this pokemon
Any way I could at least change the lang on that then? Don't see anywhere for that but I'm also known to be blind
|
2025-04-01T04:55:03.167233
| 2015-05-19T18:26:36
|
78199735
|
{
"authors": [
"Xanir",
"lorenlennie"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13862",
"repo": "EnzeyNet/AutoComplete",
"url": "https://github.com/EnzeyNet/AutoComplete/pull/19"
}
|
gharchive/pull-request
|
Keep the 'loading' indicator active until the suggestions show.
On a large set of suggestions there can be quite a delay between when the
'loading' class is removed and when the suggestions appear.
Since the request is async the removal of the class should be a then on the getResultsFn.
I don't have the ability to make the change now but this what should cover that case better:
//Existing code (for reference).
var getResultsFn = $parse(attrs.getResultsFn)(scope.$parent);
if (!getResultsFn || !typeof getResultsFn === 'function') {
throw 'A function that returns results is required!';
}
// The fix.
var getResultsInnerFn = $parse(attrs.getResultsFn)(scope.$parent);
if (!getResultsInnerFn || !typeof getResultsInnerFn === 'function') {
throw 'A function that returns results is required!';
}
// Wrap results promise generator and remove loading indicator when complete.
var getResultsFn = function() {
var resolvePromiseAndRemoveLoading = function(result) {
element.removeClass('loading');
return result;
};
return getResultsInnerFn.apply(this, arguments).then(
resolvePromiseAndRemoveLoading, resolvePromiseAndRemoveLoading
);
}
Then remove line 441 all together.
What about moving the removeClass call to the displaySuggestions function?
var displaySuggestions = function(hintResults) {
if (element.hasClass('loading')) {
element.removeClass('loading');
}
scope.hints = hintResults;
if (!scope.hints) {scope.hints = [];}
...
displaySuggestions is only run if the getResultsFn does not fail but the loading indicator should be remove if a failure occurs.
I pushed a fix for this issue 46635c844b8af7eef24727d7599a7c4baaeb3f7d
|
2025-04-01T04:55:03.192696
| 2020-08-27T13:42:13
|
687253538
|
{
"authors": [
"brunofacca"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13863",
"repo": "EpistasisLab/scikit-rebate",
"url": "https://github.com/EpistasisLab/scikit-rebate/issues/74"
}
|
gharchive/issue
|
VLSRelief + MultiSURF run time
Thank you for this library, it is most useful!
I'm currently running VLSRelief with 230k features, 2350 samples, and 3 classes (it's a very noisy dataset, BTW). It's running for 14:30 hours in a Google Cloud instance with 64 vCPUs (CPU utilization is near 100% at all times) and not yet finished.
Here are the settings I've used:
selector = VLSRelief(
core_algorithm="MultiSURF",
num_feature_subset=200,
size_feature_subset=1000,
n_jobs=-1
)
Is it expected to take that long in a dataset of this size? Any suggestions on how to speed it up while keeping a high accuracy?
Thank you.
It took a total of 32h to run.
|
2025-04-01T04:55:03.228035
| 2016-03-07T22:12:42
|
139110626
|
{
"authors": [
"SrujithPoondla",
"james-huang",
"xelven"
],
"license": "bsd-2-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13864",
"repo": "EricssonResearch/openwebrtc",
"url": "https://github.com/EricssonResearch/openwebrtc/issues/583"
}
|
gharchive/issue
|
ICE failed to establish a connection
I am using Linux after starting Daemon and joining the call I am facing this issue
(gst-plugin-scanner:13174): GLib-GObject-WARNING **: cannot register existing type 'GstRtpH265Depay'
(gst-plugin-scanner:13174): GLib-CRITICAL **: g_once_init_leave: assertion 'result != 0' failed
(gst-plugin-scanner:13174): GStreamer-CRITICAL **: gst_element_register: assertion 'g_type_is_a (type, GST_TYPE_ELEMENT)' failed
** (gst-plugin-scanner:13174): CRITICAL **: Couldn't g_module_open libpython. Reason: /usr/lib/libpython2.7.so: cannot open shared object file: No such file or directory
{"line":24,"column":32,"sourceURL":"/opt/openwebrtc-0.3/share/seed-gtk3/extensions/Seed.js"}
0:00:48.342607531 28169 0xfe1560 ERROR owrsession owr_session.c:765:_owr_session_emit_ice_state_changed:<OwrMediaSession@0xfe9ba0> Session 1, ICE failed to establish a connection!
ICE state changed from connecting to failed
0:00:48.342684923 28169 0xfe1560 ERROR owrsession owr_session.c:765:_owr_session_emit_ice_state_changed:<OwrMediaSession@0xfe9cf0> Session 2, ICE failed to establish a connection!
ICE state changed from connecting to failed
0:00:48.342725589 28169 0xfe1560 ERROR owrsession owr_session.c:765:_owr_session_emit_ice_state_changed:<OwrDataSession@0xf598f0> Session 3, ICE failed to establish a connection!
ICE state changed from connecting to failed
(openwebrtc-daemon:28169): GStreamer-CRITICAL **: gst_mini_object_unref: assertion 'mini_object != NULL' failed
** (openwebrtc-daemon:28169): WARNING **: rtpsession: Trying to send an empty RTCP packet
(openwebrtc-daemon:2750): GStreamer-WARNING **: gstpad.c:5031:store_sticky_event:<dtls-encoder:src> Sticky event misordering, got 'segment' before 'caps'
(openwebrtc-daemon:2750): GStreamer-WARNING **: gstpad.c:5031:store_sticky_event:<funnel:funnelpad6> Sticky event misordering, got 'segment' before 'caps'
Thanks
you can enable the G_MESSAGES_DEBUG & NICE_DEBUG to all.
for take look the detail will be better.
I guess is same problem with https://github.com/EricssonResearch/openwebrtc-ios-sdk/issues/59
It also can reproduce in Wi-Fi environment.
Hi @xelven the issue you referenced is in IOS. I am getting these errors in linux. are these errors due to the same problem you mentioned in EricssonResearch/openwebrtc-ios-sdk#59?
@SrujithPoondla Not 100% sure, but I think it not about platform, it most time about which NAT type your try to pass through.
I was contact the developer of libnice, the few ICE connection bug has confirmed.
you can try with the NICE_DEBUG arguments in runtime to get more info will more clearly.
@xelven
You seem to have been a step ahead of me on a bunch of openwebrtc issues so I figured I'd ask you about this. Running iphone-iphone on the same wifi (so I don't think this is a NAT issue for me) I've been getting hit with
ICE failed to establish a connection!
ICE state changed from connecting to failed
on both my video and audio sessions.
This didn't happen when I was running linux-linux. I've turned on NICE_DEBUG and put the output in a pastebin here. http://pastebin.com/JZkV5XcP
Do you have any thoughts?
@james-huang
I look at it, and I got said there may had 2 reasons.
1. From your log, I can saw it your are using Cell Phone(NOT Simulator) which had sim card and mobile network is Enabled. and also your using wifi network.
and then your can checkout your remote candidate added only
[2 for Stream 1 with one TCP-ACT; one TCP-PASS.]
[2 for Stream 2 with one TCP-ACT; one TCP-PASS.]
Adding TCP-ACT remote candidate with addr [<IP_ADDRESS>]:0 for s1/c1. U/P '2Qfx'/'T645rsQlAOYJ3TLaVrC3en' prio:<PHONE_NUMBER>
Updating existing remote candidate with addr [<IP_ADDRESS>]:0 for s1/c1. U/P '2Qfx'/'T645rsQlAOYJ3TLaVrC3en' prio:<PHONE_NUMBER>
(<unknown>:6383): libnice-DEBUG: Agent 0x103934000 : Adding TCP-PASS remote candidate with addr [<IP_ADDRESS>]:54306 for s1/c1. U/P '2Qfx'/'T645rsQlAOYJ3TLaVrC3en' prio:<PHONE_NUMBER>
Adding TCP-ACT remote candidate with addr [<IP_ADDRESS>]:0 for s2/c1. U/P 'V6M4'/'TWI5xy4g21ewWE+zv+Ks0b' prio:<PHONE_NUMBER>
(<unknown>:6383): libnice-DEBUG: Agent 0x103934000 : Updating existing remote candidate with addr [<IP_ADDRESS>]:0 for s2/c1. U/P 'V6M4'/'TWI5xy4g21ewWE+zv+Ks0b' prio:<PHONE_NUMBER>
(<unknown>:6383): libnice-DEBUG: Agent 0x103934000 : Adding TCP-PASS remote candidate with addr [<IP_ADDRESS>]:54308 for s2/c1. U/P 'V6M4'/'TWI5xy4g21ewWE+zv+Ks0b' prio:<PHONE_NUMBER>
and there all failed when check the there connection, I not sure which local candidate they using, But I am sure if they using <IP_ADDRESS>(the internal ip of the mobile network adapter) to connecting <IP_ADDRESS> will 100% failed.
I suggest your disable mobile network first when u testing.
2. your router(Wi-Fi) may broken, but seems not : )
Yo @xelven; first off, really appreciate the help here.
Good eye about the mobile network. I have 2 phones and 1 sim card and I was a little confused why there were more ICE candidates from one side. I've turned cellular off (also tried adding the TURN server from the demo app in openwebrtc-examples). Mostly the same errors below:
http://pastebin.com/vQtmk4hX
Don't think its a router issue. linux-to-linux streaming works fine. I also did a quick browse through the router settings to make sure nothing too weird was going on.
|
2025-04-01T04:55:03.229706
| 2015-02-20T15:27:25
|
58367437
|
{
"authors": [
"gkiagia",
"sdroege"
],
"license": "bsd-2-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13865",
"repo": "EricssonResearch/openwebrtc",
"url": "https://github.com/EricssonResearch/openwebrtc/pull/192"
}
|
gharchive/pull-request
|
Buildfixes
A few fixes for some build errors that I had on my linux machine.
Everything but the -lEGL thing are merged now.
Thanks. Since -lEGL is not correct to be merged, I'll close this request now.
Do you want to provide a fix for the build scripts to --disable-egl?
|
2025-04-01T04:55:03.239086
| 2024-11-12T20:20:06
|
2653229793
|
{
"authors": [
"ErikBjare",
"jrmi"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13866",
"repo": "ErikBjare/gptme",
"url": "https://github.com/ErikBjare/gptme/pull/254"
}
|
gharchive/pull-request
|
Grouping all provider/model related logic into llm directory
This is a work in progress version of the refactoring I suggested. It's not well tested yet and there are probably a few regressions here and there but I wanted to show you the idea before going further.
I've introduced the concept of ModelManager. There is one implementation per API and they deal with the small differences we can have between model. The manager is instantiated with the model so it's available everywhere.
The idea is that everything that is specific to a model or a provider should be in the provider directory.
Let me know what you think.
[!IMPORTANT]
Refactor codebase by moving provider/model logic to providers directory and introducing ModelManager for model-specific operations.
Refactoring:
Move provider and model-related logic to providers directory.
Introduce ModelManager for handling model-specific logic, instantiated with the model.
Imports:
Update imports in chat.py, commands.py, init.py, message.py, reduce.py, server/api.py, tools/chats.py, tools/youtube.py, and test_server.py to reflect new directory structure.
Functionality:
Add supports_file and supports_streaming properties to ModelManager.
Implement prepare_file method in AnthropicModelManager and OpenaiModelManager for handling file preparation.
Miscellaneous:
Update logic in llm.py, llm_anthropic.py, and llm_openai.py to use ModelManager for model-specific operations.
Adjust get_model() usage across various files to utilize the new ModelManager structure.
This description was created by for 12a90672845c49961e8ca899c12df196e96b59bf. It will automatically update as commits are pushed.
Hey @ErikBjare I think we are going in the right direction :rocket: . I applied your suggestions and it's much better. My only doubt is about the code duplication in the file handling in each providers. We could do something, but I'm not sure it's necessary/a good idea. Let me know what you think.
A few ideas on how we can get this merged, it will really be an improvement and I appreciate your efforts.
Sorry if I was grumpy before, I've been sick this week.
Sure, no problem. Happy to help.
Rebased and force pushed.
Typechecks and tests passing locally :tada:
Going to go ahead and merge this, I'll fix any remaining issues in follow-up PRs.
Thanks a lot for pulling through with this @jrmi! :muscle:
You dropped this: :crown:
|
2025-04-01T04:55:03.250467
| 2017-09-25T23:40:58
|
260447503
|
{
"authors": [
"Eriner",
"ericbn"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13867",
"repo": "Eriner/zim",
"url": "https://github.com/Eriner/zim/pull/215"
}
|
gharchive/pull-request
|
[template] Add zcompile of git-info to zlogin
and declare zim_mods as a local variable. Also minor formatting changes.
:+1:
Changes like this are good, especially now that we're not delegate to supporting the legacy local declaration syntax issues that arise when using <5.2.
LGTM
|
2025-04-01T04:55:03.307421
| 2023-10-22T14:02:41
|
1955914410
|
{
"authors": [
"gunt0001"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13869",
"repo": "Esri/arcgis-maps-sdk-kotlin-toolkit",
"url": "https://github.com/Esri/arcgis-maps-sdk-kotlin-toolkit/pull/160"
}
|
gharchive/pull-request
|
Support LocationDisplay
Summary:
Adds support for LocationDisplay to the composable Map() function.
Description:
Adds a non-nullable locationDisplay parameter to the Map() function. The parameter is defaulted to a non-started LocationDisplay cached in a remember.
A public helper function rememberLocationDisplay has been exposed to conveniently create and remember a LocationDisplay. This function also checks ArcGISEnvironment.applicationContext. If it isn't set, a context will be automatically set from the composition. This function is also used to initialize the defaulted locationDisplay parameter.
A micro app LocationDisplayApp has been added to test & demo Map usage with a location display.
Thanks @puneet-pdx , I addressed your comments.
|
2025-04-01T04:55:03.317735
| 2016-04-11T23:04:58
|
147580781
|
{
"authors": [
"singhgag"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13870",
"repo": "Esri/arcgis-runtime-samples-ios",
"url": "https://github.com/Esri/arcgis-runtime-samples-ios/pull/165"
}
|
gharchive/pull-request
|
vector tile sample changes
name change
using dark gray canvas instead of topo
@dg0yal updated the url format
|
2025-04-01T04:55:03.319121
| 2018-09-19T20:13:23
|
361909434
|
{
"authors": [
"qsmmorgan"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13871",
"repo": "Esri/arcgis-runtime-samples-macos",
"url": "https://github.com/Esri/arcgis-runtime-samples-macos/pull/178"
}
|
gharchive/pull-request
|
Adds the Display KML sample
I found that this sample would often cause crashes, but the cause appeared to be in the runtime core.
@pgruenler I made the changes you requested, when you get a chance to re-review
@saratchandrakarumuri This sample is ready for testing. Note that the URL source often crashes the app, but this is an issue in the core.
The core has been updated with a fix for the crash.
|
2025-04-01T04:55:03.326346
| 2022-09-09T21:29:18
|
1368346647
|
{
"authors": [
"Gela",
"JamesMBallard"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13872",
"repo": "Esri/arcgis-runtime-samples-qt",
"url": "https://github.com/Esri/arcgis-runtime-samples-qt/pull/1471"
}
|
gharchive/pull-request
|
Fix null width warnings
Description
This PR primarily removes the code to get the width of a null property which was causing warnings in Qt 6. I also made a few modifications to address other type errors to these samples.
In one instance there was an error pertaining to using an implicit width, which declaring the width explicitly resolved.
Type of change
[x] Bug fix
[ ] New sample implementation
[ ] Sample viewer enhancement
[ ] Other enhancement
Platforms tested on:
[x] Windows
[ ] Android
[ ] Linux
[ ] macOS
[ ] iOS
Checklist
[ ] Runs and compiles on all active platforms as a standalone sample
[ ] Runs and compiles in the sample viewer(s)
[ ] Branch is up to date with the latest main/v.next
[ ] All merge conflicts have been resolved
[ ] Self-review of changes
[ ] There are no warnings related to changes
[ ] No unrelated changes have been made to any other code or project files
[ ] Code is commented with correct formatting (CTRL+i)
[ ] All variable and method names are camel case
[ ] There is no leftover commented code
[ ] Screenshots are correct size and display in description tab (500px by 500px, platform agnostic)
[ ] If adding a new sample, it is added to the sample viewer
[ ] Cherry-picked to Main branch (if applicable)
@JamesMBallard @ldanzinger It does not impact rendering at all, in all cases the value was null in the first place so removing that bit really just cleans up the console without changing the UI
in all cases the value was null in the first place so removing that bit really just cleans up the console without changing the UI
Did that object even become non-null? Presumably that property binding will be reevaluated multiple times.
Also I see now my comments didn't come through with my suggestion. I meant to ask if the ternary would work to avoid the warnings initially, but be there for binding reevaluations once that object is valid. I would only want to remove all the + indicator.width if we are confident it never worked throughout the entire app's existence.
|
2025-04-01T04:55:03.327499
| 2017-02-10T17:11:50
|
206852566
|
{
"authors": [
"jgravois"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13873",
"repo": "Esri/bootstrap-map-js",
"url": "https://github.com/Esri/bootstrap-map-js/issues/160"
}
|
gharchive/issue
|
get rid of gh-pages branch and just host pages from master
now that github supports hosting pages from the master branch, there's no need to remember to keep gh-pages in sync.
done.
|
2025-04-01T04:55:03.345561
| 2018-04-20T17:43:51
|
316354953
|
{
"authors": [
"BobBooth",
"lfunkhouser"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13874",
"repo": "Esri/distance-direction-addin-dotnet",
"url": "https://github.com/Esri/distance-direction-addin-dotnet/issues/551"
}
|
gharchive/issue
|
Range Ring radials distorted when they would pass near the poles
I'm seeing an issue with the angle of the radials being wrong, the radial features distorted, when range rings are created that have radials that pass near the poles.
For example, if I create two range rings sets with 10 rings, 200 km spacing, and 4 radials but put one centered near Thompson Manitoba, and another near the pole in the arctic, you can see some distortion of the east-west oriented radials in the first case, but the arctic case is highly distorted.
also see a larger set of rings further south.
ArcGIS Pro 2.1.0 Military tools build from April 17, 2018.
Web Mercator coordinate system
Closing. Expected behavior for using this projection in the issue. Recommendation - use different projection for this case.
|
2025-04-01T04:55:03.350191
| 2017-08-29T23:50:14
|
253837905
|
{
"authors": [
"dmfenton",
"tomwayson"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13875",
"repo": "Esri/ember-esri-loader",
"url": "https://github.com/Esri/ember-esri-loader/pull/28"
}
|
gharchive/pull-request
|
[DNM] Chore/map acceptance test
This PR suffers from the same problems in #27 - we still can't run more than a single acceptance test.
In addition, by trying to actually test the map, we now get the following error every time in PhantomJS (but not in Chrome):
Global error: Script error. at , line 0
JSHint | unit/services/esri-loader-test.js: global failure
โ Script error.
:0
Script error. at , line 0
NOTE: that error was happening in ad5c133 - when the acceptance test didn't even try to wait for and inspect the map. In other words, the error occurs simply by loading the JSAPI modules, not even using them. Which sucks, b/c it was such a royal PIA to write a test helper to wait for the map to load.
I'm so f'ing over Ember acceptance tests and the JSAPI.
As of 0d9bd076c4e1022dea105a3f1c3546dda0084eeb we can run more than one acceptance test.
I tried DRYing up the error handling code but was having problems. Besides, I ultimately want to move that code upstream into esri-loader in https://github.com/Esri/esri-loader/issues/28
I'm still seeing the global script error in phantom. I'm going to try moving the loadModules code into the route model() hooks in hopes that that fixes it. If that doesn't I'll configure the tests to only run in Chrome, maybe FF or headless Chrome in CI and we can merge this.
I would have had to re-arrange most of the dummy app to run loadModules() in the route hook, so I abandoned that, and any hope of running tests in PhantomJS. Phantom's so 2016 anyway.
I configured the tests to run in FF in CI now. Both ember t and npm test pass locally in FF and they've passed in Travis, so I'm going to merge this PR and assume that will update #27 and we can merge into master from there.
@tomwayson I wouldn't worry about phantom. It's a deprecated library and I'd expect most folks to be moving towards headless chrome at this point.
@dmfenton speaking of... #30 has DMF written all over it. ๐
|
2025-04-01T04:55:03.358670
| 2017-04-20T21:38:34
|
223208384
|
{
"authors": [
"deelesh",
"nathanaamot"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13876",
"repo": "Esri/network-analysis-services",
"url": "https://github.com/Esri/network-analysis-services/issues/16"
}
|
gharchive/issue
|
publishing/paths issue with supporting files
I've run into this issue a few times with the v1.2 of the tools (running ArcGIS 10.4.1). I think it is isolated to arcgis server sites where the config-store and directories locations have been reconfigured to us a shared drive location such as a NAS file share. I have one system where the config-store and directories are local (C:) and another system where they are in a shared location. This issue only seems to happen with the shared location configuration.
The issue is a failure to update the published path of the "ndsupportingfiles" folder in the serves. This causes failures with the routing tool and other solvers. Digging through the network traffic I've found an error where the services are trying to find the "defaulttravelmodes.json" file this path:
"original publishing location"\0\v101\ndsupportingfiles
rather than where they should be found in:
\"sharedrivelocation"\arcgisserver\directories\arcgissystem\arcgisinput\Routing\NetworkAnalysis.GPServer\extracted\v101\ndsupportingfiles
If I replicate the exact path the service is looking for (path to original publication location) on the server and copy the ndsupportingfiles into that location, this repairs the issues with the services not functioning properly.
@nathanaamot In your workflow, If you first setup your ArcGIS Server to use file shares for the config-store and server directories and then publish services using PublishRoutingServices tool, do you run into the same issue?
Hi @deelesh - Yes, my implementations have been set up as described above from the outset. One where they use file shares, one where config-store/directories are stored locally (C). I can try republishing from SD files but given your reply I'm not sure this would be relevant. Thanks!
@nathanaamot
On my side, I tried a 10.4.1 setup where the config store and server directories were on a file share and then published these services. Everything worked as expected and when executing services, I was able to confirm that the services were reading the files in the ndsupportingfiles folder from the file share.
I also did another test where initially my config store and server directories were on a local drive and I published the services. Everything worked as expected. Next I updated all the server directories to point to a file share. Now if i run the services, they correctly read the ndsupportingfiles from the file share.
So i can say that I am not able to reproduce the issues you are encountering.
Hi @deelesh - We have upgraded to 10.5.1 and I followed the instructions for the tools v2.0 to remove the routing folder etc and republish from the script. I'm still having the same issue as indicated above where the services are not looking for DefaultTravelModes.json in the published service location. I also tried your suggestion of deleting and republishing from the .sd files. Still same issue. I have attached the PublishRoutingServices.log file and some screenshots of our server configuration and the error in the server logs. Hopefully this provides some additional insight for you as to why the service publication process does not appear to update the ndsupportingfiles folder path as intended. Thanks for providing a great package. Our work around for now is to create a copy of the ndsupportingfiles folder and it's contents in the location where the services are trying to find it.
PublishRoutingServices.log
|
2025-04-01T04:55:03.360498
| 2017-05-08T23:54:21
|
227208260
|
{
"authors": [
"RoyTinker",
"bsvensson",
"jgravois"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13877",
"repo": "Esri/resource-proxy",
"url": "https://github.com/Esri/resource-proxy/issues/423"
}
|
gharchive/issue
|
Feature request: support node.js (via Connect middleware)
It would be great if a similar resource proxy existed for node.
we're discussing this in #63
Closing as duplicate of #63
Thanks @bsvensson @jgravois
|
2025-04-01T04:55:03.362877
| 2015-07-30T16:19:24
|
98208617
|
{
"authors": [
"MikeMillerGIS",
"clareprice",
"previnWong"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13878",
"repo": "Esri/solutions-webappbuilder-widgets",
"url": "https://github.com/Esri/solutions-webappbuilder-widgets/issues/235"
}
|
gharchive/issue
|
Network Trace - Overview Layer
@MikeMillerGIS @previnWong
Able to save the overview layer however, when going to save not prompted to input the outage details. No details saved to the layer, including the count of hydrants, valves, customers.
1.2 only?
Correct
I know during one of the betas for 1.2, the attribute "layerInfos" (1.1) got changed to "_layerInfos" (1.2). WAB team was going to make a fix to handle both, will check if they got implemented or not. That could be the source of the issue.
@CTLocalGovTeam @MikeMillerGIS
Verified fix. Closing issue.
|
2025-04-01T04:55:03.376993
| 2022-04-15T07:53:22
|
1205361827
|
{
"authors": [
"Boigm",
"EthanJWright"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13879",
"repo": "EthanJWright/foundryvtt-importer",
"url": "https://github.com/EthanJWright/foundryvtt-importer/issues/41"
}
|
gharchive/issue
|
XMl import support
hi i have xml 5e compendiums files and was wondering if you would consider adding support for xml files being imported
Hey - mind adding any more details around this?
How are you generating the XML files?
What is the hope for the user interaction & final results? (i.e. is this an actor import, that generates multiple actors, etc)
Mostly just classes and features from the fight club app
Did a bit of looking into the data structures - it's a heavier lift than I have time for considering it's not a workflow I would ever use. I'd be happy if anyone wanted to contribute to this project to enable it, but I don't think I'll have time soon to do it myself. Thanks for opening the issue!
|
2025-04-01T04:55:03.447156
| 2020-05-02T16:23:29
|
611224568
|
{
"authors": [
"Eugeny",
"MartijnDekkers",
"mwfrater",
"rbustos0"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13881",
"repo": "Eugeny/terminus",
"url": "https://github.com/Eugeny/terminus/issues/2511"
}
|
gharchive/issue
|
SSH to another host from inside an existing SSH session doesnt work...freezes session
Version: 1.0.108
Platform: Windows 10 (1909)
Plugins: altair, community-color-schemes, core, plugin-manager, serial, settings, ssh, terminal
If I open an ssh session to any particular host and then attempt, from that session, to ssh to another host. The current session just seems to freeze up with nothing further happening after executing the command:
[host-a ~]# ssh root@host-b
Not even Ctrl+C cancels this. You have to close the window completely.
Please capture DevTools console logs at the time of the issue: https://github.com/Eugeny/terminus/wiki/Debug-logs
events.js:187 Uncaught Error: write EPIPE
at afterWriteDispatched (internal/stream_base_commons.js:150)
at writeGeneric (internal/stream_base_commons.js:141)
at Socket._writeGeneric (net.js:770)
at Socket._write (net.js:782)
at doWrite (_stream_writable.js:431)
at writeOrBuffer (_stream_writable.js:415)
at Socket.Writable.write (_stream_writable.js:305)
at Socket.Writable.end (_stream_writable.js:594)
at Socket.end (net.js:574)
at PageantSock.write (agent.js:407)
at Channel.eval (agent.js:323)
at Channel.emit (events.js:210)
at addChunk (_stream_readable.js:308)
at readableAddChunk (_stream_readable.js:289)
at Channel.Readable.push (_stream_readable.js:223)
at SSH2Stream.eval (Channel.js:167)
at SSH2Stream.emit (events.js:210)
at parsePacket (ssh.js:3191)
at SSH2Stream._transform (ssh.js:701)
at SSH2Stream.Transform._read (_stream_transform.js:189)
at SSH2Stream._read (ssh.js:253)
at SSH2Stream.Transform._write (_stream_transform.js:177)
at doWrite (_stream_writable.js:431)
at writeOrBuffer (_stream_writable.js:415)
at SSH2Stream.Writable.write (_stream_writable.js:305)
at Socket.ondata (_stream_readable.js:726)
at Socket.emit (events.js:210)
at addChunk (_stream_readable.js:308)
at readableAddChunk (_stream_readable.js:289)
at Socket.Readable.push (_stream_readable.js:223)
at TCP.onStreamRead (internal/stream_base_commons.js:182)
errnoException @ internal/errors.js:474
afterWriteDispatched @ internal/stream_base_commons.js:150
writeGeneric @ internal/stream_base_commons.js:141
Socket._writeGeneric @ net.js:770
Socket._write @ net.js:782
doWrite @ _stream_writable.js:431
writeOrBuffer @ _stream_writable.js:415
Writable.write @ _stream_writable.js:305
Writable.end @ _stream_writable.js:594
Socket.end @ net.js:574
PageantSock.write @ agent.js:407
eval @ agent.js:323
emit @ events.js:210
addChunk @ _stream_readable.js:308
readableAddChunk @ _stream_readable.js:289
Readable.push @ _stream_readable.js:223
eval @ Channel.js:167
emit @ events.js:210
parsePacket @ ssh.js:3191
SSH2Stream._transform @ ssh.js:701
Transform._read @ _stream_transform.js:189
SSH2Stream._read @ ssh.js:253
Transform._write @ _stream_transform.js:177
doWrite @ _stream_writable.js:431
writeOrBuffer @ _stream_writable.js:415
Writable.write @ _stream_writable.js:305
ondata @ _stream_readable.js:726
emit @ events.js:210
addChunk @ _stream_readable.js:308
readableAddChunk @ _stream_readable.js:289
Readable.push @ _stream_readable.js:223
onStreamRead @ internal/stream_base_commons.js:182
Show 2 more frames
events.js:187 Uncaught Error: spawn C:\Program Files\Terminus\resources\builtin-plugins\terminus-ssh\util\pagent.exe ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:264)
at onErrorNT (internal/child_process.js:456)
at processTicksAndRejections (internal/process/task_queues.js:80)
Seem to have found the solution, manually grabbed a copy of https://github.com/mscdex/ssh2/blob/master/util/pagent.exe and placed it in the missing dir C:\Program Files\Terminus\resources\builtin-plugins\terminus-ssh\util\
This allows SSH to host-b from within SSH session on host-a .. but I must still note that this seems to take about 30sec or so to initiate said connection, for whatever odd reason (no errors during the wait time).
I have the same issue, and unfortunately this issue, as well as issue #2284 makes Terminus completely unworkable for me, since my use-case is 100% SSH. No useful output from the debug log either. Applying @mwfrater 's fix unfortunately didn't make a difference for me.
My workaround, for now, is to configure the native win10 ssh client with a correct ssh config file and some proxycommand config. Set up a new profile in Terminus for powershell, with arguments:
-nologo -command ssh <hostname>
Make sure to grab the latest ssh from https://github.com/PowerShell/Win32-OpenSSH/releases due to some bugs.
Same problem for me.
did you find a workaround or a fix? the workaround from @mwfrater doesn't work for me :(
|
2025-04-01T04:55:03.452887
| 2024-02-20T00:05:40
|
2143309588
|
{
"authors": [
"JamesWrigley",
"philsmt"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13882",
"repo": "European-XFEL/EXtra",
"url": "https://github.com/European-XFEL/EXtra/pull/124"
}
|
gharchive/pull-request
|
Add support for binning data to the Scan component
This is usually the entire point of a scan so everyone will end up doing this anyway. I also took the liberty of cleaning up the changelog a bit in 9c39677.
One thing I wasn't sure about: some people prefer the standard error instead of the standard deviation. Should we use that by default? Or make it an option?
How about bin_steps() or reduce_steps()? That would leave the door open for different reductions in the future.
bin_steps() or reduce_steps()
Somehow these suggest something is done to steps, rather than the steps being used to sort/bin/reduce/average something else. But this may simply be due to English being a second language.
Maybe Thomas has a good idea when he's back. But I'd also be fine to use the existing names for average here, and later implement it as a specific case of a more general function.
Yeah, I'm using it more loosely in a 'bin the data that was collected during these steps' way. But I don't feel very strongly about it, how about bin_by_steps()?
how about bin_by_steps()?
I didn't dare to suggest that, but it strongly communicates the meaning to me :see_no_evil:
Alrighty, renamed to bin_by_steps() in 8a6a5dc.
Ok one more naming bikeshed :upside_down_face: Is it confusing that the label on the plots is Error: ...? Like do you think people will confuse that with an actual error from the code? If so then we could call it 'uncertainty' instead.
Ah yes, error is indeed a loaded term. I spoke to Danilo, and he strongly preferred the term "Statistical uncertainty" instead. In the docs, we should explicitly mention it's the 68% confidence interval (also called 1-sigma region).
Roger that, renamed everything to 'uncertainty' in f0fc09f.
(I will sneakily take your earlier LGTM :smirk: )
|
2025-04-01T04:55:03.505070
| 2015-01-12T23:12:54
|
54121188
|
{
"authors": [
"Alondite00",
"interactivellama",
"kevinparkerson"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13883",
"repo": "ExactTarget/fuelux",
"url": "https://github.com/ExactTarget/fuelux/issues/973"
}
|
gharchive/issue
|
Document repeater dataSourceOptions and preserveDataSourceOptions
dataSourceOptions - passes object of arbitrary key/value pairs to datasource (and we need to tell developers that in the datasource is where you want to sort, filter, search, etc.)
preserveDataSourceOptions - saves options in case you navigate to the next page, etc.
dataSourceOptions - passes object of arbitrary key/value pairs to datasource (and we need to tell developers that in the datasource is where you want to sort, filter, search, etc.)
preserveDataSourceOptions - saves options in case you navigate to the next page, etc.
@interactivellama is this exactly what we want to put in the documentation? And where?
It goes here: http://getfuelux.com/javascript.html#repeater-usage-options
Thanks, for picking this up. It fell into the cracks.
It also needs to noted here, too. Probably just mentioned and linked to http://getfuelux.com/javascript.html#repeater-dataSource
@Alondite00 Assign PR to @kevinparkerson
@Alondite00 make me the PR reviewer once you submit it please :)
@swilliamset @kevinparkerson I don't think @Alondite00 can be assigned this now that he's a full time designer.
|
2025-04-01T04:55:03.637107
| 2022-12-13T03:08:23
|
1493250886
|
{
"authors": [
"kavimuru",
"laurenreidexpensify",
"marcaaron",
"sketchydroide"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13884",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/13548"
}
|
gharchive/issue
|
mWeb / Safari - Search - Modal doesn't completely cover the screen
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Login to the prod website staging.new.expensify.com
Click on new Chat
Notice the previous screen is slightly visible and can be scrolled
Expected Result:
The new chat screen should cover the screen completely
Actual Result:
The previous screen is slightly visible and can be scrolled at the bottom
Workaround:
unknown
Platform:
Where is this issue occurring?
Mobile Web (Safari)
Version Number: 1.2.38-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/207216526-5cf6ab3e-3bbe-474b-a516-0ef99dfd04fd.mov
Expensify/Expensify Issue URL:
Issue reported by: @someone-here
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670748885345139
View all open jobs on GitHub
this seems like a regression, maybe, maybe it's just another one of those flex that has been changed
@sketchydroide do you have any idea where the regression might have stemmed from in more detail?
Seems related to the banner at the top of the screen? We have definitely had an issue like this before... ๐
Feels like a dupe of this which we put on HOLD (but I think should not have) -> https://github.com/Expensify/App/issues/13219
I'm closing in favour of https://github.com/Expensify/App/issues/13219, pls reopen if anyone disagrees
|
2025-04-01T04:55:03.671441
| 2023-05-04T02:00:38
|
1695113599
|
{
"authors": [
"MelvinBot",
"Nathan-Mulugeta",
"dukenv0307",
"kavimuru",
"marcochavezf",
"nazmulpcc",
"sobitneupane",
"strepanier03"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13885",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/18386"
}
|
gharchive/issue
|
[PAID] [$1000] Emoji-only Anchor Text with Hyperlink is accepted/doesn't look right
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Open a chat and put an emoji inside of square brackets "[]" and put a link inside of parenthesis "()" and post the comment
Expected Result:
Emoji only should not be accepted as an anchor text or it should look right
Actual Result:
Emoji only is accepted as an anchor text and it doesn't look pleasing to the eye
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop
Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/236094258-5482069d-6c84-428f-83bc-c6060017e0dc.mp4
Expensify/Expensify Issue URL:
Issue reported by: @nathan-mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683110677125259
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~016f4e82bec390b3ae
Upwork Job ID:<PHONE_NUMBER>211725824
Last Price Increase: 2023-05-10
Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Bug0 Triage Checklist (Main S/O)
[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are โ
)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
Raised internally for discussion on path forward.
Bumped again as we're still unclear what the expected and preferred behavior will be.
After a few different discussions, we have come to a consensus that we don't want emoji to be allowed as anchor text for hyperlinks.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Emoji only hyperlink doesn't look good.
What is the root cause of that problem?
The link doesn't look good because of the added underline below the emojis.
What changes do you think we should make in order to solve the problem?
As mentioned here we do no want emojis as anchor text in hyperlinks. We can mark the field as "invalid" when some/all anchor text is an emoji and let the user edit the anchortext. We can achieve this by following how ExceededCommentLength is used in ReportActionCompose
What alternative solutions did you explore? (Optional)
We can also
Remove the underline from links. Like github does:
Text only
Mixed ๐ค Text ๐ค
๐ค๐ค๐ค๐ค๐ค
Remove all emojies from anchortexts automatically. This can be achieved by removing all emojis when the text is parsed. This looks like a good place to process the anchor text with a regex and remove all emojis. In this case we also need to decide what the replacement anchortext should be.
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e2898907cab95e2a
@nazmulpcc Thanks for your proposal.
Can you please be more descriptive in your proposal.
"What is the root cause of that problem?" section should include why is this issue occurring? Where in the codebase the problem lies? Please make use of permalinks.
"What changes do you think we should make in order to solve the problem?" section::
We can achieve this by following how ExceededCommentLength is used in ReportActionCompose
Can you please explain how and for what purpose ExceededCommentLength is used in ReportActionCompose? What changes will be required in code base to solve this particular issue? Where will we make those changes?
Proposal
Please re-state the problem that we are trying to solve in this issue.
Emoji only is accepted as an anchor text and it doesn't look pleasing to the eye.
As mentioned in https://github.com/Expensify/App/issues/18386#issuecomment-1541043535, we don't want emoji-only text to be anchor text for links.
What is the root cause of that problem?
We're not validating if the anchor text contains only emojis in the 'link' rule here https://github.com/Expensify/expensify-common/blob/b29d8528cd9be19a131ef77f9edfeb652d2af646/lib/ExpensiMark.js#L107.
What changes do you think we should make in order to solve the problem?
We need to check if the anchor text g1 here contains only emojis, we can make use of the existing logic in the containsOnlyEmojis method here https://github.com/Expensify/App/blob/1b1e562a33c01dbbc2ca81c8994342f95b5aa481/src/libs/EmojiUtils.js#L62, if yes then we return match; and it will show the user input as is without converting to <a> tag.
I'm assuming here that we only does not allow anchor text to "contains only emojis", if it contains both text and emojis then it should be allowed since the underlined text in that case does not look that bad. If instead we want to avoid emoji at all in the anchor text then we can simply modify the above condition to check if the anchor text contains any emoji.
What alternative solutions did you explore? (Optional)
NA
I'm assuming here that we only does not allow anchor text to "contains only emojis", if it contains both text and emojis then it should be allowed since the underlined text in that case does not look that bad.
@strepanier03 Can you please confirm wether we will allow anchor text to contain text with emojis or not?
@sobitneupane - We do not want to allow emoji to be used as anchor text for hyperlinks moving forward.
Thanks @strepanier03. So, We will not be allowing emoji at all in the anchor text. Even text mixed with emoji like Mixed ๐ค Text ๐ค will not be allowed.
@dukenv0307 Would you like to update your proposal?
@sobitneupane sure thing!
Proposal updated
Thanks for the update @dukenv0307
Proposal from @dukenv0307 looks good to me.
cc: @marcochavezf
Result will look something like this
Friendly bump @marcochavezf - I know it was the weekend but we're overdue here so taking care of that as well.
Thanks for the bump, the proposal also LGTM, assigning @dukenv0307! ๐
@sobitneupane the PR is ready for review
Prepping for the pay hold being removed
@sobitneupane - I've hired you to the UpWork job. Finish off the checklist whenever you can and I can update or make the reg test GH if applicable.
@dukenv0307 - I am having trouble locating your profile in Upwork, can you please apply for the job using this link and also let me know your first/last name in Upwork so I'm confident I'm hiring the right person?
@Nathan-Mulugeta - I've created a bug reporting job in Upwork and hired you as well.
Chat again on the 25th!
@strepanier03 I've applied! My profile is https://www.upwork.com/freelancers/~01f5cbe690701118a2, thanks!
Thank you so much @dukenv0307, I really appreciate it. I've hired you as well so we'll be ready for tomorrow.
Thanks @strepanier03 I just received.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
It's an improvement in the app. I don't think we can blame the PR allowing the emoji in url for causing this issue because it was lately decided to not allow emoji in the url.
Regression Test Proposal
Send a url having emoji as anchor-text ( i.e, Put an emoji inside of square brackets '[]' and put a link inside of parenthesis '()')
Verify that emoji is not considered as valid anchor-text.
Sounds good to me @sobitneupane - I can make that reg test GH.
Finished up everything here, paid out the remaining contract and closed it.
Thank you everyone!
|
2025-04-01T04:55:03.681675
| 2023-07-12T13:59:09
|
1801047947
|
{
"authors": [
"AndrewGable",
"mrousavy",
"tomekzaw"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13886",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/22749"
}
|
gharchive/issue
|
Allow react-native-vision-camera 2.15.4 and react-native-reanimated 3.1.0 to work together
Problem
Install react-native-vision-camera 2.15.4 and react-native-reanimated 3.1.0 on the same React Native app and you will see this error when trying to run iOS via npm run ios ๐ฅ
โ /Users/andrew/Expensidev/App/node_modules/react-native-vision-camera/ios/Frame Processor/FrameProcessorRuntimeManager.mm:146:32: no member named 'ShareableValue' in namespace 'reanimated'
auto worklet = reanimated::ShareableValue::adapt(runtime, arguments[1], runtimeManager.get());
Note: A patch was prepared by @mrousavy that fixes this, but it would be great to support this without a patch.
diff --git a/node_modules/react-native-vision-camera/ios/Frame Processor/FrameProcessorRuntimeManager.mm b/node_modules/react-native-vision-camera/ios/Frame Processor/FrameProcessorRuntimeManager.mm
index 3841b20..687ea94 100644
--- a/node_modules/react-native-vision-camera/ios/Frame Processor/FrameProcessorRuntimeManager.mm
+++ b/node_modules/react-native-vision-camera/ios/Frame Processor/FrameProcessorRuntimeManager.mm
@@ -19,6 +19,8 @@
#import <React/RCTUIManager.h>
#import <ReactCommon/RCTTurboModuleManager.h>
+#define VISION_CAMERA_DISABLE_FRAME_PROCESSORS 1
+
#ifndef VISION_CAMERA_DISABLE_FRAME_PROCESSORS
#if __has_include(<RNReanimated/NativeReanimatedModule.h>)
#if __has_include(<RNReanimated/RuntimeManager.h>)
Solution
Allow the two libraries to work together without a patch.
@mrousavy and @tomekzaw - Can you comment here so I can assign you? Thanks!
๐
Updates being left in Slack!
We just merged the patch to main, any update here from library maintainers side?
@AndrewGable I've managed to get it working with RNVisionCamera v3. I need some more time to backport the changes to RNVisionCamera v2 and submit PRs to both libraries. Will keep you updated!
Awesome work @tomekzaw! Feel free to DM me on Slack anytime if you have any questions or want me to do any changes :)
Hey! I've managed to integrate RNVisionCamera v2 with Reanimated v3 on both platforms (Android and iOS) ๐ฅณ
Here's the PR to react-native-vision-camera (to the v2 branch):
https://github.com/mrousavy/react-native-vision-camera/pull/1759
I've used some commits from @mrousavy's PR which mostly bumps react-native version in the example app and does some general cleanup which served as a base for my further work on the integration. Also, Marc provided me with instructions on how to test out frame processors in the example app on Android. Thanks!
iOS demo: https://twitter.com/tomekzaw_/status/1697302708879765983
Android demo: https://twitter.com/tomekzaw_/status/1697604643365278077
I believe we could integrate the new RNVisionCamera v3 with Reanimated v3 this way. In fact, this should be fairly easy to do since we could re-use the migrated code from v2.
Let's go ๐
We're finishing the last bits on that PR and then I'll create a release on the v2 branch ๐
@mrousavy - Do you think we could include this fix and https://github.com/mrousavy/react-native-vision-camera/pull/1782 on a V2 release? That'd be great for us ๐
Yo Andrew - sure no problem I'll backport that!
Pushed that specific change and also a fix to build without frame processors using disableFrameProcessors. Released to npm @ 2.16.1! ๐
Thanks again for your hard work @tomekzaw, this was just amazing help bro ๐
|
2025-04-01T04:55:03.694174
| 2023-09-15T15:34:41
|
1898665376
|
{
"authors": [
"izarutskaya",
"mananjadhav",
"poonam286",
"strepanier03"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13887",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/27541"
}
|
gharchive/issue
|
[$500] Assign task - Marking the Task as Complete or incomplete does not focus the composer
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Go to any task report page
Click "Mark as done". Notice the composer is not focused
Go to the three dots and click on Mark as incomplete. Notice the composer is not focused
Expected Result:
Marking the Task as Complete or incomplete focuses the composer
Actual Result:
Marking the Task as Complete or incomplete does not focus the composer
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop
Version Number: v1.3.70-5
Reproducible in staging?: Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/29518a0e-8fd4-4c70-8024-33374593f8bf
https://github.com/Expensify/App/assets/115492554/9552b16d-23b1-42d2-8b0d-5a7385738da7
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694057465609589
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01dda7cab075cd4ea4
Upwork Job ID:<PHONE_NUMBER>787387904
Last Price Increase: 2023-09-15
Hi i want help with this
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01c0d53d695396e11c
on the composer when Task is reopened here.
@neonbhai I didn't understand what you mean here, it links to the current issue itself. Can you please elaborate?
I am able to recreate this but I raised here to discuss expected behavior.
I get that we're not focusing the composer but why would we expect the composer needs to be focused after marking a task complete or incomplete?
@neonbhai - Please join the discussion here if you'd like to help move this forward. Right now the plan is to close this GH as a feature request.
I'll reopen if we decide to make a change.
|
2025-04-01T04:55:03.706937
| 2023-10-18T21:40:12
|
1950715052
|
{
"authors": [
"abdulrahuman5196",
"abzokhattab",
"flodnv",
"mallenexpensify",
"thienlnam"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13888",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/29916"
}
|
gharchive/issue
|
[$500] Update all selectors to use new format for selected participant
Follow up from https://github.com/Expensify/App/pull/29903
In https://github.com/Expensify/App/issues/29836, we updated the flow for the group chat / split bill flow to hide the selected participants when we are searching for a user. We'll need to update the flow for all selectors to use that same format
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01b5750587ffb7e229
Upwork Job ID:<PHONE_NUMBER>126532096
Last Price Increase: 2023-11-08
Waiting to add external until the linked PR is merged
I can work on this asap
We're still looking for proposals in the standard format
@abdulrahuman5196, can review @dukenv0307 's proposal above plz?
Yup, please review the proposal and work with Duke to update if there are any issues with it and then we can move to PR
@dukenv0307 I think still we expect a formatted proposal as always even though you would get dibs here. We should still add some missing pieces in the proposal like below.
There're some that use canSelectMultiple that already work fine (does not use getOptions) like in WorkspaceMembersPage, we can evaluate them during the PR process.
We should provide information on this. This is not a straightforward forward change in my opinion.
Like do we make it to migrate to getOptions or like update existing functions in WorkspaceMembersPage to behave like the new selection mechanism?
Pass the includeSelectedOptions as true in the getOptions that gets the options for those places, similar to here
Only push the participants section if search term is empty, similar to here
And we should also provide information on what pages/code are these which needs to be updated?
Melvin we had just posted update before weekend and back from weekend
@dukenv0307 can you please address @abdulrahuman5196 's comments in their post above?
Will review update today
For this I mean in those places it's already working fine according to expected behavior, so no change needed. It's already filtering out the selected options if those do not match the search query. Only the pages that are using getOptions has the issue.
@dukenv0307 Workspace invite page doesn't behave the expected way. We might need to fix this in different way.
Being discussed above.
@dukenv0307 ? Any update on the question above?
@abdulrahuman5196 , what do we need in order to hire someone here?
Let me check on the latest response and update here
Hi, Will review again today, just back from weekend
Hi, I think this issue has been held long on discussions. Since @dukenv0307 already have dibs on assignment here with proposal here https://github.com/Expensify/App/issues/29916#issuecomment-1769762909. I think its fine to move to PR phase and clarify any questions there since I think only minor concerns are pending.
๐ ๐ ๐
C+ Reviewed
@thienlnam looks like you were already assigned, not sure why it assigned someone else. Leaving it to you ๐
Not overdue melvin, we just assigned the contributor
What's the update here @abdulrahuman5196?
Hi, Will be reviewing the PR again today.
Go to a room/WS and open the Memember page
Click Invite and choose some users
Verify that you see them at the top
Start searching for a user and verify only the participants matching the selection is shown in the list, whereas the selected participants matching the search is shown at top and the rest matching the search is followed
When there is no search, all the selected participants should show at the top and the rest following them.
@mallenexpensify
Contributor: @dukenv0307 paid $500 via Upwork
Contributor+: @abdulrahuman5196 paid $500 via Upwork
TestRail update steps GH created https://github.com/Expensify/Expensify/issues/359909
Thanks @abdulrahuman5196
|
2025-04-01T04:55:03.722870
| 2023-11-28T14:37:34
|
2014594981
|
{
"authors": [
"Beamanator",
"DylanDylann",
"davidcardoza",
"jjcoffee",
"johncschuster",
"junsupark94",
"keisyrzk",
"mvtglobally"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13889",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/32128"
}
|
gharchive/issue
|
[$500] Unexpected Redirection to DM with Concierge Instead of #admins Chat When Selecting Setup Specialist Option
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: v1.4.3-11
Reproducible in staging?: No
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation: https://expensify.slack.com/archives/C03U7DCU4/p1700167866247689
Action Performed:
Created an Account<EMAIL_ADDRESS>Created a workspace
Selected the 'Setup Specialist' option in the LHN under Support.
Closed the NewDot application.
Navigated back to Expensify.com
Selected the 'Setup Specialist' option in the LHN under Support.
Redirected to a NewDot DM with Concierge.
Expected Result:
Expectation to be redirected to the #admins chat when selecting the option to chat with a Setup Specialist.
Actual Result:
Instead of being directed to the #admins chat, was placed into a Direct Message with Concierge.
Workaround:
Currently, no workaround is identified. The user's expectation to enter the #admins chat when selecting the Setup Specialist option is not met.
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~012157b2ec7d06ca6e
Upwork Job ID:<PHONE_NUMBER>477643776
Last Price Increase: 2023-11-28
Is there a way to create fake Expensify card transactions so I can try to reproduce this bug?
No worries, @junsupark94! I've done that many many times ๐
Waiting for proposals.
@davidcardoza @johncschuster
could you please explain how to select 'Setup Specialist' option in the LHN under Support. please?
There is no video attached to the issue. Could you please add some so we could see exact steps to reproduce?
I think the implication that the first steps are in newDot might be incorrect, as there isn't any Setup Specialist option or a Support menu in the LHN on newDot.
Though I can't reproduce this specific issue of being redirected to concierge, I do get redirected to a not found page. Here's what I'm doing:
You need an account that has access to oldDot and that has at least one workspace created in newDot
Login to oldDot
Switch to a workspace that was created on newDot
Select the 'Setup Specialist' option in the LHN under Support
https://github.com/Expensify/App/assets/27287420/1890800d-cc9b-4f0d-bd6d-f35861aceb90
@jjcoffee I think this bug is not related to new dot. We should add internal label
Agreed, there's an exitTo param in the link that oldDot generates, that for me points to a report that I don't have access to. I guess the redirecting to concierge has a similar root cause. Let's make this internal @johncschuster.
@davidcardoza It looks like this might be an issue with OldDot. I'm OOO Monday, December 18 (today) through Tuesday, January 2, so I won't be able to push to advocate for this bug. Would you mind raising this up internally so we can get it fixed?
If this issue is open when I'm back from OOO, I'll take it back over. Thank you!
Issue not reproducible during KI retests. (First week)
Happily moving to be internal, not working on this for now since last tests were not reproducible
Same as ^
I can't seem to reproduce this again. I am going to go ahead and close.
|
2025-04-01T04:55:03.740434
| 2023-12-22T00:35:58
|
2053213177
|
{
"authors": [
"bfitzexpensify",
"lanitochka17",
"namhihi237",
"sakluger",
"shubham1206agra"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13890",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/33474"
}
|
gharchive/issue
|
[$500] IOU - Can't download receipt image
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Navigate to https://staging.new.expensify.com/
Navigate to a workspace chat
Go offline
Do a scan IOU
Download the image
Expected Result:
I should be able to download it
Actual Result:
Can't download the receipt image
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/5d116036-7648-453d-952e-ce43cb0752e8
View all open jobs on GitHub
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can not download receipt when offline
What is the root cause of that problem?
When we offline the image doest not upload to S3 show the source file is local but we have isAuthTokenRequired is true, so the URL has a encryptedSourceUrl. That is wrong
We do not return the isLocalFile here so isAuthTokenRequired is true.
https://github.com/Expensify/App/blob/659f509b7e1093252d7c2ea14d0082ee78dd6503/src/libs/ReceiptUtils.ts#L45-L49
What changes do you think we should make in order to solve the problem?
We shouldupdate
const isLocalFile = path.startsWith('blob:') || path.startsWith('file:');
return {thumbnail: null, image: path, isLocalFile };
What alternative solutions did you explore? (Optional)
@shubham1206agra what do you think of @namhihi237's proposal? Is this a fairly simple change? I think it would be ideal for this to work, but this feels like a fairly unusual flow for someone to follow
@shubham1206agra what do you think of @namhihi237's proposal? Is this a fairly simple change? I think it would be ideal for this to work, but this feels like a fairly unusual flow for someone to follow
Actually, it can be quite common for someone to follow this route. Example is what if I clicked the image of a receipt, and I just want a copy of the image in my local storage too. Then this flow can be followed
@namhihi237's proposal looks good to me.
๐๐๐ C+ reviewed
Sent offers via Upwork. @shubham1206agra could you please complete the BZ checklist?
@sakluger accepted
Thanks @namhihi237! I completed your payment.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/30747
[x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30747/files#r1450354884
[x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[x] [@shubham1206agra] Determine if we should create a regression test for this bug. No as this is an edge case missed by ttps://github.com/Expensify/App/pull/30747
[x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@sakluger Checklist done
Thank you! All paid out ๐
|
2025-04-01T04:55:03.754138
| 2023-12-29T11:22:00
|
2059341904
|
{
"authors": [
"FitseTLT",
"MitchExpensify",
"izarutskaya",
"namhihi237",
"skydragon0324"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13891",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/33749"
}
|
gharchive/issue
|
[$500] Task โ Deleted task in a Room not disappears from 1:1 DM and Task name is visible in LHN.
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 1.4.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Go to https://staging.new.expensify.com/
Log in with any account.
Create a task in the Room
Log is as another participant of the Room
Open the Task in the Room and canceled it
Navigate to the 1:1 DM with Task creator
Expected Result:
Deleted task in a Room disappears from 1:1 DM and Task name is not visible in LHN when Canceled Task as Room user
Actual Result:
Deleted task in a Room not disappears from 1:1 DM and Task name is visible in LHN when Canceled Task as Room user
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/3610a08b-b53a-4fe7-b928-12afbd14cb64
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~015bc9d71fb41f159d
Upwork Job ID:<PHONE_NUMBER>378986496
Last Price Increase: 2023-12-29
Proposal
Please re-state the problem that we are trying to solve in this issue.
Deleted task in a Room not disappears from 1:1 DM and Task name is visible in LHN.
What is the root cause of that problem?
We are currently setting the lastMessage to the last message of the parent report here
https://github.com/Expensify/App/blob/7d1b0f8b99616c48aedb975dd73fc3086c9f20e3/src/libs/actions/Task.js#L757-L758
What changes do you think we should make in order to solve the problem?
There is a backend job required but for the optimistic data. We should change lastMessage to task deleted task title
https://github.com/Expensify/App/blob/7d1b0f8b99616c48aedb975dd73fc3086c9f20e3/src/libs/actions/Task.js#L757-L758
to
lastMessageText: message
as we did here
https://github.com/Expensify/App/blob/7d1b0f8b99616c48aedb975dd73fc3086c9f20e3/src/libs/actions/Task.js#L748-L749
What alternative solutions did you explore? (Optional)
I just read your issue
I think this issue is very simple
If you click cancel button, this action dispatch the event that the status of task would changed as delected
And on frontend side, it doesn't display tasks that the status is delected, so, If you want to see the deleted tasks, you can change code so that shows delete tasks.
I think backend issue, we do not push delete the message in the reportAction.
Is this #vip-split worthy @GabiHExpensify ?
Friendly bump @GabiHExpensify ๐
Closing as non-urgent and not clearly tied to a wave at this point
|
2025-04-01T04:55:03.768116
| 2024-01-30T00:17:39
|
2106705254
|
{
"authors": [
"jeremy-croff",
"joekaufmanexpensify",
"lanitochka17"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13892",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/35345"
}
|
gharchive/issue
|
[$500] Bank account - On selecting "I accept expensify terms", error not displayed for "Account number"
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 1.4.33
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4251914
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Go to https://staging.new.expensify.com/
Tap profile icon
Tap workspaces--- Workspace
Tap Bank Account
Tap Connect manually
Select "I accept expensify terms"
Expected Result:
When user select "I accept expensify terms", error must be displayed for both "Routing number" & "Account number"
Actual Result:
Error displayed for "Routing number" but not shown for "Account number" when user select "I accept expensify terms".
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/cb3c8d6c-beb9-47e3-b651-e4d538f54300
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~019df4e12cd288976c
Upwork Job ID:<PHONE_NUMBER>122000384
Last Price Increase: 2024-01-30
We only show errors for fields that are touched, since the first one is focused it's marked as touched.
The account number is never touched so it won't show the error yet.
Agreed. This is not a bug.
Hm, but if the user clicks out of the routing number field, we will still show an error there, no?
Hm, personally I think this is fine and not worth changing anything now.
Hm, but if the user clicks out of the routing number field, we will still show an error there, no?
@joekaufmanexpensify Yes, if the user proactively blurs the routing number field, it will still show an error and blur the routing number input.
But on native Android/iOS if we toggle the checkbox, the input won't be blurred and no error will show, I think that makes more sense (allowing the users to continue to type on the inputs right after the user toggles the checkbox, less manual action from user) and we should do the same for mWeb/web.
Based on what you shared I actually think native has a bug to not trigger the validation.
If they follow the order of the list as we present it to the user:
fill out account number
tap Routing, and account number gets validated
fill out routing number incorrectly
tap 'i accept term'
here it should validate the routing number
So that I can be informed of whether or not I can 'Continue'
I'm not sure I understand the report. If you follow the 4 steps you listed above we do throw an incorrect routing number error.
I'm not sure I understand the report. If you follow the 4 steps you listed above we do throw an incorrect routing number error.
The report is describing how I think it should be behaving, which is how web is handling!
However if you look at the video from https://github.com/Expensify/App/issues/35345#issuecomment-1917227581 they actually demonstrate this being broken in native. Since clicking I accept does not trigger validation.
|
2025-04-01T04:55:03.773806
| 2024-02-15T13:24:54
|
2136516572
|
{
"authors": [
"JmillsExpensify",
"amyevans",
"dangrous",
"garrettmknight",
"rushatgabhane"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13893",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/36581"
}
|
gharchive/issue
|
[HOLD for payment 2024-05-22] [HOLD for payment 2024-05-20] [HelpDot] Link this issue to auto assign Rushat for a review.
When creating a PR, link this issue so that I'm auto assigned for a review.
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@lschurr you may unassign to avoid pings
@maddylewis could you please assign me this issue
@JmillsExpensify I think payment happens in the separate payment issues and the automation is incorrect here.
Checking what's going on with this on in slack
@garrettmknight this is the issue for payment - https://github.com/Expensify/App/issues/32825
It has the necessary payment details
This issue is created only for the purpose of auto-assigning me for reviews.
Ok cool. I'm going to close this issue then.
I think I'm getting all PR reviews assigned me to because I am assigned on this GH ๐ค. That isn't necessarily a problem, but I do think it'd be better to round-robin the reviews via PullerBear so I'm going to unassign.
@amyevans could you please reopen the issue
Why can't it rely on PullerBear? ๐
does it work on closed issues?
I think it will just assign a random internal engineer on the PR review (according to PullerBear logic, which is based on lowest number of reviews), but if it ends up not working we can reassess!
not a bug, no checklist needed.
Is this issue complete? It is not showing up in my K2; I just got an email about it to check in.
I think the Expensify Help stuff is still going on, right?
|
2025-04-01T04:55:03.778018
| 2024-05-21T15:38:08
|
2308587128
|
{
"authors": [
"amyevans",
"blimpich",
"pasyukevich",
"trjExpensify",
"waterim"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13894",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/42433"
}
|
gharchive/issue
|
[Payment card / Subscription] Implement - Integrate 3ds flow with Backend data
Design doc
Issue OwnerCurrent Issue Owner: @waterim
Hi, I'm Eugene from Callstack - an expert agency - and I would like to work on this issue.
Not yet ready for work
Reassigning to @blimpich since I'm headed out on extended leave after today
@waterim you're combining this issue with https://github.com/Expensify/App/issues/42432 right? Can you comment so we can assign you here to track.
Hello, yes, Im combining this issue with UI issue!
Add @Pujan92 as they are reviewing the PR
Shall we just close this issue, as we're building it in one PR and we can use this issue: https://github.com/Expensify/App/issues/42432
Yes, lets do that for sake of simplicity.
|
2025-04-01T04:55:03.800555
| 2024-05-27T21:40:40
|
2319807933
|
{
"authors": [
"DylanDylann",
"JmillsExpensify",
"bernhardoj",
"lanitochka17",
"mallenexpensify",
"mvtglobally"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13895",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/42673"
}
|
gharchive/issue
|
[HOLD for payment 2024-07-10] Android & iOS - Tags - "Enabled" badge is not crossed out when tag is deleted offline
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4578912
Issue reported by: Applause - Internal Team
Action Performed:
Launch New Expensify app
Go to workspace settings
Go to Tags
Add a tag if there is no tag
Go offline
Delete the tag
Expected Result:
The "Enabled" badge will be crossed out when tag is deleted offline (web behavior)
Actual Result:
The "Enabled" badge is not crossed out when tag is deleted offline
This issue also applies to categories, distance rates and tax rates
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/dcd0e5b0-83c7-432e-8a93-9445718ef359
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 1
Proposal
Please re-state the problem that we are trying to solve in this issue.
Enabled badge of the right component is not crossed out when deleting a tag while offline.
What is the root cause of that problem?
The crossed out style is applied from OfflineWithFeedback. OfflineWithFeedback will give the component a deleted style.
https://github.com/Expensify/App/blob/2514f2988eb26858d30fa501c0040b1f8fc2e239/src/components/OfflineWithFeedback.tsx#L116-L118
However, the Enabled badge component itself doesn't accept any style props.
https://github.com/Expensify/App/blob/2514f2988eb26858d30fa501c0040b1f8fc2e239/src/components/SelectionList/ListItemRightCaretWithLabel.tsx#L14
So, the deleted style is never applied to it.
What changes do you think we should make in order to solve the problem?
Add a style prop to ListItemRightCaretWithLabel and append it to the label text style here.
https://github.com/Expensify/App/blob/2514f2988eb26858d30fa501c0040b1f8fc2e239/src/components/SelectionList/ListItemRightCaretWithLabel.tsx#L20
Opening up to the community.
Still waiting for proposal review. cc @DylanDylann
This issue only reproduces on the native app. I think the RCA will be more complicated than the above proposals
However, the children recursive search logic will not work in case the Text is nested inside another custom component like the Badge here. In this case, when iterating here, the children of Badge element will be undefined, because children only works for elements directly exposed inside the children of OfflineWithFeedback.tsx. This leads to the Text (a child in Badge structure) not having the strike-through style applied.
@tienifr Thanks for this point. But it is still grey to me, I will need some time to dive deep into this problem. It would be great if you could detail more
Issue not reproducible during KI retests. (First week)
@mvtglobally I still reproduce on IOS
Update: I am still deep diving into @tienifr's proposal. This bug is specific to native device
@Krishna2323 @bernhardoj Your RCA isn't correct to me because we implement the recursive logic to apply strike-through to child components (read @tienifr's proposal for more detail)
@tienifr Thanks for your detail. But It is still grey to me. In TableListItem Component, we still TextWithTooltip (it is a custom component) but it still be greyed out
I would prefer @tienifr's proposal. Let's go with them
@tienifr mind filling out the BZ checklist? I confirm the $250 payment summary above is correct for both contributors.
@DylanDylann shall I create an Upwork job/contract for you?
@JmillsExpensify Yes please!
@DylanDylann offer sent!
Reminder on the Upwork contract!
@JmillsExpensify Sure thing, I accepted the offer, TY
All paid out! @tienifr I'm going to close this issue for now, though before you submit an expense via New Expensify, please make sure to complete the BZ checklist.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Go to workspace settings
Go to Tags
Add several tags if there is no tag
Go offline
Delete the tags
Verify the tag and "Enabled" badge will be crossed out when the tag is deleted offline
Go online
Verify the tags disappear
Do we agree ๐ or ๐
Ah thanks! I'll re-open this one.
@mallenexpensify would you mind double-confirming payment summary before I approve payment?
Contributor: @DylanDylann paid $250 via Upwork
Contributor+: @tienifr owed $250 via NewDot
$250 approved for @tienifr
|
2025-04-01T04:55:03.813108
| 2024-06-10T15:22:48
|
2344197033
|
{
"authors": [
"MelvinBot",
"m-natarajan",
"slafortune"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13896",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/43387"
}
|
gharchive/issue
|
[$250] Unable to load chats and continuous loading appears
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 1.4.81-1
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1718027588707529 and https://expensify.slack.com/archives/C05LX9D6E07/p1718026564489519
Action Performed:
Open the staging app from the TestFlight
Expected Result:
Chats should be loading
Actual Result:
infinite loading appears
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/a5974e1e-f9e0-4907-9e35-84861ee56a55
https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:("8919b878fae44188-LHR")+AND+timestamp:[2024-06-10T12:31:14.825Z+TO+2024-06-10T14:31:14.825Z]&index=logs_expensify-028863
logs-2024-06-10 13_35_46.937 (1).txt
App_Info_1.4.79-11 (1).json
Profile_trace_for_1.4.79-11 (1).cpuprofile
https://github.com/Expensify/App/assets/38435837/55e0dde2-0083-45c8-8fa0-9ffdb9826f87
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01b75a1eb219ec6562
Upwork Job ID:<PHONE_NUMBER>691489778
Last Price Increase: 2024-06-13
Issue OwnerCurrent Issue Owner: @rojiphil
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
We are removing all AMs as admins from workspaces - I think that might be the fix. We'll test again once that is complete.
This has been spotty - let's see if it can get reproduced in the next couple of weeks.
moving to weekly to correspond with testing
I'm still not able to reproduce this - closing
|
2025-04-01T04:55:03.848620
| 2024-08-30T17:44:25
|
2497879313
|
{
"authors": [
"JmillsExpensify",
"MelvinBot",
"Pujan92",
"bernhardoj",
"garrettmknight",
"izarutskaya",
"mallenexpensify",
"rlinoz"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13897",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/48358"
}
|
gharchive/issue
|
[$250] Invoice - Default workspace avatar is displayed for invoice receiver when it has custom avatar
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: v9.0.26-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4864174
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
Workspace has custom avatar.
Enter amount. select user and send invoice.
As invoice receiver, go to invoice chat.
Expected Result:
Invoice receiver should be able to see the custom workspace avatar.
Actual Result:
Invoice receiver is unable to see the custom workspace avatar. It shows the default avatar instead.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/3c05b551-6bf5-4305-a2a9-38bc189d0262
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~014c6b9826c08600f4
Upwork Job ID:<PHONE_NUMBER>785190043
Last Price Increase: 2024-09-02
Issue OwnerCurrent Issue Owner: @Pujan92
We think this issue might be related to the #vip-bills
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Unable to reproduce, throwing a retest on here
I tested on v9.0.26-6 and this issue was reported with Version Number: v9.0.26-5
@Nodebrute , can you outline your reproduction steps? Reckon one of us is doing something different than the other.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Default WS avatar is displayed in invoice room if the user isn't part of the workspace.
What is the root cause of that problem?
When user A sends an invoice to user B from a workspace that user B is not a member of, the policy data will be undefined. When we are trying to get the workspace icon,
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L2246-L2250
we already prioritize the avatar from report.policyAvatar. However, the icon is still wrong and it happens after we introduce the caching in https://github.com/Expensify/App/pull/46886.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1937-L1948
The caching somehow saves the default avatar for the workspace. Here is the logic to decide whether we can get the avatar from the cache or need to save it to the cache or not.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1925-L1934
The first condition is of course to make sure the cache exists. Second, it checks whether the cached image source and the policy avatar source are the same or not. We will focus on the second condition.
As mentioned above, if the user isn't part of the WS, then the policy data will be undefined, so, the avatarURL is undefined (because we don't use report.policyAvatar here) and the isSameAvatarURL condition is always false. This means, we never get the source from the cache and keep setting a new object to the cache, even though the final value is the same.
It still works fine until the report passed to the function (getWorkspaceIcon) has the same policyID (which means the same cache key) but missing policyAvatar.
If the policyAvatar is missing, a default WS avatar will be saved to the cache.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1939
And because it's a default avatar, we will return it from the cache.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1930-L1934
What changes do you think we should make in order to solve the problem?
First, we need to solve the issue where we never use the cache if the policy is undefined by using report?.policyAvatar when comparing the cache source. To do that, we can replace avatarURL with policyAvatarURL (we can even use policyExpenseChatAvatarSource so we can remove isDefaultWorkspaceAvatar condition too).
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1927-L1937
Next, to avoid saving default avatar when policyAvatar is missing, we can return the cache if policyAvatar is undefined.
if (iconFromCache && (isSameAvatarURL || isDefaultWorkspaceAvatar || report?.policyAvatar === undefined) && !hasWorkSpaceNameChanged) {
return iconFromCache.icon;
}
Next, we need to replace getWorkspaceAvatar usage with getWokspaceIcon().source because getWorkspaceAvatar doesn't have the caching and doesn't prioritize report.policyAvatar.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/pages/home/report/ReportActionItemSingle.tsx#L103
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/pages/ReportAvatar.tsx#L27
Last, I notice that the avatar doesn't update immediately, so we need to update report action item memo to compare for report.policyAvatar too.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/pages/home/report/ReportActionItem.tsx#L1010-L1014
@mallenexpensify I can reproduce it by sending an invoice from user A to B using a workspace that user B is not a member of.
@Pujan92 plz attempt reproduction, if you're able to, plz review the proposals above. thx
@Nodebrute's alternative solution of using the cached function only for ReportActionItemSingle won't solve the issue in ReportAvatar screen.
I am more inclined towards @bernhardoj's proposal because of the following reasons.
Get rid of the function getWorkspaceAvatar and use the cached function in all the places.
Fix in the caching logic when the policy is unavailable
๐๐๐ C+ reviewed
Looks good to me, thanks!
I keep getting this error when sending an invoice.
Are you in the latest main? Also when sending the company website set it to a real valid url
I was facing the same issue with the Control policy, while creating an invoice with Collect policy worked for me.
I'm still facing an error, but a different one. I'm on latest main and sending from a Collect policy.
Just sent one in a collect policy using https://expensify.com
Would you mind trying that?
Still failed.
Nevermind, it works now after I Clear cache and restart
It's very late here, I'll continue tomorrow!
PR is ready
cc: @Pujan92
Automation didn't work, this is in prod as of 3 days ago https://github.com/Expensify/App/pull/49145#issuecomment-2356867180
Contributor: @bernhardoj due $250 via NewDot
Contributor+: @Pujan92 due $250 via NewDot
@Pujan92 plz complete the BZ checklist.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Requested in ND.
$250 approved for @bernhardoj
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: No, we have had this util function getWorkspaceAvatar for a long and the invoice feature was added later. So there isn't any specific PR of causing this bug.
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X] [@Pujan92] Determine if we should create a regression test for this bug. - Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Upload an avatar for workspace W if it is a default avatar currently
As user A, send an invoice to user B from workspace W(user B isn't a member of this workspace)
As user B, verify the custom avatar has been shown in the report details
I agree we should add the step to check the workspace avatar, that can be added to the testrail that caught this bug: https://expensify.testrail.io/index.php?/tests/view/4864174
Thanks @PauloGasparSv and @rlinoz
Test case created
https://github.com/Expensify/Expensify/issues/431500
$250 approved for @Pujan92
|
2025-04-01T04:55:03.862393
| 2024-11-06T10:11:01
|
2637614617
|
{
"authors": [
"IuliiaHerets",
"OfstadC",
"c3024",
"lakchote",
"mountiny"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13898",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/52098"
}
|
gharchive/issue
|
[HOLD for payment 2024-12-03] [hold] Web - Concierge - Take a 2-minute tour task not autocomplete after finishing tour
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: https://github.com/Expensify/App/pull/51153
Issue reported by: Applause Internal Team
Action Performed:
Go to https://staging.new.expensify.com/ and log in with a new account
On the onboarding modal select any option other than 'Something else"
Complete the onboarding flow
Navigate to the Concierge chat
Select the Take a 2-minute tour task
Click on the link and finish the tour
Expected Result:
The task is marked complete automatically upon finishing the tour like other Concierge tasks
Actual Result:
The "Take a 2-minute tour" task is not marked complete automatically
Workaround:
Unknown
Platforms:
[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/a25c96b3-1f0b-47c7-9a02-aa39928ecc07
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @OfstadC
#51153 is related to this.
I do agree that it's not a blocker and that it should be handled on the backend for the reasons mentioned above by @c3024.
Waiting for your input @mountiny too
@c3024 @rushatgabhane should be assigned and we should mark this optimistically as completed and call the SelfTourViewed command and update the BE to mark the task as complete too
Didn't have time to focus on it internally as I'm focusing on a #stability issue.
@c3024 you can still raise a frontend PR to set this optimistically in the meantime (see @mountiny's comment above).
If you could do it today that'd be great @rushatgabhane
Raised a PR.
@rushatgabhane @c3024 Please complete thee BZ checklist by EOD so we can issue payment tomorrow
@c3024 Offer sent here
Ooop didn't mean to close this. Still need @c3024 to accept Upwork Offer
@c3024 Could you please accept the offer so we can close this GH out? ๐ Thanks so much!
@OfstadC , sorry for the delayed response. This is part of a project and payment is handled here. No payment in this issue. Thanks!
Ah okay! Thanks for letting me know. I will not issue payment here then ๐
|
2025-04-01T04:55:03.871733
| 2024-12-19T16:14:42
|
2750826229
|
{
"authors": [
"m-natarajan",
"mountiny",
"narefyev91"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13899",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/54373"
}
|
gharchive/issue
|
List of card-level export accounts are not displayed when using Intacct and vendor bills
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expense
Action Performed:
Prerequisite: User added a company card
Navigate to company card
Click the added cards to view the details page
Click on export options and select Intacct
Expected Result:
List of card-level export accounts when using Intacct and vendor bills
Actual Result:
List of card-level export accounts are not displayed when using Intacct and vendor bills
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Hi, Iโm Nicolay from Callstack and I would like to investigate this issue.
@dukenv0307 can you please complete the checklist and then we can close this to handle the payments
|
2025-04-01T04:55:03.878410
| 2021-10-08T16:11:19
|
1021263998
|
{
"authors": [
"MelvinBot",
"isagoico"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13900",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/5727"
}
|
gharchive/issue
|
Workspace - Desktop - Blank page is displayed after click on the "Invite" button
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Launch App and login
Create a workspace
Navigate to the People
Click on the "Invite" button
Expected Result
Invite new members" page should be open.
Actual Result
The blank page is opened.
Workaround:
Unknown
Platform:
Where is this issue occurring?
Desktop App
Version Number: 1.1.7-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
|
2025-04-01T04:55:03.887280
| 2022-02-17T05:53:22
|
1140907188
|
{
"authors": [
"MelvinBot",
"francoisl",
"mvtglobally"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13901",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/7794"
}
|
gharchive/issue
|
Feature Request: Add "Are you sure you want to Sign Out?" popup - reported by @dharmik
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Open app and login
Click on Settings > Sign out
Expected Result:
Popup should appear
Are you sure you want to Sign Out?
Yes Or No
Actual Result:
User signed out. Nothing appear
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.1.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @dharmik
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643910673108429
View all open jobs on GitHub
Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Thanks for the suggestion! As it was discussed in this Slack thread yesterday, we're not going to proceed with this change at the moment.
I left the thread open for a bit to give a chance to everyone to chime in, and it seems like no one else has anything to say anymore, I'm going to close this.
|
2025-04-01T04:55:03.934729
| 2022-03-08T06:58:50
|
1162293328
|
{
"authors": [
"Beamanator",
"MelvinBot",
"MitchExpensify",
"Santhosh-Sellavel",
"frenkield",
"laurenreidexpensify",
"marcaaron",
"mvtglobally",
"neil-marcellini",
"parasharrajat",
"robertjchen",
"thesahindia"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13902",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/8031"
}
|
gharchive/issue
|
$1000 - When you edit a comment, the composer stays hidden on other chats - reported by @thesahindia
If you havenโt already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Open :expensify: on Mobile
Navigate to a chat
Edit a comment
Navigate to a different chat
Expected Result:
Composer should be visible on other chats or user shouldn't be able to navigate to different chat until he cancels/Save the changes
Actual Result:
Composer is hidden for every chat
Workaround:
unknown
Platform:
Where is this issue occurring?
iOS
Android
Mobile Web
Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/157183657-c4c70cbf-047d-438e-9e82-7f90cc0dc139.mov
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1645699620022559
View all open jobs on GitHub
Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
@thesahindia I'm not sure I follow full here - what do you mean by "edit a comment". Do you mean editing a message that has already been sent?
Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Composer should be visible on other chats or user shouldn't be able to navigate to different chat until he cancels/Save the changes
Got it! So to clarify my understanding, what should be the proper behavior here?
At the moment, the composer stays open after switching to another chat and switching back. I don't see it as a major issue, but I do see three options to make it "better":
Automatically cancel the edit and hide the composer when switching a chat (Slack does this)
Composer should remain visible on other chats (this might be quite confusing)
Prompt the user to save/cancel the chat (e.g. highlight composer box in red and prevent user from switching, a dialog, etc.)
I see 1 as the path forward here- I'm open to any other thoughts!
I like the 2nd option. 1st option is good but there is a drawback. If the user is in the middle of editing and navigates to some other chat then the changes he made will get discarded.
Got it, that makes sense- it should mirror the behavior on the desktop version (which is working properly, just not on mobile). This is clear to me now, apologies for any initial confusion!
So, the report/proposal here is to address the issue where the composer disappears when switching to other chats on mobile ๐ Thanks again for the report- going to add the External label for the next step of the process.
Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
Upwork Job
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)
Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Hmm unable to reproduce on mobile web (chrome), latest version - I'll try android
@Beamanator Able to reproduce in mWeb
https://user-images.githubusercontent.com/85645967/158416332-14777a7e-6080-41fb-a308-b6b3c6043e4c.MOV
@Santhosh-Sellavel thanks for the vid, what platform & version are you on?
I just tried on Android, in Chrome browser, v1.1.42-6 and still couldn't reproduce ๐
Waiting on proposals ๐
I guess the interesting thing is:
In web (and Desktop, I assume), when you edit a comment the ReportActionCompose is still showing
In mobile (and mobile web), when you edit a comment the ReportActionCompose disappears even for the chat you're editing
I am guessing this is due to a recent PR, let's see if we can nail that down
In web (and Desktop, I assume), when you edit a comment the ReportActionCompose is still showing
In mobile (and mobile web), when you edit a comment the ReportActionCompose disappears even for the chat you're editing
@Beamanator, I think this is expected, info about it is in https://github.com/Expensify/App/issues/7265
Aha thank you @thesahindia !
@parasharrajat could this issue be a regression of your PR https://github.com/Expensify/App/pull/7390?
Yeah, this is a side-effect from #7390. But I just enabled the flag which was missing from the code. This means this functionality wasn't developed correctly and it had this bug.
Let me check this issue quickly...
Proposal
In ReportScreen's componentWillUnmount call toggleReportActionComposeView(true, true). It will remount the Composer when user closes the report.
The best behavior would be option 1. Where we remount the composer on each report change.
If we do that, what if the user:
Starts editing a comment (so the ReportActionCompose is hidden in that chat)
Navigates to a new chat (now ReportActionCompose should show)
Navigates back to the original chat
In this case wouldn't ReportActionCompose be showing, along with the comment being edited?
Yeah. It will but as soon as the user clicks on the message edit box, the composer hides which is normally happening when you edit a message.
@parasharrajat do you mind testing it and throwing in a short vid to explain what you mean? If I'm understanding correctly the ReportActionCompose will still be showing (in step 3 above) but it will hide if the user clicks in the comment-edit box, which seems like it would result in a weird user experience, maybe I don't understand completely?
Your understanding is correct.
which seems like it would result in a weird user experience
If you feel so then we have to think about an alternative strategy. But I think it is the best fit. On Mobile, we don't focus anything when the report screens loads. There can be multiple draft messages.
Either we remove this feature completely.
Or find something else.
Ok so now I'm thinking this does actually make sense to keep around on mobile because:
When you originally click "Edit comment", you won't be sending a message so it makes sense to hide ReportActionCompose
When you cancel or save your edit, ReportActionCompose comes back (since now you'll be thinking about sending a message)
When you navigate away & come back, you may want to send a message or continue editing, so if you click back in the edit comment box we should hide the ReportActionCompose to make it consistent
I like the idea now, sorry for flip-flopping a bit. @parasharrajat Let's go with your proposal here
๐ฃ @parasharrajat You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review ๐งโ๐ป
Keep in mind: Code of Conduct | Contributing ๐
No worries. I appreciate the clarifying questions. It is actually better to discuss it so we are on the same boat.
Invited to job @parasharrajat
@Beamanator question? What should happen when?
user was editing a message and the composer is hidden.
He goes back to LHN.
Then reopen the same report.
Should the composer be shown or not?
So far, I am only forcing the composer on report change.
Asked here https://expensify.slack.com/archives/C01GTK53T8Q/p1647881926785649
@parasharrajat I think we got the answers we need in Slack, do you have any questions before moving forward with a PR?
I will update the PR by monday.
Thanks ... I like that idea too, I agree itโs not necessary to keep the edit box open when navigating to LHN and back :thumbsup:
@Beamanator Do I need to add this as well?
@parasharrajat Yes we should include the decision made in Slack. Would you mind restating exactly what you plan to do before moving forward with this?
Ok, I found that if we want to close the edit box while going back to LHN, we have to lose the draft messages as well.
Edit box depends on the presence of draft message directly https://github.com/Expensify/App/blob/1ff6625a19f56f9d636edc09a1d2f76d5f7a893c/src/pages/home/report/ReportActionItem.js#L139
Ok, personally I think that's ok because it's just a draft edit
Ok, I will update the PR.
@Beamanator Ok, So there are two ways, I can think of.
I use withReportActionsDrafts HOC on ReportScreen to get all the reportActionsID with keys. Then use WithDrawerState to set those drafts off when the drawer is opened.
Secondly, I can directly use WithDrawerState on the ReportActionItem and reject the draft when the drawer is Opened.
Ok so just to make sure I'm following correctly:
this.props.draftMessage (in ReportActionItem.js) is where we're storing the draft of an edited message (not the draft of a new message)
You're thinking we can just kill a report's draft (probably using Report.saveReportActionDraft, storing null) when the LHN opens up
If this is correct, I'm thinking the second option may be more efficient since we only have to deal with 1 report's draft at a time, what do you think?
Yup, you are correct. But a report can have multiple drafts for actions.
Ok and that's why in your sample code you're looping through all drafts of a specific reportID, which I bet you'd have to do in either case, thanks for reminding me about that ๐
A few more questions related to this change we're thinking about making:
Now that we're planning to get rid of message-edits once a user navigates back to the LHN, do you think it even makes sense to store these in Onyx anymore? A.k.a. if we don't care about message-edit drafts when we switch to a new report, wouldn't we also not care about saving the drafts if the user closes the app, for example?
On large screen devices we won't "open the LHN" ever so to make behavior consistent would we want to kill message-edit drafts if the user changes reports? Or do we want to :donothing: for big screen devices? I'm leaning toward :donothing:
Yeah, good points.
I have a second thought about this change. We are basically removing the drafts feature from the app. Do you think we should take the opinion of a few more people? Let me know if this is the final decision, I will look into your questions as well.
Yeah I was thinking something similar ๐ I agree we should get more opinions, if you could continue the same chain as before but re-send to the channel & maybe tag contributor-management-engineering as well that would be very helpful
New Upwork Job (previous one closed)
Price doubled!
Ping'd CMEs in internal channel to try to get more eyes ๐๏ธ
We are basically removing the drafts feature from the app.
I don't think we should do this. If I start editing a message on a chat, and then I need to go reference something from another chat, I want to be able to come back to my draft and continue editing. If I have been editing a message and I go to another chat I should also be able to send messages there. That should be possible right? Is there another case I'm not thinking of?
If I have been editing a message and I go to another chat I should also be able to send messages there. That should be possible right?
Yeah, that is possible.
What should happen when?
user was editing a message and the composer is hidden.
He goes back to LHN.
Then reopen the same report.
Should the composer be shown or not?
If you do this on web / desktop then the composer will be shown, so I think it should match on mobile. In my opinion, we should let the user have the option to continue editing or to send another message. Again that behavior would match desktop. To make that happen I think we should allow the user to unfocus the composer (and dismiss the keyboard) if they click outside of it on mobile. Maybe that's a separate issue.
Left a big comment w/ multiple ideas & ping'd a few more people in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1651495589126309?thread_ts=1647881926.785649&cid=C01GTK53T8Q
So sorry, I'm new to Expensify and I don't understand what the issue is here. Where in the attached video is something incorrect?
Doubled!
Ping'd the slack channel again to see if anyone can help come to a final decision :D
Bump! Any update?
I'm getting fewer and fewer responses to my posts in slack ๐
I don't feel comfortable moving forward till we have more feedback on the thought so I will tag CMEs and try to get more thoughts
@MitchExpensify I think you can hold off doubling this time please :D Since we don't have a solid way forward yet
Heads up I'm working on this internally in a duplicate issue here and found a pretty simple solution.
I think the correct behavior is that we should hide and show the "composer" only when the edit comment field is focused or blurred.
Has anyone been hired? If not, I think we can just close this one (and the Upwork job) and have @parasharrajat and @Beamanator test my PR linked to the duplicate issue.
@marcaaron I ended up hiring @parasharrajat here: https://github.com/Expensify/App/issues/8031#issuecomment-1073543793
After that, we've been discussing what to do in some other situations (see Slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1652268683129369?thread_ts=1647881926.785649&cid=C01GTK53T8Q)
And this has been delayed due to lack of responses, which is why I just brought this to an internal slack channel as well
If you already have a PR up, maybe we can pay @parasharrajat to help test & review it? (I'll help as well)
What is decided here? Should I close my PR?
Yes, want to help us review this solution instead --> https://github.com/Expensify/App/pull/9060
Added you guys there.
Not overdue, PR testing and reviewing in progress
I believe this can be closed b/c the fix was implemented in this PR: https://github.com/Expensify/App/pull/9060
Agree!
Note: I was hired for this issue here and It was decided that this issue will be solve internally and I will review it as C+. Also, I closed my PR for the same.
Yeah, you are correct. Thanks.
@MitchExpensify, the reporting compensation is also pending.
Thanks for the heads up team! I have made a note to issue payment tomorrow as that will be 7 days since the fix was deployed here
Payments made and contract ended - Thanks @parasharrajat & @thesahindia!
|
2025-04-01T04:55:03.995217
| 2023-07-26T14:40:42
|
1822574574
|
{
"authors": [
"Gonals",
"MonilBhavsar",
"OSBotify",
"abdulrahuman5196"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13903",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/23651"
}
|
gharchive/pull-request
|
Show comment/requests in report preview
Details
cc @JmillsExpensify, @trjExpensify
Fixed Issues
$ https://github.com/Expensify/App/issues/21178
Tests
Log into your account in newdot
Request money from someone else and add a comment while doing so
Confirm the comment immediately shows in the request:
Request money again from the same person.
Confirm that, instead of the comment, the number of requests show immediately:
[x] Verify that no errors appear in the JS console
Offline tests
Same as tests but offline
QA Steps
Same as tests
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
Yes, this should be ready for review
@abdulrahuman5196 bump!
Sorry for the delay. Will review in couple of hours.
@Gonals
Request count is not updated in the preview if a request is deleted, the preview is only updated when the request is added. I assume it has to do with backend(not sure though). should that be a separate PR?
https://github.com/Expensify/App/assets/46707890/02e79bff-b3c9-41f2-98a4-35181bf43315
@Gonals Request count is not updated in the preview if a request is deleted, the preview is only updated when the request is added. I assume it has to do with backend(not sure though).
Screen.Recording.2023-08-02.at.9.35.02.PM.mov
Nice catch! it is 50-50.
@abdulrahuman5196 I have fixed the frontend here to optimistically update it, but the backend bug remains. Let's ignore it for this PR and I'll fix it in a different issue. Let's see if we can merge today, as I'm OOO staring tomorrow!
@Gonals Got it. I tested now. I think the optimistically updating data is also not complete and in cases I still seeing issues.
Like
Description is not updating in preview if we delete all requests and keep only one request with description
But I am fine with this, given we are planning to create separate bug to address the request count not getting updating on requests deletion/updation. I think it would be best to re-test the optimistic function and backend verification as well in that issue.
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
https://github.com/Expensify/App/assets/46707890/0b9b84e7-750d-45b3-ab3e-83f63a04005c
Mobile Web - Chrome
https://github.com/Expensify/App/assets/46707890/49d1eece-7f9f-45d6-95b6-85bf40f5aa34
Mobile Web - Safari
https://github.com/Expensify/App/assets/46707890/07f610be-0f53-4ffa-a4ef-d662161e50f2
Desktop
https://github.com/Expensify/App/assets/46707890/0ad3ee17-043f-4e6f-82cc-8491f481940a
iOS
https://github.com/Expensify/App/assets/46707890/10b951f0-b7a7-44c1-ac32-4309a23a27bf
Android
https://github.com/Expensify/App/assets/46707890/afd4c5f5-6a61-439d-adb0-f6a858aa3f4e
@Gonals Changes looks good. We have to create 2 issues
Request count/description is not properly updated on request deletion/updation
Request count/description is not updated on workspace chat money requests during addition for any pre-existing workspace. But working fine for new workspaces.
https://github.com/Expensify/App/assets/46707890/4a16b7a9-fa0b-4823-861e-27bd1f3928eb
Do we need to update this function usage to pass comment param https://github.com/Expensify/App/blame/2335cbaf854f236db28cbbc72fa0446a6584d78c/src/libs/actions/IOU.js#L1257
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
๐ Deployed to staging by https://github.com/luacmartins in version: 1.3.52-0 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
failure โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
๐ Deployed to staging by https://github.com/luacmartins in version: 1.3.52-0 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
๐ Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
|
2025-04-01T04:55:04.077097
| 2024-02-14T16:00:06
|
2134675801
|
{
"authors": [
"OSBotify",
"mountiny"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13905",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/36521"
}
|
gharchive/pull-request
|
Add the policy tax trackingEnabled
Details
This PR adds the policy.tax.trackingEnabled property so we copy what is in the db policy object
Fixed Issues
$ https://github.com/Expensify/App/issues/36176
Tests
Make sure Tax is enabled in Old Dot.
Add some tax policies in Old Dot.
Add a member to your workspace.
select a user from your workspace with enabled policies.
Click on request money as either manual or scan.
enter amount.
click on Show More and select tax rate.
Verify it worked fine
[ ] Verify that no errors appear in the JS console
Offline tests
N/A
QA Steps
Same as tests
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
simple change, works fine
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
@ishpaul777 ok please go ahead, I think you will need to have the Collect policy set up
yep that should be it, you need to invite in another user to the policy btw to get the workspace chat
@ishpaul777 thanks! updated!
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
๐ Deployed to staging by https://github.com/thienlnam in version: 1.4.42-0 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
๐ Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
|
2025-04-01T04:55:04.182868
| 2024-03-13T19:28:42
|
2184742469
|
{
"authors": [
"OSBotify",
"allroundexperts",
"jbroma"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13907",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/38255"
}
|
gharchive/pull-request
|
perf: improve chat switch performance - fixed
Details
Original PR got reverted because of issues with ghost draft comments, this PR brings backs the changes from the original PR, and fixes the related issues.
Please refer to original PR for more details.
Fixed Issues
$ https://github.com/Expensify/App/issues/32793
PROPOSAL: https://github.com/Expensify/App/pull/32336 (original PR)
Tests
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/20626315/5abfabfb-4293-4513-9618-80c555bd342c
MacOS: Desktop
C+ Reviewer: please refer to 3 commits on top of original PR for easy review
as to why:
callback was removed because it was capturing function that changed way too often
reverted the else if condition in Composer as it's necessary to save clean comment as current state of composer in that report, as original author intended
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/30054992/a817e55b-e0c6-4a4f-aa20-0530bed5b04f
Android: mWeb Chrome
https://github.com/Expensify/App/assets/30054992/bc78ebec-accd-43df-b7e9-2572c06087e4
iOS: Native
https://github.com/Expensify/App/assets/30054992/3980c628-5124-4408-b679-8192c69f0f80
iOS: mWeb Safari
https://github.com/Expensify/App/assets/30054992/845525be-8b26-43ad-a4b3-2d6389c66081
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/30054992/8cd50ce6-9a96-4472-81c8-b7a95d6a9b91
MacOS: Desktop
https://github.com/Expensify/App/assets/30054992/5ac08f53-7141-4bf9-950c-2ad114d21e40
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
๐ Deployed to staging by https://github.com/mountiny in version: 1.4.55-0 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
failure โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
๐ Deployed to staging by https://github.com/mountiny in version: 1.4.55-0 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
๐ Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 ๐
platform
result
๐ค android ๐ค
success โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
success โ
|
2025-04-01T04:55:04.187575
| 2022-06-28T21:01:45
|
1287880424
|
{
"authors": [
"OSBotify",
"roryabraham"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13908",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/9612"
}
|
gharchive/pull-request
|
[No QA] Make preDeploy continue if lint and test succeed
Details
Following-up on https://github.com/Expensify/App/pull/9611 to fix https://github.com/Expensify/App/actions/runs/2579056741.
Fixed Issues
$ n/a
Tests
Merge this PR
Verify that after lint and test succeed, the workflow proceeds.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
๐ Deployed to staging by @roryabraham in version: 1.1.81-0 ๐
platform
result
๐ค android ๐ค
failure โ
๐ฅ desktop ๐ฅ
success โ
๐ iOS ๐
success โ
๐ธ web ๐ธ
failure โ
|
2025-04-01T04:55:04.199669
| 2020-12-19T16:25:19
|
771410138
|
{
"authors": [
"AndrewGable",
"quinthar",
"stitesExpensify",
"tgolen"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0000.json.gz:13909",
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/pull/1025"
}
|
gharchive/pull-request
|
Add new sign in flow
NOTE
This is not hooked up to any APIs yet, it just walks through the form steps.
Things left to do:
[ ] Call GetAccountStatus to see if the user had an account already and if they have access to e.cash
[ ] Call SetGithubUsername to save the github username
[ ] Call CreateLogin if account already existed
[ ] Call CreateAccount if account didn't exist
[ ] See if the 2FA field can be hidden if it's not required (maybe add this to GetAccountStatus?)
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/148719
Fixes https://github.com/Expensify/Expensify/issues/148714
Fixes https://github.com/Expensify/Expensify/issues/148716
Tests
As you go through the testing, verify that form validation works (you can't submit an empty form)
Fill out the login form, verify you are taken to the github username form
Fill out the github username form, verify you are taken to the password form
Fill out the password form, verify you are taken to the resend validation link form
Clear out local storage according to this SO
Refresh the page and verify you are back at the first login form
Screenshots
||
||
cc @chiragsalian @stitesExpensify @shawnborton
Updated to fix conflicts and address comment. Still hard to tell if the logic is all correct until it can be tested. Once it can be fully tested then I'll bring this out of WIP.
FYI - Login isn't saved when I click "Change Expensify login" to go back, should it be?
FYI - Login isn't saved when I click "Change Expensify login" to go back, should it be?
I don't think it should be saved, no. It doesn't make sense that if you wanted to change your login that you would want the old value to be there (since you're explicitly trying to change it).
@marcaaron Thanks for the review! I've addressed some of those. Some of the NABs I'm not going to do in this PR and we can do later if we want. Some of your comments were on outdated code as well, so some of the confusion might have been cleared up already.
Is it intentional that the web version kinda looks like a mobile version?
Hm, ya ideally we'd have a more responsive design for desktop.
On Mon, Dec 21, 2020 at 8:12 PM Brandon Stites<EMAIL_ADDRESS>wrote:
Is it intentional that the web version kinda looks like a mobile version?
[image: 2020-12-21_21-12-23]
https://user-images.githubusercontent.com/42391420/102848104-39178280-43d1-11eb-8baf-e2e0d99dc3da.png
โ
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/Expensify.cash/pull/1025#issuecomment-749327366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMNUVRUACM7HPCU24577DSWAMDXANCNFSM4VCMYHKQ
.
That is sort of intentional... we can do better though. I'll have another PR to try and improve the desktop design.
This is all tested and ready to go, so finally removing WIP
I have read the CLA Document and I hereby sign the CLA
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.