id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-3652-0ba6f9da | DERBY-3652: Add more tests to stress signature matching rules.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@658736 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3652-5c04fbc9 | DERBY-3652: Allow mixing of primitive and wrapper types when matching SQL routine signatures to java methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@657819 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/loader/ClassInspector.java",
"hunks": [
{
"added": [
" *",
" * The preceding paragraph is a bit misleading. As of release 10.4, the",
" * second pass did not consider arbitrary combinations of pri... |
derby-DERBY-3652-78275372 | DERBY-3652: Don't let SQL SMALLINT args match Java numerics bigger than short.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@658427 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" short sequential)"
],
"header": "@@ -719,7 +719,7 @@ public class SystemProcedures {",
"removed": [
" int sequential)"
]
},... |
derby-DERBY-3652-886e6e1f | DERBY-3652: Don't match SQL NUMERIC to Java Object.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@660630 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/loader/ClassInspector.java",
"hunks": [
{
"added": [
" private static final String BIGDECIMAL_TYPE_NAME = \"java.math.BigDecimal\";"
],
"header": "@@ -55,6 +55,7 @@ public final class ClassInspector",
"r... |
derby-DERBY-3652-9de50b22 | DERBY-3652: Add test cases for char and long varchar.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@672029 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3652-d391eecc | DERBY-3652: Add two test cases for signatures which mix types.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@664081 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3652-e8903d64 | DERBY-3652: Add signature matching tests for DECIMAL, DATE, TIME, and TIMESTAMP.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@672323 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3652-ef426356 | DERBY-3652: Add tests for functions which return Blobs and Clobs but disable these tests because Derby chokes on them.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@672781 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3652-f6abacbd | DERBY-3652: Adding some tests for BINARY, VARBINARY, and LONGVARBINARY parameter and return types.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@670660 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3655-10e4538e | DERBY-3655 errror in nightly regression test: LobStreamsTest:encryptedjunit.framework.AssertionFailedError removing temporary lob file.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@701487 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" control = new LOBStreamControl (con, blobBytes);"
],
"header": "@@ -133,7 +133,7 @@ final class EmbedBlob extends ConnectionChild implements Blob, EngineLOB",
... |
derby-DERBY-3659-049ad6e9 | DERBY-3659 ; convert xaJNDI to junit test XAJNDITest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@654656 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3659-23273615 | DERBY-3659 - junit ldap tests - commit minor changes of patch DERBY-3659-3.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@662920 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3659-5883d471 | DERBY-3659; modifying _Suite so it checks for property derbyTesting.ldapServer
instead of derbyTesting.ldapUser, and only runs xaJNDITest if it's set; also
removing old 'sample' master file.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@662094 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3659-f0477245 | DERBY-3659; adding some LDAP tests (patch DERBY-3659-2b.diff).
Patch contributed by Myrna van Lunteren
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@661924 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-366-f578f070 | Fix for
DERBY-8
Connection object gets created with un-supported holdability on getting Connection object from XAConnection "inside" the global transaction
DERBY-366
In jdk13, when a connection transitions from global transaction to local transaction, its default holdability of HOLD_CURSORS_OVER_COMMIT is not restored.
have a patch to fix Derby-8 (Connection object gets created with un-supported holdability on getting Connection object from XAConnection "inside" the global transaction) and Derby-366 (In jdk13, when a connection transitions from global transaction to local transaction, its default holdability of HOLD_CURSORS_OVER_COMMIT is not restored.) The patch is attached to both Derby-8 and Derby-366.
The fix for both these bugs was centered around fixing the holdability handling in BrokeredConnection.java This was because BrokeredConnection.java had no code for restoring the holdability of real connection object and no code for saving the current holdability state of real connection object. I put fix for both these issues in BrokeredConnection.java so that both jdk13 and jdk14+ environments will be handled correctly. Had to use reflection for this holdability work
because Connection.setHoldability and Connection.getHoldability methods are not available through JDK13 apis.
Contributed by Mamta Satoor
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@191755 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java",
"hunks": [
{
"added": [
"import java.lang.reflect.*;",
"",
"import org.apache.derby.iapi.reference.JDBC30Translation;",
"import org.apache.derby.iapi.error.PublicAPI;",
... |
derby-DERBY-3667-34b59c62 | DERBY-3667 SQL roles: Make CURRENT_ROLE check that the role is still valid
This patch, derby-3667-1, makes CURRENT_ROLE, before returning the
value, check if the current role set, if any, is still applicable for the
current user. If it is no longer applicable, the current role is set to NONE.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@654482 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SpecialFunctionNode.java",
"hunks": [
{
"added": [
"\t\t\tmethodName = \"getCurrentRoleIdChecked\";",
"\t\t\t\tTypes.VARCHAR, true, 128);"
],
"header": "@@ -158,10 +158,10 @@ public class SpecialFuncti... |
derby-DERBY-3669-6a5890fe | DERBY-3669: ClientXADataSource fetched from JNDI not identical as originally bound; some properties have String "null" instead of null
Changed ClientBaseDataSource.getReference() to match the embedded
implementation in ReferenceableDataSource, which already handles null
values.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@792434 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3674-ec55311e | DERBY-3674
Inplace compress test in store/TransactionTable.sql started failing after the checkin for DERBY-1062.
Prior to the fix for DERBY-1062, an inplace compress request on VTI would return with no exception
although the code just ignored the compress request on VTI. After DERBY-1062 fix, Derby started
throwing exception. With the changes going through this commit, I am restoring the behavior to no-op
on inplace compress on VTI. I am doing this by making the check for VTI in SystemProcedure and returning
from it if it is a VTI. All the other inplace compress request get fulfilled through internal
generation of ALTER TABLE sql.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@656797 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.access.TransactionController;",
"import org.apache.derby.iapi.sql.dictionary.DataDictionary;",
"import org.apache.derby.iapi.sql.dic... |
derby-DERBY-3678-e4ada410 | DERBY-3678 StackOverflowException in deadlock trace
Patch derby-3678-3 which solves the issue and adds a new regression test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@666901 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
"\t{",
"\t\treturn locateSchemaRowBody(",
"\t\t\tschemaId,",
"\t\t\tTransactionController.ISOLATION_REPEATABLE_READ,",
"\t\t\ttc);",
... |
derby-DERBY-3682-5b90cf19 | DERBY-3682: SYSCS_BULK_INSERT doesn't quote identifiers or strings properly
Ensure proper quoting of SQL identifiers and string literals by using
utility functions in StringUtil and IdUtil. VTITest has been updated
to test SYSCS_BULK_INSERT with a table containing single quotes and
double quotes in its name.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@660153 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" String escapedSchema = IdUtil.normalToDelimited(schema);",
" String escapedTableName = IdUtil.normalToDelimited(tablename);"
],
"header": "@@ -723... |
derby-DERBY-3686-6bd82a52 | DERBY-3686 convert predicatePushdown.sql to JUnit
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@661847 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/RuntimeStatisticsParser.java",
"hunks": [
{
"added": [
" "
],
"header": "@@ -74,6 +74,7 @@ public class RuntimeStatisticsParser {",
"removed": []
},
{
"added": [
" ",
... |
derby-DERBY-3689-2949b9fb | DERBY-3689: 'PrivilegedActionException: javax.management.InstanceNotFoundException' in '*(VersionMBeanTest / NetworkServerMBeanTest)'
Register MBeans before starting the client thread so that the MBeans
can be accessed by the tests once they detect the network server is
up and running.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1138444 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"",
" // First, register any MBeans. We do this before we start accepting",
" // connections from the clients to ease testing of JMX (DERBY-3689).... |
derby-DERBY-3690-9526f797 | DERBY-3690: EmbedPooledConnection doesn't reset schema when creating a new logical connection.
Fixes the bug by resetting the schema in GLCC.resetFromPool, and adds two regression tests.
Patch file: derby-3690-1b-reset_schema.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@660404 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" /**",
" * Asserts that the current schema is the same as the one specified.",
" *",
" * @param con connection to check schema in",
" ... |
derby-DERBY-3693-8106edc9 | DERBY-3850: Remove unneeded workarounds for DERBY-177 and DERBY-3693
Removed the wait parameter from methods called from
SPSDescriptor.updateSYSSTATEMENTS() since waiting is prevented by
another mechanism now.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@692495 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDictionary.java",
"hunks": [
{
"added": [
"\t\tTransactionController\ttc"
],
"header": "@@ -1072,15 +1072,13 @@ public interface DataDictionary",
"removed": [
"\t * @param wait\t\t\tTo w... |
derby-DERBY-3693-85e3e123 | DERBY-3693: Deadlocks accessing DB metadata
Make sure that the nested transaction used to recompile meta-data
queries does not wait for locks to prevent hangs when there's a lock
conflict between the nested transaction and the user transaction.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@688274 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/locks/AbstractPool.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.SQLState;",
"import org.apache.derby.iapi.services.locks.LockOwner;"
],
"header": "@@ -39,6 +39,8 @@ import org.ap... |
derby-DERBY-3693-a9215529 | DERBY-3850: Remove unneeded workarounds for DERBY-177 and DERBY-3693
Removed the wait parameter from TabInfoImpl.updateRow(). The method
only had two callers, both of which called it with
wait=true. updateRow() passed the parameter on to openForUpdate() in
RowChanger, but that method is sometimes called with wait=false, so
the parameter couldn't be removed from that method.
Also removed an unused variable and some unused imports.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@695244 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/TabInfoImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -22,18 +22,14 @@",
"removed": [
"import org.apache.derby.iapi.services.context.ContextService;",
"import org.apache.derby.iapi.sql.conn.Langua... |
derby-DERBY-3695-8a4e363f | DERBY-3695: NullPointerException when invoking statement event listeners if one of the listeners is null
Made addStatementEventListener(null) a no-op on the client to match embedded.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@661292 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3696-015b39a6 | DERBY-3696: Delete superfluous test lang/longStringColumn.java.
Patch file: derby-3696-1a-delete_longStringColumn_test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@663062 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3701-1bc76745 | DERBY-3701: Fixed indentation
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@664530 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/Session.java",
"hunks": [
{
"added": [
" this.nsctrl = nsctrl;"
],
"header": "@@ -88,7 +88,7 @@ class Session",
"removed": [
" this.nsctrl = nsctrl;"
]
},
{
... |
derby-DERBY-3701-45680ff9 | DERBY-3701 java.lang.Exception: DRDA_UnableToAccept.S:Unable to accept connections and client hang if tracing is turned on but traceDirectory does not exist
- attempt to create directory if it does not exist.
- log an error but do not hang the client if session tracing file cannot be created.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@664124 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DssTrace.java",
"hunks": [
{
"added": [
"import java.io.File;",
"import org.apache.derby.iapi.util.PrivilegedFileOps;",
""
],
"header": "@@ -20,12 +20,15 @@",
"removed": []
},
{
... |
derby-DERBY-3704-1ba604e3 | DERBY-3704 If an IOException is encountered during establishment of the connection, Network Server should print the root exception to the console instead of a generic message
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@662876 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/ClientThread.java",
"hunks": [
{
"added": [
" parent.consoleExceptionPrintTrace(ioe);",
" if (clientSocket != null)",
" clientSocke... |
derby-DERBY-3705-5e717f9f | DERBY-3705: In Net Client mode, negative values for stream length are accepted without an exception for PreparedStatement.setAsciiStream().
Added check to disallow specified stream length to be negative.
Refactored specified length checking into a single method.
Patch file: derby-3705-2b.diff
Patch contributed by Suran Jayathilaka.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@666174 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/PreparedStatement.java",
"hunks": [
{
"added": [
" checkStreamLength(length);"
],
"header": "@@ -1022,11 +1022,7 @@ public class PreparedStatement extends Statement",
"removed": [
" ... |
derby-DERBY-3706-00077a4f | DERBY-3706 NetworkServer console messages should print a time stamp
Contributed by Suran Jayathilaka
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@674354 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"\t\tconsoleMessage(msg, true);"
],
"header": "@@ -538,7 +538,7 @@ public final class NetworkServerControlImpl {",
"removed": [
"\t\tconsoleMessag... |
derby-DERBY-3708-ea9b68b4 | DERBY-3708 setting tracedirectory from the command line does not work
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@669243 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3709-d2291224 | DERBY-3709
Changes the replication test to ensure that the failure due
to failover being started before replication is booted is
not hidden
Patch Contributor: Ole Soldberg
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@666006 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3710-9d7aba6f | DERBY-3710: For AES encryption, store checksum that is computed on padded key rather than unpadded key.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@800773 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/jce/JCECipherFactory.java",
"hunks": [
{
"added": [
"\tprivate EncryptedKeyResult encryptKey(byte[] secretKey, byte[] bootPassword)"
],
"header": "@@ -187,7 +187,7 @@ public final class JCECipherFactory implements ... |
derby-DERBY-3718-90701f7b | DERBY-3718
Derby has an internal datatype called REF. For REF datatypes, we associate Types.OTHER as it's type. This
association of Types.OTHER for REF datatype is causing NPE when a row level trigger is fired in the test
case provided in DERBY-3718.
This NPE happens only in 10.4 and trunk. This is because starting 10.4(DERBY-2917 revision r619995),
rather than saving the TypeId of the DataTypeDescriptor (in DataTypeDescriptor.writeExternal method), we
rely on reconstructing TypeId (in readExternal) by using the Types.xxx associated with a type. This
approach does not work for internal datatype REF, because we use Types.OTHER for REF datatypes.
Types.OTHER is not enough to know that the type to be constructed is REF.
Since we are dealing with the internal type which will be assigned a Types.OTHER type then we can't rely on Types.xxx to get us the correct data type. This fix relies on using the name of the data type rather
than it's Type.xxx to construct the correct TypeId. This is being accomplised by changing
DataTypeDescriptor.readExternal to use this.getTypeName rather than this.getJDBCTypeId to construct the TypeId. In addition to this change, I had to change DataTypeDescriptor.getTypeName() to use TypeDescriptor to get the type name rather than TypeId. This is because TypeId is not available when DataTypeDescriptor.readExternal calls DataTypeDescriptor.getTypeName. This will match how we already implement DataTypeDescriptor.getJDBCTypeId(). Junit and old harness suite have run with no new regressions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@670778 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java",
"hunks": [
{
"added": [
"\t\treturn typeDescriptor.getTypeName();"
],
"header": "@@ -1036,7 +1036,7 @@ public final class DataTypeDescriptor implements Formatable",
"removed": [
... |
derby-DERBY-3723-818ef2ab | DERBY-3723: Reset current schema to default (user name) when creating a new logical connection in the client driver.
Resets the schema to the associated user name for the physical connection when creating a new logical connection (which is currently implemented as resetting the physical connection).
Also made 'Connection.user_' final.
Patch file: derby-3723-1a-client_schema_reset.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@671128 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" protected final String user_;"
],
"header": "@@ -61,7 +61,7 @@ public abstract class Connection implements java.sql.Connection,",
"removed": [
" publi... |
derby-DERBY-3726-9b54b81f | DERBY-3726: Don't call RAFContainer.padFile() from instances of RAFContainer4
When we create a new container, allocate a byte array that is large
enough to hold an entire page so that we don't need to pad the file
after writing the array to disk.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@670534 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java",
"hunks": [
{
"added": [
"",
" // Allocating AllocPage.MAX_BORROWED_SPACE bytes for the",
" // embryonic page should be enough, but we want to leave",
" ... |
derby-DERBY-3727-30c9f828 | DERBY-3727 Improve error information reported when encountering "ERROR XSDB3: Container information cannot change once written: was 103, now 80"
Added error reporting of the container id when an error is encountered while
writing the container header information.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@959378 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/FileContainer.java",
"hunks": [
{
"added": [
"\tprotected void writeHeader(",
" Object identity, ",
" byte[] pageData)",
" try",
" {",
"... |
derby-DERBY-3728-e906df8e | DERBY-3728: Fix error handling in PrivilegedFileOpsForTests.
Removed unnecessary throws clauses (replaced PrivilegedExceptionAction with PrivilegedAction) and the possibility for a ClassCastException.
Fixed some documentation.
Patch file: derby-3728-1a.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@702518 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3731-2365e789 | DERBY-3731: Improve calculation of refSize in ClassSize.java.
Changed implementation to get the value for refSize through system properties. If that doesn't work due to missing privileges or unknown values, we fall back to the heuristic.
The system properties consulted are "sun.arch.data.model" and "os.arch".
Patch file: derby-3731-1c-refsize_from_properties.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@679690 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/cache/ClassSize.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;",
"import java.util.Arrays;"
],
"header": "@@ -23,11 +23,11 @@ pa... |
derby-DERBY-3732-146fd5c0 | DERBY-3732 SQL Length function materializes BLOB into memory
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@672818 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLBinary.java",
"hunks": [
{
"added": [
"\t\t\tthrowStreamingIOException(ioe);"
],
"header": "@@ -229,7 +229,7 @@ abstract class SQLBinary",
"removed": [
"\t\t\tthrow StandardException.newException(... |
derby-DERBY-3734-054acc3b | DERBY-3734
Changing the undocumented property derby.storage.fileCacheSize to allow
any maximum setting, previously it limited the setting to a maximum of 100.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@671240 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/BaseDataFileFactory.java",
"hunks": [
{
"added": [
" // Initialize the page cache"
],
"header": "@@ -377,6 +377,7 @@ public class BaseDataFileFactory",
"removed": []
},
{
"a... |
derby-DERBY-3735-18fca03d | DERBY-3735: Incorrect position calculation in PositionedStoreStream with read(byte[],...).
Fixed calculation by only adding positive integers (not allowing -1).
Added a general test and a regression test.
Made LoopingAlphabetStream implement Resetable to allow it to be used for testing where a resetable stream is expected.
Patch file: derby-3735-1b.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@671840 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/PositionedStoreStream.java",
"hunks": [
{
"added": [
" return read(b, 0, b.length);"
],
"header": "@@ -96,9 +96,7 @@ public class PositionedStoreStream",
"removed": [
" int ret = this.st... |
derby-DERBY-3736-0eb97d9e | DERBY-3736 Revoking a column level privilege from a user, a prepared statement relying on that privilege can still be executed
Patch derby-3736b, which fixes this issue, and adds a new testcase.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@674808 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3739-33fa3208 | DERBY-3739: Skip and read methods in ArrayInputStream may overflow
Changed checks in read() and in readFully() so that they are not
vulnerable to integer overflow.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@673610 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/ArrayInputStream.java",
"hunks": [
{
"added": [
" final int available = available();",
" if (len > available) {",
" // attempted to read more bytes than available",
" ... |
derby-DERBY-3739-50af3048 | DERBY-3739: Skip and read methods in ArrayInputStream may overflow
Fixed problems with negative byte count and overflow in skip() and
skipBytes(), and added a unit test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@673026 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/ArrayInputStream.java",
"hunks": [
{
"added": [
" /**",
" * Skip as many bytes as possible, but no more than {@code count}.",
" *",
" * @param count the number of bytes to skip",
... |
derby-DERBY-374-a36fdb78 | DERBY-374
Invalid URL with Derby Client when connecting to Network Server causes protocol exception.
This patch does the following:
1. Network server used to give NPE when InternalDriver returns null connection for certain malformed URLs. With this patch, network server checks for null connections returned by InternalDriver and returns RDBAFLRM and SQLCARD with null SQLException.
2. The client parses the SQLCARD and if finds null SQLException, it sets connectionNull variable in NetConnection to true.
3. ClientDriver connect method, which calls the constructor of NetConnection, gets back an object with connectionNull set to true. And it inturn returns null connection.
4. Added tests to checkDriver.java for more Client URLs.
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@292917 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnection.java",
"hunks": [
{
"added": [
" ",
" //If Network Server gets null connection from the embedded driver, ",
" //it sends RDBAFLRM followed by SQLCARD with null SQLException.",
" ... |
derby-DERBY-3740-3149593e | DERBY-3740 BlobClob4BlobTest.testLockingWithLongRowBlob fails with .AssertionFailedError: FAIL - statement should timeout
The 2 tests that were failing intermittently (testLockingWithLongRowBlob
and testLockingBlob) would both select a target blob known to be returned
as a stream, and assign it to a variable. The expectation was that until
the end of the routine Derby would maintain a read lock on the blob. The
problem was that it looks like some JVMs/JITs would recognize that the variable
was never used and call finalize before the test executed the code to
get an expected lock timeout on updating the blob in another connection.
Fixed by adding references to the variable in code executed after the
expected timeout. Before the fix test was failing about 1/2 time in my
environment, after the fix the test ran 100 times without a failure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1240521 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3742-373cb84f | DERBY-3742: Move test code from CompressedNumber to a unit test
Added a JUnit test with the test code and removed it from CompressedNumber.
Contributed by Junjie Peng <pjj.ccce@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@673057 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3742-d241e83d | DERBY-3742: Move test code from CompressedNumber to a unit test
* Added CompressedNumberTest to the JUnit suite
* Made checkInt() and checkLong() verify the compressed length
Contributed by Junjie Peng <pjj.ccce@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@673328 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/unitTests/junit/_Suite.java",
"hunks": [
{
"added": [
" suite.addTestSuite(CompressedNumberTest.class);"
],
"header": "@@ -50,6 +50,7 @@ public class _Suite extends BaseTestCase {",
"removed": []
}
... |
derby-DERBY-3743-1a63d73f | DERBY-3743 Revoking EXECUTE privilege on a function if used in a CHECK constraint: implementation problem
Patch derby-3743, which changes the implementation and adds a test
case to verify that the change doesn't break the current behavior.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@675129 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConstraintDescriptor.java",
"hunks": [
{
"added": [
"\t\t case DependencyManager.INTERNAL_RECOMPILE_REQUEST:"
],
"header": "@@ -557,6 +557,7 @@ public abstract class ConstraintDescriptor",
"removed... |
derby-DERBY-3743-8875d690 | DERBY-3743 Revoking EXECUTE privilege on a function if used in a CHECK constraint: implementation problem
Patch derby-3743b-2, which is a follow-up to the first patch of this issue.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@685526 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/CreateConstraintConstantAction.java",
"hunks": [
{
"added": [
"\t\t\t\t\t(activation, conDesc, null, providerInfo);"
],
"header": "@@ -329,7 +329,7 @@ public class CreateConstraintConstantAction extends Constrai... |
derby-DERBY-3745-3ea4878b | DERBY-3745 Derby can leak classloaders in an app server environment
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@675956 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.util.PrivilegedThreadOps;"
],
"header": "@@ -41,6 +41,7 @@ import org.apache.derby.iapi.services.jmx.ManagementService;",
... |
derby-DERBY-3745-493b80e2 | DERBY-6619 After silently swallowing SecurityExceptions, Derby can leak class loaders
Patch derby-6619-2.
The fix introduced in DERBY-3745 correctly is there in order to
protect against the case where the thread that starts Derby, has a
context class loader that is different from the system class
loader. In such cases, if the timer thread inherits the context class
loader, the context class loader will stay in memory until the Derby
engine is shut down, even if all other references to the class loader
are gone.
If the context class loader is the same as the system class loader, on
the other hand, such a "leak" would not be a problem, since the system
class loader will stay in memory until the JVM is shut down anyway.
We take advantage of this and only attempt to change the context class
loader if it is different from the system class loader. With this
patch, no warning is printed to derby.log when starting the server
from the command line, and there's no warning when starting the server
using the API with a security manager installed when the context class
loader hasn't been changed from the default. However, if the server is
started using the API with a non-default context class loader, we do
see warnings in derby.log if a security manager is installed and the
permission to set the class loader is missing.
Added tests for this behavior. Moved utility methods from
UpgradeClassLoader to ClassLoaderTestSetup, a new decorator. It seemed
more logical to put them there to allow reuse.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1620379 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/ClassLoaderTestSetup.java",
"hunks": [
{
"added": [
"/*",
" * Derby - Class org.apache.derbyTesting.junit.ClassLoaderTestSetup",
" *",
" * Licensed to the Apache Software Foundation (ASF) under one or... |
derby-DERBY-3745-7f4445db | DERBY-3887 Embedded Derby fails under JBoss because of JMX-related conflicts
Backed out JMX related changes for DERBY-3745.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@784831 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java",
"hunks": [
{
"added": [],
"header": "@@ -163,43 +163,7 @@ public final class JMXManagementService implements ManagementService, ModuleCont",
"removed": [
" //DERBY-3745 We wan... |
derby-DERBY-3745-921e39ea | DERBY-6619 After silently swallowing SecurityExceptions, Derby can leak class loaders
Patch derby-6619-2-refinement which implements the following
refinements to the test to avoid changing the context class loader in
SingletonTimerFactory (suggested by Knut):
The orginal test tested against the system class loader. This new patch will:
1) Check if the context class loader is the same as the loader of the
SingletonTimerFactory class (that is, the class loader from which
Derby classes are loaded). Even if this isn't the same as the system
class loader, it would be safe to skip the workaround for DERBY-3745,
since the class loader for the Derby classes would not be eligible for
garbage collection until the engine is shut down anyway. This would
prevent some more false positives from being reported in
derby.log. I'd assume this is a kind of false positive that could
easily occur in an application server environment where the Derby
classes are not found on the system class loader.
2) Check against Thread.class.getClassLoader() instead of
ClassLoader.getSystemClassLoader(). Normally, those two checks would
be identical. If however the setup is such that they aren't identical,
we'd still know that the class loader actually used for system classes
such as the Thread class would have to stay in memory for as long as
the timer thread is alive, regardless of the context class loader of
the thread, so the workaround for DERBY-3745 can be skipped if it's
the same as the context class loader. The check will be a bit more
specific this way.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1620385 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/timer/SingletonTimerFactory.java",
"hunks": [
{
"added": [
" if (cl == getClass().getClassLoader() ||",
" cl == Thread.class.getClassLoader()) {",
" ... |
derby-DERBY-3745-9e91a063 | DERBY-3803 fix 'org.apache.derbyTesting.functionTests.tests.lang.XMLTypeAndOpsTest' failures after checkin for DERBY-3745
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681104 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/SingleThreadDaemonFactory.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.util.PrivilegedThreadOps;"
],
"header": "@@ -26,6 +26,7 @@ import org.apache.derby.iapi.services.daemon.DaemonFactory;",... |
derby-DERBY-3745-c34c8e09 | DERBY-3745 inline doPrivileged blocks instead of using utility methods which can be a security risk.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@685674 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/SingleThreadDaemonFactory.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;",
"",
""
],
"header": "@@ -21,12 +21,1... |
derby-DERBY-3745-eab02c20 | DERBY-3745 Derby can leak classloaders in an app server environment
Cleanup change to set context class loader for newly created threads
directly rather than setting the context classloader of the current
thread before creation.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@679620 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java",
"hunks": [
{
"added": [
"\t\t// DERBY-3745. setContextClassLoader for thread to null to avoid",
"\t\t// leaking class loaders.",
"\t\tPrivilegedThreadOps.setContextClassLoaderIfPrivi... |
derby-DERBY-375-09150393 | DERBY-375
Specification of incomplete server properties on command line causes NPE with NetworkServerControl when starting the server.
The patch does the following:
1. Moves the call to 'init', which initializes 'langUtil', before the call to 'getPropertyInfo' method in the constructors of NetworkServerControlImpl.
2. If the system properties are specified without values, use defaults for them.
3. For 'derby.drda.traceDirectory' property following is mentioned in the doc - "If the derby.system.home property has been set, it is the default. Otherwise, the default is the current directory.". 'getPropertyInfo' was getting the value of 'derby.system.home' but not using it as default for 'derby.drda.traceDirectory'.
So the current directory was always getting used as default. Changed this.
4. When I added the default for 'derby.drda.traceDirectory', the tests derbynet/getCurrentProperties.java and derbynet/sysinfo.java had additional lines for derby.drda.traceDirectory in their outputs. Since the directory listed is dependent on the test directory, I have sed out 'traceDirectory' lines for these tests.
5. Adds tests to derbynet/testProperties.java.
6. Fixes javadoc for 'traceDirectory' in NetworkServerControl.
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@321274 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"\t\tgetPropertyInfo();"
],
"header": "@@ -285,8 +285,8 @@ public final class NetworkServerControlImpl {",
"removed": [
"\t\tgetPropertyInfo();"
... |
derby-DERBY-3754-01d6da33 | DERBY-3754 Convert "org.apache.derbyTesting.functionTests.tests.lang.connect.sql" to junit
Contributed by Junjie Peng
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@676970 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3757-f8b521a5 | DERBY-4365
For JOIN, we were doing a no-op in the method bindUntypedNullsToResultColumns(ResultColumnList) rather than checking for untyped nulls for the left and right resultsets. The changes through this commit now checks for untyped nulls for joins. Added couple more tests (including where a CAST of NULL values should work fine). The derbyall and junit suites ran fine with the exception of known intermittent (DERBY-3757) 'ASSERT FAILED transaction table has null entry when running new StressMultiTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@833430 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3763-cd1bd2a0 | DERBY-3763: Rename BaseJDBCTestCase.usingDerbyNet.
Renamed to usingDB2Client.
Patch file: derby-3763-1b-usingDB2Client.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@677848 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBCClient.java",
"hunks": [
{
"added": [
" * AKA: JCC or DB2 client (was called DerbyNet earlier, the \"old net\"",
" * client for Derby).",
" \"DB2Client\","
],
"header": "@... |
derby-DERBY-3764-0255faae | DERBY-3764: Union Query fail on Derby 10.4.1.3
A SetOperatorNode inherits the result column list from its left
operand. This patch makes sure that all generated grouping columns are
removed from the SetOperatorNode's column list to prevent it from
seeing extra columns that cause confusion when the set operation is
performed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@678668 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\t\t\"visibleSize() = (\" +",
"\t\t\t\t\t\t\tvisibleSize() +",
"\t\t\t\t\t\t\t\") is expected to equal otherRCL.visibleSize (\" +",
"\t\t\... |
derby-DERBY-3764-17f3832c | DERBY-3764: Union Query fail on Derby 10.4.1.3
Only look at the visible columns when checking that the expressions in
a UNION query are compatible. This prevents
ArrayIndexOutOfBoundsException from being thrown when preparing some
queries that contain GROUP BY clauses. It is only a partial fix, since
some of the queries run into other problems later in the execution.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@676819 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [
"\t\tint size = visibleSize();"
],
"header": "@@ -2233,7 +2233,7 @@ public class ResultColumnList extends QueryTreeNodeVector",
"removed": [
"\t\... |
derby-DERBY-3766-846a5335 | DERBY-3766 (partial): EmbedBlob.setPosition is highly ineffective for streams.
A preparation patch for the main fix, addressing several minor issues:
a) Change type of 'myStream' from InputStream to PositionedStoreStream.
This includes removing superfluous casts.
b) Fixed typo in JavaDoc for 'streamLength'
c) Improved JavaDoc for 'read()'
d) Made exception in 'truncate' use the correct position argument.
e) Added/updated a few comments.
Patch file: derby-3766-1a-preparations.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@677619 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" /**",
" * The underlying positionable store stream, if any.",
" * <p>",
" * If {@link #materialized} is {@code true}, the stream is {@code null}."... |
derby-DERBY-3766-cd7ef76f | DERBY-3766: EmbedBlob.setPosition is highly ineffective for streams.
a) Removed the 'pos' and 'biStream' variables. A "global" Blob position is no longer maintained by EmbedBlob.
b) Introduced 'streamPositionOffset' to account for the encoded length bytes. Only used when the Blob is represented by a store stream. Set to Integer.MIN_VALUE when unused. Otherwise, the offset is obtained in the constructor, where the Blob length is saved for later use as well if it is known (the stream is not skipped to find length).
c) Removed 'BLOB_BUF_SIZE' and 'buf', they're no longer needed.
d) Renamed 'setPosition' to 'setBlobPosition' and rewrote the method. The method now relies on PositionedStoreStream to do the repositioning. In some cases this will lead to using the same algorithm as earlier, otherwise it will be more effective because the stream isn't reset. Note the addition of 'streamPositionOffset' to the logical zero-based Blob position. Also note that another SQLState is used. The method also returns the new position (this is only for convenience).
e) Changes in read(); added pos argument, don't throw SQLException, use the correct stream.
f) Updated length() to reflect changes.
g) Rewrote the two 'position' methods to maintain a local position variable. Also removed special handling for the BLOB_LENGTH_TOO_LONG exception.
h) Updated JavaDoc and added position argument for the two 'checkMatch' methods.
i) Added one new test in BlobClob4BlobTest.
Patch file: derby-3766-2a-position_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681359 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
"import java.io.EOFException;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.iapi.services.io.InputStreamUtil;",
"removed": []
},
{
"added"... |
derby-DERBY-3767-4293daff | DERBY-3767 Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. Forgot to svn add test.
Contributed by Junjie Peng
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@684848 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3768-37ae69e3 | DERBY-3768: Make EmbedBlob.length use skip instead of read.
Replaced read loop with a skip loop (potential optimization).
Note the verification of EOF when skip returns zero, which seems safer (due to the somewhat relaxed contract of InputStream.skip).
Patch file: derby-3768-1b-length_skip.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@675169 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.Limits;"
],
"header": "@@ -25,18 +25,15 @@ package org.apache.derby.impl.jdbc;",
"removed": [
"import org.apache.derby.... |
derby-DERBY-3768-b526e7fe | DERBY-3768: Make EmbedBlob.length use skip instead of read.
- JavaDoc improvements
- set locator value explicitly to indicate default value (must not be a valid locator)
- renamed 'myLength' to 'streamLength'
- keep variables 'materialized' and 'streamLength' in sync
- throw exception in second constructor (mistakenly swallowed)
- only clear LOB mapping if a mapping has been created
Patch file: derby-3768-2a-misc_fixes.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@676571 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java",
"hunks": [
{
"added": [
" /**",
" * Tells whether the Blob has been materialized or not.",
" * <p>",
" * Materialization happens when the Blob is updated by the user. A",
... |
derby-DERBY-3769-1028de4a | DERBY-3769: Make LOBStoredProcedure on the server side smarter about the read buffer size.
Adjusts the maximum return size in characters for the CLOB stored procedure to 10890 (DB2_VARCHAR_MAXWIDTH / 3). This potentially results in anything from 10890 to 10890*3 bytes to be returned to the client in one round-trip, depending on the bytes per char ratio (determined by the modified UTF8 encoding).
This fix is sub-optimal for Clobs with ASCII contents, but improves performance for Clobs with contents requiring 2 or 3 bytes per char dramatically.
Patch file: derby-3769-2b-clob_buffer_size_adjustment.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@707097 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java",
"hunks": [
{
"added": [
" * The maximum length of the data returned from the BLOB stored procedures.",
" public static final int MAX_BLOB_RETURN_LEN = Limits.DB2_VARCHAR_MAXWIDTH;",
... |
derby-DERBY-3769-46244ea2 | DERBY-3769: Make LOBStoredProcedure on the server side smarter about the read buffer size.
Adjust amount of data to fetch (and thus read) if it is greater then the maximum allowed return length of the LOB stored procedures (width of VARBINARY/VARCHAR).
Reading/fetching more data caused the stream position to be advanced too far and resulted in a stream reset followed by skipping of data until at the correct position again.
Patch file: derby-3769-1b-buffer_size_adjustment.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@676912 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.Limits;"
],
"header": "@@ -27,6 +27,7 @@ import java.sql.DriverManager;",
"removed": []
},
{
"added"... |
derby-DERBY-3770-27628a01 | DERBY-3770: Create a utility class for skipping data in an InputStream
Moved helper methods from iapi/util to iapi/services/io and reduced
the number of calls to skipPersistent() from skipUntilEOF().
Patch contributed by Junjie Peng <pjj.ccce@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@691253 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/InputStreamUtil.java",
"hunks": [
{
"added": [
" private static final int SKIP_FRAGMENT_SIZE = Integer.MAX_VALUE;"
],
"header": "@@ -29,6 +29,7 @@ import java.io.*;",
"removed": []
}
]
},
... |
derby-DERBY-3770-a1c1356a | DERBY-3770: Create a utility class for skipping data in an InputStream
Replaced skip loops with calls to the new utility methods in
- EmbedBlob.length()
- PositionedStoreStream.reposition()
- UpdatableBlobStream.updateIfRequired()
- SQLBinary.getLength()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@709856 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLBinary.java",
"hunks": [
{
"added": [],
"header": "@@ -25,32 +25,22 @@ import org.apache.derby.iapi.reference.SQLState;",
"removed": [
"import org.apache.derby.iapi.services.io.FormatableBitSet;",
"import... |
derby-DERBY-3770-cd822ebe | DERBY-3770: Create a utility class for skipping data in an InputStream
Removed these unused methods from CompressedNumber:
- readIntAndReturnIntPlusOverhead(byte[], int)
- skipInt(DataInput)
- skipInt(InputStream)
- skipLong(DataInput)
- skipLong(InputStream)
The skip methods were buggy because they didn't check the return value
from InputStream.skip() or DataInput.skipBytes() and could possibly
skip too few bytes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@709900 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/CompressedNumber.java",
"hunks": [
{
"added": [],
"header": "@@ -257,137 +257,11 @@ public abstract class CompressedNumber {",
"removed": [
" /**",
" * Return the compressed Int value + stored s... |
derby-DERBY-3771-7d66c732 | DERBY-3771 testClasspathChecker under SysinfoCPCheckTest failed on Zos
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@675669 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3775-25378cb2 | DERBY-3775 BlobStoredProcedureTest failed on Zos
The test expected the number of bytes in String.getBytes() to match the number of characters in the string. Used US-ASCII encoding so this would be true.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@676014 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-378-3568cea1 | DERBY-378 (partial)
This patch adds some code required to support import/exoprt of lob data.
1) Addded code to read clob data using getCharacterStream()
instead of getString() while importing clob data from an extern file.
(Note: Clobs are read using getString() until DERBY-2465 is fixed).
2) Made some code changes to make each lob column has it it's own file handle to
the lob file to read the data, otherwise streams can get corrupted when
there are more than one clob/blob type column in the table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@520197 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/ImportAbstract.java",
"hunks": [
{
"added": [
" if (isColumnInExtFile(columnIndex)) {",
"\t\t\tval = importReadData.getClobColumnFromExtFileAsString(val, ",
" ... |
derby-DERBY-378-7c20bd09 | DERBY-378 (partial)
This patch checks for invalid hex strings in the import file
while performing import into a table with CHAR FOR BIT DATA,
VARCHAR FOR BIT DATA, LONG VARCHAR FOR BIT DATA data types.
Import will throw an exception if it detects any invalid hex
strings during import.
Tests:
Added a new junit test case to ImportExportBinaryDataTest.java
to test for the invalid hex strings in the import file.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@516145 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/ImportAbstract.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.PublicAPI;",
"import org.apache.derby.iapi.reference.SQLState;",
"import org.apache.derby.iapi.error.StandardException;",
... |
derby-DERBY-378-c8f894e5 | DERBY-378 (partial)
This patch changes the names of the new system procedures added to
support import/export of lob data. New procedure names are :
SYSCS_UTIL.SYSCS_EXPORT_TABLE_LOBS_TO_EXTFILE(..)
SYSCS_UTIL.SYSCS_EXPORT_QUERY_LOBS_TO_EXTFILE(..)
SYSCS_UTIL.SYSCS_IMPORT_DATA_LOBS_FROM_EXTFILE(...)
SYSCS_UTIL.SYSCS_IMPORT_TABLE_LOBS_FROM_EXTFILE(..)
Removed the test cases added earlier to ieptests.sql test
for this issue, now those test cases are covered by the
new junit tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@523028 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" * are exported to an external file and the reference to it is written ",
" * SYSCS_EXPORT_TABLE_LOBS_TO_EXTFILE(IN SCHEMANAME VARCHAR(128), ",
" public st... |
derby-DERBY-378-e17a43de | DERBY-378 (partial)
This patch makes lob file to be created in the same location
as main export file , if the specified lob file name is
unqualified. i.e fileName string just contains the name
of the file. And also improved error messages for couple
of user error cases.
Added test cases for the above and also modified some existing
test cases to perform import/export using different codeset.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@527319 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/Export.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.error.PublicAPI;",
"import org.apache.derby.iapi.reference.SQLState;",
"import org.apache.derby.iapi.error.StandardException;",
""
... |
derby-DERBY-378-fef20ca2 | DERBY-378 (partial)
This patch adds code required to enable new system procedures added to
support import/export of lob data on hard upgrade from versions before
10.3. Added a new test case to the 10.3 upgrade test cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@522077 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-378-ffdaf1e6 | DERBY-378 (partial)
This patch adds code to handles NULL (SQL NULL) data while
performing import/export of table with column types blob, clob.
Checks for invalid hex strings in the import file while performing
import into a table with Blob column. Import will throw an exception
if it detects any invalid hex strings in the import file for blob column.
Tests:
1) Added a new junit test ImportExportLobTest.java to
tests import/export of clobs and blob data.
2) Wrapped BufferInputStream/BufferedReader around the streams
used in BaseJDBCTestCase.java:assertEquals() methods to compare
clobs/blobs. Without buffering these assert method were really slow.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@518427 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/ExportWriteData.java",
"hunks": [
{
"added": [
" if (istream != null ) {",
" while(noBytes != -1) ",
" {",
" lobOutBinaryStream.write(byteBuf, 0 , noBytes);",
... |
derby-DERBY-3780-c3ff1bd3 | DERBY-3780 fix some encoding problems in tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@678063 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3781-634b64f4 | DERBY-3781: PositionedStoreStream.reposition(pos) with pos greater than length leaves the stream object in an inconsistent state.
Reset the underlying stream and the position to zero after an unsuccessful positioning attempt (requestedPos > length).
Patch file: derby-3781-1a-fix_and_test.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@677172 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3781-7cba6d5f | DERBY-3781: PositionedStoreStream.reposition(pos) with pos greater than length leaves the stream object in an inconsistent state.
Code cleanup, removing an unnecessary convenience variable that can lead to future bugs if used.
Patch file: derby-3781-2b-remove_convenience_link.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@677281 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/PositionedStoreStream.java",
"hunks": [
{
"added": [],
"header": "@@ -60,9 +60,6 @@ public class PositionedStoreStream",
"removed": [
" /** Convenience reference to the stream as a resettable stream. */",
... |
derby-DERBY-3783-1c589afd | DERBY-3783: LOBStreamControl shouldn't throw SQLException.
Throw StandardException instead of SQLException at this level of the code.
Patch file: derby-3783-1a-dont_throw_sqlexception.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@677623 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBInputStream.java",
"hunks": [
{
"added": [],
"header": "@@ -24,7 +24,6 @@ package org.apache.derby.impl.jdbc;",
"removed": [
"import java.sql.SQLException;"
]
},
{
"added": [
" ... |
derby-DERBY-3783-ed0be21a | DERBY-3783: Added utility method that wraps a Throwable in an IOException
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@678388 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/LOBInputStream.java",
"hunks": [
{
"added": [
" throw Util.newIOException(se);"
],
"header": "@@ -131,7 +131,7 @@ public class LOBInputStream extends InputStream {",
"removed": [
" ... |
derby-DERBY-3784-94d395e2 | DERBY-3784: ImportExportTest doesn't detect lack of expected errors
Added calls to fail() to ensure that the tests fail if the expected
exceptions are not thrown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@679027 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3786-0bcca1b9 | DERBY-3786: Assert failure in CacheEntry.unkeepForRemove when running stress.multi
Made sure GenericLanguageConnectionContext didn't call
CacheManager.remove() without the proper synchronization dictated by
CacheManager's javadoc.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@688027 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [],
"header": "@@ -29,7 +29,6 @@ import org.apache.derby.impl.sql.execute.InternalTriggerExecutionContext;",
"removed": [
"import org.apache.derby.iapi.... |
derby-DERBY-3788-c2b03c4c | DERBY-3788 and DERBY-269
Adding a new test case which will show that updating the statistics will make a query pickup better
index compare to prior to statistics availability
+ //
+ //Check statistics update causes most efficient index usage
+ //Create a table with 2 non-unique indexes on 2 different columns.
+ //The indexes are created when the table is still empty and hence
+ //there are no statistics available for them in sys.sysstatistics.
+ //The table looks as follows
+ // create table t2(c21 int, c22 char(14), c23 char(200))
+ // create index t2i1 on t2(c21)
+ // create index t2i2 on t2(c22)
+ //Load the data into the table and running following query will
+ //pickup index t2i1 on column c21
+ // select * from t2 where c21=? and c22=?
+ //But once you make the statistics available for t2i2, the query
+ //will pickup index t2i2 on column c22 for the query above
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681085 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/RuntimeStatisticsParser.java",
"hunks": [
{
"added": [
"",
" /**",
" * @param tableName",
" * @param indexName",
" * @return true if passed indexName was used for Index Scan R... |
derby-DERBY-3790-3574e108 | DERBY-3790: Investigate if request for update statistics can be skipped for certain kind of indexes, one instance may be unique indexes based on one column.
Minor test improvements: added/improved comments, skipped use of reduced row
count, removed unnecessary query execution.
Added a new method to wait for the old/current statistics to be replaced, and
then fetch the new statistics for the table.
Patch file: derby-3790-2a-minor_test_improvements.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1341830 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/IndexStatsUtil.java",
"hunks": [
{
"added": [
"import java.util.Arrays;",
"import java.util.HashSet;",
"import java.util.Set;"
],
"header": "@@ -28,9 +28,12 @@ import java.sql.SQLException;",
... |
derby-DERBY-3790-bce78c96 | DERBY-3790: Investigate if request for update statistics can be skipped for certain kind of indexes, one instance may be unique indexes based on one column.
Make update statistics code skip generation of statistics for single-column
unique indexes. This affects the istat daemon, the create index code, and the
SYSCS_UTIL.SYSCS_UPDATE_STATISTICS system procedure.
As a safe-guard a temporary debug property has been added to allow users to
revert to the old behavior in case the changes mess up their query plans.
Adjusted tests for the reduced number of statistics entries.
Added new tests for the debug property, for upgrade, and for behavior
verification.
Patch file: derby-3790-1c-skip_stats_scui.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1341481 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.IndexRowGenerator;"
],
"header": "@@ -45,6 +45,7 @@ import org.apache.derby.iapi.sql.conn.LanguageConnect... |
derby-DERBY-3791-c16a2d03 | DERBY-3791: Excessive memory usage when fetching small Clobs.
Exploits length information (where available) to reduce memory overhead wrt buffering. This improvement will only affect small Clobs in the range 1 byte to 8 KB, the smaller the Clob the bigger the overhead reduction.
Patch file: derby-3791-2a-buffer-adjustments.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681723 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/UTF8Reader.java",
"hunks": [
{
"added": [
" /** Maximum size in number of chars for the internal character buffer. */",
" private static final int MAXIMUM_BUFFER_SIZE = 8*1024; // 8 KB"
],
"header": "@@... |
derby-DERBY-3793-65e03868 | DERBY-3793: Remove unnecessary methods from InternalClob interface.
Removed InternalClob.getBytePosition.
Patch file: derby-3793-1a-remove_getBytePosition.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@678724 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-3793-e8fd6869 | DERBY-3793: Remove unnecessary methods from InternalClob interface.
Removed method InternalClob.getByteLength.
The method can be re-introduced later if beneficial, but due to lacking length information about Clobs it is a very costly operation with the current code and it is not really required (more of a convenience method).
Removed existing tests of the method, and added a new test to ensure the Derby specific end-of-stream marker isn't carried along.
Patch file: derby-3793-2b-remove_getByteLength.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@691608 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/InternalClob.java",
"hunks": [
{
"added": [],
"header": "@@ -39,15 +39,6 @@ import java.sql.SQLException;",
"removed": [
" /**",
" * Gets the number of bytes contained in the Clob.",
" *"... |
derby-DERBY-3799-51ef6db8 | DERBY-3799: NullPointerException when accessing a clob through a pooled connection.
Verify that the LOB stored procedure statements are open (not only non-null).
Patch file: derby-3799-1a-checkIfClosed.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681694 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/CallableLocatorProcedures.java",
"hunks": [
{
"added": [
" if (blobCreateLocatorCall == null ||",
" !blobCreateLocatorCall.openOnClient_) {"
],
"header": "@@ -113,7 +113,8 @@ cla... |
derby-DERBY-3803-9e91a063 | DERBY-3803 fix 'org.apache.derbyTesting.functionTests.tests.lang.XMLTypeAndOpsTest' failures after checkin for DERBY-3745
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681104 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/SingleThreadDaemonFactory.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.util.PrivilegedThreadOps;"
],
"header": "@@ -26,6 +26,7 @@ import org.apache.derby.iapi.services.daemon.DaemonFactory;",... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.