repo_name stringlengths 8 38 | pr_number int64 3 47.1k | pr_title stringlengths 8 175 | pr_description stringlengths 2 19.8k ⌀ | author null | date_created stringlengths 25 25 | date_merged stringlengths 25 25 | filepath stringlengths 6 136 | before_content stringlengths 54 884k ⌀ | after_content stringlengths 56 884k | pr_author stringlengths 3 21 | previous_commit stringlengths 40 40 | pr_commit stringlengths 40 40 | comment stringlengths 2 25.4k | comment_author stringlengths 3 29 | __index_level_0__ int64 0 5.1k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
posativ/isso | 845 | [client] Highlight linked comments to identify them | Fixes #838
TODO:
- [x] Figure out the best way to do styling
- [x] Docs
- [x] Tests (check that `.isso-target` gets applied properly) | null | 2022-04-24 00:32:28+00:00 | 2022-05-20 19:31:57+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 8d2f799ae3737ef6385bf0a740c8fee03d90601e | 1015aaa073607b4210a8ad8b35ebd83806578dfd | That animation name should be isso-namespaced | ix5 | 25 |
posativ/isso | 845 | [client] Highlight linked comments to identify them | Fixes #838
TODO:
- [x] Figure out the best way to do styling
- [x] Docs
- [x] Tests (check that `.isso-target` gets applied properly) | null | 2022-04-24 00:32:28+00:00 | 2022-05-20 19:31:57+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 8d2f799ae3737ef6385bf0a740c8fee03d90601e | 1015aaa073607b4210a8ad8b35ebd83806578dfd | This color (light yellow) is quite jarring on dark background. Try e.g. the demo with `body { background: black; color: white; }`
Also, maybe add a little code comment such as `Flash comment light yellow when focussed`, either here or in embed.js | ix5 | 26 |
posativ/isso | 845 | [client] Highlight linked comments to identify them | Fixes #838
TODO:
- [x] Figure out the best way to do styling
- [x] Docs
- [x] Tests (check that `.isso-target` gets applied properly) | null | 2022-04-24 00:32:28+00:00 | 2022-05-20 19:31:57+00:00 | isso/js/embed.js | /*
* Copyright 2014, Martin Zimmermann <info@posativ.org>. All rights reserved.
* Distributed under the MIT license
*/
var domready = require("app/lib/ready");
var config = require("app/config");
var i18n = require("app/i18n");
var api = require("app/api");
var isso = require("app/isso");
var count = require("app/c... | /*
* Copyright 2014, Martin Zimmermann <info@posativ.org>. All rights reserved.
* Distributed under the MIT license
*/
var domready = require("app/lib/ready");
var config = require("app/config");
var i18n = require("app/i18n");
var api = require("app/api");
var isso = require("app/isso");
var count = require("app/c... | BBaoVanC | 8d2f799ae3737ef6385bf0a740c8fee03d90601e | 1015aaa073607b4210a8ad8b35ebd83806578dfd | Wrap this in a try-catch block (ES5 has it, I think?) or check if `$(window.location.hash` actually returns an element. `fetchComments` (and `init`) is a function that definitely should not throw. | ix5 | 27 |
posativ/isso | 845 | [client] Highlight linked comments to identify them | Fixes #838
TODO:
- [x] Figure out the best way to do styling
- [x] Docs
- [x] Tests (check that `.isso-target` gets applied properly) | null | 2022-04-24 00:32:28+00:00 | 2022-05-20 19:31:57+00:00 | isso/js/embed.js | /*
* Copyright 2014, Martin Zimmermann <info@posativ.org>. All rights reserved.
* Distributed under the MIT license
*/
var domready = require("app/lib/ready");
var config = require("app/config");
var i18n = require("app/i18n");
var api = require("app/api");
var isso = require("app/isso");
var count = require("app/c... | /*
* Copyright 2014, Martin Zimmermann <info@posativ.org>. All rights reserved.
* Distributed under the MIT license
*/
var domready = require("app/lib/ready");
var config = require("app/config");
var i18n = require("app/i18n");
var api = require("app/api");
var isso = require("app/isso");
var count = require("app/c... | BBaoVanC | 8d2f799ae3737ef6385bf0a740c8fee03d90601e | 1015aaa073607b4210a8ad8b35ebd83806578dfd | Could you elaborate on what you meant by that code comment? | ix5 | 28 |
posativ/isso | 845 | [client] Highlight linked comments to identify them | Fixes #838
TODO:
- [x] Figure out the best way to do styling
- [x] Docs
- [x] Tests (check that `.isso-target` gets applied properly) | null | 2022-04-24 00:32:28+00:00 | 2022-05-20 19:31:57+00:00 | isso/js/embed.js | /*
* Copyright 2014, Martin Zimmermann <info@posativ.org>. All rights reserved.
* Distributed under the MIT license
*/
var domready = require("app/lib/ready");
var config = require("app/config");
var i18n = require("app/i18n");
var api = require("app/api");
var isso = require("app/isso");
var count = require("app/c... | /*
* Copyright 2014, Martin Zimmermann <info@posativ.org>. All rights reserved.
* Distributed under the MIT license
*/
var domready = require("app/lib/ready");
var config = require("app/config");
var i18n = require("app/i18n");
var api = require("app/api");
var isso = require("app/isso");
var count = require("app/c... | BBaoVanC | 8d2f799ae3737ef6385bf0a740c8fee03d90601e | 1015aaa073607b4210a8ad8b35ebd83806578dfd | Yep, can't believe I didn't catch this error when I was testing. (It happens if you click a comment for the first time, before another one was linked, meaning there is no .isso-target) | BBaoVanC | 29 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | CHANGES.rst | Changelog for Isso
==================
%(version)s (%(date)s)
- **BREAKING:** css, js: Prefix all classes with ``isso-`` (#816, ix5)
Now Isso's CSS is "namespaced" in order not to conflict with other classes on
the page.
This change necessitates adjusting custom CSS files to the new names.
- Drop support for out... | Changelog for Isso
==================
%(version)s (%(date)s)
- **BREAKING:** css, js: Prefix all classes with ``isso-`` (#816, ix5)
Now Isso's CSS is "namespaced" in order not to conflict with other classes on
the page.
This change necessitates adjusting custom CSS files to the new names.
- Drop support for out... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | `reST` requires double backticks (\`\`data-isso-...\`\`) around code instead of markdown's one. | ix5 | 30 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | docs/docs/reference/client-config.rst | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | Well done, very nicely documented!
Note to myself: The specifics of this should probably be moved into the "Tips & Tricks" section. I'll do that afterwards, not part of this PR.
Also, a script to derive the hashes should be added to contrib or as a CLI option that takes `salt` and other set options into account (... | ix5 | 31 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | docs/docs/reference/client-config.rst | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | Do I need to add that script or will you do it in another commit? And also is there anything else that needs to be modified in this PR? | BBaoVanC | 32 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | docs/docs/reference/client-config.rst | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | I'll add that script later. Apart from the missing `.isso-page-author-suffix` styles I mentioned inline, I think this should be good to go.
All in all, this PR is a good one - I know that having a proper user management would ofc be the better option, but within the restrictions of the current project status, this i... | ix5 | 33 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | docs/docs/reference/client-config.rst | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | The `.isso-page-author-suffix` style has been added in 63d2198ea2e7fe1c70fa44f3a240d832b4865abf. | BBaoVanC | 34 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | Please don't use `!important`, either make the selector more specific or fix the underlying issue. | ix5 | 35 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | How did you arrive at that specific color? Will it also look good on dark background? | ix5 | 36 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | I used a color picker to get roughly the same hue as the link color (on the reply button), and then I lightened and desaturated it.
As for it working on a dark background, it doesn't really fit. However, it looked to me that the rest of the CSS doesn't really plan for a dark background by default either. The backgro... | BBaoVanC | 37 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | To be honest, maybe don't include any style changes in this PR then and let users decide.
For instance, I'm using this and would have to tweak my CSS to override the default styling that this PR introduces:
The `(Author)` text should then be part of `isso/js/app/i18n/en... | ix5 | 39 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | > To be honest, maybe don't include any style changes in this PR then and let users decide.
>
> For instance, I'm using this and would have to tweak my CSS to override the default styling that this PR introduces: .
To gather screenshots, you can use the pre-packaged demo site. Run `isso -c share/isso-dev.cfg run` and visit `localhost:8080/demo`. Edit `isso/... | ix5 | 41 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | > I hope you're not waiting on feedback from my end.
>
> For now, let's leave out the background color changes (also, those might clash with the highlight-linked-comment PR?).
>
> To gather screenshots, you can use the pre-packaged demo site. Run `isso -c share/isso-dev.cfg run` and visit `localhost:8080/demo`. E... | BBaoVanC | 42 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | This commit is titled `css: isso.css: Implement styling for .isso-is-page-author` but it does not add any styling to `.isso-is-page-author`.
Here's what makes most sense: Style the `.isso-page-author-suffix` class:
```css
.isso-comment > .isso-text-wrapper > .isso-comment-header .isso-page-author-suffix {
fon... | ix5 | 43 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/css/isso.css | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | #isso-thread * {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}
#isso-thread .isso-comment-header a {
text-decoration: none;
}
#isso-thread {
padding: 0;
margin: 0;
}
#isso-thread > h4 {
color: #555;
font-weight: bold;
}
#isso-thread > .isso-feedl... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | Oops, that happened because I squashed the commit where I removed the explicit color styling into that one and didn't rename it. I updated it now | BBaoVanC | 44 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/config.js | var utils = require("app/utils");
"use strict";
var config = {
"css": true,
"css-url": null,
"lang": "",
"default-lang": "en",
"reply-to-self": false,
"require-email": false,
"require-author": false,
"reply-notifications": false,
"reply-notifications-default-enabled": false,
"m... | var utils = require("app/utils");
"use strict";
var config = {
"css": true,
"css-url": null,
"lang": "",
"default-lang": "en",
"reply-to-self": false,
"require-email": false,
"require-author": false,
"reply-notifications": false,
"reply-notifications-default-enabled": false,
"m... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | Please comment in the code what this does, it's not very obvious to JS beginners at first glance
`// Split "page-author-hash" by comma and spaces into array` | ix5 | 45 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/isso.js | /* Isso – Ich schrei sonst!
*/
var $ = require("app/dom");
var utils = require("app/utils");
var config = require("app/config");
var api = require("app/api");
var template = require("app/template");
var i18n = require("app/i18n");
var identicons = require("app/lib/identicons");
var globals = require("app/globals");
"u... | /* Isso – Ich schrei sonst!
*/
var $ = require("app/dom");
var utils = require("app/utils");
var config = require("app/config");
var api = require("app/api");
var template = require("app/template");
var i18n = require("app/i18n");
var identicons = require("app/lib/identicons");
var globals = require("app/globals");
"u... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | You might want to write a test case for this - template code and `isso.js` relying on DOM selectors such as `$('#isso-x')` has caused trouble before, e.g. https://github.com/posativ/isso/issues/524
See https://isso-comments.github.io/docs/technical-docs/testing-client/ (latest docs not uploaded to posativ.org yet) a... | ix5 | 46 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/isso.js | /* Isso – Ich schrei sonst!
*/
var $ = require("app/dom");
var utils = require("app/utils");
var config = require("app/config");
var api = require("app/api");
var template = require("app/template");
var i18n = require("app/i18n");
var identicons = require("app/lib/identicons");
var globals = require("app/globals");
"u... | /* Isso – Ich schrei sonst!
*/
var $ = require("app/dom");
var utils = require("app/utils");
var config = require("app/config");
var api = require("app/api");
var template = require("app/template");
var i18n = require("app/i18n");
var identicons = require("app/lib/identicons");
var globals = require("app/globals");
"u... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | I took a look at those docs and the other files, but I'm still not really sure what I should do to test it. It doesn't look like a similar scenario to the other tests. | BBaoVanC | 47 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/isso.js | /* Isso – Ich schrei sonst!
*/
var $ = require("app/dom");
var utils = require("app/utils");
var config = require("app/config");
var api = require("app/api");
var template = require("app/template");
var i18n = require("app/i18n");
var identicons = require("app/lib/identicons");
var globals = require("app/globals");
"u... | /* Isso – Ich schrei sonst!
*/
var $ = require("app/dom");
var utils = require("app/utils");
var config = require("app/config");
var api = require("app/api");
var template = require("app/template");
var i18n = require("app/i18n");
var identicons = require("app/lib/identicons");
var globals = require("app/globals");
"u... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | I'll write a test for it myself. | ix5 | 48 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/templates/comment.js | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
return "" +
"<div class='i... | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
var isPageAuthor = conf["pa... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | `isso-is-page-author` instead? (implying that it's kind of a boolean to CSS editors) | ix5 | 49 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/templates/comment.js | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
return "" +
"<div class='i... | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
var isPageAuthor = conf["pa... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | This is a string that must be translated. Add it to `i18n/en.js` (and - in a separate commit - to any other translation files of languages you speak)
~~Also, I think we might have a problem with right-to-left languages. With e.g. `Amir` + ` (Author)` in Arabic (`أمير` and `(مؤلف)`, this should be `أمير (مؤلف)`~~ Huh... | ix5 | 50 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/templates/comment.js | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
return "" +
"<div class='i... | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
var isPageAuthor = conf["pa... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | Also, the ` (Author)` part should have a different color (and be a separate `span` or whatever element). Otherwise, it wouldn't stick out
And everyone could just type in `BBao (Author)` into the comment box - you'd probably catch it when manually unlocking comments, but still annoying for people without moderation t... | ix5 | 51 |
posativ/isso | 844 | Make it possible to identify the page author's comments | Fixes #82
## TODO
- [x] Documentation
- [x] CHANGES.rst entry
- [x] Possibly remove the colors and instead explain how to change them in the docs
- [x] Screenshot using default Isso theme
## Summary of changes
- Page author's comments will have a different background
- Their name will have a different ... | null | 2022-04-24 00:11:06+00:00 | 2022-05-07 20:19:33+00:00 | isso/js/app/templates/comment.js | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
return "" +
"<div class='i... | var html = function (globals) {
var i18n = globals.i18n;
var comment = globals.comment;
var conf = globals.conf;
var datetime = globals.datetime;
var humanize = globals.humanize;
var svg = globals.svg;
var author = comment.author ? comment.author : i18n('comment-anonymous');
var isPageAuthor = conf["pa... | BBaoVanC | 05ba6023da7337340208c16e1108318195ceb5d4 | 0c8673561e2f8de129c5d82fba7e22de7d1a4043 | This is Farsi with a Farsi name ("Farid"-> "فرید"): `فرید•نویسنده•17 دقیقه پیش`
This is Farsi with a Latin-script name ("John"): `John•نویسنده•17 دقیقه پیش`
"Author" ("نویسنده") will confusingly be placed at the rightmost edge if the Author name is Latin-script. "نویسنده" highlighted in red for this scre... | ix5 | 52 |
posativ/isso | 832 | treewide: Support and test against Python 3.11 | null | null | 2022-03-28 08:22:33+00:00 | 2022-11-03 14:39:50+00:00 | CHANGES.rst | Changelog for Isso
==================
%(version)s (%(date)s)
----------------------
New Features
^^^^^^^^^^^^
- notifications: Implement 'List-Unsubscribe' header (`#906`_, ix5)
- css: Grey styling for comment code, code blocks (`#907`_, ix5)
.. _#906: https://github.com/posativ/isso/pull/906
.. _#907: https://gith... | Changelog for Isso
==================
%(version)s (%(date)s)
----------------------
New Features
^^^^^^^^^^^^
- notifications: Implement 'List-Unsubscribe' header (`#906`_, ix5)
- css: Grey styling for comment code, code blocks (`#907`_, ix5)
.. _#906: https://github.com/posativ/isso/pull/906
.. _#907: https://gith... | fliiiix | 7468a2cd28eb0bf55950d2ec545a9555e4e2ff93 | e1a629160dc8aed849d34c5478e6f54c4a789481 | Simply "Python 3.11 support" | ix5 | 53 |
posativ/isso | 828 | docs: update list of alternatives | The list was quiet outdated with abandoned projects, so i updated it.
Also added link to a great overview with all known open source comment servers.
The link is quiet long and breaks the 80 chars convention. How to handle that?
A different option for the heading would be "Alternatives". Let me know what you pre... | null | 2022-03-22 21:42:40+00:00 | 2022-03-23 16:54:08+00:00 | docs/docs/index.rst | Overview
========
Welcome to Isso's documentation. This documentation will help you get started
fast. If you run into any problems when using Isso, you can find the answer in
troubleshooting guide or you can ask me on IRC or GitHub.
Documentation overview:
.. toctree::
:maxdepth: 1
install
quickstart
tr... | Overview
========
Welcome to Isso's documentation. This documentation will help you get started
fast. If you run into any problems when using Isso, you can find the answer in
troubleshooting guide or you can ask me on IRC or GitHub.
Documentation overview:
.. toctree::
:maxdepth: 1
install
quickstart
tr... | davidak | 7ef6e054ae6b971770d67daaa8d08ee25911ef4d | 8c306f45a24b6996d2fcc44d6564a552021ed03d | While you're at it: It's `PostgreSQL` | ix5 | 54 |
posativ/isso | 828 | docs: update list of alternatives | The list was quiet outdated with abandoned projects, so i updated it.
Also added link to a great overview with all known open source comment servers.
The link is quiet long and breaks the 80 chars convention. How to handle that?
A different option for the heading would be "Alternatives". Let me know what you pre... | null | 2022-03-22 21:42:40+00:00 | 2022-03-23 16:54:08+00:00 | docs/docs/index.rst | Overview
========
Welcome to Isso's documentation. This documentation will help you get started
fast. If you run into any problems when using Isso, you can find the answer in
troubleshooting guide or you can ask me on IRC or GitHub.
Documentation overview:
.. toctree::
:maxdepth: 1
install
quickstart
tr... | Overview
========
Welcome to Isso's documentation. This documentation will help you get started
fast. If you run into any problems when using Isso, you can find the answer in
troubleshooting guide or you can ask me on IRC or GitHub.
Documentation overview:
.. toctree::
:maxdepth: 1
install
quickstart
tr... | davidak | 7ef6e054ae6b971770d67daaa8d08ee25911ef4d | 8c306f45a24b6996d2fcc44d6564a552021ed03d | Link title might say "lisakov.com: Open-source comments" or just "lisakov.com"
Also, don't worry about any line length limits here. | ix5 | 55 |
posativ/isso | 828 | docs: update list of alternatives | The list was quiet outdated with abandoned projects, so i updated it.
Also added link to a great overview with all known open source comment servers.
The link is quiet long and breaks the 80 chars convention. How to handle that?
A different option for the heading would be "Alternatives". Let me know what you pre... | null | 2022-03-22 21:42:40+00:00 | 2022-03-23 16:54:08+00:00 | docs/docs/index.rst | Overview
========
Welcome to Isso's documentation. This documentation will help you get started
fast. If you run into any problems when using Isso, you can find the answer in
troubleshooting guide or you can ask me on IRC or GitHub.
Documentation overview:
.. toctree::
:maxdepth: 1
install
quickstart
tr... | Overview
========
Welcome to Isso's documentation. This documentation will help you get started
fast. If you run into any problems when using Isso, you can find the answer in
troubleshooting guide or you can ask me on IRC or GitHub.
Documentation overview:
.. toctree::
:maxdepth: 1
install
quickstart
tr... | davidak | 7ef6e054ae6b971770d67daaa8d08ee25911ef4d | 8c306f45a24b6996d2fcc44d6564a552021ed03d | LiveFyre also doesn't seem to exist any more | ix5 | 56 |
posativ/isso | 821 | [client] js: Fetch public conf once from /config; embed.js: Preserve default config values | ### isso: js: embed.js: Preserve default config values
This way, Isso is not confusing users when a server config value overwrites a client default one, i.e. if the user has not actually attempted to overwrite it.
### isso: js, py: Fetch public conf once from /config
This is an improvement on top of: 02f3ea065... | null | 2022-03-20 22:02:58+00:00 | 2022-06-05 17:53:26+00:00 | isso/js/app/config.js | var utils = require("app/utils");
"use strict";
var config = {
"css": true,
"css-url": null,
"lang": null,
"default-lang": "en",
"reply-to-self": false,
"require-email": false,
"require-author": false,
"reply-notifications": false,
"reply-notifications-default-enabled": false,
... | var default_config = require("app/default_config");
var utils = require("app/utils");
"use strict";
// Preserve default values to filter out when comparing
// with values fetched from server
var config = {};
for (var key in default_config) {
config[key] = default_config[key];
}
var js = document.getElementsByTag... | ix5 | aaa8476fbc41400d3f70f23a1c68b22829b5ceac | 628246c82c6fb00024a7a8a523ee4b3ba622d76c | If anyone has a cleaner way to clone a dict-like objekt in JS, please let me know. | ix5 | 57 |
posativ/isso | 821 | [client] js: Fetch public conf once from /config; embed.js: Preserve default config values | ### isso: js: embed.js: Preserve default config values
This way, Isso is not confusing users when a server config value overwrites a client default one, i.e. if the user has not actually attempted to overwrite it.
### isso: js, py: Fetch public conf once from /config
This is an improvement on top of: 02f3ea065... | null | 2022-03-20 22:02:58+00:00 | 2022-06-05 17:53:26+00:00 | isso/js/app/config.js | var utils = require("app/utils");
"use strict";
var config = {
"css": true,
"css-url": null,
"lang": null,
"default-lang": "en",
"reply-to-self": false,
"require-email": false,
"require-author": false,
"reply-notifications": false,
"reply-notifications-default-enabled": false,
... | var default_config = require("app/default_config");
var utils = require("app/utils");
"use strict";
// Preserve default values to filter out when comparing
// with values fetched from server
var config = {};
for (var key in default_config) {
config[key] = default_config[key];
}
var js = document.getElementsByTag... | ix5 | aaa8476fbc41400d3f70f23a1c68b22829b5ceac | 628246c82c6fb00024a7a8a523ee4b3ba622d76c | What about this?
```js
var config = { ...default_config };
``` | Kerumen | 58 |
posativ/isso | 821 | [client] js: Fetch public conf once from /config; embed.js: Preserve default config values | ### isso: js: embed.js: Preserve default config values
This way, Isso is not confusing users when a server config value overwrites a client default one, i.e. if the user has not actually attempted to overwrite it.
### isso: js, py: Fetch public conf once from /config
This is an improvement on top of: 02f3ea065... | null | 2022-03-20 22:02:58+00:00 | 2022-06-05 17:53:26+00:00 | isso/js/app/config.js | var utils = require("app/utils");
"use strict";
var config = {
"css": true,
"css-url": null,
"lang": null,
"default-lang": "en",
"reply-to-self": false,
"require-email": false,
"require-author": false,
"reply-notifications": false,
"reply-notifications-default-enabled": false,
... | var default_config = require("app/default_config");
var utils = require("app/utils");
"use strict";
// Preserve default values to filter out when comparing
// with values fetched from server
var config = {};
for (var key in default_config) {
config[key] = default_config[key];
}
var js = document.getElementsByTag... | ix5 | aaa8476fbc41400d3f70f23a1c68b22829b5ceac | 628246c82c6fb00024a7a8a523ee4b3ba622d76c | Destructuring was on my "not-sure-we-can-do-that-without-throwing-old-browsers-under-the-bus"-list. But I've used that syntax for the template files already, so I might use it here as well.
Btw, I really appreciate the two of you, @Kerumen and @adroste, weighing in on these issues. It's a lot of work to wrangle all ... | ix5 | 59 |
posativ/isso | 808 | setup.py: drop python3.5 support | Since not tests are run for 3.5 drop support
with the next release.
Also Python 3.5 has reached end-of-life on 5-Sep-2020.
Python 3.5.10 is the final release of 3.5.
https://www.python.org/downloads/release/python-3510/ | null | 2022-03-06 14:09:53+00:00 | 2022-03-27 21:45:09+00:00 | CHANGES.rst | Changelog for Isso
==================
%(version)s (%(date)s)
0.12.6 (2022-03-06)
-------------------
- Serve isso.css separately to avoid ``style-src: unsafe-inline`` CSP and allow
clients to override fetch location (#704, ix5):
data-isso-css-url="https://comments.example.org/css/isso.css"
- New "samesite" op... | Changelog for Isso
==================
%(version)s (%(date)s)
- Drop support for outdated Python version 3.5
(#808, l33tname)
0.12.6 (2022-03-06)
-------------------
- Serve isso.css separately to avoid ``style-src: unsafe-inline`` CSP and allow
clients to override fetch location (#704, ix5):
data-isso-css-u... | fliiiix | 8c306f45a24b6996d2fcc44d6564a552021ed03d | 79a774699cfb994b5098428bad154699e2d361cf | outdated | ix5 | 60 |
posativ/isso | 808 | setup.py: drop python3.5 support | Since not tests are run for 3.5 drop support
with the next release.
Also Python 3.5 has reached end-of-life on 5-Sep-2020.
Python 3.5.10 is the final release of 3.5.
https://www.python.org/downloads/release/python-3510/ | null | 2022-03-06 14:09:53+00:00 | 2022-03-27 21:45:09+00:00 | CHANGES.rst | Changelog for Isso
==================
%(version)s (%(date)s)
0.12.6 (2022-03-06)
-------------------
- Serve isso.css separately to avoid ``style-src: unsafe-inline`` CSP and allow
clients to override fetch location (#704, ix5):
data-isso-css-url="https://comments.example.org/css/isso.css"
- New "samesite" op... | Changelog for Isso
==================
%(version)s (%(date)s)
- Drop support for outdated Python version 3.5
(#808, l33tname)
0.12.6 (2022-03-06)
-------------------
- Serve isso.css separately to avoid ``style-src: unsafe-inline`` CSP and allow
clients to override fetch location (#704, ix5):
data-isso-css-u... | fliiiix | 8c306f45a24b6996d2fcc44d6564a552021ed03d | 79a774699cfb994b5098428bad154699e2d361cf | done | fliiiix | 61 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | `rv_activate_get` | ix5 | 62 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | Any reason for duplicating this test? | ix5 | 63 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | Maybe use `uri=/moderated` (with slash) so that later on, the assert with `invalid.local/moderated` instead of `invalid.localmoderated` is not as confusing | ix5 | 64 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | handled | ix5 | 65 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | Using `id_` instead of my usage of private `_id` is much smarter, good catch! | ix5 | 66 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | Incomplete, same for `rv_incomplete_key` | ix5 | 67 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | its also what PEP8 tells you to do ;) | fliiiix | 68 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/tests/test_comments.py | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | # -*- encoding: utf-8 -*-
import json
import os
import pkg_resources
import re
import tempfile
import unittest
from urllib.parse import urlencode
from werkzeug.wrappers import Response
from isso import Isso, core, config, dist
from isso.utils import http
from isso.views import comments
from fixtures import curl, l... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | nope this is a rebase mistake i overlooked | fliiiix | 69 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | "Comment deleted" / "Comment has been deleted" ? | ix5 | 70 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | "Comment activated" / "Comment has been activated" ? | ix5 | 71 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | dito | ix5 | 72 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | Maybe mention here that the key is also base64-encoded.
The stray `['unsubscribe', email]` here is also a bit confusing.
Maybe put it on a new line with "Expected syntax" or something. | ix5 | 73 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | Pushed to your branch with my suggested change. I've left the base64 encoding part out because there's also a signature attached, which would just be confusing. | ix5 | 74 |
posativ/isso | 805 | views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications | Things this PR addresses:
* Replace Yo response from moderation with a more appropriate response
* Add tests for moderation
* Add tests for unsubscribe and fix doc string
Contributes to #755 | null | 2022-02-26 15:47:59+00:00 | 2022-03-05 18:11:46+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | # -*- encoding: utf-8 -*-
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from configparser import NoOptionError
from datetime import datetime, timedelta
from html import escape
from io import BytesIO as StringIO
from urllib.parse import unquote, urlparse
fro... | fliiiix | ae6dc847d9bc460fa6edc97159db8adc57590eea | 8bf84595492002acad3622cb8ed8c161430cb605 | thanks :+1: | fliiiix | 75 |
posativ/isso | 802 | setup.py, README: Generate proper Project Description for PyPi | ### setup.py: Include README in pypi upload
This allows for more information by embedding the README at https://pypi.org/project/isso/ as a "Project Description".
### README: ~~Point LICENSE to current GH master,~~ shuffle sections a bit
~~Reasoning: Use absolute link to allow embedding the rendered README on ... | null | 2022-02-23 21:38:43+00:00 | 2022-02-26 21:08:05+00:00 | README.md | # Isso – a commenting server similar to Disqus
Isso – *Ich schrei sonst* – is a lightweight commenting server written in
Python and JavaScript. It aims to be a drop-in replacement for
[Disqus](http://disqus.com).
See [posativ.org/isso](http://posativ.org/iss... | # Isso – a commenting server similar to Disqus
Isso – *Ich schrei sonst* – is a lightweight commenting server written in
Python and JavaScript. It aims to be a drop-in replacement for
[Disqus](http://disqus.com).
See **[posativ.org/isso](http://posativ.org/isso/)** for more details and
documentation.
.
See [posativ.org/isso](http://posativ.org/iss... | # Isso – a commenting server similar to Disqus
Isso – *Ich schrei sonst* – is a lightweight commenting server written in
Python and JavaScript. It aims to be a drop-in replacement for
[Disqus](http://disqus.com).
See **[posativ.org/isso](http://posativ.org/isso/)** for more details and
documentation.
![Isso in Actio... | ix5 | 74326fbe6ab6ea4d91ab9d9d6aa47de119883d25 | ae6dc847d9bc460fa6edc97159db8adc57590eea | You cannot link to package resources inside PyPi, even if you include them in `MANIFEST.in`.
(I tested via https://test.pypi.org/project/isso-testpypi/ and the link goes to a 404, as you'd expect: https://test.pypi.org/project/isso-testpypi/LICENSE ) | ix5 | 77 |
posativ/isso | 801 | js: Add Jest testing | As discussed in https://github.com/posativ/isso/issues/754, add some basic Jest testing config and examples to facilitate finally writing some frontend code tests.
---
**Note:** End-to-end tests using `puppeteer` were split off and moved into https://github.com/posativ/isso/pull/807
---
### Terminology
- *... | null | 2022-02-19 16:54:25+00:00 | 2022-03-21 20:42:10+00:00 | package.json | {
"name": "isso",
"author": "Martin Zimmermann",
"description": "lightweight Disquis alternative",
"license": "MIT",
"repository": "github:posativ/isso",
"dependencies": {},
"scripts": {
"build-dev": "webpack --config isso/js/webpack.config.js --config-name dev",
"watch-dev": "webpack --config iss... | {
"name": "isso",
"author": "Martin Zimmermann",
"description": "lightweight Disquis alternative",
"license": "MIT",
"repository": "github:posativ/isso",
"dependencies": {},
"scripts": {
"test": "jest --config isso/js/jest.config.js isso/js/tests/" ,
"test-unit": "jest --config isso/js/jest.config... | ix5 | 3c7ac68a4e0d320832fab068dfb7c1812363b182 | 7a1ae20cb0e94164df49ac19388c6b4163dea054 | "jest-puppeteer" is missing ;) | Lucas-C | 78 |
posativ/isso | 801 | js: Add Jest testing | As discussed in https://github.com/posativ/isso/issues/754, add some basic Jest testing config and examples to facilitate finally writing some frontend code tests.
---
**Note:** End-to-end tests using `puppeteer` were split off and moved into https://github.com/posativ/isso/pull/807
---
### Terminology
- *... | null | 2022-02-19 16:54:25+00:00 | 2022-03-21 20:42:10+00:00 | package.json | {
"name": "isso",
"author": "Martin Zimmermann",
"description": "lightweight Disquis alternative",
"license": "MIT",
"repository": "github:posativ/isso",
"dependencies": {},
"scripts": {
"build-dev": "webpack --config isso/js/webpack.config.js --config-name dev",
"watch-dev": "webpack --config iss... | {
"name": "isso",
"author": "Martin Zimmermann",
"description": "lightweight Disquis alternative",
"license": "MIT",
"repository": "github:posativ/isso",
"dependencies": {},
"scripts": {
"test": "jest --config isso/js/jest.config.js isso/js/tests/" ,
"test-unit": "jest --config isso/js/jest.config... | ix5 | 3c7ac68a4e0d320832fab068dfb7c1812363b182 | 7a1ae20cb0e94164df49ac19388c6b4163dea054 | Adding `jest-puppeteer` to `devDependencies` will automatically pull in a 400Mb+ download of headless chrome, as explained earlier. That's why I'm a bit hesitant to add it here.
Imo it should be up to the user whether they need to run the end-to-end tests.
Maybe there's an option to configure the package _before_... | ix5 | 79 |
posativ/isso | 800 | [MAJOR] js: Move to webpack, pug from r.js, jade | # Introduction
As already discussed in https://github.com/posativ/isso/issues/754, try to make Isso more maintainable by facilitating modern testing practices.
This PR is a bit massive, but trying to make `pug` or other updated deps play nice with RequireJs just for the sake of a clean history is not something I'... | null | 2022-02-19 16:30:50+00:00 | 2022-03-20 20:12:35+00:00 | isso/js/app/lib/identicons.js | /*
Copyright (C) 2013 Gregory Schier <gschier1990@gmail.com>
Copyright (C) 2013 Martin Zimmermann <info@posativ.org>
Inspired by http://codepen.io/gschier/pen/GLvAy
*/
define(["app/lib/promise", "app/config"], function(Q, config) {
"use strict";
// Number of squares width and height
var GRID = 5;
... | /*
Copyright (C) 2013 Gregory Schier <gschier1990@gmail.com>
Copyright (C) 2013 Martin Zimmermann <info@posativ.org>
Inspired by http://codepen.io/gschier/pen/GLvAy
*/
const Q = require("app/lib/promise");
"use strict";
// Number of squares width and height
var GRID = 5;
var pad = function(n, width) {
ret... | ix5 | 4d7a05f22b4dd3fb870eaab52681ff744701ecc7 | 55282737fc991f6a249b77e63c327af4d22fa3d4 | `config` should probably be passed to this function on line 85 of this file | Lucas-C | 80 |
posativ/isso | 800 | [MAJOR] js: Move to webpack, pug from r.js, jade | # Introduction
As already discussed in https://github.com/posativ/isso/issues/754, try to make Isso more maintainable by facilitating modern testing practices.
This PR is a bit massive, but trying to make `pug` or other updated deps play nice with RequireJs just for the sake of a clean history is not something I'... | null | 2022-02-19 16:30:50+00:00 | 2022-03-20 20:12:35+00:00 | isso/js/app/lib/identicons.js | /*
Copyright (C) 2013 Gregory Schier <gschier1990@gmail.com>
Copyright (C) 2013 Martin Zimmermann <info@posativ.org>
Inspired by http://codepen.io/gschier/pen/GLvAy
*/
define(["app/lib/promise", "app/config"], function(Q, config) {
"use strict";
// Number of squares width and height
var GRID = 5;
... | /*
Copyright (C) 2013 Gregory Schier <gschier1990@gmail.com>
Copyright (C) 2013 Martin Zimmermann <info@posativ.org>
Inspired by http://codepen.io/gschier/pen/GLvAy
*/
const Q = require("app/lib/promise");
"use strict";
// Number of squares width and height
var GRID = 5;
var pad = function(n, width) {
ret... | ix5 | 4d7a05f22b4dd3fb870eaab52681ff744701ecc7 | 55282737fc991f6a249b77e63c327af4d22fa3d4 | In this particular instance you are right, but looking over this code again, it occurred to me that Isso currently doesn't use the `blank`/`generateBlank` functions at all.
I'll adjust this commit to let `generateBlank` use a passed `config` for the sake of keeping current functionality. | ix5 | 81 |
posativ/isso | 800 | [MAJOR] js: Move to webpack, pug from r.js, jade | # Introduction
As already discussed in https://github.com/posativ/isso/issues/754, try to make Isso more maintainable by facilitating modern testing practices.
This PR is a bit massive, but trying to make `pug` or other updated deps play nice with RequireJs just for the sake of a clean history is not something I'... | null | 2022-02-19 16:30:50+00:00 | 2022-03-20 20:12:35+00:00 | isso/js/app/lib/identicons.js | /*
Copyright (C) 2013 Gregory Schier <gschier1990@gmail.com>
Copyright (C) 2013 Martin Zimmermann <info@posativ.org>
Inspired by http://codepen.io/gschier/pen/GLvAy
*/
define(["app/lib/promise", "app/config"], function(Q, config) {
"use strict";
// Number of squares width and height
var GRID = 5;
... | /*
Copyright (C) 2013 Gregory Schier <gschier1990@gmail.com>
Copyright (C) 2013 Martin Zimmermann <info@posativ.org>
Inspired by http://codepen.io/gschier/pen/GLvAy
*/
const Q = require("app/lib/promise");
"use strict";
// Number of squares width and height
var GRID = 5;
var pad = function(n, width) {
ret... | ix5 | 4d7a05f22b4dd3fb870eaab52681ff744701ecc7 | 55282737fc991f6a249b77e63c327af4d22fa3d4 | Done | ix5 | 82 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | Note that I moved the `allow_no_value` arg into the `__init__` function to make it easier to keep things in sync. Otherwise you'd have to adjust the tests as well every time `IssoParser` needs new args. | ix5 | 83 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | Not a fan of this since it's not strictly needed any actually disallows passwords starting or ending with these characters (in addition to whitespace that may actually be gobbled up by the ini parser) | stefangehn | 84 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | strip can be passed multiple chars to strip off a string, no need to call it twice | stefangehn | 85 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | +1 | jelmer | 86 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | Why do we need to strip these? It seems like it would make it impossible to actually use these characters at the beginning and end of strings. | jelmer | 87 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | Alright, thank you for your input! Adjusted accordingly. | ix5 | 88 |
posativ/isso | 764 | config: Disable interpolation of values | Do not attempt to use python string interpolation on values.
This is especially important for parsing passwords that might contain '%'
<strike>Strip single and double quotes from values. This might help with people who try to supply their admin password surrounded in quotes.</strike> (Edit: removed)
See: https:/... | null | 2022-01-27 12:50:11+00:00 | 2022-02-01 10:32:02+00:00 | isso/config.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import re
import logging
import datetime
from email.utils import parseaddr, formataddr
from configparser import ConfigParser, NoOptionError, NoSectionError, DuplicateSectionError
logger = logging.getLogger("isso")
def timedelta(string):
"""
... | ix5 | abe0a9a511c05ca6d3fa3ef1c499fd98085f30e9 | 7d47825a2a13830c75bff77ed74f992d1030df71 | See above. | ix5 | 89 |
posativ/isso | 704 | Serve isso.css separately instead of inline | Instead of embedding isso.css inside the client javascript (which required an `style-src: unsafe-inline` CSP), fetch isso.css from `api.endpoint+"/css/isso.css"`.
Allow clients to override fetch location using `data-isso-css-url="https://comments.example.org/css/isso.css"`
Note: No modification needed for packagi... | null | 2021-02-07 10:00:36+00:00 | 2021-03-22 22:29:43+00:00 | docs/docs/configuration/client.rst | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-lang="r... | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | ix5 | c73694959a2beea27debb2c4001e9a593d58f270 | a7c1069cf5feab721a166e7796ce725287a46189 | I guess this block was put at the wrong place. The text above this heading is for the attribute data-isso-css-url. Mind to move it below? | MorrisJobke | 90 |
posativ/isso | 704 | Serve isso.css separately instead of inline | Instead of embedding isso.css inside the client javascript (which required an `style-src: unsafe-inline` CSP), fetch isso.css from `api.endpoint+"/css/isso.css"`.
Allow clients to override fetch location using `data-isso-css-url="https://comments.example.org/css/isso.css"`
Note: No modification needed for packagi... | null | 2021-02-07 10:00:36+00:00 | 2021-03-22 22:29:43+00:00 | docs/docs/configuration/client.rst | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-lang="r... | Client Configuration
====================
You can configure the client (the JS part) with custom data attributes,
preferably in the script tag which embeds the JS:
.. code-block:: html
<script data-isso="/prefix/"
data-isso-id="thread-id"
data-isso-css="true"
data-isso-css-url... | ix5 | c73694959a2beea27debb2c4001e9a593d58f270 | a7c1069cf5feab721a166e7796ce725287a46189 | Thanks for catching this! Fixed. | ix5 | 91 |
posativ/isso | 703 | docs: install: Reorder Install from source, py3.5 | Reorder steps so that js files are generated before `python setup.py develop`.
Clarify that isso should be installed in editable mode when installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.
Isso requires python 3.5 now. | null | 2021-02-05 09:16:57+00:00 | 2021-12-24 01:58:20+00:00 | docs/docs/install.rst | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | ix5 | fb6f731f6bcbb871f5b3632843a09d2ed501a596 | 28beb7e848db5ce0e89f8a63e929ecaca4dcf529 | I don't follow this; this does include generated files (including locally changed ones), and I use it regularly. | jelmer | 92 |
posativ/isso | 703 | docs: install: Reorder Install from source, py3.5 | Reorder steps so that js files are generated before `python setup.py develop`.
Clarify that isso should be installed in editable mode when installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.
Isso requires python 3.5 now. | null | 2021-02-05 09:16:57+00:00 | 2021-12-24 01:58:20+00:00 | docs/docs/install.rst | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | ix5 | fb6f731f6bcbb871f5b3632843a09d2ed501a596 | 28beb7e848db5ce0e89f8a63e929ecaca4dcf529 | Unfortunate wording on my part.
If isso is installed using `python setup.py install`, the isso artifact files will be copied to `<venv>/lib/python3.9/site-packages/isso-0.12.4-py3.9.egg/isso/`, but any changes you make from now on will not be carried over to the site-packages isso, unless you run the install command a... | ix5 | 93 |
posativ/isso | 703 | docs: install: Reorder Install from source, py3.5 | Reorder steps so that js files are generated before `python setup.py develop`.
Clarify that isso should be installed in editable mode when installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.
Isso requires python 3.5 now. | null | 2021-02-05 09:16:57+00:00 | 2021-12-24 01:58:20+00:00 | docs/docs/install.rst | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | ix5 | fb6f731f6bcbb871f5b3632843a09d2ed501a596 | 28beb7e848db5ce0e89f8a63e929ecaca4dcf529 | I think this is quite subjective - I don't use venv, and "python install" is how I deploy isso. Perhaps just drop this note altogether? Alternative, just add a caution here about "setup.py install" and venv. | jelmer | 94 |
posativ/isso | 703 | docs: install: Reorder Install from source, py3.5 | Reorder steps so that js files are generated before `python setup.py develop`.
Clarify that isso should be installed in editable mode when installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.
Isso requires python 3.5 now. | null | 2021-02-05 09:16:57+00:00 | 2021-12-24 01:58:20+00:00 | docs/docs/install.rst | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | ix5 | fb6f731f6bcbb871f5b3632843a09d2ed501a596 | 28beb7e848db5ce0e89f8a63e929ecaca4dcf529 | I agree that using `pip install -e .` is handy during development since you do not need to install the package again after every change. Since this part of the documentation is about installing from source I think both installation variants are fine and it depends on the use case which one to choose.
So all in all I... | stefangehn | 95 |
posativ/isso | 703 | docs: install: Reorder Install from source, py3.5 | Reorder steps so that js files are generated before `python setup.py develop`.
Clarify that isso should be installed in editable mode when installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.
Isso requires python 3.5 now. | null | 2021-02-05 09:16:57+00:00 | 2021-12-24 01:58:20+00:00 | docs/docs/install.rst | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | Installation
============
Isso is a web application written in Python. If pip and virtualenv mean anything
to you, continue with :ref:`install-from-pypi`. If you are running
Debian/Ubuntu, Gentoo, Archlinux or Fedora, you can use
:ref:`prebuilt-package`. If not, read the next section carefully.
.. contents::
:loc... | ix5 | fb6f731f6bcbb871f5b3632843a09d2ed501a596 | 28beb7e848db5ce0e89f8a63e929ecaca4dcf529 | Line dropped | ix5 | 96 |
posativ/isso | 697 | Build JavaScript files during python package build | Make package builds via setuptools automatically trigger building of
merged & minified JS assets.
This fixes installing isso from source when using `pip install` as long
as both the python and node requirements are met. It also ensures that
`setup.py` commands like `build` or `bdist_wheel` create archives that
c... | null | 2021-02-03 18:30:50+00:00 | 2022-01-04 19:29:06+00:00 | setup.py | #!/usr/bin/env python3
# -*- encoding: utf-8 -*-
from setuptools import setup, find_packages
requires = ['itsdangerous', 'Jinja2', 'misaka>=2.0,<3.0', 'html5lib',
'werkzeug>=1.0', 'bleach', 'Flask-Caching>=1.9', 'Flask']
setup(
name='isso',
version='0.12.5',
author='Martin Zimmermann',
au... | #!/usr/bin/env python3
# -*- encoding: utf-8 -*-
import os
import setuptools.command.build_py
import subprocess
from setuptools import setup, find_packages
requires = ['itsdangerous', 'Jinja2', 'misaka>=2.0,<3.0', 'html5lib',
'werkzeug>=1.0', 'bleach', 'Flask-Caching>=1.9', 'Flask']
class NpmBuildComma... | stefangehn | e6dbd21819f8fdca9fdace447e9ba01276e8d6a9 | bbad14e8e1384d49cd274f573cfe8ea121fef532 | check_call() ? | jelmer | 97 |
posativ/isso | 697 | Build JavaScript files during python package build | Make package builds via setuptools automatically trigger building of
merged & minified JS assets.
This fixes installing isso from source when using `pip install` as long
as both the python and node requirements are met. It also ensures that
`setup.py` commands like `build` or `bdist_wheel` create archives that
c... | null | 2021-02-03 18:30:50+00:00 | 2022-01-04 19:29:06+00:00 | setup.py | #!/usr/bin/env python3
# -*- encoding: utf-8 -*-
from setuptools import setup, find_packages
requires = ['itsdangerous', 'Jinja2', 'misaka>=2.0,<3.0', 'html5lib',
'werkzeug>=1.0', 'bleach', 'Flask-Caching>=1.9', 'Flask']
setup(
name='isso',
version='0.12.5',
author='Martin Zimmermann',
au... | #!/usr/bin/env python3
# -*- encoding: utf-8 -*-
import os
import setuptools.command.build_py
import subprocess
from setuptools import setup, find_packages
requires = ['itsdangerous', 'Jinja2', 'misaka>=2.0,<3.0', 'html5lib',
'werkzeug>=1.0', 'bleach', 'Flask-Caching>=1.9', 'Flask']
class NpmBuildComma... | stefangehn | e6dbd21819f8fdca9fdace447e9ba01276e8d6a9 | bbad14e8e1384d49cd274f573cfe8ea121fef532 | Indeed. Although `subprocess.run(..., check=True)` does the same I find `subprocess.check_call()` to be a bit more obvious and in fact know it from Python 2.7 already. | stefangehn | 98 |
posativ/isso | 686 | utils: html: Normalize misaka extensions | As of version 0.12.2, Isso uses misaka 2.0 to render markdown. Misaka 2.0 uses `dashed-case` instead of `snake_case` for options.
Normalize passed extensions to dashed-case to avoid mistakes.
Note: Flags have only been around in Isso with misaka 2.0, so I hope users did not use dashed case with them. | null | 2021-01-17 19:07:06+00:00 | 2022-01-05 20:17:38+00:00 | isso/utils/html.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import html
import bleach
import misaka
from configparser import NoOptionError
class Sanitizer(object):
def __init__(self, elements, attributes):
# attributes found in Sundown's HTML serializer [1]
# except for <img> tag,
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import html
import bleach
import misaka
from configparser import NoOptionError
class Sanitizer(object):
def __init__(self, elements, attributes):
# attributes found in Sundown's HTML serializer [1]
# except for <img> tag,
... | ix5 | bbad14e8e1384d49cd274f573cfe8ea121fef532 | 86fbf37f3cf8c6c19b086976afa35ca65c092a29 | List comprehension would be prettier I guess? | ix5 | 99 |
posativ/isso | 686 | utils: html: Normalize misaka extensions | As of version 0.12.2, Isso uses misaka 2.0 to render markdown. Misaka 2.0 uses `dashed-case` instead of `snake_case` for options.
Normalize passed extensions to dashed-case to avoid mistakes.
Note: Flags have only been around in Isso with misaka 2.0, so I hope users did not use dashed case with them. | null | 2021-01-17 19:07:06+00:00 | 2022-01-05 20:17:38+00:00 | isso/utils/html.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import html
import bleach
import misaka
from configparser import NoOptionError
class Sanitizer(object):
def __init__(self, elements, attributes):
# attributes found in Sundown's HTML serializer [1]
# except for <img> tag,
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import html
import bleach
import misaka
from configparser import NoOptionError
class Sanitizer(object):
def __init__(self, elements, attributes):
# attributes found in Sundown's HTML serializer [1]
# except for <img> tag,
... | ix5 | bbad14e8e1384d49cd274f573cfe8ea121fef532 | 86fbf37f3cf8c6c19b086976afa35ca65c092a29 | Yes, definitely:
```python
extensions = [x.replace("_", "-") for x in extensions]
``` | vincentbernat | 100 |
posativ/isso | 686 | utils: html: Normalize misaka extensions | As of version 0.12.2, Isso uses misaka 2.0 to render markdown. Misaka 2.0 uses `dashed-case` instead of `snake_case` for options.
Normalize passed extensions to dashed-case to avoid mistakes.
Note: Flags have only been around in Isso with misaka 2.0, so I hope users did not use dashed case with them. | null | 2021-01-17 19:07:06+00:00 | 2022-01-05 20:17:38+00:00 | isso/utils/html.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import html
import bleach
import misaka
from configparser import NoOptionError
class Sanitizer(object):
def __init__(self, elements, attributes):
# attributes found in Sundown's HTML serializer [1]
# except for <img> tag,
... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
import html
import bleach
import misaka
from configparser import NoOptionError
class Sanitizer(object):
def __init__(self, elements, attributes):
# attributes found in Sundown's HTML serializer [1]
# except for <img> tag,
... | ix5 | bbad14e8e1384d49cd274f573cfe8ea121fef532 | 86fbf37f3cf8c6c19b086976afa35ca65c092a29 | Yup. | ix5 | 101 |
posativ/isso | 685 | share: isso.conf: Use dashed-case for misaka 2.0 | Misaka expects extensions and flags in `dashed-case` instead of the legacy `snake_case` as of version 2.0.
See https://github.com/FSX/misaka/blob/v2.1.1/misaka/utils.py#L15-L37
Also align "options" values with the defaults in `utils/html.py`. | null | 2021-01-17 19:01:05+00:00 | 2021-02-07 20:50:27+00:00 | share/isso.conf | # Isso configuration file
# vim: set filetype=ini
[general]
# file location to the SQLite3 database, highly recommended to change this
# location to a non-temporary location!
dbpath = /tmp/comments.db
# required to dispatch multiple websites, not used otherwise.
name =
# Your website(s). If Isso is unable to connec... | # Isso configuration file
# vim: set filetype=ini
[general]
# file location to the SQLite3 database, highly recommended to change this
# location to a non-temporary location!
dbpath = /tmp/comments.db
# required to dispatch multiple websites, not used otherwise.
name =
# Your website(s). If Isso is unable to connec... | ix5 | 08703d03ace7089f157fbdf5d560209c66d713e1 | 72e624bf6aeaeffa03a26f7d258561269ae54eec | We've been on misaka 2.0 since 1.5, do we really need to mention misaka 1.0? | jelmer | 102 |
posativ/isso | 685 | share: isso.conf: Use dashed-case for misaka 2.0 | Misaka expects extensions and flags in `dashed-case` instead of the legacy `snake_case` as of version 2.0.
See https://github.com/FSX/misaka/blob/v2.1.1/misaka/utils.py#L15-L37
Also align "options" values with the defaults in `utils/html.py`. | null | 2021-01-17 19:01:05+00:00 | 2021-02-07 20:50:27+00:00 | share/isso.conf | # Isso configuration file
# vim: set filetype=ini
[general]
# file location to the SQLite3 database, highly recommended to change this
# location to a non-temporary location!
dbpath = /tmp/comments.db
# required to dispatch multiple websites, not used otherwise.
name =
# Your website(s). If Isso is unable to connec... | # Isso configuration file
# vim: set filetype=ini
[general]
# file location to the SQLite3 database, highly recommended to change this
# location to a non-temporary location!
dbpath = /tmp/comments.db
# required to dispatch multiple websites, not used otherwise.
name =
# Your website(s). If Isso is unable to connec... | ix5 | 08703d03ace7089f157fbdf5d560209c66d713e1 | 72e624bf6aeaeffa03a26f7d258561269ae54eec | I was directing that comment towards people upgrading from older versions. | ix5 | 103 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | Maybe change the `apiExample` to
`curl 'https://comments.example.com/id/4' --cokie '4=<cookie>'` | ix5 | 104 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | Begone! | ix5 | 105 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | There's quite a few functions with that inconsistent spacing. Also *technically* the docstrings should be inside the functions, not outside of them. Fixing that feels a bit out-of-scope for this change. Maybe in the future there should be a docstring normalization pass. | fluffy-critter | 106 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | (That said, I'll remove that accidentally-introduced newline. No idea how that got in there!) | fluffy-critter | 107 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | Used `-b cookie.txt` to keep it in line with the other `@apiExample` annotations | fluffy-critter | 108 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | Yeah - I think there's value in fixing some of the formatting, but mixing those changes in with other changes just makes everything harder to review. | jelmer | 109 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | A thing I’ve found to be helpful is to make autopep8 part of the build process so that there’s never an opportunity for things to drift in the first place. | fluffy-critter | 110 |
posativ/isso | 683 | Require an edit cookie to be able to view a comment to be edited. | The `/id` GET endpoint is only used to retrieve the raw text of a comment to be edited. Being able to arbitrarily retrieve *any* comment through this endpoint is a potential privacy issue, since it allows a malicious actor to individually retrieve all comments from a website without knowledge of an existing thread URI.... | null | 2021-01-15 22:32:12+00:00 | 2021-12-22 20:37:30+00:00 | isso/views/comments.py | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | # -*- encoding: utf-8 -*-
from __future__ import unicode_literals
from configparser import NoOptionError
import collections
import re
import time
import functools
import json # json.dumps to put URL in <script>
from datetime import datetime, timedelta
from itsdangerous import SignatureExpired, BadSignature
from xml... | fluffy-critter | 57aa12699a1338820c9ec34ebbae01d687d69c9f | 5f3bf4fb8e481e09259e8fdf53995fca3461ad59 | Sure, but that should also be a separate PR :) | jelmer | 111 |
ceph/ceph-ansible | 7,380 | Collocated mgr with mon fails to start on RHEL 8.7 | With podman version podman-3:4.2.0-4.module+el8.7.0+17064+3b31f55c and later, when mgr fails to start if mon is already running. This is a workaround until podman is fixed.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2169767
Closes: #7365
Signed-off-by: Teoman ONAY <tonay@ibm.com> | null | 2023-02-07 13:58:10+00:00 | 2023-02-19 00:03:04+00:00 | roles/ceph-nfs/templates/ceph-nfs.service.j2 | [Unit]
Description=NFS-Ganesha file server
Documentation=http://github.com/nfs-ganesha/nfs-ganesha/wiki
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% end... | [Unit]
Description=NFS-Ganesha file server
Documentation=http://github.com/nfs-ganesha/nfs-ganesha/wiki
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% end... | asm0deuz | e47288ef6c23820c4fa50835574169233cd06b12 | 637ca81c9cf801e4d1d125dc8a2492b90fd78eea | ```suggestion
-v /var/lib/ceph/bootstrap-rgw/:/var/lib/ceph/bootstrap-rgw:z \
``` | guits | 0 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | library/ceph_osd.py | # Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writin... | # Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writin... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
cmd = generate_cmd(['osd', state], ids, cluster=cluster, container_image=container_image) # noqa: E501
``` | guits | 1 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | library/ceph_osd_flag.py | # Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writin... | # Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writin... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
cmd = generate_cmd(['osd', 'set'], [name], cluster=cluster, container_image=container_image) # noqa: E501
``` | guits | 2 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | library/ceph_osd_flag.py | # Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writin... | # Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writin... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
cmd = generate_cmd(['osd', 'unset'], [name], cluster=cluster, container_image=container_image) # noqa: E501
``` | guits | 3 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | library/ceph_pool.py | #!/usr/bin/python3
# Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or... | #!/usr/bin/python3
# Copyright 2020, Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
cmd = generate_cmd(cmd='rbd',
``` | guits | 4 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | module_utils/ca_common.py | import os
import datetime
def generate_ceph_cmd(sub_cmd, args, user_key=None, cluster='ceph', user='client.admin', container_image=None, interactive=False):
'''
Generate 'ceph' command line to execute
'''
if not user_key:
user_key = '/etc/ceph/{}.{}.keyring'.format(cluster, user)
cmd = p... | import os
import datetime
def generate_cmd(cmd='ceph',
sub_cmd=None,
args=None,
user_key=None,
cluster='ceph',
user='client.admin',
container_image=None,
interactive=False):
'''
Generate 'cep... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
def generate_cmd(cmd, sub_cmd, args, user_key=None, cluster='ceph', user='client.admin', container_image=None, interactive=False): # noqa: E501
```
(even though it would be nice to add type annotation...) | guits | 5 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | module_utils/ca_common.py | import os
import datetime
def generate_ceph_cmd(sub_cmd, args, user_key=None, cluster='ceph', user='client.admin', container_image=None, interactive=False):
'''
Generate 'ceph' command line to execute
'''
if not user_key:
user_key = '/etc/ceph/{}.{}.keyring'.format(cluster, user)
cmd = p... | import os
import datetime
def generate_cmd(cmd='ceph',
sub_cmd=None,
args=None,
user_key=None,
cluster='ceph',
user='client.admin',
container_image=None,
interactive=False):
'''
Generate 'cep... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
def generate_cmd(cmd = 'ceph',
sub_cmd = None,
args = None,
user_key = None,
cluster = 'ceph',
user = 'client.admin',
container_image = None,
interactive = False):
``` | guits | 6 |
ceph/ceph-ansible | 7,355 | Initialize rbd pool at pool creation | When creating a RBD pool it needs to be initialized as per documentation[1] Modified (pre_)generate_ceph_cmd to make it usable with rbd command as well
[1]https://docs.ceph.com/en/latest/rbd/rados-rbd-cmds/#create-a-block-device-pool
Signed-off-by: Teoman ONAY <tonay@redhat.com> | null | 2022-12-02 09:11:22+00:00 | 2023-01-18 13:13:04+00:00 | module_utils/ca_common.py | import os
import datetime
def generate_ceph_cmd(sub_cmd, args, user_key=None, cluster='ceph', user='client.admin', container_image=None, interactive=False):
'''
Generate 'ceph' command line to execute
'''
if not user_key:
user_key = '/etc/ceph/{}.{}.keyring'.format(cluster, user)
cmd = p... | import os
import datetime
def generate_cmd(cmd='ceph',
sub_cmd=None,
args=None,
user_key=None,
cluster='ceph',
user='client.admin',
container_image=None,
interactive=False):
'''
Generate 'cep... | asm0deuz | e5ad1953dccf7463507b932b04a00a17f3c8d81e | c39bbc3deaf7a02d36daa39d752e91e94afb3c3e | ```suggestion
cmd = pre_generate_cmd([cmd], container_image=container_image, interactive=interactive) # noqa: E501
``` | guits | 7 |
ceph/ceph-ansible | 7,326 | common: stop using ceph/daemon entrypoint | major refactor in order to make ceph-ansible use the `ceph/ceph` container image instead of `ceph/daemon` | null | 2022-10-07 12:52:53+00:00 | 2023-05-31 21:07:13+00:00 | roles/ceph-mon/templates/ceph-mon.service.j2 | [Unit]
Description=Ceph Monitor
PartOf=ceph-mon.target
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% endif %}
Wants=network-online.target local-fs.target... | [Unit]
Description=Ceph Monitor
PartOf=ceph-mon.target
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% endif %}
Wants=network-online.target local-fs.target... | guits | 5cd692dcdc8dd55036b8c283f1bca56f79965c1d | 23a8bbc6c59d78e982f343c06cfb5fe8e86cb757 | ```suggestion
-i {{ monitor_name }} --mon-data /var/lib/ceph/mon/{{ cluster }}-{{ monitor_name }} --public-addr {{ _current_monitor_address }}
``` | guits | 8 |
ceph/ceph-ansible | 7,326 | common: stop using ceph/daemon entrypoint | major refactor in order to make ceph-ansible use the `ceph/ceph` container image instead of `ceph/daemon` | null | 2022-10-07 12:52:53+00:00 | 2023-05-31 21:07:13+00:00 | roles/ceph-nfs/tasks/pre_requisite_container.yml | ---
- name: keyring related tasks
when: groups.get(mon_group_name, []) | length > 0
block:
- name: set_fact container_exec_cmd
set_fact:
container_exec_cmd: "{{ container_binary }} exec ceph-mon-{{ hostvars[item]['ansible_facts']['hostname'] }}"
with_items: "{{ groups.get(mon_group_name, [])... | ---
- name: keyring related tasks
when: groups.get(mon_group_name, []) | length > 0
block:
- name: set_fact container_exec_cmd
set_fact:
container_exec_cmd: "{{ container_binary }} exec ceph-mon-{{ hostvars[item]['ansible_facts']['hostname'] }}"
with_items: "{{ groups.get(mon_group_name, [])... | guits | 5cd692dcdc8dd55036b8c283f1bca56f79965c1d | 23a8bbc6c59d78e982f343c06cfb5fe8e86cb757 | need to figure out what to do with this | guits | 9 |
ceph/ceph-ansible | 7,326 | common: stop using ceph/daemon entrypoint | major refactor in order to make ceph-ansible use the `ceph/ceph` container image instead of `ceph/daemon` | null | 2022-10-07 12:52:53+00:00 | 2023-05-31 21:07:13+00:00 | roles/ceph-nfs/tasks/pre_requisite_container.yml | ---
- name: keyring related tasks
when: groups.get(mon_group_name, []) | length > 0
block:
- name: set_fact container_exec_cmd
set_fact:
container_exec_cmd: "{{ container_binary }} exec ceph-mon-{{ hostvars[item]['ansible_facts']['hostname'] }}"
with_items: "{{ groups.get(mon_group_name, [])... | ---
- name: keyring related tasks
when: groups.get(mon_group_name, []) | length > 0
block:
- name: set_fact container_exec_cmd
set_fact:
container_exec_cmd: "{{ container_binary }} exec ceph-mon-{{ hostvars[item]['ansible_facts']['hostname'] }}"
with_items: "{{ groups.get(mon_group_name, [])... | guits | 5cd692dcdc8dd55036b8c283f1bca56f79965c1d | 23a8bbc6c59d78e982f343c06cfb5fe8e86cb757 | this has to be uncommented out | guits | 10 |
ceph/ceph-ansible | 7,326 | common: stop using ceph/daemon entrypoint | major refactor in order to make ceph-ansible use the `ceph/ceph` container image instead of `ceph/daemon` | null | 2022-10-07 12:52:53+00:00 | 2023-05-31 21:07:13+00:00 | roles/ceph-nfs/templates/ceph-nfs.service.j2 | [Unit]
Description=NFS-Ganesha file server
Documentation=http://github.com/nfs-ganesha/nfs-ganesha/wiki
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% end... | [Unit]
Description=NFS-Ganesha file server
Documentation=http://github.com/nfs-ganesha/nfs-ganesha/wiki
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% end... | guits | 5cd692dcdc8dd55036b8c283f1bca56f79965c1d | 23a8bbc6c59d78e982f343c06cfb5fe8e86cb757 | need to preserve this line | guits | 11 |
ceph/ceph-ansible | 7,326 | common: stop using ceph/daemon entrypoint | major refactor in order to make ceph-ansible use the `ceph/ceph` container image instead of `ceph/daemon` | null | 2022-10-07 12:52:53+00:00 | 2023-05-31 21:07:13+00:00 | roles/ceph-nfs/templates/ceph-nfs.service.j2 | [Unit]
Description=NFS-Ganesha file server
Documentation=http://github.com/nfs-ganesha/nfs-ganesha/wiki
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% end... | [Unit]
Description=NFS-Ganesha file server
Documentation=http://github.com/nfs-ganesha/nfs-ganesha/wiki
{% if container_binary == 'docker' %}
After=docker.service network-online.target local-fs.target time-sync.target
Requires=docker.service
{% else %}
After=network-online.target local-fs.target time-sync.target
{% end... | guits | 5cd692dcdc8dd55036b8c283f1bca56f79965c1d | 23a8bbc6c59d78e982f343c06cfb5fe8e86cb757 | previously, the "start_nfs" script was starting idmapd as well; won't that be required? Also did this solution support nfsv3? if yes, statd and rpcbind are necessary as well? | gouthampacha | 12 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.