Update fs.py

fs.py

@@ -18,11 +18,11 @@ from citations_and_descriptions import (
 class FSConfig(datasets.BuilderConfig):
     """BuilderConfig for FS."""
 
-    def __init__(self, data_url, citation, url, max_source_length, tokenizer, **kwargs):
+    def __init__(self, additional_features, data_url, citation, url, **kwargs):
         """BuilderConfig for FS.
         Args:
-          features: `list[string]`, list of the features that will appear in the
-            feature dict. Should not include "label".
+          additional_features: `list[string]`, list of the features that will appear in the feature dict
+           additionally to the self.id_key, self.source_key and self.target_key. Should not include "label".
           data_url: `string`, url to download the zip file from.
           citation: `string`, citation for the data set.
           url: `string`, url for information about the data set.
@@ -32,29 +32,14 @@ class FSConfig(datasets.BuilderConfig):
           **kwargs: keyword arguments forwarded to super.
         """
         super(FSConfig, self).__init__(version=datasets.Version("1.0.0"), **kwargs)
-        self.features = ["pid", self.source_key, self.target_key]
+        self.features = [self.id_key, self.source_key, self.target_key] + additional_features
         self.data_url = data_url
         self.citation = citation
         self.url = url
-        self.max_source_length = max_source_length
-        self.tokenizer = tokenizer
-
-    def remove_redundant_fields(self, example):
-        for field in self.redundant_fields:
-            del example[field]
-
-    @abstractmethod
-    def postprocess(self, s):
-        pass
 
     @property
     @abstractmethod
-    def original_source_key(self):
-        pass
-
-    @property
-    @abstractmethod
-    def original_target_key(self):
+    def id_key(self):
         pass
 
     @property
@@ -73,25 +58,19 @@ class FSConfig(datasets.BuilderConfig):
         pass
 
     @property
+    @abstractmethod
     def source_key(self):
-        return "source"
-
-    @property
-    def target_key(self):
-        return "target"
+        pass
 
     @property
     @abstractmethod
-    def id_key(self):
+    def target_key(self):
         pass
 
-    @property
-    def redundant_fields(self):
-        return []
-
-    def process(self, example):  # TODO perhaps we can use this for base
-        example[self.source_key] = example[self.original_source_key].strip()
-        example[self.target_key] = example[self.original_target_key].strip() if example[self.original_target_key] else None
+    def process(self, example):
+        example[self.source_key] = example[self.source_key].strip()
+        example[self.target_key] = example[self.target_key].strip() if example[
+            self.target_key] else None
 
 
 class ScrollsConfig(FSConfig):
@@ -99,11 +78,11 @@ class ScrollsConfig(FSConfig):
         super().__init__(**kwargs)
 
     @property
-    def original_source_key(self):
+    def source_key(self):
         return "input"
 
     @property
-    def original_target_key(self):
+    def target_key(self):
         return "output"
 
     @property
@@ -122,89 +101,70 @@ class ScrollsConfig(FSConfig):
     def id_key(self):
         return "pid"
 
-    @property
-    def redundant_fields(self):
-        return [self.original_source_key, self.original_target_key, "id"]
-
-
-
-    def process_input(self, s):
-        prefix = s.strip()
-        suffix = "\nSummarize the above:"
-        prefix = _truncate_prefix(prefix, suffix, self.max_source_length, self.tokenizer)
-        return prefix + suffix
-
 
 class ArxivConfig(FSConfig):
-    # TODO properties etc...
     def __init__(self, **kwargs):
         super().__init__(**kwargs)
-        self.train_file = "train.txt"
-        self.validation_file = "val.txt"
-        self.test_file = "test.txt"
 
-        self.input_key = "article_text"
-        self.output_key = "abstract_text"
-        self.id_key = "article_id"
-        self.redundant_fields = [self.input_key, self.output_key, self.id_key, 'labels', 'section_names', 'sections']
+    @property
+    def id_key(self):
+        return "article_id"
 
-    def process_input(self, s):
-        prefix = ' '.join(s)
-        suffix = "\nSummarize the above:"
-        prefix = _truncate_prefix(prefix, suffix, self.max_source_length, self.tokenizer)
-        return prefix + suffix
+    @property
+    def source_key(self):
+        return "article_text"
 
-    def process_output(self, s):
-        # TODO remove "<S>" and "</S>" ?
-        return ' '.join(s).replace("<S>", "").replace("</S>", "")
+    @property
+    def target_key(self):
+        return "abstract_text"
 
+    @property
+    def train_file(self):
+        return "train.txt"
 
-def _truncate_prefix(prefix, suffix, max_source_length, tokenizer):
-    encoded_input = tokenizer.encode(prefix + suffix)
+    @property
+    def validation_file(self):
+        return "val.txt"
 
-    while len(encoded_input) > max_source_length:
-        overflow = len(encoded_input) - max_source_length
-        tokenized_prefix = tokenizer.encode(prefix, add_special_tokens=False)
-        if overflow > 0:
-            tokenized_prefix = tokenized_prefix[:-overflow]
-        prefix = tokenizer.decode(tokenized_prefix, skip_special_tokens=False).strip()
-        encoded_input = tokenizer.encode(prefix + suffix)
+    @property
+    def test_file(self):
+        return "test.txt"
 
-    return prefix
+    def process(self, example):
+        example[self.source_key] = " ".join(example[self.source_key])
+        example[self.target_key] = " ".join(example[self.target_key]).replace("<S>", "").replace("</S>", "")
+        del example["labels"]
+        super().process(example)
 
 
 class Fs(datasets.GeneratorBasedBuilder):
     """The SCROLLS benchmark."""
-
     DEFAULT_WRITER_BATCH_SIZE = 1000  # because Narrative QA is a rather large dataset
     BUILDER_CONFIGS = [
         ScrollsConfig(
+            additional_features=["id"],
             name="summ_screen_fd_debug",
             description=_SUMM_SCREEN_DESCRIPTION,
             data_url="https://huggingface.co/datasets/tau/fs/resolve/main/data/summ_screen_fd_debug.zip",
             citation=_SUMM_SCREEN_CITATION,
-            url="https://github.com/mingdachen/SummScreen",
-            max_source_length=None,
-            tokenizer=None,
+            url="https://github.com/mingdachen/SummScreen"
         ),
         ScrollsConfig(
+            additional_features=["id"],
             name="gov_report",
             description=_GOV_REPORT_CITATION,
             data_url="https://huggingface.co/datasets/tau/fs/resolve/main/data/gov_report.zip",
             citation=_GOV_REPORT_DESCRIPTION,
-            url="https://gov-report-data.github.io/",
-            max_source_length=None,
-            tokenizer=None,
+            url="https://gov-report-data.github.io/"
+        ),
+        ArxivConfig(
+            additional_features=['section_names', 'sections'],
+            name="arxiv_debug",
+            description=_ARXIV_CITATION,
+            data_url="https://huggingface.co/datasets/tau/fs/resolve/main/data/arxiv_debug.zip",
+            citation=_ARXIV_DESCRIPTION,
+            url="https://github.com/armancohan/long-summarization"
         ),
-        # ArxivConfig(
-        #     name="arxiv_debug",
-        #     description=_ARXIV_CITATION,
-        #     data_url="https://huggingface.co/datasets/tau/fs/resolve/main/data/arxiv_debug.zip",
-        #     citation=_ARXIV_DESCRIPTION,
-        #     url="https://github.com/armancohan/long-summarization",
-        #     max_source_length=None,
-        #     tokenizer=None,
-        # ),
     ]
 
     def _info(self):
@@ -251,12 +211,5 @@ class Fs(datasets.GeneratorBasedBuilder):
         with open(data_file, encoding="utf-8") as f:
             for line in f:
                 row = json.loads(line)
-
-                row["pid"] = row[self.config.id_key]
                 self.config.process(row)
-                self.config.remove_redundant_fields(row)
-                yield row["pid"], row
-
-
-def _get_task_name_from_data_url(data_url):
-    return data_url.split("/")[-1].split(".")[0]
+                yield row[self.config.id_key], row