Split book by chapter. Remove tiny chapters.

README.md

@@ -5,13 +5,13 @@ dataset_info:
     dtype: string
   splits:
   - name: train
-    num_bytes: 18297128
-    num_examples: 21
+    num_bytes: 18352678
+    num_examples: 699
   - name: test
-    num_bytes: 48450
+    num_bytes: 48421
     num_examples: 1
   download_size: 0
-  dataset_size: 18345578
+  dataset_size: 18401099
 ---
 
-Russian translations of Murakami novels, to fine-tune a generative language model. Originally downloaded from the FB2 archive http://flibusta.is/a/8570.
+Russian translations of Murakami novels, to fine-tune a generative language model. Originally downloaded from the FB2 archive http://flibusta.is/a/8570.

murakami.py

@@ -23,6 +23,10 @@ class Builder(datasets.GeneratorBasedBuilder):
 
     VERSION = datasets.Version("1.1.0")
 
+    # Small chapters are usually the footnotes and the title of the book, skipping by default as it's
+    # not helping to capture the style of the author anyway.
+    MIN_CHAPTER_SIZE = 500
+
     def _info(self):
         return datasets.DatasetInfo(
             # This is the description that will appear on the datasets page.
@@ -61,22 +65,19 @@ class Builder(datasets.GeneratorBasedBuilder):
 
     def _generate_examples(self, filepaths):
         for fileidx, filepath in enumerate(filepaths):
-            print(fileidx, filepath)
-            title, text = self._extract_text_from_fb2(filepath, fileidx)
-            yield title, {"text": text}
+            title, chapters = self._extract_text_from_fb2(filepath, fileidx)
+            for i, chapter in enumerate(chapters):
+                yield f"{title} {i}", {"text": chapter}
 
     @staticmethod
-    def _extract_text_from_fb2(filepath: Path, fileidx: int) -> tuple[str, str]:
+    def _extract_text_from_fb2(filepath: Path, fileidx: int) -> tuple[str, list[str]]:
         """
-        Parse FB2 file and return the concatenation of its paragraphs, along with the title.
+        Parse a FB2 file and return book chapters, along with the book title.
         """
         # Load the FB2 format file
         with filepath.open("rb") as file:
             fb2_data = file.read()
 
-        # Print structure of the FB2 format file
-        # print(etree.tostring(etree.fromstring(fb2_data), pretty_print=True))
-
         # Parse the FB2 format file using lxml
         root = etree.fromstring(fb2_data)
 
@@ -85,79 +86,38 @@ class Builder(datasets.GeneratorBasedBuilder):
             "//fb:title-info/fb:book-title",
             namespaces={"fb": "http://www.gribuser.ru/xml/fictionbook/2.0"},
         )[0].text
-        print(title)
 
-        # Get all book paragraphs
-        paragraphs = root.xpath(
-            "//fb:p",
-            namespaces={"fb": "http://www.gribuser.ru/xml/fictionbook/2.0"},
-        )
+        # UNCOMMENT THIS TO BUILD `START_PARAGRAPHS`
+        # helper_to_find_first_paragraphs(root, title, bi)
+        # continue
 
-        # UNCOMMENT THE LINE BELOW TO BUILD `START_PARAGRAPHS`:
-        # self.helper_to_find_first_paragraphs(paragraphs, title, bi)
+        # All text is stored in <p> tags. There are also <section> tags, which do not have any content,
+        # but serve as chapters separators. So we will merge all <p> tags contents between two <section>.
+        chapters: list[str] = []
 
-        found_paragraphs = []
-        skipping = True
-        for pi, p in enumerate(paragraphs):
-            if p.text is None:
-                continue
+        def _add_chapter(text: str):
+            if not text:
+                return
             if (
-                fileidx in Builder.START_PARAGRAPHS
-                and pi >= Builder.START_PARAGRAPHS[fileidx]
+                Builder.MIN_CHAPTER_SIZE is not None
+                and len(text) < Builder.MIN_CHAPTER_SIZE
             ):
-                skipping = False
-            if skipping and p.text.lower() == title.lower():
-                skipping = False
-            if not skipping:
-                found_paragraphs.append(p)
-        print(f"Found {len(found_paragraphs)} paragraphs")
-        text = ""
-        for p in found_paragraphs:
-            text += p.text.replace(" ", " ") + "\n"
-        text += "\n"
-        return title, text
-
-    # Number of initial <p> element to take from each fb2, by number. This allows to skip
-    # intros and other junk in the beginning of an fb2. This is built semi-manually using
-    # the `self.helper_to_find_first_paragraphs` function.
-    START_PARAGRAPHS = {
-        3: 5,
-        6: 27,
-        7: 3,
-        9: 4,
-        10: 3,
-        12: 11,
-        18: 5,
-        20: 3,
-        21: 5,
-    }
-
-    @staticmethod
-    def helper_to_find_first_paragraphs(paragraphs, title, book_number, n=30):
-        """
-        Helps to eyeball first few paragraphs of a book to skip junk paragraphs
-        in the beginning and manually construct the `tart_paragraphs` dict.
-        """
-        found_paragraphs = []
-        skipping = True
-        for i, p in enumerate(list(paragraphs)[:n]):
-            if p.text is None:
-                continue
-            if (
-                book_number in Builder.START_PARAGRAPHS
-                and i >= Builder.START_PARAGRAPHS[book_number]
-            ):
-                skipping = False
-            if skipping and p.text.lower() == title.lower():
-                skipping = False
-            if not skipping:
-                found_paragraphs.append(f"   {i} {p.text}")
-
-        if found_paragraphs:
-            print("✅")
-            print("\n".join(found_paragraphs))
-
-        else:
-            print("❌")
-            for i, p in enumerate(list(paragraphs)[:30]):
-                print(f"   {i} {p.text}")
+                # print(f"Skipping chapter of length {len(text)}")
+                pass
+            else:
+                # print(f"Adding chapter of length {len(text)}")
+                chapters.append(text)
+
+        chapter = ""
+        for e in root.iter():
+            if e.tag.endswith("}p"):
+                chapter += (e.text or "") + (e.tail or "")
+            elif e.tag.endswith("}section"):
+                _add_chapter(chapter)
+                chapter = ""
+        _add_chapter(chapter)
+
+        print(f'{filepath}: "{title}", found {len(chapters)} chapters')
+        # print(f"Chapter sizes: {', '.join(str(len(c)) for c in chapters)}")
+        # print()
+        return title, chapters