text stringlengths 0 1.62k |
|---|
[3224.06 --> 3229.54] crossing wires yeah and you know i think i think that that approach like it probably works for some |
[3229.54 --> 3236.28] people it probably works for people on small teams um but like i do dozens of code reviews a day and |
[3236.28 --> 3242.00] there are people on my team that do more and you know it's crucial that the process be as efficient as |
[3242.00 --> 3249.50] possible and there are just too many inefficiencies in the github way so that's that's why we didn't go |
[3249.50 --> 3255.66] with pull requests essentially uh that's another mention i want to mention here is why don't you |
[3255.66 --> 3259.46] accept pull requests we're kind of answering that so i won't ask you that directly so let's |
[3259.46 --> 3266.76] sort of roundabout answer that my thought is is that like you use garrett because it gives you a better |
[3266.76 --> 3271.82] user experience around code review accepting you know pull requests that aren't actually get a pull |
[3271.82 --> 3278.18] request but you know reviewing code changes and for the reason you just mentioned there but if github |
[3278.18 --> 3285.50] improved their pull request processes to let's say match the garrett process let's say that became |
[3285.50 --> 3292.08] the new github way would you stop using garrett well i mean there's a lot of hypotheticals in that |
[3292.08 --> 3298.16] question right of course yeah plus you got the cla or the yeah the cla is involved in there so the |
[3298.16 --> 3303.92] contributors license agreement that is part of contributing to go yeah we actually things are |
[3303.92 --> 3310.08] happening yeah so licensing is obviously important we need to make sure that um the people who are |
[3310.08 --> 3317.60] contributing code actually give the project the license to use that code that's an important legal |
[3317.60 --> 3322.30] protection for us as a project it's important legal protection for our users as well and with garrett |
[3322.30 --> 3328.74] you know you can't actually send a change until you've signed that agreement electronically um and so |
[3328.74 --> 3333.34] that's nice it means that if i'm reviewing someone's code it means that i actually legally am allowed to |
[3333.34 --> 3339.72] look at that code and submit it right on github there's no sort of uh built-in support for that |
[3339.72 --> 3345.84] but we do have this google bot that we can enable for projects that when a pull request comes in it |
[3345.84 --> 3351.20] checks whether the github user has signed the cla and so that's not actually a problem for us using |
[3351.20 --> 3357.62] github i have a couple of projects like the the code base for godoc.org the the go documentation |
[3357.62 --> 3365.22] website um that is hosted on github and i use pull requests for reviewing code because that predates the |
[3365.22 --> 3371.54] transition of the main project to github yeah um and i use the google bot for processing clis there and it works |
[3371.54 --> 3379.00] fine it's it's great but look i could i could imagine like if if github was able to give us a workflow |
[3379.00 --> 3384.12] that was i guess it would have to be better than garrett at this point because we're not going to just change |
[3384.12 --> 3389.80] things again but it would definitely be preferable you know i don't like getting pull requests on |
[3389.80 --> 3396.26] because incidentally there's no way to disable pull requests on github so like you can't opt out you |
[3396.26 --> 3401.68] can't opt out and i i don't like having a contributor send a pull request and me having to say i'm sorry |
[3401.68 --> 3406.34] we don't take pull requests that yeah that's a bummer too i almost feel like there should be like if you're |
[3406.34 --> 3413.14] not gonna not so much turn them off but point them elsewhere yeah you know so like if someone forks it |
[3413.14 --> 3417.34] and sends a pull request or wants to go through the process rather than going through the github way |
[3417.34 --> 3422.46] it points to say a different public url through garrett or something else that still gives you the |
[3422.46 --> 3429.18] same abilities just not using native github yeah i mean i would love if if anyone from github listening |
[3429.18 --> 3434.78] you know there are a lot of small things that could be done to provide essential information to |
[3434.78 --> 3442.80] contributors early like if you put a contributing.md file in your project root when a user goes to file an |
[3442.80 --> 3448.08] issue they see a link at the top that says please read the contribution guidelines before filing an |
[3448.08 --> 3453.22] issue and that's that's nice i would actually prefer it if they just showed the contributing file |
[3453.22 --> 3461.56] you know on the on the issue filing page because our contributing file is very simple but it says like |
[3461.56 --> 3466.90] for instance if you're filing an issue report please tell us these essential pieces of information |
[3466.90 --> 3473.76] and you know on google code we actually had a template you know it would say what version of go are you |
[3473.76 --> 3478.46] running what platform are you running on what did you see what did you expect to see you know what did |
[3478.46 --> 3484.36] you do this this kind of like these five essential questions and not having that template in the issue |
[3484.36 --> 3490.72] tracker means we get less informative bug reports and they require more handling and more follow-up |
[3490.72 --> 3497.82] which means that they're less likely to get addressed and with the pull request thing as far as i'm aware |
[3497.82 --> 3503.50] the the contributor doesn't get shown that that link to the contributing doc when you create a pull request |
[3503.50 --> 3509.50] and you know the essential line in that doc is we don't take pull requests here's the contribution process |
[3509.50 --> 3517.52] and so you know i feel like if github would just surface that contributing file more readily in these |
[3517.52 --> 3523.86] processes we could really uh you know reduce the double handling that happens for a lot of these issues |
[3523.86 --> 3529.38] and reduce frustration because i think you know our contributors they want to contribute in the way that works |
[3529.38 --> 3535.98] for the project you know um nobody wants to be doing the wrong thing um but i think it's frustrating |
[3535.98 --> 3541.76] and you know upsetting to people when they think they're doing the right thing by sending a pull request |
[3541.76 --> 3547.32] and then they're told sorry that's that's not the way we do things and they can't be faulted for not |
[3547.32 --> 3553.82] knowing that but at the same time like you know i get tired of of telling people the same thing like every |
[3553.82 --> 3561.52] every day or two i think it's it's surprising though when you have a disclaimer saying we don't accept pull |
[3561.52 --> 3567.66] requests i think you got to put a parentheses there and say kinda no it's it's not exactly true there's |
[3567.66 --> 3574.80] some steps that require like the cla being signed to hand the rights over to the project and whatnot |
[3574.80 --> 3579.66] so i think it's just kind of funny that you said you know we don't accept pull requests but it's not |
[3579.66 --> 3585.90] it's not exactly true well no it is it is strictly true because we accept contributions but they're not |
[3585.90 --> 3591.74] in the form of pull requests pull requests right yeah i think i almost feel like those are |
[3591.74 --> 3597.64] interchangeable terms to a degree i mean i know github coined the phrase but because open source |
[3597.64 --> 3604.30] is becoming more and more in the public's eye github is the place where people think open source |
[3604.30 --> 3610.90] happens you know so to the untrained hacker eye or developer eye trying to erase hacker from my |
[3610.90 --> 3617.54] my lingo because it's just not inclusive i want to be inclusive everybody um but anyways you know to |
[3617.54 --> 3622.34] the untrained developer eye everyone else thinks that github is sort of the epicenter which it |
[3622.34 --> 3628.02] you know reasons you're there too with uh with go is that it's become the place where the community |
[3628.02 --> 3634.46] is and so to send a pull request is like saying i contribute and so that sort of becomes the the |
[3634.46 --> 3639.96] somewhat interchangeable terminology at least at least in my opinion well you know i just i just hope that |
[3639.96 --> 3644.74] github takes the feedback from people like us and you know we're definitely not alone there's a lot of |
[3644.74 --> 3652.58] people who have similar issues with you know their pull request system and i i hope that you know they |
[3652.58 --> 3658.22] take this on and you know being the kind of de facto center of the open source world i think they have a |
[3658.22 --> 3663.72] responsibility to respond to these kinds of requests but you know ultimately they are a business and |
[3663.72 --> 3671.66] personally i don't believe that um it's healthy for everyone to have this kind of dependence on |
[3671.66 --> 3676.42] one large business and obviously working for google that might sound somewhat ironic coming out of my |
[3676.42 --> 3682.96] mouth but yeah a little bit but you know i feel you i know what you mean i i am a big fan of running |
[3682.96 --> 3688.34] your own infrastructure um i think it makes sense to use infrastructure provided by other people where it |
[3688.34 --> 3693.70] makes sense but you know i'm a contributor to brad fitzpatrick's camley store project which is |
[3693.70 --> 3701.84] all about reclaiming control of your content and you know you could it's a storage system for things |
[3701.84 --> 3709.16] like photos or basically any kind of files or anything and you know you can run it on on cloud |
[3709.16 --> 3718.22] storage or s3 or whatever but you can also run it on a server in your basement and you can do both |
[3718.22 --> 3723.34] you can synchronize it between both things and i think it's you know i think we need to build |
[3723.34 --> 3731.56] systems that break our dependence on large organizations and so yeah i mean i hope people |
[3731.56 --> 3738.06] don't forget that git is not github you know git is an open source tool that anyone can use to host |
[3738.06 --> 3744.42] source code anywhere um and i hope people don't you know i hope it's not quite true what you say about |
[3744.42 --> 3750.72] people thinking github equals open source because um well i don't think that that exactly means it |
[3750.72 --> 3755.20] equals but you know when they think open source they think well is it on github oh then it's not |
[3755.20 --> 3763.36] open sourced you know that's that's it's not the truth but to the untrained eye it it starts to become |
[3763.36 --> 3770.76] truthy because anything that's happening around open source tends to be pointed back to some sort of |
[3770.76 --> 3779.12] github.com slash url yeah i mean like kudos to github for building something people really love um |
[3779.12 --> 3786.14] and i think they've done a great job but i i think it's really important particularly in the open source |
[3786.14 --> 3793.02] community for everyone to remember to be self-reliant you know i think that's that's a really valuable |
[3793.02 --> 3798.96] thing and it's kind of a core tenet of of what open source is about let's talk a bit about uh |
[3798.96 --> 3803.28] we don't have much more time here we got maybe like eight minutes flat probably probably less than |
[3803.28 --> 3809.86] that since we've actually gone over time a bit but let's talk about uh go 1.5 is releasing uh |
[3809.86 --> 3816.30] august august 2015 with your new release cycle uh no c code will be in 1.5 you've got some new |
[3816.30 --> 3824.86] architectures supporting power pc 64 and maybe the arm 64 now when i saw this forgive me but the question |
[3824.86 --> 3830.60] i asked myself was what types of machines are running on power pc 64 and arm 64 because i guess |
[3830.60 --> 3834.94] i just never think about what my my machine is running i write my back book and whatever they |
[3834.94 --> 3841.12] give me i i just you know uh i just use it yeah no i know it's not power pc because they went to |
[3841.12 --> 3847.86] intel until a while ago but so what is the power pc 64 and arm 64 uh architectures right so places |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.