text stringlengths 0 2.29k |
|---|
**Jerod Santo:** Yeah, we can do that. |
**Gerhard Lazu:** So Adam, how do we get feature flags? What do you think? |
**Adam Stacoviak:** Hm... |
**Gerhard Lazu:** Where do you stand on that? |
**Jerod Santo:** Well, if we're doing 50/50, can't we just do like an if statement, with like random divided by two? \[laughter\] |
**Gerhard Lazu:** Sure. "If it's an even second, do this. And if it's an uneven second, do the other thing." \[laughs\] |
**Jerod Santo:** If it's an imperial unit, or if it's the metric system... Is this the metric system, or which system are we going to use here? |
**Gerhard Lazu:** Luckily, seconds only exist in one... \[laughs\] |
**Jerod Santo:** I know Adam's been keen on feature flags, and I feel like this is his big moment to introduce some sort of subsystem. |
**Gerhard Lazu:** I think so too. |
**Adam Stacoviak:** I mean, I don't feel like I have a system to pitch here... \[laughter\] |
**Gerhard Lazu:** No, I remember the conversation, Jerod. That's why I keep going back to it. Because we didn't have a good answer for Adam, and we were both against it. So maybe now it's coming back, and maybe now it's a yes, because it was a definite no back then. |
**Adam Stacoviak:** We were premature. When I tried to pitch -- |
**Jerod Santo:** Feature flags? |
**Adam Stacoviak:** The insider story here, listeners, is there was -- my initial pitch for us using feature flags fell on deaf ears, essentially, because we were premature. We just didn't have the need for it. We were trying to find a use for it, and if you follow Kaizen, and Ship It, and what we've done, then you kno... |
We do have a new sponsor coming on board, DevCycle, which is in the feature fly business, which - you know, if you wanted to use it for this one instance, I'm sure we could do something. So I mean, there is an opportunity there, but... That would be my pitch. I feel like if it's just this one off though, then the if st... |
**Jerod Santo:** Well, I'll let you know when I get this far. What we need first, I think, is the observability. Because either way, if we do it 50/50, we want to see both results. |
**Gerhard Lazu:** Of course. |
**Jerod Santo:** And so right now I can't see any results, besides sit there and stare at the log files, and look at the request responses... Which was a side effect, actually, of one of our recent changes - our log files just stopped logging. I got it fixed, but that was funny. So I'm like "Wait a second, there aren't... |
**Adam Stacoviak:** How can the Changelog not log? |
**Jerod Santo:** Right? |
**Adam Stacoviak:** That's just like against the laws of nature, essentially. |
**Jerod Santo:** Well, I'm not gonna git blame that one on the air, because I don't want to embarrass Gerhard, but... I fixed it. |
**Gerhard Lazu:** That's okay, I can't get embarrassed. \[laughter\] I can't, because I'm going to learn something new out of this. |
**Jerod Santo:** There you go. |
**Gerhard Lazu:** So tell me the commit where this was introduced, so that I can understand my mistake. Seriously. |
**Jerod Santo:** \[54:00\] So the code that fixes it is in commit f19c9cf, where I basically changed the application file to basically turn the logger back on. So I think you were overly aggressive when you were -- you were removing a few things... We removed PromEx, because we're not really using Grafana anymore... An... |
**Gerhard Lazu:** I see. |
**Jerod Santo:** ...and you didn't notice. |
**Gerhard Lazu:** Yeah, that's right. |
**Jerod Santo:** And I didn't notice, and so I just thought, "Well, I'll just go see what's going on in production", and there was no logs there. So I actually just put that code back in, that you had deleted, is all. |
**Gerhard Lazu:** Right. So hang on, let me try and understand this code... That's what's happening right now. I'm trying to understand some Elixer code live, as we are recording this... I'm looking at the application.ex, line 32, 'unless Code.ensure_loaded?(IEx) && IEx.started?() do' Which of those two lines disables ... |
**Jerod Santo:** No, that's not the line. Look at endpoint.ex line 60. Plug.telemetry. That's the line where you basically remove the telemetry plug. |
**Gerhard Lazu:** Okay, okay, okay. I see. So the telemetry plug logs. |
**Jerod Santo:** Yes. |
**Gerhard Lazu:** I see. Okay. |
**Jerod Santo:** The logger uses the telemetry plug to do its thing. |
**Gerhard Lazu:** Right, right. If it would have been plug log. I don't think I would have made that mistake. |
**Jerod Santo:** Right. Yeah. |
**Gerhard Lazu:** But yeah, cool. Okay. That's good to know. |
**Jerod Santo:** So yeah, it was an easy mistake to make. And I know how it is when you're removing stuff. You're like "Oh, this we don't need. This we don't need." And I think it was just that one line... |
**Gerhard Lazu:** That's it. |
**Jerod Santo:** ...just turned that off, and we didn't notice because we weren't really looking at production. Now, had we been sending it over to Honeycomb and observing it, we probably would have seen the drop-off immediately, because Telemetry would have been turned off there. |
**Gerhard Lazu:** Yeah, that's right. |
**Jerod Santo:** So I think the Honeycomb integration will use this OpenTelemetry plug as well, when we do it. So that was the line that did it; it wasn't the other one. There was a few other things that you also removed, I put them back in, but that was like Oban stuff. Not a big deal. It was just over-aggressive dele... |
**Gerhard Lazu:** Probably. I deleted too much. |
**Jerod Santo:** Yeah. When you're in like "Let's delete stuff" mode... I know how it is, because it feels so good. |
**Gerhard Lazu:** Okay, okay. Okay, okay. |
**Jerod Santo:** So there you go. |
**Gerhard Lazu:** Cool. That's good to know. So who reviewed my PR? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.