| {"time": "2023-09-13T14:46:17+00:00", "type": "commit", "payload": {"sha": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "node_id": "C_kwDOKNhT9doAKGVjNWZmNGUwOGJiZGY3YTgwOGZkY2NhYWM4ODBiN2VmYjYyYzg2M2U", "commit": {"author": {"name": "Daniel Neilson", "email": "53624638+ddneilson@users.noreply.github.com", "date": "2023-09-13T14:46:17Z"}, "committer": {"name": "Daniel Neilson", "email": "53624638+ddneilson@users.noreply.github.com", "date": "2023-09-14T05:05:13Z"}, "message": "fix: make typed union disciminators function correctly\n\nThis corrects two errors in the way that typed union disciminators were\nimplemented in the model:\n1. discriminator was spelled incorrectly (\"desciminator\") causing no\n discriminators to be active in the model; and\n2. discriminators for collections of unions were defined incorrectly --\n they need to be annotated on the element rather than applied to the\n collecttion field.\n\nSigned-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>", "tree": {"sha": "9df1a462b3af53107ba240c4a1638af9b0dd0bbe", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/trees/9df1a462b3af53107ba240c4a1638af9b0dd0bbe"}, "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/commits/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "comment_count": 0, "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}}, "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/commit/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "comments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/comments", "author": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "committer": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "parents": [{"sha": "47ea9598c25741833bf23bfa9c07687b987c9a1f", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits/47ea9598c25741833bf23bfa9c07687b987c9a1f", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/commit/47ea9598c25741833bf23bfa9c07687b987c9a1f"}], "stats": {"total": 118, "additions": 99, "deletions": 19}, "files": [{"sha": "d39c7fe56b15478e8073037782b41bf21e4792cc", "filename": "src/openjd/model/v2023_09/_model.py", "status": "modified", "additions": 23, "deletions": 15, "changes": 38, "blob_url": "https://github.com/OpenJobDescription/openjd-model-for-python/blob/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/src%2Fopenjd%2Fmodel%2Fv2023_09%2F_model.py", "raw_url": "https://github.com/OpenJobDescription/openjd-model-for-python/raw/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/src%2Fopenjd%2Fmodel%2Fv2023_09%2F_model.py", "contents_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contents/src%2Fopenjd%2Fmodel%2Fv2023_09%2F_model.py?ref=ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "patch": "@@ -7,6 +7,7 @@\n from enum import Enum\n from graphlib import CycleError, TopologicalSorter\n from typing import TYPE_CHECKING, Any, ClassVar, Literal, Optional, Type, Union, cast\n+from typing_extensions import Annotated\n \n from pydantic import (\n Field,\n@@ -498,7 +499,7 @@ class IntTaskParameterDefinition(OpenJDModel_v2023_09):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (TaskParameterType.INT): Descriminator to identify the type of the parameter.\n+ type (TaskParameterType.INT): discriminator to identify the type of the parameter.\n range (IntRangeList | RangeString): The list of values that the parameter takes on.\n \"\"\"\n \n@@ -587,7 +588,7 @@ class FloatTaskParameterDefinition(OpenJDModel_v2023_09):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (TaskParameterType.FLOAT): Descriminator to identify the type of the parameter.\n+ type (TaskParameterType.FLOAT): discriminator to identify the type of the parameter.\n range (FloatRangeList): The list of values that the parameter takes on.\n \"\"\"\n \n@@ -639,7 +640,7 @@ class StringTaskParameterDefinition(OpenJDModel_v2023_09):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (TaskParameterType.STRING): Descriminator to identify the type of the parameter.\n+ type (TaskParameterType.STRING): discriminator to identify the type of the parameter.\n range (StringRangeList): The list of values that the parameter takes on.\n \"\"\"\n \n@@ -667,7 +668,7 @@ class PathTaskParameterDefinition(OpenJDModel_v2023_09):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (TaskParameterType.PATH): Descriminator to identify the type of the parameter.\n+ type (TaskParameterType.PATH): discriminator to identify the type of the parameter.\n range (StringRangeList): The list of values that the parameter takes on.\n \"\"\"\n \n@@ -701,7 +702,11 @@ class PathTaskParameterDefinition(OpenJDModel_v2023_09):\n TaskParameterList = list[TaskParameterDefinition]\n CombinationExpr = str\n else:\n- TaskParameterList = conlist(TaskParameterDefinition, min_items=1, max_items=16)\n+ TaskParameterList = conlist(\n+ Annotated[TaskParameterDefinition, Field(..., discriminator=\"type\")],\n+ min_items=1,\n+ max_items=16,\n+ )\n # Limit the CombinationExpr to characters allowed in an Identifier plus whitespace\n # and the operator characters.\n CombinationExpr = constr(\n@@ -948,7 +953,7 @@ class JobStringParameterDefinition(OpenJDModel_v2023_09, JobParameterInterface):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (JobParameterType.STRING): Descriminator to identify the type of the parameter\n+ type (JobParameterType.STRING): discriminator to identify the type of the parameter\n userInterface (Optional[JobStringParameterDefinitionUserInterface]): User interface properties\n for this parameter\n description (Optional[Description]): A free form string that can be used to describe\n@@ -1163,7 +1168,7 @@ class JobPathParameterDefinition(OpenJDModel_v2023_09, JobParameterInterface):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (JobParameterType.PATH): Descriminator to identify the type of the parameter\n+ type (JobParameterType.PATH): discriminator to identify the type of the parameter\n objectType (Optional[JobPathParameterDefinitionObjectType]): The type of object the path represents,\n either a FILE or a DIRECTORY.\n dataFlow (Optional[JobPathParameterDefinitionDataFlow]): Whether the object the path represents\n@@ -1368,7 +1373,7 @@ class JobIntParameterDefinition(OpenJDModel_v2023_09):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (JobParameterType.INT): Descriminator to identify the type of the parameter\n+ type (JobParameterType.INT): discriminator to identify the type of the parameter\n userInterface (Optional[JobPathParameterDefinitionUserInterface]): User interface properties\n for this parameter\n description (Optional[Description]): A free form string that can be used to describe\n@@ -1577,7 +1582,7 @@ class JobFloatParameterDefinition(OpenJDModel_v2023_09):\n \n Attributes:\n name (Identifier): A name by which the parameter is referenced.\n- type (JobParameterType.FLOAT): Descriminator to identify the type of the parameter\n+ type (JobParameterType.FLOAT): discriminator to identify the type of the parameter\n userInterface (Optional[JobPathParameterDefinitionUserInterface]): User interface properties\n for this parameter.\n description (Optional[Description]): A free form string that can be used to describe\n@@ -2117,11 +2122,14 @@ def _validate_no_self_dependency(cls, values: dict[str, Any]) -> dict[str, Any]:\n else:\n StepTemplateList = conlist(StepTemplate, min_items=1)\n JobParameterDefinitionList = conlist(\n- Union[\n- JobIntParameterDefinition,\n- JobFloatParameterDefinition,\n- JobStringParameterDefinition,\n- JobPathParameterDefinition,\n+ Annotated[\n+ Union[\n+ JobIntParameterDefinition,\n+ JobFloatParameterDefinition,\n+ JobStringParameterDefinition,\n+ JobPathParameterDefinition,\n+ ],\n+ Field(..., discriminator=\"type\"),\n ],\n min_items=1,\n max_items=50,\n@@ -2162,7 +2170,7 @@ class JobTemplate(OpenJDModel_v2023_09):\n name: JobTemplateName\n steps: StepTemplateList\n description: Optional[Description] = None\n- parameterDefinitions: Optional[JobParameterDefinitionList] = Field(None, descriminator=\"type\")\n+ parameterDefinitions: Optional[JobParameterDefinitionList] = None\n jobEnvironments: Optional[JobEnvironmentsList] = None\n # Note: Cannot call the field 'schema'; it masks a base class field\n schemaStr: Optional[str] = Field(None, alias=\"$schema\") # noqa: N815"}, {"sha": "94df84f6e2cbcc5456bd50ad60f87d6ba9040fb7", "filename": "test/openjd/model/v2023_09/test_job_template.py", "status": "modified", "additions": 51, "deletions": 4, "changes": 55, "blob_url": "https://github.com/OpenJobDescription/openjd-model-for-python/blob/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/test%2Fopenjd%2Fmodel%2Fv2023_09%2Ftest_job_template.py", "raw_url": "https://github.com/OpenJobDescription/openjd-model-for-python/raw/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/test%2Fopenjd%2Fmodel%2Fv2023_09%2Ftest_job_template.py", "contents_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contents/test%2Fopenjd%2Fmodel%2Fv2023_09%2Ftest_job_template.py?ref=ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "patch": "@@ -182,23 +182,25 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n # no exception was raised.\n \n @pytest.mark.parametrize(\n- \"data\",\n+ \"data,expected_num_errors\",\n (\n- pytest.param({}, id=\"empty object\"),\n+ pytest.param({}, 3, id=\"empty object\"),\n pytest.param(\n {\n \"specificationVersion\": \"jobtemplate-2023-09\",\n \"name\": \"Foo\",\n \"steps\": [STEP_TEMPLATE],\n \"unknown\": \"key\",\n },\n+ 1,\n id=\"unknown key\",\n ),\n pytest.param(\n {\n \"name\": \"Foo\",\n \"steps\": [STEP_TEMPLATE],\n },\n+ 1,\n id=\"missing spec ver\",\n ),\n #\n@@ -209,6 +211,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"steps\": [STEP_TEMPLATE],\n \"description\": 12,\n },\n+ 1,\n id=\"description not string\",\n ),\n #\n@@ -217,6 +220,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"specificationVersion\": \"jobtemplate-2023-09\",\n \"name\": \"Foo\",\n },\n+ 1,\n id=\"missing steps\",\n ),\n pytest.param(\n@@ -225,6 +229,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"name\": \"Foo\",\n \"steps\": [],\n },\n+ 1,\n id=\"empty steps\",\n ),\n pytest.param(\n@@ -233,6 +238,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"name\": \"Foo\",\n \"steps\": [{\"name\": \"S\", \"script\": STEP_SCRIPT} for i in range(0, 2)],\n },\n+ 1,\n id=\"duplicate step names\",\n ),\n #\n@@ -243,6 +249,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"steps\": [STEP_TEMPLATE],\n \"parameterDefinitions\": [],\n },\n+ 1,\n id=\"empty parameters\",\n ),\n pytest.param(\n@@ -254,6 +261,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n {\"name\": f\"P{i}\", \"type\": \"INT\"} for i in range(0, 51)\n ],\n },\n+ 1,\n id=\"too many job parameters\",\n ),\n pytest.param(\n@@ -263,8 +271,42 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"steps\": [STEP_TEMPLATE],\n \"parameterDefinitions\": [{\"name\": \"P\", \"type\": \"INT\"} for i in range(0, 2)],\n },\n+ 1,\n id=\"duplicate parameter names\",\n ),\n+ pytest.param(\n+ {\n+ \"specificationVersion\": \"jobtemplate-2023-09\",\n+ \"name\": \"Foo\",\n+ \"steps\": [STEP_TEMPLATE],\n+ \"parameterDefinitions\": [\n+ {\n+ \"name\": \"foo\",\n+ },\n+ ],\n+ },\n+ # If the discriminator (\"type\" field) is missing then we should only see a single\n+ # error if the typed union discriminator is set up correctly. If it's not\n+ # set up correctly, then we'll get one error for every type in the union.\n+ 1,\n+ id=\"discriminator missing\",\n+ ),\n+ pytest.param(\n+ {\n+ \"specificationVersion\": \"jobtemplate-2023-09\",\n+ \"name\": \"Foo\",\n+ \"steps\": [STEP_TEMPLATE],\n+ \"parameterDefinitions\": [\n+ {\"name\": \"foo\", \"type\": \"INT\", \"default\": \"nine\"},\n+ ],\n+ },\n+ # If have a single error in the parameter definition and the Union discriminator\n+ # is set up correctly, then we should only see a single error for the field in\n+ # the specific Unioned type. If it's not set up correctly, then we'll\n+ # see at least an error from each type in the Union.\n+ 1,\n+ id=\"discriminator works\",\n+ ),\n #\n pytest.param(\n {\n@@ -273,6 +315,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"steps\": [STEP_TEMPLATE],\n \"jobEnvironments\": [],\n },\n+ 1,\n id=\"empty environments\",\n ),\n pytest.param(\n@@ -282,6 +325,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n \"steps\": [STEP_TEMPLATE],\n \"jobEnvironments\": [{\"name\": \"E\", \"script\": ENV_SCRIPT} for i in range(0, 2)],\n },\n+ 1,\n id=\"duplicate environment names\",\n ),\n pytest.param(\n@@ -306,6 +350,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n },\n ],\n },\n+ 1,\n id=\"with step dependency cycle\",\n ),\n pytest.param(\n@@ -324,6 +369,7 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n },\n ],\n },\n+ 1,\n id=\"refs unknown step\",\n ),\n pytest.param(\n@@ -351,11 +397,12 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n {\"name\": \"B0\", \"script\": ENV_SCRIPT},\n ],\n },\n+ 2,\n id=\"step env name duplicates job env name\",\n ),\n ),\n )\n- def test_parse_fails(self, data: dict[str, Any]) -> None:\n+ def test_parse_fails(self, data: dict[str, Any], expected_num_errors: int) -> None:\n # Failure case testing for Open Job Description JobTemplate.\n # - Constraint tests\n # - extra field test\n@@ -365,4 +412,4 @@ def test_parse_fails(self, data: dict[str, Any]) -> None:\n _parse_model(model=JobTemplate, obj=data)\n \n # THEN\n- assert len(excinfo.value.errors()) > 0\n+ assert len(excinfo.value.errors()) == expected_num_errors"}, {"sha": "cf07fa2b337ea14864bcc2eda5f6248e10298b8e", "filename": "test/openjd/model/v2023_09/test_parameter_space.py", "status": "modified", "additions": 25, "deletions": 0, "changes": 25, "blob_url": "https://github.com/OpenJobDescription/openjd-model-for-python/blob/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/test%2Fopenjd%2Fmodel%2Fv2023_09%2Ftest_parameter_space.py", "raw_url": "https://github.com/OpenJobDescription/openjd-model-for-python/raw/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e/test%2Fopenjd%2Fmodel%2Fv2023_09%2Ftest_parameter_space.py", "contents_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contents/test%2Fopenjd%2Fmodel%2Fv2023_09%2Ftest_parameter_space.py?ref=ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "patch": "@@ -452,6 +452,31 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n 1,\n id=\"duplicate parameter name\",\n ),\n+ pytest.param(\n+ {\n+ \"taskParameterDefinitions\": [\n+ {\"name\": \"foo\", \"range\": [1]},\n+ ]\n+ },\n+ # If the discriminator (\"type\" field) is missing then we should only see a single\n+ # error if the typed union discriminator is set up correctly. If it's not\n+ # set up correctly, then we'll get one error for every type in the union.\n+ 1,\n+ id=\"discriminator missing\",\n+ ),\n+ pytest.param(\n+ {\n+ \"taskParameterDefinitions\": [\n+ {\"name\": \"foo\", \"type\": \"INT\"},\n+ ]\n+ },\n+ # If we're missing a required field (\"range\") and the Union discriminator\n+ # is set up correctly, then we should only see a single error for the field being\n+ # missing in the specific Unioned type. If it's not set up correctly, then we'll\n+ # see at least an error from each type in the Union.\n+ 1,\n+ id=\"discriminator works\",\n+ ),\n pytest.param(\n {\n \"taskParameterDefinitions\": ["}]}} |
| {"time": "2023-09-13T14:46:17+00:00", "type": "timeline:committed", "payload": {"sha": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "node_id": "C_kwDOKNhT9doAKGVjNWZmNGUwOGJiZGY3YTgwOGZkY2NhYWM4ODBiN2VmYjYyYzg2M2U", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/commits/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/commit/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "author": {"name": "Daniel Neilson", "email": "53624638+ddneilson@users.noreply.github.com", "date": "2023-09-13T14:46:17Z"}, "committer": {"name": "Daniel Neilson", "email": "53624638+ddneilson@users.noreply.github.com", "date": "2023-09-14T05:05:13Z"}, "tree": {"sha": "9df1a462b3af53107ba240c4a1638af9b0dd0bbe", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/trees/9df1a462b3af53107ba240c4a1638af9b0dd0bbe"}, "message": "fix: make typed union disciminators function correctly\n\nThis corrects two errors in the way that typed union disciminators were\nimplemented in the model:\n1. discriminator was spelled incorrectly (\"desciminator\") causing no\n discriminators to be active in the model; and\n2. discriminators for collections of unions were defined incorrectly --\n they need to be annotated on the element rather than applied to the\n collecttion field.\n\nSigned-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>", "parents": [{"sha": "47ea9598c25741833bf23bfa9c07687b987c9a1f", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/commits/47ea9598c25741833bf23bfa9c07687b987c9a1f", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/commit/47ea9598c25741833bf23bfa9c07687b987c9a1f"}], "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}, "event": "committed"}} |
| {"time": "2023-09-13T15:34:14+00:00", "type": "pr", "payload": {"url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "id": 1514128531, "node_id": "PR_kwDOKNhT9c5aP8ST", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12", "diff_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12.diff", "patch_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12.patch", "issue_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/12", "number": 12, "state": "closed", "locked": false, "title": "fix: make typed union disciminators function correctly", "user": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "\r\n### What was the problem/requirement? (What/Why)\r\n\r\nModel validation errors were much too verbose. If an error was made in a typed union, then you would see at least one error (often at least 2) for each type in the union when you should only see one for the specific union type that is applicable.\r\n\r\n### What was the solution? (How)\r\n\r\nThis corrects two errors in the way that typed union disciminators were implemented in the model:\r\n1. discriminator was spelled incorrectly (\"desciminator\") causing no discriminators to be active in the model; and\r\n2. discriminators for collections of unions were defined incorrectly -- they need to be annotated on the element rather than applied to the collecttion field.\r\n\r\n### What is the impact of this change?\r\n\r\nValidation error messages are much easier to grok. The work's not done, but this is a step in the right direction.\r\n\r\n### How was this change tested?\r\n\r\nUnit tests, and manually via the cli `check` command.\r\n\r\nAs a sample, given:\r\n\r\n```yaml\r\nspecificationVersion: 'jobtemplate-2023-09'\r\nname: Test template\r\nparameterDefinitions:\r\n - name: LineEditControl\r\n type: STRING\r\n userInterface:\r\n control: LINE__EDIT # LINE_EDIT\r\n label: Line Edit Control\r\n groupLabel: Text Controls\r\n description: \"Unrestricted line of text!\"\r\n default: Default line edit value.\r\n - name: MultiLineEditControl\r\n type: STRING\r\n userInterface:\r\n control: MULTILINE__EDIT # MULTILINE_EDIT\r\n label: Multi-line Edit Control\r\n groupLabel: Text Controls\r\n description: \"Unrestricted text file\"\r\n default: |\r\n This is a\r\n text file with\r\n multiple lines.\r\n - name: IntSpinner\r\n # type: INT\r\n userInterface:\r\n control: SPIN_BOX\r\n label: Default Int Spinner\r\n groupLabel: Int Spinners\r\n description: A default integer spinner.\r\n default: 42\r\nsteps:\r\n- name: Step\r\n parameterSpace:\r\n taskParameterDefinitions:\r\n - name: p1\r\n # type: INT\r\n range: 1-10\r\n - name: p2\r\n type: STRING\r\n range:\r\n - \"foo\"\r\n - \"bar\"\r\n - name: p3\r\n type: FLOAT\r\n # range: \r\n - name: p4\r\n type: INT\r\n # range: \r\n script:\r\n embeddedFiles:\r\n - name: runScript\r\n type: TEXT\r\n runnable: true\r\n data: |\r\n #!/usr/bin/env bash\r\n\r\n echo 'LineEditControl value:'\r\n echo '{{Param.LineEditControl}}'\r\n\r\n echo 'ConstrainedLine value\"'\r\n # For testing: This value doesn't exist\r\n echo '{{Param.ConstrainedLine}}'\r\n\r\n echo 'MultiLineEditControl value:'\r\n echo '{{Param.MultiLineEditControl}}'\r\n\r\n actions:\r\n onRun:\r\n command: '{{Task.File.runScript}}'\r\n```\r\n\r\nBefore the change we get:\r\n```bash\r\n% openjd check ../test.yaml\r\nERROR: '../test.yaml' failed checks: 47 validation errors for JobTemplate\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 0 -> type\r\n field required (type=value_error.missing)\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 0 -> type\r\n field required (type=value_error.missing)\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 0 -> range\r\n value is not a valid list (type=type_error.list)\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 0 -> type\r\n... and so on\r\n```\r\n\r\nAfter this change we get:\r\n```bash\r\n% openjd check ../test.yaml \r\nERROR: '../test.yaml' failed checks: 6 validation errors for JobTemplate\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 0\r\n Discriminator 'type' is missing in value (type=value_error.discriminated_union.missing_discriminator; discriminator_key=type)\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 2 -> FloatTaskParameterDefinition -> range\r\n field required (type=value_error.missing)\r\nsteps -> 0 -> parameterSpace -> taskParameterDefinitions -> 3 -> IntTaskParameterDefinition -> range\r\n field required (type=value_error.missing)\r\nparameterDefinitions -> 0 -> JobStringParameterDefinition -> userInterface -> control\r\n value is not a valid enumeration member; permitted: 'LINE_EDIT', 'MULTILINE_EDIT', 'DROPDOWN_LIST', 'CHECK_BOX', 'HIDDEN' (type=type_error.enum; enum_values=[<StringUserInterfaceControl.LINE_EDIT: 'LINE_EDIT'>, <StringUserInterfaceControl.MULTILINE_EDIT: 'MULTILINE_EDIT'>, <StringUserInterfaceControl.DROPDOWN_LIST: 'DROPDOWN_LIST'>, <StringUserInterfaceControl.CHECK_BOX: 'CHECK_BOX'>, <StringUserInterfaceControl.HIDDEN: 'HIDDEN'>])\r\nparameterDefinitions -> 1 -> JobStringParameterDefinition -> userInterface -> control\r\n value is not a valid enumeration member; permitted: 'LINE_EDIT', 'MULTILINE_EDIT', 'DROPDOWN_LIST', 'CHECK_BOX', 'HIDDEN' (type=type_error.enum; enum_values=[<StringUserInterfaceControl.LINE_EDIT: 'LINE_EDIT'>, <StringUserInterfaceControl.MULTILINE_EDIT: 'MULTILINE_EDIT'>, <StringUserInterfaceControl.DROPDOWN_LIST: 'DROPDOWN_LIST'>, <StringUserInterfaceControl.CHECK_BOX: 'CHECK_BOX'>, <StringUserInterfaceControl.HIDDEN: 'HIDDEN'>])\r\nparameterDefinitions -> 2\r\n Discriminator 'type' is missing in value (type=value_error.discriminated_union.missing_discriminator; discriminator_key=type)\r\n```\r\n\r\n### Was this change documented?\r\n\r\nN/A\r\n\r\n### Is this a breaking change?\r\n\r\nNo\r\n----\r\n\r\n*By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.*", "created_at": "2023-09-13T15:34:14Z", "updated_at": "2023-09-14T18:08:58Z", "closed_at": "2023-09-14T18:08:54Z", "merged_at": "2023-09-14T18:08:53Z", "merge_commit_sha": "55982f393e6e12c5b5f78f0ec1f59ce797d29770", "assignees": [], "requested_reviewers": [], "requested_teams": [], "labels": [], "milestone": null, "draft": false, "commits_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12/commits", "review_comments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12/comments", "review_comment_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/comments{/number}", "comments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/12/comments", "statuses_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/statuses/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "head": {"label": "OpenJobDescription:ddneilson/B9629_discriminator", "ref": "ddneilson/B9629_discriminator", "sha": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "user": {"login": "OpenJobDescription", "id": 142452466, "node_id": "O_kgDOCH2m8g", "avatar_url": "https://avatars.githubusercontent.com/u/142452466?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OpenJobDescription", "html_url": "https://github.com/OpenJobDescription", "followers_url": "https://api.github.com/users/OpenJobDescription/followers", "following_url": "https://api.github.com/users/OpenJobDescription/following{/other_user}", "gists_url": "https://api.github.com/users/OpenJobDescription/gists{/gist_id}", "starred_url": "https://api.github.com/users/OpenJobDescription/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OpenJobDescription/subscriptions", "organizations_url": "https://api.github.com/users/OpenJobDescription/orgs", "repos_url": "https://api.github.com/users/OpenJobDescription/repos", "events_url": "https://api.github.com/users/OpenJobDescription/events{/privacy}", "received_events_url": "https://api.github.com/users/OpenJobDescription/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "repo": {"id": 685265909, "node_id": "R_kgDOKNhT9Q", "name": "openjd-model-for-python", "full_name": "OpenJobDescription/openjd-model-for-python", "private": false, "owner": {"login": "OpenJobDescription", "id": 142452466, "node_id": "O_kgDOCH2m8g", "avatar_url": "https://avatars.githubusercontent.com/u/142452466?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OpenJobDescription", "html_url": "https://github.com/OpenJobDescription", "followers_url": "https://api.github.com/users/OpenJobDescription/followers", "following_url": "https://api.github.com/users/OpenJobDescription/following{/other_user}", "gists_url": "https://api.github.com/users/OpenJobDescription/gists{/gist_id}", "starred_url": "https://api.github.com/users/OpenJobDescription/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OpenJobDescription/subscriptions", "organizations_url": "https://api.github.com/users/OpenJobDescription/orgs", "repos_url": "https://api.github.com/users/OpenJobDescription/repos", "events_url": "https://api.github.com/users/OpenJobDescription/events{/privacy}", "received_events_url": "https://api.github.com/users/OpenJobDescription/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python", "description": "Provides a Python implementation of the data model for Open Job Description's template schemas.", "fork": false, "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python", "forks_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/forks", "keys_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/teams", "hooks_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/hooks", "issue_events_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events{/number}", "events_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/events", "assignees_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/assignees{/user}", "branches_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/branches{/branch}", "tags_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/tags", "blobs_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/refs{/sha}", "trees_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/statuses/{sha}", "languages_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/languages", "stargazers_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/stargazers", "contributors_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contributors", "subscribers_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/subscribers", "subscription_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/subscription", "commits_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits{/sha}", "git_commits_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/commits{/sha}", "comments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/comments{/number}", "issue_comment_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/comments{/number}", "contents_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contents/{+path}", "compare_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/merges", "archive_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/downloads", "issues_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues{/number}", "pulls_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls{/number}", "milestones_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/milestones{/number}", "notifications_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/labels{/name}", "releases_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/releases{/id}", "deployments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/deployments", "created_at": "2023-08-30T21:28:48Z", "updated_at": "2026-05-19T19:09:34Z", "pushed_at": "2026-05-19T19:09:34Z", "git_url": "git://github.com/OpenJobDescription/openjd-model-for-python.git", "ssh_url": "git@github.com:OpenJobDescription/openjd-model-for-python.git", "clone_url": "https://github.com/OpenJobDescription/openjd-model-for-python.git", "svn_url": "https://github.com/OpenJobDescription/openjd-model-for-python", "homepage": "https://github.com/OpenJobDescription/openjd-specifications/wiki", "size": 488, "stargazers_count": 12, "watchers_count": 12, "language": "Python", "has_issues": true, "has_projects": true, "has_downloads": true, "has_wiki": false, "has_pages": false, "has_discussions": false, "forks_count": 20, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 9, "license": {"key": "apache-2.0", "name": "Apache License 2.0", "spdx_id": "Apache-2.0", "url": "https://api.github.com/licenses/apache-2.0", "node_id": "MDc6TGljZW5zZTI="}, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "has_pull_requests": true, "pull_request_creation_policy": "all", "topics": [], "visibility": "public", "forks": 20, "open_issues": 9, "watchers": 12, "default_branch": "mainline"}}, "base": {"label": "OpenJobDescription:mainline", "ref": "mainline", "sha": "47ea9598c25741833bf23bfa9c07687b987c9a1f", "user": {"login": "OpenJobDescription", "id": 142452466, "node_id": "O_kgDOCH2m8g", "avatar_url": "https://avatars.githubusercontent.com/u/142452466?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OpenJobDescription", "html_url": "https://github.com/OpenJobDescription", "followers_url": "https://api.github.com/users/OpenJobDescription/followers", "following_url": "https://api.github.com/users/OpenJobDescription/following{/other_user}", "gists_url": "https://api.github.com/users/OpenJobDescription/gists{/gist_id}", "starred_url": "https://api.github.com/users/OpenJobDescription/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OpenJobDescription/subscriptions", "organizations_url": "https://api.github.com/users/OpenJobDescription/orgs", "repos_url": "https://api.github.com/users/OpenJobDescription/repos", "events_url": "https://api.github.com/users/OpenJobDescription/events{/privacy}", "received_events_url": "https://api.github.com/users/OpenJobDescription/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "repo": {"id": 685265909, "node_id": "R_kgDOKNhT9Q", "name": "openjd-model-for-python", "full_name": "OpenJobDescription/openjd-model-for-python", "private": false, "owner": {"login": "OpenJobDescription", "id": 142452466, "node_id": "O_kgDOCH2m8g", "avatar_url": "https://avatars.githubusercontent.com/u/142452466?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OpenJobDescription", "html_url": "https://github.com/OpenJobDescription", "followers_url": "https://api.github.com/users/OpenJobDescription/followers", "following_url": "https://api.github.com/users/OpenJobDescription/following{/other_user}", "gists_url": "https://api.github.com/users/OpenJobDescription/gists{/gist_id}", "starred_url": "https://api.github.com/users/OpenJobDescription/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OpenJobDescription/subscriptions", "organizations_url": "https://api.github.com/users/OpenJobDescription/orgs", "repos_url": "https://api.github.com/users/OpenJobDescription/repos", "events_url": "https://api.github.com/users/OpenJobDescription/events{/privacy}", "received_events_url": "https://api.github.com/users/OpenJobDescription/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python", "description": "Provides a Python implementation of the data model for Open Job Description's template schemas.", "fork": false, "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python", "forks_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/forks", "keys_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/teams", "hooks_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/hooks", "issue_events_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events{/number}", "events_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/events", "assignees_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/assignees{/user}", "branches_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/branches{/branch}", "tags_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/tags", "blobs_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/refs{/sha}", "trees_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/statuses/{sha}", "languages_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/languages", "stargazers_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/stargazers", "contributors_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contributors", "subscribers_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/subscribers", "subscription_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/subscription", "commits_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits{/sha}", "git_commits_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/git/commits{/sha}", "comments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/comments{/number}", "issue_comment_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/comments{/number}", "contents_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/contents/{+path}", "compare_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/merges", "archive_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/downloads", "issues_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues{/number}", "pulls_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls{/number}", "milestones_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/milestones{/number}", "notifications_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/labels{/name}", "releases_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/releases{/id}", "deployments_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/deployments", "created_at": "2023-08-30T21:28:48Z", "updated_at": "2026-05-19T19:09:34Z", "pushed_at": "2026-05-19T19:09:34Z", "git_url": "git://github.com/OpenJobDescription/openjd-model-for-python.git", "ssh_url": "git@github.com:OpenJobDescription/openjd-model-for-python.git", "clone_url": "https://github.com/OpenJobDescription/openjd-model-for-python.git", "svn_url": "https://github.com/OpenJobDescription/openjd-model-for-python", "homepage": "https://github.com/OpenJobDescription/openjd-specifications/wiki", "size": 488, "stargazers_count": 12, "watchers_count": 12, "language": "Python", "has_issues": true, "has_projects": true, "has_downloads": true, "has_wiki": false, "has_pages": false, "has_discussions": false, "forks_count": 20, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 9, "license": {"key": "apache-2.0", "name": "Apache License 2.0", "spdx_id": "Apache-2.0", "url": "https://api.github.com/licenses/apache-2.0", "node_id": "MDc6TGljZW5zZTI="}, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "has_pull_requests": true, "pull_request_creation_policy": "all", "topics": [], "visibility": "public", "forks": 20, "open_issues": 9, "watchers": 12, "default_branch": "mainline"}}, "_links": {"self": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}, "html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12"}, "issue": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/12"}, "comments": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/12/comments"}, "review_comments": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12/comments"}, "review_comment": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/comments{/number}"}, "commits": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12/commits"}, "statuses": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/statuses/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e"}}, "author_association": "CONTRIBUTOR", "auto_merge": null, "assignee": null, "active_lock_reason": null, "merged": true, "mergeable": null, "rebaseable": null, "mergeable_state": "unknown", "merged_by": {"login": "mwiebe", "id": 399551, "node_id": "MDQ6VXNlcjM5OTU1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/399551?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mwiebe", "html_url": "https://github.com/mwiebe", "followers_url": "https://api.github.com/users/mwiebe/followers", "following_url": "https://api.github.com/users/mwiebe/following{/other_user}", "gists_url": "https://api.github.com/users/mwiebe/gists{/gist_id}", "starred_url": "https://api.github.com/users/mwiebe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mwiebe/subscriptions", "organizations_url": "https://api.github.com/users/mwiebe/orgs", "repos_url": "https://api.github.com/users/mwiebe/repos", "events_url": "https://api.github.com/users/mwiebe/events{/privacy}", "received_events_url": "https://api.github.com/users/mwiebe/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "comments": 0, "review_comments": 1, "maintainer_can_modify": false, "commits": 1, "additions": 99, "deletions": 19, "changed_files": 3}} |
| {"time": "2023-09-13T15:34:15+00:00", "type": "timeline:review_requested", "payload": {"id": 10361317521, "node_id": "RRE_lADOKNhT9c5w8CahzwAAAAJplSiR", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10361317521", "actor": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "review_requested", "commit_id": null, "commit_url": null, "created_at": "2023-09-13T15:34:15Z", "review_requester": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "requested_team": {"name": "Developers", "id": 8513209, "node_id": "T_kwDOCH2m8s4Agea5", "slug": "developers", "description": "", "privacy": "closed", "notification_setting": "notifications_enabled", "url": "https://api.github.com/organizations/142452466/team/8513209", "html_url": "https://github.com/orgs/OpenJobDescription/teams/developers", "members_url": "https://api.github.com/organizations/142452466/team/8513209/members{/member}", "repositories_url": "https://api.github.com/organizations/142452466/team/8513209/repos", "type": "organization", "organization_id": 142452466, "permission": "push", "permissions": {"admin": false, "maintain": false, "push": true, "triage": true, "pull": true}, "parent": null}, "performed_via_github_app": null}} |
| {"time": "2023-09-13T17:12:25+00:00", "type": "review", "payload": {"id": 1625045341, "node_id": "PRR_kwDOKNhT9c5g3Dld", "user": {"login": "AWS-Samuel", "id": 119458760, "node_id": "U_kgDOBx7LyA", "avatar_url": "https://avatars.githubusercontent.com/u/119458760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AWS-Samuel", "html_url": "https://github.com/AWS-Samuel", "followers_url": "https://api.github.com/users/AWS-Samuel/followers", "following_url": "https://api.github.com/users/AWS-Samuel/following{/other_user}", "gists_url": "https://api.github.com/users/AWS-Samuel/gists{/gist_id}", "starred_url": "https://api.github.com/users/AWS-Samuel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AWS-Samuel/subscriptions", "organizations_url": "https://api.github.com/users/AWS-Samuel/orgs", "repos_url": "https://api.github.com/users/AWS-Samuel/repos", "events_url": "https://api.github.com/users/AWS-Samuel/events{/privacy}", "received_events_url": "https://api.github.com/users/AWS-Samuel/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "DISMISSED", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625045341", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625045341"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-13T17:12:25Z", "commit_id": "dec75b198f23779aa3378cde2486fa85386fa4f1"}} |
| {"time": "2023-09-13T17:12:25+00:00", "type": "timeline:reviewed", "payload": {"id": 1625045341, "node_id": "PRR_kwDOKNhT9c5g3Dld", "user": {"login": "AWS-Samuel", "id": 119458760, "node_id": "U_kgDOBx7LyA", "avatar_url": "https://avatars.githubusercontent.com/u/119458760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AWS-Samuel", "html_url": "https://github.com/AWS-Samuel", "followers_url": "https://api.github.com/users/AWS-Samuel/followers", "following_url": "https://api.github.com/users/AWS-Samuel/following{/other_user}", "gists_url": "https://api.github.com/users/AWS-Samuel/gists{/gist_id}", "starred_url": "https://api.github.com/users/AWS-Samuel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AWS-Samuel/subscriptions", "organizations_url": "https://api.github.com/users/AWS-Samuel/orgs", "repos_url": "https://api.github.com/users/AWS-Samuel/repos", "events_url": "https://api.github.com/users/AWS-Samuel/events{/privacy}", "received_events_url": "https://api.github.com/users/AWS-Samuel/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "commit_id": "dec75b198f23779aa3378cde2486fa85386fa4f1", "state": "dismissed", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625045341", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625045341"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-13T17:12:25Z", "updated_at": "2023-09-14T05:05:26Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2023-09-14T05:01:21+00:00", "type": "review", "payload": {"id": 1625833702, "node_id": "PRR_kwDOKNhT9c5g6EDm", "user": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625833702", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625833702"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-14T05:01:21Z", "commit_id": "dec75b198f23779aa3378cde2486fa85386fa4f1"}} |
| {"time": "2023-09-14T05:01:21+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/comments/1325357059", "pull_request_review_id": 1625833702, "id": 1325357059, "node_id": "PRRC_kwDOKNhT9c5O_1gD", "diff_hunk": "@@ -351,11 +364,12 @@ def test_parse_success(self, data: dict[str, Any]) -> None:\n {\"name\": \"B0\", \"script\": ENV_SCRIPT},\n ],\n },\n+ 2,\n id=\"step env name duplicates job env name\",\n ),\n ),\n )\n- def test_parse_fails(self, data: dict[str, Any]) -> None:\n+ def test_parse_fails(self, data: dict[str, Any], expected_num_errors: int) -> None:", "path": "test/openjd/model/v2023_09/test_job_template.py", "commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "original_commit_id": "dec75b198f23779aa3378cde2486fa85386fa4f1", "user": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "I added all of the error counts in preparation of adding test cases like in the step's parameter space tests, but then didn't add the tests. Whoops!", "created_at": "2023-09-14T05:01:21Z", "updated_at": "2023-09-14T05:01:21Z", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#discussion_r1325357059", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "_links": {"self": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/comments/1325357059"}, "html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#discussion_r1325357059"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "reactions": {"url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/comments/1325357059/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": 405, "original_line": 405, "side": "RIGHT", "author_association": "CONTRIBUTOR", "original_position": 126, "position": 161, "subject_type": "line"}} |
| {"time": "2023-09-14T05:01:21+00:00", "type": "timeline:reviewed", "payload": {"id": 1625833702, "node_id": "PRR_kwDOKNhT9c5g6EDm", "user": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": null, "commit_id": "dec75b198f23779aa3378cde2486fa85386fa4f1", "state": "commented", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625833702", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1625833702"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-14T05:01:21Z", "updated_at": "2023-09-14T05:01:21Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2023-09-14T05:05:26+00:00", "type": "timeline:review_dismissed", "payload": {"id": 10367157960, "node_id": "RDE_lADOKNhT9c5w8CahzwAAAAJp7kbI", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10367157960", "actor": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "review_dismissed", "commit_id": null, "commit_url": null, "created_at": "2023-09-14T05:05:26Z", "dismissed_review": {"state": "approved", "review_id": 1625045341, "dismissal_message": null, "dismissal_commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e"}, "performed_via_github_app": null}} |
| {"time": "2023-09-14T05:05:26+00:00", "type": "timeline:head_ref_force_pushed", "payload": {"id": 10367157966, "node_id": "HRFPE_lADOKNhT9c5w8CahzwAAAAJp7kbO", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10367157966", "actor": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "head_ref_force_pushed", "commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "commit_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits/ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "created_at": "2023-09-14T05:05:26Z", "performed_via_github_app": null}} |
| {"time": "2023-09-14T13:46:50+00:00", "type": "timeline:review_requested", "payload": {"id": 10372593432, "node_id": "RRE_lADOKNhT9c5w8CahzwAAAAJqQTcY", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10372593432", "actor": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "review_requested", "commit_id": null, "commit_url": null, "created_at": "2023-09-14T13:46:50Z", "review_requester": {"login": "ddneilson", "id": 53624638, "node_id": "MDQ6VXNlcjUzNjI0NjM4", "avatar_url": "https://avatars.githubusercontent.com/u/53624638?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ddneilson", "html_url": "https://github.com/ddneilson", "followers_url": "https://api.github.com/users/ddneilson/followers", "following_url": "https://api.github.com/users/ddneilson/following{/other_user}", "gists_url": "https://api.github.com/users/ddneilson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ddneilson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ddneilson/subscriptions", "organizations_url": "https://api.github.com/users/ddneilson/orgs", "repos_url": "https://api.github.com/users/ddneilson/repos", "events_url": "https://api.github.com/users/ddneilson/events{/privacy}", "received_events_url": "https://api.github.com/users/ddneilson/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "requested_reviewer": {"login": "AWS-Samuel", "id": 119458760, "node_id": "U_kgDOBx7LyA", "avatar_url": "https://avatars.githubusercontent.com/u/119458760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AWS-Samuel", "html_url": "https://github.com/AWS-Samuel", "followers_url": "https://api.github.com/users/AWS-Samuel/followers", "following_url": "https://api.github.com/users/AWS-Samuel/following{/other_user}", "gists_url": "https://api.github.com/users/AWS-Samuel/gists{/gist_id}", "starred_url": "https://api.github.com/users/AWS-Samuel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AWS-Samuel/subscriptions", "organizations_url": "https://api.github.com/users/AWS-Samuel/orgs", "repos_url": "https://api.github.com/users/AWS-Samuel/repos", "events_url": "https://api.github.com/users/AWS-Samuel/events{/privacy}", "received_events_url": "https://api.github.com/users/AWS-Samuel/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "performed_via_github_app": null}} |
| {"time": "2023-09-14T16:35:04+00:00", "type": "review", "payload": {"id": 1627332862, "node_id": "PRR_kwDOKNhT9c5g_yD-", "user": {"login": "AWS-Samuel", "id": 119458760, "node_id": "U_kgDOBx7LyA", "avatar_url": "https://avatars.githubusercontent.com/u/119458760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AWS-Samuel", "html_url": "https://github.com/AWS-Samuel", "followers_url": "https://api.github.com/users/AWS-Samuel/followers", "following_url": "https://api.github.com/users/AWS-Samuel/following{/other_user}", "gists_url": "https://api.github.com/users/AWS-Samuel/gists{/gist_id}", "starred_url": "https://api.github.com/users/AWS-Samuel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AWS-Samuel/subscriptions", "organizations_url": "https://api.github.com/users/AWS-Samuel/orgs", "repos_url": "https://api.github.com/users/AWS-Samuel/repos", "events_url": "https://api.github.com/users/AWS-Samuel/events{/privacy}", "received_events_url": "https://api.github.com/users/AWS-Samuel/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "APPROVED", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627332862", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627332862"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-14T16:35:04Z", "commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e"}} |
| {"time": "2023-09-14T16:35:04+00:00", "type": "timeline:reviewed", "payload": {"id": 1627332862, "node_id": "PRR_kwDOKNhT9c5g_yD-", "user": {"login": "AWS-Samuel", "id": 119458760, "node_id": "U_kgDOBx7LyA", "avatar_url": "https://avatars.githubusercontent.com/u/119458760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AWS-Samuel", "html_url": "https://github.com/AWS-Samuel", "followers_url": "https://api.github.com/users/AWS-Samuel/followers", "following_url": "https://api.github.com/users/AWS-Samuel/following{/other_user}", "gists_url": "https://api.github.com/users/AWS-Samuel/gists{/gist_id}", "starred_url": "https://api.github.com/users/AWS-Samuel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AWS-Samuel/subscriptions", "organizations_url": "https://api.github.com/users/AWS-Samuel/orgs", "repos_url": "https://api.github.com/users/AWS-Samuel/repos", "events_url": "https://api.github.com/users/AWS-Samuel/events{/privacy}", "received_events_url": "https://api.github.com/users/AWS-Samuel/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "state": "approved", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627332862", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627332862"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-14T16:35:04Z", "updated_at": "2023-09-14T16:35:04Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2023-09-14T18:08:41+00:00", "type": "review", "payload": {"id": 1627494632, "node_id": "PRR_kwDOKNhT9c5hAZjo", "user": {"login": "mwiebe", "id": 399551, "node_id": "MDQ6VXNlcjM5OTU1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/399551?u=d4a592a0763568448a8eaa06b680ee9584a8c6e0&v=4", "gravatar_id": "", "url": "https://api.github.com/users/mwiebe", "html_url": "https://github.com/mwiebe", "followers_url": "https://api.github.com/users/mwiebe/followers", "following_url": "https://api.github.com/users/mwiebe/following{/other_user}", "gists_url": "https://api.github.com/users/mwiebe/gists{/gist_id}", "starred_url": "https://api.github.com/users/mwiebe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mwiebe/subscriptions", "organizations_url": "https://api.github.com/users/mwiebe/orgs", "repos_url": "https://api.github.com/users/mwiebe/repos", "events_url": "https://api.github.com/users/mwiebe/events{/privacy}", "received_events_url": "https://api.github.com/users/mwiebe/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "APPROVED", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627494632", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627494632"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-14T18:08:41Z", "commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e"}} |
| {"time": "2023-09-14T18:08:41+00:00", "type": "timeline:reviewed", "payload": {"id": 1627494632, "node_id": "PRR_kwDOKNhT9c5hAZjo", "user": {"login": "mwiebe", "id": 399551, "node_id": "MDQ6VXNlcjM5OTU1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/399551?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mwiebe", "html_url": "https://github.com/mwiebe", "followers_url": "https://api.github.com/users/mwiebe/followers", "following_url": "https://api.github.com/users/mwiebe/following{/other_user}", "gists_url": "https://api.github.com/users/mwiebe/gists{/gist_id}", "starred_url": "https://api.github.com/users/mwiebe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mwiebe/subscriptions", "organizations_url": "https://api.github.com/users/mwiebe/orgs", "repos_url": "https://api.github.com/users/mwiebe/repos", "events_url": "https://api.github.com/users/mwiebe/events{/privacy}", "received_events_url": "https://api.github.com/users/mwiebe/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "commit_id": "ec5ff4e08bbdf7a808fdccaac880b7efb62c863e", "state": "approved", "html_url": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627494632", "pull_request_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12", "_links": {"html": {"href": "https://github.com/OpenJobDescription/openjd-model-for-python/pull/12#pullrequestreview-1627494632"}, "pull_request": {"href": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/pulls/12"}}, "submitted_at": "2023-09-14T18:08:41Z", "updated_at": "2023-09-14T18:08:41Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2023-09-14T18:08:53+00:00", "type": "timeline:merged", "payload": {"id": 10375449452, "node_id": "ME_lADOKNhT9c5w8CahzwAAAAJqbMts", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10375449452", "actor": {"login": "mwiebe", "id": 399551, "node_id": "MDQ6VXNlcjM5OTU1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/399551?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mwiebe", "html_url": "https://github.com/mwiebe", "followers_url": "https://api.github.com/users/mwiebe/followers", "following_url": "https://api.github.com/users/mwiebe/following{/other_user}", "gists_url": "https://api.github.com/users/mwiebe/gists{/gist_id}", "starred_url": "https://api.github.com/users/mwiebe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mwiebe/subscriptions", "organizations_url": "https://api.github.com/users/mwiebe/orgs", "repos_url": "https://api.github.com/users/mwiebe/repos", "events_url": "https://api.github.com/users/mwiebe/events{/privacy}", "received_events_url": "https://api.github.com/users/mwiebe/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "merged", "commit_id": "55982f393e6e12c5b5f78f0ec1f59ce797d29770", "commit_url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/commits/55982f393e6e12c5b5f78f0ec1f59ce797d29770", "created_at": "2023-09-14T18:08:53Z", "performed_via_github_app": null}} |
| {"time": "2023-09-14T18:08:54+00:00", "type": "timeline:closed", "payload": {"id": 10375449469, "node_id": "CE_lADOKNhT9c5w8CahzwAAAAJqbMt9", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10375449469", "actor": {"login": "mwiebe", "id": 399551, "node_id": "MDQ6VXNlcjM5OTU1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/399551?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mwiebe", "html_url": "https://github.com/mwiebe", "followers_url": "https://api.github.com/users/mwiebe/followers", "following_url": "https://api.github.com/users/mwiebe/following{/other_user}", "gists_url": "https://api.github.com/users/mwiebe/gists{/gist_id}", "starred_url": "https://api.github.com/users/mwiebe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mwiebe/subscriptions", "organizations_url": "https://api.github.com/users/mwiebe/orgs", "repos_url": "https://api.github.com/users/mwiebe/repos", "events_url": "https://api.github.com/users/mwiebe/events{/privacy}", "received_events_url": "https://api.github.com/users/mwiebe/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "closed", "commit_id": null, "commit_url": null, "created_at": "2023-09-14T18:08:54Z", "state_reason": null, "performed_via_github_app": null}} |
| {"time": "2023-09-14T18:08:58+00:00", "type": "timeline:head_ref_deleted", "payload": {"id": 10375449970, "node_id": "HRDE_lADOKNhT9c5w8CahzwAAAAJqbM1y", "url": "https://api.github.com/repos/OpenJobDescription/openjd-model-for-python/issues/events/10375449970", "actor": {"login": "mwiebe", "id": 399551, "node_id": "MDQ6VXNlcjM5OTU1MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/399551?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mwiebe", "html_url": "https://github.com/mwiebe", "followers_url": "https://api.github.com/users/mwiebe/followers", "following_url": "https://api.github.com/users/mwiebe/following{/other_user}", "gists_url": "https://api.github.com/users/mwiebe/gists{/gist_id}", "starred_url": "https://api.github.com/users/mwiebe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mwiebe/subscriptions", "organizations_url": "https://api.github.com/users/mwiebe/orgs", "repos_url": "https://api.github.com/users/mwiebe/repos", "events_url": "https://api.github.com/users/mwiebe/events{/privacy}", "received_events_url": "https://api.github.com/users/mwiebe/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "head_ref_deleted", "commit_id": null, "commit_url": null, "created_at": "2023-09-14T18:08:58Z", "performed_via_github_app": null}} |
|
|
