| {"time": "2024-03-19T14:21:21+00:00", "type": "commit", "payload": {"sha": "5344696d02963939786c76732eb28b1c846024e3", "node_id": "C_kwDODAolhtoAKDUzNDQ2OTZkMDI5NjM5Mzk3ODZjNzY3MzJlYjI4YjFjODQ2MDI0ZTM", "commit": {"author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-19T14:21:21Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-19T14:21:21Z"}, "message": "Update matmul 4bit for ort>=1.17.0", "tree": {"sha": "dc1f1d3a145008d6fb8ffe717dd6ad5fd851dc86", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/dc1f1d3a145008d6fb8ffe717dd6ad5fd851dc86"}, "url": "https://api.github.com/repos/microsoft/Olive/git/commits/5344696d02963939786c76732eb28b1c846024e3", "comment_count": 0, "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}}, "url": "https://api.github.com/repos/microsoft/Olive/commits/5344696d02963939786c76732eb28b1c846024e3", "html_url": "https://github.com/microsoft/Olive/commit/5344696d02963939786c76732eb28b1c846024e3", "comments_url": "https://api.github.com/repos/microsoft/Olive/commits/5344696d02963939786c76732eb28b1c846024e3/comments", "author": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "committer": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "parents": [{"sha": "d736de8544c8e2dfaba55462af1b9c7ceca85b33", "url": "https://api.github.com/repos/microsoft/Olive/commits/d736de8544c8e2dfaba55462af1b9c7ceca85b33", "html_url": "https://github.com/microsoft/Olive/commit/d736de8544c8e2dfaba55462af1b9c7ceca85b33"}], "stats": {"total": 69, "additions": 65, "deletions": 4}, "files": [{"sha": "cecd357b8810dddbf91361a3bacd6c45de9f8402", "filename": "olive/passes/onnx/quantization.py", "status": "modified", "additions": 42, "deletions": 3, "changes": 45, "blob_url": "https://github.com/microsoft/Olive/blob/5344696d02963939786c76732eb28b1c846024e3/olive%2Fpasses%2Fonnx%2Fquantization.py", "raw_url": "https://github.com/microsoft/Olive/raw/5344696d02963939786c76732eb28b1c846024e3/olive%2Fpasses%2Fonnx%2Fquantization.py", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/olive%2Fpasses%2Fonnx%2Fquantization.py?ref=5344696d02963939786c76732eb28b1c846024e3", "patch": "@@ -594,6 +594,29 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon\n default_value=None,\n description=\"List of node names to exclude from quantization.\",\n ),\n+ \"accuracy_level\": PassConfigParam(\n+ type_=Any,\n+ default_value=None,\n+ description=\"Available from onnxruntime>=1.17.0 \"\n+ \"The minimum accuracy level of input A, can be: 0(unset), 1(fp32), 2(fp16), 3(bf16), \"\n+ \"or 4(int8) (default unset when 0 or None). It is used to control how input A is quantized or downcast \"\n+ \"internally while doing computation, for example: 0 means input A will not be quantized \"\n+ \"or downcast while doing computation. 4 means input A can be quantized with the same \"\n+ \"block_size to int8 internally from type T1. \"\n+ \"Refer to the MatMulNBits contrib op's 'accuracy_level' attribute for details \"\n+ \"(https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftmatmulnbits).\",\n+ ),\n+ \"algorithm\": PassConfigParam(\n+ type_=str,\n+ default_value=None,\n+ description=\"Available from onnxruntime>=1.17.0 \"\n+ \"Algorithm config for quantization, can be 'DEFAULT', 'HQQ' or 'RTN', 'GPTQ' \"\n+ \"(default DEFAULT when not set). For 4b quantize a model with RTN or GPTQ algorithm. \"\n+ \"Please refer to https://github.com/intel/neural-compressor/blob/master/docs/source/quantization_weight_only.md \" # noqa: E501\n+ \"for more details on weight only quantization using Intel\u00ae Neural Compressor. \"\n+ \"For HQQ, please refer to onnxruntime for more details: \"\n+ \"https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/python/tools/quantization/matmul_4bits_quantizer.py#L102C1-L126C25\",\n+ ),\n }\n config.update(get_external_data_config())\n return config\n@@ -610,9 +633,25 @@ def _run_for_config(\n \n output_model_path = resolve_onnx_path(output_model_path, Path(model.model_path).name)\n \n- quant = MatMul4BitsQuantizer(\n- model.load_model(), config[\"block_size\"], config[\"is_symmetric\"], config[\"nodes_to_exclude\"]\n- )\n+ if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n+ from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n+\n+ weight_only_quant_config = WeightOnlyQuantConfig(algorithm=config[\"algorithm\"])\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ accuracy_level=config[\"accuracy_level\"],\n+ algo_config=weight_only_quant_config,\n+ )\n+ else:\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ )\n quant.process()\n # topologically sort the graph at the end since previous optimizations may have broken it\n quant.model.topological_sort()"}, {"sha": "fa47b957803d872f95cd01a9bc01694ec1c7f6d2", "filename": "test/unit_test/passes/onnx/test_quantization.py", "status": "modified", "additions": 23, "deletions": 1, "changes": 24, "blob_url": "https://github.com/microsoft/Olive/blob/5344696d02963939786c76732eb28b1c846024e3/test%2Funit_test%2Fpasses%2Fonnx%2Ftest_quantization.py", "raw_url": "https://github.com/microsoft/Olive/raw/5344696d02963939786c76732eb28b1c846024e3/test%2Funit_test%2Fpasses%2Fonnx%2Ftest_quantization.py", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/test%2Funit_test%2Fpasses%2Fonnx%2Ftest_quantization.py?ref=5344696d02963939786c76732eb28b1c846024e3", "patch": "@@ -7,7 +7,7 @@\n \n from olive.hardware.accelerator import AcceleratorSpec\n from olive.passes.olive_pass import create_pass_from_dict\n-from olive.passes.onnx import OnnxQuantization, OnnxStaticQuantization\n+from olive.passes.onnx import OnnxMatMul4Quantizer, OnnxQuantization, OnnxStaticQuantization\n \n \n class DummyCalibrationDataReader(CalibrationDataReader):\n@@ -86,3 +86,25 @@ def test_qnn_quantization(tmp_path):\n p = create_pass_from_dict(OnnxStaticQuantization, config, disable_search=True, accelerator_spec=accelerator_spec)\n out = p.run(input_model, None, tmp_path)\n assert out is not None\n+\n+\n+@pytest.mark.skipif(\n+ version.parse(OrtVersion) < version.parse(\"1.16.2\"),\n+ reason=\"matmul 4bit quantization is only supported in onnxruntime>=1.16.2\",\n+)\n+def test_matmul_4bit_quantization(tmp_path):\n+ input_model = get_onnx_model()\n+ config = {\n+ \"block_size\": 32,\n+ \"is_symmetric\": True,\n+ \"nodes_to_exclude\": [],\n+ \"accuracy_level\": 4,\n+ \"algorithm\": \"DEFAULT\",\n+ }\n+ accelerator_spec = AcceleratorSpec(\n+ accelerator_type=\"CPU\",\n+ execution_provider=\"CPUExecutionProvider\",\n+ )\n+ p = create_pass_from_dict(OnnxMatMul4Quantizer, config, disable_search=True, accelerator_spec=accelerator_spec)\n+ out = p.run(input_model, None, tmp_path)\n+ assert out is not None"}]}} |
| {"time": "2024-03-19T14:21:21+00:00", "type": "timeline:committed", "payload": {"sha": "5344696d02963939786c76732eb28b1c846024e3", "node_id": "C_kwDODAolhtoAKDUzNDQ2OTZkMDI5NjM5Mzk3ODZjNzY3MzJlYjI4YjFjODQ2MDI0ZTM", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/5344696d02963939786c76732eb28b1c846024e3", "html_url": "https://github.com/microsoft/Olive/commit/5344696d02963939786c76732eb28b1c846024e3", "author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-19T14:21:21Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-19T14:21:21Z"}, "tree": {"sha": "dc1f1d3a145008d6fb8ffe717dd6ad5fd851dc86", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/dc1f1d3a145008d6fb8ffe717dd6ad5fd851dc86"}, "message": "Update matmul 4bit for ort>=1.17.0", "parents": [{"sha": "d736de8544c8e2dfaba55462af1b9c7ceca85b33", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/d736de8544c8e2dfaba55462af1b9c7ceca85b33", "html_url": "https://github.com/microsoft/Olive/commit/d736de8544c8e2dfaba55462af1b9c7ceca85b33"}], "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}, "event": "committed"}} |
| {"time": "2024-03-19T14:22:23+00:00", "type": "pr", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "id": 1780017385, "node_id": "PR_kwDODAolhs5qGOjp", "html_url": "https://github.com/microsoft/Olive/pull/1024", "diff_url": "https://github.com/microsoft/Olive/pull/1024.diff", "patch_url": "https://github.com/microsoft/Olive/pull/1024.patch", "issue_url": "https://api.github.com/repos/microsoft/Olive/issues/1024", "number": 1024, "state": "closed", "locked": false, "title": "\ud83c\udd99 Update matmul 4bit for ort>=1.17.0", "user": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "## Describe your changes\r\nUpdate arguments of matmul 4bit for ort>=1.17.0\r\n1. accuracy_level\r\n2. algorithm\r\n\r\n## Checklist before requesting a review\r\n- [x] Add unit tests for this change.\r\n- [ ] Make sure all tests can pass.\r\n- [ ] Update documents if necessary.\r\n- [ ] Lint and apply fixes to your code by running `lintrunner -a`\r\n- [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.\r\n- [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR.\r\n\r\n## (Optional) Issue link\r\n", "created_at": "2024-03-19T14:22:23Z", "updated_at": "2024-03-20T10:31:49Z", "closed_at": "2024-03-20T10:31:49Z", "merged_at": "2024-03-20T10:31:49Z", "merge_commit_sha": "d5c489ed60c91ea3ea9c1a28a90c2fe400e86bb1", "assignees": [], "requested_reviewers": [], "requested_teams": [], "labels": [], "milestone": null, "draft": false, "commits_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024/commits", "review_comments_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024/comments", "review_comment_url": "https://api.github.com/repos/microsoft/Olive/pulls/comments{/number}", "comments_url": "https://api.github.com/repos/microsoft/Olive/issues/1024/comments", "statuses_url": "https://api.github.com/repos/microsoft/Olive/statuses/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "head": {"label": "microsoft:jiapli/matmul_argus", "ref": "jiapli/matmul_argus", "sha": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "user": {"login": "microsoft", "id": 6154722, "node_id": "MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/6154722?v=4", "gravatar_id": "", "url": "https://api.github.com/users/microsoft", "html_url": "https://github.com/microsoft", "followers_url": "https://api.github.com/users/microsoft/followers", "following_url": "https://api.github.com/users/microsoft/following{/other_user}", "gists_url": "https://api.github.com/users/microsoft/gists{/gist_id}", "starred_url": "https://api.github.com/users/microsoft/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/microsoft/subscriptions", "organizations_url": "https://api.github.com/users/microsoft/orgs", "repos_url": "https://api.github.com/users/microsoft/repos", "events_url": "https://api.github.com/users/microsoft/events{/privacy}", "received_events_url": "https://api.github.com/users/microsoft/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "repo": {"id": 201991558, "node_id": "MDEwOlJlcG9zaXRvcnkyMDE5OTE1NTg=", "name": "Olive", "full_name": "microsoft/Olive", "private": false, "owner": {"login": "microsoft", "id": 6154722, "node_id": "MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/6154722?v=4", "gravatar_id": "", "url": "https://api.github.com/users/microsoft", "html_url": "https://github.com/microsoft", "followers_url": "https://api.github.com/users/microsoft/followers", "following_url": "https://api.github.com/users/microsoft/following{/other_user}", "gists_url": "https://api.github.com/users/microsoft/gists{/gist_id}", "starred_url": "https://api.github.com/users/microsoft/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/microsoft/subscriptions", "organizations_url": "https://api.github.com/users/microsoft/orgs", "repos_url": "https://api.github.com/users/microsoft/repos", "events_url": "https://api.github.com/users/microsoft/events{/privacy}", "received_events_url": "https://api.github.com/users/microsoft/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "html_url": "https://github.com/microsoft/Olive", "description": "Olive: Simplify ML Model Finetuning, Conversion, Quantization, and Optimization for CPUs, GPUs and NPUs.", "fork": false, "url": "https://api.github.com/repos/microsoft/Olive", "forks_url": "https://api.github.com/repos/microsoft/Olive/forks", "keys_url": "https://api.github.com/repos/microsoft/Olive/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/microsoft/Olive/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/microsoft/Olive/teams", "hooks_url": "https://api.github.com/repos/microsoft/Olive/hooks", "issue_events_url": "https://api.github.com/repos/microsoft/Olive/issues/events{/number}", "events_url": "https://api.github.com/repos/microsoft/Olive/events", "assignees_url": "https://api.github.com/repos/microsoft/Olive/assignees{/user}", "branches_url": "https://api.github.com/repos/microsoft/Olive/branches{/branch}", "tags_url": "https://api.github.com/repos/microsoft/Olive/tags", "blobs_url": "https://api.github.com/repos/microsoft/Olive/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/microsoft/Olive/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/microsoft/Olive/git/refs{/sha}", "trees_url": "https://api.github.com/repos/microsoft/Olive/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/microsoft/Olive/statuses/{sha}", "languages_url": "https://api.github.com/repos/microsoft/Olive/languages", "stargazers_url": "https://api.github.com/repos/microsoft/Olive/stargazers", "contributors_url": "https://api.github.com/repos/microsoft/Olive/contributors", "subscribers_url": "https://api.github.com/repos/microsoft/Olive/subscribers", "subscription_url": "https://api.github.com/repos/microsoft/Olive/subscription", "commits_url": "https://api.github.com/repos/microsoft/Olive/commits{/sha}", "git_commits_url": "https://api.github.com/repos/microsoft/Olive/git/commits{/sha}", "comments_url": "https://api.github.com/repos/microsoft/Olive/comments{/number}", "issue_comment_url": "https://api.github.com/repos/microsoft/Olive/issues/comments{/number}", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/{+path}", "compare_url": "https://api.github.com/repos/microsoft/Olive/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/microsoft/Olive/merges", "archive_url": "https://api.github.com/repos/microsoft/Olive/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/microsoft/Olive/downloads", "issues_url": "https://api.github.com/repos/microsoft/Olive/issues{/number}", "pulls_url": "https://api.github.com/repos/microsoft/Olive/pulls{/number}", "milestones_url": "https://api.github.com/repos/microsoft/Olive/milestones{/number}", "notifications_url": "https://api.github.com/repos/microsoft/Olive/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/microsoft/Olive/labels{/name}", "releases_url": "https://api.github.com/repos/microsoft/Olive/releases{/id}", "deployments_url": "https://api.github.com/repos/microsoft/Olive/deployments", "created_at": "2019-08-12T19:00:23Z", "updated_at": "2026-05-25T09:26:24Z", "pushed_at": "2026-05-26T19:27:21Z", "git_url": "git://github.com/microsoft/Olive.git", "ssh_url": "git@github.com:microsoft/Olive.git", "clone_url": "https://github.com/microsoft/Olive.git", "svn_url": "https://github.com/microsoft/Olive", "homepage": "https://microsoft.github.io/Olive/", "size": 171894, "stargazers_count": 2319, "watchers_count": 2319, "language": "Python", "has_issues": true, "has_projects": true, "has_downloads": true, "has_wiki": true, "has_pages": true, "has_discussions": true, "forks_count": 297, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 42, "license": {"key": "mit", "name": "MIT License", "spdx_id": "MIT", "url": "https://api.github.com/licenses/mit", "node_id": "MDc6TGljZW5zZTEz"}, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "has_pull_requests": true, "pull_request_creation_policy": "all", "topics": [], "visibility": "public", "forks": 297, "open_issues": 42, "watchers": 2319, "default_branch": "main"}}, "base": {"label": "microsoft:main", "ref": "main", "sha": "d736de8544c8e2dfaba55462af1b9c7ceca85b33", "user": {"login": "microsoft", "id": 6154722, "node_id": "MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/6154722?v=4", "gravatar_id": "", "url": "https://api.github.com/users/microsoft", "html_url": "https://github.com/microsoft", "followers_url": "https://api.github.com/users/microsoft/followers", "following_url": "https://api.github.com/users/microsoft/following{/other_user}", "gists_url": "https://api.github.com/users/microsoft/gists{/gist_id}", "starred_url": "https://api.github.com/users/microsoft/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/microsoft/subscriptions", "organizations_url": "https://api.github.com/users/microsoft/orgs", "repos_url": "https://api.github.com/users/microsoft/repos", "events_url": "https://api.github.com/users/microsoft/events{/privacy}", "received_events_url": "https://api.github.com/users/microsoft/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "repo": {"id": 201991558, "node_id": "MDEwOlJlcG9zaXRvcnkyMDE5OTE1NTg=", "name": "Olive", "full_name": "microsoft/Olive", "private": false, "owner": {"login": "microsoft", "id": 6154722, "node_id": "MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/6154722?v=4", "gravatar_id": "", "url": "https://api.github.com/users/microsoft", "html_url": "https://github.com/microsoft", "followers_url": "https://api.github.com/users/microsoft/followers", "following_url": "https://api.github.com/users/microsoft/following{/other_user}", "gists_url": "https://api.github.com/users/microsoft/gists{/gist_id}", "starred_url": "https://api.github.com/users/microsoft/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/microsoft/subscriptions", "organizations_url": "https://api.github.com/users/microsoft/orgs", "repos_url": "https://api.github.com/users/microsoft/repos", "events_url": "https://api.github.com/users/microsoft/events{/privacy}", "received_events_url": "https://api.github.com/users/microsoft/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false}, "html_url": "https://github.com/microsoft/Olive", "description": "Olive: Simplify ML Model Finetuning, Conversion, Quantization, and Optimization for CPUs, GPUs and NPUs.", "fork": false, "url": "https://api.github.com/repos/microsoft/Olive", "forks_url": "https://api.github.com/repos/microsoft/Olive/forks", "keys_url": "https://api.github.com/repos/microsoft/Olive/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/microsoft/Olive/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/microsoft/Olive/teams", "hooks_url": "https://api.github.com/repos/microsoft/Olive/hooks", "issue_events_url": "https://api.github.com/repos/microsoft/Olive/issues/events{/number}", "events_url": "https://api.github.com/repos/microsoft/Olive/events", "assignees_url": "https://api.github.com/repos/microsoft/Olive/assignees{/user}", "branches_url": "https://api.github.com/repos/microsoft/Olive/branches{/branch}", "tags_url": "https://api.github.com/repos/microsoft/Olive/tags", "blobs_url": "https://api.github.com/repos/microsoft/Olive/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/microsoft/Olive/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/microsoft/Olive/git/refs{/sha}", "trees_url": "https://api.github.com/repos/microsoft/Olive/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/microsoft/Olive/statuses/{sha}", "languages_url": "https://api.github.com/repos/microsoft/Olive/languages", "stargazers_url": "https://api.github.com/repos/microsoft/Olive/stargazers", "contributors_url": "https://api.github.com/repos/microsoft/Olive/contributors", "subscribers_url": "https://api.github.com/repos/microsoft/Olive/subscribers", "subscription_url": "https://api.github.com/repos/microsoft/Olive/subscription", "commits_url": "https://api.github.com/repos/microsoft/Olive/commits{/sha}", "git_commits_url": "https://api.github.com/repos/microsoft/Olive/git/commits{/sha}", "comments_url": "https://api.github.com/repos/microsoft/Olive/comments{/number}", "issue_comment_url": "https://api.github.com/repos/microsoft/Olive/issues/comments{/number}", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/{+path}", "compare_url": "https://api.github.com/repos/microsoft/Olive/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/microsoft/Olive/merges", "archive_url": "https://api.github.com/repos/microsoft/Olive/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/microsoft/Olive/downloads", "issues_url": "https://api.github.com/repos/microsoft/Olive/issues{/number}", "pulls_url": "https://api.github.com/repos/microsoft/Olive/pulls{/number}", "milestones_url": "https://api.github.com/repos/microsoft/Olive/milestones{/number}", "notifications_url": "https://api.github.com/repos/microsoft/Olive/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/microsoft/Olive/labels{/name}", "releases_url": "https://api.github.com/repos/microsoft/Olive/releases{/id}", "deployments_url": "https://api.github.com/repos/microsoft/Olive/deployments", "created_at": "2019-08-12T19:00:23Z", "updated_at": "2026-05-25T09:26:24Z", "pushed_at": "2026-05-26T19:27:21Z", "git_url": "git://github.com/microsoft/Olive.git", "ssh_url": "git@github.com:microsoft/Olive.git", "clone_url": "https://github.com/microsoft/Olive.git", "svn_url": "https://github.com/microsoft/Olive", "homepage": "https://microsoft.github.io/Olive/", "size": 171894, "stargazers_count": 2319, "watchers_count": 2319, "language": "Python", "has_issues": true, "has_projects": true, "has_downloads": true, "has_wiki": true, "has_pages": true, "has_discussions": true, "forks_count": 297, "mirror_url": null, "archived": false, "disabled": false, "open_issues_count": 42, "license": {"key": "mit", "name": "MIT License", "spdx_id": "MIT", "url": "https://api.github.com/licenses/mit", "node_id": "MDc6TGljZW5zZTEz"}, "allow_forking": true, "is_template": false, "web_commit_signoff_required": false, "has_pull_requests": true, "pull_request_creation_policy": "all", "topics": [], "visibility": "public", "forks": 297, "open_issues": 42, "watchers": 2319, "default_branch": "main"}}, "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024"}, "issue": {"href": "https://api.github.com/repos/microsoft/Olive/issues/1024"}, "comments": {"href": "https://api.github.com/repos/microsoft/Olive/issues/1024/comments"}, "review_comments": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024/comments"}, "review_comment": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments{/number}"}, "commits": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024/commits"}, "statuses": {"href": "https://api.github.com/repos/microsoft/Olive/statuses/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4"}}, "author_association": "CONTRIBUTOR", "auto_merge": null, "assignee": null, "active_lock_reason": null, "merged": true, "mergeable": null, "rebaseable": null, "mergeable_state": "unknown", "merged_by": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "comments": 1, "review_comments": 8, "maintainer_can_modify": false, "commits": 4, "additions": 115, "deletions": 4, "changed_files": 2}} |
| {"time": "2024-03-19T18:21:03+00:00", "type": "review", "payload": {"id": 1947041584, "node_id": "PRR_kwDODAolhs50DX8w", "user": {"login": "xiaoyu-work", "id": 85524621, "node_id": "MDQ6VXNlcjg1NTI0NjIx", "avatar_url": "https://avatars.githubusercontent.com/u/85524621?u=ce9518815001b11a1de44b6242b5181b017a3350&v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoyu-work", "html_url": "https://github.com/xiaoyu-work", "followers_url": "https://api.github.com/users/xiaoyu-work/followers", "following_url": "https://api.github.com/users/xiaoyu-work/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoyu-work/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoyu-work/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoyu-work/subscriptions", "organizations_url": "https://api.github.com/users/xiaoyu-work/orgs", "repos_url": "https://api.github.com/users/xiaoyu-work/repos", "events_url": "https://api.github.com/users/xiaoyu-work/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoyu-work/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947041584", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "COLLABORATOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947041584"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-19T18:21:03Z", "commit_id": "5344696d02963939786c76732eb28b1c846024e3"}} |
| {"time": "2024-03-19T18:21:03+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1530876604", "pull_request_review_id": 1947041584, "id": 1530876604, "node_id": "PRRC_kwDODAolhs5bP1K8", "diff_hunk": "@@ -594,6 +594,29 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon\n default_value=None,\n description=\"List of node names to exclude from quantization.\",\n ),\n+ \"accuracy_level\": PassConfigParam(\n+ type_=Any,", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "5344696d02963939786c76732eb28b1c846024e3", "user": {"login": "xiaoyu-work", "id": 85524621, "node_id": "MDQ6VXNlcjg1NTI0NjIx", "avatar_url": "https://avatars.githubusercontent.com/u/85524621?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoyu-work", "html_url": "https://github.com/xiaoyu-work", "followers_url": "https://api.github.com/users/xiaoyu-work/followers", "following_url": "https://api.github.com/users/xiaoyu-work/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoyu-work/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoyu-work/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoyu-work/subscriptions", "organizations_url": "https://api.github.com/users/xiaoyu-work/orgs", "repos_url": "https://api.github.com/users/xiaoyu-work/repos", "events_url": "https://api.github.com/users/xiaoyu-work/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoyu-work/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "Should this be `int`?", "created_at": "2024-03-19T18:21:03Z", "updated_at": "2024-03-19T18:21:03Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1530876604", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1530876604"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1530876604"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1530876604/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": null, "original_line": 598, "side": "RIGHT", "author_association": "COLLABORATOR", "original_position": 5, "position": 1, "subject_type": "line"}} |
| {"time": "2024-03-19T18:21:03+00:00", "type": "timeline:reviewed", "payload": {"id": 1947041584, "node_id": "PRR_kwDODAolhs50DX8w", "user": {"login": "xiaoyu-work", "id": 85524621, "node_id": "MDQ6VXNlcjg1NTI0NjIx", "avatar_url": "https://avatars.githubusercontent.com/u/85524621?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoyu-work", "html_url": "https://github.com/xiaoyu-work", "followers_url": "https://api.github.com/users/xiaoyu-work/followers", "following_url": "https://api.github.com/users/xiaoyu-work/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoyu-work/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoyu-work/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoyu-work/subscriptions", "organizations_url": "https://api.github.com/users/xiaoyu-work/orgs", "repos_url": "https://api.github.com/users/xiaoyu-work/repos", "events_url": "https://api.github.com/users/xiaoyu-work/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoyu-work/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": null, "commit_id": "5344696d02963939786c76732eb28b1c846024e3", "state": "commented", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947041584", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947041584"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-19T18:21:03Z", "updated_at": "2024-03-19T18:21:03Z", "author_association": "COLLABORATOR", "event": "reviewed"}} |
| {"time": "2024-03-19T18:23:29+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1530882108", "pull_request_review_id": 1947048944, "id": 1530882108, "node_id": "PRRC_kwDODAolhs5bP2g8", "diff_hunk": "@@ -594,6 +594,29 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon\n default_value=None,\n description=\"List of node names to exclude from quantization.\",\n ),\n+ \"accuracy_level\": PassConfigParam(\n+ type_=Any,\n+ default_value=None,\n+ description=\"Available from onnxruntime>=1.17.0 \"\n+ \"The minimum accuracy level of input A, can be: 0(unset), 1(fp32), 2(fp16), 3(bf16), \"\n+ \"or 4(int8) (default unset when 0 or None). It is used to control how input A is quantized or downcast \"\n+ \"internally while doing computation, for example: 0 means input A will not be quantized \"\n+ \"or downcast while doing computation. 4 means input A can be quantized with the same \"\n+ \"block_size to int8 internally from type T1. \"\n+ \"Refer to the MatMulNBits contrib op's 'accuracy_level' attribute for details \"\n+ \"(https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftmatmulnbits).\",\n+ ),\n+ \"algorithm\": PassConfigParam(", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "5344696d02963939786c76732eb28b1c846024e3", "user": {"login": "xiaoyu-work", "id": 85524621, "node_id": "MDQ6VXNlcjg1NTI0NjIx", "avatar_url": "https://avatars.githubusercontent.com/u/85524621?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoyu-work", "html_url": "https://github.com/xiaoyu-work", "followers_url": "https://api.github.com/users/xiaoyu-work/followers", "following_url": "https://api.github.com/users/xiaoyu-work/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoyu-work/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoyu-work/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoyu-work/subscriptions", "organizations_url": "https://api.github.com/users/xiaoyu-work/orgs", "repos_url": "https://api.github.com/users/xiaoyu-work/repos", "events_url": "https://api.github.com/users/xiaoyu-work/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoyu-work/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "What if the input str value is not desired? Will the api raise an error? Should we either add a value validation here, or having an enum class defined for validation for this value?", "created_at": "2024-03-19T18:23:29Z", "updated_at": "2024-03-19T18:24:04Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1530882108", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1530882108"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1530882108"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1530882108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": 611, "original_line": 609, "side": "RIGHT", "author_association": "COLLABORATOR", "original_position": 16, "position": 25, "subject_type": "line"}} |
| {"time": "2024-03-19T18:23:30+00:00", "type": "review", "payload": {"id": 1947048944, "node_id": "PRR_kwDODAolhs50DZvw", "user": {"login": "xiaoyu-work", "id": 85524621, "node_id": "MDQ6VXNlcjg1NTI0NjIx", "avatar_url": "https://avatars.githubusercontent.com/u/85524621?u=ce9518815001b11a1de44b6242b5181b017a3350&v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoyu-work", "html_url": "https://github.com/xiaoyu-work", "followers_url": "https://api.github.com/users/xiaoyu-work/followers", "following_url": "https://api.github.com/users/xiaoyu-work/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoyu-work/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoyu-work/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoyu-work/subscriptions", "organizations_url": "https://api.github.com/users/xiaoyu-work/orgs", "repos_url": "https://api.github.com/users/xiaoyu-work/repos", "events_url": "https://api.github.com/users/xiaoyu-work/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoyu-work/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947048944", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "COLLABORATOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947048944"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-19T18:23:30Z", "commit_id": "5344696d02963939786c76732eb28b1c846024e3"}} |
| {"time": "2024-03-19T18:23:30+00:00", "type": "timeline:reviewed", "payload": {"id": 1947048944, "node_id": "PRR_kwDODAolhs50DZvw", "user": {"login": "xiaoyu-work", "id": 85524621, "node_id": "MDQ6VXNlcjg1NTI0NjIx", "avatar_url": "https://avatars.githubusercontent.com/u/85524621?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoyu-work", "html_url": "https://github.com/xiaoyu-work", "followers_url": "https://api.github.com/users/xiaoyu-work/followers", "following_url": "https://api.github.com/users/xiaoyu-work/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoyu-work/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoyu-work/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoyu-work/subscriptions", "organizations_url": "https://api.github.com/users/xiaoyu-work/orgs", "repos_url": "https://api.github.com/users/xiaoyu-work/repos", "events_url": "https://api.github.com/users/xiaoyu-work/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoyu-work/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": null, "commit_id": "5344696d02963939786c76732eb28b1c846024e3", "state": "commented", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947048944", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947048944"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-19T18:23:30Z", "updated_at": "2024-03-19T18:23:30Z", "author_association": "COLLABORATOR", "event": "reviewed"}} |
| {"time": "2024-03-20T03:32:52+00:00", "type": "comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/issues/comments/2008611763", "html_url": "https://github.com/microsoft/Olive/pull/1024#issuecomment-2008611763", "issue_url": "https://api.github.com/repos/microsoft/Olive/issues/1024", "id": 2008611763, "node_id": "IC_kwDODAolhs53uPuz", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?u=bd502dd3d61efb3e3de08731a2c16da6372294ae&v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "created_at": "2024-03-20T03:32:52Z", "updated_at": "2024-03-20T03:32:52Z", "author_association": "CONTRIBUTOR", "body": "Any user requires this feature?", "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/issues/comments/2008611763/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "performed_via_github_app": null, "pin": null}} |
| {"time": "2024-03-20T03:32:52+00:00", "type": "timeline:commented", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/issues/comments/2008611763", "html_url": "https://github.com/microsoft/Olive/pull/1024#issuecomment-2008611763", "issue_url": "https://api.github.com/repos/microsoft/Olive/issues/1024", "id": 2008611763, "node_id": "IC_kwDODAolhs53uPuz", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "created_at": "2024-03-20T03:32:52Z", "updated_at": "2024-03-20T03:32:52Z", "body": "Any user requires this feature?", "author_association": "CONTRIBUTOR", "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/issues/comments/2008611763/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "performed_via_github_app": null, "event": "commented", "actor": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}}} |
| {"time": "2024-03-20T03:41:06+00:00", "type": "commit", "payload": {"sha": "604ccf841525bb9d578faf370e1c15da230bffb9", "node_id": "C_kwDODAolhtoAKDYwNGNjZjg0MTUyNWJiOWQ1NzhmYWYzNzBlMWMxNWRhMjMwYmZmYjk", "commit": {"author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T03:41:06Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T03:41:06Z"}, "message": "add validators", "tree": {"sha": "21255d6a6bd95a02d6b3c3fa25933fec61582e94", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/21255d6a6bd95a02d6b3c3fa25933fec61582e94"}, "url": "https://api.github.com/repos/microsoft/Olive/git/commits/604ccf841525bb9d578faf370e1c15da230bffb9", "comment_count": 0, "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}}, "url": "https://api.github.com/repos/microsoft/Olive/commits/604ccf841525bb9d578faf370e1c15da230bffb9", "html_url": "https://github.com/microsoft/Olive/commit/604ccf841525bb9d578faf370e1c15da230bffb9", "comments_url": "https://api.github.com/repos/microsoft/Olive/commits/604ccf841525bb9d578faf370e1c15da230bffb9/comments", "author": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "committer": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "parents": [{"sha": "5344696d02963939786c76732eb28b1c846024e3", "url": "https://api.github.com/repos/microsoft/Olive/commits/5344696d02963939786c76732eb28b1c846024e3", "html_url": "https://github.com/microsoft/Olive/commit/5344696d02963939786c76732eb28b1c846024e3"}], "stats": {"total": 60, "additions": 59, "deletions": 1}, "files": [{"sha": "41655c7ef62d99e443c1d2376738d647e50d441a", "filename": "olive/passes/onnx/quantization.py", "status": "modified", "additions": 38, "deletions": 1, "changes": 39, "blob_url": "https://github.com/microsoft/Olive/blob/604ccf841525bb9d578faf370e1c15da230bffb9/olive%2Fpasses%2Fonnx%2Fquantization.py", "raw_url": "https://github.com/microsoft/Olive/raw/604ccf841525bb9d578faf370e1c15da230bffb9/olive%2Fpasses%2Fonnx%2Fquantization.py", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/olive%2Fpasses%2Fonnx%2Fquantization.py?ref=604ccf841525bb9d578faf370e1c15da230bffb9", "patch": "@@ -13,6 +13,7 @@\n \n from olive.cache import get_local_path_from_root\n from olive.common.config_utils import validate_config\n+from olive.common.pydantic_v1 import validator\n from olive.common.utils import hash_string\n from olive.data.config import DataConfig\n from olive.exception import OlivePassError\n@@ -595,7 +596,8 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon\n description=\"List of node names to exclude from quantization.\",\n ),\n \"accuracy_level\": PassConfigParam(\n- type_=Any,\n+ # TODO(trajep): to make it searchable\n+ type_=int,\n default_value=None,\n description=\"Available from onnxruntime>=1.17.0 \"\n \"The minimum accuracy level of input A, can be: 0(unset), 1(fp32), 2(fp16), 3(bf16), \"\n@@ -621,6 +623,13 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon\n config.update(get_external_data_config())\n return config\n \n+ @classmethod\n+ def _validators(cls) -> Dict[str, Callable]:\n+ return {\n+ \"validate_accuracy_level\": validator(\"accuracy_level\", allow_reuse=True)(_validate_accuracy_level),\n+ \"validate_algorithm\": validator(\"algorithm\", allow_reuse=True)(_validate_algorithm),\n+ }\n+\n def _run_for_config(\n self, model: ONNXModelHandler, data_root: str, config: Dict[str, Any], output_model_path: str\n ) -> ONNXModelHandler:\n@@ -659,3 +668,31 @@ def _run_for_config(\n \n # save the model to the output path and return the model\n return model_proto_to_olive_model(quant.model.model, output_model_path, config)\n+\n+\n+def _validate_accuracy_level(v, values, field):\n+ if not v:\n+ return v\n+\n+ if v not in (0, 1, 2, 3, 4):\n+ raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 0(unset), 1(fp32), 2(fp16), 3(bf16) or 4(int8)\")\n+\n+ return v\n+\n+\n+def _validate_algorithm(v, values, field):\n+ if not v:\n+ return v\n+\n+ if v not in (\"DEFAULT\", \"HQQ\", \"RTN\", \"GPTQ\"):\n+ raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 'DEFAULT', 'HQQ', 'RTN', 'GPTQ'\")\n+\n+ if v in (\"RTN\", \"GPTQ\"):\n+ try:\n+ import neural_compressor # noqa: F401\n+ except ImportError:\n+ raise ImportError(\n+ f\"OnnxMatMul4Quantizer {field.name}={v} requires neural_compressor package to be installed\"\n+ ) from None\n+\n+ return v"}, {"sha": "b2f775182e3ad0995504160e62218bea0c63beec", "filename": "test/unit_test/passes/onnx/test_quantization.py", "status": "modified", "additions": 21, "deletions": 0, "changes": 21, "blob_url": "https://github.com/microsoft/Olive/blob/604ccf841525bb9d578faf370e1c15da230bffb9/test%2Funit_test%2Fpasses%2Fonnx%2Ftest_quantization.py", "raw_url": "https://github.com/microsoft/Olive/raw/604ccf841525bb9d578faf370e1c15da230bffb9/test%2Funit_test%2Fpasses%2Fonnx%2Ftest_quantization.py", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/test%2Funit_test%2Fpasses%2Fonnx%2Ftest_quantization.py?ref=604ccf841525bb9d578faf370e1c15da230bffb9", "patch": "@@ -5,6 +5,7 @@\n from onnxruntime.quantization.calibrate import CalibrationDataReader\n from packaging import version\n \n+from olive.common.pydantic_v1 import ValidationError\n from olive.hardware.accelerator import AcceleratorSpec\n from olive.passes.olive_pass import create_pass_from_dict\n from olive.passes.onnx import OnnxMatMul4Quantizer, OnnxQuantization, OnnxStaticQuantization\n@@ -108,3 +109,23 @@ def test_matmul_4bit_quantization(tmp_path):\n p = create_pass_from_dict(OnnxMatMul4Quantizer, config, disable_search=True, accelerator_spec=accelerator_spec)\n out = p.run(input_model, None, tmp_path)\n assert out is not None\n+\n+\n+@pytest.mark.skipif(\n+ version.parse(OrtVersion) < version.parse(\"1.16.2\"),\n+ reason=\"matmul 4bit quantization is only supported in onnxruntime>=1.16.2\",\n+)\n+def test_invalid_config_for_matmul_4bits():\n+ config = {\n+ \"block_size\": 32,\n+ \"is_symmetric\": True,\n+ \"nodes_to_exclude\": [],\n+ \"accuracy_level\": 5,\n+ \"algorithm\": \"TE\",\n+ }\n+ accelerator_spec = AcceleratorSpec(\n+ accelerator_type=\"CPU\",\n+ execution_provider=\"CPUExecutionProvider\",\n+ )\n+ with pytest.raises(ValidationError):\n+ create_pass_from_dict(OnnxMatMul4Quantizer, config, disable_search=True, accelerator_spec=accelerator_spec)"}]}} |
| {"time": "2024-03-20T03:41:06+00:00", "type": "timeline:committed", "payload": {"sha": "604ccf841525bb9d578faf370e1c15da230bffb9", "node_id": "C_kwDODAolhtoAKDYwNGNjZjg0MTUyNWJiOWQ1NzhmYWYzNzBlMWMxNWRhMjMwYmZmYjk", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/604ccf841525bb9d578faf370e1c15da230bffb9", "html_url": "https://github.com/microsoft/Olive/commit/604ccf841525bb9d578faf370e1c15da230bffb9", "author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T03:41:06Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T03:41:06Z"}, "tree": {"sha": "21255d6a6bd95a02d6b3c3fa25933fec61582e94", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/21255d6a6bd95a02d6b3c3fa25933fec61582e94"}, "message": "add validators", "parents": [{"sha": "5344696d02963939786c76732eb28b1c846024e3", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/5344696d02963939786c76732eb28b1c846024e3", "html_url": "https://github.com/microsoft/Olive/commit/5344696d02963939786c76732eb28b1c846024e3"}], "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}, "event": "committed"}} |
| {"time": "2024-03-20T03:41:32+00:00", "type": "review", "payload": {"id": 1947897093, "node_id": "PRR_kwDODAolhs50Go0F", "user": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?u=ab07a99edd81d7fd825251714b61b1fa968f0683&v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947897093", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947897093"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T03:41:32Z", "commit_id": "5344696d02963939786c76732eb28b1c846024e3"}} |
| {"time": "2024-03-20T03:41:32+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531478957", "pull_request_review_id": 1947897093, "id": 1531478957, "node_id": "PRRC_kwDODAolhs5bSIOt", "diff_hunk": "@@ -594,6 +594,29 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon\n default_value=None,\n description=\"List of node names to exclude from quantization.\",\n ),\n+ \"accuracy_level\": PassConfigParam(\n+ type_=Any,\n+ default_value=None,\n+ description=\"Available from onnxruntime>=1.17.0 \"\n+ \"The minimum accuracy level of input A, can be: 0(unset), 1(fp32), 2(fp16), 3(bf16), \"\n+ \"or 4(int8) (default unset when 0 or None). It is used to control how input A is quantized or downcast \"\n+ \"internally while doing computation, for example: 0 means input A will not be quantized \"\n+ \"or downcast while doing computation. 4 means input A can be quantized with the same \"\n+ \"block_size to int8 internally from type T1. \"\n+ \"Refer to the MatMulNBits contrib op's 'accuracy_level' attribute for details \"\n+ \"(https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftmatmulnbits).\",\n+ ),\n+ \"algorithm\": PassConfigParam(", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "5344696d02963939786c76732eb28b1c846024e3", "user": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "Updated.", "created_at": "2024-03-20T03:41:32Z", "updated_at": "2024-03-20T03:41:32Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531478957", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531478957"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531478957"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531478957/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": 611, "original_line": 609, "side": "RIGHT", "in_reply_to_id": 1530882108, "author_association": "CONTRIBUTOR", "original_position": 16, "position": 25, "subject_type": "line"}} |
| {"time": "2024-03-20T03:45:33+00:00", "type": "review", "payload": {"id": 1947899321, "node_id": "PRR_kwDODAolhs50GpW5", "user": {"login": "github-advanced-security[bot]", "id": 62310815, "node_id": "MDM6Qm90NjIzMTA4MTU=", "avatar_url": "https://avatars.githubusercontent.com/in/57789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-advanced-security%5Bbot%5D", "html_url": "https://github.com/apps/github-advanced-security", "followers_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947899321", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947899321"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T03:45:33Z", "commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9"}} |
| {"time": "2024-03-20T03:45:33+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531480443", "pull_request_review_id": 1947899321, "id": 1531480443, "node_id": "PRRC_kwDODAolhs5bSIl7", "diff_hunk": "@@ -610,13 +642,57 @@\n \n output_model_path = resolve_onnx_path(output_model_path, Path(model.model_path).name)\n \n- quant = MatMul4BitsQuantizer(\n- model.load_model(), config[\"block_size\"], config[\"is_symmetric\"], config[\"nodes_to_exclude\"]\n- )\n+ if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n+ from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n+\n+ weight_only_quant_config = WeightOnlyQuantConfig(algorithm=config[\"algorithm\"])\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ accuracy_level=config[\"accuracy_level\"],\n+ algo_config=weight_only_quant_config,\n+ )\n+ else:\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ )\n quant.process()\n # topologically sort the graph at the end since previous optimizations may have broken it\n quant.model.topological_sort()\n # quant.model._check_init is not needed since it's only meant for float8 quantization\n \n # save the model to the output path and return the model\n return model_proto_to_olive_model(quant.model.model, output_model_path, config)\n+\n+\n+def _validate_accuracy_level(v, values, field):\n+ if not v:\n+ return v\n+\n+ if v not in (0, 1, 2, 3, 4):\n+ raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 0(unset), 1(fp32), 2(fp16), 3(bf16) or 4(int8)\")\n+\n+ return v\n+\n+\n+def _validate_algorithm(v, values, field):\n+ if not v:\n+ return v\n+\n+ if v not in (\"DEFAULT\", \"HQQ\", \"RTN\", \"GPTQ\"):\n+ raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 'DEFAULT', 'HQQ', 'RTN', 'GPTQ'\")\n+\n+ if v in (\"RTN\", \"GPTQ\"):\n+ try:\n+ import neural_compressor # noqa: F401", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9", "user": {"login": "github-advanced-security[bot]", "id": 62310815, "node_id": "MDM6Qm90NjIzMTA4MTU=", "avatar_url": "https://avatars.githubusercontent.com/in/57789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-advanced-security%5Bbot%5D", "html_url": "https://github.com/apps/github-advanced-security", "followers_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false}, "body": "## PYLINT/W0611\n\nUnused import neural_compressor (unused-import)\nSee [unused-import](https://pylint.pycqa.org/en/latest/user_guide/messages/warning/unused-import.html).\n\n[Show more details](https://github.com/microsoft/Olive/security/code-scanning/10537)", "created_at": "2024-03-20T03:45:33Z", "updated_at": "2024-03-20T03:45:33Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531480443", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531480443"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531480443"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531480443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": null, "original_line": 692, "side": "RIGHT", "author_association": "CONTRIBUTOR", "original_position": 104, "position": 1, "subject_type": "line"}} |
| {"time": "2024-03-20T03:45:33+00:00", "type": "timeline:reviewed", "payload": {"id": 1947899321, "node_id": "PRR_kwDODAolhs50GpW5", "user": {"login": "github-advanced-security[bot]", "id": 62310815, "node_id": "MDM6Qm90NjIzMTA4MTU=", "avatar_url": "https://avatars.githubusercontent.com/in/57789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-advanced-security%5Bbot%5D", "html_url": "https://github.com/apps/github-advanced-security", "followers_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-advanced-security%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false}, "body": null, "commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9", "state": "commented", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947899321", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947899321"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T03:45:33Z", "updated_at": "2024-03-20T03:45:33Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2024-03-20T03:58:08+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531484985", "pull_request_review_id": 1947906359, "id": 1531484985, "node_id": "PRRC_kwDODAolhs5bSJs5", "diff_hunk": "@@ -610,13 +642,57 @@ def _run_for_config(\n \n output_model_path = resolve_onnx_path(output_model_path, Path(model.model_path).name)\n \n- quant = MatMul4BitsQuantizer(\n- model.load_model(), config[\"block_size\"], config[\"is_symmetric\"], config[\"nodes_to_exclude\"]\n- )\n+ if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n+ from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n+\n+ weight_only_quant_config = WeightOnlyQuantConfig(algorithm=config[\"algorithm\"])\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ accuracy_level=config[\"accuracy_level\"],\n+ algo_config=weight_only_quant_config,\n+ )\n+ else:\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ )\n quant.process()\n # topologically sort the graph at the end since previous optimizations may have broken it\n quant.model.topological_sort()\n # quant.model._check_init is not needed since it's only meant for float8 quantization\n \n # save the model to the output path and return the model\n return model_proto_to_olive_model(quant.model.model, output_model_path, config)\n+\n+\n+def _validate_accuracy_level(v, values, field):\n+ if not v:\n+ return v\n+\n+ if v not in (0, 1, 2, 3, 4):\n+ raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 0(unset), 1(fp32), 2(fp16), 3(bf16) or 4(int8)\")\n+\n+ return v\n+\n+\n+def _validate_algorithm(v, values, field):", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "the validate_algorithm seems has additional logic to verify neural compressor installation. Better to make sure only algo valiation logic in this function and move the validation inc logic somewhere else.", "created_at": "2024-03-20T03:58:08Z", "updated_at": "2024-03-20T03:58:09Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531484985", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531484985"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531484985"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531484985/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": 683, "original_line": 683, "side": "RIGHT", "author_association": "CONTRIBUTOR", "original_position": 95, "position": 95, "subject_type": "line"}} |
| {"time": "2024-03-20T03:58:09+00:00", "type": "review", "payload": {"id": 1947906359, "node_id": "PRR_kwDODAolhs50GrE3", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?u=bd502dd3d61efb3e3de08731a2c16da6372294ae&v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947906359", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947906359"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T03:58:09Z", "commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9"}} |
| {"time": "2024-03-20T03:58:09+00:00", "type": "timeline:reviewed", "payload": {"id": 1947906359, "node_id": "PRR_kwDODAolhs50GrE3", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": null, "commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9", "state": "commented", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947906359", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947906359"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T03:58:09Z", "updated_at": "2024-03-20T03:58:09Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2024-03-20T04:14:19+00:00", "type": "commit", "payload": {"sha": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "node_id": "C_kwDODAolhtoAKDZmOWQ2NmQ1OTNlZjg3OTJmZTdjYzVlNWY1MDJjNTE0ZGY5MTRlMmM", "commit": {"author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T04:14:19Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T04:14:19Z"}, "message": "move import checker into run", "tree": {"sha": "5dee3f3f76baa1553092e690d2b600d3fbd6f53f", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/5dee3f3f76baa1553092e690d2b600d3fbd6f53f"}, "url": "https://api.github.com/repos/microsoft/Olive/git/commits/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "comment_count": 0, "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}}, "url": "https://api.github.com/repos/microsoft/Olive/commits/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "html_url": "https://github.com/microsoft/Olive/commit/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "comments_url": "https://api.github.com/repos/microsoft/Olive/commits/6f9d66d593ef8792fe7cc5e5f502c514df914e2c/comments", "author": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "committer": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "parents": [{"sha": "604ccf841525bb9d578faf370e1c15da230bffb9", "url": "https://api.github.com/repos/microsoft/Olive/commits/604ccf841525bb9d578faf370e1c15da230bffb9", "html_url": "https://github.com/microsoft/Olive/commit/604ccf841525bb9d578faf370e1c15da230bffb9"}], "stats": {"total": 17, "additions": 9, "deletions": 8}, "files": [{"sha": "25131773ad90dfe8884ef59421f79f0fff0ef67a", "filename": "olive/passes/onnx/quantization.py", "status": "modified", "additions": 9, "deletions": 8, "changes": 17, "blob_url": "https://github.com/microsoft/Olive/blob/6f9d66d593ef8792fe7cc5e5f502c514df914e2c/olive%2Fpasses%2Fonnx%2Fquantization.py", "raw_url": "https://github.com/microsoft/Olive/raw/6f9d66d593ef8792fe7cc5e5f502c514df914e2c/olive%2Fpasses%2Fonnx%2Fquantization.py", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/olive%2Fpasses%2Fonnx%2Fquantization.py?ref=6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "patch": "@@ -645,6 +645,15 @@ def _run_for_config(\n if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n \n+ if config[\"algorithm\"] in (\"RTN\", \"GPTQ\"):\n+ try:\n+ import neural_compressor # noqa: F401 # pylint: disable=unused-import\n+ except ImportError:\n+ raise ImportError(\n+ f\"OnnxMatMul4Quantizer algorithm={config['algorithm']} \"\n+ \"requires neural_compressor package to be installed\"\n+ ) from None\n+\n weight_only_quant_config = WeightOnlyQuantConfig(algorithm=config[\"algorithm\"])\n quant = MatMul4BitsQuantizer(\n model.load_model(),\n@@ -687,12 +696,4 @@ def _validate_algorithm(v, values, field):\n if v not in (\"DEFAULT\", \"HQQ\", \"RTN\", \"GPTQ\"):\n raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 'DEFAULT', 'HQQ', 'RTN', 'GPTQ'\")\n \n- if v in (\"RTN\", \"GPTQ\"):\n- try:\n- import neural_compressor # noqa: F401\n- except ImportError:\n- raise ImportError(\n- f\"OnnxMatMul4Quantizer {field.name}={v} requires neural_compressor package to be installed\"\n- ) from None\n-\n return v"}]}} |
| {"time": "2024-03-20T04:14:19+00:00", "type": "timeline:committed", "payload": {"sha": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "node_id": "C_kwDODAolhtoAKDZmOWQ2NmQ1OTNlZjg3OTJmZTdjYzVlNWY1MDJjNTE0ZGY5MTRlMmM", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "html_url": "https://github.com/microsoft/Olive/commit/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T04:14:19Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T04:14:19Z"}, "tree": {"sha": "5dee3f3f76baa1553092e690d2b600d3fbd6f53f", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/5dee3f3f76baa1553092e690d2b600d3fbd6f53f"}, "message": "move import checker into run", "parents": [{"sha": "604ccf841525bb9d578faf370e1c15da230bffb9", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/604ccf841525bb9d578faf370e1c15da230bffb9", "html_url": "https://github.com/microsoft/Olive/commit/604ccf841525bb9d578faf370e1c15da230bffb9"}], "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}, "event": "committed"}} |
| {"time": "2024-03-20T04:26:10+00:00", "type": "review", "payload": {"id": 1947924094, "node_id": "PRR_kwDODAolhs50GvZ-", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?u=bd502dd3d61efb3e3de08731a2c16da6372294ae&v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947924094", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947924094"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T04:26:10Z", "commit_id": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c"}} |
| {"time": "2024-03-20T04:26:10+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531496879", "pull_request_review_id": 1947924094, "id": 1531496879, "node_id": "PRRC_kwDODAolhs5bSMmv", "diff_hunk": "@@ -610,13 +642,58 @@ def _run_for_config(\n \n output_model_path = resolve_onnx_path(output_model_path, Path(model.model_path).name)\n \n- quant = MatMul4BitsQuantizer(\n- model.load_model(), config[\"block_size\"], config[\"is_symmetric\"], config[\"nodes_to_exclude\"]\n- )\n+ if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n+ from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n+\n+ if config[\"algorithm\"] in (\"RTN\", \"GPTQ\"):", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "I suppose the underlying ORT will do raise the ImportError and we might need not this check?", "created_at": "2024-03-20T04:26:10Z", "updated_at": "2024-03-20T04:26:10Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531496879", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531496879"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531496879"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531496879/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": null, "original_line": 648, "side": "RIGHT", "author_association": "CONTRIBUTOR", "original_position": 60, "position": 1, "subject_type": "line"}} |
| {"time": "2024-03-20T04:26:10+00:00", "type": "timeline:reviewed", "payload": {"id": 1947924094, "node_id": "PRR_kwDODAolhs50GvZ-", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": null, "commit_id": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "state": "commented", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947924094", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947924094"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T04:26:10Z", "updated_at": "2024-03-20T04:26:10Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2024-03-20T04:40:50+00:00", "type": "review", "payload": {"id": 1947933420, "node_id": "PRR_kwDODAolhs50Gxrs", "user": {"login": "jambayk", "id": 94929125, "node_id": "U_kgDOBaiA5Q", "avatar_url": "https://avatars.githubusercontent.com/u/94929125?u=21f5d75908332828373c352bf9bc7f33c8967a86&v=4", "gravatar_id": "", "url": "https://api.github.com/users/jambayk", "html_url": "https://github.com/jambayk", "followers_url": "https://api.github.com/users/jambayk/followers", "following_url": "https://api.github.com/users/jambayk/following{/other_user}", "gists_url": "https://api.github.com/users/jambayk/gists{/gist_id}", "starred_url": "https://api.github.com/users/jambayk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jambayk/subscriptions", "organizations_url": "https://api.github.com/users/jambayk/orgs", "repos_url": "https://api.github.com/users/jambayk/repos", "events_url": "https://api.github.com/users/jambayk/events{/privacy}", "received_events_url": "https://api.github.com/users/jambayk/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947933420", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1947933420"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T04:40:50Z", "commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9"}} |
| {"time": "2024-03-20T04:40:50+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531502979", "pull_request_review_id": 1947933420, "id": 1531502979, "node_id": "PRRC_kwDODAolhs5bSOGD", "diff_hunk": "@@ -610,13 +642,57 @@ def _run_for_config(\n \n output_model_path = resolve_onnx_path(output_model_path, Path(model.model_path).name)\n \n- quant = MatMul4BitsQuantizer(\n- model.load_model(), config[\"block_size\"], config[\"is_symmetric\"], config[\"nodes_to_exclude\"]\n- )\n+ if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n+ from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n+\n+ weight_only_quant_config = WeightOnlyQuantConfig(algorithm=config[\"algorithm\"])\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ accuracy_level=config[\"accuracy_level\"],\n+ algo_config=weight_only_quant_config,\n+ )\n+ else:\n+ quant = MatMul4BitsQuantizer(\n+ model.load_model(),\n+ block_size=config[\"block_size\"],\n+ is_symmetric=config[\"is_symmetric\"],\n+ nodes_to_exclude=config[\"nodes_to_exclude\"],\n+ )\n quant.process()\n # topologically sort the graph at the end since previous optimizations may have broken it\n quant.model.topological_sort()\n # quant.model._check_init is not needed since it's only meant for float8 quantization\n \n # save the model to the output path and return the model\n return model_proto_to_olive_model(quant.model.model, output_model_path, config)\n+\n+\n+def _validate_accuracy_level(v, values, field):\n+ if not v:\n+ return v\n+\n+ if v not in (0, 1, 2, 3, 4):\n+ raise ValueError(f\"OnnxMatMul4Quantizer {field.name} must be 0(unset), 1(fp32), 2(fp16), 3(bf16) or 4(int8)\")\n+\n+ return v\n+\n+\n+def _validate_algorithm(v, values, field):", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "604ccf841525bb9d578faf370e1c15da230bffb9", "user": {"login": "jambayk", "id": 94929125, "node_id": "U_kgDOBaiA5Q", "avatar_url": "https://avatars.githubusercontent.com/u/94929125?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jambayk", "html_url": "https://github.com/jambayk", "followers_url": "https://api.github.com/users/jambayk/followers", "following_url": "https://api.github.com/users/jambayk/following{/other_user}", "gists_url": "https://api.github.com/users/jambayk/gists{/gist_id}", "starred_url": "https://api.github.com/users/jambayk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jambayk/subscriptions", "organizations_url": "https://api.github.com/users/jambayk/orgs", "repos_url": "https://api.github.com/users/jambayk/repos", "events_url": "https://api.github.com/users/jambayk/events{/privacy}", "received_events_url": "https://api.github.com/users/jambayk/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "saw the changes have already been made but just wanted to agree to Mikes point. Version checks and import checkers are runtime decisions to be run on the pass host. doing it during config validation or search point validation runs it on the engine's machine which is not necessarily the pass host.", "created_at": "2024-03-20T04:40:50Z", "updated_at": "2024-03-20T04:40:50Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531502979", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531502979"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531502979"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531502979/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": 683, "original_line": 683, "side": "RIGHT", "in_reply_to_id": 1531484985, "author_association": "CONTRIBUTOR", "original_position": 95, "position": 95, "subject_type": "line"}} |
| {"time": "2024-03-20T06:12:20+00:00", "type": "review", "payload": {"id": 1948003523, "node_id": "PRR_kwDODAolhs50HCzD", "user": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?u=ab07a99edd81d7fd825251714b61b1fa968f0683&v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "COMMENTED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1948003523", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1948003523"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T06:12:20Z", "commit_id": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c"}} |
| {"time": "2024-03-20T06:12:20+00:00", "type": "review_comment", "payload": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531547564", "pull_request_review_id": 1948003523, "id": 1531547564, "node_id": "PRRC_kwDODAolhs5bSY-s", "diff_hunk": "@@ -610,13 +642,58 @@ def _run_for_config(\n \n output_model_path = resolve_onnx_path(output_model_path, Path(model.model_path).name)\n \n- quant = MatMul4BitsQuantizer(\n- model.load_model(), config[\"block_size\"], config[\"is_symmetric\"], config[\"nodes_to_exclude\"]\n- )\n+ if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n+ from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n+\n+ if config[\"algorithm\"] in (\"RTN\", \"GPTQ\"):", "path": "olive/passes/onnx/quantization.py", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "original_commit_id": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "user": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "Yes, the import error will be raised in ort as well. But no extra info to tell which config needs inc package. \r\nMaybe we can keep it here to provide clear description once user choose the wrong config.", "created_at": "2024-03-20T06:12:20Z", "updated_at": "2024-03-20T06:12:20Z", "html_url": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531547564", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"self": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531547564"}, "html": {"href": "https://github.com/microsoft/Olive/pull/1024#discussion_r1531547564"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "reactions": {"url": "https://api.github.com/repos/microsoft/Olive/pulls/comments/1531547564/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}, "start_line": null, "original_start_line": null, "start_side": null, "line": null, "original_line": 648, "side": "RIGHT", "in_reply_to_id": 1531496879, "author_association": "CONTRIBUTOR", "original_position": 60, "position": 1, "subject_type": "line"}} |
| {"time": "2024-03-20T06:26:22+00:00", "type": "commit", "payload": {"sha": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "node_id": "C_kwDODAolhtoAKDVkYzkyOGM3YWMzNmEwMTkyOWMxZDJhNjUzYjdmZjkzZDc4ZTU4ZjQ", "commit": {"author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T06:26:22Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T06:26:22Z"}, "message": "remove import error check", "tree": {"sha": "d4a108ca3a89068be197c3b67de6a6f43befeb59", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/d4a108ca3a89068be197c3b67de6a6f43befeb59"}, "url": "https://api.github.com/repos/microsoft/Olive/git/commits/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "comment_count": 0, "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}}, "url": "https://api.github.com/repos/microsoft/Olive/commits/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "html_url": "https://github.com/microsoft/Olive/commit/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "comments_url": "https://api.github.com/repos/microsoft/Olive/commits/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4/comments", "author": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "committer": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "parents": [{"sha": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "url": "https://api.github.com/repos/microsoft/Olive/commits/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "html_url": "https://github.com/microsoft/Olive/commit/6f9d66d593ef8792fe7cc5e5f502c514df914e2c"}], "stats": {"total": 9, "additions": 0, "deletions": 9}, "files": [{"sha": "ffca2af56f3d33ae8eff099965d756e5b4fac6d0", "filename": "olive/passes/onnx/quantization.py", "status": "modified", "additions": 0, "deletions": 9, "changes": 9, "blob_url": "https://github.com/microsoft/Olive/blob/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4/olive%2Fpasses%2Fonnx%2Fquantization.py", "raw_url": "https://github.com/microsoft/Olive/raw/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4/olive%2Fpasses%2Fonnx%2Fquantization.py", "contents_url": "https://api.github.com/repos/microsoft/Olive/contents/olive%2Fpasses%2Fonnx%2Fquantization.py?ref=5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "patch": "@@ -645,15 +645,6 @@ def _run_for_config(\n if version.parse(OrtVersion) >= version.parse(\"1.17.0\"):\n from onnxruntime.quantization.matmul_4bits_quantizer import WeightOnlyQuantConfig\n \n- if config[\"algorithm\"] in (\"RTN\", \"GPTQ\"):\n- try:\n- import neural_compressor # noqa: F401 # pylint: disable=unused-import\n- except ImportError:\n- raise ImportError(\n- f\"OnnxMatMul4Quantizer algorithm={config['algorithm']} \"\n- \"requires neural_compressor package to be installed\"\n- ) from None\n-\n weight_only_quant_config = WeightOnlyQuantConfig(algorithm=config[\"algorithm\"])\n quant = MatMul4BitsQuantizer(\n model.load_model(),"}]}} |
| {"time": "2024-03-20T06:26:22+00:00", "type": "timeline:committed", "payload": {"sha": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "node_id": "C_kwDODAolhtoAKDVkYzkyOGM3YWMzNmEwMTkyOWMxZDJhNjUzYjdmZjkzZDc4ZTU4ZjQ", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "html_url": "https://github.com/microsoft/Olive/commit/5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "author": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T06:26:22Z"}, "committer": {"name": "jiapli", "email": "jiapli@microsoft.com", "date": "2024-03-20T06:26:22Z"}, "tree": {"sha": "d4a108ca3a89068be197c3b67de6a6f43befeb59", "url": "https://api.github.com/repos/microsoft/Olive/git/trees/d4a108ca3a89068be197c3b67de6a6f43befeb59"}, "message": "remove import error check", "parents": [{"sha": "6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "url": "https://api.github.com/repos/microsoft/Olive/git/commits/6f9d66d593ef8792fe7cc5e5f502c514df914e2c", "html_url": "https://github.com/microsoft/Olive/commit/6f9d66d593ef8792fe7cc5e5f502c514df914e2c"}], "verification": {"verified": false, "reason": "unsigned", "signature": null, "payload": null, "verified_at": null}, "event": "committed"}} |
| {"time": "2024-03-20T09:08:42+00:00", "type": "review", "payload": {"id": 1948297237, "node_id": "PRR_kwDODAolhs50IKgV", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?u=bd502dd3d61efb3e3de08731a2c16da6372294ae&v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "state": "APPROVED", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1948297237", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "author_association": "CONTRIBUTOR", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1948297237"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T09:08:42Z", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4"}} |
| {"time": "2024-03-20T09:08:42+00:00", "type": "timeline:reviewed", "payload": {"id": 1948297237, "node_id": "PRR_kwDODAolhs50IKgV", "user": {"login": "guotuofeng", "id": 817030, "node_id": "MDQ6VXNlcjgxNzAzMA==", "avatar_url": "https://avatars.githubusercontent.com/u/817030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guotuofeng", "html_url": "https://github.com/guotuofeng", "followers_url": "https://api.github.com/users/guotuofeng/followers", "following_url": "https://api.github.com/users/guotuofeng/following{/other_user}", "gists_url": "https://api.github.com/users/guotuofeng/gists{/gist_id}", "starred_url": "https://api.github.com/users/guotuofeng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guotuofeng/subscriptions", "organizations_url": "https://api.github.com/users/guotuofeng/orgs", "repos_url": "https://api.github.com/users/guotuofeng/repos", "events_url": "https://api.github.com/users/guotuofeng/events{/privacy}", "received_events_url": "https://api.github.com/users/guotuofeng/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "body": "", "commit_id": "5dc928c7ac36a01929c1d2a653b7ff93d78e58f4", "state": "approved", "html_url": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1948297237", "pull_request_url": "https://api.github.com/repos/microsoft/Olive/pulls/1024", "_links": {"html": {"href": "https://github.com/microsoft/Olive/pull/1024#pullrequestreview-1948297237"}, "pull_request": {"href": "https://api.github.com/repos/microsoft/Olive/pulls/1024"}}, "submitted_at": "2024-03-20T09:08:42Z", "updated_at": "2024-03-20T09:08:42Z", "author_association": "CONTRIBUTOR", "event": "reviewed"}} |
| {"time": "2024-03-20T10:31:49+00:00", "type": "timeline:merged", "payload": {"id": 12182672222, "node_id": "ME_lADODAolhs6C1tMRzwAAAALWJNNe", "url": "https://api.github.com/repos/microsoft/Olive/issues/events/12182672222", "actor": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "merged", "commit_id": "d5c489ed60c91ea3ea9c1a28a90c2fe400e86bb1", "commit_url": "https://api.github.com/repos/microsoft/Olive/commits/d5c489ed60c91ea3ea9c1a28a90c2fe400e86bb1", "created_at": "2024-03-20T10:31:49Z", "performed_via_github_app": null}} |
| {"time": "2024-03-20T10:31:49+00:00", "type": "timeline:closed", "payload": {"id": 12182672256, "node_id": "CE_lADODAolhs6C1tMRzwAAAALWJNOA", "url": "https://api.github.com/repos/microsoft/Olive/issues/events/12182672256", "actor": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "closed", "commit_id": null, "commit_url": null, "created_at": "2024-03-20T10:31:49Z", "state_reason": null, "performed_via_github_app": null}} |
| {"time": "2024-03-20T10:31:49+00:00", "type": "timeline:head_ref_deleted", "payload": {"id": 12182672408, "node_id": "HRDE_lADODAolhs6C1tMRzwAAAALWJNQY", "url": "https://api.github.com/repos/microsoft/Olive/issues/events/12182672408", "actor": {"login": "trajepl", "id": 13343117, "node_id": "MDQ6VXNlcjEzMzQzMTE3", "avatar_url": "https://avatars.githubusercontent.com/u/13343117?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trajepl", "html_url": "https://github.com/trajepl", "followers_url": "https://api.github.com/users/trajepl/followers", "following_url": "https://api.github.com/users/trajepl/following{/other_user}", "gists_url": "https://api.github.com/users/trajepl/gists{/gist_id}", "starred_url": "https://api.github.com/users/trajepl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trajepl/subscriptions", "organizations_url": "https://api.github.com/users/trajepl/orgs", "repos_url": "https://api.github.com/users/trajepl/repos", "events_url": "https://api.github.com/users/trajepl/events{/privacy}", "received_events_url": "https://api.github.com/users/trajepl/received_events", "type": "User", "user_view_type": "public", "site_admin": false}, "event": "head_ref_deleted", "commit_id": null, "commit_url": null, "created_at": "2024-03-20T10:31:49Z", "performed_via_github_app": null}} |
|
|