diff stringlengths 136 4.7k | msg stringlengths 9 207 |
|---|---|
--- tools/tpm2_hmac.c
+++ tools/tpm2_hmac.c
@@ -208,7 +208,7 @@ static bool init(int argc, char *argv[], tpm_hmac_ctx *ctx) {
}
/*
- * Options g, i, o must be specified and k or c must be specified.
+ * Options g, I, o must be specified and k or c must be specified.
*/
if (!((flags.k || f... | tpm2_hmac: fix option comment |
--- tools/tpm2_getmanufec.c
+++ tools/tpm2_getmanufec.c
@@ -235,6 +235,12 @@ int createEKHandle(TSS2_SYS_CONTEXT *sapi_context)
LOG_INFO("EK create succ.. Handle: 0x%8.8x", handle2048ek);
if (!ctx.non_persistent_read) {
+
+ if (!ctx.persistent_handle) {
+ LOG_ERR("Persistent handle for EK ... | tpm2_getmanufec: only attempt to persist the EK if a handle was provided |
--- tools/tpm2_import.c
+++ tools/tpm2_import.c
@@ -161,6 +161,7 @@ static bool encrypt_seed_with_tpm2_rsa_public_key(void) {
return false;
}
return_code = RSA_generate_key_ex(rsa, 2048, bne, NULL);
+ BN_free(bne);
if (return_code != 1) {
LOG_ERR("RSA_generate_key_ex failed\n");
... | tpm2_import: free exponent BIGNUM after RSA_generate_key_ex() call |
--- tools/tpm2_verifysignature.c
+++ tools/tpm2_verifysignature.c
@@ -194,6 +194,14 @@ static bool init(tpm2_verifysig_ctx *ctx) {
/* If no digest is specified, compute it */
if (!ctx->flags.digest) {
+ if (!ctx->flags.msg) {
+ /*
+ * This is a redundant check since main() chec... | tpm2_verifysignature: ensure msg is not null |
--- lib/tpm2_tcti_ldr.c
+++ lib/tpm2_tcti_ldr.c
@@ -55,7 +55,7 @@ const TSS2_TCTI_INFO *tpm2_tcti_ldr_getinfo(void) {
bool tpm2_tcti_ldr_is_tcti_present(const char *name) {
char path[PATH_MAX];
- snprintf(path, sizeof(path), "libtss2-tcti-%s.so", name);
+ snprintf(path, sizeof(path), "libtss2-tcti-%s.so.0... | tcti_ldr: load a specific so version |
--- ldap/servers/slapd/back-ldbm/ldbm_bind.c
+++ ldap/servers/slapd/back-ldbm/ldbm_bind.c
@@ -76,8 +76,8 @@ ldbm_back_bind(Slapi_PBlock *pb)
case LDAP_AUTH_SIMPLE: {
Slapi_Value cv;
if (slapi_entry_attr_find(e->ep_entry, "userpassword", &attr) != 0) {
- slapi_send_ldap_result(pb, LDAP_... | Issue 4609 - CVE - info disclosure when authenticating |
--- ldap/servers/slapd/back-ldbm/ldbm_config.c
+++ ldap/servers/slapd/back-ldbm/ldbm_config.c
@@ -1243,7 +1243,7 @@ ldbm_config_search_entry_callback(Slapi_PBlock *pb __attribute__((unused)),
if (attrs) {
for (size_t i = 0; attrs[i]; i++) {
if (ldbm_config_moved_attr(a... | Issue 4480 - Unexpected info returned to ldap request (#4491) |
--- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
@@ -295,14 +295,17 @@ void CAnalyzerCCpp::GetIndependentBuldIdPC(const std::string& pBuildIdPC, std::s
line += pBuildIdPC[ii];
ii++;
}
- while (!isspace(line[jj]) && jj < line.length())
+ while (line[jj] != '+' && jj < li... | fixed local UUID |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -721,6 +721,14 @@ int main(int argc, char** argv)
dd_save_text(dd, FILENAME_ENVIRON, environ ? : "");
free(environ);
+ char *fips_enabled = xmalloc_fopen_fgetline_fclose("/proc/sys/crypto/fips_enabled");
+ if (fips_enable... | abrt-hook-ccpp: save /proc/sys/crypto/fips_enabled value if it isn't "0". Closes rhbz#747870 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -795,6 +795,8 @@ int main(int argc, char** argv)
unlink(core_basename);
}
+/* Because of #1211835 and #1126850 */
+#if 0
/* Save JVM crash log if it exists. (JVM's coredump per se
* is nearly useless for JVM deve... | ccpp: stop reading hs_error.log from /tmp |
--- src/Hooks/abrt-hook-ccpp.cpp
+++ src/Hooks/abrt-hook-ccpp.cpp
@@ -137,7 +137,15 @@ static char* get_executable(pid_t pid)
char buf[sizeof("/proc/%lu/exe") + sizeof(long)*3];
sprintf(buf, "/proc/%lu/exe", (long)pid);
- return malloc_readlink(buf);
+ char *executable = malloc_readlink(buf);
+ /* ... | remove "(deleted)" from executable path rhbz#593037 |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -116,6 +116,8 @@ static off_t copyfd_sparse(int src_fd, int dst_fd1, int dst_fd2, off_t size2)
size2 -= rd;
if (size2 < 0)
dst_fd2 = -1;
+//TODO: truncate to 0 or even delete the second file
+//(currently we delete the file later)
}
out:
| abrt-hook-ccpp: added a TODO comment. No code changes |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -718,7 +718,8 @@ int main(int argc, char** argv)
if (snprintf(path, sizeof(path), "%s/%s-coredump", g_settings_dump_location, last_slash) >= sizeof(path))
error_msg_and_die("Error saving '%s': truncated long file path", path);
- ... | ccpp: save abrt core files only to new files |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -678,7 +678,7 @@ int main(int argc, char** argv)
{
char *rootdir = get_rootdir(pid);
- dd_create_basic_files(dd, fsuid, (rootdir && strcmp(rootdir, "/") != 0) ? rootdir : NULL);
+ dd_create_basic_files(dd, fsuid, NULL);
... | ccpp: do not read data from root directories |
--- src/Daemon/Daemon.cpp
+++ src/Daemon/Daemon.cpp
@@ -810,6 +810,7 @@ int main(int argc, char** argv)
int inotify_fd = inotify_init();
if (inotify_fd == -1)
perror_msg_and_die("inotify_init failed");
+ close_on_exec_on(inotify_fd);
if (inotify_add_watch(inotify_fd, DEBUG... | trivial: close inotify_fd on exec |
--- src/applet/applet.c
+++ src/applet/applet.c
@@ -195,7 +195,7 @@ static bool problem_info_ensure_writable(problem_info_t *pi)
static problem_info_t *problem_info_new(const char *dir)
{
- problem_info_t *pi = xzalloc(sizeof(*pi));
+ problem_info_t *pi = g_new0(problem_info_t, 1);
pi->problem_data = pro... | applet: Use g_new0() instead of xzalloc() |
--- src/plugins/abrt-action-analyze-oops.c
+++ src/plugins/abrt-action-analyze-oops.c
@@ -48,10 +48,15 @@ static void hash_oops_str(char hash_str[SHA1_RESULT_LEN*2 + 1], char *oops_buf,
end_mem_block = skip_whitespace(end_mem_block);
- /* +1 for '?' and +1 for space after '?' == +2*/
+ ... | rhbz#789526 - abrt hashing on kernel backtraces needs improving |
--- lib/plugins/FileTransfer.cpp
+++ lib/plugins/FileTransfer.cpp
@@ -232,6 +232,10 @@ void CFileTransfer::Run(const char *pActionDir, const char *pArgs, int force)
{
/* Remember pActiveDir for later sending */
FILE *dirlist = fopen(FILETRANSFER_DIRLIST, "a");
+ if (!dirlist)
+ {
+ ... | FileTransfer.cpp: add forgotten open error test |
--- lib/Plugins/CCpp.cpp
+++ lib/Plugins/CCpp.cpp
@@ -183,8 +183,8 @@ void CAnalyzerCCpp::InstallDebugInfos(const std::string& pPackage)
}
if (strstr(buff, "Total download size") != NULL)
{
- int r = write(pipein[1], "y\n", sizeof("y\n"));
- if (r != sizeof("y\n"))
+ ... | two trivial fixlets in lib/Plugins/CCpp.cpp |
--- src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
+++ src/plugins/abrt-action-install-debuginfo-to-abrt-cache.c
@@ -182,6 +182,9 @@ int main(int argc, char **argv)
if (u != 0)
strcpy(path_env, "PATH=/usr/bin:/bin:"BIN_DIR);
putenv(path_env);
+
+ /* Use safe umask */
+ ... | a-a-i-d-t-a-cache: sanitize umask |
--- src/gui-gtk/abrt-gtk.c
+++ src/gui-gtk/abrt-gtk.c
@@ -390,7 +390,7 @@ GtkWidget *create_main_window(void)
gtk_container_add(GTK_CONTAINER(halign), hbox_report_delete);
GtkWidget *hbox_help_close = gtk_hbutton_box_new();
- GtkWidget *btn_online_help = gtk_button_new_with_mnemonic(_("_Online Help"));
+... | abrt-gui: change the help accelerator to alt-H |
--- src/hooks/abrt-hook-ccpp.c
+++ src/hooks/abrt-hook-ccpp.c
@@ -399,7 +399,7 @@ static int open_user_core(uid_t uid, uid_t fsuid, pid_t pid, char **percent_valu
static bool dump_fd_info(const char *dest_filename, char *source_filename, int source_base_ofs, uid_t uid, gid_t gid)
{
- FILE *fp = fopen(dest_filena... | ccpp: open file for dump_fd_info with O_EXCL |
--- src/dbus/abrt-dbus.c
+++ src/dbus/abrt-dbus.c
@@ -599,7 +599,7 @@ static void handle_method_call(GDBusConnection *connection,
g_variant_get(parameters, "(&s&s&s)", &problem_id, &element, &value);
- if (element == NULL || element[0] == '\0' || strlen(element) > 64)
+ if (!str_is_correct_fi... | dbus: report invalid element names |
--- src/daemon/Daemon.cpp
+++ src/daemon/Daemon.cpp
@@ -142,8 +142,8 @@ static gboolean server_socket_cb(GIOChannel *source, GIOCondition condition, gpo
pid_t pid = fork();
if (pid < 0)
{
- close(socket);
perror_msg("fork");
+ close(socket);
return TRUE;
}
if (pi... | perror has to be used immediately after failed syscall |
--- src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
+++ src/lib/OpenEXR/ImfCompositeDeepScanLine.cpp
@@ -238,6 +238,20 @@ CompositeDeepScanLine::setFrameBuffer(const FrameBuffer& fr)
for(FrameBuffer::ConstIterator q=fr.begin();q!=fr.end();q++)
{
+
+ //
+ // Frame buffer must have xSampling an... | enforce xSampling/ySampling==1 in CompositeDeepScanLine (#1209) |
--- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -340,6 +340,11 @@ MultiPartInputFile::initialize()
// Perform usual check on headers.
//
+ if ( _data->_headers.size() == 0)
+ {
+ throw IEX_NAMESPACE::ArgExc ("Files must contain at least one header");... | add sanity check for reading multipart files with no parts (#840) |
--- OpenEXR/IlmImf/ImfTiledInputFile.cpp
+++ OpenEXR/IlmImf/ImfTiledInputFile.cpp
@@ -1313,6 +1313,13 @@ TiledInputFile::rawTileData (int &dx, int &dy,
throw IEX_NAMESPACE::ArgExc ("rawTileData read the wrong tile");
}
}
+ else
+ {
+ if(!isValidTile (dx, ... | Fix for #494: validate tile coordinates when doing copyPixels |
--- OpenEXR/exrmakepreview/makePreview.cpp
+++ OpenEXR/exrmakepreview/makePreview.cpp
@@ -120,8 +120,8 @@ generatePreview (const char inFileName[],
previewHeight = max (int (h / (w * a) * previewWidth + .5f), 1);
previewPixels.resizeErase (previewHeight, previewWidth);
- float fx = (previewWidth > 0)? (... | Fix logic for 1 pixel high/wide preview images (Fixes #493) |
--- OpenEXR/IlmImf/ImfB44Compressor.cpp
+++ OpenEXR/IlmImf/ImfB44Compressor.cpp
@@ -494,7 +494,7 @@ B44Compressor::B44Compressor
//
_tmpBuffer = new unsigned short
- [checkArraySize (uiMult (maxScanLineSize, numScanLines),
+ [checkArraySize (uiMult (maxScanLineSize / sizeof(unsigned short), nu... | reduce B44 _tmpBufferSize (was allocating two bytes per byte) (#843) |
--- OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
+++ OpenEXR/IlmImf/ImfMultiPartInputFile.cpp
@@ -571,7 +571,7 @@ MultiPartInputFile::Data::chunkOffsetReconstruction(OPENEXR_IMF_INTERNAL_NAMESPA
- if(partNumber<0 || partNumber> static_cast<int>(parts.size()))
+ ... | Fix #491, issue with part number range check reconstructing chunk offset table |
--- keepalived/core/main.c
+++ keepalived/core/main.c
@@ -882,7 +882,7 @@ set_umask(const char *optarg)
if (*endptr || umask_long < 0 || umask_long & ~0777L) {
fprintf(stderr, "Invalid --umask option %s", optarg);
- return;
+ return 0;
}
umask_val = umask_long & 0777;
| Fix compile warning introduced in commit c6247a9 |
--- accel-pppd/radius/packet.c
+++ accel-pppd/radius/packet.c
@@ -206,6 +206,14 @@ int rad_packet_recv(int fd, struct rad_packet_t **p, struct sockaddr_in *addr)
len -= vendor->tag + vendor->len;
n -= 4 + vendor->tag + vendor->len;
+ if (len < 0) {
+ log_ppp_warn("radius:packet invalid vendor attribu... | radius: sanity check for vendor attribute length |
--- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exmisc - ACPI AML (p-code) execution - specific opcodes
- * $Revision: 1.127 $
+ * $Revision: 1.... | Allow RefOf on the Debug object |
--- source/common/adisasm.c
+++ source/common/adisasm.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: adisasm - Application-level disassembler routines
- * $Revision: 1.67 $
+ * $Revision: 1.68 $
*
********************... | Special handling for FACS table "name" |
--- source/components/disassembler/dmresrc.c
+++ source/components/disassembler/dmresrc.c
@@ -544,6 +544,15 @@ AcpiDmIsResourceTemplate (
* intialization byte list. Because the resource macros will create
* a buffer of the exact required length (buffer length will be equal
* to the actual length).
+ ... | Add new comment, no functional change |
--- source/components/namespace/nsxfname.c
+++ source/components/namespace/nsxfname.c
@@ -239,7 +239,7 @@ AcpiGetHandle (
{
ACPI_STATUS Status;
NAME_TABLE_ENTRY *ThisEntry;
- ACPI_HANDLE Scope = NULL;
+ NAME_TABLE_ENTRY *Scope = NULL;
if (!RetHandle || !Path... | Fixed bug in AcpiGetHandle(): searching for a relative path always |
--- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: evregion - ACPI AddressSpace / OpRegion handler dispatch
- * $Revision: 1.79 $
+ * $Revision: 1.... | Ran acpisrc source cleanup |
--- source/compiler/aslerror.c
+++ source/compiler/aslerror.c
@@ -247,6 +247,11 @@ AePrintException (
FILE *SourceFile;
+ if (Gbl_NoErrors)
+ {
+ return;
+ }
+
/*
* Only listing files have a header, and remarks/optimizations
* are always output
--- source/co... | iASL: Add option to display summary only. |
--- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -795,11 +795,14 @@ CmInitStaticObject (
* 1) This is an ACPI_OBJECT_INTERNAL descriptor
* 2) The size is the full object (worst case)
* 3) The flags field indicates static allocation
+ * 4) Reference count star... | Init static object reference count |
--- source/include/acpixf.h
+++ source/include/acpixf.h
@@ -270,7 +270,6 @@ INT32
AcpiModeCapabilities (
void);
-
/*
* Event / System interfaces
*/
| Modified various APIs to match our intent. |
--- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: evgpe - General Purpose Event handling and dispatch
- * $Revision: 1.32 $
+ * $Revision: 1.34 $
*
... | Check for the case where there are no GPEs |
--- source/components/hardware/hwsleep.c
+++ source/components/hardware/hwsleep.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Name: hwsleep.c - ACPI Hardware Sleep/Wake Interface
- * $Revision: 1.14 $
+ * $Revision: 1.15 $
*
****... | don't try secondary PM_EN write if doing S1 |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: psparse - Parser top level AML parse routines
- * $Revision: 1.75 $
+ * $Revision: 1.76 $
*
**... | Code cleanup (acpisrc -c) |
--- source/compiler/cvcompiler.c
+++ source/compiler/cvcompiler.c
@@ -198,18 +198,15 @@ CvProcessComment (
CvDbgPrint ("CommentString: %s\n", CommentString);
/*
- * Determine whether if this comment spans multiple lines.
- * If so, break apart the comment by line so that it can be
- ... | iasl: fix ASL/ASL+ converter comment. |
--- source/compiler/aslglobal.h
+++ source/compiler/aslglobal.h
@@ -3,7 +3,7 @@
/******************************************************************************
*
* Module Name: aslglobal.h - Global variable definitions
- * $Revision: 1.15 $
+ * $Revision: 1.17 $
*
********************... | Support for Switch/Case added |
--- source/components/hardware/hwgpe.c
+++ source/components/hardware/hwgpe.c
@@ -222,7 +222,7 @@ AcpiHwLowSetGpe (
break;
default:
- ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u\n", Action));
+ ACPI_ERROR ((AE_INFO, "Invalid GPE Action, %u", Action));
return (AE_BAD_PARAMETER);
... | Remove some extraneous newlines in ACPI_ERROR type calls.. |
--- source/components/events/evxface.c
+++ source/components/events/evxface.c
@@ -714,7 +714,7 @@ AcpiRemoveNotifyHandler (
ACPI_STATUS
AcpiInstallAddressSpaceHandler (
ACPI_HANDLE Device,
- UINT32 SpaceId,
+ ACPI_ADDRESS_SPACE_TYPE SpaceId,
ADDRESS_SPACE_HANDLER Hand... | date 2000.01.24.22.09.00; author psdiefen; state Exp; |
--- source/components/namespace/nseval.c
+++ source/components/namespace/nseval.c
@@ -428,6 +428,16 @@ AcpiNsEvaluate (
Status = AE_OK;
}
+ else if (ACPI_FAILURE(Status))
+ {
+ /* If ReturnObject exists, delete it */
+
+ if (Info->ReturnObject)
+ {
+ AcpiUtRemoveR... | acpi: acpica: fix acpi operand cache leak in nseval.c |
--- source/tools/acpiexec/aeexec.c
+++ source/tools/acpiexec/aeexec.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: aeexec - Support routines for AcpiExec utility
- * $Revision: 1.107 $
+ * $Revision: 1.108 $
*
*******... | ACPICA: test timeout on global lock interface |
--- source/components/tables/tbinstal.c
+++ source/components/tables/tbinstal.c
@@ -236,7 +236,7 @@ AcpiTbInstallTableWithOverride (
* DESCRIPTION: This function is called to verify and install an ACPI table.
* When this function is called by "Load" or "LoadTable" opcodes,
* or by AcpiLo... | Tables: Fix spelling mistake in comment |
--- source/components/namespace/nsnames.c
+++ source/components/namespace/nsnames.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: nsnames - Name manipulation and search
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
*
**... | Fix for RefOf/DeRefOf issue. RefOf now returns an object of type |
--- source/components/executer/exdump.c
+++ source/components/executer/exdump.c
@@ -358,6 +358,11 @@ AmlDumpOperand (
break;
+ case AML_NAMEPATH_OP:
+ DEBUG_PRINT_RAW (ACPI_INFO, ("Lvalue.Nte->Name %x\n",
+ EntryDesc->Lvalue.Nte->Name));
+ break;
+ ... | Added AML_NAMEPATH_OP to AmlDumpOperand case statement. |
--- source/components/events/evxfregn.c
+++ source/components/events/evxfregn.c
@@ -139,6 +139,12 @@
*
* DESCRIPTION: Install a handler for all OpRegions of a given SpaceId.
*
+ * NOTE: This function should only be called after AcpiEnableSubsystem has
+ * been called. This is because any _REG methods associated w... | Comment update; no functional change. |
--- source/include/platform/acwin.h
+++ source/include/platform/acwin.h
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Name: acwin.h - OS specific defines, etc.
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
*
***************************************... | ACPICA: Fix for Linux source translation |
--- source/compiler/asllisting.c
+++ source/compiler/asllisting.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: asllisting - Listing file generation
- * $Revision: 1.24 $
+ * $Revision: 1.25 $
*
***********************... | Split opcode flags into separate class/type/flags fields |
--- source/components/executer/exstore.c
+++ source/components/executer/exstore.c
@@ -206,12 +206,13 @@ AmlExecute (
* the execution of an numeric operator. It is not clear who should delete the result
* object if it is not to be returned. Needs more investigation.
*/
-
+/*
if (... | Fixes for ESG. |
--- source/components/executer/exfldio.c
+++ source/components/executer/exfldio.c
@@ -613,13 +613,13 @@ AcpiExFieldDatumIo (
return_ACPI_STATUS (Status);
}
- ACPI_DEBUG_PRINT ((ACPI_DB_BFIELD,
- "I/O to Data Register: ValuePtr %p\n", Value));
-
if (ReadWrite == ACPI_RE... | Update debug output for IndexField I/O. |
--- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: dbstats - Generation and display of ACPI table statistics
- * $Revision: 1.89 $
+ * $Revision... | Added additional object to SIZES command. |
--- source/tools/acpiexec/aehandlers.c
+++ source/tools/acpiexec/aehandlers.c
@@ -1127,11 +1127,21 @@ AeInstallEarlyHandlers (
Status = AcpiDetachData (Handle, AeAttachedDataHandler);
AE_CHECK_OK (AcpiDetachData, Status);
- Status = AcpiAttachData (Handle, AeAttachedDataHandler, Handle);
+ ... | AcpiExec: Add support to test attach/delete root node objects. |
--- source/components/utilities/utdecode.c
+++ source/components/utilities/utdecode.c
@@ -629,9 +629,9 @@ static const char *AcpiGbl_GenericNotify[ACPI_GENERIC_NOTIFY_MAX + 1]
/* 09 */ "Device PLD Check",
/* 0A */ "Reserved",
/* 0B */ "System Locality Update",
- /* 0C */ "Shutdown Request", ... | Utilities: Make a notify value reserved |
--- source/compiler/aslcodegen.c
+++ source/compiler/aslcodegen.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: aslcodegen - AML code generation
- * $Revision: 1.60 $
+ * $Revision: 1.61 $
*
***************************... | Fix fault if package length too long to be encoded (BZ 432) |
--- source/include/platform/acenv.h
+++ source/include/platform/acenv.h
@@ -224,8 +224,8 @@ typedef char *va_list;
#endif /* va_arg */
-#define STRSTR(s1,s2) __strstr((char *) (s1), (char *) (s2))
-#define STRUPR(s) _strupr((char *) (s))
+#define STRSTR(s1,s2) _strstr((char *) (s1... | Changed _strupr to __strupr (two __) unable to link on WDM because |
--- source/components/executer/exmisc.c
+++ source/components/executer/exmisc.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exmisc - ACPI AML (p-code) execution - specific opcodes
- * $Revision: 1.84 $
+ * $Revision: 1.8... | Added NATIVE_UINT for switch statements, prevents switch on a 64-bit |
--- source/components/events/evgpe.c
+++ source/components/events/evgpe.c
@@ -494,6 +494,16 @@ AcpiEvGpeDetect (
GpeRegisterInfo = &GpeBlock->RegisterInfo[i];
+ /*
+ * Optimization: If there are no GPEs enabled within this
+ * register, we can safely ignore the entire... | GPE detect optimization - ignore unused GPE registers. |
--- source/components/events/evevent.c
+++ source/components/events/evevent.c
@@ -2,7 +2,7 @@
*
* Module Name: evevent - Fixed and General Purpose AcpiEvent
* handling and dispatch
- * $Revision: 1.52 $
+ * $Revision: 1.53 $
*
********************************... | Cleanup - extraneous spaces and tab removal |
--- source/include/actypes.h
+++ source/include/actypes.h
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Name: actypes.h - Common data types for the entire ACPI subsystem
- * $Revision: 1.134 $
+ * $Revision: 1.135 $
*
***************************... | Ran acpisrc source cleanup |
--- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exutils - interpreter/scanner utilities
- * $Revision: 1.116 $
+ * $Revision: 1.117 $
*
**... | typo in comment |
--- source/components/namespace/nsdump.c
+++ source/components/namespace/nsdump.c
@@ -287,6 +287,13 @@ AcpiNsDumpOneObject (
}
ThisNode = AcpiNsMapHandleToNode (ObjHandle);
+ if (!ThisNode)
+ {
+ ACPI_DEBUG_PRINT ((ACPI_DB_INFO, "Invalid object handle %p\n",
+ ObjHandle));
+ r... | Add error check to debug object dump routine. |
--- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: aslopcode - AML opcode generation
- * $Revision: 1.68 $
+ * $Revision: 1.69 $
*
**************************... | warning and truncation for large integers in 32-bit tables |
--- source/components/debugger/dbstats.c
+++ source/components/debugger/dbstats.c
@@ -213,13 +213,13 @@ DbDisplayStatistics (void)
OsdPrintf ("Control Method Parse Trees:.% 7ld\n", SizeOfMethodTrees);
OsdPrintf ("Named Object NTEs:..........% 7ld\n", SizeOfNTEs);
OsdPrintf ("Named Internal Objects......%... | date 2000.05.03.23.17.00; author rmoore1; state Exp; |
--- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
@@ -188,8 +188,8 @@ AcpiNsRootInitialize (
continue;
}
- Status = AcpiNsLookup (NULL, (char *) InitVal->Name, InitVal->Type,
- ACPI_IMODE_LOAD_PASS2, ACPI_NS_NO_UPSEARCH,
+ Status = Acp... | Fix deconstification warnings (-Wcast-qual) with AcpiNsRootInitialize(). |
--- source/components/debugger/dbdisply.c
+++ source/components/debugger/dbdisply.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: dbdisply - debug display commands
- * $Revision: 1.81 $
+ * $Revision: 1.82 $
*
*******... | Display all Args - they can be used as locals |
--- source/components/resources/rsutils.c
+++ source/components/resources/rsutils.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: rsutils - Utilities for the resource manager
- * $Revision: 1.22 $
+ * $Revision: 1.23 $
... | double deleting ByteStream - remove non-refcounted version |
--- source/components/executer/excreate.c
+++ source/components/executer/excreate.c
@@ -322,7 +322,7 @@ AmlExecCreateField (
FieldDesc->FieldUnit.UpdateRule = (UINT8) UPDATE_Preserve;
FieldDesc->FieldUnit.Length = BitCount;
FieldDesc->FieldUnit.BitOffset = (UINT8) (BitOffset % 8);
... | Added alignment and math macros |
--- tests/aapits/athardware.c
+++ tests/aapits/athardware.c
@@ -1095,7 +1095,7 @@ AtHardwTest0010(void)
return (Status);
}
- Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress);
+ Status = AcpiSetFirmwareWakingVector ((UINT32) PhysicalAddress, 0);
if (ACPI_FAILURE(Status))
{
... | aapts: Update for ACPICA interface change. |
--- source/tools/acpidump/apdump.c
+++ source/tools/acpidump/apdump.c
@@ -154,7 +154,7 @@ ApIsValidHeader (
/* Check for minimum table length */
- if (Table->Length <= sizeof (ACPI_TABLE_HEADER))
+ if (Table->Length < sizeof (ACPI_TABLE_HEADER))
{
fprintf (stderr, "Table... | AcpiDump: Allow tables that contain only an ACPI table header. |
--- source/compiler/aslcompile.c
+++ source/compiler/aslcompile.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: aslcompile - top level compile module
- * $Revision: 1.77 $
+ * $Revision: 1.78 $
*
**********************... | Exit with non-zero on error |
--- source/components/hardware/hwregs.c
+++ source/components/hardware/hwregs.c
@@ -382,17 +382,19 @@ AcpiHwClearAcpiStatus (
Status = AcpiHwRegisterWrite (ACPI_REGISTER_PM1_STATUS,
ACPI_BITMASK_ALL_FIXED_STATUS);
+
+ AcpiOsReleaseLock (AcpiGbl_HardwareLock, LockFlags);
+
if (ACPI_FAILUR... | Hardware: Fix possible recursive locking in hwregs.c |
--- source/compiler/asltransform.c
+++ source/compiler/asltransform.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: asltransform - Parse tree transforms
- * $Revision: 1.27 $
+ * $Revision: 1.28 $
*
*******************... | update a comment |
--- source/components/namespace/nsload.c
+++ source/components/namespace/nsload.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: nsload - namespace loading/expanding/contracting procedures
- * $Revision: 1.49 $
+ * $Revisio... | Added support for FADT, FACS in AcpiInstallTable. |
--- source/components/parser/psargs.c
+++ source/components/parser/psargs.c
@@ -1051,6 +1051,9 @@ AcpiPsGetNextArg (
if (Arg->Common.AmlOpcode == AML_INT_METHODCALL_OP)
{
+ /* Free method call op and corresponding namestring sub-ob */
+
+ AcpiPsFreeOp (Arg->Comm... | Fix memory leak on unusual memory leak |
--- source/components/events/evgpeblk.c
+++ source/components/events/evgpeblk.c
@@ -613,6 +613,19 @@ AcpiEvInitializeGpeBlock (
GpeIndex = (i * ACPI_GPE_REGISTER_WIDTH) + j;
GpeEventInfo = &GpeBlock->EventInfo[GpeIndex];
+ GpeNumber = GpeIndex + GpeBlock->BlockBaseNumber;
+
+ ... | Ensure GPEs are not enabled twice. |
--- source/compiler/aslwalks.c
+++ source/compiler/aslwalks.c
@@ -176,9 +176,12 @@ AnMethodTypingWalkEnd (
* The called method is untyped at this time (typically a
* forward reference).
*
- * Check for a recursive method call first.
+ ... | iASL: Fix a possible fault in a Return statement |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -524,19 +524,19 @@ PsParseLoop (
switch (Op->Opcode)
{
- case AML_ByteOp: /* AML_BYTEDATA_ARG */
- case AML_WordOp: /* AML_WORDDATA_ARG */
- case AML_DWordOp: /* AML_DWORDATA_A... | Fix to support method references without mistaking them for method |
--- source/components/events/evregion.c
+++ source/components/events/evregion.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: evregion - ACPI AddressSpace (OpRegion) handler dispatch
- * $Revision: 1.120 $
+ * $Revision: 1... | Macro rename and cleanup |
--- source/os_specific/service_layers/osunixxf.c
+++ source/os_specific/service_layers/osunixxf.c
@@ -879,10 +879,17 @@ AcpiOsDeleteSemaphore (
return (AE_BAD_PARAMETER);
}
+#ifdef __APPLE__
+ if (sem_close (Sem) == -1)
+ {
+ return (AE_BAD_PARAMETER);
+ }
+#else
if (sem_destroy (Se... | MacOSX: Fix wrong sem_destroy definition |
--- source/include/acglobal.h
+++ source/include/acglobal.h
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Name: acglobal.h - Declarations for global variables
- * $Revision: 1.153 $
+ * $Revision: 1.154 $
*
**************************************... | automated code cleanup |
--- source/include/amlresrc.h
+++ source/include/amlresrc.h
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: amlresrc.h - AML resource descriptors
- * $Revision: 1.25 $
+ * $Revision: 1.26 $
*
****************************... | Support for ACPI 3.0 Register macro, new parameter |
--- source/components/utilities/utdelete.c
+++ source/components/utilities/utdelete.c
@@ -388,6 +388,11 @@ CmDeleteInternalObj (
FUNCTION_TRACE_PTR ("CmDeleteInternalObj", Object);
+ if (!Object)
+ {
+ return_VOID;
+ }
+
/* Only delete the object when the reference count reaches zero */
... | date 99.09.24.23.01.00; author grsmith1; state Exp; |
--- source/tools/acpisrc/astable.c
+++ source/tools/acpisrc/astable.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: astable - Tables used for source conversion
- * $Revision: 1.18 $
+ * $Revision: 1.19 $
*
************... | 2008 Copyright support added. |
--- source/components/executer/exutils.c
+++ source/components/executer/exutils.c
@@ -2,7 +2,7 @@
/******************************************************************************
*
* Module Name: exutils - interpreter/scanner utilities
- * $Revision: 1.107 $
+ * $Revision: 1.109 $
*
**... | fix DigitsNeeded for 0 (Takayoshi Kochi) |
--- source/components/utilities/utalloc.c
+++ source/components/utilities/utalloc.c
@@ -121,8 +121,9 @@
#include <namespace.h>
#include <globals.h>
-#define _THIS_MODULE "cmalloc.c"
#define _COMPONENT MISCELLANEOUS
+ MODULE_NAME ("cmalloc");
+
/*
* Most of this code is for track... | Macro support to eliminate excessive debug string duplication |
--- source/compiler/aslopcodes.c
+++ source/compiler/aslopcodes.c
@@ -956,7 +956,7 @@ OpcDoPld (
{
UINT8 *Buffer;
ACPI_PARSE_OBJECT *Node;
- ACPI_PLD_INFO PldInfo = {0};
+ ACPI_PLD_INFO PldInfo;
ACPI_PARSE_OBJECT *NewOp;
@@ -979,6 +979,8 @@ Opc... | iASL: Update for ToPLD macro. |
--- source/components/executer/exsystem.c
+++ source/components/executer/exsystem.c
@@ -382,7 +382,7 @@ ACPI_STATUS
OsGetGlobalLock(void)
{
UINT32 GlobalLockReg;
- ACPI_STATUS Status;
+ ACPI_STATUS Status = AE_OK;
if (FACS)
| Initialized Status, line 386. |
--- source/components/parser/psparse.c
+++ source/components/parser/psparse.c
@@ -1,7 +1,7 @@
/******************************************************************************
*
* Module Name: psparse - Parser top level AML parse routines
- * $Revision: 1.124 $
+ * $Revision: 1.125 $
*
... | Fourth pass to include lint changes/comments/cleanup (64-bit) |
--- source/components/namespace/nsaccess.c
+++ source/components/namespace/nsaccess.c
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: nsaccess - Top-level functions for accessing ACPI namespace
- * $Revision: 1.163 $
+ * $R... | Init Mutex Node. Set proper type for single-nameseg case |
--- src/lib/Libifl/trq_auth.c
+++ src/lib/Libifl/trq_auth.c
@@ -998,6 +998,9 @@ int authorize_socket(
if (trq_server_addr != NULL)
free(trq_server_addr);
+ if (server_name != NULL)
+ free(server_name);
+
return(rc);
} // END authorize_socket()
| TRQ-3017 Leak in trqauthd |
--- src/lib/Libutils/numa_chip.cpp
+++ src/lib/Libutils/numa_chip.cpp
@@ -1425,6 +1425,14 @@ void Chip::calculateStepCounts(
int &place_count_remaining)
{
+ if (lprocs_per_task == 0)
+ {
+ step = 0;
+ step_remainder = processing_units_per_task;
+ place_count = 0;
+ return;
+ }
+
if... | Made it so cores or threads can be allocated on |
--- src/resmom/requests.c
+++ src/resmom/requests.c
@@ -2469,7 +2469,7 @@ int req_stat_job(
*/
snprintf(name, sizeof(name), "%s", preq->rq_ind.rq_status.rq_id);
- name[(PBS_MAXSVRJOBID > PBS_MAXDEST ? PBS_MAXSVRJOBID:PBS_MAXDEST)] = '\0';
+ name[sizeof(name) - 1] = '\0';
if ((name[0] == '\0') || (name[0... | Improved a line of code checked in earlier. |
--- src/cmds/qstat.c
+++ src/cmds/qstat.c
@@ -1366,7 +1366,8 @@ void display_statjob(
}
}
- c++; /* List the first part of the server name, too. */
+ if (*c != '\0')
+ c++; /* List the first part of the server name, too. */
while ((*c != '.') && (*c != '... | Avoid reading/writing past the end of a buffer with display_job_server_suffix=false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.