File size: 9,393 Bytes
ea8c728 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 | """
Tests for visualization data sanitization.
Ensures -inf, +inf, and NaN values are properly sanitized for JSON serialization.
"""
import json
import math
import os
import sys
import unittest
class TestCheckJsonFloat(unittest.TestCase):
"""Tests for the check_json_float helper function"""
@classmethod
def setUpClass(cls):
"""Add scripts directory to path for importing visualizer"""
cls.scripts_path = os.path.join(
os.path.dirname(__file__), "..", "scripts"
)
sys.path.insert(0, cls.scripts_path)
@classmethod
def tearDownClass(cls):
"""Remove scripts directory from path"""
if cls.scripts_path in sys.path:
sys.path.remove(cls.scripts_path)
def test_valid_positive_float(self):
"""Test that positive floats are valid"""
try:
from visualizer import check_json_float
self.assertTrue(check_json_float(1.5))
self.assertTrue(check_json_float(100.0))
self.assertTrue(check_json_float(0.001))
except ImportError:
self.skipTest("Visualizer module not available")
def test_valid_negative_float(self):
"""Test that negative floats are valid"""
try:
from visualizer import check_json_float
self.assertTrue(check_json_float(-1.5))
self.assertTrue(check_json_float(-100.0))
except ImportError:
self.skipTest("Visualizer module not available")
def test_valid_zero(self):
"""Test that zero is valid"""
try:
from visualizer import check_json_float
self.assertTrue(check_json_float(0))
self.assertTrue(check_json_float(0.0))
except ImportError:
self.skipTest("Visualizer module not available")
def test_valid_integer(self):
"""Test that integers are valid"""
try:
from visualizer import check_json_float
self.assertTrue(check_json_float(1))
self.assertTrue(check_json_float(-5))
self.assertTrue(check_json_float(1000))
except ImportError:
self.skipTest("Visualizer module not available")
def test_invalid_positive_infinity(self):
"""Test that positive infinity is invalid"""
try:
from visualizer import check_json_float
self.assertFalse(check_json_float(float('inf')))
except ImportError:
self.skipTest("Visualizer module not available")
def test_invalid_negative_infinity(self):
"""Test that negative infinity is invalid"""
try:
from visualizer import check_json_float
self.assertFalse(check_json_float(float('-inf')))
except ImportError:
self.skipTest("Visualizer module not available")
def test_invalid_nan(self):
"""Test that NaN is invalid"""
try:
from visualizer import check_json_float
self.assertFalse(check_json_float(float('nan')))
except ImportError:
self.skipTest("Visualizer module not available")
def test_invalid_none(self):
"""Test that None is invalid (not a number)"""
try:
from visualizer import check_json_float
self.assertFalse(check_json_float(None))
except ImportError:
self.skipTest("Visualizer module not available")
class TestSanitizeProgramForVisualization(unittest.TestCase):
"""Tests for the sanitize_program_for_visualization function"""
@classmethod
def setUpClass(cls):
"""Add scripts directory to path for importing visualizer"""
cls.scripts_path = os.path.join(
os.path.dirname(__file__), "..", "scripts"
)
sys.path.insert(0, cls.scripts_path)
@classmethod
def tearDownClass(cls):
"""Remove scripts directory from path"""
if cls.scripts_path in sys.path:
sys.path.remove(cls.scripts_path)
def test_sanitize_negative_infinity_in_metrics(self):
"""Test that -inf in metrics is sanitized to None"""
try:
from visualizer import sanitize_program_for_visualization
program = {
"metrics": {"combined_score": float('-inf')},
"metadata": {}
}
sanitize_program_for_visualization(program)
self.assertIsNone(program["metrics"]["combined_score"])
except ImportError:
self.skipTest("Visualizer module not available")
def test_sanitize_positive_infinity_in_metrics(self):
"""Test that +inf in metrics is sanitized to None"""
try:
from visualizer import sanitize_program_for_visualization
program = {
"metrics": {"score": float('inf')},
"metadata": {}
}
sanitize_program_for_visualization(program)
self.assertIsNone(program["metrics"]["score"])
except ImportError:
self.skipTest("Visualizer module not available")
def test_sanitize_nan_in_metrics(self):
"""Test that NaN in metrics is sanitized to None"""
try:
from visualizer import sanitize_program_for_visualization
program = {
"metrics": {"validity": float('nan')},
"metadata": {}
}
sanitize_program_for_visualization(program)
self.assertIsNone(program["metrics"]["validity"])
except ImportError:
self.skipTest("Visualizer module not available")
def test_valid_metrics_unchanged(self):
"""Test that valid metrics are not changed"""
try:
from visualizer import sanitize_program_for_visualization
program = {
"metrics": {"score": 0.85, "validity": 1.0},
"metadata": {}
}
sanitize_program_for_visualization(program)
self.assertEqual(program["metrics"]["score"], 0.85)
self.assertEqual(program["metrics"]["validity"], 1.0)
except ImportError:
self.skipTest("Visualizer module not available")
def test_sanitize_parent_metrics(self):
"""Test that parent_metrics are also sanitized"""
try:
from visualizer import sanitize_program_for_visualization
program = {
"metrics": {"score": 0.5},
"metadata": {
"parent_metrics": {
"score": float('inf'),
"other": 1.0,
}
}
}
sanitize_program_for_visualization(program)
self.assertIsNone(program["metadata"]["parent_metrics"]["score"])
self.assertEqual(program["metadata"]["parent_metrics"]["other"], 1.0)
except ImportError:
self.skipTest("Visualizer module not available")
def test_mixed_valid_and_invalid_values(self):
"""Test sanitization with mix of valid and invalid values"""
try:
from visualizer import sanitize_program_for_visualization
program = {
"metrics": {
"score": 0.5,
"combined_score": float('-inf'),
"validity": float('nan'),
"eval_time": 1.23,
},
"metadata": {}
}
sanitize_program_for_visualization(program)
self.assertEqual(program["metrics"]["score"], 0.5)
self.assertIsNone(program["metrics"]["combined_score"])
self.assertIsNone(program["metrics"]["validity"])
self.assertEqual(program["metrics"]["eval_time"], 1.23)
except ImportError:
self.skipTest("Visualizer module not available")
class TestJsonSerialization(unittest.TestCase):
"""Tests for JSON serialization of sanitized data"""
def test_sanitized_data_is_json_serializable(self):
"""Test that sanitized data can be JSON serialized"""
data = {
"metrics": {
"score": None, # Sanitized from -inf
"other": 1.0,
}
}
# This should not raise an error
json_str = json.dumps(data)
self.assertIn('"score": null', json_str)
def test_unsanitized_infinity_fails_strict_json(self):
"""Test that unsanitized infinity fails strict JSON serialization"""
data = {"score": float('inf')}
# With allow_nan=False (strict JSON compliance), this should fail
with self.assertRaises(ValueError):
json.dumps(data, allow_nan=False)
def test_unsanitized_nan_fails_strict_json(self):
"""Test that unsanitized NaN fails strict JSON serialization"""
data = {"score": float('nan')}
# With allow_nan=False (strict JSON compliance), this should fail
with self.assertRaises(ValueError):
json.dumps(data, allow_nan=False)
def test_sanitized_none_works_with_strict_json(self):
"""Test that sanitized None values work with strict JSON"""
data = {"score": None} # Properly sanitized
# Should work with strict JSON
json_str = json.dumps(data, allow_nan=False)
self.assertIn('"score": null', json_str)
if __name__ == "__main__":
unittest.main()
|