Publish tests/ from marimo

tests/test_accessibility.py

@@ -10,10 +10,12 @@ import os
 import pytest
 from PIL import Image
 
+import platform
+
 from tiny_computer_agent import (
     INTERACTIVE_ROLES, TEXT_ROLES, AccessibleNode, AtspiDetector, AtspiReader,
-    AutoDetector, Element, IndexedScreen, Observation, detector_available,
-    make_detector,
+    AutoDetector, Element, GridDetector, IndexedScreen, Observation, UiaDetector,
+    UiaReader, detector_available, make_detector,
 )
 from tiny_computer_agent.accessibility import accessibility_available
 from tiny_computer_agent.perception import DetectorUnavailable
@@ -131,6 +133,28 @@ def test_screen_coordinates_are_not_double_mapped_by_a_downscaled_capture():
     assert (save.x, save.y) == (390, 201), "the accessibility tree was scaled twice"
 
 
+def test_the_chain_reports_the_space_of_the_branch_it_used():
+    """The bug this pins down: `best` wraps the tree detector, so a *static* flag
+    said "frame" and every accessibility click was re-mapped through the downscale
+    - shifting it by the capture's scale factor, silently."""
+    tree = AtspiDetector(reader=FakeReader([node("button", "Save", 390, 201, 100, 36)]))
+
+    class Empty:
+        name = "empty"
+
+        def detect(self, image=None):
+            return ()
+
+    chained = AutoDetector(accessibility=tree, grid=GridDetector(rows=1, cols=2))
+    observation = IndexedScreen(ScaledSource(), chained).capture()
+    assert observation.elements[0].x == 390, "the chained tree index was double-mapped"
+
+    chained.accessibility = Empty()                      # now the grid answers
+    observation = IndexedScreen(ScaledSource(), chained).capture()
+    assert observation.elements[0].x == 0                # frame space: mapped
+    assert chained.coordinates_of_last_detect() == "frame"
+
+
 def test_a_frame_relative_detector_is_still_mapped():
     """The opt-out is per-detector: a grid in a downscaled frame must be mapped."""
     from tiny_computer_agent import GridDetector
@@ -151,9 +175,7 @@ def test_a_reader_that_cannot_reach_the_bus_raises_rather_than_lying():
         AtspiDetector(reader=Broken()).detect()
 
 
-def test_ui_automation_is_reported_as_not_implemented():
-    ok, detail = accessibility_available("uia")
-    assert ok is False and "not implemented" in detail
+def test_an_unknown_accessibility_backend_is_refused():
     assert accessibility_available("telepathy")[0] is False
 
 
@@ -226,6 +248,103 @@ def test_the_new_detector_names_are_reachable():
     assert TEXT_ROLES and "label" in TEXT_ROLES
 
 
+# -- the Windows backend: its mapping, exercised without Windows ---------------
+
+class FakeBox:
+    def __init__(self, left, top, right, bottom):
+        self.left, self.top, self.right, self.bottom = left, top, right, bottom
+
+
+class FakeControl:
+    """The slice of a UI Automation control element this reader actually uses."""
+
+    def __init__(self, name, control_type, box=None, children=()):
+        self.Name = name
+        self.ControlTypeName = control_type
+        self.BoundingRectangle = box
+        self._children = list(children)
+
+    def GetChildren(self):
+        return self._children
+
+
+def uia_tree():
+    """The same window the GTK app opens, as UI Automation would report it."""
+    return FakeControl("Accessible desktop", "WindowControl", FakeBox(160, 160, 620, 380), [
+        FakeControl("", "PaneControl", FakeBox(174, 174, 606, 366), [
+            FakeControl("Files", "ButtonControl", FakeBox(174, 201, 274, 237)),
+            FakeControl("Terminal", "ButtonControl", FakeBox(282, 201, 382, 237)),
+            FakeControl("Save", "ButtonControl", FakeBox(390, 201, 490, 237)),
+            FakeControl("Cancel", "ButtonControl", FakeBox(498, 201, 598, 237)),
+            FakeControl("Choose an action", "TextControl", FakeBox(174, 245, 598, 264)),
+        ]),
+    ])
+
+
+def uia_elements():
+    return UiaDetector(reader=UiaReader(provider=uia_tree)).detect()
+
+
+def test_uia_maps_control_types_to_the_roles_the_harness_speaks():
+    assert [(e.label, e.kind) for e in uia_elements()] == [
+        ("Files", "button"), ("Terminal", "button"), ("Save", "button"), ("Cancel", "button")]
+    save = next(e for e in uia_elements() if e.label == "Save")
+    assert (save.x, save.y, save.width, save.height) == (390, 201, 100, 36)
+    assert save.center == (440, 219)
+
+
+def test_uia_window_furniture_is_not_offered_as_a_choice():
+    """A window and a pane have names too, and neither is a button."""
+    roles = {e.kind for e in uia_elements()}
+    assert roles == {"button"}
+
+
+def test_uia_keeps_an_unnamed_container_but_walks_into_it():
+    """The pane has no name, so it is not an element - its children still are."""
+    assert all(e.label for e in uia_elements())
+    assert len(uia_elements()) == 4
+
+
+def test_uia_respects_the_depth_and_node_caps():
+    deep = UiaReader(provider=uia_tree, max_depth=1)
+    assert [e.label for e in UiaDetector(reader=deep).detect()] == []
+    # the window itself is the first node, so the cap of two leaves one button
+    capped = UiaReader(provider=uia_tree, max_nodes=2)
+    assert [e.label for e in UiaDetector(reader=capped).detect()] == ["Files"]
+
+
+def test_uia_detector_text_reads_the_tree_too():
+    assert "Choose an action" in UiaDetector(reader=UiaReader(provider=uia_tree)).text()
+
+
+def test_the_windows_backend_is_reported_honestly_on_this_machine():
+    ok, detail = accessibility_available("uia")
+    if platform.system() == "Windows":
+        return                      # on Windows this is a real, working backend
+    assert ok is False and "Windows-only" in detail
+
+
+def test_the_uia_reader_refuses_rather_than_returning_an_empty_index():
+    if platform.system() == "Windows":
+        pytest.skip("this machine really is Windows")
+    with pytest.raises(DetectorUnavailable, match="Windows-only"):
+        UiaReader().read()
+
+
+def test_the_detector_names_cover_both_backends():
+    assert type(make_detector("atspi")).__name__ == "AtspiDetector"
+    ok, detail = detector_available("uia")
+    assert isinstance(ok, bool) and detail
+
+
+def test_a_provider_that_throws_is_reported_as_unavailable():
+    def broken():
+        raise RuntimeError("COM is not initialised")
+
+    with pytest.raises(DetectorUnavailable, match="could not reach UI Automation"):
+        UiaReader(provider=broken).read()
+
+
 # -- the one test that drives real AT-SPI ------------------------------------
 
 OPT_IN = os.environ.get("TINY_COMPUTER_AGENT_LIVE_TEST") == "1"