refactor: extract hook::install() helper to reduce hook boilerplate

Each hook installation was 12-14 lines of repeated MinHook setup.
New hook::install(name, addr, detour) handles create_hook, enable_hook,
and logging, returning the trampoline pointer. Each call site is now
4-5 lines.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

crates/openwa-wormkit/src/hook.rs

@@ -0,0 +1,38 @@
+//! MinHook helper for installing inline hooks on WA.exe functions.
+
+use std::ffi::c_void;
+
+use minhook::MinHook;
+
+use crate::log_line;
+use crate::rebase::rb;
+
+/// Install a MinHook inline hook on a WA.exe function.
+///
+/// - `name`: human-readable name for log/error messages
+/// - `ghidra_addr`: Ghidra VA of the target function (rebased automatically)
+/// - `detour`: replacement function pointer
+///
+/// Returns the trampoline pointer (for calling the original).
+/// Caller can store it in an `AtomicU32` if needed, or discard with `let _ =`.
+pub unsafe fn install(
+    name: &str,
+    ghidra_addr: u32,
+    detour: *const (),
+) -> Result<*mut c_void, String> {
+    let target = rb(ghidra_addr) as *mut c_void;
+    let detour = detour as *mut c_void;
+
+    let trampoline = MinHook::create_hook(target, detour)
+        .map_err(|e| format!("MinHook create_hook failed for {name}: {e}"))?;
+
+    MinHook::enable_hook(target)
+        .map_err(|e| format!("MinHook enable_hook failed for {name}: {e}"))?;
+
+    let _ = log_line(&format!(
+        "  [REPLACE] {name}: target 0x{:08X}, trampoline 0x{:08X}",
+        target as u32, trampoline as u32
+    ));
+
+    Ok(trampoline)
+}

crates/openwa-wormkit/src/lib.rs

@@ -2,6 +2,7 @@
 
 use std::ffi::c_void;
 
+pub mod hook;
 pub mod rebase;
 pub mod wa_call;
 mod replacements;

crates/openwa-wormkit/src/replacements/frontend.rs

@@ -3,11 +3,8 @@
 //! Original: 0x447A20, stdcall(screen_id), ESI = dialog this (__usercall).
 //! Navigates between frontend menu screens via MFC CDialog::EndDialog.
 
-use std::ffi::c_void;
 use std::sync::atomic::{AtomicU32, Ordering};
 
-use minhook::MinHook;
-
 use crate::log_line;
 use crate::rebase::rb;
 use crate::wa_call;
@@ -97,21 +94,12 @@ unsafe extern "cdecl" fn frontend_change_screen_impl(dialog: u32, screen_id: u32
 
 pub fn install() -> Result<(), String> {
     unsafe {
-        let target = rb(va::FRONTEND_CHANGE_SCREEN) as *mut c_void;
-        let detour = trampoline as *const () as *mut c_void;
-
-        let trampoline_ptr = MinHook::create_hook(target, detour)
-            .map_err(|e| format!("MinHook create_hook failed for FrontendChangeScreen: {e}"))?;
-
-        MinHook::enable_hook(target)
-            .map_err(|e| format!("MinHook enable_hook failed for FrontendChangeScreen: {e}"))?;
-
+        let trampoline_ptr = crate::hook::install(
+            "FrontendChangeScreen",
+            va::FRONTEND_CHANGE_SCREEN,
+            trampoline as *const (),
+        )?;
         ORIG_FRONTEND_CHANGE_SCREEN.store(trampoline_ptr as u32, Ordering::Relaxed);
-
-        let _ = log_line(&format!(
-            "  [REPLACE] FrontendChangeScreen: target 0x{:08X}, trampoline 0x{:08X}",
-            target as u32, trampoline_ptr as u32
-        ));
     }
 
     Ok(())

crates/openwa-wormkit/src/replacements/scheme.rs

@@ -5,14 +5,11 @@
 //! - Scheme__ValidateExtendedOptions (0x4D5110): pure Rust validation
 //! - Scheme__FileExists (0x4D4CD0): Rust path check
 
-use std::ffi::{c_void, CStr};
+use std::ffi::CStr;
 use std::path::Path;
 use std::sync::atomic::{AtomicU32, Ordering};
 
-use minhook::MinHook;
-
 use crate::log_line;
-use crate::rebase::rb;
 use openwa_types::address::va;
 use openwa_types::scheme::{
     ExtendedOptions, SchemeFile, SchemeVersion, EXTENDED_OPTIONS_DEFAULTS, EXTENDED_OPTIONS_SIZE,
@@ -225,62 +222,24 @@ unsafe extern "stdcall" fn hook_scheme_file_exists(name: u32) -> u32 {
 
 pub fn install() -> Result<(), String> {
     unsafe {
-        // Hook Scheme__ReadFile (0x4D3890) — full Rust replacement
-        {
-            let target = rb(va::SCHEME_READ_FILE) as *mut c_void;
-            let detour = hook_scheme_read_file as *const () as *mut c_void;
-
-            let trampoline = MinHook::create_hook(target, detour)
-                .map_err(|e| format!("MinHook create_hook failed for Scheme__ReadFile: {e}"))?;
-
-            MinHook::enable_hook(target)
-                .map_err(|e| format!("MinHook enable_hook failed for Scheme__ReadFile: {e}"))?;
-
-            ORIG_SCHEME_READ_FILE.store(trampoline as u32, Ordering::Relaxed);
-
-            let _ = log_line(&format!(
-                "  [REPLACE] Scheme__ReadFile: target 0x{:08X}, trampoline 0x{:08X}",
-                target as u32, trampoline as u32
-            ));
-        }
-
-        // Hook Scheme__ValidateExtendedOptions (0x4D5110) — full Rust replacement
-        {
-            let target = rb(va::SCHEME_VALIDATE_EXTENDED_OPTIONS) as *mut c_void;
-            let detour = trampoline_validate_ext_opts as *const () as *mut c_void;
-
-            MinHook::create_hook(target, detour).map_err(|e| {
-                format!("MinHook create_hook failed for ValidateExtendedOptions: {e}")
-            })?;
-
-            MinHook::enable_hook(target).map_err(|e| {
-                format!("MinHook enable_hook failed for ValidateExtendedOptions: {e}")
-            })?;
-
-            let _ = log_line(&format!(
-                "  [REPLACE] Scheme__ValidateExtendedOptions: target 0x{:08X}",
-                target as u32
-            ));
-        }
-
-        // Hook Scheme__FileExists (0x4D4CD0) — full Rust replacement
-        {
-            let target = rb(va::SCHEME_FILE_EXISTS) as *mut c_void;
-            let detour = hook_scheme_file_exists as *const () as *mut c_void;
-
-            MinHook::create_hook(target, detour).map_err(|e| {
-                format!("MinHook create_hook failed for Scheme__FileExists: {e}")
-            })?;
-
-            MinHook::enable_hook(target).map_err(|e| {
-                format!("MinHook enable_hook failed for Scheme__FileExists: {e}")
-            })?;
-
-            let _ = log_line(&format!(
-                "  [REPLACE] Scheme__FileExists: target 0x{:08X}",
-                target as u32
-            ));
-        }
+        let trampoline = crate::hook::install(
+            "Scheme__ReadFile",
+            va::SCHEME_READ_FILE,
+            hook_scheme_read_file as *const (),
+        )?;
+        ORIG_SCHEME_READ_FILE.store(trampoline as u32, Ordering::Relaxed);
+
+        let _ = crate::hook::install(
+            "Scheme__ValidateExtendedOptions",
+            va::SCHEME_VALIDATE_EXTENDED_OPTIONS,
+            trampoline_validate_ext_opts as *const (),
+        )?;
+
+        let _ = crate::hook::install(
+            "Scheme__FileExists",
+            va::SCHEME_FILE_EXISTS,
+            hook_scheme_file_exists as *const (),
+        )?;
     }
 
     Ok(())