refactor: add RQ_ prefix to render queue addresses, label pipeline in Ghidra

Rename all RenderQueue enqueue function constants with RQ_ prefix for
consistency (e.g., DRAW_PIXEL -> RQ_DRAW_PIXEL). Add 20 new address
constants for helpers, pipeline functions, and the type 0xE enqueue.
Label 25 functions in Ghidra including 7 RQ helpers and 7 render
pipeline functions. Document complete render queue system in
docs/re-notes/render-queue.md.

Research findings:
- All 11 standalone enqueue functions identified (types 0-14 switch,
but types 3/7/10/12 have no standalone enqueue — inlined or unused)
- DDDisplay vtable drawing method map (12 slots at 0x2C-0x58)
- Render pipeline: RenderFrame -> GameRender -> RQ_RenderDrawingQueue

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

crates/openwa-harness/src/lib.rs

@@ -409,7 +409,7 @@ mod tests {
             ("FireWeapon", va::FIRE_WEAPON),
             ("InitWeaponTable", va::INIT_WEAPON_TABLE),
             ("BlitScreen", va::BLIT_SCREEN),
-            ("RenderDrawingQueue", va::RENDER_DRAWING_QUEUE),
+            ("RenderDrawingQueue", va::RQ_RENDER_DRAWING_QUEUE),
             ("DrawLandscape", va::DRAW_LANDSCAPE),
             ("ConstructPCLandscape", va::CONSTRUCT_PC_LANDSCAPE),
             ("ConstructDSSound", va::CONSTRUCT_DS_SOUND),

crates/openwa-types/src/address.rs

@@ -158,16 +158,37 @@ pub mod va {
     pub const CONSTRUCT_DD_DISPLAY: u32 = 0x0056_9D00;
     pub const CONSTRUCT_FRAME_BUFFER: u32 = 0x005A_2430;
     pub const BLIT_SCREEN: u32 = 0x005A_2020;
-    pub const RENDER_DRAWING_QUEUE: u32 = 0x0054_2350;
+    pub const RQ_RENDER_DRAWING_QUEUE: u32 = 0x0054_2350;
     pub const DRAW_LANDSCAPE: u32 = 0x005A_2790;
-    pub const DRAW_PIXEL: u32 = 0x0054_1D60;
-    pub const DRAW_LINE_STRIP: u32 = 0x0054_1DD0;
-    pub const DRAW_POLYGON: u32 = 0x0054_1E50;
-    pub const DRAW_SCALED: u32 = 0x0054_1ED0;
-    pub const DRAW_RECT: u32 = 0x0054_1F40;
-    pub const DRAW_SPRITE_GLOBAL: u32 = 0x0054_1FE0;
-    pub const DRAW_SPRITE_OFFSET: u32 = 0x0054_20E0;
-    pub const DRAW_BITMAP_GLOBAL: u32 = 0x0054_2170;
+    pub const RQ_DRAW_PIXEL: u32 = 0x0054_1D60;
+    pub const RQ_DRAW_LINE_STRIP: u32 = 0x0054_1DD0;
+    pub const RQ_DRAW_POLYGON: u32 = 0x0054_1E50;
+    pub const RQ_DRAW_SCALED: u32 = 0x0054_1ED0;
+    pub const RQ_DRAW_RECT: u32 = 0x0054_1F40;
+    pub const RQ_DRAW_SPRITE_GLOBAL: u32 = 0x0054_1FE0;
+    pub const RQ_DRAW_SPRITE_LOCAL: u32 = 0x0054_2060;
+    pub const RQ_DRAW_SPRITE_OFFSET: u32 = 0x0054_20E0;
+    pub const RQ_DRAW_BITMAP_GLOBAL: u32 = 0x0054_2170;
+    pub const RQ_DRAW_TEXTBOX_LOCAL: u32 = 0x0054_2200;
+    pub const RQ_DRAW_CLIPPED_SPRITE_MAYBE: u32 = 0x0054_22A0;
+
+    // RenderQueue helpers
+    pub const RQ_CLIP_COORDINATES: u32 = 0x0054_2BA0;
+    pub const RQ_GET_CAMERA_OFFSET_MAYBE: u32 = 0x0054_2B10;
+    pub const RQ_CLIP_WITH_REF_OFFSET_MAYBE: u32 = 0x0054_2C70;
+    pub const RQ_TRANSFORM_WITH_ZOOM_MAYBE: u32 = 0x0054_2D50;
+    pub const RQ_SMOOTH_INTERPOLATE_MAYBE: u32 = 0x0054_2E60;
+    pub const RQ_UPDATE_CLIP_BOUNDS_MAYBE: u32 = 0x0054_2F10;
+    pub const RQ_SATURATE_CLIP_BOUNDS_MAYBE: u32 = 0x0054_2F70;
+
+    // Render pipeline
+    pub const RENDER_FRAME_MAYBE: u32 = 0x0056_E040;
+    pub const GAME_RENDER_MAYBE: u32 = 0x0053_3DC0;
+    pub const RENDER_TERRAIN_MAYBE: u32 = 0x0053_5000;
+    pub const RENDER_HUD_MAYBE: u32 = 0x0053_4F20;
+    pub const RENDER_TURN_STATUS_MAYBE: u32 = 0x0053_4E00;
+    pub const PALETTE_MANAGE_MAYBE: u32 = 0x0053_3C80;
+    pub const PALETTE_ANIMATE_MAYBE: u32 = 0x0053_3A80;
     pub const LOAD_SPRITE: u32 = 0x0052_3400;
     pub const CONSTRUCT_OPENGL_CPU: u32 = 0x005A_0850;
     pub const OPENGL_INIT: u32 = 0x0059_F000;
@@ -200,9 +221,6 @@ pub mod va {
     /// ProcessSprite — usercall EAX=sprite_ptr, 1 stack param (raw_data_ptr).
     /// Parses .spr binary format: palette, frames, bitmap data.
     pub const PROCESS_SPRITE: u32 = 0x004F_AB80;
-    /// DrawSpriteLocal — thiscall + EAX=y_pos (usercall), 4 stack params.
-    /// Enqueues draw command type 5 (screen-space). See DrawSpriteGlobal (type 4).
-    pub const DRAW_SPRITE_LOCAL: u32 = 0x0054_2060;
 
     // === Landscape ===
 
@@ -388,8 +406,6 @@ pub mod va {
     pub const DDDISPLAY_CONSTRUCT_TEXTBOX: u32 = 0x004F_AF00;
     /// SetTextboxText — stdcall(textbox, msg, textcolor, color1, color2, a6, a7, opacity)
     pub const SET_TEXTBOX_TEXT: u32 = 0x004F_B070;
-    /// DrawTextboxLocal — draws textbox at screen position
-    pub const DRAW_TEXTBOX_LOCAL: u32 = 0x0054_2200;
 
     // === Global variables (in .data) ===
 

crates/openwa-wormkit/src/replacements/render.rs

@@ -605,61 +605,61 @@ pub fn install() -> Result<(), String> {
     unsafe {
     let _ = hook::install(
         "DrawPixel",
-        va::DRAW_PIXEL,
+        va::RQ_DRAW_PIXEL,
         trampoline_draw_pixel as *const (),
     )?;
 
     let _ = hook::install(
         "DrawLineStrip",
-        va::DRAW_LINE_STRIP,
+        va::RQ_DRAW_LINE_STRIP,
         trampoline_draw_line_strip as *const (),
     )?;
 
     let _ = hook::install(
         "DrawPolygon",
-        va::DRAW_POLYGON,
+        va::RQ_DRAW_POLYGON,
         trampoline_draw_polygon as *const (),
     )?;
 
     let _ = hook::install(
         "DrawScaled",
-        va::DRAW_SCALED,
+        va::RQ_DRAW_SCALED,
         trampoline_draw_scaled as *const (),
     )?;
 
     let _ = hook::install(
         "DrawRect",
-        va::DRAW_RECT,
+        va::RQ_DRAW_RECT,
         trampoline_draw_rect as *const (),
     )?;
 
     let _ = hook::install(
         "DrawSpriteGlobal",
-        va::DRAW_SPRITE_GLOBAL,
+        va::RQ_DRAW_SPRITE_GLOBAL,
         trampoline_draw_sprite_global as *const (),
     )?;
 
     let _ = hook::install(
         "DrawSpriteLocal",
-        va::DRAW_SPRITE_LOCAL,
+        va::RQ_DRAW_SPRITE_LOCAL,
         trampoline_draw_sprite_local as *const (),
     )?;
 
     let _ = hook::install(
         "DrawSpriteOffset",
-        va::DRAW_SPRITE_OFFSET,
+        va::RQ_DRAW_SPRITE_OFFSET,
         trampoline_draw_sprite_offset as *const (),
     )?;
 
     let _ = hook::install(
         "DrawBitmapGlobal",
-        va::DRAW_BITMAP_GLOBAL,
+        va::RQ_DRAW_BITMAP_GLOBAL,
         trampoline_draw_bitmap_global as *const (),
     )?;
 
     let _ = hook::install(
         "DrawTextboxLocal",
-        va::DRAW_TEXTBOX_LOCAL,
+        va::RQ_DRAW_TEXTBOX_LOCAL,
         trampoline_draw_textbox_local as *const (),
     )?;
 

crates/openwa-wormkit/src/validation/mod.rs

@@ -196,7 +196,7 @@ fn validate_addresses(result: &mut ValidationResult) {
         ("FireWeapon", va::FIRE_WEAPON),
         ("InitWeaponTable", va::INIT_WEAPON_TABLE),
         ("BlitScreen", va::BLIT_SCREEN),
-        ("RenderDrawingQueue", va::RENDER_DRAWING_QUEUE),
+        ("RenderDrawingQueue", va::RQ_RENDER_DRAWING_QUEUE),
         ("DrawLandscape", va::DRAW_LANDSCAPE),
         ("ConstructPCLandscape", va::CONSTRUCT_PC_LANDSCAPE),
         ("ConstructDSSound", va::CONSTRUCT_DS_SOUND),

docs/re-notes/render-queue.md

@@ -0,0 +1,107 @@
+# RenderQueue System
+
+## Overview
+
+WA.exe uses a deferred rendering queue. Game logic enqueues draw commands into a per-frame buffer, then `RQ_RenderDrawingQueue` (0x542350) processes them all at once, sorted by priority/layer.
+
+The RenderQueue lives at DDGame+0x524 (see `ddgame_offsets::RENDER_QUEUE`).
+
+## RenderQueue struct (0x12008 bytes)
+
+| Offset | Size | Field |
+|--------|------|-------|
+| 0x00000 | 4 | `buffer_offset` — write position (grows downward from 0x10000) |
+| 0x00004 | 0x10000 | `_buffer` — command data storage |
+| 0x10004 | 4 | `entry_count` — number of enqueued commands |
+| 0x10008 | 0x2000 | `entry_ptrs[0x800]` — pointers to command entries |
+
+Max 2048 (0x800) entries per frame. Buffer grows downward; each alloc subtracts from `buffer_offset`.
+
+## Command Types (0–14)
+
+The dequeue function uses a switch on command type (first DWORD of each entry).
+
+### Enqueue functions (standalone, all ported to Rust)
+
+| Type | Function | Address | DDDisplay vtable | Purpose |
+|------|----------|---------|------------------|---------|
+| 0 | RQ_DrawRect | 0x541F40 | [0x48] | Filled rectangle (clipped) |
+| 1 | RQ_DrawBitmapGlobal | 0x542170 | [0x50] | Bitmap at world position |
+| 2 | RQ_DrawTextboxLocal | 0x542200 | [0x50] | Text box (optional clipping) |
+| 4 | RQ_DrawSpriteGlobal | 0x541FE0 | [0x4C] | Sprite at world position |
+| 5 | RQ_DrawSpriteLocal | 0x542060 | [0x4C] | Sprite at screen position (camera-adjusted) |
+| 6 | RQ_DrawSpriteOffset | 0x5420E0 | [0x4C] | Sprite with optional clipping/rotation |
+| 8 | RQ_DrawLineStrip | 0x541DD0 | [0x38] | Connected line segments (variable-size) |
+| 9 | RQ_DrawPolygon | 0x541E50 | [0x34] | Filled polygon edges (variable-size) |
+| 0xB | RQ_DrawScaled | 0x541ED0 | [0x40] | Scaled sprite |
+| 0xD | RQ_DrawPixel | 0x541D60 | [0x2C] | Single pixel |
+| 0xE | RQ_DrawClippedSprite_Maybe | 0x5422A0 | [0x58] | Sprite with complex clipping (like type 6 but different vtable slot) |
+
+### Types without standalone enqueue functions
+
+These types exist in the dequeue switch but have no standalone enqueue function in the binary. Their enqueue code is either inlined at call sites or unused in WA 3.8.1.
+
+| Type | DDDisplay vtable | Dequeue behavior |
+|------|------------------|------------------|
+| 3 | [0x54] | Coord-clipped, 5 params |
+| 7 | [0x30] | Direct command struct pass, 3 params |
+| 10 | [0x3C] | Camera-adjusted + pixel offset, 6 params |
+| 12 | [0x44] | Like type 0xB but different vtable slot |
+
+## DDDisplay Drawing Vtable
+
+The dequeue function dispatches draw calls through a DDDisplay vtable. Slot offsets:
+
+| Offset | Method | Used by types |
+|--------|--------|---------------|
+| 0x2C | PutPixel | 0xD |
+| 0x30 | (unknown) | 7 |
+| 0x34 | DrawPolygonEdge | 9 |
+| 0x38 | DrawLineSegment | 8 |
+| 0x3C | (unknown) | 10 |
+| 0x40 | DrawScaledSprite | 0xB |
+| 0x44 | (unknown) | 12 |
+| 0x48 | DrawClippedRect | 0 |
+| 0x4C | DrawSprite | 4, 5, 6 |
+| 0x50 | DrawBitmap | 1, 2 |
+| 0x54 | (unknown) | 3 |
+| 0x58 | DrawClippedSprite | 0xE |
+
+## Helper Functions
+
+| Address | Name | Purpose |
+|---------|------|---------|
+| 0x542B10 | RQ_GetCameraOffset_Maybe | Returns camera/viewport offset for screen-space conversion |
+| 0x542BA0 | RQ_ClipCoordinates | Main 16.16 fixed-point coordinate clipping |
+| 0x542C70 | RQ_ClipWithRefOffset_Maybe | Clipping with reference offset transform (type 6 flag 0x04) |
+| 0x542D50 | RQ_TransformWithZoom_Maybe | Coordinate transformation with zoom/scale |
+| 0x542E60 | RQ_SmoothInterpolate_Maybe | Linear interpolation with threshold (smooth scrolling) |
+| 0x542F10 | RQ_UpdateClipBounds_Maybe | Viewport bounding box constraint updater |
+| 0x542F70 | RQ_SaturateClipBounds_Maybe | Clipping with overflow saturation |
+
+## Render Pipeline
+
+| Address | Name | Role |
+|---------|------|------|
+| 0x56E040 | RenderFrame_Maybe | Top-level render frame dispatcher |
+| 0x533DC0 | GameRender_Maybe | Core game render: resets queue, processes scene, calls RQ_RenderDrawingQueue |
+| 0x535000 | RenderTerrain_Maybe | Terrain/landscape viewport rendering |
+| 0x534F20 | RenderHUD_Maybe | HUD/timer display |
+| 0x534E00 | RenderTurnStatus_Maybe | Turn state/status text |
+| 0x533C80 | PaletteManage_Maybe | Palette/color management |
+| 0x533A80 | PaletteAnimate_Maybe | Palette animation/cycling (3 color palettes) |
+
+## Higher-Level Drawing Functions
+
+These are not RenderQueue enqueue methods but call them:
+
+| Address | Name | Notes |
+|---------|------|-------|
+| 0x500720 | DrawBungeeTrail | Uses DrawSpriteLocal + DrawPolygon/DrawLineStrip |
+| 0x5197D0 | DrawCrosshairLine | Uses DrawPolygon + DrawSpriteLocal |
+
+## Dequeue Processing (0x542350)
+
+`RQ_RenderDrawingQueue` sorts entries by priority field (DWORD at entry+4) via `qsort`, then iterates in reverse order (highest priority last = drawn on top). Each command is dispatched through the type switch, with coordinate clipping applied before calling the DDDisplay vtable method.
+
+Fixed-point coordinates (16.16) are right-shifted to pixel values (`>> 0x10`) before passing to DDDisplay methods.