feat: add openwa-config crate with WA installation locator

Centralizes game path discovery into a new openwa-config crate.
find_wa_dir() checks OPENWA_WA_PATH env var then falls back to
HKCU\Software\Team17SoftwareLTD\WormsArmageddon (PATH value).

Removes all hardcoded Steam library paths from launcher, test runner,
and scheme_parse integration test.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Cargo.lock

@@ -1469,6 +1469,13 @@ version = "1.21.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "42f5e15c9953c5e4ccceeb2e7382a716482c34515315f7b03532b8b4e8393d2d"
 
+[[package]]
+name = "openwa-config"
+version = "0.1.0"
+dependencies = [
+ "windows-sys 0.59.0",
+]
+
 [[package]]
 name = "openwa-core"
 version = "0.1.0"
@@ -1476,6 +1483,7 @@ dependencies = [
  "heapless",
  "hound",
  "inventory",
+ "openwa-config",
  "openwa-debug-proto",
  "openwa-derive",
  "windows",
@@ -1518,12 +1526,16 @@ dependencies = [
 [[package]]
 name = "openwa-launcher"
 version = "0.1.0"
+dependencies = [
+ "openwa-config",
+]
 
 [[package]]
 name = "openwa-test-runner"
 version = "0.1.0"
 dependencies = [
  "chrono",
+ "openwa-config",
 ]
 
 [[package]]

crates/openwa-config/Cargo.toml

@@ -0,0 +1,11 @@
+[package]
+name = "openwa-config"
+version = "0.1.0"
+edition = "2021"
+description = "Configuration and installation discovery for OpenWA tools"
+
+[dependencies]
+windows-sys = { version = "0.59", features = [
+    "Win32_Foundation",
+    "Win32_System_Registry",
+] }

crates/openwa-config/src/lib.rs

@@ -0,0 +1,83 @@
+//! Configuration and installation discovery for OpenWA tools.
+
+use std::path::PathBuf;
+
+use windows_sys::Win32::System::Registry::*;
+
+const WA_REGISTRY_KEY: &[u8] = b"Software\\Team17SoftwareLTD\\WormsArmageddon\0";
+const WA_PATH_VALUE: &[u8] = b"PATH\0";
+
+/// Locate the Worms Armageddon installation directory.
+///
+/// Search order:
+/// 1. `OPENWA_WA_PATH` environment variable — may be either the WA.exe path or
+///    the installation directory. If it ends with `.exe`, the parent directory
+///    is returned.
+/// 2. Windows registry: `HKEY_CURRENT_USER\Software\Team17SoftwareLTD\WormsArmageddon`,
+///    value `PATH`.
+///
+/// Returns `None` if the installation cannot be located.
+pub fn find_wa_dir() -> Option<PathBuf> {
+    if let Some(dir) = from_env() {
+        return Some(dir);
+    }
+    from_registry()
+}
+
+fn from_env() -> Option<PathBuf> {
+    let val = std::env::var_os("OPENWA_WA_PATH")?;
+    let path = PathBuf::from(val);
+    // Accept either a WA.exe path or a directory.
+    if path.extension().map(|e| e.eq_ignore_ascii_case("exe")).unwrap_or(false) {
+        path.parent().map(|p| p.to_path_buf())
+    } else {
+        Some(path)
+    }
+}
+
+fn from_registry() -> Option<PathBuf> {
+    let mut buf = [0u8; 512];
+    let len = read_registry_sz(WA_REGISTRY_KEY, WA_PATH_VALUE, &mut buf)?;
+    let s = std::str::from_utf8(&buf[..len]).ok()?;
+    if s.is_empty() {
+        return None;
+    }
+    Some(PathBuf::from(s))
+}
+
+/// Read a REG_SZ value from `HKCU\<key>`. Returns the number of bytes written
+/// to `buf` (excluding null terminator), or `None` on any failure.
+fn read_registry_sz(key: &[u8], value: &[u8], buf: &mut [u8]) -> Option<usize> {
+    unsafe {
+        let mut hkey: HKEY = std::ptr::null_mut();
+        let status = RegOpenKeyExA(
+            HKEY_CURRENT_USER,
+            key.as_ptr(),
+            0,
+            KEY_READ,
+            &mut hkey,
+        );
+        if status != 0 {
+            return None;
+        }
+
+        let mut data_size = buf.len() as u32;
+        let mut value_type: u32 = 0;
+        let status = RegQueryValueExA(
+            hkey,
+            value.as_ptr(),
+            std::ptr::null_mut(),
+            &mut value_type,
+            buf.as_mut_ptr(),
+            &mut data_size,
+        );
+        RegCloseKey(hkey);
+
+        if status != 0 || value_type != REG_SZ || data_size == 0 {
+            return None;
+        }
+
+        // data_size includes the null terminator
+        Some((data_size - 1) as usize)
+    }
+}

crates/openwa-core/Cargo.toml

@@ -11,6 +11,9 @@ inventory = "0.3.22"
 openwa-derive = { path = "../openwa-derive" }
 openwa-debug-proto = { path = "../openwa-debug-proto" }
 
+[dev-dependencies]
+openwa-config = { path = "../openwa-config" }
+
 [target.'cfg(target_os = "windows")'.dependencies]
 windows = { version = "0.62", features = [
     "Win32_Media_Audio_DirectSound",

crates/openwa-core/tests/scheme_parse.rs

@@ -181,8 +181,11 @@ fn v2_super_weapons_zeroed_region() {
 /// Parse all .wsc files from the game directory if available.
 #[test]
 fn parse_all_game_schemes() {
-    let schemes_dir =
-        Path::new("I:/games/SteamLibrary/steamapps/common/Worms Armageddon/User/Schemes");
+    let Some(wa_dir) = openwa_config::find_wa_dir() else {
+        eprintln!("Skipping: WA installation not found");
+        return;
+    };
+    let schemes_dir = wa_dir.join("User/Schemes");
     if !schemes_dir.exists() {
         eprintln!("Skipping: game schemes directory not found");
         return;

crates/openwa-launcher/Cargo.toml

@@ -9,3 +9,4 @@ name = "openwa-launcher"
 path = "src/main.rs"
 
 [dependencies]
+openwa-config = { path = "../openwa-config" }

crates/openwa-launcher/src/main.rs

@@ -111,13 +111,12 @@ fn run() -> Result<(), String> {
         }
     }
 
-    // Locate WA.exe: explicit arg > env var > hardcoded fallback paths.
+    // Locate WA.exe: explicit arg > env var / registry (via openwa-config).
     let wa_exe = if let Some(p) = wa_path_arg {
         PathBuf::from(p)
-    } else if let Ok(p) = std::env::var("OPENWA_WA_PATH") {
-        PathBuf::from(p)
     } else {
-        find_wa_hardcoded()
+        openwa_config::find_wa_dir()
+            .map(|d| d.join("WA.exe"))
             .ok_or("WA.exe not found. Set OPENWA_WA_PATH or pass the path as an argument.")?
     };
 
@@ -296,14 +295,3 @@ fn path_to_cstring(p: &Path) -> Result<CString, String> {
     .map_err(|e| format!("path contains nul byte: {e}"))
 }
 
-/// Try a few well-known default Steam install locations for WA.exe.
-/// Users with non-standard library locations should set OPENWA_WA_PATH instead.
-fn find_wa_hardcoded() -> Option<PathBuf> {
-    const CANDIDATES: &[&str] = &[
-        r"I:\games\SteamLibrary\steamapps\common\Worms Armageddon\WA.exe",
-        r"C:\Program Files (x86)\Steam\steamapps\common\Worms Armageddon\WA.exe",
-        r"C:\Program Files\Steam\steamapps\common\Worms Armageddon\WA.exe",
-    ];
-
-    CANDIDATES.iter().map(PathBuf::from).find(|p| p.exists())
-}

crates/openwa-test-runner/Cargo.toml

@@ -10,3 +10,4 @@ path = "src/main.rs"
 
 [dependencies]
 chrono = "0.4"
+openwa-config = { path = "../openwa-config" }

crates/openwa-test-runner/src/main.rs

@@ -24,11 +24,6 @@ const TIMEOUT_SECS: u64 = 120;
 const REPLAYS_DIR: &str = "testdata/replays";
 const RUNS_DIR: &str = "testdata/runs";
 
-/// Known WA.exe locations to try if not specified.
-const WA_CANDIDATES: &[&str] = &[
-    "I:/games/SteamLibrary/steamapps/common/Worms Armageddon/WA.exe",
-    "C:/Program Files (x86)/Steam/steamapps/common/Worms Armageddon/WA.exe",
-];
 
 // ─── Types ──────────────────────────────────────────────────────────────────
 
@@ -167,22 +162,7 @@ fn find_wa_exe(override_path: Option<&Path>) -> Option<PathBuf> {
             return Some(p.to_path_buf());
         }
     }
-
-    if let Ok(p) = env::var("OPENWA_WA_PATH") {
-        let path = PathBuf::from(p);
-        if path.exists() {
-            return Some(path);
-        }
-    }
-
-    for candidate in WA_CANDIDATES {
-        let path = PathBuf::from(candidate);
-        if path.exists() {
-            return Some(path);
-        }
-    }
-
-    None
+    openwa_config::find_wa_dir().map(|d| d.join("WA.exe"))
 }
 
 fn find_launcher() -> Option<PathBuf> {