feat: replace DSSound slot 0 (destructor) with Rust

Releases all COM objects in correct order: 8 channel desc buffers
(Stop + Release), 500 channel slot buffers (Release), primary buffer
(Stop + Release), IDirectSound (Release). Sets secondary vtable at end.

Update Ghidra names for all converted DSSound vtable methods.

22/24 DSSound vtable slots now Rust. Only slots 3 (play_sound) and
4 (play_sound_pooled) remain.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

crates/openwa-core/src/audio/dssound.rs

@@ -396,6 +396,60 @@ pub unsafe extern "thiscall" fn set_channel_volume(
     1
 }
 
+/// Slot 0: destructor — releases all COM objects and frees memory.
+pub unsafe extern "thiscall" fn destructor(
+    this: *mut DSSound, flags: u8,
+) -> *mut DSSound {
+    let snd = &mut *this;
+
+    // Reset vtable to primary (destructor chain pattern).
+    use crate::address::va;
+    use crate::rebase::rb;
+    snd.vtable = rb(va::DS_SOUND_VTABLE) as *const DSSoundVtable;
+
+    // Release all 8 channel descriptor buffers (Stop + Release).
+    for desc in &mut snd.channel_descs {
+        if let Some(buf) = desc.take_buffer() {
+            let _ = buf.Stop();
+            // Release on drop
+        }
+    }
+
+    // Release all 500 channel slot buffers.
+    for slot in &mut snd.channel_slots {
+        if *slot != 0 {
+            let buf: IDirectSoundBuffer = core::mem::transmute_copy(slot);
+            // Release on drop (no Stop needed — these are template buffers)
+            drop(buf);
+            *slot = 0;
+        }
+    }
+
+    // Release primary buffer (Stop + Release).
+    if snd.primary_buffer != 0 {
+        let buf: IDirectSoundBuffer = core::mem::transmute_copy(&snd.primary_buffer);
+        let _ = buf.Stop();
+        drop(buf);
+        snd.primary_buffer = 0;
+    }
+
+    // Release IDirectSound.
+    if snd.direct_sound != 0 {
+        use windows::Win32::Media::Audio::DirectSound::IDirectSound;
+        let ds: IDirectSound = core::mem::transmute_copy(&snd.direct_sound);
+        drop(ds);
+        snd.direct_sound = 0;
+    }
+
+    // Set secondary vtable (base class destructor pattern).
+    snd.vtable = rb(0x0066_AF58) as *const DSSoundVtable;
+
+    if flags & 1 != 0 {
+        crate::wa_alloc::wa_free(this as *mut u8);
+    }
+    this
+}
+
 /// Slot 14: sub_destructor — sets secondary vtable (0x66AF58), optionally frees.
 /// This is a base-class destructor called by the primary destructor (slot 0).
 pub unsafe extern "thiscall" fn sub_destructor(

crates/openwa-core/src/audio/mod.rs

@@ -8,6 +8,7 @@ pub mod streaming;
 pub use active_sound::{ActiveSoundEntry, ActiveSoundTable};
 pub use dssound::{DSSound, DSSoundVtable, ChannelDescriptor};
 pub use dssound::{
+    destructor as dssound_destructor,
     update_channels, release_finished,
     is_slot_loaded, is_channel_finished, stop_channel,
     set_volume_params, set_master_volume, set_channel_volume, set_pan,

crates/openwa-wormkit/src/replacements/sound.rs

@@ -170,6 +170,7 @@ unsafe fn patch_dssound_vtable() -> Result<(), String> {
     use openwa_core::audio::{
         update_channels, release_finished,
         is_slot_loaded, is_channel_finished, stop_channel,
+        dssound_destructor,
         set_volume_params, set_master_volume, set_channel_volume, set_pan,
         dssound_sub_destructor,
         load_wav, dssound_noop, dssound_returns_0, dssound_returns_1,
@@ -181,6 +182,9 @@ unsafe fn patch_dssound_vtable() -> Result<(), String> {
         // Slot 12: load_wav — WAV file → DirectSound secondary buffer (hound + windows crate)
         *vt.add(12) = load_wav as *const () as u32;
 
+        // Slot 0: destructor — releases all COM objects
+        *vt.add(0) = dssound_destructor as *const () as u32;
+
         // Slot 1: update_channels — release finished buffers each frame
         *vt.add(1) = update_channels as *const () as u32;
 
@@ -223,6 +227,6 @@ unsafe fn patch_dssound_vtable() -> Result<(), String> {
         // Trivial returns-1 (slot 23)
         *vt.add(23) = dssound_returns_1 as *const () as u32;
 
-        let _ = log_line("[Sound]   DSSound vtable: patched 21/24 slots with Rust");
+        let _ = log_line("[Sound]   DSSound vtable: patched 22/24 slots with Rust");
     }).map_err(|e| e.to_string())
 }