fix: add missing LoadSprites fallback in DDGame constructor for gfx_mode=0

The original DDGame constructor calls GfxHandler__LoadSprites (0x570B50)
when gfx_mode=0 (headless) or when GfxResource__Create fails. Our Rust
replacement skipped this call entirely, leaving DDGame+0x730C (color
table) unpopulated. This caused checksum mismatches in the longbow
replay.

Added the missing call with correct parameters (primary_gfx_dir as 4th
param for gfx_mode=0, 0 for resource creation failure). The color table
is still not fully matching vanilla (0xFFFFFFFF vs 1-9) — further
investigation needed in LoadSprites or CTaskGameState initialization.

Also: cleaned up bisect debug code, removed unused call_original
bridge functions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

crates/openwa-core/src/engine/ddgame.rs

@@ -849,8 +849,10 @@ unsafe fn init_graphics_and_resources(
     let layer_ctx = DDDisplay::set_active_layer((*ddgame).display, 1);
 
     // ── GfxDir color entries DDGame+0x730C..0x732C ──
+    // Original logic: if gfx_mode!=0, try GfxResource__Create for colours.img.
+    // If gfx_mode==0 OR resource creation fails, fall back to LoadSprites.
+    // The fallback's 4th param is primary_gfx_dir when gfx_mode==0, or 0 on resource fail.
     if (*wrapper).gfx_mode != 0 {
-        // The layer_ctx is used as the output buffer, not a plain stack alloc.
         let res = gfx_resource_create(
             (*wrapper).primary_gfx_dir,
             rb(va::STR_COLOURS_IMG) as *const c_char,
@@ -858,18 +860,31 @@ unsafe fn init_graphics_and_resources(
         );
         if !res.is_null() {
             let rvt = *(res as *const *const u32);
-            // vtable[4] = get_pixel: thiscall(this, x, y) -> color, RET 0x8.
             let get_color: unsafe extern "thiscall" fn(*mut u8, u32, u32) -> u32 =
                 core::mem::transmute(*rvt.add(4));
             for i in 0..9u32 {
                 (*ddgame).gfx_color_table[i as usize] = get_color(res, i, 0);
             }
-            // DisplayGfx__vmethod_3: thiscall(this, byte param_2), RET 4.
-            // param_2 & 1 = free the object itself.
             let release: unsafe extern "thiscall" fn(*mut u8, u8) =
                 core::mem::transmute(*rvt.add(3));
             release(res, 1);
+        } else {
+            // Resource creation failed — fallback with param4=0
+            wa_load_sprites(
+                wrapper,
+                (*ddgame).gfx_sprite_data.as_mut_ptr(),
+                (*game_info).display_flags,
+                0,
+            );
         }
+    } else {
+        // gfx_mode==0 (headless): fallback LoadSprites with param4=primary_gfx_dir
+        wa_load_sprites(
+            wrapper,
+            (*ddgame).gfx_sprite_data.as_mut_ptr(),
+            (*game_info).display_flags,
+            (*wrapper).primary_gfx_dir as u32,
+        );
     }
 
     // ── Secondary GfxDir object (DDGame+0x2C, conditional) ──

crates/openwa-wormkit/src/replacements/game_session.rs

@@ -95,6 +95,7 @@ pub(crate) unsafe fn construct_ddgame_wrapper(
         core::mem::transmute(rb(va::DDGAME_INIT_GAME_STATE) as usize);
     init_state(this);
 
+
     let _ = log_line(&format!(
         "[GameSession] DDGameWrapper::Constructor done: wrapper=0x{:08X}  ddgame=0x{:08X}",
         this as u32, (*this).ddgame as u32,
@@ -106,9 +107,7 @@ pub(crate) unsafe fn construct_ddgame_wrapper(
 pub fn install() -> Result<(), String> {
     unsafe {
         INIT_REPLAY_ADDR = rb(va::DDGAMEWRAPPER_INIT_REPLAY);
-        // Initialize runtime addresses for create_ddgame bridges.
         init_constructor_addrs();
-        // DDGameWrapper__Constructor is fully converted — trap the original.
         hook::install_trap!("DDGameWrapper__Constructor", va::CONSTRUCT_DD_GAME_WRAPPER);
     }
     Ok(())

crates/openwa-wormkit/src/replacements/weapon.rs

@@ -180,22 +180,6 @@ unsafe extern "C" fn trampoline_fire_weapon() {
     );
 }
 
-/// Call the original FireWeapon (trampoline) for debugging.
-/// Restores EAX=entry, ECX=local_struct, stack=worm.
-#[unsafe(naked)]
-unsafe extern "C" fn call_original_fire_weapon(
-    _entry: *const WeaponEntry, _local_struct: u32, _worm: *mut CTaskWorm,
-) {
-    core::arch::naked_asm!(
-        "mov eax, [esp+4]",   // entry
-        "mov ecx, [esp+8]",   // local_struct
-        "push [esp+12]",      // worm
-        "call [{orig}]",
-        "ret",
-        orig = sym ORIG_FIRE_WEAPON,
-    );
-}
-
 /// Rust implementation of FireWeapon dispatch.
 ///
 /// `entry`: EAX = active WeaponEntry pointer (from CTaskWorm+0x36C).