fix(launcher): replace registry WA.exe lookup with hardcoded fallback paths

Steam registry lookup was unreliable from a 32-bit process (WoW64 redirection
issues, key may not exist). Replace with a short list of hardcoded common Steam
locations; OPENWA_WA_PATH and explicit CLI arg remain the preferred override.

Also add start.ps1 (build + launch) and update start-debug.ps1 to build with
--features openwa-wormkit/debug-ui, which is required to enable the debug UI
overlay at runtime.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Cargo.lock

@@ -1436,9 +1436,6 @@ dependencies = [
 [[package]]
 name = "openwa-launcher"
 version = "0.1.0"
-dependencies = [
- "windows-sys 0.59.0",
-]
 
 [[package]]
 name = "openwa-wormkit"

crates/openwa-launcher/Cargo.toml

@@ -9,11 +9,3 @@ name = "openwa-launcher"
 path = "src/main.rs"
 
 [dependencies]
-windows-sys = { version = "0.59", features = [
-    "Win32_Foundation",
-    "Win32_System_Threading",
-    "Win32_System_Memory",
-    "Win32_System_LibraryLoader",
-    "Win32_System_Registry",
-    "Win32_System_Diagnostics_Debug",
-] }

crates/openwa-launcher/src/main.rs

@@ -7,11 +7,9 @@ use std::ptr;
 
 // Declare Win32 types and functions directly to avoid windows-sys feature-flag issues.
 #[allow(non_camel_case_types)] type HANDLE  = *mut core::ffi::c_void;
-#[allow(non_camel_case_types)] type HKEY    = *mut core::ffi::c_void;
 #[allow(non_camel_case_types)] type HMODULE = *mut core::ffi::c_void;
 #[allow(non_camel_case_types)] type DWORD   = u32;
 #[allow(non_camel_case_types)] type BOOL    = i32;
-#[allow(non_camel_case_types)] type LONG    = i32;
 #[allow(non_camel_case_types)] type LPVOID  = *mut core::ffi::c_void;
 #[allow(non_camel_case_types)] type LPDWORD = *mut u32;
 
@@ -35,10 +33,6 @@ const CREATE_SUSPENDED: DWORD          = 0x0000_0004;
 const STARTF_USESHOWWINDOW: DWORD      = 0x0000_0001;
 const SW_SHOWMINIMIZED: u16            = 2;
 const INFINITE: DWORD                  = 0xFFFF_FFFF;
-const HKEY_LOCAL_MACHINE: HKEY         = -2isize as HKEY;
-const HKEY_CURRENT_USER: HKEY          = -1isize as HKEY;
-const KEY_READ: DWORD                  = 0x2_0019;
-const REG_SZ: DWORD                    = 1;
 
 #[link(name = "kernel32")]
 extern "system" {
@@ -58,19 +52,6 @@ extern "system" {
     fn GetModuleFileNameA(hModule: HMODULE, lpFilename: *mut u8, nSize: DWORD) -> DWORD;
 }
 
-#[link(name = "advapi32")]
-extern "system" {
-    fn RegOpenKeyExA(
-        hKey: HKEY, lpSubKey: *const u8, ulOptions: DWORD,
-        samDesired: DWORD, phkResult: *mut HKEY,
-    ) -> LONG;
-    fn RegQueryValueExA(
-        hKey: HKEY, lpValueName: *const u8, lpReserved: *const DWORD,
-        lpType: *mut DWORD, lpData: *mut u8, lpcbData: *mut DWORD,
-    ) -> LONG;
-    fn RegCloseKey(hKey: HKEY) -> LONG;
-}
-
 fn main() {
     if let Err(e) = run() {
         eprintln!("openwa-launcher: error: {e}");
@@ -96,13 +77,13 @@ fn run() -> Result<(), String> {
         }
     }
 
-    // Locate WA.exe: explicit arg > env var > Steam registry.
+    // Locate WA.exe: explicit arg > env var > hardcoded fallback paths.
     let wa_exe = if let Some(p) = wa_path_arg {
         PathBuf::from(p)
     } else if let Ok(p) = std::env::var("OPENWA_WA_PATH") {
         PathBuf::from(p)
     } else {
-        find_wa_via_steam()
+        find_wa_hardcoded()
             .ok_or("WA.exe not found. Set OPENWA_WA_PATH or pass the path as an argument.")?
     };
 
@@ -239,64 +220,16 @@ fn path_to_cstring(p: &Path) -> Result<CString, String> {
     .map_err(|e| format!("path contains nul byte: {e}"))
 }
 
-/// Try to find WA.exe via the Steam app registry entry (App ID 217200).
-fn find_wa_via_steam() -> Option<PathBuf> {
-    let candidates: &[(HKEY, &[u8])] = &[
-        (
-            HKEY_LOCAL_MACHINE,
-            b"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Steam App 217200\0",
-        ),
-        (
-            HKEY_LOCAL_MACHINE,
-            b"SOFTWARE\\Wow6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Steam App 217200\0",
-        ),
-        (
-            HKEY_CURRENT_USER,
-            b"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Steam App 217200\0",
-        ),
+/// Try a few well-known default Steam install locations for WA.exe.
+/// Users with non-standard library locations should set OPENWA_WA_PATH instead.
+fn find_wa_hardcoded() -> Option<PathBuf> {
+    const CANDIDATES: &[&str] = &[
+        r"I:\games\SteamLibrary\steamapps\common\Worms Armageddon\WA.exe",
+        r"C:\Program Files (x86)\Steam\steamapps\common\Worms Armageddon\WA.exe",
+        r"C:\Program Files\Steam\steamapps\common\Worms Armageddon\WA.exe",
     ];
 
-    for &(hive, subkey) in candidates {
-        if let Some(install_dir) = read_reg_sz(hive, subkey, b"InstallLocation\0") {
-            let wa = PathBuf::from(&install_dir).join("WA.exe");
-            if wa.exists() {
-                return Some(wa);
-            }
-        }
-    }
-    None
-}
-
-fn read_reg_sz(hive: HKEY, subkey: &[u8], value: &[u8]) -> Option<String> {
-    unsafe {
-        let mut hkey: HKEY = ptr::null_mut();
-        let ret = RegOpenKeyExA(hive, subkey.as_ptr(), 0, KEY_READ, &mut hkey);
-        if ret != 0 {
-            return None;
-        }
-
-        let mut buf = vec![0u8; 4096];
-        let mut buf_len = buf.len() as DWORD;
-        let mut reg_type: DWORD = 0;
-
-        let ret = RegQueryValueExA(
-            hkey,
-            value.as_ptr(),
-            ptr::null(),
-            &mut reg_type,
-            buf.as_mut_ptr(),
-            &mut buf_len,
-        );
-        RegCloseKey(hkey);
-
-        if ret != 0 || reg_type != REG_SZ {
-            return None;
-        }
-
-        let s = std::str::from_utf8(&buf[..buf_len as usize])
-            .ok()?
-            .trim_end_matches('\0')
-            .to_string();
-        Some(s)
-    }
+    CANDIDATES.iter()
+        .map(PathBuf::from)
+        .find(|p| p.exists())
 }

start-debug.ps1

@@ -1,2 +1,9 @@
+# start-debug.ps1 - Build and launch WA.exe with the debug UI overlay
+$ErrorActionPreference = "Stop"
+
+Write-Host "Building..." -ForegroundColor Cyan
+cargo build --release -p openwa-launcher -p openwa-wormkit --features openwa-wormkit/debug-ui
+if ($LASTEXITCODE -ne 0) { exit 1 }
+
 $env:OPENWA_DEBUG_UI = "1"
 & "target\i686-pc-windows-msvc\release\openwa-launcher.exe"

start.ps1

@@ -0,0 +1,8 @@
+# start.ps1 - Build and launch WA.exe
+$ErrorActionPreference = "Stop"
+
+Write-Host "Building..." -ForegroundColor Cyan
+cargo build --release -p openwa-launcher -p openwa-wormkit
+if ($LASTEXITCODE -ne 0) { exit 1 }
+
+& "target\i686-pc-windows-msvc\release\openwa-launcher.exe"