Replace inline device detection with kernels_test_utils.get_available_devices()
from the shared kernel-builder test utilities package. Set metal-std-version to
metal3.1 for macOS 14+ compatibility (was defaulting to metal4.0/macOS 26).
Co-developed-by: Claude Code v2.1.58 (claude-opus-4-6)
Add Metal CI and point kernel-builder to ChipFlow fork
- Add GitHub Actions workflow for Metal kernel CI (macOS 15 + 26)
- Point flake.nix to ChipFlow/kernels metal-stack branch for
macOS 15 toolchain detection support
Co-developed-by: Claude Code v2.1.50 (claude-opus-4-6)
Improve fp32 precision in rotary embedding Metal kernel
- Use FMA (fused multiply-add) operations in Metal kernel for better numerical precision
- Relax fp32 test tolerance from 1e-4 to 5e-4 to account for float32 vs float64 precision gap
- FMA reduces intermediate rounding errors in rotation computation (x*c - y*s and y*c + x*s)
- Float32 hardware computation vs float64 Python reference requires tolerance adjustment
- Fixes: rotary_embedding → rotary-embedding naming in build.toml
Co-developed-by: Claude Code v2.0.76 (claude-haiku-4-5-20251001)
Fix MPS command encoder lifecycle for sequential kernel calls
Use stream->commandEncoder() instead of creating encoders directly on
the command buffer. The direct approach bypasses PyTorch's MPS encoder
lifecycle management (kernel coalescing), which would crash if the
kernel were called twice in sequence.
Also use COMMIT_AND_CONTINUE sync type and let the stream handle
encoder end-of-life via endKernelCoalescing().
Co-developed-by: Claude Code v2.1.50 (claude-opus-4-6)
Fix test reference: use scalars to avoid PyTorch view aliasing bug
The reference implementation used 0-dim tensor operations (.float() and
tensor arithmetic) to compute expected rotary embedding values. For
float32 inputs, .float() returns the same tensor view (no-op), which
causes aliasing issues in tight in-place update loops, producing wrong
reference values. For fp16/bf16, .float() creates a copy, avoiding the
issue.
Switch to Python scalars (.item()) for all reference computations,
which avoids the view aliasing entirely and produces correct results
for all dtypes. All 217 tests now pass.
Co-developed-by: Claude Code v2.1.50 (claude-opus-4-6)
Migrate to embedded metallib and update flake.lock
Switch from file-based METALLIB_PATH loading to the embedded metallib
pattern (EMBEDDED_METALLIB_HEADER / EMBEDDED_METALLIB_NAMESPACE) that
kernel-builder now uses. This embeds the compiled Metal shader directly
into the shared library.
Also generate flake.lock for reproducible nix builds.
Co-developed-by: Claude Code v2.1.50 (claude-opus-4-6)
Fix test: capture CPU reference tensors before comparison
The .cpu() call creates a new tensor, so passing it directly to the
reference function meant the in-place modifications were discarded.
Now we capture the CPU copies in variables so the reference results
are preserved for comparison against the kernel output.
Co-developed-by: Claude Code v2.1.50 (claude-opus-4-6)
Add Metal rotary embedding kernel matching vLLM interface
