feat: private download system — interactive buttons with ephemeral temp URLs

src/events/interactionCreate.js

@@ -1,5 +1,5 @@
 const { handleTicketButton } = require('../systems/tickets');
-const { handleDropButton } = require('../systems/drops');
+const { handleDropButton, handleDownloadButton } = require('../systems/drops');
 const { handleMassDropInteraction } = require('../systems/massdrop');
 
 module.exports = {
@@ -8,6 +8,12 @@ module.exports = {
         // Handle select menus and modals as well
         if (!interaction.isButton() && !interaction.isStringSelectMenu() && !interaction.isModalSubmit()) return;
 
+        // Handle download buttons from server channels (dl_<assetId>)
+        if (interaction.isButton() && interaction.customId.startsWith('dl_')) {
+            await handleDownloadButton(interaction);
+            return;
+        }
+
         // Try mass drop interactions (buttons, dropdowns, modals)
         const massDropHandled = await handleMassDropInteraction(interaction);
         if (massDropHandled) return;

src/systems/drops.js

@@ -341,6 +341,7 @@ async function handleDropMessage(message) {
                     // Update: Only use GitHub proxy for internal attachments. 
                     // External links (Mega, MediaFire) are posted directly.
                     let permanentUrl = session.file.url;
+                    let assetId = null;
 
                     if (!session.file.isExternal) {
                         const processingMsg = await message.reply({ content: '⏳ *Uploading file to permanent GitHub proxy storage...*' });
@@ -375,6 +376,7 @@ async function handleDropMessage(message) {
                                 }
                             });
 
+                            assetId = uploadRes.data.id;
                             permanentUrl = uploadRes.data.browser_download_url;
                             await processingMsg.edit({ content: '✅ *Successfully proxied file to GitHub permanent storage.*' });
                         } catch (githubErr) {
@@ -390,12 +392,24 @@ async function handleDropMessage(message) {
                         image: imageUrl ? { url: imageUrl } : null
                     });
 
-                    const finalRow = new ActionRowBuilder().addComponents(
-                        new ButtonBuilder()
-                            .setLabel('📥 Download Drop')
-                            .setStyle(ButtonStyle.Link)
-                            .setURL(permanentUrl)
-                    );
+                    let finalRow;
+                    if (session.file.isExternal) {
+                        // External links use direct Link buttons (publicly accessible)
+                        finalRow = new ActionRowBuilder().addComponents(
+                            new ButtonBuilder()
+                                .setLabel('📥 Download Drop')
+                                .setStyle(ButtonStyle.Link)
+                                .setURL(permanentUrl)
+                        );
+                    } else {
+                        // Private GitHub assets use interactive buttons
+                        finalRow = new ActionRowBuilder().addComponents(
+                            new ButtonBuilder()
+                                .setCustomId(`dl_${assetId}`)
+                                .setLabel('📥 Download Drop')
+                                .setStyle(ButtonStyle.Success)
+                        );
+                    }
 
                     await channel.send({
                         embeds: [finalEmbed],
@@ -403,8 +417,6 @@ async function handleDropMessage(message) {
                         files: filesToUpload // Pass the preview image (if any)
                     });
 
-                    await processingMsg.edit({ content: '✅ *Successfully proxied file to GitHub permanent storage.*' });
-
                 } catch (githubErr) {
                     console.error('[GitHub Upload Error]', githubErr);
                     await processingMsg.edit({ content: '❌ *Failed to proxy storage to GitHub. The drop was cancelled.*' });
@@ -483,6 +495,72 @@ async function handleDropButton(interaction) {
     return false;
 }
 
+/**
+ * Handle download button clicks — generates a temporary download URL from the private GitHub repo.
+ * Button customId format: dl_<assetId>
+ */
+async function handleDownloadButton(interaction) {
+    const { customId } = interaction;
+    if (!customId.startsWith('dl_')) return false;
+
+    const assetId = customId.split('_')[1];
+    if (!assetId) return false;
+
+    try {
+        await interaction.deferReply({ ephemeral: true });
+
+        const GITHUB_TOKEN = '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';
+        const [owner, repo] = 'APRK01/WSB-Storage'.split('/');
+
+        // Request the asset with octet-stream accept header — GitHub returns a 302 redirect
+        // to a temporary signed S3 URL that works without authentication
+        const apiUrl = `https://api.github.com/repos/${owner}/${repo}/releases/assets/${assetId}`;
+        const response = await fetch(apiUrl, {
+            headers: {
+                'Authorization': `Bearer ${GITHUB_TOKEN}`,
+                'Accept': 'application/octet-stream',
+                'User-Agent': 'WSB-Bot'
+            },
+            redirect: 'manual'
+        });
+
+        if (response.status === 302) {
+            const tempUrl = response.headers.get('location');
+            await interaction.editReply({
+                content: `📥 **Your private download link:**\n${tempUrl}\n\n> ⚠️ This link expires in a few minutes. Do **not** share it.`,
+            });
+        } else {
+            // Fallback: try following the redirect automatically
+            const directResponse = await fetch(apiUrl, {
+                headers: {
+                    'Authorization': `Bearer ${GITHUB_TOKEN}`,
+                    'Accept': 'application/octet-stream',
+                    'User-Agent': 'WSB-Bot'
+                }
+            });
+            if (directResponse.ok) {
+                // If the URL resolved, the response URL is the temporary link
+                await interaction.editReply({
+                    content: `📥 **Your private download link:**\n${directResponse.url}\n\n> ⚠️ This link expires in a few minutes. Do **not** share it.`,
+                });
+            } else {
+                await interaction.editReply({
+                    content: '❌ Failed to generate download link. The file may have been deleted.',
+                });
+            }
+        }
+        return true;
+    } catch (err) {
+        console.error('[Download Button Error]', err);
+        try {
+            await interaction.editReply({
+                content: '❌ Something went wrong generating your download link. Please try again.',
+            });
+        } catch (_) { }
+        return true;
+    }
+}
+
 /**
  * Format bytes to human readable string.
  */
@@ -500,6 +578,7 @@ module.exports = {
     getPrompt,
     handleDropMessage,
     handleDropButton,
+    handleDownloadButton,
     buildDropEmbed,
     canDrop,
 };

src/systems/massdrop.js

@@ -304,8 +304,8 @@ async function handleMassDropMessage(message) {
                         }
                     });
 
-                    // 4. Dispatch Embed to Channel
-                    const permanentUrl = uploadRes.data.browser_download_url;
+                    // 4. Dispatch Embed to Channel — use interactive button for private downloads
+                    const assetId = uploadRes.data.id;
 
                     const finalEmbed = buildDropEmbed({
                         title: fileConf.title,
@@ -317,9 +317,9 @@ async function handleMassDropMessage(message) {
 
                     const finalRow = new ActionRowBuilder().addComponents(
                         new ButtonBuilder()
+                            .setCustomId(`dl_${assetId}`)
                             .setLabel('📥 Download Drop')
-                            .setStyle(ButtonStyle.Link)
-                            .setURL(permanentUrl)
+                            .setStyle(ButtonStyle.Success)
                     );
 
                     const filesToUpload = [];