feat: migrate all drops permanently to github proxy regardless of size

src/systems/drops.js

@@ -323,79 +323,75 @@ async function handleDropMessage(message) {
                     imageUrl = `attachment://${session.image.name}`;
                 }
 
-                // Build embed with local attachment references
-                const dropEmbed = buildDropEmbed({
-                    ...session,
-                    image: imageUrl ? { url: imageUrl } : null
-                });
+                // 3. We upload the main file to GitHub Releases for unlimited, permanent CDN proxy storage
+                const processingMsg = await message.reply({ content: '⏳ *Uploading file to permanent GitHub proxy storage...*' });
 
-                // We'll try to upload the files first. If it fails (e.g., file too large for server limits),
-                // we catch the error and fallback to sending just the URL and download button.
                 try {
-                    await channel.send({
-                        embeds: [dropEmbed],
-                        files: filesToUpload,
+                    const octokit = new Octokit({ auth: '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' });
+                    const [owner, repo] = 'APRK01/WSB-Storage'.split('/');
+
+                    // Download the file from Discord's temporary DM CDN
+                    let fileBuffer;
+                    if (session.file.isExternal) {
+                        // User provided an external link instead of uploading to Discord DM
+                        const fileRes = await fetch(session.file.url);
+                        fileBuffer = await fileRes.buffer();
+                    } else {
+                        // User uploaded directly to Discord DM
+                        const fileRes = await fetch(session.file.url);
+                        fileBuffer = await fileRes.buffer();
+                    }
+
+                    // Create the release
+                    const releaseTitle = `Drop: ${session.title.replace(/[^a-zA-Z0-9 -]/g, '')} - ${Date.now()}`;
+                    const release = await octokit.rest.repos.createRelease({
+                        owner,
+                        repo,
+                        tag_name: `drop-${Date.now()}`,
+                        name: releaseTitle,
+                        body: `Auto-generated drop upload for WSB.\n\nDescription: ${session.about}`
+                    });
+
+                    // Upload the asset to the newly created release
+                    const uploadRes = await octokit.rest.repos.uploadReleaseAsset({
+                        owner,
+                        repo,
+                        release_id: release.data.id,
+                        name: session.file.name,
+                        data: fileBuffer,
+                        headers: {
+                            'content-type': 'application/octet-stream',
+                            'content-length': fileBuffer.length
+                        }
                     });
-                } catch (uploadErr) {
-                    console.warn('[Drop Upload Fallback]', uploadErr.message);
 
-                    const processingMsg = await message.reply({ content: '⏳ *File is too large for Discord limits. Uploading to permanent GitHub proxy storage...*' });
+                    // Update Embed to point to the permanent GitHub file
+                    const permanentUrl = uploadRes.data.browser_download_url;
 
-                    try {
+                    const finalEmbed = buildDropEmbed({
+                        ...session,
+                        image: imageUrl ? { url: imageUrl } : null
+                    });
 
-                        // Using GitHub Releases as unlimited CDN proxy storage
-                        const octokit = new Octokit({ auth: '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' });
-                        const [owner, repo] = 'APRK01/WSB-Storage'.split('/');
+                    const finalRow = new ActionRowBuilder().addComponents(
+                        new ButtonBuilder()
+                            .setLabel('📥 Download Drop')
+                            .setStyle(ButtonStyle.Link)
+                            .setURL(permanentUrl)
+                    );
 
-                        // 1. Download the file from Discord's temporary DM CDN
-                        const fileRes = await fetch(session.file.url);
-                        const fileBuffer = await fileRes.buffer();
-
-                        // 2. Create the release
-                        const releaseTitle = `Drop: ${session.title.replace(/[^a-zA-Z0-9 -]/g, '')} - ${Date.now()}`;
-                        const release = await octokit.rest.repos.createRelease({
-                            owner,
-                            repo,
-                            tag_name: `drop-${Date.now()}`,
-                            name: releaseTitle,
-                            body: `Auto-generated drop upload for WSB.\n\nDescription: ${session.about}`
-                        });
-
-                        // 3. Upload the asset to the newly created release
-                        const uploadRes = await octokit.rest.repos.uploadReleaseAsset({
-                            owner,
-                            repo,
-                            release_id: release.data.id,
-                            name: session.file.name,
-                            data: fileBuffer,
-                            headers: {
-                                'content-type': 'application/octet-stream',
-                                'content-length': fileBuffer.length
-                            }
-                        });
-
-                        // Update Embed to point to the permanent GitHub file
-                        const permanentUrl = uploadRes.data.browser_download_url;
-                        const fallbackEmbed = buildDropEmbed(session);
-                        const fallbackRow = new ActionRowBuilder().addComponents(
-                            new ButtonBuilder()
-                                .setLabel('📥 Download Drop')
-                                .setStyle(ButtonStyle.Link)
-                                .setURL(permanentUrl)
-                        );
-
-                        await channel.send({
-                            embeds: [fallbackEmbed],
-                            components: [fallbackRow]
-                        });
-
-                        await processingMsg.edit({ content: '✅ *Successfully proxied massive file to GitHub permanent storage.*' });
-
-                    } catch (githubErr) {
-                        console.error('[GitHub Upload Error]', githubErr);
-                        await processingMsg.edit({ content: '❌ *Failed to proxy storage to GitHub. The drop was cancelled.*' });
-                        throw new Error('File too large for Discord and GitHub proxy failed.');
-                    }
+                    await channel.send({
+                        embeds: [finalEmbed],
+                        components: [finalRow],
+                        files: filesToUpload // Pass the preview image (if any)
+                    });
+
+                    await processingMsg.edit({ content: '✅ *Successfully proxied file to GitHub permanent storage.*' });
+
+                } catch (githubErr) {
+                    console.error('[GitHub Upload Error]', githubErr);
+                    await processingMsg.edit({ content: '❌ *Failed to proxy storage to GitHub. The drop was cancelled.*' });
+                    throw new Error('GitHub proxy failed.');
                 }
 
                 // Log the drop for rate limiting