fix: re-upload drop files as local attachments to prevent discord CDN expiration

src/systems/drops.js

@@ -3,6 +3,7 @@ const {
     ButtonBuilder,
     ButtonStyle,
     StringSelectMenuBuilder,
+    AttachmentBuilder,
 } = require('discord.js');
 const { createEmbed } = require('../utils/embeds');
 const { Colors } = require('../config');
@@ -183,7 +184,8 @@ function buildDropEmbed(session) {
     };
 
     if (session.image) {
-        embedData.image = session.image;
+        // Handle both object-style (from re-upload) and string-style (from direct URL/preview)
+        embedData.image = typeof session.image === 'object' ? session.image.url : session.image;
     }
 
     return createEmbed(embedData);
@@ -232,7 +234,13 @@ async function handleDropMessage(message) {
                 return true;
             }
             const att = message.attachments.first();
-            session.file = { url: att.url, name: att.name, size: att.size };
+            // Store the full attachment object to re-upload it later
+            session.file = {
+                url: att.url,
+                name: att.name,
+                size: att.size,
+                attachment: att // Save reference to original attachment
+            };
             session.step = 'warnings';
             await message.reply(getPrompt(session));
             return true;
@@ -253,7 +261,12 @@ async function handleDropMessage(message) {
             if (content.toLowerCase() === 'none') {
                 session.image = null;
             } else if (message.attachments.size > 0) {
-                session.image = message.attachments.first().url;
+                const imgAtt = message.attachments.first();
+                session.image = {
+                    url: imgAtt.url,
+                    name: imgAtt.name,
+                    attachment: imgAtt
+                };
             } else {
                 session.image = null;
             }
@@ -289,11 +302,46 @@ async function handleDropMessage(message) {
                 const channel = await guild.channels.fetch(channelId);
                 if (!channel) throw new Error('Channel not found');
 
-                const dropEmbed = buildDropEmbed(session);
-                const downloadRow = buildDownloadButton(session);
+                // We must re-upload the files so they don't expire
+                const filesToUpload = [];
+                let fileDndUrl = session.file.url;
+                let imageUrl = session.image?.url;
+
+                // 1. The main dropped file
+                if (session.file.attachment) {
+                    const mainFile = new AttachmentBuilder(session.file.attachment.url, { name: session.file.name });
+                    filesToUpload.push(mainFile);
+                    fileDndUrl = `attachment://${session.file.name}`;
+                }
+
+                // 2. The preview image (if any)
+                if (session.image && session.image.attachment) {
+                    const imgFile = new AttachmentBuilder(session.image.attachment.url, { name: session.image.name });
+                    filesToUpload.push(imgFile);
+                    imageUrl = `attachment://${session.image.name}`;
+                }
+
+                // Build embed with local attachment references
+                const dropEmbed = buildDropEmbed({
+                    ...session,
+                    image: imageUrl ? { url: imageUrl } : null
+                });
+
+                // Update the download button to use the new attachment URL
+                // We'll actually remove the URL from the button and let them click the raw file attached to the message
+                // Alternatively, we send the files WITH the embed, and the button becomes a dummy/informational
+                const downloadRow = new ActionRowBuilder().addComponents(
+                    new ButtonBuilder()
+                        .setCustomId('dummy_download')
+                        .setLabel('📥 Download Attached File')
+                        .setStyle(ButtonStyle.Secondary)
+                        .setDisabled(true)
+                );
+
                 await channel.send({
                     embeds: [dropEmbed],
                     components: [downloadRow],
+                    files: filesToUpload,
                 });
 
                 // Log the drop for rate limiting