File size: 6,094 Bytes
6a7089a | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 | package bridge
import (
"testing"
)
// ---------------------------------------------------------------------------
// NormalizeSelector – legacy Ref promotion
// ---------------------------------------------------------------------------
func TestNormalizeSelector_RefPromotion(t *testing.T) {
// When Ref is set and Selector is empty, Ref should promote to Selector.
req := ActionRequest{Ref: "e5"}
req.NormalizeSelector()
if req.Selector != "e5" {
t.Errorf("after NormalizeSelector: Selector = %q, want %q", req.Selector, "e5")
}
}
func TestNormalizeSelector_RefPromotionVariousRefs(t *testing.T) {
refs := []string{"e0", "e1", "e42", "e99999"}
for _, ref := range refs {
req := ActionRequest{Ref: ref}
req.NormalizeSelector()
if req.Selector != ref {
t.Errorf("NormalizeSelector(Ref=%q): Selector = %q, want %q", ref, req.Selector, ref)
}
}
}
// ---------------------------------------------------------------------------
// NormalizeSelector – Selector preserved
// ---------------------------------------------------------------------------
func TestNormalizeSelector_SelectorPreserved(t *testing.T) {
// When Selector is already set, it should not be overwritten.
req := ActionRequest{Selector: "#login"}
req.NormalizeSelector()
if req.Selector != "#login" {
t.Errorf("after NormalizeSelector: Selector = %q, want %q", req.Selector, "#login")
}
}
func TestNormalizeSelector_SelectorPreservedVariousTypes(t *testing.T) {
selectors := []string{
"#login",
".btn.primary",
"div > span",
"//div[@id='main']",
"button",
"e5", // even if it looks like a ref, if it's in Selector field, keep it
}
for _, sel := range selectors {
req := ActionRequest{Selector: sel}
req.NormalizeSelector()
if req.Selector != sel {
t.Errorf("NormalizeSelector(Selector=%q): Selector = %q, want %q", sel, req.Selector, sel)
}
}
}
// ---------------------------------------------------------------------------
// NormalizeSelector – Ref wins when both set
// ---------------------------------------------------------------------------
func TestNormalizeSelector_RefWinsWhenBothSet(t *testing.T) {
// When both Ref and Selector are set, Selector is already populated
// so NormalizeSelector leaves it as-is (Ref doesn't overwrite).
// This tests the documented "Ref > Selector" priority — but the
// implementation only promotes Ref when Selector is empty.
req := ActionRequest{Ref: "e5", Selector: "#login"}
req.NormalizeSelector()
// Selector stays as "#login" because it was already set
if req.Selector != "#login" {
t.Errorf("after NormalizeSelector: Selector = %q, want %q", req.Selector, "#login")
}
}
// ---------------------------------------------------------------------------
// NormalizeSelector – empty fields
// ---------------------------------------------------------------------------
func TestNormalizeSelector_BothEmpty(t *testing.T) {
req := ActionRequest{}
req.NormalizeSelector()
if req.Selector != "" {
t.Errorf("after NormalizeSelector: Selector = %q, want empty", req.Selector)
}
if req.Ref != "" {
t.Errorf("after NormalizeSelector: Ref = %q, want empty", req.Ref)
}
}
func TestNormalizeSelector_EmptyRef(t *testing.T) {
req := ActionRequest{Ref: "", Selector: ".btn"}
req.NormalizeSelector()
if req.Selector != ".btn" {
t.Errorf("after NormalizeSelector: Selector = %q, want %q", req.Selector, ".btn")
}
}
// ---------------------------------------------------------------------------
// NormalizeSelector – idempotency
// ---------------------------------------------------------------------------
func TestNormalizeSelector_Idempotent(t *testing.T) {
// Calling NormalizeSelector multiple times should produce the same result.
tests := []ActionRequest{
{Ref: "e5"},
{Selector: "#login"},
{Ref: "e42", Selector: ""},
{},
{Ref: "e10", Selector: ".btn"},
}
for _, req := range tests {
r1 := req
r1.NormalizeSelector()
sel1 := r1.Selector
ref1 := r1.Ref
r1.NormalizeSelector()
if r1.Selector != sel1 {
t.Errorf("idempotency failed: Selector changed from %q to %q", sel1, r1.Selector)
}
if r1.Ref != ref1 {
t.Errorf("idempotency failed: Ref changed from %q to %q", ref1, r1.Ref)
}
// Third call for good measure
r1.NormalizeSelector()
if r1.Selector != sel1 {
t.Errorf("idempotency failed on 3rd call: Selector = %q, want %q", r1.Selector, sel1)
}
}
}
// ---------------------------------------------------------------------------
// NormalizeSelector – does not modify other fields
// ---------------------------------------------------------------------------
func TestNormalizeSelector_OtherFieldsUntouched(t *testing.T) {
req := ActionRequest{
Ref: "e5",
Kind: "click",
Text: "hello",
Key: "Enter",
TabID: "tab1",
NodeID: 42,
X: 1.5,
Y: 2.5,
HasXY: true,
}
req.NormalizeSelector()
if req.Kind != "click" {
t.Errorf("Kind changed: %q", req.Kind)
}
if req.Text != "hello" {
t.Errorf("Text changed: %q", req.Text)
}
if req.Key != "Enter" {
t.Errorf("Key changed: %q", req.Key)
}
if req.TabID != "tab1" {
t.Errorf("TabID changed: %q", req.TabID)
}
if req.NodeID != 42 {
t.Errorf("NodeID changed: %d", req.NodeID)
}
if req.X != 1.5 || req.Y != 2.5 {
t.Errorf("X/Y changed: %f, %f", req.X, req.Y)
}
if !req.HasXY {
t.Error("HasXY changed")
}
// Ref should still be "e5" (not cleared)
if req.Ref != "e5" {
t.Errorf("Ref changed: %q", req.Ref)
}
}
// ---------------------------------------------------------------------------
// NormalizeSelector – non-ref values in Ref field (legacy edge case)
// ---------------------------------------------------------------------------
func TestNormalizeSelector_NonRefValueInRefField(t *testing.T) {
// Some legacy callers might put a CSS selector in the Ref field.
// NormalizeSelector should still promote it to Selector.
req := ActionRequest{Ref: "#login"}
req.NormalizeSelector()
if req.Selector != "#login" {
t.Errorf("after NormalizeSelector: Selector = %q, want %q", req.Selector, "#login")
}
}
|