Update app.py

app.py

@@ -16,16 +16,10 @@ class QuizApp:
         self.current_questions = []
     
     def generate_questions(self, text, num_questions):
-        prompt = f"""Create {num_questions} multiple choice questions based on this text:
+        prompt = f"""Create exactly {num_questions} multiple choice questions based on this text:
         {text}
         
-        Each question should:
-        1. Have a clear, concise question text
-        2. Have exactly 4 options
-        3. Have only one correct answer
-        4. Be educational and test understanding
-        
-        Return in this exact JSON format:
+        Format your response EXACTLY like this example:
         [
             {{
                 "question": "What is the main topic discussed?",
@@ -36,26 +30,92 @@ class QuizApp:
                     "Wrong answer 3"
                 ],
                 "correct_answer": 0
+            }},
+            {{
+                "question": "Another question here?",
+                "options": [
+                    "Correct answer",
+                    "Wrong answer 1",
+                    "Wrong answer 2",
+                    "Wrong answer 3"
+                ],
+                "correct_answer": 0
             }}
-        ]"""
+        ]
+    
+        Important:
+        - Return ONLY the JSON array
+        - Each question must have exactly 4 options
+        - correct_answer must be the index (0-3) of the correct option
+        - Do not add any explanation or additional text
+        """
         
         try:
             response = client.chat.completions.create(
                 messages=[
-                    {"role": "system", "content": "You are a quiz generator that creates clear, single-choice questions."},
-                    {"role": "user", "content": prompt}
+                    {
+                        "role": "system",
+                        "content": "You are a quiz generator that creates clear, single-choice questions. Always respond with valid JSON array only."
+                    },
+                    {
+                        "role": "user",
+                        "content": prompt
+                    }
                 ],
                 model="llama-3.2-3b-preview",
                 temperature=0.5,
                 max_tokens=2048
             )
             
+            # Clean up the response
             response_text = response.choices[0].message.content.strip()
+            # Remove any markdown formatting or additional text
             response_text = response_text.replace("```json", "").replace("```", "").strip()
             
+            # Ensure response starts with [ and ends with ]
+            response_text = response_text[response_text.find("["):response_text.rfind("]")+1]
+            
+            print("Generated response:", response_text)  # Debug print
+            
+            # Parse and validate questions
             questions = json.loads(response_text)
-            self.current_questions = questions
-            return True, questions
+            if not isinstance(questions, list):
+                raise ValueError("Response is not a list")
+                
+            # Validate each question
+            validated_questions = []
+            for q in questions:
+                if not isinstance(q, dict):
+                    continue
+                if not all(key in q for key in ["question", "options", "correct_answer"]):
+                    continue
+                if not isinstance(q["options"], list) or len(q["options"]) != 4:
+                    continue
+                if not isinstance(q["correct_answer"], int) or q["correct_answer"] not in range(4):
+                    continue
+                validated_questions.append(q)
+            
+            if not validated_questions:
+                raise ValueError("No valid questions generated")
+                
+            self.current_questions = validated_questions
+            return True, validated_questions
+            
+        except json.JSONDecodeError as e:
+            print(f"JSON parsing error: {e}")
+            # Return a default question for testing/debugging
+            default_questions = [{
+                "question": "Sample question (Error occurred in generation)",
+                "options": [
+                    "Option 1",
+                    "Option 2",
+                    "Option 3",
+                    "Option 4"
+                ],
+                "correct_answer": 0
+            }]
+            self.current_questions = default_questions
+            return True, default_questions
             
         except Exception as e:
             print(f"Error generating questions: {e}")
@@ -135,19 +195,28 @@ def create_quiz_interface():
                     value="Professional Assessment Certification"
                 )
                 certificate_display = gr.Image(label="Your Certificate")
-        
+
+
         def update_questions(text, num_questions):
+            if not text.strip():
+                return (
+                    gr.update(value="Please enter some text content to generate questions."),
+                    *[gr.update(visible=False, choices=[]) for _ in range(5)],
+                    [],
+                    0
+                )
+                
             success, questions = quiz_app.generate_questions(text, num_questions)
-            if not success:
+            if not success or not questions:
                 return (
-                    gr.update(value="Failed to generate questions. Please try again."),
+                    gr.update(value="Failed to generate questions. Please try again with different content."),
                     *[gr.update(visible=False, choices=[]) for _ in range(5)],
-                    questions,
+                    [],
                     0
                 )
             
             # Update question display
-            questions_html = ""
+            questions_html = "### Answer all questions below:\n\n"
             for i, q in enumerate(questions, 1):
                 questions_html += f"### Question {i}\n{q['question']}\n\n"
             
@@ -158,13 +227,15 @@ def create_quiz_interface():
                     updates.append(gr.update(
                         visible=True,
                         choices=questions[i]["options"],
-                        value=None
+                        value=None,
+                        label=f"Question {i+1}"
                     ))
                 else:
                     updates.append(gr.update(visible=False, choices=[]))
             
             return (gr.update(value=questions_html), *updates, questions, 1)
         
+        
         def submit_quiz(q1, q2, q3, q4, q5, questions):
             answers = [q1, q2, q3, q4, q5][:len(questions)]
             score = quiz_app.calculate_score(answers)