Update app.py

app.py

@@ -108,21 +108,41 @@ def validate_usage_series(usage_str):
 
 def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, alert_status: list, current_stock: int, forecast_7: int, forecast_14: int, forecast_30: int, fig_daily: go.Figure, fig_alerts: go.Figure, usage_series: str) -> BytesIO:
     try:
+        logger.info("Starting PDF generation")
+        # Validate inputs
+        if not isinstance(forecast_data, dict) or not forecast_data:
+            logger.error("Invalid forecast_data: Must be a non-empty dictionary")
+            return None
+        if not isinstance(daily_forecasts, pd.DataFrame) or daily_forecasts.empty:
+            logger.error("Invalid daily_forecasts: Must be a non-empty DataFrame")
+            return None
+        if not isinstance(alert_status, list) or len(alert_status) != 3:
+            logger.error("Invalid alert_status: Must be a list of 3 booleans")
+            return None
+        if not isinstance(usage_series, str) or not usage_series:
+            logger.error("Invalid usage_series: Must be a non-empty string")
+            return None
+        if not isinstance(fig_daily, go.Figure) or not isinstance(fig_alerts, go.Figure):
+            logger.error("Invalid Plotly figures: fig_daily and fig_alerts must be valid go.Figure objects")
+            return None
+
         pdf_file = BytesIO()
         c = canvas.Canvas(pdf_file, pagesize=letter)
         c.setFont("Helvetica", 12)
         c.drawString(1 * inch, 10 * inch, "Consumables Forecast Report")
         c.setFont("Helvetica", 10)
         y_position = 9.5 * inch
+        logger.info("Initialized PDF canvas")
 
-        # Basic Forecast Data (Consumable Type, Current Stock, Forecast Results, Order Suggestions, Reorder Information)
+        # Basic Forecast Data
+        logger.info("Writing forecast data")
         for key, value in forecast_data.items():
             display_key = key.replace('_', ' ').title()
             value_str = str(value)
             c.drawString(1 * inch, y_position, f"{display_key}: {value_str}")
             y_position -= 0.3 * inch
 
-        # Add Last 60 Days Usage (comma-separated)
+        # Add Last 60 Days Usage
         y_position -= 0.3 * inch
         c.drawString(1 * inch, y_position, "Last 60 Days Usage (comma-separated):")
         y_position -= 0.3 * inch
@@ -133,8 +153,9 @@ def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, al
             text_object.textLine(line)
             y_position -= 0.3 * inch
         c.drawText(text_object)
+        logger.info("Added usage series")
 
-        # Add Daily Forecast Values (Next 30 Days) / Comma-separated daily forecasts
+        # Add Daily Forecast Values
         y_position -= 0.3 * inch
         c.drawString(1 * inch, y_position, "Daily Forecast Values (Next 30 Days):")
         y_position -= 0.3 * inch
@@ -146,8 +167,9 @@ def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, al
             text_object.textLine(line)
             y_position -= 0.3 * inch
         c.drawText(text_object)
+        logger.info("Added daily forecast values")
 
-        # Add Threshold Alerts (with flag indicator as text)
+        # Add Threshold Alerts
         y_position -= 0.3 * inch
         c.drawString(1 * inch, y_position, "Threshold Alerts:")
         y_position -= 0.3 * inch
@@ -159,8 +181,9 @@ def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, al
                 alert_text = f"No alert for {period} forecast."
             c.drawString(1 * inch, y_position, alert_text)
             y_position -= 0.3 * inch
+        logger.info("Added threshold alerts")
 
-        # Add Daily Forecast Visualization Data (Next 30 Days)
+        # Add Daily Forecast Visualization Data
         y_position -= 0.3 * inch
         c.drawString(1 * inch, y_position, "Daily Forecast Visualization Data (Next 30 Days):")
         y_position -= 0.3 * inch
@@ -173,19 +196,25 @@ def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, al
                 c.showPage()
                 c.setFont("Helvetica", 10)
                 y_position = 10 * inch
+        logger.info("Added daily forecast visualization data")
 
         # Add Daily Forecast Visualization Image
         y_position -= 0.3 * inch
-        if y_position < 4 * inch:  # Ensure enough space for the image
+        if y_position < 4 * inch:
             c.showPage()
             y_position = 10 * inch
         c.drawString(1 * inch, y_position, "Daily Forecast Visualization (Next 30 Days):")
         y_position -= 0.3 * inch
         daily_chart_img = BytesIO()
-        pio.write_image(fig_daily, daily_chart_img, format='png', width=600, height=400)
-        daily_chart_img.seek(0)
-        img = Image(daily_chart_img, width=6 * inch, height=4 * inch)
-        img.drawOn(c, 1 * inch, y_position - 4 * inch)
+        try:
+            pio.write_image(fig_daily, daily_chart_img, format='png', width=600, height=400)
+            daily_chart_img.seek(0)
+            img = Image(daily_chart_img, width=6 * inch, height=4 * inch)
+            img.drawOn(c, 1 * inch, y_position - 4 * inch)
+            logger.info("Added daily forecast visualization image")
+        except Exception as e:
+            logger.error(f"Failed to export daily forecast image: {str(e)}")
+            c.drawString(1 * inch, y_position - 0.3 * inch, "Error: Could not include daily forecast visualization.")
         y_position -= 4.5 * inch
 
         # Add Threshold Alerts Visualization Data
@@ -208,6 +237,7 @@ def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, al
                 c.showPage()
                 c.setFont("Helvetica", 10)
                 y_position = 10 * inch
+        logger.info("Added threshold alerts visualization data")
 
         # Add Threshold Alerts Visualization Image
         y_position -= 0.3 * inch
@@ -217,14 +247,20 @@ def generate_forecast_pdf(forecast_data: dict, daily_forecasts: pd.DataFrame, al
         c.drawString(1 * inch, y_position, "Threshold Alerts Visualization:")
         y_position -= 0.3 * inch
         alerts_chart_img = BytesIO()
-        pio.write_image(fig_alerts, alerts_chart_img, format='png', width=600, height=400)
-        alerts_chart_img.seek(0)
-        img = Image(alerts_chart_img, width=6 * inch, height=4 * inch)
-        img.drawOn(c, 1 * inch, y_position - 4 * inch)
+        try:
+            pio.write_image(fig_alerts, alerts_chart_img, format='png', width=600, height=400)
+            alerts_chart_img.seek(0)
+            img = Image(alerts_chart_img, width=6 * inch, height=4 * inch)
+            img.drawOn(c, 1 * inch, y_position - 4 * inch)
+            logger.info("Added threshold alerts visualization image")
+        except Exception as e:
+            logger.error(f"Failed to export alerts visualization image: {str(e)}")
+            c.drawString(1 * inch, y_position - 0.3 * inch, "Error: Could not include threshold alerts visualization.")
 
         c.showPage()
         c.save()
         pdf_file.seek(0)
+        logger.info("PDF generation completed successfully")
         return pdf_file
     except Exception as e:
         logger.error(f"Error generating PDF: {str(e)}")
@@ -403,7 +439,7 @@ def main():
                             {"Pdf_report__c": pdf_url}
                         )
                         logger.info(f"PDF uploaded to Salesforce: {pdf_url}")
-                        st.success(f"PDF Report generated and uploaded to Salesforce: {pdf_url}")
+                        logger.info(f"PDF Report generated and uploaded to Salesforce: {pdf_url}")
                     else:
                         logger.error("Failed to upload PDF to Salesforce")
                         st.error("Failed to upload PDF to Salesforce")