added secret logic

adapters/external/part1_runner.py

@@ -2,23 +2,28 @@ from typing import Optional
 from pathlib import Path
 import logging
 from inspect import signature
-from vendors.part1.main import run_ielts_part1_agent
 from utils.env import temp_env
 
 logger = logging.getLogger(__name__)
 
 def run_part1(image_path: str | Path, essay_text: str, api_key: Optional[str] = None) -> str:
+    """
+    Lazy-import vendor code AFTER we inject GOOGLE_API_KEY so that any
+    model constructed at import time sees the key.
+    """
     image_path = Path(image_path)
     if not image_path.exists():
         raise FileNotFoundError(f"Image not found: {image_path}")
 
     logger.info("Running Part1 agent")
 
-    try:
-        if "api_key" in signature(run_ielts_part1_agent).parameters and api_key:
-            return str(run_ielts_part1_agent(str(image_path), essay_text, api_key=api_key))
-    except Exception:
-        pass
-
     with temp_env("GOOGLE_API_KEY", api_key):
+        from vendors.part1.main import run_ielts_part1_agent
+
+        try:
+            if "api_key" in signature(run_ielts_part1_agent).parameters and api_key:
+                return str(run_ielts_part1_agent(str(image_path), essay_text, api_key=api_key))
+        except Exception:
+            pass
+
         return str(run_ielts_part1_agent(str(image_path), essay_text))

adapters/external/part2_runner.py

@@ -1,17 +1,24 @@
 import logging
 from inspect import signature
 from typing import Optional
-from vendors.part2.main import run_ielts_part2_agent
 from utils.env import temp_env
 
 logger = logging.getLogger(__name__)
 
 def run_part2(question: str, essay_text: str, api_key: Optional[str] = None) -> str:
+    """
+    Same lazy-import pattern as Part1; ensures import-time model build
+    sees GOOGLE_API_KEY when running on Spaces with BYO key.
+    """
     logger.info("Running Part2 agent")
-    try:
-        if "api_key" in signature(run_ielts_part2_agent).parameters and api_key:
-            return str(run_ielts_part2_agent(question, essay_text, api_key=api_key))
-    except Exception:
-        pass
+
     with temp_env("GOOGLE_API_KEY", api_key):
+        from vendors.part2.main import run_ielts_part2_agent
+
+        try:
+            if "api_key" in signature(run_ielts_part2_agent).parameters and api_key:
+                return str(run_ielts_part2_agent(question, essay_text, api_key=api_key))
+        except Exception:
+            pass
+
         return str(run_ielts_part2_agent(question, essay_text))

app/ui.py

@@ -11,7 +11,7 @@ logger = logging.getLogger(__name__)
 session_key = gr.State("")
 
 def _effective_key(user_input_key: str | None) -> str | None:
-    """Priority: user input (session) > env (local or Space Secret)."""
+    """Priority: user input (session) > env (local .env or Space Secret)."""
     k = (user_input_key or "").strip()
     if k:
         return k
@@ -73,7 +73,7 @@ with gr.Blocks(title="IELTS Writing Assistant", fill_height=True) as demo:
         gr.Markdown(
             f"Set your API key. Locally, you can save to `.env`. On Spaces, use **Session Key** or set a **Space Secret** `{ENV_VAR_NAME}`."
         )
-        key_box = gr.Textbox(label=f"{ENV_VAR_NAME}", type="password", placeholder="sk-...")
+        key_box = gr.Textbox(label=f"{ENV_VAR_NAME}", type="password", placeholder="AIza... (your Google API key)")
         save_local = gr.Button("Save to .env (Local Only)")
         save_session = gr.Button("Save Session Key")
         status = gr.Markdown("")

core/config.py

@@ -3,14 +3,17 @@ from pathlib import Path
 from dotenv import load_dotenv
 
 ENV_PATH = Path(".env")
-ENV_VAR_NAME = "GOOGLE_API_KEY"
+ENV_VAR_NAME = "GOOGLE_API_KEY"  # Keep Google-style key name for Gemini
 
+# Load .env once on import (local runs)
 load_dotenv(dotenv_path=ENV_PATH, override=False)
 
 def in_hf_spaces() -> bool:
+    """Detect if running inside Hugging Face Spaces."""
     return bool(os.getenv("SPACE_ID"))
 
 def get_api_key() -> str | None:
+    """Read the API key (from env or Space Secret)."""
     return os.getenv(ENV_VAR_NAME)
 
 def ensure_env_file() -> None:
@@ -18,10 +21,16 @@ def ensure_env_file() -> None:
         ENV_PATH.write_text("")
 
 def set_api_key(value: str, var_name: str = ENV_VAR_NAME) -> None:
+    """
+    Persist the key to .env for local runs.
+    On Spaces, DO NOT write to disk (no-op) — use session key instead.
+    """
     if in_hf_spaces():
-        return  
+        return  # no-op on Spaces
+
     value = (value or "").strip()
     ensure_env_file()
+
     lines = ENV_PATH.read_text().splitlines()
     out, found = [], False
     for line in lines:
@@ -32,5 +41,6 @@ def set_api_key(value: str, var_name: str = ENV_VAR_NAME) -> None:
             out.append(line)
     if not found:
         out.append(f"{var_name}={value}")
+
     ENV_PATH.write_text("\n".join(out) + "\n")
-    os.environ[var_name] = value  
+    os.environ[var_name] = value  # also set for this process

utils/env.py

@@ -14,4 +14,4 @@ def temp_env(var: str, value: str | None):
         if old is None:
             os.environ.pop(var, None)
         else:
-            os.environ[var] = old
+            os.environ[var] = old