Update app.py

app.py

@@ -88,6 +88,23 @@ st.markdown("""
     </style>
 """, unsafe_allow_html=True)
 
+def detect_best_aspect_ratio(image):
+    """Detect the best aspect ratio for the image"""
+    height, width = image.shape[:2]
+    current_ratio = width / height
+    
+    ratios = {
+        "16:9": 16/9,
+        "9:16": 9/16,
+        "4:5": 4/5,
+        "1:1": 1
+    }
+    
+    # Find closest ratio
+    best_ratio = min(ratios.items(), key=lambda x: abs(x[1] - current_ratio))
+    
+    return best_ratio[0], current_ratio
+    
 def extract_dominant_colors(image, n_colors=3):
     """Extract dominant neon-suitable colors from the image"""
     # Resize for faster processing
@@ -247,7 +264,7 @@ def create_enhanced_neon_glow(edge_image, colors, glow_size=20):
     result = np.clip(result, 0, 255).astype(np.uint8)
     return result
 
-def create_human_like_drawing(image, edges, strokes, num_frames, colors, glow_size=20, bg_color=(0, 0, 0), hold_drawn_frames=0):
+def create_human_like_drawing(image, edges, strokes, num_frames, colors, glow_size=20, bg_color=(0, 0, 0), hold_drawn_frames=0, hold_final_frames=0):
     """Create drawing animation that progressively reveals the original image with accurate colors"""
     height, width = edges.shape
     frames = []
@@ -349,7 +366,7 @@ def create_human_like_drawing(image, edges, strokes, num_frames, colors, glow_si
     
     # Add final complete frame - show 100% original image
     final_frame = image.copy()
-    frames.extend([final_frame] * 25)  # Hold for 25 frames
+    frames.extend([final_frame] * max(hold_final_frames, 25))  # Hold for specified frames or minimum 25
     
     gc.collect()
     return frames
@@ -467,23 +484,50 @@ def create_outro_frame(text, width, height, bg_color=(10, 10, 15),
     
     return cv2.cvtColor(np.array(img), cv2.COLOR_RGB2BGR)
 
-def add_audio_to_video(video_path, audio_path, output_path):
-    """Add audio to video using ffmpeg"""
+def add_audio_to_video(video_path, audio_path, output_path, start_time=0.0, fadeout_duration=2.0):
+    """Add audio to video using ffmpeg with start time and fade out"""
     import subprocess
     
     try:
+        # Build ffmpeg command with audio filters
+        audio_filters = []
+        
+        # Add fade out filter
+        if fadeout_duration > 0:
+            # Get video duration to calculate fade start
+            probe_cmd = [
+                'ffprobe', '-v', 'error', '-show_entries', 
+                'format=duration', '-of', 
+                'default=noprint_wrappers=1:nokey=1', video_path
+            ]
+            try:
+                result = subprocess.run(probe_cmd, capture_output=True, text=True, timeout=10)
+                video_duration = float(result.stdout.strip())
+                fade_start = max(0, video_duration - fadeout_duration)
+                audio_filters.append(f"afade=t=out:st={fade_start}:d={fadeout_duration}")
+            except:
+                # If can't get duration, use default fade
+                audio_filters.append(f"afade=t=out:d={fadeout_duration}")
+        
+        # Combine filters
+        filter_str = ",".join(audio_filters) if audio_filters else None
+        
         cmd = [
             'ffmpeg', '-y', '-hide_banner', '-loglevel', 'error',
             '-i', video_path,
+            '-ss', str(start_time),  # Start audio from this time
             '-i', audio_path,
-            '-c:v', 'libx264',
-            '-preset', 'fast',
+            '-c:v', 'copy',  # Copy video without re-encoding
             '-c:a', 'aac',
             '-b:a', '192k',
-            '-shortest',
-            output_path
         ]
-        result = subprocess.run(cmd, capture_output=True, text=True)
+        
+        if filter_str:
+            cmd.extend(['-af', filter_str])
+        
+        cmd.extend(['-shortest', output_path])
+        
+        result = subprocess.run(cmd, capture_output=True, text=True, timeout=300)
         if result.returncode != 0:
             st.warning(f"Audio mixing warning: {result.stderr}")
             return False
@@ -491,9 +535,13 @@ def add_audio_to_video(video_path, audio_path, output_path):
     except FileNotFoundError:
         st.error("FFmpeg not found. Please install FFmpeg to add audio.")
         return False
+    except subprocess.TimeoutExpired:
+        st.error("Audio processing timeout. Try a shorter audio file.")
+        return False
     except Exception as e:
         st.error(f"Audio error: {str(e)}")
         return False
+        
 
 def create_video(frames, fps, output_path, aspect_ratio):
     """Create video from frames"""
@@ -547,7 +595,15 @@ with col1:
     
     if uploaded_file:
         image = Image.open(uploaded_file)
-        st.image(image, caption="Original Image")
+        st.image(image, caption="Original Image", use_container_width=True)
+        
+        # Auto-detect best aspect ratio
+        image_array = np.array(image)
+        image_cv = cv2.cvtColor(image_array, cv2.COLOR_RGB2BGR)
+        best_ratio, current_ratio = detect_best_aspect_ratio(image_cv)
+        
+        st.success(f"📐 **Recommended Aspect Ratio:** {best_ratio}")
+        st.info(f"ℹ️ Current image ratio: {current_ratio:.2f}:1")
     
     st.markdown("</div>", unsafe_allow_html=True)
 
@@ -557,7 +613,12 @@ with col2:
     
     # Simple settings
     duration = st.slider("Animation Duration (seconds)", 5, 60, 10)
-    hold_drawn = st.slider("Hold Drawn Image (seconds)", 0, 10, 3)
+    
+    col_hold1, col_hold2 = st.columns(2)
+    with col_hold1:
+        hold_drawn = st.slider("Hold Drawn Image (sec)", 0, 10, 3)
+    with col_hold2:
+        hold_final = st.slider("Hold Final Image (sec)", 0, 10, 2)
     
     st.info("✨ Colors and effects are automatically detected from your image!")
     
@@ -578,7 +639,35 @@ col6, col7 = st.columns(2)
 
 with col6:
     aspect_ratio = st.selectbox("Aspect Ratio", ["16:9", "9:16", "4:5", "1:1"])
-    audio_file = st.file_uploader("Background Music (Optional)", type=['mp3', 'wav', 'ogg'])
+    
+    st.markdown("---")
+    st.subheader("🎵 Background Audio")
+    audio_file = st.file_uploader("Upload Audio (Optional)", type=['mp3', 'wav', 'ogg', 'm4a'])
+    
+    if audio_file:
+        # Audio preview
+        st.audio(audio_file, format=f'audio/{audio_file.name.split(".")[-1]}')
+        
+        # Audio controls
+        col_audio1, col_audio2 = st.columns(2)
+        with col_audio1:
+            audio_start_time = st.number_input(
+                "Start Time (seconds)", 
+                min_value=0.0, 
+                max_value=300.0, 
+                value=0.0, 
+                step=0.5,
+                help="Audio will start from this time"
+            )
+        with col_audio2:
+            audio_fadeout = st.number_input(
+                "Fade Out Duration (sec)", 
+                min_value=0.0, 
+                max_value=10.0, 
+                value=2.0, 
+                step=0.5,
+                help="Smooth fade out at the end"
+            )
 
 with col7:
     fps = st.slider("Frame Rate (FPS)", 24, 60, 30)
@@ -661,11 +750,13 @@ if st.button("🎬 Generate Neon Drawing Video", type="primary"):
                 progress_bar.progress(55)
                 
                 hold_drawn_frames = int(hold_drawn * fps)
+                hold_final_frames = int(hold_final * fps)
                 
                 frames = create_human_like_drawing(
                     image_cv, edges, strokes, num_frames,
                     colors=neon_colors, glow_size=glow_intensity,
-                    bg_color=bg_color, hold_drawn_frames=hold_drawn_frames
+                    bg_color=bg_color, hold_drawn_frames=hold_drawn_frames,
+                    hold_final_frames=hold_final_frames
                 )
                 
                 if not frames:
@@ -725,7 +816,9 @@ if st.button("🎬 Generate Neon Drawing Video", type="primary"):
                     final_video = tempfile.NamedTemporaryFile(delete=False, suffix='.mp4')
                     final_video.close()
                     
-                    if add_audio_to_video(video_path, temp_audio.name, final_video.name):
+                    if add_audio_to_video(video_path, temp_audio.name, final_video.name, 
+                                         start_time=audio_start_time, 
+                                         fadeout_duration=audio_fadeout):
                         final_video_path = final_video.name
                         try:
                             os.unlink(video_path)