No longer can create room with custom room ID

server/src/socket/routes/join_room.ts

@@ -23,9 +23,14 @@ export function JoinRoomHandler(ctx: Context<JoinRoomPayload>) {
 
     if (ctx.payload.roomId && !ctx.server.rooms[ctx.payload.roomId]) {
         // User sent roomId, but room doesn't exist
-        room = new Room(ctx.payload.roomId);
-        room.id = room.id.toUpperCase();
-        ctx.server.rooms[room.id] = room;
+        return ctx.ws.send(JSON.stringify({
+            "message": "join_room_response",
+            "status": "room doesn't exist",
+        }))
+        // Custom ID Code:
+        // room = new Room(ctx.payload.roomId);
+        // room.id = room.id.toUpperCase();
+        // ctx.server.rooms[room.id] = room;
 
     } else if (!ctx.payload.roomId) {
         // Didn't include RoomID, creating new one

server/test/socket/routes/join_room.spec.ts

@@ -43,6 +43,16 @@ describe("Join Room", () => {
     expect(ctx.payload.roomId!).to.satisfy((id: string) => id.length > 3, "room id not generated");
     expect(user.username).to.equal("test", "didn't set username");
   });
+  
+  it("should fail to join not existant room", () => {
+    ctx.payload.roomId = "testid"
+    JoinRoomHandler(ctx);
+    const resData = (ws.sendData as string);
+    const res = JSON.parse(resData);
+    expect(res.message).to.eq("join_room_response", "didn't get server response");
+    const roomNowExists = server.rooms["testid"]
+    expect(roomNowExists).to.equal(undefined, "server allowed to join non-existant room");
+  });
 
   it("should join existing room", () => {
     testJoinRoom(1); // Initial user joins and creates room

server/test/socket/routes/send_touch.spec.ts

@@ -24,13 +24,13 @@ describe("Send Vibration", () => {
     ctx = {
       ws: ws,
       user: user,
-      payload: { username: "test", roomId: "testRoom" },
+      payload: { username: "test" },
       server: server,
     };
     ctx2 = {
       ws: ws2,
       user: user2,
-      payload: { username: "test2", roomId: "testRoom" },
+      payload: { username: "test2" },
       server: server,
     };
 
@@ -54,6 +54,8 @@ describe("Send Vibration", () => {
 
   it("should broadcast vibration", () => {
     JoinRoomHandler(ctx)
+    const resData = JSON.parse(ws.sendData as string)
+    ctx2.payload.roomId = resData.roomId
     JoinRoomHandler(ctx2)
     ws.sendData = "";
     ws2.sendData = "";