Update app.py

app.py

@@ -1,25 +1,26 @@
 import os
+from dotenv import load_dotenv
+load_dotenv()
+
+from smolagents import CodeAgent, HfApiModel, tool
 import datetime
 import pytz
-import requests
-from dotenv import load_dotenv
-from langdetect import detect
+import gradio as gr
 from geopy.geocoders import Nominatim
 from timezonefinder import TimezoneFinder
-import gradio as gr
-from smolagents import CodeAgent, HfApiModel, tool
-
-load_dotenv()
+import requests
+from langdetect import detect
 
 @tool
 def get_timezone_by_city(city: str) -> str:
-    """Get timezone for a city.
+    """
+    Get timezone for a city.
 
     Args:
         city (str): City name.
 
     Returns:
-        str: Timezone or error message.
+        str: Timezone name or error.
     """
     try:
         geolocator = Nominatim(user_agent="smolagents_bot")
@@ -27,20 +28,21 @@ def get_timezone_by_city(city: str) -> str:
         if not location:
             return f"❌ Город '{city}' не найден."
         tf = TimezoneFinder()
-        tz = tf.timezone_at(lat=location.latitude, lng=location.longitude)
-        return tz or f"❌ Часовой пояс не найден."
+        timezone = tf.timezone_at(lat=location.latitude, lng=location.longitude)
+        return timezone or f"❌ Часовой пояс не определён."
     except Exception as e:
-        return f"❌ Ошибка пояса: {str(e)}"
+        return f"❌ Ошибка определения пояса: {str(e)}"
 
 @tool
 def get_current_time_in_timezone(timezone: str) -> str:
-    """Get local time for timezone.
+    """
+    Get current time in given timezone.
 
     Args:
         timezone (str): Timezone name.
 
     Returns:
-        str: Current time or error.
+        str: Local time or error.
     """
     try:
         tz = pytz.timezone(timezone)
@@ -50,7 +52,8 @@ def get_current_time_in_timezone(timezone: str) -> str:
 
 @tool
 def get_air_quality(city: str, lang: str = "en") -> str:
-    """Air quality with translation.
+    """
+    Air quality in city with translations.
 
     Args:
         city (str): City name.
@@ -64,12 +67,14 @@ def get_air_quality(city: str, lang: str = "en") -> str:
         location = geolocator.geocode(city, language="en")
         if not location:
             return f"❌ Город '{city}' не найден."
+
         api_key = os.environ["OPENWEATHERMAP_API_KEY"]
-        url = (
-            f"http://api.openweathermap.org/data/2.5/air_pollution"
-            f"?lat={location.latitude}&lon={location.longitude}&appid={api_key}"
-        )
-        data = requests.get(url).json()
+        url = f"http://api.openweathermap.org/data/2.5/air_pollution?lat={location.latitude}&lon={location.longitude}&appid={api_key}"
+        response = requests.get(url)
+        if response.status_code != 200:
+            return f"❌ Ошибка API: {response.status_code}"
+
+        data = response.json()
         aqi = data["list"][0]["main"]["aqi"]
         c = data["list"][0]["components"]
 
@@ -79,23 +84,24 @@ def get_air_quality(city: str, lang: str = "en") -> str:
                 "aqi_desc": {1: "Good", 2: "Fair", 3: "Moderate", 4: "Poor", 5: "Very Poor"},
                 "pm2_5": "Fine particles (PM2.5)",
                 "pm10": "Coarse particles (PM10)",
-                "co": "Carbon monoxide (CO)",
+                "co": "Carbon monoxide (CO)"
             },
             "ru": {
                 "title": "😷 Качество воздуха",
                 "aqi_desc": {1: "Хорошее", 2: "Удовлетворительное", 3: "Среднее", 4: "Плохое", 5: "Очень плохое"},
                 "pm2_5": "Мелкодисперсные частицы (PM2.5)",
                 "pm10": "Крупнодисперсные частицы (PM10)",
-                "co": "Угарный газ (CO)",
+                "co": "Угарный газ (CO)"
             },
             "hi": {
                 "title": "😷 वायु गुणवत्ता",
                 "aqi_desc": {1: "अच्छा", 2: "संतोषजनक", 3: "मध्यम", 4: "खराब", 5: "बहुत खराब"},
                 "pm2_5": "सूक्ष्म कण (PM2.5)",
                 "pm10": "मोटे कण (PM10)",
-                "co": "कार्बन मोनोऑक्साइड (CO)",
+                "co": "कार्बन मोनोऑक्साइड (CO)"
             }
         }
+
         t = translations.get(lang, translations["en"])
         emoji = "🌱" if aqi <= 2 else "😷" if aqi <= 4 else "☣️"
 
@@ -106,11 +112,12 @@ def get_air_quality(city: str, lang: str = "en") -> str:
             f"{t['co']}: {c['co']} µg/m³"
         )
     except Exception as e:
-        return f"❌ Ошибка воздуха: {str(e)}"
+        return f"❌ Ошибка качества воздуха: {str(e)}"
 
 @tool
 def get_weather(city: str, lang: str = "en") -> str:
-    """Weather with translation.
+    """
+    Weather info for a city with translations.
 
     Args:
         city (str): City name.
@@ -124,14 +131,15 @@ def get_weather(city: str, lang: str = "en") -> str:
         location = geolocator.geocode(city, language="en")
         if not location:
             return f"❌ Город '{city}' не найден."
+
         api_key = os.environ["OPENWEATHERMAP_API_KEY"]
-        url = (
-            f"http://api.openweathermap.org/data/2.5/weather"
-            f"?lat={location.latitude}&lon={location.longitude}"
-            f"&appid={api_key}&units=metric"
-        )
-        data = requests.get(url).json()
-        w = data["weather"][0]["main"]
+        url = f"http://api.openweathermap.org/data/2.5/weather?lat={location.latitude}&lon={location.longitude}&appid={api_key}&units=metric"
+        response = requests.get(url)
+        if response.status_code != 200:
+            return f"❌ Ошибка API: {response.status_code}"
+
+        data = response.json()
+        condition = data["weather"][0]["main"]
         temp = data["main"]["temp"]
         humidity = data["main"]["humidity"]
 
@@ -142,8 +150,7 @@ def get_weather(city: str, lang: str = "en") -> str:
                 "humidity": "Humidity",
                 "conditions": {
                     "Clear": "Clear ☀️", "Clouds": "Cloudy ☁️", "Rain": "Rain 🌧",
-                    "Snow": "Snow ❄️", "Thunderstorm": "Storm ⛈", "Drizzle": "Drizzle 🌦",
-                    "Mist": "Mist 🌫", "Haze": "Haze 🌫"
+                    "Snow": "Snow ❄️", "Thunderstorm": "Storm ⛈", "Drizzle": "Drizzle 🌦", "Mist": "Mist 🌫", "Haze": "Haze 🌫"
                 }
             },
             "ru": {
@@ -152,8 +159,7 @@ def get_weather(city: str, lang: str = "en") -> str:
                 "humidity": "Влажность",
                 "conditions": {
                     "Clear": "Ясно ☀️", "Clouds": "Облачно ☁️", "Rain": "Дождь 🌧",
-                    "Snow": "Снег ❄️", "Thunderstorm": "Гроза ⛈", "Drizzle": "Морось 🌦",
-                    "Mist": "Туман 🌫", "Haze": "Дымка 🌫"
+                    "Snow": "Снег ❄️", "Thunderstorm": "Гроза ⛈", "Drizzle": "Морось 🌦", "Mist": "Туман 🌫", "Haze": "Дымка 🌫"
                 }
             },
             "hi": {
@@ -162,13 +168,13 @@ def get_weather(city: str, lang: str = "en") -> str:
                 "humidity": "नमी",
                 "conditions": {
                     "Clear": "साफ ☀️", "Clouds": "बादल ☁️", "Rain": "बारिश 🌧",
-                    "Snow": "बर्फ ❄️", "Thunderstorm": "तूफान ⛈", "Drizzle": "बूंदाबांदी 🌦",
-                    "Mist": "कोहरा 🌫", "Haze": "धुंध 🌫"
+                    "Snow": "बर्फ ❄️", "Thunderstorm": "तूफान ⛈", "Drizzle": "बूंदाबांदी 🌦", "Mist": "कोहरा 🌫", "Haze": "धुंध 🌫"
                 }
             }
         }
+
         t = translations.get(lang, translations["en"])
-        desc = t["conditions"].get(w, w)
+        desc = t["conditions"].get(condition, condition)
 
         return (
             f"{t['title']}: {desc}\n"
@@ -181,29 +187,29 @@ def get_weather(city: str, lang: str = "en") -> str:
 @tool
 def final_answer(answer: str) -> str:
     """
-    Return the final answer string to the user.
+    Return final response.
 
     Args:
-        answer (str): The final response to display.
+        answer (str): The output.
 
     Returns:
-        str: The same response passed in.
+        str: Same as input.
     """
     return answer
 
 model = HfApiModel(
     max_tokens=1000,
     temperature=0.5,
-    model_id="mistralai/Mixtral-8x7B-Instruct-v0.1"
+    model_id='mistralai/Mixtral-8x7B-Instruct-v0.1',
 )
 
 system_prompt = (
-    "Ты помощник. Используй только функции: "
-    "`get_timezone_by_city`, `get_current_time_in_timezone`, `get_air_quality`, "
-    "`get_weather`, `final_answer`. Передавай `lang = variables['lang']`. "
-    "Ответ в формате:\n"
+    "Ты полезный ассистент. Используй только функции: "
+    "`get_timezone_by_city`, `get_current_time_in_timezone`, `get_air_quality`, `get_weather`, `final_answer`. "
+    "В начале всегда указывай: `lang = variables['lang']` и передавай его в функции. "
+    "Ответ должен быть только на языке пользователя. Возвращай только код внутри блока:\n"
     "```py\nfinal_answer('...')\n```<end_code>\n"
-    "❌ Без пояснений, markdown, JSON."
+    "❌ Никаких пояснений, комментариев, JSON, markdown, описаний вне кода."
 )
 
 prompt_templates = {
@@ -215,7 +221,7 @@ prompt_templates = {
         "task": "```py\nfinal_answer('Not implemented')\n```"
     },
     "planning": {
-        "initial_plan": "```py\nfinal_answer('Plan')\n```",
+        "initial_plan": "```py\nfinal_answer('Plan not needed')\n```",
         "update_plan_pre_messages": "```py\nfinal_answer('Plan updated')\n```",
         "update_plan_post_messages": "```py\nfinal_answer('Plan adjusted')\n```"
     },
@@ -231,7 +237,7 @@ agent = CodeAgent(
     tools=[get_timezone_by_city, get_current_time_in_timezone, get_air_quality, get_weather, final_answer],
     prompt_templates=prompt_templates,
     max_steps=3,
-    verbosity_level=2
+    verbosity_level=2,
 )
 
 def process_input(user_input):
@@ -239,16 +245,15 @@ def process_input(user_input):
         lang = detect(user_input)
         lang = lang if lang in ["en", "ru", "hi"] else "en"
         agent.variables = {"lang": lang}
-        return agent.run(user_input) or "❌ Агент не ответил."
+        return agent.run(user_input) or "❌ Нет ответа от агента."
     except Exception as e:
         return f"❌ Ошибка: {str(e)}"
 
-
 if __name__ == "__main__":
     gr.Interface(
         fn=process_input,
         inputs="text",
         outputs="text",
-        title="🦊 Умный ассистент",
-        description="Напиши город — узнаешь время, погоду и качество воздуха"
+        title="🦊 Помощник по городу",
+        description="Напиши город, и я покажу тебе время, воздух и погоду"
     ).launch()