Update app.py

app.py

@@ -5,7 +5,6 @@ from skimage.transform import resize
 from skimage.draw import line
 import gradio as gr
 import tempfile
-import os
 
 def preprocess_image(image, size=(200, 200)):
     if image.ndim == 3:
@@ -38,22 +37,37 @@ def generate_connections(img, pins, num_connections):
     connections = []
     current_pin = 0
     used = set()
+    img_work = img.copy()  # Work on a copy so we can lighten pixels
+
     for _ in range(num_connections):
         best_score = -1
         best_pin = None
+        best_rr, best_cc = None, None
         for next_pin in range(num_pins):
             if next_pin == current_pin:
                 continue
             if (current_pin, next_pin) in used or (next_pin, current_pin) in used:
                 continue
-            score = line_darkness_score(img, pins[current_pin], pins[next_pin])
+            h, w = img_work.shape
+            x1 = int((pins[current_pin][0] + 1) / 2 * (w - 1))
+            y1 = int((pins[current_pin][1] + 1) / 2 * (h - 1))
+            x2 = int((pins[next_pin][0] + 1) / 2 * (w - 1))
+            y2 = int((pins[next_pin][1] + 1) / 2 * (h - 1))
+            rr, cc = line(y1, x1, y2, x2)
+            rr = np.clip(rr, 0, h-1)
+            cc = np.clip(cc, 0, w-1)
+            line_pixels = img_work[rr, cc]
+            score = np.sum(1 - line_pixels)
             if score > best_score:
                 best_score = score
                 best_pin = next_pin
+                best_rr, best_cc = rr, cc
         if best_pin is None:
             break
         connections.append((current_pin, best_pin))
         used.add((current_pin, best_pin))
+        # Lighten the pixels along this line (simulate string covering)
+        img_work[best_rr, best_cc] = 1.0
         current_pin = best_pin
     return connections
 
@@ -67,13 +81,12 @@ def draw_string_art(image, num_pins, num_connections):
     ax.axis("off")
     for c in connections:
         p1, p2 = pins[c[0]], pins[c[1]]
-        ax.plot([p1[0], p2[0]], [p1[1], p2[1]], 'k-', linewidth=0.7, alpha=0.9)  # Black, thicker lines
+        ax.plot([p1[0], p2[0]], [p1[1], p2[1]], 'k-', linewidth=0.7, alpha=0.2)  # Black, thin, low opacity
     ax.scatter(pins[:,0], pins[:,1], c='red', s=16)  # Red pins, moderate size
     plt.tight_layout(pad=0)
     plt.close(fig)
     # Prepare connections file (1-based indexing)
     connections_1_based = [str(c[0]+1) for c in connections]
-    # Make continuous: start at pin 1, then next, etc.
     connections_str = ', '.join(connections_1_based)
     # Save to temporary file
     temp_file = tempfile.NamedTemporaryFile(delete=False, suffix=".txt", mode="w", encoding="utf-8")
@@ -97,7 +110,7 @@ demo = gr.Interface(
         gr.File(label="Connections File")
     ],
     title="String Art Generator",
-    description="Upload an image, set the number of pins and connections, and generate circular string art with a downloadable connection file."
+    description="Upload an image, set the number of pins and connections, and generate circular string art with a downloadable connection file. Strings are drawn with reduced opacity."
 )
 
 if __name__ == "__main__":