Reem Othman commited on
Commit
7b41208
·
unverified ·
1 Parent(s): c82d419

Update README.md

Browse files
Files changed (1) hide show
  1. README.md +72 -29
README.md CHANGED
@@ -49,33 +49,76 @@ Run the app with ```python3 app.py```
49
  Input the raw video into a [reasoning vision model](https://huggingface.co/blog/nvidia/nvidia-cosmos-reason-2-brings-advanced-reasoning) and develop the workflow with [daggr](https://huggingface.co/blog/daggr) for gradio.
50
 
51
 
52
- ### PR Review Guidelines
53
-
54
- To ensure code quality, stability of the HuggingFace deployment, and consistent development practices, all pull requests must follow these guidelines:
55
-
56
- #### Before creating a PR
57
- - Code must follow project structure and naming conventions
58
- - No `.pdf` or `.xlsx` files should be committed (these break HuggingFace sync)
59
- - Code should pass local linting checks
60
- - Changes should be tested locally when possible
61
-
62
- #### CI/CD requirements
63
- - Linting must pass before merge
64
- - CI pipeline must complete successfully
65
-
66
- #### PR description must include
67
- - Clear explanation of what was implemented or changed
68
- - Reason for the change
69
- - Screenshots or demo output (if UI/model related)
70
-
71
- #### Reviewer checklist
72
- - Code readability and structure
73
- - Consistency with project design
74
- - No restricted file uploads (.pdf/.xlsx)
75
- - CI pipeline passes
76
- - No breaking changes to deployment
77
-
78
- #### Merge rules
79
- - PR cannot be merged if CI fails
80
- - PR must be up-to-date with `main` branch before merging
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
81
 
 
49
  Input the raw video into a [reasoning vision model](https://huggingface.co/blog/nvidia/nvidia-cosmos-reason-2-brings-advanced-reasoning) and develop the workflow with [daggr](https://huggingface.co/blog/daggr) for gradio.
50
 
51
 
52
+ ### Development & Contribution Guidelines
53
+
54
+ Currently, the team commits directly to the `main` branch.
55
+ Instead of formal pull request restrictions, we follow shared development and quality guidelines to ensure stability, especially for the HuggingFace deployment and ML workflows.
56
+
57
+ These rules will also prepare the project for a future PR-based workflow.
58
+
59
+ ---
60
+
61
+ #### General development rules
62
+
63
+ - Follow the existing project structure and naming conventions
64
+ - Keep notebooks and scripts readable and well-documented
65
+ - Avoid committing temporary, experimental, or unused code
66
+ - Document design decisions when introducing new components
67
+
68
+ ---
69
+
70
+ #### HuggingFace deployment safety
71
+
72
+ - Do NOT commit `.pdf` or `.xlsx` files (they break HuggingFace sync)
73
+ - Avoid committing large model artifacts unless required
74
+ - Ensure changes do not break the deployment app (`app.py`)
75
+
76
+ ---
77
+
78
+ #### Code quality expectations
79
+
80
+ Before pushing to `main`:
81
+
82
+ - Run local linting checks when possible
83
+ - Ensure notebooks execute without errors
84
+ - Remove unused imports and variables
85
+ - Keep code modular and readable
86
+
87
+ CI/CD will enforce:
88
+
89
+ - Linting checks for `.py` and `.ipynb`
90
+ - Automated tests
91
+ - Deployment only after quality checks pass
92
+
93
+ ---
94
+
95
+ #### Design and coding principles
96
+
97
+ - Write clear, modular Python code
98
+ - Separate experimentation (notebooks) from production logic
99
+ - Reusable functions should live in `.py` modules
100
+ - Use consistent naming and documentation practices
101
+
102
+ ---
103
+
104
+ #### Team review practice
105
+
106
+ Even without PRs, team members:
107
+
108
+ - Communicate major changes in Slack/GitHub Issues
109
+ - Request peer feedback before large commits
110
+ - Document model changes and performance improvements
111
+ - Flag anything that may affect deployment
112
+
113
+ ---
114
+
115
+ #### Future transition
116
+
117
+ As the project grows, we may transition to:
118
+
119
+ - Feature branches
120
+ - Pull request reviews
121
+ - Mandatory CI approval before merge
122
+
123
+ These guidelines are the first step toward a structured DevOps workflow.
124